Re: [PATCH try #3] security: Convert LSM into a static interface

2007-07-18 Thread Arjan van de Ven
On Sat, 2007-07-14 at 12:37 -0400, James Morris wrote: Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates the overall security architecture. Needlessly exported LSM symbols have been unexported, to help

Re: [kvm-devel] [PATCH 3/3] KVM - add hypercall nr to kvm_run

2007-07-18 Thread Anthony Liguori
Jeff Dike wrote: On Tue, Jul 17, 2007 at 09:15:51AM -0500, Anthony Liguori wrote: I'm planning on breaking this interface again since the new hypercall API only takes 4 arguments instead of 6. Is anything written anywhere about this hypercall interface? I've posted patches. I'll

Re: [PATCH 4/10] cpu: deliver CPU_UP_CANCELED only to NOTIFY_OKed callbacks with CPU_UP_PREPARE

2007-07-18 Thread Akinobu Mita
[...] However, it might break slab. If I am not mistaken, slab code initializes multiple objects in CPU_UP_PREPARE and relies on the CPU_UP_CANCELLED to destroy the objects which successfully got initialized before the some object's initialization went bad. My testing machine is ordinary

Re: [PATCH/RFC] msleep() with hrtimers

2007-07-18 Thread Nick Piggin
Nish Aravamudan wrote: Well, before these changes, the only guarantee msleep() could make, just like the only guarantee schedule_timeout() could make, was that it would not return early. The 1-jiffy sleep was always tough to deal with, because of rounding and such. And it's simply exacerbated

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Tejun Heo
Satyam Sharma wrote: sysfs_find_dirent() -- to check for -EEXIST -- should be called *before* we create the new dentry for the to-be-created symlink in the first place. [ It's weird to grab a reference on the target for ourselves (and in fact even allocate the new dirent for the

Re: [PATCH 2/3] i386: use x86_64's desc_def.h

2007-07-18 Thread Zachary Amsden
Rusty Russell wrote: The main effect is to change the definition of struct desc_struct to a union of more complex types. Yay! Someone finally killed it. Every time I tried to kill it, I ended up off in the weeds chasing some bug. diff -r 656f3ff2c9ce arch/i386/kernel/process.c @@

Re: Q: a bogus task_running() check in try_to_wake_up() ?

2007-07-18 Thread Oleg Nesterov
On 07/17, Ingo Molnar wrote: * Oleg Nesterov [EMAIL PROTECTED] wrote: try_to_wake_up: if (p-se.on_rq) goto out_running; ... if (unlikely(task_running(rq, p))) goto out_activate; How it possible that rq-curr has on_rq == 0 ?

[PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64

2007-07-18 Thread Avi Kivity
Commit 9d9bbd4d247a674deb43565582151acdc22e90d1 makes CONFIG_CMPXCHG64 dependent on CONFIG_HIGHMEM64G, but KVM guest SMP support now also requires CMPXCHG64 while not being tied to PAE. So the effect of that patch is to disable KVM on non-PAE configs. Untangle those dependencies by: - having

Re: RFC: CONFIG_PAGE_SHIFT (aka software PAGE_SIZE)

2007-07-18 Thread Rene Herman
On 07/18/2007 03:32 PM, William Lee Irwin III wrote: On Tue, Jul 17, 2007 at 09:33:08PM +0200, Andrea Arcangeli wrote: kmalloced 4k naturally aligned object into userland). I wouldn't call it tail packing, it's more a fine-granular pagecache with the already available kmalloc granularities.

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Satyam Sharma
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote: Satyam Sharma wrote: Readability, fewer LOC, 308 lesser bytes in kernel image and faster for the common case -- not good enough for you?! Oh, well. Sorry, not agreed on readability. The rest doesn't really matter too much and please stop making

Re: 2.6.22-git* regression: Kconfig prompts without help text

2007-07-18 Thread Randy Dunlap
On Wed, 18 Jul 2007 17:18:34 +0200 (CEST) Jan Engelhardt wrote: Hi, On Jul 16 2007 20:49, Stefan Richter wrote: It is an error to add visible Kconfig options without help text. Among them are the new menuconfig options. Jan obviously never uses make oldconfig. Untrue. Users of

Re: [RFT][PATCH v7] sata_mv: convert to new EH

2007-07-18 Thread dean gaudet
On Wed, 18 Jul 2007, Pasi Kärkkäinen wrote: What brand/model your sata_mv controller is? Would be nice to know to be able to get a known-to-work one.. http://supermicro.com/products/accessories/addon/AoC-SAT2-MV8.cfm -dean

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
What if we will force the specific device to the end of the list. Once IRQ_NONE was returned by the other devices, we will mask the irq, forward the irq to the guest, issue a timer for 1msec. Motivation: 1msec is long enough for the guest to ack the irq + host unmask the irq It makes no

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Tejun Heo
Tejun Heo wrote: Satyam Sharma wrote: sysfs_find_dirent() -- to check for -EEXIST -- should be called *before* we create the new dentry for the to-be-created symlink in the first place. [ It's weird to grab a reference on the target for ourselves (and in fact even allocate the new dirent for

Re: XFS -git changes and Linux-VServer patch porting

2007-07-18 Thread Josef Sipek
On Wed, Jul 18, 2007 at 03:49:07PM +0200, Radoslaw Szkodzinski wrote: Linux-VServer patch adds 2 new flags: barrier and iunlink. With recent changes in -git (filestreams), XFS now lacks di_flags bits to add these. iunlink flag adds Copy-on-Write semantics to hard links, while barrier flag

[PATCH v3 1/2] NetLabel: enable dynamic activation/deactivation of NetLabel/SELinux enforcement

2007-07-18 Thread Paul Moore
Create a new NetLabel KAPI interface, netlbl_enabled(), which reports on the current runtime status of NetLabel based on the existing configuration. LSMs that make use of NetLabel, i.e. SELinux, can use this new function to determine if they should perform NetLabel access checks. This patch

Re: [patch] revert: [NET]: Fix races in net_rx_action vs netpoll

2007-07-18 Thread Ingo Molnar
* Olaf Kirch [EMAIL PROTECTED] wrote: also, i'm using netconsole via the command line (both the network driver and netconsole is built into the bzImage), maybe that makes a difference? Possibly - but so far there's nothing in the code that jumped at me. Can you try the following

[PATCH v3 0/2] The comedy of errors patchset (was: SELinux NetLabel updates)

2007-07-18 Thread Paul Moore
This rev of the patchset solves both the original problem that Michal posted involving backwards compatibility with old SELinux policy as well as the problem Linus posted about the fix not working correctly when CONFIG_NETLABEL was not set. I also tried to fixup the #ifdefs in

[PATCH v3 2/2] SELinux: use SECINITSID_NETMSG instead of SECINITSID_UNLABELED for NetLabel

2007-07-18 Thread Paul Moore
These changes will make NetLabel behave like labeled IPsec where there is an access check for both labeled and unlabeled packets as well as providing the ability to restrict domains to receiving only labeled packets when NetLabel is in use. The changes to the policy are straight forward with the

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Avi Kivity
Alan Cox wrote: What if we will force the specific device to the end of the list. Once IRQ_NONE was returned by the other devices, we will mask the irq, forward the irq to the guest, issue a timer for 1msec. Motivation: 1msec is long enough for the guest to ack the irq + host unmask the irq

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Satyam Sharma
On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote: Tejun Heo wrote: Satyam Sharma wrote: sysfs_find_dirent() -- to check for -EEXIST -- should be called *before* we create the new dentry for the to-be-created symlink in the first place. [ It's weird to grab a reference on the target for

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
IMO the only reasonable solution is to disallow interrupt forwarding with shared irqs. If someone later comes up with a bright idea, we can Which means you are back to ISA bus devices. Even checking if an IRQ is currently unshared isn't simple as with hotplug this may change. implement it.

RE: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Dor Laor
In particular, this requires interrupt handling to be done by the guest -- The host shouldn't load the corresponding device driver or otherwise access the device. Since the host kernel is not aware of the device semantics it cannot acknowledge the interrupt at the device level. Tricky indeed.

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Avi Kivity
Alan Cox wrote: IMO the only reasonable solution is to disallow interrupt forwarding with shared irqs. If someone later comes up with a bright idea, we can Which means you are back to ISA bus devices. Even checking if an IRQ is currently unshared isn't simple as with hotplug this may

Re: [PATCH] fs: Add romfs version 2

2007-07-18 Thread Tim Bird
Lindsay Roberts wrote: Yes, my experience has been that it has been almost chillingly close to .5k per regular file increase in partition size. I know in applications in which size is utterly critical this may be slightly unattractive, but in cases where romfs is chosen for its byte

Re: [PATCH] sysfs: kill an extra put in sysfs_create_link() failure path

2007-07-18 Thread Miles Lane
On 7/18/07, Satyam Sharma [EMAIL PROTECTED] wrote: On 7/18/07, Tejun Heo [EMAIL PROTECTED] wrote: Tejun Heo wrote: Satyam Sharma wrote: sysfs_find_dirent() -- to check for -EEXIST -- should be called *before* we create the new dentry for the to-be-created symlink in the first place. [

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Matt Mackall
On Wed, Jul 18, 2007 at 04:38:19AM +0200, Rene Herman wrote: On 07/17/2007 01:27 AM, Matt Mackall wrote: Larger soft pages waste tremendous amounts of memory (mostly in page cache) for minimal benefit on, say, the typical desktop. While there are workloads where it's a win, it's probably on

Re: [PATCH] Re: 2.6.22-git ppc build failure

2007-07-18 Thread Bret Towe
On 7/17/07, Tony Breeds [EMAIL PROTECTED] wrote: On Tue, Jul 17, 2007 at 11:04:57AM -0700, Bret Towe wrote: this is off my g4 mac mini latest git as of when this email was sent config file attached Hi Bret, the patch below will fix it. yeap it compiled and boots fine thanks

Re: [ofa-general] Further 2.6.23 merge plans...

2007-07-18 Thread Sean Hefty
We will have a better idea of the issues and possible solutions once the QoS spec is released, and we can hold discussions on it. I will be working more details on QoS enhancements starting in the next couple of weeks. Based on discussions so far, maybe the best path forward from here is to

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
Hotplug is user-controllable, so if the user refrains from adding pci devices after assigning a device to the guest, it should work. I think that USB interrupts are assigned to the controller, not the device, so USB hotplug can be ruled out. Cardbus is more problematic. Alan - To

RE: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Dor Laor
Alan Cox wrote: What if we will force the specific device to the end of the list. Once IRQ_NONE was returned by the other devices, we will mask the irq, forward the irq to the guest, issue a timer for 1msec. Motivation: 1msec is long enough for the guest to ack the irq + host unmask the irq

Re: Slow Soft-RAID 5 performance

2007-07-18 Thread Rui Santos
koan wrote: How did you create the ext3 filesystem? The chunk_size is at 256KB, ext3 block size is 4k. I believe the correct option that should be passed trough to --stride is 64. Am I correct ? I've also tested ( after sending my first report ) with xfs. I've also increases readahead to 65535

Re: VESAFB CUSTOM RESOLUTION

2007-07-18 Thread Matan Ziv-Av
On Wed, 18 Jul 2007, Antonino A. Daplas wrote: So, one cannot just set any mode, unless that mode is already defined in the BIOS mode table. In VBE 3.0, you might be able to choose an arbitrary vertical refresh rate, but that's the best mode tuning you can do with the video BIOS.

Re: Slow Soft-RAID 5 performance

2007-07-18 Thread Rui Santos
J.A. Magallón wrote: On Wed, 18 Jul 2007 10:56:11 +0100, Rui Santos [EMAIL PROTECTED] wrote: Hi, I'm getting a strange slow performance behavior on a recently installed Server. Here are the details: ... I can get a write throughput of 60 MB/sec on each HD by issuing the

Re: 2.6.22-git* regression: Kconfig prompts without help text

2007-07-18 Thread Jan Engelhardt
On Jul 18 2007 09:41, Randy Dunlap wrote: Looks good to me except that help text should be indented by 2 more spaces according to CodingStyle. Who invented that rule anyway... the ---help--- marker (note the dashes) clearly separates things already. Here you go. === Add some help texts to

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Rene Herman
On 07/18/2007 06:54 PM, Matt Mackall wrote: You can expect the distribution of file sizes to follow a gamma distribution, with a large hump towards the small end of the spectrum around 1-10K, dropping off very rapidly as file sizes grow. Okay. Not too sure then that 8K wouldn't be something

Re: [PATCH] Introduce is_owner_or_cap() to wrap CAP_FOWNER use with fsuid check

2007-07-18 Thread Serge E. Hallyn
Quoting Serge E. Hallyn ([EMAIL PROTECTED]): Quoting Satyam Sharma ([EMAIL PROTECTED]): From: Satyam Sharma [EMAIL PROTECTED] [PATCH] Introduce is_owner_or_cap() to wrap CAP_FOWNER use with fsuid check Introduce is_owner_or_cap() macro in fs.h, and convert over relevant users to it.

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Phillip Susi
Matt Mackall wrote: As far as I'm aware, the actual reason for 4K stacks is that after the system has been up and running for some time getting 1 physically contiguous pages becomes significantly easier than 2 which wouldn't be arbitrary. If there are exactly two free pages in the system,

Re: [PATCH] Use tty_schedule in VT code.

2007-07-18 Thread James Simmons
James Simmons wrote: The low_latency is used by the drivers in the case where its not in a interrupt context. Well we are trusting the drivers. Now if it is true what you said then tty_flip_buffer_push has a bug. Looking at several drivers including serial devices they set the

Re: i386: pata_cs5520 does not work

2007-07-18 Thread TAKADA Yoshihito
Hi. Thanks for reply. It is not issue of pata_cs5520. In good case, ReiserFS detects root partition. Bad case, ReiserFS does not detects partition. ReiserFS: sda2: found reiserfs format 3.6 with standard journal On Wed, 18 Jul 2007 14:42:12 +0100 Alan Cox [EMAIL PROTECTED] wrote: I'll take a

Re: [patch] CFS scheduler, -v19

2007-07-18 Thread Linus Torvalds
On Wed, 18 Jul 2007, Ingo Molnar wrote: Linus, Thomas, what do you think, should we keep the time.c change? No, not if it's off by the second field. That 30% CPU usage indicates that there's some nasty bug there somewhere, and that's just not worth it. If time() cannot get the second

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Alan Cox
Guest0 - blocked on I/O IRQ14 from your hardware Block IRQ14 Sent to guest (guest is blocked) IRQ14 from hard disk Ignored (as blocked) But now the timer will pop and the hard disk will get its irq. The guest will be released

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Alan Cox
Why do the two pages have to be physically contiguous? The stack just needs to be two contiguous pages in virtual memory, but they can map to any two pages anywhere in physical memory. Historically we allowed DMA off the stack on old x86 systems. Removing that while a good idea would take a

[PATCH (updated) 1/2] workqueue: debug flushing deadlocks with lockdep

2007-07-18 Thread Johannes Berg
In the following scenario: code path 1: my_function() - lock(L1); ...; flush_workqueue(); ... code path 2: run_workqueue() - my_work() - ...; lock(L1); ... you can get a deadlock when my_work() is queued or running but my_function() has acquired L1 already. This patch adds a pseudo-lock to

Re: [GIT-PULL] pull from UBI git

2007-07-18 Thread Linus Torvalds
On Wed, 18 Jul 2007, Artem Bityutskiy wrote: please pull from upstream branch of git://git.infradead.org/~dedekind/ubi-2.6.git to receive the following updates: Please don't hide the branch name in the free-flowing text, and instead write your please pull messages like this: Please

Re: [patch] CFS scheduler, -v19

2007-07-18 Thread Ian Kent
On Wed, 2007-07-18 at 09:03 -0700, Linus Torvalds wrote: On Tue, 17 Jul 2007, Ingo Molnar wrote: * Ian Kent [EMAIL PROTECTED] wrote: In several places I have code similar to: wait.tv_sec = time(NULL) + 1; wait.tv_nsec = 0; Ok, that definitely should work. Does the

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Phillip Susi
Alan Cox wrote: Why do the two pages have to be physically contiguous? The stack just needs to be two contiguous pages in virtual memory, but they can map to any two pages anywhere in physical memory. Historically we allowed DMA off the stack on old x86 systems. Removing that while a good

Re: [PATCH][RFC] 4K stacks default, not a debug thing any more...?

2007-07-18 Thread Rene Herman
On 07/18/2007 07:19 PM, Phillip Susi wrote: Why do the two pages have to be physically contiguous? The stack just needs to be two contiguous pages in virtual memory, but they can map to any two pages anywhere in physical memory. As far as I'm aware that's just a consequence of the way linux

Re: 2.6.22-git* regression: Kconfig prompts without help text

2007-07-18 Thread Randy Dunlap
On Wed, 18 Jul 2007 19:17:49 +0200 (CEST) Jan Engelhardt wrote: On Jul 18 2007 09:41, Randy Dunlap wrote: Looks good to me except that help text should be indented by 2 more spaces according to CodingStyle. Who invented that rule anyway... the ---help--- marker (note the dashes)

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-18 Thread Roland Dreier
Hey, I appreciate it, but I really do have to warn you that I did this all blind, and just meant for it to be a I think this kind of direction is more productive thing. I'm not going to guarantee that it works at all. Oh, understood, and I'm definitely planning on taking your patch as

Re: VESAFB CUSTOM RESOLUTION

2007-07-18 Thread H. Peter Anvin
Antonino A. Daplas wrote: What about the VBE 3.0 arbitrary vertical refresh rate thing? This is not implemented by the video-vesa.c because it will require complex calculations of mode timings (such as with GTF) to be done before starting the kernel. However, uvesafb probably does.

Re: Documentation for sysfs, hotplug, and firmware loading.

2007-07-18 Thread Rob Landley
On Wednesday 18 July 2007 3:58:57 am Cornelia Huck wrote: On Tue, 17 Jul 2007 17:03:31 -0400, Rob Landley [EMAIL PROTECTED] wrote: Here's some sysfs/hotplug/firmware loading documentation I wrote. I finally tracked down the netlink bits to finish it up, so I can send it out to the world.

Re: [kvm-devel] [PATCH 3/3] KVM - add hypercall nr to kvm_run

2007-07-18 Thread Jeff Dike
On Wed, Jul 18, 2007 at 11:28:18AM -0500, Anthony Liguori wrote: Within the kernel right (VMCALL is only usable in ring 1). Yup. Is it terribly important to be able to pass through the syscall arguments in registers verses packing them in a data structure and passing a pointer to that

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread S.Çağlar Onur
Hi Avi; 18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: This trace is certainly a kvm bug. What guest are you running? If it is free (and does not contain private information), can you post it somewhere for me to download? After seeing your [PATCH] i386: Decouple PAE from

Re: [PATCH - 0/2] Identify native drivers and ACPI subsystem accessing the same resources

2007-07-18 Thread Thomas Renninger
On Fri, 2007-07-13 at 10:56 -0600, Bjorn Helgaas wrote: On Friday 13 July 2007 06:58:12 am Thomas Renninger wrote: This patch should: a) Identify machines where potentially ACPI interference can happen and tell the user which legacy drivers are affected. b) Identify drivers/HW where we

Re: [PATCH/RFC] msleep() with hrtimers

2007-07-18 Thread Nish Aravamudan
On 7/16/07, Nick Piggin [EMAIL PROTECTED] wrote: Nish Aravamudan wrote: Well, before these changes, the only guarantee msleep() could make, just like the only guarantee schedule_timeout() could make, was that it would not return early. The 1-jiffy sleep was always tough to deal with,

Re: 2.6.22-git* regression: Kconfig prompts without help text

2007-07-18 Thread Jan Engelhardt
On Jul 18 2007 10:34, Randy Dunlap wrote: On Jul 18 2007 09:41, Randy Dunlap wrote: Looks good to me except that help text should be indented by 2 more spaces according to CodingStyle. Who invented that rule anyway... the ---help--- marker (note the dashes) clearly separates things

Re: PS3 Storage Driver O_DIRECT issue

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Geert Uytterhoeven wrote: On Fri, 13 Jul 2007, Olaf Hering wrote: This driver (or the generic PS3 code) has appearently problems with O_DIRECT. glibc aborts parted because the malloc metadata get corrupted. While it is reproducible, the place where it crashes changes

Re: 2.6.22-git* regression: Kconfig prompts without help text

2007-07-18 Thread Randy Dunlap
Jan Engelhardt wrote: On Jul 18 2007 10:34, Randy Dunlap wrote: On Jul 18 2007 09:41, Randy Dunlap wrote: Looks good to me except that help text should be indented by 2 more spaces according to CodingStyle. Who invented that rule anyway... the ---help--- marker (note the dashes) clearly

Re: v2.6.21.5-rt19 (sched_getaffinity?)

2007-07-18 Thread Fernando Lopez-Lezcano
On Wed, 2007-07-18 at 09:18 +0200, Ingo Molnar wrote: * Fernando Lopez-Lezcano [EMAIL PROTECTED] wrote: does lockdep pinpoint anything? Lots of stuff, and at the end the lock report for the problem. Hopefully some of this will help... I have attached the whole bootup sequence as

Re: [git patches 1/2] warnings: attack valid cases spotted by warnings

2007-07-18 Thread Linus Torvalds
On Wed, 18 Jul 2007, Roland Dreier wrote: BTW, I noticed one interesting thing while starting on this cleanup. I wanted to make sure that the generated code didn't change with the first step, and I actually discovered that the patch below seems to make the generated code *better*, maybe

[PATCH] Revert part of 3f1b0e1f287547903f11fa1e6de7d2765597766e

2007-07-18 Thread S.Çağlar Onur
Hi; With 3f1b0e1f287547903f11fa1e6de7d2765597766e Linus's current git tree starts to ignore any *.orig or *.rej files (for example git status cannot show what are they) but if there are some *.orig or *.rej files exists, for whatever reason, that means some unresolved merge conflicts occured

Re: [kvm-devel] [GIT PULL][RESEND #2] KVM Updates for 2.6.23-rc1

2007-07-18 Thread Avi Kivity
S.Çağlar Onur wrote: Hi Avi; 18 Tem 2007 Çar tarihinde, Avi Kivity şunları yazmıştı: This trace is certainly a kvm bug. What guest are you running? If it is free (and does not contain private information), can you post it somewhere for me to download? After seeing your [PATCH]

Re: Slow Soft-RAID 5 performance

2007-07-18 Thread koan
Are you sure about that chunk size? In you initial posting you show /proc/mdstat reporting: md2 : active raid5 sdc3[2] sda3[0] sdb3[1] 780083968 blocks level 5, 128k chunk, algorithm 2 [3/3] [UUU] Which would seem to state a 128K chunk, and thus with a 4k block size you would need a stride

Re: sunrpc-related Oops in latest git

2007-07-18 Thread Haavard Skinnemoen
On Mon, 16 Jul 2007 10:52:14 -0400 Trond Myklebust [EMAIL PROTECTED] wrote: Please let me know if there's anything I can do to help debug this. Håvard So you are saying that if you revert this patch, and only this patch, then it fixes nfsroot? (sorry, I tend not to trust git-bisect)

Re: [PATCH 10/10] Use standard CR8 flags, and fix TPR definition

2007-07-18 Thread Avi Kivity
H. Peter Anvin wrote: Rusty Russell wrote: Intel manual (and KVM definition) say it's TPR is 4 bits wide. Also fix CR8_RESEVED_BITS typo. Signed-off-by: Rusty Russell [EMAIL PROTECTED] Indeed it is. Acked-by: H. Peter Anvin [EMAIL PROTECTED] Applied-by: Avi Kivity [EMAIL

Re: [PATCH] Use tty_schedule in VT code.

2007-07-18 Thread James Simmons
What should be done is if (tty-low_latency) flush_to_ldisc(tty-buf.work.work); else schedule_delayed_work(tty-buf.work, 1); Is this acceptable to you? In that case, we might as well just always do the scheduled_delayed_work()

Re: [PATCH] Use menuconfig objects - CONFIG_ISDN_I4L [v2]

2007-07-18 Thread Jan Engelhardt
Remove a menu statement and several dependencies from the Kconfig files in the drivers/isdn tree as they have become unnecessary by the transformation of CONFIG_ISDN from menu, config into menuconfig. (Modified version of a patch originally proposed by Jan Engelhardt.) Signed-off-by: Tilman

Re: [PATCH] i386: Decouple PAE from CONFIG_CMPXCHG64

2007-07-18 Thread Andi Kleen
On Wed, Jul 18, 2007 at 07:34:47PM +0300, Avi Kivity wrote: Commit 9d9bbd4d247a674deb43565582151acdc22e90d1 makes CONFIG_CMPXCHG64 dependent on CONFIG_HIGHMEM64G, but KVM guest SMP support now also requires CMPXCHG64 while not being tied to PAE. So the effect of that patch is to disable KVM

Re: Patches for REALLY TINY 386 kernels

2007-07-18 Thread Andi Kleen
On Wed, Jul 18, 2007 at 08:55:50AM -0700, H. Peter Anvin wrote: Andi Kleen wrote: Already with these patches I can compile a zImage kernel that is 450kb large (890kb decompressed) The important part is not how big the vmlinux is, but how much memory is actually used after boot.

Re: [more PATCHes] Use menuconfig objects - CONFIG_ISDN_I4L

2007-07-18 Thread Jan Engelhardt
Hi, here are two more changes I propose for the isdn submenu(s). They go on top of Tilman's patch; each of the two following patches is independent of another. Opinions please :) Jan -- - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message

[patch 1/2] Use menuconfig objects - ISDN

2007-07-18 Thread Jan Engelhardt
Unclutter the ISDN menu a tiny bit by moving ISDN4Linux and the CAPI2.0 layers into their own menu. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- drivers/isdn/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.23/drivers/isdn/Kconfig

[patch 2/2] Use menuconfig objects - ISDN/Gigaset

2007-07-18 Thread Jan Engelhardt
Change Kconfig objects from menu, config into menuconfig so that the user can disable the whole feature without having to enter the menu first. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] --- drivers/isdn/gigaset/Kconfig |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-)

Re: [PATCH] Check for compound pages in set_page_dirty()

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Hugh Dickins wrote: On Wed, 18 Jul 2007, Jens Axboe wrote: We have these checks scattered, makes sense to put them in set_page_dirty() instead. This also fixes a bug where __bio_unmap_user() does set_page_dirty_lock() without checking for a compound page, instead

Re: Patches for REALLY TINY 386 kernels

2007-07-18 Thread Jan Engelhardt
On Jul 18 2007 20:20, Andi Kleen wrote: Well, how big the vmlinux file is matters if it doesn't fit in memory with enough time to get to the phase where it is dumping the init sections. If you don't have enough memory for a few tens of KB of init sections you're very unlikely to have

Re: 2.6.22-git* regression: Kconfig prompts without help text

2007-07-18 Thread Jan Engelhardt
On Jul 18 2007 11:04, Randy Dunlap wrote: I have no idea where it came from. (not me) It was akpm: http://linux.bkbits.net:8080/linux-2.6/Documentation/CodingStyle?PAGE=diffsREV=1.5 I think that would only make sense if ---help--- is used (like you did) instead of the plain help string.

Re: Patches for REALLY TINY 386 kernels

2007-07-18 Thread Adrian Bunk
On Wed, Jul 18, 2007 at 08:55:50AM -0700, H. Peter Anvin wrote: Andi Kleen wrote: Already with these patches I can compile a zImage kernel that is 450kb large (890kb decompressed) The important part is not how big the vmlinux is, but how much memory is actually used after boot.

Re: 2.6.22-git* regression: Kconfig prompts without help text

2007-07-18 Thread Adrian Bunk
On Wed, Jul 18, 2007 at 08:33:27PM +0200, Jan Engelhardt wrote: On Jul 18 2007 11:04, Randy Dunlap wrote: I have no idea where it came from. (not me) It was akpm: http://linux.bkbits.net:8080/linux-2.6/Documentation/CodingStyle?PAGE=diffsREV=1.5 I think that would only make sense

Re: Patches for REALLY TINY 386 kernels

2007-07-18 Thread Andi Kleen
On Wed, Jul 18, 2007 at 08:29:27PM +0200, Jan Engelhardt wrote: On Jul 18 2007 20:20, Andi Kleen wrote: Well, how big the vmlinux file is matters if it doesn't fit in memory with enough time to get to the phase where it is dumping the init sections. If you don't have enough memory

Re: [PATCH] Check for compound pages in set_page_dirty()

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Jens Axboe wrote: On Wed, Jul 18 2007, Hugh Dickins wrote: On Wed, 18 Jul 2007, Jens Axboe wrote: We have these checks scattered, makes sense to put them in set_page_dirty() instead. This also fixes a bug where __bio_unmap_user() does set_page_dirty_lock()

Re: Patches for REALLY TINY 386 kernels

2007-07-18 Thread Jan Engelhardt
On Jul 18 2007 20:33, Adrian Bunk wrote: Well, how big the vmlinux file is matters if it doesn't fit in memory with enough time to get to the phase where it is dumping the init sections. *If that is not the issue*, then axing stuff like CPUID is a major lose in terms of code maintainability

Re: Patches for REALLY TINY 386 kernels

2007-07-18 Thread Andi Kleen
On Wed, Jul 18, 2007 at 08:33:59PM +0200, Adrian Bunk wrote: On Wed, Jul 18, 2007 at 08:55:50AM -0700, H. Peter Anvin wrote: Andi Kleen wrote: Already with these patches I can compile a zImage kernel that is 450kb large (890kb decompressed) The important part is not how big the

Re: Patches for REALLY TINY 386 kernels

2007-07-18 Thread Jan Engelhardt
On Jul 18 2007 20:38, Andi Kleen wrote: Well, how big the vmlinux file is matters if it doesn't fit in memory with enough time to get to the phase where it is dumping the init sections. If you don't have enough memory for a few tens of KB of init sections you're very unlikely to

Re: [PATCH] Check for compound pages in set_page_dirty()

2007-07-18 Thread Hugh Dickins
On Wed, 18 Jul 2007, Jens Axboe wrote: OK, you clearly have more knowledge in that area than I, but I do wish that you would have made a note in the code at least to remove things like this. It's pretty ugly to have superflous tests like that, especially since there was not even a comment

Re: Patches for REALLY TINY 386 kernels

2007-07-18 Thread Andi Kleen
And the hypothetical case where RAM is hotplugged and/or recognized after the kernel has been loaded by the bootloader? I do not claim to be an expert, but RAM hotadd needs working user space to trigger it. Besides it typically comes with cpuhotplug too, so you couldn't even discard __cpuinit.

Re: [PATCH] Check for compound pages in set_page_dirty()

2007-07-18 Thread Jens Axboe
On Wed, Jul 18 2007, Hugh Dickins wrote: On Wed, 18 Jul 2007, Jens Axboe wrote: OK, you clearly have more knowledge in that area than I, but I do wish that you would have made a note in the code at least to remove things like this. It's pretty ugly to have superflous tests like that,

Re: [PATCH] Revert part of 3f1b0e1f287547903f11fa1e6de7d2765597766e

2007-07-18 Thread Alexey Dobriyan
On Wed, Jul 18, 2007 at 09:03:13PM +0300, S.Çağlar Onur wrote: With 3f1b0e1f287547903f11fa1e6de7d2765597766e Linus's current git tree starts to ignore any *.orig or *.rej files (for example git status cannot show what are they) but if there are some *.orig or *.rej files exists, for

[PATCH] Conexant 2388x: check for kthread_run

2007-07-18 Thread Cyrill Gorcunov
This patch adds checking of kthread_run return code. Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED] --- Probably we could just ignore a such situation (we do check for core-kthread value before trying to stop the thread) but we have to leave a footmark in kernel messages anyway I guess.

Re: sunrpc-related Oops in latest git

2007-07-18 Thread Trond Myklebust
On Wed, 2007-07-18 at 20:07 +0200, Haavard Skinnemoen wrote: On Mon, 16 Jul 2007 10:52:14 -0400 Trond Myklebust [EMAIL PROTECTED] wrote: Please let me know if there's anything I can do to help debug this. Håvard So you are saying that if you revert this patch, and only this

[GIT PULL] Bug- and documentation fixes for the x86 setup code

2007-07-18 Thread H. Peter Anvin
Hi Linus, please pull: git://git.kernel.org/pub/scm/linux/kernel/git/hpa/linux-2.6-x86setup.git for-linus H. Peter Anvin (5): [x86 setup] MAINTAINERS: document x86 setup code git tree [x86 setup] build/tools.c: fix comment [x86 setup] Fix assembly constraints [x86

Re: [PATCH] Revert part of 3f1b0e1f287547903f11fa1e6de7d2765597766e

2007-07-18 Thread S.Çağlar Onur
Hi; 18 Tem 2007 Çar tarihinde, Alexey Dobriyan şunları yazmıştı: *.orig are generated even if line numbers change a bit, so untrusted is a somewhat exaggerated. :), although i prefer previous one, what about something like following? With 3f1b0e1f287547903f11fa1e6de7d2765597766e Linus's

[PATCH] Use read and write crX in .c files

2007-07-18 Thread Glauber de Oliveira Costa
This patch uses the read and write functions provided at system.h for control registers instead of writting raw assembly over and over again in .c files. Functions to manipulate cr2 and cr8 were provided, as they were lacking. Also, removed some extra space after closing brackets

Re: [PATCH] posix-timer: fix deletion race

2007-07-18 Thread Jeremy Katz
On Wed, 18 Jul 2007, Thomas Gleixner wrote: On Wed, 2007-07-18 at 08:05 +0200, Thomas Gleixner wrote: On Tue, 2007-07-17 at 16:58 -0700, Jeremy Katz wrote: EFLAGS: 00010246 (2.6.22.1-WR1.4aq_cgl #2) Hmm. Are there any other patches on that kernel ? Just hrt6 and your proposed fix. The

Re: Patches for REALLY TINY 386 kernels

2007-07-18 Thread H. Peter Anvin
Adrian Bunk wrote: On Wed, Jul 18, 2007 at 08:55:50AM -0700, H. Peter Anvin wrote: Andi Kleen wrote: Already with these patches I can compile a zImage kernel that is 450kb large (890kb decompressed) The important part is not how big the vmlinux is, but how much memory is actually used after

Re: [PATCH] posix-timer: fix deletion race

2007-07-18 Thread Jeremy Katz
On Wed, 18 Jul 2007, Oleg Nesterov wrote: Jeremy, I agree with Thomas that your patch should not be right, but it does make a difference. Perhaps this is just the timing, but who knows. Could you add some printk's to be sure that lock_timer() actually fails while it never should? Agreed.

Re: [kvm-devel] [RFC] Deferred interrupt handling.

2007-07-18 Thread Lennart Sorensen
On Wed, Jul 18, 2007 at 07:46:13PM +0300, Avi Kivity wrote: IMO the only reasonable solution is to disallow interrupt forwarding with shared irqs. If someone later comes up with a bright idea, we can implement it. Otherwise the problem will solve itself with hardware moving to msi.

[GIT PULL] AVR32 update

2007-07-18 Thread Haavard Skinnemoen
Hi Linus, Please pull git://git.kernel.org/pub/scm/linux/kernel/git/hskinnemoen/avr32-2.6.git for-linus to receive the following updates. David Brownell (2): [AVR32] faster avr32 unaligned access [AVR32] Make STK1000 mux settings configurable Haavard Skinnemoen (5):

Re: [kvm-devel] [PATCH 3/3] KVM - add hypercall nr to kvm_run

2007-07-18 Thread Anthony Liguori
Jeff Dike wrote: On Wed, Jul 18, 2007 at 11:28:18AM -0500, Anthony Liguori wrote: Within the kernel right (VMCALL is only usable in ring 1). Yup. Is it terribly important to be able to pass through the syscall arguments in registers verses packing them in a data structure and

Re: [PATCH] Conexant 2388x: check for kthread_run

2007-07-18 Thread Mauro Carvalho Chehab
Hi Cyrill, Em Qua, 2007-07-18 às 22:56 +0400, Cyrill Gorcunov escreveu: This patch adds checking of kthread_run return code. Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED] --- Probably we could just ignore a such situation (we do check for core-kthread value before trying to stop the

Re: [PATCH] Use tty_schedule in VT code.

2007-07-18 Thread Paul Fulghum
On Wed, 2007-07-18 at 19:17 +0100, James Simmons wrote: I have no problem leaving at one. Here is the new patch. I did address the problem with tty_flip_buffer_push in this patch. It is possible for a driver to call tty_flip_buffer_push within a interrupt context if they set the low_latency

<    4   5   6   7   8   9   10   11   12   >