Re: [PATCH] make atomic_t volatile on all architectures

2007-08-11 Thread Segher Boessenkool
You'd have to use "+m". Yes, though I would use "=m" on the output list and "m" on the input list. The reason is that I've seen gcc fall on its face with an ICE on s390 due to "+m". The explanation I've got from our compiler people was quite esoteric, as far as I remember gcc splits "+m" to an

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread WU Fengguang
On Sat, Aug 11, 2007 at 11:31:09PM +0530, Balbir Singh wrote: > Andrew Morton wrote: > > On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote: > >>> > >> Shouldn't we just not stop vm accounting for kernel threads? > >> > > > > Could be. It'd help heaps if we knew which

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread WU Fengguang
On Sat, Aug 11, 2007 at 10:00:15AM -0700, Andrew Morton wrote: > On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote: > > > On 8/11/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: > > hm, both people who replied to this removed Fengguang from cc. Disagreement > between

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Cyrill Gorcunov
[Fengguang Wu - Sun, Aug 12, 2007 at 01:29:15PM +0800] | On Sat, Aug 11, 2007 at 06:17:14PM +0400, Cyrill Gorcunov wrote: | > [Fengguang Wu - Sat, Aug 11, 2007 at 09:21:31PM +0800] | > | Andrew, | > | | > | I'm not sure if this patch is the right fix for the bug. But it do | > | stops the oops

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Fengguang Wu
On Sat, Aug 11, 2007 at 06:17:14PM +0400, Cyrill Gorcunov wrote: > [Fengguang Wu - Sat, Aug 11, 2007 at 09:21:31PM +0800] > | Andrew, > | > | I'm not sure if this patch is the right fix for the bug. But it do > | stops the oops message. The bug also happens in > 2.6.23-rc1-mm2/2.6.23-rc2-mm2. >

Re: CFS review

2007-08-11 Thread Ingo Molnar
* Willy Tarreau <[EMAIL PROTECTED]> wrote: > > 1. Two simple busy loops, one of them is reniced to 15, according to > > my calculations the reniced task should get about 3.4% > > (1/(1.25^15+1)), but I get this: > > > > PID USER PR NI VIRT RES SHR S %CPU %MEMTIME+ COMMAND > >

Re: Driver-level memory management

2007-08-11 Thread Paul Mundt
On Sat, Aug 11, 2007 at 09:14:00PM -0600, Michael Bourgeous wrote: > I'm working on a driver for older HDTV cards based on the TL880 chip. > These cards typically have 16MB of their own memory, which is > available to me over the PCI bus. Various functions of the card > require me to manage this

Re: [PATCH] - Add "def_bool" Kconfig format documentation

2007-08-11 Thread Randy Dunlap
On Tue, 07 Aug 2007 00:29:40 +0200 Vincent Legoll wrote: > Hello, > > here is a small documentation patch for the KConfig file format > "def_bool" type definition that was missing. There are also def_boolean and def_tristate. I suppose that I should resubmit this patch:

[PATCH] sysdev: remove global sysdev drivers list

2007-08-11 Thread Akinobu Mita
No one uses sysdev_drivers. Because no one calls sysdev_driver_register with NULL class. And it is difficult to imagine that someone want to implement a global sysdev driver which is called with all sys_device on any kind of sysdev_class. So this patch removes global sysdev_drivers list. Cc:

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Kyle Moffett
Linus and AKPM pulled from CC, I'm sure they're bored to tears by now ;-). On Aug 11, 2007, at 21:21:55, Casey Schaufler wrote: --- Kyle Moffett <[EMAIL PROTECTED]> wrote: On Aug 11, 2007, at 17:01:09, Casey Schaufler wrote: It would be instructive for those who are not well versed in the

Re: CFS review

2007-08-11 Thread Ingo Molnar
* Al Boldi <[EMAIL PROTECTED]> wrote: > That's because granularity increases when decreasing nice, and results > in larger timeslices, which affects smoothness negatively. chew.c > easily shows this problem with 2 background cpu-hogs at the same > nice-level. > > pid 908, prio 0, out for

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Keith Owens
Casey Schaufler (on Sat, 11 Aug 2007 10:57:31 -0700) wrote: >Smack is the Simplified Mandatory Access Control Kernel. > > [snip] > >Smack defines and uses these labels: > >"*" - pronounced "star" >"_" - pronounced "floor" >"^" - pronounced "hat" >"?" - pronounced "huh" > >The

Re: Are we properly prepared to handle 3 Socket setups?

2007-08-11 Thread Rene Herman
On 08/12/2007 05:29 AM, Roland Dreier wrote: > /* > * Maximum threshold is 125 > */ > threshold = min(125, threshold); > > as either the comment or the code is wrong and it seems it's the > code. What's the problem? That line sets threshold to the

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Keith Owens
Casey Schaufler (on Sat, 11 Aug 2007 12:56:42 -0700 (PDT)) wrote: > >--- Arjan van de Ven <[EMAIL PROTECTED]> wrote: >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include >> > +#include "../../net/netlabel/netlabel_domainhash.h" >> >> can't you move this header to

[BUG] Kernel panic - not syncing: VFS

2007-08-11 Thread charles gagalac
i'm getting the following kernel panic when booting: Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) a bisect generated the commit below: 3320ad994afb2c44ad34b3b34c3c5cf0da297331 is first bad commit commit 3320ad994afb2c44ad34b3b34c3c5cf0da297331 Author: dean

[RFC] FUSE: mnotify (was: [RFC] VFS: mnotify)

2007-08-11 Thread Al Boldi
Al Boldi wrote: > Jakob Oestergaard wrote: > > Why on earth would you cripple the kernel defaults for ext3 (which is a > > fine FS for boot/root filesystems), when the *fundamental* problem you > > really want to solve lie much deeper in the implementation of the > > filesystem? Noatime doesn't

reset during bootup - 2.6.23-rc2 (git d23cf676)

2007-08-11 Thread Dan Merillat
This one is going to be fun, since it's a hard reset back to bios, no OOPS or anything shown. It may be about the time RadeonFB kicks in, but it's impossible to tell. I'd guess 15-20 lines into dmesg. I'm in the process of bisecting, currently 94c18227..d23cf676. Any guesses of a specific

Re: Are we properly prepared to handle 3 Socket setups?

2007-08-11 Thread Roland Dreier
> /* > * Maximum threshold is 125 > */ > threshold = min(125, threshold); > > as either the comment or the code is wrong and it seems it's the > code. What's the problem? That line sets threshold to the smaller of the current value or 125, which is

[GIT PULL] sh64 updates for 2.6.23-rc3

2007-08-11 Thread Paul Mundt
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh64-2.6.git Which contains: Jesper Juhl (1): sh64: arch/sh64/kernel/signal.c: duplicate include removal Michal Piotrowski (1): sh64: arch/sh64/kernel/setup.c: duplicate include removal. Paul Mundt (1):

Re: Documentation files in html format?

2007-08-11 Thread Sam Ravnborg
> Hi Sam, > > Sorry for the late question (I've been away :). > > Was your makefiles.txt conversion done totally by hand? Yes. A few search, the rest manual. > Could it be automated? For text with a unifom structure like makefiles.txt - yes. Sam - To unsubscribe from this list: send

[GIT PULL] sh updates for 2.6.23-rc3

2007-08-11 Thread Paul Mundt
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6.23.git Which contains: Paul Mundt (3): sh: Fix PTRACE_PEEKTEXT/PEEKDATA fallout from generic_ptrace_peekdata(). sh: panic on machvec section misalignment. sh: Add missing

Re: Are we properly prepared to handle 3 Socket setups?

2007-08-11 Thread Rene Herman
On 08/12/2007 03:52 AM, Jesper Juhl wrote: On 12/08/07, Rene Herman <[EMAIL PROTECTED]> wrote: On 08/12/2007 03:08 AM, Jesper Juhl wrote: This may be a little off topic, but I think it's interresting enough to warrent a single mail. I just saw a news article

Driver-level memory management

2007-08-11 Thread Michael Bourgeous
Hello everyone, I'm working on a driver for older HDTV cards based on the TL880 chip. These cards typically have 16MB of their own memory, which is available to me over the PCI bus. Various functions of the card require me to manage this memory, allocating and freeing chunks of it as necessary.

Re: Documentation files in html format?

2007-08-11 Thread Randy Dunlap
On Sat, 11 Aug 2007 16:17:19 +0200 Willy Tarreau wrote: > On Sat, Aug 11, 2007 at 10:19:25AM -0400, J. Bruce Fields wrote: > > On Fri, Aug 10, 2007 at 10:51:17PM +0200, Willy Tarreau wrote: > > > The problem I have with asciidoc is that it's a nightmare to get it > > > to work. It's what GIT

Re: Documentation files in html format?

2007-08-11 Thread Randy Dunlap
On Fri, 10 Aug 2007 22:17:04 +0200 Willy Tarreau wrote: > Hi Stephen, > > On Thu, Aug 09, 2007 at 11:31:22AM +0100, Stephen Hemminger wrote: > > Since the network device documentation needs a rewrite, I was thinking > > of using basic html format instead of just plain text. But since this would

Re: Documentation files in html format?

2007-08-11 Thread Randy Dunlap
On Fri, 10 Aug 2007 22:12:35 +0200 Sam Ravnborg wrote: > > > > What primary requirements does in-tree Linux kernel documentation have > > to fulfill in general? > > Skipping the obvious ones such as correct, up-to-date etc. > o Readable as-is > o Grepable > o buildable as structured documents

Re: [PATCH] Re: cciss: warning: right shift count >= width of type

2007-08-11 Thread Rene Herman
On 08/12/2007 03:25 AM, Rene Herman wrote: On 08/12/2007 02:56 AM, Jesper Juhl wrote: (whoops, forgot to add maintainer to Cc - now added) Ehm... too late... Useless followup though -- hp.com rejects me as it feels the SPF neutral results gmail sends due to me not using the gmail SMTP

Re: Are we properly prepared to handle 3 Socket setups?

2007-08-11 Thread Jesper Juhl
On 12/08/07, Rene Herman <[EMAIL PROTECTED]> wrote: > On 08/12/2007 03:08 AM, Jesper Juhl wrote: > > > This may be a little off topic, but I think it's interresting enough > > to warrent a single mail. > > > > I just saw a news article (http://www.theinquirer.net/?article=41610) > > about a 3

[PATCH] Re: cciss: warning: right shift count >= width of type

2007-08-11 Thread Rene Herman
On 08/12/2007 02:28 AM, Jesper Juhl wrote: I've been building some randconfig kernels lately and I've noticed this in a few builds : drivers/block/cciss.c:2614: warning: right shift count >= width of type drivers/block/cciss.c:2615: warning: right shift count >= width of type

[PATCH] Re: cciss: warning: right shift count >= width of type

2007-08-11 Thread Rene Herman
On 08/12/2007 02:56 AM, Jesper Juhl wrote: (whoops, forgot to add maintainer to Cc - now added) Ehm... too late... On 12/08/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: Hi, I've been building some randconfig kernels lately and I've noticed this in a few builds : drivers/block/cciss.c:2614:

Re: Are we properly prepared to handle 3 Socket setups?

2007-08-11 Thread Rene Herman
On 08/12/2007 03:08 AM, Jesper Juhl wrote: This may be a little off topic, but I think it's interresting enough to warrent a single mail. I just saw a news article (http://www.theinquirer.net/?article=41610) about a 3 Socket Opteron motherboard and couldn't help but wonder if we are prepared

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Casey Schaufler
--- Andi Kleen <[EMAIL PROTECTED]> wrote: > Casey Schaufler <[EMAIL PROTECTED]> writes: > > > Smack is the Simplified Mandatory Access Control Kernel. > > I like the simplified part. > > > +static int smk_get_access(smack_t sub, smack_t obj) > > +{ > > + struct smk_list_entry *sp =

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Casey Schaufler
--- Kyle Moffett <[EMAIL PROTECTED]> wrote: > On Aug 11, 2007, at 17:01:09, Casey Schaufler wrote: > >> [SELinux...] which can do *all* of this, completely and without > >> exceptions, > > > > That's quite a strong assertion. > > It is, but I stand by it. If anyone can point out some portion

Are we properly prepared to handle 3 Socket setups?

2007-08-11 Thread Jesper Juhl
Hi, This may be a little off topic, but I think it's interresting enough to warrent a single mail. I just saw a news article (http://www.theinquirer.net/?article=41610) about a 3 Socket Opteron motherboard and couldn't help but wonder if we are prepared to deal with such a beast, so I thought

Re: cciss: warning: right shift count >= width of type

2007-08-11 Thread Jesper Juhl
(whoops, forgot to add maintainer to Cc - now added) On 12/08/07, Jesper Juhl <[EMAIL PROTECTED]> wrote: > Hi, > > I've been building some randconfig kernels lately and I've noticed > this in a few builds : > > drivers/block/cciss.c:2614: warning: right shift count >= width of type >

cciss: warning: right shift count >= width of type

2007-08-11 Thread Jesper Juhl
Hi, I've been building some randconfig kernels lately and I've noticed this in a few builds : drivers/block/cciss.c:2614: warning: right shift count >= width of type drivers/block/cciss.c:2615: warning: right shift count >= width of type drivers/block/cciss.c:2616: warning: right shift count

mtd: build failure in drivers/mtd/chips/chipreg.c / include/linux/mtd/map.h

2007-08-11 Thread Jesper Juhl
Trying to build current Linus git tree (head at ac07860264bd2b18834d3fa3be47032115524cea) using the attached config file (generated by 'make randconfig') the build fails for me with : ... CC drivers/mtd/chips/chipreg.o In file included from drivers/mtd/chips/chipreg.c:13:

mtd: build failure - error: implicit declaration of function 'cfi_interleave'

2007-08-11 Thread Jesper Juhl
Trying to build current Linus git tree (head at ac07860264bd2b18834d3fa3be47032115524cea) using the attached config file (generated by 'make randconfig') the build fails for me with : ... CC drivers/mtd/rfd_ftl.o CC drivers/mtd/chips/chipreg.o CC

Build failure in advansys driver - error: implicit declaration of function 'to_pci_dev'

2007-08-11 Thread Jesper Juhl
Trying to build current Linus git tree (head at ac07860264bd2b18834d3fa3be47032115524cea) using the attached config file (generated by 'make randconfig') the build fails for me with : ... CC drivers/scsi/advansys.o drivers/scsi/advansys.c:794:2: warning: #warning this driver is still

Re: encrypted hibernation (was Re: Hibernation considerations)

2007-08-11 Thread Dr. David Alan Gilbert
* Pavel Machek ([EMAIL PROTECTED]) wrote: > Hi! > > > > > Two things which I think would be nice to consider are: > > > >1) Encryption - I'd actually prefer if my luks device did not > > > >remember the key accross a hibernation; I want to be forced to > > > >reenter the

Re: two questions about the boot_delay

2007-08-11 Thread Randy Dunlap
On Wed, 8 Aug 2007 07:39:33 + Dave Young wrote: > Hi, > I have tried the "slow down printk" , and I have two questions. > > 1. why it depends the DEBUG_KERNEL? Sometimes we only need boot_delay > to see the printk infomations. How about set it as a standalone > config option? Is depending

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Casey Schaufler
--- Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Aug 11 2007 10:57, Casey Schaufler wrote: > > > >"*" - pronounced "star" > wall > >"_" - pronounced "floor" > floor > >"^" - pronounced "hat" > roof > >"?" - pronounced "huh" > it's dark in here :) It's almost worth

Re: [PATCH 00/23] per device dirty throttling -v8

2007-08-11 Thread Valerie Henson
On Wed, Aug 08, 2007 at 05:54:57PM -0700, Martin Bligh wrote: > Andrew Morton wrote: > >On Wed, 08 Aug 2007 14:10:15 -0700 > >"Martin J. Bligh" <[EMAIL PROTECTED]> wrote: > > > >>Why isn't this easily fixable by just adding an additional dirty > >>flag that says atime has changed? Then we only

[PATCH 5/5] Add a 00-INDEX file to Documentation/watchdog/

2007-08-11 Thread Jesper Juhl
Add a 00-INDEX file to Documentation/watchdog/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- 00-INDEX | 10 ++ 1 file changed, 10 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ linux-2.6/Documentation/watchdog/00-INDEX 2007-08-12 00:06:01.0

[PATCH 4/5] Add a 00-INDEX file to Documentation/telephony/

2007-08-11 Thread Jesper Juhl
Add a 00-INDEX file to Documentation/telephony/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- 00-INDEX |4 1 file changed, 4 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ linux-2.6/Documentation/telephony/00-INDEX 2007-08-11 23:55:54.0 +0200 @@

[PATCH 3/5] Add a 00-INDEX file to Documentation/sysctl/

2007-08-11 Thread Jesper Juhl
Add a 00-INDEX file to Documentation/sysctl/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- 00-INDEX | 16 1 file changed, 16 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ linux-2.6/Documentation/sysctl/00-INDEX 2007-08-11 23:52:50.0

[PATCH 2/5] Add a 00-INDEX file to Documentation/mips/

2007-08-11 Thread Jesper Juhl
Add a 00-INDEX file to Documentation/mips/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- 00-INDEX |8 1 file changed, 8 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ linux-2.6/Documentation/mips/00-INDEX 2007-08-11 22:56:26.0 +0200 @@

[PATCH 0/5] Add some missing Documentation/*/00-INDEX files

2007-08-11 Thread Jesper Juhl
Hi, Rob Landley is trying to organize Linux kernel documentation. One thing he is doing is generating index.html files based on our 00-INDEX files in the Documentation directory. He has met with a small problem however, since not all subdirectories inside Documentation contain such a file,

[PATCH 1/5] Add a 00-INDEX file to Documentation/auxdisplay/

2007-08-11 Thread Jesper Juhl
Add a 00-INDEX file to Documentation/auxdisplay/ Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- 00-INDEX |8 1 file changed, 8 insertions(+) --- /dev/null 2005-11-21 04:22:37.0 +0100 +++ linux-2.6/Documentation/auxdisplay/00-INDEX 2007-08-11 23:58:49.0

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Andi Kleen
Casey Schaufler <[EMAIL PROTECTED]> writes: > Smack is the Simplified Mandatory Access Control Kernel. I like the simplified part. > +static int smk_get_access(smack_t sub, smack_t obj) > +{ > + struct smk_list_entry *sp = smack_list; > + > + for (; sp != NULL; sp = sp->smk_next) > +

Re: [PATCH 3/3] ACPI: thinkpad-acpi: change thinkpad-acpi input default and kconfig help

2007-08-11 Thread Henrique de Moraes Holschuh
On Sat, 11 Aug 2007, Michael S. Tsirkin wrote: > > Quoting Henrique de Moraes Holschuh <[EMAIL PROTECTED]>: > > Subject: [PATCH 3/3] ACPI: thinkpad-acpi: change thinkpad-acpi input > > default and kconfig help > > > > The current kconfig help text was misleading users. Also, the default for > >

[PATCH] Re: 2.6.23-rc2-mm2: sata disk going slow

2007-08-11 Thread Hugh Dickins
Why is the G5 so slow with 2.6.23-rc2-mm2? hdparm -t shows 1.8MB/sec instead of 58MB/sec. alpm-increase-number-of-allowable-device-flags.patch (raising ATA_DFLAG_CFG_MASK) turns out to be the guilty party: though the problem doesn't appear until the next patch, which adds ATA_DFLAG_IPM as the

Re: Weird network problems with 2.6.23-rc2

2007-08-11 Thread Jiri Kosina
On Sat, 11 Aug 2007, Shish wrote: > Something seems to have broken in 2.6.23-rc2, and I'm not sure what, or > where I should look for further debugging. The info I have: > > On my 2.6.23-rc2 desktop, things run fine. > > On my test server, built from the same source tree, networking goes >

[PATCH] tuxonice-head 070811

2007-08-11 Thread Steven
Small problem with kernel/power/tuxonice_checksum.c which causes compilation to fail with wrong type for get_next_bit_on --- tuxonice_checksum.c.orig2007-08-11 14:22:52.0 -0700 +++ tuxonice_checksum.c 2007-08-11 14:23:01.0 -0700 @@ -292,7 +292,7 @@ if (check)

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Kyle Moffett
On Aug 11, 2007, at 17:01:09, Casey Schaufler wrote: [SELinux...] which can do *all* of this, completely and without exceptions, That's quite a strong assertion. It is, but I stand by it. If anyone can point out some portion of this which *cannot* be implemented as SELinux policy I will

Re: resume from ram much slower

2007-08-11 Thread Rafael J. Wysocki
On Saturday, 11 August 2007 11:04, Arkadiusz Miskiewicz wrote: > On Friday 10 of August 2007, Rafael J. Wysocki wrote: > > On Friday, 10 August 2007 18:48, Arkadiusz Miskiewicz wrote: > > > Hi, > > > > > > Starting 1-2 weeks ago I have very long resume from > > > ram times. It takes more than 1

Re: [3/3] 2.6.23-rc2: known regressions v2

2007-08-11 Thread Rafael J. Wysocki
On Saturday, 11 August 2007 12:53, Meelis Roos wrote: > > > > 3. Can you please check if this patch changes anything: > > > > http://marc.info/?l=linux-mm-commits=118669680811669=2 > > > > > > Tried it on current git, kernel/power/Kconfig gave 2 rejects. > > > Tried on 2.6.23-rc2, still 2 rejects

Re: [PATCH] Minor fix to Documentation/powerpc/00-INDEX

2007-08-11 Thread Randy Dunlap
On Thu, 9 Aug 2007 23:42:35 -0500 Rob Landley wrote: > Signed-off-by: Rob Landley <[EMAIL PROTECTED]> > > I have a python script to convert 00-INDEX files into index.html files, and a > second script to show 404 errors in the result as well as files/directories > nothing links to. (It's not

Re: joydev.c and saitek cyborg evo force

2007-08-11 Thread Renato Golin
On 11/08/07, Jiri Kosina <[EMAIL PROTECTED]> wrote: > Force feedback functionality shouldn't be influenced in any means by this > patch - FF implementation doesn't care about the values of the > input_dev->abs{max,min,fuzz,flat}. So it means the patch should work for all other joysticks as well?

Re: joydev.c and saitek cyborg evo force

2007-08-11 Thread Jiri Kosina
On Sat, 11 Aug 2007, Renato Golin wrote: > fixes perfectly. But it probably breaks the output range and kills the > force-feedback. Thanks for testing. Force feedback functionality shouldn't be influenced in any means by this patch - FF implementation doesn't care about the values of the

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Casey Schaufler
--- Kyle Moffett <[EMAIL PROTECTED]> wrote: > On Aug 11, 2007, at 13:57:31, Casey Schaufler wrote: > > Smack implements mandatory access control (MAC) using labels > > attached to tasks and data containers, including files, SVIPC, and > > other tasks. Smack is a kernel based scheme that

Re: [linux-usb-devel] 2.6.23-rc2-mm2

2007-08-11 Thread David Brownell
On Friday 10 August 2007, Gabriel C wrote: > Getting that with gcc 4.2.1 : > > drivers/usb/host/ohci-dbg.c: In function 'show_registers': > drivers/usb/host/ohci-dbg.c:620: warning: the address of 'next' will always > evaluate as 'true' > drivers/usb/host/ohci-dbg.c:639: warning: the address of

Re: [PATCH] Add missing newlines to some uses of dev_ messages

2007-08-11 Thread David Brownell
On Saturday 11 August 2007, Jean Delvare wrote: > Note that there are 3 more messages to fix in > drivers/i2c/chips/menelaus.c (3 calls to pr_err.) I'd hope those will get fixed by final versions of the patches I've seen floating around definining a standard pr_err() ... not fixing them here

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Jan Engelhardt
On Aug 11 2007 10:57, Casey Schaufler wrote: > >"*" - pronounced "star" wall >"_" - pronounced "floor" floor >"^" - pronounced "hat" roof >"?" - pronounced "huh" it's dark in here :) >+config SECURITY_SMACK >+ bool "Simplified Mandatory Access Control Kernel Support" >+

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Casey Schaufler
--- Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > +extern struct smk_list_entry *smack_list; > > any reason to invent your own list rather than just using list.h? The list.h mechanisms are fine, but heavier than I require. I'm willing to give in on it, but I don't see an advantage. > > + >

Re: 2.6.23-rc2-mm1: rcutorture xtime usage

2007-08-11 Thread Paul E. McKenney
On Sat, Aug 11, 2007 at 08:09:09PM +0200, Ingo Molnar wrote: > > * Paul E. McKenney <[EMAIL PROTECTED]> wrote: > > > Add an EXPORT_SYMBOL_GPL() for cpu_clock() and make rcutorture.c use it. > > Compiles, but not yet tested. > > > > Signed-off-by: Paul E. McKenney <[EMAIL PROTECTED]> > > > ---

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Kyle Moffett
On Aug 11, 2007, at 13:57:31, Casey Schaufler wrote: Smack implements mandatory access control (MAC) using labels attached to tasks and data containers, including files, SVIPC, and other tasks. Smack is a kernel based scheme that requires an absolute minimum of application support and a

Re: [PATCH] Smack: Simplified Mandatory Access Control Kernel

2007-08-11 Thread Arjan van de Ven
> +extern struct smk_list_entry *smack_list; any reason to invent your own list rather than just using list.h? > + > +#include > +#include > +#include > +#include > +#include > +#include "../../net/netlabel/netlabel_domainhash.h" can't you move this header to include/ instead? > + >

Re: Documentation files in html format?

2007-08-11 Thread Rene Herman
On 08/11/2007 08:31 AM, Stefan Richter wrote: Rene Herman wrote: On 08/10/2007 10:12 PM, Sam Ravnborg wrote: What primary requirements does in-tree Linux kernel documentation have to fulfill in general? Skipping the obvious ones such as correct, up-to-date etc. o Readable as-is o Grepable o

[2.6.20.16 review 04/28] make freezeable workqueues singlethread

2007-08-11 Thread Willy Tarreau
It is a known fact that freezeable multithreaded workqueues doesn't like CPU_DEAD. We keep them only for the incoming CPU-hotplug rework. Sadly, we can't just kill create_freezeable_workqueue() right now, make them singlethread. Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> Cc: "Rafael J.

[2.6.20.16 review 27/28] NTP: remove clock_was_set() call to prevent deadlock

2007-08-11 Thread Willy Tarreau
The clock_was_set() call in seconds_overflow() which happens only when leap seconds are inserted / deleted is wrong in two aspects: 1. it results in a call to on_each_cpu() with interrupts disabled 2. it is potential deadlock source vs. call_lock in smp_call_function() The only possible side

[2.6.20.16 review 11/28] rt-mutex: Fix chain walk early wakeup bug

2007-08-11 Thread Willy Tarreau
Alexey Kuznetsov found some problems in the pi-futex code. One of the root causes is: When a wakeup happens, we do not to stop the chain walk so we we follow a non existing locking chain. Drop out when this happens. Cc: Alexey Kuznetsov <[EMAIL PROTECTED]> Signed-off-by: Thomas Gleixner

[2.6.20.16 review 10/28] rt-mutex: Fix stale return value

2007-08-11 Thread Willy Tarreau
Alexey Kuznetsov found some problems in the pi-futex code. The major problem is a stale return value in rt_mutex_slowlock(): When the pi chain walk returns -EDEADLK, but the waiter was woken up during the phases where the locks were dropped, the rtmutex could be acquired, but due to the stale

[2.6.20.16 review 22/28] POWERPC: Fix subtle FP state corruption bug in signal return on SMP

2007-08-11 Thread Willy Tarreau
This fixes a bug which can cause corruption of the floating-point state on return from a signal handler. If we have a signal handler that has used the floating-point registers, and it happens to context-switch to another task while copying the interrupted floating-point state from the user stack

[2.6.20.16 review 06/28] e1000: disable polling before registering netdevice

2007-08-11 Thread Willy Tarreau
To assure the symmetry of poll enable/disable in up/down, we should initialize the netdevice to be poll_disabled at load time. Doing this after register_netdevice leaves us open to another race, so lets move all the netif_* calls above register_netdevice so the stack starts out how we expect it to

[2.6.20.16 review 25/28] serial: clear proper MPSC interrupt cause bits

2007-08-11 Thread Willy Tarreau
The interrupt clearing code in mpsc_sdma_intr_ack() mistakenly clears the interrupt for both controllers instead of just the one its supposed to. This can result in the other controller appearing to hang because its interrupt was effectively lost. So, don't clear the interrupt cause bits for both

[2.6.20.16 review 26/28] i386: fix infinite loop with singlestep int80 syscalls

2007-08-11 Thread Willy Tarreau
The commit 635cf99a80f4ebee59d70eb64bb85ce829e4591f introduced a regression. Executing a ptrace single step after certain int80 accesses will infinitely loop and never advance the PC. The TIF_SINGLESTEP check should be done on the return from the syscall and not before it. The new test case is

[2.6.20.16 review 28/28] sky2: workaround for lost IRQ

2007-08-11 Thread Willy Tarreau
This patch restores a couple of workarounds from 2.6.16: * restart transmit moderation timer in case it expires during IRQ routine * default to having 10 HZ watchdog timer. At this point it more important not to hang than to worry about the power cost. Signed-off-by: Stephen Hemminger <[EMAIL

[2.6.20.16 review 23/28] mm: kill validate_anon_vma to avoid mapcount BUG

2007-08-11 Thread Willy Tarreau
validate_anon_vma gave a useful check on the integrity of the anon_vma list when Andrea was developing obj rmap; but it was not enabled in SLES9 itself, nor in mainline, until Nick changed commented-out RMAP_DEBUG to configurable CONFIG_DEBUG_VM in 2.6.17. Now Petr Vandrovec reports that its

[2.6.20.16 review 24/28] saa7134: fix thread shutdown handling

2007-08-11 Thread Willy Tarreau
This patch changes the test for the thread pid from >= 0 to > 0. When the saa7134 driver initialization fails after a certain point, it goes through the complete shutdown process for the driver. Part of shutting it down includes tearing down the thread for tv audio. The test for tearing down

[2.6.20.16 review 15/28] dm crypt: disable barriers

2007-08-11 Thread Willy Tarreau
Disable barriers in dm-crypt because of current workqueue processing can reorder requests. This must be addresed later but for now disabling barriers is needed to prevent data corruption. Signed-off-by: Milan Broz <[EMAIL PROTECTED]> Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]> Cc: Jens

[2.6.20.16 review 19/28] sched: fix next_interval determination in idle_balance()

2007-08-11 Thread Willy Tarreau
Fix massive SMP imbalance on NUMA nodes observed on 2.6.21.5 with CFS. (and later on reproduced without CFS as well). The intervals of domains that do not have SD_BALANCE_NEWIDLE must be considered for the calculation of the time of the next balance. Otherwise we may defer rebalancing forever and

[2.6.20.16 review 17/28] dm crypt: fix avoid cloned bio ref after free

2007-08-11 Thread Willy Tarreau
Do not access the bio after generic_make_request We should never access a bio after generic_make_request - there's no guarantee it still exists. Signed-off-by: Olaf Kirch <[EMAIL PROTECTED]> Signed-off-by: Alasdair G Kergon <[EMAIL PROTECTED]> Cc: Jens Axboe <[EMAIL PROTECTED]> Signed-off-by:

[2.6.20.16 review 21/28] audit: fix oops removing watch if audit disabled

2007-08-11 Thread Willy Tarreau
Removing a watched file will oops if audit is disabled (auditctl -e 0). To reproduce: - auditctl -e 1 - touch /tmp/foo - auditctl -w /tmp/foo - auditctl -e 0 - rm /tmp/foo (or mv) Signed-off-by: Tony Jones <[EMAIL PROTECTED]> Cc: Al Viro <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL

[2.6.20.16 review 16/28] dm crypt: fix call to clone_init

2007-08-11 Thread Willy Tarreau
Call clone_init early We need to call clone_init as early as possible - at least before call bio_put(clone) in any error path. Otherwise, the destructor will try to dereference bi_private, which may still be NULL. Signed-off-by: Olaf Kirch <[EMAIL PROTECTED]> Signed-off-by: Alasdair G Kergon

[2.6.20.16 review 08/28] x86_64: allocate sparsemem memmap above 4G

2007-08-11 Thread Willy Tarreau
On systems with huge amount of physical memory, VFS cache and memory memmap may eat all available system memory under 4G, then the system may fail to allocate swiotlb bounce buffer. There was a fix for this issue in arch/x86_64/mm/numa.c, but that fix dose not cover sparsemem model. This patch

[2.6.20.16 review 09/28] sparsemem: fix oops in x86_64 show_mem

2007-08-11 Thread Willy Tarreau
We aren't sampling for holes in memory. Thus we encounter a section hole with empty section map pointer for SPARSEMEM and OOPs for show_mem. This issue has been seen in 2.6.21, current git and current mm. This patch is for 2.6.21 stable. It was tested against sparsemem. Previous to commit

[2.6.20.16 review 14/28] md: Fix bug in error handling during raid1 repair.

2007-08-11 Thread Willy Tarreau
If raid1/repair (which reads all block and fixes any differences it finds) hits a read error, it doesn't reset the bio for writing before writing correct data back, so the read error isn't fixed, and the device probably gets a zero-length write which it might complain about. Signed-off-by: Neil

[2.6.20.16 review 13/28] md: Fix two raid10 bugs.

2007-08-11 Thread Willy Tarreau
1/ When resyncing a degraded raid10 which has more than 2 copies of each block, garbage can get synced on top of good data. 2/ We round the wrong way in part of the device size calculation, which can cause confusion. Signed-off-by: Neil Brown <[EMAIL PROTECTED]> Signed-off-by: Chris Wright

[2.6.20.16 review 02/28] md: Avoid overflow in raid0 calculation with large components.

2007-08-11 Thread Willy Tarreau
If a raid0 has a component device larger than 4TB, and is accessed on a 32bit machines, then as 'chunk' is unsigned lock, chunk << chunksize_bits can overflow (this can be as high as the size of the device in KB). chunk itself will not overflow (without triggering a BUG). So change 'chunk' to

[2.6.20.16 review 01/28] i386: Fix K8/core2 oprofile on multiple CPUs

2007-08-11 Thread Willy Tarreau
Only try to allocate MSRs once instead of for every CPU. This assumes the MSRs are the same on all CPUs which is currently true. P4-HT is a special case for different SMT threads, but the code always saves/restores all MSRs so it works identical. Signed-off-by: Andi Kleen <[EMAIL PROTECTED]>

[2.6.20.16 review 05/28] Char: cyclades, fix deadlock

2007-08-11 Thread Willy Tarreau
An omitted unlock. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- drivers/char/cyclades.c |1 + 1 files changed, 1 insertions(+), 0

[2.6.20.16 review 00/28] 2.6.20.16 -stable review

2007-08-11 Thread Willy Tarreau
I proposed Chris and Greg to continue issuing a few more 2.6.20 releases during the time needed for 2.6.21 and 2.6.22 to show a significant drop in their patch rates, which hopefully will be just a matter of a few releases. My goal is *not* to do all the hard work they do, but just to backport

[2.6.20.16 review 03/28] md: Dont write more than is required of the last page of a bitmap

2007-08-11 Thread Willy Tarreau
It is possible that real data or metadata follows the bitmap without full page alignment. So limit the last write to be only the required number of bytes, rounded up to the hard sector size of the device. Signed-off-by: Neil Brown <[EMAIL PROTECTED]> Signed-off-by: Chris Wright <[EMAIL

Re: 2.6.22-rc: regression: no irda0 interface (2.6.21 was OK), smsc does not find chip

2007-08-11 Thread Andrey Borzenkov
On Saturday 30 June 2007, Bjorn Helgaas wrote: > On Saturday 30 June 2007 01:16:18 am Andrey Borzenkov wrote: > > > This patch fixes the 2.6.22 regression: > > > "no irda0 interface (2.6.21 was OK), smsc does not find chip" > > > > does not work, sorry. > > Sigh ;-) Thanks for your patience

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Cyrill Gorcunov
[Balbir Singh - Sat, Aug 11, 2007 at 11:31:09PM +0530] | Andrew Morton wrote: | > On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote: | > | >> On 8/11/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: | > | > hm, both people who replied to this removed Fengguang from cc.

Re: 2.6.23-rc2-mm1: rcutorture xtime usage

2007-08-11 Thread Ingo Molnar
* Paul E. McKenney <[EMAIL PROTECTED]> wrote: > Add an EXPORT_SYMBOL_GPL() for cpu_clock() and make rcutorture.c use it. > Compiles, but not yet tested. > > Signed-off-by: Paul E. McKenney <[EMAIL PROTECTED]> > --- linux-2.6.23-rc2/kernel/sched.c 2007-08-03 19:49:55.0 -0700 > +++

Re: [PATCH 3/3] ACPI: thinkpad-acpi: change thinkpad-acpi input default and kconfig help

2007-08-11 Thread Michael S. Tsirkin
> Quoting Henrique de Moraes Holschuh <[EMAIL PROTECTED]>: > Subject: [PATCH 3/3] ACPI: thinkpad-acpi: change thinkpad-acpi input default > and kconfig help > > The current kconfig help text was misleading users. Also, the default for > an input-layer-optimized support caused way too many

Re: [BUGFIX] NULL pointer dereference in __vm_enough_memory()

2007-08-11 Thread Balbir Singh
Andrew Morton wrote: > On Sat, 11 Aug 2007 20:00:12 +0530 "Balbir Singh" <[EMAIL PROTECTED]> wrote: > >> On 8/11/07, Fengguang Wu <[EMAIL PROTECTED]> wrote: > > hm, both people who replied to this removed Fengguang from cc. Disagreement > between headers and MUAs, perhaps? > Oops... Not sure

Re: sb-400 audigy prob

2007-08-11 Thread Alistair John Strachan
On Saturday 11 August 2007 17:58:43 Gene Heskett wrote: > Greetings; > > Running 23-rc2 since it came out, I've just discovered I have only the > system beep for sound. From lspci: > 01:08.0 Multimedia audio controller: Creative Labs SB0400 Audigy2 Value > Subsystem: Creative Labs Unknown

  1   2   3   4   >