[2.6 patch] omap1/leds-innovator.c: remove dead code

2007-08-27 Thread Adrian Bunk
This patch removes dead code. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- 327cae41c436186c6c480b0b8d5f125ab26b6b7c diff --git a/arch/arm/mach-omap1/leds-innovator.c b/arch/arm/mach-omap1/leds-innovator.c index a0cd001..e7835d6 100644 --- a/arch/arm/mach-omap1/leds-innovator.c +++

[2.6 patch] ark3116.c: fix check-after-use

2007-08-27 Thread Adrian Bunk
The Coverity checker spotted that we'd have already oops'ed if one of these was NULL. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 14 Aug 2007 --- linux-2.6.23-rc1-mm2/drivers/usb/serial/ark3116.c.old 2007-08-08 15:00:03.0 +0200 +++

[2.6 patch] make kernel/profile.c:time_hook static

2007-08-27 Thread Adrian Bunk
{,un}register_timer_hook() is the API that should be used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 14 Aug 2007 include/linux/profile.h |3 --- kernel/profile.c|2 +- 2 files changed, 1 insertion(+), 4 deletions(-)

[2.6 patch] kernel/sys_ni.c: add dummy sys_ni_syscall() prototype

2007-08-27 Thread Adrian Bunk
kernel/sys_ni.c can't #include due to cond_syscall(), but let's tell gcc to not warn with -Wmissing-prototypes. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 14 Aug 2007 --- a/kernel/sys_ni.c +++ b/kernel/sys_ni.c @@ -4,6 +4,10 @@ #include +/* we

[2.6 patch] bitmap.h: remove dead artefacts

2007-08-27 Thread Adrian Bunk
bitmap_active() no longer exists and BITMAP_ACTIVE is no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- include/linux/raid/bitmap.h |2 -- 1 file changed, 2 deletions(-) f2c10857c60e13e63c67c656713b50b18f2bc1e4 diff --git a/include/linux/raid/bitmap.h

[2.6 patch] n_hdlc.c: fix check-after-use

2007-08-27 Thread Adrian Bunk
The Coverity checker spotted that we'd have already oops'ed if "tty" was NULL. Since "tty" can't be NULL when we reach this line of code this patch removes the NULL check. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 14 Aug 2007 ---

[2.6 patch] video-buf.c: remove dead code

2007-08-27 Thread Adrian Bunk
This patch removes code that was both dead and pointless. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- d72841ad9ded136818ab054613ab2f3e027af67f diff --git a/drivers/media/video/video-buf.c b/drivers/media/video/video-buf.c index f6f31e1..87cf89a 100644 ---

[-mm patch] mousedev.c:mixdev_open_devices() bugfix

2007-08-27 Thread Adrian Bunk
On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc2-mm2: >... > git-input.patch >... > git trees >... This patch fixes an obvious bug in mixdev_open_devices(). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> ---

[2.6 patch] mm/: remove unused exports

2007-08-27 Thread Adrian Bunk
This patch removes the following unused EXPORT_SYMBOL's: - migrate.c: migrate_page - mmap.c: get_unmapped_area - nommu.c: get_unmapped_area Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 14 Aug 2007 - 29 Jul 2007 - 13 Jul 2007 mm/migrate.c |1 -

[2.6 patch] i386 visws: "extern inline" -> "static inline"

2007-08-27 Thread Adrian Bunk
"extern inline" will have different semantics with gcc 4.3. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 14 Aug 2007 include/asm-i386/mach-visws/cobalt.h |8 include/asm-i386/mach-visws/lithium.h |8 2 files changed, 8

[2.6 patch] drivers/pci/: possible cleanups

2007-08-27 Thread Adrian Bunk
This patch contains the following possible cleanups: - make the following needlessly global function static: - pci.c: pci_restore_bars() - #if 0 the following unused global functions: - rom.c: pci_map_rom_copy() - rom.c: pci_remove_rom() - remove the following unused EXPORT_SYMBOL's: -

[2.6 patch] make the dummy touchkit_ps2_detect() static

2007-08-27 Thread Adrian Bunk
The dummy touchkit_ps2_detect() for the CONFIG_MOUSE_PS2_TOUCHKIT=n case shouldn't be a global function. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 14 Aug 2007 --- a/drivers/input/mouse/touchkit_ps2.h +++ b/drivers/input/mouse/touchkit_ps2.h @@ -15,7

[2.6 patch] arm: "extern inline" -> "static inline"

2007-08-27 Thread Adrian Bunk
"extern inline" will have different semantics with gcc 4.3. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 14 Aug 2007 arch/arm/nwfpe/ARM-gcc.h|2 +- arch/arm/nwfpe/fpa11.inl|8

[RFC: 2.6 patch] remove include/asm-*/ipc.h

2007-08-27 Thread Adrian Bunk
All asm/ipc.h files do only #include . This patch therefore removes all include/asm-*/ipc.h files and moves the contents of include/asm-generic/ipc.h to include/linux/ipc.h. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 14 Aug 2007

[2.6 patch] i386: unexport machine_id

2007-08-27 Thread Adrian Bunk
This patch removes the unused EXPORT_SYMBOL(machine_id). Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- This patch has been sent on: - 14 Aug 2007 --- a/arch/i386/kernel/setup.c +++ b/arch/i386/kernel/setup.c @@ -86,9 +86,6 @@ unsigned long mmu_cr4_features; /* for MCA, but anyone else

[2.6 patch] fix SERIAL_CORE_CONSOLE driver dependencies

2007-08-27 Thread Adrian Bunk
SERIAL_BFIN=m or SERIAL_MUX=m shouldn't allow SERIAL_CORE_CONSOLE=y. Additionally, this patch fixes whitespaceinstead of tabs at the SERIAL_MUX_CONSOLE option. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- drivers/serial/Kconfig |8 1 file changed, 4 insertions(+), 4

[-mm patch] unexport noautodma

2007-08-27 Thread Adrian Bunk
On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc2-mm2: >... > +ide-ide-remove-hwif-autodma-and-drive-autodma.patch >... > IDE tree updates >... noautodma can now be unexported. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> ---

[-mm patch] remove unwind exports

2007-08-27 Thread Adrian Bunk
On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc2-mm2: >... > +x86_64-mm-unwinder.patch >... > x86 tree updates >... This patch removes the unused unwind exports. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- kernel/unwind.c |4 1

2.6.23-rc3-mm1: m32r defconfig compile error

2007-08-27 Thread Adrian Bunk
On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc2-mm2: >... > git-m32r.patch >... > git trees >... <-- snip --> ... AS arch/m32r/kernel/entry.o /home/bunk/linux/kernel-2.6/linux-2.6.23-rc3-mm1/arch/m32r/kernel/entry.S: Assembler messages:

[-mm patch] make types.h usable for non-gcc C parsers

2007-08-27 Thread Adrian Bunk
On Wed, Aug 22, 2007 at 03:33:27PM +0200, Gabriel C wrote: >... > WARNING: "div64_64" [net/netfilter/xt_connbytes.ko] has no CRC! >... Patch below. > Regards, > > Gabriel cu Adrian <-- snip --> This patch makes the 64bit integers on 32bit architectures usable for all C parsers that know

[-mm patch] unexport sys_{open,read}

2007-08-27 Thread Adrian Bunk
On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc2-mm2: >... > git-alsa.patch >... > git trees >... sys_{open,read} can finally be unexported. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- fs/open.c |1 - fs/read_write.c |1 - 2

[-mm patch] unexport snd_ctl_elem_{read,write}

2007-08-27 Thread Adrian Bunk
On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc2-mm2: >... > git-alsa.patch >... > git trees >... snd_ctl_elem_{read,write} no longer have any modular users. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- sound/core/control.c |4 1

[-mm patch] make do_restart_poll() static

2007-08-27 Thread Adrian Bunk
On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc2-mm2: >... > +use-erestart_restartblock-if-poll-is-interrupted-by-a-signal.patch >... > The infamous misc >... do_restart_poll() can become static. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> ---

[-mm patch] remove parport_device_num()

2007-08-27 Thread Adrian Bunk
On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc2-mm2: >... > +sysctl-parport-remove-binary-paths.patch >... > More sysctl work >... parport_device_num() is no longer used. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> ---

[-mm patch] make "struct menu_governor" static (again)

2007-08-27 Thread Adrian Bunk
On Wed, Aug 22, 2007 at 02:06:48AM -0700, Andrew Morton wrote: >... > Changes since 2.6.23-rc2-mm2: >... > git-acpi.patch >... > git trees >... "struct menu_governor" needlessly again became global. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- cb33b296204127cf50df54b84b2d79e152fb924b

Re: [PATCH] SLUB use cmpxchg_local

2007-08-27 Thread Christoph Lameter
On Mon, 27 Aug 2007, Mathieu Desnoyers wrote: > > a clean solution source code wise. It also minimizes the interrupt holdoff > > for the non-cmpxchg_local arches. However, it means that we will have to > > disable interrupts twice for the slow path. If that is too expensive then > > we need a

Re: [parisc-linux] [patch 15/23] Add cmpxchg_local to parisc

2007-08-27 Thread David Miller
From: Grant Grundler <[EMAIL PROTECTED]> Date: Mon, 27 Aug 2007 15:04:32 -0600 > Doesn't explain the difference between "local" and "non-local" either. > Per CPU data should only need memory barriers (in some cases) and > protection against interrupts (in probably more cases). So I'm not >

[PATCH] v1 of IBM power meter driver

2007-08-27 Thread Darrick J. Wong
Hi everyone, Attached is a driver to export sensor readings from power meters that are found in several IBM x86 systems. At the moment, the hwmon sysfs documentation doesn't mention any naming conventions for sensors that measure Watts, so I am proposing that they be called "powerX_input" in a

Re: [PATCH] SLUB use cmpxchg_local

2007-08-27 Thread Mathieu Desnoyers
* Christoph Lameter ([EMAIL PROTECTED]) wrote: > I think the simplest solution may be to leave slub as done in the patch > that we developed last week. The arch must provide a cmpxchg_local that is > performance wise the fastest possible. On x86 this is going to be the > cmpxchg_local on others

[PATCH 23/23] via_map.c: drm_calloc to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/via_map.c | 3449 -> 3439 (-10 bytes) drivers/char/drm/via_map.o | 110028 -> 110488 (+460 bytes) drivers/char/drm/via_map.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---

[PATCH 22/23] sis_drv.c: drm_calloc to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/sis_drv.c | 3249 -> 3239 (-10 bytes) drivers/char/drm/sis_drv.o | 104756 -> 105460 (+704 bytes) drivers/char/drm/sis_drv.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---

[PATCH 20/23] radeon_mem.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/radeon_mem.c | 7711 -> 7677 (-34 bytes) drivers/char/drm/radeon_mem.o | 115484 -> 115396 (-88 bytes) drivers/char/drm/radeon_mem.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ---

[PATCH 18/23] r128_cce.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/r128_cce.c | 25912 -> 25792 (-120 bytes) drivers/char/drm/r128_cce.o | 133640 -> 133468 (-172 bytes) drivers/char/drm/r128_cce.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) ---

[PATCH 21/23] savage_bci.c: drm_alloc + memset to drm_zalloc and cleanup

2007-08-27 Thread m . kozlowski
The initialization in for loop can be removed as the SET_AGE macro set the age struct and other members to zero. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/savage_bci.c | 31888 -> 31634 (-254 bytes) drivers/char/drm/savage_bci.o | 138936 -> 138984 (+48 bytes)

[PATCH 19/23] radeon_cp.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/radeon_cp.c | 62519 -> 62461 (-58 bytes) drivers/char/drm/radeon_cp.o | 160564 -> 160596 (+32 bytes) drivers/char/drm/radeon_cp.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ---

[PATCH 16/23] i915_mem.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/i915_mem.c | 9842 -> 9808 (-34 bytes) drivers/char/drm/i915_mem.o | 114556 -> 114464 (-92 bytes) drivers/char/drm/i915_mem.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ---

[PATCH 15/23] i915_irq.c: drm_calloc to drm_zalloc and bugfix

2007-08-27 Thread m . kozlowski
This patch does drm_calloc to drm_zalloc conversion. Also it seems that unpatched version allocated wrong nr of bytes. drm_i915_vbl_swap_t *vbl_swap; ... sizeof(vbl_swap) vs. sizeof(*vbl_swap) No? Please review. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]>

[PATCH 14/23] i915_dma.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/i915_dma.c | 22680 -> 22623 (-57 bytes) drivers/char/drm/i915_dma.o | 134192 -> 133704 (-488 bytes) drivers/char/drm/i915_dma.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) ---

[PATCH 17/23] mga_dma.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/mga_dma.c | 30418 -> 30253 (-165 bytes) drivers/char/drm/mga_dma.o | 140668 -> 140304 (-364 bytes) drivers/char/drm/mga_dma.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) ---

[PATCH 11/23] drm_stub.c: drm_calloc to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drm_stub.c | 7731 -> 7728 (-3 bytes) drivers/char/drm/drm_stub.o | 110301 -> 111354 (+1053 bytes) drivers/char/drm/drm_stub.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

[PATCH 12/23] i810_dma.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/i810_dma.c | 37542 -> 37480 (-62 bytes) drivers/char/drm/i810_dma.o | 150664 -> 149996 (-668 bytes) drivers/char/drm/i810_dma.c |9 - 1 file changed, 4 insertions(+), 5 deletions(-) ---

[PATCH 13/23] i830_dma.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/i830_dma.c | 41269 -> 41212 (-57 bytes) drivers/char/drm/i830_dma.o | 157920 -> 157480 (-440 bytes) drivers/char/drm/i830_dma.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) ---

[PATCH 10/23] drm_sman.c: drm_calloc to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drm_sman.c | 9108 -> 9094 (-14 bytes) drivers/char/drm/drm_sman.o | 104466 -> 103946 (-520 bytes) drivers/char/drm/drm_sman.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) ---

[PATCH 09/23] drm_scatter.c: drm_alloc + memset to drm_alloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drm_scatter.c | 6113 -> 5945 (-168 bytes) drivers/char/drm/drm_scatter.o | 105552 -> 105584 (+32 bytes) drivers/char/drm/drm_scatter.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) ---

[PATCH 07/23] drm_fops.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drm_fops.c | 11849 -> 11817 (-32 bytes) drivers/char/drm/drm_fops.o | 115963 -> 115177 (-786 bytes) drivers/char/drm/drm_fops.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) ---

[PATCH 08/23] drm_irq.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drm_irq.c | 13062 -> 13003 (-59 bytes) drivers/char/drm/drm_irq.o | 114446 -> 114298 (-148 bytes) drivers/char/drm/drm_irq.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) ---

[PATCH 05/23] drm_dma.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
This patch does the conversion of drm_alloc + memset to drm_zalloc. The memset in loop is also superfluous and can be removed. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drm_dma.c | 4624 -> 4475 (-149 bytes) drivers/char/drm/drm_dma.o | 104277 -> 103917 (-360 bytes)

[PATCH 06/23] drm_drawable.c: drm_calloc to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drm_drawable.c | 5425 -> 5422 (-3 bytes) drivers/char/drm/drm_drawable.o | 108201 -> 107765 (-436 bytes) drivers/char/drm/drm_drawable.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

[PATCH 03/23] drm_auth.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drm_auth.c | 5835 -> 5802 (-33 bytes) drivers/char/drm/drm_auth.o | 104968 -> 104860 (-108 bytes) drivers/char/drm/drm_auth.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) ---

[PATCH 04/23] drm_bufs.c: drm_alloc + memset to drm_alloc

2007-08-27 Thread m . kozlowski
This patch does dma_alloc and memset conversion to drm_zalloc or drm_calloc. Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drm_bufs.c | 44959 -> 44420 (-539 bytes) drivers/char/drm/drm_bufs.o | 149686 -> 146822 (-2864 bytes) drivers/char/drm/drm_bufs.c | 31

[PATCH 01/23] introduce drm_zalloc as a drm_alloc + memset replacement

2007-08-27 Thread m . kozlowski
Add drm_zalloc(). Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drmP.h |7 +++ drivers/char/drm/drm_memory_debug.h | 17 ++--- 2 files changed, 21 insertions(+), 3 deletions(-) --- linux-2.6.23-rc3-mm1.orig/drivers/char/drm/drmP.h +++

[PATCH 02/23] drm_agpsupport.c: drm_alloc + memset to drm_zalloc

2007-08-27 Thread m . kozlowski
Signed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> drivers/char/drm/drm_agpsupport.c | 13896 -> 13828 (-68 bytes) drivers/char/drm/drm_agpsupport.o | 120046 -> 119814 (-232 bytes) drivers/char/drm/drm_agpsupport.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) ---

[PATCH 00/23] drm: introduce drm_zalloc

2007-08-27 Thread m . kozlowski
Hello, As there are many places in drm code where drm_alloc + memset is used this patch series introduces drm_zalloc and also makes use of drm_calloc where needed. Most of these patches save some bytes so the benefit is a few kB saved (gcc 4.1.2) with patch applied. Also some small

Re: [parisc-linux] [patch 15/23] Add cmpxchg_local to parisc

2007-08-27 Thread Mathieu Desnoyers
* Grant Grundler ([EMAIL PROTECTED]) wrote: > On Sun, Aug 12, 2007 at 10:54:49AM -0400, Mathieu Desnoyers wrote: > > Use the new generic cmpxchg_local (disables interrupt). Also use the generic > > cmpxchg as fallback if SMP is not set. > > Mathieu, > thanks for adding __cmpxchg_local to

Re: [PATCH] fix bogus hotplug cpu warning

2007-08-27 Thread Hugh Dickins
On Mon, 27 Aug 2007, Andrew Morton wrote: > On Mon, 27 Aug 2007 21:37:14 +0100 (BST) > Hugh Dickins <[EMAIL PROTECTED]> wrote: > > > > So I agree with the patch, but not with its description. > > > > I don't see which part of the description you disagree with, but please > > do improve it if you

Re: [parisc-linux] [patch 15/23] Add cmpxchg_local to parisc

2007-08-27 Thread Grant Grundler
On Sun, Aug 12, 2007 at 10:54:49AM -0400, Mathieu Desnoyers wrote: > Use the new generic cmpxchg_local (disables interrupt). Also use the generic > cmpxchg as fallback if SMP is not set. Mathieu, thanks for adding __cmpxchg_local to parisc but why do we need it? By definition, atomic

Re: [PATCH] SLUB use cmpxchg_local

2007-08-27 Thread Christoph Lameter
I think the simplest solution may be to leave slub as done in the patch that we developed last week. The arch must provide a cmpxchg_local that is performance wise the fastest possible. On x86 this is going to be the cmpxchg_local on others where cmpxchg is slower than interrupt disable/enable

Re: RFC: issues concerning the next NAPI interface

2007-08-27 Thread David Miller
From: James Chapman <[EMAIL PROTECTED]> Date: Mon, 27 Aug 2007 16:51:29 +0100 > To implement this, there's no need for timers, hrtimers or generic NAPI > support that others have suggested. A driver's poll() would set an > internal flag and record the current jiffies value when finding >

Re: [PATCH] trivial - constify sched.h

2007-08-27 Thread Jiri Slaby
Joe Perches napsal(a): > Add const to some struct task_struct * uses Does this have any impact on generated code? What (some objdumps or something)? Or more descriptive log, why is this about to be done, please. > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > --- > >

Re: [PATCH] fix maxcpus=N parsing

2007-08-27 Thread Hugh Dickins
On Mon, 27 Aug 2007, Linus Torvalds wrote: > On Mon, 27 Aug 2007, Hugh Dickins wrote: > > > > Fix 61ec7567db103d537329b0db9a887db570431ff4: maxcpus=N is now having no > > ... > > On a totally unrelated issue: > > While looking at the history in gitk and gitweb etc shows these commit > ID's as

Re: [PATCH] fix bogus hotplug cpu warning

2007-08-27 Thread Andrew Morton
On Mon, 27 Aug 2007 21:37:14 +0100 (BST) Hugh Dickins <[EMAIL PROTECTED]> wrote: > > So I agree with the patch, but not with its description. > > I don't see which part of the description you disagree with, but please > do improve it if you can. I'd change the description to

Re: CONFIG_HOTPLUG_CPU: kconfig bug?

2007-08-27 Thread Hugh Dickins
On Mon, 27 Aug 2007, Sam Ravnborg wrote: > On Mon, Aug 27, 2007 at 03:54:49PM +0100, Hugh Dickins wrote: > > Hi Roman, > > > > I've noticed an oddity with CONFIG_HOTPLUG_CPU in 2.6.23-rc: > > make oldconfig seems to turn it on even when nothing wants it, > > increasing kernel size by about 10k;

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Al Viro
On Mon, Aug 27, 2007 at 03:24:20PM -0500, Robin Holt wrote: > On Mon, Aug 27, 2007 at 08:35:10PM +0100, Al Viro wrote: > > On Mon, Aug 27, 2007 at 02:19:06PM -0500, Dean Nelson wrote: > > > > > No operations can be done once it's closed, only while it's opened. > > > > What the hell do you mean,

Re: CFS review

2007-08-27 Thread Ingo Molnar
* Al Boldi <[EMAIL PROTECTED]> wrote: > > Could you try the patch below instead, does this make 3x glxgears > > smooth again? (if yes, could you send me your Signed-off-by line as > > well.) > > The task-startup stalling is still there for ~10sec. > > Can you see the problem on your machine?

[PATCH] trivial - constify sched.h

2007-08-27 Thread Joe Perches
Add const to some struct task_struct * uses Signed-off-by: Joe Perches <[EMAIL PROTECTED]> --- include/linux/sched.h | 24 1 files changed, 12 insertions(+), 12 deletions(-) diff --git a/include/linux/sched.h b/include/linux/sched.h index ba78807..71d40a1 100644 ---

Re: RFC: issues concerning the next NAPI interface

2007-08-27 Thread David Miller
From: Jan-Bernd Themann <[EMAIL PROTECTED]> Date: Mon, 27 Aug 2007 11:47:01 +0200 > So the question is simply: Do we want drivers that need (benefit > from) a timer based polling support to implement their own timers > each, or should there be a generic support? I'm trying to figure out how an

Re: [PATCH] SLUB use cmpxchg_local

2007-08-27 Thread Mathieu Desnoyers
* Christoph Lameter ([EMAIL PROTECTED]) wrote: > On Mon, 27 Aug 2007, Mathieu Desnoyers wrote: > > > * Christoph Lameter ([EMAIL PROTECTED]) wrote: > > > On Mon, 27 Aug 2007, Peter Zijlstra wrote: > > > > > > > So, if the fast path can be done with a preempt off, it might be doable > > > > to

Re: [PATCH] fix bogus hotplug cpu warning

2007-08-27 Thread Hugh Dickins
On Mon, 27 Aug 2007, Andrew Morton wrote: > On Mon, 27 Aug 2007 16:06:19 +0100 (BST) > Hugh Dickins <[EMAIL PROTECTED]> wrote: > > > Fix bogus DEBUG_PREEMPT warning on x86_64, when cpu brought online after > > bootup: current_is_keventd is right to note its use of smp_processor_id > > is

Re: "double" hpet clocksource && hard freeze [bisected]

2007-08-27 Thread Luiz Fernando N. Capitulino
Em Fri, 24 Aug 2007 11:17:34 -0700 john stultz <[EMAIL PROTECTED]> escreveu: | On Fri, 2007-08-24 at 08:46 -0400, Bob Picco wrote: | > john stultz wrote: [Thu Aug 23 2007, 05:41:45PM EDT] | > > On Thu, 2007-08-23 at 14:05 -0700, john stultz wrote: | > > > On Thu, 2007-08-23 at 13:41 -0700, Luck,

Re: [PATCH] SLUB use cmpxchg_local

2007-08-27 Thread Christoph Lameter
On Mon, 27 Aug 2007, Mathieu Desnoyers wrote: > * Christoph Lameter ([EMAIL PROTECTED]) wrote: > > On Mon, 27 Aug 2007, Peter Zijlstra wrote: > > > > > So, if the fast path can be done with a preempt off, it might be doable > > > to suffer the slow path with a per cpu lock like that. > > > >

Re: [PATCH 1/4] export __put_task_struct for XPMEM

2007-08-27 Thread Robin Holt
On Mon, Aug 27, 2007 at 08:35:10PM +0100, Al Viro wrote: > On Mon, Aug 27, 2007 at 02:19:06PM -0500, Dean Nelson wrote: > > > No operations can be done once it's closed, only while it's opened. > > What the hell do you mean, can't be done? > > fd = open(...); > fp =

Re: [PATCH] SLUB: use have_arch_cmpxchg()

2007-08-27 Thread Mathieu Desnoyers
* Christoph Lameter ([EMAIL PROTECTED]) wrote: > On Mon, 27 Aug 2007, Mathieu Desnoyers wrote: > > > Hrm, actually, I don't think such have_arch_cmpxchg() macro will be > > required at all because of the small performance hit disabling > > preemption will have on the slow and fast paths. Let's

[PATCH 13/15] knfsd: remove code duplication in nfsd4_setclientid()

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> Each branch of this if-then-else has a bunch of duplicated code that we could just put at the end. Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]> --- fs/nfsd/nfs4state.c | 30 ++ 1 files changed, 6 insertions(+), 24

[PATCH 11/15] knfsd: fix callback rpc cred

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> It doesn't make sense to make the callback with credentials that the client made the setclientid with. Instead the spec requires that the callback occur with the credentials the client authenticated *to*. It probably doesn't matter what we use for

[PATCH 03/15] nfsd: fix horrible indentation in nfsd_setattr

2007-08-27 Thread J. Bruce Fields
From: Christoph Hellwig <[EMAIL PROTECTED]> Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> --- fs/nfsd/vfs.c | 43 ++- 1 files changed, 26 insertions(+), 17 deletions(-) diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c index a0c2b25..11ae949 100644 ---

[PATCH 10/15] knfsd: Validate filehandle type in fsid_source

2007-08-27 Thread J. Bruce Fields
From: Neil Brown <[EMAIL PROTECTED]> fsid_source decided where to get the 'fsid' number to return for a GETATTR based on the type of filehandle. It can be from the device, from the fsid, or from the UUID. It is possible for the filehandle to be inconsistent with the export information, so make

[PATCH 15/15] knfsd: 64 bit ino support for NFS server

2007-08-27 Thread J. Bruce Fields
From: Peter Staubach <[EMAIL PROTECTED]> Modify the NFS server code to support 64 bit ino's, as appropriate for the system and the NFS protocol version. The gist of the changes is to query the underlying file system for attributes and not just to use the cached attributes in the inode. For this

[PATCH 08/15] knfsd: spawn kernel thread to probe callback channel

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> We want to allow gss on the callback channel, so people using krb5 can still get the benefits of delegations. But looking up the rpc credential can take some time in that case. And we shouldn't delay the response to setclientid_confirm while we wait.

[PATCH 12/15] nfsd warning fix

2007-08-27 Thread J. Bruce Fields
From: Andrew Morton <[EMAIL PROTECTED]> fs/nfsd/nfsctl.c: In function 'write_filehandle': fs/nfsd/nfsctl.c:301: warning: 'maxsize' may be used uninitialized in this function Cc: Neil Brown <[EMAIL PROTECTED]> Signed-off-by: Andrew Morton <[EMAIL PROTECTED]> Signed-off-by: "J. Bruce Fields"

[PATCH 14/15] svcgss: move init code into separate function

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> We've let svcauth_gss_accept() get much too long and hairy. The RPC_GSS_PROC_INIT and RPC_GSS_PROC_CONTINUE_INIT cases share very little with the other cases, so it's very natural to split them off into a separate function. This will also nicely isolate

nfs server patches for review

2007-08-27 Thread J. Bruce Fields
These are some nfs server patches I intend to submit for 2.6.24. I'm also keeping this sort of thing in the nfs-server-stable branch, at git://linux-nfs.org/~bfields/linux.git nfs-server-stable That repository has a bunch of random other (mainly nfs-related) projects, but that

[PATCH 09/15] knfsd: move nfsv4 slab creation/destruction to module init/exit

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> We have some slabs that the nfs4 server uses to store state objects. We're currently creating and destroying those slabs whenever the server is brought up or down. That seems excessive; may as well just do that in module initialization and exit. Also

[PATCH 05/15] knfsd: cleanup of nfsd4 cmp_* functions

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> Benny Halevy suggested renaming cmp_* to same_* to make the meaning of the return value clearer. Fix some nearby style deviations while we're at it, including a small swath of creative indentation in nfs4_preprocess_seqid_op(). Signed-off-by: "J. Bruce

[PATCH 06/15] knfsd: demote some printk()s to dprintk()s

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> To quote a recent mail from Andrew Morton: Look: if there's a way in which an unprivileged user can trigger a printk we fix it, end of story. OK. I assume that goes double for printk()s that might be triggered by random hosts on the

[PATCH 02/15] nfsd: remove unused cache_for_each macro

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> This macro is unused. Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]> --- include/linux/sunrpc/cache.h | 10 -- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/include/linux/sunrpc/cache.h b/include/linux/sunrpc/cache.h

[PATCH 07/15] knfsd: nfs4 name->id mapping not correctly parsing negative downcall

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> Note that qword_get() returns length or -1, not an -ERROR. Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]> --- fs/nfsd/nfs4idmap.c |8 +--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/nfsd/nfs4idmap.c

[PATCH 04/15] knfsd: delete code made redundant by map_new_errors

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> I moved this check into map_new_errors, but forgot to delete the original. Oops. Signed-off-by: "J. Bruce Fields" <[EMAIL PROTECTED]> --- fs/nfsd/nfssvc.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/fs/nfsd/nfssvc.c

[PATCH 01/15] nfsd: tone down inaccurate dprintk

2007-08-27 Thread J. Bruce Fields
From: J. Bruce Fields <[EMAIL PROTECTED]> The nfserr_dropit happens routinely on upcalls (so a kmalloc failure is almost never the actual cause), but I occasionally get a complant from some tester that's worried because they ran across this message after turning on debugging to research some

[PATCH 1/1] hotplug cpu: documentation addition to downing a cpu

2007-08-27 Thread Cliff Wickman
In answer to Andrew: > How do we communicate this new design/feature to our users? > Documentation/cpusets.txt, perhaps? Documentation/cpu-hotplug.txt? > git-log? ;) Patch "[PATCH 1/1] V4: hotplug cpu: migrate a task within its cpuset" may warrant an addition to the documentation. I would

Re: [PATCH] SLUB use cmpxchg_local

2007-08-27 Thread Mathieu Desnoyers
* Christoph Lameter ([EMAIL PROTECTED]) wrote: > On Mon, 27 Aug 2007, Peter Zijlstra wrote: > > > So, if the fast path can be done with a preempt off, it might be doable > > to suffer the slow path with a per cpu lock like that. > > Sadly the cmpxchg_local requires local per cpu data access.

Re: [patch 00/28] Add cmpxchg64_local and cmpxchg_local to each architecture

2007-08-27 Thread Mathieu Desnoyers
* Christoph Lameter ([EMAIL PROTECTED]) wrote: > On Mon, 27 Aug 2007, Mathieu Desnoyers wrote: > > > Here is the patch series for 2.6.23-rc3-mm1 that adds cmpxchg_local, and now > > also cmpxchg64_local, to each architecture. > > Any planned uses of cmpxchg64_local? Let's say it could possibly

Re: nfs4 filesystem mounted via the "bind" option reports wrong fstype

2007-08-27 Thread Gabriel Barazer
On 08/27/2007 9:32:42 PM +0200, "J. Bruce Fields" <[EMAIL PROTECTED]> wrote: On Mon, Aug 27, 2007 at 08:15:07PM +0100, Al Viro wrote: On Mon, Aug 27, 2007 at 02:40:59PM -0400, J. Bruce Fields wrote: There's no reason not to just mount server:/exports/data directly at /home/data; the bind

Re: uncached page allocator

2007-08-27 Thread Christoph Lameter
There is an uncached allocator in IA64 arch code (linux/arch/ia64/kernel/uncached.c). Maybe having a look at that will help? Jes wrote it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 4/4] add SGI Altix cross partition memory (XPMEM) driver

2007-08-27 Thread Adrian Bunk
On Mon, Aug 27, 2007 at 11:41:12AM -0500, Dean Nelson wrote: > This patch has been bzip2'd and included as an attachment due to size. 200 kB shouldn't be a problem (AFAIR the current limit on linux-kernel is 400 kB). cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly

Re: [PATCH 1/1] cciss: fix error reporting for SG_IO

2007-08-27 Thread Mike Miller (OS Dev)
On Fri, Aug 24, 2007 at 05:10:47PM -0700, Andrew Morton wrote: > On Fri, 24 Aug 2007 12:53:54 -0500 > "Mike Miller (OS Dev)" <[EMAIL PROTECTED]> wrote: > > > This fixes a problem with the way cciss was filling out the "errors" > > field of the request structure upon completion of requests. > >

Re: [PATCH 1/6] x86: fix cpu_to_node references (v2)

2007-08-27 Thread Mike Travis
On Fri, 24 Aug 2007, Siddha, Suresh B wrote: > On Fri, Aug 24, 2007 at 03:26:55PM -0700, [EMAIL PROTECTED] wrote: > > Fix four instances where cpu_to_node is referenced > > by array instead of via the cpu_to_node macro. This > > is preparation to moving it to the per_cpu data area. > > > ... >

Re: [PATCH] SLUB: use have_arch_cmpxchg()

2007-08-27 Thread Christoph Lameter
On Mon, 27 Aug 2007, Mathieu Desnoyers wrote: > Hrm, actually, I don't think such have_arch_cmpxchg() macro will be > required at all because of the small performance hit disabling > preemption will have on the slow and fast paths. Let's compare, for each > of the slow path and fast path, what

[PATCH 1/3] Refactor hypercall infrastructure (v2)

2007-08-27 Thread Anthony Liguori
This patch refactors the current hypercall infrastructure to better support live migration and SMP. It eliminates the hypercall page by trapping the UD exception that would occur if you used the wrong hypercall instruction for the underlying architecture and replacing it with the right one

[PATCH 2/3] KVM paravirt-ops implementation (v2)

2007-08-27 Thread Anthony Liguori
A very simple paravirt_ops implementation for KVM. Future patches will add more sophisticated optimizations. The goal of having this presenting this now is to validate the new hypercall infrastructure and to make my patch queue smaller. Signed-off-by: Anthony Liguori <[EMAIL PROTECTED]> diff

[PATCH 0/3] KVM paravirtualization framework (v2)

2007-08-27 Thread Anthony Liguori
This patchset refactors KVM's paravirtualization support to better support guest SMP and cross platform migration. It also introduces a bare-bones KVM paravirt_ops implementation. I've tested this on VT and it works nicely. I'm having trouble getting a bzImage to boot on SVM so I haven't been

<    1   2   3   4   5   6   7   8   9   10   >