Re: [PATCH] fs/ocfs2/: removed unneeded initial value and function's return value

2007-09-26 Thread Mark Fasheh
On Thu, Sep 27, 2007 at 02:10:04AM +0800, Denis Cheng wrote: > Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> Committed, thanks. --Mark -- Mark Fasheh Senior Software Developer, Oracle [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 1/4] Avoid taking waitqueue lock in dmapool

2007-09-26 Thread David Miller
From: Matthew Wilcox <[EMAIL PROTECTED]> Date: Wed, 26 Sep 2007 15:01:16 -0400 > With one trivial change (taking the lock slightly earlier on wakeup > from schedule), all uses of the waitq are under the pool lock, so we > can use the locked (or __) versions of the wait queue functions, and >

Re: [PATCH 01/24] CRED: Introduce a COW credentials record

2007-09-26 Thread David Howells
Al Viro <[EMAIL PROTECTED]> wrote: > Umm... Perhaps a better primitive would be "make sure that our cred is > not shared with anybody, creating a copy and redirecting reference to > it if needed". I wanted to make the point that once a cred record was made live - i.e. exposed to the rest of the

Re: [PATCH 2/4] dmapool: Validate parameters to dma_pool_create

2007-09-26 Thread roel
Matthew Wilcox wrote: > On Wed, Sep 26, 2007 at 09:47:41PM +0200, roel wrote: >> The brackets in the first if/else are not required, and you could combine >> the two statements: > > You mean braces, not brackets. And I find this little fetish of yours > highly disturbing. I prefer to use

Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc

2007-09-26 Thread Mingming Cao
On Wed, 2007-09-26 at 12:54 -0700, Andrew Morton wrote: > On Fri, 21 Sep 2007 16:13:56 -0700 > Mingming Cao <[EMAIL PROTECTED]> wrote: > > > Convert kmalloc to kzalloc() and get rid of the memset(). > > I split this into separate ext3/jbd and ext4/jbd2 patches. It's generally > better to raise

Re: why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-26 Thread Stephen Hemminger
On Wed, 26 Sep 2007 23:06:53 +0200 Oleg Verych <[EMAIL PROTECTED]> wrote: > * Wed, 26 Sep 2007 08:37:05 -0700 > * Organization: Linux Foundation > > > > On Wed, 26 Sep 2007 08:53:27 +0100 > > "Jan Beulich" <[EMAIL PROTECTED]> wrote: > > > >> Otherwise 'modprobe -r' on a module having a dependency

State of the Linux PCI Subsystem for 2.6.23-rc8

2007-09-26 Thread Greg KH
Here's a summary of the current state of the Linux PCI subsystem, as of 2.6.23-rc8. If the information in here is incorrect, or anyone knows of any outstanding issues not listed here, please let me know. List of outstanding regressions from 2.6.22: - none known. List of outstanding

Re: [patch 1/7] Extended crashkernel command line

2007-09-26 Thread Bernhard Walle
* Oleg Verych <[EMAIL PROTECTED]> [2007-09-26 20:18]: > > > > --- a/kernel/kexec.c > > +++ b/kernel/kexec.c > > @@ -1172,33 +1172,50 @@ static int __init parse_crashkernel_mem( > > do { > > unsigned long long start = 0, end = ULLONG_MAX; > > unsigned long long size =

State of the Linux USB Subsystem for 2.6.23-rc8

2007-09-26 Thread Greg KH
Here's a summary of the current state of the Linux USB subsystem, as of 2.6.23-rc8 If the information in here is incorrect, or anyone knows of any outstanding issues not listed here, please let me know. List of outstanding regressions from 2.6.22: - none known. List of outstanding

State of the Linux Driver Core Subsystem for 2.6.23-rc8

2007-09-26 Thread Greg KH
Here's a summary of the current state of the Linux Driver core subsystem, as of 2.6.23-rc8. If the information in here is incorrect, or anyone knows of any outstanding issues not listed here, please let me know. List of outstanding regressions from 2.6.22: - none known. List of

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread H. Peter Anvin
Jordan Crouse wrote: > On 26/09/07 12:14 -0700, H. Peter Anvin wrote: >> Please try the following debug patch to let us know what is going on. >> >> -hpa > >> diff --git a/arch/i386/boot/memory.c b/arch/i386/boot/memory.c >> index 1a2e62d..a0ccf29 100644 >> --- a/arch/i386/boot/memory.c >>

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 12:12:50 -0700 Brett Warden wrote: > Appeases the warning "parport0 (bw-qcam): use data_reverse for this!" > > Signed-off-by: Brett T. Warden <[EMAIL PROTECTED]> > Where does the warning come from? (what software produces it?) > --- > > It seems to work fine with my

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Ray Lee
On 9/26/07, Brett Warden <[EMAIL PROTECTED]> wrote: > On 9/26/07, Ray Lee <[EMAIL PROTECTED]> wrote: > > > Just as an aside, if you've tested this and it works, then there's no > > point to keep the write_lpcontrol even as a comment. Kill those four > > lines, and if someone's interested in what

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread Jordan Crouse
On 26/09/07 12:14 -0700, H. Peter Anvin wrote: > Please try the following debug patch to let us know what is going on. > > -hpa > diff --git a/arch/i386/boot/memory.c b/arch/i386/boot/memory.c > index 1a2e62d..a0ccf29 100644 > --- a/arch/i386/boot/memory.c > +++ b/arch/i386/boot/memory.c >

2.6.23-rc8-rt1

2007-09-26 Thread Steven Rostedt
We are pleased to announce the 2.6.23-rc8-rt1 tree, which can be downloaded from the new location: http://www.kernel.org/pub/linux/kernel/projects/rt/ Changes since 2.6.23-rc4-rt1 - update to -rc8 - A bunch of PowerPC stuff(Tony Breeds) - rearrange thread flags

Re: [PATCH 7/8] taskstats: fix stats->ac_exitcode to work on threads and use group_exit_code

2007-09-26 Thread Guillaume Chazarain
Le Wed, 26 Sep 2007 22:47:54 +0200, roel <[EMAIL PROTECTED]> a écrit : > > + if (thread_group_leader(tsk) && ((tsk->flags & PF_FORKNOEXEC))) > > if (thread_group_leader(tsk) && (tsk->flags & PF_FORKNOEXEC)) Yeah, right, good catch. > > + group_exit_code = tg_stats ?

Re: No linux/module.h

2007-09-26 Thread Jiri Slaby
On 09/26/2007 10:25 PM, Kristof Provost wrote: > On 2007-09-26 11:29:33 (+0100), mahamuni ashish <[EMAIL PROTECTED]> wrote: >> I am writing simple kernel module. >> I have included linux/module.h >> compiler gives me error that no such file, I also >> searched it on my machine. >> It really

Re: [PATCH 1/1] Kernel compile bug in 2.6.22.6/7 {maybe more} ARM/StrongARM

2007-09-26 Thread Dave Jones
On Tue, Sep 25, 2007 at 10:36:51AM -0400, Dave Jones wrote: > On Tue, Sep 25, 2007 at 08:31:32AM +0100, Russell King wrote: > > On Mon, Sep 24, 2007 at 05:53:57PM -0500, [EMAIL PROTECTED] wrote: > > > I was building a kernel for an iPaq {SA1110} and ran into this. > > > > > >

Re: [RFC][PATCH 1/2 -mm] kexec based hibernation -v3: kexec jump

2007-09-26 Thread Nigel Cunningham
Hi. On Thursday 27 September 2007 06:30:36 Joseph Fannin wrote: > On Fri, Sep 21, 2007 at 11:45:12AM +0200, Pavel Machek wrote: > > Hi! > > > > > > > > Sounds doable, as long as you can cope with long command lines (which > > > > shouldn't be a biggie). (If you've got a swapfile or parts of a

Re: [Re: NMI error and Intel S5000PSL Motherboards]

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 15:07:14 -0400 samson yeung wrote: > Hello, > > I'm working with AndrewL733 on this issue. I'm doing the git bisect right now. > > scanpci -f -1 causes the problem, scanpci -f -2 and scanpci -O do not. Does the problem always happen when scanpci is making an ioperm syscall

Re: [linux-pm] Re: [RFC][PATCH 1/2 -mm] kexec based hibernation -v3: kexec jump

2007-09-26 Thread Joseph Fannin
FWIW, on all the hardware I have, Windows is able to deal with: (1) hibernate Windows (2) run $(OTHER_OS) (3) resume Windows ... which seems to me to say that Linux is doing it wrong if it can't handle other ACPI users between hibernate and resume. But maybe that's just my

why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed)

2007-09-26 Thread Oleg Verych
* Wed, 26 Sep 2007 08:37:05 -0700 * Organization: Linux Foundation > > On Wed, 26 Sep 2007 08:53:27 +0100 > "Jan Beulich" <[EMAIL PROTECTED]> wrote: > >> Otherwise 'modprobe -r' on a module having a dependency on bridge will >> implicitly unload bridge, bringing down all connectivity that was >>

RE: [PATCH4/4] [POWERPC] Fix cpm_uart driver

2007-09-26 Thread Rune Torgersen
> From: Scott Wood > Maybe that's how it was, but the current code initializes it (more or > less) directly with IMAP_ADDR, which also gets fed into ioremap. > > One of the two has got to be wrong. arch/ppc maps the immr area 1:1 into kernel memory, so ioremap and physical are the same. See

Re: [PATCH 7/8] taskstats: fix stats->ac_exitcode to work on threads and use group_exit_code

2007-09-26 Thread roel
Guillaume Chazarain wrote: [...] > @@ -65,13 +65,15 @@ void bacct_add_tsk(struct taskstats *stats, struct > task_struct *tsk) > void bacct_fill_threadgroup(struct taskstats *stats, struct task_struct *tsk, > bool tg_stats) > { > + int group_exit_code; > + >

Re: [PATCH 09/12] mm: remove throttle_vm_writeback

2007-09-26 Thread Peter Zijlstra
On Thu, 2007-04-05 at 15:44 -0700, Andrew Morton wrote: > On Thu, 05 Apr 2007 19:42:18 +0200 > [EMAIL PROTECTED] wrote: > > > rely on accurate dirty page accounting to provide enough push back > > I think we'd like to see a bit more justification than that, please. it should read like this:

[REGRESSION from 2.6.23-rc8] (was: Re: 2.6.23-rc4-mm1 and -rc6-mm1: boot failure on HP nx6325, related to clockevents)

2007-09-26 Thread Rafael J. Wysocki
On Wednesday, 26 September 2007 21:49, Rafael J. Wysocki wrote: > On Wednesday, 26 September 2007 20:51, Thomas Gleixner wrote: > > On Wed, 2007-09-26 at 17:25 +0200, Rafael J. Wysocki wrote: > > > There still are some oddities. > > > > > > First, with the "x86-64: Disable local APIC timer use on

Re: BUG: unable to handle kernel NULL pointer dereference at virtual address 00000008

2007-09-26 Thread Mel Gorman
On (26/09/07 21:40), D-Tick didst pronounce: > Hi, > i described it a little more in detail in > http://lkml.org/lkml/2007/9/25/184 2 months ago. Are you sure about that link? It looks like my own posting. > The kernel oopses often when there is (heavy) disk access, but not > always, thats the

Re: [PATCH4/4] [POWERPC] Fix cpm_uart driver

2007-09-26 Thread Scott Wood
On Wed, Sep 26, 2007 at 03:32:29PM -0500, Rune Torgersen wrote: > > From: Scott Wood > > Maybe that's how it was, but the current code initializes it (more or > > less) directly with IMAP_ADDR, which also gets fed into ioremap. > > > > One of the two has got to be wrong. > > arch/ppc maps the

Re: + uninline-find_task_by_xxx-set-of-functions.patch added to -mm tree

2007-09-26 Thread Ingo Molnar
* [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > -- > Subject: Uninline find_task_by_xxx set of functions > From: Pavel Emelyanov <[EMAIL PROTECTED]> > > The find_task_by_something is a set of macros are used to find task by pid > depending on

Re: No linux/module.h

2007-09-26 Thread Kristof Provost
On 2007-09-26 11:29:33 (+0100), mahamuni ashish <[EMAIL PROTECTED]> wrote: > I am writing simple kernel module. > I have included linux/module.h > compiler gives me error that no such file, I also > searched it on my machine. > It really doesn't exist. I am using fedora 6. > How do I install

Re: [RFC][PATCH 1/2 -mm] kexec based hibernation -v3: kexec jump

2007-09-26 Thread Joseph Fannin
On Fri, Sep 21, 2007 at 11:45:12AM +0200, Pavel Machek wrote: > Hi! > > > > > > Sounds doable, as long as you can cope with long command lines (which > > > shouldn't be a biggie). (If you've got a swapfile or parts of a swap > > > partition already in use, it can be quite fragmented). > > > > Hmm.

sata_sil24 broken since 2.6.23-rc4-mm1

2007-09-26 Thread Torsten Kaiser
As reported in the "2.6.23-rc4-mm1"-thread and the "What's in linux-2.6-block.git for 2.6.24"-thread I'm having trouble that sometimes on bootup one drive from the SiI-3132 throws errors and becomes inaccesible. The latest kernel I have seen this error was 2.6.23-rc7-mm1. >From 7 boots 2 times

Re: commit 6dccd16b7c2703e8bbf8bca62b5cf248332afbe2 kills r8169 send performance

2007-09-26 Thread Timo Jantunen
On Wed, 26 Sep 2007, Willy Tarreau wrote: > On Wed, Sep 26, 2007 at 09:52:02PM +0300, Timo Jantunen wrote: > > On Wed, 26 Sep 2007, Francois Romieu wrote: > > > The patch below is scheduled for inclusion before 2.6.23. Please try it > > > and > > > see if it makes a difference on top of

Re: [PATCH 4/4] dmapool: Improve memory usage for devices which can't cross boundaries

2007-09-26 Thread roel
Matthew Wilcox wrote: [...] > @@ -142,14 +144,13 @@ struct dma_pool *dma_pool_create(const char *name, > struct device *dev, > if ((size % align) != 0) > size = ALIGN(size, align); > > - if (allocation == 0) { > - if (PAGE_SIZE < size) > -

Re: commit 6dccd16b7c2703e8bbf8bca62b5cf248332afbe2 kills r8169 send performance

2007-09-26 Thread Willy Tarreau
On Wed, Sep 26, 2007 at 09:52:02PM +0300, Timo Jantunen wrote: > On Wed, 26 Sep 2007, Francois Romieu wrote: > > > The patch below is scheduled for inclusion before 2.6.23. Please try it and > > see if it makes a difference on top of 2.6.23-rc8 (full dmesg will be > > welcome > > too). > >

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
On 9/26/07, Ray Lee <[EMAIL PROTECTED]> wrote: > Just as an aside, if you've tested this and it works, then there's no > point to keep the write_lpcontrol even as a comment. Kill those four > lines, and if someone's interested in what happened they'll just look > at the file history. Point

Re: [PATCH 3/4] Change dmapool free block management

2007-09-26 Thread roel
Matthew Wilcox wrote: [...] > @@ -113,9 +133,12 @@ struct dma_pool *dma_pool_create(const char *name, > struct device *dev, > return NULL; > } > > - if (size == 0) > + if (size == 0) { > return NULL; > - > + } else if (size < 4) { > +

Re: [PATCH 1/8] taskstats: fix indentation of long argument lists

2007-09-26 Thread Andrew Morton
On Wed, 26 Sep 2007 19:08:18 +0200 Guillaume Chazarain <[EMAIL PROTECTED]> wrote: > Align with the opening parenthesis. > > Changelog since V1 (http://lkml.org/lkml/2007/9/21/527): > - renamed fill_threadgroup() and add_tsk() to respectively > fill_threadgroup_stats() and add_tsk_stats() as

No linux/module.h

2007-09-26 Thread mahamuni ashish
I am writing simple kernel module. I have included linux/module.h compiler gives me error that no such file, I also searched it on my machine. It really doesn't exist. I am using fedora 6. How do I install required libraries. Did you know? You can CHAT without downloading messenger. Go to

Re: [PATCH] JBD/ext34 cleanups: convert to kzalloc

2007-09-26 Thread Andrew Morton
On Fri, 21 Sep 2007 16:13:56 -0700 Mingming Cao <[EMAIL PROTECTED]> wrote: > Convert kmalloc to kzalloc() and get rid of the memset(). I split this into separate ext3/jbd and ext4/jbd2 patches. It's generally better to raise separate patches, please - the ext3 patches I'll merge directly but

Re: [PATCH 0/3] A kernel tracing interface - (updated)

2007-09-26 Thread David Wilder
Randy Dunlap wrote: On Wed, 26 Sep 2007 11:22:29 -0700 David J. Wilder wrote: These patches provide a kernel tracing interface called "trace". (update) Moved the sample code to the new samples\ subdir The motivation for "trace" is to: - Provide a simple set of tracing primitives that will

Re: [PATCH 2/4] dmapool: Validate parameters to dma_pool_create

2007-09-26 Thread roel
Matthew Wilcox wrote: > Check that 'align' is a power of two, like the API specifies. > Align 'size' to 'align' correctly -- the current code has an off-by-one. > The ALIGN macro in kernel.h doesn't. > > Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> > --- > mm/dmapool.c | 15

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Ray Lee
On 9/26/07, Brett Warden <[EMAIL PROTECTED]> wrote: > Appeases the warning "parport0 (bw-qcam): use data_reverse for this!" > > Signed-off-by: Brett T. Warden <[EMAIL PROTECTED]> > > --- > > It seems to work fine with my Quickcam under 2.6.22. > @@ -369,7 +374,11 @@ static void qc_reset(struct

What's in linux1394-2.6.git

2007-09-26 Thread Stefan Richter
I heard that project tree maintainers are encouraged to post merge plans in time, so I'm going to do so now too. Although this time there isn't much in store for drivers/{ieee1394,firewire} for the merge window because we all got sidetracked lately... It's basically bugfixes which I felt were

Re: BUG: unable to handle kernel NULL pointer dereference at virtual address 00000008

2007-09-26 Thread D-Tick
Hi, i described it a little more in detail in http://lkml.org/lkml/2007/9/25/184 2 months ago. The kernel oopses often when there is (heavy) disk access, but not always, thats the point, sometimes it runs 4 weeks, sometimes only a few days. With older kernels sometimes the software raid was out

Re: [PATCH] Add iSCSI iBFT support.

2007-09-26 Thread roel
Konrad Rzeszutek wrote: [...] > +static ssize_t > +ibft_read_binary(struct kobject *kobj, struct bin_attribute *attr, char *buf, > + loff_t off, size_t count) > +{ > + > + struct ibft_device *ibft = container_of(kobj, struct ibft_device, kobj); > + ssize_t len =

Re: 2.6.23-rc4-mm1 and -rc6-mm1: boot failure on HP nx6325, related to clockevents

2007-09-26 Thread Rafael J. Wysocki
On Wednesday, 26 September 2007 20:51, Thomas Gleixner wrote: > On Wed, 2007-09-26 at 17:25 +0200, Rafael J. Wysocki wrote: > > There still are some oddities. > > > > First, with the "x86-64: Disable local APIC timer use on AMD systems with > > C1E" > > patch and my collection of suspend patches

Re: sys_chroot+sys_fchdir Fix

2007-09-26 Thread Christer Weinigel
On Wed, 26 Sep 2007 20:04:14 +0930 David Newall <[EMAIL PROTECTED]> wrote: > Al Viro wrote: > > Oh, for fsck sake... Folks, it's standard-required behaviour. > > Ability to chroot() implies the ability to break out of it. Could > > we please add that (along with reference to SuS) to l-k FAQ and

Re: [RFC][PATCH] page->mapping clarification [1/3] base functions

2007-09-26 Thread Hugh Dickins
On Sat, 22 Sep 2007, KAMEZAWA Hiroyuki wrote: > On Fri, 21 Sep 2007 18:02:47 +0100 (BST) > Hugh Dickins <[EMAIL PROTECTED]> wrote: > > > Or should I now leave PG_swapcache as is, > > given your designs on page->mapping? > > > will conflict with my idea ? > == >

Re: [PATCH 0/4] allow drivers to flush in-flight DMA

2007-09-26 Thread Roland Dreier
> Can we define this API to provide the same semantics as the memory > that dma_alloc_coherent() returns? No, definitely not. The property of the mapping here is all about ordering with respect to other DMAs (from the same device) and nothing to do with coherency between the CPU's and device's

Re: Chroot bug (was: sys_chroot+sys_fchdir Fix)

2007-09-26 Thread Bodo Eggert
On Wed, 26 Sep 2007, David Newall wrote: > Miloslav Semler pointed out that a root process can chdir("..") out of > its chroot. Although this is documented in the man page, it conflicts > with the essential function, which is to change the root directory of > the process. The root directory,

Re: [PATCH 3/4] Change dmapool free block management

2007-09-26 Thread Roland Dreier
> Also add documentation for how dma pools work, move the header above the > includes, add my copyright, add the original author's copyright, add a > GPL v2 licence to the file and fix the includes. The fact that you have all these other changes mixed in makes the main change very difficult to

Re: [PATCH 0/3] A kernel tracing interface - (updated)

2007-09-26 Thread Mathieu Desnoyers
* David J. Wilder ([EMAIL PROTECTED]) wrote: > These patches provide a kernel tracing interface called "trace". > > (update) Moved the sample code to the new samples\ subdir > > The motivation for "trace" is to: > - Provide a simple set of tracing primitives that will utilize the high- >

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread H. Peter Anvin
Jordan Crouse wrote: > > Its the latter - max_pfn as read by find_max_pfn() in arch/i386/e820.c > is being set to 9F (640k) in the broken case, this due to the > the e820 map looking something like this: > > Address Size Type > 0009FC00 1 > 0009FC00 0400 2 > 000E

Re: __kernel_vsyscall () hangs in SIGCHLD handler

2007-09-26 Thread Mikael Pettersson
Ulrich Drepper writes: > On 9/26/07, John Z. Bohach <[EMAIL PROTECTED]> wrote: > > Is there some reason that syslog() sleeps in __kernel_vsyscall() when > > invoked from a signal handler? > > Only very few functions are allowed to be called from signal handlers. > This is clearly spelled

[PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
Appeases the warning "parport0 (bw-qcam): use data_reverse for this!" Signed-off-by: Brett T. Warden <[EMAIL PROTECTED]> --- It seems to work fine with my Quickcam under 2.6.22. diff --git a/drivers/media/video/bw-qcam.c b/drivers/media/video/bw-qcam.c index 7d47cbe..01e47ed 100644 ---

[Re: NMI error and Intel S5000PSL Motherboards]

2007-09-26 Thread samson yeung
Hello, I'm working with AndrewL733 on this issue. I'm doing the git bisect right now. scanpci -f -1 causes the problem, scanpci -f -2 and scanpci -O do not. The systems have two 1-Gig sticks in the D1 and C1 slots of the motherboard. I ran memtest86 overnight and got no errors. (Samsung 1GB

Re: [ofa-general] [PATCH v3] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts.

2007-09-26 Thread Steve Wise
Rolan/Sean, What do you all think? Steve. Steve Wise wrote: iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts. Version 3: - don't use list_del_init() where list_del() is sufficient. Version 2: - added a per-device mutex for the address and listening endpoints lists. -

[PATCH 4/4] dmapool: Improve memory usage for devices which can't cross boundaries

2007-09-26 Thread Matthew Wilcox
The previous implementation simply refused to allocate more than a boundary's worth of data from an entire page. Some users didn't know this, so specified things like SMP_CACHE_BYTES, not realising the horrible waste of memory that this was. It's fairly easy to correct this problem, just by

[PATCH 3/4] Change dmapool free block management

2007-09-26 Thread Matthew Wilcox
Also add documentation for how dma pools work, move the header above the includes, add my copyright, add the original author's copyright, add a GPL v2 licence to the file and fix the includes. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- mm/dmapool.c | 161

Re: missing mnt_drop_write() on open error

2007-09-26 Thread Miklos Szeredi
> > Btw, may_open() doesn't do mnt_want_write() around the truncation if > > file is opened with O_TRUNC | O_RDONLY. > > What's the path to may_open() in that case? open_namei() should wrap > all callers other than nfs, and it does: > > /* O_TRUNC implies we need access checks for write

[PATCH 1/4] Avoid taking waitqueue lock in dmapool

2007-09-26 Thread Matthew Wilcox
With one trivial change (taking the lock slightly earlier on wakeup from schedule), all uses of the waitq are under the pool lock, so we can use the locked (or __) versions of the wait queue functions, and avoid the extra spinlock. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> ---

[PATCH 2/4] dmapool: Validate parameters to dma_pool_create

2007-09-26 Thread Matthew Wilcox
Check that 'align' is a power of two, like the API specifies. Align 'size' to 'align' correctly -- the current code has an off-by-one. The ALIGN macro in kernel.h doesn't. Signed-off-by: Matthew Wilcox <[EMAIL PROTECTED]> --- mm/dmapool.c | 15 --- 1 files changed, 8 insertions(+),

dmapool

2007-09-26 Thread Matthew Wilcox
I have a series of patches to dmapool that I'd like opinions on. I don't have any performance numbers yet, but some of the patches are a good idea, with or without performance numbers. One of the problems with dmapool is that it doesn't have a maintainer listed. I've spent enough time looking

[PATCH] Add iSCSI iBFT support.

2007-09-26 Thread Konrad Rzeszutek
This patch adds a /sysfs/firmware/ibft/table binary blob which exports the iSCSI Boot Firmware Table (iBFT) structure. What is iSCSI Boot Firmware Table? It is a mechanism for the iSCSI tools to extract from the machine NICs the iSCSI connection information so that they can automagically mount

Re: commit 6dccd16b7c2703e8bbf8bca62b5cf248332afbe2 kills r8169 send performance

2007-09-26 Thread Timo Jantunen
On Wed, 26 Sep 2007, Francois Romieu wrote: > The patch below is scheduled for inclusion before 2.6.23. Please try it and > see if it makes a difference on top of 2.6.23-rc8 (full dmesg will be welcome > too). Thanks for the quick reply and fix. Unfortunately the fix didn't help in my case.

Re: 2.6.23-rc8-mm1: ata3: soft resetting link after STR

2007-09-26 Thread Alexey Dobriyan
On Wed, Sep 26, 2007 at 05:00:20PM +0100, Alan Cox wrote: > On Wed, 26 Sep 2007 19:39:01 +0400 > Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > > Frequently get these messages after resume from STR, > > (subjectively, first STR is always OK). > > Does this occur if you have the acpi support

Re: 2.6.23-rc4-mm1 and -rc6-mm1: boot failure on HP nx6325, related to clockevents

2007-09-26 Thread Thomas Gleixner
On Wed, 2007-09-26 at 17:25 +0200, Rafael J. Wysocki wrote: > There still are some oddities. > > First, with the "x86-64: Disable local APIC timer use on AMD systems with C1E" > patch and my collection of suspend patches applied, the box doesn't boot > (the suspend patches don't even thouch the

Re: __kernel_vsyscall () hangs in SIGCHLD handler

2007-09-26 Thread John Z. Bohach
On Wednesday 26 September 2007 10:03:33 Ulrich Drepper wrote: > On 9/26/07, John Z. Bohach <[EMAIL PROTECTED]> wrote: > > Is there some reason that syslog() sleeps in __kernel_vsyscall() > > when invoked from a signal handler? > > Only very few functions are allowed to be called from signal >

Re: [PATCH 0/3] A kernel tracing interface - (updated)

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:22:29 -0700 David J. Wilder wrote: > These patches provide a kernel tracing interface called "trace". > > (update) Moved the sample code to the new samples\ subdir > > The motivation for "trace" is to: > - Provide a simple set of tracing primitives that will utilize the

[PATCH 1/1] nmi_watchdog: x86_64 count timer and hpet like i386

2007-09-26 Thread David Bahi
This modifies nmi_watchdog_tick behavior for x86_64 arch to consider both timer and pit/hpet IRQs just as the i386 arch does. Without this fix a kernel crash occurs very early in the boot process if nmi_watchdog is on. Signed-off-by: David Bahi <[EMAIL PROTECTED]> ---

Re: [patch 3/3] Trace sample

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:22:43 -0700 David J. Wilder wrote: > Trace example - Adds the trace example to samples/ > > Signed-off-by: David Wilder <[EMAIL PROTECTED]> Acked-by: Randy Dunlap <[EMAIL PROTECTED]> > --- > samples/Kconfig|6 ++ > samples/Makefile |1 + >

Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

2007-09-26 Thread Christoph Lameter
On Wed, 26 Sep 2007, Hugh Dickins wrote: > Probably better, yes. In -mm Peter is doing an #ifdef CONFIG_SWAP > bdi_init() on swapper_space. Would make sense to do both together, > perhaps move them to a swapper_space_init() in swap_state.c, saving > his #ifdef too. I suggest leave such

Re: [PATCH] Patches for tiny 386 kernels, again. Linux kernel 2.6.22.7

2007-09-26 Thread Jonathan Campbell
Here is the DMI patch again, written against linux-2.6.23-rc8, with some of the #ifdef CONFIG_DMI's removed and moved to include/linux/dmi.h. Putting them there in the way I've done ensures that you don't have to put #ifdef CONFIG_DMI around each dmi_check_machine() and that you don't have to

Re: [patch 1/3] Trace code and documentation

2007-09-26 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:22:35 -0700 David J. Wilder wrote: > diff --git a/Documentation/trace.txt b/Documentation/trace.txt > new file mode 100644 > index 000..0e42fb8 > --- /dev/null > +++ b/Documentation/trace.txt > @@ -0,0 +1,160 @@ > +Trace User Interface > +=== > +When a

Re: sys_chroot+sys_fchdir Fix

2007-09-26 Thread Al Viro
On Wed, Sep 26, 2007 at 08:04:14PM +0930, David Newall wrote: > Al Viro wrote: > >Oh, for fsck sake... Folks, it's standard-required behaviour. Ability > >to chroot() implies the ability to break out of it. Could we please > >add that (along with reference to SuS) to l-k FAQ and be done with

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on copyup ops

2007-09-26 Thread Adrian Bunk
On Wed, Sep 26, 2007 at 09:40:20AM -0400, Erez Zadok wrote: >... > Also, Auke, if indeed compilers are [sic] likely to do better than > programmers adding un/likely wrappers, then why do we still support that in > the kernel? (Working for a company tat produces high-quality compilers, you > may

Re: [PATCH 2/6] LBS: fix uninitialized swapper_space

2007-09-26 Thread Hugh Dickins
On Mon, 24 Sep 2007, Christoph Lameter wrote: > On Fri, 21 Sep 2007, Hugh Dickins wrote: > > > Swapping crashed immediately: must initialize new fields of swapper_space. > > Thanks for finding that. It may be better though to use the new > mapping_setup() function instead? That way there is no

forcedeth question

2007-09-26 Thread roel
in file ./drivers/net/forcedeth.c line 2142 of current git I have a for (i=0;i<=np->register_size;i+= 32) { ^ shouldn't this be a '<' In the same file on line 4015: for (i = 0;i <= np->register_size/sizeof(u32); i++) shouldn't the "<=" be a '<'? Roel - To unsubscribe from this list:

Re: [PATCH] Since we have counters in __u64 format we have to print them with %llu macros.

2007-09-26 Thread H. Peter Anvin
Balbir Singh wrote: > Andreas Schwab wrote: >> Maxim Uvarov <[EMAIL PROTECTED]> writes: >> >>> diff --git a/Documentation/accounting/getdelays.c >>> b/Documentation/accounting/getdelays.c >>> index cbee3a2..73924df 100644 >>> --- a/Documentation/accounting/getdelays.c >>> +++

Proposed 2.6 Patch for AMD MIPS Alchemy au1550 I2C interface I2C interface

2007-09-26 Thread Chris David
Hello, Please CC me on replies. I have made a trivial patch to fix a problem on the AMD MIPS Alchemy au1550 I2C interface. The PSC (programmable serial controller) seem to 'hang' when I sent only an 'address' byte on the I2C bus. The patch essentially uses the PSC_SMBSTAT register's TE

Re: [PATCH 3/3] CRED: Move the effective capabilities into the cred struct

2007-09-26 Thread Al Viro
On Wed, Sep 19, 2007 at 09:11:26PM -0700, Andrew Morgan wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > David Howells wrote: > > Move the effective capabilities mask from the task struct into the > > credentials > > record. > > > > Note that the effective capabilities mask in the

nmi_watchdog fix for x86_64 to be more like i386

2007-09-26 Thread David Bahi
Thanks to tglx and ghaskins for all the help in tracking down a very early nmi_watchdog crash on certain x86_64 machines. This modifies nmi_watchdog_tick behavior for x86_64 arch to consider both timer and hpet IRQs just as the i386 arch does. Signed-off-by: David Bahi <[EMAIL PROTECTED]> ---

[patch 3/3] Trace sample

2007-09-26 Thread David J. Wilder
Trace example - Adds the trace example to samples/ Signed-off-by: David Wilder <[EMAIL PROTECTED]> --- samples/Kconfig|6 ++ samples/Makefile |1 + samples/trace/Makefile |4 + samples/trace/fork_trace.c | 132 4

[patch 2/3] Relay Reset Consumed

2007-09-26 Thread David J. Wilder
This patch allows relay channels to be reset i.e. unconsumed. Basically allows a 'rewind' function for flight-recorder tracing. Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> Signed-off-by: David Wilder <[EMAIL PROTECTED]> --- Documentation/filesystems/relay.txt | 11 ++

[PATCH 0/3] A kernel tracing interface - (updated)

2007-09-26 Thread David J. Wilder
These patches provide a kernel tracing interface called "trace". (update) Moved the sample code to the new samples\ subdir The motivation for "trace" is to: - Provide a simple set of tracing primitives that will utilize the high- performance and low-overhead of relayfs for passing traces data

[patch 1/3] Trace code and documentation

2007-09-26 Thread David J. Wilder
Trace - Provides tracing primitives Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]> Signed-off-by: Martin Hunt <[EMAIL PROTECTED]> Signed-off-by: David Wilder <[EMAIL PROTECTED]> --- Documentation/trace.txt | 160 ++ include/linux/trace.h | 99 + lib/Kconfig |

[PATCH] just rename call_rcu_bh instead of making it a macro

2007-09-26 Thread Steven Rostedt
Seems that I found a box that has a config that passes call_rcu_bh as a function pointer (see net/sctp/sm_make_chunk.c), so declaring the call_rcu_bh has a macro function isn't good enough. This patch makes it just another name of call_rcu for rcupreempt. Signed-off-by: Steven Rostedt <[EMAIL

Re: [patch 1/7] Extended crashkernel command line

2007-09-26 Thread Bernhard Walle
* Oleg Verych <[EMAIL PROTECTED]> [2007-09-26 20:18]: > > I was thinking about errors in YaST or typos in bootloader config, that > may appear sometimes. And kernel must tolerate this kind of userspace > input to be more reliable. But you know better, i just am waving hands. Of course the kernel

Re: Linux 2.6.22.9

2007-09-26 Thread Greg Kroah-Hartman
diff --git a/Documentation/dvb/get_dvb_firmware b/Documentation/dvb/get_dvb_firmware index 4820366..6cb3080 100644 --- a/Documentation/dvb/get_dvb_firmware +++ b/Documentation/dvb/get_dvb_firmware @@ -56,7 +56,7 @@ syntax(); sub sp8870 { my $sourcefile = "tt_Premium_217g.zip"; -my

Linux 2.6.22.9

2007-09-26 Thread Greg Kroah-Hartman
We (the -stable team) are announcing the release of the 2.6.22.9 kernel. It fixes a number of reported bugs, and any user of the 2.6.22 series is encouraged to upgrade. I'll also be replying to this message with a copy of the patch between 2.6.22.8 and 2.6.22.9 The updated 2.6.22.y git tree can

[PATCH] fs/ocfs2/: removed unneeded initial value and function's return value

2007-09-26 Thread Denis Cheng
Signed-off-by: Denis Cheng <[EMAIL PROTECTED]> --- fs/ocfs2/super.c | 17 - 1 files changed, 8 insertions(+), 9 deletions(-) diff --git a/fs/ocfs2/super.c b/fs/ocfs2/super.c index c034b51..b98ec12 100644 --- a/fs/ocfs2/super.c +++ b/fs/ocfs2/super.c @@ -105,7 +105,7 @@ static

Re: missing mnt_drop_write() on open error

2007-09-26 Thread Dave Hansen
On Wed, 2007-09-26 at 19:50 +0200, Miklos Szeredi wrote: > Maybe. Can we do the mnt_want_write() from __dentry_open(), instead > of may_open()? That would be a lot cleaner. I'll explore that. It may make very good sense. > Btw, may_open() doesn't do mnt_want_write() around the truncation if >

Re: [PATCH 01/24] CRED: Introduce a COW credentials record

2007-09-26 Thread Al Viro
On Wed, Sep 26, 2007 at 03:21:05PM +0100, David Howells wrote: > To alter the credentials record, a copy must be made. This copy may then be > altered and then the pointer in the task_struct redirected to it. From that > point on the new record should be considered immutable. Umm... Perhaps a

Re: Man page for revised timerfd API

2007-09-26 Thread Davide Libenzi
Michael, SCB ... On Wed, 26 Sep 2007, Michael Kerrisk wrote: > .TH TIMERFD_CREATE 2 2007-09-26 Linux "Linux Programmer's Manual" > .SH NAME > timerfd_create, timerfd_settime, timer_gettime \- > timers that notify via file descriptors > .SH SYNOPSIS > .\" FIXME . This header file may well

Re: [patch 1/7] Extended crashkernel command line

2007-09-26 Thread Oleg Verych
Wed, Sep 26, 2007 at 06:16:02PM +0200, Bernhard Walle (part two, see bottom): > > memparse(), as a wrapper for somple_strtoll(), always have a return value > > (zero by default). > > Sorry for my typos, i should write `simple_strtoull()'. This

Re: missing mnt_drop_write() on open error

2007-09-26 Thread Miklos Szeredi
> On Wed, 2007-09-26 at 10:38 +0200, Miklos Szeredi wrote: > > In __dentry_open() there's still a few places where fput() won't be > > called, notably when ->open fails, which is what I'm triggering I > > think. > > > > Also even more horrible things can happen because of the > >

Re: KPROBES: Instrumenting a function's call site

2007-09-26 Thread Avishay Traeger
On Wed, 2007-09-26 at 10:28 -0700, Keshavamurthy, Anil S wrote: > On Wed, Sep 26, 2007 at 10:09:33AM +0530, Ananth N Mavinakayanahalli wrote: > > On Tue, Sep 25, 2007 at 06:12:38PM -0400, Avishay Traeger wrote: > > > Hello, > > > I am trying to use kprobes to measure the latency of a function by >

Re: KPROBES: Instrumenting a function's call site

2007-09-26 Thread Avishay Traeger
On Wed, 2007-09-26 at 22:57 +0530, Ananth N Mavinakayanahalli wrote: > On Wed, Sep 26, 2007 at 12:09:35PM -0400, Avishay Traeger wrote: > > On Wed, 2007-09-26 at 14:33 +0530, Ananth N Mavinakayanahalli wrote: > > > What happens when the "call" is singlestepped is that the instruction > > > pointer

Re: [PATCH 1/3] taskstats: separate PID/TGID stats producers to complete the TGID ones

2007-09-26 Thread Guillaume Chazarain
Le Sat, 22 Sep 2007 23:36:29 +0530, Balbir Singh <[EMAIL PROTECTED]> a écrit : [reordered] > How about calling this one fill_threadgroup_stats()? > How about we call function add_tsk_stats()? > I still prefer braces around do <--> while, I think the code is easier > to read with them. > Could we

<    1   2   3   4   5   6   7   8   9   >