Re: Chroot bug

2007-09-26 Thread Olivier Galibert
On Wed, Sep 26, 2007 at 07:57:38PM +0930, David Newall wrote: As has been said, there are thousands of ways to break out of a chroot. It's just that one of them should not be that chroot lets you walk out. chroot does not allow you to walk out if you're in. It only allows you to walk

Re: Network slowdown due to CFS

2007-09-26 Thread Martin Michlmayr
* Mike Galbraith [EMAIL PROTECTED] [2007-09-26 12:23]: I noticed on the iperf website a patch which contains sched_yield(). http://dast.nlanr.net/Projects/Iperf2.0/patch-iperf-linux-2.6.21.txt Do you have that patch applied by any chance? If so, it might be a worth while to try it without

Re: kbuild: LDFLAGS_MODULE unusable for external module builds (2.6.23-rc2)

2007-09-26 Thread Sam Ravnborg
What macro should set for linker parameters of foo.o ? I'm not shure. Have you read: Documentation/kbuild/makfilefiles.txt? Yes. This was a *very* helpfull. And many examples spokes about LDFLAGS_$@ there. Not directly described for modules. Took a deeper look. I saw one reference to

Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread Joerg Pommnitz
Hello all, this is what git bisect told me about the problem: [EMAIL PROTECTED]:~/linux-2.6$ git bisect good 4fd06960f120e02e9abc802a09f9511c400042a5 is first bad commit commit 4fd06960f120e02e9abc802a09f9511c400042a5 Author: H. Peter Anvin [EMAIL PROTECTED] Date: Wed Jul 11 12:18:56 2007 -0700

Re: [PATCH] Since we have counters in __u64 format we have to print themwith %llu macros.

2007-09-26 Thread Balbir Singh
Maxim Uvarov wrote: Small fix for documentation. --- Documentation/accounting/getdelays.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/accounting/getdelays.c

Re: [PATCHSET 1/4] sysfs: misc updates

2007-09-26 Thread Cornelia Huck
On Thu, 20 Sep 2007 16:05:09 +0900, Tejun Heo [EMAIL PROTECTED] wrote: 0001-sysfs-kill-SYSFS_FLAG_REMOVED.patch 0002-sysfs-fix-comments-of-sysfs_add-remove_one.patch 0003-sysfs-fix-sysfs_chmod_file-such-that-it-updates-s.patch 0004-sysfs-clean-up-header-files.patch

Re: Chroot bug

2007-09-26 Thread David Newall
Alan Cox wrote: The dot-dot entry in the root directory is interpreted to mean the root directory itself. Thus, dot-dot cannot be used to access files outside the subtree rooted at the root directory. Which is behaviour chroot preserves properly. And yet it is the dot-dot entry

Re: NMI error and Intel S5000PSL Motherboards

2007-09-26 Thread Alan Cox
Aug 29 09:02:10 master kernel: Uhhuh. NMI received for unknown reason 30. Aug 29 09:02:10 master kernel: Do you have a strange power saving mode enabled? What would be useful is to know under what situations that board can raise NMI 30. In other words, Intel seems to be blaming the problem

Re: Chroot bug

2007-09-26 Thread David Newall
Olivier Galibert wrote: chroot does not allow you to walk out if you're in. You're mistaken. Or more properly, further use of chroot lets you walk out. This really has been said before, and before, and before. chroot(subtree); // enter chroot chdir(/);// now at subtree

[patch/backport] CFS scheduler, -v22, for v2.6.23-rc8, v2.6.22.8, v2.6.21.7, v2.6.20.20

2007-09-26 Thread Ingo Molnar
By popular demand, here is release -v22 of the CFS scheduler. It is a full backport of the latest greatest sched-devel.git code to v2.6.23-rc8, v2.6.22.8, v2.6.21.7 and v2.6.20.20. The patches can be downloaded from the usual place: http://people.redhat.com/mingo/cfs-scheduler/ This is

Re: Chroot bug

2007-09-26 Thread Alan Cox
The dot-dot entry in the root directory is interpreted to mean the root directory itself. Thus, dot-dot cannot be used to access files outside the subtree rooted at the root directory. Which is behaviour chroot preserves properly. And yet it is the dot-dot entry which is

Re: sys_chroot+sys_fchdir Fix

2007-09-26 Thread Alan Cox
On Wed, 26 Sep 2007 20:04:14 +0930 David Newall [EMAIL PROTECTED] wrote: Al Viro wrote: Oh, for fsck sake... Folks, it's standard-required behaviour. Ability to chroot() implies the ability to break out of it. Could we please add that (along with reference to SuS) to l-k FAQ and be done

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-26 Thread Alan Cox
On Wed, 26 Sep 2007 00:03:19 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Peer Chen wrote: According to the description of section 5.2.2.1 and 10.1.2 of AHCI specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ by software when GHC.AE is set to ¡®1¡¯. Signed-off-by: Peer Chen

Re: Network slowdown due to CFS

2007-09-26 Thread Ingo Molnar
* Martin Michlmayr [EMAIL PROTECTED] wrote: * Mike Galbraith [EMAIL PROTECTED] [2007-09-26 12:23]: I noticed on the iperf website a patch which contains sched_yield(). http://dast.nlanr.net/Projects/Iperf2.0/patch-iperf-linux-2.6.21.txt Do you have that patch applied by any chance? If

Re: sys_chroot+sys_fchdir Fix

2007-09-26 Thread David Newall
Alan Cox wrote: On Wed, 26 Sep 2007 20:04:14 +0930 David Newall [EMAIL PROTECTED] wrote: Al Viro wrote: Oh, for fsck sake... Folks, it's standard-required behaviour. Ability to chroot() implies the ability to break out of it. Could we please add that (along with reference to SuS) to

Semantics of SO_REUSEADDR and P2P TCP NAT traversal

2007-09-26 Thread Paul Clark
Folks, I'm working on implementing a TCP NAT traversal scheme for a P2P application, similar to that described in: http://www.brynosaurus.com/pub/net/p2pnat/ and also in http://tools.ietf.org/html/draft-ietf-behave-p2p-state-03 [3.4] The idea in using TCP is to provide a P2P file

Re: Network slowdown due to CFS

2007-09-26 Thread Martin Michlmayr
* Ingo Molnar [EMAIL PROTECTED] [2007-09-26 13:21]: I noticed on the iperf website a patch which contains sched_yield(). http://dast.nlanr.net/Projects/Iperf2.0/patch-iperf-linux-2.6.21.txt great! Could you try this too: echo 1 /proc/sys/kernel/sched_compat_yield does it fix iperf

Re: kbuild: LDFLAGS_MODULE unusable for external module builds (2.6.23-rc2)

2007-09-26 Thread Henry Nestler
Hello Sam, Sam Ravnborg wrote: What macro should set for linker parameters of foo.o ? I'm not shure. Have you read: Documentation/kbuild/makfilefiles.txt? Yes. This was a *very* helpfull. And many examples spokes about LDFLAGS_$@ there. Not directly described for modules. Took a deeper

Re: [PATCH] Since we have counters in __u64 format we have to print them with %llu macros.

2007-09-26 Thread Andreas Schwab
Maxim Uvarov [EMAIL PROTECTED] writes: diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c index cbee3a2..73924df 100644 --- a/Documentation/accounting/getdelays.c +++ b/Documentation/accounting/getdelays.c @@ -208,7 +208,7 @@ void

Re: sys_chroot+sys_fchdir Fix

2007-09-26 Thread Alan Cox
I've made no error. The documentation says what it says, and what it doesn't say, other than for Linux, is that there is an unspecified way of breaking out. Now see I've been working on Unix systems since 1988 or so and in that time I've learned to read the documentation properly (you

Re: Chroot bug

2007-09-26 Thread Miloslav Semler
Alan Cox napsal(a): but many program use this as security feature. So do you think that bind may use vserver? It would be a lot stronger if it did. A bind running non-root will be probably safe. A bind running as root can be attacked and break out of a chroot trivially. I guess it depends

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-26 Thread Jeff Garzik
Alan Cox wrote: On Wed, 26 Sep 2007 00:03:19 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Peer Chen wrote: According to the description of section 5.2.2.1 and 10.1.2 of AHCI specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ by software when GHC.AE is set to ¡®1¡¯. Signed-off-by:

Re: [PATCH] Since we have counters in __u64 format we have to print them with %llu macros.

2007-09-26 Thread Balbir Singh
Andreas Schwab wrote: Maxim Uvarov [EMAIL PROTECTED] writes: diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c index cbee3a2..73924df 100644 --- a/Documentation/accounting/getdelays.c +++ b/Documentation/accounting/getdelays.c @@ -208,7 +208,7 @@

Re: sys_chroot+sys_fchdir Fix

2007-09-26 Thread David Newall
Alan Cox wrote: Now see I've been working on Unix systems since 1988 or so and in that time I've learned to read the documentation properly (you haven't) My, my, you can be unpleasant when you try. There's no need for it. As it happens I have years of UNIX experience on you. (Newbie!)

RE: Network slowdown due to CFS

2007-09-26 Thread David Schwartz
I think the real fix would be for iperf to use blocking network IO though, or maybe to use a POSIX mutex or POSIX semaphores. So it's definitely not a bug in the kernel, only in iperf? Martin: Actually, in this case I think iperf is doing the right thing (though not the best thing) and

Re: [PATCH] TASK_KILLABLE version 2

2007-09-26 Thread Ric Wheeler
Bob Bell wrote: On Sat, Sep 01, 2007 at 08:43:49PM -0600, Matthew Wilcox wrote: Here's the second version of TASK_KILLABLE. A few changes since version 1: snip I obviously haven't covered every place that can result in a process sleeping uninterruptibly while attempting an operation. But

Re: [PATCH] hibernation doesn't even build on frv - tons of helpers are missing

2007-09-26 Thread David Howells
Acked-By: David Howells [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: 2.6.23-rc8-mm1

2007-09-26 Thread Andy Whitcroft
On Tue, Sep 25, 2007 at 03:05:53PM -0700, Badari Pulavarty wrote: Hi Andy, One the patch you created in -mm is causing compile warning. Here is the fix. Please verify. Thanks, Badari arch/powerpc/mm/init_64.c: In function `vmemmap_populated': arch/powerpc/mm/init_64.c:211: warning:

Re: [PATCH] Since we have counters in __u64 format we have to print them with %llu macros.

2007-09-26 Thread Mikael Pettersson
On Wed, 26 Sep 2007 17:18:06 +0530, Balbir Singh wrote: Andreas Schwab wrote: Maxim Uvarov [EMAIL PROTECTED] writes: diff --git a/Documentation/accounting/getdelays.c b/Documentation/accounting/getdelays.c index cbee3a2..73924df 100644 --- a/Documentation/accounting/getdelays.c

Re: Chroot bug

2007-09-26 Thread Kyle Moffett
On Sep 26, 2007, at 06:27:38, David Newall wrote: Kyle Moffett wrote: David, please do tell myself and Adrian how locking down chroot () the way you want will avoid letting root break out through any of the above ways? As has been said, there are thousands of ways to break out of a

Re: [PATCH] usbvision-video: buggered method tables

2007-09-26 Thread Mauro Carvalho Chehab
Em Qua, 2007-09-26 às 01:53 +0100, Al Viro escreveu: duplicated .mmap in one, .vidioc_s_audio misspelled as .vidioc_g_audio in other Signed-off-by: Al Viro [EMAIL PROTECTED] Acked-by: Mauro Carvalho Chehab [EMAIL PROTECTED] --- drivers/media/video/usbvision/usbvision-video.c |5

Re: Oops in pwc v4l driver

2007-09-26 Thread Mauro Carvalho Chehab
Hi Oliver, May you send your Signed-off-by for the patch? Cheers, Mauro. Em Dom, 2007-09-02 às 15:02 +0200, Oliver Neukum escreveu: Am Sonntag 02 September 2007 schrieb Alex Smith: Hi, I found an old Philips Askey VC010 webcam and attempted to get it working on Linux (latest git,

Re: Chroot bug

2007-09-26 Thread Miloslav Semler
Kyle Moffett napsal(a): On Sep 26, 2007, at 06:27:38, David Newall wrote: Kyle Moffett wrote: David, please do tell myself and Adrian how locking down chroot() the way you want will avoid letting root break out through any of the above ways? As has been said, there are thousands of ways to

Re: Chroot bug

2007-09-26 Thread Bongani Hlope
On Wednesday 26 September 2007 13:06:51 David Newall wrote: Alan Cox wrote: The dot-dot entry in the root directory is interpreted to mean the root directory itself. Thus, dot-dot cannot be used to access files outside the subtree rooted at the root directory. Which is behaviour chroot

Re: Oops in pwc v4l driver

2007-09-26 Thread Oliver Neukum
The pwc driver is defficient in locking, which can trigger an oops when disconnecting. Signed-off-by: Oliver Neukum [EMAIL PROTECTED] Regards Oliver --- --- a/drivers/media/video/pwc/pwc-if.c 2007-08-24 10:16:38.0 +0200 +++ b/drivers/media/video/pwc/pwc-if.c

[PATCH] Remove unused member from nsproxy

2007-09-26 Thread Pavel Emelyanov
The nslock spinlock is not used in the kernel at all. Remove it. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/include/linux/init_task.h b/include/linux/init_task.h index a3f2541..cae35b6 100644 --- a/include/linux/init_task.h +++ b/include/linux/init_task.h @@ -73,7 +73,6

Re: Oops in pwc v4l driver

2007-09-26 Thread Oliver Neukum
The pwc driver is defficient in locking, which can trigger an oops when disconnecting. Signed-off-by: Oliver Neukum [EMAIL PROTECTED] Regards Oliver --- --- a/drivers/media/video/pwc/pwc-if.c 2007-08-24 10:16:38.0 +0200 +++ b/drivers/media/video/pwc/pwc-if.c

Re: Chroot bug

2007-09-26 Thread linux-os \(Dick Johnson\)
On Wed, 26 Sep 2007, David Newall wrote: Olivier Galibert wrote: chroot does not allow you to walk out if you're in. You're mistaken. Or more properly, further use of chroot lets you walk out. This really has been said before, and before, and before. chroot(subtree); // enter

[PATCH] Use KMEM_CACHE macro to create the nsproxy cache

2007-09-26 Thread Pavel Emelyanov
The blessed way for standard caches is to use it. Besides, this may give this cache a better alignment. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c index ee68964..31351cc 100644 --- a/kernel/nsproxy.c +++ b/kernel/nsproxy.c @@ -222,8

Re: realtime preemption performance difference

2007-09-26 Thread Ankita Garg
Hi Jaswinder, On Mon, Sep 24, 2007 at 05:18:01PM +0530, Jaswinder Singh wrote: Hi all, I want to check performance difference by using realtime preemption patch : http://www.kernel.org/pub/linux/kernel/projects/rt/ Please let me know from where I can download samples to test realtime

Re: [PATCH 2/3] CRED: Split the task security data and move part of it into struct cred

2007-09-26 Thread David Howells
Stephen Smalley [EMAIL PROTECTED] wrote: Precisely when to use one identity vs. the other though isn't always clear, and the potential for accidental divergence is also a concern. What should auditing use in audit_filter_rules() when dealing with AUDIT_SUBJ_* cases? Should the SUBJ cases use

Re: Network slowdown due to CFS

2007-09-26 Thread Ingo Molnar
* David Schwartz [EMAIL PROTECTED] wrote: I think the real fix would be for iperf to use blocking network IO though, or maybe to use a POSIX mutex or POSIX semaphores. So it's definitely not a bug in the kernel, only in iperf? Martin: Actually, in this case I think iperf is

2.6.23-rc7-ext4-1 patchset released

2007-09-26 Thread Theodore Ts'o
I've just released the 2.6.23-rc7-ext4-1; it's largely identical to 2.6.23-rc6-ext4-1 except that I've synchronized patches and patch names with patches that Andrew had pulled into 2.6.23-rc7-mm1. It's available in the standard place: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git

Re: [patch/backport] CFS scheduler, -v22, for v2.6.23-rc8, v2.6.22.8, v2.6.21.7, v2.6.20.20

2007-09-26 Thread S.Çağlar Onur
26 Eyl 2007 Çar tarihinde, Ingo Molnar şunları yazmıştı: By popular demand, here is release -v22 of the CFS scheduler. It is a full backport of the latest greatest sched-devel.git code to v2.6.23-rc8, v2.6.22.8, v2.6.21.7 and v2.6.20.20. The patches can be downloaded from the usual place:

Re: [PATCH] Use KMEM_CACHE macro to create the nsproxy cache

2007-09-26 Thread Cedric Le Goater
Pavel Emelyanov wrote: The blessed way for standard caches is to use it. Besides, this may give this cache a better alignment. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] yes of course. thanks. Acked-by: Cedric Le Goater [EMAIL PROTECTED] --- diff --git a/kernel/nsproxy.c

Re: [PATCH 1/2] [INPUT] Blackfin BF54x Input Keypad controller driver

2007-09-26 Thread Dmitry Torokhov
Hi Bryan, Michael, On 9/25/07, Bryan Wu [EMAIL PROTECTED] wrote: From: Michael Hennerich [EMAIL PROTECTED] Date: Sun, 5 Aug 2007 18:45:26 +0800 Subject: [PATCH 1/2] [INPUT] Blackfin BF54x Input Keypad controller driver Thank you for the patch. Couple of comments: + +static void

Re: [PATCH] Use KMEM_CACHE macro to create the nsproxy cache

2007-09-26 Thread Serge E. Hallyn
Quoting Pavel Emelyanov ([EMAIL PROTECTED]): The blessed way for standard caches is to use it. Besides, this may give this cache a better alignment. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] Acked-by: Serge Hallyn [EMAIL PROTECTED] --- diff --git a/kernel/nsproxy.c

Re: [PATCH] Remove unused member from nsproxy

2007-09-26 Thread Pavel Emelyanov
Cedric Le Goater wrote: Pavel Emelyanov wrote: The nslock spinlock is not used in the kernel at all. it's also useless now that you have put some RCU rules around it. right ? Exactly! C. Remove it. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git

Re: [PATCH 10/25] Unionfs: add un/likely conditionals on copyup ops

2007-09-26 Thread Erez Zadok
In message [EMAIL PROTECTED], Kok, Auke writes: Erez Zadok wrote: Signed-off-by: Erez Zadok [EMAIL PROTECTED] --- fs/unionfs/copyup.c | 102 +- 1 files changed, 51 insertions(+), 51 deletions(-) diff --git a/fs/unionfs/copyup.c

Re: Chroot bug

2007-09-26 Thread Al Viro
On Wed, Sep 26, 2007 at 03:11:33PM +0200, Miloslav Semler wrote: As for the nested-chroot() bit, the root user inside of a chroot is always allowed to chroot(). This is necessary for test-suites for various distro installers, chroot once to enter the installer playpen, installer chroots

Re: [PATCH 05/25] Unionfs: cast page-index loff_t before shifting

2007-09-26 Thread Erez Zadok
In message [EMAIL PROTECTED], Christoph Hellwig writes: On Tue, Sep 25, 2007 at 11:09:44PM -0400, Erez Zadok wrote: Fixes bugs in number promotion/demotion computation, as per http://lkml.org/lkml/2007/9/20/17 It's better to use te page_offset helper as that avoids any confusion on where

Re: [patch/backport] CFS scheduler, -v22, for v2.6.23-rc8, v2.6.22.8, v2.6.21.7, v2.6.20.20

2007-09-26 Thread Ingo Molnar
* S.Çağlar Onur [EMAIL PROTECTED] wrote: Compilation [against 2.6.20.20] fails with buildfarm linux-2.6.20 # make CHK include/linux/version.h CHK include/linux/utsrelease.h CHK include/linux/compile.h CC kernel/sched.o In file included from kernel/sched.c:850:

[PATCH] Since we have counters in __u64 format we have to print them with %llu macros.

2007-09-26 Thread Maxim Uvarov
Small fix for documentation. Added (unsigned long long). --- Documentation/accounting/getdelays.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/accounting/getdelays.c

Re: realtime preemption performance difference

2007-09-26 Thread Ankita Garg
Hi Jaswinder, On Wed, Sep 26, 2007 at 12:41:57PM +0530, Jaswinder Singh wrote: hello hufey, I am not using montavista kernel, I am using standard linux kernel. Realtime is known by worst case latencies. Ingo and team are claiming for realtime support so their should be some samples and

Re: [PATCH 03/25] Unionfs: display informational messages only if debug is on

2007-09-26 Thread Erez Zadok
In message [EMAIL PROTECTED], Jan Engelhardt writes: On Sep 25 2007 23:09, Erez Zadok wrote: --- a/fs/unionfs/commonfops.c +++ b/fs/unionfs/commonfops.c @@ -394,8 +394,8 @@ int unionfs_file_revalidate(struct file *file, bool willwrite) if (willwrite IS_WRITE_FLAG(file-f_flags)

Re: Chroot bug

2007-09-26 Thread Kyle Moffett
On Sep 26, 2007, at 09:11:33, Miloslav Semler wrote: + long directory_is_out(struct vfsmount *wdmnt, struct dentry *wdentry, + struct vfsmount *rootmnt, struct dentry *root) + { + struct nameidata oldentry, newentry; + long ret = 1; + +

Re: Chroot bug

2007-09-26 Thread Alan Cox
On Wed, 26 Sep 2007 13:34:53 +0200 Miloslav Semler [EMAIL PROTECTED] wrote: Alan Cox napsal(a): but many program use this as security feature. So do you think that bind may use vserver? It would be a lot stronger if it did. A bind running non-root will be probably safe. A bind

Re: sys_chroot+sys_fchdir Fix

2007-09-26 Thread Alan Cox
therefore it must be right. You present no reasoning to explain why the behavior is correct; instead you use insults. I've exhausted my tolerance for rudeness. Well if citing standards documents at people is rudeness so be it. Alan - To unsubscribe from this list: send the line

Re: queued patches for SCSI for 2.6.24

2007-09-26 Thread James Bottomley
On Wed, 2007-09-26 at 13:56 +0900, FUJITA Tomonori wrote: On Tue, 25 Sep 2007 22:45:53 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Tue, 2007-09-25 at 23:34 -0400, Jeff Garzik wrote: Matthew Wilcox wrote: On Tue, Sep 25, 2007 at 10:37:33PM -0400, Jeff Garzik wrote: Are there

Re: Regression in 2.6.23-pre Was: Problems with 2.6.23-rc6 on AMD Geode LX800

2007-09-26 Thread H. Peter Anvin
Joerg Pommnitz wrote: Hello all, this is what git bisect told me about the problem: [EMAIL PROTECTED]:~/linux-2.6$ git bisect good 4fd06960f120e02e9abc802a09f9511c400042a5 is first bad commit commit 4fd06960f120e02e9abc802a09f9511c400042a5 Author: H. Peter Anvin [EMAIL PROTECTED] Date:

[PATCH] powerpc: fix pci domain detection

2007-09-26 Thread Arnd Bergmann
The /proc/bus/pci/* files list PCI domain numbers only for devices that claim to be on a multi-domain system. The check for this is broken on powerpc, because the buid value is truncated to 32 bits. There is at least one machine (IBM QS21) that only uses the high-order bits of the buid, so the

Re: 2.6.23-rc7-mm1 AHCI ATA errors -- won't boot

2007-09-26 Thread Berck E. Nash
Jeff Garzik wrote: Would it also be possible for you to send along 'hdparm --Istdout' output for your config disk thingy, /dev/sdd ? Sure, just don't ask me what it is! (I've generally assumed that writing to it would be a bad idea.) Berck /dev/sdd: 0040 3fff c837 0010 003f

[PATCH 00/24] Introduce credential record

2007-09-26 Thread David Howells
Hi Al, Christoph, Trond, Stephen, Casey, Here's a set of patches that implement a very basic set of COW credentials. It compiles, links and runs for x86_64 with EXT3, (V)FAT, NFS, AFS, SELinux and keyrings all enabled. I've included a patch that should make most of the other archs and

[PATCH 03/24] CRED: Alter security_task_getsecid() and similar to return both task SIDs

2007-09-26 Thread David Howells
Alter security_task_getsecid(), selinux_get_task_sid() and associated functions to return both the objective/victim and subjective/action task SIDs. Both results are optional by submitting NULL result pointers. Interestingly, AF_NETLINK calls directly into SELinux. I suspect this to be

[PATCH 02/24] CRED: Split the task security data and move part of it into struct cred

2007-09-26 Thread David Howells
Move into the cred struct the part of the task security data that defines how a task acts upon an object. The part that defines how something acts upon a task remains attached to the task. For SELinux this requires some of task_security_struct to be split off into cred_security_struct which is

[PATCH 04/24] CRED: Move the effective capabilities into the cred struct

2007-09-26 Thread David Howells
Move the effective capabilities mask from the task struct into the credentials record. Note that the effective capabilities mask in the cred struct shadows that in the task_struct because a thread can have its capabilities masks changed by another thread. The shadowing is performed by

[PATCH 06/24] CRED: Request a credential record for a kernel service

2007-09-26 Thread David Howells
Request a credential record for the named kernel service. This produces a cred struct with appropriate DAC and MAC controls for effecting that service. It may be used to override the credentials on a task to do work on that task's behalf. Signed-off-by: David Howells [EMAIL PROTECTED] ---

[PATCH 08/24] FS-Cache: Recruit a couple of page flags for cache management

2007-09-26 Thread David Howells
Recruit a couple of page flags to aid in cache management. The following extra flags are defined: (1) PG_fscache (PG_owner_priv_2) The marked page is backed by a local cache and is pinning resources in the cache driver. (2) PG_fscache_write (PG_owner_priv_3) The marked page

[PATCH 05/24] CRED: Fix up the other credentials references

2007-09-26 Thread David Howells
Fix up the other credentials references to use the new COW cred struct. Signed-off-by: David Howells [EMAIL PROTECTED] --- arch/ia64/ia32/sys_ia32.c |7 ++-- arch/ia64/kernel/perfmon.c|2 - arch/powerpc/platforms/cell/spufs/inode.c |2 -

[PATCH 07/24] FS-Cache: Release page-private after failed readahead

2007-09-26 Thread David Howells
The attached patch causes read_cache_pages() to release page-private data on a page for which add_to_page_cache() fails or the filler function fails. This permits pages with caching references associated with them to be cleaned up. The invalidatepage() address space op is called (indirectly) to

[PATCH 09/24] FS-Cache: Provide an add_wait_queue_tail() function

2007-09-26 Thread David Howells
Provide an add_wait_queue_tail() function to add a waiter to the back of a wait queue instead of the front. Signed-off-by: David Howells [EMAIL PROTECTED] --- include/linux/wait.h |1 + kernel/wait.c| 18 ++ 2 files changed, 19 insertions(+), 0 deletions(-) diff

[PATCH 11/24] CacheFiles: Add missing copy_page export for ia64

2007-09-26 Thread David Howells
This one-line patch fixes the missing export of copy_page introduced by the cachefile patches. This patch is not yet upstream, but is required for cachefile on ia64. It will be pushed upstream when cachefile goes upstream. Signed-off-by: Prarit Bhargava [EMAIL PROTECTED] Signed-Off-By: David

[PATCH 13/24] CacheFiles: Permit the page lock state to be monitored

2007-09-26 Thread David Howells
Add a function to install a monitor on the page lock waitqueue for a particular page, thus allowing the page being unlocked to be detected. This is used by CacheFiles to detect read completion on a page in the backing filesystem so that it can then copy the data to the waiting netfs page.

[PATCH 12/24] CacheFiles: Add a hook to write a single page of data to an inode

2007-09-26 Thread David Howells
Add an address space operation to write one single page of data to an inode at a page-aligned location (thus permitting the implementation to be highly optimised). This is used by CacheFiles to store the contents of netfs pages into their backing file pages. Supply a generic implementation for

[PATCH 14/24] CacheFiles: Export things for CacheFiles

2007-09-26 Thread David Howells
Export a number of functions for CacheFiles's use. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/super.c |2 ++ kernel/auditsc.c |2 ++ 2 files changed, 4 insertions(+), 0 deletions(-) diff --git a/fs/super.c b/fs/super.c index 28e7370..0e8c0e2 100644 --- a/fs/super.c +++

Re: 2.6.23-rc7-mm1 AHCI ATA errors -- won't boot

2007-09-26 Thread Berck E. Nash
Bernd Schmidt wrote: One of these appears in my system as well (ASUS P5W-DH Deluxe mainboard). Here's the hdparm output: Yup, same mainboard here. Since about 2.6.17 or 2.6.18, it has been causing long delays while booting: ata2: SATA link up 3.0 Gbps (SStatus 123 SControl 300) ata2.00:

[PATCH 19/24] AFS: Add TestSetPageError()

2007-09-26 Thread David Howells
Add a TestSetPageError() macro to the suite of page flag manipulators. This can be used by AFS to prevent over-excision of rejected writes from the page cache. Signed-off-by: David Howells [EMAIL PROTECTED] --- include/linux/page-flags.h |1 + 1 files changed, 1 insertions(+), 0

[PATCH 17/24] NFS: Configuration and mount option changes to enable local caching on NFS

2007-09-26 Thread David Howells
Changes to the kernel configuration defintions and to the NFS mount options to allow the local caching support added by the previous patch to be enabled. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/Kconfig|8 fs/nfs/client.c | 14 ++

[PATCH 16/24] NFS: Use local caching

2007-09-26 Thread David Howells
The attached patch makes it possible for the NFS filesystem to make use of the network filesystem local caching service (FS-Cache). To be able to use this, an updated mount program is required. This can be obtained from: http://people.redhat.com/steved/fscache/util-linux/ To mount an

[PATCH 18/24] NFS: Display local caching state

2007-09-26 Thread David Howells
Display the local caching state in /proc/fs/nfsfs/volumes. Signed-off-by: David Howells [EMAIL PROTECTED] --- fs/nfs/client.c |7 --- fs/nfs/fscache.h | 12 2 files changed, 16 insertions(+), 3 deletions(-) diff --git a/fs/nfs/client.c b/fs/nfs/client.c index

[PATCH 20/24] AFS: Add a function to excise a rejected write from the pagecache

2007-09-26 Thread David Howells
Add a function - cancel_rejected_write() - to excise a rejected write from the pagecache. This function is related to the truncation family of routines. It permits the pages modified by a network filesystem client (such as AFS) to be excised and discarded from the pagecache if the attempt to

[PATCH 21/24] AFS: Improve handling of a rejected writeback

2007-09-26 Thread David Howells
Improve the handling of the case of a server rejecting an attempt to write back a cached write. AFS operates a write-back cache, so the following sequence of events can theoretically occur: CLIENT 1CLIENT 2 === ===

[PATCH 23/24] AF_RXRPC: Save the operation ID for debugging

2007-09-26 Thread David Howells
Save the operation ID to be used with a call that we're making for display through /proc/net/rxrpc_calls. This helps debugging stuck operations as we then know what they are. Signed-off-by: David Howells [EMAIL PROTECTED] --- include/net/af_rxrpc.h |1 + net/rxrpc/af_rxrpc.c|3 +++

[PATCH 24/24] FS-Cache: Make kAFS use FS-Cache

2007-09-26 Thread David Howells
The attached patch makes the kAFS filesystem in fs/afs/ use FS-Cache, and through it any attached caches. The kAFS filesystem will use caching automatically if it's available. Signed-Off-By: David Howells [EMAIL PROTECTED] --- fs/Kconfig |8 + fs/afs/Makefile|3

Re: [PATCH 2/3] CRED: Split the task security data and move part of it into struct cred

2007-09-26 Thread Stephen Smalley
On Wed, 2007-09-26 at 14:30 +0100, David Howells wrote: Stephen Smalley [EMAIL PROTECTED] wrote: Precisely when to use one identity vs. the other though isn't always clear, and the potential for accidental divergence is also a concern. What should auditing use in audit_filter_rules()

[PATCH 22/24] AFS: Implement shared-writable mmap

2007-09-26 Thread David Howells
Implement shared-writable mmap for AFS. The key with which to access the file is obtained from the VMA at the point where the PTE is made writable by the page_mkwrite() VMA op and cached in the affected page. If there's an outstanding write on the page made with a different key, then

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-26 Thread Alan Cox
NAK - mmio is an iomap so writel and readl are the wrong things to use The patch is consistent with the rest of the driver. You are welcome to submit a patch to convert ahci to using ioremap. You could just flip the relevant function to use ioread while you are tidying it up, instead of

Re: [PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-26 Thread Jeff Garzik
Alan Cox wrote: NAK - mmio is an iomap so writel and readl are the wrong things to use The patch is consistent with the rest of the driver. You are welcome to submit a patch to convert ahci to using ioremap. You could just flip the relevant function to use ioread while you are tidying it up,

Re: [PATCH 1/4] module: implement module_inhibit_unload()

2007-09-26 Thread Alan Stern
On Wed, 26 Sep 2007, Tejun Heo wrote: Hmmm... I might be missing something here. Who else can wake up a thread in uninterruptible sleep? In principle, anything can. There has never been any guarantee in the kernel that a task sleeping on a waitqueue will remain asleep until the

Re: Chroot bug

2007-09-26 Thread Miloslav Semler
Al Viro napsal(a): On Wed, Sep 26, 2007 at 03:11:33PM +0200, Miloslav Semler wrote: As for the nested-chroot() bit, the root user inside of a chroot is always allowed to chroot(). This is necessary for test-suites for various distro installers, chroot once to enter the installer playpen,

Re: [PATCH] x86-64: Disable local APIC timer use on AMD systems with C1E

2007-09-26 Thread Rafael J. Wysocki
On Wednesday, 26 September 2007 10:31, Ingo Molnar wrote: * Rafael J. Wysocki [EMAIL PROTECTED] wrote: On Tuesday, 25 September 2007 22:55, Thomas Gleixner wrote: On Tue, 2007-09-25 at 22:55 +0200, Rafael J. Wysocki wrote: I have reworked the patch a bit so that it applies on top of

__kernel_vsyscall () hangs in SIGCHLD handler

2007-09-26 Thread John Z. Bohach
Is there some reason that syslog() sleeps in __kernel_vsyscall() when invoked from a signal handler? Is it that I am not allowed to call any system calls from inside a signal handler? I use syslog() from a daemon client/server sys. app. that (tries) to log whenever a child exits. I've

Re: [PATCH 2/3] CRED: Split the task security data and move part of it into struct cred

2007-09-26 Thread Casey Schaufler
--- David Howells [EMAIL PROTECTED] wrote: Stephen Smalley [EMAIL PROTECTED] wrote: Precisely when to use one identity vs. the other though isn't always clear, and the potential for accidental divergence is also a concern. What should auditing use in audit_filter_rules() when dealing

Re: Chroot bug

2007-09-26 Thread Miloslav Semler
This is basically both painfully racy and easily broken with umount and/or access to proc. See this busybox-compatible example: ## Set up chroot mkdir /root1 mount -o mode=0750 -t tmpfs tmpfs /root1 cp -a /bin/busybox /root1/busybox ## Enter chroot chroot /root1 /busybox ## Mount proc

Re: [PATCH 2/2]: PCI Error Recovery: Symbios SCSI First Failure

2007-09-26 Thread Matthew Wilcox
On Fri, Apr 20, 2007 at 03:47:20PM -0500, Linas Vepstas wrote: Implement the so-called first failure data capture (FFDC) for the symbios PCI error recovery. After a PCI error event is reported, the driver requests that MMIO be enabled. Once enabled, it then reads and dumps assorted status

Re: Chroot bug

2007-09-26 Thread Olivier Galibert
On Wed, Sep 26, 2007 at 08:43:44PM +0930, David Newall wrote: Olivier Galibert wrote: chroot does not allow you to walk out if you're in. You're mistaken. Or more properly, further use of chroot lets you walk out. This really has been said before, and before, and before.

Re: [patch] fix sys_mknodat breakage from r/o bind mounts

2007-09-26 Thread Christoph Hellwig
On Wed, Sep 26, 2007 at 12:58:47AM +0200, Miklos Szeredi wrote: if (!S_ISREG(mode) !S_ISCHR(mode) !S_ISBLK(mode) - !S_ISFIFO(mode) !S_ISSOCK(mode) mode != 0) { + !S_ISFIFO(mode) !S_ISSOCK(mode) (mode S_IFMT) != 0) { FYI this whole section might be cleaner as

Re: missing mnt_drop_write() on open error

2007-09-26 Thread Christoph Hellwig
On Wed, Sep 26, 2007 at 10:38:22AM +0200, Miklos Szeredi wrote: Also even more horrible things can happen because of the nd-intent.open.file thing. For example if the lookup routine calls lookup_instantiate_filp(), and after this, but before may_open() some error happens, then

Re: [PATCH RFC 3/9] RCU: Preemptible RCU

2007-09-26 Thread Oleg Nesterov
On 09/23, Paul E. McKenney wrote: On Sun, Sep 23, 2007 at 09:38:07PM +0400, Oleg Nesterov wrote: Isn't DEFINE_PER_CPU_SHARED_ALIGNED better for rcu_flip_flag and rcu_mb_flag? Looks like it to me, thank you for the tip! Hmmm... Why not the same for rcu_data? I guess because there is

Re: [PATCH] - drivers/hid/hid-debug.c - trivial - add KERN_DEBUG prefix, fix typo, constify

2007-09-26 Thread Jiri Kosina
On Tue, 25 Sep 2007, Joe Perches wrote: Also, exported symbol hid_resolv_event is unused by the current kernel tree and perhaps should be removed. This is not true, hid_resolv_event() is called from the code that establishes the mapping between HID and input, see hidinput_configure_usage().

<    1   2   3   4   5   6   7   8   9   >