Re: [PATCH] update checkpatch.pl to version 0.10

2007-09-29 Thread Andy Whitcroft
On Fri, Sep 28, 2007 at 10:46:42AM -0700, Andrew Morton wrote: On Fri, 28 Sep 2007 14:21:38 +0100 Andy Whitcroft [EMAIL PROTECTED] wrote: On Fri, Sep 28, 2007 at 12:49:35PM +0200, Ingo Molnar wrote: * Andy Whitcroft [EMAIL PROTECTED] wrote: On Fri, Sep 28, 2007 at 11:39:02AM

Re: [patch 09/10] Use struct path in fs_struct

2007-09-29 Thread Christoph Hellwig
On Fri, Sep 28, 2007 at 10:39:48PM +0200, Andreas Gruenbacher wrote: On Friday 28 September 2007 20:42, Christoph Hellwig wrote: __d_path should probably switch to taking a struct path * aswell. Indeed, it now easily can. Here we go... One less parameter to __d_path All callers to

Re: [patch] Combine path_put and path_put_conditional

2007-09-29 Thread Christoph Hellwig
On Fri, Sep 28, 2007 at 10:43:50PM +0200, Andreas Gruenbacher wrote: Here is another cleanup on top of Jan's set. Comments? The name path_put_conditional (formerly, dput_path) is a little unclear. Replace (path_put_conditional + path_put) with path_walk_put_both, put a pair of paths after

Re: [patch 09/10] Use struct path in fs_struct

2007-09-29 Thread Christoph Hellwig
On Sat, Sep 29, 2007 at 11:24:26AM +0200, Christoph Hellwig wrote: On Fri, Sep 28, 2007 at 10:39:48PM +0200, Andreas Gruenbacher wrote: On Friday 28 September 2007 20:42, Christoph Hellwig wrote: __d_path should probably switch to taking a struct path * aswell. Indeed, it now easily

Re: [15/17] SLUB: Support virtual fallback via SLAB_VFALLBACK

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 11:14:02 +0200 Peter Zijlstra [EMAIL PROTECTED] wrote: oom-killings, or page allocation failures? The latter, one hopes. Linux version 2.6.23-rc4-mm1-dirty ([EMAIL PROTECTED]) (gcc version 4.1.2 (Ubuntu 4.1.2-0ubuntu4)) #27 Tue Sep 18 15:40:35 CEST 2007 ...

Re: 2.6.23-rc[68]-mm: network hangs

2007-09-29 Thread David Miller
From: Laurent Riffard [EMAIL PROTECTED] Date: Sat, 29 Sep 2007 11:22:06 +0200 Could a router problem prevent ping 127.0.0.1 from working ? Two things that are new and could cause these problems: 1) We dynamically allocate the loopback device now. 2) We have the network namespace stuff.

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Wolfgang Erig
On Sat, Sep 29, 2007 at 01:30:33AM -0700, H. Peter Anvin wrote: Wolfgang Erig wrote: Both are bad. Two different systems and two different bisections. I sent the last step of each. $ git bisect good Bisecting: 0 revisions left to test after this

Re: 2.6.23-rc8-mm2

2007-09-29 Thread Dave Young
Hi, The kernel report warnings about sysfs filename duplicate under rc8-mm1 and rc8-mm2. 1. cut NET: Registered protocol family 16 ACPI: bus type pci registered PCI: PCI BIOS revision 2.10 entry at 0xfb93e, last bus=3 PCI: Using configuration type 1 Setting up standard PCI resources

Re: [COMPAT] Add compat_merge64 helper

2007-09-29 Thread Heiko Carstens
On Fri, Sep 28, 2007 at 06:33:51PM -0400, Kyle McMartin wrote: To be used when endianness matters for argument ordering when reassembling a 64-bit value out of two register halves. Signed-off-by: Kyle McMartin [EMAIL PROTECTED] +static inline u64 compat_merge64(u32 left, u32 right) +{

Re: Write-back from inside FS - need suggestions

2007-09-29 Thread Artem Bityutskiy
Andrew Morton wrote: This is precisely the problem which needs to be solved for delayed allocation on ext2/3/4. This is because it is infeasible to work out how much disk space an ext2 pagecache page will take to write out (it will require zero to three indirect blocks as well). When I did

Re: vga text console not working on 2.6.23-rc8

2007-09-29 Thread Santiago Garcia Mantinan
Please send me your .config as well as /etc/grub.conf and the output of /proc/cmdline. I suppose you mean my grub's menu.lst, after looking at it I've done some more tests and identified the posible cause. This would be my grub menu.lst: default 0 fallback 2 timeout 2 color

Re: [PATCH 3/3] New script to check coding-style compliance on multiple regular files

2007-09-29 Thread Sam Ravnborg
Hi Erez. On Fri, Sep 28, 2007 at 05:32:02PM -0400, Erez Zadok wrote: The script calls checkpatch.pl on each file, and formats any error messages to comply with standard compiler error messages: file_name:line_number:error_message This is particularly useful when run from within a

[PATCH] module: return error when mod_sysfs_init() failed

2007-09-29 Thread Akinobu Mita
load_module() returns zero when mod_sysfs_init() fails, then the module loading will succeed accidentally. This patch makes load_module() return error correctly in that case. Cc: Greg Kroah-Hartman [EMAIL PROTECTED] Cc: Rusty Russell [EMAIL PROTECTED] Signed-off-by: Akinobu Mita [EMAIL

[PATCH] update sb-s_frozen when freezing read-only mounted device, too

2007-09-29 Thread Akinobu Mita
freeze_bdev() with the device which is mounted as read only does not change sb-s_frozen from SB_UNFROZEN to SB_FREEZE_TRANS. Because of this behavior, xfs_freeze can break read-only XFS filesystem. Because xfs_thaw does nothing for the filesystem whose sb-s_frozen is SB_UNFROZEN. So freezed

Re: [PATCH 2.6.23-rc4][reRESEND] i2c-i801: SMBus patch for Intel Tolapai

2007-09-29 Thread Jean Delvare
Hi Jason, On Fri, 28 Sep 2007 15:09:16 -0700, Gaston, Jason D wrote: The pci_ids.h file is updated in 2.6.23-rc8. Can you push this i2c-i801.c patch? This patch has been in -mm since 2.6.23-rc7-mm1. It will go into Linus' tree shortly after 2.6.23 is released. This is not a bug fix, so I

[PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Jean Delvare
Remove a not particularly relevant rule from CodingStyle. Sometimes, printing numbers in parentheses doesn't add value, but in some (most?) cases it makes the message easier to read. As a matter of fact, this practice is widely used in the kernel: linux-2.6.23-rc8$ quilt grep -I '(%l*[du])' | wc

Re: Write-back from inside FS - need suggestions

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 12:56:55 +0300 Artem Bityutskiy [EMAIL PROTECTED] wrote: Andrew Morton wrote: This is precisely the problem which needs to be solved for delayed allocation on ext2/3/4. This is because it is infeasible to work out how much disk space an ext2 pagecache page will take to

Re: Write-back from inside FS - need suggestions

2007-09-29 Thread Artem Bityutskiy
Andrew Morton wrote: I'd have thought that a suitable wrapper around a suitably-modified sync_sb_inodes() would be appropriate for both filesystems? Hmm, OK, I'll try to do this. Thanks. -- Best Regards, Artem Bityutskiy (Артём Битюцкий) - To unsubscribe from this list: send the line

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 12:25:30 +0200 Jean Delvare [EMAIL PROTECTED] wrote: Remove a not particularly relevant rule from CodingStyle. Sometimes, printing numbers in parentheses doesn't add value, but in some (most?) cases it makes the message easier to read. As a matter of fact, this practice is

Re: A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?)

2007-09-29 Thread Fengguang Wu
On Thu, Sep 27, 2007 at 11:32:36PM -0700, Chakri n wrote: Hi, In my testing, a unresponsive file system can hang all I/O in the system. This is not seen in 2.4. I started 20 threads doing I/O on a NFS share. They are just doing 4K writes in a loop. Now I stop NFS server hosting the NFS

Re: [PATCH] Add TV (RGB) support to Dreamcast PVR driver

2007-09-29 Thread Paul Mundt
On Fri, Sep 28, 2007 at 12:22:04PM +0100, Adrian McMenamin wrote: Add support for RGB output to the Dreamcast PVR2 frame buffer driver. Signed-off by Adrian McMenamin [EMAIL PROTECTED] Looks fine, I'll add it to my 2.6.24 queue, thanks. - To unsubscribe from this list: send the line

Re: [patch/backport] CFS scheduler, -v22, for v2.6.23-rc8, v2.6.22.8, v2.6.21.7, v2.6.20.20

2007-09-29 Thread Matthew
Hi Ingo everbody on the list, first of all: many thanks for developing this great scheduler (also: kudos to Con Kolivas for having developed SD CK-patchset) (this is my second mail to this list and I hope I'm doing everything right) I'm doing some backup during work right now: rsyncing my

Re: A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?)

2007-09-29 Thread Peter Zijlstra
On Sat, 2007-09-29 at 19:04 +0800, Fengguang Wu wrote: On Thu, Sep 27, 2007 at 11:32:36PM -0700, Chakri n wrote: Hi, In my testing, a unresponsive file system can hang all I/O in the system. This is not seen in 2.4. I started 20 threads doing I/O on a NFS share. They are just doing

[PATCH -mm] intel-iommu sg chaining support

2007-09-29 Thread FUJITA Tomonori
x86_64 defines ARCH_HAS_SG_CHAIN. So if IOMMU implementations don't support sg chaining, we will get data corruption. Signed-off-by: FUJITA Tomonori [EMAIL PROTECTED] --- drivers/pci/intel-iommu.c | 32 1 files changed, 16 insertions(+), 16 deletions(-) diff

Re: [sdhci] mmc0: unrecognised SCR structure version 1

2007-09-29 Thread Adam Wysocki
29.09.07 [EMAIL PROTECTED] napisał: If it's just this card, then I would have to conclude that it is indeed broken. You'd have to return it to the store and get a new one. If you say so - I will do it, and also try to borrow some other SD card (this is my only one) to test. I have posted

Re: A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?)

2007-09-29 Thread Fengguang Wu
On Sat, Sep 29, 2007 at 01:48:01PM +0200, Peter Zijlstra wrote: On Sat, 2007-09-29 at 19:04 +0800, Fengguang Wu wrote: On Thu, Sep 27, 2007 at 11:32:36PM -0700, Chakri n wrote: Hi, In my testing, a unresponsive file system can hang all I/O in the system. This is not seen in 2.4.

Re: [PATCH] libata drain fifo on stuck DRQ HSM violation

2007-09-29 Thread Mark Lord
Alan Cox wrote: Why 512 words ? Though I have queued Mark's patch to be applied, my gut feeling would lean towards a single DRQ block, rather than 512. Why not just work from the old IDE code. ata_altstatus(ap); - ata_chk_status(ap); + ata_drain_fifo(ap, qc);

Re: [patch] Combine path_put and path_put_conditional

2007-09-29 Thread Jan Blunck
On Fri, Sep 28, Andreas Gruenbacher wrote: The name path_put_conditional (formerly, dput_path) is a little unclear. Replace (path_put_conditional + path_put) with path_walk_put_both, put a pair of paths after a path_walk (see the kerneldoc). Hmm, I don't know. To put both the nd and path is

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Mark Lord
Wolfgang Erig wrote: On Sat, Sep 29, 2007 at 01:30:33AM -0700, H. Peter Anvin wrote: Wolfgang Erig wrote: Both are bad. Two different systems and two different bisections. I sent the last step of each. $ git bisect good Bisecting: 0 revisions left to test after this

Re: Network slowdown due to CFS

2007-09-29 Thread Nick Piggin
On Friday 28 September 2007 00:42, Jarek Poplawski wrote: On Thu, Sep 27, 2007 at 03:31:23PM +0200, Ingo Molnar wrote: * Jarek Poplawski [EMAIL PROTECTED] wrote: ... OK, but let's forget about fixing iperf. Probably I got this wrong, but I've thought this bad iperf patch was tested on

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-09-29 Thread Ilpo Järvinen
On Fri, 28 Sep 2007, Ilpo Järvinen wrote: On Fri, 28 Sep 2007, Cedric Le Goater wrote: I just found that warning in my logs. It seems that it's been happening since rc7-mm1 at least. WARNING: at /home/legoater/linux/2.6.23-rc8-mm2/net/ipv4/tcp_input.c:2314 tcp_fastretrans_alert()

Re: [RFC][PATCH] mm: couple rcu and memory reclaim

2007-09-29 Thread Nick Piggin
On Monday 24 September 2007 18:45, Peter Zijlstra wrote: Just an idea I had, it seems like a good idea to wait for RCU callbacks in reclaim so that we won't get all of memory stuck there. I think it would be much too aggressive (_especially_ with preemptible RCU, I would have thought?). And not

Re: Strange system hangs

2007-09-29 Thread Nick Piggin
On Friday 28 September 2007 18:42, Krzysztof Oledzki wrote: Hello, I am experiencing weird system hangs. Once about 2-5 weeks system freezes and stops accepting remote connections, so it is no longer possible to connect to most important services: smtp (postfix), www (squid) or even ssh.

Re: [15/17] SLUB: Support virtual fallback via SLAB_VFALLBACK

2007-09-29 Thread Nick Piggin
On Saturday 29 September 2007 19:27, Andrew Morton wrote: On Sat, 29 Sep 2007 11:14:02 +0200 Peter Zijlstra [EMAIL PROTECTED] wrote: oom-killings, or page allocation failures? The latter, one hopes. Linux version 2.6.23-rc4-mm1-dirty ([EMAIL PROTECTED]) (gcc version 4.1.2 (Ubuntu

Re: [15/17] SLUB: Support virtual fallback via SLAB_VFALLBACK

2007-09-29 Thread Nick Piggin
On Saturday 29 September 2007 04:41, Christoph Lameter wrote: On Fri, 28 Sep 2007, Peter Zijlstra wrote: memory got massively fragemented, as anti-frag gets easily defeated. setting min_free_kbytes to 12M does seem to solve it - it forces 2 max order blocks to stay available, so we don't

Re: [PATCH] writeback: remove unnecessary wait in throttle_vm_writeout()

2007-09-29 Thread Nick Piggin
On Saturday 29 September 2007 03:57, Mathieu Desnoyers wrote: Isn't the actual instrumentation present in the VM subsystem consisting mostly of event counters ? This kind of profiling provides limited help in following specific delays in the kernel. Martin Bligh's paper Linux Kernel Debugging

Re: [patch] x86: improved memory barrier implementation

2007-09-29 Thread Nick Piggin
On Fri, Sep 28, 2007 at 09:15:06AM -0700, Linus Torvalds wrote: On Fri, 28 Sep 2007, Alan Cox wrote: However - You've not shown the patch has any performance gain It would be nice to see this. Actually, in a userspace test I have (which actually does enough work to trigger out of

Re: [patch] x86: improved memory barrier implementation

2007-09-29 Thread Nick Piggin
On Fri, Sep 28, 2007 at 06:18:31PM +0100, Alan Cox wrote: on the broken ppro stores config option if you just tell me what should be there (again, remember that my patch isn't actually changing anything already there except for smp_rmb side). The PPro needs rmb to ensure a store doesn't

[rfc][patch] i386: remove comment about barriers

2007-09-29 Thread Nick Piggin
Hi, OK this was going to be a quick patch, but after sleeping on it, I think it deserves a better analysis... I can prove the comment is incorrect with a test program, but I'm not as sure about my thinking that leads me to call it also misleading. The comment being removed by this patch is

IT8716F SPI driver submission?

2007-09-29 Thread Carl-Daniel Hailfinger
Hi! I have written a rough code skeleton to be able to use the ITE IT8716F Super I/O chip as SPI host/master. The code works fine in userspace, but the Linux kernel SPI framework looks like it could save me from implementing full support for SPI flash clients/slaves. That's why I'd like to

Re: [PATCH] module: return error when mod_sysfs_init() failed

2007-09-29 Thread Rusty Russell
On Sat, 2007-09-29 at 19:06 +0900, Akinobu Mita wrote: load_module() returns zero when mod_sysfs_init() fails, then the module loading will succeed accidentally. This patch makes load_module() return error correctly in that case. Thanks, applied. Cheers, Rusty. - To unsubscribe from this

Re: x86-64 sporadic hang in 2.6.23rc7 and 2.6.22

2007-09-29 Thread Helge Hafting
Thomas Gleixner wrote: On Mon, 2007-09-24 at 23:08 +0200, Helge Hafting wrote: The two kernels mentioned hangs occationally. Typically when I compile something and pass the time by surfing the web. A few minutes and then I notice that the mouse (and everything else in X) stops. kbd LEDs

Re: [PATCH 1/3] CodingStyle updates

2007-09-29 Thread Shawn Bohrer
On Fri, Sep 28, 2007 at 05:32:00PM -0400, Erez Zadok wrote: 1. Updates chapter 13 (printing kernel messages) to expand on the use of pr_debug()/pr_info(), what to avoid, and how to hook your debug code with kernel.h. 2. New chapter 19, branch prediction optimizations, discusses the

Re: A unresponsive file system can hang all I/O in the system on linux-2.6.23-rc6 (dirty_thresh problem?)

2007-09-29 Thread Peter Zijlstra
On Sat, 2007-09-29 at 20:28 +0800, Fengguang Wu wrote: On Sat, Sep 29, 2007 at 01:48:01PM +0200, Peter Zijlstra wrote: On the patch itself, not sure if it would have been enough. As soon as there is a single dirty inode on the list one would get caught in the same problem as before.

Re: [PATCH] module: return error when mod_sysfs_init() failed

2007-09-29 Thread Greg KH
On Sat, Sep 29, 2007 at 07:06:53PM +0900, Akinobu Mita wrote: load_module() returns zero when mod_sysfs_init() fails, then the module loading will succeed accidentally. This patch makes load_module() return error correctly in that case. Cc: Greg Kroah-Hartman [EMAIL PROTECTED] Cc: Rusty

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-09-29 Thread Cedric Le Goater
Ilpo Järvinen wrote: On Fri, 28 Sep 2007, Ilpo Järvinen wrote: On Fri, 28 Sep 2007, Cedric Le Goater wrote: I just found that warning in my logs. It seems that it's been happening since rc7-mm1 at least. WARNING: at /home/legoater/linux/2.6.23-rc8-mm2/net/ipv4/tcp_input.c:2314

Re: [PATCH 05/12] mm: trylock_page

2007-09-29 Thread Peter Zijlstra
On Fri, 2007-09-28 at 13:11 +1000, Nick Piggin wrote: On Friday 28 September 2007 17:42, Peter Zijlstra wrote: Replace raw TestSetPageLocked() usage with trylock_page() I have such a thing queued too, for the lock bitops patches for when 2.6.24 opens, Andrew promises me :). I guess they

Chroot bug take 3

2007-09-29 Thread David Newall
/. I hope I haven't crossed the line between determined and annoying. I thought we were done, but now I find meat still on this bone. Posit a normal process having some filesystem root, and a current working directory (pwd) lying within that root subtree. When chroot is performed, pwd is

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Alexey Starikovskiy
Mark Lord wrote: Wolfgang Erig wrote: On Sat, Sep 29, 2007 at 01:30:33AM -0700, H. Peter Anvin wrote: Wolfgang Erig wrote: Both are bad. Two different systems and two different bisections. I sent the last step of each. $ git bisect good Bisecting: 0 revisions left to test after this

Re: 2.6.23-rc8-mm2

2007-09-29 Thread Greg KH
On Sat, Sep 29, 2007 at 05:37:29PM +0800, Dave Young wrote: Hi, The kernel report warnings about sysfs filename duplicate under rc8-mm1 and rc8-mm2. 1. cut NET: Registered protocol family 16 ACPI: bus type pci registered PCI: PCI BIOS revision 2.10 entry at 0xfb93e, last bus=3

Re: [PATCH] module: return error when mod_sysfs_init() failed

2007-09-29 Thread Akinobu Mita
2007/9/29, Greg KH [EMAIL PROTECTED]: Index: 2.6-git/kernel/module.c === --- 2.6-git.orig/kernel/module.c +++ 2.6-git/kernel/module.c @@ -1782,7 +1782,8 @@ static struct module *load_module(void _

Re: Strange system hangs

2007-09-29 Thread Krzysztof Oledzki
On Sat, 29 Sep 2007, Nick Piggin wrote: On Friday 28 September 2007 18:42, Krzysztof Oledzki wrote: Hello, I am experiencing weird system hangs. Once about 2-5 weeks system freezes and stops accepting remote connections, so it is no longer possible to connect to most important services:

Re: [PATCH 1/3] CodingStyle updates

2007-09-29 Thread Scott Preece
A couple of comments interspersed... On 9/28/07, Erez Zadok [EMAIL PROTECTED] wrote: ... There are a number of driver model diagnostic macros in linux/device.h which you should use to make sure messages are matched to the right device --- I think this which is non-restrictive, so it should

Re: [patch] x86: improved memory barrier implementation

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, Nick Piggin wrote: The non-temporal stores should be basically considered to be IO, not any normal memory operation. Maybe you're thinking of uncached / WC? Non-temporal stores to cacheable RAM apparently can go out of order too, and they are being used in the

Re: [rfc][patch] i386: remove comment about barriers

2007-09-29 Thread Linus Torvalds
On Sat, 29 Sep 2007, Nick Piggin wrote: OK this was going to be a quick patch, but after sleeping on it, I think it deserves a better analysis... I can prove the comment is incorrect with a test program, but I'm not as sure about my thinking that leads me to call it also misleading.

getting FUSD compiled with current kernels

2007-09-29 Thread Florian Schmidt
Hi, I'm trying to build FUSD [1] against current kernels [2.6.22]. I get errors [2]: I tried looking into it but not being a kernel hacker i must admit i didn't even find out where sysfs_dentry is defined (so i can make the type complete). Or whether this would even be the correct way to fix

Re: getting FUSD compiled with current kernels

2007-09-29 Thread Florian Schmidt
On Saturday 29 September 2007, Florian Schmidt wrote: Hi, I'm trying to build FUSD [1] against current kernels [2.6.22]. I get errors [2]: Oh i forgot to show the code snippets in question. I put them to the crresponding error below [matching line number is marked with [*]]: [2]

Re: getting FUSD compiled with current kernels

2007-09-29 Thread Florian Schmidt
On Saturday 29 September 2007, Florian Schmidt wrote: On Saturday 29 September 2007, Florian Schmidt wrote: Hi, I'm trying to build FUSD [1] against current kernels [2.6.22]. I get errors [2]: Oh i forgot to show the code snippets in question. I put them to the Oh and i also forget to

Re: [patch/backport] CFS scheduler, -v22, for v2.6.23-rc8, v2.6.22.8, v2.6.21.7, v2.6.20.20

2007-09-29 Thread Alejandro Riveira Fernández
El Fri, 28 Sep 2007 23:20:13 -0300 Henrique de Moraes Holschuh [EMAIL PROTECTED] escribió: On Fri, 28 Sep 2007, Alejandro Riveira Fernández wrote: I feel it better than 20.5 but the later is more stable. Let me explain. I patched a 2.6.22.9 kernel with both versions 22 and 20.5[1]. With

RE: [PATCH RFC] paravirt_ops: refactor struct paravirt_ops into smaller pv_*_ops

2007-09-29 Thread Nakajima, Jun
Jeremy Fitzhardinge wrote: Nakajima, Jun wrote: Yes. For the native, safe_halt is sti; hlt. The native_halt is just hlt. So the para_virt part of hlt could be moved to pv_cpu_ops, and the sti part stays in pv_irq_ops. By sti part, you mean the full sti; hlt sequence of safe_halt,

Re: [PATCH RFC] paravirt_ops: refactor struct paravirt_ops into smaller pv_*_ops

2007-09-29 Thread Jeremy Fitzhardinge
Nakajima, Jun wrote: To me such atomicity is provided by the sti instruction (i.e. the processor begins responding to external, maskable interrupts _after_ the next instruction is executed), and there is nothing special with that combination sti; hlt (you can also have like sti; ret, for

Re: 2.6.22.6 + oprofile oops

2007-09-29 Thread Sami Farin
On Sat, Sep 22, 2007 at 14:23:35 +0300, Sami Farin wrote: x86_64 SMP kernel v2.6.22.6 (not using callgraph). sometimes oprofile works for a longer time... but not this time. 2007-09-22 13:53:32.52723 1[ 3372.390188] Unable to handle kernel NULL pointer dereference at 0650

Re: [patch 0/2] suspend/resume regression fixes

2007-09-29 Thread Bill Davidsen
Mark Lord wrote: Linus Torvalds wrote: On Sat, 22 Sep 2007, Thomas Gleixner wrote: My final enlightment was, when I removed the ACPI processor module, which controls the lower idle C-states, right before resume; this worked fine all the time even without all the workaround hacks. I really

Bonnie++ with 1024k stripe SW/RAID5 causes kernel to goto D-state

2007-09-29 Thread Justin Piszcz
Kernel: 2.6.23-rc8 (older kernels do this as well) When running the following command: /usr/bin/time /usr/sbin/bonnie++ -d /x/test -s 16384 -m p34 -n 16:10:16:64 It hangs unless I increase various parameters md/raid such as the stripe_cache_size etc.. # ps auxww | grep D USER PID

Re: getting FUSD compiled with current kernels

2007-09-29 Thread Sam Ravnborg
On Sat, Sep 29, 2007 at 06:37:51PM +0200, Florian Schmidt wrote: On Saturday 29 September 2007, Florian Schmidt wrote: On Saturday 29 September 2007, Florian Schmidt wrote: Hi, I'm trying to build FUSD [1] against current kernels [2.6.22]. I get errors [2]: Oh i forgot to show

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
-Printing numbers in parentheses (%d) adds no value and should be avoided. I wonder how that got there. Well, the only place that numbers naturally appear wrapped in parenthesis is tables of credits and debits... as a debit, sort of a literal add no value situation. ;) Oh, and for

Re: [PATCH] module: return error when mod_sysfs_init() failed

2007-09-29 Thread Greg KH
On Sun, Sep 30, 2007 at 12:37:10AM +0900, Akinobu Mita wrote: 2007/9/29, Greg KH [EMAIL PROTECTED]: Index: 2.6-git/kernel/module.c === --- 2.6-git.orig/kernel/module.c +++ 2.6-git/kernel/module.c @@ -1782,7 +1782,8 @@

[PATCH] fix console change race exposed by CFS

2007-09-29 Thread Jan Luebbe
From: Jan Lübbe [EMAIL PROTECTED] The new behaviour of CFS exposes a race which occurs if a switch is requested when vt_mode.mode is VT_PROCESS. The process with vc-vt_pid is signaled before vc-vt_newvt is set. This causes the switch to fail when triggered by the monitoing process because the

2.6.23-rc8 - Hangcheck on resume from x2mem

2007-09-29 Thread Bill Davidsen
I find this in dmesg after resume from s2mem: Hangcheck: hangcheck value past margin! System: ASUS P5LD2-VM board, Intel 6600 CPU at 2.40 GHz (no o/c) 2GB RAM, 3x320GB SATA sw RAID-5. FC6 distribution, fully updated, suspend via system menu pulldown. Just in case this is of interest, the

Re: [PATCH 1/3] CodingStyle updates

2007-09-29 Thread Randy Dunlap
On Fri, 28 Sep 2007 17:32:00 -0400 Erez Zadok wrote: 1. Updates chapter 13 (printing kernel messages) to expand on the use of pr_debug()/pr_info(), what to avoid, and how to hook your debug code with kernel.h. Signed-off-by: Erez Zadok [EMAIL PROTECTED] ---

Re: [PATCH 1/1] Kernel compile bug in 2.6.22.6/7 {maybe more} ARM/StrongARM

2007-09-29 Thread Russell King
On Wed, Sep 26, 2007 at 04:53:14PM -0400, Dave Jones wrote: Following up on this from yesterday, Linus please revert the above cset. It doesn't seem to be necessary (it was added to fix a miscompile in 'make allnoconfig' which doesn't seem to be repeatable with it reverted) and actively breaks

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Wolfgang Erig
Hi Peter, On Sat, Sep 29, 2007 at 11:35:53AM +0200, Wolfgang Erig wrote: I start again with a fresh tree and better controlled experiments. now the result of bisection seems to be consistent. The last good commit is f2d98ae63dc64dedb00499289e13a50677f771f9 Linker script for the new x86 setup

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Linus Torvalds
On Fri, 28 Sep 2007, Erez Zadok wrote: Documentation/CodingStyle | 88 +- I'm not very happy with this. CodingStyle should be about the big issues, not about details. Yes, we've messed that up over the years, but let's not continue that. In

Re: [PATCH 1/3] CodingStyle updates

2007-09-29 Thread Sam Ravnborg
On Sat, Sep 29, 2007 at 11:01:29AM -0700, Randy Dunlap wrote: On Fri, 28 Sep 2007 17:32:00 -0400 Erez Zadok wrote: 1. Updates chapter 13 (printing kernel messages) to expand on the use of pr_debug()/pr_info(), what to avoid, and how to hook your debug code with kernel.h.

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 03:51:56 -0700 Andrew Morton wrote: On Sat, 29 Sep 2007 12:25:30 +0200 Jean Delvare [EMAIL PROTECTED] wrote: Remove a not particularly relevant rule from CodingStyle. Sometimes, printing numbers in parentheses doesn't add value, but in some (most?) cases it makes the

Re: Bonnie++ with 1024k stripe SW/RAID5 causes kernel to goto D-state

2007-09-29 Thread Chris Snook
Justin Piszcz wrote: Kernel: 2.6.23-rc8 (older kernels do this as well) When running the following command: /usr/bin/time /usr/sbin/bonnie++ -d /x/test -s 16384 -m p34 -n 16:10:16:64 It hangs unless I increase various parameters md/raid such as the stripe_cache_size etc.. # ps auxww |

2.6.22/realtek bug in hardware, any kernel work-around?

2007-09-29 Thread Justin Piszcz
Package: samba Version: 3.0.26a-1 Kernel: 2.6.22 samba 3.0.26a-1 performance 900 KiB/s, but FTP = 30-90 MiB/s Let me start out by saing this is an oddball problem: SAMBA: LINUX - WINDOWS = 900 KiB/s (varies between 100 - 900 KiB/s) WINDOWS - LINUX = 30-90 MiB/s (always) FTP: Either

Re: Versioning file system

2007-09-29 Thread Sorin Faibish
Interesting that you mention the multitude of file systems because I was very surprised to see NILFS being promoted in the latest Linux Magazine but no mention of the other more important file systems currently in work like UnionFS ChunkFS or ext4 so publisized. I can say I was disapointed of the

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread David Brownell
From [EMAIL PROTECTED] Sat Sep 29 11:40:17 2007 Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? Yet Another Subtle And Hard To Fix Source Of Bloat is not a plus. I'd kind of think a change like this should have some positive motivation. - To

Re: [rfc][patch] i386: remove comment about barriers

2007-09-29 Thread Davide Libenzi
On Sat, 29 Sep 2007, Nick Piggin wrote: [ This is true for x86's sfence/lfence, but raises a question about Linux's memory barriers. Does anybody expect that a sequence of smp_wmb and smp_rmb would ever provide a full smp_mb barrier? I've always assumed no, but I don't know if it is actually

Re: [15/17] SLUB: Support virtual fallback via SLAB_VFALLBACK

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 06:19:33 +1000 Nick Piggin [EMAIL PROTECTED] wrote: On Saturday 29 September 2007 19:27, Andrew Morton wrote: On Sat, 29 Sep 2007 11:14:02 +0200 Peter Zijlstra [EMAIL PROTECTED] wrote: oom-killings, or page allocation failures? The latter, one hopes. Linux

FW: [patch 01/02] vfs: variant symlinks

2007-09-29 Thread Schmidt, Kenneth P
On 9/28/07 11:22 AM, Jan Dittmer [EMAIL PROTECTED] wrote: Ken Schmidt wrote: Variant symlinks add the ability to embed variables in to the contents of symbolic links so their targets can change based on outside sources (user environment, uts, filesystems, etc.) Could you elaborate why

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Wolfgang Erig
Hi Peter, On Sat, Sep 29, 2007 at 08:07:21PM +0200, Wolfgang Erig wrote: Now I try the things written in http://marc.info/[EMAIL PROTECTED] I have dumped a memory region which is my understanding what you want to see. The difference between the good and the bad case is only the patch

Re: Out of memory management in embedded systems

2007-09-29 Thread Abhishek Sagar
On 9/29/07, Daniel Spång [EMAIL PROTECTED] wrote: An embedded system is NOT an ordinary system that happens to boot from flash. An embedded system requires intelligent design. We might be talking about slightly different systems. I agree that systems that are really embedded, in the classic

[FYI] 2.6.23-rc8-git3 misc observations

2007-09-29 Thread Bill Davidsen
Running FC6 (updated this am) the temp sensors GNOME applet works with the kernel.org kernel, not the FC6 kernel. This has been true for a while, and I've stopped chasing it, I don't really care right now, since the sensors command works fine and that's what my daemon checks. Using 2.6.23-rc8

Re: Write-back from inside FS - need suggestions

2007-09-29 Thread Artem Bityutskiy
Andrew Morton wrote: I'd have thought that a suitable wrapper around a suitably-modified sync_sb_inodes() would be appropriate for both filesystems? Ok, I've modified sync_inodes_sb() so that I can pass it my own wbc, where I set wcb-nr_to_write = 20. It gives me _exactly_ what I want. It just

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread J. Bruce Fields
On Sat, Sep 29, 2007 at 11:18:05AM -0700, Linus Torvalds wrote: I'm not very happy with this. CodingStyle should be about the big issues, not about details. Yes, we've messed that up over the years, but let's not continue that. In other words, I'd suggest *removing* lines from

Re: Write-back from inside FS - need suggestions

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 22:10:42 +0300 Artem Bityutskiy [EMAIL PROTECTED] wrote: Andrew Morton wrote: I'd have thought that a suitable wrapper around a suitably-modified sync_sb_inodes() would be appropriate for both filesystems? Ok, I've modified sync_inodes_sb() so that I can pass it my own

Re: [2.6.23-rc8-mm2] System hangs (loops?) during boot

2007-09-29 Thread Andrew Morton
On Sat, 29 Sep 2007 21:40:22 +0200 Frans Pop [EMAIL PROTECTED] wrote: On Saturday 29 September 2007, you wrote: On Sat, 29 Sep 2007 02:32:44 +0200 Frans Pop [EMAIL PROTECTED] wrote: On Friday 28 September 2007, Frans Pop wrote: My Toshiba Satellite A40 (i386, P4 Mobile) hangs during

[PATCH 4/4] hpt366: MWDMA filter for SATA cards (take 2)

2007-09-29 Thread Sergei Shtylyov
The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in their so-called drivers :-), so the driver needs to account for this -- to achieve this: - add mdma_filter() method from the original patch by Bartlomiej Zolnierkewicz

[RFC] Extending kbuild syntax

2007-09-29 Thread Sam Ravnborg
Over the last few weeks I have pondered with the idea to extend the current kbuild syntax. The idea have existed for long but only recently I started to think how to do this in a truely flexible manner. Two areas are in need for a bit of attention to improve current kbuild files in the kernel.

Re: [PATCH] 0/3 coding standards documentation/code updates

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 15:56:38 -0400 J. Bruce Fields wrote: On Sat, Sep 29, 2007 at 11:18:05AM -0700, Linus Torvalds wrote: I'm not very happy with this. CodingStyle should be about the big issues, not about details. Yes, we've messed that up over the years, but let's not continue that.

Re: [PATCH] CodingStyle: Printing numbers in parentheses is fine

2007-09-29 Thread Randy Dunlap
On Sat, 29 Sep 2007 11:53:06 -0700 David Brownell wrote: From [EMAIL PROTECTED] Sat Sep 29 11:40:17 2007 Let's kill it, please. (i.e., ACK) But ... why? What value could needless parens provide? Who says that needless parens could provide value? Yet Another Subtle And Hard To Fix

[OT] kbuild syntax extension for ccflags and asflags (was: [PATCH 1/3] CodingStyle updates)

2007-09-29 Thread Ingo Oeser
Hi Sam, On Saturday 29 September 2007, Sam Ravnborg wrote: Lately I have considered extending the kbuild syntax a bit. Introducing ccflags-y asflags-y [with same functionality as the EXTRA_CFLAGS, EXTRA_AFLAGS] would allow us to do: ccflags-$(CONFIG_WHATEVER_DEBUG) := -DDEBUG Please

Re: [OT] kbuild syntax extension for ccflags and asflags (was: [PATCH 1/3] CodingStyle updates)

2007-09-29 Thread Sam Ravnborg
Lately I have considered extending the kbuild syntax a bit. Introducing ccflags-y asflags-y [with same functionality as the EXTRA_CFLAGS, EXTRA_AFLAGS] would allow us to do: ccflags-$(CONFIG_WHATEVER_DEBUG) := -DDEBUG Please do! That is very useful for testing and

Re: FW: [patch 01/02] vfs: variant symlinks

2007-09-29 Thread Al Viro
On Sat, Sep 29, 2007 at 12:40:23PM -0700, Schmidt, Kenneth P wrote: The best example of how this can be useful is to allow a heterogeneous environment which uses a common filesystem. For example, both x86_64 and power systems could mount a root nfs share and execute with a common set of

Re: [spi-devel-general] IT8716F SPI driver submission?

2007-09-29 Thread David Brownell
The IT8716F accepts commands byte-wise and does all of the lifting on the SPI bus as well. There are limitations, though: - It can send 1,2,4,5 bytes (including command byte) to the slave and read 0,1,2,3 bytes back. Other values are not possible. - Bus clock rate is either 33 MHz or 16.5

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Bill Davidsen
Alexey Starikovskiy wrote: -static void -acpi_power_off (void) -{ - printk(%s called\n,__FUNCTION__); - /* Some SMP machines only can poweroff in boot CPU */ - set_cpus_allowed(current, cpumask_of_cpu(0)); ACPI in kernel 2.6.12 did disable non-boot cpus too in powe_off. Later

Re: 2.6.23-rc8-mm2 - tcp_fastretrans_alert() WARNING

2007-09-29 Thread Ilpo Järvinen
On Sat, 29 Sep 2007, Cedric Le Goater wrote: Ilpo Järvinen wrote: On Fri, 28 Sep 2007, Ilpo Järvinen wrote: On Fri, 28 Sep 2007, Cedric Le Goater wrote: I just found that warning in my logs. It seems that it's been happening since rc7-mm1 at least. WARNING: at

Re: regression in 2.6.23-rc8 - power off failed

2007-09-29 Thread Rafael J. Wysocki
On Saturday, 29 September 2007 22:47, Bill Davidsen wrote: Alexey Starikovskiy wrote: -static void -acpi_power_off (void) -{ - printk(%s called\n,__FUNCTION__); - /* Some SMP machines only can poweroff in boot CPU */ - set_cpus_allowed(current, cpumask_of_cpu(0));

<    1   2   3   4   >