Andrew Morton skrev:
> On Wed, 10 Oct 2007 10:28:45 +0200 (CEST)
> [EMAIL PROTECTED] wrote:
>
>> I get this on brand new hardware, 2xHitachi Deathstar 320gb SATA2
>> (sata_via driver)
Sep 28 04:32:40 locker ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0
action 0x2 frozen
Sep 28 04:32:40 locker
Mike Galbraith wrote:
> On Fri, 2007-10-12 at 23:31 +0200, Sam Ravnborg wrote:
>> On Fri, Oct 12, 2007 at 06:48:58AM +0200, Mike Galbraith wrote:
>>> Greetings,
>>>
>>> Freshly pulled 2.6.23.git failed to build:
>>>
>>> make[1]: *** No rule to make target `arch/x86/kernel/asm-offsets.c', needed
Greetings,
Perhaps my .config is dainbramaged. When make oldconfig asked me if I
wanted CONFIG_PATA_PLATFORM, I said "Damned if I know, go for it".
drivers/ide/legacy/ide_platform.c: .name = "pata_platform",
drivers/ata/pata_platform.c:#define DRV_NAME "pata_platform"
[
On Fri, 12 Oct 2007 23:00:27 +0200 Pierre Ossman wrote:
> Ok, let's see if we can finally sort this out.
>
> Please pull/cherry-pick from:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/drzeus/mmc.git for-linus
>
> to receive the following update:
>
> drivers/mmc/core/host.c |
Jan Engelhardt skrev:
> On Oct 12 2007 18:25, Renato S. Yamane wrote:
>> "IP Innovation LLC has just filed a patent infringement claim against Red Hat
>> and Novell. It was filed October 9, case no. 2:2007cv00447, IP Innovation,
>> LLC
>> et al v. Red Hat Inc. et al, in Texas":
>
> I think the
Gustavo Chain wrote:
> Al Boldi <[EMAIL PROTECTED]> escribió:
> > Kyle Moffett wrote:
> > > On Oct 12, 2007, at 01:37:23, Al Boldi wrote:
> > > > You have a point, and resource-controllers can probably control
> > > > DoS a lot better, but the they also incur more overhead. Think
> > > > of this
> On Fri, 12 Oct 2007, Yasunori Goto wrote:
>
> > > > + down_read(_lock);
> > > > + list_for_each_entry(s, _caches, list) {
> > > > + local_node = page_to_nid(virt_to_page(s));
> > > > + if (local_node == offline_node)
> > > > + /*
Jarek Poplawski wrote:
On 12-10-2007 00:23, Peter Williams wrote:
...
The reason I was going that route was for modularity (which helps when
adding plugsched patches). I'll submit a revised patch for consideration.
...
IMHO, it looks like modularity could suck here:
+static unsigned int
Hi Andrew,
Another build failure with following message
CC drivers/scsi/advansys.o
drivers/scsi/advansys.c:71:2: warning: #warning this driver is still not
properly converted to the DMA API
drivers/scsi/advansys.c: In function ‘AdvBuildCarrierFreelist’:
drivers/scsi/advansys.c:6486:
Hi Andrew,
The build fails with following message
CC drivers/net/ibm_newemac/zmii.o
CC drivers/net/ibm_newemac/rgmii.o
drivers/net/ibm_newemac/rgmii.c: In function ‘rgmii_probe’:
drivers/net/ibm_newemac/rgmii.c:254: error: implicit declaration of
function ‘device_is_compatible’
make[3]: ***
From: Randy Dunlap <[EMAIL PROTECTED]>
Fix docbook templates for new x86 path/filenames:
docproc: linux-2.6.23-git2/include/asm-i386/mca_dma.h: No such file or directory
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
Documentation/DocBook/mcabook.tmpl |2 +-
1 file changed, 1
From: Randy Dunlap <[EMAIL PROTECTED]>
Fix docbook templates for new x86 path/filenames:
docproc: linux-2.6.23-git2/include/asm-i386/io.h: No such file or directory
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
Documentation/DocBook/deviceiobook.tmpl |2 +-
1 file changed, 1
From: Randy Dunlap <[EMAIL PROTECTED]>
Fix networking code kernel-doc for newly added parameters.
Warning(linux-2.6.23-git2//net/core/sock.c:879): No description found for
parameter 'net'
Warning(linux-2.6.23-git2//net/core/dev.c:570): No description found for
parameter 'net'
From: Randy Dunlap <[EMAIL PROTECTED]>
Fix docbook templates for modified x86 path/filenames.
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
Documentation/DocBook/kernel-hacking.tmpl |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
From: Randy Dunlap <[EMAIL PROTECTED]>
Fix docbook templates for new x86 path/filenames.
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
Documentation/DocBook/kernel-api.tmpl | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
---
Please pull from:
master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh-2.6.git
Which contains:
Adrian McMenamin (4):
fb: pvr2fb: Shared IRQ for dreamcast pvr2.
sh: Add maple bus support for the SEGA Dreamcast.
video: pvr2fb: Add TV (RGB) support to Dreamcast PVR
Please pull from:
master.kernel.org:/pub/scm/linux/kernel/git/lethal/sh64-2.6.git
Which contains:
Paul Mundt (18):
sh64: Move *_p() I/O routine variants to io.h.
sh64: Tidy up includes for Cayman board.
sh64: Kill off dead ROM-RAM and generic boards.
sh64: Kill
On Fri, 2007-10-12 at 14:40 +0200, Jan Blunck wrote:
> This is with 2.6.23-mm1 and allmodconfig.
>
> Seems that se in the following is a NULL pointer.
>
> 453 static void check_spread(struct cfs_rq *cfs_rq, struct
> sched_entity *se)
> 454 {
> 455 #ifdef CONFIG_SCHED_DEBUG
> 456
On Fri, 2007-10-12 at 23:31 +0200, Sam Ravnborg wrote:
> On Fri, Oct 12, 2007 at 06:48:58AM +0200, Mike Galbraith wrote:
> > Greetings,
> >
> > Freshly pulled 2.6.23.git failed to build:
> >
> > make[1]: *** No rule to make target `arch/x86/kernel/asm-offsets.c', needed
> > by
Fix DMI const-ification fallout that appeared when merging subsystem
trees.
Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]>
---
arch/x86/pci/acpi.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/pci/acpi.c b/arch/x86/pci/acpi.c
index 27a391d..2d88f7c 100644
---
Since the x86 merge, lots of files that referenced their own filenames
are no longer correct. Rather than keep them up to date, just delete
them, as they add no real value.
Additionally:
- fix up comment formatting in scx200_32.c
- Remove a credit from myself in setup_64.c from a time when we
On Friday 12 October 2007, Jeff Garzik wrote:
>
> [ I just sent this upstream to Andrew and Linus ]
>
> Now that I have nailed down the corruption problem, I can attend to
> this... Fun stuff:
>
> * port multiplier support (like an ethernet hub, only dumber)
Great to see this here.
> *
El Fri, 12 Oct 2007 09:29:10 +0300
Al Boldi <[EMAIL PROTECTED]> escribió:
> Kyle Moffett wrote:
> > On Oct 12, 2007, at 01:37:23, Al Boldi wrote:
> > > You have a point, and resource-controllers can probably control
> > > DoS a lot better, but the they also incur more overhead. Think
> > > of
On Sat, Oct 13, 2007 at 11:11:31AM +1000, Nigel Cunningham wrote:
> Hi all.
>
> Maybe I just picked a bad time to try, but...
>
> arch/x86/kernel/alternative.c: In function 'apply_alternatives':
> arch/x86/kernel/alternative.c:191: error: 'VSYSCALL_START' undeclared (first
> use in this
Dave Jones wrote:
I never really understood the motivation behind putting the filename
in a comment, but this fixes up a bunch of them that are now wrong
post-merge.
Presumably it is there just in case you print them out with lpr instead
of enscript, or if your editor doesn't tell you the
Hi all.
Maybe I just picked a bad time to try, but...
arch/x86/kernel/alternative.c: In function 'apply_alternatives':
arch/x86/kernel/alternative.c:191: error: 'VSYSCALL_START' undeclared (first
use in this function)
arch/x86/kernel/alternative.c:191: error: (Each undeclared identifier is
On Thu, 11 Oct 2007 18:17:19 -0700 (PDT)
David Miller <[EMAIL PROTECTED]> wrote:
> From: Roland Dreier <[EMAIL PROTECTED]>
> Date: Thu, 11 Oct 2007 18:08:52 -0700
>
> > This will get the batch of changes queued up for the 2.6.24 merge
> > window (although I still have a few more things to merge
On Fri, 12 Oct 2007 15:47:59 -0400
Mathieu Desnoyers <[EMAIL PROTECTED]> wrote:
> Hi Andrew,
>
> I noticed a regression between 2.6.23-rc8-mm2 and 2.6.23-mm1 (with your
> hotfixes). User space threads seems to receive a ERESTART_RESTARTBLOCK
> as soon as a thread does a pthread_join on them. The
Hi Hinko,
On Fri, Oct 12, 2007 at 02:36:46PM +0200, [EMAIL PROTECTED] wrote:
> Hi,
>
> While testing the mcs7780 based IrDA USB dongle I've stumbled upon
> memory leak in mcs_net_close(). Patch below fixes it.
Thanks for the fix. Applied to my local git, will push forward.
Cheers,
Samuel.
>
On Fri, Oct 12, 2007 at 05:49:50PM -0700, Andrew Morton wrote:
> On Fri, 12 Oct 2007 20:43:32 -0400
> Dave Jones <[EMAIL PROTECTED]> wrote:
>
> > I never really understood the motivation behind putting the filename
> > in a comment, but this fixes up a bunch of them that are now wrong
> >
On Fri, 12 Oct 2007, Andrew Morton wrote:
> On Fri, 12 Oct 2007 20:43:32 -0400
> Dave Jones <[EMAIL PROTECTED]> wrote:
>
> > I never really understood the motivation behind putting the filename
> > in a comment, but this fixes up a bunch of them that are now wrong
> > post-merge.
>
> Let's
On Wed, 10 Oct 2007 15:17:19 -0400
"Greg Cormier" <[EMAIL PROTECTED]> wrote:
> I'd like to hop in on this, and add my similar problem. This is my
> first post so please excuse me if I'm doing something wrong.
Please cc [EMAIL PROTECTED] on ide, sata and pata reports.
A "hard freeze" is fairly
On Fri, 12 Oct 2007 20:43:32 -0400
Dave Jones <[EMAIL PROTECTED]> wrote:
> I never really understood the motivation behind putting the filename
> in a comment, but this fixes up a bunch of them that are now wrong
> post-merge.
Let's just delete them.
-
To unsubscribe from this list: send the
I never really understood the motivation behind putting the filename
in a comment, but this fixes up a bunch of them that are now wrong
post-merge.
Signed-off-by: Dave Jones <[EMAIL PROTECTED]>
diff --git a/arch/x86/kernel/bugs_64.c b/arch/x86/kernel/bugs_64.c
index 4e5e9d3..45aa435 100644
---
On Wed, 10 Oct 2007 21:03:43 +0200
Luca Tettamanti <[EMAIL PROTECTED]> wrote:
> Hello,
> sometimes kernel complains about spurious completions on my new
> notebook:
>
> ata3.00: exception Emask 0x2 SAct 0x407fd SErr 0x0 action 0x2 frozen
> ata3.00: spurious completions during NCQ issue=0x0
On Wed, 10 Oct 2007 10:28:45 +0200 (CEST)
[EMAIL PROTECTED] wrote:
> I get this on brand new hardware, 2xHitachi Deathstar 320gb SATA2
> (sata_via driver)
>
> I get this a lot, the disk makes some sound after heavy IO and then the
> system hangs for a few seconds, then this comes up:
>
>
The current code runs the balance_rt_tasks() on every _schedule()
once the system enters an overload state. Now that we have better
distribution on the push side, we can reduce the conditions that
require us to pull tasks. They are as follows:
At the time of a _schedule(), if our priority is
On Fri, 12 Oct 2007, Dave Jones wrote:
>
> $ git log --follow arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
> fatal: ambiguous argument 'arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c':
> unknown revision or path not in the working tree.
> Use '--' to separate paths from revisions
Duh. You need to
In theory, tasks will be most efficient if they are allowed to re-wake to
the CPU that they last ran on due to cache affinity. Short of that, it is
cheaper to wake up the current CPU. If neither of those two are options,
than the lowest CPU will do.
Signed-off-by: Gregory Haskins <[EMAIL
On Tue, Oct 09, 2007 at 08:00:44AM -0400, Mark M. Hoffman wrote:
> Sorry it took me so long to get back to this. I've applied this to my hwmon
> testing branch, but I would still like to get a review from an IPMI expert.
I'm working on finding somebody to do that.
> OBTW: please try to send
There are three events that require consideration for redistributing RT
tasks:
1) When one or more higher-priority tasks preempts a lower-one from a
RQ
2) When a lower-priority task is woken up on a RQ
3) When a RQ downgrades its current priority
Steve Rostedt's push_rt patch addresses (1).
Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]>
---
kernel/sched.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 50c88e8..62f9f0b 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -4663,6 +4663,7 @@ void
The system currently evaluates all online CPUs whenever one or more enters
an rt_overload condition. This suffers from scalability limitations as
the # of online CPUs increases. So we introduce a cpumask to track
exactly which CPUs need RT balancing.
Signed-off-by: Gregory Haskins <[EMAIL
A little cleanup to avoid #ifdef proliferation later in the series
Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]>
---
kernel/sched.c | 23 ---
1 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 0a1ad0e..c9afc8a 100644
Signed-off-by: Gregory Haskins <[EMAIL PROTECTED]>
---
kernel/sched.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index c9afc8a..50c88e8 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -7395,6 +7395,8 @@ void __init
This series applies to 2.6.23-rt1 + Steven Rostedt's last published "push-rt"
patch.
Changes since v1:
- Rebased to the final 23-rt1 from 23-rt1-pre1
- Rebased to Steve's last published patch
- Removed controversial "cpupri" algorithm (may revisit later, drop for now)
- Fixed a missing priority
On Fri, Oct 12, 2007 at 08:11:53PM -0400, Dave Jones wrote:
> On Fri, Oct 12, 2007 at 04:14:54PM -0700, Linus Torvalds wrote:
> >
> >
> > On Fri, 12 Oct 2007, Dave Jones wrote:
> > >
> > > Something I find useful is to just do for eg..
> > >
> > > git log
On Fri, Oct 12, 2007 at 04:14:54PM -0700, Linus Torvalds wrote:
>
>
> On Fri, 12 Oct 2007, Dave Jones wrote:
> >
> > Something I find useful is to just do for eg..
> >
> > git log arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
> >
> > from time to time, to figure out when certain changes
You should run "git-update-server-info" in
pub/scm/linux/kernel/git/jgarzik/libata-dev.git.
info/refs disagrees with refs/heads/* .
Luben
--- Jeff Garzik <[EMAIL PROTECTED]> wrote:
>
> [ I just sent this upstream to Andrew and Linus ]
>
> Now that I have nailed down the corruption
On Fri, Oct 12, 2007 at 04:51:00PM -0700, Philip Langdale wrote:
> The hiddev driver currently lacks 32bit ioctl compatibility, so
> if you're running with a 64bit kernel and 32bit userspace, it won't
> work.
>
> I'm pretty sure that the only thing missing is a compat_ioctl
> implementation as
The hiddev driver currently lacks 32bit ioctl compatibility, so
if you're running with a 64bit kernel and 32bit userspace, it won't
work.
I'm pretty sure that the only thing missing is a compat_ioctl
implementation as all structs have fixed size fields.
With this change I can use revoco to
Jan Engelhardt wrote:
On Oct 12 2007 15:57, Randy Dunlap wrote:
On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote:
warning("override: %s turns state choice", sym->name);
What does that warning message mean? I can't decipher it.
It is when the value of a "choice" kconfig
On Oct 12 2007 15:57, Randy Dunlap wrote:
>On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote:
>
>> warning("override: %s turns state choice", sym->name);
>
>What does that warning message mean? I can't decipher it.
It is when the value of a "choice" kconfig object is changed, for
On Sat, 13 Oct 2007 00:25:15 +0200 Sebastian Siewior wrote:
> drivers/mmc/core/host.c: In function 'mmc_remove_host':
> drivers/mmc/core/host.c:146: error: implicit declaration of function
> 'led_trigger_unregister'
> drivers/mmc/core/host.c:146: error: 'struct mmc_host' has no member named
>
On Fri, 12 Oct 2007, Dave Jones wrote:
>
> Something I find useful is to just do for eg..
>
> git log arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
>
> from time to time, to figure out when certain changes happened,
> or even to grep for something in a changelog.
> With that file moved, git
Al Boldi wrote:
Patrick McHardy wrote:
The netlink based iptables successor I'm currently working on allows to
dynamically create tables with user-specified priorities and "built-in"
chains. The only built-in tables will be those that need extra
processing (mangle/nat). So it should be
On Fri, 12 Oct 2007 23:44:08 +0200 (CEST) Jan Engelhardt wrote:
> Allow config variables in .config to override earlier ones in the same
> file. In other words,
>
> # CONFIG_SECURITY is not defined
> CONFIG_SECURITY=y
>
> will activate it. This makes it a bit easier to do
>
>
Patrick McHardy wrote:
> Al Boldi wrote:
> > But can you see how forcing people into splitting
> > their rules across tables adds complexity. And without ipt_REJECT
> > patch, they can't even use REJECT in prerouting, which forces them to do
> > some strange hacks.
> >
> > IMHO, we should make
Patrick McHardy wrote:
> Jan Engelhardt wrote:
> > On Oct 12 2007 16:30, Al Boldi wrote:
> With the existence of the mangle table, how useful is the filter
> table?
> >>>
> >>>A similar discussion was back in March 2007.
> >>>http://marc.info/?l=netfilter-devel=117394977210823=2
>
This fix corrects the problem that early_identify_cpu() sets
cpu_index to '0' (needed when called by setup_arch) after
smp_store_cpu_info() had set it to the correct value.
Thanks to Suresh for discovering this problem.
--
-
To unsubscribe from this list: send the line "unsubscribe
This fix corrects the problem that early_identify_cpu() sets
cpu_index to '0' (needed when called by setup_arch) after
smp_store_cpu_info() had set it to the correct value.
Signed-off-by: Mike Travis <[EMAIL PROTECTED]>
---
arch/x86_64/kernel/smpboot.c |2 +-
1 file changed, 1 insertion(+),
On Fri, Oct 12, 2007 at 03:43:46PM -0700, Linus Torvalds wrote:
>
>
> On Fri, 12 Oct 2007, Dave Jones wrote:
> >
> > pull req below. If it turns out to be more trouble than its worth,
>
> It merged totally automatically, no trouble what-so-ever:
>
> Renamed
On Fri, 12 Oct 2007, Dave Jones wrote:
>
> pull req below. If it turns out to be more trouble than its worth,
It merged totally automatically, no trouble what-so-ever:
Renamed arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c =>
arch/x86/kernel/cpu/cpufreq/acpi-cpufreq.c
On Fri, Oct 12, 2007 at 03:20:50PM -0700, David Miller wrote:
> From: Greg KH <[EMAIL PROTECTED]>
> Date: Fri, 12 Oct 2007 15:12:45 -0700
>
> > Alan Stern (44):
> ...
> > USB: mutual exclusion for EHCI init and port resets
>
> Greg, if you haven't already, please consider queueing
> this
drivers/mmc/core/host.c: In function 'mmc_remove_host':
drivers/mmc/core/host.c:146: error: implicit declaration of function
'led_trigger_unregister'
drivers/mmc/core/host.c:146: error: 'struct mmc_host' has no member named 'led'
Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]>
---
From: Alan Stern <[EMAIL PROTECTED]>
This patch (as993) merges the suspend.c and resume.c files in
drivers/base/power into main.c, making some public symbols private.
Signed-off-by: Alan Stern <[EMAIL PROTECTED]>
Acked-by: Rafael J. Wysocki <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman
From: Tejun Heo <[EMAIL PROTECTED]>
Sysfs has gone through considerable amount of reimplementation. Add
copyrights. Any objections? :-)
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
fs/sysfs/bin.c|8 +++-
fs/sysfs/dir.c
I've been hacking on these files for a while now, might as well make it
official...
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
include/linux/kobject.h |6 --
lib/kobject.c |2 ++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
include/linux/kobject.h | 33 +
1 files changed, 17 insertions(+), 16 deletions(-)
diff --git a/include/linux/kobject.h b/include/linux/kobject.h
index 05cc5b2..973aa7b 100644
---
This makes it a bit more sane when trying to figure out how to clean up
the ktype mess.
Based on a larger patch from Kay Sievers
Cc: Kay Sievers <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
drivers/firmware/edd.c |4 ++--
drivers/firmware/efivars.c |
This makes it a bit more sane when trying to figure out how to clean up
the ktype mess.
Based on a larger patch from Kay Sievers
Cc: Kay Sievers <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
drivers/base/bus.c |4 ++--
1 files changed, 2 insertions(+), 2
Here are a some PCI patches against your 2.6.23 git tree.
Nothing major here, just a number of bugfixes and updates and new
quirks. See the shortlog below for details.
All of these have been in the -mm tree for a while.
Please pull from:
This makes it a bit more sane when trying to figure out how to clean up
the ktype mess.
Based on a larger patch from Kay Sievers
Cc: Kay Sievers <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
drivers/base/core.c |6 +++---
1 files changed, 3 insertions(+), 3
This makes it a bit more sane when trying to figure out how to clean up
the ktype mess.
Based on a larger patch from Kay Sievers
Cc: Kay Sievers <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
drivers/base/class.c | 10 +-
1 files changed, 5
There is only one user of it, and it is only a wrapper for kset_init().
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
Documentation/kobject.txt |1 -
drivers/base/class.c |2 +-
include/linux/kobject.h |1 -
lib/kobject.c |5 -
4 files changed,
Hi,
I just wanted to voice my opinion about the static LSM changes.
(I apologize about being late[1] to the discussion[2] -- I'd only recently
become aware of it.) I'm personally really against this. For example,
I want to give people choice about their security protections in Ubuntu,
and I'd
From: Tejun Heo <[EMAIL PROTECTED]>
Sysfs file poll implementation is scattered over sysfs and kobject.
Event numbering is done in sysfs_dirent but wait itself is done on
kobject. This not only unecessarily bloats both kobject and
sysfs_dirent but is also buggy - if a sysfs_dirent is removed
From: Tejun Heo <[EMAIL PROTECTED]>
Implement sysfs_open_dirent which represents an open file (attribute)
sysfs_dirent. A file sysfs_dirent with one or more open files have
one sysfs_dirent and all sysfs_buffers (one for each open instance)
are linked to it.
sysfs_open_dirent doesn't actually
From: Tejun Heo <[EMAIL PROTECTED]>
sysfs_root is different from a regular directory dirent in that it's
of type SYSFS_ROOT and doesn't have a name. These differences aren't
used by anybody and only adds to complexity. Make sysfs_root a
regular directory dirent.
Signed-off-by: Tejun Heo
From: Tejun Heo <[EMAIL PROTECTED]>
Children list head is only meaninful for directory nodes. Move it
into s_dir. This doesn't save any space currently but it will with
further changes.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Acked-by: Cornelia Huck <[EMAIL PROTECTED]>
Signed-off-by: Greg
From: Tejun Heo <[EMAIL PROTECTED]>
sysfs_attach_dentry() now has only one caller and isn't doing much
other than obfuscating the code. Open code and kill it.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Acked-by: Cornelia Huck <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL
From: Tejun Heo <[EMAIL PROTECTED]>
Make s_elem an anonymous union. Prefixing with s_elem makes things
needlessly longer without any advantage.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Acked-by: Cornelia Huck <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
From: Tejun Heo <[EMAIL PROTECTED]>
In sysfs_release(), sysfs_buffer pointed to by filp->private_data is
guaranteed to exist. Kill the unnecessary NULL check. This also
makes the code more consistent with the counterpart in fs/sysfs/bin.c.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Acked-by:
From: Tejun Heo <[EMAIL PROTECTED]>
All bin attr operations require active references of itself and its
parent. There's no reason to allow open when its parent has been
deactivated and allowing it is inconsistent with regular sysfs file.
Use sysfs_get_active_two() in bin attribute open function.
From: Tejun Heo <[EMAIL PROTECTED]>
Move s_mode downward such that it's side-by-side with s_iattr which is
used for the same thing.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Acked-by: Cornelia Huck <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
fs/sysfs/sysfs.h
From: Tejun Heo <[EMAIL PROTECTED]>
There's no reason to get an extra reference to sysfs_dirent for an
open file. Open file has a reference to the dentry which in turn has
a reference to sysfs_dirent. This is fairly obvious as otherwise open
itself won't be able to access the sysfs_dirent.
From: Tejun Heo <[EMAIL PROTECTED]>
sysfs_update_file() depends on inode->i_mtime but sysfs iondes are now
reclaimable making the reported modification time unreliable. There's
only one user (pci hotplug) of this notification mechanism and it
reportedly isn't utilized from userland.
Kill
From: Tejun Heo <[EMAIL PROTECTED]>
sysfs is about to go through major overhaul making this a pretty good
opportunity to clean up (out-of-tree changes and pending patches will
need regeneration anyway). Clean up headers.
* Kill space between * and symbolname.
* Move SYSFS_* type constants and
From: Tejun Heo <[EMAIL PROTECTED]>
sysfs_chmod_file() looked and updated only inode of the target file.
Dentry and inode are reclaimable and the update mode data will go away
when the inode is reclaimed. This patch makes sysfs_chmod_file()
update sd->s_mode too such that the change is
From: Tejun Heo <[EMAIL PROTECTED]>
sysfs_add/remove_one() now link and unlink the target dirent into and
from the children list. Update comments accordingly.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Acked-by: Cornelia Huck <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL
We want to let people know when we create a duplicate sysfs file, as
they need to fix up their code.
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
fs/sysfs/dir.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/fs/sysfs/dir.c b/fs/sysfs/dir.c
index
From: Eric W. Biederman <[EMAIL PROTECTED]>
This patch rewrites sysfs_move_dir to perform it's checks
as much as possible on the underlying sysfs_dirents instead
of the contents of the dcache, making sysfs_move_dir
more like the rest of the sysfs directory modification
code.
Signed-off-by: Eric
From: Kay Sievers <[EMAIL PROTECTED]>
Signed-off-by: Kay Sievers <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]>
---
Documentation/kernel-parameters.txt |4
drivers/char/pty.c |9 +++--
include/linux/tty.h |1 -
3
From: Eric W. Biederman <[EMAIL PROTECTED]>
The only uses of s_dentry left are the code that maintains
s_dentry and trivial users that don't actually need it.
So this patch removes the s_dentry maintenance code and
restructures the trivial uses to use something else.
Signed-off-by: Eric W.
From: Eric W. Biederman <[EMAIL PROTECTED]>
This patch rewrites sysfs_rename_dir to perform it's checks
as much as possible on the underlying sysfs_dirents instead
of the contents of the dcache. It turns out that this version
is a little simpler, and a little more like the rest of
the sysfs
From: Tejun Heo <[EMAIL PROTECTED]>
Now that we know the sysfs tree structure cannot change under us and
sysfs shadow support is dropped, sysfs_get_dentry() can be simplified
greatly. It can just look up from the root and there's no need to
retry on failure.
Signed-off-by: Tejun Heo <[EMAIL
From: Eric W. Biederman <[EMAIL PROTECTED]>
Currently we find the dentry to drop by looking at sd->s_dentry.
We can just as easily accomplish the same task by looking up the
sysfs inode and finding all of the dentries from there, with the
added bonus that we don't need to play with the
From: Eric W. Biederman <[EMAIL PROTECTED]>
Looking carefully at the rename code we have a subtle dependency
that the structure of sysfs not change while we are performing
a rename. If the parent directory of the object we are renaming
changes while the rename is being performed nasty things
From: Eric W. Biederman <[EMAIL PROTECTED]>
At some point someone wrote sysfs_readdir to insert a cursor
into the list of sysfs_dirents to ensure that sysfs_readdir would
restart properly. That works but it is complex code and tends
to be expensive.
The same effect can be achieved by keeping
From: Eric W. Biederman <[EMAIL PROTECTED]>
This is a small cleanup patch that makes the code just
a little bit cleaner.
Signed-off-by: Eric W. Biederman <[EMAIL PROTECTED]>
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Cc: Cornelia Huck <[EMAIL PROTECTED]>
Signed-off-by: Greg Kroah-Hartman
1 - 100 of 1030 matches
Mail list logo
