Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Mel Gorman
On (15/11/07 02:39), Andrew Morton didst pronounce: > On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: > > > This patch is a fix for 2.6.24. > > > > Ordinarily the size of a pageblock is determined at compile-time based on > > the > > hugepage size. On PPC64, the

Re: 2.6.24-rc2-mm1 -- QLogics ISP1020 gone missing

2007-11-15 Thread Andy Whitcroft
All of our machines with QLogics ISP1020 cards seem to have lost them on boot with 2.6.24-rc1-mm1+hotfixes. # lspci :00:0a.0 SCSI storage controller: QLogic Corp. ISP1020 Fast-wide SCSI (rev 05) # lspci -n :00:0a.0 0100: 1077:1020 (rev 05) # lspci -v -v :00:0a.0 SCSI storage

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Thu, 15 Nov 2007 11:43:32 +0100 > The crash logs contain this: > > VFS: Mounted root (ext3 filesystem) readonly. > Freeing unused kernel memory: 396k freed > Write protecting the kernel read-only data: 2056k > udev: renamed network interface eth1

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Ingo Molnar
* David Miller <[EMAIL PROTECTED]> wrote: > From: Matt Mackall <[EMAIL PROTECTED]> > Date: Wed, 14 Nov 2007 17:37:13 -0600 > > > No, the usual strategy for debugging problems -outside- SLOB is to > > switch to another allocator with more extensive debugging facilities. > > Ok, so the thing we

[PATCH 2/2]: drivers/video: remove unnecessary pci_dev_put

2007-11-15 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> pci_get_class implicitly does a pci_dev_put on its second argument, so pci_dev_put is only needed if there is a break out of the loop. The semantic match detecting this problem is as follows: // @@ expression dev; expression E; @@ * pci_dev_put(dev)

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: > This patch is a fix for 2.6.24. > > Ordinarily the size of a pageblock is determined at compile-time based on the > hugepage size. On PPC64, the hugepage size is determined at runtime based on > what is supported by the

[PATCH 1/2]: drivers/char: remove unnecessary pci_dev_put

2007-11-15 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> pci_get_class implicitly does a pci_dev_put on its second argument, so pci_dev_put is only needed if there is a break out of the loop. The semantic match detecting this problem is as follows: // @@ expression dev; expression E; @@ * pci_dev_put(dev)

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [2/3] fix section mismatch in vmammap_allock_block

2007-11-15 Thread KAMEZAWA Hiroyuki
Fixes section mismatch below. WARNING: vmlinux.o(.text+0x946b5): Section mismatch: reference to .init.text:' __alloc_bootmem_node (between 'vmemmap_alloc_block' and 'vmemmap_pgd_populate') Changelog - changed bootmem alloc wrapper function's name to be __earlyonly_bootmem_alloc().

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: > This patch is a fix for 2.6.24. > > Ordinarily the size of a pageblock is determined at compile-time based on the > hugepage size. On PPC64, the hugepage size is determined at runtime based on > what is supported by the

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [3/3] fix section mismatch in init_memory_mapping

2007-11-15 Thread KAMEZAWA Hiroyuki
Changes __meminit to __init_refok. == WARNING: vmlinux.o(.text+0x1d07c): Section mismatch: reference to .init.text:find_e820_area (between 'init_memory_mapping' and 'arch_add_memory') == Changelog: * changes __init_refok from find_early_table_space() to init_memory_mapping(). Signed-off-by:

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [0/3]

2007-11-15 Thread KAMEZAWA Hiroyuki
memory hotplug fix against 2.6.23-rc2-mm1. Changelog - Divided into 3 patches - dropped patch against mm/sparse.c ( This was my misunderstanding.) - merged Andy's suggestion. All patches are related to memory hotplug. [1/3] ... export memory_add_physaddr_to_nid to acpi memory hotplug [2/3]

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [1/3] memory_add_physaddr_to_nid export for acpi memhotplug.ko

2007-11-15 Thread KAMEZAWA Hiroyuki
Fix following reference error (when CONFIG_ACPI_HOTPLUG_MEMORY=m) == ERROR: "memory_add_physaddr_to_nid" [drivers/acpi/acpi_memhotplug.ko] undefined! == Changelog: - EXPORT_SYMBOL to EXPORT_SYMBOL_GPL. Signed-off-by: KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> arch/x86/mm/srat_64.c |1 + 1

[PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Mel Gorman
This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is determined at runtime based on what is supported by the machine. With legacy machines such as iSeries that do not support hugepages,

Re: 2.6.24-rc2 panic: (non-exitent) NFS root f/s

2007-11-15 Thread Shane
On Wed, 2007-11-14 at 22:42 +0100, Rafael J. Wysocki wrote: > Perhaps it just can't find the root filesystem at all? Indeed - thanks for the input. My supposed "good" source config didn't match the running kernel. A "work in progress" I had obviously forgotten about. Apologies for having

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Nov 2007 09:39:15 + Andy Whitcroft <[EMAIL PROTECTED]> wrote: > Can you explain "this is bug" for me. The routine was __init_refok and > therefore ! __init and therefore always present. The logic there must > guarentee it only calls the bootmem allocator in early boot, and the

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-15 Thread Andy Whitcroft
When testing some of the later 2.6.24-rc2-mm1+hotfix combinations on three of our test systems one job from each batch (1/4) failed. In each case the machine appears to have booted normally all the way to a login: prompt. However in the failed boots the networking though apparently initialised

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Alexey Dobriyan
On Thu, Nov 15, 2007 at 01:44:46AM -0800, Andrew Morton wrote: > On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > > > Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 > > (1) and during 2.6.24 cycle (2): > > > > kernel_restart > >

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan <[EMAIL PROTECTED]> wrote: > Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 > (1) and during 2.6.24 cycle (2): > > kernel_restart > sys_reboot > [garbage] > Code: 8b 88 a8 00 00 00 85 c9 74 04 89 > EIP is

Re: tg3: strange errors and non-working-ness

2007-11-15 Thread Jarek Poplawski
On 13-11-2007 19:57, Jon Nelson wrote: > I'm not sure if this is the right place, Me too. Looks more like acpi or pci problem. Did you try to experiment with something like: pci=noacpi or acpi=off boot parameters? Probably some point to your .config and dmesg should be useful too, so taking it to

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread Andy Whitcroft
On Thu, Nov 15, 2007 at 01:29:19PM +0900, KAMEZAWA Hiroyuki wrote: > Fixes for memory hotplug compile and .section handling. > > This patch fixes following bugs > == > WARNING: vmlinux.o(.text+0x1d07c): Section mismatch: reference to .init.text:f > ind_e820_area (between 'init_memory_mapping' and

[PATCH] fs: remove dead config CONFIG_HAS_COMPAT_EPOLL_EVENT symbol

2007-11-15 Thread Jiri Olsa
remove dead config CONFIG_HAS_COMPAT_EPOLL_EVENT symbol Signed-off-by: Jiri Olsa <[EMAIL PROTECTED]> --- fs/compat.c| 49 include/linux/compat.h |8 --- 2 files changed, 0 insertions(+), 57 deletions(-) diff --git

Re: libata_uli puts second channel to PIO4 on 2.6.18

2007-11-15 Thread Patric Karlsson
Grzegorz Kulewski wrote: On Wed, 7 Feb 2007, Tejun Heo wrote: Grzegorz Kulewski wrote: It worked very well for half a year but with one disk (IIRC it was even plugged into second channel but I wont bet on it). Now I have second disk (very similar) and it is always put into PIO4 mode: [

Re: libata_uli puts second channel to PIO4 on 2.6.18

2007-11-15 Thread Patric Karlsson
Patric Karlsson wrote: Grzegorz Kulewski wrote: On Wed, 7 Feb 2007, Tejun Heo wrote: Grzegorz Kulewski wrote: It worked very well for half a year but with one disk (IIRC it was even plugged into second channel but I wont bet on it). Now I have second disk (very similar) and it is always

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Nov 2007 00:56:57 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > eek. > > What I now need to do with this patch is > > - Work out which patches in -mm it is actually fixing. > > - If that is more than one patch then split this patch up into multiple ones. > > - Stage the one or

EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Alexey Dobriyan
Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 (1) and during 2.6.24 cycle (2): kernel_restart sys_reboot [garbage] Code: 8b 88 a8 00 00 00 85 c9 74 04 89 EIP is at device_shutdown+0x32/0x60 which corresponds to the following place: c110659c :

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Haavard Skinnemoen
On Thu, 15 Nov 2007 00:20:33 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > > > - gpio_direction_input()/gpio_direction_output() implicitly > > > request the pins, if they weren't already requested. > > > > Eek, that's completely wrong. Allowing to access a resource _before_ > > it is

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread David Brownell
On Wednesday 14 November 2007, Nick Piggin wrote: > > > > All this does is prevent constant and needless checking for > > > > "do you want to preempt me now?" "now?" "now?" in "now?" the > > > > middle "now?" of "now?" i/o "now?" loops. > > > > > > Actually that's wrong. > > > > Certainly it's

Re: 2.6.24-rc2-mm1

2007-11-15 Thread Kay Sievers
On Thu, 2007-11-15 at 16:14 +0800, Dave Young wrote: > On Thu, Nov 15, 2007 at 03:38:13AM +0100, Kay Sievers wrote: > > On Thu, 2007-11-15 at 09:01 +0800, Dave Young wrote: > > > On Nov 15, 2007 5:27 AM, Kay Sievers <[EMAIL PROTECTED]> wrote: > > > > On Wed, 2007-11-14 at 20:19 +0100, Jiri Kosina

Re: [PATCH] drivers/ide/ide-probe.c, kernel 2.6.23.1

2007-11-15 Thread Jonas Stare
Hi, thanks for the reply. :) Bartlomiej Zolnierkiewicz wrote: Hi, On Monday 12 November 2007, Andrew Morton wrote: On Fri, 09 Nov 2007 11:22:41 +0100 Jonas Stare <[EMAIL PROTECTED]> wrote: Hi. This week I ran into a strange hardware problem. During boot I got a 35 second delay while

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 19:17, David Brownell wrote: > On Wednesday 14 November 2007, Nick Piggin wrote: > > > > > All this does is prevent constant and needless checking for > > > > > "do you want to preempt me now?" "now?" "now?" in "now?" the > > > > > middle "now?" of "now?" i/o "now?"

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 13:29:19 +0900 KAMEZAWA Hiroyuki <[EMAIL PROTECTED]> wrote: > Fixes for memory hotplug compile and .section handling. > > This patch fixes following bugs > == > WARNING: vmlinux.o(.text+0x1d07c): Section mismatch: reference to .init.text:f > ind_e820_area (between

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Stephane Eranian
Hello, On Wed, Nov 14, 2007 at 08:20:22PM -0800, dean gaudet wrote: > On Wed, 14 Nov 2007, Andi Kleen wrote: > > > Later a syscall might be needed with event multiplexing, but that seems > > more like a far away non essential feature. > > actually multiplexing is the main feature i am in need

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Haavard Skinnemoen
On Wed, 14 Nov 2007 22:50:17 -0800 David Brownell <[EMAIL PROTECTED]> wrote: > > Since this is the code that runs under the lock > > No, there's more than that. This is what runs under it in > the hot paths, yes, but the gpio request/free paths do > more work than this. (That includes

Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)

2007-11-15 Thread Jens Axboe
On Thu, Nov 15 2007, Rusty Russell wrote: > On Wednesday 14 November 2007 23:39:31 Jens Axboe wrote: > > On Wed, Nov 14 2007, Rusty Russell wrote: > > > Hi Jens, > > > > > > As you asked for some time ago. Of course, it turns out that the > > > eject command ignores the error anyway, but it's

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread David Brownell
On Wednesday 14 November 2007, Thomas Gleixner wrote: > On Wed, 14 Nov 2007, David Brownell wrote: > > > The protection of the chip list can be converted to a mutex and > > > does not need to be a spinlock at all. > > > > No, we still need to use a spinlock to protect table changes. > > The

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Andi Kleen
Herbert Xu <[EMAIL PROTECTED]> writes: > That's strong static typing. Netlink is 90% strong static > typing plus 10% strong dynamic typing. That is, it'll tell > you at run-time if you give it the wrong netlink attribute. Well it tells you EINVAL no matter what is wrong. That's roughly

Re: [PATCH] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better

2007-11-15 Thread Jesper Nilsson
On Wed, Nov 14, 2007 at 06:29:17PM -0800, Denys Vlasenko wrote: > On Wednesday 14 November 2007 09:08, Jesper Nilsson wrote: > > /* Not true gettimeofday, only checks the jiffies (uptime) + useconds */ > > -void __INLINE__ do_gettimeofday_fast(struct fasttime_t *tv) > > +inline void

Re: OT: Does Linux have any "Perfect Code"

2007-11-15 Thread Andi Kleen
Eric Dumazet <[EMAIL PROTECTED]> writes: > > http://cvs.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/os/timers.c#1106 > > I would say this code was OK 10 years ago. I would have expected 1997 compilers to already do these standard muliplication optimizations. > Now that a

Re: 2.6.24-rc2-mm1

2007-11-15 Thread Dave Young
On Thu, Nov 15, 2007 at 03:38:13AM +0100, Kay Sievers wrote: > On Thu, 2007-11-15 at 09:01 +0800, Dave Young wrote: > > On Nov 15, 2007 5:27 AM, Kay Sievers <[EMAIL PROTECTED]> wrote: > > > On Wed, 2007-11-14 at 20:19 +0100, Jiri Kosina wrote: > > > > On Wed, 14 Nov 2007, Kay Sievers wrote: > > >

Re: OT: Does Linux have any "Perfect Code"

2007-11-15 Thread Philippe Elie
On Wed, 14 Nov 2007 at 20:21 +, Russell Leighton wrote: > > Bryan Cantrill of Sun (ala DTrace) has a notion of perfect code: > > http://blogs.sun.com/bmc/entry/on_i_dreaming_in_code > > He also has some examples (from bottom comment section of above): > > > > > > >Can you list a

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 06:19, Nick Piggin wrote: > On Thursday 15 November 2007 19:17, David Brownell wrote: > > On Wednesday 14 November 2007, Nick Piggin wrote: > > > > > > All this does is prevent constant and needless checking for > > > > > > "do you want to preempt me now?" "now?"

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Stephane Eranian
Hi, On Thu, Nov 15, 2007 at 12:11:10PM +1100, Paul Mackerras wrote: > David Miller writes: > > > From: Paul Mackerras <[EMAIL PROTECTED]> > > Date: Thu, 15 Nov 2007 10:12:22 +1100 > > > > > *I* never had a problem with a few extra system calls. I don't > > > understand why you (apparently)

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Christian Kujau
On Wed, 14 Nov 2007, Christian Kujau wrote: Yes, the nfsd process only got stuck when I did ls(1) (with or without -l) on a NFS share which contained a XFS partition. Since NFS was not working (the nfsd processes were already in D state), to mount a CIFS share from the very same server (and

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 17:28, David Brownell wrote: > On Tuesday 13 November 2007, Nick Piggin wrote: > > > All this does is prevent constant and needless checking for > > > "do you want to preempt me now?" "now?" "now?" in "now?" the > > > middle "now?" of "now?" i/o "now?" loops. > > > >

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Herbert Xu
Paul Mackerras <[EMAIL PROTECTED]> wrote: > > Well you must mean something different by "strong typing" from the > rest of us. Strong typing means that the compiler can check that you > have passed in the correct types of arguments, but the compiler > doesn't have any visibility into what

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Herbert Xu
Paul Mackerras [EMAIL PROTECTED] wrote: Well you must mean something different by strong typing from the rest of us. Strong typing means that the compiler can check that you have passed in the correct types of arguments, but the compiler doesn't have any visibility into what structures are

Re: 2.6.24-rc2 XFS nfsd hang / smbd too

2007-11-15 Thread Christian Kujau
On Wed, 14 Nov 2007, Christian Kujau wrote: Yes, the nfsd process only got stuck when I did ls(1) (with or without -l) on a NFS share which contained a XFS partition. Since NFS was not working (the nfsd processes were already in D state), to mount a CIFS share from the very same server (and

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 17:28, David Brownell wrote: On Tuesday 13 November 2007, Nick Piggin wrote: All this does is prevent constant and needless checking for do you want to preempt me now? now? now? in now? the middle now? of now? i/o now? loops. Actually that's wrong.

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 06:19, Nick Piggin wrote: On Thursday 15 November 2007 19:17, David Brownell wrote: On Wednesday 14 November 2007, Nick Piggin wrote: All this does is prevent constant and needless checking for do you want to preempt me now? now? now? in now? the

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Stephane Eranian
Hi, On Thu, Nov 15, 2007 at 12:11:10PM +1100, Paul Mackerras wrote: David Miller writes: From: Paul Mackerras [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 10:12:22 +1100 *I* never had a problem with a few extra system calls. I don't understand why you (apparently) do. We're

Re: OT: Does Linux have any Perfect Code

2007-11-15 Thread Philippe Elie
On Wed, 14 Nov 2007 at 20:21 +, Russell Leighton wrote: Bryan Cantrill of Sun (ala DTrace) has a notion of perfect code: http://blogs.sun.com/bmc/entry/on_i_dreaming_in_code He also has some examples (from bottom comment section of above): Can you list a small number of

Re: OT: Does Linux have any Perfect Code

2007-11-15 Thread Andi Kleen
Eric Dumazet [EMAIL PROTECTED] writes: http://cvs.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/os/timers.c#1106 I would say this code was OK 10 years ago. I would have expected 1997 compilers to already do these standard muliplication optimizations. Now that a processor

Re: 2.6.24-rc2-mm1

2007-11-15 Thread Dave Young
On Thu, Nov 15, 2007 at 03:38:13AM +0100, Kay Sievers wrote: On Thu, 2007-11-15 at 09:01 +0800, Dave Young wrote: On Nov 15, 2007 5:27 AM, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-14 at 20:19 +0100, Jiri Kosina wrote: On Wed, 14 Nov 2007, Kay Sievers wrote: Could it

Re: [PATCH] CRISv10 fasttimer: Scrap INLINE and name timeval_cmp better

2007-11-15 Thread Jesper Nilsson
On Wed, Nov 14, 2007 at 06:29:17PM -0800, Denys Vlasenko wrote: On Wednesday 14 November 2007 09:08, Jesper Nilsson wrote: /* Not true gettimeofday, only checks the jiffies (uptime) + useconds */ -void __INLINE__ do_gettimeofday_fast(struct fasttime_t *tv) +inline void

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Andi Kleen
Herbert Xu [EMAIL PROTECTED] writes: That's strong static typing. Netlink is 90% strong static typing plus 10% strong dynamic typing. That is, it'll tell you at run-time if you give it the wrong netlink attribute. Well it tells you EINVAL no matter what is wrong. That's roughly similar to

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread David Brownell
On Wednesday 14 November 2007, Thomas Gleixner wrote: On Wed, 14 Nov 2007, David Brownell wrote: The protection of the chip list can be converted to a mutex and does not need to be a spinlock at all. No, we still need to use a spinlock to protect table changes. The reason for that is

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Haavard Skinnemoen
On Wed, 14 Nov 2007 22:50:17 -0800 David Brownell [EMAIL PROTECTED] wrote: Since this is the code that runs under the lock No, there's more than that. This is what runs under it in the hot paths, yes, but the gpio request/free paths do more work than this. (That includes direction

Re: [PATCH] Attempt to get eject failures back to ioctl(CDROMEJECT)

2007-11-15 Thread Jens Axboe
On Thu, Nov 15 2007, Rusty Russell wrote: On Wednesday 14 November 2007 23:39:31 Jens Axboe wrote: On Wed, Nov 14 2007, Rusty Russell wrote: Hi Jens, As you asked for some time ago. Of course, it turns out that the eject command ignores the error anyway, but it's nice that it

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 13:29:19 +0900 KAMEZAWA Hiroyuki [EMAIL PROTECTED] wrote: Fixes for memory hotplug compile and .section handling. This patch fixes following bugs == WARNING: vmlinux.o(.text+0x1d07c): Section mismatch: reference to .init.text:f ind_e820_area (between

Re: [perfmon] Re: [perfmon2] perfmon2 merge news

2007-11-15 Thread Stephane Eranian
Hello, On Wed, Nov 14, 2007 at 08:20:22PM -0800, dean gaudet wrote: On Wed, 14 Nov 2007, Andi Kleen wrote: Later a syscall might be needed with event multiplexing, but that seems more like a far away non essential feature. actually multiplexing is the main feature i am in need of. there

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 19:17, David Brownell wrote: On Wednesday 14 November 2007, Nick Piggin wrote: All this does is prevent constant and needless checking for do you want to preempt me now? now? now? in now? the middle now? of now? i/o now? loops. Actually that's

Re: [PATCH] drivers/ide/ide-probe.c, kernel 2.6.23.1

2007-11-15 Thread Jonas Stare
Hi, thanks for the reply. :) Bartlomiej Zolnierkiewicz wrote: Hi, On Monday 12 November 2007, Andrew Morton wrote: On Fri, 09 Nov 2007 11:22:41 +0100 Jonas Stare [EMAIL PROTECTED] wrote: Hi. This week I ran into a strange hardware problem. During boot I got a 35 second delay while waiting

Re: 2.6.24-rc2-mm1

2007-11-15 Thread Kay Sievers
On Thu, 2007-11-15 at 16:14 +0800, Dave Young wrote: On Thu, Nov 15, 2007 at 03:38:13AM +0100, Kay Sievers wrote: On Thu, 2007-11-15 at 09:01 +0800, Dave Young wrote: On Nov 15, 2007 5:27 AM, Kay Sievers [EMAIL PROTECTED] wrote: On Wed, 2007-11-14 at 20:19 +0100, Jiri Kosina wrote:

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread David Brownell
On Wednesday 14 November 2007, Nick Piggin wrote: All this does is prevent constant and needless checking for do you want to preempt me now? now? now? in now? the middle now? of now? i/o now? loops. Actually that's wrong. Certainly it's right for the mainstream kernel.  

Re: [patch 2.6.24-rc2 1/3] generic gpio -- gpio_chip support

2007-11-15 Thread Haavard Skinnemoen
On Thu, 15 Nov 2007 00:20:33 -0800 David Brownell [EMAIL PROTECTED] wrote: - gpio_direction_input()/gpio_direction_output() implicitly request the pins, if they weren't already requested. Eek, that's completely wrong. Allowing to access a resource _before_ it is assigned and

EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Alexey Dobriyan
Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 (1) and during 2.6.24 cycle (2): kernel_restart sys_reboot [garbage] Code: 8b 88 a8 00 00 00 85 c9 74 04 89 EIP is at device_shutdown+0x32/0x60 which corresponds to the following place: c110659c

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Nov 2007 00:56:57 -0800 Andrew Morton [EMAIL PROTECTED] wrote: eek. What I now need to do with this patch is - Work out which patches in -mm it is actually fixing. - If that is more than one patch then split this patch up into multiple ones. - Stage the one or more fixup

Re: libata_uli puts second channel to PIO4 on 2.6.18

2007-11-15 Thread Patric Karlsson
Patric Karlsson wrote: Grzegorz Kulewski wrote: On Wed, 7 Feb 2007, Tejun Heo wrote: Grzegorz Kulewski wrote: It worked very well for half a year but with one disk (IIRC it was even plugged into second channel but I wont bet on it). Now I have second disk (very similar) and it is always

Re: libata_uli puts second channel to PIO4 on 2.6.18

2007-11-15 Thread Patric Karlsson
Grzegorz Kulewski wrote: On Wed, 7 Feb 2007, Tejun Heo wrote: Grzegorz Kulewski wrote: It worked very well for half a year but with one disk (IIRC it was even plugged into second channel but I wont bet on it). Now I have second disk (very similar) and it is always put into PIO4 mode: [

[PATCH] fs: remove dead config CONFIG_HAS_COMPAT_EPOLL_EVENT symbol

2007-11-15 Thread Jiri Olsa
remove dead config CONFIG_HAS_COMPAT_EPOLL_EVENT symbol Signed-off-by: Jiri Olsa [EMAIL PROTECTED] --- fs/compat.c| 49 include/linux/compat.h |8 --- 2 files changed, 0 insertions(+), 57 deletions(-) diff --git

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread Andy Whitcroft
On Thu, Nov 15, 2007 at 01:29:19PM +0900, KAMEZAWA Hiroyuki wrote: Fixes for memory hotplug compile and .section handling. This patch fixes following bugs == WARNING: vmlinux.o(.text+0x1d07c): Section mismatch: reference to .init.text:f ind_e820_area (between 'init_memory_mapping' and

Re: tg3: strange errors and non-working-ness

2007-11-15 Thread Jarek Poplawski
On 13-11-2007 19:57, Jon Nelson wrote: I'm not sure if this is the right place, Me too. Looks more like acpi or pci problem. Did you try to experiment with something like: pci=noacpi or acpi=off boot parameters? Probably some point to your .config and dmesg should be useful too, so taking it to

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote: Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 (1) and during 2.6.24 cycle (2): kernel_restart sys_reboot [garbage] Code: 8b 88 a8 00 00 00 85 c9 74 04 89 EIP is at

Re: EIP is at device_shutdown+0x32/0x60

2007-11-15 Thread Alexey Dobriyan
On Thu, Nov 15, 2007 at 01:44:46AM -0800, Andrew Morton wrote: On Thu, 15 Nov 2007 12:11:58 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote: Three boxes rarely oops during reboot or poweroff with 2.6.24-rc2-mm1 (1) and during 2.6.24 cycle (2): kernel_restart sys_reboot

Re: 2.6.24-rc2-mm1 -- strange apparent network failures

2007-11-15 Thread Andy Whitcroft
When testing some of the later 2.6.24-rc2-mm1+hotfix combinations on three of our test systems one job from each batch (1/4) failed. In each case the machine appears to have booted normally all the way to a login: prompt. However in the failed boots the networking though apparently initialised

Re: 2.6.24-rc2-mm1 (memory hotplug x86_64/vmemmap fix)

2007-11-15 Thread KAMEZAWA Hiroyuki
On Thu, 15 Nov 2007 09:39:15 + Andy Whitcroft [EMAIL PROTECTED] wrote: Can you explain this is bug for me. The routine was __init_refok and therefore ! __init and therefore always present. The logic there must guarentee it only calls the bootmem allocator in early boot, and the logic

Re: 2.6.24-rc2 panic: (non-exitent) NFS root f/s

2007-11-15 Thread Shane
On Wed, 2007-11-14 at 22:42 +0100, Rafael J. Wysocki wrote: Perhaps it just can't find the root filesystem at all? Indeed - thanks for the input. My supposed good source config didn't match the running kernel. A work in progress I had obviously forgotten about. Apologies for having disturbed

[PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Mel Gorman
This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is determined at runtime based on what is supported by the machine. With legacy machines such as iSeries that do not support hugepages,

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [0/3]

2007-11-15 Thread KAMEZAWA Hiroyuki
memory hotplug fix against 2.6.23-rc2-mm1. Changelog - Divided into 3 patches - dropped patch against mm/sparse.c ( This was my misunderstanding.) - merged Andy's suggestion. All patches are related to memory hotplug. [1/3] ... export memory_add_physaddr_to_nid to acpi memory hotplug [2/3]

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [1/3] memory_add_physaddr_to_nid export for acpi memhotplug.ko

2007-11-15 Thread KAMEZAWA Hiroyuki
Fix following reference error (when CONFIG_ACPI_HOTPLUG_MEMORY=m) == ERROR: memory_add_physaddr_to_nid [drivers/acpi/acpi_memhotplug.ko] undefined! == Changelog: - EXPORT_SYMBOL to EXPORT_SYMBOL_GPL. Signed-off-by: KAMEZAWA Hiroyuki [EMAIL PROTECTED] arch/x86/mm/srat_64.c |1 + 1

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is determined at runtime based on what is supported by the

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [3/3] fix section mismatch in init_memory_mapping

2007-11-15 Thread KAMEZAWA Hiroyuki
Changes __meminit to __init_refok. == WARNING: vmlinux.o(.text+0x1d07c): Section mismatch: reference to .init.text:find_e820_area (between 'init_memory_mapping' and 'arch_add_memory') == Changelog: * changes __init_refok from find_early_table_space() to init_memory_mapping(). Signed-off-by:

[PATCH][2.6.24-rc2-mm1] memory hotplug x86_64 fix [2/3] fix section mismatch in vmammap_allock_block

2007-11-15 Thread KAMEZAWA Hiroyuki
Fixes section mismatch below. WARNING: vmlinux.o(.text+0x946b5): Section mismatch: reference to .init.text:' __alloc_bootmem_node (between 'vmemmap_alloc_block' and 'vmemmap_pgd_populate') Changelog - changed bootmem alloc wrapper function's name to be __earlyonly_bootmem_alloc().

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is determined at runtime based on what is supported by the

[PATCH 1/2]: drivers/char: remove unnecessary pci_dev_put

2007-11-15 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] pci_get_class implicitly does a pci_dev_put on its second argument, so pci_dev_put is only needed if there is a break out of the loop. The semantic match detecting this problem is as follows: // smpl @@ expression dev; expression E; @@ * pci_dev_put(dev)

[PATCH 2/2]: drivers/video: remove unnecessary pci_dev_put

2007-11-15 Thread Julia Lawall
From: Julia Lawall [EMAIL PROTECTED] pci_get_class implicitly does a pci_dev_put on its second argument, so pci_dev_put is only needed if there is a break out of the loop. The semantic match detecting this problem is as follows: // smpl @@ expression dev; expression E; @@ * pci_dev_put(dev)

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Ingo Molnar
* David Miller [EMAIL PROTECTED] wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 17:37:13 -0600 No, the usual strategy for debugging problems -outside- SLOB is to switch to another allocator with more extensive debugging facilities. Ok, so the thing we still can do

Re: 2.6.24-rc2-mm1 -- QLogics ISP1020 gone missing

2007-11-15 Thread Andy Whitcroft
All of our machines with QLogics ISP1020 cards seem to have lost them on boot with 2.6.24-rc1-mm1+hotfixes. # lspci :00:0a.0 SCSI storage controller: QLogic Corp. ISP1020 Fast-wide SCSI (rev 05) # lspci -n :00:0a.0 0100: 1077:1020 (rev 05) # lspci -v -v :00:0a.0 SCSI storage

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 11:43:32 +0100 The crash logs contain this: VFS: Mounted root (ext3 filesystem) readonly. Freeing unused kernel memory: 396k freed Write protecting the kernel read-only data: 2056k udev: renamed network interface eth1 to eth0

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Mel Gorman
On (15/11/07 02:39), Andrew Morton didst pronounce: On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Nick Piggin
On Thursday 15 November 2007 21:43, Ingo Molnar wrote: * David Miller [EMAIL PROTECTED] wrote: From: Matt Mackall [EMAIL PROTECTED] Date: Wed, 14 Nov 2007 17:37:13 -0600 No, the usual strategy for debugging problems -outside- SLOB is to switch to another allocator with more extensive

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Andrew Morton
On Thu, 15 Nov 2007 10:52:38 + [EMAIL PROTECTED] (Mel Gorman) wrote: Shouldn't this have been HUGETLB_PAGE_ORDER? As a #define, possibly but as a static inline - definitly not. In this context, the define is not used because set_pageblock_order() is a no-op when

[PATCH] trivial: SERIAL_NETX_CONSOLE provides console for NetX, not IMX

2007-11-15 Thread Uwe Kleine-König
Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED] --- drivers/serial/Kconfig |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig index d6ae38e..6d0c97a 100644 --- a/drivers/serial/Kconfig +++ b/drivers/serial/Kconfig @@

[PATCH Documentation] use the newc archive format as requested by initramfs

2007-11-15 Thread Uwe Kleine-König
This is a documentation followup to 2e591bbc0d563e12f5a260fbbca0df7d5810910e Signed-off-by: Uwe Kleine-König [EMAIL PROTECTED] --- Documentation/initrd.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/initrd.txt b/Documentation/initrd.txt index

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread Ingo Molnar
* David Miller [EMAIL PROTECTED] wrote: Yeah I wish udev would just leave the damn devices alone. It even does things like try to rename a network device to the same name it already has, and other strange stuff. But that log difference is a good clue. Because udev can try to rename a

Re: [bug] SLOB crash, 2.6.24-rc2

2007-11-15 Thread David Miller
From: Ingo Molnar [EMAIL PROTECTED] Date: Thu, 15 Nov 2007 12:03:25 +0100 now that it's reproducible again i'll try more direct debugging. (Networking might not even be the cause of this - that was just a quick first impression that i had.) Btw., the .config is the result of automated

Re: [patch 5/8] Immediate Values - x86 Optimization

2007-11-15 Thread Rusty Russell
On Thursday 15 November 2007 16:37:51 Mathieu Desnoyers wrote: * Rusty Russell ([EMAIL PROTECTED]) wrote: On Thursday 15 November 2007 15:06:10 Mathieu Desnoyers wrote: A - the NMI or MCE code calls any external kernel code (printk, notify_die, spin_lock/unlock, die_nmi, lapic_wd_event

Re: [PATCH] Fix boot problem with iSeries lacking hugepage support

2007-11-15 Thread Mel Gorman
On (15/11/07 02:32), Andrew Morton didst pronounce: On Thu, 15 Nov 2007 10:13:22 + [EMAIL PROTECTED] (Mel Gorman) wrote: This patch is a fix for 2.6.24. Ordinarily the size of a pageblock is determined at compile-time based on the hugepage size. On PPC64, the hugepage size is

[2.6.24-rc2-git5] kernel panic when config_sysfs = n

2007-11-15 Thread Daniel Lezcano
Hi, When I tryed to boot with qemu a 2.6.24-rc2-git5 with sysfs disabled, the boot fails when trying to mount root partition: VFS: Cannot open root device hda2 or unknown-block(0,0) Please append a correct root= boot option; here are the available partitions: 03002097152 hda0300

Re: [2.6.24-rc2-git5] kernel panic when config_sysfs = n

2007-11-15 Thread Daniel Lezcano
Alexey Dobriyan wrote: On 11/15/07, Daniel Lezcano [EMAIL PROTECTED] wrote: When I tryed to boot with qemu a 2.6.24-rc2-git5 with sysfs disabled, the boot fails when trying to mount root partition: VFS: Cannot open root device hda2 or unknown-block(0,0) Please append a correct root= boot

<    1   2   3   4   5   6   7   8   9   >