Re: [PATCHSET] printk: implement printk_header() and merging printk, take #3

2008-02-13 Thread Andrew Morton
On Thu, 14 Feb 2008 09:40:51 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Can you please take a look at ata_eh_link_report() in > drivers/ata/libata-eh.c? I did. Punishment? > Currently, it has some problems. Yes, and the patches do clean that up. ho hum. What tends to happen with this

[PATCH 4/4]: [LMB]: Make lmb support large physical addressing

2008-02-13 Thread David Miller
[LMB]: Make lmb support large physical addressing Convert the lmb code to use u64 instead of unsigned long for physical addresses and sizes. This is needed to support large amounts of RAM on 32-bit systems that support 36-bit physical addressing. Signed-off-by: Becky Bruce <[EMAIL PROTECTED]>

[PATCH 2/4]: [LMB]: Fix bug in __lmb_alloc_base().

2008-02-13 Thread David Miller
[LMB]: Fix bug in __lmb_alloc_base(). We need to check lmb_add_region() for errors, it can run out of regions etc. Also, the size needs to be padded to the given alignment or else the lmb.reserved regions don't get expanded and instead we get tons of holes and eventually run out of regions

[PATCH 3/4]: [LMB]: Fix initial lmb add region with a non-zero base

2008-02-13 Thread David Miller
[LMB]: Fix initial lmb add region with a non-zero base If we add to an empty lmb region with a non-zero base we will not coalesce the number of regions down to one. This causes problems on ppc32 for the memory region as its assumed to only have one region. We can fix this be easily specially

[PATCH 1/4]: [LIB]: Make PowerPC LMB code generic so sparc64 can use it too.

2008-02-13 Thread David Miller
[LIB]: Make PowerPC LMB code generic so sparc64 can use it too. Signed-off-by: David S. Miller <[EMAIL PROTECTED]> --- arch/powerpc/Kconfig|1 + arch/powerpc/kernel/btext.c |3 +- arch/powerpc/kernel/crash.c |3 +-

[2.6 patch] fix module_update_markers() compile error

2008-02-13 Thread Adrian Bunk
This patch fixes the following compile error with CONFIG_MODULES=n caused by commit fb40bd78b0f91b274879cf5db8facd1e04b6052e: <-- snip --> ... CC kernel/marker.o /home/bunk/linux/kernel-2.6/git/linux-2.6/kernel/marker.c: In function ‘marker_update_probes’:

[PATCH 0/4]: Respun LMB patches.

2008-02-13 Thread David Miller
I've taken into consideration the various feedback, and ported the bug fix and other LMB patches posted recently in an effort to keep the patch churn by others down wrt. my moving of these files. 1) Use HAVE_LMB as suggested by Sam. 2) Fix potential build errors wrt. asm/prom.h dependencies.

[PATCH] debugfs: fix sparse warnings

2008-02-13 Thread Harvey Harrison
extern does not belong in C files, move declaration to linux/debugfs.h fs/debugfs/file.c:42:30: warning: symbol 'debugfs_file_operations' was not declared. Should it be static? fs/debugfs/file.c:54:31: warning: symbol 'debugfs_link_operations' was not declared. Should it be static?

[PATCH] asm-*/futex.h should include linux/uaccess.h

2008-02-13 Thread Jeff Dike
[ non-urgent - 2.6.26 material ] Lots of asm-*/futex.h call pagefault_enable and pagefault_disable, which are declared in linux/uaccess.h, without including linux/uaccess.h. They all include asm/uaccess.h, so this patch replaces asm/uaccess.h with linux/uaccess.h. Compile-tested on sparc64,

Re: Strange hang on ia64 with CONFIG_PRINTK_TIME=y

2008-02-13 Thread David Miller
From: "Tony Luck" <[EMAIL PROTECTED]> Date: Wed, 13 Feb 2008 16:59:30 -0800 > > It is legal to access per-cpu data as early as you like, > > it just evaluates to the static copy in the per-cpu section > > of the kernel image until the per-cpu areas are setup. > > On ia64 per-cpu variables are

Re: [PATCH][I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec

2008-02-13 Thread Dan Williams
On Feb 13, 2008 2:05 PM, Brice Goglin <[EMAIL PROTECTED]> wrote: > [I/OAT]: Remove duplicate assignation in dma_skb_copy_datagram_iovec > > No need to compute copy twice in the frags loop in > dma_skb_copy_datagram_iovec(). > > Signed-off-by: Brice Goglin <[EMAIL PROTECTED]> Thanks, I'll push

nf_conntrack - still missing one critical patch

2008-02-13 Thread Jeff Chua
Jozsef, Krzysztof Have you had a chance to take a look at this missing bit? Thanks, Jeff. On Feb 10, 2008 11:06 PM, Jeff Chua <[EMAIL PROTECTED]> wrote: > > On Feb 5, 2008 9:47 PM, Patrick McHardy wrote: > >> On Feb 5, 2008 4:16 PM, Jozsef Kadlecsik wrote: > >> Patrick, I suppose you need a

Re: Strange hang on ia64 with CONFIG_PRINTK_TIME=y

2008-02-13 Thread Tony Luck
> It is legal to access per-cpu data as early as you like, > it just evaluates to the static copy in the per-cpu section > of the kernel image until the per-cpu areas are setup. On ia64 per-cpu variables are mapped into the top 64K of the address space. Accessing them before the resources to

Re: [2.6 patch] thinkpad_acpi.c: make 2 functions static

2008-02-13 Thread Adrian Bunk
On Wed, Feb 13, 2008 at 09:03:21PM -0200, Henrique de Moraes Holschuh wrote: >... > That said, I have no idea what toshiba-acpi has to do with the above patch > ;-) They both begin with a t and end with acpi so they have to be the same, don't they? ;-) cu Adrian -- "Is there not

Re: distributed module configuration [Was: Announce: Linux-next (Or Andrew's dream :-))]

2008-02-13 Thread Roman Zippel
Hi, On Wednesday 13. February 2008, Sam Ravnborg wrote: > config foo > tristate "do you want foo?" > depends on USB && BAR > module > obj-$(CONFIG_FOO) += foo.o > foo-y := file1.o file2.o > help > foo will allow you to explode your PC I'm more

Re: [PATCH-resend] jbd/jbd2: sparse warnings in revoke.c, journal.c

2008-02-13 Thread Harvey Harrison
On Wed, 2008-02-13 at 16:50 -0800, Andrew Morton wrote: > On Wed, 13 Feb 2008 16:33:37 -0800 > Harvey Harrison <[EMAIL PROTECTED]> wrote: > > > Subject: [PATCH-resend] jbd/jbd2: sparse warnings in revoke.c, journal.c > > ext3/jbd and ext4/jbd2 patches usually find their way into the tree > via

Re: [ofa-general] Re: Demand paging for memory regions

2008-02-13 Thread Andrea Arcangeli
Hi Kanoj, On Wed, Feb 13, 2008 at 03:43:17PM -0800, Kanoj Sarcar wrote: > Oh ok, yes, I did see the discussion on this; sorry I > missed it. I do see what notifiers bring to the table > now (without endorsing it :-)). I'm not really livelocks are really the big issue here. I'm running N 1G VM

[PATCH] dlm: match signedness between dlm_config_info and cluster_set

2008-02-13 Thread Harvey Harrison
cluster_set is only called from the macro CLUSTER_ATTR which defines read/write access functions. Make the signedness match to avoid sparse warnings every time CLUSTER_ATTR is used (lines 149-159) all of the form: fs/dlm/config.c:149:1: warning: incorrect type in argument 3 (different

Re: 2.6.24-git16 Oops @ sysfs_move_dir w/ btdelconn

2008-02-13 Thread Dave Young
On Feb 8, 2008 12:57 AM, Barnaby <[EMAIL PROTECTED]> wrote: > Hello Dave, Add someone to cc-list > > Got your name and email from the 2.6.24-git16 changelog. > > I get these Oops when suspending or doing.. > > echo disable > /proc/acpi/ibm/bluetooth > or > echo 0 >

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 16:42:53 -0800 "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > On Wed, Feb 13, 2008 at 04:27:00PM -0800, Stephen Hemminger wrote: > > On Wed, 13 Feb 2008 16:14:04 -0800 > > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > > On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen

Re: [PATCH-resend] jbd/jbd2: sparse warnings in revoke.c, journal.c

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 16:33:37 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote: > Subject: [PATCH-resend] jbd/jbd2: sparse warnings in revoke.c, journal.c ext3/jbd and ext4/jbd2 patches usually find their way into the tree via different routes, so bundling these two fixes was inappropriate.

Re: BTRFS partition usage...

2008-02-13 Thread Szabolcs Szakacsits
On Tue, 12 Feb 2008, Jeff Garzik wrote: > > Yep. I chose 32K unused space in the prototype filesystem I wrote [1, 2.4 > era]. I'm pretty sure I got that number from some other filesystem, maybe > even some NTFS incarnation. NTFS superblock (and the partial mirror copy) can be anywhere

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 04:27:00PM -0800, Stephen Hemminger wrote: > On Wed, 13 Feb 2008 16:14:04 -0800 > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote: [ . . . ] > > > Maybe cast both sides to void * in this case: > > > > >

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #3

2008-02-13 Thread Tejun Heo
Andrew Morton wrote: >> And mprintk the following. >> >> code: >> DEFINE_MPRINTK(mp, 2 * 80); >> >> mprintk_set_header(, KERN_INFO "ata%u.%2u: ", 1, 0); >> mprintk_push(, "ATA %d", 7); >> mprintk_push(, ", %u sectors\n", 1024); >> mprintk(, "everything seems dandy\n"); >> >> output: >>

Re: [PATCH] Use ELF_CORE_EFLAGS for kcore ELF header flags.

2008-02-13 Thread Andrew Morton
On Tue, 12 Feb 2008 14:34:23 +0100 "Edgar E. Iglesias" <[EMAIL PROTECTED]> wrote: > ELF_CORE_EFLAGS is already used by the binfmt_elf coredumper to set correct > arch specific ELF header flags on coredumps. Use it for kcore aswell. > This corrects kcore files for the CRIS arch and I beleive it

[PATCH-resend] jbd/jbd2: sparse warnings in revoke.c, journal.c

2008-02-13 Thread Harvey Harrison
fs/jbd/revoke.c:176:29: warning: Using plain integer as NULL pointer fs/jbd/revoke.c:182:28: warning: Using plain integer as NULL pointer fs/jbd/journal.c:1622:2: warning: Using plain integer as NULL pointer fs/jbd/journal.c:1629:28: warning: Using plain integer as NULL pointer

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 16:14:04 -0800 "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote: > > On Wed, 13 Feb 2008 15:37:44 -0800 > > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > > On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen

Re: [PATCH 4/8][for -mm] mem_notify v6: memory_pressure_notify() caller

2008-02-13 Thread KOSAKI Motohiro
Hi Andi, > > to be honest, I don't think at mem-cgroup until now. > > There is not only mem-cgroup BTW, but also NUMA node restrictons from > NUMA memory policy. So this means a process might not be able to access > all memory. you are right. good point out. current implementation may cause

Re: Strange hang on ia64 with CONFIG_PRINTK_TIME=y

2008-02-13 Thread Roland Dreier
> > so .. how about the patch below? Note that we already had an "early > > bootup" special (the rq->idle check), it's now just made explicit via > > the scheduler_running flag. > > the one below even builds. (untested otherwise) I just tried this... it doesn't work on top of current git

Re: [RFC PATCH] feature-removal: add documentation for exported symbols going away

2008-02-13 Thread Alan Cox
> Unexports are done immediately when there's a subsystem maintainer > taking a patch and deprecation periods are required when a patch has to > go through you... Agreed - with the expect of stuff which is used in tree or forms part of a logical exported API we should just throw them out

[PATCH 11/11] ppc/pmac: remove no longer needed IDE quirk

2008-02-13 Thread Bartlomiej Zolnierkiewicz
IDE PMAC host driver and all IDE PCI host drivers use pci_enable_device() nowadays so the following quirk in pmac_pcibios_after_init() can be removed. Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> ---

[PATCH 10/11] ppc: don't include

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- arch/ppc/platforms/4xx/bamboo.c |1 - arch/ppc/platforms/4xx/ebony.c |1 - arch/ppc/platforms/4xx/luan.c |1 - arch/ppc/platforms/4xx/ocotea.c |1 -

[PATCH 09/11] ppc: remove ppc_ide_md

2008-02-13 Thread Bartlomiej Zolnierkiewicz
* Add special cases for pplus and prep to ide_default_{irq,io_base}() (+ FIXMEs about the need to use IDE platform host driver instead). * Remove no longer needed ppc_ide_md and struct ide_machdep_calls. * Then remove include from: - arch/powerpc/kernel/setup_32.c -

[PATCH 07/11] ppc/sandpoint: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
* Add IDE_HFLAG_FORCE_LEGACY_IRQS host flag for Motorola-Sandpoint platform to sl82c105 host driver. * Disable ide_generic host driver in arch/ppc/configs/sandpoint_defconfig and enable sl82c105 one. * Remove ppc_ide_md hooks from arch/ppc/platforms/sandpoint.c - no need for them (sl82c105

[PATCH 08/11] ppc/pplus: remove ppc_ide_md.ide_init_hwif hook

2008-02-13 Thread Bartlomiej Zolnierkiewicz
* Call ide_init_default_irq() for pplus in init_ide_data(). * Remove no longer needed pplus_ide_init_hwif_ports(). There should be no functional changes caused by this patch. Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> ---

[PATCH 06/11] ppc/lopec: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
* Add IDE_HFLAG_FORCE_LEGACY_IRQS host flag for Motorola-LoPEC platform to sl82c105 host driver. * Remove ppc_ide_md hooks from arch/ppc/platforms/lopec.c - no need for them (sl82c105 host driver takes care of all this setup). * Then remove no longer needed include. Looking at

[PATCH 05/11] ppc/mpc8xx: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
* Initialize IDE ports in mpc8xx_ide_probe(). * Remove m8xx_ide_init() and ppc_ide_md hooks - no need for them (IDE mpc8xx host driver takes care of all this setup). * Remove needless 'if (irq)' and 'if (data_port >= MAX_HWIFS)' checks from m8xx_ide_init_hwif_ports(). * Remove 'ctrl_port'

Re: Semaphores with timeouts

2008-02-13 Thread Alan Cox
On Thu, 14 Feb 2008 01:08:28 +0100 "Ricardo J. Rodríguez" <[EMAIL PROTECTED]> wrote: > Hi everybody, > I'm developing a driver to support a new protocol on the kernel 2.6.x, > a real time communication protocol used in robotic fields. Skipping > the intro: I need to know if there is any function

[PATCH 04/11] ppc/pmac: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
* Add pmac_ide_init_ports() helper and use it instead of pmac_ide_init_hwif_ports(). * Remove ppc_ide_md hooks - no need for them (IDE pmac host driver takes care of all this setup). * Then remove no longer needed include from arch/powerpc/platforms/powermac/pmac.h. Cc: Benjamin

[PATCH 03/11] ppc/ppc4xx: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
There are no "default" IDE ports on PPC4xx so ppc4xx_ide_init_hwif_ports() is unnecessary, remove it. Also remove no longer needed include. There should be no functional changes caused by this patch. Cc: Josh Boyer <[EMAIL PROTECTED]> Cc: Matt Porter <[EMAIL PROTECTED]> Cc: Benjamin

[PATCH 02/11] ppc/hdpu: remove dead IDE code

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Also remove now not needed include. Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- arch/ppc/platforms/hdpu.c | 36 1 file changed, 36 deletions(-) Index: b/arch/ppc/platforms/hdpu.c

[PATCH 01/11] ide-pmac: remove dead code

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Remove unused pmac_ide_{check_base,get_irq}() and pmac_find_ide_boot(), then remove no longer needed ide_majors[] and pmac_ide_count. Cc: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ppc/pmac.c | 47

Re: [stable 2.6.24] WARNING: at kernel/time/clockevents.c

2008-02-13 Thread Thomas Gleixner
On Wed, 13 Feb 2008, Frans Pop wrote: > On Wednesday 13 February 2008, Thomas Gleixner wrote: > > can you please apply the following patch ? I really should have > > thought about that, when I fixed the above one. > > I still get the bug with this patch. At least I'm now certain it happens >

[PATCH 00/11] ide/ppc: remove PPC specific IDE hacks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Previous patchset adding warm-plug support allows the removal of PPC specific IDE hacks (500 LOC gone)... [ Ben, please take a look when you have some time, thanks! ] diffstat: arch/powerpc/kernel/setup_32.c |8 -- arch/powerpc/platforms/powermac/pci.c | 22 ---

Re: [PATCH 3/8] IPMI: Run to completion fixes

2008-02-13 Thread Corey Minyard
Andrew Morton wrote: On Wed, 13 Feb 2008 10:23:42 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: From: Corey Minyard <[EMAIL PROTECTED]> The "run_to_completion" mode was somewhat broken. Locks need to be avoided in run_to_completion mode, and it shouldn't be used by normal users, just

Re: [PATCH 7/8] IPMI: convert locked counters to atomics

2008-02-13 Thread Corey Minyard
Andrew Morton wrote: The code forgot to initialise all of these. It just so happens that the all-bits-zero pattern works correctly for all current architectures, so the code should work OK. But there is no reason (I hope) why an architecture cannot implement atomic_t as struct atomic_t {

[PATCH] SCSI: fix data corruption caused by ses v2

2008-02-13 Thread Yinghai Lu
one system: initrd get courrupted: RAMDISK: Compressed image found at block 0 RAMDISK: incomplete write (-28 != 2048) 134217728 crc error VFS: Mounted root (ext2 filesystem). Freeing unused kernel memory: 388k freed init_special_inode: bogus i_mode (17) Warning: unable to open an initial

Re: [GIT PATCH] SCSI bug fixes for 2.6.25-rc1

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 18:02:44 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > This one's not too bad given the number of patches we had in the merge > window. We have the advansys fix, a gdth severe problem fix (wouldn't > scan any devices) a bug fix series for lpfc and a few other odds and >

Re: Upgrade to 2.6.24 breaks NFS service

2008-02-13 Thread Nix
On 13 Feb 2008, Jeff Layton told this: > If upgrading nfs-utils doesn't help, on this box, could you run: > > # rpcinfo -p localhost > > send the output? statd expects that lockd will always be listening on a > UDP socket and some changes recently made it so that when there are > only TCP mounts

Re: [PATCH] printk: implement printk_buf overflow warning

2008-02-13 Thread Tejun Heo
Andrew Morton wrote: > On Wed, 13 Feb 2008 18:03:12 +0900 > Tejun Heo <[EMAIL PROTECTED]> wrote: > >> printk silently truncates messages longer than 1024 - 1 bytes. >> Implement overflow detection and append "$PRINTK_BUF_OVERFLOW$\n" to >> truncated messages. > > I don't think I've ever heard of

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 03:51:58PM -0800, Stephen Hemminger wrote: > On Wed, 13 Feb 2008 15:37:44 -0800 > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote: > > > On Wed, 13 Feb 2008 14:41:34 -0800 > > > "Paul E. McKenney" <[EMAIL

Re: Demand paging for memory regions

2008-02-13 Thread Jesse Barnes
On Wednesday, February 13, 2008 3:43 pm Kanoj Sarcar wrote: > Oh ok, yes, I did see the discussion on this; sorry I > missed it. I do see what notifiers bring to the table > now (without endorsing it :-)). > > An orthogonal question is this: is IB/rdma the only > "culprit" that elevates page

Re: [PATCH REPOST] printk: fix possible printk buffer overrun introduced with recursion check

2008-02-13 Thread Tejun Heo
Hello, Ingo. Ingo Molnar wrote: > but i'm not sure i agree with the moving of these variables inside > vprintk: > >> -/* cpu currently holding logbuf_lock */ >> -static volatile unsigned int printk_cpu = UINT_MAX; >> - >> -const char printk_recursion_bug_msg [] = >> -

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 15:57:38 -0800 (PST) David Miller <[EMAIL PROTECTED]> wrote: > From: Andrew Morton <[EMAIL PROTECTED]> > Date: Wed, 13 Feb 2008 15:52:45 -0800 > > > On Wed, 13 Feb 2008 15:37:44 -0800 > > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > > > > Ah. It does take a bit to get

Semaphores with timeouts

2008-02-13 Thread Ricardo J. Rodríguez
Hi everybody, I'm developing a driver to support a new protocol on the kernel 2.6.x, a real time communication protocol used in robotic fields. Skipping the intro: I need to know if there is any function in the kernel to get the process sleeping, as down_interruptible(...), but with timeouts, I

[GIT PATCH] SCSI bug fixes for 2.6.25-rc1

2008-02-13 Thread James Bottomley
This one's not too bad given the number of patches we had in the merge window. We have the advansys fix, a gdth severe problem fix (wouldn't scan any devices) a bug fix series for lpfc and a few other odds and ends. The patch is available here:

strange SysRq problem

2008-02-13 Thread Hans-Peter Jansen
Hi, I'm suffering from a strange SysRq problem: syslog shows haphazardly "SysRq : HELP" lines, while I definitely didn't triggered them, neither via (PS/2) keyboard, nor via /proc/sysrq-trigger. This is accompanied with stalls of about 15-60 secs. Here's an example: Feb 14 00:16:11 xrated

Re: [ofa-general] Re: Demand paging for memory regions

2008-02-13 Thread Jason Gunthorpe
On Wed, Feb 13, 2008 at 06:23:08PM -0500, Pete Wyckoff wrote: > [EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 20:09 -0800: > > One other area that has not been brought up yet (I think) is the > > applicability of notifiers in letting users know when pinned memory > > is reclaimed by the kernel.

Re: [PATCH] printk: implement printk_buf overflow warning

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 18:03:12 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > printk silently truncates messages longer than 1024 - 1 bytes. > Implement overflow detection and append "$PRINTK_BUF_OVERFLOW$\n" to > truncated messages. I don't think I've ever heard of anyone managing to overflow the

Re: [RFC PATCH] feature-removal: add documentation for exported symbols going away

2008-02-13 Thread Adrian Bunk
On Wed, Feb 13, 2008 at 03:43:31PM -0800, Andrew Morton wrote: > On Thu, 14 Feb 2008 01:22:48 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > I don't get your point why bigger API changes should still be allowed > > without any advance warning while removing an export should require > >

Re: [PATCHSET] printk: implement printk_header() and merging printk, take #3

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 18:09:28 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > This is the third take of implement-printk_header-and-mprintk > patchset. > > Changes from the last take[L] are... > > * Now header is printed on every line of a multiline message. If the > header ends with ':'

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread David Miller
From: Andrew Morton <[EMAIL PROTECTED]> Date: Wed, 13 Feb 2008 15:52:45 -0800 > On Wed, 13 Feb 2008 15:37:44 -0800 > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > > Ah. It does take a bit to get fib_trie into one's build -- allyesconfig > > doesn't cut it. > > This is not good. The sole

Re: [RFC v2 5/5] Atmel MCI: Driver for Atmel on-chip MMC controllers

2008-02-13 Thread Dan Williams
On Feb 13, 2008 2:06 PM, Haavard Skinnemoen <[EMAIL PROTECTED]> wrote: > On Wed, 13 Feb 2008 12:11:58 -0700 > "Dan Williams" <[EMAIL PROTECTED]> wrote: > > > > + desc = chan->device->device_prep_slave(chan, > > > + sg_dma_address(sg), direction, > > > +

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 15:52:45 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 13 Feb 2008 15:37:44 -0800 > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > > Ah. It does take a bit to get fib_trie into one's build -- allyesconfig > > doesn't cut it. > > This is not good. The sole

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 15:37:44 -0800 "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > Ah. It does take a bit to get fib_trie into one's build -- allyesconfig > doesn't cut it. This is not good. The sole purpose of allmodconfig and allyesconfig is for compilation and linkage coverage testing.

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Stephen Hemminger
On Wed, 13 Feb 2008 15:37:44 -0800 "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote: > > On Wed, 13 Feb 2008 14:41:34 -0800 > > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > > > > On Wed, Feb 13, 2008 at 02:35:37PM -0800,

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Greg KH wrote: > On Wed, Feb 13, 2008 at 11:20:36PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Wednesday 13 February 2008, Greg KH wrote: > > > On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote: > > > > On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej

Re: [PATCH] SCSI: fix data corruption caused by ses

2008-02-13 Thread Yinghai Lu
On Wednesday 13 February 2008 03:25:27 pm James Bottomley wrote: > On Tue, 2008-02-12 at 23:10 -0800, Yinghai Lu wrote: > > if (type_ptr[0] != ENCLOSURE_COMPONENT_DEVICE && > > type_ptr[0] != ENCLOSURE_COMPONENT_ARRAY_DEVICE) > > -

Re: [RFC PATCH] feature-removal: add documentation for exported symbols going away

2008-02-13 Thread Andrew Morton
On Thu, 14 Feb 2008 01:22:48 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > I don't get your point why bigger API changes should still be allowed > without any advance warning while removing an export should require > deprecation periods. Because the cost to us of giving people a few months

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Greg KH
On Wed, Feb 13, 2008 at 11:20:36PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Wednesday 13 February 2008, Greg KH wrote: > > On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote: > > > On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote: > > > > On Wednesday 13 February

[RFC PATCH] PCI: remove initial bios sort of PCI devices on x86

2008-02-13 Thread Greg KH
We currently keep 2 lists of PCI devices in the system, one in the driver core, and one all on its own. This second list is sorted at boot time, in "BIOS" order, to try to remain compatible with older kernels (2.2 and earlier days). There was also a "nosort" option to turn this sorting off, to

Re: [ofa-general] Re: Demand paging for memory regions

2008-02-13 Thread Kanoj Sarcar
--- Christoph Lameter <[EMAIL PROTECTED]> wrote: > On Wed, 13 Feb 2008, Kanoj Sarcar wrote: > > > It seems that the need is to solve potential > memory > > shortage and overcommit issues by being able to > > reclaim pages pinned by rdma driver/hardware. Is > my > > understanding correct? > >

Re: [2.6 patch] make secmark_tg_destroy() static

2008-02-13 Thread James Morris
On Wed, 13 Feb 2008, Paul Moore wrote: > On Wednesday 13 February 2008 4:29:40 pm Adrian Bunk wrote: > > This patch makes the needlessly global secmark_tg_destroy() static. > > > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > Thanks for catching this. > > Acked-by: Paul Moore <[EMAIL

Re: [GIT PATCH] split up feature-removal-schedule.txt

2008-02-13 Thread Junio C Hamano
Linus Torvalds <[EMAIL PROTECTED]> writes: > On Wed, 13 Feb 2008, Linus Torvalds wrote: >> >> So in that sense, I think both MAINTAINERS and the deprecation schedule >> are totally uninteresting. Yes, they have merge conflicts. But those merge >> conflicts are really really easy to handle. > >

Re: [PATCH 1/2] remove rcu_assign_pointer(NULL) penalty with type/macro safety

2008-02-13 Thread Paul E. McKenney
On Wed, Feb 13, 2008 at 02:42:33PM -0800, Stephen Hemminger wrote: > On Wed, 13 Feb 2008 14:41:34 -0800 > "Paul E. McKenney" <[EMAIL PROTECTED]> wrote: > > > On Wed, Feb 13, 2008 at 02:35:37PM -0800, Stephen Hemminger wrote: > > > On Wed, 13 Feb 2008 14:00:24 -0800 > > > "Paul E. McKenney"

Re: IDE cdrom problem with PLEXTOR DVDR PX-608AL

2008-02-13 Thread Hans-Peter Jansen
Am Dienstag, 12. Februar 2008 schrieb Borislav Petkov: > On Tue, Feb 12, 2008 at 10:26:17AM +0100, Hans-Peter Jansen wrote: > > Hi, > > > > I suffer from unreliable cdrom operations (failing DAE and burn > > sessions) with the openSUSE 2.6.18.8-0.7-bigsmp kernel. > > >

Re: [Patch 0/2] powerpc: avoid userspace poking to legacy ioports

2008-02-13 Thread Arnd Bergmann
On Wednesday 13 February 2008, Benjamin Herrenschmidt wrote: > On Wed, 2008-02-13 at 18:35 +0100, Christian Krafft wrote: > > sensors_detect crashes kernel on PowerPC, as it pokes directly to memory. > > This patch adds a check_legacy_ioports to read_port and write_port. > > It will now return

[PATCH] kprobes: remove sparse warnings from x86

2008-02-13 Thread Harvey Harrison
arch/x86/kernel/kprobes.c:584:16: warning: symbol 'kretprobe_trampoline_holder' was not declared. Should it be static? arch/x86/kernel/kprobes.c:676:6: warning: symbol 'trampoline_handler' was not declared. Should it be static? Make them static and add the __used attribute, approach taken from

Re: [PATCH 8/8] IPMI: Convert locked counters to atomics in the system interface

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 10:34:32 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: > +struct smi_stats > +{ > + atomic_t short_timeouts; > + atomic_t long_timeouts; > + atomic_t timeout_restarts; > + atomic_t idles; > + atomic_t interrupts; > + atomic_t attentions; > +

Re: problem with starting 2.5.25-rc1 and latest git

2008-02-13 Thread Mariusz Kozlowski
Of course there is a typo in the subject :) 2.5.25-rc1 -> 2.6.25-rc1 > Hello, > > I tried 2.6.25-rc1 and latest git on my laptop (x86 32bit) and have a > problem. > Linux boots but with huge delay due to some issue with loading usb modules. > Udev complains: > > 'Could not lock modprobe

Re: [PATCH 7/8] IPMI: convert locked counters to atomics

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 10:32:20 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: > From: Konstantin Baydarov <[EMAIL PROTECTED]> > > Atomics are a lot more efficient and neat than using a lock. > Yes, but... > +struct ipmi_stats > +{ > + /* Commands we got that were invalid. */ > +

Re: [PATCH] SCSI: fix data corruption caused by ses

2008-02-13 Thread James Bottomley
On Tue, 2008-02-12 at 23:10 -0800, Yinghai Lu wrote: > if (type_ptr[0] != ENCLOSURE_COMPONENT_DEVICE && > type_ptr[0] != ENCLOSURE_COMPONENT_ARRAY_DEVICE) > - continue; > + goto next; > + >

Re: [PATCH 1/4 resend] [x86] Add generic GPIO support to x86

2008-02-13 Thread David Brownell
On Wednesday 13 February 2008, Andrew Morton wrote: > Someone please fix. This is what I was using purely for test builds ... most x86 hardware actually has no GPIOs, and I sure don't have any of the "unusual" x86 platforms here, so I'd not want to see this version merge. Someone more clued in

Re: [PATCH 6/8] IPMI: Update driver version

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 10:30:48 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: > Enough bug fixes and changes that we need a new driver version. Are none of them serious enough to warrant a 2.6.24.x backport? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH 4/8] IPMI: Don't grab locks in run-to-completion mode

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 10:27:49 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: > This patch prevents deadlocks in IPMI panic handler caused by msg_lock > in smi_info structure and waiting_msgs_lock in ipmi_smi structure. Again, what are the newly-added barrier()s for? Was cpu_relax() intended? If

Re: [ofa-general] Re: Demand paging for memory regions

2008-02-13 Thread Pete Wyckoff
[EMAIL PROTECTED] wrote on Tue, 12 Feb 2008 20:09 -0800: > One other area that has not been brought up yet (I think) is the > applicability of notifiers in letting users know when pinned memory > is reclaimed by the kernel. This is useful when a lower-level > library employs lazy deregistration

Re: [RFC PATCH] feature-removal: add documentation for exported symbols going away

2008-02-13 Thread Adrian Bunk
On Wed, Feb 13, 2008 at 02:54:05PM -0800, Andrew Morton wrote: > On Thu, 14 Feb 2008 00:43:08 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > There's simply no point in treating the removal of exports differently > > from the many other API breaks we have in each release. > > I have

Re: [PATCH 3/8] IPMI: Run to completion fixes

2008-02-13 Thread Andrew Morton
On Wed, 13 Feb 2008 10:23:42 -0600 Corey Minyard <[EMAIL PROTECTED]> wrote: > From: Corey Minyard <[EMAIL PROTECTED]> > > The "run_to_completion" mode was somewhat broken. Locks need to be > avoided in run_to_completion mode, and it shouldn't be used by normal > users, just internally for panic

Re: [RFC/PATCH] [POWERPC] Make lmb support large physical addressing

2008-02-13 Thread David Miller
From: Benjamin Herrenschmidt <[EMAIL PROTECTED]> Date: Thu, 14 Feb 2008 09:50:42 +1100 > > On Wed, 2008-02-13 at 16:43 -0600, Becky Bruce wrote: > > Convert the lmb code to use phys_addr_t instead of unsigned long for > > physical addresses and sizes. This is needed to support large amounts > >

Re: Compiler for mn10300?

2008-02-13 Thread David Howells
Adrian Bunk <[EMAIL PROTECTED]> wrote: > How can I get a compiler suitable for mn10300? ftp://ftp.redhat.com/pub/redhat/gnupro/AM33/am33-04r2-5/tools David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [2.6 patch] #if 0 aoedev_isbusy()

2008-02-13 Thread Ed L. Cashin
On Thu, Feb 14, 2008 at 12:05:37AM +0200, Adrian Bunk wrote: > On Wed, Feb 13, 2008 at 11:03:35PM +0100, Jan Engelhardt wrote: > > > > On Feb 13 2008 23:30, Adrian Bunk wrote: > > > > > >This patch #if 0's the no longer used aoedev_isbusy(). > > > > Why not just remove it? (It can be resurrected

Re: [RFC PATCH] feature-removal: add documentation for exported symbols going away

2008-02-13 Thread Arjan van de Ven
On Wed, 13 Feb 2008 14:22:06 -0800 Harvey Harrison <[EMAIL PROTECTED]> wrote: > Signed-off-by: Harvey Harrison <[EMAIL PROTECTED]> > --- > Documentation/feature-removal-schedule.txt | 10 -- > Documentation/feature-removal/exported-symbols.txt | 34 > >

Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"

2008-02-13 Thread Rafael J. Wysocki
On Thursday, 14 of February 2008, Alexey Dobriyan wrote: > On Wed, Feb 13, 2008 at 11:52:46PM +0100, Rafael J. Wysocki wrote: > > On Monday, 4 of February 2008, Alexey Dobriyan wrote: > > > Commit c40a22e0ce5eb400f27449e59e43d021bee58b8d aka > > > "PCI: Fix bus resource assignment on 32 bits with

Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"

2008-02-13 Thread Benjamin Herrenschmidt
On Wed, 2008-02-13 at 23:52 +0100, Rafael J. Wysocki wrote: > On Monday, 4 of February 2008, Alexey Dobriyan wrote: > > Commit c40a22e0ce5eb400f27449e59e43d021bee58b8d aka > > "PCI: Fix bus resource assignment on 32 bits with 64b resources" > > renders one tg3-equipped box networkless here. > >

Re: tg3 broken after "PCI: Fix bus resource assignment on 32 bits with 64b resources"

2008-02-13 Thread Alexey Dobriyan
On Wed, Feb 13, 2008 at 11:52:46PM +0100, Rafael J. Wysocki wrote: > On Monday, 4 of February 2008, Alexey Dobriyan wrote: > > Commit c40a22e0ce5eb400f27449e59e43d021bee58b8d aka > > "PCI: Fix bus resource assignment on 32 bits with 64b resources" > > renders one tg3-equipped box networkless here.

Re: [2.6 patch] thinkpad_acpi.c: make 2 functions static

2008-02-13 Thread Henrique de Moraes Holschuh
On Wed, 13 Feb 2008, Adrian Bunk wrote: > this_patch_makes_the_needlessly_global_hotkey_wakeup_reason_notify_change_and_hotkey_wakeup_hotunplug_complete_notify_change_static > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > > ;-) > > da7d9b1a1d74ba5265d02e316a215540fe2daf19 diff

Re: [PATCH] SMACK: add maintainers entry

2008-02-13 Thread Casey Schaufler
--- Jiri Kosina <[EMAIL PROTECTED]> wrote: > Casey, > > what do you think about this one? :) We really should have entry for smack > there. Thanks. I would be delighted and proud for this patch to go in. Thank you. > > > From: Jiri Kosina <[EMAIL PROTECTED]> > > SMACK: add maintainers

Re: [ofa-general] Re: Demand paging for memory regions

2008-02-13 Thread Christoph Lameter
On Wed, 13 Feb 2008, Kanoj Sarcar wrote: > It seems that the need is to solve potential memory > shortage and overcommit issues by being able to > reclaim pages pinned by rdma driver/hardware. Is my > understanding correct? Correct. > If I do understand correctly, then why is rdma page >

Re: [RFC PATCH] feature-removal: add documentation for exported symbols going away

2008-02-13 Thread Adrian Bunk
On Wed, Feb 13, 2008 at 02:42:30PM -0800, Harvey Harrison wrote: > On Thu, 2008-02-14 at 00:34 +0200, Adrian Bunk wrote: > > On Wed, Feb 13, 2008 at 02:22:06PM -0800, Harvey Harrison wrote: > > > + > > > +What:__inet_hash_connect > > > +Where: net/ipv4/inet_hashtables.c > > > +When:

Re: [PATCH] fib_trie: rcu_assign_pointer warning fix

2008-02-13 Thread Paul E. McKenney
On Tue, Feb 12, 2008 at 08:46:30PM +0100, Jarek Poplawski wrote: > On Tue, Feb 12, 2008 at 08:32:18PM +0100, Jarek Poplawski wrote: > ... > > It seems the above version of this macro uses the barrier for 0, but > > if I miss something, or for these other: documenting reasons, > > ...or

<    1   2   3   4   5   6   7   8   9   10   >