Re: [RFC v2 0/3][TESTS] LAB: Support for Legacy Application Booster governor - tests results

2013-05-23 Thread Lukasz Majewski
Hi Viresh, > > > On 22 May 2013 15:57, Lukasz Majewski > > wrote: > > >> On 3 May 2013 19:37, Jonghwa Lee > > >> wrote: > > > > > I think, that overclocking support is crucial here. As you pointed > > > out > > > - ondemand and conservative benefit from it. Therefore, I would > > > urge for

Re: [PATCH 3/6] dma: Add a jz4740 dmaengine driver

2013-05-23 Thread Lars-Peter Clausen
On 05/24/2013 06:59 AM, Vinod Koul wrote: > On Thu, May 23, 2013 at 10:36:24PM +0200, Lars-Peter Clausen wrote: >> This patch adds dmaengine support for the JZ4740 DMA controller. For now the >> driver will be a wrapper around the custom JZ4740 DMA API. Once all users of >> the >> custom JZ4740

Re: [PATCH] dma: use platform_{get,set}_drvdata()

2013-05-23 Thread Vinod Koul
On Fri, May 24, 2013 at 10:10:13AM +0900, Jingoo Han wrote: > Use the wrapper functions for getting and setting the driver data using > platform_device instead of using dev_{get,set}_drvdata() with >dev, > so we can directly pass a struct platform_device. > > Also, unnecessary dev_set_drvdata()

Re: [PATCH v7 09/11] KVM: MMU: introduce kvm_mmu_prepare_zap_obsolete_page

2013-05-23 Thread Xiao Guangrong
On 05/24/2013 01:39 PM, Xiao Guangrong wrote: >>> if (kvm_mmu_prepare_zap_page(sp, list)) >>> hlist_del(sp->hlist); >>> >>> Or, i missed your suggestion? >> My assumption is that we can leave obsolete shadow pages on hashtable >> till commit_zap time. > > Ah, i see. > > Yes, i agree with

Re: [RFC PATCH] fs: call_usermodehelper_root helper introduced

2013-05-23 Thread Stanislav Kinsbursky
23.05.2013 23:55, J. Bruce Fields пишет: On Thu, May 23, 2013 at 09:05:26AM -0400, Jeff Layton wrote: On Thu, 23 May 2013 15:25:20 +0300 I'm not familiar with nfsdcltrack but I would imagine it receives it's information from Kernel as a command line parameters. Would it not be the simplest

Re: [PATCH v7 09/11] KVM: MMU: introduce kvm_mmu_prepare_zap_obsolete_page

2013-05-23 Thread Xiao Guangrong
On 05/23/2013 11:57 PM, Gleb Natapov wrote: > On Thu, May 23, 2013 at 09:03:50PM +0800, Xiao Guangrong wrote: >> On 05/23/2013 08:39 PM, Gleb Natapov wrote: >>> On Thu, May 23, 2013 at 07:13:58PM +0800, Xiao Guangrong wrote: On 05/23/2013 04:09 PM, Gleb Natapov wrote: > On Thu, May 23,

Re: [net-next RFC 6/8] macvtap: allow TUNSETIFF to create multiqueue device

2013-05-23 Thread Jason Wang
On 05/23/2013 07:45 PM, Michael S. Tsirkin wrote: > On Thu, May 23, 2013 at 11:12:31AM +0800, Jason Wang wrote: >> Though the queue were in fact created by open(), we still need to add this >> check >> to be compatible with tuntap which can let mgmt software use a single API to >> manage queues.

Re: [PATCH 3/6] dma: Add a jz4740 dmaengine driver

2013-05-23 Thread Vinod Koul
On Thu, May 23, 2013 at 10:36:24PM +0200, Lars-Peter Clausen wrote: > This patch adds dmaengine support for the JZ4740 DMA controller. For now the > driver will be a wrapper around the custom JZ4740 DMA API. Once all users of > the > custom JZ4740 DMA API have been converted to the dmaengine API

RE: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue

2013-05-23 Thread B, Ravi
Subject: Re: [PATCH v1 2/9] usb: musb: nop: remove unused nop_xceiv_(un)register APIs from glue Hello. On 05/23/2013 09:07 PM, B, Ravi wrote: >>> removed unused nop xceiv (un_)register API's from all musb platform >>> drivers >> Since when are they unused? > Please refer to commit id

RE: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx

2013-05-23 Thread B, Ravi
Subject: Re: [PATCH v1 8/9] usb: phy: dts: Adding usbphy DT bindings for am33xx Hello. On 05/23/2013 09:13 PM, B, Ravi wrote: > >>> + phy1: usbphy-gs70@44e10620 { >>> + compatible = "ti,dsps-usbphy"; >>> + reg = <0x44e10620 0x8 >>> +

Re: [net-next RFC 5/8] macvtap: eliminate linear search

2013-05-23 Thread Jason Wang
On 05/23/2013 07:41 PM, Michael S. Tsirkin wrote: > On Thu, May 23, 2013 at 11:12:30AM +0800, Jason Wang wrote: >> Linear search were used in both get_slot() and macvtap_get_queue(), this is >> because: >> >> - macvtap didn't reshuffle the array of taps when create or destroy a queue, >> so >>

Re: [PATCH] cpufreq: fix governor start/stop race condition

2013-05-23 Thread Viresh Kumar
On 23 May 2013 08:14, Xiaoguang Chen wrote: > Do you mean my patch will cause deadlock? I once tried to add another lock > to protect the GOV_STOP/START sequence instead of using the rwsem in this > patch. > But I saw deadlock indeed. > In cpufreq_add_policy_cpu, the lock has to be added before

Re: [PATCH] Documentation/kdump: Remove TODO in this document

2013-05-23 Thread Zhang Yanfei
Add cc'ing triv...@kernel.org 于 2013年05月24日 12:54, Rob Landley 写道: > On 05/23/2013 03:30:15 AM, Zhang Yanfei wrote: >> We have already had the relocatable kernel, so just remove >> the TODO in the kdump document. >> >> Signed-off-by: Zhang Yanfei > > Acked-by: Rob Landley > > Please forward

Re: [net-next RFC 4/8] macvlan: reduce the max number of taps to 8

2013-05-23 Thread Jason Wang
On 05/23/2013 02:37 PM, Michael S. Tsirkin wrote: > On Thu, May 23, 2013 at 11:12:29AM +0800, Jason Wang wrote: >> To be same with tap. >> >> Signed-off-by: Jason Wang > Well for tap the very specific reason was that > there's an array of big queue structures, > so we need to limit it to make it

Re: [PATCH] Documentation/kdump: Remove TODO in this document

2013-05-23 Thread Rob Landley
On 05/23/2013 03:30:15 AM, Zhang Yanfei wrote: We have already had the relocatable kernel, so just remove the TODO in the kdump document. Signed-off-by: Zhang Yanfei Acked-by: Rob Landley Please forward to triv...@kernel.org Rob-- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] build some drivers only when compile-testing

2013-05-23 Thread Rob Landley
On 05/23/2013 09:01:40 AM, Ben Hutchings wrote: On Wed, 2013-05-22 at 19:23 -0700, Greg Kroah-Hartman wrote: > On Wed, May 22, 2013 at 11:18:46AM +0200, Jiri Slaby wrote: > > Some drivers can be built on more platforms than they run on. This > > causes users and distributors packaging burden

RE: [PATCH RFC v3 1/3] i2c: i2c-bfin-twi: convert to devm_* API

2013-05-23 Thread Zhang, Sonic
Acked-by: Sonic Zhang >-Original Message- >From: Libo Chen [mailto:libo.c...@huawei.com] >Sent: Thursday, May 23, 2013 8:00 PM >To: w...@the-dreams.de >Cc: guz.f...@cn.fujitsu.com; Zhang, Sonic; uclinux-dist- >de...@blackfin.uclinux.org; linux-...@vger.kernel.org; linux-

Re: [PATCH] proc: move proc mount options out of pid_namespace

2013-05-23 Thread Stephen Mell
Gu, On Friday, May 24, 2013 11:03:31 Gu Zheng wrote: > Hi Stephen, > > On 05/24/2013 07:32 AM, Stephen Mell wrote: > > > On Thursday, May 23, 2013 18:20:57 Gu Zheng wrote: > > > >> Here it'll create a new proc sb instance which holds the same context as > >> the old ones > >> each time we

Re: [PATCH 6/8] Documentation: Updating a broken link in "the perfect patch"

2013-05-23 Thread Rob Landley
On 05/23/2013 07:49:58 AM, Ben Minerds wrote: The link to Andrews patches were out of date. Replacing with new links. Also slightly reformatted to allow easier selection of links. Signed-off-by: Ben Minerds --- Documentation/development-process/patches/The-Perfect-Patch.txt | 8

Re: [PATCH 1/8] Documentation: Adding "The Perfect Patch" by Andrew Morton

2013-05-23 Thread Joe Perches
On Thu, 2013-05-23 at 23:10 -0500, Rob Landley wrote: > On 05/23/2013 07:49:53 AM, Ben Minerds wrote: > > Adding Andrews advice on patch submission and subdirectory for > > further patch > > documentstion. > > You've seen Documentation/SubmittingPatches right? Maybe not. > > +- Ensure that

Re: [PATCH 5/8] Documentation: Replacing reference to broken submission format URL

2013-05-23 Thread Rob Landley
On 05/23/2013 07:49:57 AM, Ben Minerds wrote: Replacing refs to broken URL with internal documentation reference, and a little whitespace shuffle to keep it under 80 chars wide. Signed-off-by: Ben Minerds --- Documentation/HOWTO | 10 +-

Re: [PATCH 2/8] Documentation: Adding "Linux Kernel Patch Submission Format"

2013-05-23 Thread Rob Landley
On 05/23/2013 07:49:54 AM, Ben Minerds wrote: Adding "Linux Kernel Patch Submission Format" reference to remove external dependancy. Signed-off-by: Ben Minerds --- .../patches/Patch-Submission-Format.txt| 89 ++ ... +For more details, read

Re: [PATCH 1/8] Documentation: Adding "The Perfect Patch" by Andrew Morton

2013-05-23 Thread Rob Landley
On 05/23/2013 07:49:53 AM, Ben Minerds wrote: Adding Andrews advice on patch submission and subdirectory for further patch documentstion. You've seen Documentation/SubmittingPatches right? Signed-off-by: Ben Minerds --- .../patches/The-Perfect-Patch.txt | 167

Re: [PATCH 1/2] mmc: sdhci: Added set_power sdhci_ops handler.

2013-05-23 Thread Jaehoon Chung
On 05/23/2013 04:25 PM, Guennadi Liakhovetski wrote: > On Wed, 22 May 2013, Felipe Ferreri Tonello wrote: > >> Hi Guennadi, >> >> On Wednesday, May 22, 2013 10:30:40 PM Guennadi Liakhovetski wrote: >>> On Wed, 22 May 2013, Felipe F. Tonello wrote: From: "Felipe F. Tonello" This is

Re: [PATCH RFC v3 2/3] i2c: pxa: convert to devm_* API

2013-05-23 Thread Libo Chen
On 2013/5/24 11:35, Gu Zheng wrote: > Hi Libo, >I think you can merge patch 1/3 and 2/3, they e thdo the saming that using > devm_* API to simplify > and make the code clean, and the additional goal is it also can fix a bug. > Besides, maybe you need to > change the title and make it clear

Re: [PATCH 2/2] mmc: sdhci-s3c: Added set_power handler to platdata

2013-05-23 Thread Jaehoon Chung
Hi Felipe, I didn't understand this patch, why need to add set_power? We can use to control the power with the fixed regulator. Then we can also use the regulator framework. And i know also control the module like wifi with rfkill. In set_power, what is it controlled? Best Regards, Jaehoon Chung

Re: [PATCH 03/07] Documentation patch of ams AS3722 PMIC against linux_3.8.8

2013-05-23 Thread Rob Landley
On 05/23/2013 07:07:37 AM, Florian Lobmaier wrote: From: Florian Lobmaier Added multi-function device driver support for ams AS3722 PMIC Includes modules gpio, regulator, rtc, and watchdog Signed-off-by: Florian Lobmaier This seems like company-internal documentation that's got large

Re: [PATCH RFC v3 2/3] i2c: pxa: convert to devm_* API

2013-05-23 Thread Li Zefan
On 2013/5/24 11:35, Gu Zheng wrote: > Hi Libo, >I think you can merge patch 1/3 and 2/3, they do the same thing that using > devm_* API to simplify > and make the code clean, and the additional goal is it also can fix a bug. nope. they should be separated. > Besides, maybe you need to >

BUG_ON in virtio-ring.c

2013-05-23 Thread Dave Airlie
Hi Rusty, current virtio-ring.c has a BUG_ON in virtqueue_add that checks total_sg > vg->vring.num, however I'm not sure it really is 100% correct. If I have an indirect ring and I'm adding sgs to it and the host is delayed (say I've got a thread consuming things from the vring and its off doing

Re: [PATCH v2 00/12] VFS hot tracking

2013-05-23 Thread Zhi Yong Wu
HI, Al Viro. I have incorporated all comments from all reviewers and waited for so long time. If you have no comments, can you merge the patchset? thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH RFC v3 2/3] i2c: pxa: convert to devm_* API

2013-05-23 Thread Gu Zheng
Hi Libo, I think you can merge patch 1/3 and 2/3, they do the same thing that using devm_* API to simplify and make the code clean, and the additional goal is it also can fix a bug. Besides, maybe you need to change the title and make it clear and self-described. Thanks, Gu On 05/23/2013

Re: [Suggestion] fs/namespace.c: the direct cause of the warning for: "ida_remove called for id=0 which is not allocated" with mnt_release_group_id()

2013-05-23 Thread Chen Gang
> From: Takashi Iwai > Subject: vfs: fix invalid ida_remove() call > > When the group id of a shared mount is not allocated, the umount still > tries to call mnt_release_group_id(), which eventually hits a kernel > warning at ida_remove() spewing a message like: > > ida_remove called for id=0

Re: 3.9.2/3.9.3: stack overrun on s390x and ppc64 (WAS Re: 3.9.2: xfstests triggered panic)

2013-05-23 Thread CAI Qian
OK, here is clearer stack output from the run. CAI Qian + ./check FSTYP -- xfs (non-debug) PLATFORM -- Linux/s390x ibm-z10-23 3.9.3 001 29s 002 3s 003 2s 004 [not run] this test requires a valid $SCRATCH_DEV 005 2s 006 9s 007 10s 008 7s 009

Re: [PATCH] scsi: megaraid: check kzalloc

2013-05-23 Thread Santosh Y
On Fri, May 24, 2013 at 7:52 AM, Libo Chen wrote: > > we should check kzalloc, avoid to hit oops > > Signed-off-by: Libo Chen > --- > drivers/scsi/megaraid.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c >

Re: [ANNOUNCE] ktap 0.1 released

2013-05-23 Thread zhangwei(Jovi)
On 2013/5/22 2:13, Frank Ch. Eigler wrote: > "zhangwei(Jovi)" writes: > >> I'm pleased to announce that ktap release v0.1, this is the first official >> release of ktap project [...] > > Congrats. > > >> = what's ktap? >> >>Because this is the first release, so there wouldn't include too

Re: [PATCH RFC v3 1/3] i2c: i2c-bfin-twi: convert to devm_* API

2013-05-23 Thread Sachin Kamat
On 23 May 2013 17:30, Libo Chen wrote: > peripheral_request_list has got free if any one faild, so no need to free > again in err case. > aovid this, convert them to devm_* API > > Signed-off-by: Libo Chen It is a good practice to include changelog while submitting revised versions of the

Re: [PATCH 0/5 v2] VFIO PPC64: add VFIO support on POWERPC64

2013-05-23 Thread Alexey Kardashevskiy
On 05/24/2013 12:56 AM, Alex Williamson wrote: > On Tue, 2013-05-21 at 13:33 +1000, Alexey Kardashevskiy wrote: >> The series adds support for VFIO on POWERPC in user space (such as QEMU). >> The in-kernel real mode IOMMU support is added by another series posted >> separately. >> >> As the first

Re: [PATCH RFC v3 1/3] i2c: i2c-bfin-twi: convert to devm_* API

2013-05-23 Thread Libo Chen
On 2013/5/24 10:49, Zhang, Sonic wrote: >> >- iface = kzalloc(sizeof(struct bfin_twi_iface), GFP_KERNEL); >> >+ iface = devm_kzalloc(>dev, sizeof(struct bfin_twi_iface), >> >+ GFP_KERNEL); >> > if (!iface) { >> > dev_err(>dev, "Cannot allocate

Re: [PATCH] proc: move proc mount options out of pid_namespace

2013-05-23 Thread Gu Zheng
Hi Stephen, On 05/24/2013 07:32 AM, Stephen Mell wrote: > On Thursday, May 23, 2013 18:20:57 Gu Zheng wrote: > >> Here it'll create a new proc sb instance which holds the same context as the >> old ones >> each time we mount proc though in the same PID namespace, won't it? > I believe so. But

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-23 Thread Dave Jones
On Thu, May 23, 2013 at 09:52:19PM -0400, Dave Jones wrote: > On Fri, May 24, 2013 at 11:26:25AM +1000, Dave Chinner wrote: > > > You want to print the debug output if the masked value != 0. > > XFS (sda2): xfs_setattr_size: mask 0xaa69, masked 0x801 ii > 0x8802129e98c0, d

Re: [PATCH] regulator: 88pm800: add regulator driver

2013-05-23 Thread yi zhang
Hi, Brown: 2013/5/23 Mark Brown : > On Wed, May 22, 2013 at 08:10:53PM +0800, yizhang.m...@gmail.com wrote: > > You need a DT binding document for any new DT bindings like this one. > Thanks for your comments, I'll do it; >> +static const unsigned int BUCK1_table[] = { >> + /* 0x00-0x4F:

[PATCH] usb/xhci: unify parameter of xhci_msi_irq

2013-05-23 Thread Alex Shi
Ops, I just find a old patch left on my laptop. and it still works on latest Linus tree. I don't remember there is a reasonable excuse to reject this patch. So, anyone like to pick it up? -- >From 6ae1b9e71f9b14be5774ae9c1b4cf57cd4e747ac Mon Sep 17 00:00:00 2001 From: Alex Shi Date: Mon,

Re: [PATCH v2 0/4] dma-mapping: Define dma_{alloc,free}_attrs() for all archs

2013-05-23 Thread Damian Hobson-Garcia
On 2013/05/23 18:47, Catalin Marinas wrote: > On Thu, May 23, 2013 at 03:47:13AM +0100, Damian Hobson-Garcia wrote: >> Hi Catalin, >> On 2013/05/22 18:47, Catalin Marinas wrote: >>> On Wed, May 22, 2013 at 03:37:17AM +0100, Damian Hobson-Garcia wrote: Hello, On 2013/04/30 12:01, Damian

RE: [PATCH RFC v3 1/3] i2c: i2c-bfin-twi: convert to devm_* API

2013-05-23 Thread Zhang, Sonic
Hi Libo, >-Original Message- >From: Libo Chen [mailto:libo.c...@huawei.com] >Sent: Thursday, May 23, 2013 8:00 PM >To: w...@the-dreams.de >Cc: guz.f...@cn.fujitsu.com; Zhang, Sonic; uclinux-dist- >de...@blackfin.uclinux.org; linux-...@vger.kernel.org; linux- >ker...@vger.kernel.org;

[PATCH 3.9-stable] staging:iio:light:tsl2x7x: fix the error handling in tsl2x7x_probe()

2013-05-23 Thread Jonghwan Choi
This patch looks like it should be in the 3.9-stable tree, should we apply it? -- From: "Wei Yongjun " commit 3b813798aa7030f1beef638c75f8b0008f737a82 upstream Fix to return -EINVAL in the i2c device found error handling case instead of 0, as done elsewhere in this function.

[PATCH 3.9-stable] staging/iio/mxs-lradc: fix preenable for multiple

2013-05-23 Thread Jonghwan Choi
This patch looks like it should be in the 3.9-stable tree, should we apply it? -- From: "Michał Mirosław " commit c80712c793febdf1b13ad0e1c71a051e071b3fd8 upstream This fixes 'preenable failed: -EINVAL' error when using this driver. Signed-off-by: Michał Mirosław "

[PATCH] scsi: megaraid: check kzalloc

2013-05-23 Thread Libo Chen
we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c index 846f475..195b095 100644 --- a/drivers/scsi/megaraid.c +++

[PATCH] x86: Have debug/nmi restore the IDT it replaced

2013-05-23 Thread Steven Rostedt
I've sent this out before, and I'm sending it out again. https://patchwork.kernel.org/patch/2082571/ It was ignored because I signed it with "Not-yet-signed-off-by". This time I'm signing it off with a real full signed off by, as this will help with Seiji's patch set to do the IDT swap to enable

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-23 Thread Dave Jones
On Fri, May 24, 2013 at 11:26:25AM +1000, Dave Chinner wrote: > You want to print the debug output if the masked value != 0. XFS (sda2): xfs_setattr_size: mask 0xaa69, masked 0x801 ii 0x8802129e98c0, d 0x88021757d970 path /davej/src/trinity/tmp/tmp.5/ Dave -- To unsubscribe

Re: [PATCH 00/11] sysv mqueue: do not hold the ipc lock unnecessarily

2013-05-23 Thread Davidlohr Bueso
ping, Andrew? On Wed, 2013-05-15 at 18:07 -0700, Davidlohr Bueso wrote: > This patchset continues the work that began in the sysv ipc semaphore scaling > series: https://lkml.org/lkml/2013/3/20/546 > > Just like semaphores used to be, sysv shared memory and msg queues also abuse > the ipc >

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-23 Thread Tejun Heo
On Thu, May 23, 2013 at 11:47:25AM +0200, Paolo Bonzini wrote: > > No no, I'm not talking about it not working for the users - it's just > > passing the commands, it of course works. I'm doubting about it being > > a worthy security isolation layer. cdb filtering (of any form really) > > has

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-23 Thread Dave Jones
On Fri, May 24, 2013 at 11:26:25AM +1000, Dave Chinner wrote: > You want to print the debug output if the masked value != 0. Derp. Thanks. Rerunning the tests now. Hopefully I'll have something in a few hours. Dave -- To unsubscribe from this list: send the line "unsubscribe

Re: Is spin_is_locked() safe to use with BUG_ON()/WARN_ON()?

2013-05-23 Thread Ryan Mallon
On 24/05/13 01:12, David Howells wrote: > Linus Torvalds wrote: > >> We do *not* want to add some crazy "spin_is_nt_locked". We just want >> to get rid of these idiotic debug tests. > > Generally, I think you are right, though there are also some checks in > deallocation routines that check

Re: [Suggestion] fs/namespace.c: the direct cause of the warning for: "ida_remove called for id=0 which is not allocated" with mnt_release_group_id()

2013-05-23 Thread Chen Gang
On 05/24/2013 07:18 AM, Andrew Morton wrote: > On Tue, 14 May 2013 17:06:30 +0800 Chen Gang wrote: > >> > After call collect_mounts(), then call drop_collected_mounts(), it will >> > report an warning: "ida_remove called for id=0 which is not allocated" >> > (one sample is audit_add_tree_rule()

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-23 Thread Dave Chinner
On Thu, May 23, 2013 at 08:49:06PM -0400, Dave Jones wrote: > On Fri, May 24, 2013 at 08:30:38AM +1000, Dave Chinner wrote: > > > > > Which I put just before the assert that is firing on your machine. > > > > > > > > And, obviously, it isn't firing on mine and obviously shouldn't be >

Re: [PATCH] kernel/debug/kdb: code enhancement for 3 areas.

2013-05-23 Thread Chen Gang
On 05/24/2013 01:28 AM, Anton Vorontsov wrote: > On Thu, May 16, 2013 at 07:25:46PM +0800, Chen Gang wrote: >> > Delete waste '{' for 'case' statement. >> > >> > For the return variable 'long res' in function kdb_task_state_string(), >> > neither it matches the function return type 'unsigned

[PATCH] dma: use platform_{get,set}_drvdata()

2013-05-23 Thread Jingoo Han
Use the wrapper functions for getting and setting the driver data using platform_device instead of using dev_{get,set}_drvdata() with >dev, so we can directly pass a struct platform_device. Also, unnecessary dev_set_drvdata() is removed, because the driver core clears the driver data to NULL

Kernel Oops on xfrm_output_resume

2013-05-23 Thread laurent . jourden
Hello, I don't know how to handle this, not a lkml subscriber, just reporting this bug to the devs. All 3.9.y kernels crash after about 6 to 9 hours running without error messages before the Oops. I'm running 3.8.13 kernel so far without problem. Even tried 3.10-rc2, same issue. Context :

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-23 Thread Dave Jones
On Fri, May 24, 2013 at 08:30:38AM +1000, Dave Chinner wrote: > > > Which I put just before the assert that is firing on your machine. > > > > > > And, obviously, it isn't firing on mine and obviously shouldn't be > > firing on a > > > mask of 0xa068. > > > > With this, I get a spew

Re: [PATCH 1/1] x86/iommu: use bit structures for context_entry

2013-05-23 Thread ZhenHua
Use lo and hi for clear, may run faster than memset. But it is not a big problem. Never mind. Thanks ZhenHua On 05/24/2013 08:36 AM, Joe Perches wrote: On Fri, 2013-05-24 at 08:22 +0800, Li, Zhen-Hua wrote: There is a structure named context_entry used by intel iommu, and there are some bit

Re: [PATCH 1/1] x86/iommu: use bit structures for context_entry

2013-05-23 Thread Joe Perches
On Fri, 2013-05-24 at 08:22 +0800, Li, Zhen-Hua wrote: > There is a structure named context_entry used by intel iommu, and there > are some bit operations on it. Use bit structure may make these operations > easy. [] > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c [] > @@

[PATCH 1/1] x86/iommu: fix dma pte address size error

2013-05-23 Thread Li, Zhen-Hua
In Intel Vt-D specs, Chapter 9.3 Page-Table Entry, The size of ADDR(address) field is 12:51, but the function dma_pte_addr treats it as 12:63. Signed-off-by: Li, Zhen-Hua --- drivers/iommu/intel-iommu.c |4 ++-- include/linux/dma_remapping.h |2 ++ 2 files changed, 4 insertions(+), 2

[PATCH 1/1] x86/iommu: use bit structures for context_entry

2013-05-23 Thread Li, Zhen-Hua
There is a structure named context_entry used by intel iommu, and there are some bit operations on it. Use bit structure may make these operations easy. Signed-off-by: Li, Zhen-Hua --- drivers/iommu/intel-iommu.c | 88 +++ 1 file changed, 31

[PATCH] mutex: do not unnecessarily deal with waiters

2013-05-23 Thread Davidlohr Bueso
From: Davidlohr Bueso Upon entering the slowpath, we immediately attempt to acquire the lock by checking if it is already unlocked. If we are lucky enough that this is the case, then we don't need to deal with any waiter related logic. Furthermore any checks for an empty wait_list are

Re: [PATCH v3] mm/pagewalk.c: walk_page_range should avoid VM_PFNMAP areas

2013-05-23 Thread Andrew Morton
On Wed, 15 May 2013 07:46:36 -0500 Cliff Wickman wrote: > Certain tests in walk_page_range() (specifically split_huge_page_pmd()) > assume that all the mapped PFN's are backed with page structures. And this is > not usually true for VM_PFNMAP areas. This can result in panics on kernel > page

Re: OOPS in perf_mmap_close()

2013-05-23 Thread Vince Weaver
On Thu, 23 May 2013, Peter Zijlstra wrote: > On Thu, May 23, 2013 at 10:10:36AM -0400, Vince Weaver wrote: > > > > I can confirm your patch avoids the oops on my machine. > > > > It does lead to interesting behavior if I run the sample program > > multiple times (with added printfs): > > > >

Re: [PATCH] proc: move proc mount options out of pid_namespace

2013-05-23 Thread Stephen Mell
On Thursday, May 23, 2013 18:20:57 Gu Zheng wrote: > Here it'll create a new proc sb instance which holds the same context as the > old ones > each time we mount proc though in the same PID namespace, won't it? I believe so. But this is the point, right? They won't be identical if different

Re: [PATCH] msm: iommu: fix leak and invalid access

2013-05-23 Thread Andrew Morton
On Wed, 15 May 2013 12:47:03 +0800 Libo Chen wrote: > It fixes two obvious problems: > 1. We have registered msm_iommu_driver first, and need unregister it when > registered msm_iommu_ctx_driver fail yup, that's a bug. > 2. We don`t need to kfree drvdata before kzalloc successful The code's

Re: [Suggestion] fs/namespace.c: the direct cause of the warning for: "ida_remove called for id=0 which is not allocated" with mnt_release_group_id()

2013-05-23 Thread Andrew Morton
On Tue, 14 May 2013 17:06:30 +0800 Chen Gang wrote: > After call collect_mounts(), then call drop_collected_mounts(), it will > report an warning: "ida_remove called for id=0 which is not allocated" > (one sample is audit_add_tree_rule() in kernel/audit_tree.c). > > The direct cause (maybe also

Re: [PATCH] ARM: avoid mis-detecting some V7 cores in the decompressor

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 10:54:26AM -0700, Stephen Boyd wrote: > On 05/15/13 12:38, Stephen Boyd wrote: > > On 05/08/13 14:47, Stephen Boyd wrote: > >> From: Brian Swetland > >> > >> Currently v7 CPUs with an MIDR that has no bits set in the range > >> [16:12] will be detected as old ARM CPUs with

Re: [PATCH v7] arm: use built-in byte swap function

2013-05-23 Thread Russell King - ARM Linux
On Thu, May 23, 2013 at 11:46:54AM -0500, Kim Phillips wrote: > Enable the compiler intrinsic for byte swapping on arch ARM. This > allows the compiler to detect and be able to optimize out byte > swappings, and has a very modest benefit on vmlinux size (Linaro gcc > 4.8): > >text

Re: [PATCH] x86/PCI: setup data may be in highmem

2013-05-23 Thread H. Peter Anvin
On 05/22/2013 02:43 AM, Matt Fleming wrote: > From: Matt Fleming > > pcibios_add_device() assumes that the physical addresses stored in > setup_data are accessible via the direct kernel mapping, and that > calling phys_to_virt() is valid. This isn't guaranteed to be true on x86 > where the

Re: [PATCH 1/7] staging/silicom/bypasslib: Reformat comments

2013-05-23 Thread Joe Perches
On Thu, 2013-05-23 at 13:51 -0700, Lisa Nguyen wrote: > Resolved the C99 comment style issue by reformatting existing comments > to meet kernel coding standards in bp_ioctl.h [] > diff --git a/drivers/staging/silicom/bypasslib/bp_ioctl.h > b/drivers/staging/silicom/bypasslib/bp_ioctl.h [] >

Re: [PATCH 2/2] net: mv643xx_eth: proper initialization for Kirkwood SoCs

2013-05-23 Thread Sebastian Hesselbarth
On 05/23/2013 08:40 PM, Jason Cooper wrote: On Thu, May 23, 2013 at 11:53:57AM -0600, Jason Gunthorpe wrote: On Thu, May 23, 2013 at 01:23:39PM -0400, Jason Cooper wrote: Shouldn't it rather be compatible = "marvell,kirkwood-eth", "marvell,orion-eth"; Not sure about orion-eth?

Re: [f2fs-dev] [PATCH 3/4] f2fs: return proper error from start_gc_thread

2013-05-23 Thread Namjae Jeon
2013/5/23, Jason Hrycay : > On 5/23/2013 8:58 AM, Namjae Jeon wrote: >> From: Namjae Jeon >> >> when there is an error from kthread_run, then return proper error >> rather than returning -ENOMEM. >> >> Signed-off-by: Namjae Jeon >> Signed-off-by: Amit Sahrawat >> --- >> fs/f2fs/gc.c |2 +-

Re: XFS assertion from truncate. (3.10-rc2)

2013-05-23 Thread Dave Chinner
On Thu, May 23, 2013 at 02:49:48PM -0400, Dave Jones wrote: > On Thu, May 23, 2013 at 07:54:54AM +1000, Dave Chinner wrote: > > > Gah, I've got not idea what the hell I was smoking yesterday > > afternoon. 0x2000 is actually ATTR_FILE, and 0x8000 is ATTR_OPEN. > > > > So a mask of 0xa068 is

RE: [PATCH RFC] sched/rt: preserve global runtime/period ratio in do_balance_runtime()

2013-05-23 Thread Peter Boonstoppel
I think my patch was aiming at enabling rt_runtime borrowing, while preserving the global invariant of not allowing 100% allocation of time to rt_rq. Disabling RT_RUNTIME_SHARE definitely addresses the safety mechanism concern. However, I'd like to understand the original goal of this

Re: [PATCH v8 9/9] vmcore: support mmap() on /proc/vmcore

2013-05-23 Thread Andrew Morton
On Thu, 23 May 2013 14:25:48 +0900 HATAYAMA Daisuke wrote: > This patch introduces mmap_vmcore(). > > Don't permit writable nor executable mapping even with mprotect() > because this mmap() is aimed at reading crash dump memory. > Non-writable mapping is also requirement of remap_pfn_range()

Re: [regression, bisected] x86: efi: Pass boot services variable info to runtime code

2013-05-23 Thread Russ Anderson
On Thu, May 23, 2013 at 12:58:01PM +0100, Matt Fleming wrote: > On Wed, 22 May, at 11:27:47AM, Russ Anderson wrote: > > [6.062157] EFI Variables Facility v0.08 2004-May-17 > > [6.067731] BUG: unable to handle kernel paging request at > > 7ca95b10 > > [6.075519] IP: []

Re: [PATCH v8 6/9] vmcore: allocate ELF note segment in the 2nd kernel vmalloc memory

2013-05-23 Thread Andrew Morton
On Thu, 23 May 2013 14:25:30 +0900 HATAYAMA Daisuke wrote: > The reasons why we don't allocate ELF note segment in the 1st kernel > (old memory) on page boundary is to keep backward compatibility for > old kernels, and that if doing so, we waste not a little memory due to > round-up operation

Re: [PATCH v8 5/9] vmalloc: introduce remap_vmalloc_range_partial

2013-05-23 Thread Andrew Morton
On Thu, 23 May 2013 14:25:24 +0900 HATAYAMA Daisuke wrote: > We want to allocate ELF note segment buffer on the 2nd kernel in > vmalloc space and remap it to user-space in order to reduce the risk > that memory allocation fails on system with huge number of CPUs and so > with huge ELF note

Re: [PATCH v8 3/9] vmcore: treat memory chunks referenced by PT_LOAD program header entries in page-size boundary in vmcore_list

2013-05-23 Thread Andrew Morton
On Thu, 23 May 2013 14:25:13 +0900 HATAYAMA Daisuke wrote: > Treat memory chunks referenced by PT_LOAD program header entries in > page-size boundary in vmcore_list. Formally, for each range [start, > end], we set up the corresponding vmcore object in vmcore_list to > [rounddown(start,

Re: [PATCH, RFC 19/22] staging/solo6x10: depend on CONFIG_FONTS

2013-05-23 Thread Arnd Bergmann
On Thursday 23 May 2013, Geert Uytterhoeven wrote: > Sorry for only noticing this now, but CONFIG_FONTS is not about font support. > It's about allowing the user to override the default list of builtin fonts. > I know it's a bad name, but changing this would break make oldconfig. > Or is this

Re: [PATCH v8 2/9] vmcore: allocate buffer for ELF headers on page-size alignment

2013-05-23 Thread Andrew Morton
On Thu, 23 May 2013 14:25:07 +0900 HATAYAMA Daisuke wrote: > Allocate ELF headers on page-size boundary using __get_free_pages() > instead of kmalloc(). > > Later patch will merge PT_NOTE entries into a single unique one and > decrease the buffer size actually used. Keep original buffer size

Re: [PATCH v2 04/11] pwm: Add Renesas TPU PWM driver

2013-05-23 Thread Thierry Reding
On Wed, Apr 24, 2013 at 10:50:09PM +0200, Laurent Pinchart wrote: > The Timer Pulse Unit (TPU is a 4-channels 16-bit timer used to generate > waveforms. This driver exposes PWM functions through the PWM API for > other drivers to use. > > The code is loosely based on the leds-renesas-tpu driver

Re: [RFC 3/8] mfd:syscon: Introduce claim/read/write/release APIs

2013-05-23 Thread Arnd Bergmann
On Monday 20 May 2013, Srinivas KANDAGATLA wrote: > On 17/05/13 15:36, Arnd Bergmann wrote: > > Some of the drivers like Ethernet already provide higher level > interfaces via callbacks. We did implement such a callbacks per each SOC > in non-DT case, and ended up having code duplicated for each

Re: [PATCH 0/3 v3] dcache: make it more scalable on large system

2013-05-23 Thread Waiman Long
On 05/23/2013 05:42 AM, Dave Chinner wrote: On Wed, May 22, 2013 at 09:37:25PM -0400, Waiman Long wrote: Change log: v2->v3 - Fix the RCU lock problem found by Al Viro. - Rebase the code to the latest v3.10-rc1 linux mainline. - Remove patch 4 which may be problematic if the dentry is

Re: [RFC PATCH] fs: call_usermodehelper_root helper introduced

2013-05-23 Thread Eric W. Biederman
"J. Bruce Fields" writes: > On Thu, May 23, 2013 at 03:55:47PM -0400, J. Bruce Fields wrote: >> On Thu, May 23, 2013 at 09:05:26AM -0400, Jeff Layton wrote: >> > What might help most here is to lay out a particular scenario for how >> > you envision setting up knfsd in a container so we can

Re: [PATCHv6 01/11] clockevents: Prefer CPU local devices over global devices

2013-05-23 Thread Sören Brinkmann
On Mon, May 13, 2013 at 12:26:05PM -0700, Stephen Boyd wrote: > On an SMP system with only one global clockevent and a dummy > clockevent per CPU we run into problems. We want the dummy > clockevents to be registered as the per CPU tick devices, but > we can only achieve that if we register the

[PATCH] fs: ecryptfs: fixed msync to flush data

2013-05-23 Thread Paul Taysom
When msync is called on a memory mapped file, that data is not flushed to the disk. In Linux, msync calls fsync for the file. For ecryptfs, fsync just calls the lower level file system's fsync. Changed the ecryptfs fsync code to call filemap_write_and_wait before calling the lower level fsync.

[GIT PULL] GPIO fixes for v3.10

2013-05-23 Thread Linus Walleij
Hi Linus, here are some GPIO fixes I've collected for the v3.10 series. Detailed info in the signed tag. It's all been in -next and it's all been build tested, yes. Yours, Linus Walleij The following changes since commit f722406faae2d073cc1d01063d1123c35425939e: Linux 3.10-rc1 (2013-05-11

Re: [PATCH V2 0/3] x86/microcode: early microcode patch loading support on AMD

2013-05-23 Thread Jacob Shin
On Thu, May 23, 2013 at 09:01:21PM +, Yu, Fenghua wrote: > > From: Jacob Shin [mailto:jacob.s...@amd.com] > > The following patchset adds early microcode patch loading support on > > AMD systems, on top of the framework introduced by: > > https://lkml.org/lkml/2012/12/21/193 > > > > Could

[PATCH] mtip32xx: dynamically allocate buffer in debugfs functions

2013-05-23 Thread David Milburn
Dynamically allocate buf to prevent warnings: drivers/block/mtip32xx/mtip32xx.c: In function ‘mtip_hw_read_device_status’: drivers/block/mtip32xx/mtip32xx.c:2823: warning: the frame size of 1056 bytes is larger than 1024 bytes drivers/block/mtip32xx/mtip32xx.c: In function

RE: [PATCH V2 0/3] x86/microcode: early microcode patch loading support on AMD

2013-05-23 Thread Yu, Fenghua
> From: Jacob Shin [mailto:jacob.s...@amd.com] > The following patchset adds early microcode patch loading support on > AMD systems, on top of the framework introduced by: > https://lkml.org/lkml/2012/12/21/193 > Could you please change Documentation/x86/early-microcode.txt for AMD? At least

[PATCH 7/7] staging/silicom/bypasslib: Move opening brace to previous line

2013-05-23 Thread Lisa Nguyen
Moved opening brace to previous line to resolve checkpatch errors and meet kernel coding standards in bplibk.h Signed-off-by: Lisa Nguyen --- drivers/staging/silicom/bypasslib/bplibk.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 6/7] staging/silicom/bypasslib: Remove extra space before line

2013-05-23 Thread Lisa Nguyen
Removed extra space at beginning of a statement to resolve checkpatch errors and meet kernel coding standards in bplibk.h Signed-off-by: Lisa Nguyen --- drivers/staging/silicom/bypasslib/bplibk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 5/7] staging/silicom/bypasslib: Add space around ||

2013-05-23 Thread Lisa Nguyen
Added space around piping symbols to resolve checkpatch errors and meet kernel coding standards in bplibk.h Signed-off-by: Lisa Nguyen --- drivers/staging/silicom/bypasslib/bplibk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/silicom/bypasslib/bplibk.h

[PATCH 4/7] staging/silicom/bypasslib: Add space around &

2013-05-23 Thread Lisa Nguyen
Added space around double ampersands to resolve checkpatch errors and meet kernel coding standards in bplibk.h Signed-off-by: Lisa Nguyen --- drivers/staging/silicom/bypasslib/bplibk.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/silicom/bypasslib/bplibk.h

[PATCH 3/7] staging/silicom/bypasslib: Add space around ==

2013-05-23 Thread Lisa Nguyen
Added space around equal signs to resolve checkpatch errors and meet kernel coding standards in bplibk.h Signed-off-by: Lisa Nguyen --- drivers/staging/silicom/bypasslib/bplibk.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/silicom/bypasslib/bplibk.h

[PATCH 2/7] staging/silicom/bypasslib: Fix code indentation errors

2013-05-23 Thread Lisa Nguyen
Fixed code indentation errors generated by checkpatch.pl to meet kernel coding standards in bplibk.h Signed-off-by: Lisa Nguyen --- drivers/staging/silicom/bypasslib/bplibk.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/silicom/bypasslib/bplibk.h

  1   2   3   4   5   6   7   8   9   10   >