Re: [PATCH net-next v3] net: cpsw: Add support for wake-on-lan for cpsw

2013-08-19 Thread Mugunthan V N
On Tuesday 20 August 2013 11:08 AM, ujhely...@gmail.com wrote: > From: Matus Ujhelyi > > Some phy's can be configured to enable wake on lan (e.g. at803x or marvell > 88E1318S). > There is no way how to enable wol on CPSW with such connected phys. This patch > adds this support. It is provided by

Re: [PATCH v1] seq_file: Fix overflow condition in seq_commit

2013-08-19 Thread Al Viro
On Tue, Aug 20, 2013 at 10:55:40AM +0530, Arun KS wrote: > >From 932a134abeac597f18c86c513704709ad154994b Mon Sep 17 00:00:00 2001 > From: Arun KS > Date: Mon, 19 Aug 2013 12:06:33 +0530 > Subject: seq_file: Fix overflow condition in seq_commit > > seq_path()/seq_commit() is treating a d_path()

Re: [PATCH 0/3] mm: mempolicy: the failure processing about mpol_to_str()

2013-08-19 Thread Chen Gang
On 08/20/2013 01:30 PM, Cyrill Gorcunov wrote: > On Tue, Aug 20, 2013 at 11:56:15AM +0800, Chen Gang wrote: >> For the implementation (patch 1/3), need fill buffer as full as >> possible when buffer space is not enough. >> >> For the caller (patch 2/3, 3/3), need check the return value of >>

[PATCH net-next v3] net: cpsw: Add support for wake-on-lan for cpsw

2013-08-19 Thread ujhelyi . m
From: Matus Ujhelyi Some phy's can be configured to enable wake on lan (e.g. at803x or marvell 88E1318S). There is no way how to enable wol on CPSW with such connected phys. This patch adds this support. It is provided by calling the phy's related code. Tested on board with at8030x connected

Re: [PATCH 0/3] mm: mempolicy: the failure processing about mpol_to_str()

2013-08-19 Thread Cyrill Gorcunov
On Tue, Aug 20, 2013 at 11:56:15AM +0800, Chen Gang wrote: > For the implementation (patch 1/3), need fill buffer as full as > possible when buffer space is not enough. > > For the caller (patch 2/3, 3/3), need check the return value of > mpol_to_str(). > > Signed-off-by: Chen Gang Won't

Aw: Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups

2013-08-19 Thread screamingfist
- Original Nachricht Von: Greg Kroah-Hartman An: Stefan Achatz Datum: 15.08.2013 18:40 Betreff: Re: [PATCH 35/36] hid: roccat: convert class code to use bin_attrs in groups > On Thu, Aug 15, 2013 at 06:03:46PM +0200, Stefan Achatz wrote: > > Hello Greg, > > looking through

Re: [PATCH 5/6] sched, fair: Make group power more consitent

2013-08-19 Thread Preeti U Murthy
Hi Peter, Thank you for the clarification. On 08/19/2013 04:00 PM, Peter Zijlstra wrote: > On Mon, Aug 19, 2013 at 09:47:47AM +0530, Preeti U Murthy wrote: >> Hi Peter, >> >> On 08/16/2013 03:42 PM, Peter Zijlstra wrote: >> >> I have a few comments and clarification to seek. >> >> 1. How are you

3.11.0-rc6+: INFO: possible circular locking dependency detected

2013-08-19 Thread Miles Lane
[ 24.990076] [ INFO: possible circular locking dependency detected ] [ 24.990086] 3.11.0-rc6+ #154 Not tainted [ 24.990094] --- [ 24.990103] crda/1159 is trying to acquire lock: [ 24.990111] (genl_mutex){+.+.+.}, at: []

[PATCH v1] seq_file: Fix overflow condition in seq_commit

2013-08-19 Thread Arun KS
>From 932a134abeac597f18c86c513704709ad154994b Mon Sep 17 00:00:00 2001 From: Arun KS Date: Mon, 19 Aug 2013 12:06:33 +0530 Subject: seq_file: Fix overflow condition in seq_commit seq_path()/seq_commit() is treating a d_path() failure as an overflow condition, but it isn't. seq_read handles

[PATCH] cpuidle: coupled: fix dead loop corner case

2013-08-19 Thread Neil Zhang
There is a corener case when no peripheral irqs route to secondary cores. Let's take dual core system for example, the sequence is as following: Core 0 Core1 1. set waiting bit and enter waiting loop 2. set waiting bit and

Re: [PATCH] SeqFile: Fix overflow condition

2013-08-19 Thread Arun KS
Hi Andrew, On Tue, Aug 20, 2013 at 4:35 AM, Andrew Morton wrote: > On Mon, 19 Aug 2013 17:02:37 +0530 Arun KS wrote: > >> seq_path()/seq_commit() is treating a d_path() failure as an overflow >> condition, but it isn't. > > This is too brief. When fixing a bug please always describe the >

Re: [PATCH v6] ARM: davinci: da850: add DT node for ethernet

2013-08-19 Thread Sekhar Nori
On Friday 16 August 2013 10:37 PM, Lad, Prabhakar wrote: > From: "Lad, Prabhakar" > > Add ethernet device tree node information and pinmux for mii to da850 by > providing interrupt details and local mac address. > > Signed-off-by: Lad, Prabhakar Queuing this for v3.12 Thanks, Sekhar -- To

Re: [PATCH 1/2] ARC: gdbserver breakage in Big-Endian configuration #1

2013-08-19 Thread Vineet Gupta
Hi Greg, On 08/19/2013 08:27 PM, greg Kroah-Hartman wrote: > On Mon, Aug 19, 2013 at 09:08:49AM +, Vineet Gupta wrote: >> Hi Greg, >> >> I'd posted these patches for stable backport. Do I need to do anything more >> to get them included. >> >> https://patchwork.kernel.org/patch/2841153/

Re: [PATCH 1/2] kernel/sysctl.c: check return value after call proc_put_char() in __do_proc_doulongvec_minmax()

2013-08-19 Thread Chen Gang
On 08/20/2013 01:09 PM, Joe Perches wrote: > On Tue, 2013-08-20 at 11:38 +0800, Chen Gang wrote: >> Need check the return value of proc_put_char(), just like another have >> done in __do_proc_doulongvec_minmax(). >> >> Signed-off-by: Chen Gang >> --- >> kernel/sysctl.c |5 - >> 1 files

Re: [PATCH 1/2] kernel/sysctl.c: check return value after call proc_put_char() in __do_proc_doulongvec_minmax()

2013-08-19 Thread Joe Perches
On Tue, 2013-08-20 at 11:38 +0800, Chen Gang wrote: > Need check the return value of proc_put_char(), just like another have > done in __do_proc_doulongvec_minmax(). > > Signed-off-by: Chen Gang > --- > kernel/sysctl.c |5 - > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff

Re: [PATCH tip/core/rcu 0/3] v2 Documentation updates for 3.12

2013-08-19 Thread Josh Triplett
On Mon, Aug 19, 2013 at 09:28:32PM -0700, Paul E. McKenney wrote: > On Mon, Aug 19, 2013 at 08:24:11PM -0700, Josh Triplett wrote: > > On Mon, Aug 19, 2013 at 07:37:17PM -0700, Paul E. McKenney wrote: > > > Hello! > > > > > > This series provides a few documentation updates: > > > > > > 1.

Re: [REGRESSION] 3.10.{6,7} crashes on network activity

2013-08-19 Thread Felix Fietkau
On 2013-08-20 2:28 AM, Greg Kroah-Hartman wrote: > On Tue, Aug 20, 2013 at 08:26:11AM +0800, Tom Gundersen wrote: >> On Tue, Aug 20, 2013 at 8:03 AM, Greg Kroah-Hartman >> wrote: >> > On Tue, Aug 20, 2013 at 07:59:47AM +0800, Tom Gundersen wrote: >> >> Hi guys, >> >> >> >> Starting with 3.10.6

Re: [PATCH] kernel/rcutree.c: deem to be lazy if there are no callbacks.

2013-08-19 Thread Chen Gang
On 08/20/2013 12:43 PM, Chen Gang wrote: > On 08/20/2013 12:18 PM, Paul E. McKenney wrote: >> On Tue, Aug 20, 2013 at 11:51:23AM +0800, Chen Gang wrote: >>> >>> >>> If 'hc' is false, 'al' will never be false, either (only need check >>> "irdp->qlen != rdp->qlen_lazy' when 'rdp->nxtlist'

Re: [PATCH] kernel/rcutree.c: deem to be lazy if there are no callbacks.

2013-08-19 Thread Chen Gang
On 08/20/2013 12:18 PM, Paul E. McKenney wrote: > On Tue, Aug 20, 2013 at 11:51:23AM +0800, Chen Gang wrote: >> >> >> If 'hc' is false, 'al' will never be false, either (only need check >> "irdp->qlen != rdp->qlen_lazy' when 'rdp->nxtlist' existance). >> >> Recommend to improve the related code,

Re: unused swap offset / bad page map.

2013-08-19 Thread Hillf Danton
On Tue, Aug 20, 2013 at 7:18 AM, Dave Jones wrote: > > btw, anyone have thoughts on a patch something like below ? And another(sorry if message is reformatted by the mail agent, and it took my an hour to get the agent back to the correct format but failed, and thanks a lot for any howto send

Re: [PATCH] kernel/rcutree.c: deem to be lazy if there are no callbacks.

2013-08-19 Thread Chen Gang
On 08/20/2013 12:10 PM, Paul E. McKenney wrote: > On Tue, Aug 20, 2013 at 11:50:02AM +0800, Chen Gang wrote: >> According to the comment above rcu_cpu_has_callbacks(): "If there are >> no callbacks, all of them are deemed to be lazy". >> >> So when both 'hc' and 'al' are false, '*all_lazy' should

Re: [PATCH tip/core/rcu 0/3] v2 Documentation updates for 3.12

2013-08-19 Thread Paul E. McKenney
On Mon, Aug 19, 2013 at 08:24:11PM -0700, Josh Triplett wrote: > On Mon, Aug 19, 2013 at 07:37:17PM -0700, Paul E. McKenney wrote: > > Hello! > > > > This series provides a few documentation updates: > > > > 1. Update rcu_barrier() documentation to note that it no longer is > > guaranteed

Re: [PATCH 4/4] mtd: m25p80: remove unnecessary ifdef

2013-08-19 Thread Brian Norris
On Mon, Aug 12, 2013 at 12:22:26PM +0200, Sascha Hauer wrote: > of_property_read_bool properly compiles away, no need to ifdef this > for non DT builds. > > Signed-off-by: Sascha Hauer Pushed only this one to l2-mtd.git, since it's independent. Thanks, Brian -- To unsubscribe from this list:

Re: [PATCH v6 3/5] zsmalloc: move it under zram

2013-08-19 Thread Minchan Kim
Hello Seth, On Fri, Aug 16, 2013 at 05:00:34PM -0500, Seth Jennings wrote: > On Wed, Aug 14, 2013 at 02:55:34PM +0900, Minchan Kim wrote: > > This patch moves zsmalloc under zram directory because there > > isn't any other user any more. > > > > Before that, description will explain why we have

Re: [PATCH 2/4] mtd: m25p80: make CONFIG_M25PXX_USE_FAST_READ safe to enable

2013-08-19 Thread Brian Norris
On Mon, Aug 19, 2013 at 10:42:26AM +0200, Sascha Hauer wrote: > On Sat, Aug 17, 2013 at 01:17:02PM -0700, Brian Norris wrote: > > On Mon, Aug 12, 2013 at 12:22:24PM +0200, Sascha Hauer wrote: > > > This patch adds a flag to struct flash_info indicating that > > > fast_read is not supported. This

Re: [PATCH] kernel/rcutree.c: deem to be lazy if there are no callbacks.

2013-08-19 Thread Paul E. McKenney
On Tue, Aug 20, 2013 at 11:51:23AM +0800, Chen Gang wrote: > > > If 'hc' is false, 'al' will never be false, either (only need check > "irdp->qlen != rdp->qlen_lazy' when 'rdp->nxtlist' existance). > > Recommend to improve the related code, like the diff below. Are you sure that this

Re: [PATCH v3 3/5] mm: Notify filesystems when it's time to apply a deferred cmtime update

2013-08-19 Thread Andy Lutomirski
On Mon, Aug 19, 2013 at 9:08 PM, Dave Chinner wrote: > On Mon, Aug 19, 2013 at 08:28:20PM -0700, Andy Lutomirski wrote: >> On Mon, Aug 19, 2013 at 7:36 PM, Dave Chinner wrote: >> > On Fri, Aug 16, 2013 at 04:22:10PM -0700, Andy Lutomirski wrote: >> >> Filesystems that defer cmtime updates should

Re: [PATCH] kernel/rcutree.c: deem to be lazy if there are no callbacks.

2013-08-19 Thread Paul E. McKenney
On Tue, Aug 20, 2013 at 11:50:02AM +0800, Chen Gang wrote: > According to the comment above rcu_cpu_has_callbacks(): "If there are > no callbacks, all of them are deemed to be lazy". > > So when both 'hc' and 'al' are false, '*all_lazy' should be true, not > false. If there are no callbacks,

Re: [PATCH v3 5/5] ext4: Defer mmap cmtime update until writeback

2013-08-19 Thread Dave Chinner
On Mon, Aug 19, 2013 at 08:30:02PM -0700, Andy Lutomirski wrote: > On Mon, Aug 19, 2013 at 7:38 PM, Dave Chinner wrote: > > On Fri, Aug 16, 2013 at 04:22:12PM -0700, Andy Lutomirski wrote: > >> A fancier implementation could probably avoid an extra journal > >> transaction by adding a

Re: [PATCH v3 3/5] mm: Notify filesystems when it's time to apply a deferred cmtime update

2013-08-19 Thread Dave Chinner
On Mon, Aug 19, 2013 at 08:28:20PM -0700, Andy Lutomirski wrote: > On Mon, Aug 19, 2013 at 7:36 PM, Dave Chinner wrote: > > On Fri, Aug 16, 2013 at 04:22:10PM -0700, Andy Lutomirski wrote: > >> Filesystems that defer cmtime updates should update cmtime when any > >> of these events happen after a

Re: [PATCH v3 2/5] fs: Add inode_update_time_writable

2013-08-19 Thread Andy Lutomirski
On Mon, Aug 19, 2013 at 8:33 PM, Dave Chinner wrote: > On Mon, Aug 19, 2013 at 08:20:12PM -0700, Andy Lutomirski wrote: >> On Mon, Aug 19, 2013 at 7:28 PM, Dave Chinner wrote: >> > On Fri, Aug 16, 2013 at 04:22:09PM -0700, Andy Lutomirski wrote: >> >> This is like file_update_time, except that

Re: [3.10] Oopses in kmem_cache_allocate() via prepare_creds()

2013-08-19 Thread Al Viro
On Mon, Aug 19, 2013 at 02:16:36PM -0700, Linus Torvalds wrote: > On Mon, Aug 19, 2013 at 1:29 PM, Christoph Lameter wrote: > > On Mon, 19 Aug 2013, Simon Kirby wrote: > > > >>[... ] The > >> alloc/free traces are always the same -- always alloc_pipe_info and > >> free_pipe_info. This is

Re: [PATCH] x86: remove redundant local_irq_enable() after cpuidle_idle_call()

2013-08-19 Thread Li.Wang
Hi All, Anybody help me review this? Thanks, LiWang. On 08/14/2013 10:20 AM, Li Wang wrote: When cpuidle_idle_call() return 0, it shows that linux system is using idle framwork driver. Now, local irq has already been enabled in cpuidle_idle_call(). So, it need not enable local irq again, when

Re: [RFC PATCH] pwm: atmel-pwm: add pwm controller driver

2013-08-19 Thread Bo Shen
Hi Thierry, On 8/20/2013 05:20, Thierry Reding wrote: On Mon, Aug 19, 2013 at 11:11:06AM +0800, Bo Shen wrote: add atmel pwm controller driver based on PWM framework this is basic function implementation of pwm controller it can work with pwm based led and backlight Please use the proper

[PATCH 3/3] mm/shmem.c: check the return value of mpol_to_str()

2013-08-19 Thread Chen Gang
mpol_to_str() may fail, and not fill the buffer (e.g. -EINVAL), so need check about it, or buffer may not be zero based, and next seq_printf() will cause issue. Also print related warning when the buffer space is not enough. Signed-off-by: Chen Gang --- mm/shmem.c | 15 ++- 1

[PATCH 2/3] fs/proc/task_mmu.c: check the return value of mpol_to_str()

2013-08-19 Thread Chen Gang
mpol_to_str() may fail, and not fill the buffer (e.g. -EINVAL), so need check about it, or buffer may not be zero based, and next seq_printf() will cause issue. Also print related warning when the buffer space is not enough. Signed-off-by: Chen Gang --- fs/proc/task_mmu.c | 16

[PATCH 1/3] mm/mempolicy.c: still fill buffer as full as possible when buffer space is not enough in mpol_to_str()

2013-08-19 Thread Chen Gang
Need still try to fill buffer as full as possible if the buffer space is not enough, commonly, the caller can bear of it (e.g. print warning and still continue). Signed-off-by: Chen Gang --- mm/mempolicy.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git

[PATCH 0/3] mm: mempolicy: the failure processing about mpol_to_str()

2013-08-19 Thread Chen Gang
For the implementation (patch 1/3), need fill buffer as full as possible when buffer space is not enough. For the caller (patch 2/3, 3/3), need check the return value of mpol_to_str(). Signed-off-by: Chen Gang --- fs/proc/task_mmu.c | 16 ++-- mm/mempolicy.c | 14

Re: [PATCH] vfio-pci: PCI hot reset interface

2013-08-19 Thread Alex Williamson
On Tue, 2013-08-20 at 04:18 +0100, Al Viro wrote: > On Wed, Aug 14, 2013 at 04:42:14PM -0600, Bjorn Helgaas wrote: > > [+cc Al, linux-fsdevel for fdget/fdput usage] > > fdget/fdput use looks sane, the only thing is that I would rather > have an explicit include of linux/file.h instead of relying

Re: [PATCH] kernel/rcutree.c: deem to be lazy if there are no callbacks.

2013-08-19 Thread Chen Gang
If 'hc' is false, 'al' will never be false, either (only need check "irdp->qlen != rdp->qlen_lazy' when 'rdp->nxtlist' existance). Recommend to improve the related code, like the diff below. --diff begin diff --git

[PATCH] kernel/rcutree.c: deem to be lazy if there are no callbacks.

2013-08-19 Thread Chen Gang
According to the comment above rcu_cpu_has_callbacks(): "If there are no callbacks, all of them are deemed to be lazy". So when both 'hc' and 'al' are false, '*all_lazy' should be true, not false. Signed-off-by: Chen Gang --- kernel/rcutree.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu()

2013-08-19 Thread Chen Gang
If this patch is correct, better to let CPU_ONLINE and CPU_DOWN_FAILED share the same code. And do we need a comment "/* fall through */" between CPU_UP_CANCELED and CPU_DOWN_FAILED (or it is another bug, need a 'break' statement) ? At last, also better to let CPU_DOWN_PREPARE and

[PATCH] kernel/padata.c: always check the return value of __padata_remove_cpu() and __padata_add_cpu()

2013-08-19 Thread Chen Gang
When failure occures, __padata_add_cpu() and __padata_remove_cpu() will return -ENOMEM, which need be noticed in any cases (even in cleaning up cases). Signed-off-by: Chen Gang --- kernel/padata.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/padata.c

[RFC][PATCH RT] rtmutex: Add up/down_read_non_owner() API

2013-08-19 Thread Steven Rostedt
As the up/down_read_non_owner() API has been brought back from the dead, and has a single user (bcache), this module now breaks -rt, as -rt has no API for non owner rwsems. Now I looked at the code for bcache, and I don't see a way to fix it. Perhaps there is, but I don't see it. Thus, I decided

[PATCH 2/2] kernel/sysctl.c: simplify code for C code readers

2013-08-19 Thread Chen Gang
In related functions, they have already had tag 'free', so use 'goto' instead of 'break' to keep one (not multiple) style in each function. Also remove useless checking 'err' code or move it to related 'if' code block. Signed-off-by: Chen Gang --- kernel/sysctl.c | 25

[PATCH 1/2] kernel/sysctl.c: check return value after call proc_put_char() in __do_proc_doulongvec_minmax()

2013-08-19 Thread Chen Gang
Need check the return value of proc_put_char(), just like another have done in __do_proc_doulongvec_minmax(). Signed-off-by: Chen Gang --- kernel/sysctl.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index 7822cd8..ee00986 100644

[PATCH 0/2] kernel/sysctl.c: about the return value after fail call

2013-08-19 Thread Chen Gang
Patch 1 for bug fix: check return value after call proc_put_char() in __do_proc_doulongvec_minmax() Patch 2 for simplify code : Simplify code for C code readers. Signed-off-by: Chen Gang --- kernel/sysctl.c | 30 +- 1 files changed, 17 insertions(+), 13

Re: [PATCH] acpi_i2c: set MODULE_LICENSE, MODULE_AUTHOR, and MODULE_DESCRIPTION

2013-08-19 Thread Jerry Snitselaar
On Tue Aug 20 13, Rafael J. Wysocki wrote: > On Monday, August 19, 2013 04:35:29 PM Jerry Snitselaar wrote: > > On Tue Aug 20 13, Rafael J. Wysocki wrote: > > > On Monday, August 19, 2013 09:16:14 AM Mika Westerberg wrote: > > > > On Fri, Aug 16, 2013 at 06:26:35PM -0700, Jerry Snitselaar wrote: >

Re: [PATCH v3 2/5] fs: Add inode_update_time_writable

2013-08-19 Thread Dave Chinner
On Mon, Aug 19, 2013 at 08:20:12PM -0700, Andy Lutomirski wrote: > On Mon, Aug 19, 2013 at 7:28 PM, Dave Chinner wrote: > > On Fri, Aug 16, 2013 at 04:22:09PM -0700, Andy Lutomirski wrote: > >> This is like file_update_time, except that it acts on a struct inode * > >> instead of a struct file *.

Re: [PATCH v3 5/5] ext4: Defer mmap cmtime update until writeback

2013-08-19 Thread Andy Lutomirski
On Mon, Aug 19, 2013 at 7:38 PM, Dave Chinner wrote: > On Fri, Aug 16, 2013 at 04:22:12PM -0700, Andy Lutomirski wrote: >> A fancier implementation could probably avoid an extra journal >> transaction by adding a mapping_test_clear_cmtime call in >> ext4_writepages, but this should already be a

Re: [PATCH v3 3/5] mm: Notify filesystems when it's time to apply a deferred cmtime update

2013-08-19 Thread Andy Lutomirski
On Mon, Aug 19, 2013 at 7:36 PM, Dave Chinner wrote: > On Fri, Aug 16, 2013 at 04:22:10PM -0700, Andy Lutomirski wrote: >> Filesystems that defer cmtime updates should update cmtime when any >> of these events happen after a write via a mapping: >> >> - The mapping is written back to disk. This

[PATCH] kvm tools: powerpc: Fix init order for xics

2013-08-19 Thread Michael Neuling
xics_init() assumes kvm->nrcpus is already setup. kvm->nrcpus is setup in kvm_cpu_init() Unfortunately xics_init() and kvm_cpu_init() both use base_init(). So depending on the order randomly determined by the compiler, xics_init() may initialised see kvm->nrcpus as 0 and not setup any of the

Re: [PATCH tip/core/rcu 1/5] rcu: Add duplicate-callback tests to rcutorture

2013-08-19 Thread Josh Triplett
On Mon, Aug 19, 2013 at 07:51:10PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > This commit adds a object_debug option to rcutorture to allow the > debug-object-based checks for duplicate call_rcu() invocations to > be deterministically tested. > > Signed-off-by: Paul E.

Re: [PATCH tip/core/rcu 0/3] v2 Documentation updates for 3.12

2013-08-19 Thread Josh Triplett
On Mon, Aug 19, 2013 at 07:37:17PM -0700, Paul E. McKenney wrote: > Hello! > > This series provides a few documentation updates: > > 1.Update rcu_barrier() documentation to note that it no longer is > guaranteed to wait for a full grace period. This guarantee was > a victim of

Re: [PATCH tip/core/rcu 2/3] rcu: Update RTFP documentation

2013-08-19 Thread Josh Triplett
On Mon, Aug 19, 2013 at 07:37:46PM -0700, Paul E. McKenney wrote: > From: "Paul E. McKenney" > > Note that this commit also updates the formatting of serveral of the > bibtex entries to conform to that of my .bib files. I started > accumulating entries back in the 1980s, back when bibtex

Re: [PATCH tip/core/rcu 1/5] rcu: Add duplicate-callback tests to rcutorture

2013-08-19 Thread Josh Triplett
On Mon, Aug 19, 2013 at 07:05:58PM -0700, Paul E. McKenney wrote: > On Mon, Aug 19, 2013 at 10:16:52AM -0700, Josh Triplett wrote: > > On Mon, Aug 19, 2013 at 09:09:45AM -0700, Paul E. McKenney wrote: > > > On Sun, Aug 18, 2013 at 09:19:25PM -0700, Josh Triplett wrote: > > > > On Sun, Aug 18, 2013

Re: [PATCH v3 2/5] fs: Add inode_update_time_writable

2013-08-19 Thread Andy Lutomirski
On Mon, Aug 19, 2013 at 7:28 PM, Dave Chinner wrote: > On Fri, Aug 16, 2013 at 04:22:09PM -0700, Andy Lutomirski wrote: >> This is like file_update_time, except that it acts on a struct inode * >> instead of a struct file *. >> >> Signed-off-by: Andy Lutomirski >> --- >> fs/inode.c | 72

Re: [PATCH] vfio-pci: PCI hot reset interface

2013-08-19 Thread Al Viro
On Wed, Aug 14, 2013 at 04:42:14PM -0600, Bjorn Helgaas wrote: > [+cc Al, linux-fsdevel for fdget/fdput usage] fdget/fdput use looks sane, the only thing is that I would rather have an explicit include of linux/file.h instead of relying upon linux/eventfd.h pulling it. Incidentally, there are

[PATCH] kernel/params.c: use scnprintf() instead of sprintf()

2013-08-19 Thread Chen Gang
For some strings (e.g. version string), they are permitted to be larger than PAGE_SIZE (although meaningless), so recommend to use scnprintf() instead of sprintf(). Signed-off-by: Chen Gang --- kernel/params.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [Help Test] kdump, x86, acpi: Reproduce CPU0 SMI corruption issue after unsetting BSP flag

2013-08-19 Thread HATAYAMA Daisuke
(2013/08/19 22:46), Petr Tesarik wrote: On Sun, 18 Aug 2013 19:59:53 -0700 "Eric W. Biederman" wrote: Sorry Eric, I'm not clear to what you mean by ``short one core''... Which are you suggesting? Disabling BSP if crash happens on AP is reasonable? Or restricting cpus to a single one only

[PATCH] kernel/module.c: use scnprintf() instead of sprintf()

2013-08-19 Thread Chen Gang
For some strings, they are permitted to be larger than PAGE_SIZE, so need use scnprintf() instead of sprintf(), or it will cause issue. One case is: if a module version is crazy defined (length more than PAGE_SIZE), 'modinfo' command is still OK (print full contents), but for "cat

[PATCH] kernel/futex.c: notice the return value after rt_mutex_finish_proxy_lock() fails

2013-08-19 Thread Chen Gang
rt_mutex_finish_proxy_lock() can return failure code (e.g. -EINTR, -ETIMEDOUT). Original implementation has already noticed about it, but not check it before next work. Also let coments within 80 columns to pass "./scripts/checkpatch.pl". Signed-off-by: Chen Gang --- kernel/futex.c | 30

[PATCH] staging: tidspbridge: Fix typos in comments

2013-08-19 Thread Masanari Iida
Correct spelling typos in comments. Signed-off-by: Masanari Iida --- drivers/staging/tidspbridge/include/dspbridge/cmm.h | 2 +- drivers/staging/tidspbridge/include/dspbridge/proc.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] kernel/groups.c: consider about NULL for 'group_info' in all related extern functions

2013-08-19 Thread Chen Gang
If this patch is correct, also need modify the man page for the return value of getgroups(). Thanks. On 08/20/2013 11:01 AM, Chen Gang wrote: > groups_alloc() can return NULL for 'group_info', also group_search() > already considers about NULL for 'group_info', so can assume the caller > has

[PATCH] kernel/groups.c: consider about NULL for 'group_info' in all related extern functions

2013-08-19 Thread Chen Gang
groups_alloc() can return NULL for 'group_info', also group_search() already considers about NULL for 'group_info', so can assume the caller has right to use all related extern functions when 'group_info' is NULL. For groups_free(), need check NULL to match groups_alloc(), just like

[PATCH] kernel: user_namespace: always set the return parameter 'new_cred' when call unshare_userns() successfully.

2013-08-19 Thread Chen Gang
When unshare_userns() succeed, recommend to always set the return parameter which may be used by caller. The caller has rights to call it with 'new_cred' uninitialized, if succeed, the caller can assume the 'new_cred' has been initialized. Signed-off-by: Chen Gang ---

[PATCH tip/core/rcu 3/5] rcu: Sort rcutorture module parameters

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" There are getting to be too many module parameters to permit the current semi-random order, so this patch orders them. Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett --- kernel/rcutorture.c | 101 +--- 1

[PATCH tip/core/rcu 4/5] rcu: Remove unused variable from rcu_torture_writer()

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" The oldbatch variable in rcu_torture_writer() is stored to, but never loaded from. This commit therefore removes it. Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett --- kernel/rcutorture.c | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH tip/core/rcu 1/5] rcu: Add duplicate-callback tests to rcutorture

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds a object_debug option to rcutorture to allow the debug-object-based checks for duplicate call_rcu() invocations to be deterministically tested. Signed-off-by: Paul E. McKenney Cc: Mathieu Desnoyers Cc: Sedat Dilek Cc: Davidlohr Bueso Cc: Rik van

[PATCH tip/core/rcu 2/5] rcu: Increase rcutorture test coverage

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" Currently, rcutorture has separate torture_types to test synchronous, asynchronous, and expedited grace-period primitives. This has two disadvantages: (1) Three times the number of runs to cover the combinations and (2) Little testing of concurrent combinations of the

[PATCH tip/core/rcu 5/5] rcu: Make rcutorture emit online failures if verbose

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" Although rcutorture counts CPU-hotplug online failures, it does not explicitly record which CPUs were having trouble coming online. This commit therefore emits a console message when online failure occurs. Signed-off-by: Paul E. McKenney Reviewed-by: Josh Triplett ---

[PATCH tip/core/rcu 7/9] nohz_full: Add full-system-idle arguments to API

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds an isidle and jiffies argument to force_qs_rnp(), dyntick_save_progress_counter(), and rcu_implicit_dynticks_qs() to enable RCU's force-quiescent-state process to check for full-system idle. Signed-off-by: Paul E. McKenney Cc: Frederic Weisbecker Cc:

[PATCH tip/core/rcu 8/9] nohz_full: Add full-system-idle state machine

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds the state machine that takes the per-CPU idle data as input and produces a full-system-idle indication as output. This state machine is driven out of RCU's quiescent-state-forcing mechanism, which invokes rcu_sysidle_check_cpu() to collect per-CPU idle

[PATCH tip/core/rcu 0/5] v2 rcutorture updates for 3.12

2013-08-19 Thread Paul E. McKenney
Hello! This series provides some rcutorture updates: 1. Add a debug_object option to rcutorture to allow testing of RCU's debug-objects facilities. 2. Increase rcutorture test coverage by concurrently testing synchronous, asynchronous, and expedited grace periods. 3.

[PATCH tip/core/rcu 6/9] nohz_full: Add full-system idle states and variables

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds control variables and states for full-system idle. The system will progress through the states in numerical order when the system is fully idle (other than the timekeeping CPU), and reset down to the initial state if any non-timekeeping CPU goes

[PATCH tip/core/rcu 1/9] rcu: Eliminate unused APIs intended for adaptive ticks

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" The rcu_user_enter_after_irq() and rcu_user_exit_after_irq() functions were intended for use by adaptive ticks, but changes in implementation have rendered them unnecessary. This commit therefore removes them. Reported-by: Frederic Weisbecker Signed-off-by: Paul E.

Re: [PATCH 6/6] vhost_net: remove the max pending check

2013-08-19 Thread Jason Wang
On 08/16/2013 06:02 PM, Michael S. Tsirkin wrote: > On Fri, Aug 16, 2013 at 01:16:30PM +0800, Jason Wang wrote: >> We used to limit the max pending DMAs to prevent guest from pinning too many >> pages. But this could be removed since: >> >> - We have the sk_wmem_alloc check in both tun/macvtap to

[PATCH tip/core/rcu 9/9] nohz_full: Force RCU's grace-period kthreads onto timekeeping CPU

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" Because RCU's quiescent-state-forcing mechanism is used to drive the full-system-idle state machine, and because this mechanism is executed by RCU's grace-period kthreads, this commit forces these kthreads to run on the timekeeping CPU (tick_do_timer_cpu). To do

[PATCH tip/core/rcu 4/9] nohz_full: Add rcu_dyntick data for scalable detection of all-idle state

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds fields to the rcu_dyntick structure that are used to detect idle CPUs. These new fields differ from the existing ones in that the existing ones consider a CPU executing in user mode to be idle, where the new ones consider CPUs executing in user mode to

[PATCH tip/core/rcu 2/9] nohz_full: Add testing information to documentation

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds information about testing nohz_full, and also emphasizes the fact that you need a multi-CPU system to get any benefit from nohz_full. Signed-off-by: Paul E. McKenney Acked-by: Frederic Weisbecker Reviewed-by: Josh Triplett ---

[PATCH tip/core/rcu 0/9] v2 sysidle changes for 3.12

2013-08-19 Thread Paul E. McKenney
Hello! Whenever there is at least one non-idle CPU, it is necessary to periodically update timekeeping information. Before NO_HZ_FULL, this updating was carried out by the scheduling-clock tick, which ran on every non-idle CPU. With the advent of NO_HZ_FULL, it is possible to have non-idle CPUs

[PATCH tip/core/rcu 5/9] nohz_full: Add per-CPU idle-state tracking

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit adds the code that updates the rcu_dyntick structure's new fields to track the per-CPU idle state based on interrupts and transitions into and out of the idle loop (NMIs are ignored because NMI handlers cannot cleanly read out the time anyway). This code is

[PATCH tip/core/rcu 3/9] nohz_full: Add Kconfig parameter for scalable detection of all-idle state

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" At least one CPU must keep the scheduling-clock tick running for timekeeping purposes whenever there is a non-idle CPU. However, with the new nohz_full adaptive-idle machinery, it is difficult to distinguish between all CPUs really being idle as opposed to all non-idle

Re: Fix apparent cut-and-paste error in super_90_validate

2013-08-19 Thread NeilBrown
On Mon, 19 Aug 2013 22:26:32 -0400 Dave Jones wrote: > Setting a variable to itself probably wasn't the intention here. Probably not, no. Applied, thanks. NeilBrown > > Signed-off-by: Dave Jones > > diff --git a/drivers/md/md.c b/drivers/md/md.c > index 9f13e13..b9cb9e4 100644 > ---

[PATCH] kernel/taskstats.c: add nla_nest_cancel() for failure processing between nla_nest_start() and nla_nest_end()

2013-08-19 Thread Chen Gang
When failure occurs between nla_nest_start() and nla_nest_end(), need call nla_nest_cancel() to clean up related things. Signed-off-by: Chen Gang --- kernel/taskstats.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/kernel/taskstats.c b/kernel/taskstats.c index

Re: [PATCH 5/6] vhost_net: poll vhost queue after marking DMA is done

2013-08-19 Thread Jason Wang
On 08/16/2013 06:00 PM, Michael S. Tsirkin wrote: > On Fri, Aug 16, 2013 at 01:16:29PM +0800, Jason Wang wrote: >> We used to poll vhost queue before making DMA is done, this is racy if vhost >> thread were waked up before marking DMA is done which can result the signal >> to >> be missed. Fix

[PATCH tip/core/rcu 1/9] rcu: Expedite grace periods during suspend/resume

2013-08-19 Thread Paul E. McKenney
From: Borislav Petkov CONFIG_RCU_FAST_NO_HZ can increase grace-period durations by up to a factor of four, which can result in long suspend and resume times. Thus, this commit temporarily switches to expedited grace periods when suspending the box and return to normal settings when resuming.

[PATCH tip/core/rcu 2/9] rcu: Simplify debug-objects fixups

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" The current debug-objects fixups are complex and heavyweight, and the fixups are not complete: Even with the fixups, RCU's callback lists can still be corrupted. This commit therefore strips the fixups down to their minimal form, eliminating two of the three. It would

[PATCH tip/core/rcu 8/9] rcu: Simplify _rcu_barrier() processing

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" This commit drops an unneeded ACCESS_ONCE() and simplifies an "our work is done" check in _rcu_barrier(). This applies feedback from Linus (https://lkml.org/lkml/2013/7/26/777) that he gave to similar code in an unrelated patch. Signed-off-by: Paul E. McKenney

[PATCH tip/core/rcu 7/9] rcu: Select IRQ_WORK from TREE_PREEMPT_RCU

2013-08-19 Thread Paul E. McKenney
From: James Hogan TREE_RCU and TREE_PREEMPT_RCU both cause kernel/rcutree.c to be built, but only TREE_RCU selects IRQ_WORK, which can result in an undefined reference to irq_work_queue for some (random) configs: kernel/built-in.o In function `rcu_start_gp_advanced': kernel/rcutree.c:1564:

[PATCH tip/core/rcu 6/9] rculist: list_first_or_null_rcu() should use list_entry_rcu()

2013-08-19 Thread Paul E. McKenney
From: Tejun Heo list_first_or_null() should test whether the list is empty and return pointer to the first entry if not in a RCU safe manner. It's broken in several ways. * It compares __kernel @__ptr with __rcu @__next triggering the following sparse warning. net/core/dev.c:4331:17:

[PATCH tip/core/rcu 4/9] rcu: Make call_rcu() leak callbacks for debug-object errors

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" If someone does a duplicate call_rcu(), the worst thing the second call_rcu() could do would be to actually queue the callback the second time because doing so corrupts whatever list the callback was already queued on. This commit therefore makes __call_rcu() check the

[PATCH tip/core/rcu 5/9] rcu: Avoid redundant grace-period kthread wakeups

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" When setting up an in-the-future "advanced" grace period, the code needs to wake up the relevant grace-period kthread, which it currently does unconditionally. However, this results in needless wakeups in the case where the advanced grace period is being set up by the

[PATCH tip/core/rcu 9/9] jiffies: Avoid undefined behavior from signed overflow

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" According to the C standard 3.4.3p3, overflow of a signed integer results in undefined behavior. This commit therefore changes the definitions of time_after(), time_after_eq(), time_after64(), and time_after_eq64() to avoid this undefined behavior. The trick is that

[PATCH tip/core/rcu 3/9] debugobjects: Make debug_object_activate() return status

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" In order to better respond to things like duplicate invocations of call_rcu(), RCU needs to see the status of a call to debug_object_activate(). This would allow RCU to leak the callback in order to avoid adding freelist-reuse mischief to the duplicate invoations. This

[PATCH tip/core/rcu 0/9] v2 Fixes for 3.12

2013-08-19 Thread Paul E. McKenney
Hello! This series contains a number of miscellaneous fixes: 1. Switch to expedited grace periods during hibernation and suspend/resume operations (courtesy of Borislav Petkov and Bjørn Mork). 2. Make RCU debugobjects fixup actions leak callbacks rather than

[PATCH] kernel/delayacct.c: check NULL for member variable 'delays' in all extern functions.

2013-08-19 Thread Chen Gang
The member variable 'delays' may be NULL, so need check NULL before use it for all extern functions, just like __delayacct_tsk_init() and __delayacct_add_tsk() have already done. Signed-off-by: Chen Gang --- kernel/delayacct.c | 10 ++ 1 files changed, 10 insertions(+), 0

[PATCH tip/core/rcu 2/3] rcu: Update RTFP documentation

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" Note that this commit also updates the formatting of serveral of the bibtex entries to conform to that of my .bib files. I started accumulating entries back in the 1980s, back when bibtex insisted that comma (",") was a separator, not a terminator. This rule forced

Re: [PATCH v3 5/5] ext4: Defer mmap cmtime update until writeback

2013-08-19 Thread Dave Chinner
On Fri, Aug 16, 2013 at 04:22:12PM -0700, Andy Lutomirski wrote: > A fancier implementation could probably avoid an extra journal > transaction by adding a mapping_test_clear_cmtime call in > ext4_writepages, but this should already be a considerable > improvement -- we'll start one transaction

[PATCH tip/core/rcu 3/3] doc: Fix memory-barrier control-dependency example

2013-08-19 Thread Paul E. McKenney
From: "Paul E. McKenney" Each control-dependency example needs its barriers between the "if" condition and the body of the "if" because a control dependency is a dependency induced by a branch. This commit makes the needed adjustment. Reported-by: Yongming Shen Signed-off-by: Paul E. McKenney

  1   2   3   4   5   6   7   8   9   10   >