Re: OMAPFB: CMA allocation failures

2013-10-29 Thread Minchan Kim
Hello, Ивайло On Tue, Oct 29, 2013 at 02:47:35PM +0200, Ивайло Димитров wrote: > > Hi, > > > > Оригинално писмо > >От: Minchan Kim > >Относно: Re: OMAPFB: CMA allocation failures > >До: Ивайло Димитров > >Изпратено на: Понеделник, 2013, Октомври 28 09:37:48 EET > >

Re: [PATCH] edac, highbank: Add MAINTAINERS entry

2013-10-29 Thread Rob Herring
On 10/29/2013 12:47 PM, Robert Richter wrote: > So taking over maintainership for the EDAC highbank driver. > > Cc: Rob Herring > Cc: Borislav Petkov > Signed-off-by: Robert Richter Acked-by: Rob Herring -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH] mm: cma: free cma page to buddy instead of being cpu hot page

2013-10-29 Thread Minchan Kim
Hello, On Tue, Oct 29, 2013 at 09:14:03AM -0700, Laura Abbott wrote: > On 10/29/2013 8:02 AM, Zhang Mingjun wrote: > > >It would move the cost to the CMA paths so I would complain less. Bear > >in mind as well that forcing everything to go through free_one_page() > >means that every

[PATCH -next] ARM i.MX53: remove duplicated include from clk-imx51-imx53.c

2013-10-29 Thread Wei Yongjun
From: Wei Yongjun Remove duplicated include. Signed-off-by: Wei Yongjun --- arch/arm/mach-imx/clk-imx51-imx53.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-imx/clk-imx51-imx53.c b/arch/arm/mach-imx/clk-imx51-imx53.c index ce37af2..2828ea65 100644 ---

[PATCH -next] ARM: ixp4xx: remove duplicated include from dsmg600-setup.c

2013-10-29 Thread Wei Yongjun
From: Wei Yongjun Remove duplicated include. Signed-off-by: Wei Yongjun --- arch/arm/mach-ixp4xx/dsmg600-setup.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-ixp4xx/dsmg600-setup.c b/arch/arm/mach-ixp4xx/dsmg600-setup.c index 736dc69..7740e13 100644 ---

Re: [PATCH v6 01/21] scripts/gdb: Add infrastructure

2013-10-29 Thread Andi Kleen
> The loading mechanism is based on gdb loading for -gdb.py when > opening . Therefore, this places a corresponding link to the > main helper script into the output directory that contains vmlinux. > This feature depends on CONFIG_DEBUG_INFO. Could you make this a separate config option? Having

[PATCH -next] mtd: remove duplicated include from mtdcore.c

2013-10-29 Thread Wei Yongjun
From: Wei Yongjun Remove duplicated include. Signed-off-by: Wei Yongjun --- drivers/mtd/mtdcore.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index 7189089..92311a5 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -37,7

[PATCH -next] tifm: fix error return code in tifm_7xx1_probe()

2013-10-29 Thread Wei Yongjun
From: Wei Yongjun Fix to return ENODEV in the pci ioremap error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/misc/tifm_7xx1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/misc/tifm_7xx1.c

Re: [PATCH] scripts/kconfig/menu.c: warning: jump may be used uninitialized in this function

2013-10-29 Thread Madhavan Srinivasan
On Tuesday 29 October 2013 11:23 PM, Yann E. MORIN wrote: > Christian, All, > > On 2013-10-27 19:02 -0700, Christian Kujau spake thusly: >> On Sun, 27 Oct 2013 at 18:28, Christian Kujau wrote: >>> While doing "make oldconfig" on 3.12-rc7 with gcc-4.7.2 (Debian), the >>> following warning is

RE: [PATCH v9 01/13] KVM: PPC: POWERNV: move iommu_add_device earlier

2013-10-29 Thread Bhushan Bharat-R65777
Hi Alex, Looks like this patch is not picked by anyone, Are you going to pick this patch? My vfio/iommu patches have dependency on this patch (this is already tested by me). Thanks -Bharat > -Original Message- > From: Linuxppc-dev [mailto:linuxppc-dev- >

Re: [PATCH] sysfs: move assignment to be under lock in sysfs_remove_dir()

2013-10-29 Thread Eric W. Biederman
Linus Torvalds writes: > On Tue, Oct 29, 2013 at 5:39 PM, Eric W. Biederman > wrote: >> >> I don't have a strong feeling either way but how would that matter? >> There is only ever one sd associated with a kobj. > > What does that matter? If you have multiple callers, they might try to > free

Re: [PATCH] x86: Run checksumming in parallel accross multiple alu's

2013-10-29 Thread Doug Ledford
* Neil Horman wrote: > 3) The run times are proportionally larger, but still indicate that Parallel > ALU > execution is hurting rather than helping, which is counter-intuitive. I'm > looking into it, but thought you might want to see these results in case > something jumped out at you So

[PATCH -next] skd: fix error return code in skd_pci_probe()

2013-10-29 Thread Wei Yongjun
From: Wei Yongjun Fix to return -ENOMEM in the skd construct error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/block/skd_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/block/skd_main.c

Re: [PATCH 2/5] fat: add fat_fallocate operation

2013-10-29 Thread Namjae Jeon
2013/10/30, OGAWA Hirofumi : > Namjae Jeon writes: > + /* Release unwritten fallocated blocks on file release. */ + if (round_up(inode->i_size, sb->s_blocksize) < + MSDOS_I(inode)->i_disksize && inode->i_nlink != 0) + fat_truncate_blocks(inode, inode->i_size);

linux-next: manual merge of the xen-tip tree with the tree

2013-10-29 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the xen-tip tree got a conflict in arch/arm/include/asm/dma-mapping.h between commit 223016339ce7 ("ARM: 7805/1: mm: change max*pfn to include the physical offset of memory") from the arm tree and commit 06e6295bcece ("arm: make SWIOTLB available") from the

[PATCH] of: set dma_mask to point to coherent_dma_mask

2013-10-29 Thread Rob Herring
From: Rob Herring Platform devices created by DT code don't initialize dma_mask pointer to anything. Set it to coherent_dma_mask by default if the architecture code has not set it. Signed-off-by: Rob Herring --- I think this is at least part of what is needed to fix dma_mask issue raised by

Re: [PATCH 1/3] dma: imx-sdma: Add ssi dual fifo script support

2013-10-29 Thread Nicolin Chen
Hi Sascha, On Tue, Oct 29, 2013 at 02:51:43PM +0100, Sascha Hauer wrote: > Look at drivers/dma/imx-sdma.c: > > > /** > > * struct sdma_firmware_header - Layout of the firmware image > > * > > * @magic "SDMA" > > * @version_major increased whenever layout of struct > > *

Re: [PATCH 1/5] fat: add i_disksize to represent uninitialized size

2013-10-29 Thread Namjae Jeon
2013/10/30, OGAWA Hirofumi : > Namjae Jeon writes: > diff --git a/fs/fat/cache.c b/fs/fat/cache.c index 91ad9e1..37572c2 100644 --- a/fs/fat/cache.c +++ b/fs/fat/cache.c @@ -329,10 +329,10 @@ int fat_bmap(struct inode *inode, sector_t sector, sector_t *phys,

Re: [PATCH] crypto: omap-aes: Fix CTR mode counter length

2013-10-29 Thread Herbert Xu
On Tue, Oct 29, 2013 at 05:37:38PM -0500, Joel Fernandes wrote: > NIST vectors for CTR mode in testmgr.h assume the entire IV as the counter. To > get correct results that match the output of these vectors, we need to set the > counter length correctly. > > Signed-off-by: Joel Fernandes Patch

Re: [PATCH v3 2/2] hwrng: msm: Add PRNG support for MSM SoC's

2013-10-29 Thread Herbert Xu
On Fri, Oct 18, 2013 at 11:39:28AM -0700, Stephen Boyd wrote: > On 10/15/13 07:11, Stanimir Varbanov wrote: > > This adds a driver for hardware random number generator present > > on Qualcomm MSM SoC's. > > > > Signed-off-by: Stanimir Varbanov > > --- > > Reviewed-by: Stephen Boyd Both patches

Re: [PATCH] CRYPTO: omap-sham: Add missing modalias

2013-10-29 Thread Herbert Xu
On Sat, Oct 26, 2013 at 11:00:41PM +0200, Pali Rohár wrote: > From: Joni Lapilainen > > Signed-off-by: Joni Lapilainen Patch applied. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list:

[PATCH] include/linux/wait.h: add ';' for the statement which missed it.

2013-10-29 Thread Chen Gang
Add ';' for the statement, or can not pass compiling. The related error (for powerpc allmodconfig): CC block/blk-mq.o block/blk-mq.c: In function ‘blk_mq_queue_enter’: block/blk-mq.c:108:8: error: expected ‘;’ before ‘__ret’ block/blk-mq.c:108:6: error: void value not ignored as it

Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int()

2013-10-29 Thread Cong Wang
On Tue, Oct 29, 2013 at 7:42 PM, David Miller wrote: > From: David Mackey > Date: Tue, 29 Oct 2013 15:16:38 -0700 > >> Using dev_kfree_skb_any() will resolve the below issue when a >> netconsole message is transmitted in an irq. > ... >> Signed-off-by: David Mackey > > This is absolutely not

Re: [PATCH V4 1/2] tps6507x-ts: Add DT support

2013-10-29 Thread Manish Badarkhe
Hi Mark, Apologize for my late reply. On Thu, Oct 24, 2013 at 10:57 PM, Mark Rutland wrote: > > On Thu, Oct 24, 2013 at 06:05:53PM +0100, Manish Badarkhe wrote: > > Hi Mark, > > > > Thank you for your reply. > > > > On Wed, Oct 23, 2013 at 10:15 PM, Mark Rutland wrote: > > > > On Wed, Oct

Re: [RFC PATCH RESEND] fb: reorder the lock sequence to fix a potential lockdep

2013-10-29 Thread Gu Zheng
Hi Tomi, Jean, How about this patch? Thanks, Gu On 10/28/2013 02:01 PM, Gu Zheng wrote: > Following commits: > 50e244cc79 fb: rework locking to fix lock ordering on takeover > e93a9a8687 fb: Yet another band-aid for fixing lockdep mess > 054430e773 fbcon: fix locking harder > > reworked

Re: [PATCH V2 2/2] sched: Remove un-necessary iteration over sched domains to update nr_busy_cpus

2013-10-29 Thread Preeti U Murthy
The changelog has missed mentioning the introduction of sd_asym per_cpu sched domain. Apologies for this. The patch with the changelog including mention of sd_asym is pasted below. Regards Preeti U Murthy --- sched: Remove un-necessary iteration over sched domains to update

Re: [PATCH 1/2] spi: add Intel Mid SSP driver

2013-10-29 Thread Ning Li
On Tue, 29 Oct 2013 13:18:37 -0700 David Cohen wrote: > Hi Felipe, > > On 10/29/2013 11:31 AM, Felipe Balbi wrote: > > Hi, > > > > On Tue, Oct 29, 2013 at 11:05:49AM -0700, David Cohen wrote: > >> diff --git a/drivers/spi/spi-intel-mid-ssp.c > >> b/drivers/spi/spi-intel-mid-ssp.c new file mode

Re: [PATCH] perf: fix two warning in bench/numa

2013-10-29 Thread Wei Yang
Dear maintainer, Is this one accepted or droped? Or I missed the right person? On Sun, Sep 22, 2013 at 04:49:24PM +0800, Wei Yang wrote: >There two warnings in bench/numa, when buiding this on 32-bit machine. > >The warning output is attached: > >bench/numa.c:1113:20: error: comparison between

[PATCH V2 2/2] sched: Remove un-necessary iteration over sched domains to update nr_busy_cpus

2013-10-29 Thread Preeti U Murthy
nr_busy_cpus parameter is used by nohz_kick_needed() to find out the number of busy cpus in a sched domain which has SD_SHARE_PKG_RESOURCES flag set. Therefore instead of updating nr_busy_cpus at every level of sched domain, since it is irrelevant, we can update this parameter only at the parent

[PATCH V2 1/2] sched: Fix asymmetric scheduling for POWER7

2013-10-29 Thread Preeti U Murthy
From: Vaidyanathan Srinivasan Asymmetric scheduling within a core is a scheduler loadbalancing feature that is triggered when SD_ASYM_PACKING flag is set. The goal for the load balancer is to move tasks to lower order idle SMT threads within a core on a POWER7 system. In nohz_kick_needed(), we

[PATCH V2 0/2] sched: Cleanups,fixes in nohz_kick_needed()

2013-10-29 Thread Preeti U Murthy
Changes from V1:https://lkml.org/lkml/2013/10/21/248 1. Swapped the order of PATCH1 and PATCH2 in V1 so as to not mess with the nr_busy_cpus parameter computation during asymmetric balancing, while fixing it. 2. nohz_busy_cpus parameter is to be updated and queried at only one level of the sched

Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-29 Thread Michael Opdenacker
Hi Yann, Thank you for your review! On 10/29/2013 07:06 PM, Yann E. MORIN wrote: > I guess all these grep spawning are what makes it slow. > > I wonder if it would not be possible to invert the loop (in pseudo > Python code): > > for f in all_interesting_files: > read f in memory >

Re: [PATCH net 2/3] r8152: modify the tx flow

2013-10-29 Thread David Miller
From: hayeswang Date: Wed, 30 Oct 2013 11:03:55 +0800 > David Miller [mailto:da...@davemloft.net] >> Sent: Wednesday, October 30, 2013 5:50 AM >> To: Hayeswang >> Cc: net...@vger.kernel.org; nic_swsd; >> linux-kernel@vger.kernel.org; linux-...@vger.kernel.org >> Subject: Re: [PATCH net 2/3]

Re: [PATCH v9 1/5] ARM: add basic support for Trusted Foundations

2013-10-29 Thread Alex Courbot
On 10/29/2013 05:12 PM, Kumar Gala wrote: On Oct 28, 2013, at 7:25 PM, Mark Rutland wrote: On Mon, Oct 28, 2013 at 11:31:36PM +, Tomasz Figa wrote: On Monday 28 of October 2013 14:56:49 Olof Johansson wrote: On Mon, Oct 28, 2013 at 05:57:04AM -0500, Kumar Gala wrote: On Oct 28, 2013,

Re: [PATCH] scripts/checkkconfig.py: find unused Kconfig parameters

2013-10-29 Thread Michael Opdenacker
Hi Michal, Thank you very much for your reviews! On 10/25/2013 03:45 PM, Michal Marek wrote: > You can process Kconfig files and source files separately. And you can > speed up the script a lot, if you simply record all CONFIG_* strings > found in the sources, and then compare this to the set

Re: [PATCH] tpm/tpm_i2c_stm_st33: Check return code of get_burstcount (fix CID: 986658)

2013-10-29 Thread Greg KH
On Wed, Oct 30, 2013 at 01:42:11AM +0100, Peter Hüwe wrote: > Hi Greg, > > > > > > CID: 986658 > > What is this field for? > > That's the scan id in the coverity database. > If you think that's just noise I can leave it out. It's noise as not everyone can see it or make anything out of it, so

RE: [PATCH net 2/3] r8152: modify the tx flow

2013-10-29 Thread hayeswang
David Miller [mailto:da...@davemloft.net] > Sent: Wednesday, October 30, 2013 5:50 AM > To: Hayeswang > Cc: net...@vger.kernel.org; nic_swsd; > linux-kernel@vger.kernel.org; linux-...@vger.kernel.org > Subject: Re: [PATCH net 2/3] r8152: modify the tx flow > > From: Hayes Wang > Date: Tue, 29

Re: [PATCH] mm: cma: free cma page to buddy instead of being cpu hot page

2013-10-29 Thread Minchan Kim
Hello, On Tue, Oct 29, 2013 at 11:02:30PM +0800, Zhang Mingjun wrote: > On Tue, Oct 29, 2013 at 8:27 PM, Mel Gorman wrote: > > > On Tue, Oct 29, 2013 at 07:49:30PM +0800, Zhang Mingjun wrote: > > > On Tue, Oct 29, 2013 at 5:33 PM, Mel Gorman wrote: > > > > > > > On Mon, Oct 28, 2013 at

Re: [PATCH net] virtio-net: correctly handle cpu hotplug notifier during resuming

2013-10-29 Thread David Miller
From: Jason Wang Date: Tue, 29 Oct 2013 15:11:07 +0800 > commit 3ab098df35f8b98b6553edc2e40234af512ba877 (virtio-net: don't respond to > cpu hotplug notifier if we're not ready) tries to bypass the cpu hotplug > notifier by checking the config_enable and does nothing is it was false. So it >

BUG_ON(irq_has_action(entry->irq + i)) in free_msi_irqs()

2013-10-29 Thread LF.Tan
Hi all I am new in PCI and now working on MSI support on our PCIe host driver. I have an endpoint driver requests for a MSI interrupt. When the endpoint driver try to free the interrupt, it cause the kernel BUG_ON() message is printed out. The software flow: Endpoint driver --> pci_disable_msi

[PATCH 1/3] block: Add REQ_NOMERGE into REQ_COMMON_MASK

2013-10-29 Thread majianpeng
For bio with REQ_NOMERGE,it mean this bio can't merge with other bios. And the request with this bio has the same meaning. In blk_queue_bio, bio with REQ_NOMERGE can't be merged and get a new request. But in init_request_from_bio, request can't test REQ_NOMERGE. So the request can merge other bio

[PATCH 2/3] block: Check bio can merge before call attempt_plug_merge.

2013-10-29 Thread majianpeng
Signed-off-by: Jianpeng Ma --- block/blk-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-core.c b/block/blk-core.c index 0a00e4e..fb970fd 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -1492,7 +1492,7 @@ void blk_queue_bio(struct request_queue *q,

Re: [PATCH] bnx2: Use dev_kfree_skb_any() in bnx2_tx_int()

2013-10-29 Thread David Miller
From: David Mackey Date: Tue, 29 Oct 2013 15:16:38 -0700 > Using dev_kfree_skb_any() will resolve the below issue when a > netconsole message is transmitted in an irq. ... > Signed-off-by: David Mackey This is absolutely not the correct fix. The netpoll facility must invoke ->poll() in an

[PATCH 0/3] handle some bugs for REQ_NOMERGE.

2013-10-29 Thread majianpeng
This patch set mainly handle some bugs for REQ_NOMERGE. Jianpeng Ma (3): block: Add REQ_NOMERGE into REQ_COMMON_MASK block: Check bio can merge before call attempt_plug_merge. md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE. block/blk-core.c

[PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE.

2013-10-29 Thread majianpeng
For R5_ReadNoMerge,it mean this bio can't merge with other bios or request.It used REQ_FLUSH to achieve this. But REQ_NOMERGE can do the same work. Signed-off-by: Jianpeng Ma --- drivers/md/raid5.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/raid5.c

Re: [PATCH] net/cdc_ncm: fix null pointer panic at usbnet_link_change

2013-10-29 Thread David Miller
From: "Du, ChangbinX" Date: Tue, 29 Oct 2013 03:30:42 + > In cdc_ncm_bind() function, it call cdc_ncm_bind_common() to setup usb. > But cdc_ncm_bind_common() may meet error and cause usbnet_disconnect() > be called which calls free_netdev(net). Thus usbnet structure(alloced > with net_device

Re: [PATCH v7 1/3] Staging: zram: Fix access of NULL pointer

2013-10-29 Thread Minchan Kim
On Wed, Oct 30, 2013 at 04:40:54AM +0530, Rashika Kheria wrote: > This patch fixes the bug in reset_store caused by accessing NULL pointer. > > The bdev gets its value from bdget_disk() which could fail when memory > pressure is severe and hence can return NULL because allocation of > inode in

Re: [PATCH v7 3/3] Staging: zram: Fix variable dereferenced before check

2013-10-29 Thread Minchan Kim
On Wed, Oct 30, 2013 at 04:45:24AM +0530, Rashika Kheria wrote: > This patch fixes the following Smatch warning in zram_drv.c- > drivers/staging/zram/zram_drv.c:899 > destroy_device() warn: variable dereferenced before check 'zram->disk' (see > line 896) > > Cc: sta...@vger.kernel.org It

Re: [PATCH v7 2/3] Staging: zram: Fix decrement of variable by calling bdput()

2013-10-29 Thread Minchan Kim
On Wed, Oct 30, 2013 at 04:42:56AM +0530, Rashika Kheria wrote: > As suggested by Jerome Marchand "The code in reset_store get the block device > (bdget_disk()) but it does not put it (bdput()) when it's done using it. > The usage count is therefor incremented but never decremented." > > Hence,

Re: [PATCH v7 1/3] Staging: zram: Fix access of NULL pointer

2013-10-29 Thread Minchan Kim
On Wed, Oct 30, 2013 at 04:40:54AM +0530, Rashika Kheria wrote: > This patch fixes the bug in reset_store caused by accessing NULL pointer. > > The bdev gets its value from bdget_disk() which could fail when memory > pressure is severe and hence can return NULL because allocation of > inode in

Re: [PATCH 2/3] PCI: Refactor MSI/MSIX mask restore code to fix interrupt lost issue

2013-10-29 Thread Zhenzhong Duan
On 2013-10-30 05:58, Bjorn Helgaas wrote: On Wed, Oct 16, 2013 at 02:33:04PM +0800, Zhenzhong Duan wrote: Driver init call graph under baremetal: driver_init-> msix_capability_init-> msix_program_entries-> msix_mask_irq-> entry->masked = 1

linux-next: manual merge of the net-next tree with the net tree

2013-10-29 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in drivers/net/netconsole.c between commit c7c6effdeffc ("netconsole: fix multiple race conditions") from the net tree and commit 22ded57729e6 ("netconsole: Convert to pr_") from the net-next tree. (Thanks for removing that

Re: [PATCH] mmc: rtsx: change phase searching method

2013-10-29 Thread micky
Hi Chris: Have you accepted this patch, I'm waiting a long time for your reply. Best Reagards. micky On 09/02/2013 05:16 PM, micky_ch...@realsil.com.cn wrote: From: Micky Ching The new phase searching method is more concise, and makes the code easier to understand. Signed-off-by: Micky

Re: [patch 3/6] Cleanup efi_enter_virtual_mode function

2013-10-29 Thread Dave Young
On 10/29/13 at 02:43pm, Borislav Petkov wrote: > On Tue, Oct 29, 2013 at 10:32:03AM +0800, Dave Young wrote: > > I remember I tried your efi branch, but the code is different from > > what you sent to list, thus I turned to use the mbox patches. > > Yeah, please use the #efi branch as I keep

Re: mmotm 2013-10-29-16-22 uploaded (input)

2013-10-29 Thread Randy Dunlap
On 10/29/13 16:23, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2013-10-29-16-22 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of my

Re: ELAN Touchscreen regression in recent 3.12 rc's? (USB)

2013-10-29 Thread Kevin Fenzi
On Wed, 30 Oct 2013 09:41:06 +0800 AceLan Kao wrote: > Hi, > > It's hard to believe that those quirks will lead to the problem. > And actually, there are 4 new commits introduced to -rc7, and 3 of > them are quirks. > > % git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid >

Re: [Suggestion] arc: compiler: bug: about an arc compiler's bug which is not in gcc main source code.

2013-10-29 Thread Chen Gang
On 10/23/2013 11:12 AM, Chen Gang wrote: > On 10/23/2013 10:51 AM, Francois Bedard wrote: >> Our sources are on github at >> https://github.com/foss-for-synopsys-dwc-arc-processors and you can report >> problems by opening "Issues" with command lines and log outputs below >> against relevant

Re: [PATCH 1/2] spi: add Intel Mid SSP driver

2013-10-29 Thread Randy Dunlap
On 10/29/13 11:05, David Cohen wrote: a few more comments: > +static unsigned int ssp_get_clk_div(int speed) > +{ > + return max(1 / speed, 4) - 1; Divide uses library call? I dunno... Bad if so. Would need to use some function from #include > +} > +/** > + * setup() - Driver

Re: ELAN Touchscreen regression in recent 3.12 rc's? (USB)

2013-10-29 Thread AceLan Kao
Hi, It's hard to believe that those quirks will lead to the problem. And actually, there are 4 new commits introduced to -rc7, and 3 of them are quirks. % git log --pretty=oneline v3.12-rc6..v3.12-rc7 drivers/hid 86b84167d4e67372376a57ea9955c5d53dae232f HID: wiimote: add LEGO-wiimote VID

Re: [PATCH 2/5] fat: add fat_fallocate operation

2013-10-29 Thread OGAWA Hirofumi
Namjae Jeon writes: >>> + /* Release unwritten fallocated blocks on file release. */ >>> + if (round_up(inode->i_size, sb->s_blocksize) < >>> + MSDOS_I(inode)->i_disksize && inode->i_nlink != 0) >>> + fat_truncate_blocks(inode, inode->i_size); >>> + >>>

Re: [PATCH] sysfs: move assignment to be under lock in sysfs_remove_dir()

2013-10-29 Thread Linus Torvalds
On Tue, Oct 29, 2013 at 5:39 PM, Eric W. Biederman wrote: > > I don't have a strong feeling either way but how would that matter? > There is only ever one sd associated with a kobj. What does that matter? If you have multiple callers, they might try to free that one sd twice, since they could

Re: [PATCH 17/23] dm: Refactor for new bio cloning/splitting

2013-10-29 Thread Mike Snitzer
On Tue, Oct 29 2013 at 8:19pm -0400, Kent Overstreet wrote: > On Tue, Oct 29, 2013 at 08:09:08PM -0400, Mike Snitzer wrote: > > > > But now that I look closer, the above dm-thin.c hunks belong in: > > [PATCH 19/23] block: Generic bio chaining > > > > Seems these changes were mistakenly folded

Re: [PATCH 1/5] fat: add i_disksize to represent uninitialized size

2013-10-29 Thread OGAWA Hirofumi
Namjae Jeon writes: >>> diff --git a/fs/fat/cache.c b/fs/fat/cache.c >>> index 91ad9e1..37572c2 100644 >>> --- a/fs/fat/cache.c >>> +++ b/fs/fat/cache.c >>> @@ -329,10 +329,10 @@ int fat_bmap(struct inode *inode, sector_t sector, >>> sector_t *phys, >>> return 0; >>> >>>

Re: [PATCH v9 01/18] arm: make SWIOTLB available

2013-10-29 Thread Stefano Stabellini
On Tue, 29 Oct 2013, Russell King - ARM Linux wrote: > So... what I'm saying is please fix xgmac to use the DMA API properly > rather than working around such problems. :) OK. Would the appended patch fix your concerns? --- arm: make SWIOTLB available IOMMU_HELPER is needed because SWIOTLB

[PATCH-next v3] kernel/system_certificate.S: use real contents instead of macro GLOBAL()

2013-10-29 Thread Chen Gang
If a macro is only used within 2 times, and also its contents are within 2 lines, recommend to expand it to shrink code line. For our case, the macro is not portable either: some architectures' assembler may use another character to mark newline in a macro (e.g. '`' for arc), which will cause

RE: [f2fs-dev] [PATCH V2 RESEND] f2fs: check all ones or zeros bitmap with bitops for better mount performance

2013-10-29 Thread Chao Yu
Hi Lee, > -Original Message- > From: Changman Lee [mailto:cm224@samsung.com] > Sent: Wednesday, October 30, 2013 7:25 AM > To: 'Chao Yu'; jaegeuk@samsung.com > Cc: linux-fsde...@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-f2fs-de...@lists.sourceforge.net > Subject: RE:

Re: [PATCH 1/2] tpm/tpm_ppi: Do not compare strcmp(a,b) == -1

2013-10-29 Thread Joe Perches
On Wed, 2013-10-30 at 01:40 +0100, Peter Huewe wrote: > strcmp does return the difference between two strings not only -1,0,1 > consequently > if (strcmp (a,b) == -1) > might lead to taking the wrong branch > > -> compare with <= instead. lib/string.c:strcmp returns only -1,0,1 so that's what

Re: [PATCH v5 5/7] arm64, jump label: detect %c support for ARM64

2013-10-29 Thread Will Deacon
On Fri, Oct 18, 2013 at 04:19:59PM +0100, Jiang Liu wrote: > From: Jiang Liu > > As commit a9468f30b5eac6 "ARM: 7333/2: jump label: detect %c > support for ARM", this patch detects the same thing for ARM64 > because some ARM64 GCC versions have the same issue. > > Some versions of ARM64 GCC

Re: [PATCH] arch: use ASM_NL instead of ';' for assembler new line character in the macro

2013-10-29 Thread Chen Gang
On 10/29/2013 09:59 PM, David Howells wrote: > Chen Gang wrote: > > For "kernel/modsign_certificate.S", I recommend to expand the macro > which will shrink code line, either need not include additional header > file, I feel that will be simpler for both code reader and writers. >>> I

Re: [PATCH v5 6/7] arm64, jump label: optimize jump label implementation

2013-10-29 Thread Will Deacon
On Fri, Oct 18, 2013 at 04:20:00PM +0100, Jiang Liu wrote: > From: Jiang Liu > > Optimize jump label implementation for ARM64 by dynamically patching > kernel text. > > Signed-off-by: Jiang Liu > Cc: Jiang Liu > --- > arch/arm64/Kconfig | 1 + >

Re: linux-next: build failure after merge of the final tree (gpio tree related)

2013-10-29 Thread Alex Courbot
On 10/29/2013 10:25 PM, Linus Walleij wrote: On Tue, Oct 29, 2013 at 10:10 AM, Stephen Rothwell wrote: I have applied the following patch for today (it should go into the gpio tree if it is considered correct): From: Stephen Rothwell Date: Tue, 29 Oct 2013 20:05:12 +1100 Subject: [PATCH]

perf confused by modules being loaded in between addresses in /proc/kallsyms

2013-10-29 Thread Michael Hudson-Doyle
Hi, On arm, probably since "ARM: use linker magic for vectors and vector stubs" (although I haven't checked this), perf report tends to allocate all kernel time to the module loaded at the highest address. This turns out to be because the "perf_event__synthesize_modules" generates a

[PATCH net-next RFC 4/5] xen-netback: Fix indentations

2013-10-29 Thread Zoltan Kiss
I've left intentionally these indentations in this way, to improve readability of previous patches. Signed-off-by: Zoltan Kiss --- drivers/net/xen-netback/netback.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/xen-netback/netback.c

[PATCH net-next RFC 1/5] xen-netback: Introduce TX grant map definitions

2013-10-29 Thread Zoltan Kiss
This patch contains the new definitions necessary for grant mapping. Signed-off-by: Zoltan Kiss --- drivers/net/xen-netback/common.h| 22 ++ drivers/net/xen-netback/interface.c |1 + drivers/net/xen-netback/netback.c | 134 +++ 3 files changed,

[PATCH net-next RFC 2/5] xen-netback: Change TX path from grant copy to mapping

2013-10-29 Thread Zoltan Kiss
This patch changes the grant copy on the TX patch to grant mapping Signed-off-by: Zoltan Kiss --- drivers/net/xen-netback/interface.c | 39 +- drivers/net/xen-netback/netback.c | 241 +-- 2 files changed, 126 insertions(+), 154 deletions(-) diff --git

[PATCH net-next RFC 4/5] xen-netback: Change RX path for mapped SKB fragments

2013-10-29 Thread Zoltan Kiss
RX path need to know if the SKB fragments are stored on pages from another domain. Signed-off-by: Zoltan Kiss --- drivers/net/xen-netback/netback.c | 46 + 1 file changed, 41 insertions(+), 5 deletions(-) diff --git a/drivers/net/xen-netback/netback.c

[PATCH net-next RFC 3/5] xen-netback: Remove old TX grant copy definitons

2013-10-29 Thread Zoltan Kiss
These became obsolate with grant mapping. Signed-off-by: Zoltan Kiss --- drivers/net/xen-netback/common.h | 37 +--- drivers/net/xen-netback/netback.c | 48 ++--- 2 files changed, 3 insertions(+), 82 deletions(-) diff --git

[PATCH net-next RFC 0/5] xen-netback: TX grant mapping instead of copy

2013-10-29 Thread Zoltan Kiss
A long known problem of the upstream netback implementation that on the TX path (from guest to Dom0) it copies the whole packet from guest memory into Dom0. That simply became a bottleneck with 10Gb NICs, and generally it's a huge perfomance penalty. The classic kernel version of netback used

Re: [PATCH v5 4/7] arm64: introduce aarch64_insn_gen_{nop|branch_imm}() helper functions

2013-10-29 Thread Will Deacon
On Fri, Oct 18, 2013 at 04:19:58PM +0100, Jiang Liu wrote: > From: Jiang Liu > > Introduce aarch64_insn_gen_{nop|branch_imm}() helper functions, which > will be used to implement jump label on ARM64. > > Signed-off-by: Jiang Liu > Cc: Jiang Liu > --- > arch/arm64/include/asm/insn.h | 13

Re: pull request for Tegra clock rework and Tegra124 clock support

2013-10-29 Thread Peter De Schrijver
Mike, This is an update to the previous pull request which fixes some late bugs. Thanks, Peter. The following changes since commit 6c984fc8c6314596c302bbecf79dc59d9f98f348: clk: tegra124: add suspend/resume function for tegra_cpu_car_ops (2013-10-21 16:39:24 +0300) are available in the

Re: [PATCH v4 0/3] x86, apic, kexec: Add disable_cpu_apic kernel parameter

2013-10-29 Thread HATAYAMA Daisuke
(2013/10/29 23:21), Baoquan He wrote: Hi, I am reviewing this patchset, and found there's a cpu0 hotplug feature posted by intel which we can borrow an idea from. In that implementation, CPU0 is waken up by nmi not INIT to avoid the realmode bootstrap code execution. I tried it by below patch

Re: [PATCH] sysfs: move assignment to be under lock in sysfs_remove_dir()

2013-10-29 Thread Eric W. Biederman
Greg KH writes: > From: Greg Kroah-Hartman > > Linus noticed that the assignment of sd isn't protected by the lock in > sysfs_remove_dir(), so move the assignment of the variable under the > lock to be safe. I don't have a strong feeling either way but how would that matter? There is only ever

[PATCH] clk: tegra: use pll_ref as the pll_e parent

2013-10-29 Thread Peter De Schrijver
Use pll_ref instead of pll_re_vco as the pll_e parent on Tegra114 and Tegra124. Also add a pll_ref table entry for pll_e for Tegra114. Signed-off-by: Peter De Schrijver --- drivers/clk/tegra/clk-pll.c |7 --- drivers/clk/tegra/clk-tegra114.c |3 ++- 2 files changed, 6

Re: [PATCH 2/2] dma: mv_xor: Use high_base mmio where appropriate

2013-10-29 Thread Dan Williams
On Tue, Oct 29, 2013 at 5:33 PM, Ezequiel Garcia wrote: > By the way, I didn't initially Cced dmaengine list because it's not > in the MAINTAINERS file. > > How about we add it and avoid this happening to other developers? It's there now, but we just created it so you happened to be one of the

Re: [PATCH] tpm/tpm_i2c_stm_st33: Check return code of get_burstcount (fix CID: 986658)

2013-10-29 Thread Peter Hüwe
Hi Greg, > > > > CID: 986658 > What is this field for? That's the scan id in the coverity database. If you think that's just noise I can leave it out. Thanks, Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 4/6] edac: Document Krait L1/L2 EDAC driver binding

2013-10-29 Thread Mark Rutland
On Tue, Oct 29, 2013 at 06:00:59PM +, Stephen Boyd wrote: > On 10/29/13 01:21, Kumar Gala wrote: > > On Oct 28, 2013, at 7:31 PM, Stephen Boyd wrote: > > > >> The Krait L1/L2 error reporting device is made up of two > >> interrupts, one per-CPU interrupt for the L1 caches and one > >>

[PATCH 1/2] tpm/tpm_ppi: Do not compare strcmp(a,b) == -1

2013-10-29 Thread Peter Huewe
strcmp does return the difference between two strings not only -1,0,1 consequently if (strcmp (a,b) == -1) might lead to taking the wrong branch -> compare with <= instead. This also makes the code/behavior compliant with its comments. (e.g. if PPI Version is 1.0) Fixes Coverity complaints:

[PATCH 2/2] tpm/tpm_ppi: Check return value of acpi_get_name

2013-10-29 Thread Peter Huewe
If status = acpi_get_name(handle, ACPI_FULL_PATHNAME, ); fails for whatever reason and does not return AE_OK if (strstr(buffer.pointer, context) != NULL) { does dereference a null pointer. -> Check the return value and return the status to the caller Found by coverity CID: 728462 Explicit null

Re: [PATCH 4/6] edac: Document Krait L1/L2 EDAC driver binding

2013-10-29 Thread Mark Rutland
On Tue, Oct 29, 2013 at 05:06:45AM +, Stephen Boyd wrote: > On 10/28, Mark Rutland wrote: > > On Tue, Oct 29, 2013 at 12:31:28AM +, Stephen Boyd wrote: > > > + > > > +Optional properties: > > > +- interrupt-names: Should contain the interrupt names "l1_irq" and > > > + "l2_irq" > > > >

Re: [PATCH 2/2] dma: mv_xor: Use high_base mmio where appropriate

2013-10-29 Thread Ezequiel Garcia
On Tue, Oct 29, 2013 at 12:15:18PM -0700, Dan Williams wrote: > On Tue, Oct 29, 2013 at 2:32 AM, Thomas Petazzoni > wrote: > > Dan, Ezequiel, > > > > On Tue, 29 Oct 2013 05:34:08 -0300, Ezequiel Garcia wrote: > > > >> > On Mon, Oct 28, 2013 at 3:54 PM, Ezequiel Garcia > >> > wrote: > >> > >

Re: [PATCH 01/12] clocksource: sh_cmt: Add clk_prepare/unprepare support

2013-10-29 Thread Simon Horman
On Wed, Oct 30, 2013 at 01:13:40AM +0100, Laurent Pinchart wrote: > Hi Simon, > > On Wednesday 30 October 2013 09:10:19 Simon Horman wrote: > > On Tue, Oct 29, 2013 at 10:55:05AM +0100, Laurent Pinchart wrote: > > > On Tuesday 29 October 2013 14:55:35 Simon Horman wrote: > > > > On Mon, Oct 28,

Re: [PATCH v7 4/5] clk: Add common __clk_get(), __clk_put() implementations

2013-10-29 Thread Russell King - ARM Linux
On Tue, Oct 29, 2013 at 08:51:07PM +0100, Sylwester Nawrocki wrote: > This patch adds common __clk_get(), __clk_put() clkdev helpers that > replace their platform specific counterparts when the common clock > API is used. > > The owner module pointer field is added to struct clk so a reference >

Re: [PATCH 17/23] dm: Refactor for new bio cloning/splitting

2013-10-29 Thread Kent Overstreet
On Tue, Oct 29, 2013 at 08:09:08PM -0400, Mike Snitzer wrote: > On Tue, Oct 29 2013 at 4:18pm -0400, > Kent Overstreet wrote: > > > We need to convert the dm code to the new bvec_iter primitives which > > respect bi_bvec_done; they also allow us to drastically simplify dm's > > bio splitting

Re: [PATCH v5 2/7] arm64: introduce interfaces to hotpatch kernel and module code

2013-10-29 Thread Will Deacon
Hi Jinag Liu, Sorry for the delayed review, I've been travelling. On Fri, Oct 18, 2013 at 04:19:56PM +0100, Jiang Liu wrote: > From: Jiang Liu If I try and email you at your Huawei address, I get a bounce from the mail server. Is that expected? If so, it's not very helpful from a commit log

Re: [PATCH 01/12] clocksource: sh_cmt: Add clk_prepare/unprepare support

2013-10-29 Thread Laurent Pinchart
Hi Simon, On Wednesday 30 October 2013 09:10:19 Simon Horman wrote: > On Tue, Oct 29, 2013 at 10:55:05AM +0100, Laurent Pinchart wrote: > > On Tuesday 29 October 2013 14:55:35 Simon Horman wrote: > > > On Mon, Oct 28, 2013 at 11:49:18PM +0100, Laurent Pinchart wrote: > > > > Prepare the clock at

Re: [PATCH v3 02/10] spmi: Linux driver framework for SPMI

2013-10-29 Thread Russell King - ARM Linux
On Mon, Oct 28, 2013 at 01:12:35PM -0500, Josh Cartwright wrote: > From: Kenneth Heitke > > System Power Management Interface (SPMI) is a specification > developed by the MIPI (Mobile Industry Process Interface) Alliance > optimized for the real time control of Power Management ICs (PMIC). > >

Re: [PATCH 01/12] clocksource: sh_cmt: Add clk_prepare/unprepare support

2013-10-29 Thread Simon Horman
On Tue, Oct 29, 2013 at 10:55:05AM +0100, Laurent Pinchart wrote: > Hi Simon, > > On Tuesday 29 October 2013 14:55:35 Simon Horman wrote: > > On Mon, Oct 28, 2013 at 11:49:18PM +0100, Laurent Pinchart wrote: > > > Prepare the clock at probe time, as there is no other appropriate place > > > in

Re: [PATCH 17/23] dm: Refactor for new bio cloning/splitting

2013-10-29 Thread Mike Snitzer
On Tue, Oct 29 2013 at 4:18pm -0400, Kent Overstreet wrote: > We need to convert the dm code to the new bvec_iter primitives which > respect bi_bvec_done; they also allow us to drastically simplify dm's > bio splitting code. > > Also kill bio_sector_offset(), dm was the only user and it

Re: [PATCH 4/6] edac: Document Krait L1/L2 EDAC driver binding

2013-10-29 Thread Stephen Boyd
On 10/29, Stephen Boyd wrote: > On 10/29/13 01:21, Kumar Gala wrote: > > On Oct 28, 2013, at 7:31 PM, Stephen Boyd wrote: > > > >> The Krait L1/L2 error reporting device is made up of two > >> interrupts, one per-CPU interrupt for the L1 caches and one > >> interrupt for the L2 cache. > >> > >>

Re: [PATCH] Immutable biovecs

2013-10-29 Thread Kent Overstreet
On Tue, Oct 29, 2013 at 02:36:47PM -0600, Jens Axboe wrote: > On Tue, Oct 29 2013, Kent Overstreet wrote: > > Jens - this patch series is ready to go, driver maintainers have reviewed > > and > > tested it and the code's been essentially done for probably a year now - > > can we > > get this

  1   2   3   4   5   6   7   8   9   10   >