Re: [RFC] drop owner assignment from platform_drivers

2014-10-11 Thread Wolfram Sang
> I missed the one code path you pointed out, and that should be fixed, > but that doesn't mean that the original patch should be reverted, as it > is the way we want things to be, let's just fix up the bug and move on. OK, that is a clear statement. So, what is your opinion on the original

Re: [PATCH] tty/serial_core: Introduce lock mechanism for RS485

2014-10-11 Thread Nicolas Ferre
On 10/10/2014 15:38, Ricardo Ribalda Delgado : > Introduce an homogeneous lock system between setting and using the rs485 > data of the uart_port. > > This patch should not be split into multiple ones in order to avoid > leaving the tree in an unstable state. > > Suggested-by: Alan Cox > Cc:

Re: fs/namei.c: Misuse of sequence counts?

2014-10-11 Thread Eric Biggers
Here's a patch for reference (untested): diff --git a/fs/namei.c b/fs/namei.c index a7b05bf..84704e4 100644 --- a/fs/namei.c +++ b/fs/namei.c @@ -649,17 +649,15 @@ static __always_inline void set_root(struct nameidata *nd) static int link_path_walk(const char *, struct nameidata *); -static

[PATCH] drm: drm_err: Remove unnecessary __func__ argument

2014-10-11 Thread Joe Perches
Removing the unnecessary drm_err __func__ argument by using the equivalent %pf and __builtin_return_address(0) makes the code smaller for every use of the DRM_ERROR macro. For instance: (allmodconfig) $ size drivers/gpu/drm/i915/i915.o* textdata bss dec hex filename 922447

[PATCH v9 06/12] mpx: extend siginfo structure to include bound violation information

2014-10-11 Thread Qiaowei Ren
This patch adds new fields about bound violation into siginfo structure. si_lower and si_upper are respectively lower bound and upper bound when bound violation is caused. Signed-off-by: Qiaowei Ren --- include/uapi/asm-generic/siginfo.h |9 - kernel/signal.c|

[PATCH v9 04/12] x86, mpx: add MPX to disaabled features

2014-10-11 Thread Qiaowei Ren
This allows us to use cpu_feature_enabled(X86_FEATURE_MPX) as both a runtime and compile-time check. When CONFIG_X86_INTEL_MPX is disabled, cpu_feature_enabled(X86_FEATURE_MPX) will evaluate at compile-time to 0. If CONFIG_X86_INTEL_MPX=y, then the cpuid flag will be checked at runtime. This

[PATCH v9 07/12] mips: sync struct siginfo with general version

2014-10-11 Thread Qiaowei Ren
New fields about bound violation are added into general struct siginfo. This will impact MIPS and IA64, which extend general struct siginfo. This patch syncs this struct for MIPS with general version. Signed-off-by: Qiaowei Ren --- arch/mips/include/uapi/asm/siginfo.h |4 1 files

[PATCH v9 05/12] x86, mpx: on-demand kernel allocation of bounds tables

2014-10-11 Thread Qiaowei Ren
MPX only has 4 hardware registers for storing bounds information. If MPX-enabled code needs more than these 4 registers, it needs to spill them somewhere. It has two special instructions for this which allow the bounds to be moved between the bounds registers and some new "bounds tables". They

[PATCH v9 03/12] x86, mpx: add MPX specific mmap interface

2014-10-11 Thread Qiaowei Ren
We have to do the allocation of bounds tables in kernel (See the patch "on-demand kernel allocation of bounds tables"). Moreover, if we want to track MPX VMAs we need to be able to stick new VM_MPX flag and a specific vm_ops for MPX in the vma_area_struct. But there are not suitable interfaces to

[PATCH v9 01/12] x86, mpx: introduce VM_MPX to indicate that a VMA is MPX specific

2014-10-11 Thread Qiaowei Ren
MPX-enabled applications using large swaths of memory can potentially have large numbers of bounds tables in process address space to save bounds information. These tables can take up huge swaths of memory (as much as 80% of the memory on the system) even if we clean them up aggressively. In the

[PATCH v9 08/12] ia64: sync struct siginfo with general version

2014-10-11 Thread Qiaowei Ren
New fields about bound violation are added into general struct siginfo. This will impact MIPS and IA64, which extend general struct siginfo. This patch syncs this struct for IA64 with general version. Signed-off-by: Qiaowei Ren --- arch/ia64/include/uapi/asm/siginfo.h |8 ++-- 1 files

[PATCH v9 12/12] x86, mpx: add documentation on Intel MPX

2014-10-11 Thread Qiaowei Ren
This patch adds the Documentation/x86/intel_mpx.txt file with some information about Intel MPX. Signed-off-by: Qiaowei Ren --- Documentation/x86/intel_mpx.txt | 245 +++ 1 files changed, 245 insertions(+), 0 deletions(-) create mode 100644

[PATCH v9 09/12] x86, mpx: decode MPX instruction to get bound violation information

2014-10-11 Thread Qiaowei Ren
This patch sets bound violation fields of siginfo struct in #BR exception handler by decoding the user instruction and constructing the faulting pointer. This patch does't use the generic decoder, and implements a limited special-purpose decoder to decode MPX instructions, simply because the

[PATCH v9 11/12] x86, mpx: cleanup unused bound tables

2014-10-11 Thread Qiaowei Ren
There are two mappings in play: 1. The mapping with the actual data, which userspace is munmap()ing or brk()ing away, etc... 2. The mapping for the bounds table *backing* the data (is tagged with mpx_vma_ops, see the patch "add MPX specific mmap interface"). If userspace use the prctl()

[PATCH v9 10/12] x86, mpx: add prctl commands PR_MPX_ENABLE_MANAGEMENT, PR_MPX_DISABLE_MANAGEMENT

2014-10-11 Thread Qiaowei Ren
This patch adds two prctl() commands to provide one explicit interaction mechanism to enable or disable the management of bounds tables in kernel, including on-demand kernel allocation (See the patch "on-demand kernel allocation of bounds tables") and cleanup (See the patch "cleanup unused bound

Re: fs/namei.c: Misuse of sequence counts?

2014-10-11 Thread Eric Biggers
On Sun, Oct 12, 2014 at 05:37:37AM +0100, Al Viro wrote: > > Gets clumsy in set_root_rcu() - you do *not* want it to bugger nd->inode > when done by follow_dotdot_rcu(), so we'd need either some indication which > caller it is, or something like struct inode **inode in argument list, > with NULL

[PATCH v9 00/12] Intel MPX support

2014-10-11 Thread Qiaowei Ren
This patch set adds support for the Memory Protection eXtensions (MPX) feature found in future Intel processors. MPX is used in conjunction with compiler changes to check memory references, and can be used to catch buffer overflow or underflow. For MPX to work, changes are required in the kernel,

[PATCH v9 02/12] x86, mpx: rename cfg_reg_u and status_reg

2014-10-11 Thread Qiaowei Ren
According to Intel SDM extension, MPX configuration and status registers should be BNDCFGU and BNDSTATUS. This patch renames cfg_reg_u and status_reg to bndcfgu and bndstatus. Signed-off-by: Qiaowei Ren --- arch/x86/include/asm/processor.h |4 ++-- 1 files changed, 2 insertions(+), 2

Re: fs/namei.c: Misuse of sequence counts?

2014-10-11 Thread Al Viro
On Sat, Oct 11, 2014 at 11:01:42PM -0500, Eric Biggers wrote: > On Sun, Oct 12, 2014 at 01:12:59AM +0100, Al Viro wrote: > > > > Huh? What's to guarantee that dentry hasn't become negative since the > > moment we'd fetched the seqcount? _That_ is the problem we are dealing > > with here -

Re: fs/namei.c: Misuse of sequence counts?

2014-10-11 Thread Al Viro
On Sat, Oct 11, 2014 at 10:55:10PM -0500, Eric Biggers wrote: > On Sun, Oct 12, 2014 at 12:46:35AM +0100, Al Viro wrote: > > > > Nope. What we do is > > * pick parent inode and seqcount (in whatever order) > > * THEN check that child is still unchanged. > > The second part guarantees

Re: fs/namei.c: Misuse of sequence counts?

2014-10-11 Thread Eric Biggers
On Sun, Oct 12, 2014 at 01:12:59AM +0100, Al Viro wrote: > > Huh? What's to guarantee that dentry hasn't become negative since the > moment we'd fetched the seqcount? _That_ is the problem we are dealing > with here - link_path_walk() relies on nd->inode being non-NULL. Hmm, I guess that makes

Re: fs/namei.c: Misuse of sequence counts?

2014-10-11 Thread Eric Biggers
On Sun, Oct 12, 2014 at 12:46:35AM +0100, Al Viro wrote: > > Nope. What we do is > * pick parent inode and seqcount (in whatever order) > * THEN check that child is still unchanged. > The second part guarantees that parent dentry had been the parent of > child all along, since the

Re: hfsplus: invalid memory access in hfsplus_brec_lenoff

2014-10-11 Thread Vyacheslav Dubeyko
On Sat, 2014-10-11 at 23:04 -0400, Sasha Levin wrote: > Hi all, > > While fuzzing with trinity inside a KVM tools guest running the latest -next > kernel, I've stumbled on the following spew: > > > [ 2435.025476] BUG: unable to handle kernel paging request at 88056730bfd4 Thank you. I

hfsplus: invalid memory access in hfsplus_brec_lenoff

2014-10-11 Thread Sasha Levin
Hi all, While fuzzing with trinity inside a KVM tools guest running the latest -next kernel, I've stumbled on the following spew: [ 2435.025476] BUG: unable to handle kernel paging request at 88056730bfd4 [ 2435.033434] IP: memcpy (arch/x86/lib/memcpy_64.S:160) [ 2435.034378] PGD 145c3067

[PATCH 2/3] staging/lustre: get rid of deprecaed acl mount option code

2014-10-11 Thread Oleg Drokin
This is long since unused code, so get rid of it. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/llite_lib.c | 19 --- 1 file changed, 19 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c

[PATCH 1/3] staging/lustre/ptlrpc: get rid of lustre 1.8 compatible checksums

2014-10-11 Thread Oleg Drokin
Old version of lustre (1.8) calculated RPC checksums differently, but the compat code is no longer important since in-kernel version of lustre is nto compatible with 1.8 lustre servers (that are long deprecated too). Signed-off-by: Oleg Drokin ---

[PATCH 3/3] staging/lustre/quota: Get rid of compat quota code

2014-10-11 Thread Oleg Drokin
Nobody should be using any fo the old lustre 1.8 era tools anymore, so drop compatibility with those. Signed-off-by: Oleg Drokin --- drivers/staging/lustre/lustre/llite/dir.c | 58 -- .../staging/lustre/lustre/llite/llite_internal.h | 18 --- 2 files changed,

[PATCH 0/3] Lustre: remove old compat code

2014-10-11 Thread Oleg Drokin
These three patches remove support for code that is no longer needed. Mostly ability to talk to old version of lustre clients and servers. Oleg Drokin (3): staging/lustre/ptlrpc: get rid of lustre 1.8 compatible checksums staging/lustre: get rid of deprecaed acl mount option code

Re: [PATCH] char: hw_random: core.c: Changed from using strncpy to strlcpy

2014-10-11 Thread Guenter Roeck
On Sat, Oct 11, 2014 at 07:11:22PM -0700, Guenter Roeck wrote: > On Sat, Oct 11, 2014 at 05:27:41PM -0700, Mark D Rustad wrote: > > On Oct 11, 2014, at 3:36 PM, Rickard Strandqvist > > wrote: > > > > > Changed from using strncpy to strlcpy to simplify the code > > > > Actually you changed from

unaligned accesses in SLAB etc.

2014-10-11 Thread David Miller
I'm getting tons of the following on sparc64: [603965.383447] Kernel unaligned access at TPC[546b58] free_block+0x98/0x1a0 [603965.396987] Kernel unaligned access at TPC[546b60] free_block+0xa0/0x1a0 [603965.410523] Kernel unaligned access at TPC[546b58] free_block+0x98/0x1a0 [603965.424061]

Re: [PATCH] char: hw_random: core.c: Changed from using strncpy to strlcpy

2014-10-11 Thread Guenter Roeck
On Sat, Oct 11, 2014 at 05:27:41PM -0700, Mark D Rustad wrote: > On Oct 11, 2014, at 3:36 PM, Rickard Strandqvist > wrote: > > > Changed from using strncpy to strlcpy to simplify the code > > Actually you changed from using strncat to strlcat. > ... and changed the length parameter along the

RE: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-11 Thread KY Srinivasan
> -Original Message- > From: Jeff Leung [mailto:jle...@v10networks.ca] > Sent: Saturday, October 11, 2014 1:22 PM > To: KY Srinivasan; James Bottomley; Christoph Hellwig > Cc: Sitsofe Wheeler; Haiyang Zhang; Christoph Hellwig; Hannes Reinecke; > linux-s...@vger.kernel.org;

Re: [PATCH] usb: serial: Fix indentation style issue

2014-10-11 Thread Joe Perches
On Sat, 2014-10-11 at 13:19 -0700, Greg KH wrote: > On Sat, Oct 11, 2014 at 08:36:33AM -0700, Joe Perches wrote: > > On Sat, 2014-10-11 at 07:20 -0700, Greg KH wrote: > > > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: > > > > Fix a style issue > > [] > > > > diff --git

Re: [PATCH 07/12] rtc: omap: silence bogus power-up reset message at probe

2014-10-11 Thread Felipe Balbi
Hi, On Sat, Oct 11, 2014 at 12:20:04PM +0200, Johan Hovold wrote: > On Fri, Oct 10, 2014 at 01:02:56PM -0500, Felipe Balbi wrote: > > On Fri, Oct 10, 2014 at 01:00:54PM -0500, Felipe Balbi wrote: > > > On Thu, Oct 09, 2014 at 09:06:29PM +0200, Johan Hovold wrote: > > > > Some legacy RTC IP

Re: [PATCH 08/12] rtc: omap: restore irq state after reading TC registers

2014-10-11 Thread Felipe Balbi
On Sat, Oct 11, 2014 at 12:12:01PM +0200, Johan Hovold wrote: > On Fri, Oct 10, 2014 at 01:02:31PM -0500, Felipe Balbi wrote: > > Hi, > > > > On Thu, Oct 09, 2014 at 09:06:30PM +0200, Johan Hovold wrote: > > > Make sure to restore local irq state when reading the timer/calendar > > > (TC)

Re: [PATCH 10/12] usb: musb: ux500_dma: use dmaengine_xxx() APIs

2014-10-11 Thread Felipe Balbi
Hi, On Sat, Oct 11, 2014 at 09:10:38PM +0530, Vinod Koul wrote: > The drivers should use dmaengine_terminate_all() or dmaengine_slave_config() > API instead of accessing the device_control which will be deprecated soon > > Signed-off-by: Vinod Koul awesome. It looks like it doesn't have a

Re: [PATCH] char: hw_random: core.c: Changed from using strncpy to strlcpy

2014-10-11 Thread Mark D Rustad
On Oct 11, 2014, at 3:36 PM, Rickard Strandqvist wrote: > Changed from using strncpy to strlcpy to simplify the code Actually you changed from using strncat to strlcat. > Signed-off-by: Rickard Strandqvist > --- > drivers/char/hw_random/core.c | 12 > 1 file changed, 4

Re: fs/namei.c: Misuse of sequence counts?

2014-10-11 Thread Al Viro
On Sat, Oct 11, 2014 at 05:58:08PM -0500, Eric Biggers wrote: > In path_init(), said commit added a call to read_seqcount_retry() after > loading > the inode. I see two problems with this: > > - The read_seqcount_retry() isn't needed just to load the inode pointer, so > the change

[PATCH] net: wireless: brcm80211: brcmfmac: dhd_sdio.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-10-11 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And changed from using strncpy to strlcpy to simplify code. Signed-off-by: Rickard Strandqvist --- drivers/net/wireless/brcm80211/brcmfmac/dhd_sdio.c | 25 ++-- 1 file changed, 12 insertions(+), 13

Re: fs/namei.c: Misuse of sequence counts?

2014-10-11 Thread Al Viro
On Sat, Oct 11, 2014 at 05:58:08PM -0500, Eric Biggers wrote: > In follow_dotdot_rcu(), said commit moved loads of the inode to just before > read_seqcount_begin(), in several instances. I don't think this is correct, > because (as I understand it) read_seqcount_begin() is opening a seq-read >

Re: rhashtable: hang while running tests on boot

2014-10-11 Thread Sasha Levin
On 10/11/2014 06:26 PM, Thomas Graf wrote: > On 10/11/14 at 12:09pm, Sasha Levin wrote: >> On 10/11/2014 11:50 AM, Paul E. McKenney wrote: >>> I am guessing that this happens only when running the resizable >>> hashtable >>> tests -- if that guess is incorrect, please let me know.

Re: [PATCH 1/1] drivers/staging: Fixed sparse error "directive in argument list"

2014-10-11 Thread Filipe Gonçalves
Ah .. right! I didn't know what OBD_OCD_VERSION() was. Now I see it's a way to test kernel version. I am going to submit a new patch shortly. Thanks, Filipe On Sat, Oct 11, 2014 at 9:15 PM, Greg KH wrote: > > On Sat, Oct 11, 2014 at 08:13:42PM +0100, Filipe Gonçalves wrote: >> This patch fixes

Re: [patch 3/3] mm: memcontrol: fix transparent huge page allocations under pressure

2014-10-11 Thread Johannes Weiner
On Wed, Oct 08, 2014 at 01:47:25PM -0400, Johannes Weiner wrote: > On Wed, Oct 08, 2014 at 05:33:29PM +0200, Michal Hocko wrote: > > On Tue 07-10-14 21:11:06, Johannes Weiner wrote: > > > On Tue, Oct 07, 2014 at 03:59:50PM +0200, Michal Hocko wrote: > > > > Another part that matters is the size.

Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

2014-10-11 Thread David Miller
From: Thomas Graf Date: Sat, 11 Oct 2014 23:25:14 +0100 > I think the issue here is obvious and a fix is on the way to move > the insertion and removal to a worker to no longer require the > synchronize_rcu(). > > What bothers me is that the synchronize_rcu() should only occur > on

Re: [PATCH v3 2/2] DT: iio: vadc: document dt binding

2014-10-11 Thread Hartmut Knaack
Hi, two small issues inline. Stanimir Varbanov schrieb am 24.09.2014 14:56: > Document DT binding for Qualcomm SPMI PMIC voltage ADC > driver. > > Signed-off-by: Stanimir Varbanov > Signed-off-by: Ivan T. Ivanov > --- > .../devicetree/bindings/iio/adc/qcom,spmi-vadc.txt | 130 >

fs/namei.c: Misuse of sequence counts?

2014-10-11 Thread Eric Biggers
Hi, I've been reading through the path lookup code and I believe there may have been bugs introduced by commit 4023bfc9 ("be careful with nd->inode in path_init() and follow_dotdot_rcu()"). And I may have found a pre-existing bug as well. In follow_dotdot_rcu(), said commit moved loads of the

Re: [PATCH 3/8] iio: Add support for DA9150 GPADC

2014-10-11 Thread Hartmut Knaack
Hi, I have put a few comments inline. Adam Thomson schrieb am 23.09.2014 12:53: > This patch adds support for DA9150 Charger & Fuel-Gauge IC GPADC. > > Signed-off-by: Adam Thomson > --- > drivers/iio/adc/Kconfig| 9 + > drivers/iio/adc/Makefile | 1 + >

Re: [PATCH 1/1] drivers/staging: Fixed sparse error "directive in argument list"

2014-10-11 Thread Filipe Gonçalves
Hi, Oops.. sorry for the mess then. I am still trying to get to know the codebase. I submitted a new patch where I removed the check. Thanks for your patience :) Best, Filipe On Sat, Oct 11, 2014 at 10:49 PM, Drokin, Oleg wrote: > > Hello! > >No, it's not the way to test the kernel

Re: [PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Jonas Brunsgaard
On Sat, Oct 11, 2014 at 10:17 PM, Greg KH wrote: > On Sat, Oct 11, 2014 at 06:02:48PM +0200, Jonas Brunsgaard wrote: >> Signed-off-by: Jonas Brunsgaard >> --- >> drivers/usb/atm/ueagle-atm.c | 95 >> >> 1 file changed, 42 insertions(+), 53

[PATCH] char: hw_random: core.c: Changed from using strncpy to strlcpy

2014-10-11 Thread Rickard Strandqvist
Changed from using strncpy to strlcpy to simplify the code Signed-off-by: Rickard Strandqvist --- drivers/char/hw_random/core.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c index aa30a25..1500cfd

Re: Removing per-task TSD? (Re: Tightening up rdpmc permissions?)

2014-10-11 Thread Andy Lutomirski
On Fri, Oct 3, 2014 at 1:06 PM, Peter Zijlstra wrote: > On Fri, Oct 03, 2014 at 09:41:30AM -0700, Andy Lutomirski wrote: >> So this is a mess. I think that any reasonable implementation of >> rdpmc permissions should be per mm, since we perf_event maps are, of >> course, per mm. >> >> Similarly,

Re: rhashtable: hang while running tests on boot

2014-10-11 Thread Thomas Graf
On 10/11/14 at 12:09pm, Sasha Levin wrote: > On 10/11/2014 11:50 AM, Paul E. McKenney wrote: > >>> > > I am guessing that this happens only when running the resizable > >>> > > hashtable > >>> > > tests -- if that guess is incorrect, please let me know. > >> > > >> > I've seen it a few times

Re: [3.16.1 BISECTED REGRESSION]: Simtec Entropy Key (cdc-acm) broken in 3.16

2014-10-11 Thread Nix
On 11 Oct 2014, Paul Martin spake thusly: > Having been privy to the firmware of the eKey, it is very simplisting, > with no implementation whatsoever of any flow control. That's what I thought. (Why would something that just provides data at a constant rate way below that of even the slowest

Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

2014-10-11 Thread Thomas Graf
On 10/11/14 at 12:32pm, Eric Dumazet wrote: > On Sat, 2014-10-11 at 10:36 +0200, Heiko Carstens wrote: > > Hi all, > > > > it just came to my attention that commit e341694e3eb5 > > "netlink: Convert netlink_lookup() to use RCU protected hash table" > > causes network latencies for me on s390. > >

[GIT] Networking

2014-10-11 Thread David Miller
This set fixes a bunch of fallout from the changes that went in during this merge window, particularly: 1) Fix fsl_pq_mdio (Claudiu Manoil) and fm10k (Pranith Kumar) build failures. 2) Several networking drivers do atomic_set() on page counts where that's not exactly legal. From Eric

[PATCH v2] gpu: drm: drm_dp_mst_topology.c: Fix improper use of strncat

2014-10-11 Thread Rickard Strandqvist
Fixed wrong usage of strncat, switched to strlcpy. While sending the string size to function to reduce the potential for misuse in future. Signed-off-by: Rickard Strandqvist --- drivers/gpu/drm/drm_dp_mst_topology.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff

Re: [PATCH 1/1] drivers/staging: Fixed sparse error "directive in argument list"

2014-10-11 Thread Drokin, Oleg
Hello! No, it's not the way to test the kernel version, it's the way to test internal lustre version. Either way maintaining compatibility with Lustre 1.8 and 2.0 servers should not be important anymore, so it's fine to drop this check indeed. Bye, Oleg On Oct 11, 2014, at 5:06

[PATCH v2] usb: atm: fix style issues

2014-10-11 Thread Jonas Brunsgaard
Signed-off-by: Jonas Brunsgaard --- drivers/usb/atm/ueagle-atm.c | 95 1 file changed, 42 insertions(+), 53 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 5a45937..eedb217 100644 ---

[PATCH 1/1] drivers/staging: Removed unnecessary check for LUSTRE_VERSION_CODE

2014-10-11 Thread Filipe Goncalves
From: Filipe Gonçalves Given that this code is now part of the kernel tree, the #ifdef directive comparing LUSTRE_VERSION_CODE to the kernel version is no longer needed. As a side effect, this will also remove the sparse error "directive in argument list". Signed-off-by: Filipe Gonçalves

[RFC PATCH 2/2] kernel: power: Drop pm_poweroff_prepare

2014-10-11 Thread Guenter Roeck
The only user of pm_poweroff_prepare was acpi, which has been converted to use a syscore callback. Drop pm_poweroff_prepare as it is no longer necessary. Cc: Rafael J. Wysocki Cc: Len Brown Cc: Pavel Machek Signed-off-by: Guenter Roeck --- include/linux/pm.h | 1 - kernel/reboot.c| 8

[RFC PATCH 1/2] acpi: Use syscore instead of pm_power_off_prepare to prepare for poweroff

2014-10-11 Thread Guenter Roeck
The syscore shutdown callback seems to be perfectly suited to prepare for system poweroff. Use it instead of pm_power_off_prepare. Cc: Rafael J. Wysocki Cc: Len Brown Signed-off-by: Guenter Roeck --- drivers/acpi/sleep.c | 21 - 1 file changed, 16 insertions(+), 5

[RFC PATCH 0/2] kernel: Drop pm_poweroff_prepare

2014-10-11 Thread Guenter Roeck
While working on the poweroff handler implementation, I also started looking into pm_power_off_prepare. Ultimately, I concluded that it is not really necessary, and that it would be easy to remove. The first patch in this series converts acpi to use a syscore callback instead of setting

Re: [RFC] drop owner assignment from platform_drivers

2014-10-11 Thread Greg KH
On Sat, Oct 11, 2014 at 06:56:51PM +0200, Wolfram Sang wrote: > > > > You got me wondering, though, that it could not be correct to call > > > platform_driver_register() from the platform core instead of module > > > init. I will check tomorrow. Still, this would be a bug independent of > > > my

Re: [PATCH] ARM: keystone: add bus notifier to set dma_pfn_offset for pci devices

2014-10-11 Thread Arnd Bergmann
On Friday 10 October 2014 20:04:57 Santosh Shilimkar wrote: > On 10/10/14 5:37 PM, Murali Karicheri wrote: > > Based on this, dma configuration parameters get set for the device which > > is probed through DT. > > > > As PCI devices are attached to the PCI bus during scan, and we don't > > have DT

RE: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-11 Thread Jeff Leung
> On the current release of Windows (windows 10), we are advertising SPC3 > compliance. > We are ok with declaring compliance to SPC3 in our drivers. If you are going to declare SPC3 compliance in the drivers, are you going to put in checks to ensure that SPC-3 compliance doesn't get

Re: [PATCH 10/12] usb: musb: ux500_dma: use dmaengine_xxx() APIs

2014-10-11 Thread Greg Kroah-Hartman
On Sat, Oct 11, 2014 at 09:10:38PM +0530, Vinod Koul wrote: > The drivers should use dmaengine_terminate_all() or dmaengine_slave_config() > API instead of accessing the device_control which will be deprecated soon > > Signed-off-by: Vinod Koul Acked-by: Greg Kroah-Hartman -- To unsubscribe

Re: [PATCH 09/12] serial: sh-sci: use dmaengine_terminate_all() API

2014-10-11 Thread Greg Kroah-Hartman
On Sat, Oct 11, 2014 at 09:10:37PM +0530, Vinod Koul wrote: > The drivers should use dmaengine_terminate_all() API instead of > accessing the device_control which will be deprecated soon > > Signed-off-by: Vinod Koul Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line

Re: [PATCH] usb: serial: Fix indentation style issue

2014-10-11 Thread Greg KH
On Sat, Oct 11, 2014 at 08:36:33AM -0700, Joe Perches wrote: > On Sat, 2014-10-11 at 07:20 -0700, Greg KH wrote: > > On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: > > > Fix a style issue > [] > > > diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c > [] > >

Re: [PATCH] debugfs: add helper function to create device related seq_file

2014-10-11 Thread Greg Kroah-Hartman
On Sat, Oct 11, 2014 at 06:09:47PM +0200, Arend van Spriel wrote: > On 10/11/14 18:01, Arend van Spriel wrote: > >This patch adds a helper function that simplifies adding a > >sequence file for device drivers. The calling device driver > >needs to provide a read function and a device pointer. The

Re: [PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Greg KH
On Sat, Oct 11, 2014 at 06:02:48PM +0200, Jonas Brunsgaard wrote: > Signed-off-by: Jonas Brunsgaard > --- > drivers/usb/atm/ueagle-atm.c | 95 > > 1 file changed, 42 insertions(+), 53 deletions(-) Your Subject: doesn't seem to make sense, please fix

Re: [PATCH] debugfs: add helper function to create device related seq_file

2014-10-11 Thread Greg Kroah-Hartman
On Sat, Oct 11, 2014 at 06:01:55PM +0200, Arend van Spriel wrote: > This patch adds a helper function that simplifies adding a > sequence file for device drivers. The calling device driver > needs to provide a read function and a device pointer. The > field struct seq_file::private will reference

Re: [PATCH 1/1] drivers/staging: Fixed sparse error "directive in argument list"

2014-10-11 Thread Greg KH
On Sat, Oct 11, 2014 at 08:13:42PM +0100, Filipe Gonçalves wrote: > This patch fixes a sparse warning on layout.c (ptlrpc) that was caused by > having preprocessor directives in the arguments to a macro. > > Signed-off-by: Filipe Gonçalves > --- > drivers/staging/lustre/lustre/ptlrpc/layout.c

Re: [3.16.1 BISECTED REGRESSION]: Simtec Entropy Key (cdc-acm) broken in 3.16

2014-10-11 Thread Paul Martin
Having been privy to the firmware of the eKey, it is very simplisting, with no implementation whatsoever of any flow control. -- Paul Martin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: [PATCH 0/3] scsi: Add Hyper-V logical block provisioning quirks

2014-10-11 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:james.bottom...@hansenpartnership.com] > Sent: Saturday, October 11, 2014 10:42 AM > To: Christoph Hellwig > Cc: Sitsofe Wheeler; KY Srinivasan; Haiyang Zhang; Christoph Hellwig; Hannes > Reinecke; linux-s...@vger.kernel.org;

Re: [RFC][PATCH] audit: log join and part events to the read-only multicast log socket

2014-10-11 Thread Paul Moore
On Saturday, October 11, 2014 11:42:06 AM Steve Grubb wrote: > On Tue, 07 Oct 2014 18:06:51 -0400 > > Paul Moore wrote: > > On Tuesday, October 07, 2014 03:39:51 PM Richard Guy Briggs wrote: > > > I also thought of moving audit_log_task() from auditsc.c to audit.c > > > and using that. For that

Re: [Bulk] Re: [3.16-rcX][pciehp][radeon] PCIe HotPlug conflicts with radeon GPU

2014-10-11 Thread Shawn Starr
On September 11, 2014 04:26:21 PM Bjorn Helgaas wrote: > [+cc linux-pci] > > On Sat, Aug 2, 2014 at 10:02 AM, Shawn Starr wrote: > > Hello devs, > > > > There are two issues I am encountering with the PCIe Hotplug driver on my > > Lenovo Laptop (W500). I note this goes back further than 3.15. >

Please reply

2014-10-11 Thread Jose Calvache
Dear Sir/Madam, Here is a pdf attachment of my proposal to you. Please read and reply I would be grateful. Jose Calvache -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [bisected] e341694e3eb5 netlink_lookup() rcu conversion causes latencies

2014-10-11 Thread Eric Dumazet
On Sat, 2014-10-11 at 10:36 +0200, Heiko Carstens wrote: > Hi all, > > it just came to my attention that commit e341694e3eb5 > "netlink: Convert netlink_lookup() to use RCU protected hash table" > causes network latencies for me on s390. > > The testcase is quite simple and 100% reproducible on

Re: RCU bug with v3.17-rc3 ?

2014-10-11 Thread Nathan Lynch
On 10/10/2014 08:44 PM, Nathan Lynch wrote: > On 10/10/2014 11:25 AM, Russell King - ARM Linux wrote: >> >> Right, so GCC 4.8.{1,2} are totally unsuitable for kernel building (and >> it seems that this has been known about for some time.) > > Looking at http://gcc.gnu.org/PR58854 it seems that

[PATCH 1/1] drivers/staging: Fixed sparse error "directive in argument list"

2014-10-11 Thread Filipe Gonçalves
This patch fixes a sparse warning on layout.c (ptlrpc) that was caused by having preprocessor directives in the arguments to a macro. Signed-off-by: Filipe Gonçalves --- drivers/staging/lustre/lustre/ptlrpc/layout.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 00/12] rtc: omap: fixes and power-off feature

2014-10-11 Thread Tony Lindgren
* Johan Hovold [141011 02:42]: > On Fri, Oct 10, 2014 at 12:54:22PM -0500, Felipe Balbi wrote: > > > > is this power-off feature "RTC-only mode" ? > > Yes, I believe so, at least as long as RTC power is maintained. The > pmic_power_en pin can otherwise still be used to power off. > > On the

Re: [PATCH v2 1/2] kconfig: fix bad syntactic transformation in expr.c

2014-10-11 Thread Paul Bolle
On Mon, 2014-09-22 at 19:13 +0200, Martin Walch wrote: > Fix it by removing expr_eliminate_dups2() and the functions that have no use > anywhere else: expr_extract_eq_and(), expr_extract_eq_or(), > and expr_extract_eq() from scripts/kconfig/expr.[ch] > > Currently the bug is not triggered in

Re: [3.16.1 BISECTED REGRESSION]: Simtec Entropy Key (cdc-acm) broken in 3.16

2014-10-11 Thread Nix
[Cc:ed someone who knows the people behind the Entropy Key: they're not being manufactured at the moment, but he might want to know anyway] On 5 Sep 2014, n...@esperi.org.uk stated: > On 1 Sep 2014, Oliver Neukum stated: > >>> I'll do a bisection of the cdc-acm changes since 3.15 tomorrow night

Re: [PATCH] clk: rockchip: rk3288: i2s_frac adds flag to set parent's rate

2014-10-11 Thread Heiko Stübner
Hi Jianqun, Am Dienstag, 30. September 2014, 11:12:04 schrieb Jianqun: > The relation of i2s nodes as follows: > i2s_src 0 059400 0 > i2s_frac 0 011289600 0 > i2s_pre 0

Re: [RFC 1/4] dma-buf: Add constraints sharing information

2014-10-11 Thread Daniel Vetter
On Sat, Oct 11, 2014 at 01:37:55AM +0530, Sumit Semwal wrote: > At present, struct device lacks a mechanism of exposing memory > access constraints for the device. > > Consequently, there is also no mechanism to share these constraints > while sharing buffers using dma-buf. > > If we add support

Re: [PATCH v2 0/5] pinctrl: samsung: Data structure clean-up

2014-10-11 Thread Tomasz Figa
On 08.10.2014 12:23, Linus Walleij wrote: > On Thu, Oct 2, 2014 at 8:52 PM, Tomasz Figa wrote: > >> This series intends to clean up data structures used by pinctrl-samsung >> driver. >> More specifically, it separates initial compile time constants from data used >> at runtime, allowing unused

Re: [PATCH] x86, kexec: Add .gitignore file

2014-10-11 Thread Prarit Bhargava
On 10/10/2014 07:47 PM, Shuah Khan wrote: > On Fri, Oct 10, 2014 at 4:55 PM, Prarit Bhargava wrote: >> When doing git-status there are two untracked files: >> >> \# Untracked files: >> \# (use "git add ..." to include in what will be committed) >> \# >> \#

Re: [RFC 2/4] cenalloc: Constraint-Enabled Allocation helpers for dma-buf

2014-10-11 Thread Daniel Vetter
On Fri, Oct 10, 2014 at 04:09:00PM -0700, Greg Kroah-Hartman wrote: > On Sat, Oct 11, 2014 at 01:37:56AM +0530, Sumit Semwal wrote: > > Devices sharing buffers using dma-buf could benefit from sharing their > > constraints via struct device, and dma-buf framework would manage the > > common

Re: [PATCH] clk: rockchip: Add CLK_SET_RATE_PARENT to aclk_cpu_pre

2014-10-11 Thread Heiko Stübner
Hi Doug, Am Montag, 6. Oktober 2014, 10:15:27 schrieb Doug Anderson: > We'd like to be able to call clk_set_rate() on aclk_cpu (a gate) at > bootup. In order for this to have any effect we need its parent > (aclk_cpu_pre) to percolate the rate change to _its_ parent > (aclk_cpu_src). Add

Re: [PATCH] char: misc: use pr_err instead of printk

2014-10-11 Thread Joe Perches
On Sun, 2014-10-12 at 00:01 +0530, Rahul Bedarkar wrote: [] > diff --git a/drivers/char/misc.c b/drivers/char/misc.c [] > @@ -280,12 +280,12 @@ static int __init misc_init(void) > > err = -EIO; > if (register_chrdev(MISC_MAJOR,"misc",_fops)) > - goto fail_printk; > +

Re: [PATCH 3/4] drm/exynos: enable vblank after DPMS on

2014-10-11 Thread Daniel Vetter
On Fri, Oct 10, 2014 at 02:31:55PM +0200, Andrzej Hajda wrote: > Before DPMS off driver disables vblank. > It should be balanced by vblank enable after DPMS on. > The patch fixes issue with page_flip ioctl not being able > to acquire vblank counter introduced by patch: > drm: Always reject

[PATCH] char: misc: fix coding style issues

2014-10-11 Thread Rahul Bedarkar
This patch fixes checkpatch.pl error ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Rahul Bedarkar --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index a6b96b1..47c9b04 100644 ---

Re: [PATCH] clk: rockchip: fix parent for spdif_8ch_frac on rk3288

2014-10-11 Thread Heiko Stübner
Hi Sonny, Am Mittwoch, 8. Oktober 2014, 01:55:16 schrieb Sonny Rao: > The parent should be spdif_8ch_pre not spdif_8ch_src, which doesn't > exist and looks to be a typo. The TRM also confirms this. thanks for the catch. I've added the patch to a temporary branch for 3.19 till we have a stable

[PATCH] char: misc: use pr_err instead of printk

2014-10-11 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/char/misc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 75b6de9..a6b96b1 100644 --- a/drivers/char/misc.c +++ b/drivers/char/misc.c @@ -280,12 +280,12 @@ static int __init

[PATCH] char: misc: EXPORT_SYMBOL should immediately follow its function

2014-10-11 Thread Rahul Bedarkar
This patch fixes checkpatch.pl warning WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable Signed-off-by: Rahul Bedarkar --- drivers/char/misc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index

[PATCH] char: misc: add missing blank line after declarations

2014-10-11 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/char/misc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index cb32ea9..3111e86 100644 --- a/drivers/char/misc.c +++ b/drivers/char/misc.c @@ -186,6 +186,7 @@ int misc_register(struct miscdevice *misc)

[PATCH] char: misc: remove trailing whitespaces

2014-10-11 Thread Rahul Bedarkar
Signed-off-by: Rahul Bedarkar --- drivers/char/misc.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index b4cf821..cb32ea9 100644 --- a/drivers/char/misc.c +++ b/drivers/char/misc.c @@ -117,14 +117,14 @@ static int

[PATCH] char: misc: fix coding style issues

2014-10-11 Thread Rahul Bedarkar
This patch fixes checkpatch.pl error ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Rahul Bedarkar --- drivers/char/misc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/char/misc.c b/drivers/char/misc.c index ffa97d2..b4cf821 100644 ---

Re: [alsa-devel] [PATCH v2 2/2] ALSA: au88x0: pr_* replaced with dev_*

2014-10-11 Thread Sudip Mukherjee
On Sat, Oct 11, 2014 at 08:32:49AM -0700, Joe Perches wrote: > On Sat, 2014-10-11 at 17:03 +0530, Sudip Mukherjee wrote: > > On Sat, Oct 11, 2014 at 03:48:11AM -0700, Joe Perches wrote: > > > On Sat, 2014-10-11 at 14:39 +0530, Sudip Mukherjee wrote: > > > > On Sat, Oct 11, 2014 at 03:20:56PM

Re: [PATCH] ARM: dts: rockchip: enable DMA on SPI for rk3066 and rk3188

2014-10-11 Thread Heiko Stübner
Hi Julien, Am Freitag, 10. Oktober 2014, 10:04:13 schrieb Julien CHAUVEAU: > According to the RK3066 and RK3188 TRM, the two SPI controllers support DMA > handshake interface. Add the DMA properties so they can be used when needed. > > Signed-off-by: Julien CHAUVEAU added the patch to a

  1   2   3   4   5   >