Re: [PATCH v3 60/77] ncr5380: Implement new eh_abort_handler

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Introduce a new eh_abort_handler implementation. This one attempts to follow all of the rules relating to EH handlers. There is still a known bug: during selection, a command becomes invisible to the EH handlers because it only appears in a pointer on

Re: [PATCH v3 59/77] ncr5380: Fix autosense bugs

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: NCR5380_information_transfer() may re-queue a command for autosense, after calling scsi_eh_prep_cmnd(). This creates several possibilities: 1. Reselection may intervene before the re-queued command gets processed. If the reconnected command then

Re: [PATCH v3 58/77] ncr5380: Refactor command completion

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Implement a 'complete_cmd' function to complete commands. This is needed by the following patch; the new function provides a site for the logic needed to correctly handle REQUEST SENSE commands. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c

Re: [PATCH v3 57/77] ncr5380: Use standard list data structure

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: The NCR5380 drivers have a home-spun linked list implementation for scsi_cmnd structs that uses cmd->host_scribble as a 'next' pointer. Adopt the standard list_head data structure and list operations instead. Remove the eh_abort_handler rather than

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Julian Calaby
; >> > Patch was compile tested with: x86_64_defconfig + >> > CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) >> > >> > Patch is against linux-next (localversion-next is -next-20151221) >> > >> > drivers/net/wireless/ti/wlcore/main.c | 3 +-- >> > 1 file

Re: [PATCH v3 56/77] ncr5380: Remove redundant volatile qualifiers

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: The hostdata struct is now protected by a spin lock so the volatile qualifiers are redundant. Remove them. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.h | 12 ++-- drivers/scsi/atari_NCR5380.c |2 +- 2 files changed, 7

[PATCH] soc: mediatek: PMIC wrap: Clear the vldclr if state machine is stay on FSM_VLDCLR state.

2015-12-21 Thread Henry Chen
Sometimes PMIC is too busy to send data in time to cause pmic wrap timeout, because pmic wrap is waiting for FSM_VLDCLR after finishing WACS2_CMD. It just return error when issue happened, so the state machine will stay on FSM_VLDCLR state when data send back later by PMIC and timeout again in

Re: [PATCH v3 55/77] ncr5380: Remove LIST and REMOVE macros

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Printing command pointers can be useful when debugging queues. Other than that, the LIST and REMOVE macros are just clutter. These macros are redundant now that NDEBUG_QUEUES causes pointers to be printed, so remove them. Signed-off-by: Finn Thain ---

Re: [PATCH v3 54/77] ncr5380: Use dsprintk() for queue debugging

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Print the command pointers in the log messages for debugging queue data structures. The LIST and REMOVE macros can then be removed. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 36

Re: [PATCH] OMAPDSS: fix omapfb build error due missing feat functions declaration

2015-12-21 Thread Tomi Valkeinen
Hi Javier, On 21/12/15 20:26, Javier Martinez Canillas wrote: > The omapfb is failing to build in -next due missing declarations for > dss_feat_get_supported_displays() and dss_feat_get_supported_outputs(): > > CC [M] drivers/video/fbdev/omap2//omapfb/dss/dss.o >

Re: [PATCH v3 53/77] ncr5380: Use shost_priv helper

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Make use of the shost_priv() helper. Remove HOSTDATA and SETUP_HOSTDATA macros because they harm readability. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 23 ++- drivers/scsi/atari_NCR5380.c | 20

Re: [PATCH v3 52/77] ncr5380: Remove H_NO macro and introduce dsprintk

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Replace all H_NO and some HOSTNO macros (both peculiar to atari_NCR5380.c) with a new dsprintk macro that's more useful and more consistent. The new macro avoids a lot of boilerplate in new code in subsequent patches. Keep NCR5380.c in sync. Remaining

Re: [PATCH v3 51/77] ncr5380: Remove command list debug code

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Some NCR5380 hosts offer a .show_info method to access the contents of the various command list data structures from a procfs file. When NDEBUG is set, the same information is sent to the console during EH. The two core drivers, atari_NCR5380.c and

Re: [PATCH v3 50/77] ncr5380: Change instance->host_lock to hostdata->lock

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: NCR5380.c presently uses the instance->host_lock spin lock. Convert this to a new spin lock that protects the NCR5380_hostdata struct. atari_NCR5380.c previously used local_irq_save/restore() rather than a spin lock. Convert this to hostdata->lock in

Re: [PATCH v3 49/77] ncr5380: Remove redundant ICR_ARBITRATION_LOST test and eliminate FLAG_DTC3181E

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Remove FLAG_DTC3181E. It was used to suppress a final Arbitration Lost (SEL asserted) test that isn't actually needed. The test was suppressed because it causes problems for DTC436 and DTC536 chips. It takes place after the host wins arbitration, so SEL

Re: [PATCH v3 48/77] atari_NCR5380: Fix queue_size limit

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: When a target reports a QUEUE_FULL condition it causes the driver to update the 'queue_size' limit with the number of currently allocated tags. At least, that's what's supposed to happen, according to the comments. Unfortunately the terms in the

Re: [PATCH v3 47/77] ncr5380: Fix and cleanup scsi_host_template initializers

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Add missing .module initializer. Use distinct .proc_name values for the g_NCR5380 and g_NCR5380_mmio modules. Remove pointless CAN_QUEUE and CMD_PER_LUN override macros. Cleanup whitespace and code style. Signed-off-by: Finn Thain ---

Re: [PATCH v3 46/77] ncr5380: Fix NDEBUG_NO_DATAOUT flag

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: NDEBUG_NO_DATAOUT should not disable DATA IN phases too. Fix this. (This bug has long been fixed in atari_NCR5380.c.) Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by:

Re: [PATCH v3 45/77] ncr5380: Cleanup #include directives

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Remove unused includes (stat.h, signal.h, proc_fs.h) and move includes needed by the core drivers into the common header (delay.h etc). Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c |2 -- drivers/scsi/NCR5380.h |4

Re: [PATCH v3 44/77] ncr5380: Fix off-by-one bug in extended_msg[] bounds check

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Fix the array bounds check when transferring an extended message from the target. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c |3 ++- drivers/scsi/atari_NCR5380.c |4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-)

Re: [PATCH v3 43/77] ncr5380: Standardize reselection handling

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Bring the two NCR5380_reselect() implementations into agreement. Replace infinite loops in atari_NCR5380.c with timeouts, as per NCR5380.c. Remove 'abort' flag in NCR5380.c as per atari_NCR5380.c -- if reselection fails, there may be no MESSAGE IN

Re: [char-misc-next v3 3/8] watchdog: mei_wdt: implement MEI iAMT watchdog driver

2015-12-21 Thread Guenter Roeck
On 12/21/2015 11:19 PM, Winkler, Tomas wrote: On 12/21/2015 03:17 PM, Tomas Winkler wrote: Create a driver with the generic watchdog interface for the MEI iAMT watchdog device. Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- V2: The watchdog device is no longer

Re: [PATCH v3 41/77] ncr5380: Replace redundant flags with FLAG_NO_DMA_FIXUP

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: The flags DMA_WORKS_RIGHT, FLAG_NCR53C400 and FLAG_HAS_LAST_BYTE_SENT all mean the same thing, i.e. the chip is not a 538[01]. (More recent devices such as the 53C80 have a 'Last Byte Sent' bit in the Target Command Register as well as other fixes for

Re: [PATCH v3 42/77] ncr5380: Replace READ_OVERRUNS macro with FLAG_NO_DMA_FIXUPS

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: The workarounds for chip errata appear twice, in slightly different forms. One is used when defined(REAL_DMA) || defined(REAL_DMA_POLL), the other when defined(PSEUDO_DMA). In the PDMA case, the workarounds have been made conditional on

Re: linux-next: Tree for Dec 22

2015-12-21 Thread Sudip Mukherjee
On Tue, Dec 22, 2015 at 04:29:55PM +1100, Stephen Rothwell wrote: > Hi all, > > Changes since 20151221: cris allmodconfig fails with: ../block/partitions/ldm.c: In function 'ldm_partition': ../block/partitions/ldm.c:1567:1: internal compiler error: in gen_reg_rtx, at emit-rtl.c:1027

Re: [PATCH v3 40/77] ncr5380: Introduce NCR5380_poll_politely2

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: SCSI bus protocol sometimes requires monitoring two related conditions simultaneously. Enhance NCR5380_poll_politely() for this purpose, and put it to use in the arbitration algorithm. It will also find use in pseudo DMA. Signed-off-by: Finn Thain ---

Re: [PATCH v3 39/77] ncr5380: Standardize interrupt handling

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Because interrupt handling is crucial to the core driver(s), all wrapper drivers need to agree on this code. This patch removes discrepancies. NCR5380_intr() in NCR5380.c has the following pointless loop that differs from the code in atari_NCR5380.c.

Re: [f2fs-dev] [PATCH 2/2] f2fs: speed up shrinking extent tree entries

2015-12-21 Thread Jaegeuk Kim
On Tue, Dec 22, 2015 at 01:20:13PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > We should update _zombie_tree whenever removing unreferenced > extent tree during shrinking: > - f2fs_shrink_extent_tree > if (!atomic_read(>refcount)) { > ... > atomic_dec(>total_ext_tree); >

Re: [PATCH v3 38/77] ncr5380: Remove UNSAFE macro

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Configuring core drivers using macros like this one prevents re-unifying the core driver forks, and prevents implementing the core driver as a library or a platform driver. The UNSAFE macro in particular is a poor workaround for the problem of interrupt

Re: [f2fs-dev] [PATCH 1/2] f2fs: use atomic variable for total_extent_tree

2015-12-21 Thread Jaegeuk Kim
On Tue, Dec 22, 2015 at 01:28:09PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > > -Original Message- > > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > > Sent: Tuesday, December 22, 2015 11:39 AM > > To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; > >

Re: [PATCH v3 37/77] ncr5380: Standardize work queueing algorithm

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: The complex main_running/queue_main mechanism is peculiar to atari_NCR5380.c. It isn't SMP safe and offers little value given that the work queue already offers concurrency management. Remove this complexity to bring atari_NCR5380.c closer to NCR5380.c.

Re: [PATCH v3 36/77] ncr5380: Use work_struct instead of delayed_work

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Each host instance now has it's own work queue so the main() work item can sleep when necessary. That means we can use a simple work item rather than a delayed work item. This brings NCR5380.c closer to atari_NCR5380.c. Signed-off-by: Finn Thain ---

Re: [PATCH v3 35/77] ncr5380: Dont wait for BUS FREE after disconnect

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: When there is a queued command and no connected command, NCR5380_select() is called and arbitration begins. The chip waits for BUS FREE once the MR_ARBITRATE bit in the mode register is enabled. That means there is no need to wait for BUS FREE after

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Nicholas Mc Guire
s Mc Guire > > --- > > > > Found by coccinelle script (relaxed version of > > scripts/coccinelle/api/alloc/kzalloc-simple.cocci) > > > > Patch was compile tested with: x86_64_defconfig + > > CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) > > > >

Re: [PATCH v3 34/77] atari_NCR5380: Use arbitration timeout

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Allow target selection to fail with a timeout instead of waiting in infinite loops. This gets rid of the unused NCR_TIMEOUT macro, it is more defensive and has proved helpful in debugging. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c |

Re: [PATCH 09/10] perf tools: Make 'trace' sort key default for tracepoint events

2015-12-21 Thread Jiri Olsa
On Mon, Dec 21, 2015 at 11:26:52PM +0900, Namhyung Kim wrote: > When an evlist contains tracepoint events only, use 'trace' sort key as > default. This will make users more convenient to see trace result. > > Suggested-by: Jiri Olsa > Cc: Steven Rostedt > Signed-off-by: Namhyung Kim > --- >

Re: [PATCH v3 33/77] atari_NCR5380: Set do_abort() timeouts

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Use timeouts in do_abort() in atari_NCR5380.c instead of infinite loops. Also fix the kernel-doc comment. Keep the two core driver forks in sync. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 26 +-

Re: [PATCH v3 32/77] ncr5380: Fix bus phase in do_abort()

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: NCR5380_poll_politely() returns either 0 (success) or -ETIMEDOUT. However, in do_abort(), the return value is incorrectly taken to be the status register value. This means that the bus is put into DATA OUT phase instead of MESSAGE OUT. Fix this.

Re: [PATCH v3 31/77] ncr5380: Fix !REQ timeout in do_abort()

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: NCR5380_poll_politely() never returns -1. That means do_abort() can fail to handle a timeout after waiting for the target to negate REQ. Fix this and cleanup other NCR5380_poll_politely() call sites. Signed-off-by: Finn Thain ---

Re: [PATCH v3 30/77] ncr5380: Add missing break after case MESSAGE_REJECT

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: MESSAGE REJECT does not imply DISCONNECT: the target is about to enter MESSAGE IN or MESSAGE OUT phase. This bug fix comes from atari_NCR5380.c. Unfortunately it never made it into the original NCR5380.c core driver. Signed-off-by: Finn Thain ---

Re: [PATCH v3 29/77] ncr5380: Remove references to linked commands

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: From: Hannes Reinecke Some old drivers partially implemented support for linked commands using a "proposed" next_link pointer in struct scsi_cmnd that never actually existed. Remove this code. Signed-off-by: Finn Thain --- This is a modified

Re: [PATCH v3 28/77] ncr5380: Drop DEF_SCSI_QCMD macro

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Remove the DEF_SCSI_QCMD macro (already removed from atari_NCR5380.c). The lock provided by DEF_SCSI_QCMD is only needed for queue data structures. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c | 30 +++---

Re: [PATCH v3 27/77] ncr5380: Add missing lock in eh_abort_handler

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: The host spin lock needs to be acquired by NCR5380_abort() before it calls NCR5380_select(). This patch doesn't actually fix the EH issues in this driver but it does avoid this: BUG: spinlock already unlocked on CPU#0, kworker/u4:1/14 lock:

Re: [PATCH 07/10] perf tools: Add 'trace' sort key

2015-12-21 Thread Jiri Olsa
On Mon, Dec 21, 2015 at 11:26:50PM +0900, Namhyung Kim wrote: SNIP > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > index e28d26d0e73c..50a6b35a2fee 100644 > --- a/tools/perf/util/sort.c > +++ b/tools/perf/util/sort.c > @@ -445,6 +445,65 @@ struct sort_entry sort_socket = { >

Re: [PATCH v3 26/77] ncr5380: Fix NCR5380_transfer_pio() result

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: According to the SCSI-2 draft revision 10L, atari_NCR5380.c is correct when it says that the phase lines are valid up until ACK is negated following the transmission of the last byte in MESSAGE IN phase. This is true for all information transfer phases,

Re: [PATCH v3 25/77] ncr5380: Rework disconnect versus poll logic

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: The atari_NCR5380.c and NCR5380.c core drivers differ in their handling of target disconnection. This is partly because atari_NCR5380.c had all of the polling and sleeping removed to become entirely interrupt-driven, and it is partly because of damage

RE: [char-misc-next v3 3/8] watchdog: mei_wdt: implement MEI iAMT watchdog driver

2015-12-21 Thread Winkler, Tomas
> > On 12/21/2015 03:17 PM, Tomas Winkler wrote: > > Create a driver with the generic watchdog interface > > for the MEI iAMT watchdog device. > > > > Signed-off-by: Alexander Usyskin > > Signed-off-by: Tomas Winkler > > --- > > V2: The watchdog device is no longer dynamically allocated in

RE: [PATCH v2 1/2] KVM: x86: Use vector-hashing to deliver lowest-priority interrupts

2015-12-21 Thread Wu, Feng
Hi Radim/Paolo, > -Original Message- > From: Yang Zhang [mailto:yang.zhang...@gmail.com] > Sent: Tuesday, December 22, 2015 3:14 PM > To: Wu, Feng ; pbonz...@redhat.com; > rkrc...@redhat.com > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; Jiang Liu > (jiang@linux.intel.com)

Re: [PATCH v3 24/77] ncr5380: Implement NCR5380_dma_xfer_len and remove LIMIT_TRANSFERSIZE macro

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Follow the example of the atari_NCR5380.c core driver and adopt the NCR5380_dma_xfer_len() hook. Implement NCR5380_dma_xfer_len() for dtc.c and g_NCR5380.c to take care of the limitations of these cards. Keep the default for drivers using PSEUDO_DMA.

Re: [PATCH v2 3/4] staging: lustre: Less checks in mgc_process_recover_log() after error detection

2015-12-21 Thread SF Markus Elfring
>> 6. Apply a recommendation from the script "checkpatch.pl". > > That's 6 different things, shouldn't this be 6 different patches? > > please redo. Dan Carpenter requested to squash the previous update steps 5 and 6 into a single patch for better source code review. Now I see further software

Re: [PATCH] s390/vmur: fix build warning

2015-12-21 Thread Sudip Mukherjee
On Tue, Dec 22, 2015 at 06:58:50AM +, Al Viro wrote: > On Tue, Dec 22, 2015 at 12:23:51PM +0530, Sudip Mukherjee wrote: > > The helper no_seek_end_llseek() was added but now newpos is not required > > and as a result we are getting build warning of unused variable. > > Mind if I simply fold

Re: [PATCH v3 23/77] ncr5380: Always retry arbitration and selection

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: If NCR5380_select() returns -1, it means arbitration was lost or selection failed and should be retried. If the main loop simply terminates when there are still commands on the issue queue, they will remain queued until they expire. Fix this by clearing

Re: [PATCH v3 22/77] ncr5380: Eliminate selecting state

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:18 AM, Finn Thain wrote: Linux v2.1.105 changed the algorithm for polling for the BSY signal in NCR5380_select() and NCR5380_main(). Presently, this code has a bug. Back then, NCR5380_set_timer(hostdata, 1) meant reschedule main() after sleeping for 10 ms. Repeated 25 times

Re: [PATCH v2 1/2] KVM: x86: Use vector-hashing to deliver lowest-priority interrupts

2015-12-21 Thread Yang Zhang
On 2015/12/22 14:59, Wu, Feng wrote: -Original Message- From: Yang Zhang [mailto:yang.zhang...@gmail.com] Sent: Tuesday, December 22, 2015 2:49 PM To: Wu, Feng ; pbonz...@redhat.com; rkrc...@redhat.com Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; Jiang Liu

Re: [PATCH v3 21/77] ncr5380: Sleep when polling, if possible

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:17 AM, Finn Thain wrote: When in process context, sleep during polling if doing so won't add significant latency. In interrupt context or if the lock is held, poll briefly then give up. Keep both core drivers in sync. Calibrate busy-wait iterations to allow for variation in

Re: [PATCH v3 20/77] ncr5380: Introduce unbound workqueue

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:17 AM, Finn Thain wrote: Allocate a work queue that will permit busy waiting and sleeping. This means NCR5380_init() can potentially fail, so add this error path. Signed-off-by: Finn Thain --- In subsequent patches, the work function adopts this work queue so it can sleep

Re: [PATCH kernel] rcu: Define lockless version of list_for_each_entry_rcu

2015-12-21 Thread Alexey Kardashevskiy
On 12/08/2015 04:46 PM, Paul E. McKenney wrote: On Tue, Dec 08, 2015 at 04:20:03PM +1100, Paul Mackerras wrote: On Sat, Dec 05, 2015 at 06:19:46PM -0800, Paul E. McKenney wrote: As in the following? (And yes, I was confused by the fact that the docbook header was in front of a

Re: [PATCH] wlcore: consolidate kmalloc + memset 0 into kzalloc

2015-12-21 Thread Souptick Joarder
inelle/api/alloc/kzalloc-simple.cocci) > > Patch was compile tested with: x86_64_defconfig + > CONFIG_WL12XX=m (implies CONFIG_WLCORE=m) > > Patch is against linux-next (localversion-next is -next-20151221) > > drivers/net/wireless/ti/wlcore/main.c | 3 +-- > 1 file change

Re: [PATCH v3 19/77] ncr5380: Cleanup bogus {request,release}_region() calls

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:17 AM, Finn Thain wrote: Commit 8b801ead3d7a ("[ARM] rpc: update Acorn SCSI drivers to modern ecard interfaces") neglected to remove a request_region() call in cumana_1.c. Commit eda32612f7b2 ("[PATCH] give all LLDD driver a ->release method") in history/history.git added some

Re: [PATCH v3 18/77] ncr5380: Eliminate USLEEP_WAITLONG delay

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:17 AM, Finn Thain wrote: Linux 2.1.105 introduced the USLEEP_WAITLONG delay, apparently "needed for Mustek scanners". It is intended to stall the issue queue for 5 seconds. There are a number of problems with this. 1. Only g_NCR5380 enables the delay, which implies that the

Re: [PATCH v3 17/77] ncr5380: Keep BSY asserted when entering SELECTION phase

2015-12-21 Thread Hannes Reinecke
On 12/22/2015 02:17 AM, Finn Thain wrote: NCR5380.c is not compliant with the SCSI-2 standard (at least, not with the draft revision 10L that I have to refer to). The selection algorithm in atari_NCR5380.c is correct, so use that. Signed-off-by: Finn Thain Reviewed-by: Hannes Reinecke

Re: [PATCH] Revert "kernel/stop_machine.c: remove CONFIG_SMP dependencies"

2015-12-21 Thread Andrew Morton
On Tue, 22 Dec 2015 11:30:51 +0530 Sudip Mukherjee wrote: > > Rationale: > > > > stop_machine.o is only built when CONFIG_SMP=y so > > > > #if defined(CONFIG_SMP) || defined(CONFIG_HOTPLUG_CPU) > > > > always evaluates to true, so remove it. > > Hi Andrew, > The error is still there. I

RE: [PATCH v2 1/2] KVM: x86: Use vector-hashing to deliver lowest-priority interrupts

2015-12-21 Thread Wu, Feng
> -Original Message- > From: Yang Zhang [mailto:yang.zhang...@gmail.com] > Sent: Tuesday, December 22, 2015 2:49 PM > To: Wu, Feng ; pbonz...@redhat.com; > rkrc...@redhat.com > Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org; Jiang Liu > (jiang@linux.intel.com) > Subject: Re:

[PATCH v6.2 4/6] drm: rockchip: Support Synopsys DW MIPI DSI

2015-12-21 Thread Chris Zhong
Add support for Synopsys DesignWare MIPI DSI controller which is embedded in the rk3288 SoCs. Signed-off-by: Chris Zhong --- Changes in v6.2: - Remove the atomic feature check (Mark Yao) Changes in v6.1: - Add atomic API support (Heiko Stübne) Changes in v6: - Do not use bridge driver

Re: [PATCH] s390/vmur: fix build warning

2015-12-21 Thread Al Viro
On Tue, Dec 22, 2015 at 12:23:51PM +0530, Sudip Mukherjee wrote: > The helper no_seek_end_llseek() was added but now newpos is not required > and as a result we are getting build warning of unused variable. Mind if I simply fold that into the commit in question? -- To unsubscribe from this list:

Re: [PATCH v4 2/2] zram: try vmalloc() after kmalloc()

2015-12-21 Thread Sergey Senozhatsky
Hello, Cc stable Do I need to resend the patch or providing the message-id is enough? lkml.kernel.org/r/1448973390-21170-3-git-send-email-sergey.senozhat...@gmail.com ( http://marc.info/?l=linux-kernel=144897350818887 ) -ss > From: Kyeongdon Kim > > When we're using LZ4 multi

Re: linux-next: build failure after merge of the gpio tree

2015-12-21 Thread Robert Jarzmik
Stephen Rothwell writes: > Hi Linus, > > After merging the gpio tree, today's linux-next build (lots without > CONFIG_OF) failed like this: > > drivers/gpio/gpio-pxa.c: In function 'pxa_gpio_probe': > drivers/gpio/gpio-pxa.c:648:12: error: 'pxa_irq_domain_ops' undeclared (first > use in this

Re: [PATCH 08/10] perf tools: Add --raw-trace option

2015-12-21 Thread Jiri Olsa
On Mon, Dec 21, 2015 at 05:44:41PM +0900, Namhyung Kim wrote: SNIP > > > > I think the default is good with the 'trace' sort key as it is now: > > > > $ ./perf report -s trace > > 27.01% offlineimap:17701 [120] S ==> swapper/1:0 [120] > > 27.00% swapper/1:0 [120] R ==>

[PATCH] s390/vmur: fix build warning

2015-12-21 Thread Sudip Mukherjee
The helper no_seek_end_llseek() was added but now newpos is not required and as a result we are getting build warning of unused variable. Fixes: fb1d259e480c ("new helpers: no_seek_end_llseek{,_size}()") Cc: Al Viro Signed-off-by: Sudip Mukherjee --- drivers/s390/char/vmur.c | 2 -- 1 file

Re: [PATCH v4 2/2] zram: try vmalloc() after kmalloc()

2015-12-21 Thread Sergey Senozhatsky
On (12/22/15 12:10), Kyeongdon Kim wrote: [..] > > Hello Kyeongdon, > > > > just to make sure, the patch works fine for you and we can move > > forward and Cc -stable. correct? > > > > -ss > > > Hello Sergey, > > I was on vacation so I checked your email a moment ago, sorry about it. > We're

Re: [PATCH] s390: fix build failure

2015-12-21 Thread Dan Williams
On Mon, Dec 21, 2015 at 10:40 PM, Sudip Mukherjee wrote: > s390 defconfig fails with the error: > ERROR: "phys_to_pfn_t" [drivers/s390/block/dcssblk.ko] undefined! > > We need CONFIG_HAS_IOMEM for phys_to_pfn_t() and for that we need to > have CONFIG_PCI. > > Fixes: bfac97e7b361 ("mm, dax, pmem:

Re: [PATCH v2 1/2] KVM: x86: Use vector-hashing to deliver lowest-priority interrupts

2015-12-21 Thread Yang Zhang
On 2015/12/22 12:37, Wu, Feng wrote: -Original Message- From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel- ow...@vger.kernel.org] On Behalf Of Yang Zhang Sent: Monday, December 21, 2015 10:06 AM To: Wu, Feng ; pbonz...@redhat.com; rkrc...@redhat.com Cc:

Re: [PATCH v2 2/2] KVM: x86: Add lowest-priority support for vt-d posted-interrupts

2015-12-21 Thread Yang Zhang
On 2015/12/22 12:36, Wu, Feng wrote: -Original Message- From: Yang Zhang [mailto:yang.zhang...@gmail.com] Sent: Monday, December 21, 2015 10:01 AM To: Wu, Feng ; pbonz...@redhat.com; rkrc...@redhat.com Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/2]

[PATCH] s390: fix build failure

2015-12-21 Thread Sudip Mukherjee
s390 defconfig fails with the error: ERROR: "phys_to_pfn_t" [drivers/s390/block/dcssblk.ko] undefined! We need CONFIG_HAS_IOMEM for phys_to_pfn_t() and for that we need to have CONFIG_PCI. Fixes: bfac97e7b361 ("mm, dax, pmem: introduce pfn_t") Cc: Dan Williams Cc: Andrew Morton Signed-off-by:

Re: [PATCH 1/6] perf, tools, stat: Abstract stat metrics printing

2015-12-21 Thread Jiri Olsa
On Tue, Dec 22, 2015 at 02:16:30AM +0100, Andi Kleen wrote: > > > - fprintf(out, " "); > > > + print_metric(ctxp, NULL, NULL, "insn per cycle", 0); > > > } > > > total = > > >

Inconsistent description in memory-barrier.txt

2015-12-21 Thread Jianyu Zhan
Hi, Paul, I noticed that in the control dependency section in memory-barrier.txt, you mistakenly made an inconsistent description: On the description part: 641 It is tempting to try to enforce ordering on identical stores on both 642 branches of the "if" statement as follows: 643 644

[PATCH] ASoC: atmel_wm8904: add snd_soc_pm_ops

2015-12-21 Thread Songjun Wu
Sometimes the audio play can not be resumed after it is suspended. Add snd_soc_pm_ops to execute power management operations, then this issue is fixed. Signed-off-by: Songjun Wu --- sound/soc/atmel/atmel_wm8904.c |1 + 1 file changed, 1 insertion(+) diff --git

Re:Hello

2015-12-21 Thread hi
Hello Christmas day is coming We are holding a big activity this week tv, brand watch, laptop, bicycle, gultat, dj, Samsung products all of our product can be offered 50% discount iphone 6s, 420USD si te: poazzlo .com

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Kent Overstreet
On Tue, Dec 22, 2015 at 10:59:09AM +0500, Artem S. Tashkinov wrote: > On 2015-12-22 10:55, Kent Overstreet wrote: > >On Tue, Dec 22, 2015 at 10:52:37AM +0500, Artem S. Tashkinov wrote: > >>On 2015-12-22 10:38, Kent Overstreet wrote: > >>>On Tue, Dec 22, 2015 at 05:26:12AM +, Junichi Nomura

Re: [PATCH] Revert "kernel/stop_machine.c: remove CONFIG_SMP dependencies"

2015-12-21 Thread Sudip Mukherjee
On Fri, Dec 18, 2015 at 03:07:53PM -0800, Andrew Morton wrote: > On Fri, 18 Dec 2015 15:35:55 +0530 Sudip Mukherjee > wrote: > > > This reverts commit 64dab25b058c12f935794cb239089303bda7dbc1. > > > > CONFIG_SMP dependency is needed for some arch like tile, tilegx and > > m32r. They use

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Artem S. Tashkinov
On 2015-12-22 10:55, Kent Overstreet wrote: On Tue, Dec 22, 2015 at 10:52:37AM +0500, Artem S. Tashkinov wrote: On 2015-12-22 10:38, Kent Overstreet wrote: >On Tue, Dec 22, 2015 at 05:26:12AM +, Junichi Nomura wrote: >>On 12/22/15 12:59, Kent Overstreet wrote: >>> reproduced it with 32 bit

Re: [PATCH v7 4/5] iommu/mediatek: Add mt8173 IOMMU driver

2015-12-21 Thread Yong Wu
On Fri, 2015-12-18 at 17:44 +, Robin Murphy wrote: > On 18/12/15 08:09, Yong Wu wrote: > > This patch adds support for mediatek m4u (MultiMedia Memory Management > > Unit). > > > > Signed-off-by: Yong Wu > > --- > > drivers/iommu/Kconfig | 14 + > > drivers/iommu/Makefile| 1 + >

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Kent Overstreet
On Tue, Dec 22, 2015 at 10:52:37AM +0500, Artem S. Tashkinov wrote: > On 2015-12-22 10:38, Kent Overstreet wrote: > >On Tue, Dec 22, 2015 at 05:26:12AM +, Junichi Nomura wrote: > >>On 12/22/15 12:59, Kent Overstreet wrote: > >>> reproduced it with 32 bit pae: > >>> > 1. Exclude memory

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Artem S. Tashkinov
On 2015-12-22 10:38, Kent Overstreet wrote: On Tue, Dec 22, 2015 at 05:26:12AM +, Junichi Nomura wrote: On 12/22/15 12:59, Kent Overstreet wrote: > reproduced it with 32 bit pae: > >> 1. Exclude memory above 4G line with boot param "max_addr=4G". > > doesn't work - max_addr=1G doesn't work

[PATCH v2 1/2] ASoC: rt5616: add an of_match table

2015-12-21 Thread Caesar Wang
Add a device tree match table. This serves to make the driver's support of device tree more explicit. Signed-off-by: Caesar Wang --- Changes in v2: None Changes in v1: None sound/soc/codecs/rt5616.c | 9 + 1 file changed, 9 insertions(+) diff --git a/sound/soc/codecs/rt5616.c

[PATCH v2 2/2] dt-bindings: sound: add devicetree document for rt5616

2015-12-21 Thread Caesar Wang
Add the description for rt5616 codec. Signed-off-by: Caesar Wang --- Changes in v2: - As Frank comments, rt5616@1b to instead of rt5616. - Update the Pins device from Bard. Changes in v1: - As Heiko comments, remove the not exist option properties.

linux-next: build failure after merge of the gpio tree

2015-12-21 Thread Stephen Rothwell
Hi Linus, After merging the gpio tree, today's linux-next build (lots without CONFIG_OF) failed like this: drivers/gpio/gpio-pxa.c: In function 'pxa_gpio_probe': drivers/gpio/gpio-pxa.c:648:12: error: 'pxa_irq_domain_ops' undeclared (first use in this function) Caused by commit 384ca3c6a28d

[PATCH] Staging: comedi: fix block comments coding style issue in comedi.h

2015-12-21 Thread maomao xu
Fix up block comments to make a trailing */ on a separate line Signed-off-by: maomao xu --- drivers/staging/comedi/comedi.h |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi/comedi.h index 66edda1..ec5e59c 100644

Re: [PATCH] dmaengine: dw: clear LLP_[SD]_EN bits in last descriptor of a chain

2015-12-21 Thread Viresh Kumar
On 21-12-15, 19:10, Mans Rullgard wrote: > The datasheet requires that the LLP_[SD]_EN bits be cleared whenever > LLP.LOC is zero, i.e. in the last descriptor of a multi-block chain. > Make the driver do this. > > Signed-off-by: Mans Rullgard > --- > drivers/dma/dw/core.c | 2 ++ > 1 file

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Kent Overstreet
On Tue, Dec 22, 2015 at 05:26:12AM +, Junichi Nomura wrote: > On 12/22/15 12:59, Kent Overstreet wrote: > > reproduced it with 32 bit pae: > > > >> 1. Exclude memory above 4G line with boot param "max_addr=4G". > > > > doesn't work - max_addr=1G doesn't work either > > > >> 2. Disable

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Kent Overstreet
On Tue, Dec 22, 2015 at 05:26:12AM +, Junichi Nomura wrote: > On 12/22/15 12:59, Kent Overstreet wrote: > > reproduced it with 32 bit pae: > > > >> 1. Exclude memory above 4G line with boot param "max_addr=4G". > > > > doesn't work - max_addr=1G doesn't work either > > > >> 2. Disable

Re: [PATCH 2/2] blackfin-cpufreq: Mark cpu_set_cclk() as static

2015-12-21 Thread Viresh Kumar
On 21-12-15, 22:32, SF Markus Elfring wrote: > From: Markus Elfring > Date: Mon, 21 Dec 2015 22:12:26 +0100 > > The cpu_set_cclk() function was only used in a single source file so far. > Indicate this setting also by the corresponding linkage specifier. > > Signed-off-by: Markus Elfring >

Re: [RFC] mm: change find_vma() function

2015-12-21 Thread yalin wang
> On Dec 15, 2015, at 19:53, Kirill A. Shutemov > wrote: > > On Tue, Dec 15, 2015 at 02:41:21PM +0800, yalin wang wrote: >>> On Dec 15, 2015, at 05:11, Kirill A. Shutemov wrote: >>> Anyway, I don't think it's possible to gain anything measurable from this >>> optimization. >>> >> the

Re: [char-misc-next v3 4/8] watchdog: mei_wdt: add status debugfs entry

2015-12-21 Thread Guenter Roeck
On 12/21/2015 03:17 PM, Tomas Winkler wrote: Add entry for dumping current watchdog internal state Signed-off-by: Tomas Winkler --- V2: new in the series V3: rebase drivers/watchdog/mei_wdt.c | 88 ++ 1 file changed, 88 insertions(+) diff --git

linux-next: Tree for Dec 22

2015-12-21 Thread Stephen Rothwell
Hi all, Changes since 20151221: I added a patch to the orangefs tree for a post release discovered build failure. The i2c tree still had its build failure for which I applied a patch. The drm tree gained a conflict against the imx-mxs tree. The drm-intel tree gained a conflict against Linus

RE: [f2fs-dev] [PATCH 1/2] f2fs: use atomic variable for total_extent_tree

2015-12-21 Thread Chao Yu
Hi Jaegeuk, > -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Tuesday, December 22, 2015 11:39 AM > To: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; > linux-f2fs-de...@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 1/2]

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Junichi Nomura
On 12/22/15 12:59, Kent Overstreet wrote: > reproduced it with 32 bit pae: > >> 1. Exclude memory above 4G line with boot param "max_addr=4G". > > doesn't work - max_addr=1G doesn't work either > >> 2. Disable highmem with "highmem=0". > > works! > >> 3. Try booting 64bit kernel. > > works

RE: [f2fs-dev] [PATCH 2/2] f2fs: speed up shrinking extent tree entries

2015-12-21 Thread Chao Yu
Hi Jaegeuk, We should update _zombie_tree whenever removing unreferenced extent tree during shrinking: - f2fs_shrink_extent_tree if (!atomic_read(>refcount)) { ... atomic_dec(>total_ext_tree); atomic_dec(>total_zombie_tree); ... } Other parts look good to me. :)

Re: IO errors after "block: remove bio_get_nr_vecs()"

2015-12-21 Thread Artem S. Tashkinov
On 2015-12-22 01:07, Tejun Heo wrote: Hello, Artem. Can you please apply the following patch on top and see whether anything changes? If it does make the issue go away, can you please revert the ".can_queue" part and test again? Thanks. --- drivers/ata/ahci.h|2 +-

Re: [char-misc-next v3 6/8] watchdog: mei_wdt: register wd device only if required

2015-12-21 Thread Guenter Roeck
On 12/21/2015 03:17 PM, Tomas Winkler wrote: From: Alexander Usyskin For Intel Broadwell and newer platforms, the ME device can inform the host whether the watchdog functionality is activated or not. If the watchdog functionality is not activated then the watchdog interface can be not

  1   2   3   4   5   6   7   8   9   10   >