Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

2016-06-16 Thread Luis R. Rodriguez
On Thu, Sep 03, 2015 at 07:56:33AM +0200, Julia Lawall wrote: > > > On Thu, 3 Sep 2015, Luis R. Rodriguez wrote: > > > On Sat, Aug 29, 2015 at 06:18:20PM +0200, Julia Lawall wrote: > > > > +@ defines_module_init exists @ > > > > +declarer name module_init; > > > > +identifier init; > > > > +@@

Re: [RFC] firmware: annotate thou shalt not request fw on init or probe

2016-06-16 Thread Luis R. Rodriguez
On Thu, Sep 03, 2015 at 07:56:33AM +0200, Julia Lawall wrote: > > > On Thu, 3 Sep 2015, Luis R. Rodriguez wrote: > > > On Sat, Aug 29, 2015 at 06:18:20PM +0200, Julia Lawall wrote: > > > > +@ defines_module_init exists @ > > > > +declarer name module_init; > > > > +identifier init; > > > > +@@

Re: [PATCH v2] audit: add fields to exclude filter by reusing user filter

2016-06-16 Thread Paul Moore
On Tue, Jun 14, 2016 at 5:04 PM, Richard Guy Briggs wrote: > RFE: add additional fields for use in audit filter exclude rules > https://github.com/linux-audit/audit-kernel/issues/5 > > Re-factor and combine audit_filter_type() with audit_filter_user() to > use

Re: [PATCH v2] audit: add fields to exclude filter by reusing user filter

2016-06-16 Thread Paul Moore
On Tue, Jun 14, 2016 at 5:04 PM, Richard Guy Briggs wrote: > RFE: add additional fields for use in audit filter exclude rules > https://github.com/linux-audit/audit-kernel/issues/5 > > Re-factor and combine audit_filter_type() with audit_filter_user() to > use audit_filter_user_rules() to enable

[BUG] act_ife: sleeping functions called in atomic context

2016-06-16 Thread Alexey Khoroshilov
tcf_ife_init() contains a big chunk of code executed with ife->tcf_lock spinlock held. But that code contains several calls to sleeping functions: populate_metalist() and use_all_metadata() -> add_metainfo() -> find_ife_oplist(metaid) -> read_lock() ->

[BUG] act_ife: sleeping functions called in atomic context

2016-06-16 Thread Alexey Khoroshilov
tcf_ife_init() contains a big chunk of code executed with ife->tcf_lock spinlock held. But that code contains several calls to sleeping functions: populate_metalist() and use_all_metadata() -> add_metainfo() -> find_ife_oplist(metaid) -> read_lock() ->

RE: [PATCH v4 07/10] ntb_tool: Add link status and files to debugfs

2016-06-16 Thread Allen Hubbe
From: Logan Gunthorpe > In order to more successfully script with ntb_tool it's useful to > have a link file to check the link status so that the script > doesn't use the other files until the link is up. > > This commit adds a 'link' file to the debugfs directory which reads > boolean (Y or N)

RE: [PATCH v4 09/10] ntb_test: Add a selftest script for the NTB subsystem

2016-06-16 Thread Allen Hubbe
From: Logan Gunthorpe > This script automates testing doorbells, scratchpads and memory windows > for an NTB device. It can be run locally, with the NTB looped > back to the same host or use SSH to remotely control the second host. > > In the single host case, the script just needs to be passed

RE: [PATCH v4 07/10] ntb_tool: Add link status and files to debugfs

2016-06-16 Thread Allen Hubbe
From: Logan Gunthorpe > In order to more successfully script with ntb_tool it's useful to > have a link file to check the link status so that the script > doesn't use the other files until the link is up. > > This commit adds a 'link' file to the debugfs directory which reads > boolean (Y or N)

RE: [PATCH v4 09/10] ntb_test: Add a selftest script for the NTB subsystem

2016-06-16 Thread Allen Hubbe
From: Logan Gunthorpe > This script automates testing doorbells, scratchpads and memory windows > for an NTB device. It can be run locally, with the NTB looped > back to the same host or use SSH to remotely control the second host. > > In the single host case, the script just needs to be passed

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-16 Thread Francois Romieu
Netanel Belgazal : [...] Very limited review below. > diff --git a/Documentation/networking/ena.txt > b/Documentation/networking/ena.txt > new file mode 100644 > index 000..528544f > --- /dev/null > +++ b/Documentation/networking/ena.txt > @@ -0,0 +1,330 @@ >

[PATCH] MIPS: Lantiq: fix build failure

2016-06-16 Thread Sudip Mukherjee
Some configs of mips like xway_defconffig are failing with the error: arch/mips/lantiq/irq.c:209:2: error: initialization from incompatible pointer type [-Werror] "icu", ^ arch/mips/lantiq/irq.c:209:2: error: (near initialization for 'ltq_irq_type.parent_device') [-Werror]

Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

2016-06-16 Thread Francois Romieu
Netanel Belgazal : [...] Very limited review below. > diff --git a/Documentation/networking/ena.txt > b/Documentation/networking/ena.txt > new file mode 100644 > index 000..528544f > --- /dev/null > +++ b/Documentation/networking/ena.txt > @@ -0,0 +1,330 @@ > +Linux kernel driver for

[PATCH] MIPS: Lantiq: fix build failure

2016-06-16 Thread Sudip Mukherjee
Some configs of mips like xway_defconffig are failing with the error: arch/mips/lantiq/irq.c:209:2: error: initialization from incompatible pointer type [-Werror] "icu", ^ arch/mips/lantiq/irq.c:209:2: error: (near initialization for 'ltq_irq_type.parent_device') [-Werror]

Re: [tpmdd-devel] [PATCH 3/3] tpm, tpm_crb: runtime power management

2016-06-16 Thread Jason Gunthorpe
On Thu, Jun 16, 2016 at 11:26:48PM +0300, Tomas Winkler wrote: > > It is compiled out if it is unused. Why would you want to trash the code > > with #ifdef cages if they are not necessary? I can add /* CONFIG_PM */ > > before the function if that makes it cleaner. > > I'm not sure about that, I

Re: [tpmdd-devel] [PATCH 3/3] tpm, tpm_crb: runtime power management

2016-06-16 Thread Jason Gunthorpe
On Thu, Jun 16, 2016 at 11:26:48PM +0300, Tomas Winkler wrote: > > It is compiled out if it is unused. Why would you want to trash the code > > with #ifdef cages if they are not necessary? I can add /* CONFIG_PM */ > > before the function if that makes it cleaner. > > I'm not sure about that, I

Re: [REDO PATCH v7] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

2016-06-16 Thread Vince Weaver
On Thu, 16 Jun 2016, Huang Rui wrote: > > 1. In theory this should also work on an amd fam16h model 30h > > processor too, correct? The current code limits things to fam15h > > even though the fam16mod30h has all the proper cpuid flags. > > > > I was told this feature would be

Re: [REDO PATCH v7] perf/x86/amd/power: Add AMD accumulated power reporting mechanism

2016-06-16 Thread Vince Weaver
On Thu, 16 Jun 2016, Huang Rui wrote: > > 1. In theory this should also work on an amd fam16h model 30h > > processor too, correct? The current code limits things to fam15h > > even though the fam16mod30h has all the proper cpuid flags. > > > > I was told this feature would be

[PATCH] lib: Make strreplace prototype compatible with C++

2016-06-16 Thread Matt Ullman
Since "new" is a keyword in C++, this breaks compilation when string.h is included in a C++ file. For example, this affects VirtualBox Guest Additions. https://www.virtualbox.org/pipermail/vbox-dev/2015-August/013368.html Signed-off-by: Matt Ullman ---

[PATCH] lib: Make strreplace prototype compatible with C++

2016-06-16 Thread Matt Ullman
Since "new" is a keyword in C++, this breaks compilation when string.h is included in a C++ file. For example, this affects VirtualBox Guest Additions. https://www.virtualbox.org/pipermail/vbox-dev/2015-August/013368.html Signed-off-by: Matt Ullman --- include/linux/string.h | 2 +-

Re: [PATCH v2 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-16 Thread Thiago Jung Bauermann
Am Donnerstag, 16 Juni 2016, 09:58:53 schrieb Dave Young: > On 06/15/16 at 01:21pm, Thiago Jung Bauermann wrote: > > +/** > > + * arch_kexec_walk_mem - call func(data) on free memory regions > > + * @image_type:kimage.type > > + * @top_down: Start from the highest address? > > + * @data:

Re: [PATCH v2 2/9] kexec_file: Generalize kexec_add_buffer.

2016-06-16 Thread Thiago Jung Bauermann
Am Donnerstag, 16 Juni 2016, 09:58:53 schrieb Dave Young: > On 06/15/16 at 01:21pm, Thiago Jung Bauermann wrote: > > +/** > > + * arch_kexec_walk_mem - call func(data) on free memory regions > > + * @image_type:kimage.type > > + * @top_down: Start from the highest address? > > + * @data:

Re: [PATCH] tpm: use devm_add_action_or_reset

2016-06-16 Thread Jarkko Sakkinen
On Sun, Jun 12, 2016 at 03:05:29PM +0100, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling put_device() to > free the resources allocated. Lets use the helper > devm_add_action_or_reset() and return directly in case of error, as we > know that the cleanup function has

Re: [PATCH] tpm: use devm_add_action_or_reset

2016-06-16 Thread Jarkko Sakkinen
On Sun, Jun 12, 2016 at 03:05:29PM +0100, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling put_device() to > free the resources allocated. Lets use the helper > devm_add_action_or_reset() and return directly in case of error, as we > know that the cleanup function has

Re: [PATCH] tpm_vtpm_proxy: fix sparse warning

2016-06-16 Thread Jarkko Sakkinen
On Thu, Jun 16, 2016 at 09:39:38AM -0400, Stefan Berger wrote: > On 06/16/2016 06:37 AM, Jarkko Sakkinen wrote: > >When running make C=2 M=drivers/char/tpm/ > > > > CC [M] drivers/char/tpm//tpm_crb.o > > CHECK drivers/char/tpm//tpm_vtpm_proxy.c > >drivers/char/tpm//tpm_vtpm_proxy.c:552:32:

Re: [PATCH] tpm_vtpm_proxy: fix sparse warning

2016-06-16 Thread Jarkko Sakkinen
On Thu, Jun 16, 2016 at 09:39:38AM -0400, Stefan Berger wrote: > On 06/16/2016 06:37 AM, Jarkko Sakkinen wrote: > >When running make C=2 M=drivers/char/tpm/ > > > > CC [M] drivers/char/tpm//tpm_crb.o > > CHECK drivers/char/tpm//tpm_vtpm_proxy.c > >drivers/char/tpm//tpm_vtpm_proxy.c:552:32:

Re: [tpmdd-devel] [PATCH 3/3] tpm, tpm_crb: runtime power management

2016-06-16 Thread Tomas Winkler
On Thu, Jun 16, 2016 at 10:57 PM, Jarkko Sakkinen wrote: > Hi Thomas, > > I'm on a vacation this week but I'll give you quick answers :) > > On Tue, Jun 14, 2016 at 04:14:58PM +0300, Tomas Winkler wrote: >> On Wed, Jun 8, 2016 at 2:02 AM, Jarkko Sakkinen >>

Re: [tpmdd-devel] [PATCH 3/3] tpm, tpm_crb: runtime power management

2016-06-16 Thread Tomas Winkler
On Thu, Jun 16, 2016 at 10:57 PM, Jarkko Sakkinen wrote: > Hi Thomas, > > I'm on a vacation this week but I'll give you quick answers :) > > On Tue, Jun 14, 2016 at 04:14:58PM +0300, Tomas Winkler wrote: >> On Wed, Jun 8, 2016 at 2:02 AM, Jarkko Sakkinen >> wrote: >> > The register

Re: [PATCH v6 4/5] tpm: Allow TPM chip drivers to override reported command durations

2016-06-16 Thread Jarkko Sakkinen
On Fri, Jun 10, 2016 at 06:55:06PM -0700, Ed Swierk wrote: > Some TPM chips report bogus command durations in their capabilities, > just as others report incorrect timeouts. Rework tpm_get_timeouts() to > allow chip drivers to override either via a single callback. Also > clean up handling of TPMs

Re: [PATCH v6 4/5] tpm: Allow TPM chip drivers to override reported command durations

2016-06-16 Thread Jarkko Sakkinen
On Fri, Jun 10, 2016 at 06:55:06PM -0700, Ed Swierk wrote: > Some TPM chips report bogus command durations in their capabilities, > just as others report incorrect timeouts. Rework tpm_get_timeouts() to > allow chip drivers to override either via a single callback. Also > clean up handling of TPMs

Re: [PATCH 0/7] Add SATA3 support for Broadcom NSP SoC

2016-06-16 Thread Tejun Heo
On Thu, Jun 16, 2016 at 09:53:28AM -0400, Yendapally Reddy Dhananjaya Reddy wrote: > This patch set adds support for SATA3 interface available in Broadcom > NSP SoC. Applied 1-7 to libata/for-4.8. If any should be routed differently, please let me know. Thanks. -- tejun

Re: [PATCH 0/7] Add SATA3 support for Broadcom NSP SoC

2016-06-16 Thread Tejun Heo
On Thu, Jun 16, 2016 at 09:53:28AM -0400, Yendapally Reddy Dhananjaya Reddy wrote: > This patch set adds support for SATA3 interface available in Broadcom > NSP SoC. Applied 1-7 to libata/for-4.8. If any should be routed differently, please let me know. Thanks. -- tejun

Re: [PATCH 0/5] Input: alps - cleanup

2016-06-16 Thread Pali Rohár
On Monday 06 June 2016 13:23:56 Pali Rohár wrote: > This patch series cleanup usage of alps_model_data table. > > Pali Rohár (5): > Input: alps - move ALPS_PROTO_V6 out of alps_model_data table > Input: alps - move ALPS_PROTO_V4 out of alps_model_data table > Input: alps - move

Re: [PATCH 0/5] Input: alps - cleanup

2016-06-16 Thread Pali Rohár
On Monday 06 June 2016 13:23:56 Pali Rohár wrote: > This patch series cleanup usage of alps_model_data table. > > Pali Rohár (5): > Input: alps - move ALPS_PROTO_V6 out of alps_model_data table > Input: alps - move ALPS_PROTO_V4 out of alps_model_data table > Input: alps - move

Re: [PATCH v3] Linux VM workaround for Knights Landing A/D leak

2016-06-16 Thread Dave Hansen
On 06/16/2016 08:14 AM, Lukasz Anaczkowski wrote: > For reclaim this brings the performance back to before Mel's > flushing changes, but for unmap it disables batching. This turns out to be pretty catastrophic for unmap. In a workload that uses, say 200 hardware threads and alloc/frees() a few

Re: [PATCH v3] Linux VM workaround for Knights Landing A/D leak

2016-06-16 Thread Dave Hansen
On 06/16/2016 08:14 AM, Lukasz Anaczkowski wrote: > For reclaim this brings the performance back to before Mel's > flushing changes, but for unmap it disables batching. This turns out to be pretty catastrophic for unmap. In a workload that uses, say 200 hardware threads and alloc/frees() a few

Re: [PATCH v6 3/5] tpm: Factor out reading of timeout and duration capabilities

2016-06-16 Thread Jarkko Sakkinen
On Fri, Jun 10, 2016 at 06:55:05PM -0700, Ed Swierk wrote: > Factor sending the TPM_GetCapability command and validating the result > from tpm_get_timeouts() into a new function. Return all errors to the > caller rather than swallowing them (e.g. when tpm_transmit_cmd() > returns nonzero). LGTM

Re: [PATCH v6 3/5] tpm: Factor out reading of timeout and duration capabilities

2016-06-16 Thread Jarkko Sakkinen
On Fri, Jun 10, 2016 at 06:55:05PM -0700, Ed Swierk wrote: > Factor sending the TPM_GetCapability command and validating the result > from tpm_get_timeouts() into a new function. Return all errors to the > caller rather than swallowing them (e.g. when tpm_transmit_cmd() > returns nonzero). LGTM

Re: [PATCH V2 resend] libata:fix kernel panic when hotplug

2016-06-16 Thread Tejun Heo
On Thu, Jun 16, 2016 at 12:45:40PM +0800, DingXiang wrote: ... > In fact,we don't need libata to deal with hotplug in sas environment. > So we can't run ata hotplug task when ata port is sas host. Martin, can you please confirm whether the above is true. If so, I'll route the patch through

Re: [PATCH V2 resend] libata:fix kernel panic when hotplug

2016-06-16 Thread Tejun Heo
On Thu, Jun 16, 2016 at 12:45:40PM +0800, DingXiang wrote: ... > In fact,we don't need libata to deal with hotplug in sas environment. > So we can't run ata hotplug task when ata port is sas host. Martin, can you please confirm whether the above is true. If so, I'll route the patch through

Re: [tpmdd-devel] [PATCH 3/3] tpm, tpm_crb: runtime power management

2016-06-16 Thread Jarkko Sakkinen
On Thu, Jun 16, 2016 at 09:57:35PM +0200, Jarkko Sakkinen wrote: > Hi Thomas, > > I'm on a vacation this week but I'll give you quick answers :) > > On Tue, Jun 14, 2016 at 04:14:58PM +0300, Tomas Winkler wrote: > > On Wed, Jun 8, 2016 at 2:02 AM, Jarkko Sakkinen > >

Re: [tpmdd-devel] [PATCH 3/3] tpm, tpm_crb: runtime power management

2016-06-16 Thread Jarkko Sakkinen
On Thu, Jun 16, 2016 at 09:57:35PM +0200, Jarkko Sakkinen wrote: > Hi Thomas, > > I'm on a vacation this week but I'll give you quick answers :) > > On Tue, Jun 14, 2016 at 04:14:58PM +0300, Tomas Winkler wrote: > > On Wed, Jun 8, 2016 at 2:02 AM, Jarkko Sakkinen > > wrote: > > > The register

Re: hfi1 use of PCI internals

2016-06-16 Thread Bjorn Helgaas
On Thu, Jun 16, 2016 at 02:48:30PM -0400, Ashutosh Dixit wrote: > On Thu, Jun 16 2016 at 12:20:52 PM, Bjorn Helgaas wrote: > > I noticed drivers/infiniband/hw/hfi1 got moved from staging to > > drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM > >

Re: hfi1 use of PCI internals

2016-06-16 Thread Bjorn Helgaas
On Thu, Jun 16, 2016 at 02:48:30PM -0400, Ashutosh Dixit wrote: > On Thu, Jun 16 2016 at 12:20:52 PM, Bjorn Helgaas wrote: > > I noticed drivers/infiniband/hw/hfi1 got moved from staging to > > drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM > > configuration, e.g., see

Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

2016-06-16 Thread Peter Zijlstra
On Thu, Jun 16, 2016 at 09:00:57PM +0200, Vincent Guittot wrote: > On 16 June 2016 at 20:51, Peter Zijlstra wrote: > > On Thu, Jun 16, 2016 at 06:30:13PM +0200, Vincent Guittot wrote: > >> With patch [1] for the init of cfs_rq side, all use cases will be > >> covered

Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

2016-06-16 Thread Peter Zijlstra
On Thu, Jun 16, 2016 at 09:00:57PM +0200, Vincent Guittot wrote: > On 16 June 2016 at 20:51, Peter Zijlstra wrote: > > On Thu, Jun 16, 2016 at 06:30:13PM +0200, Vincent Guittot wrote: > >> With patch [1] for the init of cfs_rq side, all use cases will be > >> covered regarding the issue linked to

Re: [PATCH] mm: memcontrol: fix cgroup creation failure after many small jobs

2016-06-16 Thread Tejun Heo
Hello, Looks generally good to me. Some comments below. On Wed, Jun 15, 2016 at 11:42:44PM -0400, Johannes Weiner wrote: > @@ -6205,6 +6205,24 @@ struct cgroup *cgroup_get_from_path(const char *path) > } > EXPORT_SYMBOL_GPL(cgroup_get_from_path); > > +/** > + * css_id_free - relinquish an

Re: [PATCH] mm: memcontrol: fix cgroup creation failure after many small jobs

2016-06-16 Thread Tejun Heo
Hello, Looks generally good to me. Some comments below. On Wed, Jun 15, 2016 at 11:42:44PM -0400, Johannes Weiner wrote: > @@ -6205,6 +6205,24 @@ struct cgroup *cgroup_get_from_path(const char *path) > } > EXPORT_SYMBOL_GPL(cgroup_get_from_path); > > +/** > + * css_id_free - relinquish an

[PATCH] snd: soc: cx20442 codec: set tty->receiver_room in v253_open

2016-06-16 Thread Janusz Krzysztofik
Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"), introduced in v3.10, revealed a bug in the cx20442 codec driver which has never been setting tty->receive_room on line discipline open as it should from the beginning. Fix it. Created and tested on Amstrad Delta against

[PATCH] snd: soc: cx20442 codec: set tty->receiver_room in v253_open

2016-06-16 Thread Janusz Krzysztofik
Commit 79901317ce80 ("n_tty: Don't flush buffer when closing ldisc"), introduced in v3.10, revealed a bug in the cx20442 codec driver which has never been setting tty->receive_room on line discipline open as it should from the beginning. Fix it. Created and tested on Amstrad Delta against

[PATCH] arm: omap1: fix ams-delta FIQ handler to work with sparse IRQ

2016-06-16 Thread Janusz Krzysztofik
After OMAP1 IRQ definitions have been changed by commit 685e2d08c54b ("ARM: OMAP1: Change interrupt numbering for sparse IRQ") introduced in v4.2, ams-delta FIQ handler which depends on them no longer works as expected. Fix it. Created and tested on Amstrad Delta against Linux-4.7-rc3

[PATCH] arm: omap1: fix ams-delta FIQ handler to work with sparse IRQ

2016-06-16 Thread Janusz Krzysztofik
After OMAP1 IRQ definitions have been changed by commit 685e2d08c54b ("ARM: OMAP1: Change interrupt numbering for sparse IRQ") introduced in v4.2, ams-delta FIQ handler which depends on them no longer works as expected. Fix it. Created and tested on Amstrad Delta against Linux-4.7-rc3

Re: [tpmdd-devel] [PATCH 3/3] tpm, tpm_crb: runtime power management

2016-06-16 Thread Jarkko Sakkinen
Hi Thomas, I'm on a vacation this week but I'll give you quick answers :) On Tue, Jun 14, 2016 at 04:14:58PM +0300, Tomas Winkler wrote: > On Wed, Jun 8, 2016 at 2:02 AM, Jarkko Sakkinen > wrote: > > The register TPM_CRB_CTRL_REQ_0 contains bits goIdle and

Re: [tpmdd-devel] [PATCH 3/3] tpm, tpm_crb: runtime power management

2016-06-16 Thread Jarkko Sakkinen
Hi Thomas, I'm on a vacation this week but I'll give you quick answers :) On Tue, Jun 14, 2016 at 04:14:58PM +0300, Tomas Winkler wrote: > On Wed, Jun 8, 2016 at 2:02 AM, Jarkko Sakkinen > wrote: > > The register TPM_CRB_CTRL_REQ_0 contains bits goIdle and cmdReady for > > invoking the chip to

RE: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival

2016-06-16 Thread Odzioba, Lukasz
On Thu 16-06-16 08:19 PM, Michal Hocko wrote: > > On Thu 16-06-16 18:08:57, Odzioba, Lukasz wrote: > I am not able to find clear reasons why we shouldn't do it for the rest. > Ok so what do we do now? I'll send v2 with proposed changes. > Then do we still want to have stats on those pvecs? > In

RE: [PATCH 1/1] mm/swap.c: flush lru_add pvecs on compound page arrival

2016-06-16 Thread Odzioba, Lukasz
On Thu 16-06-16 08:19 PM, Michal Hocko wrote: > > On Thu 16-06-16 18:08:57, Odzioba, Lukasz wrote: > I am not able to find clear reasons why we shouldn't do it for the rest. > Ok so what do we do now? I'll send v2 with proposed changes. > Then do we still want to have stats on those pvecs? > In

Re: [PATCH RFC 1/3] perf: script: Fix documentation of '-f' when it should be '-F'

2016-06-16 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 16, 2016 at 03:34:32PM +0300, Adrian Hunter escreveu: > The documentation for perf script mixes up '-f' and '-F'. Fix it. Applied, thanks, - Arnaldo > Signed-off-by: Adrian Hunter > --- > tools/perf/Documentation/perf-script.txt | 20 ++-- >

Re: [PATCH RFC 1/3] perf: script: Fix documentation of '-f' when it should be '-F'

2016-06-16 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 16, 2016 at 03:34:32PM +0300, Adrian Hunter escreveu: > The documentation for perf script mixes up '-f' and '-F'. Fix it. Applied, thanks, - Arnaldo > Signed-off-by: Adrian Hunter > --- > tools/perf/Documentation/perf-script.txt | 20 ++-- > 1 file changed, 10

Re: [PATCH v2 0/9] kexec_file_load implementation for PowerPC

2016-06-16 Thread Thiago Jung Bauermann
Am Donnerstag, 16 Juni 2016, 15:48:30 schrieb Michael Ellerman: > On Tue, 2016-06-14 at 11:59 -0300, Thiago Jung Bauermann wrote: > > Hello, > > > > This patch series implements the kexec_file_load system call on PowerPC. > > Can you tell me what this syscall does and why I would want it?

Re: [PATCH v2 0/9] kexec_file_load implementation for PowerPC

2016-06-16 Thread Thiago Jung Bauermann
Am Donnerstag, 16 Juni 2016, 15:48:30 schrieb Michael Ellerman: > On Tue, 2016-06-14 at 11:59 -0300, Thiago Jung Bauermann wrote: > > Hello, > > > > This patch series implements the kexec_file_load system call on PowerPC. > > Can you tell me what this syscall does and why I would want it?

Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()

2016-06-16 Thread Geert Uytterhoeven
Hi Peter, On Thu, Jun 16, 2016 at 7:44 PM, Peter Zijlstra wrote: > On Thu, Jun 16, 2016 at 05:04:24PM +0200, Andreas Schwab wrote: >> Peter Zijlstra writes: >> >> > If not, do you want me to 'fix' this or just remove the comment? >> >> It's not

Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()

2016-06-16 Thread Geert Uytterhoeven
Hi Peter, On Thu, Jun 16, 2016 at 7:44 PM, Peter Zijlstra wrote: > On Thu, Jun 16, 2016 at 05:04:24PM +0200, Andreas Schwab wrote: >> Peter Zijlstra writes: >> >> > If not, do you want me to 'fix' this or just remove the comment? >> >> It's not broken, so nothing to fix. > > Its non obvious

Re: [GIT PULL 00/19] perf/core improvements and fixes

2016-06-16 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 16, 2016 at 08:29:47AM +0200, Jiri Olsa escreveu: > On Wed, Jun 15, 2016 at 03:13:09PM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > > > He Kuang (1): > > perf unwind: Fix compile error for static cross

Re: [GIT PULL 00/19] perf/core improvements and fixes

2016-06-16 Thread Arnaldo Carvalho de Melo
Em Thu, Jun 16, 2016 at 08:29:47AM +0200, Jiri Olsa escreveu: > On Wed, Jun 15, 2016 at 03:13:09PM -0300, Arnaldo Carvalho de Melo wrote: > > SNIP > > > > > He Kuang (1): > > perf unwind: Fix compile error for static cross

Re: [Kernel] Mainlining of Pyra nub joystick driver

2016-06-16 Thread Andrey Utkin
On Tue, Jun 14, 2016 at 07:09:50PM +0200, H. Nikolaus Schaller wrote: > > > Am 14.06.2016 um 19:02 schrieb Andrey Utkin : > > Update: found drivers/input/joystick/as5011.c in mainline kernel, > > will look how it works with as5013 hardware. > > Before you spend too

Re: [Kernel] Mainlining of Pyra nub joystick driver

2016-06-16 Thread Andrey Utkin
On Tue, Jun 14, 2016 at 07:09:50PM +0200, H. Nikolaus Schaller wrote: > > > Am 14.06.2016 um 19:02 schrieb Andrey Utkin : > > Update: found drivers/input/joystick/as5011.c in mainline kernel, > > will look how it works with as5013 hardware. > > Before you spend too much time on it, they have not

iPhone Users Database

2016-06-16 Thread Gavan Hunt
Hi, How are you doing? I'm Gavan. We are an email list vendor serving numerous companies in finding the targeted audience. We have compiled millions of contacts in each category based on an individual’s interest and with their consent. Just emailing you today to see if you'd be interested

iPhone Users Database

2016-06-16 Thread Gavan Hunt
Hi, How are you doing? I'm Gavan. We are an email list vendor serving numerous companies in finding the targeted audience. We have compiled millions of contacts in each category based on an individual’s interest and with their consent. Just emailing you today to see if you'd be interested

Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks

2016-06-16 Thread Josh Poimboeuf
On Thu, Jun 16, 2016 at 10:39:43AM -0700, Andy Lutomirski wrote: > On Thu, Jun 16, 2016 at 8:33 AM, Josh Poimboeuf wrote: > > On Wed, Jun 15, 2016 at 05:28:26PM -0700, Andy Lutomirski wrote: > >> Currently, NR_KERNEL_STACK tracks the number of kernel stacks in a > >> zone.

Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks

2016-06-16 Thread Josh Poimboeuf
On Thu, Jun 16, 2016 at 10:39:43AM -0700, Andy Lutomirski wrote: > On Thu, Jun 16, 2016 at 8:33 AM, Josh Poimboeuf wrote: > > On Wed, Jun 15, 2016 at 05:28:26PM -0700, Andy Lutomirski wrote: > >> Currently, NR_KERNEL_STACK tracks the number of kernel stacks in a > >> zone. This only makes sense

Re: [PATCH v2 1/2] Documentation: bindings: add dt documentation for Rockchip PCIe PHY

2016-06-16 Thread Heiko Stübner
Am Donnerstag, 16. Juni 2016, 13:46:32 schrieb Rob Herring: > On Tue, Jun 14, 2016 at 10:27:46AM -0700, Doug Anderson wrote: > > Hi, > > > > On Mon, Jun 13, 2016 at 5:44 PM, Shawn Lin wrote: > > > This patch adds a binding that describes the Rockchip PCIe PHY > > >

Re: [PATCH v2 1/2] Documentation: bindings: add dt documentation for Rockchip PCIe PHY

2016-06-16 Thread Heiko Stübner
Am Donnerstag, 16. Juni 2016, 13:46:32 schrieb Rob Herring: > On Tue, Jun 14, 2016 at 10:27:46AM -0700, Doug Anderson wrote: > > Hi, > > > > On Mon, Jun 13, 2016 at 5:44 PM, Shawn Lin wrote: > > > This patch adds a binding that describes the Rockchip PCIe PHY > > > found on Rockchip SoCs PCIe

Re: [PATCH 2/2] workqueue:Fix affinity of an unbound worker of a node with 1 online CPU

2016-06-16 Thread Tejun Heo
On Thu, Jun 16, 2016 at 02:45:48PM +0200, Peter Zijlstra wrote: > Subject: workqueue: Fix setting affinity of unbound worker threads > From: Peter Zijlstra > Date: Thu Jun 16 14:38:42 CEST 2016 > > With commit e9d867a67fd03ccc ("sched: Allow per-cpu kernel threads to > run

Re: [PATCH 2/2] workqueue:Fix affinity of an unbound worker of a node with 1 online CPU

2016-06-16 Thread Tejun Heo
On Thu, Jun 16, 2016 at 02:45:48PM +0200, Peter Zijlstra wrote: > Subject: workqueue: Fix setting affinity of unbound worker threads > From: Peter Zijlstra > Date: Thu Jun 16 14:38:42 CEST 2016 > > With commit e9d867a67fd03ccc ("sched: Allow per-cpu kernel threads to > run on online &&

Re: [PATCH 1/2] workqueue: Move wq_update_unbound_numa() to the beginning of CPU_ONLINE

2016-06-16 Thread Tejun Heo
Hello, So, the issue of the initial worker not having its affinity set correctly wasn't caused by the order of the operations. Reordering just made set_cpus_allowed tried one more time late enough so that it hides the race condition most of the time. The problem is that CPU_ONLINE callbacks are

Re: [PATCH 1/2] workqueue: Move wq_update_unbound_numa() to the beginning of CPU_ONLINE

2016-06-16 Thread Tejun Heo
Hello, So, the issue of the initial worker not having its affinity set correctly wasn't caused by the order of the operations. Reordering just made set_cpus_allowed tried one more time late enough so that it hides the race condition most of the time. The problem is that CPU_ONLINE callbacks are

Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks

2016-06-16 Thread Andy Lutomirski
On Thu, Jun 16, 2016 at 10:21 AM, Andy Lutomirski wrote: > On Thu, Jun 16, 2016 at 4:10 AM, Vladimir Davydov > wrote: >> On Wed, Jun 15, 2016 at 05:28:26PM -0700, Andy Lutomirski wrote: >> ... >>> @@ -225,7 +225,8 @@ static void

Re: [PATCH 04/13] mm: Track NR_KERNEL_STACK in pages instead of number of stacks

2016-06-16 Thread Andy Lutomirski
On Thu, Jun 16, 2016 at 10:21 AM, Andy Lutomirski wrote: > On Thu, Jun 16, 2016 at 4:10 AM, Vladimir Davydov > wrote: >> On Wed, Jun 15, 2016 at 05:28:26PM -0700, Andy Lutomirski wrote: >> ... >>> @@ -225,7 +225,8 @@ static void account_kernel_stack(struct thread_info >>> *ti, int account) >>>

Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()

2016-06-16 Thread Andreas Schwab
Peter Zijlstra writes: > On Thu, Jun 16, 2016 at 05:04:24PM +0200, Andreas Schwab wrote: >> Peter Zijlstra writes: >> >> > If not, do you want me to 'fix' this or just remove the comment? >> >> It's not broken, so nothing to fix. > > Its non obvious

Re: [PATCH -v2 14/33] locking,m68k: Implement atomic_fetch_{add,sub,and,or,xor}()

2016-06-16 Thread Andreas Schwab
Peter Zijlstra writes: > On Thu, Jun 16, 2016 at 05:04:24PM +0200, Andreas Schwab wrote: >> Peter Zijlstra writes: >> >> > If not, do you want me to 'fix' this or just remove the comment? >> >> It's not broken, so nothing to fix. > > Its non obvious code, that's usually plenty reason to

Re: [PATCH 0/6] Intel Integrated Sensor Hub Support (ISH)

2016-06-16 Thread Grant Likely
On Sat, Jun 11, 2016 at 1:13 PM, Srinivas Pandruvada wrote: > Starting from Cherrytrail, multiple generation of Intel processors offers > on package sensor hub. Several recent tablets, 2-in-1 convertible laptops > are using ISH instead of external sensor hubs.

Re: [PATCH 0/6] Intel Integrated Sensor Hub Support (ISH)

2016-06-16 Thread Grant Likely
On Sat, Jun 11, 2016 at 1:13 PM, Srinivas Pandruvada wrote: > Starting from Cherrytrail, multiple generation of Intel processors offers > on package sensor hub. Several recent tablets, 2-in-1 convertible laptops > are using ISH instead of external sensor hubs. This resulted in lack of > support

Re: [PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-06-16 Thread Emil Velikov
Hi Jitao Shi, A few comments/suggestions which I hope you'll find useful. Note that I'm not an expert in the area so take them with a pinch of salt. On 2 June 2016 at 10:57, Jitao Shi wrote: > +#define WRITE_STATUS_REG_CMD 0x01 > +#define READ_STATUS_REG_CMD0x05 >

Re: [PATCH 2/2 v16] drm/bridge: Add I2C based driver for ps8640 bridge

2016-06-16 Thread Emil Velikov
Hi Jitao Shi, A few comments/suggestions which I hope you'll find useful. Note that I'm not an expert in the area so take them with a pinch of salt. On 2 June 2016 at 10:57, Jitao Shi wrote: > +#define WRITE_STATUS_REG_CMD 0x01 > +#define READ_STATUS_REG_CMD0x05 > +#define BUSY

Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

2016-06-16 Thread Vincent Guittot
On 16 June 2016 at 20:51, Peter Zijlstra wrote: > On Thu, Jun 16, 2016 at 06:30:13PM +0200, Vincent Guittot wrote: >> With patch [1] for the init of cfs_rq side, all use cases will be >> covered regarding the issue linked to a last_update_time set to 0 at >> init >> [1]

Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

2016-06-16 Thread Vincent Guittot
On 16 June 2016 at 20:51, Peter Zijlstra wrote: > On Thu, Jun 16, 2016 at 06:30:13PM +0200, Vincent Guittot wrote: >> With patch [1] for the init of cfs_rq side, all use cases will be >> covered regarding the issue linked to a last_update_time set to 0 at >> init >> [1]

Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

2016-06-16 Thread Vincent Guittot
On 16 June 2016 at 19:17, Peter Zijlstra wrote: > On Thu, Jun 16, 2016 at 06:30:13PM +0200, Vincent Guittot wrote: >> Le Wednesday 15 Jun 2016 à 17:22:17 (+0200), Peter Zijlstra a écrit : >> > On Wed, Jun 15, 2016 at 09:46:53AM +0200, Vincent Guittot wrote: >> > > I still

Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

2016-06-16 Thread Vincent Guittot
On 16 June 2016 at 19:17, Peter Zijlstra wrote: > On Thu, Jun 16, 2016 at 06:30:13PM +0200, Vincent Guittot wrote: >> Le Wednesday 15 Jun 2016 à 17:22:17 (+0200), Peter Zijlstra a écrit : >> > On Wed, Jun 15, 2016 at 09:46:53AM +0200, Vincent Guittot wrote: >> > > I still have concerned with this

Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-16 Thread Shuah Khan
On 06/16/2016 12:43 PM, Max Kellermann wrote: > On 2016/06/16 18:24, Shuah Khan wrote: >> On 06/15/2016 02:15 PM, Max Kellermann wrote: >>> media_gobj_destroy() may be called twice on one instance - once by >>> media_device_unregister() and again by

Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-16 Thread Shuah Khan
On 06/16/2016 12:43 PM, Max Kellermann wrote: > On 2016/06/16 18:24, Shuah Khan wrote: >> On 06/15/2016 02:15 PM, Max Kellermann wrote: >>> media_gobj_destroy() may be called twice on one instance - once by >>> media_device_unregister() and again by dvb_media_device_free(). The >>> function

Re: [PATCH 10/13] x86/dumpstack: Try harder to get a call trace on stack overflow

2016-06-16 Thread Josh Poimboeuf
On Thu, Jun 16, 2016 at 11:37:07AM -0700, Andy Lutomirski wrote: > On Thu, Jun 16, 2016 at 11:33 AM, Josh Poimboeuf wrote: > > On Thu, Jun 16, 2016 at 11:22:14AM -0700, Andy Lutomirski wrote: > >> On Thu, Jun 16, 2016 at 11:16 AM, Josh Poimboeuf > >>

Re: [PATCH 10/13] x86/dumpstack: Try harder to get a call trace on stack overflow

2016-06-16 Thread Josh Poimboeuf
On Thu, Jun 16, 2016 at 11:37:07AM -0700, Andy Lutomirski wrote: > On Thu, Jun 16, 2016 at 11:33 AM, Josh Poimboeuf wrote: > > On Thu, Jun 16, 2016 at 11:22:14AM -0700, Andy Lutomirski wrote: > >> On Thu, Jun 16, 2016 at 11:16 AM, Josh Poimboeuf > >> wrote: > >> > On Wed, Jun 15, 2016 at

Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

2016-06-16 Thread Peter Zijlstra
On Thu, Jun 16, 2016 at 06:30:13PM +0200, Vincent Guittot wrote: > With patch [1] for the init of cfs_rq side, all use cases will be > covered regarding the issue linked to a last_update_time set to 0 at > init > [1] https://lkml.org/lkml/2016/5/30/508 Aah, wait, now I get it :-) Still, we

Re: [PATCH v6 1/4] sched/fair: Fix attaching task sched avgs twice when switching to fair or changing task group

2016-06-16 Thread Peter Zijlstra
On Thu, Jun 16, 2016 at 06:30:13PM +0200, Vincent Guittot wrote: > With patch [1] for the init of cfs_rq side, all use cases will be > covered regarding the issue linked to a last_update_time set to 0 at > init > [1] https://lkml.org/lkml/2016/5/30/508 Aah, wait, now I get it :-) Still, we

Re: hfi1 use of PCI internals

2016-06-16 Thread Ashutosh Dixit
On Thu, Jun 16 2016 at 12:20:52 PM, Bjorn Helgaas wrote: > I noticed drivers/infiniband/hw/hfi1 got moved from staging to > drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM > configuration, e.g., see drivers/infiniband/hw/hfi1/aspm.h. > > I know there have

Re: hfi1 use of PCI internals

2016-06-16 Thread Ashutosh Dixit
On Thu, Jun 16 2016 at 12:20:52 PM, Bjorn Helgaas wrote: > I noticed drivers/infiniband/hw/hfi1 got moved from staging to > drivers/ for v4.7. It does a bunch of grubbing around in PCIe ASPM > configuration, e.g., see drivers/infiniband/hw/hfi1/aspm.h. > > I know there have been lots of ASPM

Re: [PATCH v2 1/2] Documentation: bindings: add dt documentation for Rockchip PCIe PHY

2016-06-16 Thread Rob Herring
On Tue, Jun 14, 2016 at 10:27:46AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jun 13, 2016 at 5:44 PM, Shawn Lin wrote: > > This patch adds a binding that describes the Rockchip PCIe PHY > > found on Rockchip SoCs PCIe interface. > > > > Signed-off-by: Shawn Lin

Re: [PATCH v2 1/2] Documentation: bindings: add dt documentation for Rockchip PCIe PHY

2016-06-16 Thread Rob Herring
On Tue, Jun 14, 2016 at 10:27:46AM -0700, Doug Anderson wrote: > Hi, > > On Mon, Jun 13, 2016 at 5:44 PM, Shawn Lin wrote: > > This patch adds a binding that describes the Rockchip PCIe PHY > > found on Rockchip SoCs PCIe interface. > > > > Signed-off-by: Shawn Lin > > > > --- > > > > Changes

Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-16 Thread Max Kellermann
On 2016/06/16 18:24, Shuah Khan wrote: > On 06/15/2016 02:15 PM, Max Kellermann wrote: > > media_gobj_destroy() may be called twice on one instance - once by > > media_device_unregister() and again by dvb_media_device_free(). The > > function media_remove_intf_links()

Re: [PATCH 2/3] drivers/media/media-entity: clear media_gobj.mdev in _destroy()

2016-06-16 Thread Max Kellermann
On 2016/06/16 18:24, Shuah Khan wrote: > On 06/15/2016 02:15 PM, Max Kellermann wrote: > > media_gobj_destroy() may be called twice on one instance - once by > > media_device_unregister() and again by dvb_media_device_free(). The > > function media_remove_intf_links() establishes and documents

<    2   3   4   5   6   7   8   9   10   11   >