Re: linux-next: Signed-off-by missing for commit in the renesas tree

Hi, On Fri, 28 Jul 2017 12:09:12 +0700 jmondi wrote: > > On Fri, Jul 28, 2017 at 09:21:08AM +1000, Stephen Rothwell wrote: > > > > Commit > > > > bb003371172f ("arm: dts: genmai: Add RIIC2 pin group") > > > > is missing a Signed-off-by from its committer. > > I do see my

Re: linux-next: Signed-off-by missing for commit in the renesas tree

Hi, On Fri, 28 Jul 2017 12:09:12 +0700 jmondi wrote: > > On Fri, Jul 28, 2017 at 09:21:08AM +1000, Stephen Rothwell wrote: > > > > Commit > > > > bb003371172f ("arm: dts: genmai: Add RIIC2 pin group") > > > > is missing a Signed-off-by from its committer. > > I do see my SOB in the patch

Re: [PATCH V3] mm/madvise: Enable (soft|hard) offline of HugeTLB pages at PGD level

On 07/28/2017 06:19 AM, Mike Kravetz wrote: > On 05/16/2017 03:05 AM, Anshuman Khandual wrote: >> Though migrating gigantic HugeTLB pages does not sound much like real >> world use case, they can be affected by memory errors. Hence migration >> at the PGD level HugeTLB pages should be supported

Re: [PATCH V1 02/12] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other cleanup

On 2017-07-28 05:30, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: This patch cleans up the following. - Rename the "pa" to "pmic_arb". - Rename the spmi_pmic_arb *dev to spmi_pmic_arb *pmic_arb. - Rename the pa_{read,write}_data() functions to pmic_arb_{read,write}_data(). - Rename

Re: [PATCH V3] mm/madvise: Enable (soft|hard) offline of HugeTLB pages at PGD level

On 07/28/2017 06:19 AM, Mike Kravetz wrote: > On 05/16/2017 03:05 AM, Anshuman Khandual wrote: >> Though migrating gigantic HugeTLB pages does not sound much like real >> world use case, they can be affected by memory errors. Hence migration >> at the PGD level HugeTLB pages should be supported

Re: [PATCH V1 02/12] spmi: pmic-arb: rename pa_xx to pmic_arb_xx and other cleanup

On 2017-07-28 05:30, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: This patch cleans up the following. - Rename the "pa" to "pmic_arb". - Rename the spmi_pmic_arb *dev to spmi_pmic_arb *pmic_arb. - Rename the pa_{read,write}_data() functions to pmic_arb_{read,write}_data(). - Rename

linux-next: Tree for Jul 28

Hi all, Changes since 20170727: Non-merge commits (relative to Linus' tree): 2843 2887 files changed, 101051 insertions(+), 48048 deletions(-) I have created today's linux-next tree at git://git.kernel.org/pub/scm

linux-next: Tree for Jul 28

Hi all, Changes since 20170727: Non-merge commits (relative to Linus' tree): 2843 2887 files changed, 101051 insertions(+), 48048 deletions(-) I have created today's linux-next tree at git://git.kernel.org/pub/scm

Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx

On Fri, Jul 28, 2017 at 10:11:48AM +0530, Arvind Yadav wrote: > Hi, > > > On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: > >The s3c_i2sv2_probe() only enabled iis clock. Missing prepare isn't > >probably fatal, because for SoC clocks this is usually no-op, but for > >correctness

Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx

On Fri, Jul 28, 2017 at 10:11:48AM +0530, Arvind Yadav wrote: > Hi, > > > On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: > >The s3c_i2sv2_probe() only enabled iis clock. Missing prepare isn't > >probably fatal, because for SoC clocks this is usually no-op, but for > >correctness

Re: [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

On 2017-07-28 05:31, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Replace the writel_relaxed with __raw_writel to avoid byte swapping in pmic_arb_write_data() function. That way the code is independent of the CPU endianness. Signed-off-by: Kiran Gunda Reviewed-by:

Re: [PATCH V1 06/12] spmi: pmic-arb: replace the writel_relaxed with __raw_writel

On 2017-07-28 05:31, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Replace the writel_relaxed with __raw_writel to avoid byte swapping in pmic_arb_write_data() function. That way the code is independent of the CPU endianness. Signed-off-by: Kiran Gunda Reviewed-by: Stephen Boyd This

Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function

On 2017-07-28 06:48, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Clean up the pmic_arb_find_apid() by using the local variables to improve the code readability. Signed-off-by: Kiran Gunda --- Reviewed-by: Stephen Boyd One nit below:

Re: [PATCH V1 03/12] spmi: pmic-arb: clean up pmic_arb_find_apid function

On 2017-07-28 06:48, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Clean up the pmic_arb_find_apid() by using the local variables to improve the code readability. Signed-off-by: Kiran Gunda --- Reviewed-by: Stephen Boyd One nit below: break;

Re: [PATCH V1 05/12] spmi: pmic-arb: fix memory allocation for mapping_table

On 2017-07-28 05:19, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Allocate the correct memory size (max_pmic_peripherals) for the mapping_table that holds the apid to ppid mapping. Also use a local variable for mapping_table for better alignment of the code. Signed-off-by: Kiran Gunda

Re: [PATCH V1 05/12] spmi: pmic-arb: fix memory allocation for mapping_table

On 2017-07-28 05:19, Stephen Boyd wrote: On 07/20, Kiran Gunda wrote: Allocate the correct memory size (max_pmic_peripherals) for the mapping_table that holds the apid to ppid mapping. Also use a local variable for mapping_table for better alignment of the code. Signed-off-by: Kiran Gunda

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

+ IMX maintainers. On 27-07-17, 19:54, Leonard Crestez wrote: > On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote: > > - Find how much time does it really take to change the frequency of > >   the CPU. I don't really thing 109 us is the right transition > >   latency. Use attached patch for

Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms

+ IMX maintainers. On 27-07-17, 19:54, Leonard Crestez wrote: > On Wed, 2017-07-26 at 11:36 +0530, Viresh Kumar wrote: > > - Find how much time does it really take to change the frequency of > >   the CPU. I don't really thing 109 us is the right transition > >   latency. Use attached patch for

Re: [PATCH 3/4] KVM: VMX: simplify and fix vmx_vcpu_pi_load

On 2017/7/28 12:22, Longpeng (Mike) wrote: > > > On 2017/6/6 18:57, Paolo Bonzini wrote: > >> The simplify part: do not touch pi_desc.nv, we can set it when the >> VCPU is first created. Likewise, pi_desc.sn is only handled by >> vmx_vcpu_pi_load, do not touch it in __pi_post_block. >> >>

Re: [PATCH 3/4] KVM: VMX: simplify and fix vmx_vcpu_pi_load

On 2017/7/28 12:22, Longpeng (Mike) wrote: > > > On 2017/6/6 18:57, Paolo Bonzini wrote: > >> The simplify part: do not touch pi_desc.nv, we can set it when the >> VCPU is first created. Likewise, pi_desc.sn is only handled by >> vmx_vcpu_pi_load, do not touch it in __pi_post_block. >> >>

Re: strace-4.18 test suite oopses sparc64 4.12 and 4.13-rc kernels

From: Mikael Pettersson Date: Thu, 27 Jul 2017 21:45:25 +0200 > Attempting to build strace-4.18 as sparcv9 code and run its test suite > on a sparc64 machine (Sun Blade 2500 w/ 2 x USIIIi in my case) fails > reliably in three test cases (sched.gen, sched_xetattr.gen, and

Re: strace-4.18 test suite oopses sparc64 4.12 and 4.13-rc kernels

From: Mikael Pettersson Date: Thu, 27 Jul 2017 21:45:25 +0200 > Attempting to build strace-4.18 as sparcv9 code and run its test suite > on a sparc64 machine (Sun Blade 2500 w/ 2 x USIIIi in my case) fails > reliably in three test cases (sched.gen, sched_xetattr.gen, and poll) > because two test

Re: linux-next: Signed-off-by missing for commit in the renesas tree

Hi Simon, On Fri, Jul 28, 2017 at 09:21:08AM +1000, Stephen Rothwell wrote: > Hi Simon, > > Commit > > bb003371172f ("arm: dts: genmai: Add RIIC2 pin group") > > is missing a Signed-off-by from its committer. I do see my SOB in the patch I've sent. Any chance it has been dropped while applying

Re: linux-next: Signed-off-by missing for commit in the renesas tree

Hi Simon, On Fri, Jul 28, 2017 at 09:21:08AM +1000, Stephen Rothwell wrote: > Hi Simon, > > Commit > > bb003371172f ("arm: dts: genmai: Add RIIC2 pin group") > > is missing a Signed-off-by from its committer. I do see my SOB in the patch I've sent. Any chance it has been dropped while applying

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

> > On 07/27/2017 01:47 PM, Oliver Hartkopp wrote: > > On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote: > >> > > > >> I'm fine with switching to using bitrate instead of speed. Kurk was > >> originally the one that suggested to use the term arbitration and data > >> since thats how the spec

Re: [PATCH v2 2/4] can: fixed-transceiver: Add documentation for CAN fixed transceiver bindings

> > On 07/27/2017 01:47 PM, Oliver Hartkopp wrote: > > On 07/26/2017 08:29 PM, Franklin S Cooper Jr wrote: > >> > > > >> I'm fine with switching to using bitrate instead of speed. Kurk was > >> originally the one that suggested to use the term arbitration and data > >> since thats how the spec

Re: [PATCH v3/resubmit 1/3] staging: gs_fpgaboot: add buffer overflow checks

On Wed, Jul 26, 2017 at 09:13:57PM -0400, Jacob von Chorus wrote: > Four fields in struct fpgaimage are char arrays of length MAX_STR (256). > The amount of data read into these buffers is controlled by a length > field in the bitstream file read from userspace. If a corrupt or > malicious

Re: [PATCH v3/resubmit 1/3] staging: gs_fpgaboot: add buffer overflow checks

On Wed, Jul 26, 2017 at 09:13:57PM -0400, Jacob von Chorus wrote: > Four fields in struct fpgaimage are char arrays of length MAX_STR (256). > The amount of data read into these buffers is controlled by a length > field in the bitstream file read from userspace. If a corrupt or > malicious

Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

On Thu, Jul 27, 2017 at 05:27:32PM +0300, Gilad Ben-Yossef wrote: > From: Suniel Mahesh > > It is recommended to use managed function devm_kzalloc, which > simplifies driver cleanup paths and driver code. > This patch does the following: > (a) replace kzalloc with

Re: [PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

On Thu, Jul 27, 2017 at 05:27:32PM +0300, Gilad Ben-Yossef wrote: > From: Suniel Mahesh > > It is recommended to use managed function devm_kzalloc, which > simplifies driver cleanup paths and driver code. > This patch does the following: > (a) replace kzalloc with devm_kzalloc. > (b) drop

Re: [PATCH 0/4] staging: ccree: coding style clean ups

On Thu, Jul 27, 2017 at 01:43:14PM +0300, Gilad Ben-Yossef wrote: > Misc. coding style fixes for ccree driver. > > These are the missing patches that failed to apply two weeks ago, > rebased onto latest staging-next. > > By the way, I still do not understand why they failed to apply, > as they

Re: [PATCH 0/4] staging: ccree: coding style clean ups

On Thu, Jul 27, 2017 at 01:43:14PM +0300, Gilad Ben-Yossef wrote: > Misc. coding style fixes for ccree driver. > > These are the missing patches that failed to apply two weeks ago, > rebased onto latest staging-next. > > By the way, I still do not understand why they failed to apply, > as they

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

On Mon, Jul 24, 2017 at 10:08:37AM +0300, Dan Carpenter wrote: > I don't understand why greybus has to be special instead of the same as > everything else. Who cares about this stuff really? Just do whatever > is easiest and most common. It's not special, and --strict should apply here as long

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

On Mon, Jul 24, 2017 at 10:08:37AM +0300, Dan Carpenter wrote: > I don't understand why greybus has to be special instead of the same as > everything else. Who cares about this stuff really? Just do whatever > is easiest and most common. It's not special, and --strict should apply here as long

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > Alignment should match with open parenthesis. > This fixes the coding style issue. > > Signed-off-by: Shreeya Patel > --- > drivers/staging/greybus/tools/loopback_test.c | 35 >

Re: [PATCH] Staging: greybus: Match alignment with open parenthesis.

On Sun, Jul 23, 2017 at 02:09:57PM +0530, Shreeya Patel wrote: > Alignment should match with open parenthesis. > This fixes the coding style issue. > > Signed-off-by: Shreeya Patel > --- > drivers/staging/greybus/tools/loopback_test.c | 35 > --- > 1 file changed, 16

Re: [PATCH V3 2/9] cpufreq: Use transition_delay_us for legacy governors as well

On 24-07-17, 18:17, Peter Zijlstra wrote: > On Wed, Jul 19, 2017 at 03:42:42PM +0530, Viresh Kumar wrote: > > The policy->transition_delay_us field is used only by the schedutil > > governor currently, and this field describes how fast the driver wants > > the cpufreq governor to change CPUs

Re: [PATCH V3 2/9] cpufreq: Use transition_delay_us for legacy governors as well

On 24-07-17, 18:17, Peter Zijlstra wrote: > On Wed, Jul 19, 2017 at 03:42:42PM +0530, Viresh Kumar wrote: > > The policy->transition_delay_us field is used only by the schedutil > > governor currently, and this field describes how fast the driver wants > > the cpufreq governor to change CPUs

Re: Possible race in hysdn.ko

Hello Anton, first of all, this code was developed by other people and I never managed to get one of these cards - so I do not know so much about this driver at all. Unfortunately the firm behind hysdn do not longer exist and was taken over by Hermstedt AG years ago and even Hermstedt AG is not

Re: Possible race in hysdn.ko

Hello Anton, first of all, this code was developed by other people and I never managed to get one of these cards - so I do not know so much about this driver at all. Unfortunately the firm behind hysdn do not longer exist and was taken over by Hermstedt AG years ago and even Hermstedt AG is not

Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx

Hi, On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: The s3c_i2sv2_probe() only enabled iis clock. Missing prepare isn't probably fatal, because for SoC clocks this is usually no-op, but for correctness this clock should be prepared. Signed-off-by: Krzysztof Kozlowski

Re: [RFT v2 2/3] ASoC: samsung: Add missing prepare for iis clock of s3c24xx

Hi, On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: The s3c_i2sv2_probe() only enabled iis clock. Missing prepare isn't probably fatal, because for SoC clocks this is usually no-op, but for correctness this clock should be prepared. Signed-off-by: Krzysztof Kozlowski ---

Re: [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework

On Thu, Jul 27, 2017 at 11:44:32PM +, Salil Mehta wrote: > Hi Leon > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > > Sent: Sunday, July 23, 2017 2:16 PM > > To: Salil Mehta > > Cc:

Re: [PATCH V4 net-next 2/8] net: hns3: Add support of the HNAE3 framework

On Thu, Jul 27, 2017 at 11:44:32PM +, Salil Mehta wrote: > Hi Leon > > > -Original Message- > > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > ow...@vger.kernel.org] On Behalf Of Leon Romanovsky > > Sent: Sunday, July 23, 2017 2:16 PM > > To: Salil Mehta > > Cc:

Re: [RFT v2 1/3] ASoC: samsung: Fix possible double iounmap on s3c24xx driver probe failure

On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: Commit 87b132bc0315 ("ASoC: samsung: s3c24{xx,12}-i2s: port to use generic dmaengine API") moved ioremap() call from s3c-i2s-v2.c:s3c_i2sv2_probe() to s3c2412-i2s.c:s3c2412_iis_dev_probe() and converted it to devm- resource managed

Re: [RFT v2 1/3] ASoC: samsung: Fix possible double iounmap on s3c24xx driver probe failure

On Thursday 27 July 2017 10:43 PM, Krzysztof Kozlowski wrote: Commit 87b132bc0315 ("ASoC: samsung: s3c24{xx,12}-i2s: port to use generic dmaengine API") moved ioremap() call from s3c-i2s-v2.c:s3c_i2sv2_probe() to s3c2412-i2s.c:s3c2412_iis_dev_probe() and converted it to devm- resource managed

Re: [PATCH V8 3/3] powernv: Add support to clear sensor groups data

On Wed, 2017-07-26 at 10:35 +0530, Shilpasri G Bhat wrote: > Adds support for clearing different sensor groups. OCC inband sensor > groups like CSM, Profiler, Job Scheduler can be cleared using this > driver. The min/max of all sensors belonging to these sensor groups > will be cleared. > Hi

Re: [PATCH V8 3/3] powernv: Add support to clear sensor groups data

On Wed, 2017-07-26 at 10:35 +0530, Shilpasri G Bhat wrote: > Adds support for clearing different sensor groups. OCC inband sensor > groups like CSM, Profiler, Job Scheduler can be cleared using this > driver. The min/max of all sensors belonging to these sensor groups > will be cleared. > Hi

Re: [PATCH] staging: unisys: visorchipset: constify attribute_group structure

On Wed, Jul 26, 2017 at 09:51:32PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. > > File size before: > text data bss dec

Re: [PATCH] staging: unisys: visorchipset: constify attribute_group structure

On Wed, Jul 26, 2017 at 09:51:32PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. > > File size before: > text data bss dec

Re: [PATCH] staging: unisys: visorbus_main: constify attribute_group structures

On Tue, Jul 25, 2017 at 06:45:52PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. > > File size before: > text data bss dec

Re: [PATCH] staging: unisys: visorbus_main: constify attribute_group structures

On Tue, Jul 25, 2017 at 06:45:52PM -0400, Amitoj Kaur Chawla wrote: > Functions working with attribute_groups provided by > work with const attribute_group. These attribute_group structures do not > change at runtime so mark them as const. > > File size before: > text data bss dec

Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks

On Thu, Jul 27, 2017 at 12:55 PM, Saravana Kannan wrote: > On 07/26/2017 08:30 PM, Viresh Kumar wrote: >> >> On 26-07-17, 14:00, Saravana Kannan wrote: >>> >>> No, the alternative is to pass it on to the CPU freq driver and let it >>> decide what it wants to do. That's the

Re: [Eas-dev] [PATCH V3 1/3] sched: cpufreq: Allow remote cpufreq callbacks

On Thu, Jul 27, 2017 at 12:55 PM, Saravana Kannan wrote: > On 07/26/2017 08:30 PM, Viresh Kumar wrote: >> >> On 26-07-17, 14:00, Saravana Kannan wrote: >>> >>> No, the alternative is to pass it on to the CPU freq driver and let it >>> decide what it wants to do. That's the whole point if having a

Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

On Friday 28 July 2017 01:18 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote: >> +new_drvdata->cc_base = devm_ioremap_resource(_dev->dev, >> + req_mem_cc_regs); >> +if (IS_ERR(new_drvdata->cc_base))

Re: [PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

On Friday 28 July 2017 01:18 AM, Dan Carpenter wrote: > On Thu, Jul 27, 2017 at 05:27:33PM +0300, Gilad Ben-Yossef wrote: >> +new_drvdata->cc_base = devm_ioremap_resource(_dev->dev, >> + req_mem_cc_regs); >> +if (IS_ERR(new_drvdata->cc_base))

Re: [PATCH 3.10] pstore: Make spinlock per zone instead of global

Hi Leo, There was no upstream commit ID here but I found it in mainline here : commit 109704492ef637956265ec2eb72ae7b3b39eb6f4 Author: Joel Fernandes Date: Thu Oct 20 00:34:00 2016 -0700 pstore: Make spinlock per zone instead of global What worries me is

Re: [PATCH 3.10] pstore: Make spinlock per zone instead of global

Hi Leo, There was no upstream commit ID here but I found it in mainline here : commit 109704492ef637956265ec2eb72ae7b3b39eb6f4 Author: Joel Fernandes Date: Thu Oct 20 00:34:00 2016 -0700 pstore: Make spinlock per zone instead of global What worries me is that some later fixes

Re: [PATCH 3/4] KVM: VMX: simplify and fix vmx_vcpu_pi_load

On 2017/6/6 18:57, Paolo Bonzini wrote: > The simplify part: do not touch pi_desc.nv, we can set it when the > VCPU is first created. Likewise, pi_desc.sn is only handled by > vmx_vcpu_pi_load, do not touch it in __pi_post_block. > > The fix part: do not check kvm_arch_has_assigned_device,

Re: [PATCH 3/4] KVM: VMX: simplify and fix vmx_vcpu_pi_load

On 2017/6/6 18:57, Paolo Bonzini wrote: > The simplify part: do not touch pi_desc.nv, we can set it when the > VCPU is first created. Likewise, pi_desc.sn is only handled by > vmx_vcpu_pi_load, do not touch it in __pi_post_block. > > The fix part: do not check kvm_arch_has_assigned_device,

Re: [PATCH V8 2/3] powernv: Add support to set power-shifting-ratio

On Wed, 2017-07-26 at 10:35 +0530, Shilpasri G Bhat wrote: > This patch adds support to set power-shifting-ratio for CPU-GPU which > is used by OCC power capping algorithm. > > Signed-off-by: Shilpasri G Bhat Hi Shilpasri, I started looking though this - a lot

Re: [PATCH V8 2/3] powernv: Add support to set power-shifting-ratio

On Wed, 2017-07-26 at 10:35 +0530, Shilpasri G Bhat wrote: > This patch adds support to set power-shifting-ratio for CPU-GPU which > is used by OCC power capping algorithm. > > Signed-off-by: Shilpasri G Bhat Hi Shilpasri, I started looking though this - a lot the comments to patch 1/3 apply

Re: [PATCH V8 1/3] powernv: powercap: Add support for powercap framework

Hi Cyril, On 07/28/2017 07:09 AM, Cyril Bur wrote: > Is there any reason that pcap_attrs needs to be contiguous? If not, I > feel like you could eliminate the entire loop below (and the last one > as well maybe) and just do the assignment of pattr_groups[].attrs[] up > there. > > In fact do you

Re: [PATCH V8 1/3] powernv: powercap: Add support for powercap framework

Hi Cyril, On 07/28/2017 07:09 AM, Cyril Bur wrote: > Is there any reason that pcap_attrs needs to be contiguous? If not, I > feel like you could eliminate the entire loop below (and the last one > as well maybe) and just do the assignment of pattr_groups[].attrs[] up > there. > > In fact do you

Re: [PATCH net-next 3/3] tap: XDP support

On Fri, Jul 28, 2017 at 11:50:45AM +0800, Jason Wang wrote: > > > On 2017年07月28日 11:46, Michael S. Tsirkin wrote: > > On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > > > + if (old_prog) > > > > > +

Re: [PATCH net-next 3/3] tap: XDP support

On Fri, Jul 28, 2017 at 11:50:45AM +0800, Jason Wang wrote: > > > On 2017年07月28日 11:46, Michael S. Tsirkin wrote: > > On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > > > + if (old_prog) > > > > > +

Re: [PATCH v8 09/13] iommu/amd: Use is_attach_deferred call-back

On 07/27/17 at 05:53pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:07PM +0800, Baoquan He wrote: > > +static bool amd_iommu_is_attach_deferred(struct iommu_domain *domain, > > +struct device *dev) > > +{ > > + struct iommu_dev_data *dev_data =

Re: [PATCH v8 09/13] iommu/amd: Use is_attach_deferred call-back

On 07/27/17 at 05:53pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:07PM +0800, Baoquan He wrote: > > +static bool amd_iommu_is_attach_deferred(struct iommu_domain *domain, > > +struct device *dev) > > +{ > > + struct iommu_dev_data *dev_data =

Re: [PATCH v8 05/13] iommu/amd: Add function copy_dev_tables()

On 07/27/17 at 05:29pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:03PM +0800, Baoquan He wrote: > > Add function copy_dev_tables to copy the old DEV table entries of the > > panicked > > Since there is only one (for now), you can name the function in > singular: copy_dev_table() or

Re: [PATCH v8 05/13] iommu/amd: Add function copy_dev_tables()

On 07/27/17 at 05:29pm, Joerg Roedel wrote: > On Fri, Jul 21, 2017 at 04:59:03PM +0800, Baoquan He wrote: > > Add function copy_dev_tables to copy the old DEV table entries of the > > panicked > > Since there is only one (for now), you can name the function in > singular: copy_dev_table() or

Fwd: trinity test fanotify cause hungtasks on kernel 4.13

hi,ALL: when we used the trinity test the fanotify interfaces, it cause many hungtasks. CONFIG_FANOTIFY_ACCESS_PERMISSIONS=y the shell is simple: 1 #!/bin/bash 2 3 while true 4 do 5 ./trinity -c fanotify_init -l off -C 2 -X > /dev/null 2>&1 & 6 sleep 1 7 ./trinity -c fanotify_mark

Fwd: trinity test fanotify cause hungtasks on kernel 4.13

hi,ALL: when we used the trinity test the fanotify interfaces, it cause many hungtasks. CONFIG_FANOTIFY_ACCESS_PERMISSIONS=y the shell is simple: 1 #!/bin/bash 2 3 while true 4 do 5 ./trinity -c fanotify_init -l off -C 2 -X > /dev/null 2>&1 & 6 sleep 1 7 ./trinity -c fanotify_mark

Re: [PATCH net-next 3/3] tap: XDP support

On Fri, 28 Jul 2017 06:46:40 +0300, Michael S. Tsirkin wrote: > On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > > + if (old_prog) > > > > + bpf_prog_put(old_prog); > > > > +

Re: [PATCH net-next 3/3] tap: XDP support

On Fri, 28 Jul 2017 06:46:40 +0300, Michael S. Tsirkin wrote: > On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > > + if (old_prog) > > > > + bpf_prog_put(old_prog); > > > > +

Re: [PATCH net-next 3/3] tap: XDP support

On 2017年07月28日 11:46, Michael S. Tsirkin wrote: On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: + old_prog = rtnl_dereference(tun->xdp_prog); + if (old_prog) + bpf_prog_put(old_prog); + rcu_assign_pointer(tun->xdp_prog, prog); Is this OK? Could

Re: [PATCH net-next 3/3] tap: XDP support

On 2017年07月28日 11:46, Michael S. Tsirkin wrote: On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: + old_prog = rtnl_dereference(tun->xdp_prog); + if (old_prog) + bpf_prog_put(old_prog); + rcu_assign_pointer(tun->xdp_prog, prog); Is this OK? Could

Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

On Fri, Jul 28, 2017 at 8:43 AM, Vinod Koul wrote: > On Thu, Jul 27, 2017 at 09:42:33AM +0530, Anup Patel wrote: >> On Wed, Jul 26, 2017 at 10:39 PM, Vinod Koul wrote: >> > On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote: > >> >>

Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

On Fri, Jul 28, 2017 at 8:43 AM, Vinod Koul wrote: > On Thu, Jul 27, 2017 at 09:42:33AM +0530, Anup Patel wrote: >> On Wed, Jul 26, 2017 at 10:39 PM, Vinod Koul wrote: >> > On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote: > >> >> drivers/dma/bcm-sba-raid.c | 439 >> >>

Re: [PATCH net-next 3/3] tap: XDP support

On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > + if (old_prog) > > > + bpf_prog_put(old_prog); > > > + rcu_assign_pointer(tun->xdp_prog, prog); > > Is this OK? Could this lead to the program getting freed and then > >

Re: [PATCH net-next 3/3] tap: XDP support

On Fri, Jul 28, 2017 at 11:28:54AM +0800, Jason Wang wrote: > > > + old_prog = rtnl_dereference(tun->xdp_prog); > > > + if (old_prog) > > > + bpf_prog_put(old_prog); > > > + rcu_assign_pointer(tun->xdp_prog, prog); > > Is this OK? Could this lead to the program getting freed and then > >

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

On Thu, Jul 27, 2017 at 12:21 AM, Juri Lelli wrote: [..] >> > >> > But even without that, if you see the routine >> > init_entity_runnable_average() in fair.c, the new tasks are >> > initialized in a way that they are seen as heavy tasks. And so even >> > for the first time

Re: [Eas-dev] [PATCH V4 0/3] sched: cpufreq: Allow remote callbacks

On Thu, Jul 27, 2017 at 12:21 AM, Juri Lelli wrote: [..] >> > >> > But even without that, if you see the routine >> > init_entity_runnable_average() in fair.c, the new tasks are >> > initialized in a way that they are seen as heavy tasks. And so even >> > for the first time they run, freq should

Re: [PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests

On Fri, Jul 28, 2017 at 8:45 AM, Vinod Koul wrote: > On Thu, Jul 27, 2017 at 10:25:25AM +0530, Anup Patel wrote: >> On Wed, Jul 26, 2017 at 10:40 PM, Vinod Koul wrote: >> > On Wed, Jul 26, 2017 at 11:06:40AM +0530, Anup Patel wrote: >> >> We should

Re: [PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests

On Fri, Jul 28, 2017 at 8:45 AM, Vinod Koul wrote: > On Thu, Jul 27, 2017 at 10:25:25AM +0530, Anup Patel wrote: >> On Wed, Jul 26, 2017 at 10:40 PM, Vinod Koul wrote: >> > On Wed, Jul 26, 2017 at 11:06:40AM +0530, Anup Patel wrote: >> >> We should peek mbox channels when we are left with no

Re: [Eas-dev] [PATCH V4 1/3] sched: cpufreq: Allow remote cpufreq callbacks

On Thu, Jul 27, 2017 at 12:14 AM, Viresh Kumar wrote: > On 26-07-17, 23:13, Joel Fernandes (Google) wrote: >> On Wed, Jul 26, 2017 at 10:50 PM, Viresh Kumar >> wrote: >> > On 26-07-17, 22:34, Joel Fernandes (Google) wrote: >> >> On Wed, Jul 26,

Re: [Eas-dev] [PATCH V4 1/3] sched: cpufreq: Allow remote cpufreq callbacks

On Thu, Jul 27, 2017 at 12:14 AM, Viresh Kumar wrote: > On 26-07-17, 23:13, Joel Fernandes (Google) wrote: >> On Wed, Jul 26, 2017 at 10:50 PM, Viresh Kumar >> wrote: >> > On 26-07-17, 22:34, Joel Fernandes (Google) wrote: >> >> On Wed, Jul 26, 2017 at 2:22 AM, Viresh Kumar >> >> wrote: >> >>

Re: [PATCH net-next 3/3] tap: XDP support

On 2017年07月28日 11:13, Jakub Kicinski wrote: On Thu, 27 Jul 2017 17:25:33 +0800, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two parts: - fast path: small and no gso packet. We try to do XDP at page level before build_skb(). For XDP_TX,

Re: [PATCH net-next 3/3] tap: XDP support

On 2017年07月28日 11:13, Jakub Kicinski wrote: On Thu, 27 Jul 2017 17:25:33 +0800, Jason Wang wrote: This patch tries to implement XDP for tun. The implementation was split into two parts: - fast path: small and no gso packet. We try to do XDP at page level before build_skb(). For XDP_TX,

Re: [PATCH v2] net: inet: diag: expose sockets cgroup classid

On Thu, 27 Jul 2017 18:11:32 +, Levin, Alexander (Sasha Levin) wrote: > This is useful for directly looking up a task based on class id rather than > having to scan through all open file descriptors. > > Signed-off-by: Sasha Levin > --- > > Changes in V2: > -

Re: [PATCH v2] net: inet: diag: expose sockets cgroup classid

On Thu, 27 Jul 2017 18:11:32 +, Levin, Alexander (Sasha Levin) wrote: > This is useful for directly looking up a task based on class id rather than > having to scan through all open file descriptors. > > Signed-off-by: Sasha Levin > --- > > Changes in V2: > - Addressed comments from Cong

Re: [PATCH tip/core/rcu 07/15] rcu: Add event tracing to ->gp_tasks update at GP start

On Thu, Jul 27, 2017 at 09:38:10PM -0400, Steven Rostedt wrote: > On Mon, 24 Jul 2017 14:44:36 -0700 > "Paul E. McKenney" wrote: > > > There is currently event tracing to track when a task is preempted > > within a preemptible RCU read-side critical section, and also

Re: [PATCH tip/core/rcu 07/15] rcu: Add event tracing to ->gp_tasks update at GP start

On Thu, Jul 27, 2017 at 09:38:10PM -0400, Steven Rostedt wrote: > On Mon, 24 Jul 2017 14:44:36 -0700 > "Paul E. McKenney" wrote: > > > There is currently event tracing to track when a task is preempted > > within a preemptible RCU read-side critical section, and also when that > > task

Re: [PATCH net-next 3/3] tap: XDP support

On Thu, 27 Jul 2017 17:25:33 +0800, Jason Wang wrote: > This patch tries to implement XDP for tun. The implementation was > split into two parts: > > - fast path: small and no gso packet. We try to do XDP at page level > before build_skb(). For XDP_TX, since creating/destroying queues > were

Re: [PATCH net-next 3/3] tap: XDP support

On Thu, 27 Jul 2017 17:25:33 +0800, Jason Wang wrote: > This patch tries to implement XDP for tun. The implementation was > split into two parts: > > - fast path: small and no gso packet. We try to do XDP at page level > before build_skb(). For XDP_TX, since creating/destroying queues > were

Re: [PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests

On Thu, Jul 27, 2017 at 10:25:25AM +0530, Anup Patel wrote: > On Wed, Jul 26, 2017 at 10:40 PM, Vinod Koul wrote: > > On Wed, Jul 26, 2017 at 11:06:40AM +0530, Anup Patel wrote: > >> We should peek mbox channels when we are left with no free > >> sba_requests in

Re: [PATCH Y.A. RESEND] MAINTAINERS: fix alpha. ordering

On Thu, 2017-07-27 at 19:43 -0700, Linus Torvalds wrote: > On Thu, Jul 27, 2017 at 5:30 PM, Joe Perches wrote: > > > > Maybe add a reordering of the patterns so that each pattern list > > is in a specific order too > > I don't think this is wrong per se, but I'm not sure I

Re: [PATCH 2/6] dma: bcm-sba-raid: Peek mbox when we are left with no free requests

On Thu, Jul 27, 2017 at 10:25:25AM +0530, Anup Patel wrote: > On Wed, Jul 26, 2017 at 10:40 PM, Vinod Koul wrote: > > On Wed, Jul 26, 2017 at 11:06:40AM +0530, Anup Patel wrote: > >> We should peek mbox channels when we are left with no free > >> sba_requests in sba_alloc_request() > > > > and

Re: [PATCH Y.A. RESEND] MAINTAINERS: fix alpha. ordering

On Thu, 2017-07-27 at 19:43 -0700, Linus Torvalds wrote: > On Thu, Jul 27, 2017 at 5:30 PM, Joe Perches wrote: > > > > Maybe add a reordering of the patterns so that each pattern list > > is in a specific order too > > I don't think this is wrong per se, but I'm not sure I want to get > into

Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

On Thu, Jul 27, 2017 at 09:42:33AM +0530, Anup Patel wrote: > On Wed, Jul 26, 2017 at 10:39 PM, Vinod Koul wrote: > > On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote: > >> drivers/dma/bcm-sba-raid.c | 439 > >> +++-- > >>

Re: [PATCH 1/6] dma: bcm-sba-raid: Improve memory allocation in SBA RAID driver

On Thu, Jul 27, 2017 at 09:42:33AM +0530, Anup Patel wrote: > On Wed, Jul 26, 2017 at 10:39 PM, Vinod Koul wrote: > > On Wed, Jul 26, 2017 at 11:06:39AM +0530, Anup Patel wrote: > >> drivers/dma/bcm-sba-raid.c | 439 > >> +++-- > >> 1 file changed, 226

  1   2   3   4   5   6   7   8   9   10   >