Re: [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type

2018-05-15 Thread Tony Lindgren
* Keerthy [180509 04:03]: > > > On Tuesday 08 May 2018 07:46 PM, Tony Lindgren wrote: > > * Peter Ujfalusi [180508 13:22]: > >> Hi, > >> > >> While based on the datasheet of tps65218 the INT is low active, the GIC_SPI > >> does not support anythin but

Re: [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type

2018-05-15 Thread Tony Lindgren
* Keerthy [180509 04:03]: > > > On Tuesday 08 May 2018 07:46 PM, Tony Lindgren wrote: > > * Peter Ujfalusi [180508 13:22]: > >> Hi, > >> > >> While based on the datasheet of tps65218 the INT is low active, the GIC_SPI > >> does not support anythin but IRQ_TYPE_LEVEL_HIGH or

Re: [tip:locking/core] locking/atomics: Simplify the op definitions in atomic.h some more

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 06:53:08PM +0100, Mark Rutland wrote: > On Tue, May 15, 2018 at 07:10:21PM +0200, Peter Zijlstra wrote: > > On Tue, May 15, 2018 at 04:43:33PM +0100, Mark Rutland wrote: > > > I *think* the table can encode enough info to generate atomic-long.h, > > > atomic-instrumented.h,

Re: [tip:locking/core] locking/atomics: Simplify the op definitions in atomic.h some more

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 06:53:08PM +0100, Mark Rutland wrote: > On Tue, May 15, 2018 at 07:10:21PM +0200, Peter Zijlstra wrote: > > On Tue, May 15, 2018 at 04:43:33PM +0100, Mark Rutland wrote: > > > I *think* the table can encode enough info to generate atomic-long.h, > > > atomic-instrumented.h,

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

2018-05-15 Thread Håkon Bugge
> On 15 May 2018, at 02:38, Hal Rosenstock wrote: > > On 5/14/2018 5:02 PM, Jason Gunthorpe wrote: >> On Thu, May 10, 2018 at 05:16:28PM +0200, Håkon Bugge wrote: >> >>> We are talking about two things here. The PKey in the BTH and the >>> PKey in the CM REQ payload.

Re: [PATCH IB/core 2/2] IB/cm: Send authentic pkey in REQ msg and check eligibility of the pkeys

2018-05-15 Thread Håkon Bugge
> On 15 May 2018, at 02:38, Hal Rosenstock wrote: > > On 5/14/2018 5:02 PM, Jason Gunthorpe wrote: >> On Thu, May 10, 2018 at 05:16:28PM +0200, Håkon Bugge wrote: >> >>> We are talking about two things here. The PKey in the BTH and the >>> PKey in the CM REQ payload. They differ. >>> >>> I

[GIT PULL rcu/next] RCU commits for 4.18

2018-05-15 Thread Paul E. McKenney
Hello, Ingo! This pull request contains the following changes: 1. Updates to the handling of expedited grace periods, perhaps most notably parallelizing their initialization. Other changes include fixes from Boqun Feng.

[GIT PULL rcu/next] RCU commits for 4.18

2018-05-15 Thread Paul E. McKenney
Hello, Ingo! This pull request contains the following changes: 1. Updates to the handling of expedited grace periods, perhaps most notably parallelizing their initialization. Other changes include fixes from Boqun Feng.

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Amir Goldstein
On Tue, May 15, 2018 at 9:02 PM, Waiman Long wrote: > On 05/15/2018 01:58 PM, Peter Zijlstra wrote: >> On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: >>> +/* >>> + * Owner value to indicate the rwsem's owner is not currently known. >>> + */ >>> +#define

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Amir Goldstein
On Tue, May 15, 2018 at 9:02 PM, Waiman Long wrote: > On 05/15/2018 01:58 PM, Peter Zijlstra wrote: >> On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: >>> +/* >>> + * Owner value to indicate the rwsem's owner is not currently known. >>> + */ >>> +#define RWSEM_OWNER_UNKNOWN ((struct

[PATCH v1] x86/mtrr: Convert to use strncpy_from_user() helper

2018-05-15 Thread Andy Shevchenko
Replace the open coded string fetch from the user. Signed-off-by: Andy Shevchenko --- arch/x86/kernel/cpu/mtrr/if.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/cpu/mtrr/if.c b/arch/x86/kernel/cpu/mtrr/if.c

[PATCH v1] x86/mtrr: Convert to use strncpy_from_user() helper

2018-05-15 Thread Andy Shevchenko
Replace the open coded string fetch from the user. Signed-off-by: Andy Shevchenko --- arch/x86/kernel/cpu/mtrr/if.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/cpu/mtrr/if.c b/arch/x86/kernel/cpu/mtrr/if.c index e4adad68b5e5..3cbae60663fa

[PATCH 2/6] swiotlb: do not panic on mapping failures

2018-05-15 Thread Christoph Hellwig
We now have error handling in map_single/map_page callers (most of them anyway). As swiotlb_tbl_map_single already prints a useful warning when running out of swiotlb pool swace we can also remove swiotlb_full entirely as it serves no purpose now. Signed-off-by: Christoph Hellwig

[PATCH 2/6] swiotlb: do not panic on mapping failures

2018-05-15 Thread Christoph Hellwig
We now have error handling in map_single/map_page callers (most of them anyway). As swiotlb_tbl_map_single already prints a useful warning when running out of swiotlb pool swace we can also remove swiotlb_full entirely as it serves no purpose now. Signed-off-by: Christoph Hellwig ---

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 11:02:19AM -0700, Matthew Wilcox wrote: > On Tue, May 15, 2018 at 07:58:05PM +0200, Peter Zijlstra wrote: > > On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: > > > +/* > > > + * Owner value to indicate the rwsem's owner is not currently known. > > > + */ > > >

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 11:02:19AM -0700, Matthew Wilcox wrote: > On Tue, May 15, 2018 at 07:58:05PM +0200, Peter Zijlstra wrote: > > On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: > > > +/* > > > + * Owner value to indicate the rwsem's owner is not currently known. > > > + */ > > >

[PATCH 3/6] swiotlb: merge swiotlb_unmap_page and unmap_single

2018-05-15 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- lib/swiotlb.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 4d36340bc4f9..2ebbc7204061 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -814,9 +814,9 @@ dma_addr_t

[PATCH 3/6] swiotlb: merge swiotlb_unmap_page and unmap_single

2018-05-15 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- lib/swiotlb.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 4d36340bc4f9..2ebbc7204061 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -814,9 +814,9 @@ dma_addr_t

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 02:02:00PM -0400, Waiman Long wrote: > On 05/15/2018 01:58 PM, Peter Zijlstra wrote: > > On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: > >> +/* > >> + * Owner value to indicate the rwsem's owner is not currently known. > >> + */ > >> +#define

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 02:02:00PM -0400, Waiman Long wrote: > On 05/15/2018 01:58 PM, Peter Zijlstra wrote: > > On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: > >> +/* > >> + * Owner value to indicate the rwsem's owner is not currently known. > >> + */ > >> +#define

[PATCH 6/6] swiotlb: respect DMA_ATTR_NO_WARN in __swiotlb_map_page

2018-05-15 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- lib/swiotlb.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 5becc2fc680a..5cf88e090cb6 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -608,8 +608,11 @@

Re: [PATCH] clk: qcom: Add some missing gcc clks for msm8996

2018-05-15 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-04-17 17:09:26) > @@ -3350,6 +3522,7 @@ static struct clk_regmap *gcc_msm8996_clocks[] = { > [GCC_AGGRE0_CNOC_AHB_CLK] = _aggre0_cnoc_ahb_clk.clkr, > [GCC_SMMU_AGGRE0_AXI_CLK] = _smmu_aggre0_axi_clk.clkr, > [GCC_SMMU_AGGRE0_AHB_CLK] =

[PATCH 6/6] swiotlb: respect DMA_ATTR_NO_WARN in __swiotlb_map_page

2018-05-15 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- lib/swiotlb.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 5becc2fc680a..5cf88e090cb6 100644 --- a/lib/swiotlb.c +++ b/lib/swiotlb.c @@ -608,8 +608,11 @@ __swiotlb_map_page(struct

Re: [PATCH] clk: qcom: Add some missing gcc clks for msm8996

2018-05-15 Thread Stephen Boyd
Quoting Bjorn Andersson (2018-04-17 17:09:26) > @@ -3350,6 +3522,7 @@ static struct clk_regmap *gcc_msm8996_clocks[] = { > [GCC_AGGRE0_CNOC_AHB_CLK] = _aggre0_cnoc_ahb_clk.clkr, > [GCC_SMMU_AGGRE0_AXI_CLK] = _smmu_aggre0_axi_clk.clkr, > [GCC_SMMU_AGGRE0_AHB_CLK] =

[PATCH 5/6] swiotlb: share more code between map_page and map_sg

2018-05-15 Thread Christoph Hellwig
Refactor all the common code into what previously was map_single, which is now renamed to __swiotlb_map_page. This also improves the map_sg error handling and diagnostics to match the map_page ones. Signed-off-by: Christoph Hellwig --- lib/swiotlb.c | 114

[PATCH 5/6] swiotlb: share more code between map_page and map_sg

2018-05-15 Thread Christoph Hellwig
Refactor all the common code into what previously was map_single, which is now renamed to __swiotlb_map_page. This also improves the map_sg error handling and diagnostics to match the map_page ones. Signed-off-by: Christoph Hellwig --- lib/swiotlb.c | 114

[PATCH 4/6] swiotlb: mark is_swiotlb_buffer static

2018-05-15 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/linux/swiotlb.h | 1 - lib/swiotlb.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 965be92c33b5..7ef541ce8f34 100644 --- a/include/linux/swiotlb.h

[PATCH 4/6] swiotlb: mark is_swiotlb_buffer static

2018-05-15 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig --- include/linux/swiotlb.h | 1 - lib/swiotlb.c | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/include/linux/swiotlb.h b/include/linux/swiotlb.h index 965be92c33b5..7ef541ce8f34 100644 --- a/include/linux/swiotlb.h +++

[PATCH 1/6] swiotlb: remove a pointless comment

2018-05-15 Thread Christoph Hellwig
This comments describes an aspect of the map_sg interface that isn't even exploited by swiotlb. Signed-off-by: Christoph Hellwig --- lib/swiotlb.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 16ace0e25d52..721f93677eee 100644 ---

swiotlb cleanup

2018-05-15 Thread Christoph Hellwig
Hi Konrad, below are a few swiotlb patches. Mostly just cleanups, but the removal of the panic option is an actual change in (rarely used) functionality.

swiotlb cleanup

2018-05-15 Thread Christoph Hellwig
Hi Konrad, below are a few swiotlb patches. Mostly just cleanups, but the removal of the panic option is an actual change in (rarely used) functionality.

[PATCH 1/6] swiotlb: remove a pointless comment

2018-05-15 Thread Christoph Hellwig
This comments describes an aspect of the map_sg interface that isn't even exploited by swiotlb. Signed-off-by: Christoph Hellwig --- lib/swiotlb.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/swiotlb.c b/lib/swiotlb.c index 16ace0e25d52..721f93677eee 100644 --- a/lib/swiotlb.c

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-15 Thread Lina Iyer
On Tue, May 15 2018 at 10:50 -0600, Doug Anderson wrote: Hi, On Tue, May 15, 2018 at 9:23 AM, Lina Iyer wrote: On Tue, May 15 2018 at 09:52 -0600, Doug Anderson wrote: Hi, On Mon, May 14, 2018 at 12:59 PM, Lina Iyer wrote: /** @@ -77,12

Re: [PATCH v8 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-05-15 Thread Lina Iyer
On Tue, May 15 2018 at 10:50 -0600, Doug Anderson wrote: Hi, On Tue, May 15, 2018 at 9:23 AM, Lina Iyer wrote: On Tue, May 15 2018 at 09:52 -0600, Doug Anderson wrote: Hi, On Mon, May 14, 2018 at 12:59 PM, Lina Iyer wrote: /** @@ -77,12 +82,14 @@ struct rpmh_request { * @cache: the

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: > diff --git a/kernel/locking/rwsem-xadd.c b/kernel/locking/rwsem-xadd.c > index e795908..a27dbb4 100644 > --- a/kernel/locking/rwsem-xadd.c > +++ b/kernel/locking/rwsem-xadd.c > @@ -357,11 +357,8 @@ static inline bool

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: > diff --git a/kernel/locking/rwsem-xadd.c b/kernel/locking/rwsem-xadd.c > index e795908..a27dbb4 100644 > --- a/kernel/locking/rwsem-xadd.c > +++ b/kernel/locking/rwsem-xadd.c > @@ -357,11 +357,8 @@ static inline bool

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Matthew Wilcox
On Tue, May 15, 2018 at 07:58:05PM +0200, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: > > +/* > > + * Owner value to indicate the rwsem's owner is not currently known. > > + */ > > +#define RWSEM_OWNER_UNKNOWN((struct task_struct *)-1) > > It might

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Matthew Wilcox
On Tue, May 15, 2018 at 07:58:05PM +0200, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: > > +/* > > + * Owner value to indicate the rwsem's owner is not currently known. > > + */ > > +#define RWSEM_OWNER_UNKNOWN((struct task_struct *)-1) > > It might

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Waiman Long
On 05/15/2018 01:58 PM, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: >> +/* >> + * Owner value to indicate the rwsem's owner is not currently known. >> + */ >> +#define RWSEM_OWNER_UNKNOWN ((struct task_struct *)-1) > It might be nice to comment that this

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Waiman Long
On 05/15/2018 01:58 PM, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: >> +/* >> + * Owner value to indicate the rwsem's owner is not currently known. >> + */ >> +#define RWSEM_OWNER_UNKNOWN ((struct task_struct *)-1) > It might be nice to comment that this

Re: [PATCH] clk: meson: use SPDX license identifiers consistently

2018-05-15 Thread Stephen Boyd
Quoting Jerome Brunet (2018-05-15 09:42:29) > diff --git a/drivers/clk/meson/clk-audio-divider.c > b/drivers/clk/meson/clk-audio-divider.c > index f7ab5b1db342..ac0743cd0f2f 100644 > --- a/drivers/clk/meson/clk-audio-divider.c > +++ b/drivers/clk/meson/clk-audio-divider.c > @@ -1,18 +1,7 @@ > +//

Re: [PATCH] clk: meson: use SPDX license identifiers consistently

2018-05-15 Thread Stephen Boyd
Quoting Jerome Brunet (2018-05-15 09:42:29) > diff --git a/drivers/clk/meson/clk-audio-divider.c > b/drivers/clk/meson/clk-audio-divider.c > index f7ab5b1db342..ac0743cd0f2f 100644 > --- a/drivers/clk/meson/clk-audio-divider.c > +++ b/drivers/clk/meson/clk-audio-divider.c > @@ -1,18 +1,7 @@ > +//

[PATCH v2] x86/mtrr: Convert to use match_string() helper

2018-05-15 Thread Andy Shevchenko
The helper returns index of the matching string in an array. Replace the open coded array lookup. Signed-off-by: Andy Shevchenko --- - reword commit message arch/x86/kernel/cpu/mtrr/if.c | 21 ++--- 1 file changed, 10 insertions(+), 11

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: > +/* > + * Owner value to indicate the rwsem's owner is not currently known. > + */ > +#define RWSEM_OWNER_UNKNOWN ((struct task_struct *)-1) It might be nice to comment that this works and relies on having that ANON_OWNER bit set.

[PATCH v2] x86/mtrr: Convert to use match_string() helper

2018-05-15 Thread Andy Shevchenko
The helper returns index of the matching string in an array. Replace the open coded array lookup. Signed-off-by: Andy Shevchenko --- - reword commit message arch/x86/kernel/cpu/mtrr/if.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git

Re: [PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 01:38:04PM -0400, Waiman Long wrote: > +/* > + * Owner value to indicate the rwsem's owner is not currently known. > + */ > +#define RWSEM_OWNER_UNKNOWN ((struct task_struct *)-1) It might be nice to comment that this works and relies on having that ANON_OWNER bit set.

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Waiman Long
On 05/15/2018 01:55 PM, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 01:52:06PM -0400, Waiman Long wrote: >> On 05/15/2018 01:48 PM, Peter Zijlstra wrote: >>> On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Waiman Long
On 05/15/2018 01:55 PM, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 01:52:06PM -0400, Waiman Long wrote: >> On 05/15/2018 01:48 PM, Peter Zijlstra wrote: >>> On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 01:52:06PM -0400, Waiman Long wrote: > On 05/15/2018 01:48 PM, Peter Zijlstra wrote: > > On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: > >> diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c > >> index 30465a2..b7208e1 100644 > >> ---

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 01:52:06PM -0400, Waiman Long wrote: > On 05/15/2018 01:48 PM, Peter Zijlstra wrote: > > On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: > >> diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c > >> index 30465a2..b7208e1 100644 > >> ---

Re: [tip:locking/core] locking/atomics: Simplify the op definitions in atomic.h some more

2018-05-15 Thread Mark Rutland
On Tue, May 15, 2018 at 07:10:21PM +0200, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 04:43:33PM +0100, Mark Rutland wrote: > > I *think* the table can encode enough info to generate atomic-long.h, > > atomic-instrumented.h, and the atomic.h ordering fallbacks. I'll need to > > flesh out the

Re: [tip:locking/core] locking/atomics: Simplify the op definitions in atomic.h some more

2018-05-15 Thread Mark Rutland
On Tue, May 15, 2018 at 07:10:21PM +0200, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 04:43:33PM +0100, Mark Rutland wrote: > > I *think* the table can encode enough info to generate atomic-long.h, > > atomic-instrumented.h, and the atomic.h ordering fallbacks. I'll need to > > flesh out the

SCM_RIGHTS and file descriptor limits

2018-05-15 Thread Andres Freund
Hi, I'm not sure if this is a documentation omission, kernel code bug, missing understanding on my part, or all of the above. I'm looking at recvmsg()'s behaviour for AF_UNIX, where the sender has sent an fd using SCM_RIGHTS, and the receiving process has already exceeded RLIMIT_NOFILE. By my

SCM_RIGHTS and file descriptor limits

2018-05-15 Thread Andres Freund
Hi, I'm not sure if this is a documentation omission, kernel code bug, missing understanding on my part, or all of the above. I'm looking at recvmsg()'s behaviour for AF_UNIX, where the sender has sent an fd using SCM_RIGHTS, and the receiving process has already exceeded RLIMIT_NOFILE. By my

[PATCH v5] mm: don't allow deferred pages with NEED_PER_CPU_KM

2018-05-15 Thread Pavel Tatashin
It is unsafe to do virtual to physical translations before mm_init() is called if struct page is needed in order to determine the memory section number (see SECTION_IN_PAGE_FLAGS). This is because only in mm_init() we initialize struct pages for all the allocated memory when deferred struct pages

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Waiman Long
On 05/15/2018 01:48 PM, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: >> diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c >> index 30465a2..b7208e1 100644 >> --- a/kernel/locking/rwsem.c >> +++ b/kernel/locking/rwsem.c >> @@ -130,7 +130,8 @@ void

[PATCH v5] mm: don't allow deferred pages with NEED_PER_CPU_KM

2018-05-15 Thread Pavel Tatashin
It is unsafe to do virtual to physical translations before mm_init() is called if struct page is needed in order to determine the memory section number (see SECTION_IN_PAGE_FLAGS). This is because only in mm_init() we initialize struct pages for all the allocated memory when deferred struct pages

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Waiman Long
On 05/15/2018 01:48 PM, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: >> diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c >> index 30465a2..b7208e1 100644 >> --- a/kernel/locking/rwsem.c >> +++ b/kernel/locking/rwsem.c >> @@ -130,7 +130,8 @@ void

Re: linux-next: build warning after merge of the netfilter-next tree

2018-05-15 Thread Florian Westphal
Geert Uytterhoeven wrote: > On Tue, May 8, 2018 at 9:17 AM, Florian Westphal wrote: > > Stephen Rothwell wrote: > >> On Mon, 7 May 2018 10:55:19 +1000 Stephen Rothwell > >> wrote: > >> > > >> > After merging

Re: linux-next: build warning after merge of the netfilter-next tree

2018-05-15 Thread Florian Westphal
Geert Uytterhoeven wrote: > On Tue, May 8, 2018 at 9:17 AM, Florian Westphal wrote: > > Stephen Rothwell wrote: > >> On Mon, 7 May 2018 10:55:19 +1000 Stephen Rothwell > >> wrote: > >> > > >> > After merging the netfilter-next tree, today's linux-next build (x86_64 > >> > allmodconfig)

Re: [PATCH RFC v5] pidns: introduce syscall translate_pid

2018-05-15 Thread Nagarathnam Muthusamy
On 05/15/2018 10:40 AM, Nagarathnam Muthusamy wrote: On 05/15/2018 10:36 AM, Konstantin Khlebnikov wrote: On 15.05.2018 20:19, Nagarathnam Muthusamy wrote: On 04/24/2018 10:36 PM, Konstantin Khlebnikov wrote: On 23.04.2018 20:37, Nagarathnam Muthusamy wrote: On 04/05/2018 12:02 AM,

Re: [PATCH RFC v5] pidns: introduce syscall translate_pid

2018-05-15 Thread Nagarathnam Muthusamy
On 05/15/2018 10:40 AM, Nagarathnam Muthusamy wrote: On 05/15/2018 10:36 AM, Konstantin Khlebnikov wrote: On 15.05.2018 20:19, Nagarathnam Muthusamy wrote: On 04/24/2018 10:36 PM, Konstantin Khlebnikov wrote: On 23.04.2018 20:37, Nagarathnam Muthusamy wrote: On 04/05/2018 12:02 AM,

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-05-15 Thread Gustavo A. R. Silva
ectre media issues I see smatch is reporting in linux-next-20180515: drivers/media/cec/cec-pin-error-inj.c:170 cec_pin_error_inj_parse_line() warn: potential spectre issue 'pin->error_inj_args' drivers/media/dvb-core/dvb_ca_en50221.c:1479 dvb_ca_en50221_io_write() warn: potential spectre issue

Re: [PATCH 01/11] media: tm6000: fix potential Spectre variant 1

2018-05-15 Thread Gustavo A. R. Silva
. Possibly... There was an ancient bug in Smatch's function pointer handling. I just pushed a fix for it now so the warning is there on linux-next. Dan, These are all the Spectre media issues I see smatch is reporting in linux-next-20180515: drivers/media/cec/cec-pin-error-inj.c:170

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: > diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c > index 30465a2..b7208e1 100644 > --- a/kernel/locking/rwsem.c > +++ b/kernel/locking/rwsem.c > @@ -130,7 +130,8 @@ void up_read(struct rw_semaphore *sem) > void

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: > diff --git a/kernel/locking/rwsem.c b/kernel/locking/rwsem.c > index 30465a2..b7208e1 100644 > --- a/kernel/locking/rwsem.c > +++ b/kernel/locking/rwsem.c > @@ -130,7 +130,8 @@ void up_read(struct rw_semaphore *sem) > void

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Waiman Long
On 05/15/2018 01:46 PM, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: >> +#define WSEM_ANONYMOUSLY_OWNED ((struct task_struct >> *)__RWSEM_ANONYMOUSLY_OWNED) > typoed and unused.. Sorry about the typo. I know it is not used. I include it for

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Waiman Long
On 05/15/2018 01:46 PM, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: >> +#define WSEM_ANONYMOUSLY_OWNED ((struct task_struct >> *)__RWSEM_ANONYMOUSLY_OWNED) > typoed and unused.. Sorry about the typo. I know it is not used. I include it for

Re: [PATCH 5/6] udf: Simplify calls to udf_disk_stamp_to_time

2018-05-15 Thread Deepa Dinamani
On Mon, May 14, 2018 at 6:57 AM, Jan Kara wrote: > Hello, > > On Fri 11-05-18 21:59:20, Deepa Dinamani wrote: >> Subsequent patches in the series convert inode timestamps >> to use struct timespec64 instead of struct timespec as >> part of solving the y2038 problem. >> >> commit

Re: [PATCH 5/6] udf: Simplify calls to udf_disk_stamp_to_time

2018-05-15 Thread Deepa Dinamani
On Mon, May 14, 2018 at 6:57 AM, Jan Kara wrote: > Hello, > > On Fri 11-05-18 21:59:20, Deepa Dinamani wrote: >> Subsequent patches in the series convert inode timestamps >> to use struct timespec64 instead of struct timespec as >> part of solving the y2038 problem. >> >> commit fd3cfad374d4

Re: [PATCH v8 04/10] drivers: qcom: rpmh: add RPMH helper functions

2018-05-15 Thread Lina Iyer
On Fri, May 11 2018 at 14:17 -0600, Doug Anderson wrote: Hi, On Wed, May 9, 2018 at 10:01 AM, Lina Iyer wrote: +int rpmh_write(const struct device *dev, enum rpmh_state state, + const struct tcs_cmd *cmd, u32 n) +{ + DECLARE_COMPLETION_ONSTACK(compl);

Re: [PATCH v8 04/10] drivers: qcom: rpmh: add RPMH helper functions

2018-05-15 Thread Lina Iyer
On Fri, May 11 2018 at 14:17 -0600, Doug Anderson wrote: Hi, On Wed, May 9, 2018 at 10:01 AM, Lina Iyer wrote: +int rpmh_write(const struct device *dev, enum rpmh_state state, + const struct tcs_cmd *cmd, u32 n) +{ + DECLARE_COMPLETION_ONSTACK(compl); +

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: > +#define WSEM_ANONYMOUSLY_OWNED ((struct task_struct > *)__RWSEM_ANONYMOUSLY_OWNED) typoed and unused..

Re: [PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Peter Zijlstra
On Tue, May 15, 2018 at 01:38:03PM -0400, Waiman Long wrote: > +#define WSEM_ANONYMOUSLY_OWNED ((struct task_struct > *)__RWSEM_ANONYMOUSLY_OWNED) typoed and unused..

Re: [PATCH RFC v5] pidns: introduce syscall translate_pid

2018-05-15 Thread Nagarathnam Muthusamy
On 05/15/2018 10:36 AM, Konstantin Khlebnikov wrote: On 15.05.2018 20:19, Nagarathnam Muthusamy wrote: On 04/24/2018 10:36 PM, Konstantin Khlebnikov wrote: On 23.04.2018 20:37, Nagarathnam Muthusamy wrote: On 04/05/2018 12:02 AM, Konstantin Khlebnikov wrote: On 05.04.2018 01:29, Eric

Re: [PATCH RFC v5] pidns: introduce syscall translate_pid

2018-05-15 Thread Nagarathnam Muthusamy
On 05/15/2018 10:36 AM, Konstantin Khlebnikov wrote: On 15.05.2018 20:19, Nagarathnam Muthusamy wrote: On 04/24/2018 10:36 PM, Konstantin Khlebnikov wrote: On 23.04.2018 20:37, Nagarathnam Muthusamy wrote: On 04/05/2018 12:02 AM, Konstantin Khlebnikov wrote: On 05.04.2018 01:29, Eric

Re: linux-next: manual merge of the rcu tree with Linus' tree

2018-05-15 Thread Paul E. McKenney
On Mon, May 14, 2018 at 01:46:36PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rcu tree got a conflict in: > > drivers/nvme/host/core.c > > between commit: > > 12d9f07022dc ("nvme: fix use-after-free in nvme_free_ns_head") > > from Linus' tree and commit:

Re: [PATCH v2] pstore: Convert internal records to timespec64

2018-05-15 Thread Deepa Dinamani
Acked-by: Deepa Dinamani I think for 4.18, I can include it as part of my series. Thanks, -Deepa On Mon, May 14, 2018 at 3:50 PM, Kees Cook wrote: > This prepares pstore for converting the VFS layer to timespec64. > > Signed-off-by: Kees Cook

Re: linux-next: manual merge of the rcu tree with Linus' tree

2018-05-15 Thread Paul E. McKenney
On Mon, May 14, 2018 at 01:46:36PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rcu tree got a conflict in: > > drivers/nvme/host/core.c > > between commit: > > 12d9f07022dc ("nvme: fix use-after-free in nvme_free_ns_head") > > from Linus' tree and commit:

Re: [PATCH v2] pstore: Convert internal records to timespec64

2018-05-15 Thread Deepa Dinamani
Acked-by: Deepa Dinamani I think for 4.18, I can include it as part of my series. Thanks, -Deepa On Mon, May 14, 2018 at 3:50 PM, Kees Cook wrote: > This prepares pstore for converting the VFS layer to timespec64. > > Signed-off-by: Kees Cook > --- > I can carry this for v4.18 unless you'd

[PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Waiman Long
There are use cases where a rwsem can be acquired by one task, but released by another task. In thess cases, optimistic spinning may need to be disabled. One example will be the filesystem freeze/thaw code where the task that freezes the filesystem will acquire a rwsem and then un-owns it before

[PATCH v3 1/2] locking/rwsem: Add a new RWSEM_ANONYMOUSLY_OWNED flag

2018-05-15 Thread Waiman Long
There are use cases where a rwsem can be acquired by one task, but released by another task. In thess cases, optimistic spinning may need to be disabled. One example will be the filesystem freeze/thaw code where the task that freezes the filesystem will acquire a rwsem and then un-owns it before

Re: [PATCH v2] ARM: dts: exynos: Add support for audio over HDMI for Odroid X/X2/U3

2018-05-15 Thread Krzysztof Kozlowski
On Mon, May 14, 2018 at 10:01:48AM +0200, Sylwester Nawrocki wrote: > This patch switches Odroid X/X2/U3 to use dedicated Odroid audio subsystem > DT bindings instead of the simple-card in order to add support for audio > over HDMI. > > Signed-off-by: Sylwester Nawrocki >

Re: [PATCH v2] ARM: dts: exynos: Add support for audio over HDMI for Odroid X/X2/U3

2018-05-15 Thread Krzysztof Kozlowski
On Mon, May 14, 2018 at 10:01:48AM +0200, Sylwester Nawrocki wrote: > This patch switches Odroid X/X2/U3 to use dedicated Odroid audio subsystem > DT bindings instead of the simple-card in order to add support for audio > over HDMI. > > Signed-off-by: Sylwester Nawrocki > --- >

[PATCH v3 0/2] locking/rwsem: Fix DEBUG_RWSEM warning from thaw_super()

2018-05-15 Thread Waiman Long
v3: - Modify patch 1 to not expose any new rwsem owner related function. - Modify patch 2 to make percpu_rwsem_release() and percpu_rwsem_acquire() set the owner field directly, if applicable. This patchset aims to fix the DEBUG_RWSEM warning in the filesystem freezing/thawing code. A new

[PATCH v3 0/2] locking/rwsem: Fix DEBUG_RWSEM warning from thaw_super()

2018-05-15 Thread Waiman Long
v3: - Modify patch 1 to not expose any new rwsem owner related function. - Modify patch 2 to make percpu_rwsem_release() and percpu_rwsem_acquire() set the owner field directly, if applicable. This patchset aims to fix the DEBUG_RWSEM warning in the filesystem freezing/thawing code. A new

[PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Waiman Long
The filesystem freezing code needs to transfer ownership of a rwsem embedded in a percpu-rwsem from the task that does the freezing to another one that does the thawing by calling percpu_rwsem_release() after freezing and percpu_rwsem_acquire() before thawing. However, the new rwsem debug code

[PATCH v3 2/2] locking/percpu-rwsem: Annotate rwsem ownership transfer by setting RWSEM_OWNER_UNKNOWN

2018-05-15 Thread Waiman Long
The filesystem freezing code needs to transfer ownership of a rwsem embedded in a percpu-rwsem from the task that does the freezing to another one that does the thawing by calling percpu_rwsem_release() after freezing and percpu_rwsem_acquire() before thawing. However, the new rwsem debug code

Re: [PATCH RFC v5] pidns: introduce syscall translate_pid

2018-05-15 Thread Konstantin Khlebnikov
On 15.05.2018 20:19, Nagarathnam Muthusamy wrote: On 04/24/2018 10:36 PM, Konstantin Khlebnikov wrote: On 23.04.2018 20:37, Nagarathnam Muthusamy wrote: On 04/05/2018 12:02 AM, Konstantin Khlebnikov wrote: On 05.04.2018 01:29, Eric W. Biederman wrote: Nagarathnam Muthusamy

Re: [PATCH RFC v5] pidns: introduce syscall translate_pid

2018-05-15 Thread Konstantin Khlebnikov
On 15.05.2018 20:19, Nagarathnam Muthusamy wrote: On 04/24/2018 10:36 PM, Konstantin Khlebnikov wrote: On 23.04.2018 20:37, Nagarathnam Muthusamy wrote: On 04/05/2018 12:02 AM, Konstantin Khlebnikov wrote: On 05.04.2018 01:29, Eric W. Biederman wrote: Nagarathnam Muthusamy writes:

Re: [PATCH] input: fix coding style issues in input.c

2018-05-15 Thread Dmitry Torokhov
On Sat, May 12, 2018 at 02:01:20AM +0300, Nick Simonov wrote: > Wed, May 09, 2018 at 05:33:13PM -0700, Dmitry Torokhov wrote: > > Hi NIck, > > > > On Wed, May 09, 2018 at 05:07:14PM +0300, Nick Simonov wrote: > > > This is a patch to the input.c file that fixes > > > up warning found by

Re: [PATCH] input: fix coding style issues in input.c

2018-05-15 Thread Dmitry Torokhov
On Sat, May 12, 2018 at 02:01:20AM +0300, Nick Simonov wrote: > Wed, May 09, 2018 at 05:33:13PM -0700, Dmitry Torokhov wrote: > > Hi NIck, > > > > On Wed, May 09, 2018 at 05:07:14PM +0300, Nick Simonov wrote: > > > This is a patch to the input.c file that fixes > > > up warning found by

[PATCH v3] device property: Get rid of union aliasing

2018-05-15 Thread Andy Shevchenko
The commit 318a19718261 ("device property: refactor built-in properties support") went way too far and brought a union aliasing. Partially revert it here to get rid of union aliasing. Note, all Apple properties are considered as u8 arrays. To get a value of any of them the caller must use

[PATCH v3] device property: Get rid of union aliasing

2018-05-15 Thread Andy Shevchenko
The commit 318a19718261 ("device property: refactor built-in properties support") went way too far and brought a union aliasing. Partially revert it here to get rid of union aliasing. Note, all Apple properties are considered as u8 arrays. To get a value of any of them the caller must use

Re: [PATCH 09/15] x86/split_lock: Explicitly enable or disable #AC for split locked accesses

2018-05-15 Thread Fenghua Yu
On Tue, May 15, 2018 at 09:15:16AM -0700, Dave Hansen wrote: > On 05/14/2018 11:52 AM, Fenghua Yu wrote: > > By default, we don't set or clear the bit 29 in TEST_CTL MSR 0x33 and > > the bit is inherited from BIOS/hardware setting. > > > > The kernel parameter "split_lock_ac=on/off" explicitly

Re: [PATCH 09/15] x86/split_lock: Explicitly enable or disable #AC for split locked accesses

2018-05-15 Thread Fenghua Yu
On Tue, May 15, 2018 at 09:15:16AM -0700, Dave Hansen wrote: > On 05/14/2018 11:52 AM, Fenghua Yu wrote: > > By default, we don't set or clear the bit 29 in TEST_CTL MSR 0x33 and > > the bit is inherited from BIOS/hardware setting. > > > > The kernel parameter "split_lock_ac=on/off" explicitly

Re: [PATCH v4 0/6] clocksource: rework Atmel TCB timer driver

2018-05-15 Thread Sebastian Andrzej Siewior
On 2018-05-02 20:10:46 [+0200], Alexandre Belloni wrote: > > > As said below, this is solving multiple issues, including the one for > > > SoCs that don't have the PIT. > > will the PIT be removed? Where it needs the PIT? > > > > The last patch is unselecting the PIT driver so by default it is

Re: [PATCH v4 0/6] clocksource: rework Atmel TCB timer driver

2018-05-15 Thread Sebastian Andrzej Siewior
On 2018-05-02 20:10:46 [+0200], Alexandre Belloni wrote: > > > As said below, this is solving multiple issues, including the one for > > > SoCs that don't have the PIT. > > will the PIT be removed? Where it needs the PIT? > > > > The last patch is unselecting the PIT driver so by default it is

Re: [PATCH 3/3] sched/fair: schedutil: explicit update only when required

2018-05-15 Thread Patrick Bellasi
On 15-May 18:53, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 03:53:43PM +0100, Patrick Bellasi wrote: > > On 15-May 12:19, Vincent Guittot wrote: > > > On 14 May 2018 at 18:32, Patrick Bellasi wrote: > > What about adding a new explicit callback at the end of: > >

Re: [PATCH 3/3] sched/fair: schedutil: explicit update only when required

2018-05-15 Thread Patrick Bellasi
On 15-May 18:53, Peter Zijlstra wrote: > On Tue, May 15, 2018 at 03:53:43PM +0100, Patrick Bellasi wrote: > > On 15-May 12:19, Vincent Guittot wrote: > > > On 14 May 2018 at 18:32, Patrick Bellasi wrote: > > What about adding a new explicit callback at the end of: > >update_blocked_averages()

<    4   5   6   7   8   9   10   11   12   13   >