Re: [PATCH v2 15/18] serial: intel: Support more platform

2018-08-02 Thread Greg Kroah-Hartman
On Fri, Aug 03, 2018 at 11:02:34AM +0800, Songjun Wu wrote: > Support more platform. > > Signed-off-by: Songjun Wu > --- Your changelog text makes no sense, sorry. greg k-h

Re: [PATCH v2 15/18] serial: intel: Support more platform

2018-08-02 Thread Greg Kroah-Hartman
On Fri, Aug 03, 2018 at 11:02:34AM +0800, Songjun Wu wrote: > Support more platform. > > Signed-off-by: Songjun Wu > --- Your changelog text makes no sense, sorry. greg k-h

Re: [PATCH v2 14/18] serial: intel: Add CCF support

2018-08-02 Thread Greg Kroah-Hartman
On Fri, Aug 03, 2018 at 11:02:33AM +0800, Songjun Wu wrote: > Previous implementation uses platform-dependent API to get the clock. > Those functions are not available for other SoC which uses the same IP. > The CCF (Common Clock Framework) have an abstraction based APIs for > clock. In future,

Re: [PATCH v2 14/18] serial: intel: Add CCF support

2018-08-02 Thread Greg Kroah-Hartman
On Fri, Aug 03, 2018 at 11:02:33AM +0800, Songjun Wu wrote: > Previous implementation uses platform-dependent API to get the clock. > Those functions are not available for other SoC which uses the same IP. > The CCF (Common Clock Framework) have an abstraction based APIs for > clock. In future,

[PATCH v1] mm:memcg: skip memcg of current in mem_cgroup_soft_limit_reclaim

2018-08-02 Thread Zhaoyang Huang
for the soft_limit reclaim has more directivity than global reclaim, we have current memcg be skipped to avoid potential page thrashing. Signed-off-by: Zhaoyang Huang --- mm/memcontrol.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol.c

[PATCH v1] mm:memcg: skip memcg of current in mem_cgroup_soft_limit_reclaim

2018-08-02 Thread Zhaoyang Huang
for the soft_limit reclaim has more directivity than global reclaim, we have current memcg be skipped to avoid potential page thrashing. Signed-off-by: Zhaoyang Huang --- mm/memcontrol.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/mm/memcontrol.c

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Sergey Senozhatsky
On (08/03/18 14:23), Sergey Senozhatsky wrote: > > Hmm, any chance a WB device can be async on its own? We add a page > to a new bio and submit it to another async device driver. Then we > return back to the upper layer (swap), which can free a page before > the device picks up a request. Can

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Sergey Senozhatsky
On (08/03/18 14:23), Sergey Senozhatsky wrote: > > Hmm, any chance a WB device can be async on its own? We add a page > to a new bio and submit it to another async device driver. Then we > return back to the upper layer (swap), which can free a page before > the device picks up a request. Can

Re: [PATCH v2 08/18] serial: intel: Get serial id from dts

2018-08-02 Thread Greg Kroah-Hartman
On Fri, Aug 03, 2018 at 11:02:27AM +0800, Songjun Wu wrote: > Get serial id from dts. > > "#ifdef CONFIG_LANTIQ" preprocessor is used because LTQ_EARLY_ASC > macro is defined in lantiq_soc.h. > lantiq_soc.h is in arch path for legacy product support. > >

Re: [PATCH v2 08/18] serial: intel: Get serial id from dts

2018-08-02 Thread Greg Kroah-Hartman
On Fri, Aug 03, 2018 at 11:02:27AM +0800, Songjun Wu wrote: > Get serial id from dts. > > "#ifdef CONFIG_LANTIQ" preprocessor is used because LTQ_EARLY_ASC > macro is defined in lantiq_soc.h. > lantiq_soc.h is in arch path for legacy product support. > >

Re: [PATCH 4.14 000/246] 4.14.60-stable review

2018-08-02 Thread Greg Kroah-Hartman
On Thu, Aug 02, 2018 at 06:21:39PM -0700, Guenter Roeck wrote: > On 08/02/2018 12:45 PM, Greg Kroah-Hartman wrote: > [ ... ] > > > > I've pushed out -rc2 releases for all of these with that patch removed. > > > > Boot tests with updated images passed for all three releases. Wonderful, thanks

Re: [PATCH 4.14 000/246] 4.14.60-stable review

2018-08-02 Thread Greg Kroah-Hartman
On Thu, Aug 02, 2018 at 06:21:39PM -0700, Guenter Roeck wrote: > On 08/02/2018 12:45 PM, Greg Kroah-Hartman wrote: > [ ... ] > > > > I've pushed out -rc2 releases for all of these with that patch removed. > > > > Boot tests with updated images passed for all three releases. Wonderful, thanks

Re: [PATCH] firmware: make sure builtin firmware is page alignment

2018-08-02 Thread Greg KH
On Fri, Aug 03, 2018 at 09:45:21AM +0800, Zhang Ning wrote: > when firmware is in filesystem, request_firmware will load it, > and copy it to vmalloc memory, that is page align memory. > > but when firmware is builtin, it is 8 bytes or 4 bytes alignment. > > make sure builtin firmware is page

Re: [PATCH] firmware: make sure builtin firmware is page alignment

2018-08-02 Thread Greg KH
On Fri, Aug 03, 2018 at 09:45:21AM +0800, Zhang Ning wrote: > when firmware is in filesystem, request_firmware will load it, > and copy it to vmalloc memory, that is page align memory. > > but when firmware is builtin, it is 8 bytes or 4 bytes alignment. > > make sure builtin firmware is page

Re: [PATCH 23/25] selftests/ftrace: Add max stack tracer testcase

2018-08-02 Thread Masami Hiramatsu
On Fri, 27 Jul 2018 21:20:47 +0900 Masami Hiramatsu wrote: > Add a testcase for max stack tracer, which checks basic > max stack usage tracing and its filter feature. > Hmm, this test sometimes fails. (not always) Let me check what happens. Thank you, > Signed-off-by: Masami Hiramatsu >

Re: [PATCH 23/25] selftests/ftrace: Add max stack tracer testcase

2018-08-02 Thread Masami Hiramatsu
On Fri, 27 Jul 2018 21:20:47 +0900 Masami Hiramatsu wrote: > Add a testcase for max stack tracer, which checks basic > max stack usage tracing and its filter feature. > Hmm, this test sometimes fails. (not always) Let me check what happens. Thank you, > Signed-off-by: Masami Hiramatsu >

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Sergey Senozhatsky
On (08/03/18 13:51), Minchan Kim wrote: > > AFAIK, onging writeback page couldn't freed so it was not writeabck problem. > > What I'm tryig to fix is read part. > If we use swapcache, it shouldn't be a problem either because swapcache > has a reference count and we should wait PG_lock release

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Sergey Senozhatsky
On (08/03/18 13:51), Minchan Kim wrote: > > AFAIK, onging writeback page couldn't freed so it was not writeabck problem. > > What I'm tryig to fix is read part. > If we use swapcache, it shouldn't be a problem either because swapcache > has a reference count and we should wait PG_lock release

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Minchan Kim
On Fri, Aug 03, 2018 at 01:13:02PM +0900, Sergey Senozhatsky wrote: > Hi Minchan, > > On (08/03/18 12:00), Minchan Kim wrote: > > > "Device is so fast that asynchronous IO would be inefficient." > > > > > > Which is not the reason why BDI_CAP_SYNCHRONOUS_IO is used by ZRAM. > > > Probably, the

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Minchan Kim
On Fri, Aug 03, 2018 at 01:13:02PM +0900, Sergey Senozhatsky wrote: > Hi Minchan, > > On (08/03/18 12:00), Minchan Kim wrote: > > > "Device is so fast that asynchronous IO would be inefficient." > > > > > > Which is not the reason why BDI_CAP_SYNCHRONOUS_IO is used by ZRAM. > > > Probably, the

Re: Re: [PATCH] i2c: xlp9xx: Fix case where SSIF read transaction completes early

2018-08-02 Thread George Cherian
Hi Wolfran, Thanks for the review. I will update the patch with a small comment section above len --; so that there is no confusion. On 08/01/2018 02:35 AM, Wolfram Sang wrote: --- a/drivers/i2c/busses/i2c-xlp9xx.c +++ b/drivers/i2c/busses/i2c-xlp9xx.c @@ -191,28 +191,30 @@ static void

Re: Re: [PATCH] i2c: xlp9xx: Fix case where SSIF read transaction completes early

2018-08-02 Thread George Cherian
Hi Wolfran, Thanks for the review. I will update the patch with a small comment section above len --; so that there is no confusion. On 08/01/2018 02:35 AM, Wolfram Sang wrote: --- a/drivers/i2c/busses/i2c-xlp9xx.c +++ b/drivers/i2c/busses/i2c-xlp9xx.c @@ -191,28 +191,30 @@ static void

linux-next: build warning after merge of the spi tree

2018-08-02 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/spi/spi-mem.c: In function 'spi_mem_probe': drivers/spi/spi-mem.c:375:13: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]

[PATCH v2] staging: rtlwifi: refactor rtl_get_tcb_desc

2018-08-02 Thread Luke Triantafyllidis
Refactored rtl_get_tcb_desc slightly to stay within the 80 character line limit. Signed-off-by: Luke Triantafyllidis --- Changes in v2: - Fixed the formatting of the comments - Unwrapped some of the lines that were originally wrapped over multiple lines to stay within the 80 character

linux-next: build warning after merge of the spi tree

2018-08-02 Thread Stephen Rothwell
Hi Mark, After merging the spi tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/spi/spi-mem.c: In function 'spi_mem_probe': drivers/spi/spi-mem.c:375:13: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]

[PATCH v2] staging: rtlwifi: refactor rtl_get_tcb_desc

2018-08-02 Thread Luke Triantafyllidis
Refactored rtl_get_tcb_desc slightly to stay within the 80 character line limit. Signed-off-by: Luke Triantafyllidis --- Changes in v2: - Fixed the formatting of the comments - Unwrapped some of the lines that were originally wrapped over multiple lines to stay within the 80 character

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Sergey Senozhatsky
Hi Minchan, On (08/03/18 12:00), Minchan Kim wrote: > > "Device is so fast that asynchronous IO would be inefficient." > > > > Which is not the reason why BDI_CAP_SYNCHRONOUS_IO is used by ZRAM. > > Probably, the comment needs to be updated as well. > > I couldn't catch your point. Could

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Sergey Senozhatsky
Hi Minchan, On (08/03/18 12:00), Minchan Kim wrote: > > "Device is so fast that asynchronous IO would be inefficient." > > > > Which is not the reason why BDI_CAP_SYNCHRONOUS_IO is used by ZRAM. > > Probably, the comment needs to be updated as well. > > I couldn't catch your point. Could

Re: [PATCH v5 4/6] KVM: X86: Implement PV IPIs send hypercall

2018-08-02 Thread Wanpeng Li
On Thu, 2 Aug 2018 at 21:04, Paolo Bonzini wrote: > > On 23/07/2018 08:39, Wanpeng Li wrote: > > +Returns 0 if successfully delivery the IPIs and 1 if discarded. > > I'm changing this to > > "Returns the number of CPUs to which the IPIs were delivered successfully" > > with an obvious change to

Re: [PATCH v5 4/6] KVM: X86: Implement PV IPIs send hypercall

2018-08-02 Thread Wanpeng Li
On Thu, 2 Aug 2018 at 21:04, Paolo Bonzini wrote: > > On 23/07/2018 08:39, Wanpeng Li wrote: > > +Returns 0 if successfully delivery the IPIs and 1 if discarded. > > I'm changing this to > > "Returns the number of CPUs to which the IPIs were delivered successfully" > > with an obvious change to

Re: [RFC 1/2] slub: Avoid trying to allocate memory on offline nodes

2018-08-02 Thread Jeremy Linton
Hi, On 08/02/2018 04:15 AM, Michal Hocko wrote: On Wed 01-08-18 15:04:17, Jeremy Linton wrote: [...] @@ -2519,6 +2519,8 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, if (unlikely(!node_match(page, searchnode))) { stat(s,

Re: [RFC 1/2] slub: Avoid trying to allocate memory on offline nodes

2018-08-02 Thread Jeremy Linton
Hi, On 08/02/2018 04:15 AM, Michal Hocko wrote: On Wed 01-08-18 15:04:17, Jeremy Linton wrote: [...] @@ -2519,6 +2519,8 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags, int node, if (unlikely(!node_match(page, searchnode))) { stat(s,

Re: [RFC 2/2] mm: harden alloc_pages code paths against bogus nodes

2018-08-02 Thread Jeremy Linton
Hi, On 08/02/2018 02:31 AM, Michal Hocko wrote: On Wed 01-08-18 15:04:18, Jeremy Linton wrote: Its possible to crash __alloc_pages_nodemask by passing it bogus node ids. This is caused by NODE_DATA() returning null (hopefully) when the requested node is offline. We can harded against the basic

Re: [RFC 2/2] mm: harden alloc_pages code paths against bogus nodes

2018-08-02 Thread Jeremy Linton
Hi, On 08/02/2018 02:31 AM, Michal Hocko wrote: On Wed 01-08-18 15:04:18, Jeremy Linton wrote: Its possible to crash __alloc_pages_nodemask by passing it bogus node ids. This is caused by NODE_DATA() returning null (hopefully) when the requested node is offline. We can harded against the basic

Re: [RFC 0/2] harden alloc_pages against bogus nid

2018-08-02 Thread Jeremy Linton
Hi, On 08/01/2018 07:14 PM, Andrew Morton wrote: On Wed, 1 Aug 2018 17:56:46 -0500 Jeremy Linton wrote: Hi, On 08/01/2018 04:50 PM, Andrew Morton wrote: On Wed, 1 Aug 2018 15:04:16 -0500 Jeremy Linton wrote: The thread "avoid alloc memory on offline node"

Re: [RFC 0/2] harden alloc_pages against bogus nid

2018-08-02 Thread Jeremy Linton
Hi, On 08/01/2018 07:14 PM, Andrew Morton wrote: On Wed, 1 Aug 2018 17:56:46 -0500 Jeremy Linton wrote: Hi, On 08/01/2018 04:50 PM, Andrew Morton wrote: On Wed, 1 Aug 2018 15:04:16 -0500 Jeremy Linton wrote: The thread "avoid alloc memory on offline node"

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-02 Thread Ricardo Neri
On Thu, Aug 02, 2018 at 11:40:55AM +0200, Thomas Gleixner wrote: > On Thu, 2 Aug 2018, Marc Zyngier wrote: > > On Thu, 02 Aug 2018 07:55:49 +0100, > > Thomas Gleixner wrote: > > > > > > On Thu, 2 Aug 2018, Marc Zyngier wrote: > > > > > > > > If we need to distinguish between the two, then we

Re: [PATCH 1/4] genirq: Provide basic NMI management for interrupt lines

2018-08-02 Thread Ricardo Neri
On Thu, Aug 02, 2018 at 11:40:55AM +0200, Thomas Gleixner wrote: > On Thu, 2 Aug 2018, Marc Zyngier wrote: > > On Thu, 02 Aug 2018 07:55:49 +0100, > > Thomas Gleixner wrote: > > > > > > On Thu, 2 Aug 2018, Marc Zyngier wrote: > > > > > > > > If we need to distinguish between the two, then we

Re: [RFC 1/2] slub: Avoid trying to allocate memory on offline nodes

2018-08-02 Thread Jeremy Linton
Hi, On 08/02/2018 09:23 AM, Christopher Lameter wrote: On Wed, 1 Aug 2018, Jeremy Linton wrote: diff --git a/mm/slub.c b/mm/slub.c index 51258eff4178..e03719bac1e2 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2519,6 +2519,8 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags,

Re: [RFC 1/2] slub: Avoid trying to allocate memory on offline nodes

2018-08-02 Thread Jeremy Linton
Hi, On 08/02/2018 09:23 AM, Christopher Lameter wrote: On Wed, 1 Aug 2018, Jeremy Linton wrote: diff --git a/mm/slub.c b/mm/slub.c index 51258eff4178..e03719bac1e2 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2519,6 +2519,8 @@ static void *___slab_alloc(struct kmem_cache *s, gfp_t gfpflags,

[PATCH v2 12/18] serial: intel: Rename fpiclk to freqclk

2018-08-02 Thread Songjun Wu
Rename fpiclk to freqclk. Signed-off-by: Songjun Wu --- Changes in v2: None drivers/tty/serial/lantiq.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c index 2e1b35b1cf4d..28086d52e980 100644 ---

[PATCH v2 12/18] serial: intel: Rename fpiclk to freqclk

2018-08-02 Thread Songjun Wu
Rename fpiclk to freqclk. Signed-off-by: Songjun Wu --- Changes in v2: None drivers/tty/serial/lantiq.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c index 2e1b35b1cf4d..28086d52e980 100644 ---

[PATCH v2 17/18] serial: intel: Change init_lqasc to static declaration

2018-08-02 Thread Songjun Wu
init_lqasc() is only used internally, change to static declaration. Signed-off-by: Songjun Wu --- Changes in v2: None drivers/tty/serial/lantiq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c index

[PATCH v2 18/18] dt-bindings: serial: lantiq: Add optional properties for CCF

2018-08-02 Thread Songjun Wu
Clocks and clock-names are updated in device tree binding. Signed-off-by: Songjun Wu --- Changes in v2: None Documentation/devicetree/bindings/serial/lantiq_asc.txt | 15 +++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/lantiq_asc.txt

[PATCH v2 17/18] serial: intel: Change init_lqasc to static declaration

2018-08-02 Thread Songjun Wu
init_lqasc() is only used internally, change to static declaration. Signed-off-by: Songjun Wu --- Changes in v2: None drivers/tty/serial/lantiq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/lantiq.c b/drivers/tty/serial/lantiq.c index

[PATCH v2 18/18] dt-bindings: serial: lantiq: Add optional properties for CCF

2018-08-02 Thread Songjun Wu
Clocks and clock-names are updated in device tree binding. Signed-off-by: Songjun Wu --- Changes in v2: None Documentation/devicetree/bindings/serial/lantiq_asc.txt | 15 +++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/serial/lantiq_asc.txt

[PATCH v2 14/18] serial: intel: Add CCF support

2018-08-02 Thread Songjun Wu
Previous implementation uses platform-dependent API to get the clock. Those functions are not available for other SoC which uses the same IP. The CCF (Common Clock Framework) have an abstraction based APIs for clock. In future, the platform specific code will be removed when the legacy soc use CCF

[PATCH v2 07/18] MIPS: dts: Add aliases node for lantiq danube serial

2018-08-02 Thread Songjun Wu
Previous implementation uses a hard-coded register value to check if the current serial entity is the console entity. Now the lantiq serial driver uses the aliases for the index of the serial port. The lantiq danube serial dts are updated with aliases to support this. Signed-off-by: Songjun Wu

[PATCH v2 09/18] serial: intel: Change ltq_w32_mask to asc_update_bits

2018-08-02 Thread Songjun Wu
ltq prefix is platform specific function, asc prefix is more generic. Signed-off-by: Songjun Wu --- Changes in v2: None drivers/tty/serial/lantiq.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/tty/serial/lantiq.c

[PATCH v2 15/18] serial: intel: Support more platform

2018-08-02 Thread Songjun Wu
Support more platform. Signed-off-by: Songjun Wu --- Changes in v2: None drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index df8bd0c7b97d..564c71fc24bb 100644 ---

[PATCH v2 11/18] serial: intel: Use readl/writel instead of ltq_r32/ltq_w32

2018-08-02 Thread Songjun Wu
Previous implementation uses platform-dependent functions ltq_w32()/ltq_r32() to access registers. Those functions are not available for other SoC which uses the same IP. Change to OS provided readl()/writel() and readb()/writeb(), so that different SoCs can use the same driver. Signed-off-by:

[PATCH v2 14/18] serial: intel: Add CCF support

2018-08-02 Thread Songjun Wu
Previous implementation uses platform-dependent API to get the clock. Those functions are not available for other SoC which uses the same IP. The CCF (Common Clock Framework) have an abstraction based APIs for clock. In future, the platform specific code will be removed when the legacy soc use CCF

[PATCH v2 07/18] MIPS: dts: Add aliases node for lantiq danube serial

2018-08-02 Thread Songjun Wu
Previous implementation uses a hard-coded register value to check if the current serial entity is the console entity. Now the lantiq serial driver uses the aliases for the index of the serial port. The lantiq danube serial dts are updated with aliases to support this. Signed-off-by: Songjun Wu

[PATCH v2 09/18] serial: intel: Change ltq_w32_mask to asc_update_bits

2018-08-02 Thread Songjun Wu
ltq prefix is platform specific function, asc prefix is more generic. Signed-off-by: Songjun Wu --- Changes in v2: None drivers/tty/serial/lantiq.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/tty/serial/lantiq.c

[PATCH v2 15/18] serial: intel: Support more platform

2018-08-02 Thread Songjun Wu
Support more platform. Signed-off-by: Songjun Wu --- Changes in v2: None drivers/tty/serial/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index df8bd0c7b97d..564c71fc24bb 100644 ---

[PATCH v2 11/18] serial: intel: Use readl/writel instead of ltq_r32/ltq_w32

2018-08-02 Thread Songjun Wu
Previous implementation uses platform-dependent functions ltq_w32()/ltq_r32() to access registers. Those functions are not available for other SoC which uses the same IP. Change to OS provided readl()/writel() and readb()/writeb(), so that different SoCs can use the same driver. Signed-off-by:

[PATCH v2 16/18] serial: intel: Reorder the head files

2018-08-02 Thread Songjun Wu
Reorder the head files according to the coding style. Signed-off-by: Songjun Wu --- Changes in v2: - New patch to reorder the head files according to the coding style. drivers/tty/serial/lantiq.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH v2 06/18] MIPS: dts: Change upper case to lower case

2018-08-02 Thread Songjun Wu
All the upper case in unit-address and hex constants are changed to lower case according to the Linux conventions. Signed-off-by: Songjun Wu --- Changes in v2: None arch/mips/boot/dts/lantiq/danube.dtsi | 42 - arch/mips/boot/dts/lantiq/easy50712.dts | 14

[PATCH v2 13/18] serial: intel: Replace clk_enable/clk_disable with clk generic API

2018-08-02 Thread Songjun Wu
The clk driver has introduced new clock APIs that replace the existing clk_enable and clk_disable. -clk_enable() APIs is replaced with clk_prepare_enable(). -clk_disable() API is replaced with clk_disable_unprepare(). Signed-off-by: Songjun Wu --- Changes in v2: None

[PATCH v2 10/18] MIPS: lantiq: Unselect SWAP_IO_SPACE when LANTIQ is selected

2018-08-02 Thread Songjun Wu
SWAP_IO_SPACE macro prevents serial driver /drivers/tty/serial/lantiq.c to use readl/writel to replace ltq_r32/w32 which are SoC or platform specific APIs. readl/writel are used for this serial driver to support multiple platforms and multiple architectures. The legacy lantiq platform(Danube)

[PATCH v2 08/18] serial: intel: Get serial id from dts

2018-08-02 Thread Songjun Wu
Get serial id from dts. "#ifdef CONFIG_LANTIQ" preprocessor is used because LTQ_EARLY_ASC macro is defined in lantiq_soc.h. lantiq_soc.h is in arch path for legacy product support. arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h If "#ifdef preprocessor" is changed to "if

[PATCH v2 16/18] serial: intel: Reorder the head files

2018-08-02 Thread Songjun Wu
Reorder the head files according to the coding style. Signed-off-by: Songjun Wu --- Changes in v2: - New patch to reorder the head files according to the coding style. drivers/tty/serial/lantiq.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git

[PATCH v2 06/18] MIPS: dts: Change upper case to lower case

2018-08-02 Thread Songjun Wu
All the upper case in unit-address and hex constants are changed to lower case according to the Linux conventions. Signed-off-by: Songjun Wu --- Changes in v2: None arch/mips/boot/dts/lantiq/danube.dtsi | 42 - arch/mips/boot/dts/lantiq/easy50712.dts | 14

[PATCH v2 13/18] serial: intel: Replace clk_enable/clk_disable with clk generic API

2018-08-02 Thread Songjun Wu
The clk driver has introduced new clock APIs that replace the existing clk_enable and clk_disable. -clk_enable() APIs is replaced with clk_prepare_enable(). -clk_disable() API is replaced with clk_disable_unprepare(). Signed-off-by: Songjun Wu --- Changes in v2: None

[PATCH v2 10/18] MIPS: lantiq: Unselect SWAP_IO_SPACE when LANTIQ is selected

2018-08-02 Thread Songjun Wu
SWAP_IO_SPACE macro prevents serial driver /drivers/tty/serial/lantiq.c to use readl/writel to replace ltq_r32/w32 which are SoC or platform specific APIs. readl/writel are used for this serial driver to support multiple platforms and multiple architectures. The legacy lantiq platform(Danube)

[PATCH v2 08/18] serial: intel: Get serial id from dts

2018-08-02 Thread Songjun Wu
Get serial id from dts. "#ifdef CONFIG_LANTIQ" preprocessor is used because LTQ_EARLY_ASC macro is defined in lantiq_soc.h. lantiq_soc.h is in arch path for legacy product support. arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h If "#ifdef preprocessor" is changed to "if

[PATCH v2 05/18] dt-binding: MIPS: Add documentation of Intel MIPS SoCs

2018-08-02 Thread Songjun Wu
From: Hua Ma This patch adds binding documentation for the compatible values of the Intel MIPS SoCs. Signed-off-by: Hua Ma Signed-off-by: Songjun Wu --- Changes in v2: - New patch split from previous patch - Add the board and chip compatible in dt document

[PATCH v2 03/18] dt-bindings: clk: Add documentation of grx500 clock controller

2018-08-02 Thread Songjun Wu
From: Yixin Zhu This patch adds binding documentation for grx500 clock controller. Signed-off-by: YiXin Zhu Signed-off-by: Songjun Wu --- Changes in v2: - Rewrite clock driver's dt-binding document according to Rob Herring's comments. - Simplify device tree docoment, remove some clock

[PATCH v2 04/18] MIPS: dts: Add initial support for Intel MIPS SoCs

2018-08-02 Thread Songjun Wu
From: Hua Ma Add dts files to support Intel MIPS SoCs: - xrx500.dtsi is the chip dts - easy350_anywan.dts is the board dts Signed-off-by: Hua Ma Signed-off-by: Songjun Wu --- Changes in v2: - New patch split from previous patch - The memory address is changed to @2000 - Update to

[PATCH v2 05/18] dt-binding: MIPS: Add documentation of Intel MIPS SoCs

2018-08-02 Thread Songjun Wu
From: Hua Ma This patch adds binding documentation for the compatible values of the Intel MIPS SoCs. Signed-off-by: Hua Ma Signed-off-by: Songjun Wu --- Changes in v2: - New patch split from previous patch - Add the board and chip compatible in dt document

[PATCH v2 03/18] dt-bindings: clk: Add documentation of grx500 clock controller

2018-08-02 Thread Songjun Wu
From: Yixin Zhu This patch adds binding documentation for grx500 clock controller. Signed-off-by: YiXin Zhu Signed-off-by: Songjun Wu --- Changes in v2: - Rewrite clock driver's dt-binding document according to Rob Herring's comments. - Simplify device tree docoment, remove some clock

[PATCH v2 04/18] MIPS: dts: Add initial support for Intel MIPS SoCs

2018-08-02 Thread Songjun Wu
From: Hua Ma Add dts files to support Intel MIPS SoCs: - xrx500.dtsi is the chip dts - easy350_anywan.dts is the board dts Signed-off-by: Hua Ma Signed-off-by: Songjun Wu --- Changes in v2: - New patch split from previous patch - The memory address is changed to @2000 - Update to

[PATCH v2 00/18] MIPS: intel: add initial support for Intel MIPS SoCs

2018-08-02 Thread Songjun Wu
This patch series is for adding the support for Intel MIPS interAptiv SoC GRX500 family. It includes CCF support, serial driver optimization and DTS modification. This patch series is applied on top of linux v4.18-rc7. Basic verification is performed on GRX500 board. We propose merging this

[PATCH v2 00/18] MIPS: intel: add initial support for Intel MIPS SoCs

2018-08-02 Thread Songjun Wu
This patch series is for adding the support for Intel MIPS interAptiv SoC GRX500 family. It includes CCF support, serial driver optimization and DTS modification. This patch series is applied on top of linux v4.18-rc7. Basic verification is performed on GRX500 board. We propose merging this

[PATCH v2 02/18] clk: intel: Add clock driver for Intel MIPS SoCs

2018-08-02 Thread Songjun Wu
From: Yixin Zhu This driver provides PLL clock registration as well as various clock branches, e.g. MUX clock, gate clock, divider clock and so on. PLLs that provide clock to DDR, CPU and peripherals are shown below: +-+ |--->| LCPLL3 0|--PCIe clk--> XO

[PATCH v2 01/18] MIPS: intel: Add initial support for Intel MIPS SoCs

2018-08-02 Thread Songjun Wu
From: Hua Ma Add initial support for Intel MIPS interAptiv SoCs made by Intel. This series will add support for the grx500 family. The series allows booting a minimal system using a initramfs. Signed-off-by: Hua Ma Signed-off-by: Songjun Wu --- Changes in v2: - Remove unused _END macros -

[PATCH v2 02/18] clk: intel: Add clock driver for Intel MIPS SoCs

2018-08-02 Thread Songjun Wu
From: Yixin Zhu This driver provides PLL clock registration as well as various clock branches, e.g. MUX clock, gate clock, divider clock and so on. PLLs that provide clock to DDR, CPU and peripherals are shown below: +-+ |--->| LCPLL3 0|--PCIe clk--> XO

[PATCH v2 01/18] MIPS: intel: Add initial support for Intel MIPS SoCs

2018-08-02 Thread Songjun Wu
From: Hua Ma Add initial support for Intel MIPS interAptiv SoCs made by Intel. This series will add support for the grx500 family. The series allows booting a minimal system using a initramfs. Signed-off-by: Hua Ma Signed-off-by: Songjun Wu --- Changes in v2: - Remove unused _END macros -

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Minchan Kim
Hi Sergey, On Fri, Aug 03, 2018 at 11:39:29AM +0900, Sergey Senozhatsky wrote: > On (08/02/18 14:13), Andrew Morton wrote: > [..] > > That changelog is rather hard to follow. Please review my edits: > > > > : If zram supports writeback feature, it's no longer a BD_CAP_SYNCHRONOUS_IO >

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Minchan Kim
Hi Sergey, On Fri, Aug 03, 2018 at 11:39:29AM +0900, Sergey Senozhatsky wrote: > On (08/02/18 14:13), Andrew Morton wrote: > [..] > > That changelog is rather hard to follow. Please review my edits: > > > > : If zram supports writeback feature, it's no longer a BD_CAP_SYNCHRONOUS_IO >

Re: [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

2018-08-02 Thread Joel Fernandes
Hi Masami, On Thu, Aug 2, 2018 at 7:55 AM, Masami Hiramatsu wrote: > Hi Joel, > > I found this caused several issues when testing ftrace. > > #1) ftrace boottest (FTRACE_STARTUP_TEST) fails This sadly appears to be a real issue. The startup test for "preemptirqsoff" tracer fails, however it

Re: [PATCH v12 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

2018-08-02 Thread Joel Fernandes
Hi Masami, On Thu, Aug 2, 2018 at 7:55 AM, Masami Hiramatsu wrote: > Hi Joel, > > I found this caused several issues when testing ftrace. > > #1) ftrace boottest (FTRACE_STARTUP_TEST) fails This sadly appears to be a real issue. The startup test for "preemptirqsoff" tracer fails, however it

Re: linux-next: build failure after merge of the pstore tree

2018-08-02 Thread Kees Cook
On Thu, Aug 2, 2018 at 6:00 PM, Stephen Rothwell wrote: > Hi Kees, > > After merging the pstore tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > fs/pstore/platform.o: In function `zbufsize_zstd': > platform.c:(.text+0x172): undefined reference to `ZSTD_compressBound' >

Re: linux-next: build failure after merge of the pstore tree

2018-08-02 Thread Kees Cook
On Thu, Aug 2, 2018 at 6:00 PM, Stephen Rothwell wrote: > Hi Kees, > > After merging the pstore tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > fs/pstore/platform.o: In function `zbufsize_zstd': > platform.c:(.text+0x172): undefined reference to `ZSTD_compressBound' >

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Minchan Kim
Hi Andrew, On Thu, Aug 02, 2018 at 02:13:04PM -0700, Andrew Morton wrote: > On Thu, 2 Aug 2018 14:11:12 +0900 Minchan Kim wrote: > > > If zram supports writeback feature, it's no more syncrhonous > > device beause zram does synchronous IO opeation for > > incompressible page. > > > > Do not

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Sergey Senozhatsky
On (08/03/18 11:39), Sergey Senozhatsky wrote: > [..] > > > A reader looking at this would wonder "why the heck are we doing that". > > Adding a code comment would help them. > > The interesting thing here is that include/linux/backing-dev.h > BDI_CAP_SYNCHRONOUS_IO comment says > >

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Minchan Kim
Hi Andrew, On Thu, Aug 02, 2018 at 02:13:04PM -0700, Andrew Morton wrote: > On Thu, 2 Aug 2018 14:11:12 +0900 Minchan Kim wrote: > > > If zram supports writeback feature, it's no more syncrhonous > > device beause zram does synchronous IO opeation for > > incompressible page. > > > > Do not

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Sergey Senozhatsky
On (08/03/18 11:39), Sergey Senozhatsky wrote: > [..] > > > A reader looking at this would wonder "why the heck are we doing that". > > Adding a code comment would help them. > > The interesting thing here is that include/linux/backing-dev.h > BDI_CAP_SYNCHRONOUS_IO comment says > >

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Sergey Senozhatsky
On (08/02/18 14:13), Andrew Morton wrote: [..] > That changelog is rather hard to follow. Please review my edits: > > : If zram supports writeback feature, it's no longer a BD_CAP_SYNCHRONOUS_IO ^BDI_CAP_SYNCHRONOUS_IO [..] > A reader

Re: [PATCH 1/2] zram: remove BD_CAP_SYNCHRONOUS_IO with writeback feature

2018-08-02 Thread Sergey Senozhatsky
On (08/02/18 14:13), Andrew Morton wrote: [..] > That changelog is rather hard to follow. Please review my edits: > > : If zram supports writeback feature, it's no longer a BD_CAP_SYNCHRONOUS_IO ^BDI_CAP_SYNCHRONOUS_IO [..] > A reader

[PATCH] trace: Use rcu_dereference_raw for hooks from trace-event subsystem

2018-08-02 Thread Joel Fernandes (Google)
Since we switched to using SRCU for tracepoints used in the idle path, we can no longer use rcu_dereference_sched for dereferencing points in trace-event hooks. Since tracepoints can now use either SRCU or sched-RCU, just use rcu_dereference_raw for traceevents just like we're doing when

[PATCH] trace: Use rcu_dereference_raw for hooks from trace-event subsystem

2018-08-02 Thread Joel Fernandes (Google)
Since we switched to using SRCU for tracepoints used in the idle path, we can no longer use rcu_dereference_sched for dereferencing points in trace-event hooks. Since tracepoints can now use either SRCU or sched-RCU, just use rcu_dereference_raw for traceevents just like we're doing when

linux-next: build failure after merge of the pstore tree

2018-08-02 Thread Stephen Rothwell
ssion support") I have used the pstore tree from next-20180802 for today. -- Cheers, Stephen Rothwell pgpqkh2PNeXBK.pgp Description: OpenPGP digital signature

linux-next: build failure after merge of the pstore tree

2018-08-02 Thread Stephen Rothwell
ssion support") I have used the pstore tree from next-20180802 for today. -- Cheers, Stephen Rothwell pgpqkh2PNeXBK.pgp Description: OpenPGP digital signature

Re: [PATCH v4 2/4] x86/boot: Add acpitb.c to parse acpi tables

2018-08-02 Thread Chao Fan
On Fri, Aug 03, 2018 at 10:00:48AM +0800, Dou Liyang wrote: > > >At 07/23/2018 05:29 PM, Chao Fan wrote: >> Imitate the ACPI code to parse ACPI tables. Functions are simplified >> cause some operations are not needed here. >> And also, this method won't influence the initialization of ACPI. >> >>

Re: [PATCH v4 2/4] x86/boot: Add acpitb.c to parse acpi tables

2018-08-02 Thread Chao Fan
On Fri, Aug 03, 2018 at 10:00:48AM +0800, Dou Liyang wrote: > > >At 07/23/2018 05:29 PM, Chao Fan wrote: >> Imitate the ACPI code to parse ACPI tables. Functions are simplified >> cause some operations are not needed here. >> And also, this method won't influence the initialization of ACPI. >> >>

Re: [V9fs-developer] [PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag

2018-08-02 Thread Dominique Martinet
Dominique Martinet wrote on Fri, Aug 03, 2018: > (the code is currently not safe if it returns an error, I'm sending > another mail about it right after this one as we already have a partial > fix) I take that one back, ksys_mount() does check for error properly so just the null checks we have in

Re: [V9fs-developer] [PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag

2018-08-02 Thread Dominique Martinet
Dominique Martinet wrote on Fri, Aug 03, 2018: > (the code is currently not safe if it returns an error, I'm sending > another mail about it right after this one as we already have a partial > fix) I take that one back, ksys_mount() does check for error properly so just the null checks we have in

Re: [V9fs-developer] [PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag

2018-08-02 Thread Dominique Martinet
piaojun wrote on Fri, Aug 03, 2018: > We'd better reach an agreement about the patch fix. The way I read Greg's comment was that he agreed to the proposed changes and is waiting for a new version. I'm writing a longer reply than I should because I don't like people saying strncmp is safe just

Re: [V9fs-developer] [PATCH v2] net/9p/trans_virtio.c: add null terminal for mount tag

2018-08-02 Thread Dominique Martinet
piaojun wrote on Fri, Aug 03, 2018: > We'd better reach an agreement about the patch fix. The way I read Greg's comment was that he agreed to the proposed changes and is waiting for a new version. I'm writing a longer reply than I should because I don't like people saying strncmp is safe just

  1   2   3   4   5   6   7   8   9   10   >