Re: [PATCH v4 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA controller

2020-05-03 Thread Vinod Koul
On 28-04-20, 16:13, Sanjay R Mehta wrote: > From: Sanjay R Mehta > > This driver add support for AMD PTDMA controller. This device > performs high-bandwidth memory to memory and IO copy operation. > Device commands are managed via a circular queue of 'descriptors', > each of which specifies

Re: [PATCH/RFC] clk: gate: Add some kunit test suites

2020-05-03 Thread Vaittinen, Matti
Hello David, & All This review and mail is more for pointing out the downsides of UTs. I am not demanding any changes, these comments can be seen as 'nit's. On Wed, 2020-04-29 at 12:15 +0800, David Gow wrote: > On Tue, Apr 14, 2020 at 7:46 PM Vaittinen, Matti > wrote: > > Hello Stephen & All, >

Re: [PATCH] staging: iio: ad5933: rework probe to use devm_ function variants

2020-05-03 Thread Ardelean, Alexandru
On Sat, 2020-05-02 at 19:25 +0100, Jonathan Cameron wrote: > On Tue, 28 Apr 2020 12:31:28 +0300 > Alexandru Ardelean wrote: > > > This change cleans up the driver's probe function to use only devm_ > > function variants. This also gets rid of the remove function and moves the > > clock &

Re: [PATCH] i2c: fix missing pm_runtime_put_sync in i2c_device_probe

2020-05-03 Thread Jarkko Nikula
On 4/30/20 7:35 PM, Wolfram Sang wrote: On Thu, Apr 30, 2020 at 05:43:21PM +0200, Alain Volmat wrote: In case of the I2C client exposes the flag I2C_CLIENT_HOST_NOTIFY, pm_runtime_get_sync is called in order to always keep active the adapter. However later on, pm_runtime_put_sync is never

Re: [PATCH] RISC-V: Remove unused code from STRICT_KERNEL_RWX

2020-05-03 Thread Zong Li
On Mon, May 4, 2020 at 12:04 PM Atish Patra wrote: > > This patch removes the unused functions set_kernel_text_rw/ro. > Currently, it is not being invoked from anywhere and no other architecture > (except arm) uses this code. Even in ARM, these functions are not invoked > from anywhere currently.

Re: [PATCH V2 00/11] Subject: Remove duplicated kmap code

2020-05-03 Thread Al Viro
On Sun, May 03, 2020 at 10:04:47PM -0700, Ira Weiny wrote: > Grepping for 'asm/highmem.h' and investigations don't reveal any issues... > But > you do have me worried. That said 0-day has been crunching on multiple > versions of this series without issues such as this (save the mips issue >

RE: [PATCH] dma: zynqmp_dma: Initialize descriptor list after freeing during reset

2020-05-03 Thread Harini Katakam
Hi Vinod, > -Original Message- > From: Vinod Koul [mailto:vk...@kernel.org] > Sent: Monday, May 4, 2020 10:46 AM > To: Rafał Hibner > Cc: Appana Durga Kedareswara Rao ; Radhey Shyam > Pandey ; Harini Katakam ; Dan > Williams ; Michal Simek ; open > list:DMA GENERIC OFFLOAD ENGINE

Re: [PATCH][next] dmaengine: dw-edma: support local dma device transfer semantics

2020-05-03 Thread Vinod Koul
On 28-04-20, 18:10, Alan Mikhak wrote: > From: Alan Mikhak > > Modify dw_edma_device_transfer() to also support the semantics of dma > device transfer for additional use cases involving pcitest utility as a > local initiator. > > For its original use case, dw-edma supported the semantics of dma

[PATCH 0/2] kmap cleanup 2

2020-05-03 Thread ira . weiny
From: Ira Weiny Continue the kmap clean up with 2 follow on patches These apply after the kmap cleanup V2 series: https://lore.kernel.org/lkml/20200504010912.982044-1-ira.we...@intel.com/ Ira Weiny (2): kmap: Remove kmap_atomic_to_page() parisc/kmap: Remove duplicate kmap code

[PATCH 2/2] parisc/kmap: Remove duplicate kmap code

2020-05-03 Thread ira . weiny
From: Ira Weiny parisc reimplements the kmap calls except to flush it's dcache. This is arguably an abuse of kmap but regardless it is messy and confusing. Remove the duplicate code and have parisc define ARCH_HAS_FLUSH_ON_KUNMAP for a kunmap_flush_on_unmap() architecture specific call to

[PATCH 1/2] kmap: Remove kmap_atomic_to_page()

2020-05-03 Thread ira . weiny
From: Ira Weiny kmap_atomic_to_page() has no callers and is only defined on 1 arch and declared on another. Remove it. Suggested-by: Al Viro Signed-off-by: Ira Weiny --- arch/csky/include/asm/highmem.h | 1 - arch/csky/mm/highmem.c | 13 -

Re: [PATCH v5 1/5] soc: qcom: rpmh-rsc: Correctly ignore CPU_CLUSTER_PM notifications

2020-05-03 Thread Maulik Shah
Hi, On 4/24/2020 10:16 PM, Douglas Anderson wrote: Our switch statement doesn't have entries for CPU_CLUSTER_PM_ENTER, CPU_CLUSTER_PM_ENTER_FAILED, and CPU_CLUSTER_PM_EXIT and doesn't have a default. This means that we'll try to do a flush in those cases but we won't necessarily be the last

[PATCH rdma-next v3 0/5] Set flow_label and RoCEv2 UDP source port for datagram QP

2020-05-03 Thread Leon Romanovsky
From: Leon Romanovsky Changelog: v3: Rebased on latest rdma-nex, which includes HCA set capability patch and LAG code and this is why new patch from Maor was added. v2: https://lore.kernel.org/linux-rdma/20200413133703.932731-1-l...@kernel.org Dropped patch "RDMA/cm: Set flow label of

Re: [PATCH] dma: zynqmp_dma: Initialize descriptor list after freeing during reset

2020-05-03 Thread Vinod Koul
On 02-05-20, 15:00, Rafał Hibner wrote: > Hello Vinod, > > On 02.05.2020 14:32, Vinod Koul wrote: > > Would it not be better to use list_del_init() where we delete it rather > > than do the init here? > > > > It is not a problem of list element itself not being initialized. > The problem is that

Re: [PATCH 4.14 000/117] 4.14.178-rc2 review

2020-05-03 Thread Naresh Kamboju
On Sat, 2 May 2020 at 12:17, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.14.178 release. > There are 117 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH 4.19 00/47] 4.19.120-rc2 review

2020-05-03 Thread Naresh Kamboju
On Sat, 2 May 2020 at 12:18, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.120 release. > There are 47 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

Re: [PATCH] cpufreq: qcom: fix wrong compatible binding

2020-05-03 Thread Viresh Kumar
On 01-05-20, 00:22, Ansuel Smith wrote: > Binding in Documentation is still "operating-points-v2-kryo-cpu". > Restore the old binding to fix the compatibility problem. > > Fixes: a8811ec764f9 ("cpufreq: qcom: Add support for krait based socs") > Signed-off-by: Ansuel Smith > --- >

Re: [PATCH] powerpc/powernv: Fix a warning message

2020-05-03 Thread Gautham R Shenoy
Hello Christophe, On Sat, May 02, 2020 at 01:59:49PM +0200, Christophe JAILLET wrote: > Fix a cut'n'paste error in a warning message. This should be > 'cpu-idle-state-residency-ns' to match the property searched in the > previous 'of_property_read_u32_array()' > > Fixes: 9c7b185ab2fe

Re: [PATCH v4 1/1] dmaengine: owl: Use correct lock in owl_dma_get_pchan()

2020-05-03 Thread Vinod Koul
On 02-05-20, 20:15, Cristian Ciocaltea wrote: > When the kernel is built with lockdep support and the owl-dma driver is > used, the following message is shown: > > [2.496939] INFO: trying to register non-static key. > [2.501889] the code is fine but needs lockdep annotation. > [

Re: [PATCH V2 00/11] Subject: Remove duplicated kmap code

2020-05-03 Thread Ira Weiny
On Mon, May 04, 2020 at 02:35:09AM +0100, Al Viro wrote: > On Sun, May 03, 2020 at 06:09:01PM -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > The kmap infrastructure has been copied almost verbatim to every > > architecture. > > This series consolidates obvious duplicated code by

Re: [PATCH v7 6/7] OPP: Update the bandwidth on OPP frequency changes

2020-05-03 Thread Viresh Kumar
On 30-04-20, 09:32, Saravana Kannan wrote: > You are missing the point. This is not about aggregation. This is > about OPP voting for bandwidth on a path when the vote can/should be > 0. > > I'll give another example. Say one of the interconnect paths needs to > be voted only when a particular

Re: [PATCH v3 1/1] dma: actions: Fix lockdep splat for owl-dma

2020-05-03 Thread Vinod Koul
Hi Cristian, On 02-05-20, 20:35, Cristian Ciocaltea wrote: > On Sat, May 02, 2020 at 05:53:33PM +0530, Vinod Koul wrote: > > Hi Cristian, > > > > On 29-04-20, 18:28, Cristian Ciocaltea wrote: > > > When the kernel is built with lockdep support and the owl-dma driver is > > > used, the following

Re: [PATCH] epoll: ensure ep_poll() doesn't miss wakeup events

2020-05-03 Thread Jason Baron
On 5/4/20 12:29 AM, Jason Baron wrote: > > > On 5/3/20 6:24 AM, Roman Penyaev wrote: >> On 2020-05-02 00:09, Jason Baron wrote: >>> On 5/1/20 5:02 PM, Roman Penyaev wrote: Hi Jason, That is indeed a nice catch. Seems we need smp_rmb() pair between

Re: [PATCH net-next v4 0/2] provide support for PHY master/slave configuration

2020-05-03 Thread Oleksij Rempel
please ignore it, i send it by accident. On Mon, May 04, 2020 at 06:33:18AM +0200, Oleksij Rempel wrote: > changes v3: > - rename port_mode to master_slave > - move validation code to net/ethtool/linkmodes.c > - add UNSUPPORTED state and avoid sending unsupported fields > - more formatting and

[PATCH net-next v4 0/2] provide support for PHY master/slave configuration

2020-05-03 Thread Oleksij Rempel
changes v3: - rename port_mode to master_slave - move validation code to net/ethtool/linkmodes.c - add UNSUPPORTED state and avoid sending unsupported fields - more formatting and naming fixes - tja11xx: support only force mode - tja11xx: mark state as unsupported changes v3: - provide separate

Re: [PATCH] epoll: ensure ep_poll() doesn't miss wakeup events

2020-05-03 Thread Jason Baron
On 5/3/20 6:24 AM, Roman Penyaev wrote: > On 2020-05-02 00:09, Jason Baron wrote: >> On 5/1/20 5:02 PM, Roman Penyaev wrote: >>> Hi Jason, >>> >>> That is indeed a nice catch. >>> Seems we need smp_rmb() pair between list_empty_careful(>rdllist) and >>> READ_ONCE(ep->ovflist) for

[PATCH v5 4/6] arch/x86/kvm: Refactor L1D flushing

2020-05-03 Thread Balbir Singh
Move out the initialization function to l1d_flush_init_once() so that it can be reused for subsequent patches. The side-effect of this patch is that the memory allocated for l1d flush pages is no longer freed up and the memory allocated once is shared amongst callers. l1d_flush_sw/hw() are now

[PATCH v5 5/6] Optionally flush L1D on context switch

2020-05-03 Thread Balbir Singh
Implement a mechanism to selectively flush the L1D cache. The goal is to allow tasks that are paranoid due to the recent snoop assisted data sampling vulnerabilites, to flush their L1D on being switched out. This protects their data from being snooped or leaked via side channels after the task

[PATCH v5 6/6] Documentation: Add L1D flushing Documentation

2020-05-03 Thread Balbir Singh
Add documentation of l1d flushing, explain the need for the feature and how it can be used. Signed-off-by: Balbir Singh Reviewed-by: Kees Cook --- Documentation/admin-guide/hw-vuln/index.rst | 1 + .../admin-guide/hw-vuln/l1d_flush.rst | 40 +++ 2 files changed, 41

[PATCH v5 3/6] arch/x86/mm: Refactor cond_ibpb() to support other use cases

2020-05-03 Thread Balbir Singh
cond_ibpb() has the necessary bits required to track the previous mm in switch_mm_irqs_off(). This can be reused for other use cases like L1D flushing (on context switch out). Suggested-by: Thomas Gleixner Signed-off-by: Balbir Singh --- arch/x86/include/asm/tlbflush.h | 2 +-

[PATCH v5 2/6] arch/x86/kvm: Refactor tlbflush and l1d flush

2020-05-03 Thread Balbir Singh
Refactor the existing assembly bits into smaller helper functions and also abstract L1D_FLUSH into a helper function. Use these functions in kvm for L1D flushing. Reviewed-by: Kees Cook Signed-off-by: Balbir Singh --- arch/x86/include/asm/cacheflush.h | 3 ++ arch/x86/kernel/l1d_flush.c

[PATCH v5 1/6] arch/x86/kvm: Refactor l1d flush lifecycle management

2020-05-03 Thread Balbir Singh
Split out the allocation and free routines to be used in a follow up set of patches (to reuse for L1D flushing). Signed-off-by: Balbir Singh Reviewed-by: Kees Cook --- arch/x86/include/asm/cacheflush.h | 3 +++ arch/x86/kernel/Makefile | 1 + arch/x86/kernel/l1d_flush.c | 36

[PATCH v5 0/6] Optionally flush L1D on context switch

2020-05-03 Thread Balbir Singh
Provide a mechanism to flush the L1D cache on context switch. The goal is to allow tasks that are paranoid due to the recent snoop assisted data sampling vulnerabilites, to flush their L1D on being switched out. This protects their data from being snooped or leaked via side channels after the

Re: [PATCH V2 2/8] usb: gadget: tegra-xudc: Add vbus_draw support

2020-05-03 Thread Nagarjuna Kristam
On 28-04-2020 15:29, Thierry Reding wrote: @@ -2042,6 +2044,19 @@ static int tegra_xudc_gadget_stop(struct usb_gadget *gadget) return 0; } +static int tegra_xudc_gadget_vbus_draw(struct usb_gadget *gadget, + unsigned int m_a) +{ +

[PATCH] RISC-V: Remove unused code from STRICT_KERNEL_RWX

2020-05-03 Thread Atish Patra
This patch removes the unused functions set_kernel_text_rw/ro. Currently, it is not being invoked from anywhere and no other architecture (except arm) uses this code. Even in ARM, these functions are not invoked from anywhere currently. Fixes: d27c3c90817e ("riscv: add STRICT_KERNEL_RWX support")

[PATCH V18 2/2] mm/debug: Add tests validating architecture page table helpers

2020-05-03 Thread Anshuman Khandual
This adds tests which will validate architecture page table helpers and other accessors in their compliance with expected generic MM semantics. This will help various architectures in validating changes to existing page table helpers or addition of new ones. This test covers basic page table

[PATCH V18 1/2] x86/mm: Define mm_p4d_folded()

2020-05-03 Thread Anshuman Khandual
This just defines mm_p4d_folded() to check whether P4D page table level is folded at runtime. Cc: Thomas Gleixner Cc: Andrew Morton Cc: Ingo Molnar Cc: x...@kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Kirill A. Shutemov Signed-off-by: Anshuman Khandual ---

[PATCH V18 0/2] mm/debug: Add tests validating architecture page table helpers

2020-05-03 Thread Anshuman Khandual
This adds a test validation for architecture exported page table helpers. Patch adds basic transformation tests at various levels of the page table. This test was originally suggested by Catalin during arm64 THP migration RFC discussion earlier. Going forward it can include more specific tests

Re: [PATCH v2 5/6] sched/deadline: Make DL capacity-aware

2020-05-03 Thread Pavan Kondeti
On Fri, May 01, 2020 at 06:12:07PM +0200, Dietmar Eggemann wrote: > On 30/04/2020 15:10, Pavan Kondeti wrote: > > On Mon, Apr 27, 2020 at 10:37:08AM +0200, Dietmar Eggemann wrote: > >> From: Luca Abeni > > [...] > > >> @@ -1653,10 +1654,19 @@ select_task_rq_dl(struct task_struct *p, int cpu, >

Re: Possible memory leak in unxz()

2020-05-03 Thread Randy Dunlap
On 5/3/20 12:23 AM, Dongyang Zhan wrote: > Hi, > > I am a security researcher, my name is Dongyang Zhan. I found a potential bug. > > I hope you can help me to confirm it. > > Thank you. > > Possible memory leak in Linux 4.10.17. The function unxz() in It would be more helpful if you could

[PATCH v2] riscv: force __cpu_up_ variables to put in data section

2020-05-03 Thread Zong Li
Put __cpu_up_stack_pointer and __cpu_up_task_pointer in data section. Currently, these two variables are put in bss section, there is a potential risk that secondary harts get the uninitialized value before main hart finishing the bss clearing. In this case, all secondary harts would pass the

linux-next: manual merge of the devicetree tree with the drm tree

2020-05-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the devicetree tree got a conflict in: Documentation/devicetree/bindings/display/panel/panel-common.yaml between commit: 92e513fb0798 ("dt-bindings: display: grammar fixes in panel/") from the drm tree and commit: 3d21a4609335 ("dt-bindings: Remove

[PATCH net] net: dsa: Do not make user port errors fatal

2020-05-03 Thread Florian Fainelli
Prior to 1d27732f411d ("net: dsa: setup and teardown ports"), we would not treat failures to set-up an user port as fatal, but after this commit we would, which is a regression for some systems where interfaces may be declared in the Device Tree, but the underlying hardware may not be present

linux-next: build warnings after merge of the keys tree

2020-05-03 Thread Stephen Rothwell
Hi all, After merging the keys tree, today's linux-next build (x86_64 allmodconfig) produced these warnings: scripts/Makefile.lib:8: 'always' is deprecated. Please use 'always-y' instead scripts/Makefile.lib:12: 'hostprogs-y' and 'hostprogs-m' are deprecated. Please use 'hostprogs' instead

[PATCH v5.6-rt] mm: slub: Always flush the delayed empty slubs in flush_all()

2020-05-03 Thread Kevin Hao
After commit f0b231101c94 ("mm/SLUB: delay giving back empty slubs to IRQ enabled regions"), when the free_slab() is invoked with the IRQ disabled, the empty slubs are moved to a per-CPU list and will be freed after IRQ enabled later. But in the current codes, there is a check to see if there

Re: linux-next: build failure after merge of the keys tree

2020-05-03 Thread Stephen Rothwell
Hi all, On Mon, 4 May 2020 13:25:29 +1000 Stephen Rothwell wrote: > > Due to further changes in Linus' tree over the weekend, this fixup is > not linger needed. "no longer" (Monday's ...) -- Cheers, Stephen Rothwell pgpQJB6x10RtY.pgp Description: OpenPGP digital signature

Re: linux-next: build failure after merge of the keys tree

2020-05-03 Thread Stephen Rothwell
Hi all, On Mon, 2 Mar 2020 11:37:37 +1100 Stephen Rothwell wrote: > > After merging the keys tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > fs/io_uring.c: In function 'io_splice_punt': > fs/io_uring.c:2473:6: error: too few arguments to function 'get_pipe_info'

linux-next: manual merge of the keys tree with the kbuild tree

2020-05-03 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the keys tree got conflicts in: samples/Kconfig samples/Makefile between commit: 3ba9c29d1877 ("samples: watchdog: use 'userprogs' syntax") from the kbuild tree and commit: 631ec151fd96 ("Add sample notification program") from the keys tree. I

[PATCH] Makefile: support compressed debug info

2020-05-03 Thread Nick Desaulniers
As debug information gets larger and larger, it helps significantly save the size of vmlinux images to compress the information in the debug information sections. Note: this debug info is typically split off from the final compressed kernel image, which is why vmlinux is what's used in conjunction

Re: [PATCH v2 03/10] kexec: separate PageHighMem() and PageHighMemZone() use case

2020-05-03 Thread Joonsoo Kim
2020년 5월 1일 (금) 오후 11:06, Eric W. Biederman 님이 작성: > > js1...@gmail.com writes: > > > From: Joonsoo Kim > > > > Until now, PageHighMem() is used for two different cases. One is to check > > if there is a direct mapping for this page or not. The other is to check > > the zone of this page, that

Re: [PATCH v3 18/25] mm: Allow large pages to be added to the page cache

2020-05-03 Thread Matthew Wilcox
On Wed, Apr 29, 2020 at 06:36:50AM -0700, Matthew Wilcox wrote: > @@ -886,7 +906,7 @@ static int __add_to_page_cache_locked(struct page *page, > /* Leave page->index set: truncation relies upon it */ > if (!huge) > mem_cgroup_cancel_charge(page, memcg, false); > -

Re: [PATCH v2 00/10] change the implementation of the PageHighMem()

2020-05-03 Thread Joonsoo Kim
2020년 5월 1일 (금) 오후 9:34, Christoph Hellwig 님이 작성: > > On Fri, May 01, 2020 at 09:15:30PM +0900, Joonsoo Kim wrote: > > I think that PageHighMemZone() is long and complicated enough to have > > a macro. > > It is. But then again it also shouldn't really be used by anything > but MM internals. I'm

Re: [PATCH v2 07/10] mm: separate PageHighMem() and PageHighMemZone() use case

2020-05-03 Thread Joonsoo Kim
2020년 5월 1일 (금) 오후 9:30, Christoph Hellwig 님이 작성: > > On Wed, Apr 29, 2020 at 12:26:40PM +0900, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > Until now, PageHighMem() is used for two different cases. One is to check > > if there is a direct mapping for this page or not. The other is to

Re: [PATCH v2 06/10] mm/hugetlb: separate PageHighMem() and PageHighMemZone() use case

2020-05-03 Thread Joonsoo Kim
2020년 5월 1일 (금) 오후 9:26, Christoph Hellwig 님이 작성: > > On Wed, Apr 29, 2020 at 12:26:39PM +0900, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > Until now, PageHighMem() is used for two different cases. One is to check > > if there is a direct mapping for this page or not. The other is to

Re: [PATCH v2 05/10] mm/gup: separate PageHighMem() and PageHighMemZone() use case

2020-05-03 Thread Joonsoo Kim
2020년 5월 1일 (금) 오후 9:24, Christoph Hellwig 님이 작성: > > On Wed, Apr 29, 2020 at 12:26:38PM +0900, js1...@gmail.com wrote: > > From: Joonsoo Kim > > > > Until now, PageHighMem() is used for two different cases. One is to check > > if there is a direct mapping for this page or not. The other is to

Re: WARNING in hsr_addr_subst_dest

2020-05-03 Thread syzbot
syzbot suspects this bug was fixed by commit: commit 4b793acdca0050739b99ace6a8b9e7f717f57c6b Author: Taehee Yoo Date: Fri Feb 28 18:01:46 2020 + hsr: use netdev_err() instead of WARN_ONCE() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=130746ffe0 start commit:

Re: [PATCH v2 04/10] power: separate PageHighMem() and PageHighMemZone() use case

2020-05-03 Thread Joonsoo Kim
2020년 5월 1일 (금) 오후 9:22, Christoph Hellwig 님이 작성: > > On Wed, Apr 29, 2020 at 12:26:37PM +0900, js1...@gmail.com wrote: > > index 6598001..be759a6 100644 > > --- a/kernel/power/snapshot.c > > +++ b/kernel/power/snapshot.c > > @@ -1227,7 +1227,7 @@ static struct page *saveable_highmem_page(struct

Re: [PATCH v3] mm: Add kvfree_sensitive() for freeing sensitive data objects

2020-05-03 Thread Waiman Long
On 5/1/20 7:22 PM, Eric Biggers wrote: On Tue, Apr 07, 2020 at 04:03:18PM -0400, Waiman Long wrote: For kvmalloc'ed data object that contains sensitive information like cryptographic key, we need to make sure that the buffer is always cleared before freeing it. Using memset() alone for buffer

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-03 Thread Rafael Aquini
On Sat, May 02, 2020 at 11:16:30PM +, Christopher Lameter wrote: > On Fri, 1 May 2020, Rafael Aquini wrote: > > > Sometimes it is desirable to override SLUB's debug facilities > > default behavior upon stumbling on a cache or object error > > and just stop the execution in order to grab a

Re: [PATCH] mm: slub: add panic_on_error to the debug facilities

2020-05-03 Thread Rafael Aquini
On Fri, May 01, 2020 at 07:17:24PM -0400, Qian Cai wrote: > > > > On May 1, 2020, at 5:54 PM, Rafael Aquini wrote: > > > > It seems like a good idea which also would required "adding things" > > elsewhere, but doesn't look mutually exclusive with the approach here. > > Also, what’s so special

Re: [PATCH 11/24] rcu/tree: Maintain separate array for vmalloc ptrs

2020-05-03 Thread Paul E. McKenney
On Sun, May 03, 2020 at 08:58:58PM -0400, Joel Fernandes wrote: > On Sun, May 03, 2020 at 05:20:32PM -0700, Paul E. McKenney wrote: > > On Sun, May 03, 2020 at 07:42:50PM -0400, Joel Fernandes wrote: > > > On Fri, May 01, 2020 at 02:37:53PM -0700, Paul E. McKenney wrote: > > > [...] > > > > > @@

[PATCH 2/2] scripts/dtc: compile separate dtc-yaml

2020-05-03 Thread Masahiro Yamada
Marek Behún reported a case where pkg-config fails to detect the libyaml-dev package, which is presumably a bug of the distro. Irrespective of that, I am not a big fan of pkg-config in the Makefile parse stage. The cost of pkg-config is quite small, but it is evaluated everytime we run make, even

[PATCH 1/2] kbuild: use separate commands for generating *.dtb and *.dt.yaml

2020-05-03 Thread Masahiro Yamada
Currently, cmd_dtc takes $(2) to select the target format. The additional parameter complicates things when it is used with cmd_and_fixdep and if_changed_rule. To make it easier to understand, use a separate cmd_dtc_yaml. One visible change is, 'DTCYAML' is used for the log when compiling *.dts

Re: [PATCH v4 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC

2020-05-03 Thread Ramuthevar, Vadivel MuruganX
Hi Boris, On 30/4/2020 9:01 pm, Boris Brezillon wrote: On Thu, 30 Apr 2020 14:36:00 +0200 Boris Brezillon wrote: On Thu, 30 Apr 2020 17:07:03 +0800 "Ramuthevar, Vadivel MuruganX" wrote: The question is, is it the same value we have in nand_pa or it is different? Different

Re: [PATCH v4 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC

2020-05-03 Thread Ramuthevar, Vadivel MuruganX
Hi Boris, Thank you very much for the review comments and your time... On 30/4/2020 9:01 pm, Boris Brezillon wrote: On Thu, 30 Apr 2020 14:36:00 +0200 Boris Brezillon wrote: On Thu, 30 Apr 2020 17:07:03 +0800 "Ramuthevar, Vadivel MuruganX" wrote: The question is, is it the same value

Re: [PATCH v4 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC

2020-05-03 Thread Ramuthevar, Vadivel MuruganX
Hi Boris, Thank you very much for the review comments and giving inputs... On 30/4/2020 8:36 pm, Boris Brezillon wrote: On Thu, 30 Apr 2020 17:07:03 +0800 "Ramuthevar, Vadivel MuruganX" wrote: The question is, is it the same value we have in nand_pa or it is different? Different

Re: linux-next: build failure after merge of the char-misc tree

2020-05-03 Thread Stephen Rothwell
Hi all, [Just adding cc] On Mon, 4 May 2020 11:46:25 +1000 Stephen Rothwell wrote: > > Hi all, > > After merging the char-misc tree, Friday's linux-next build (arm64 > allmodconfig) failed like this: > > ERROR: modpost: "zynqmp_pm_fpga_get_status" [drivers/fpga/zynqmp-fpga.ko] > undefined!

linux-next: build failure after merge of the char-misc tree

2020-05-03 Thread Stephen Rothwell
Hi all, After merging the char-misc tree, Friday's linux-next build (arm64 allmodconfig) failed like this: ERROR: modpost: "zynqmp_pm_fpga_get_status" [drivers/fpga/zynqmp-fpga.ko] undefined! ERROR: modpost: "zynqmp_pm_fpga_load" [drivers/fpga/zynqmp-fpga.ko] undefined! Presumably caused by

Re: [PATCH V2 00/11] Subject: Remove duplicated kmap code

2020-05-03 Thread Al Viro
On Sun, May 03, 2020 at 06:09:01PM -0700, ira.we...@intel.com wrote: > From: Ira Weiny > > The kmap infrastructure has been copied almost verbatim to every architecture. > This series consolidates obvious duplicated code by defining core functions > which call into the architectures only when

Re: [RFC v3 2/8] drm: ingenic-drm: add MODULE_DEVICE_TABLE

2020-05-03 Thread Paul Cercueil
Hi Nikolaus, Le dim. 29 mars 2020 à 19:35, H. Nikolaus Schaller a écrit : so that the driver can load by matching the device tree if compiled as module. Signed-off-by: H. Nikolaus Schaller Please add: Cc: sta...@vger.kernel.org # v5.3+ Fixes: 90b86fcc47b4 ("DRM: Add KMS driver for the

Re: [PATCH 3/5] sysctl: remove all extern declaration from sysctl.c

2020-05-03 Thread Stephen Rothwell
Hi Christoph, On Fri, 24 Apr 2020 08:43:36 +0200 Christoph Hellwig wrote: > > Extern declarations in .c files are a bad style and can lead to > mismatches. Use existing definitions in headers where they exist, > and otherwise move the external declarations to suitable header > files. > >

[PATCH V2 10/11] arch/kmap: Define kmap_atomic_prot() for all arch's

2020-05-03 Thread ira . weiny
From: Ira Weiny To support kmap_atomic_prot(), all architectures need to support protections passed to their kmap_atomic_high() function. Pass protections into kmap_atomic_high() and change the name to kmap_atomic_high_prot() to match. Then define kmap_atomic_prot() as a core function which

[PATCH V2 00/11] Subject: Remove duplicated kmap code

2020-05-03 Thread ira . weiny
From: Ira Weiny The kmap infrastructure has been copied almost verbatim to every architecture. This series consolidates obvious duplicated code by defining core functions which call into the architectures only when needed. Some of the k[un]map_atomic() implementations have some similarities but

[PATCH V2 02/11] arch/xtensa: Move kmap build bug out of the way

2020-05-03 Thread ira . weiny
From: Ira Weiny Move the kmap() build bug to kmap_init() to facilitate patches to lift kmap() to the core. Reviewed-by: Christoph Hellwig Signed-off-by: Ira Weiny --- Changes from V1: combine code onto 1 line. --- arch/xtensa/include/asm/highmem.h | 5 - arch/xtensa/mm/highmem.c

[PATCH V2 03/11] arch/kmap: Remove redundant arch specific kmaps

2020-05-03 Thread ira . weiny
From: Ira Weiny The kmap code for all the architectures is almost 100% identical. Lift the common code to the core. Use ARCH_HAS_KMAP_FLUSH_TLB to indicate if an arch defines kmap_flush_tlb() and call if if needed. This also has the benefit of changing kmap() on a number of architectures to

[PATCH V2 05/11] {x86,powerpc,microblaze}/kmap: Move preempt disable

2020-05-03 Thread ira . weiny
From: Ira Weiny During this kmap() conversion series we must maintain bisect-ability. To do this, kmap_atomic_prot() in x86, powerpc, and microblaze need to remain functional. Create a temporary inline version of kmap_atomic_prot within these architectures so we can rework their kmap_atomic()

[PATCH V2 06/11] arch/kmap_atomic: Consolidate duplicate code

2020-05-03 Thread ira . weiny
From: Ira Weiny Every arch has the same code to ensure atomic operations and a check for !HIGHMEM page. Remove the duplicate code by defining a core kmap_atomic() which only calls the arch specific kmap_atomic_high() when the page is high memory. Signed-off-by: Ira Weiny --- Changes from V1:

[PATCH V2 09/11] arch/kmap: Don't hard code kmap_prot values

2020-05-03 Thread ira . weiny
From: Ira Weiny To support kmap_atomic_prot() on all architectures each arch must support protections passed in to them. Change csky, mips, nds32 and xtensa to use their global constant kmap_prot rather than a hard coded value which was equal. Reviewed-by: Christoph Hellwig Signed-off-by: Ira

[PATCH V2 08/11] arch/kmap: Ensure kmap_prot visibility

2020-05-03 Thread ira . weiny
From: Ira Weiny We want to support kmap_atomic_prot() on all architectures and it makes sense to define kmap_atomic() to use the default kmap_prot. So we ensure all arch's have a globally available kmap_prot either as a define or exported symbol. Signed-off-by: Ira Weiny ---

[PATCH V2 04/11] arch/kunmap: Remove duplicate kunmap implementations

2020-05-03 Thread ira . weiny
From: Ira Weiny All architectures do exactly the same thing for kunmap(); remove all the duplicate definitions and lift the call to the core. This also has the benefit of changing kmap_unmap() on a number of architectures to be an inline call rather than an actual function. Reviewed-by:

[PATCH V2 11/11] drm: Remove drm specific kmap_atomic code

2020-05-03 Thread ira . weiny
From: Ira Weiny kmap_atomic_prot() is now exported by all architectures. Use this function rather than open coding a driver specific kmap_atomic. Reviewed-by: Christian König Reviewed-by: Christoph Hellwig Signed-off-by: Ira Weiny --- drivers/gpu/drm/ttm/ttm_bo_util.c| 56

[PATCH V2 01/11] arch/kmap: Remove BUG_ON()

2020-05-03 Thread ira . weiny
From: Ira Weiny Replace the use of BUG_ON(in_interrupt()) in the kmap() and kunmap() in favor of might_sleep(). Besides the benefits of might_sleep(), this normalizes the implementations such that they can be made generic in subsequent patches. Reviewed-by: Dan Williams Reviewed-by: Christoph

[PATCH V2 07/11] arch/kunmap_atomic: Consolidate duplicate code

2020-05-03 Thread ira . weiny
From: Ira Weiny Every single architecture (including !CONFIG_HIGHMEM) calls... pagefault_enable(); preempt_enable(); ... before returning from __kunmap_atomic(). Lift this code into the kunmap_atomic() macro. While we are at it rename __kunmap_atomic() to kunmap_atomic_high()

Re: DRM interaction problems on Ingenic CI20 / jz4780 with dw-hdmi and ingenic-drm

2020-05-03 Thread Paul Cercueil
Hi Nikolaus, So I just wrote a HDMI driver for a different chip, I guess I can answer some of your questions now. Le lun. 13 avril 2020 à 13:25, Paul Cercueil a écrit : Hi Nikolaus, Le sam. 11 avril 2020 à 16:14, H. Nikolaus Schaller a écrit : Hi, we (Paul Boddie and me) are working

Re: [PATCH 11/24] rcu/tree: Maintain separate array for vmalloc ptrs

2020-05-03 Thread Joel Fernandes
On Sun, May 03, 2020 at 05:20:32PM -0700, Paul E. McKenney wrote: > On Sun, May 03, 2020 at 07:42:50PM -0400, Joel Fernandes wrote: > > On Fri, May 01, 2020 at 02:37:53PM -0700, Paul E. McKenney wrote: > > [...] > > > > @@ -2993,41 +2994,73 @@ put_cached_bnode(struct kfree_rcu_cpu *krcp, > > > >

Re: [PATCH 12/14] docs: move remaining stuff under Documentation/*.txt to Documentation/staging

2020-05-03 Thread Joe Perches
On Mon, 2020-05-04 at 08:54 +0900, Masami Hiramatsu wrote: > On Fri, 1 May 2020 17:37:56 +0200 > Mauro Carvalho Chehab wrote: [] > > diff --git a/MAINTAINERS b/MAINTAINERS [] > > @@ -9855,7 +9855,7 @@ L:linux-kernel@vger.kernel.org > > L: linux-a...@vger.kernel.org > > S: Supported > > T:

Re: [PATCH 03/24] rcu/tree: Use consistent style for comments

2020-05-03 Thread Joel Fernandes
On Sun, May 03, 2020 at 05:23:09PM -0700, Paul E. McKenney wrote: > On Sun, May 03, 2020 at 07:44:00PM -0400, Joel Fernandes wrote: > > On Fri, May 01, 2020 at 01:52:46PM -0700, Joe Perches wrote: > > > On Fri, 2020-05-01 at 12:05 -0700, Paul E. McKenney wrote: > > > > On Tue, Apr 28, 2020 at

Re: [PATCH 03/24] rcu/tree: Use consistent style for comments

2020-05-03 Thread Joel Fernandes
On Sun, May 03, 2020 at 05:26:56PM -0700, Paul E. McKenney wrote: > On Sun, May 03, 2020 at 07:52:13PM -0400, Joel Fernandes wrote: > > On Fri, May 01, 2020 at 12:05:55PM -0700, Paul E. McKenney wrote: > > > On Tue, Apr 28, 2020 at 10:58:42PM +0200, Uladzislau Rezki (Sony) wrote: > > > > From:

Re: [PATCH 03/24] rcu/tree: Use consistent style for comments

2020-05-03 Thread Joe Perches
On Sun, 2020-05-03 at 17:23 -0700, Paul E. McKenney wrote: > On Sun, May 03, 2020 at 07:44:00PM -0400, Joel Fernandes wrote: > > On Fri, May 01, 2020 at 01:52:46PM -0700, Joe Perches wrote: [] > > > Perhaps a change to coding-style.rst > > > --- > > > diff --git

Re: [PATCH 19/24] rcu/tree: Support reclaim for head-less object

2020-05-03 Thread Joel Fernandes
On Sun, May 03, 2020 at 05:28:55PM -0700, Paul E. McKenney wrote: > On Sun, May 03, 2020 at 08:12:58PM -0400, Joel Fernandes wrote: > > On Fri, May 01, 2020 at 03:39:09PM -0700, Paul E. McKenney wrote: > > > On Tue, Apr 28, 2020 at 10:58:58PM +0200, Uladzislau Rezki (Sony) wrote: > > > > Update

Re: [PATCH 20/24] rcu/tree: Make kvfree_rcu() tolerate any alignment

2020-05-03 Thread Joel Fernandes
On Sun, May 03, 2020 at 05:29:47PM -0700, Paul E. McKenney wrote: > On Sun, May 03, 2020 at 08:24:37PM -0400, Joel Fernandes wrote: > > On Fri, May 01, 2020 at 04:00:52PM -0700, Paul E. McKenney wrote: > > > On Tue, Apr 28, 2020 at 10:58:59PM +0200, Uladzislau Rezki (Sony) wrote: > > > > From:

Re: [PATCH 20/24] rcu/tree: Make kvfree_rcu() tolerate any alignment

2020-05-03 Thread Paul E. McKenney
On Sun, May 03, 2020 at 08:24:37PM -0400, Joel Fernandes wrote: > On Fri, May 01, 2020 at 04:00:52PM -0700, Paul E. McKenney wrote: > > On Tue, Apr 28, 2020 at 10:58:59PM +0200, Uladzislau Rezki (Sony) wrote: > > > From: "Joel Fernandes (Google)" > > > > > > Handle cases where the the object

Re: [PATCH 19/24] rcu/tree: Support reclaim for head-less object

2020-05-03 Thread Paul E. McKenney
On Sun, May 03, 2020 at 08:12:58PM -0400, Joel Fernandes wrote: > On Fri, May 01, 2020 at 03:39:09PM -0700, Paul E. McKenney wrote: > > On Tue, Apr 28, 2020 at 10:58:58PM +0200, Uladzislau Rezki (Sony) wrote: > > > Update the kvfree_call_rcu() with head-less support, it > > > means an object

Re: [PATCH 03/24] rcu/tree: Use consistent style for comments

2020-05-03 Thread Paul E. McKenney
On Sun, May 03, 2020 at 07:52:13PM -0400, Joel Fernandes wrote: > On Fri, May 01, 2020 at 12:05:55PM -0700, Paul E. McKenney wrote: > > On Tue, Apr 28, 2020 at 10:58:42PM +0200, Uladzislau Rezki (Sony) wrote: > > > From: "Joel Fernandes (Google)" > > > > > > Simple clean up of comments in

Re: [PATCH 22/24] rcu/tiny: support reclaim for head-less object

2020-05-03 Thread Joel Fernandes
On Fri, May 01, 2020 at 04:06:38PM -0700, Paul E. McKenney wrote: > On Tue, Apr 28, 2020 at 10:59:01PM +0200, Uladzislau Rezki (Sony) wrote: > > Make a kvfree_call_rcu() function to support head-less > > freeing. Same as for tree-RCU, for such purpose we store > > pointers in array. SLAB and

Re: [PATCH RFC 04/15] drivers/base: Add support for a new IMS irq domain

2020-05-03 Thread Dey, Megha
On 5/3/2020 3:46 PM, Jason Gunthorpe wrote: On Sun, May 03, 2020 at 03:40:44PM -0700, Dey, Megha wrote: On 5/3/2020 3:25 PM, Jason Gunthorpe wrote: On Fri, May 01, 2020 at 03:30:02PM -0700, Dey, Megha wrote: Hi Jason, On 4/23/2020 1:11 PM, Jason Gunthorpe wrote: On Tue, Apr 21, 2020 at

Re: [PATCH 20/24] rcu/tree: Make kvfree_rcu() tolerate any alignment

2020-05-03 Thread Joel Fernandes
On Fri, May 01, 2020 at 04:00:52PM -0700, Paul E. McKenney wrote: > On Tue, Apr 28, 2020 at 10:58:59PM +0200, Uladzislau Rezki (Sony) wrote: > > From: "Joel Fernandes (Google)" > > > > Handle cases where the the object being kvfree_rcu()'d is not aligned by > > 2-byte boundaries. > > > >

Re: [PATCH 03/24] rcu/tree: Use consistent style for comments

2020-05-03 Thread Paul E. McKenney
On Sun, May 03, 2020 at 07:44:00PM -0400, Joel Fernandes wrote: > On Fri, May 01, 2020 at 01:52:46PM -0700, Joe Perches wrote: > > On Fri, 2020-05-01 at 12:05 -0700, Paul E. McKenney wrote: > > > On Tue, Apr 28, 2020 at 10:58:42PM +0200, Uladzislau Rezki (Sony) wrote: > > > > Simple clean up of

Re: [PATCH 11/24] rcu/tree: Maintain separate array for vmalloc ptrs

2020-05-03 Thread Paul E. McKenney
On Sun, May 03, 2020 at 07:42:50PM -0400, Joel Fernandes wrote: > On Fri, May 01, 2020 at 02:37:53PM -0700, Paul E. McKenney wrote: > [...] > > > @@ -2993,41 +2994,73 @@ put_cached_bnode(struct kfree_rcu_cpu *krcp, > > > static void kfree_rcu_work(struct work_struct *work) > > > { > > >

Re: [PATCH RFC 00/15] Add VFIO mediated device support and IMS support for the idxd driver.

2020-05-03 Thread Dey, Megha
On 5/3/2020 3:36 PM, Jason Gunthorpe wrote: On Sun, May 03, 2020 at 03:31:39PM -0700, Dey, Megha wrote: Hi Jason, On 5/3/2020 3:22 PM, Jason Gunthorpe wrote: On Fri, May 01, 2020 at 03:31:51PM -0700, Dey, Megha wrote: This has been my concern reviewing the implementation. IMS needs more

  1   2   3   4   5   >