Re: [PATCH v2 03/10] kexec: separate PageHighMem() and PageHighMemZone() use case

2020-05-05 Thread Joonsoo Kim
On Mon, May 04, 2020 at 09:03:56AM -0500, Eric W. Biederman wrote: > > I have added in the kexec mailling list. > > Looking at the patch we are discussing it appears that the kexec code > could be doing much better in highmem situations today but is not. Sound great! > > > Joonsoo Kim

Re: [PATCH 0/3] kasan: memorize and print call_rcu stack

2020-05-05 Thread Qian Cai
> On May 6, 2020, at 1:19 AM, Walter Wu wrote: > > This patchset improves KASAN reports by making them to have > call_rcu() call stack information. It is helpful for programmers > to solve use-after-free or double-free memory issue. > > The KASAN report was as follows(cleaned up slightly): >

[no subject]

2020-05-05 Thread Jiaxun Yang
Subject: [PATCH v6] MIPS: Truncate link address into 32bit for 32bit kernel In-Reply-To: <20200413062651.3992652-1-jiaxun.y...@flygoat.com> LLD failed to link vmlinux with 64bit load address for 32bit ELF while bfd will strip 64bit address into 32bit silently. To fix LLD build, we should truncate

MAINTAINERS: Wrong ordering in DYNAMIC INTERRUPT MODERATION

2020-05-05 Thread Lukas Bulwahn
Hi Jakub, with your commit 9b038086f06b ("docs: networking: convert DIM to RST"), visible on next-20200505, ./scripts/checkpatch.pl -f MAINTAINERS complains: WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order #5966: FILE: MAINTAINERS:5966: +F: l

[PATCH v2 5/5] [media] mtk-mdp: Remove mtk_mdp_comp.id and supporting functionality

2020-05-05 Thread Eizan Miyamoto
Since components are registered in a list, the numeric component id that specified a location in an array is not necessary. Signed-off-by: ei...@chromium.org Signed-off-by: Eizan Miyamoto --- Changes in v1: - rebase onto linux-next/master to pick up 757570f11fa4b0ce5472a6583de6f06e996a8527

[PATCH v2 4/5] [media] mtk-mdp: convert mtk_mdp_dev.comp array to list

2020-05-05 Thread Eizan Miyamoto
The functions mtk_mdp_register/unregister_component have been created to add / remove items from the list of components. This will eventually enable us to specify a list of components in the device tree instead of hardcoding them into this driver. The list is modified by a single thread at

[PATCH v2 1/5] [media] mtk-mdp: remove mtk_mdp_comp.regs from mtk_mdp_comp.h

2020-05-05 Thread Eizan Miyamoto
These fields are not used and can be removed. Signed-off-by: ei...@chromium.org Reviewed-by: Enric Balletbo I Serra Signed-off-by: Eizan Miyamoto --- Changes in v1: None drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 1 - drivers/media/platform/mtk-mdp/mtk_mdp_comp.h | 2 -- 2 files

[PATCH v2 0/5] MTK MDP driver cleanups to prep for futher work

2020-05-05 Thread Eizan Miyamoto
It most notably converts an array of MDP components to a list instead, but also removes some unused fields. This series of patches does some cleanup in preparation for futher work so that hardware video decode works on 4.19 and later kernels. We are planning on adding a dummy driver for the

[PATCH v2 3/5] [media] mtk-mdp: handle vpu_wdt_reg_handler() errors during probe

2020-05-05 Thread Eizan Miyamoto
This is a cleanup to better handle errors during MDP probe. Signed-off-by: ei...@chromium.org Signed-off-by: Eizan Miyamoto --- Changes in v1: - remove unnecessary error handling labels in favor of err_m2m_register drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++-- 1 file changed, 6

[PATCH v2 2/5] [media] mtk-mdp: handle vb2_dma_contig_set_max_seg_size errors during probe

2020-05-05 Thread Eizan Miyamoto
This is a cleanup to better handle errors during MDP probe. Signed-off-by: ei...@chromium.org Signed-off-by: Eizan Miyamoto --- Changes in v1: - remove unnecessary error handling labels in favor of err_m2m_register drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 6 +- 1 file changed, 5

RE: [PATCH v2 2/2] PCI: hv: Retry PCI bus D0 entry when the first attempt failed with invalid device state

2020-05-05 Thread Wei Hu
> -Original Message- > From: Lorenzo Pieralisi > Sent: Tuesday, May 5, 2020 11:10 PM > To: Wei Hu > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > wei@kernel.org; r...@kernel.org; bhelg...@google.com; linux- > hyp...@vger.kernel.org; linux-...@vger.kernel.org; linux- >

MAINTAINERS: Wrong ordering in S390 PCI SUBSYSTEM

2020-05-05 Thread Lukas Bulwahn
Hi Pierre, with your commit de267a7c71ba ("s390/pci: Documentation for zPCI"), visible on next-20200505, ./scripts/checkpatch.pl -f MAINTAINERS complains: WARNING: Misordered MAINTAINERS entry - list file patterns in alphabetic order #14723: FILE: MAINTAINERS:14723: +F: drivers/p

RE: [PATCH v2 1/2] PCI: hv: Fix the PCI HyperV probe failure path to release resource properly

2020-05-05 Thread Wei Hu
Hi Lorenzo, Thanks for your review. Please see my comments inline. > -Original Message- > From: Lorenzo Pieralisi > Sent: Tuesday, May 5, 2020 11:03 PM > To: Wei Hu > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > wei@kernel.org; r...@kernel.org; bhelg...@google.com;

[PATCH v2 RESEND] MAINTAINERS: rectify MMP SUPPORT after moving cputype.h

2020-05-05 Thread Lukas Bulwahn
tries by entry name") and commit 3b50142d8528 ("MAINTAINERS: sort field names for all entries"). - PATCH v2 applies on v5.7-rc1 now. Please pick v2 instead of v1. v2-resend: - still applies on v5.7-rc4 and next-20200505 - asking for inclusion through trivial tree, as mainta

Re: [PATCH v3 1/2] arm: rpi: Add function to trigger VL805's firmware load

2020-05-05 Thread Bin Meng
Hi Nicolas, On Wed, May 6, 2020 at 12:26 AM Nicolas Saenz Julienne wrote: > > On the Raspberry Pi 4, after a PCI reset, VL805's (a xHCI chip) firmware > may either be loaded directly from an EEPROM or, if not present, by the > SoC's VideCore (the SoC's co-processor). Introduce the function that

Re: [PATCH] uprobes: ensure that uprobe->offset and ->ref_ctr_offset are properly aligned

2020-05-05 Thread Srikar Dronamraju
* Oleg Nesterov [2020-05-04 18:47:25]: > uprobe_write_opcode() must not cross page boundary; prepare_uprobe() > relies on arch_uprobe_analyze_insn() which should validate "vaddr" but > some architectures (csky, s390, and sparc) don't do this. > > We can remove the BUG_ON() check in

Re: [PATCH] virtio_net: fix lockdep warning on 32 bit

2020-05-05 Thread Jason Wang
On 2020/5/6 上午8:01, Michael S. Tsirkin wrote: When we fill up a receive VQ, try_fill_recv currently tries to count kicks using a 64 bit stats counter. Turns out, on a 32 bit kernel that uses a seqcount. sequence counts are "lock" constructs where you need to make sure that writers are

[PATCH 3/3] kasan: add KASAN_RCU_STACK_RECORD documentation

2020-05-05 Thread Walter Wu
This adds the documentation for the KASAN_RCU_STACK_RECORD config option. Signed-off-by: Walter Wu Cc: Andrey Ryabinin Cc: Dmitry Vyukov Cc: Alexander Potapenko Cc: Jonathan Corbet --- Documentation/dev-tools/kasan.rst | 21 + 1 file changed, 21 insertions(+) diff --git

[PATCH 2/3] kasan: record and print the free track

2020-05-05 Thread Walter Wu
We add new KASAN_RCU_STACK_RECORD configuration option. It will move free track from slub meta-data (struct kasan_alloc_meta) into freed object. Because we hope this options doesn't enlarge slub meta-data size. This option doesn't enlarge struct kasan_alloc_meta size. - add two call_rcu() call

[PATCH v2 RESEND] MAINTAINERS: correct typo in new NXP LAYERSCAPE GEN4

2020-05-05 Thread Lukas Bulwahn
l.org/lkml/20200413070649.7014-1-lukas.bulw...@gmail.com/ - still applies to v5.7-rc4 and next-20200505 MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e64e5db31497..0fd27329e6f7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12941,7 +1294

[PATCH 1/3] rcu/kasan: record and print call_rcu() call stack

2020-05-05 Thread Walter Wu
When call_rcu() is called, we store the call_rcu() call stack into slub alloc meta-data, so that KASAN report prints call_rcu() information. We add new KASAN_RCU_STACK_RECORD configuration option. It will record first and last call_rcu() call stack and KASAN report will print two call_rcu() call

[PATCH 0/3] kasan: memorize and print call_rcu stack

2020-05-05 Thread Walter Wu
This patchset improves KASAN reports by making them to have call_rcu() call stack information. It is helpful for programmers to solve use-after-free or double-free memory issue. The KASAN report was as follows(cleaned up slightly): BUG: KASAN: use-after-free in kasan_rcu_reclaim+0x58/0x60 Freed

Re: [PATCH net v2 1/2] Revert "coallocate socket_wq with socket itself"

2020-05-05 Thread kbuild test robot
755f5738ff981769211a0bfac709d514ef5b9f86 config: x86_64-randconfig-g001-20200505 (attached as .config) compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 24b4965ce65b14ead595dcc68add22ba37533207) reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master

Re: [PATCH v5 0/7] Add interrupt support to FPGA DFL drivers

2020-05-05 Thread Xu Yilun
Hi Moritz: Hao and I did several rounds of review and fix in the mailing list. Now the patches are all acked by Hao. Could you please help review it when you have time? Thanks! :) On Mon, Apr 20, 2020 at 04:11:36PM +0800, Xu Yilun wrote: > This patchset add interrupt support to FPGA DFL

Re: [PATCH] xenbus: avoid stack overflow warning

2020-05-05 Thread Jürgen Groß
On 05.05.20 22:57, Arnd Bergmann wrote: On Tue, May 5, 2020 at 6:02 PM Jürgen Groß wrote: On 05.05.20 17:01, Arnd Bergmann wrote: On Tue, May 5, 2020 at 4:34 PM Jürgen Groß wrote: On 05.05.20 16:15, Arnd Bergmann wrote: I considered that as well, and don't really mind either way. I think

Re: [PATCH] crypto: blake2b - Fix clang optimization for ARMv7-M

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 03:53:45PM +0200, Arnd Bergmann wrote: > When building for ARMv7-M, clang-9 or higher tries to unroll some loops, > which ends up confusing the register allocator to the point of generating > rather bad code and using more than the warning limit for stack frames: > >

Re: [PATCH v1] dt-bindings: net: nxp,tja11xx: rework validation support

2020-05-05 Thread Oleksij Rempel
On Tue, May 05, 2020 at 04:01:27PM +0200, Andrew Lunn wrote: > On Tue, May 05, 2020 at 12:42:15PM +0200, Oleksij Rempel wrote: > > To properly identify this node, we need to use ethernet-phy-id0180.dc80. > > And add missing required properties. > > > > Signed-off-by: Oleksij Rempel > > --- > >

[PATCH -next] drm/amdgpu/navi10: fix unsigned comparison with 0

2020-05-05 Thread ChenTao
Fixes warning because size is uint32_t and can never be negtative drivers/gpu/drm/amd/amdgpu/../powerplay/navi10_ppt.c:1296:12: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] if (size < 0) Reported-by: Hulk Robot Signed-off-by: ChenTao ---

Re: [PATCH v4 04/10] loop: Refactor loop_set_status() size calculation

2020-05-05 Thread Christoph Hellwig
On Fri, May 01, 2020 at 09:33:23PM +0200, Martijn Coenen wrote: > On Fri, May 1, 2020 at 7:30 PM Christoph Hellwig wrote: > > > > For some reason this fails to apply for me against both > > Jens' for-5.8/block and Linus' current tree. > > > > What is the baseline for this series? > > This was

Re: [PATCH 1/2] riscv: defconfig: enable spi nor on Hifive Unleashed A00 board.

2020-05-05 Thread Anup Patel
On Wed, May 6, 2020 at 9:26 AM Sagar Kadam wrote: > > Hi Palmer, > > > -Original Message- > > From: Palmer Dabbelt > > Sent: Wednesday, May 6, 2020 4:54 AM > > To: Sagar Kadam > > Cc: tudor.amba...@microchip.com; miquel.ray...@bootlin.com; > > rich...@nod.at; vigne...@ti.com; Paul

[GIT PULL] Crypto Fixes for 5.7

2020-05-05 Thread Herbert Xu
Hi Linus: This push fixes a potential scheduling latency problem for the algorithms used by WireGuard. The following changes since commit 55b3209acbb01cb02b1ee6b1afe80d83b1aab36d: crypto: caam - fix the address of the last entry of S/G (2020-04-16 16:48:56 +1000) are available in the Git

[PATCH -next] firmware: imx: scu: Fix possible memory leak in imx_scu_probe()

2020-05-05 Thread Wei Yongjun
'chan_name' is malloced in imx_scu_probe() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: edbee095fafb ("firmware: imx: add SCU firmware driver support") Signed-off-by: Wei Yongjun --- drivers/firmware/imx/imx-scu.c | 1 + 1 file

Re: [PATCH v2 1/6] kunit: Kconfig: enable a KUNIT_RUN_ALL fragment

2020-05-05 Thread David Gow
On Tue, May 5, 2020 at 6:27 PM Anders Roxell wrote: > > Make it easier to enable all KUnit fragments. This is needed for kernel > test-systems, so its easy to get all KUnit tests enabled and if new gets > added they will be enabled as well. Fragments that has to be builtin > will be missed if

[PATCH RESEND] MAINTAINERS: adjust entries to moving CEC platform drivers

2020-05-05 Thread Lukas Bulwahn
--- Mauro, please pick this non-urgent minor clean-up patch on top of the CEC platform driver moves. applies cleanly on next-20200417 and still on next-20200505 for this resend. v1 send here: https://lore.kernel.org/lkml/20200418093630.6149-1-lukas.bulw...@gmail.com/ MAINTAINERS | 14 ++--

Re: [PATCH 1/2] net: qed*: Reduce RX and TX default ring count when running inside kdump kernel

2020-05-05 Thread Bhupesh Sharma
Hi David, On Wed, May 6, 2020 at 2:54 AM David Miller wrote: > > From: Bhupesh Sharma > Date: Wed, 6 May 2020 00:34:40 +0530 > > > -#define NUM_RX_BDS_DEF ((u16)BIT(10) - 1) > > +#define NUM_RX_BDS_DEF ((is_kdump_kernel()) ? ((u16)BIT(6) - > > 1) : ((u16)BIT(10) -

Re: [PATCH 7/7] sysvipc_find_ipc should increase position index

2020-05-05 Thread Vasily Averin
On 5/5/20 7:13 PM, Andreas Schwab wrote: > I think this is causing this bug (seen on 5.6.8): thank you for reporting, yes, you are right, it's my fault patch incorrectly updated *new_pos in case of found entry > # ipcs -q > > -- Message Queues > keymsqid owner

[PATCH v2] [media] mtk-mdp: Remove states for format checks

2020-05-05 Thread Eizan Miyamoto
From: Francois Buergisser The mtk-mdp driver uses states to check if the formats have been set on the capture and output when turning the streaming on, setting controls or setting the selection rectangles. Those states are reset when 0 buffers are requested like when checking capabilities. This

[PATCH v4 1/1] scsi: pm: Balance pm_only counter of request queue during system resume

2020-05-05 Thread Can Guo
During system resume, scsi_resume_device() decreases a request queue's pm_only counter if the scsi device was quiesced before. But after that, if the scsi device's RPM status is RPM_SUSPENDED, the pm_only counter is still held (non-zero). Current scsi resume hook only sets the RPM status of the

Re: [PATCH 1/1] s390/dasd: remove ioctl_by_bdev from DASD driver

2020-05-05 Thread Christoph Hellwig
On Tue, May 05, 2020 at 05:09:56PM +0200, Stefan Haberland wrote: > OK, thanks for the hint.I did not have this in mind. And I still have > to look up how this is working at all. > But isn't this only a real issue for devices with more than 16 minors > or partitions? So it should not be a problem

Re: [PATCH net-next v3] net: phy: micrel: add phy-mode support for the KSZ9031 PHY

2020-05-05 Thread Oleksij Rempel
Hi Grygorii, On Tue, May 05, 2020 at 09:26:46PM +0300, Grygorii Strashko wrote: > > > On 22/04/2020 10:21, Oleksij Rempel wrote: > > Add support for following phy-modes: rgmii, rgmii-id, rgmii-txid, > > rgmii-rxid. > > > > This PHY has an internal RX delay of 1.2ns and no delay for TX. > > >

[PATCH 1/2] net: qrtr: Add MHI transport layer

2020-05-05 Thread Manivannan Sadhasivam
MHI is the transport layer used for communicating to the external modems. Hence, this commit adds MHI transport layer support to QRTR for transferring the QMI messages over IPC Router. Reviewed-by: Bjorn Andersson Signed-off-by: Manivannan Sadhasivam --- net/qrtr/Kconfig | 7 +++

[PATCH 2/2] net: qrtr: Do not depend on ARCH_QCOM

2020-05-05 Thread Manivannan Sadhasivam
IPC Router protocol is also used by external modems for exchanging the QMI messages. Hence, it doesn't always depend on Qualcomm platforms. One such instance is the QCA6390 WLAN device connected to x86 machine. Reviewed-by: Bjorn Andersson Signed-off-by: Manivannan Sadhasivam ---

Re: [PATCH] serial: lantiq: Add x86 in Kconfig dependencies for Lantiq serial driver

2020-05-05 Thread Tanwar, Rahul
On 5/5/2020 10:25 pm, Greg KH wrote: > On Mon, May 04, 2020 at 04:03:52PM +0800, Rahul Tanwar wrote: >> Lantiq serial driver/IP is reused for a x86 based SoC as well. >> Update the Kconfig accordingly. >> >> Signed-off-by: Rahul Tanwar >> --- >> drivers/tty/serial/Kconfig | 2 +- >> 1 file

Re: [PATCH v2] kcsan: Add test suite

2020-05-05 Thread David Gow
On Wed, May 6, 2020 at 2:30 AM Marco Elver wrote: > > This adds KCSAN test focusing on behaviour of the integrated runtime. > Tests various race scenarios, and verifies the reports generated to > console. Makes use of KUnit for test organization, and the Torture > framework for test thread

Proper use for linking foo.o_shipped after 69ea912fda74 ("kbuild: remove unneeded link_multi_deps")?

2020-05-05 Thread Florian Fainelli
Hi Masahiro, Michal, While updating our systems from 4.9 to 5.4, we noticed that one of the kernel modules that we build, which is done by linking an object that we pre-compile out of Kbuild stopped working. I bisected it down to: commit 69ea912fda74a673d330d23595385e5b73e3a2b9

RE: [EXT] [PATCH] scsi: qedi: remove Comparison of 0/1 to bool variable

2020-05-05 Thread Manish Rangankar
> -Original Message- > From: Jason Yan > Sent: Thursday, April 30, 2020 5:47 PM > To: qlogic-storage-upstr...@cavium.com; j...@linux.ibm.com; > martin.peter...@oracle.com; Manish Rangankar > ; linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org > Cc: Jason Yan > Subject: [EXT]

Re: [PATCH] x86: bitops: fix build regression

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 10:44:22AM -0700, Nick Desaulniers wrote: > From: Sedat Dilek > > It turns out that if your config tickles __builtin_constant_p via > differences in choices to inline or not, this now produces invalid > assembly: > > $ cat foo.c > long a(long b, long c) { >

Re: [PATCH 2/2] powerpc/perf: Add support for outputting extended regs in perf intr_regs

2020-05-05 Thread Madhavan Srinivasan
On 4/29/20 11:34 AM, Anju T Sudhakar wrote: The capability flag PERF_PMU_CAP_EXTENDED_REGS, is used to indicate the PMU which support extended registers. The generic code define the mask of extended registers as 0 for non supported architectures. Add support for extended registers in POWER9

[PATCH v3 4/5] ntb_perf: increase sleep time from one milli sec to one sec

2020-05-05 Thread Sanjay R Mehta
After trying to send commands for a maximum of MSG_TRIES re-tries, link-up fails due to short sleep time(1ms) between re-tries. Hence increasing the sleep time to one second providing sufficient time for perf link-up. Signed-off-by: Sanjay R Mehta Signed-off-by: Arindam Nath ---

[PATCH v3 2/5] ntb_perf: pass correct struct device to dma_alloc_coherent

2020-05-05 Thread Sanjay R Mehta
Currently, ntb->dev is passed to dma_alloc_coherent and dma_free_coherent calls. The returned dma_addr_t is the CPU physical address. This works fine as long as IOMMU is disabled. But when IOMMU is enabled, we need to make sure that IOVA is returned for dma_addr_t. So the correct way to achieve

[PATCH v3 3/5] ntb_tool: pass correct struct device to dma_alloc_coherent

2020-05-05 Thread Sanjay R Mehta
Currently, ntb->dev is passed to dma_alloc_coherent and dma_free_coherent calls. The returned dma_addr_t is the CPU physical address. This works fine as long as IOMMU is disabled. But when IOMMU is enabled, we need to make sure that IOVA is returned for dma_addr_t. So the correct way to achieve

[PATCH v3 5/5] ntb_perf: avoid false dma unmap of destination address

2020-05-05 Thread Sanjay R Mehta
The DMA map and unmap of destination address is already being done in perf_init_test() and perf_clear_test() functions. Hence avoiding it by making necessary changes in perf_copy_chunk() function. Signed-off-by: Sanjay R Mehta Signed-off-by: Arindam Nath --- drivers/ntb/test/ntb_perf.c | 11

[PATCH v3 0/5] ntb perf, ntb tool and ntb-hw improvements

2020-05-05 Thread Sanjay R Mehta
v3: - Increased ntb_perf command re-try sleep time - avoid false dma unmap of dst address. v2: Incorporated improvements suggested by Logan Gunthorpe Links of the review comments for v3: 1. https://lkml.org/lkml/2020/3/11/981 2. https://lkml.org/lkml/2020/3/10/1827 Logan Gunthorpe (1): ntb:

[PATCH v3 1/5] ntb: hw: remove the code that sets the DMA mask

2020-05-05 Thread Sanjay R Mehta
From: Logan Gunthorpe This patch removes the code that sets the DMA mask as it no longer makes sense to do this. Fixes: 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port NTB API support") Signed-off-by: Logan Gunthorpe Tested-by: Alexander Fomichev Signed-off-by: Sanjay R Mehta ---

Re: [PATCH v3 12/14] PCI: j721e: Add TI J721E PCIe driver

2020-05-05 Thread Kishon Vijay Abraham I
Hi Rob, On 4/30/2020 7:41 AM, Rob Herring wrote: > On Fri, Apr 17, 2020 at 06:27:51PM +0530, Kishon Vijay Abraham I wrote: >> Add support for PCIe controller in J721E SoC. The controller uses the >> Cadence PCIe core programmed by pcie-cadence*.c. The PCIe controller >> will work in both host

Re: [PATCH v8 1/5] dt-bindings: phy: Add binding for qcom,usb-snps-femto-v2

2020-05-05 Thread Vinod Koul
On 05-05-20, 12:38, Wesley Cheng wrote: > > > On 5/5/2020 6:34 AM, Rob Herring wrote: > > On Mon, 4 May 2020 16:54:23 -0700, Wesley Cheng wrote: > >> This binding shows the descriptions and properties for the > >> Synopsis Femto USB PHY V2 used on QCOM platforms. > >> > >> Signed-off-by: Wesley

Re: KASAN: slab-out-of-bounds Read in gadget_dev_desc_UDC_store

2020-05-05 Thread Kyungtae Kim
On Fri, May 01, 2020 at 09:05:38AM +0200, Greg KH wrote: > On Thu, Apr 30, 2020 at 11:03:54PM -0400, Kyungtae Kim wrote: > > We report a bug (in linux-5.6.8) found by FuzzUSB (a modified version > > of syzkaller). > > > > This happened when the size of "name" buffer is smaller than that of > >

[PATCH] USB: gadget: fix illegal array access in binding with UDC

2020-05-05 Thread Kyungtae Kim
FuzzUSB (a variant of syzkaller) found an illegal array access using an incorrect index while binding a gadget with UDC. Reference: https://www.spinics.net/lists/linux-usb/msg194331.html This bug occurs when a size variable used for a buffer is misused to access its strcpy-ed buffer. Given a

Re: [PATCH 1/4] block: Move SECTORS_PER_PAGE and SECTORS_PER_PAGE_SHIFT definitions into

2020-05-05 Thread Leizhen (ThunderTown)
On 2020/5/5 20:10, Matthew Wilcox wrote: > On Tue, May 05, 2020 at 07:55:40PM +0800, Zhen Lei wrote: >> +#ifndef SECTORS_PER_PAGE_SHIFT >> +#define SECTORS_PER_PAGE_SHIFT (PAGE_SHIFT - SECTOR_SHIFT) >> +#endif >> +#ifndef SECTORS_PER_PAGE >> +#define SECTORS_PER_PAGE(1 <<

Re: [PATCH] securityfs: Add missing d_delete() call on removal

2020-05-05 Thread Al Viro
On Tue, May 05, 2020 at 08:28:33PM -0700, Kees Cook wrote: > On Wed, May 06, 2020 at 02:14:31AM +0100, Al Viro wrote: > > On Tue, May 05, 2020 at 04:40:35PM -0700, Kees Cook wrote: > > > After using simple_unlink(), a call to d_delete() is needed in addition > > > to dput(). > > > > > >

Re: [PATCH v3 09/14] PCI: cadence: Add MSI-X support to Endpoint driver

2020-05-05 Thread Kishon Vijay Abraham I
Hi Rob, On 4/30/2020 7:25 AM, Rob Herring wrote: > On Fri, Apr 17, 2020 at 06:27:48PM +0530, Kishon Vijay Abraham I wrote: >> From: Alan Douglas >> >> Implement ->set_msix() and ->get_msix() callback functions in order >> to configure MSIX capability in the PCIe endpoint controller. >> >> Add

RE: [PATCH 1/2] riscv: defconfig: enable spi nor on Hifive Unleashed A00 board.

2020-05-05 Thread Sagar Kadam
Hi Palmer, > -Original Message- > From: Palmer Dabbelt > Sent: Wednesday, May 6, 2020 4:54 AM > To: Sagar Kadam > Cc: tudor.amba...@microchip.com; miquel.ray...@bootlin.com; > rich...@nod.at; vigne...@ti.com; Paul Walmsley > ; linux-ri...@lists.infradead.org; linux- >

Re: [PATCH v3 14/14] MAINTAINERS: Add Kishon Vijay Abraham I for TI J721E SoC PCIe

2020-05-05 Thread Kishon Vijay Abraham I
Hi Joe, On 4/17/2020 8:49 PM, Joe Perches wrote: > On Fri, 2020-04-17 at 18:27 +0530, Kishon Vijay Abraham I wrote: >> Add Kishon Vijay Abraham I as MAINTAINER for TI J721E SoC PCIe. > [] >> diff --git a/MAINTAINERS b/MAINTAINERS > [] >> @@ -12968,13 +12968,15 @@ S: Maintained >> F:

Re: [PATCH v2] security: disable FORTIFY_SOURCE on clang

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 07:54:09PM -0700, Kees Cook wrote: > On Tue, May 05, 2020 at 06:14:53PM -0600, Jason A. Donenfeld wrote: > > clang-10 has a broken optimization stage that doesn't allow the > > compiler to prove at compile time that certain memcpys are within > > bounds, and thus the

[PATCH] KVM: VMX: Explicitly clear RFLAGS.CF and RFLAGS.ZF in VM-Exit RSB path

2020-05-05 Thread Sean Christopherson
Clear CF and ZF in the VM-Exit path after doing __FILL_RETURN_BUFFER so that KVM doesn't interpret clobbered RFLAGS as a VM-Fail. Filling the RSB has always clobbered RFLAGS, its current incarnation just happens clear CF and ZF in the processs. Relying on the macro to clear CF and ZF is

[PATCH] iio: sca3000: Remove an erroneous 'get_device()'

2020-05-05 Thread Christophe JAILLET
This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' call. Remove it. While at it add a missing \n at the end of the message. Signed-off-by: Christophe JAILLET --- This patch is purely speculative. I've looked a bit arround and see no point for this get_device() but other

Re: [PATCH 2/4] mm/swap: use SECTORS_PER_PAGE_SHIFT to clean up code

2020-05-05 Thread Leizhen (ThunderTown)
On 2020/5/6 9:33, Leizhen (ThunderTown) wrote: > > > On 2020/5/6 1:25, Matthew Wilcox wrote: >> On Tue, May 05, 2020 at 07:55:41PM +0800, Zhen Lei wrote: >>> +++ b/mm/swapfile.c >>> @@ -177,8 +177,8 @@ static int discard_swap(struct swap_info_struct *si) >>> >>> /* Do not discard the

Re: [PATCH] arm64: disable patchable function entry on big-endian clang builds

2020-05-05 Thread Nathan Chancellor
+ Fangrui, who implemented patchable_function_entry in LLVM/clang On Tue, May 05, 2020 at 07:42:43PM +0200, Torsten Duwe wrote: > Hi Arnd, Mark and others, > > this may not be worth arguing but I'm currently fighting excessive > workarounds in another area and so this triggers me, so I have to

callchain ABI change with commit 6cbc304f2f360

2020-05-05 Thread Stephane Eranian
Hi, I have received reports from users who have noticed a change of behaviour caused by commit: 6cbc304f2f360 ("perf/x86/intel: Fix unwind errors from PEBS entries (mk-II)") When using PEBS sampling on Intel processors. Doing simple profiling with: $ perf record -g -e cycles:pp ... Before: 1

Re: [PATCH v2] security: disable FORTIFY_SOURCE on clang

2020-05-05 Thread Jason A. Donenfeld
On Tue, May 5, 2020 at 8:54 PM Kees Cook wrote: > > On Tue, May 05, 2020 at 06:14:53PM -0600, Jason A. Donenfeld wrote: > > clang-10 has a broken optimization stage that doesn't allow the > > compiler to prove at compile time that certain memcpys are within > > bounds, and thus the outline memcpy

Re: Intel KVM entry failed, hardware error 0x0

2020-05-05 Thread Sean Christopherson
On Tue, May 05, 2020 at 08:00:15PM -0700, Sean Christopherson wrote: > On Tue, May 05, 2020 at 10:32:15PM -0400, Qian Cai wrote: > > Today’s linux-next started to fail with this config, > > > > https://raw.githubusercontent.com/cailca/linux-mm/master/kcsan.config > > > >

RE: [PATCH net-next 1/1] net: stmmac: Add option for VLAN filter fail queue enable

2020-05-05 Thread Wong, Vee Khee
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of David Miller > Sent: Friday, April 24, 2020 6:53 AM > To: Wong, Vee Khee > Cc: peppe.cavall...@st.com; alexandre.tor...@st.com; > joab...@synopsys.com; mcoquelin.st...@gmail.com; > net...@vger.kernel.org;

Re: [PATCH] securityfs: Add missing d_delete() call on removal

2020-05-05 Thread Kees Cook
On Wed, May 06, 2020 at 02:14:31AM +0100, Al Viro wrote: > On Tue, May 05, 2020 at 04:40:35PM -0700, Kees Cook wrote: > > After using simple_unlink(), a call to d_delete() is needed in addition > > to dput(). > > > > Signed-off-by: Kees Cook > > --- > > Is this correct? I went looking around and

[PATCH] i2c: puv3: Fix an error handling path in 'puv3_i2c_probe()'

2020-05-05 Thread Christophe JAILLET
There is a spurious 'put_device()' in the remove function. A reference to 'pdev->dev' is taken in the probe function without a corresponding 'get_device()' to increment the refcounted reference. Add the missing 'get_device()' and update the error handling path accordingly. Fixes: d10e4a660d11

RE: [GIT PULL] vhost: fixes

2020-05-05 Thread Justin He
Hi Michael > -Original Message- > From: Michael S. Tsirkin > Sent: Monday, May 4, 2020 8:16 PM > To: Linus Torvalds > Cc: k...@vger.kernel.org; virtualizat...@lists.linux-foundation.org; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; Justin He > ; ldi...@redhat.com;

Re: [PATCH v2 2/4] PCI: cadence: Use "dma-ranges" instead of "cdns,no-bar-match-nbits" property

2020-05-05 Thread Kishon Vijay Abraham I
Hi Robin, On 5/4/2020 6:23 PM, Kishon Vijay Abraham I wrote: > Hi Robin, > > On 5/4/2020 4:24 PM, Robin Murphy wrote: >> On 2020-05-04 9:44 am, Kishon Vijay Abraham I wrote: >>> Hi Robin, >>> >>> On 5/1/2020 9:24 PM, Robin Murphy wrote: On 2020-05-01 3:46 pm, Lorenzo Pieralisi wrote: >

[PATCH -next] soundwire: qcom: Use IRQF_ONESHOT

2020-05-05 Thread Samuel Zou
Fixes coccicheck error: drivers/soundwire/qcom.c:815:7-32: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/soundwire/qcom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [PATCH -next] iwlwifi: pcie: Use bitwise instead of arithmetic operator for flags

2020-05-05 Thread Joe Perches
On Wed, 2020-05-06 at 11:07 +0800, Samuel Zou wrote: > This silences the following coccinelle warning: > > "WARNING: sum of probable bitmasks, consider |" I suggest instead ignoring bad and irrelevant warnings. PREFIX_LEN is 32 not 0x20 or BIT(5) PCI_DUMP_SIZE is 352 > diff --git

Re: WARNING: proc registration bug in snmp6_register_dev

2020-05-05 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:ac935d22 Add linux-next specific files for 20200415 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=17006f4c10 kernel config:

[PATCH -next] iwlwifi: pcie: Use bitwise instead of arithmetic operator for flags

2020-05-05 Thread Samuel Zou
This silences the following coccinelle warning: "WARNING: sum of probable bitmasks, consider |" Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/net/wireless/intel/iwlwifi/pcie/trans.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: Intel KVM entry failed, hardware error 0x0

2020-05-05 Thread Sean Christopherson
On Tue, May 05, 2020 at 10:32:15PM -0400, Qian Cai wrote: > Today’s linux-next started to fail with this config, > > https://raw.githubusercontent.com/cailca/linux-mm/master/kcsan.config > > qemu-kvm-2.12.0-99.module+el8.2.0+5827+8c39933c.x86_64 > > I believe it was working yesterday. Before I

Re: [PATCH] net: bareudp: avoid uninitialized variable warning

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 07:22:14PM +0200, Arnd Bergmann wrote: > clang points out that building without IPv6 would lead to returning > an uninitialized variable if a packet with family!=AF_INET is > passed into bareudp_udp_encap_recv(): > > drivers/net/bareudp.c:139:6: error: variable 'err' is

Re: [PATCH v7 2/2] tty: add rpmsg driver

2020-05-05 Thread Bjorn Andersson
On Wed 25 Mar 09:57 PDT 2020, Arnaud POULIQUEN wrote: > Hi Bjorn, > > On 3/24/20 9:52 PM, Bjorn Andersson wrote: > > On Tue 24 Mar 10:04 PDT 2020, Arnaud Pouliquen wrote: > > [..] > >> diff --git a/drivers/tty/Makefile b/drivers/tty/Makefile > >> index 020b1cd9294f..c2465e7ebc2a 100644 > >> ---

Re: [PATCH v2] security: disable FORTIFY_SOURCE on clang

2020-05-05 Thread Kees Cook
On Tue, May 05, 2020 at 06:14:53PM -0600, Jason A. Donenfeld wrote: > clang-10 has a broken optimization stage that doesn't allow the > compiler to prove at compile time that certain memcpys are within > bounds, and thus the outline memcpy is always called, resulting in > horrific performance, and

Re: [PATCH] Kbuild: disable FORTIFY_SOURCE on clang-10

2020-05-05 Thread Kees Cook
On Tue, May 05, 2020 at 04:36:49PM -0700, Nick Desaulniers wrote: > On Tue, May 5, 2020 at 4:22 PM Jason A. Donenfeld wrote: > > > > On Tue, May 5, 2020 at 5:19 PM Kees Cook wrote: > > > > > > (Though as was mentioned, it's likely that FORTIFY_SOURCE isn't working > > > _at all_ under Clang, so

Re: [PATCH v5 1/5] powerpc: Move idle_loop_prolog()/epilog() functions to header file

2020-05-05 Thread Michael Ellerman
On Tue, 2020-04-07 at 08:47:39 UTC, "Gautham R. Shenoy" wrote: > From: "Gautham R. Shenoy" > > Currently prior to entering an idle state on a Linux Guest, the > pseries cpuidle driver implement an idle_loop_prolog() and > idle_loop_epilog() functions which ensure that idle_purr is correctly >

Re: [PATCH] powerpc/ps3: Move static keyword to the front of declaration

2020-05-05 Thread Michael Ellerman
On Wed, 2020-04-29 at 10:00:48 UTC, Xiongfeng Wang wrote: > Move the static keyword to the front of declaration of 'vuart_bus_priv', > and resolve the following compiler warning that can be seen when > building with warnings enabled (W=1): > > drivers/ps3/ps3-vuart.c:867:1: warning: ‘static’

[PATCH -next] net: ethernet: ti: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-05 Thread Samuel Zou
Fixes coccicheck warning: drivers/net/ethernet/ti/am65-cpts.c:1017:1-3: WARNING: PTR_ERR_OR_ZERO can be used Reported-by: Hulk Robot Signed-off-by: Samuel Zou --- drivers/net/ethernet/ti/am65-cpts.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

Re: [PATCH] leds: lm355x: avoid enum conversion warning

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 04:19:17PM +0200, Arnd Bergmann wrote: > clang points out that doing arithmetic between diffent enums is usually ^ different > a mistake: > > drivers/leds/leds-lm355x.c:167:28: warning: bitwise operation between > different

Re: [PATCH] mtd: lpddr: fix excessive stack usage with clang

2020-05-05 Thread Nathan Chancellor
On Tue, May 05, 2020 at 04:01:16PM +0200, Arnd Bergmann wrote: > Building lpddr2_nvm with clang can result in a giant stack usage > in one function: > > drivers/mtd/lpddr/lpddr2_nvm.c:399:12: error: stack frame size of 1144 bytes > in function 'lpddr2_nvm_probe' [-Werror,-Wframe-larger-than=] >

Re: [PATCH] ASoC: Intel: sst: ipc command timeout

2020-05-05 Thread Keyon Jie
On 4/22/20 12:16 AM, Lu, Brent wrote: Regs width difference between BDW and BYT comes from specification. BDW has IPC registers which are 32 wide. This fact ain't exactly the reason to modify sst_shim32_read64. I'm sharing Amadeo's point of view. Your change should slow down execution a

Re: [PATCH 2/3] ASoC: fsl_esai: Add support for imx8qm

2020-05-05 Thread Shengjiu Wang
Hi On Fri, May 1, 2020 at 6:23 PM Mark Brown wrote: > > On Fri, May 01, 2020 at 04:12:05PM +0800, Shengjiu Wang wrote: > > The difference for esai on imx8qm is that DMA device is EDMA. > > > > EDMA requires the period size to be multiple of maxburst. Otherwise > > the remaining bytes are not

Intel KVM entry failed, hardware error 0x0

2020-05-05 Thread Qian Cai
Today’s linux-next started to fail with this config, https://raw.githubusercontent.com/cailca/linux-mm/master/kcsan.config qemu-kvm-2.12.0-99.module+el8.2.0+5827+8c39933c.x86_64 I believe it was working yesterday. Before I bury myself bisecting it, does anyone have any thought? #

[PATCH -next] powerpc/kernel/sysfs: Use ARRAY_SIZE instead of calculating the array size

2020-05-05 Thread Samuel Zou
fix coccinelle warning, use ARRAY_SIZE arch/powerpc/kernel/sysfs.c:853:34-35: WARNING: Use ARRAY_SIZE arch/powerpc/kernel/sysfs.c:860:33-34: WARNING: Use ARRAY_SIZE arch/powerpc/kernel/sysfs.c:868:28-29: WARNING: Use ARRAY_SIZE arch/powerpc/kernel/sysfs.c:947:34-35: WARNING: Use ARRAY_SIZE

Re: [PATCH v2] stacktrace: cleanup inconsistent variable type

2020-05-05 Thread Walter Wu
On Wed, 2020-04-22 at 18:21 -0700, Bart Van Assche wrote: > On 4/20/20 6:35 PM, Walter Wu wrote: > > Modify the variable type of 'skip' member of struct stack_trace. > > In theory, the 'skip' variable type should be unsigned int. > > There are two reasons: > > - The 'skip' only has two situation,

Re: cgroup pointed by sock is leaked on mode switch

2020-05-05 Thread Zefan Li
On 2020/5/6 9:50, Yang Yingliang wrotee: +cc lize...@huawei.com On 2020/5/6 0:06, Tejun Heo wrote: Hello, Yang. On Sat, May 02, 2020 at 06:27:21PM +0800, Yang Yingliang wrote: I find the number nr_dying_descendants is increasing: linux-dVpNUK:~ # find /sys/fs/cgroup/ -name cgroup.stat -exec

Re: [PATCH v4 0/3] Replace private domain with per-group default domain

2020-05-05 Thread Daniel Drake
On Wed, May 6, 2020 at 10:03 AM Lu Baolu wrote: > https://lkml.org/lkml/2020/4/14/616 > [This has been applied in iommu/next.] > > Hence, there is no need to keep the private domain implementation > in the Intel IOMMU driver. This patch series aims to remove it. I applied these patches on top of

[PATCH v4 1/3] iommu/vt-d: Allow 32bit devices to uses DMA domain

2020-05-05 Thread Lu Baolu
Currently, if a 32bit device initially uses an identity domain, Intel IOMMU driver will convert it forcibly to a DMA one if its address capability is not enough for the whole system memory. The motivation was to overcome the overhead caused by possible bounced buffer. Unfortunately, this

Re: [RFC 2/2] remoteproc: core: keep rproc in crash state in case of recovery failure

2020-05-05 Thread Bjorn Andersson
On Wed 11 Mar 03:54 PDT 2020, Loic Pallardy wrote: > When an error occurs during recovery procedure, internal rproc > variables may be unaligned: > - state is set to RPROC_OFFLINE > - power atomic not equal to 0 > which is normal as only rproc_stop() has been executed and not > rproc_shutdown() >

[PATCH v4 2/3] iommu/vt-d: Allow PCI sub-hierarchy to use DMA domain

2020-05-05 Thread Lu Baolu
Before commit fa954e6831789 ("iommu/vt-d: Delegate the dma domain to upper layer"), Intel IOMMU started off with all devices in the identity domain, and took them out later if it found they couldn't access all of memory. This required devices behind a PCI bridge to use a DMA domain at the

  1   2   3   4   5   6   7   8   9   10   >