[RFC 1/4] regulator: lp87565: enable voltage regardless of ENx pin

2020-06-03 Thread Luca Ceresoli
This driver enables outputs by setting bit EN_BUCKn in the BUCKn_CTRL1 register. However, if bit EN_PIN_CTRLn in the same register is set, the output is actually enabled only if EN_BUCKn is set AND an enable pin is active. Since the driver does not touch EN_PIN_CTRLn, the choice is left to the

Re: [PATCH v3 13/13] PCI: brcmstb: Add bcm7211, bcm7216, bcm7445, bcm7278 to match list

2020-06-03 Thread Florian Fainelli
On 6/3/2020 12:20 PM, Jim Quinlan wrote: > Now that the support is in place with previous commits, we add several > chips that use the BrcmSTB driver. > > Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli -- Florian

Re: v5.7: new core kernel option missing help text

2020-06-03 Thread Russell King - ARM Linux admin
On Wed, Jun 03, 2020 at 09:24:56PM +0200, Vincent Guittot wrote: > On Wed, 3 Jun 2020 at 20:45, Russell King - ARM Linux admin > wrote: > > It's a start. I'm still wondering whether I should answer yes or no > > for the platforms I'm building for. > > > > So far, all I've found is: > > > >

Re: [RFC][PATCH 05/14] ia64: csum_partial_copy_nocheck(): don't abuse csum_partial_copy_from_user()

2020-06-03 Thread Guenter Roeck
On Wed, Jun 03, 2020 at 08:10:38PM +0100, Al Viro wrote: > On Wed, Jun 03, 2020 at 08:37:14AM -0700, Guenter Roeck wrote: > > On Fri, Mar 27, 2020 at 11:31:08PM +, Al Viro wrote: > > > From: Al Viro > > > > > > Just inline the call and use memcpy() instead of __copy_from_user() and > > >

Re: [PATCH v8 0/5] support reserving crashkernel above 4G on arm64 kdump

2020-06-03 Thread Bhupesh Sharma
Hi All, On Wed, Jun 3, 2020 at 9:03 PM John Donnelly wrote: > > > > > On Jun 3, 2020, at 8:20 AM, chenzhou wrote: > > > > Hi, > > > > > > On 2020/6/3 19:47, Prabhakar Kushwaha wrote: > >> Hi Chen, > >> > >> On Tue, Jun 2, 2020 at 8:12 PM John Donnelly > >> wrote: > >>> > >>> > On Jun 2,

Re: [PATCH v2] dmaengine: stm32-dma: call pm_runtime_put if pm_runtime_get_sync fails

2020-06-03 Thread Markus Elfring
>> How do you think about a wording variant like the following? > Please stop proposing rewording on my patches! I am trying to remind you on open issues according to patch review concerns. > I will consider updating my patches only if a maintainer asks for it. * I hope that more contributors

[PATCH] dmaengine: stm32-dmamux: fix pm_runtime_get_sync fialure cases

2020-06-03 Thread Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put_sync if pm_runtime_get_sync fails. Signed-off-by: Navid Emamdoost --- drivers/dma/stm32-dmamux.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

Re: [PATCH v2 02/10] KVM: x86: extend struct kvm_vcpu_pv_apf_data with token info

2020-06-03 Thread Vivek Goyal
On Thu, May 28, 2020 at 10:42:38AM +0200, Vitaly Kuznetsov wrote: > Vivek Goyal writes: > > > On Mon, May 25, 2020 at 04:41:17PM +0200, Vitaly Kuznetsov wrote: > >> > > > > [..] > >> diff --git a/arch/x86/include/asm/kvm_host.h > >> b/arch/x86/include/asm/kvm_host.h > >> index

DEAR SIR

2020-06-03 Thread SUHIL ABDULZAHRA
Dear Sir, My name is Mr. SUHIL ABDULZAHRA BADR AL-ASADI from IRAQ Ministry of Oil (MoO). Please can I have a confidentially funds transaction with you valued at $166 million dollars for safe keeping and investment? Please forward your response to my private email: abdulzahrasu...@gmail.com for

[git pull] uaccess comedi compat

2020-06-03 Thread Al Viro
comedi compat ioctls done saner (killing the single biggest pile of __get_user/__put_user outside of arch/* in process). The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the git repository at:

Re: [PATCH] dm zoned: Fix memory leak of newly allocated zone on xa_insert failure

2020-06-03 Thread Markus Elfring
> Currently if an xa_insert fails then there is a memory lead of the > recently allocated zone object. … I hope that a typo will be avoided for the final change description. Regards, Markus

Re: kobject_init_and_add is easy to misuse

2020-06-03 Thread Jason Gunthorpe
On Wed, Jun 03, 2020 at 12:02:08PM -0700, James Bottomley wrote: > On Wed, 2020-06-03 at 15:36 -0300, Jason Gunthorpe wrote: > > On Wed, Jun 03, 2020 at 11:04:35AM -0700, James Bottomley wrote: > > > On Tue, 2020-06-02 at 21:22 -0300, Jason Gunthorpe wrote: > > > > On Tue, Jun 02, 2020 at

Re: [PATCH] mm: thp: Add new kernel parameters transparent_hugepage_defrag/khugepaged_defrag

2020-06-03 Thread David Rientjes
On Wed, 3 Jun 2020, Vlastimil Babka wrote: > > There is no way to set up the defrag options in boot time. And it's > > useful to set it up by default instead of making it work by a > > systemd/upstart service or put the command to set up defrag inside > > /etc/rc.local. > > > > Signed-off-by:

[git pull] vfs.git work.splice

2020-06-03 Thread Al Viro
Christoph's assorted splice cleanups. The following changes since commit 8f3d9f354286745c751374f5f1fcafee6b3f3136: Linux 5.7-rc1 (2020-04-12 12:35:55 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.splice for you to

Re: v5.7: new core kernel option missing help text

2020-06-03 Thread Vincent Guittot
On Wed, 3 Jun 2020 at 20:45, Russell King - ARM Linux admin wrote: > > On Wed, Jun 03, 2020 at 07:00:26PM +0100, Valentin Schneider wrote: > > > > On 03/06/20 18:31, Russell King - ARM Linux admin wrote: > > > Hi, > > > > > > A new kernel configuration option ("SCHED_THERMAL_PRESSURE") was > > >

Re: [PATCH v5 00/18] Rework READ_ONCE() to improve codegen

2020-06-03 Thread Marco Elver
On Wed, 03 Jun 2020, Borislav Petkov wrote: > On Thu, May 14, 2020 at 12:05:38PM +0100, Will Deacon wrote: > > Talking off-list, Clang >= 7 is pretty reasonable wrt inlining decisions > > and the behaviour for __always_inline is: > > > > * An __always_inline function inlined into a

[git pull] misc uaccess stuff

2020-06-03 Thread Al Viro
uaccess patches that really didn't fit anywhere else. kvm_hv_set_msr() patch left as-is; __put_user() is by no means final there, but that'll be dealt with along with other KVM uaccess stuff next cycle. The following changes since commit b44f687386875b714dae2afa768e73401e45c21c:

[PATCH v3 00/13] PCI: brcmstb: enable PCIe for STB chips

2020-06-03 Thread Jim Quinlan
v3: Commit "device core: Introduce multiple dma pfn offsets" Commit "arm: dma-mapping: Invoke dma offset func if needed" -- The above two commits have been squashed. More importantly, the code has been modified so that the functionality for multiple pfn offsets subsumes the use of

[PATCH v3 02/13] ata: ahci_brcm: Fix use of BCM7216 reset controller

2020-06-03 Thread Jim Quinlan
From: Jim Quinlan A reset controller "rescal" is shared between the AHCI driver and the PCIe driver for the BrcmSTB 7216 chip. The code is modified to allow this sharing and to deassert() properly. Signed-off-by: Jim Quinlan Fixes: 272ecd60a636 ("ata: ahci_brcm: BCM7216 reset is self

[PATCH v3 13/13] PCI: brcmstb: Add bcm7211, bcm7216, bcm7445, bcm7278 to match list

2020-06-03 Thread Jim Quinlan
Now that the support is in place with previous commits, we add several chips that use the BrcmSTB driver. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/pcie-brcmstb.c

[PATCH v3 12/13] PCI: brcmstb: Set bus max burst size by chip type

2020-06-03 Thread Jim Quinlan
From: Jim Quinlan The proper value of the parameter SCB_MAX_BURST_SIZE varies per chip. The 2711 family requires 128B whereas other devices can employ 512. The assignment is complicated by the fact that the values for this two-bit field have different meanings; Value Type_Generic

[PATCH v3 03/13] dt-bindings: PCI: Add bindings for more Brcmstb chips

2020-06-03 Thread Jim Quinlan
From: Jim Quinlan - Add compatible strings for three more Broadcom STB chips: 7278, 7216, 7211 (STB version of RPi4). - add new property 'brcm,scb-sizes' - add new property 'resets' - add new property 'reset-names' for 7216 only - allow 'ranges' and 'dma-ranges' to have more than one item and

[PATCH v3 07/13] PCI: brcmstb: Add control of rescal reset

2020-06-03 Thread Jim Quinlan
From: Jim Quinlan Some STB chips have a special purpose reset controller named RESCAL (reset calibration). The PCIe HW can now control RESCAL to start and stop its operation. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 81 ++- 1 file

[PATCH v3 04/13] PCI: brcmstb: Add bcm7278 reigister info

2020-06-03 Thread Jim Quinlan
From: Jim Quinlan Add in compatibility strings and code for three Broadcom STB chips. Some of the register locations, shifts, and masks are different for certain chips, requiring the use of different constants based on of_id. We would like to add the following at this time to the match list

[PATCH v3 05/13] PCI: brcmstb: Add suspend and resume pm_ops

2020-06-03 Thread Jim Quinlan
From: Jim Quinlan Broadcom Set-top (BrcmSTB) boards typically support S2, S3, and S5 suspend and resume. Now the PCIe driver may do so as well. Signed-off-by: Jim Quinlan --- drivers/pci/controller/pcie-brcmstb.c | 49 +++ 1 file changed, 49 insertions(+) diff --git

[PATCH v3 10/13] PCI: brcmstb: Set internal memory viewport sizes

2020-06-03 Thread Jim Quinlan
BrcmSTB PCIe controllers are intimately connected to the memory controller(s) on the SOC. There is a "viewport" for each memory controller that allows inbound accesses to CPU memory. Each viewport's size must be set to a power of two, and that size must be equal to or larger than the amount of

[PATCH v3 11/13] PCI: brcmstb: Accommodate MSI for older chips

2020-06-03 Thread Jim Quinlan
From: Jim Quinlan Older BrcmSTB chips do not have a separate register for MSI interrupts; the MSIs are in a register that also contains unrelated interrupts. In addition, the interrupts lie in bits [31..24] for these legacy chips. This commit provides common code for both legacy and non-legacy

[PATCH v3 06/13] PCI: brcmstb: Add bcm7278 PERST support

2020-06-03 Thread Jim Quinlan
From: Jim Quinlan The PERST bit was moved to a different register in 7278-type STB chips. In addition, the polarity of the bit was also changed; for other chips writing a 1 specified assert; for 7278-type chips, writing a 0 specifies assert. Signal-wise, PERST is an asserted-low signal.

[PATCH v3 08/13] of: Include a dev param in of_dma_get_range()

2020-06-03 Thread Jim Quinlan
Currently there is only one caller of of_dma_get_range(). A struct device *dev param is needed For implementing multiple dma offsets. This function will still work if dev == NULL. Signed-off-by: Jim Quinlan --- drivers/of/address.c| 4 +++- drivers/of/device.c | 2 +-

[PATCH v3 01/13] PCI: brcmstb: PCIE_BRCMSTB depends on ARCH_BRCMSTB

2020-06-03 Thread Jim Quinlan
From: Jim Quinlan Have PCIE_BRCMSTB depend on ARCH_BRCMSTB. Also set the default value to ARCH_BRCMSTB. Signed-off-by: Jim Quinlan Acked-by: Florian Fainelli Reviewed-by: Rob Herring --- drivers/pci/controller/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [patch V9 00/39] x86/entry: Rework leftovers (was part V)

2020-06-03 Thread Andrew Cooper
On 22/05/2020 22:17, Peter Zijlstra wrote: > On Fri, May 22, 2020 at 08:20:15AM +0100, Andrew Cooper wrote: >> Apologies for opening a related can of worms. >> >> The new debug_enter() has propagated a pre-existing issue forward, >> ultimately caused by bad advice in the SDM. >> >> Because the RTM

Re: [PATCH] x86/mm: Fix boot with some memory above MAXMEM

2020-06-03 Thread Dave Hansen
On 6/2/20 4:18 PM, Kirill A. Shutemov wrote: > On Tue, May 26, 2020 at 07:27:15AM -0700, Dave Hansen wrote: >> On 5/25/20 8:08 AM, Kirill A. Shutemov wrote: >> +if (not_addressable) { >> +pr_err("%lldGB of physical memory is not addressable in >> the paging

Re: [PATCHES] uaccess hpsa

2020-06-03 Thread Al Viro
On Wed, Jun 03, 2020 at 06:37:11PM +, don.br...@microchip.com wrote: > -Original Message- > From: linux-scsi-ow...@vger.kernel.org > [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Al Viro > Sent: Friday, May 29, 2020 6:39 PM > To: Linus Torvalds > Cc:

Re: [PATCH] dmaengine: stm32-mdma: call pm_runtime_put if pm_runtime_get_sync fails

2020-06-03 Thread Navid Emamdoost
On Wed, Jun 3, 2020 at 1:52 PM Markus Elfring wrote: > > > Calling pm_runtime_get_sync increments the counter even in case of > > failure, causing incorrect ref count. Call pm_runtime_put if > > pm_runtime_get_sync fails. > > Is it appropriate to copy a sentence from the change description > into

Re: [PATCH] tty/vt: check allocation size in con_set_unimap()

2020-06-03 Thread Kees Cook
On Wed, Jun 03, 2020 at 01:28:04PM +0300, Denis Efremov wrote: > The vmemdup_user() function has no 2-factor argument form. Use array_size() > to check for the overflow. > > Cc: Kees Cook > Signed-off-by: Denis Efremov Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 2/2] docs: fs: proc.rst: fix a warning due to a merge conflict

2020-06-03 Thread Kees Cook
On Wed, Jun 03, 2020 at 12:38:14AM +0200, Mauro Carvalho Chehab wrote: > Changeset 424037b77519 ("mm: smaps: Report arm64 guarded pages in smaps") > added a new parameter to a table. This causes Sphinx warnings, > because there's now an extra "-" at the wrong place: > >

Re: [RFC][PATCH 05/14] ia64: csum_partial_copy_nocheck(): don't abuse csum_partial_copy_from_user()

2020-06-03 Thread Al Viro
On Wed, Jun 03, 2020 at 08:37:14AM -0700, Guenter Roeck wrote: > On Fri, Mar 27, 2020 at 11:31:08PM +, Al Viro wrote: > > From: Al Viro > > > > Just inline the call and use memcpy() instead of __copy_from_user() and > > note that the tail is precisely ia64 csum_partial(). > > > >

Re: seccomp feature development

2020-06-03 Thread Kees Cook
[trying to get back to this thread -- I've been distracted] On Tue, May 19, 2020 at 12:39:39AM +0200, Jann Horn wrote: > On Mon, May 18, 2020 at 11:05 PM Kees Cook wrote: > > ## deep argument inspection > > > > Background: seccomp users would like to write filters that traverse > > the user

Re: [PATCH 0/9] x86/entry fixes

2020-06-03 Thread Marco Elver
On Wed, 3 Jun 2020 at 20:16, Peter Zijlstra wrote: > > On Wed, Jun 03, 2020 at 06:07:22PM +0200, Peter Zijlstra wrote: > > On Wed, Jun 03, 2020 at 04:47:54PM +0200, Marco Elver wrote: > > > > With that in mind, you could whitelist "__ubsan_handle"-prefixed > > > functions in objtool. Given the

Re: [PATCH v4 08/14] powerpc: add support for folded p4d page tables

2020-06-03 Thread Andrew Morton
On Tue, 14 Apr 2020 18:34:49 +0300 Mike Rapoport wrote: > Implement primitives necessary for the 4th level folding, add walks of p4d > level where appropriate and replace 5level-fixup.h with pgtable-nop4d.h. A bunch of new material just landed in linux-next/powerpc. The timing is awkward! I

[PATCH bpf v2] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Matthieu Baerts
A recent commit added new variables only used if CONFIG_NETDEVICES is set. A simple fix would be to only declare these variables if the same condition is valid but Alexei suggested an even simpler solution: since CONFIG_NETDEVICES doesn't change anything in .h I think the best is to

Re: [RESEND PATCH v9 5/5] powerpc/papr_scm: Implement support for PAPR_PDSM_HEALTH

2020-06-03 Thread Vaibhav Jain
Hi Ira, Thanks for reviewing this patch. My responses below: Ira Weiny writes: > On Tue, Jun 02, 2020 at 03:44:38PM +0530, Vaibhav Jain wrote: >> This patch implements support for PDSM request 'PAPR_PDSM_HEALTH' >> that returns a newly introduced 'struct nd_papr_pdsm_health' instance >>

Re: kobject_init_and_add is easy to misuse

2020-06-03 Thread James Bottomley
On Wed, 2020-06-03 at 15:36 -0300, Jason Gunthorpe wrote: > On Wed, Jun 03, 2020 at 11:04:35AM -0700, James Bottomley wrote: > > On Tue, 2020-06-02 at 21:22 -0300, Jason Gunthorpe wrote: > > > On Tue, Jun 02, 2020 at 02:51:10PM -0700, James Bottomley wrote: > > > > > > > My first thought was

Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Ferenc Fejes
> > Hi Alexei, > > On 03/06/2020 20:14, Alexei Starovoitov wrote: > > On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote: > >> Hi Ferenc, > >> > >> On 03/06/2020 10:56, Ferenc Fejes wrote: > >>> Matthieu Baerts ezt írta (időpont: > >>> 2020. jún. 3., Sze, 10:11): > > A

[tip: timers/urgent] lib/vdso: Force inlining of __cvdso_clock_gettime_common()

2020-06-03 Thread tip-bot2 for Christophe Leroy
The following commit has been merged into the timers/urgent branch of tip: Commit-ID: b91c8c42ffdd5c983923edb38b3c3e112bfe6263 Gitweb: https://git.kernel.org/tip/b91c8c42ffdd5c983923edb38b3c3e112bfe6263 Author:Christophe Leroy AuthorDate:Tue, 28 Apr 2020 13:16:53

Re: [PATCH] dmaengine: stm32-mdma: call pm_runtime_put if pm_runtime_get_sync fails

2020-06-03 Thread Markus Elfring
> Calling pm_runtime_get_sync increments the counter even in case of > failure, causing incorrect ref count. Call pm_runtime_put if > pm_runtime_get_sync fails. Is it appropriate to copy a sentence from the change description into the patch subject? How do you think about a wording variant like

Re: [PATCH v5 00/18] Rework READ_ONCE() to improve codegen

2020-06-03 Thread Borislav Petkov
On Thu, May 14, 2020 at 12:05:38PM +0100, Will Deacon wrote: > Talking off-list, Clang >= 7 is pretty reasonable wrt inlining decisions > and the behaviour for __always_inline is: > > * An __always_inline function inlined into a __no_sanitize function is > not instrumented > * An

Re: [PATCH v3 0/4] forbid fix {SQ,IO}POLL

2020-06-03 Thread Jens Axboe
On 6/3/20 9:03 AM, Pavel Begunkov wrote: > The first one adds checks {SQPOLL,IOPOLL}. IOPOLL check can be > moved in the common path later, or rethinked entirely, e.g. > not io_iopoll_req_issued()'ed for unsupported opcodes. > > 3 others are just cleanups on top. > > > v2: add IOPOLL to the

Re: [PATCHv1 00/19] Improve SBS battery support

2020-06-03 Thread Marek Szyprowski
20200529 pointed me to the first bad >>>> commit: [c4b12a2f3f3de670f6be5e96092a2cab0b877f1a] power: supply: >>>> sbs-battery: simplify read_read_string_data. >>> ok. I tested this on an to-be-upstreamed i.MX6 based system >>> and arch/arm/boot/dts/imx53-ppd.

Re: Re: [RESEND PATCH v5 5/5] Documentation/vmcoreinfo: Add documentation for 'TCR_EL1.T1SZ'

2020-06-03 Thread Scott Branden
Hi Bhupesh, Would be great to get this patch series upstreamed? On 2019-12-25 10:49 a.m., Bhupesh Sharma wrote: Hi James, On 12/12/2019 04:02 PM, James Morse wrote: Hi Bhupesh, I am sorry this review mail skipped my attention due to holidays and focus on other urgent issues. On

Re: v5.7: new core kernel option missing help text

2020-06-03 Thread Russell King - ARM Linux admin
On Wed, Jun 03, 2020 at 07:00:26PM +0100, Valentin Schneider wrote: > > On 03/06/20 18:31, Russell King - ARM Linux admin wrote: > > Hi, > > > > A new kernel configuration option ("SCHED_THERMAL_PRESSURE") was > > recently added, but has no help text. This is most unhelpful when > > trying to

Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Alexei Starovoitov
On Wed, Jun 3, 2020 at 11:41 AM Matthieu Baerts wrote: > > Hi Alexei, > > On 03/06/2020 20:14, Alexei Starovoitov wrote: > > On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote: > >> Hi Ferenc, > >> > >> On 03/06/2020 10:56, Ferenc Fejes wrote: > >>> Matthieu Baerts ezt írta

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Jassi Brar
On Wed, Jun 3, 2020 at 1:31 PM Sudeep Holla wrote: > > > > > > H/W is actually fine :) Its just that the driver is written to > > _also_ support a platform (my original) that doesn't have shmem and > > need to pass data via 32bit registers. > > Frankly, I am not against the doorbell mode, I am

[PATCH] dmaengine: tegra210-adma: fix pm_runtime_get_sync failure

2020-06-03 Thread Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Navid Emamdoost --- drivers/dma/tegra210-adma.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Matthieu Baerts
Hi Alexei, On 03/06/2020 20:14, Alexei Starovoitov wrote: On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote: Hi Ferenc, On 03/06/2020 10:56, Ferenc Fejes wrote: Matthieu Baerts ezt írta (időpont: 2020. jún. 3., Sze, 10:11): A recent commit added new variables only used if

Re: [PATCH] usb: usbtest: fix missing kfree(dev->buf) in usbtest_disconnect

2020-06-03 Thread Alan Stern
On Wed, Jun 03, 2020 at 11:05:06AM +0800, qiang.zh...@windriver.com wrote: > From: Zqiang > > BUG: memory leak > unreferenced object 0x888055046e00 (size 256): > comm "kworker/2:9", pid 2570, jiffies 4294942129 (age 1095.500s) > hex dump (first 32 bytes): > 00 70 04 55 80 88 ff ff 18

[PATCH] dmaengine: tegra210-adma: fix pm_runtime_get_sync failure

2020-06-03 Thread Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Navid Emamdoost --- drivers/dma/tegra210-adma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

RE: [PATCHES] uaccess hpsa

2020-06-03 Thread Don.Brace
-Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Al Viro Sent: Friday, May 29, 2020 6:39 PM To: Linus Torvalds Cc: linux-kernel@vger.kernel.org; linux-fsde...@vger.kernel.org; Don Brace ; linux-s...@vger.kernel.org Subject:

Re: [PATCH v4 1/4] riscv: Move kernel mapping to vmalloc zone

2020-06-03 Thread kernel test robot
Hi Alexandre, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on powerpc/next] [also build test WARNING on linus/master v5.7 next-20200603] [cannot apply to mpe/next atish-riscv-linux/topo_v3] [if your patch is applied to the wrong git tree, please drop us a note

Re: kobject_init_and_add is easy to misuse

2020-06-03 Thread Jason Gunthorpe
On Wed, Jun 03, 2020 at 11:04:35AM -0700, James Bottomley wrote: > On Tue, 2020-06-02 at 21:22 -0300, Jason Gunthorpe wrote: > > On Tue, Jun 02, 2020 at 02:51:10PM -0700, James Bottomley wrote: > > > > > My first thought was "what? I got suckered into creating a patch", > > > thanks ;-) But now

[PATCH] engine: stm32-dma: call pm_runtime_put if pm_runtime_get_sync fails

2020-06-03 Thread Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Navid Emamdoost --- drivers/dma/stm32-dma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Jassi Brar
On Wed, Jun 3, 2020 at 1:04 PM Sudeep Holla wrote: > > On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > > On 28-05-20, 13:20, Rob Herring wrote: > > > Whether Linux > > > requires serializing mailbox accesses is a separate issue. On that side, > > > it seems silly to not allow

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Sudeep Holla
On Mon, May 18, 2020 at 11:05:03PM -0500, Jassi Brar wrote: > On Mon, May 18, 2020 at 10:40 PM Viresh Kumar wrote: > > > > On 18-05-20, 18:29, Bjorn Andersson wrote: > > > On Thu 14 May 22:17 PDT 2020, Viresh Kumar wrote: > > > > This stuff has been doing rounds on the mailing list since several

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Roelof Berg
I’m testing with Microchip Lan7430, which is an integrated circuit that contains MAC and PHY in one package. With the release kernel the hardware works fine, so the overall configuration is ok (jumpers). I will verify wether the effective RGMII and delay settings, you mention, are equal in

[PATCH] dmaengine: stm32-mdma: call pm_runtime_put if pm_runtime_get_sync fails

2020-06-03 Thread Navid Emamdoost
Calling pm_runtime_get_sync increments the counter even in case of failure, causing incorrect ref count. Call pm_runtime_put if pm_runtime_get_sync fails. Signed-off-by: Navid Emamdoost --- drivers/dma/stm32-mdma.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Sudeep Holla
Hi Bjorn, Thanks for the details response. On Mon, May 18, 2020 at 06:29:27PM -0700, Bjorn Andersson wrote: > On Thu 14 May 22:17 PDT 2020, Viresh Kumar wrote: > [...] I find this part nicely summarise your response. > > - With serialization, if we use only one channel as today at every > >

Re: [PATCH] media: budget-core: Improve exception handling in budget_register()

2020-06-03 Thread Markus Elfring
> Add the missed undo functions for error handling to fix it. … > +++ b/drivers/media/pci/ttpci/budget-core.c > @@ -369,20 +369,25 @@ static int budget_register(struct budget *budget) … > return 0; > + +err: > + dvb_dmxdev_release(>dmxdev); > + dvb_dmx_release(>demux); > +

[PATCH v2 4/4] selftests/livepatch: fix mem leaks in test-klp-shadow-vars

2020-06-03 Thread Yannick Cote
In some cases, when an error occurs during testing and the main test routine returns, a memory leak occurs via leaving previously registered shadow variables allocated in the kernel as well as shadow_ptr list elements. From now on, in case of error, remove all allocated shadow variables and

[PATCH v2 2/4] selftests/livepatch: rework test-klp-shadow-vars

2020-06-03 Thread Yannick Cote
The initial idea was to make a change to please cppcheck and remove void pointer arithmetics found a few times: portability: 'obj' is of type 'void *'. When using void pointers in calculations, the behaviour is undefined.

[PATCH v2 3/4] selftests/livepatch: more verification in test-klp-shadow-vars

2020-06-03 Thread Yannick Cote
This change makes the test feel more familiar with narrowing to a typical usage by operating on a number of identical structure instances and populating the same two new shadow variables symmetrically while keeping the same testing and verification criteria for the extra variables. Reviewed-by:

[PATCH v2 1/4] selftests/livepatch: simplify test-klp-callbacks busy target tests

2020-06-03 Thread Yannick Cote
From: Joe Lawrence The test-klp-callbacks script includes a few tests which rely on kernel task timings that may not always execute as expected under system load. These may generate out of sequence kernel log messages that result in test failure. Instead of using sleep timing windows to

[PATCH v2 0/4] selftests/livepatch: rework of test-klp-{callbacks,shadow_vars}

2020-06-03 Thread Yannick Cote
v2: - drop completion variables and flush workqueue [pmladek] - comment typo/pr_info cleanup [kbabulal/mbenes] - cleanup goto ret assignations [pmladek] - allocate pndup[]'s, leave some svar allocations to shadow_get_or_alloc() [pmladek] - change allocation order for cleaner test dmesg

Re: [PATCH 08/10] clk: qcom: Add graphics clock controller driver for SM8250

2020-06-03 Thread Sai Prakash Ranjan
Hi Bjorn, On 2020-06-03 23:39, Bjorn Andersson wrote: On Thu 28 May 23:56 PDT 2020, Sai Prakash Ranjan wrote: Hi Bjorn, On 2020-05-29 06:41, Bjorn Andersson wrote: > On Mon 25 May 02:47 PDT 2020, Sai Prakash Ranjan wrote: > > > Hi Jonathan, > > > > On 2020-05-25 02:36, Jonathan Marek wrote:

Re: [PATCH][next] dm zoned: fix memory leak of newly allocated zone on xa_insert failure

2020-06-03 Thread Mike Snitzer
On Wed, Jun 03 2020 at 12:02pm -0400, Colin King wrote: > From: Colin Ian King > > Currently if an xa_insert fails then there is a memory lead of the > recently allocated zone object. Fix this by kfree'ing zone before > returning on the error return path. > > Addresses-Coverity: ("Resource

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Sudeep Holla
On Wed, Jun 03, 2020 at 07:04:35PM +0100, Sudeep Holla wrote: > On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > > On 28-05-20, 13:20, Rob Herring wrote: > > > Whether Linux > > > requires serializing mailbox accesses is a separate issue. On that side, > > > it seems silly to not

Re: [PATCH 0/9] x86/entry fixes

2020-06-03 Thread Peter Zijlstra
On Wed, Jun 03, 2020 at 06:07:22PM +0200, Peter Zijlstra wrote: > On Wed, Jun 03, 2020 at 04:47:54PM +0200, Marco Elver wrote: > > With that in mind, you could whitelist "__ubsan_handle"-prefixed > > functions in objtool. Given the __always_inline+noinstr+__ubsan_handle > > case is quite rare, it

Re: [GIT pull] irq/core for v5.8

2020-06-03 Thread pr-tracker-bot
The pull request you sent on Tue, 02 Jun 2020 12:08:09 -: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq-core-2020-06-02 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f6606d0c0010953e4c28c8662623662b5108b4ce Thank you! -- Deet-doot-dot, I am a

Re: [GIT pull] timers/core for v5.8

2020-06-03 Thread pr-tracker-bot
The pull request you sent on Tue, 02 Jun 2020 12:08:10 -: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > timers-core-2020-06-02 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/dabc4df27c628866ede130a09121f255ca894d8c Thank you! -- Deet-doot-dot,

Re: [GIT pull] x86/timers for v5.8

2020-06-03 Thread pr-tracker-bot
The pull request you sent on Wed, 03 Jun 2020 15:08:43 -: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > x86-timers-2020-06-03 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f6aee505c71bbb035dde146caf5a6abbf3ccbe47 Thank you! -- Deet-doot-dot, I

Re: [PATCH bpf] bpf: fix unused-var without NETDEVICES

2020-06-03 Thread Alexei Starovoitov
On Wed, Jun 03, 2020 at 11:12:01AM +0200, Matthieu Baerts wrote: > Hi Ferenc, > > On 03/06/2020 10:56, Ferenc Fejes wrote: > > Matthieu Baerts ezt írta (időpont: > > 2020. jún. 3., Sze, 10:11): > > > > > > A recent commit added new variables only used if CONFIG_NETDEVICES is > > > set. > > > >

Re: [RESEND PATCH v9 4/5] ndctl/papr_scm,uapi: Add support for PAPR nvdimm specific methods

2020-06-03 Thread Vaibhav Jain
Hi Ira, Thanks for reviewing this patch. My responses below: Ira Weiny writes: > On Tue, Jun 02, 2020 at 03:44:37PM +0530, Vaibhav Jain wrote: >> Introduce support for PAPR NVDIMM Specific Methods (PDSM) in papr_scm >> module and add the command family NVDIMM_FAMILY_PAPR to the white list >>

Re: [PATCH] rcu/performance: Fix kfree_perf_init() build warning on 32-bit kernels

2020-06-03 Thread Paul E. McKenney
On Tue, May 26, 2020 at 09:14:13PM -0400, Joel Fernandes wrote: > On Tue, May 26, 2020 at 08:27:44PM +0200, Ingo Molnar wrote: > [...] > > ./include/linux/kern_levels.h:5:18: warning: format ‘%lu’ expects argument > > of type ‘long unsigned int’, but argument 2 has type ‘unsigned int’ > >

Re: [PATCH 08/10] clk: qcom: Add graphics clock controller driver for SM8250

2020-06-03 Thread Bjorn Andersson
On Thu 28 May 23:56 PDT 2020, Sai Prakash Ranjan wrote: > Hi Bjorn, > > On 2020-05-29 06:41, Bjorn Andersson wrote: > > On Mon 25 May 02:47 PDT 2020, Sai Prakash Ranjan wrote: > > > > > Hi Jonathan, > > > > > > On 2020-05-25 02:36, Jonathan Marek wrote: > > > > Add support for the graphics

[tip: x86/urgent] x86/cpu: Add Sapphire Rapids CPU model number

2020-06-03 Thread tip-bot2 for Tony Luck
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: be25d1b5ea6a3a3ecbb5474e2ae8e32d2ba055ea Gitweb: https://git.kernel.org/tip/be25d1b5ea6a3a3ecbb5474e2ae8e32d2ba055ea Author:Tony Luck AuthorDate:Wed, 03 Jun 2020 10:33:52 -07:00 Committer:

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Andrew Lunn
On Wed, Jun 03, 2020 at 06:33:28PM +0200, Roelof Berg wrote: > Ok, let's proceed :) The code runs well, dmesg looks good, ip addr shows me a > link up, speed/duplex looks ok. But it does not transfer any data. > > Debugging steps (A/B versions): > - Check clocks with oscilloscope (10/100/1000) >

Re: [GIT PULL] SELinux patches for v5.8

2020-06-03 Thread Casey Schaufler
On 6/3/2020 10:37 AM, Linus Torvalds wrote: > On Wed, Jun 3, 2020 at 10:20 AM Casey Schaufler > wrote: >> We could have inode->i_security be the blob, rather than a pointer to it. >> That will have its own performance issues. > It wouldn't actually really fix anything, because the inode is so

Re: [RFC] dt-bindings: mailbox: add doorbell support to ARM MHU

2020-06-03 Thread Sudeep Holla
On Fri, May 29, 2020 at 09:37:58AM +0530, Viresh Kumar wrote: > On 28-05-20, 13:20, Rob Herring wrote: > > Whether Linux > > requires serializing mailbox accesses is a separate issue. On that side, > > it seems silly to not allow driving the h/w in the most efficient way > > possible. > > That's

Re: kobject_init_and_add is easy to misuse

2020-06-03 Thread James Bottomley
On Tue, 2020-06-02 at 21:22 -0300, Jason Gunthorpe wrote: > On Tue, Jun 02, 2020 at 02:51:10PM -0700, James Bottomley wrote: > > > My first thought was "what? I got suckered into creating a patch", > > thanks ;-) But now I look, all the error paths do unwind back to > > the initial state, so

Re: [PATCH] lan743x: Added fixed link and RGMII support / debugging

2020-06-03 Thread Andrew Lunn
On Wed, Jun 03, 2020 at 06:36:28PM +0200, Roelof Berg wrote: > If I find a fix, would I need to submit a delta patch (to our last one) or a > full patch ? A delta. Andrew

Re: v5.7: new core kernel option missing help text

2020-06-03 Thread Valentin Schneider
On 03/06/20 18:31, Russell King - ARM Linux admin wrote: > Hi, > > A new kernel configuration option ("SCHED_THERMAL_PRESSURE") was > recently added, but has no help text. This is most unhelpful when > trying to configure the kernel, since one does not know what the > effect of answering yes or

Re: [PATCH v3] iio: amplifiers: ad8366: Change devm_gpiod_get() to optional and add the missed check

2020-06-03 Thread Markus Elfring
> Since if there is no GPIO, nothing happens, replace devm_gpiod_get() > with devm_gpiod_get_optional(). … > +++ b/drivers/iio/amplifiers/ad8366.c > @@ -262,8 +262,12 @@ static int ad8366_probe(struct spi_device *spi) … > case ID_HMC1119: > - st->reset_gpio =

Re: headers_install builds break on a lot of targets?

2020-06-03 Thread Arnd Bergmann
On Wed, Jun 3, 2020 at 7:04 PM Rich Felker wrote: > On Wed, Jun 03, 2020 at 08:49:54AM -0500, Rob Landley wrote: > > make ARCH=$i distclean defconfig headers_install \ > > > > On the bright side, the resulting fruitbasket.tar.xz is 1.5 megabytes. The > > downside is I have no idea how broken

Re: [PATCH v1 2/7] Bluetooth: Add handler of MGMT_OP_READ_ADV_MONITOR_FEATURES

2020-06-03 Thread Marcel Holtmann
Hi Miao-chen, > This adds the request handler of MGMT_OP_READ_ADV_MONITOR_FEATURES > command. Since the controller-based monitoring is not yet in place, this > report only the supported features but not the enabled features. > > The following test was performed. > - Issuing btmgmt

Re: [PATCH] Bluetooth: Check scan state before disabling during suspend

2020-06-03 Thread Marcel Holtmann
Hi Manish, > Check current scan state by checking HCI_LE_SCAN flag and send scan > disable command only if scan is already enabled. > > Signed-off-by: Manish Mandlik > --- > > net/bluetooth/hci_request.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) patch has been applied

[tip: x86/entry] x86/entry: Use __irq_exit_rcu() in irq_exit()

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 10396895ab36357e676b894d89f64667ce226150 Gitweb: https://git.kernel.org/tip/10396895ab36357e676b894d89f64667ce226150 Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:15 +02:00

[tip: x86/entry] x86/entry: __always_inline CR2 for noinstr

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 8c4d7f8109431652f469b116f2f4fd6526b01a14 Gitweb: https://git.kernel.org/tip/8c4d7f8109431652f469b116f2f4fd6526b01a14 Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:22 +02:00

Re: [PATCH] Bluetooth: Terminate the link if pairing is cancelled

2020-06-03 Thread Marcel Holtmann
Hi Manish, > Based on your feedback, in the BlueZ kernel, if we plan to track whether the > link was created because of Pair Device action or not, we'll need to add a > flag in struch hci_conn and update related functions/APIs. I was wondering if > this would look like a clean fix or not. >

[tip: x86/entry] x86/entry: __always_inline arch_atomic_* for noinstr

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: c74809a9760f0d0c80ebe4e6ddcc9aebba9d90bc Gitweb: https://git.kernel.org/tip/c74809a9760f0d0c80ebe4e6ddcc9aebba9d90bc Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:19 +02:00

[tip: x86/entry] lockdep: __always_inline more for noinstr

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 87374bc31053b40d64dfe7199d830fb225694637 Gitweb: https://git.kernel.org/tip/87374bc31053b40d64dfe7199d830fb225694637 Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:21 +02:00

[tip: x86/entry] x86/entry: Re-order #DB handler to avoid *SAN instrumentation

2020-06-03 Thread tip-bot2 for Peter Zijlstra
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 6452aaf182a1deb9fda63754cf8e92353c5f49fd Gitweb: https://git.kernel.org/tip/6452aaf182a1deb9fda63754cf8e92353c5f49fd Author:Peter Zijlstra AuthorDate:Wed, 03 Jun 2020 13:40:20 +02:00

<    1   2   3   4   5   6   7   8   9   10   >