Re: [PATCH] [v2] wilc1000: Fix memleak in wilc_sdio_probe

2020-08-19 Thread Ajay.Kathat
On 20/08/20 11:18 am, Dinghao Liu wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > When devm_clk_get() returns -EPROBE_DEFER, sdio_priv > should be freed just like when wilc_cfg80211_init() > fails. > > Fixes: 8692b047e86cf ("staging:

Re: [PATCH 1/1] mm, oom_adj: don't loop through tasks in __set_oom_adj when not necessary

2020-08-19 Thread Michal Hocko
On Wed 19-08-20 17:20:53, Suren Baghdasaryan wrote: > Currently __set_oom_adj loops through all processes in the system to > keep oom_score_adj and oom_score_adj_min in sync between processes > sharing their mm. This is done for any task with more that one mm_users, > which includes processes with

linux-next: Tree for Aug 20

2020-08-19 Thread Stephen Rothwell
Hi all, Changes since 20200819: New tree: ti-k3-new My fixes tree contains: 73c7adb54169 ("device_cgroup: Fix RCU list debugging warning") The dma-mapping tree caused my qemu test boot to fail so I reverted a commit. I applied a supplied patch for a runtime fault to the se

[PATCH] [v2] wilc1000: Fix memleak in wilc_bus_probe

2020-08-19 Thread Dinghao Liu
When devm_clk_get() returns -EPROBE_DEFER, spi_priv should be freed just like when wilc_cfg80211_init() fails. Fixes: 854d66df74aed ("staging: wilc1000: look for rtc_clk clock in spi mode") Signed-off-by: Dinghao Liu --- Changelog: v2: - Remove 'staging' prefix in subject. ---

[PATCH v9 11/24] coresight: etb: allow etb to be built as a module

2020-08-19 Thread Tingwei Zhang
From: Kim Phillips Allow to build coresight-etb10 as a module, for ease of development. - Kconfig becomes a tristate, to allow =m - add an etb_remove function, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc:

[PATCH v9 24/24] coresight: allow the coresight core driver to be built as a module

2020-08-19 Thread Tingwei Zhang
Enhance coresight developer's efficiency to debug coresight drivers. - Kconfig becomes a tristate, to allow =m - append -core to source file name to allow module to be called coresight by the Makefile - modules can have only one init/exit, so we add the etm_perf register/unregister function

linux-next: boot failure after merge of the dma-mapping tree

2020-08-19 Thread Stephen Rothwell
Hi all, After merging the dma-mapping tree, today's linux-next build (powerpc pseries_le_defconfig) failed like this: [1.829053][T1] [ cut here ] [1.829629][T1] kernel BUG at include/linux/iommu-helper.h:21! [1.830182][T1] Oops: Exception in kernel

[PATCH v9 23/24] coresight: catu: allow catu drivers to be built as modules

2020-08-19 Thread Tingwei Zhang
Allow to build coresight-catu as modules, for ease of development. - Kconfig becomes a tristate, to allow =m - add catu_remove functions, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Signed-off-by: Tingwei Zhang Reviewed-by: Mike Leach Reviewed-by: Suzuki K Poulose

[PATCH v9 20/24] coresight: cti: increase reference count when enabling cti

2020-08-19 Thread Tingwei Zhang
CTI device is enabled when associated coresight device is enabled. Increase the module and device reference count for CTI device when it's enabled. This can prevent CTI device be removed or module be unloaded when CTI device is enabled by an active trace session. Signed-off-by: Mike Leach

[PATCH v9 16/24] coresight: cti: add function to register cti associate ops

2020-08-19 Thread Tingwei Zhang
Add static cti_assoc_ops to coresight core driver. Let cti driver register the add_assoc and remove_assoc call back. Avoid coresight core driver to depend on cti driver. Signed-off-by: Tingwei Zhang Tested-by: Mike Leach Reviewed-by: Mathieu Poirier ---

[PATCH v9 22/24] coresight: tmc-etr: add function to register catu ops

2020-08-19 Thread Tingwei Zhang
From: Mian Yousaf Kaukab Make etr_catu_buf_ops static. Instead of directly accessing it in etr_buf_ops[], add a function to let catu driver register the ops at runtime. Break circular dependency between tmc-etr and catu drivers. Signed-off-by: Mian Yousaf Kaukab Signed-off-by: Tingwei Zhang

[PATCH v9 21/24] coresight: cti: allow cti to be built as a module

2020-08-19 Thread Tingwei Zhang
Allow to build coresight-cti as a module, for ease of development. - Kconfig becomes a tristate, to allow =m - append -core to source file name to allow module to be called coresight-cti by the Makefile - add an cti_remove function, for module unload - move cti_remove_conn_xrefs to cti_remove -

Re: [PATCH 2/2] nvme: add emulation for zone-append

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 05:43:29PM -0600, David Fugate wrote: > There were queries? My key takeaways were a maintainer NAK followed by > instructions to make the Intel drive align with the driver by > implementing NOIOB. While I disagree with the rejection as it appeared > to be based entirely on

[PATCH v9 12/24] coresight: tpiu: allow tpiu to be built as a module

2020-08-19 Thread Tingwei Zhang
From: Kim Phillips Allow to build coresight-tpiu as a module, for ease of development. - Kconfig becomes a tristate, to allow =m - add a tpiu_remove function, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc:

[PATCH v9 15/24] coresight: allow replicator driver to be built as module

2020-08-19 Thread Tingwei Zhang
From: Kim Phillips Allow to build coresight-replicator as modules, for ease of development. - Kconfig becomes a tristate, to allow =m - combine static and dynamic replicator init into single module_init/exit call - add replicator_remove functions, for module unload - add a MODULE_DEVICE_TABLE

[PATCH v9 19/24] coresight: cti: don't disable ect device if it's not enabled

2020-08-19 Thread Tingwei Zhang
If associated ect device is not enabled at first place, disable routine should not be called. Add ect_enabled flag to check whether ect device is enabled. Fix the issue in below case. Ect device is not available when associated coresight device enabled and the association is established after

[PATCH v9 18/24] coresight: cti: Fix bug clearing sysfs links on callback

2020-08-19 Thread Tingwei Zhang
From: Mike Leach During module unload, a coresight driver module will call back into the CTI driver to remove any links between the two devices. The current code has 2 issues:- 1) in the CTI driver the matching code is matching to the wrong device so misses all the links. 2) The callback is

[PATCH v9 13/24] coresight: tmc: allow tmc to be built as a module

2020-08-19 Thread Tingwei Zhang
From: Kim Phillips Allow to build coresight-tmc as a module, for ease of development. - Kconfig becomes a tristate, to allow =m - append -core to source file name to allow module to be called coresight-tmc by the Makefile - add an tmc_remove function, for module unload - add a

[PATCH v9 17/24] coresight: cti: Fix remove sysfs link error

2020-08-19 Thread Tingwei Zhang
From: Mike Leach CTI code to remove sysfs link to other devices on shutdown, incorrectly tries to remove a single ended link when these are all double ended. This implementation leaves elements in the link info structure undefined which results in a crash in recent tests for driver module

[PATCH v9 14/24] coresight: allow funnel driver to be built as module

2020-08-19 Thread Tingwei Zhang
From: Kim Phillips Allow to build coresight-funnel as module, for ease of development. - combine static and dynamic funnel init into single module_init/exit call - add funnel_remove functions, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier Cc: Leo

[PATCH v9 10/24] coresight: etm4x: allow etm4x to be built as a module

2020-08-19 Thread Tingwei Zhang
From: Kim Phillips Allow to build coresight-etm4x as a module, for ease of development. - Kconfig becomes a tristate, to allow =m - append -core to source file name to allow module to be called coresight-etm4x by the Makefile - add an etm4_remove function, for module unload - add a

[PATCH v9 09/24] coresight: etm3x: allow etm3x to be built as a module

2020-08-19 Thread Tingwei Zhang
From: Kim Phillips Allow to build coresight-etm3x as a module, for ease of development. - Kconfig becomes a tristate, to allow =m - append -core to source file name to allow module to be called coresight-etm3x by the Makefile - add an etm_remove function, for module unload - add a

[PATCH v9 06/24] coresight: add try_get_module() in coresight_grab_device()

2020-08-19 Thread Tingwei Zhang
When coresight device is in an active session, driver module of that device should not be removed. Use try_get_module() in coresight_grab_device() to prevent module to be unloaded. Use get_device()/put_device() to protect device data in the middle of active session. Signed-off-by: Tingwei Zhang

[PATCH v9 03/24] coresight: use IS_ENABLED for CONFIGs that may be modules

2020-08-19 Thread Tingwei Zhang
From: Kim Phillips Checking for ifdef CONFIG_x fails if CONFIG_x=m. Use IS_ENABLED that is true for both built-ins and modules, instead. Required when building coresight components as modules. Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc: Randy Dunlap Cc: Suzuki K Poulose

[PATCH v9 08/24] coresight: etm: perf: Fix warning caused by etm_setup_aux failure

2020-08-19 Thread Tingwei Zhang
When coresight_build_path() fails on all the cpus, etm_setup_aux calls etm_free_aux() to free allocated event_data. WARN_ON(cpumask_empty(mask) will be triggered since cpu mask is empty. Check event_data->snk_config is not NULL first to avoid this warning. Signed-off-by: Tingwei Zhang

[PATCH v9 02/24] coresight: cpu_debug: define MODULE_DEVICE_TABLE

2020-08-19 Thread Tingwei Zhang
Define a MODULE_DEVICE_TABLE for cpu_debug so module can be auto loaded on boot. Signed-off-by: Tingwei Zhang Reviewed-by: Suzuki K Poulose Reviewed-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-cpu-debug.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH v9 05/24] coresight: export global symbols

2020-08-19 Thread Tingwei Zhang
From: Mian Yousaf Kaukab Export symbols used among coresight modules. Signed-off-by: Mian Yousaf Kaukab Signed-off-by: Tingwei Zhang Tested-by: Mike Leach Reviewed-by: Suzuki K Poulose Reviewed-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +

[PATCH v9 04/24] coresight: add coresight prefix to barrier_pkt

2020-08-19 Thread Tingwei Zhang
Add coresight prefix to make it specific. It will be a export symbol. Signed-off-by: Mian Yousaf Kaukab Signed-off-by: Tingwei Zhang Reviewed-by: Suzuki K Poulose Reviewed-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etb10.c | 2 +-

[PATCH v2 02/11] usb: early: ehci-dbgp: convert to readl_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Cc: "Eric W. Biederman" Cc: Petr Mladek Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/early/ehci-dbgp.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/usb/early/ehci-dbgp.c

[PATCH v9 07/24] coresight: stm: allow to build coresight-stm as a module

2020-08-19 Thread Tingwei Zhang
- Kconfig becomes a tristate, to allow =m - add a stm_remove function, for module unload - add a MODULE_DEVICE_TABLE for autoloading on boot Cc: Mathieu Poirier Cc: Leo Yan Cc: Alexander Shishkin Cc: Randy Dunlap Cc: Suzuki K Poulose Cc: Greg Kroah-Hartman Cc: Russell King Signed-off-by:

[PATCH] [v2] wilc1000: Fix memleak in wilc_sdio_probe

2020-08-19 Thread Dinghao Liu
When devm_clk_get() returns -EPROBE_DEFER, sdio_priv should be freed just like when wilc_cfg80211_init() fails. Fixes: 8692b047e86cf ("staging: wilc1000: look for rtc_clk clock") Signed-off-by: Dinghao Liu --- Changelog: v2: - Remove 'staging' prefix in subject. ---

[PATCH v2 07/11] usb: isp1760-hcd: convert to readl_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/isp1760/isp1760-hcd.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c

[PATCH v9 00/24] coresight: allow to build coresight as modules

2020-08-19 Thread Tingwei Zhang
Allow to build coresight as modules. This gives developers the feasibility to test their code without reboot. This series is based on below two series. - "coresight: allow to build components as modules" https://lkml.org/lkml/2018/6/5/989 - "coresight: make drivers modular"

[PATCH v2 08/11] usb: phy-ulpi-viewport: convert to readl_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/phy/phy-ulpi-viewport.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/usb/phy/phy-ulpi-viewport.c b/drivers/usb/phy/phy-ulpi-viewport.c

[PATCH v2 11/11] iopoll: update kerneldoc of read_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Arguments description of read_poll_timeout_atomic() if out of date, update it. Cc: Alan Stern Signed-off-by: Chunfeng Yun --- v2: new patch, suggested by Alan --- include/linux/iopoll.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/iopoll.h

[PATCH v9 01/24] coresight: cpu_debug: add module name in Kconfig

2020-08-19 Thread Tingwei Zhang
Provide name of cpu_debug module in Kconfig help section. Signed-off-by: Tingwei Zhang Tested-by: Mike Leach Reviewed-by: Suzuki K Poulose Reviewed-by: Mathieu Poirier --- drivers/hwtracing/coresight/Kconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v2 05/11] usb: oxu210hp-hcd: convert to readl_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/host/oxu210hp-hcd.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/oxu210hp-hcd.c b/drivers/usb/host/oxu210hp-hcd.c index

[PATCH v2 04/11] usb: xhci-rcar: convert to readl_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Cc: Mathias Nyman Cc: Yoshihiro Shimoda Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/host/xhci-rcar.c | 43 --- 1 file changed, 12 insertions(+), 31 deletions(-) diff --git

[PATCH v2 01/11] usb: early: convert to readl_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Cc: Lu Baolu Cc: Mathias Nyman Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/early/xhci-dbc.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/usb/early/xhci-dbc.c

[PATCH v2 10/11] usb: udc: net2280: convert to readl_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Cc: Alan Stern Cc: Felipe Balbi Signed-off-by: Chunfeng Yun Acked-by: Alan Stern --- v2: add Acked-by Alan --- drivers/usb/gadget/udc/net2280.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git

[PATCH v2 09/11] usb: phy: phy-mv-usb: convert to readl_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Signed-off-by: Chunfeng Yun --- v2: udelay 10us instead of 20us according to kerneldoc --- drivers/usb/phy/phy-mv-usb.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/usb/phy/phy-mv-usb.c

[PATCH v2 06/11] usb: fotg210-hcd: convert to readl_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/host/fotg210-hcd.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/usb/host/fotg210-hcd.c b/drivers/usb/host/fotg210-hcd.c index

[PATCH v2 03/11] usb: pci-quirks: convert to readl_poll_timeout_atomic()

2020-08-19 Thread Chunfeng Yun
Use readl_poll_timeout_atomic() to simplify code Cc: Mathias Nyman Signed-off-by: Chunfeng Yun --- v2: no changes --- drivers/usb/host/pci-quirks.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c

Re: Re: [PATCH] staging: wilc1000: Fix memleak in wilc_sdio_probe

2020-08-19 Thread dinghao . liu
ajay.kat...@microchip.com写道: > Thanks for submitting the patch. The code changes looks okay to me. > > The driver is now moved out of staging so 'staging' prefix is not > required in subject. For future patches on wilc driver, the 'staging' > prefix can be removed. > > For this patch, I am not

Re: [Patch] cpufreq: replace cpu_logical_map with read_cpuid_mpir

2020-08-19 Thread Viresh Kumar
On 12-08-20, 01:13, Sumit Gupta wrote: > Commit eaecca9e7710 ("arm64: Fix __cpu_logical_map undefined issue") > fixes the issue with building tegra194 cpufreq driver as module. But > the fix might cause problem while supporting physical cpu hotplug[1]. > > This patch fixes the original problem by

INFO: task can't die in netdev_run_todo

2020-08-19 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:4993e4fe Add linux-next specific files for 20200814 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1181e1a690 kernel config: https://syzkaller.appspot.com/x/.config?x=2055bd0d83d5ee16 dashboard

KASAN: global-out-of-bounds Read in fbcon_resize

2020-08-19 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:8eb858df Add linux-next specific files for 20200819 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=1158a00e90 kernel config: https://syzkaller.appspot.com/x/.config?x=cd187ef624ef7f02 dashboard

Re: [PATCH 2/2] nvme: add emulation for zone-append

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 01:11:58PM -0600, David Fugate wrote: > On Tue, 2020-08-18 at 07:12 +, Christoph Hellwig wrote: > > On Tue, Aug 18, 2020 at 10:59:36AM +0530, Kanchan Joshi wrote: > > > If drive does not support zone-append natively, enable emulation > > > using > > > regular write. > >

Re: [PATCH] staging: wilc1000: Fix memleak in wilc_sdio_probe

2020-08-19 Thread Ajay.Kathat
Thanks for submitting the patch. The code changes looks okay to me. The driver is now moved out of staging so 'staging' prefix is not required in subject. For future patches on wilc driver, the 'staging' prefix can be removed. For this patch, I am not sure if Kalle can apply as is otherwise

[PATCH] dt-bindings: spi: Convert spi-mtk-nor to json-schema

2020-08-19 Thread Ikjoon Jang
Convert Mediatek ARM SOC's serial NOR flash controller binding to json-schema format. Signed-off-by: Ikjoon Jang --- .../bindings/spi/mediatek,spi-mtk-nor.yaml| 82 +++ .../devicetree/bindings/spi/spi-mtk-nor.txt | 47 --- 2 files changed, 82 insertions(+), 47

[PATCH] drivers: gpu: amd: Initialize amdgpu_dm_backlight_caps object to 0 in amdgpu_dm_update_backlight_caps

2020-08-19 Thread Furquan Shaikh
In `amdgpu_dm_update_backlight_caps()`, there is a local `amdgpu_dm_backlight_caps` object that is filled in by `amdgpu_acpi_get_backlight_caps()`. However, this object is uninitialized before the call and hence the subsequent check for aux_support can fail since it is not initialized by

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Thu, Aug 20, 2020 at 06:43:47AM +0200, Christoph Hellwig wrote: > On Wed, Aug 19, 2020 at 03:57:53PM +0200, Tomasz Figa wrote: > > > > Could you explain what makes you think it's unused? It's a feature of > > > > the UAPI generally supported by the videobuf2 framework and relied on > > > > by

Re: [PATCH 19/28] dma-mapping: replace DMA_ATTR_NON_CONSISTENT with dma_{alloc, free}_pages

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 05:03:52PM +0200, Tomasz Figa wrote: > > > > -Warning: These pieces of the DMA API should not be used in the > > -majority of cases, since they cater for unlikely corner cases that > > -don't belong in usual drivers. > > +These APIs allow to allocate pages that can be used

Re: [PATCH] Harden autofs ioctl table

2020-08-19 Thread Ian Kent
On Tue, 2020-08-18 at 13:22 +0100, Matthew Wilcox wrote: > The table of ioctl functions should be marked const in order to put > them > in read-only memory, and we should use array_index_nospec() to avoid > speculation disclosing the contents of kernel memory to userspace. > > Signed-off-by:

Re: [driver core] e2ae9bcc4a: unixbench.score -2.2% regression

2020-08-19 Thread Saravana Kannan
On Wed, Aug 19, 2020 at 12:06 AM kernel test robot wrote: > > Greeting, > > FYI, we noticed a -2.2% regression of unixbench.score due to commit: > > > commit: e2ae9bcc4aaacda04edb75c4eea93384719efaa5 ("driver core: Add support > for linking devices during device addition") >

Re: [PATCH v2] mm, THP, swap: fix allocating cluster for swapfile by mistake

2020-08-19 Thread Huang, Ying
Gao Xiang writes: > SWP_FS is used to make swap_{read,write}page() go through > the filesystem, and it's only used for swap files over > NFS. So, !SWP_FS means non NFS for now, it could be either > file backed or device backed. Something similar goes with > legacy SWP_FILE. > > So in order to

Re: [clk] a2499eff4b: BUG:kernel_NULL_pointer_dereference,address

2020-08-19 Thread Rong Chen
On 8/19/20 11:13 AM, Stephen Boyd wrote: Quoting kernel test robot (2020-08-11 01:49:44) Greeting, FYI, we noticed the following commit (built with gcc-9): commit: a2499eff4b30a85d56e4466e6ca4746c72a347c6 ("[PATCH v2] clk: samsung: Keep top BPLL mux on Exynos542x enabled") url:

[PATCHv2] PCI: Add pci_iounmap

2020-08-19 Thread George Cherian
In case if any architecture selects CONFIG_GENERIC_PCI_IOMAP and not CONFIG_GENERIC_IOMAP, then the pci_iounmap function is reduced to a NULL function. Due to this the managed release variants or even the explicit pci_iounmap calls doesn't really remove the mappings. This issue is seen on an

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 03:07:04PM +0100, Robin Murphy wrote: >> FWIW, I asked back in time what the plan is for non-coherent >> allocations and it seemed like DMA_ATTR_NON_CONSISTENT and >> dma_sync_*() was supposed to be the right thing to go with. [2] The >> same thread also explains why

KMSAN: uninit-value in soft_cursor

2020-08-19 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:ce8056d1 wip: changed copy_from_user where instrumented git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=14dcd11690 kernel config:

Re: linux-next: Fixes tag needs some work in the pm tree

2020-08-19 Thread Viresh Kumar
On 20-08-20, 08:01, Stephen Rothwell wrote: > Hi all, > > In commit > > ceac7fc18ac7 ("opp: Enable resources again if they were disabled earlier") > > Fixes tag > > Fixes: cd7ea582 ("opp: Make dev_pm_opp_set_rate() handle freq = 0 to drop > performance votes") > > has these problem(s): >

[PATCH v2] mm, THP, swap: fix allocating cluster for swapfile by mistake

2020-08-19 Thread Gao Xiang
SWP_FS is used to make swap_{read,write}page() go through the filesystem, and it's only used for swap files over NFS. So, !SWP_FS means non NFS for now, it could be either file backed or device backed. Something similar goes with legacy SWP_FILE. So in order to achieve the goal of the original

Re: [PATCH v2] checkpatch: Fix the usage of capture group ( ... )

2020-08-19 Thread Mrinal Pandey
On 20/07/30 12:31AM, Joe Perches wrote: > On Thu, 2020-07-30 at 07:58 +0200, Lukas Bulwahn wrote: > > Hi Joe, > > > > did you see this quick fix to checkpatch.pl? Can you comment on the > > commit and can we get a quick ack on that fix, please? > > Yes, in a bit. > > > General question on

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 04:22:29PM +0200, Tomasz Figa wrote: > > > FWIW, I asked back in time what the plan is for non-coherent > > > allocations and it seemed like DMA_ATTR_NON_CONSISTENT and > > > dma_sync_*() was supposed to be the right thing to go with. [2] The > > > same thread also explains

[PATCH v8 0/2] pwm: intel: Add PWM driver for a new SoC

2020-08-19 Thread Rahul Tanwar
Patch 1 adds dt binding document in YAML format. Patch 2 add PWM fan controller driver for LGM SoC. v8: - Remove fan related optional properties usage, keep them as default. If needed, change pwm-fan driver separately in future to add them as generic properties. v7: - Address code quality

Re: [RESEND PATCH 3/5] ARM: dts: spear: Align L2 cache-controller nodename with dtschema

2020-08-19 Thread Viresh Kumar
On 19-08-20, 19:58, Krzysztof Kozlowski wrote: > Fix dtschema validator warnings like: > l2-cache: $nodename:0: 'l2-cache' does not match > '^(cache-controller|cpu)(@[0-9a-f,]+)*$' > > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm/boot/dts/spear13xx.dtsi | 2 +- > 1 file changed, 1

[PATCH v8 2/2] Add PWM fan controller driver for LGM SoC

2020-08-19 Thread Rahul Tanwar
Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. This PWM controller does not have any other consumer, it is a dedicated PWM controller for fan attached to the system. Add driver for this PWM fan controller. Signed-off-by: Rahul Tanwar --- drivers/pwm/Kconfig | 11 ++

[PATCH v8 1/2] Add DT bindings YAML schema for PWM fan controller of LGM SoC

2020-08-19 Thread Rahul Tanwar
Intel's LGM(Lightning Mountain) SoC contains a PWM fan controller which is only used to control the fan attached to the system. This PWM controller does not have any other consumer other than fan. Add DT bindings documentation for this PWM fan controller. Signed-off-by: Rahul Tanwar ---

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 04:11:52PM +0200, Tomasz Figa wrote: > > > By the way, as a videobuf2 reviewer, I'd appreciate being CC'd on any > > > series related to the subsystem-facing DMA API changes, since > > > videobuf2 is one of the biggest users of it. > > > > The cc list is too long - I cc

Re: [PATCH 05/28] media/v4l2: remove V4L2-FLAG-MEMORY-NON-CONSISTENT

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 03:57:53PM +0200, Tomasz Figa wrote: > > > Could you explain what makes you think it's unused? It's a feature of > > > the UAPI generally supported by the videobuf2 framework and relied on > > > by Chromium OS to get any kind of reasonable performance when > > > accessing

Re: [GIT PULL] VFIO fix for v5.9-rc2

2020-08-19 Thread pr-tracker-bot
The pull request you sent on Wed, 19 Aug 2020 13:04:22 -0600: > git://github.com/awilliam/linux-vfio.git tags/vfio-v5.9-rc2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7eac66d0456fe12a462e5c14c68e97c7460989da Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH] mm, THP, swap: fix allocating cluster for swapfile by mistake

2020-08-19 Thread Gao Xiang
Hi Ying, On Thu, Aug 20, 2020 at 12:36:08PM +0800, Huang, Ying wrote: > Gao Xiang writes: > > > SWP_FS doesn't mean the device is file-backed swap device, > > which just means each writeback request should go through fs > > by DIO. Or it'll just use extents added by .swap_activate(), > > but it

Re: [PATCH] net: bypass ->sendpage for slab pages

2020-08-19 Thread Christoph Hellwig
On Wed, Aug 19, 2020 at 12:07:09PM -0700, David Miller wrote: > Yes this fixes the problem, but it doesn't in any way deal with the > callers who are doing this stuff. > > They are all likely using sendpage because they expect that it will > avoid the copy, for performance reasons or whatever. >

Re: [PATCH] mm, THP, swap: fix allocating cluster for swapfile by mistake

2020-08-19 Thread Huang, Ying
Gao Xiang writes: > SWP_FS doesn't mean the device is file-backed swap device, > which just means each writeback request should go through fs > by DIO. Or it'll just use extents added by .swap_activate(), > but it also works as file-backed swap device. > > So in order to achieve the goal of the

[PATCH] ASoC: qcom: common: Fix refcount imbalance on error

2020-08-19 Thread Dinghao Liu
for_each_child_of_node returns a node pointer np with refcount incremented. So when devm_kzalloc fails, a pairing refcount decrement is needed to keep np's refcount balanced. Fixes: 16395ceee11f8 ("ASoC: qcom: common: Fix NULL pointer in of parser") Signed-off-by: Dinghao Liu ---

Re: GPS fun on Droid 4 and leste

2020-08-19 Thread Tony Lindgren
* Pavel Machek [200712 09:28]: > Hi! > > GPS on the droid 4 does not really work out of the box. > > gpsd is not in default installation, maybe it should be? > > What is worse, there's something broken with gpsd. Try: > > /usr/sbin/gpsd -N -D 5 /dev/gnss0 > gpspipe -w > # this seems to work,

Re: [PATCH v7 0/3] Modularization of DFL private feature drivers

2020-08-19 Thread Moritz Fischer
Hi Xu, On Wed, Aug 19, 2020 at 03:45:18PM +0800, Xu Yilun wrote: > This patchset makes it possible to develop independent driver modules > for DFL private features. It also helps to leverage existing kernel > drivers to enable some IP blocks in DFL. > > Patch #1: Release the dfl mmio regions

Re: [PATCH v4 1/4] fpga: dfl: change data type of feature id to u16

2020-08-19 Thread Moritz Fischer
On Thu, Aug 13, 2020 at 05:04:09PM +0800, Xu Yilun wrote: > On Thu, Aug 13, 2020 at 08:28:05AM +, David Laight wrote: > > From: Xu Yilun > > > Sent: 13 August 2020 08:59 > > > On Wed, Aug 12, 2020 at 08:52:39AM +, David Laight wrote: > > > > From: Moritz Fischer > > > > > Sent: 12 August

Re: [RFC] Limiting charge current on Droid 4 (and N900)

2020-08-19 Thread Tony Lindgren
* Tony Lindgren [200629 18:46]: > * Pavel Machek [200615 07:06]: > > Hi! > > > > Droid 4 has same problem as N900: it is often neccessary to manually > > tweak current draw from USB, for example when using thin charging cable. > > > > N900 creates unique attribute by hand, but I believe > >

Re: [PATCH v1 3/3] arm64: defconfig: Enable imx8mq-librem5-devkit display stack

2020-08-19 Thread Fabio Estevam
Hi Guido, On Wed, Jul 29, 2020 at 9:19 AM Guido Günther wrote: > > Enable the panel, NWL DSI host controller and dphy. This > also needs the reset controller. > > Signed-off-by: Guido Günther > --- > arch/arm64/configs/defconfig | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > >

Re: [PATCH 1/3] fpga manager: xilinx-spi: remove stray comment

2020-08-19 Thread Moritz Fischer
On Mon, Aug 17, 2020 at 06:59:09PM +0200, Luca Ceresoli wrote: > Remove comment committed by mistake. > > Fixes: dd2784c01d93 ("fpga manager: xilinx-spi: check INIT_B pin during > write_init") > Signed-off-by: Luca Ceresoli > --- > drivers/fpga/xilinx-spi.c | 1 - > 1 file changed, 1

[PATCH v2] ARM: dts: vfxxx: Add syscon compatible with ocotp

2020-08-19 Thread Chris Healy
From: Chris Healy Add syscon compatibility with Vybrid ocotp node. This is required to access the UID. Fixes: fa8d20c8dbb77 ("ARM: dts: vfxxx: Add node corresponding to OCOTP") Cc: sta...@vger.kernel.org Signed-off-by: Chris Healy --- Changes in v2: - Add Fixes line to commit message

Re: [PATCH] x86/pci: fix intel_mid_pci.c build error when ACPI is not enabled

2020-08-19 Thread Randy Dunlap
On 8/13/20 1:55 PM, Andy Shevchenko wrote: > On Thu, Aug 13, 2020 at 11:31 PM Arjan van de Ven > wrote: >> On 8/13/2020 12:58 PM, Randy Dunlap wrote: >>> From: Randy Dunlap >>> >>> Fix build error when CONFIG_ACPI is not set/enabled by adding >>> the header file which contains a stub for the

Re: [PATCH v1 2/3] arm64: dts: imx8mq-librem5-devkit: Enable the LCD panel

2020-08-19 Thread Fabio Estevam
Hi Guido, On Wed, Jul 29, 2020 at 9:19 AM Guido Günther wrote: > > Enable LCD panel output by adding nodes for the NWL DSI host controller, > the Rocktech panel and the eLCDIF display controller. > > Signed-off-by: Guido Günther Reviewed-by: Fabio Estevam

Re: [PATCH v1 1/3] arm64: dts: imx8mq: Add NWL MIPI DSI controller

2020-08-19 Thread Fabio Estevam
Hi Guido, On Wed, Jul 29, 2020 at 9:19 AM Guido Günther wrote: > > Add a node for the Northwest Logic MIPI DSI IP core, "disabled" by > default. This also adds the necessary port to LCDIF. > > Signed-off-by: Guido Günther Reviewed-by: Fabio Estevam

Re: [PATCH][next] ASoC: qcom: add missing out of memory check on drvdata->clks allocation

2020-08-19 Thread Rohit Kumar
On 8/19/2020 9:31 PM, Colin King wrote: From: Colin Ian King Currently drvdata->clks is not being checked for an allocation failure, leading to potential null pointer dereferencing. Fix this by adding a check and returning -ENOMEM if an error occurred. Addresses-Coverity: ("Dereference null

[PATCH 4/3] drm: hikey9xx: remove wait for VACTIVE IRQ

2020-08-19 Thread John Stultz
From: Vincent Donnefort A quick add-on to my earlier fixup series as I realized what the performance problem was. This is against Mauro's tree here: https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/master/ For each display cycle, the Kirin960 display IP will generate a

Re: Re: [PATCH] video: backlight: sky81452-backlight: Fix reference count imbalance on error

2020-08-19 Thread dinghao . liu
> On Wed, 19 Aug 2020, Markus Elfring wrote: > > > > When of_property_read_u32_array() returns an error code, > > > a pairing refcount decrement is needed to keep np's refcount balanced. > > > > Can another imperative wording be helpful for the change description? > >

Re: [RESEND PATCH 1/2] dma-buf: Fix kerneldoc of dma_buf_set_name()

2020-08-19 Thread Sumit Semwal
Hello Krzystof, On Wed, 19 Aug 2020 at 23:21, Krzysztof Kozlowski wrote: > > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/dma-buf/dma-buf.c:328: warning: Function parameter or member > 'dmabuf' not described in 'dma_buf_set_name' Thanks for the patch; I will apply it to

Re: [REGRESSION 5.8] x86/entry: DR0 break-on-write not working

2020-08-19 Thread Josh Poimboeuf
On Wed, Aug 19, 2020 at 05:14:18PM -0700, Andy Lutomirski wrote: > On Wed, Aug 19, 2020 at 3:47 PM Josh Poimboeuf wrote: > > What amazes me is that it successfully schedules back to the end of the > > #DB handler finish and everything keeps working. > > > > Do we not have assertions in the

Re: [PATCH 2/2] nvme: add emulation for zone-append

2020-08-19 Thread Keith Busch
On Wed, Aug 19, 2020 at 05:43:29PM -0600, David Fugate wrote: > There were queries? My key takeaways were a maintainer NAK followed by > instructions to make the Intel drive align with the driver by > implementing NOIOB. While I disagree with the rejection as it appeared > to be based entirely on

[PATCH 3/3] drm: hikey9xxx: Fix null pointer crash on reboot

2020-08-19 Thread John Stultz
This is against Mauro's tree here: https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/master/ On reboot we see the following crash: [ 608.746787] Unable to handle kernel read from unreadable memory at virtual address 00a8 ... [ 608.822101] CPU: 3 PID: 234 Comm:

[PATCH 2/3] drm: kirin9xxx: Add additional color formats

2020-08-19 Thread John Stultz
This is against Mauro's tree here: https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/master/ Add support for two color formats (ARGB and ABGR) needed for use with drm_hwcomposer and AOSP. NOTE: I see Red/Blue swapped colors with this (and yes I did try the obvious swap of formats

[PATCH 1/3] drm: hikey9xx: Fix inconsistent compat string

2020-08-19 Thread John Stultz
This is against Mauro's tree here: https://gitlab.freedesktop.org/mchehab_kernel/hikey-970/-/commits/master/ A previous patch changed this string to be "hisilicon,kirin960-dpe", but there are other place where the code still expects "hisilicon,hi3660-dpe", so change it back. Cc: Mauro Carvalho

Re: [PATCH v2 3/5] Revert "lib/string.c: implement a basic bcmp"

2020-08-19 Thread Nathan Chancellor
On Wed, Aug 19, 2020 at 12:16:52PM -0700, Nick Desaulniers wrote: > This reverts commit 5f074f3e192f10c9fade898b9b3b8812e3d83342. > > An earlier commit in the series prevents the compiler from emitting > calls to bcmp as part of "libcall optimization," and there are no > explicit callers, so we

Re: [PATCH v2 1/5] Makefile: add -fno-builtin-stpcpy

2020-08-19 Thread Nathan Chancellor
On Wed, Aug 19, 2020 at 12:16:50PM -0700, Nick Desaulniers wrote: > LLVM implemented a recent "libcall optimization" that lowers calls to > `sprintf(dest, "%s", str)` where the return value is used to > `stpcpy(dest, str) - dest`. This generally avoids the machinery involved > in parsing format

Re: [PATCH v2 2/5] Makefile: add -fno-builtin-bcmp

2020-08-19 Thread Nathan Chancellor
On Wed, Aug 19, 2020 at 12:16:51PM -0700, Nick Desaulniers wrote: > The issue with using `-fno-builtin-*` flags was that they were not > retained during an LTO link with LLVM. This was fixed in clang-11 by > https://reviews.llvm.org/D71193 > (0508c994f0b14144041f2cfd3ba9f9a80f03de08), which is

Re: [PATCH v1 01/11] perf/x86/core: Support KVM to assign a dedicated counter for guest PEBS

2020-08-19 Thread Like Xu
Hi Peter, On 2020/6/12 13:28, Kang, Luwei wrote: Suppose your KVM thing claims counter 0/2 (ICL/SKL) for some random PEBS event, and then the host wants to use PREC_DIST.. Then one of them will be screwed for no reason what so ever. The multiplexing should be triggered. For host, if both

Re: [PATCH 00/49] DRM driver for Hikey 970

2020-08-19 Thread John Stultz
On Wed, Aug 19, 2020 at 7:01 PM John Stultz wrote: > > On Wed, Aug 19, 2020 at 2:36 PM John Stultz wrote: > > > > On Wed, Aug 19, 2020 at 4:46 AM Mauro Carvalho Chehab > > wrote: > > > So, IMO, the best is to keep it on staging for a while, until those > > > remaining bugs gets solved. > > > >

[PATCH] debugobjects: install cpu hotplug callback

2020-08-19 Thread qiang.zhang
From: Zqiang When a cpu going offline, we should free objects in "percpu_obj_pool" free_objs list which corresponding to this cpu. Signed-off-by: Zqiang --- include/linux/cpuhotplug.h | 1 + lib/debugobjects.c | 23 +++ 2 files changed, 24 insertions(+) diff

  1   2   3   4   5   6   7   8   9   10   >