Re: [PATCH 2/2] dev_ioctl: split out SIOC?IFMAP ioctls

2020-09-18 Thread Christoph Hellwig
> diff --git a/include/uapi/linux/if.h b/include/uapi/linux/if.h > index 797ba2c1562a..a332d6ae4dc6 100644 > --- a/include/uapi/linux/if.h > +++ b/include/uapi/linux/if.h > @@ -247,7 +247,13 @@ struct ifreq { > short ifru_flags; > int ifru_ivalue; >

[PATCH v5 1/3] leds: pwm: Remove platform_data support

2020-09-18 Thread Alexander Dahl
Since commit 141f15c66d94 ("leds: pwm: remove header") that platform interface is not usable from outside and there seems to be no in tree user anymore. All in-tree users of the leds-pwm driver seem to use DT currently. Getting rid of the old platform interface will allow the leds-pwm driver to

[PATCH v5 0/3] leds: pwm: Make automatic labels work

2020-09-18 Thread Alexander Dahl
Hei hei, for leds-gpio you can use the properties 'function' and 'color' in the devicetree node and omit 'label', the label is constructed automatically. This is a common feature supposed to be working for all LED drivers. However it did not yet work for the 'leds-pwm' driver. This series

Re: [PATCH 1/2] ethtool: improve compat ioctl handling

2020-09-18 Thread Christoph Hellwig
> + if (ethtool_translate_compat()) { > + struct compat_ethtool_rxnfc crxnfc = {}; > + > + if (copy_from_user(, useraddr, > +min(size, sizeof(crxnfc > + return -EFAULT; > + > + *rxnfc = (struct

Re: [PATCH 4/4] mm: remove compat numa syscalls

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 03:24:39PM +0200, Arnd Bergmann wrote: > The compat implementations for mbind, get_mempolicy, set_mempolicy > and migrate_pages are just there to handle the subtly different > layout of bitmaps on 32-bit hosts. > > The compat implementation however lacks some of the checks

Re: [PATCH -next] tty: serial: imx: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n

2020-09-18 Thread Greg KH
On Sat, Sep 19, 2020 at 10:26:38AM +0800, Yang Yingliang wrote: > Hi, > > On 2020/9/18 19:16, Greg KH wrote: > > On Fri, Sep 18, 2020 at 05:13:05PM +0800, Yang Yingliang wrote: > > > Fix the link error by selecting SERIAL_CORE_CONSOLE. > > > > > > aarch64-linux-gnu-ld:

Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n

2020-09-18 Thread Greg KH
On Sat, Sep 19, 2020 at 10:48:41AM +0800, Yang Yingliang wrote: > > On 2020/9/18 19:17, Greg KH wrote: > > On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote: > > > Fix the link error by selecting SERIAL_CORE_CONSOLE. > > > > > > aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in

[PATCH v5 2/3] leds: pwm: Allow automatic labels for DT based devices

2020-09-18 Thread Alexander Dahl
If LEDs are configured through device tree and the property 'label' is omitted, the label is supposed to be generated from the properties 'function' and 'color' if present. While this works fine for e.g. the 'leds-gpio' driver, it did not for 'leds-pwm'. The reason is, you get this label naming

Re: [PATCH 3/4] mm: remove compat_sys_move_pages

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 03:24:38PM +0200, Arnd Bergmann wrote: > The compat move_pages() implementation uses compat_alloc_user_space() > for converting the pointer array. Moving the compat handling into > the function itself is a bit simpler and lets us avoid the > compat_alloc_user_space() call.

[PATCH v5 3/3] dt-bindings: leds: Convert pwm to yaml

2020-09-18 Thread Alexander Dahl
The example was adapted slightly to make use of the 'function' and 'color' properties. License discussed with the original author. Suggested-by: Jacek Anaszewski Signed-off-by: Alexander Dahl Cc: Peter Ujfalusi --- Notes: v4 -> v5: * updated based on feedback by Rob Herring *

Re: [PATCH 2/4] kexec: remove compat_sys_kexec_load syscall

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 03:24:37PM +0200, Arnd Bergmann wrote: > The compat version of sys_kexec_load() uses compat_alloc_user_space to > convert the user-provided arguments into the native format. > > Move the conversion into the regular implementation with > an in_compat_syscall() check to

Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote: > sys_move_pages() is an optional syscall, and once we remove > the compat version of it in favor of the native one with an > in_compat_syscall() check, the x32 syscall table refers to > a __x32_sys_move_pages symbol that may not exist

Re: [PATCH v2 5/9] ARM: oabi-compat: rework epoll_wait/epoll_pwait emulation

2020-09-18 Thread Christoph Hellwig
> index 855aa7cc9b8e..156880943c16 100644 > --- a/arch/arm/include/asm/syscall.h > +++ b/arch/arm/include/asm/syscall.h > @@ -28,6 +28,17 @@ static inline int syscall_get_nr(struct task_struct *task, > return task_thread_info(task)->syscall & ~__NR_OABI_SYSCALL_BASE; > } > > +static

Re: [PATCH v2] hwmon:Driver for Delta power supplies

2020-09-18 Thread Guenter Roeck
On 9/18/20 12:18 AM, xiao.mx.ma wrote: > Add delta.rst in Documentation/hwmon > Tristate "DELTA" in Kconfig is changed to "DELTA_POWER_SUPPLIES" > Modify code: drop the excessive empty lines, correct the comment content, > adjust indent, remove extra brackets. > Description goes here. >

Re: [PATCH v2 2/9] ARM: traps: use get_kernel_nofault instead of set_fs()

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 02:46:17PM +0200, Arnd Bergmann wrote: > ARM uses set_fs() and __get_user() to allow the stack dumping code to > access possibly invalid pointers carefully. These can be changed to the > simpler get_kernel_nofault(), and allow the eventual removal of set_fs(). > >

Re: [PATCH v2 0/9] ARM: remove set_fs callers and implementation

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 02:46:15PM +0200, Arnd Bergmann wrote: > Hi Christoph, Russell, > > Here is an updated series for removing set_fs() from arch/arm, > based on the previous feedback. > > I have tested the oabi-compat changes using the LTP tests for the three > modified syscalls using an

Re: [PATCH v2 3/3] scsi: megaraid_sas: simplify compat_ioctl handling

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 02:15:43PM +0200, Arnd Bergmann wrote: > There have been several attempts to fix serious problems > in the compat handling in megasas_mgmt_compat_ioctl_fw(), > and it also uses the compat_alloc_user_space() function. > > Folding the compat handling into the regular ioctl >

Re: [PATCH v2 2/3] scsi: megaraid_sas: check user-provided offsets

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 02:15:22PM +0200, Arnd Bergmann wrote: > It sounds unwise to let user space pass an unchecked 32-bit > offset into a kernel structure in an ioctl. This is an unsigned > variable, so checking the upper bound for the size of the structure > it points into is sufficient to

Re: [PATCH 02/14] block: switch register_disk to use blkdev_get_by_dev

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 11:52:39AM +0300, Sergei Shtylyov wrote: > Hello! > > On 17.09.2020 19:57, Christoph Hellwig wrote: > >> Use blkdev_get_by_dev instead of open coding it using bdget_disk + >> blkdev_get. > >I don't see where you are removing bdget_disk() call (situated just before > the

Re: [fs] 36e2c7421f: kernel-selftests.splice.short_splice_read.sh.fail

2020-09-18 Thread Christoph Hellwig
On Fri, Sep 18, 2020 at 02:49:19PM -0700, Kees Cook wrote: > In response to my recent bug fix for splice vs sysfs binary handler[1], > I added splice testing for other pseudo filesystems[2], for which the > test output is seen above. > > What is the final verdict on the "should splice have a

Re: [PATCH 3/4] erofs: specify accurate nr_iovecs for compressed bios

2020-09-18 Thread Gao Xiang
On Fri, Sep 18, 2020 at 09:54:35PM +0800, Gao Xiang wrote: > Use more accurate compressed page count > instead of BIO_MAX_PAGES unconditionally. > > Signed-off-by: Gao Xiang Found by ro_fsstress, the submission chain could be extended by other threads, so this patch wouldn't work with the tail

[PATCH] thermal/drivers/cpuidle_cooling: Change the latency limit

2020-09-18 Thread zhuguangqing83
From: zhuguangqing The injected idle duration must be greater than the wake up latency (entry + exit latency) or the idle state target residency (or min residency), otherwise we end up consuming more energy and potentially invert the mitigation effect. In function idle_inject_fn(), we call

Re: [PATCH v6 7/7] perf diff: Support hot streams comparison

2020-09-18 Thread Jin, Yao
Hi Arnaldo, On 9/18/2020 4:26 AM, Arnaldo Carvalho de Melo wrote: Em Fri, Sep 11, 2020 at 04:03:53PM +0800, Jin Yao escreveu: This patch enables perf-diff with "--stream" option. "--stream": Enable hot streams comparison Now let's see examples. perf record -b ... Generate perf.data.old

Re: [PATCH] riscv: Add sfence.vma after page table changed

2020-09-18 Thread Palmer Dabbelt
On Mon, 14 Sep 2020 20:58:13 PDT (-0700), greentime...@sifive.com wrote: Palmer Dabbelt 於 2020年8月5日 週三 上午10:03寫道: On Mon, 03 Aug 2020 20:29:32 PDT (-0700), a...@brainfault.org wrote: > On Tue, Aug 4, 2020 at 8:32 AM Greentime Hu wrote: >> >> This patch addes local_flush_tlb_page(addr) to use

Re: [PATCH v2] powerpc: fix EDEADLOCK redefinition error in uapi/asm/errno.h

2020-09-18 Thread Tony Ambardar
On Thu, 17 Sep 2020 at 07:34, Andreas Schwab wrote: > > On Sep 17 2020, Arnd Bergmann wrote: > > > The errno man page says they are supposed to be synonyms, > > and glibc defines it that way, while musl uses the numbers > > from the kernel. > > glibc also uses whatever the kernel defines. >

Re: [External] Re: [PATCH] tasklet: Introduce tasklet tracepoints

2020-09-18 Thread Muchun Song
On Sat, Sep 19, 2020 at 12:46 AM Steven Rostedt wrote: > > On Sat, 5 Sep 2020 14:04:12 +0800 > Muchun Song wrote: > > > Introduce tracepoints for tasklets just like softirq does. In this case, > > we can calculate tasklet latency and know what tasklet run. > > > > Signed-off-by: Muchun Song >

Re: [PATCH] MIPS: Loongson64: Add kexec/kdump support

2020-09-18 Thread Huacai Chen
Hi, Jinyang, On Fri, Sep 18, 2020 at 2:20 PM Jinyang He wrote: > > On 09/17/2020 09:52 PM, Zhou Yanjie wrote: > > Hello, > > > > 在 2020/9/17 下午8:41, Jinyang He 写道: > >> Hi, Huacai, > >> > >> > >> On 09/16/2020 01:39 PM, Huacai Chen wrote: > >>> Hi, Jinyang, > >>> > >>> On Tue, Sep 15, 2020 at

[PATCH] ARM: OMAP2+: Remove redundant assignment to variable ret

2020-09-18 Thread Jing Xiangfeng
The variable ret has been initialized with '-ENOMEM'. The assignment in the if branch is redundant. So remove it. Signed-off-by: Jing Xiangfeng --- arch/arm/mach-omap2/omap_device.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/omap_device.c

RE: [External] [PATCH] dm/dax: Fix table reference counts

2020-09-18 Thread Adrian Huang12
> -Original Message- > From: Dan Williams > Sent: Saturday, September 19, 2020 3:51 AM > To: dm-de...@redhat.com > Cc: sta...@vger.kernel.org; Jan Kara ; Alasdair Kergon > ; Mike Snitzer ; Adrian Huang12 > ; linux-nvd...@lists.01.org; linux- > ker...@vger.kernel.org > Subject: [External]

Re: [GIT PULL] percpu fix for v5.9-rc6

2020-09-18 Thread Arvind Sankar
On Sat, Sep 19, 2020 at 03:45:56AM +0100, Matthew Wilcox wrote: > On Fri, Sep 18, 2020 at 06:39:57PM -0400, Arvind Sankar wrote: > > On Fri, Sep 18, 2020 at 02:18:20PM -0700, Linus Torvalds wrote: > > > On Fri, Sep 18, 2020 at 2:00 PM Arvind Sankar > > > wrote: > > > > > > > > You could just

[PATCH] mm: fix some doc warnings in workingset.c

2020-09-18 Thread Xiaofei Tan
Fix following warnings caused by mismatch bewteen function parameters and comments. mm/workingset.c:228: warning: Function parameter or member 'lruvec' not described in 'workingset_age_nonresident' mm/workingset.c:228: warning: Excess function parameter 'memcg' description in

[PATCH] powerpc: Select HAVE_FUTEX_CMPXCHG

2020-09-18 Thread Samuel Holland
On powerpc, access_ok() succeeds for the NULL pointer. This breaks the dynamic check in futex_detect_cmpxchg(), which expects -EFAULT. As a result, robust futex operations are not functional on powerpc. Since the architecture's futex_atomic_cmpxchg_inatomic() implementation requires no runtime

Re: [PATCH v2 1/2] locktorture: doesn't check nreaders_stress when no readlock support

2020-09-18 Thread Hou Tao
Hi Paul, On 2020/9/19 1:59, Paul E. McKenney wrote: > On Fri, Sep 18, 2020 at 07:44:24PM +0800, Hou Tao wrote: >> When do locktorture for exclusive lock which doesn't have readlock >> support, the following module parameters will be considered as valid: >> >> torture_type=mutex_lock

RE: [PATCH] [v2] nvme: use correct upper limit for tag in nvme_handle_cqe()

2020-09-18 Thread Tianxianting
Hi Keith, Thanks a lot for your comments, I will try to figure out a safe fix for this issue, then for you review:) -Original Message- From: Keith Busch [mailto:kbu...@kernel.org] Sent: Saturday, September 19, 2020 3:21 AM To: tianxianting (RD) Cc: ax...@fb.com; h...@lst.de;

[PATCH] xen: remove redundant initialization of variable ret

2020-09-18 Thread Jing Xiangfeng
After commit 9f51c05dc41a ("pvcalls-front: Avoid get_free_pages(GFP_KERNEL) under spinlock"), the variable ret is being initialized with '-ENOMEM' that is meaningless. So remove it. Signed-off-by: Jing Xiangfeng --- drivers/xen/pvcalls-front.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH v2 0/3] crypto: hisilicon/hpre - misc clean up and fixes

2020-09-18 Thread yumeng 00484669
Adjust some tiny coding problems and fix a bug of DH algorithm. Changes since v1: Remove 'u64' cast in 'cpu_to_le64'; Meng Yu (3): crypto: hisilicon/hpre - remove useless code crypto: hisilicon/hpre - adjust some coding style crypto: hisilicon/hpre - fix a bug in dh algorithm

[PATCH v2 1/3] crypto: hisilicon/hpre - remove useless code

2020-09-18 Thread yumeng 00484669
From: Meng Yu 1. Remove unused member 'debug_root' in 'struct hpre_debug'; 2. The u64 cast is redundant in 'cpu_to_le64'. Fixes: 848974151618("crypto: hisilicon - Add debugfs for HPRE") Fixes: dadbe4c11753("crypto: hisilicon/hpre - update debugfs ...") Signed-off-by: Meng Yu Reviewed-by: Zaibo

[PATCH v2 3/3] crypto: hisilicon/hpre - fix a bug in dh algorithm

2020-09-18 Thread yumeng 00484669
From: Meng Yu Using 'g' not equal to 2 in dh algorithm may cause an error like this: arm-smmu-v3 arm-smmu-v3.1.auto: event 0x10 received: dh: Party A: generate public key test failed. err -22 11375.065672] dh alg: dh: test failed on vector 1, err=-22 arm-smmu-v3 arm-smmu-v3.1.auto:

[PATCH v2 2/3] crypto: hisilicon/hpre - adjust some coding style

2020-09-18 Thread yumeng 00484669
From: Meng Yu Adjust some coding style to make code aligned. Signed-off-by: Meng Yu Reviewed-by: Zaibo Xu --- drivers/crypto/hisilicon/hpre/hpre_crypto.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c

答复: [PATCH net-next] net: microchip: Remove set but not used variable

2020-09-18 Thread zhengyongjun
This is the bad patch, my fault, I forget to check patch title, please ignore it, thank you very much. -邮件原件- 发件人: zhengyongjun 发送时间: 2020年9月19日 10:39 收件人: bryan.whiteh...@microchip.com; unglinuxdri...@microchip.com; da...@davemloft.net; k...@kernel.org; net...@vger.kernel.org;

Re: [GIT PULL] s390 updates for 5.9-rc6

2020-09-18 Thread pr-tracker-bot
The pull request you sent on Sat, 19 Sep 2020 01:27:25 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git tags/s390-5.9-6 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/eb5f95f1593f7c22dac681b19e815828e2af3efd Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] percpu fix for v5.9-rc6

2020-09-18 Thread Linus Torvalds
On Fri, Sep 18, 2020 at 7:53 PM Arvind Sankar wrote: > > Is it ever necessary to allocate _at least_ sizeof() even if > offsetof()+size is smaller? Not that I can tell. Obviously all allocators tend to have their own alignment concerns, so they'll all align things up internally anyway. But why

Re: [GIT PULL] percpu fix for v5.9-rc6

2020-09-18 Thread Matthew Wilcox
On Fri, Sep 18, 2020 at 10:53:36PM -0400, Arvind Sankar wrote: > I think you can't do this in standard C. It's a GCC extension. > > A structure containing a flexible array member, or a union > containing such a structure (possibly recursively), may not be a > member of a

答复: [PATCH net-next] net: microchip: Remove set but not used variable

2020-09-18 Thread zhengyongjun
This is the bad patch, please ignore it, thank you very much. -邮件原件- 发件人: zhengyongjun 发送时间: 2020年9月19日 10:38 收件人: bryan.whiteh...@microchip.com; unglinuxdri...@microchip.com; da...@davemloft.net; k...@kernel.org; net...@vger.kernel.org; linux-kernel@vger.kernel.org 抄送: zhengyongjun

Re: [PATCH v7 11/11] usb: typec: tcpci_maxim: Implemnent set_auto_vbus_discharge_threshold

2020-09-18 Thread Badhri Jagan Sridharan
On Fri, Sep 18, 2020 at 7:20 AM Heikki Krogerus wrote: > > On Thu, Sep 17, 2020 at 03:18:56AM -0700, Badhri Jagan Sridharan wrote: > > Programs VBUS_SINK_DISCONNECT_THRESHOLD based on the power_role, > > voltage requested as sink, mode of operation. > > > > The programmed threshold is based on

Re: [GIT PULL] percpu fix for v5.9-rc6

2020-09-18 Thread Arvind Sankar
On Fri, Sep 18, 2020 at 06:28:30PM -0700, Linus Torvalds wrote: > On Fri, Sep 18, 2020 at 3:40 PM Arvind Sankar wrote: > > > > Ouch, offsetof() and sizeof() will give different results in the > > presence of alignment padding. > > Indeed. But from an allocation standpoint, the offsetof()+size is

[PATCH -next v2] mips: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. arch/mips/cavium-octeon/oct_ilm.c | 16 +++- arch/mips/kernel/segment.c| 14 ++

[PATCH -next v2] sh: mm: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. arch/sh/mm/asids-debugfs.c | 15 ++- arch/sh/mm/cache-debugfs.c | 15 ++- arch/sh/mm/pmb.c

[PATCH -next v2] usb: gadget: lpc32xx_udc: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/usb/gadget/udc/lpc32xx_udc.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git

[PATCH -next v2] x86/xen: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. arch/x86/xen/p2m.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/arch/x86/xen/p2m.c

[PATCH -next v2] scsi: qla2xxx: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/scsi/qla2xxx/qla_dfs.c | 68 -- 1 file changed, 8 insertions(+), 60 deletions(-)

[PATCH -next v2] soc: ti: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/soc/ti/knav_dma.c| 16 +++- drivers/soc/ti/knav_qmss_queue.c | 14 ++ 2 files

[PATCH -next v2] drivers: visorbus: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/visorbus/visorbus_main.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git

[PATCH -next v2] nbd: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/block/nbd.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git

[PATCH -next v2] arm: dump: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. arch/arm/mm/ptdump_debugfs.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git

[PATCH -next v2] bus: mvebu-mbus: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/bus/mvebu-mbus.c | 24 ++-- 1 file changed, 2 insertions(+), 22 deletions(-) diff --git

[PATCH -next v2] block: aoe: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/block/aoe/aoeblk.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git

[PATCH -next v2] drm/msm/dpu: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/gpu/drm/msm/disp/dpu1/dpu_core_irq.c | 15 +- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 29

[PATCH -next v2] scsi: snic: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/scsi/snic/snic_debugfs.c | 20 +--- 1 file changed, 1 insertion(+), 19 deletions(-) diff --git

[PATCH -next v2] sh: intc: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/sh/intc/virq-debugfs.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git

[PATCH -next v2] c6x: pll: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. arch/c6x/platforms/pll.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git

[PATCH -next v2] pktcdvd: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/block/pktcdvd.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) diff --git

Re: [PATCH -next] mt7601u: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread miaoqinglang
在 2020/7/16 23:20, Jakub Kicinski 写道: On Thu, 16 Jul 2020 16:57:49 +0800 Qinglang Miao wrote: Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao Acked-by: Jakub Kicinski Hi Jakub, I noticed that this patch has been acked by you and not patched into

[PATCH -next v2] mt7601u: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- .../net/wireless/mediatek/mt7601u/debugfs.c | 34 --- 1 file changed, 6 insertions(+), 28 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt7601u/debugfs.c

Re: [PATCH -next] tty: hvc: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n

2020-09-18 Thread Yang Yingliang
On 2020/9/18 19:17, Greg KH wrote: On Fri, Sep 18, 2020 at 05:20:30PM +0800, Yang Yingliang wrote: Fix the link error by selecting SERIAL_CORE_CONSOLE. aarch64-linux-gnu-ld: drivers/tty/hvc/hvc_dcc.o: in function `dcc_early_write': hvc_dcc.c:(.text+0x164): undefined reference to

Re: [GIT PULL] percpu fix for v5.9-rc6

2020-09-18 Thread Matthew Wilcox
On Fri, Sep 18, 2020 at 06:39:57PM -0400, Arvind Sankar wrote: > On Fri, Sep 18, 2020 at 02:18:20PM -0700, Linus Torvalds wrote: > > On Fri, Sep 18, 2020 at 2:00 PM Arvind Sankar wrote: > > > > > > You could just assert that offsetof(typeof(s),flex) == sizeof(s), no? > > > > No, because the

[PATCH net-next] net: natsemi: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/natsemi/ns83820.c: In function ns83820_get_link_ksettings: drivers/net/ethernet/natsemi/ns83820.c:1210:11: warning: variable ‘tanar’ set but not used [-Wunused-but-set-variable] `tanar` is never used, so remove it.

Re: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device

2020-09-18 Thread Zenghui Yu
On 2020/9/19 10:11, Alex Williamson wrote: On Sat, 19 Sep 2020 09:54:00 +0800 Zenghui Yu wrote: Hi Alex, On 2020/9/18 6:07, Alex Williamson wrote: On Thu, 17 Sep 2020 13:35:37 +0200 Cornelia Huck wrote: On Thu, 17 Sep 2020 11:31:28 +0800 Zenghui Yu wrote: It isn't clear what

[PATCH -next v2] scsi: hisi_sas: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/scsi/hisi_sas/hisi_sas_main.c | 137 ++ 1 file changed, 10 insertions(+), 127 deletions(-)

[PATCH net-next] net: microchip: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend: drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] `ret` is set but not used, so check it's

[PATCH net-next] net: microchip: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/microchip/lan743x_main.c: In function lan743x_pm_suspend: drivers/net/ethernet/microchip/lan743x_main.c:3041:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] `ret` is never used, so remove it.

Re: bus/mhi/core: Double lock in mhi_device_put() and dev_wake inc/dec

2020-09-18 Thread bbhatt
On 2020-09-17 16:16, Shuah Khan wrote: While looking at this file for an unrelated issue, I happen to notice there is a double locking on mhi_cntrl->pm_lock in the mhi_device_put() when it gets called from mhi_driver_remove() The other two calls from mhi_driver_probe() don't hold the pm_lock.

Re: [PATCH -next] scsi: hisi_sas: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread miaoqinglang
在 2020/7/16 20:39, luojiaxing 写道: Hi, Qinglang On 2020/7/16 16:47, Qinglang Miao wrote: From: Yongqiang Liu Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yongqiang Liu ---   drivers/scsi/hisi_sas/hisi_sas_main.c | 137 ++   1 file changed,

[PATCH net-next] net: micrel: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/micrel/ksz884x.c: In function rx_proc: drivers/net/ethernet/micrel/ksz884x.c:4981:6: warning: variable ‘rx_status’ set but not used [-Wunused-but-set-variable] drivers/net/ethernet/micrel/ksz884x.c: In function

[PATCH net-next] net: remove unnecessary NULL checking in napi_consume_skb()

2020-09-18 Thread Yunsheng Lin
When budget is non-zero, skb_unref() has already handled the NULL checking. When budget is zero, the dev_consume_skb_any() has handled NULL checking in __dev_kfree_skb_irq(), or dev_kfree_skb() which also ultimately call skb_unref(). So remove the unnecessary checking in napi_consume_skb().

[PATCH net-next] net: mventa: remove unused variable 'dummy' in mvneta_mib_counters_clear()

2020-09-18 Thread Zhang Changzhong
Fixes the following W=1 kernel build warning(s): drivers/net/ethernet/marvell/mvneta.c:754:6: warning: variable 'dummy' set but not used [-Wunused-but-set-variable] 754 | u32 dummy; | ^ This variable is not used in function mvneta_mib_counters_clear(), so remove it to avoid

Re: [PATCH] vt: fix some doc warnings in vt.c

2020-09-18 Thread Xiaofei Tan
Hi Jiri, On 2020/9/18 15:52, Jiri Slaby wrote: > On 18. 09. 20, 9:47, Xiaofei Tan wrote: >> Fix following warnings caused by mismatch bewteen function parameters >> and comments. >> drivers/tty/vt/vt.c:3994: warning: Function parameter or member 'vc' not >> described in 'con_debug_enter' >>

Re: [PATCH -next] tty: serial: imx: fix link error with CONFIG_SERIAL_CORE_CONSOLE=n

2020-09-18 Thread Yang Yingliang
Hi, On 2020/9/18 19:16, Greg KH wrote: On Fri, Sep 18, 2020 at 05:13:05PM +0800, Yang Yingliang wrote: Fix the link error by selecting SERIAL_CORE_CONSOLE. aarch64-linux-gnu-ld: drivers/tty/serial/imx_earlycon.o: in function `imx_uart_console_early_write': imx_earlycon.c:(.text+0x84):

Re: [PATCH net-next] net: hns3: remove unnecessary NULL checking in napi_consume_skb()

2020-09-18 Thread Yunsheng Lin
Please ignore this patch, the title is not right, sorry for the noise. On 2020/9/19 10:16, Yunsheng Lin wrote: > When budget is non-zero, skb_unref() has already handled the > NULL checking. > > When budget is zero, the dev_consume_skb_any() has handled NULL > checking in __dev_kfree_skb_irq(),

[PATCH net-next] net: hns3: remove unnecessary NULL checking in napi_consume_skb()

2020-09-18 Thread Yunsheng Lin
When budget is non-zero, skb_unref() has already handled the NULL checking. When budget is zero, the dev_consume_skb_any() has handled NULL checking in __dev_kfree_skb_irq(), or dev_kfree_skb() which also ultimately call skb_unref(). So remove the unnecessary checking in napi_consume_skb().

[PATCH -next v2] mfd: ab3100-core: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/mfd/ab3100-core.c | 15 ++- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git

[PATCH -next v2] mfd: ab3100-otp: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/mfd/ab3100-otp.c | 16 +++- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git

[PATCH -next v2] mfd: tps65010: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/mfd/tps65010.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git

Re: [PATCH -next] mfd: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread miaoqinglang
在 2020/7/16 21:46, Lee Jones 写道: On Thu, 16 Jul 2020, Qinglang Miao wrote: From: Yongqiang Liu Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yongqiang Liu --- drivers/mfd/ab3100-core.c | 15 ++- drivers/mfd/ab3100-otp.c | 16 +++-

Re: [PATCH -next] rsxx: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread miaoqinglang
在 2020/7/17 10:16, Jens Axboe 写道: On 7/16/20 7:37 PM, miaoqinglang wrote: 在 2020/7/16 23:45, Jens Axboe 写道: On 7/16/20 3:04 AM, Qinglang Miao wrote: From: Liu Shixin Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. None of these apply against the 5.9 block tree, looks like some

[PATCH -next v2] rsxx: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. drivers/block/rsxx/core.c | 31 --- 1 file changed, 4 insertions(+), 27 deletions(-) diff --git

[PATCH -next v2] mt76: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-18 Thread Qinglang Miao
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- .../wireless/mediatek/mt76/mt7603/debugfs.c | 18 +++--- .../wireless/mediatek/mt76/mt7615/debugfs.c | 17 ++ .../wireless/mediatek/mt76/mt76x02_debugfs.c | 34 --- 3 files

Re: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device

2020-09-18 Thread Alex Williamson
On Sat, 19 Sep 2020 09:54:00 +0800 Zenghui Yu wrote: > Hi Alex, > > On 2020/9/18 6:07, Alex Williamson wrote: > > On Thu, 17 Sep 2020 13:35:37 +0200 > > Cornelia Huck wrote: > > > >> On Thu, 17 Sep 2020 11:31:28 +0800 > >> Zenghui Yu wrote: > >> > >>> It isn't clear what purpose the

[PATCH v2] brcmfmac: check return value of driver_for_each_device()

2020-09-18 Thread Zhang Changzhong
Fixes the following W=1 kernel build warning(s): drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:1576:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable] 1576 | int ret; | ^~~ driver_for_each_device() has been declared with __must_check, so the return

[PATCH net-next] net: marvell: Remove set but not used variable

2020-09-18 Thread Zheng Yongjun
Fixes gcc '-Wunused-but-set-variable' warning: drivers/net/ethernet/marvell/pxa168_eth.c: In function pxa168_eth_change_mtu: drivers/net/ethernet/marvell/pxa168_eth.c:1190:6: warning: variable ‘retval’ set but not used [-Wunused-but-set-variable] `retval` is never used, so remove it.

[PATCH v1 01/10] bus: mhi: core: Use appropriate names for firmware load functions

2020-09-18 Thread Bhaumik Bhatt
mhi_fw_load_sbl() function is currently used to transfer SBL or EDL images over BHI (Boot Host Interface). Same goes with mhi_fw_load_amss() which uses BHIe. However, the contents of these functions do not indicate support for a specific set of images. Since these can be used for any image

[PATCH v1 07/10] bus: mhi: core: Move to SYS_ERROR regardless of RDDM capability

2020-09-18 Thread Bhaumik Bhatt
In some cases, the entry of device to RDDM execution environment can occur after a significant amount of time has elapsed after the SYS_ERROR state change event has arrived. This can result in scenarios where users of the MHI bus are unaware of the error state of the device. Hence, moving the MHI

[PATCH v1 06/10] bus: mhi: core: Improve shutdown handling after link down detection

2020-09-18 Thread Bhaumik Bhatt
If MHI were to attempt a device shutdown following an assumption that the device is inaccessible, the host currently moves to a state where device register accesses are allowed when they should not be. This would end up allowing accesses to the device register space when the link is inaccessible

[PATCH v1 08/10] bus: mhi: core: Move to an error state on any firmware load failure

2020-09-18 Thread Bhaumik Bhatt
Move MHI to a firmware download error state for a failure to find the firmware files or to load SBL or EBL image using BHI/BHIe. This helps detect an error state sooner and shortens the wait for a synchronous power up timeout. Signed-off-by: Bhaumik Bhatt --- drivers/bus/mhi/core/boot.c | 43

[PATCH] Documentation: filesystems: mount_api: fix headings

2020-09-18 Thread Randy Dunlap
From: Randy Dunlap Fix capitalization in two headings, correct one verb, and demote one heading to a section heading. Fixes: 791a17ee1973 ("docs: filesystems: convert mount_api.txt to ReST") Signed-off-by: Randy Dunlap Cc: Mauro Carvalho Chehab --- Documentation/filesystems/mount_api.rst |

[PATCH v1 03/10] bus: mhi: core: Skip device wake in error or shutdown states

2020-09-18 Thread Bhaumik Bhatt
MHI clients can request a device wake even if the device may be in an error state or undergoing shutdown. To prevent unnecessary device wake processing, check for the device state and bail out early so that the clients are made aware of the device state sooner. Signed-off-by: Bhaumik Bhatt ---

[PATCH v1 02/10] bus: mhi: core: Move to using high priority workqueue

2020-09-18 Thread Bhaumik Bhatt
MHI work is currently scheduled on the global/system workqueue and can encounter delays on a stressed system. To avoid those unforeseen delays which can hamper bootup or shutdown times, use a dedicated high priority workqueue instead of the global/system workqueue. Signed-off-by: Bhaumik Bhatt

[PATCH v1 04/10] bus: mhi: core: Use the IRQF_ONESHOT flag for the BHI interrupt line

2020-09-18 Thread Bhaumik Bhatt
Remove the IRQF_SHARED flag as it is not needed for the BHI interrupt and replace it with IRQF_ONESHOT so that host can be sure that the next BHI hard interrupt is triggered only when the threaded interrupt handler has returned. This is to avoid any race conditions we may run into if BHI

[PATCH v1 09/10] bus: mhi: core: Move to an error state on mission mode failure

2020-09-18 Thread Bhaumik Bhatt
If the host receives a mission mode event and by the time it can get to processing it, the register accesses fail implying a connectivity error, MHI should move to an error state. This helps avoid longer wait times from a synchronous power up perspective and accurately reflects the MHI execution

[PATCH v1 00/10] Bug fixes and improvements for MHI power operations

2020-09-18 Thread Bhaumik Bhatt
Bug fixes and improvements for MHI powerup and shutdown handling. Firmware load function names are updated to accurately reflect their purpose. Closed certain design gaps where the host (MHI bus) would allow clients to operate after a power down or error detection. Move to an error state sooner

  1   2   3   4   5   6   7   8   9   10   >