Re: [DISCUSSION PATCH 00/41] random: possible ways towards NIST SP800-90B compliance

2020-10-06 Thread Stephan Mueller
Am Mittwoch, 7. Oktober 2020, 06:24:09 CEST schrieb Eric Biggers: Hi Eric, > > Note that having multiple RNG implementations would cause fragmentation, > more maintenance burden, etc. So IMO, that should be a last resort. > Instead we should try to find an implementation that works for

Re: [PATCH] misc: Kconfig: add a new dependency for HISI_HIKEY_USB

2020-10-06 Thread Randy Dunlap
On 10/6/20 10:09 PM, Mauro Carvalho Chehab wrote: > As warned by Randy: > > on x86_64: > CONFIG_USB_ROLE_SWITCH=m > and HISI_HIKEY_USB=y. > > ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_remove': > hisi_hikey_usb.c:(.text+0x61): undefined reference

Re: [PATCH] arm/arm64: xen: Fix to convert percpu address to gfn correctly

2020-10-06 Thread Masami Hiramatsu
On Tue, 6 Oct 2020 10:56:52 -0700 (PDT) Stefano Stabellini wrote: > On Tue, 6 Oct 2020, Masami Hiramatsu wrote: > > On Mon, 5 Oct 2020 18:13:22 -0700 (PDT) > > Stefano Stabellini wrote: > > > > > On Mon, 5 Oct 2020, Julien Grall wrote: > > > > Hi Masami, > > > > > > > > On 05/10/2020 14:39,

Re: [PATCH 1/7] 9P: Cast to loff_t before multiplying

2020-10-06 Thread Christoph Hellwig
On Sun, Oct 04, 2020 at 07:04:22PM +0100, Matthew Wilcox (Oracle) wrote: > On 32-bit systems, this multiplication will overflow for files larger > than 4GB. > > Cc: sta...@vger.kernel.org > Fixes: fb89b45cdfdc ("9P: introduction of a new cache=mmap model.") > Signed-off-by: Matthew Wilcox

RE: [PATCH 0/3] Enable USB host for AST2600

2020-10-06 Thread Ryan Chen
Hello Joel, Have you take time review this patches ? Ryan Chen Tel : 886-3-5751185 ext:8857 > -Original Message- > From: Ryan Chen > Sent: Wednesday, September 30, 2020 12:08 PM > To: Joel Stanley ; Andrew Jeffery ; > linux-arm-ker...@lists.infradead.org;

Re: [PATCH v2] mtd: spi-nor: Fix address width on flash chips > 16MB

2020-10-06 Thread Cédric Le Goater
On 10/7/20 3:51 AM, Joel Stanley wrote: > On Sun, 4 Oct 2020 at 21:33, Bert Vermeulen wrote: >> >> If a flash chip has more than 16MB capacity but its BFPT reports >> BFPT_DWORD1_ADDRESS_BYTES_3_OR_4, the spi-nor framework defaults to 3. >> >> The check in spi_nor_set_addr_width() doesn't catch

Re: [PATCH 01/18] dmaengine: of-dma: Add support for optional router configuration callback

2020-10-06 Thread Vinod Koul
Hi Peter, On 30-09-20, 12:13, Peter Ujfalusi wrote: > Additional configuration for the DMA event router might be needed for a > channel which can not be done during device_alloc_chan_resources callback > since the router information is not yet present for the drivers. > > If there is a need for

Re: [PATCH net-next 05/16] devlink: Add remote reload stats

2020-10-06 Thread Moshe Shemesh
On 10/5/2020 10:12 PM, Jacob Keller wrote: On 10/4/2020 12:09 AM, Moshe Shemesh wrote: On 10/3/2020 12:05 PM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:08PM CEST, mo...@mellanox.com wrote: Add remote reload stats to hold the history of actions performed due devlink reload commands

Re: [PATCH -v2 15/17] sched: Fix migrate_disable() vs rt/dl balancing

2020-10-06 Thread Juri Lelli
On 06/10/20 16:48, Peter Zijlstra wrote: > On Tue, Oct 06, 2020 at 04:37:04PM +0200, Juri Lelli wrote: > > On 06/10/20 15:48, Peter Zijlstra wrote: > > > On Tue, Oct 06, 2020 at 12:20:43PM +0100, Valentin Schneider wrote: > > > > > > > > On 05/10/20 15:57, Peter Zijlstra wrote: > > > > > In order

[PATCH v2] ALSA: hda/realtek: Enable audio jacks of ASUS D700SA with ALC887

2020-10-06 Thread Jian-Hong Pan
The ASUS D700SA desktop's audio (1043:2390) with ALC887 cannot detect the headset microphone and another headphone jack until ALC887_FIXUP_ASUS_HMIC and ALC887_FIXUP_ASUS_AUDIO quirks are applied. The NID 0x15 maps as the headset microphone and NID 0x19 maps as another headphone jack. Also need

Re: [PATCH v2] cpufreq: stats: Add memory barrier to store_reset()

2020-10-06 Thread Viresh Kumar
On 06-10-20, 21:43, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > There is nothing to prevent the CPU or the compiler from reordering > the writes to stats->reset_time and stats->reset_pending in > store_reset(), in which case the readers of stats->reset_time may see > a stale value.

Re: [PATCH 1/4] drivers core: Introduce CPU type sysfs interface

2020-10-06 Thread Greg Kroah-Hartman
On Tue, Oct 06, 2020 at 08:14:47PM -0700, Ricardo Neri wrote: > On Tue, Oct 06, 2020 at 09:37:44AM +0200, Greg Kroah-Hartman wrote: > > On Mon, Oct 05, 2020 at 05:57:36PM -0700, Ricardo Neri wrote: > > > On Sat, Oct 03, 2020 at 10:53:45AM +0200, Greg Kroah-Hartman wrote: > > > > On Fri, Oct 02,

Re: [PATCH 1/2] cpufreq,arm,arm64: restructure definitions of arch_set_freq_scale()

2020-10-06 Thread Viresh Kumar
On 24-09-20, 13:30, Ionela Voinescu wrote: > Compared to other arch_* functions, arch_set_freq_scale() has an atypical > weak definition that can be replaced by a strong architecture specific > implementation. > > The more typical support for architectural functions involves defining > an empty

Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360

2020-10-06 Thread kernel test robot
Hi Gene, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on pavel-linux-leds/for-next] [also build test WARNING on v5.9-rc8 next-20201006] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [PATCH] cpufreq: schedutil: Simplify sugov_fast_switch()

2020-10-06 Thread Viresh Kumar
On 06-10-20, 14:01, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Drop a redundant local variable definition from sugov_fast_switch() > and rearrange the code in there to avoid the redundant logical > negation. > > Signed-off-by: Rafael J. Wysocki > --- > > The code reads a bit

[PATCH] misc: Kconfig: add a new dependency for HISI_HIKEY_USB

2020-10-06 Thread Mauro Carvalho Chehab
As warned by Randy: on x86_64: CONFIG_USB_ROLE_SWITCH=m and HISI_HIKEY_USB=y. ld: drivers/misc/hisi_hikey_usb.o: in function `hisi_hikey_usb_remove': hisi_hikey_usb.c:(.text+0x61): undefined reference to `usb_role_switch_unregister' ld:

[PATCH v3 0/2] PM / devfreq: Add governor feature and attribute flag

2020-10-06 Thread Chanwoo Choi
Each devfreq governor can have the different sysfs attributes and features. In order to provide the only available sysfs attribute to user-space, add governor attribute flag with DEVFREQ_GOV_ATTR_[attribute name] defintion. Also, each governor is able to have the specific flag in order to support

[PATCH v3 2/2] PM / devfreq: Add governor attribute flag for specifc sysfs nodes

2020-10-06 Thread Chanwoo Choi
DEVFREQ supports the default governors like performance, simple_ondemand and also allows the devfreq driver to add their own governor like tegra30-devfreq.c according to their requirement. In result, some sysfs attributes are useful or not useful. Prior to that the user can access all sysfs

[PATCH v3 1/2] PM / devfreq: Add governor feature flag

2020-10-06 Thread Chanwoo Choi
The devfreq governor is able to have the specific flag as follows in order to implement the specific feature. For example, devfreq allows user to change the governors on runtime via sysfs interface. But, if devfreq device uses 'passive' governor, don't allow user to change the governor. For this

Re: linux-next: manual merge of the akpm-current tree with the risc-v tree

2020-10-06 Thread Atish Patra
On Tue, 2020-10-06 at 21:32 -0700, Palmer Dabbelt wrote: > On Tue, 06 Oct 2020 03:39:06 PDT (-0700), Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the akpm-current tree got a conflict > > in: > > > > arch/riscv/mm/init.c > > > > between commit: > > > >

[PATCH v2 2/2] scsi: arcmsr: use round_up() instead of logical operation

2020-10-06 Thread ching Huang
From: ching Huang Use round_up() instead of logical operation. Reported-by: Martin K. Petersen Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index 55d85c9..1e358d9 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++

Re: [PATCH v2] Bluetooth: Move force_bredr_smp debugfs into hci_debugfs_create_bredr

2020-10-06 Thread Claire Chang
Hi, This patch is to fix the kernel error [ 46.271811] debugfs: File 'force_bredr_smp' in directory 'hci0' already present! When powering off and on the bluetooth, the smp_register will try to create the force_bredr_smp entry again. Move the creation to hci_debugfs_create_bredr so the

[PATCH v2 1/2] scsi: arcmsr: fix warning: right shift count >= width of type

2020-10-06 Thread ching Huang
From: ching Huang Fix warning: right shift count >= width of type. Reported-by: kernel test robot Signed-off-by: ching Huang --- diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c index be6fb72..55d85c9 100644 --- a/drivers/scsi/arcmsr/arcmsr_hba.c +++

Re: [PATCH v39 21/24] x86/vdso: Implement a vDSO for Intel SGX enclave call

2020-10-06 Thread Sean Christopherson
On Wed, Oct 07, 2020 at 06:14:02AM +0300, Jarkko Sakkinen wrote: > On Tue, Oct 06, 2020 at 06:17:38PM -0700, Sean Christopherson wrote: > > On Wed, Oct 07, 2020 at 03:22:36AM +0300, Jarkko Sakkinen wrote: > > > > And then a third flavor comes along, e.g. Jethro's request interrupt > > > > case, >

[PATCH v2 0/2] scsi: arcmsr: fix warning: right shift count >= width of type

2020-10-06 Thread ching Huang
This patch is against to mkp's 5.10/scsi-staging. 1. fix warning: right shift count >= width of type. 2. use round_up() instead of logical operation. ---

Re: linux-next: manual merge of the akpm-current tree with the risc-v tree

2020-10-06 Thread Palmer Dabbelt
On Tue, 06 Oct 2020 03:39:06 PDT (-0700), Stephen Rothwell wrote: Hi all, Today's linux-next merge of the akpm-current tree got a conflict in: arch/riscv/mm/init.c between commit: c29c38fa2a8b ("RISC-V: Remove any memblock representing unusable memory area") from the risc-v tree and

Re: [PATCH 2/2] PCI: vmd: Enable ASPM for mobile platforms

2020-10-06 Thread Kai-Heng Feng
> On Oct 6, 2020, at 03:19, Bjorn Helgaas wrote: > > [+cc Ian, who's also working on an ASPM issue] > > On Tue, Oct 06, 2020 at 02:40:32AM +0800, Kai-Heng Feng wrote: >>> On Oct 3, 2020, at 06:18, Bjorn Helgaas wrote: >>> On Wed, Sep 30, 2020 at 04:24:54PM +0800, Kai-Heng Feng wrote:

Re: [DISCUSSION PATCH 00/41] random: possible ways towards NIST SP800-90B compliance

2020-10-06 Thread Eric Biggers
On Fri, Oct 02, 2020 at 02:38:36PM +0200, Torsten Duwe wrote: > Almost two weeks passed and these are the "relevant" replies: > > Jason personally does not like FIPS, and is afraid of > "subpar crypto". Albeit this patch set strictly isn't about > crypto at all; the crypto subsystem is in the

Re: [PATCH v7 0/3] PCI: uniphier: Add PME/AER support for UniPhier PCIe host controller

2020-10-06 Thread Kunihiko Hayashi
Hi, Gentle ping. Are there any comments about this series? Thank you, On 2020/09/11 18:33, Kunihiko Hayashi wrote: The original subject up to v6 is "PCI: uniphier: Add features for UniPhier PCIe host controller". This adds a new function called by MSI handler in DesignWare PCIe framework,

Re: [PATCH] random: fix the RNDRESEEDCRNG ioctl

2020-10-06 Thread Jann Horn
On Wed, Sep 16, 2020 at 6:19 AM Eric Biggers wrote: > The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which > doesn't make sense. Reseed it from the input_pool instead. Good catch. (And its purpose is to ensure that entropy from random_write() is plumbed all the way through such

Re: [PATCH] riscv: Fixup bootup failure with HARDENED_USERCOPY

2020-10-06 Thread Palmer Dabbelt
On Tue, 06 Oct 2020 09:49:33 PDT (-0700), guo...@kernel.org wrote: From: Guo Ren As Aurelien has reported: [3.484586] AppArmor: AppArmor sha1 policy hashing enabled [4.749835] Freeing unused kernel memory: 492K [4.752017] Run /init as init process [4.753571] usercopy: Kernel

[PATCH] usb: cdns3: Add static to cdns3_gadget_exit function

2020-10-06 Thread Pawel Laszczak
Function cdns3_gadget_exit is used only in gadget.c file. This patch removes declaration and definition of this function from gadget-export.h file and makes it static. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/gadget-export.h | 3 --- drivers/usb/cdns3/gadget.c| 2 +- 2 files

[PATCH] net: wireless: nl80211: fix out-of-bounds access in nl80211_del_key()

2020-10-06 Thread Anant Thazhemadam
In nl80211_parse_key(), key.idx is first initialized as -1. If this value of key.idx remains unmodified and gets returned, and nl80211_key_allowed() also returns 0, then rdev_del_key() gets called with key.idx = -1. This causes an out-of-bounds array access. Handle this issue by checking if the

Re: [PATCH] random: initialize ChaCha20 constants with correct endianness

2020-10-06 Thread Eric Biggers
On Fri, Sep 18, 2020 at 02:57:05PM -0700, Eric Biggers wrote: > On Fri, Sep 18, 2020 at 04:42:07PM -0400, Theodore Y. Ts'o wrote: Ted, any further feedback on this? Are you planning to apply this patch? - Eric

[PATCH 3/4] platform/x86: intel_pmc_core: fix: Replace dev_dbg macro with dev_info()

2020-10-06 Thread David E. Box
From: Gayatri Kammela dev_dbg macro is used to dump the debug registers in resume from an S0ix failure. However, when CONFIG_DYNAMIC_DEBUG is not set, the user may not be able to find the debug dump on an S0ix failure which defeats the purpose. The output of these messages is already controlled

Re: [PATCH] random: remove dead code left over from blocking pool

2020-10-06 Thread Eric Biggers
On Tue, Sep 15, 2020 at 09:36:52PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Remove some dead code that was left over following commit 90ea1c6436d2 > ("random: remove the blocking pool"). > > Signed-off-by: Eric Biggers Ping?

[PATCH 2/4] platform/x86: intel_pmc_core: Add Intel RocketLake (RKL) support

2020-10-06 Thread David E. Box
From: Gayatri Kammela Add RocketLake to the list of the platforms that intel_pmc_core driver supports for pmc_core device. RocketLake reuses all the TigerLake PCH IPs. Cc: Srinivas Pandruvada Cc: Andy Shevchenko Cc: David E. Box Cc: Tony Luck Cc: Rui Zhang Signed-off-by: Gayatri Kammela

[PATCH 1/4] platform/x86: intel_pmc_core: Clean up: Remove the duplicate comments and reorganize

2020-10-06 Thread David E. Box
From: Gayatri Kammela Some of the Cannon Lake PCH IPs are reused by most of the platforms such as Ice Lake, Tiger Lake, Elkhart Lake, Jasper Lake and can be reused by future platforms as well. The same was mentioned via comments not once but twice in an array of bit map structs for Cannon Lake

Re: [PATCH] random: fix the RNDRESEEDCRNG ioctl

2020-10-06 Thread Eric Biggers
On Tue, Sep 15, 2020 at 09:19:08PM -0700, Eric Biggers wrote: > From: Eric Biggers > > The RNDRESEEDCRNG ioctl reseeds the primary_crng from itself, which > doesn't make sense. Reseed it from the input_pool instead. > > Fixes: d848e5f8e1eb ("random: add new ioctl RNDRESEEDCRNG") > Cc:

[PATCH 0/4] pmc_core: Add RocketLake and other changes

2020-10-06 Thread David E. Box
Add RocketLake platform support and other driver maintainance. Gayatri Kammela (4): platform/x86: intel_pmc_core: Clean up: Remove the duplicate comments and reorganize platform/x86: intel_pmc_core: Add Intel RocketLake (RKL) support platform/x86: intel_pmc_core: fix: Replace dev_dbg

Re: [PATCH] scsi: qedf: remove redundant assignment to variable 'rc'

2020-10-06 Thread Martin K. Petersen
On Thu, 17 Sep 2020 10:19:06 +0800, Jing Xiangfeng wrote: > This assignment is meaningless, so remove it. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: qedf: Remove redundant assignment to variable 'rc' https://git.kernel.org/mkp/scsi/c/da7d5d72ae83 -- Martin K. Petersen Oracle

[PATCH 4/4] MAINTAINERS: Update maintainers for pmc_core driver

2020-10-06 Thread David E. Box
From: Gayatri Kammela Update MAINTAINERS file for pmc_core driver to reflect the current maintainers. Cc: Vishwanath Somayaji Cc: Andy Shevchenko Cc: Srinivas Pandruvada Cc: David E. Box Acked-by: David E. Box Acked-by: Vishwanath Somayaji Signed-off-by: Gayatri Kammela Signed-off-by:

Re: [PATCH 0/7] hisi_sas: Add runtime PM support for v3 hw

2020-10-06 Thread Martin K. Petersen
On Fri, 2 Oct 2020 22:30:31 +0800, John Garry wrote: > This series adds runtime PM support for v3 hw. Consists of: > - Switch to new PM suspend and resume framework > - Add links to devices to ensure host cannot be suspended while devices > are not > - Filter out phy events during suspend to

Re: [PATCH -next] scsi: snic: convert to use DEFINE_SEQ_ATTRIBUTE macro

2020-10-06 Thread Martin K. Petersen
On Wed, 16 Sep 2020 10:50:30 +0800, Liu Shixin wrote: > Use DEFINE_SEQ_ATTRIBUTE macro to simplify the code. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: snic: Convert to use DEFINE_SEQ_ATTRIBUTE macro https://git.kernel.org/mkp/scsi/c/936dc95d09d8 -- Martin K. Petersen Oracle

Re: [PATCH ] scsi: page warning: 'page' may be used uninitialized

2020-10-06 Thread Martin K. Petersen
On Wed, 23 Sep 2020 17:19:20 -0700, john.p.donne...@oracle.com wrote: > corrects: drivers/target/target_core_user.c:688:6: warning: 'page' may be used > uninitialized > > Fixes: 3c58f737231e ("scsi: target: tcmu: Optimize use of > flush_dcache_page") Applied to 5.10/scsi-queue, thanks! [1/1]

Re: [PATCH] scsi: snic: Remove unnecessary condition to simplify the code

2020-10-06 Thread Martin K. Petersen
On Fri, 25 Sep 2020 14:07:54 +0800, Jing Xiangfeng wrote: > ret is always zero or an error in this code path. So the assignment to > ret is redundant, and the code jumping to a label is unneed. > Let's remove them to simplify the code. No functional changes. Applied to 5.10/scsi-queue, thanks!

Re: [PATCH] scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()

2020-10-06 Thread Martin K. Petersen
On Mon, 28 Sep 2020 12:13:00 +0300, Dan Carpenter wrote: > The be_fill_queue() function can only fail when "eq_vaddress" is NULL > and since it's non-NULL here that means the function call can't fail. > But imagine if it could, then in that situation we would want to store > the "paddr" so that

Re: [PATCH -next] scsi: use module_platform_driver to simplify the code

2020-10-06 Thread Martin K. Petersen
On Mon, 14 Sep 2020 14:54:03 +0800, Liu Shixin wrote: > module_platform_driver() makes the code simpler by eliminating > boilerplate code. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: sun_esp: Use module_platform_driver to simplify the code

Re: [PATCH] scsi: mvumi: Fix error return in mvumi_io_attach()

2020-10-06 Thread Martin K. Petersen
On Thu, 10 Sep 2020 20:38:48 +0800, Jing Xiangfeng wrote: > Fix to return error code PTR_ERR() from the error handling case instead > of 0. Applied to 5.10/scsi-queue, thanks! [1/1] scsi: mvumi: Fix error return in mvumi_io_attach() https://git.kernel.org/mkp/scsi/c/055f15ab2cb4 --

[PATCH v4] bluetooth: hci_h5: fix memory leak in h5_close

2020-10-06 Thread Anant Thazhemadam
If h5_close is called when !hu->serdev, h5 is directly freed. However, h5->rx_skb is not freed, which causes a memory leak. Freeing h5->rx_skb fixes this memory leak. In case hu->serdev exists, h5->rx_skb is then set to NULL, since we do not want to risk a potential NULL pointer dereference.

Re: [PATCH v2] scsi: ufs: fix missing brace warning for old compilers

2020-10-06 Thread Martin K. Petersen
On Fri, 2 Oct 2020 14:35:38 +0800, Pujin Shi wrote: > For older versions of gcc, the array = {0}; will cause warnings: > > drivers/scsi/ufs/ufshcd-crypto.c: In function 'ufshcd_crypto_keyslot_program': > drivers/scsi/ufs/ufshcd-crypto.c:62:8: warning: missing braces around > initializer

RE: [PATCH v3 2/2] firmware: Keem Bay: Add support for Arm Trusted Firmware Service call

2020-10-06 Thread Zulkifli, Muhammad Husaini
Hi Sudeep and Michal, I would like to receive some feedback on this patch before send out another version to fix the autobot compiler warning. Really appreciated it. Thanks >-Original Message- >From: Zulkifli, Muhammad Husaini >Sent: Tuesday, October 6, 2020 11:56 PM >To: Hunter,

[PATCH 2/2] usb: cdns3: Variable ‘length’ set but not used

2020-10-06 Thread Pawel Laszczak
Patch removes not used variable 'length' from cdns3_wa2_descmiss_copy_data function. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/gadget.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c index 6e7b70a2e352..692acf7b9b14 100644

RE: [PATCH v2 1/3] dt-bindings: fu540: prci: convert PRCI bindings to json-schema

2020-10-06 Thread Sagar Kadam
> -Original Message- > From: Rob Herring > Sent: Wednesday, October 7, 2020 12:13 AM > To: Sagar Kadam > Cc: a...@eecs.berkeley.edu; linux-ri...@lists.infradead.org; > t...@linutronix.de; linux-...@vger.kernel.org; pal...@dabbelt.com; > ja...@lakedaemon.net; Yash Shah ; >

[PATCH 1/2] usb: cdns3: Rids of duplicate error message

2020-10-06 Thread Pawel Laszczak
On failure, the platform_get_irq_byname prints an error message so, patch removes error message related to this function from core.c file. A change was suggested during reviewing CDNSP driver by Chunfeng Yun. Signed-off-by: Pawel Laszczak --- drivers/usb/cdns3/core.c | 7 +-- 1 file

Re: [PATCH 1/5] interconnect: qcom: Consolidate interconnect RPM support

2020-10-06 Thread Jun Nie
> > obj-$(CONFIG_INTERCONNECT_QCOM_SMD_RPM) += icc-smd-rpm.o > > +obj-$(CONFIG_INTERCONNECT_QCOM_SMD_RPM) += icc-smd-rpm.o > > Duplicate ? > > Thanks for msm8939 work, please Cc: me on any related patch :-) > > OK, will CC you on next version. This issue should be a typo in vim. Thanks for

Re: [PATCH -next] powerpc/papr_scm: Fix warnings about undeclared variable

2020-10-06 Thread Michael Ellerman
On Fri, 18 Sep 2020 08:59:51 +, Wang Wensheng wrote: > Build the kernel with 'make C=2': > arch/powerpc/platforms/pseries/papr_scm.c:825:1: warning: symbol > 'dev_attr_perf_stats' was not declared. Should it be static? Applied to powerpc/next. [1/1] powerpc/papr_scm: Fix warnings about

Re: [PATCH v2 00/11] Optimization to improve CPU online/offline on Powerpc

2020-10-06 Thread Michael Ellerman
On Mon, 21 Sep 2020 15:26:42 +0530, Srikar Dronamraju wrote: > Here are some optimizations and fixes to make CPU online/offline > faster and hence result in faster bootup. > > Its based on top of my v5 coregroup support patchset. >

Re: [PATCH 00/14] Small step toward KSM for file back page.

2020-10-06 Thread Matthew Wilcox
On Tue, Oct 06, 2020 at 09:05:49PM -0400, jgli...@redhat.com wrote: > The present patchset just add mapping argument to the various vfs call- > backs. It does not make use of that new parameter to avoid regression. > I am posting this whole things as small contain patchset as it is rather > big

Re: [PATCH v3] selftests/bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

2020-10-06 Thread patchwork-bot+bpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Tue, 6 Oct 2020 19:28:57 -0700 you wrote: > Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched > the order of check_subprogs() and resolve_pseudo_ldimm() in > the verifier. Now an empty prog expects to see the

[PATCH v3 4/4] io_uring: Fix double list add in io_queue_async_work()

2020-10-06 Thread Muchun Song
If we queue work in io_poll_wake(), it will leads to list double add. So we should add the list when the callback func is the io_sq_wq_submit_work. The following oops was seen: list_add double add: new=9ca6a8f1b0e0, prev=9ca62001cee8, next=9ca6a8f1b0e0. [ cut

[PATCH v3 3/4] io_uring: Fix remove irrelevant req from the task_list

2020-10-06 Thread Muchun Song
If the process 0 has been initialized io_uring is complete, and then fork process 1. If process 1 exits and it leads to delete all reqs from the task_list. If we kill process 0. We will not send SIGINT signal to the kworker. So we can not remove the req from the task_list. The

[PATCH v3 1/4] io_uring: Fix resource leaking when kill the process

2020-10-06 Thread Muchun Song
From: Yinyin Zhu The commit 1c4404efcf2c0> ("") doesn't solve the resource leak problem totally! When kworker is doing a io task for the io_uring, The process which submitted the io task has received a SIGKILL signal from the user. Then the io_cancel_async_work function could have sent a

[PATCH v3 0/4] io_uring: Fix async workqueue is not canceled on some corner case

2020-10-06 Thread Muchun Song
We should make sure that async workqueue is canceled on exit, but on some corner case, we found that the async workqueue is not canceled on exit in the linux-5.4. So we started an in-depth investigation. Fortunately, we finally found the problem. The commit: 1c4404efcf2c ("io_uring: make sure

[PATCH v3 2/4] io_uring: Fix missing smp_mb() in io_cancel_async_work()

2020-10-06 Thread Muchun Song
The store to req->flags and load req->work_task should not be reordering in io_cancel_async_work(). We should make sure that either we store REQ_F_CANCE flag to req->flags or we see the req->work_task setted in io_sq_wq_submit_work(). Fixes: 1c4404efcf2c ("io_uring: make sure async workqueue is

Re: [PATCH v39 21/24] x86/vdso: Implement a vDSO for Intel SGX enclave call

2020-10-06 Thread Jarkko Sakkinen
On Tue, Oct 06, 2020 at 06:17:38PM -0700, Sean Christopherson wrote: > On Wed, Oct 07, 2020 at 03:22:36AM +0300, Jarkko Sakkinen wrote: > > On Tue, Oct 06, 2020 at 04:21:29PM -0700, Sean Christopherson wrote: > > > On Tue, Oct 06, 2020 at 08:28:19PM +0300, Jarkko Sakkinen wrote: > > > > On Tue,

Re: [PATCH 1/4] drivers core: Introduce CPU type sysfs interface

2020-10-06 Thread Ricardo Neri
On Tue, Oct 06, 2020 at 09:37:44AM +0200, Greg Kroah-Hartman wrote: > On Mon, Oct 05, 2020 at 05:57:36PM -0700, Ricardo Neri wrote: > > On Sat, Oct 03, 2020 at 10:53:45AM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Oct 02, 2020 at 06:17:42PM -0700, Ricardo Neri wrote: > > > > Hybrid CPU

RE: [PATCH] usb: cdns3: platform_get_irq_byname_optional instead platform_get_irq_byname

2020-10-06 Thread Pawel Laszczak
Felipe, Please ignore this patch. I will create the new one. It's no sense to send the v2 because I have to change the patch name, Description and contents. Regards, Pawel, >Roger, > >>Pawel, >> >>On 05/10/2020 08:54, Pawel Laszczak wrote: >>> Roger, Pawel, On 02/10/2020

Re: [PATCH -next] scsi: dc395x: use module_pci_driver to simplify the code

2020-10-06 Thread Martin K. Petersen
Liu, > Use the module_pci_driver() macro to make the code simpler by > eliminating module_init and module_exit calls. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

RE: irq_build_affinity_masks() allocates improper affinity if num_possible_cpus() > num_present_cpus()?

2020-10-06 Thread Dexuan Cui
> From: Thomas Gleixner > Sent: Tuesday, October 6, 2020 11:58 AM > > ... > > I pass through an MSI-X-capable PCI device to the Linux VM (which has > > only 1 virtual CPU), and the below code does *not* report any error > > (i.e. pci_alloc_irq_vectors_affinity() returns 2, and request_irq() > >

Re: [PATCH -next] scsi: initio: use module_pci_driver to simplify the code

2020-10-06 Thread Martin K. Petersen
Liu, > Use the module_pci_driver() macro to make the code simpler by > eliminating module_init and module_exit calls. Applied to 5.10/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] fs: dax: fix build error on ARC

2020-10-06 Thread Vineet Gupta
On 10/6/20 7:54 PM, Randy Dunlap wrote: > From: Randy Dunlap > > fs/dax.c uses copy_user_page() but ARC does not provide that interface, > resulting in a build error. > > Provide copy_user_page() in (beside copy_page()) and > add to fs/dax.c to fix the build error. > > ../fs/dax.c: In

Re: [PATCH] scsi: pmcraid: Fix memory allocation in 'pmcraid_alloc_sglist()'

2020-10-06 Thread Martin K. Petersen
> When the scatter list is allocated in 'pmcraid_alloc_sglist()', the > corresponding pointer should be stored in 'scatterlist' within the > 'pmcraid_sglist' structure. Otherwise, 'scatterlist' is NULL. > > This leads to a potential memory leak and NULL pointer dereference. > Fixes:

[PATCH] fs: dax: fix build error on ARC

2020-10-06 Thread Randy Dunlap
From: Randy Dunlap fs/dax.c uses copy_user_page() but ARC does not provide that interface, resulting in a build error. Provide copy_user_page() in (beside copy_page()) and add to fs/dax.c to fix the build error. ../fs/dax.c: In function 'copy_cow_page_dax': ../fs/dax.c:702:2: error: implicit

Re: [PATCH] mm: mmap: Fix general protection fault in unlink_file_vma()

2020-10-06 Thread linmiaohe
Friendly ping. > The syzbot reported the below general protection fault: > > general protection fault, probably for non-canonical address > 0xe00eeaee003b: [#1] PREEMPT SMP KASAN > KASAN: maybe wild-memory-access in range > [0x007001d8-0x007001df] > CPU: 1 PID: 10488

Re: [PATCH] arm64/mm: Validate hotplug range before creating linear mapping

2020-10-06 Thread Anshuman Khandual
On 10/06/2020 09:04 PM, David Hildenbrand wrote: > On 17.09.20 10:46, Anshuman Khandual wrote: >> During memory hotplug process, the linear mapping should not be created for >> a given memory range if that would fall outside the maximum allowed linear >> range. Else it might cause memory

Re: [PATCH] mm: swap: Use memset to fill the swap_map with SWAP_HAS_CACHE

2020-10-06 Thread linmiaohe
Friendly ping. > We could use helper memset to fill the swap_map with SWAP_HAS_CACHE instead > of a direct loop here to simplify the code. Also we can remove the local > variable i and map this way. > > Signed-off-by: Miaohe Lin > --- > mm/swapfile.c | 7 ++- > 1 file changed, 2

Re: [PATCH 0/4] drivers core: Introduce CPU type sysfs interface

2020-10-06 Thread Ricardo Neri
On Tue, Oct 06, 2020 at 09:51:53AM +0100, Qais Yousef wrote: > Hi Ricardo Hi Qais, Thanks for chiming in. > > Adding some people who might be interested. > > On 10/02/20 18:17, Ricardo Neri wrote: > > Hybrid CPU topologies combine processors with more than one type of > > micro-architecture.

[PATCH] [v2] thermal: core: add upper and lower limits to power_actor_set_power

2020-10-06 Thread Michael Kao
The upper and lower limits of thermal throttle state in the DT do not apply to the Intelligent Power Allocation (IPA) governor. Add the clamping for cooling device upper and lower limits in the power_actor_set_power() used by IPA. Signed-off-by: Michael Kao --- drivers/thermal/thermal_core.c |

Re: linux-next: Fixes tag needs some work in the powerpc tree

2020-10-06 Thread Michael Ellerman
Stephen Rothwell writes: > Hi all, > > In commit > > 3b6c3adbb2fa ("powerpc/perf: Exclude pmc5/6 from the irrelevant PMU group > constraints") > > Fixes tag > > Fixes: 7ffd948 ("powerpc/perf: factor out power8 pmu functions") > > has these problem(s): > > - SHA1 should be at least 12

Re: [PATCH] ext4/xfs: add page refcount helper

2020-10-06 Thread Dan Williams
On Tue, Oct 6, 2020 at 4:09 PM Ralph Campbell wrote: > > There are several places where ZONE_DEVICE struct pages assume a reference > count == 1 means the page is idle and free. Instead of open coding this, > add a helper function to hide this detail. > > Signed-off-by: Ralph Campbell >

Re: [PATCH v2] selftests/bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

2020-10-06 Thread Hao Luo
Ack. Sent one with just deletion. Hao On Tue, Oct 6, 2020 at 7:04 PM Alexei Starovoitov wrote: > > On Tue, Oct 06, 2020 at 06:23:13PM -0700, Hao Luo wrote: > > Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched > > the order of check_subprogs() and resolve_pseudo_ldimm() in > >

[PATCH v3] selftests/bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

2020-10-06 Thread Hao Luo
Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched the order of check_subprogs() and resolve_pseudo_ldimm() in the verifier. Now an empty prog expects to see the error "last insn is not an the prog of a single invalid ldimm exit or jmp" instead, because the check for subprogs comes

[PATCH bpf-next] kernel/bpf/verifier: fix build when NET is not enabled

2020-10-06 Thread Randy Dunlap
Fix build errors in kernel/bpf/verifier.c when CONFIG_NET is not enabled. ../kernel/bpf/verifier.c:3995:13: error: ‘btf_sock_ids’ undeclared here (not in a function); did you mean ‘bpf_sock_ops’? .btf_id = _sock_ids[BTF_SOCK_TYPE_SOCK_COMMON], ../kernel/bpf/verifier.c:3995:26: error:

Re: [PATCH] MIPS: pgtable: Remove used PAGE_USERIO define

2020-10-06 Thread Huacai Chen
s/used/unused/g, but it is too late, I'm sorry. Huacai On Tue, Oct 6, 2020 at 7:31 PM Thomas Bogendoerfer wrote: > > On Mon, Oct 05, 2020 at 01:28:46PM +0200, Thomas Bogendoerfer wrote: > > There are no users of PAGE_USERIO. > > > > Signed-off-by: Thomas Bogendoerfer > > --- > >

linux-next: manual merge of the net-next tree with the net tree

2020-10-06 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the net-next tree got a conflict in: net/rxrpc/conn_event.c between commit: fa1d113a0f96 ("rxrpc: Fix some missing _bh annotations on locking conn->state_lock") from the net tree and commit: 245500d853e9 ("rxrpc: Rewrite the client connection

Re: [PATCH v2] selftests/bpf: Fix test_verifier after introducing resolve_pseudo_ldimm64

2020-10-06 Thread Alexei Starovoitov
On Tue, Oct 06, 2020 at 06:23:13PM -0700, Hao Luo wrote: > Commit 4976b718c355 ("bpf: Introduce pseudo_btf_id") switched > the order of check_subprogs() and resolve_pseudo_ldimm() in > the verifier. Now an empty prog expects to see the error "last > insn is not an the prog of a single invalid

Re: [PATCH v2] mtd: spi-nor: Fix address width on flash chips > 16MB

2020-10-06 Thread Joel Stanley
On Sun, 4 Oct 2020 at 21:33, Bert Vermeulen wrote: > > If a flash chip has more than 16MB capacity but its BFPT reports > BFPT_DWORD1_ADDRESS_BYTES_3_OR_4, the spi-nor framework defaults to 3. > > The check in spi_nor_set_addr_width() doesn't catch it because addr_width > did get set. This fixes

Re: [External] Re: [PATCH v2 0/5] io_uring: Fix async workqueue is not canceled on some corner case

2020-10-06 Thread Muchun Song
On Wed, Oct 7, 2020 at 4:26 AM Jens Axboe wrote: > > On 9/28/20 6:50 AM, Muchun Song wrote: > > Ping guys. This is worth fixing. > > Agree - can you respin with the suggested change? OK, will do. > > -- > Jens Axboe > -- Yours, Muchun

[tip:auto-latest] BUILD SUCCESS 6f7122ae48059b458385c6a750575faa6f4ef64d

2020-10-06 Thread kernel test robot
mips allmodconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a004-20201006 x86_64 randconfig-a002-20201006 x86_64

Re: [PATCH V8 1/5] PCI: Add defines for Designated Vendor-Specific Extended Capability

2020-10-06 Thread David E. Box
On Tue, 2020-10-06 at 19:51 -0500, Bjorn Helgaas wrote: > On Tue, Oct 06, 2020 at 03:45:54PM -0700, David E. Box wrote: > > Hi Bjorn, > > > > This patch has been acked and unchanged for weeks. Is it possible > > to > > get this pulled into next? We have SIOV and CXL related work that > > is > >

Re: PCI: Race condition in pci_create_sysfs_dev_files

2020-10-06 Thread Oliver O'Halloran
On Wed, Oct 7, 2020 at 10:26 AM Bjorn Helgaas wrote: > > I'm not really a fan of this because pci_sysfs_init() is a bit of a > hack to begin with, and this makes it even more complicated. > > It's not obvious from the code why we need pci_sysfs_init(), but > Yinghai hinted [1] that we need to

[PATCH 1/6] KVM: VMX: Drop guest CPUID check for VMXE in vmx_set_cr4()

2020-10-06 Thread Sean Christopherson
Drop vmx_set_cr4()'s somewhat hidden guest_cpuid_has() check on VMXE now that common x86 handles the check by incorporating VMXE into the CR4 reserved bits, i.e. in cr4_guest_rsvd_bits. This fixes a bug where KVM incorrectly rejects KVM_SET_SREGS with CR4.VMXE=1 if it's executed before

[PATCH 2/6] KVM: VMX: Drop explicit 'nested' check from vmx_set_cr4()

2020-10-06 Thread Sean Christopherson
Drop vmx_set_cr4()'s explicit check on the 'nested' module param now that common x86 handles the check by incorporating VMXE into the CR4 reserved bits, via kvm_cpu_caps. X86_FEATURE_VMX is set in kvm_cpu_caps (by vmx_set_cpu_caps()), if and only if 'nested' is true. No functional change

[PATCH 4/6] KVM: x86: Move vendor CR4 validity check to dedicated kvm_x86_ops hook

2020-10-06 Thread Sean Christopherson
Split out VMX's checks on CR4.VMXE to a dedicated hook, .is_valid_cr4(), and invoke the new hook from kvm_valid_cr4(). This fixes an issue where KVM_SET_SREGS would return success while failing to actually set CR4. Fixing the issue by explicitly checking kvm_x86_ops.set_cr4()'s return in

[PATCH 0/6] KVM: x86: KVM_SET_SREGS.CR4 bug fixes and cleanup

2020-10-06 Thread Sean Christopherson
Two bug fixes to handle KVM_SET_SREGS without a preceding KVM_SET_CPUID2. The overarching issue is that kvm_x86_ops.set_cr4() can fail, but its invocation from __set_sregs(), a.k.a. KVM_SET_SREGS, ignores the result. Fix the issue by moving all validity checks out of .set_cr4() in one way or

[PATCH 6/6] KVM: selftests: Verify supported CR4 bits can be set before KVM_SET_CPUID2

2020-10-06 Thread Sean Christopherson
Extend the KVM_SET_SREGS test to verify that all supported CR4 bits, as enumerated by KVM, can be set before KVM_SET_CPUID2, i.e. without first defining the vCPU model. KVM is supposed to skip guest CPUID checks when host userspace is stuffing guest state. Check the inverse as well, i.e. that

[PATCH 5/6] KVM: x86: Return bool instead of int for CR4 and SREGS validity checks

2020-10-06 Thread Sean Christopherson
Rework the common CR4 and SREGS checks to return a bool instead of an int, i.e. true/false instead of 0/-EINVAL, and add "is" to the name to clarify the polarity of the return value (which is effectively inverted by this change). No functional changed intended. Signed-off-by: Sean Christopherson

[PATCH 3/6] KVM: SVM: Drop VMXE check from svm_set_cr4()

2020-10-06 Thread Sean Christopherson
Drop svm_set_cr4()'s explicit check CR4.VMXE now that common x86 handles the check by incorporating VMXE into the CR4 reserved bits, via kvm_cpu_caps. SVM obviously does not set X86_FEATURE_VMX. No functional change intended. Signed-off-by: Sean Christopherson --- arch/x86/kvm/svm/svm.c | 3

[PATCH v5 0/2] leds: mt6360: Add LED driver for MT6360

2020-10-06 Thread Gene Chen
This patch series add MT6360 LED support contains driver and binding document Gene Chen (2) dt-bindings: leds: Add bindings for MT6360 LED leds: mt6360: Add LED driver for MT6360 Documentation/devicetree/bindings/leds/leds-mt6360.yaml | 95 + drivers/leds/Kconfig

  1   2   3   4   5   6   7   8   9   10   >