Re: [PATCH v5 00/14] irqchip: Fix potential resource leaks

2020-10-11 Thread Tiezhu Yang
On 09/02/2020 11:59 AM, Tiezhu Yang wrote: On 07/06/2020 03:30 PM, Marc Zyngier wrote: On 2020-07-06 02:19, Tiezhu Yang wrote: When I test the irqchip code of Loongson, I read the related code of other chips in drivers/irqchip and I find some potential resource leaks in the error path, I

Re: [PATCH v9 2/6] fpga: dfl: move dfl_device_id to mod_devicetable.h

2020-10-11 Thread Xu Yilun
On Sun, Oct 11, 2020 at 04:43:51PM +0200, Greg KH wrote: > On Sat, Oct 10, 2020 at 03:09:49PM +0800, Xu Yilun wrote: > > In order to support MODULE_DEVICE_TABLE() for dfl device driver, this > > patch moves struct dfl_device_id to mod_devicetable.h > > > > Signed-off-by: Xu Yilun > >

Re: [PATCH RFC PKS/PMEM 26/58] fs/zonefs: Utilize new kmap_thread()

2020-10-11 Thread Damien Le Moal
On 2020/10/10 4:52, ira.we...@intel.com wrote: > From: Ira Weiny > > The kmap() calls in this FS are localized to a single thread. To avoid > the over head of global PKRS updates use the new kmap_thread() call. > > Cc: Damien Le Moal > Cc: Naohiro Aota > Signed-off-by: Ira Weiny > --- >

[PATCH] f2fs: don't issue flush in f2fs_flush_device_cache() for nobarrier case

2020-10-11 Thread Chao Yu
This patch changes f2fs_flush_device_cache() to skip issuing flush for nobarrier case. Signed-off-by: Chao Yu --- fs/f2fs/segment.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c index 13ecd2c2c361..f14499632b45 100644 --- a/fs/f2fs/segment.c +++

Re: [PATCH] rtw88: fix fw_fifo_addr check

2020-10-11 Thread Nathan Chancellor
On Sun, Oct 11, 2020 at 08:54:38AM -0700, t...@redhat.com wrote: > From: Tom Rix > > The clang build reports this warning > > fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' > will always evaluate to 'true' > if (!rtwdev->chip->fw_fifo_addr) { > > fw_fifo_addr is

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-11 Thread Xiaoming Ni
On 2020/10/12 5:32, Russell King - ARM Linux admin wrote: On Fri, Oct 09, 2020 at 10:18:20AM +0200, Sebastian Andrzej Siewior wrote: On 2020-10-09 09:08:50 [+0100], Russell King - ARM Linux admin wrote: I am really not happy about this - it hurts at least my ability to debug the kernel when

Re: [PATCH] page-flags: Remove unused __[Set|Clear]PagePrivate

2020-10-11 Thread linmiaohe
David Hildenbrand wrote: >> Am 10.10.2020 um 03:53 schrieb linmiaohe : >> >> David Hildenbrand wrote: On 09.10.20 15:59, Miaohe Lin wrote: They are unused anymore. >>> >>> -EINVAL, sentence does not make sense :) >>> >>> "They are not used anymore." >>> "They are unused ." >> >>

[PATCH v2 13/22] drm/msm: Document and rename preempt_lock

2020-10-11 Thread Rob Clark
From: Rob Clark Before adding another lock, give ring->lock a more descriptive name. Signed-off-by: Rob Clark Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 4 ++-- drivers/gpu/drm/msm/adreno/a5xx_preempt.c | 12 ++-- drivers/gpu/drm/msm/adreno/a6xx_gpu.c

[PATCH v2 21/22] drm/msm: Drop struct_mutex in shrinker path

2020-10-11 Thread Rob Clark
From: Rob Clark Now that the inactive_list is protected by mm_lock, and everything else on per-obj basis is protected by obj->lock, we no longer depend on struct_mutex. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 1 - drivers/gpu/drm/msm/msm_gem_shrinker.c | 54

[PATCH v2 15/22] drm/msm: Refcount submits

2020-10-11 Thread Rob Clark
From: Rob Clark Before we remove dev->struct_mutex from the retire path, we have to deal with the situation of a submit retiring before the submit ioctl returns. To deal with this, ring->submits will hold a reference to the submit, which is dropped when the submit is retired. And the submit

[PATCH v2 19/22] drm/msm: remove msm_gem_free_work

2020-10-11 Thread Rob Clark
From: Rob Clark Now that we don't need struct_mutex in the free path, we can get rid of the asynchronous free altogether. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_drv.c | 3 --- drivers/gpu/drm/msm/msm_drv.h | 5 - drivers/gpu/drm/msm/msm_gem.c | 27

[PATCH v2 22/22] drm/msm: Don't implicit-sync if only a single ring

2020-10-11 Thread Rob Clark
From: Rob Clark Any cross-device sync use-cases *must* use explicit sync. And if there is only a single ring (no-preemption), everything is FIFO order and there is no need to implicit-sync. Mesa should probably just always use MSM_SUBMIT_NO_IMPLICIT, as behavior is undefined when fences are

[PATCH v2 18/22] drm/msm: Drop struct_mutex in free_object() path

2020-10-11 Thread Rob Clark
From: Rob Clark Now that active_list/inactive_list is protected by mm_lock, we no longer need dev->struct_mutex in the free_object() path. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c

[PATCH v2 16/22] drm/msm: Remove obj->gpu

2020-10-11 Thread Rob Clark
From: Rob Clark It cannot be atomically updated with obj->active_count, and the only purpose is a useless WARN_ON() (which becomes a buggy WARN_ON() once retire_submits() is not serialized with incoming submits via struct_mutex) Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 2

[PATCH v2 14/22] drm/msm: Protect ring->submits with it's own lock

2020-10-11 Thread Rob Clark
From: Rob Clark One less place to rely on dev->struct_mutex. Signed-off-by: Rob Clark Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_gem_submit.c | 2 ++ drivers/gpu/drm/msm/msm_gpu.c| 37 ++-- drivers/gpu/drm/msm/msm_ringbuffer.c | 1 +

[PATCH v2 17/22] drm/msm: Drop struct_mutex from the retire path

2020-10-11 Thread Rob Clark
From: Rob Clark Now that we are not relying on dev->struct_mutex to protect the ring->submits lists, drop the struct_mutex lock. Signed-off-by: Rob Clark Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_gpu.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

[PATCH v2 10/22] drm/msm: Drop chatty trace

2020-10-11 Thread Rob Clark
From: Rob Clark It is somewhat redundant with the gpu tracepoints, and anyways not too useful to justify spamming the log when debug traces are enabled. Signed-off-by: Rob Clark Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_gpu.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2 20/22] drm/msm: drop struct_mutex in madvise path

2020-10-11 Thread Rob Clark
From: Rob Clark The obj->lock is sufficient for what we need. This *does* have the implication that userspace can try to shoot themselves in the foot by racing madvise(DONTNEED) with submit. But the result will be about the same if they did madvise(DONTNEED) before the submit ioctl, ie. they

[PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path

2020-10-11 Thread Rob Clark
From: Rob Clark Unfortunately, due to an dev_pm_opp locking interaction with mm->mmap_sem, we need to do pm get before aquiring obj locks, otherwise we can have anger lockdep with the chain: opp_table_lock --> >mmap_sem --> reservation_ww_class_mutex For an explicit fencing userspace, the

[PATCH v2 12/22] drm/msm: Add priv->mm_lock to protect active/inactive lists

2020-10-11 Thread Rob Clark
From: Rob Clark Rather than relying on the big dev->struct_mutex hammer, introduce a more specific lock for protecting the bo lists. Signed-off-by: Rob Clark Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_debugfs.c | 7 +++ drivers/gpu/drm/msm/msm_drv.c | 7

[PATCH v2 01/22] drm/msm/gem: Add obj->lock wrappers

2020-10-11 Thread Rob Clark
From: Rob Clark This will make it easier to transition over to obj->resv locking for everything that is per-bo locking. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 99 --- drivers/gpu/drm/msm/msm_gem.h | 28 ++ 2 files changed, 74

[PATCH v2 02/22] drm/msm/gem: Rename internal get_iova_locked helper

2020-10-11 Thread Rob Clark
From: Rob Clark We'll need to introduce a _locked() version of msm_gem_get_iova(), so we need to make that name available. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c

[PATCH v2 05/22] drm/msm/gem: Move locking in shrinker path

2020-10-11 Thread Rob Clark
From: Rob Clark Move grabbing the bo lock into shrinker, with a msm_gem_trylock() to skip over bo's that are already locked. This gets rid of the nested lock classes. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 24 + drivers/gpu/drm/msm/msm_gem.h

[PATCH v2 04/22] drm/msm/gem: Add some _locked() helpers

2020-10-11 Thread Rob Clark
From: Rob Clark When we cut-over to using dma_resv_lock/etc instead of msm_obj->lock, we'll need these for the submit path (where resv->lock is already held). Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 50 +++ drivers/gpu/drm/msm/msm_gem.h |

[PATCH v2 06/22] drm/msm/submit: Move copy_from_user ahead of locking bos

2020-10-11 Thread Rob Clark
From: Rob Clark We cannot switch to using obj->resv for locking without first moving all the copy_from_user() ahead of submit_lock_objects(). Otherwise in the mm fault path we aquire mm->mmap_sem before obj lock, but in the submit path the order is reversed. Signed-off-by: Rob Clark ---

[PATCH v2 11/22] drm/msm: Move update_fences()

2020-10-11 Thread Rob Clark
From: Rob Clark Small cleanup, update_fences() is used in the hangcheck path, but also in the normal retire path. Signed-off-by: Rob Clark Reviewed-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_gpu.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff

[PATCH v2 09/22] drm/msm: Use correct drm_gem_object_put() in fail case

2020-10-11 Thread Rob Clark
From: Rob Clark We only want to use the _unlocked() variant in the unlocked case. Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c index

[PATCH v2 08/22] drm/msm/gem: Switch over to obj->resv for locking

2020-10-11 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/msm_gem.c| 4 +--- drivers/gpu/drm/msm/msm_gem.h| 16 +--- drivers/gpu/drm/msm/msm_gem_submit.c | 4 ++-- drivers/gpu/drm/msm/msm_gpu.c| 2 +- 4 files changed, 9 insertions(+), 17

[PATCH v2 03/22] drm/msm/gem: Move prototypes to msm_gem.h

2020-10-11 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- drivers/gpu/drm/msm/disp/mdp4/mdp4_crtc.c | 1 + drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c | 1 + drivers/gpu/drm/msm/dsi/dsi_host.c| 1 + drivers/gpu/drm/msm/msm_drv.h | 54 --

[PATCH 00/14] drm/msm: de-struct_mutex-ification

2020-10-11 Thread Rob Clark
From: Rob Clark This doesn't remove *all* the struct_mutex, but it covers the worst of it, ie. shrinker/madvise/free/retire. The submit path still uses struct_mutex, but it still needs *something* serialize a portion of the submit path, and lock_stat mostly just shows the lock contention there

Re: [question] What happens when dd writes data to a missing device?

2020-10-11 Thread Douglas Gilbert
On 2020-10-11 3:46 p.m., Mikhail Gavrilov wrote: Hi folks! I have a question. What happens when dd writes data to a missing device? For example: # dd if=/home/mikhail/Downloads/Fedora-Workstation-Live-x86_64-Rawhide-20201010.n.0.iso of=/dev/adb Today I and wrongly entered /dev/adb instead of

Re: [PATCH 2/2] Arm: dts: aspeed-g6: Add sgpio node and pinctrl setting

2020-10-11 Thread Billy Tsai
Hi Joel, Thanks for your advice. On 2020/10/8, 11:49 AM, Joel Stanley wrote: > On Thu, 8 Oct 2020 at 01:51, Billy Tsai wrote: > > > > This patch is used to add sgpiom and sgpios nodes and add pinctrl setting > > for sgpiom1 > > The code looks good Billy. > >

[PATCH v4] i2c: virtio: add a virtio i2c frontend driver

2020-10-11 Thread Jie Deng
Add an I2C bus driver for virtio para-virtualization. The controller can be emulated by the backend driver in any device model software by following the virtio protocol. This driver communicates with the backend driver through a virtio I2C message structure which includes following parts: -

[PATCH] x86: Fix x32 System V message queue syscalls

2020-10-11 Thread Jessica Clarke
POSIX specifies that the first field of the supplied msgp, namely mtype, is a long, not a __kernel_long_t, and it's a user-defined struct due to the variable-length mtext field so we can't even bend the spec and make it a __kernel_long_t even if we wanted to. Thus we must use the compat syscalls

Re: [PATCH] powerpc/smp: Use GFP_ATOMIC while allocating tmp mask

2020-10-11 Thread Michael Ellerman
Srikar Dronamraju writes: > Qian Cai reported a regression where CPU Hotplug fails with the latest > powerpc/next > > BUG: sleeping function called from invalid context at mm/slab.h:494 > in_atomic(): 1, irqs_disabled(): 1, non_block: 0, pid: 0, name: swapper/88 > no locks held by swapper/88/0.

RE: [PATCH] bpf: Avoid allocing memory on memoryless numa node

2020-10-11 Thread Tianxianting
Thanks Alexei for your suggestion, I will try to do it. -Original Message- From: Alexei Starovoitov [mailto:alexei.starovoi...@gmail.com] Sent: Monday, October 12, 2020 9:21 AM To: tianxianting (RD) Cc: Alexei Starovoitov ; Daniel Borkmann ; David S. Miller ; Jakub Kicinski ; Jesper

Re: [PATCH v2 4/4] dt-bindings: usb: use preferred license tag

2020-10-11 Thread Chunfeng Yun
On Sat, 2020-10-10 at 11:50 +0200, Greg Kroah-Hartman wrote: > On Sat, Oct 10, 2020 at 04:43:14PM +0800, Chunfeng Yun wrote: > > This is used to fix the checkpach.pl WARNING:SPDX_LICENSE_TAG > > > > See bindings/submitting-patches.rst: > > "DT binding files should be dual licensed. The preferred

Re: [PATCH] bpf: Avoid allocing memory on memoryless numa node

2020-10-11 Thread Alexei Starovoitov
On Sat, Oct 10, 2020 at 1:55 AM Xianting Tian wrote: > > In architecture like powerpc, we can have cpus without any local memory > attached to it. In such cases the node does not have real memory. > > Use local_memory_node(), which is guaranteed to have memory. > local_memory_node is a noop in

[PATCH] arm64: KVM: marking pages as XN in Stage-2 does not care about CTR_EL0.DIC

2020-10-11 Thread l00484210
From: MingWang Li When testing the ARMv8.2-TTS2UXN feature, setting bits of XN is unavailable. Because the control bit CTR_EL0.DIC is set by default on system. But when CTR_EL0.DIC is set, software does not need to flush icache actively, instead of clearing XN bits.The patch, the commit id of

Re: [PATCH v2 06/14] perf arm-spe: Refactor packet header parsing

2020-10-11 Thread Leo Yan
On Thu, Oct 08, 2020 at 08:49:11PM +0100, André Przywara wrote: > On 29/09/2020 14:39, Leo Yan wrote: > > Hi Leo, > > > The packet header parsing uses the hard coded values and it uses nested > > if-else statements. > > > > To improve the readability, this patch refactors the macros for packet

Re: [PATCH v4 4/4] mmc: mediatek: Add subsys clock control for MT8192 msdc

2020-10-11 Thread Nicolas Boichat
On Sun, Oct 11, 2020 at 5:10 PM Wenbin Mei wrote: > > MT8192 msdc is an independent sub system, we need control more bus > clocks for it. > Add support for the additional subsys clocks to allow it to be > configured appropriately. > > Signed-off-by: Wenbin Mei > Reviewed-by: Nicolas Boichat

RE: [PATCH v2 3/3] ARM: dts: add ehci uhci enable in evb dts

2020-10-11 Thread Ryan Chen
Hello Segei, > -Original Message- > From: Sergei Shtylyov > Sent: Friday, October 9, 2020 4:23 PM > To: Ryan Chen ; Joel Stanley ; > Andrew Jeffery ; linux-arm-ker...@lists.infradead.org; > linux-asp...@lists.ozlabs.org; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org; BMC-SW ;

Re: LPC 2020 Hackroom Session: summary and next steps for isolated user namespaces

2020-10-11 Thread Andy Lutomirski
On Sun, Oct 11, 2020 at 1:53 PM Josh Triplett wrote: > > On Fri, Oct 09, 2020 at 11:26:06PM -0500, Serge E. Hallyn wrote: > > > 3. Find a way to allow setgroups() in a user namespace while keeping > > >in mind the case of groups used for negative access control. > > >This was suggested by

Re: [PATCH v2 05/14] perf arm-spe: Refactor printing string to buffer

2020-10-11 Thread Leo Yan
On Thu, Oct 08, 2020 at 02:46:06PM +0100, André Przywara wrote: > On 29/09/2020 14:39, Leo Yan wrote: > > Hi, > > > When outputs strings to the decoding buffer with function snprintf(), > > SPE decoder needs to detects if any error returns from snprintf() and if > > so needs to directly bail

Re: [PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error

2020-10-11 Thread Alan Stern
On Sun, Oct 11, 2020 at 09:50:08PM +0100, Sudip Mukherjee wrote: > Add a comment explaining why find_tt() will not return error even though > find_tt() is checking for NULL and other errors. > > Signed-off-by: Sudip Mukherjee > --- > drivers/usb/host/ehci-sched.c | 12 > 1 file

Re: [PATCH v2 03/14] perf arm-spe: Refactor payload length calculation

2020-10-11 Thread Leo Yan
Hi Andre, On Thu, Oct 08, 2020 at 02:44:59PM +0100, André Przywara wrote: > On 29/09/2020 14:39, Leo Yan wrote: > > Hi Leo, > > > Defines macro for payload length calculation instead of static function. > > What is the reason for that? I thought the kernel's direction is more > the other way:

RE: [PATCH] net: Avoid allocing memory on memoryless numa node

2020-10-11 Thread Tianxianting
Hi Jakub, Thanks for your suggestion, Let me try it :-) -Original Message- From: Jakub Kicinski [mailto:k...@kernel.org] Sent: Monday, October 12, 2020 3:18 AM To: tianxianting (RD) Cc: da...@davemloft.net; net...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] net:

Re: [tip: objtool/core] x86/insn: Support big endian cross-compiles

2020-10-11 Thread Masami Hiramatsu
On Sat, 10 Oct 2020 12:44:15 -0500 Josh Poimboeuf wrote: > On Fri, Oct 09, 2020 at 10:49:21PM +0200, Borislav Petkov wrote: > > On Fri, Oct 09, 2020 at 10:38:22PM +0200, Peter Zijlstra wrote: > > > On Wed, Oct 07, 2020 at 04:20:19PM -, tip-bot2 for Martin Schwidefsky > > > wrote: > > > >

Re: [tip: objtool/core] x86/insn: Support big endian cross-compiles

2020-10-11 Thread Masami Hiramatsu
On Sat, 10 Oct 2020 16:02:10 +0200 Vasily Gorbik wrote: > On Fri, Oct 09, 2020 at 10:49:21PM +0200, Borislav Petkov wrote: > > On Fri, Oct 09, 2020 at 10:38:22PM +0200, Peter Zijlstra wrote: > > > On Wed, Oct 07, 2020 at 04:20:19PM -, tip-bot2 for Martin Schwidefsky > > > wrote: > > > > The

Re: [RFC PATCH 0/3] l3mdev icmp error route lookup fixes

2020-10-11 Thread David Ahern
On 10/5/20 9:30 AM, David Ahern wrote: > On 9/25/20 1:04 PM, Mathieu Desnoyers wrote: >> Hi, >> >> Here is an updated series of fixes for ipv4 and ipv6 which which ensure >> the route lookup is performed on the right routing table in VRF >> configurations when sending TTL expired icmp errors

[PATCH RESEND] drm/aspeed: fix Kconfig warning & subsequent build errors

2020-10-11 Thread Randy Dunlap
kernel test robot reported build errors (undefined references) that didn't make much sense. After reproducing them, there is also a Kconfig warning that is the root cause of the build errors, so fix that Kconfig problem. Fixes this Kconfig warning: WARNING: unmet direct dependencies detected for

Re: [PATCH 1/2] cx82310_eth: re-enable ethernet mode after router reboot

2020-10-11 Thread Jakub Kicinski
On Sat, 10 Oct 2020 16:00:46 +0200 Ondrej Zary wrote: > When the router is rebooted without a power cycle, the USB device > remains connected but its configuration is reset. This results in > a non-working ethernet connection with messages like this in syslog: > usb 2-2: RX packet too long:

Re: [PATCH v2] net: korina: fix kfree of rx/tx descriptor array

2020-10-11 Thread Willem de Bruijn
On Sun, Oct 11, 2020 at 6:04 PM Valentin Vidic wrote: > > kmalloc returns KSEG0 addresses so convert back from KSEG1 > in kfree. Also make sure array is freed when the driver is > unloaded from the kernel. > > Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") >

linux-next: manual merge of the arm64 tree with the asm-generic tree

2020-10-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the arm64 tree got a conflict in: arch/arm64/include/asm/mmu_context.h between commit: f911c2a7c096 ("arm64: use asm-generic/mmu_context.h for no-op implementations") from the asm-generic tree and commit: 48118151d8cc ("arm64: mm: Pin down ASIDs for

Re: [PATCH v2] net: usb: rtl8150: don't incorrectly assign random MAC addresses

2020-10-11 Thread Stephen Rothwell
Hi Greg, On Sun, 11 Oct 2020 23:00:30 +0530 Anant Thazhemadam wrote: > > In set_ethernet_addr(), if get_registers() succeeds, the ethernet address > that was read must be copied over. Otherwise, a random ethernet address > must be assigned. > > get_registers() returns 0 if successful, and

Re: [PATCH 4.19 21/38] spi: fsl-espi: Only process interrupts for expected events

2020-10-11 Thread Pavel Machek
Hi! > >> [ Upstream commit b867eef4cf548cd9541225aadcdcee644669b9e1 ] > >> > >> The SPIE register contains counts for the TX FIFO so any time the irq > >> handler was invoked we would attempt to process the RX/TX fifos. Use the > >> SPIM value to mask the events so that we only process interrupts

[PATCH v2] net: korina: fix kfree of rx/tx descriptor array

2020-10-11 Thread Valentin Vidic
kmalloc returns KSEG0 addresses so convert back from KSEG1 in kfree. Also make sure array is freed when the driver is unloaded from the kernel. Fixes: ef11291bcd5f ("Add support the Korina (IDT RC32434) Ethernet MAC") Signed-off-by: Valentin Vidic --- v2: convert kfree address back to KSEG0

Re: [PATCH RESEND 1/1] perf build: Allow nested externs to enable BUILD_BUG() usage

2020-10-11 Thread Stephen Rothwell
Hi all, On Fri, 9 Oct 2020 14:41:11 +0200 Jiri Olsa wrote: > > On Fri, Oct 09, 2020 at 02:25:23PM +0200, Vasily Gorbik wrote: > > Currently BUILD_BUG() macro is expanded to smth like the following: > >do { > >extern void __compiletime_assert_0(void) > >

Re: arm-smmu 5000000.iommu: Cannot accommodate DMA offset for IOMMU page tables

2020-10-11 Thread Florian Fainelli
+Abhimanyu, Ioana, Fabio On 10/11/2020 1:36 PM, Jim Quinlan wrote: On Sat, Oct 10, 2020 at 2:53 PM Stephen Rothwell wrote: Hi Naresh, Just adding Christoph and Jim to cc] On Fri, 9 Oct 2020 19:26:24 +0530 Naresh Kamboju wrote: On Fri, 9 Oct 2020 at 19:24, Naresh Kamboju wrote: On

Re: [PATCH] arm:traps: Don't print stack or raw PC/LR values in backtraces

2020-10-11 Thread Russell King - ARM Linux admin
On Fri, Oct 09, 2020 at 10:18:20AM +0200, Sebastian Andrzej Siewior wrote: > On 2020-10-09 09:08:50 [+0100], Russell King - ARM Linux admin wrote: > > I am really not happy about this - it hurts at least my ability to > > debug the kernel when people post oopses to the mailing list. If > > people

Linux 5.9

2020-10-11 Thread Linus Torvalds
Ok, so I'll be honest - I had hoped for quite a bit fewer changes this last week, but at the same time there doesn't really seem to be anything particularly scary in here. It's just more commits and more lines changed than I would have wished for. The bulk of this is the networking fixes that I

Re: [PATCH v4 3/6] drivers: hwmon: Add the iEi WT61P803 PUZZLE HWMON driver

2020-10-11 Thread Guenter Roeck
On Wed, Oct 07, 2020 at 02:48:58AM +0200, Luka Kovacic wrote: > Add the iEi WT61P803 PUZZLE HWMON driver, that handles the fan speed > control via PWM, reading fan speed and reading on-board temperature > sensors. > > The driver registers a HWMON device and a simple thermal cooling device to >

[PATCH] e1000: drop unneeded assignment in e1000_set_itr()

2020-10-11 Thread Sudip Mukherjee
The variable 'current_itr' is assigned to 0 before jumping to 'set_itr_now' but it has not been used after the jump. So, remove the unneeded assignement. Signed-off-by: Sudip Mukherjee --- drivers/net/ethernet/intel/e1000/e1000_main.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH v2] arm64: dts: allwinner: beelink-gs1: Update LED power node

2020-10-11 Thread Clément Péron
Beelink GS1 LED trigger a warning when running dtbs_check. Update the node with a valid pattern property. Also add the function and the color of the LED and drop the label which is deprecated. Signed-off-by: Clément Péron --- arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 6 --

Re: [PATCH] arm64: dts: allwinner: beelink-gs1: Update LED power node

2020-10-11 Thread Clément Péron
Hi, On Sun, 11 Oct 2020 at 23:14, Clément Péron wrote: > > Beelink GS1 LED trigger a warning when running dtbs_check. > > Update the node with a valid pattern property. > > Also add the function and the color of the LED and drop the > label which is deprecated. > > Signed-off-by: Clément Péron

Re: [PATCH] net: korina: free array used for rx/tx descriptors

2020-10-11 Thread Valentin Vidić
On Sun, Oct 11, 2020 at 02:37:33PM -0400, Willem de Bruijn wrote: > Slightly off-topic, but I don't fully fathom what goes on with this > pointer straight after the initial kmalloc. > > lp->td_ring = (struct dma_desc *)KSEG1ADDR(lp->td_ring); KSEG1ADDR should rewrite the memory address

[PATCH] dt-bindings: sound: sun8i-a33-codec: Add Allwinner A64 codec compatible fallback

2020-10-11 Thread Clément Péron
make dtbs_check report a warning because the documentation for the A64 codec compatible is missing. The A64 codec compatible is actually a simple fallback to the A33. Reflect this in the dt-bindings Documentation. Signed-off-by: Clément Péron ---

Re: [PATCH 5/5] x86/kvm: Add KVM_FEATURE_MSI_EXT_DEST_ID

2020-10-11 Thread David Woodhouse
On 11 October 2020 18:12:08 BST, Thomas Gleixner wrote: >On Sat, Oct 10 2020 at 12:58, David Woodhouse wrote: >> On 10 October 2020 12:44:10 BST, Thomas Gleixner >wrote: >>>On Sat, Oct 10 2020 at 11:06, David Woodhouse wrote: > The IRQ remapping drivers already plug into the device-add

[PATCH] arm64: dts: allwinner: pinetab: Drop unnecessary address/size-cells information

2020-10-11 Thread Clément Péron
make dtbs_check warm about unknown address/size-cells property in the pinetab device-tree. This is because these information are not necessary. Drop them. Signed-off-by: Clément Péron --- arch/arm64/boot/dts/allwinner/sun50i-a64-pinetab.dts | 3 --- 1 file changed, 3 deletions(-) diff --git

[PATCH] arm64: dts: allwinner: beelink-gs1: Update LED power node

2020-10-11 Thread Clément Péron
Beelink GS1 LED trigger a warning when running dtbs_check. Update the node with a valid pattern property. Also add the function and the color of the LED and drop the label which is deprecated. Signed-off-by: Clément Péron --- arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 6 --

Re: LPC 2020 Hackroom Session: summary and next steps for isolated user namespaces

2020-10-11 Thread Josh Triplett
On Fri, Oct 09, 2020 at 11:26:06PM -0500, Serge E. Hallyn wrote: > > 3. Find a way to allow setgroups() in a user namespace while keeping > >in mind the case of groups used for negative access control. > >This was suggested by Josh Triplett and Geoffrey Thomas. Their idea was > > to > >

[PATCH] usb: host: ehci-sched: add comment about find_tt() not returning error

2020-10-11 Thread Sudip Mukherjee
Add a comment explaining why find_tt() will not return error even though find_tt() is checking for NULL and other errors. Signed-off-by: Sudip Mukherjee --- drivers/usb/host/ehci-sched.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/usb/host/ehci-sched.c

Re: arm-smmu 5000000.iommu: Cannot accommodate DMA offset for IOMMU page tables

2020-10-11 Thread Jim Quinlan
On Sat, Oct 10, 2020 at 2:53 PM Stephen Rothwell wrote: > > Hi Naresh, > > Just adding Christoph and Jim to cc] > > On Fri, 9 Oct 2020 19:26:24 +0530 Naresh Kamboju > wrote: > > > > On Fri, 9 Oct 2020 at 19:24, Naresh Kamboju > > wrote: > > > > > > > > > > > > On Thu, 24 Sep 2020 at 15:26,

Re: [question] What happens when dd writes data to a missing device?

2020-10-11 Thread Al Viro
On Mon, Oct 12, 2020 at 12:46:03AM +0500, Mikhail Gavrilov wrote: > Hi folks! > I have a question. > What happens when dd writes data to a missing device? > > For example: > # dd > if=/home/mikhail/Downloads/Fedora-Workstation-Live-x86_64-Rawhide-20201010.n.0.iso > of=/dev/adb > > Today I and

[tip:master] BUILD REGRESSION 820e6f502f021417140bc8ee11f9c7be148ea844

2020-10-11 Thread kernel test robot
ids grouped by kconfigs: clang_recent_errors `-- x86_64-randconfig-a016-20201011 |-- tools-include-linux-types.h:error:typedef-redefinition-with-different-types-(-int64_t-(aka-long-)-vs-__s64-(aka-long-long-)) `-- tools-include-linux-types.h:error:typedef-redefinition-with-different-types

Re: git grep/sed to standardize "/* SPDX-License-Identifier: "

2020-10-11 Thread Joe Perches
On Sun, 2020-10-11 at 11:47 -0700, Joe Perches wrote: > On Sun, 2020-10-11 at 11:42 -0700, Linus Torvalds wrote: > > On Tue, Oct 6, 2020 at 4:13 PM Joe Perches wrote: > > > Almost all source files in the kernel use a standardized SPDX header > > > at line 1 with a comment /* initiator and

[tip:efi/core] BUILD SUCCESS cc383a9e245c527d3175e2cf4cced9dbbedbbac6

2020-10-11 Thread kernel test robot
powerpc allmodconfig powerpc allnoconfig i386 randconfig-a005-20201011 i386 randconfig-a006-20201011 i386 randconfig-a001-20201011 i386 randconfig-a003-20201011 i386

[PATCH v7 12/14] arm64: defconfig: Enable Allwinner i2s driver

2020-10-11 Thread Clément Péron
Enable Allwinner I2S driver for arm64 defconfig. Signed-off-by: Clément Péron --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 63003ec116ee..9a3c3bbe60e4 100644 ---

[PATCH v7 13/14] dt-bindings: sound: sun4i-i2s: Document H3 with missing RX channel possibility

2020-10-11 Thread Clément Péron
Like A83T the Allwinner H3 doesn't have the DMA reception available for some audio interfaces. As it's already documented for A83T convert this to an enum and add the H3 interface. Acked-by: Rob Herring Signed-off-by: Clément Péron ---

[PATCH v7 14/14] arm: dts: sunxi: h3/h5: Add I2S2 node

2020-10-11 Thread Clément Péron
From: Marcus Cooper Add H3/H5 I2S2 node connected to the HDMI interface. Signed-off-by: Jernej Skrabec Signed-off-by: Marcus Cooper Acked-by: Chen-Yu Tsai Signed-off-by: Clément Péron --- arch/arm/boot/dts/sunxi-h3-h5.dtsi | 13 + 1 file changed, 13 insertions(+) diff --git

[PATCH v7 11/14] arm64: dts: allwinner: a64: Add I2S2 node

2020-10-11 Thread Clément Péron
From: Marcus Cooper Add the I2S2 node connected to the HDMI interface. Signed-off-by: Jernej Skrabec Signed-off-by: Marcus Cooper Acked-by: Chen-Yu Tsai Signed-off-by: Clément Péron --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 14 ++ 1 file changed, 14 insertions(+)

Re: VM_BUG_ON_PAGE(page_to_pgoff(page) != offset) on s390

2020-10-11 Thread Hugh Dickins
Adding a note to update this thread: the v5.9 tree now has 033b5d775511 ("mm/khugepaged: fix filemap page_to_pgoff(page) != offset") which fixes this VM_BUG_ON_PAGE (or data corruption) when CONFIG_NUMA is not set: we are hoping that may have have been the problem here.

[PATCH v7 08/14] ASoC: sun4i-i2s: fix coding-style for callback definition

2020-10-11 Thread Clément Péron
Checkpatch script produces warning: WARNING: function definition argument 'const struct sun4i_i2s *' should also have an identifier name. Let's fix this by adding identifier name to get_bclk_parent_rate() and set_fmt() callback definition. Acked-by: Maxime Ripard Signed-off-by: Clément Péron

[PATCH v7 06/14] ASoC: sun4i-i2s: Fix sun8i volatile regs

2020-10-11 Thread Clément Péron
The FIFO TX reg is volatile and sun8i i2s register mapping is different from sun4i. Even if in this case it's doesn't create an issue, Avoid setting some regs that are undefined in sun8i. Acked-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai Signed-off-by: Clément Péron ---

[PATCH v7 04/14] ASoC: sun4i-i2s: Set sign extend sample

2020-10-11 Thread Clément Péron
From: Marcus Cooper On the newer SoCs such as the H3 and A64 this is set by default to transfer a 0 after each sample in each slot. However the A10 and A20 SoCs that this driver was developed on had a default setting where it padded the audio gain with zeros. This isn't a problem while we have

[PATCH v7 10/14] arm64: dts: allwinner: h6: Add I2S1 node

2020-10-11 Thread Clément Péron
From: Jernej Skrabec Add Allwinner H6 I2S1 node connected to HDMI interface. Signed-off-by: Jernej Skrabec Signed-off-by: Marcus Cooper Acked-by: Chen-Yu Tsai Signed-off-by: Clément Péron --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 13 + 1 file changed, 13 insertions(+)

[PATCH v7 03/14] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit

2020-10-11 Thread Clément Péron
We are actually using a complex formula to just return a bunch of simple values. Also this formula is wrong for sun4i when calling get_wss() the function return 4 instead of 3. Replace this with a simpler switch case. Also drop the i2s params which is unused and return a simple int as returning

[PATCH v7 02/14] ASoC: sun4i-i2s: Add support for H6 I2S

2020-10-11 Thread Clément Péron
From: Jernej Skrabec H6 I2S is very similar to that in H3, except it supports up to 16 channels. Signed-off-by: Jernej Skrabec Signed-off-by: Marcus Cooper Reviewed-by: Chen-Yu Tsai Signed-off-by: Clément Péron --- sound/soc/sunxi/sun4i-i2s.c | 222 1

[PATCH v7 05/14] ASoc: sun4i-i2s: Add 20 and 24 bit support

2020-10-11 Thread Clément Péron
From: Marcus Cooper Extend the functionality of the driver to include support of 20 and 24 bits per sample. Signed-off-by: Marcus Cooper Acked-by: Maxime Ripard Reviewed-by: Chen-Yu Tsai Signed-off-by: Clément Péron --- sound/soc/sunxi/sun4i-i2s.c | 11 +-- 1 file changed, 9

[PATCH v7 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-10-11 Thread Clément Péron
As slots and slot_width can be set manually using set_tdm(). These values are then kept in sun4i_i2s struct. So we need to check if these values are set or not. This is not done actually and will trigger a bug. For example, if we set to the simple soundcard in the device-tree dai-tdm-slot-width =

[PATCH v7 07/14] ASoC: sun4i-i2s: Fix setting of FIFO modes

2020-10-11 Thread Clément Péron
From: Samuel Holland Because SUN4I_I2S_FIFO_CTRL_REG is volatile, writes done while the regmap is cache-only are ignored. To work around this, move the configuration to a callback that runs while the ASoC core has a runtime PM reference to the device. Signed-off-by: Samuel Holland Reviewed-by:

[PATCH v7 00/14] Add Allwinner H3/H5/H6/A64 HDMI audio

2020-10-11 Thread Clément Péron
Hi, Just some minor changes compare to v6. As explain in v6 there is no more HDMI soundcard, I will try to introduce a dedicated Allwinner soundcard in a next series. Clément Change since v6: - move set_channel_cfg() in first position - convert return value to decimal Change since v5: - Drop

[PATCH v7 09/14] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible

2020-10-11 Thread Clément Péron
From: Jernej Skrabec H6 I2S is very similar to H3, except that it supports up to 16 channels and thus few registers have fields on different position. Signed-off-by: Jernej Skrabec Signed-off-by: Marcus Cooper Acked-by: Maxime Ripard Acked-by: Rob Herring Acked-by: Chen-Yu Tsai

Re: [PATCH v2] net: usb: rtl8150: don't incorrectly assign random MAC addresses

2020-10-11 Thread Joe Perches
On Sun, 2020-10-11 at 22:31 +0300, Petko Manolov wrote: > On 20-10-11 11:33:00, Joe Perches wrote: > > On Sun, 2020-10-11 at 10:59 -0700, Jakub Kicinski wrote: > > > On Sun, 11 Oct 2020 23:00:30 +0530 Anant Thazhemadam wrote: > > > > In set_ethernet_addr(), if get_registers() succeeds, the

[PATCH] ptp: ptp_clockmatrix: initialize variables

2020-10-11 Thread trix
From: Tom Rix Clang static analysis reports this representative problem ptp_clockmatrix.c:1852:2: warning: 5th function call argument is an uninitialized value snprintf(idtcm->version, sizeof(idtcm->version), "%u.%u.%u",

Re: [PATCH 4/5] net/ipv6: use semicolons rather than commas to separate statements

2020-10-11 Thread Paul Moore
On Sun, Oct 11, 2020 at 7:18 AM Julia Lawall wrote: > > Replace commas with semicolons. Commas introduce unnecessary > variability in the code structure and are hard to see. What is done > is essentially described by the following Coccinelle semantic patch > (http://coccinelle.lip6.fr/): > > //

Re: [question] What happens when dd writes data to a missing device?

2020-10-11 Thread Sven-Haegar Koch
On Mon, 12 Oct 2020, Mikhail Gavrilov wrote: > I have a question. > What happens when dd writes data to a missing device? > > For example: > # dd > if=/home/mikhail/Downloads/Fedora-Workstation-Live-x86_64-Rawhide-20201010.n.0.iso > of=/dev/adb > > Today I and wrongly entered /dev/adb instead

Re: [GIT PULL] x86 fixes

2020-10-11 Thread Thomas Gleixner
Linus, On Sun, Oct 11 2020 at 11:00, Linus Torvalds wrote: > On Sun, Oct 11, 2020 at 1:09 AM Ingo Molnar wrote: >> >> - Fix a (hopefully final) IRQ state tracking bug vs. MCE handling > > Why is the nmi_enter/nmi_exit thing not a problem on non-x86 architectures? > > Put another way: x86 does

Re: [PATCH 4.19 21/38] spi: fsl-espi: Only process interrupts for expected events

2020-10-11 Thread Chris Packham
On 7/10/20 8:36 am, Pavel Machek wrote: > Hi! > >> [ Upstream commit b867eef4cf548cd9541225aadcdcee644669b9e1 ] >> >> The SPIE register contains counts for the TX FIFO so any time the irq >> handler was invoked we would attempt to process the RX/TX fifos. Use the >> SPIM value to mask the events

[question] What happens when dd writes data to a missing device?

2020-10-11 Thread Mikhail Gavrilov
Hi folks! I have a question. What happens when dd writes data to a missing device? For example: # dd if=/home/mikhail/Downloads/Fedora-Workstation-Live-x86_64-Rawhide-20201010.n.0.iso of=/dev/adb Today I and wrongly entered /dev/adb instead of /dev/sdb, and what my surprise was when the data

<    1   2   3   4   5   >