Re: [RESEND PATCH v3 1/1] PCI/ERR: don't clobber status after reset_link()

2020-10-11 Thread Sinan Kaya
On 10/10/2020 6:16 PM, Hedi Berriche wrote: > Commit 6d2c89441571 ("PCI/ERR: Update error status after reset_link()") > broke pcie_do_recovery(): updating status after reset_link() has the ill > side effect of causing recovery to fail if the error status is > PCI_ERS_RESULT_CAN_RECOVER or

Re: [PATCH 02/18] dt-bindings: usb: usb-hcd: Add "wireless" maximum-speed property value

2020-10-11 Thread Serge Semin
On Sun, Oct 11, 2020 at 04:42:36PM +0200, Greg Kroah-Hartman wrote: > On Sun, Oct 11, 2020 at 01:41:05AM +0300, Serge Semin wrote: > > It appears that the "maximum-speed" property can also accept the > > "wireless" value. Add it to the enumeration of the possible property > > values then. > > > >

Re: [tip: x86/entry] x86/entry: Convert Divide Error to IDTENTRY

2020-10-11 Thread Thomas Gleixner
On Sun, Oct 11 2020 at 17:25, Dmitry Vyukov wrote: > On Tue, May 19, 2020 at 9:59 PM tip-bot2 for Thomas Gleixner > wrote: >> The following commit has been merged into the x86/entry branch of tip: >> >> -DO_ERROR(X86_TRAP_DE, SIGFPE, FPE_INTDIV, IP, "divide error", >> divide_error)

Re: [PATCH] dt-bindings: clock: adi,axi-clkgen: convert old binding to yaml format

2020-10-11 Thread Lars-Peter Clausen
On 10/8/20 11:28 AM, Ardelean, Alexandru wrote: -Original Message- From: Rob Herring Sent: Tuesday, October 6, 2020 11:25 PM To: Ardelean, Alexandru Cc: linux-...@vger.kernel.org; devicet...@vger.kernel.org; linux- ker...@vger.kernel.org; Hennerich, Michael ; l...@metafoo.de;

[PATCH v2] net: usb: rtl8150: don't incorrectly assign random MAC addresses

2020-10-11 Thread Anant Thazhemadam
In set_ethernet_addr(), if get_registers() succeeds, the ethernet address that was read must be copied over. Otherwise, a random ethernet address must be assigned. get_registers() returns 0 if successful, and negative error number otherwise. However, in set_ethernet_addr(), this return value is

Re: [PATCH] PCI: aardvark: Update comment about disabling link training

2020-10-11 Thread Pali Rohár
On Thursday 24 September 2020 17:22:32 Pali Rohár wrote: > On Thursday 24 September 2020 10:11:06 Bjorn Helgaas wrote: > > On Thu, Sep 24, 2020 at 10:46:18AM +0200, Pali Rohár wrote: > > > It is not HW bug or workaround for some cards but it is requirement by PCI > > > Express spec. After

Re: [PATCH 5/5] x86/kvm: Add KVM_FEATURE_MSI_EXT_DEST_ID

2020-10-11 Thread Thomas Gleixner
On Sat, Oct 10 2020 at 12:58, David Woodhouse wrote: > On 10 October 2020 12:44:10 BST, Thomas Gleixner wrote: >>On Sat, Oct 10 2020 at 11:06, David Woodhouse wrote: >>> The IRQ remapping drivers already plug into the device-add notifier >>> and can fill in the appropriate MSI domain just like

Re: [PATCH v6 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

2020-10-11 Thread Enric Balletbo i Serra
Hi Duncan, On 11/10/20 18:35, Duncan Laurie wrote: > On Sun, Oct 11, 2020 at 4:59 AM Enric Balletbo i Serra > mailto:enric.balle...@collabora.com>> wrote: > > Hi Bhanu, > > Thank you for your patch. > > On 9/10/20 23:01, Bhanu Prakash Maiya wrote: > > Add DT compatible string

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Enric Balletbo i Serra
Hi Borislav, On 11/10/20 17:57, Borislav Petkov wrote: > On Sun, Oct 11, 2020 at 05:40:27PM +0200, Enric Balletbo i Serra wrote: >> How do you quantify those things are NOT common enough? Do you have a number? > > I don't want to change the defconfig - you do. So quantifying is in your > court -

Re: [Linux-kernel-mentees] [PATCH net] ethtool: strset: Fix out of bound read in strset_parse_request()

2020-10-11 Thread Jakub Kicinski
On Sun, 11 Oct 2020 02:39:29 +0530 Anmol Karn wrote: > Flag ``ETHTOOL_A_STRSET_COUNTS_ONLY`` tells the kernel to only return the > string > counts of the sets, but, when req_info->counts_only tries to read the > tb[ETHTOOL_A_STRSET_COUNTS_ONLY] it gets out of bound. > > - net/ethtool/strset.c

Ping: Re: [PATCH v4] : Add nitems()

2020-10-11 Thread Alejandro Colomar
Ping. On 2020-09-28 21:12, Alejandro Colomar wrote: 'nitems()' calculates the length of an array in number of items. It is safe: if a pointer is passed to the macro (or function, in C++), the compilation is broken due to: - In >= C11: _Static_assert() - In C89, C99: Negative anonymous

Re: [PATCH v6 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

2020-10-11 Thread Duncan Laurie
On Sun, Oct 11, 2020 at 4:59 AM Enric Balletbo i Serra wrote: > > Hi Bhanu, > > Thank you for your patch. > > On 9/10/20 23:01, Bhanu Prakash Maiya wrote: > > Add DT compatible string in > > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > > > > The problem with this patchset continues

Re: [PATCH v6 1/4] rcu/tree: Make rcu_do_batch count how many callbacks were executed

2020-10-11 Thread Joel Fernandes
On Fri, Oct 9, 2020 at 4:14 PM Frederic Weisbecker wrote: > > On Wed, Sep 23, 2020 at 11:22:08AM -0400, Joel Fernandes (Google) wrote: > > Currently, rcu_do_batch() depends on the unsegmented callback list's len > > field > > to know how many CBs are executed. This fields counts down from 0 as

Re: [PATCH] pinctrl: ingenic: Fix invalid SSI pins

2020-10-11 Thread Zhou Yanjie
Hi Paul, On 2020/10/11 上午3:25, Paul Cercueil wrote: The values for the SSI pins on GPIO chips D and E were off by 0x20. My bad, I missed a group when calculating the offset. Thanks for fix that. Reviewed-by: 周琰杰 (Zhou Yanjie) Fixes: d3ef8c6b2286 ("pinctrl: Ingenic: Add SSI pins support

Re: [PATCH] net: stmmac: Don't call _irqoff() with hardirqs enabled

2020-10-11 Thread Jakub Kicinski
On Sun, 11 Oct 2020 11:24:41 +0200 Heiner Kallweit wrote: > >> qeth_qdio_poll > >> netvsc_channel_cb > >> napi_watchdog > > > > This one runs from a hrtimer, which I believe will be a hard irq > > context on anything but RT. I could be wrong. > > > > A similar discussion can be found e.g.

[PATCH v5 seccomp 5/5] seccomp/cache: Report cache data through /proc/pid/seccomp_cache

2020-10-11 Thread YiFei Zhu
From: YiFei Zhu Currently the kernel does not provide an infrastructure to translate architecture numbers to a human-readable name. Translating syscall numbers to syscall names is possible through FTRACE_SYSCALL infrastructure but it does not provide support for compat syscalls. This will

[PATCH v5 seccomp 4/5] selftests/seccomp: Compare bitmap vs filter overhead

2020-10-11 Thread YiFei Zhu
From: Kees Cook As part of the seccomp benchmarking, include the expectations with regard to the timing behavior of the constant action bitmaps, and report inconsistencies better. Example output with constant action bitmaps on x86: $ sudo ./seccomp_benchmark 1 Current BPF sysctl

Re: [External] Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-11 Thread Muchun Song
On Sun, Oct 11, 2020 at 9:53 PM Mike Rapoport wrote: > > On Sat, Oct 10, 2020 at 06:38:54PM +0800, Muchun Song wrote: > > The amount of memory allocated to sockets buffer can become significant. > > However, we do not display the amount of memory consumed by sockets > > buffer. In this case,

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Borislav Petkov
On Sun, Oct 11, 2020 at 05:40:27PM +0200, Enric Balletbo i Serra wrote: > How do you quantify those things are NOT common enough? Do you have a number? I don't want to change the defconfig - you do. So quantifying is in your court - not mine. > I don't have a number, the only I can tell is that

[PATCH v5 seccomp 3/5] x86: Enable seccomp architecture tracking

2020-10-11 Thread YiFei Zhu
From: Kees Cook Provide seccomp internals with the details to calculate which syscall table the running kernel is expecting to deal with. This allows for efficient architecture pinning and paves the way for constant-action bitmaps. Signed-off-by: Kees Cook Co-developed-by: YiFei Zhu

Re: [PATCH] net: stmmac: Don't call _irqoff() with hardirqs enabled

2020-10-11 Thread Jakub Kicinski
On Sun, 11 Oct 2020 15:42:24 +0200 Heiner Kallweit wrote: > On 10.10.2020 17:22, Jakub Kicinski wrote: > > On Sat, 10 Oct 2020 15:08:15 +0200 Heiner Kallweit wrote: > >> On 09.10.2020 18:06, Heiner Kallweit wrote: > >>> On 09.10.2020 17:58, Jakub Kicinski wrote: > On Fri, 9 Oct 2020

[PATCH] rtw88: fix fw_fifo_addr check

2020-10-11 Thread trix
From: Tom Rix The clang build reports this warning fw.c:1485:21: warning: address of array 'rtwdev->chip->fw_fifo_addr' will always evaluate to 'true' if (!rtwdev->chip->fw_fifo_addr) { fw_fifo_addr is an array in rtw_chip_info so it is always nonzero. A better check is if the first

[PATCH v5 seccomp 2/5] seccomp/cache: Add "emulator" to check if filter is constant allow

2020-10-11 Thread YiFei Zhu
From: YiFei Zhu SECCOMP_CACHE will only operate on syscalls that do not access any syscall arguments or instruction pointer. To facilitate this we need a static analyser to know whether a filter will return allow regardless of syscall arguments for a given architecture number / syscall number

[PATCH] nfsd: remove unneeded break

2020-10-11 Thread trix
From: Tom Rix Because every path through nfs4_find_file()'s switch does an explicit return, the break is not needed. Signed-off-by: Tom Rix --- fs/nfsd/nfs4state.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c index c09a2a4281ec..741f64672d96

Dear good friend

2020-10-11 Thread Mrs Lila Haber
Dear good friend, I greet you with the name in the of the LORD Almighty the giver of every good thing. Good day and compliments of the seasons, I know it is true that this letter may come to you as a surprise. Nevertheless, I humbly ask you to give me your attention and hear me well. but I

[PATCH v5 seccomp 1/5] seccomp/cache: Lookup syscall allowlist bitmap for fast path

2020-10-11 Thread YiFei Zhu
From: YiFei Zhu The overhead of running Seccomp filters has been part of some past discussions [1][2][3]. Oftentimes, the filters have a large number of instructions that check syscall numbers one by one and jump based on that. Some users chain BPF filters which further enlarge the overhead. A

[PATCH v5 seccomp 0/5]seccomp: Add bitmap cache of constant allow filter results

2020-10-11 Thread YiFei Zhu
From: YiFei Zhu Alternative: https://lore.kernel.org/lkml/20200923232923.3142503-1-keesc...@chromium.org/T/ Major differences from the linked alternative by Kees: * No x32 special-case handling -- not worth the complexity * No caching of denylist -- not worth the complexity * No seccomp arch

[PATCH] staging: rtl8723bs: remove unnecessary type cast of rtw_netdev_priv() result

2020-10-11 Thread Ivan Safonov
The type cast padapter = (struct adapter *)rtw_netdev_priv(dev); do nothing because type of rtw_netdev_priv() result is (struct adapter *). Signed-off-by: Ivan Safonov --- .../staging/rtl8723bs/core/rtw_wlan_util.c| 6 +- .../staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 50

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Enric Balletbo i Serra
Hi Borislav, On 11/10/20 14:20, Borislav Petkov wrote: > On Sun, Oct 11, 2020 at 01:43:44PM +0200, Enric Balletbo i Serra wrote: >> We're also probably lacking a definition of what normal users mean, because I >> don't think normal users build their own kernel. > > You'd be surprised. > >> I

[PATCH] net/af_unix: Remove unused old_pid variable

2020-10-11 Thread Or Cohen
Commit 109f6e39fa07c48f5801 ("af_unix: Allow SO_PEERCRED to work across namespaces.") introduced the old_pid variable in unix_listen, but it's never used. Remove the declaration and the call to put_pid. Signed-off-by: Or Cohen --- net/unix/af_unix.c | 2 -- 1 file changed, 2 deletions(-) diff

Re: [PATCH] block: switch to pr_warn() in __device_add_disk()

2020-10-11 Thread Rustam Kovhaev
On Sun, Oct 11, 2020 at 04:53:22PM +0200, Hannes Reinecke wrote: > On 10/11/20 3:03 PM, Rustam Kovhaev wrote: > > syzbot triggered a warning while fuzzing with failslab fault injection > > enabled > > let's convert WARN_ON() to pr_warn() > > > > Reported-and-tested-by: > >

Re: [tip: x86/entry] x86/entry: Convert Divide Error to IDTENTRY

2020-10-11 Thread Dmitry Vyukov
On Tue, May 19, 2020 at 9:59 PM tip-bot2 for Thomas Gleixner wrote: > > The following commit has been merged into the x86/entry branch of tip: > > -DO_ERROR(X86_TRAP_DE, SIGFPE, FPE_INTDIV, IP, "divide error", > divide_error) > > +DEFINE_IDTENTRY(exc_divide_error) > +{ > +

Re: [PATCH] iio:core: In map_array_register() cleanup in case of error

2020-10-11 Thread Jonathan Cameron
On Sun, 11 Oct 2020 14:41:20 +0200 Lino Sanfilippo wrote: > In function map_array_register() properly rewind in case of error. > Furthermore save an extra label by using a break instead of goto to leave > the concerning loop. > > Signed-off-by: Lino Sanfilippo Good spot. I'd rather we went

Re: [RFC PATCH v1 22/26] docs: reporting-bugs: explain what users should do once the report got out

2020-10-11 Thread Randy Dunlap
On 10/11/20 6:29 AM, Thorsten Leemhuis wrote: > Many thx for you comments. Consider all the obvious spelling and grammatical > mistakes you pointed out fixed, I won't mention all of them in this reply to > keep things easier to follow. > > Am 09.10.20 um 19:37 schrieb Randy Dunlap: >> On

[PATCH v3 0/3] time namespace aware system boot time

2020-10-11 Thread Michael Weiß
Time namespaces make it possible to virtualize time inside of containers, e.g., it is feasible to reset the uptime of a container to zero by setting the time namespace offset for boottime to the negated current value of the CLOCK_BOOTTIME. However, the boot time stamp provided by getboottime64()

[PATCH v3 1/3] timens: additional helper function to add boottime in nsec

2020-10-11 Thread Michael Weiß
Provide a helper function to apply the boottime offset to u64 types in nanoseconds. Signed-off-by: Michael Weiß --- include/linux/time_namespace.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/linux/time_namespace.h b/include/linux/time_namespace.h index

[PATCH v3 3/3] selftests/timens: added selftest for /proc/stat btime

2020-10-11 Thread Michael Weiß
Test that btime value of /proc/stat is as expected in the time namespace using a simple parser to get btime from /proc/stat. Signed-off-by: Michael Weiß --- tools/testing/selftests/timens/procfs.c | 58 - 1 file changed, 57 insertions(+), 1 deletion(-) diff --git

[PATCH v3 2/3] fs/proc: apply the time namespace offset to /proc/stat btime

2020-10-11 Thread Michael Weiß
'/proc/stat' provides the field 'btime' which states the time stamp of system boot in seconds. In case of time namespaces, the offset to the boot time stamp was not applied earlier. However, in container runtimes which utilize time namespaces to virtualize boottime of a container, this leaks

Re: [PATCH v2 12/12] arm64: dts: mediatek: Add mt8183 power domains controller

2020-10-11 Thread kernel test robot
Hi Enric, I love your patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on mediatek/for-next linus/master v5.9-rc8] [cannot apply to next-20201009] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

Re: [PATCH] block: switch to pr_warn() in __device_add_disk()

2020-10-11 Thread Hannes Reinecke
On 10/11/20 3:03 PM, Rustam Kovhaev wrote: syzbot triggered a warning while fuzzing with failslab fault injection enabled let's convert WARN_ON() to pr_warn() Reported-and-tested-by: syzbot+f41893bb8c45cd18c...@syzkaller.appspotmail.com Link:

Re: [PATCH v9 4/6] fpga: dfl: move dfl bus related APIs to include/linux/fpga/dfl.h

2020-10-11 Thread Greg KH
On Sat, Oct 10, 2020 at 03:09:51PM +0800, Xu Yilun wrote: > Now the dfl drivers could be made as independent modules and put in > different folders according to their functionalities. In order for > scattered dfl device drivers to include dfl bus APIs, move the > dfl bus APIs to a new header file

Re: [PATCH v9 2/6] fpga: dfl: move dfl_device_id to mod_devicetable.h

2020-10-11 Thread Greg KH
On Sat, Oct 10, 2020 at 03:09:49PM +0800, Xu Yilun wrote: > In order to support MODULE_DEVICE_TABLE() for dfl device driver, this > patch moves struct dfl_device_id to mod_devicetable.h > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Signed-off-by: Matthew Gerlach > Signed-off-by: Russ

Re: [PATCH 02/18] dt-bindings: usb: usb-hcd: Add "wireless" maximum-speed property value

2020-10-11 Thread Greg Kroah-Hartman
On Sun, Oct 11, 2020 at 01:41:05AM +0300, Serge Semin wrote: > It appears that the "maximum-speed" property can also accept the > "wireless" value. Add it to the enumeration of the possible property > values then. > > Signed-off-by: Serge Semin > --- >

Re: [tip: objtool/core] x86/insn: Support big endian cross-compiles

2020-10-11 Thread Borislav Petkov
On Sat, Oct 10, 2020 at 04:02:10PM +0200, Vasily Gorbik wrote: > Should I resent the entire patch series again with these changes > squashed? Or just as a separate commit which would go on top? You can wait at least a week (merge window starts tomorrow) and then resend the entire series once the

Re: [PATCH 1/9] dma-mapping: split

2020-10-11 Thread Guenter Roeck
On Wed, Sep 30, 2020 at 10:55:40AM +0200, Christoph Hellwig wrote: > Split out all the bits that are purely for dma_map_ops implementations > and related code into a new header so that they > don't get pulled into all the drivers. That also means the architecture > specific is not pulled in by

Re: [PATCH 4/5] alpha: simplify osf_mount

2020-10-11 Thread Guenter Roeck
On Thu, Sep 17, 2020 at 10:22:35AM +0200, Christoph Hellwig wrote: > Merge the mount_args structures and mount helpers to simplify the code a > bit. > > Signed-off-by: Christoph Hellwig > --- > arch/alpha/kernel/osf_sys.c | 111 +--- > 1 file changed, 28

[PATCH] efi/x86: Only copy the compressed kernel image in efi_relocate_kernel()

2020-10-11 Thread Arvind Sankar
The image_size argument to efi_relocate_kernel() is currently specified as init_size, but this is unnecessarily large. The compressed kernel is much smaller, in fact, its image only extends up to the start of _bss, since at this point, the .bss section is still uninitialized. Depending on

Re: [PATCH 5/5] fs: remove do_mounts

2020-10-11 Thread Guenter Roeck
On Thu, Sep 17, 2020 at 10:22:36AM +0200, Christoph Hellwig wrote: > There are only two callers left, one of which is is in the alpha-specific > OSF/1 compat code. Just open code it in both. > > Signed-off-by: Christoph Hellwig > --- > arch/alpha/kernel/osf_sys.c | 7 ++- > fs/namespace.c

Re: [PATCH] mtd: parsers: bcm63xx: Do not make it modular

2020-10-11 Thread Guenter Roeck
On Tue, Sep 29, 2020 at 10:27:21AM -0700, Florian Fainelli wrote: > With commit 91e81150d388 ("mtd: parsers: bcm63xx: simplify CFE > detection"), we generate a reference to fw_arg3 which is the fourth > firmware/command line argument on MIPS platforms. That symbol is not > exported and would cause

Re: [PATCH 1/3] i2c: owl: Clear NACK and BUS error bits

2020-10-11 Thread Manivannan Sadhasivam
On Fri, Oct 09, 2020 at 12:44:39AM +0300, Cristian Ciocaltea wrote: > When the NACK and BUS error bits are set by the hardware, the driver is > responsible for clearing them by writing "1" into the corresponding > status registers. > > Hence perform the necessary operations in

Re: [PATCH 2/3] i2c: owl: Add support for atomic transfers

2020-10-11 Thread Manivannan Sadhasivam
On Fri, Oct 09, 2020 at 12:44:40AM +0300, Cristian Ciocaltea wrote: > Atomic transfers are required to properly power off a machine through > an I2C controlled PMIC, such as the Actions Semi ATC260x series. > > System shutdown may happen with interrupts being disabled and, as a > consequence, the

Re: [PATCH 3/3] i2c: owl: Enable asynchronous probing

2020-10-11 Thread Manivannan Sadhasivam
On Fri, Oct 09, 2020 at 12:44:41AM +0300, Cristian Ciocaltea wrote: > Speed up the boot process by using the asynchronous probing feature > supported by the recent kernels. > > For SBCs based on the Actions Semi S500 SoC, the overall boot time is > expected to be reduced by 200-300 ms. > >

Re: [PATCH] mm: proc: add Sock to /proc/meminfo

2020-10-11 Thread Mike Rapoport
On Sat, Oct 10, 2020 at 06:38:54PM +0800, Muchun Song wrote: > The amount of memory allocated to sockets buffer can become significant. > However, we do not display the amount of memory consumed by sockets > buffer. In this case, knowing where the memory is consumed by the kernel > is very

Re: [PATCH] net: stmmac: Don't call _irqoff() with hardirqs enabled

2020-10-11 Thread Heiner Kallweit
On 10.10.2020 17:22, Jakub Kicinski wrote: > On Sat, 10 Oct 2020 15:08:15 +0200 Heiner Kallweit wrote: >> On 09.10.2020 18:06, Heiner Kallweit wrote: >>> On 09.10.2020 17:58, Jakub Kicinski wrote: On Fri, 9 Oct 2020 16:54:06 +0200 Heiner Kallweit wrote: > I'm thinking about a

Re: [RFC PATCH v1 22/26] docs: reporting-bugs: explain what users should do once the report got out

2020-10-11 Thread Thorsten Leemhuis
Many thx for you comments. Consider all the obvious spelling and grammatical mistakes you pointed out fixed, I won't mention all of them in this reply to keep things easier to follow. Am 09.10.20 um 19:37 schrieb Randy Dunlap: On 10/1/20 1:50 AM, Thorsten Leemhuis wrote: +wait a week at

Re: [RFC PATCH v1 23/26] docs: reporting-bugs: details for issues specific to stable and longterm

2020-10-11 Thread Thorsten Leemhuis
Am 09.10.20 um 20:42 schrieb Randy Dunlap: On 10/1/20 1:50 AM, Thorsten Leemhuis wrote: Many thx for you comments, all suggestions implemented. Ciao, Thorsten

Re: [PATCH v1] kbuild: enforce -Werror=return-type

2020-10-11 Thread Masahiro Yamada
On Mon, Oct 5, 2020 at 7:13 PM Olaf Hering wrote: > > Catch errors which at least gcc tolerates by default: > warning: 'return' with no value, in function returning non-void > [-Wreturn-type] > > Signed-off-by: Olaf Hering > --- > Makefile | 3 +++ > 1 file changed, 3 insertions(+) > > diff

[PATCH] block: switch to pr_warn() in __device_add_disk()

2020-10-11 Thread Rustam Kovhaev
syzbot triggered a warning while fuzzing with failslab fault injection enabled let's convert WARN_ON() to pr_warn() Reported-and-tested-by: syzbot+f41893bb8c45cd18c...@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=f41893bb8c45cd18cf08 Signed-off-by: Rustam Kovhaev ---

[tip:master 45/51] tools/include/linux/types.h:30:18: error: typedef redefinition with different types ('uint64_t' (aka 'unsigned long') vs '__u64' (aka 'unsigned long long'))

2020-10-11 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git master head: 820e6f502f021417140bc8ee11f9c7be148ea844 commit: 3212da94d17000536c98b7c54fb4689bd5d4b092 [45/51] Merge branch 'objtool/core' config: x86_64-randconfig-a016-20201011 (attached as .config) compiler: clang version

[PATCH] iio:core: In map_array_register() cleanup in case of error

2020-10-11 Thread Lino Sanfilippo
In function map_array_register() properly rewind in case of error. Furthermore save an extra label by using a break instead of goto to leave the concerning loop. Signed-off-by: Lino Sanfilippo --- drivers/iio/inkern.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff

Re: Additional debug info to aid cacheline analysis

2020-10-11 Thread Florian Weimer
* Mark Wielaard: > On Sun, Oct 11, 2020 at 02:15:18PM +0200, Florian Weimer wrote: >> * Mark Wielaard: >> >> > Yes, that would work. I don't know what the lowest supported GCC >> > version is, but technically it was definitely fixed in 4.10.0, 4.8.4 >> > and 4.9.2. And various distros would

Re: KASAN: use-after-free Read in fscache_alloc_cookie

2020-10-11 Thread syzbot
syzbot has bisected this issue to: commit c99c2171fc61476afac0dfb59fb2c447a01fb1e0 Author: David Howells Date: Thu Nov 1 23:07:27 2018 + afs: Use fs_context to pass parameters over automount bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=17960d5850 start commit:

Re: Additional debug info to aid cacheline analysis

2020-10-11 Thread Mark Wielaard
On Sun, Oct 11, 2020 at 02:15:18PM +0200, Florian Weimer wrote: > * Mark Wielaard: > > > Yes, that would work. I don't know what the lowest supported GCC > > version is, but technically it was definitely fixed in 4.10.0, 4.8.4 > > and 4.9.2. And various distros would probably have backported the

Renew 90-day free Let’s Encrypt SSL Certificate for SSL VPN on Cisco ASA 5506-X Firewall

2020-10-11 Thread Turritopsis Dohrnii Teo En Ming
Subject: Renew 90-day free Let’s Encrypt SSL Certificate for SSL VPN on Cisco ASA 5506-X Firewall SSL Certificate Renewal Completed By: Mr. Turritopsis Dohrnii Teo En Ming Date of Renewal: 9 Oct 2020 Friday Singapore Time Date of Expiry: 8 Jan 2021 Singapore Time Country: Singapore Simply

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Borislav Petkov
On Sun, Oct 11, 2020 at 01:43:44PM +0200, Enric Balletbo i Serra wrote: > We're also probably lacking a definition of what normal users mean, because I > don't think normal users build their own kernel. You'd be surprised. > I think that at least X86_AMD_PLATFORM_DEVICE and MFD_INTEL_LPSS_PCI >

Re: Additional debug info to aid cacheline analysis

2020-10-11 Thread Florian Weimer
* Mark Wielaard: > Yes, that would work. I don't know what the lowest supported GCC > version is, but technically it was definitely fixed in 4.10.0, 4.8.4 > and 4.9.2. And various distros would probably have backported the > fix. But checking for 5.0+ would certainly give you a good version. > >

[PATCH] perf c2c: Update usage for showing memory events

2020-10-11 Thread Leo Yan
Since commit b027cc6fdf1b ("perf c2c: Fix 'perf c2c record -e list' to show the default events used"), "perf c2c" tool can show the memory events properly, it's no reason to still suggest user to use the command "perf mem record -e list" for showing events. This patch updates the usage for

Re: [PATCH v6 2/2] dt-bindings: mfd: Add DT compatible string "google,cros_ec_uart"

2020-10-11 Thread Enric Balletbo i Serra
Hi Bhanu, Thank you for your patch. On 9/10/20 23:01, Bhanu Prakash Maiya wrote: > Add DT compatible string in > Documentation/devicetree/bindings/mfd/google,cros-ec.yaml > The problem with this patchset continues being the same. You are using the trick of using a DT compatible string to

Configure Cisco ASA 5506-X Firewall for M1 Leased Line

2020-10-11 Thread Turritopsis Dohrnii Teo En Ming
Subject: Configure Cisco ASA 5506-X Firewall for M1 Leased Line Author: Mr. Turritopsis Dohrnii Teo En Ming Country: Singapore Date: 11 October 2020 Sunday Singapore Time Type of Publication: Plain Text Document Version: 20201011.01 Cisco ASA Firewall CLI commands: enable conf t interface

[PATCH] net: korina: free array used for rx/tx descriptors

2020-10-11 Thread Valentin Vidic
Memory was not freed when driver is unloaded from the kernel. Signed-off-by: Valentin Vidic --- drivers/net/ethernet/korina.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/korina.c b/drivers/net/ethernet/korina.c index 03e034918d14..99146145f020 100644 ---

Re: [PATCH] x86/x86_64_defconfig: Enable the serial console

2020-10-11 Thread Enric Balletbo i Serra
Hi Borislav and Randy, Thank you for your comments. On 8/10/20 20:31, Randy Dunlap wrote: > On 10/8/20 9:40 AM, Borislav Petkov wrote: >> On Thu, Oct 08, 2020 at 06:22:06PM +0200, Enric Balletbo i Serra wrote: >>> As part of KernelCI, we added a bunch of different x86 based Chromebooks >>> to do

Re: [PATCH 4/8] ALSA: fireworks: use semicolons rather than commas to separate statements

2020-10-11 Thread Takashi Sakamoto
Hi, On Sun, Oct 11, 2020 at 11:19:35AM +0200, Julia Lawall wrote: > Replace commas with semicolons. What is done is essentially described by > the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): > > // > @@ expression e1,e2; @@ > e1 > -, > +; > e2 > ... when any > // > >

[PATCH 4/5] net/ipv6: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. Commas introduce unnecessary variability in the code structure and are hard to see. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any //

[PATCH 5/5] net/tls: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. Commas introduce unnecessary variability in the code structure and are hard to see. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any //

[PATCH 2/5] mac80211: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. Commas introduce unnecessary variability in the code structure and are hard to see. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any //

[PATCH 3/5] tcp: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. Commas introduce unnecessary variability in the code structure and are hard to see. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any //

[PATCH 0/5] net: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
These patches replace commas by semicolons. Commas introduce unnecessary variability in the code structure and are hard to see. This was done using the Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below. This semantic patch ensures that commas inside for loop headers will not be

[PATCH 1/5] rxrpc: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. Commas introduce unnecessary variability in the code structure and are hard to see. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any //

Re: [PATCH v2 0/3] [PATCH v2 0/3] [PATCH v2 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling

2020-10-11 Thread Johannes Berg
On 11 October 2020 12:37:29 CEST, Andrey Konovalov wrote: >I initially hesitated to do that, as it would multiply the number of >kcov callbacks. But perhaps you're right and a clean API look >outweighs the rest. I will do this in v3. Yeah, OK, dunno. You can always make it an inline calling

Re: Additional debug info to aid cacheline analysis

2020-10-11 Thread Segher Boessenkool
Hi! On Sat, Oct 10, 2020 at 10:58:36PM +0200, Mark Wielaard wrote: > On Thu, Oct 08, 2020 at 02:23:00PM -0700, Andi Kleen wrote: > > So I guess could disable it for 5.0+ only. > > Yes, that would work. I don't know what the lowest supported GCC > version is, but technically it was definitely

[PATCH] staging: r8188eu: use native wireless IE codes from linux/ieee80211.h

2020-10-11 Thread Ivan Safonov
IE code definitions have been replaced with native ones to avoid code duplication. The unobvious substitutions are: _SSN_IE_1_ -> WLAN_EID_VENDOR_SPECIFIC; _WPA_IE_ID_ -> WLAN_EID_VENDOR_SPECIFIC; _WPA2_IE_ID_ -> WLAN_EID_RSN. Signed-off-by: Ivan Safonov ---

Re: [PATCH v2 0/3] [PATCH v2 0/3] [PATCH v2 0/3] net, mac80211, kernel: enable KCOV remote coverage collection for 802.11 frame handling

2020-10-11 Thread Andrey Konovalov
On Fri, Oct 9, 2020 at 7:13 PM Johannes Berg wrote: > > > > On 9 October 2020 19:01:59 CEST, Aleksandr Nogikh wrote: > > >This patch series conflicts with another proposed patch > >http://lkml.kernel.org/r/223901affc7bd759b2d6995c2dbfbdd0a29bc88a.1602248029.git.andreyk...@google.com > >One of

[PATCH v4 3/3] Documentation: Coccinelle: Modify Parallelisation information in docs

2020-10-11 Thread Sumera Priyadarsini
This patchset modifies coccicheck to use at most one thread per core by default in machines with more than 4 hyperthreads for optimal performance. Modify documentation in coccinelle.rst to reflect the same. Signed-off-by: Sumera Priyadarsini --- Documentation/dev-tools/coccinelle.rst | 6 --

[PATCH v4 2/3] scripts: coccicheck: Change default condition for parallelism

2020-10-11 Thread Sumera Priyadarsini
Currently, Coccinelle uses at most one thread per core by default in machines with more than 2 hyperthreads. However, for systems with only 4 hyperthreads, this does not improve performance. Modify coccicheck to use all available threads in machines with upto 4 hyperthreads. Signed-off-by:

[PATCH v4 1/3] scripts: coccicheck: Add quotes to improve portability

2020-10-11 Thread Sumera Priyadarsini
While fetching the number of threads per core with lscpu, the [:digit:] set is used for translation of digits from 0-9. However, using [:digit:] instead of "[:digit:]" does not seem to work uniformly for some shell types and configurations (such as zsh). Therefore, modify coccicheck to use double

[PATCH v4 0/3] Improve Coccinelle Parallelisation

2020-10-11 Thread Sumera Priyadarsini
Presently, Coccinelle uses at most one thread per core to improve performance in machines with more than 2 hyperthreads. Modify coccicheck to use all available threads in machines upto 4 hyperthreads. Further, modify the coccicheck script to improve portability. Modify documentation to reflect

Re: [PATCH] crypto: inside-secure: Fix sizeof() mismatch

2020-10-11 Thread Antoine Tenart
Hello, Quoting Colin King (2020-10-10 18:47:36) > From: Colin Ian King > > An incorrect sizeof() is being used, sizeof(priv->ring[i].rdr_req) is > not correct, it should be sizeof(*priv->ring[i].rdr_req). Note that > since the size of ** is the same size as * this is not causing any > issues. >

Re: [PATCH v3] dt-bindings: power: rockchip: Convert to json-schema

2020-10-11 Thread Enric Balletbo i Serra
On 11/10/20 11:56, Enric Balletbo i Serra wrote: > Hi Rob, > > Many thanks for your comments, some questions below. > > On 7/10/20 17:11, Rob Herring wrote: >> On Mon, Sep 21, 2020 at 11:29:51AM +0200, Enric Balletbo i Serra wrote: >>> Convert the soc/rockchip/power_domain.txt binding

[PATCH 8/8] ASoC: dapm: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any // Signed-off-by: Julia Lawall --- sound/soc/soc-dapm.c |2 +- 1 file changed, 1

[PATCH 2/8] ALSA: hda: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any // Signed-off-by: Julia Lawall --- sound/pci/hda/patch_ca0132.c |2 +-

[PATCH 1/8] ASoC: wm8350: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any // Signed-off-by: Julia Lawall --- sound/soc/codecs/wm8350.c |3 ++- 1 file changed, 2

[PATCH 3/8] ASoC: Intel: bytcr_rt5651: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any // Signed-off-by: Julia Lawall --- sound/soc/intel/boards/bytcr_rt5651.c |2 +- 1 file

[PATCH 7/8] ASoC: madera: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any // Signed-off-by: Julia Lawall --- sound/soc/codecs/madera.c |4 ++-- 1 file changed, 2

[PATCH 6/8] ASoC: samsung: snow: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any // Signed-off-by: Julia Lawall --- sound/soc/samsung/snow.c |2 +- 1 file changed, 1

[PATCH 5/8] ASoC: SOF: Intel: hda: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any // Signed-off-by: Julia Lawall --- sound/soc/sof/intel/hda-dsp.c |2 +- 1 file changed, 1

[PATCH 4/8] ALSA: fireworks: use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
Replace commas with semicolons. What is done is essentially described by the following Coccinelle semantic patch (http://coccinelle.lip6.fr/): // @@ expression e1,e2; @@ e1 -, +; e2 ... when any // Signed-off-by: Julia Lawall --- sound/firewire/fireworks/fireworks_pcm.c |2 +- 1 file

[PATCH 0/8] use semicolons rather than commas to separate statements

2020-10-11 Thread Julia Lawall
These patches replace commas by semicolons. This was done using the Coccinelle semantic patch (http://coccinelle.lip6.fr/) shown below. This semantic patch ensures that commas inside for loop headers will not be transformed. It also doesn't touch macro definitions. Coccinelle ensures that

Re: [PATCH v3] dt-bindings: power: rockchip: Convert to json-schema

2020-10-11 Thread Enric Balletbo i Serra
Hi Rob, Many thanks for your comments, some questions below. On 7/10/20 17:11, Rob Herring wrote: > On Mon, Sep 21, 2020 at 11:29:51AM +0200, Enric Balletbo i Serra wrote: >> Convert the soc/rockchip/power_domain.txt binding document to json-schema >> and move to the power bindings directory. >>

Re: [PATCH v6 3/6] mm: introduce memfd_secret system call to create "secret" memory areas

2020-10-11 Thread Mike Rapoport
On Wed, Sep 30, 2020 at 08:11:28PM +, Edgecombe, Rick P wrote: > On Wed, 2020-09-30 at 13:35 +0300, Mike Rapoport wrote: > > > > Our thinking was that copy_*user() would work in the context of the > > process that "owns" the secretmem and gup() would not allow access in > > general, unless

Re: [PATCH] net: stmmac: Don't call _irqoff() with hardirqs enabled

2020-10-11 Thread Heiner Kallweit
On 10.10.2020 17:22, Jakub Kicinski wrote: > On Sat, 10 Oct 2020 15:08:15 +0200 Heiner Kallweit wrote: >> On 09.10.2020 18:06, Heiner Kallweit wrote: >>> On 09.10.2020 17:58, Jakub Kicinski wrote: On Fri, 9 Oct 2020 16:54:06 +0200 Heiner Kallweit wrote: > I'm thinking about a

<    1   2   3   4   5   >