[PATCH] speakup: Fix clearing selection in safe context

2020-11-07 Thread Samuel Thibault
speakup_cut() calls speakup_clear_selection() which calls console_lock. Problem is: speakup_cut() is called from a keyboard interrupt context. This would hang if speakup_cut is pressed while the console lock is unfortunately already held. We can however as well just defer calling

Re: [PATCH net] ethtool: netlink: add missing netdev_features_change() call

2020-11-07 Thread Jakub Kicinski
On Thu, 05 Nov 2020 16:26:58 + Alexander Lobakin wrote: > After updating userspace Ethtool from 5.7 to 5.9, I noticed that > NETDEV_FEAT_CHANGE is no more raised when changing netdev features > through Ethtool. > That's because the old Ethtool ioctl interface always calls >

Re: [PATCH 2/2] selftests: pmtu.sh: improve the test result processing

2020-11-07 Thread Jakub Kicinski
On Thu, 5 Nov 2020 18:50:51 +0800 Po-Hsu Lin wrote: > This test will treat all non-zero return codes as failures, it will > make the pmtu.sh test script being marked as FAILED when some > sub-test got skipped. > > Improve the result processing by > * Only mark the whole test script as SKIP

[PATCH RESEND] driver core: export device_is_bound() to fix build failure

2020-11-07 Thread Sudip Mukherjee
When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it is unable to find device_is_bound(). The error being: ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko] undefined! Export the symbol so that the module finds it. Fixes: 77d8f3068c63 ("clk: imx: scu: add

Re: [PATCH] net/dsa: remove unused macros to tame gcc warning

2020-11-07 Thread Andrew Lunn
On Sat, Nov 07, 2020 at 09:39:42AM -0800, Joe Perches wrote: > On Sat, 2020-11-07 at 20:54 +0800, Alex Shi wrote: > > 在 2020/11/7 上午12:39, Florian Fainelli 写道: > > > > It is good to remember that there are multiple readers of source > > > > files. There is the compiler which generates code from

Re: [PATCH] mm/gup_benchmark: GUP_BENCHMARK depends on DEBUG_FS

2020-11-07 Thread Randy Dunlap
On 11/7/20 11:16 AM, John Hubbard wrote: > On 11/7/20 11:05 AM, Song Bao Hua (Barry Song) wrote: >>> -Original Message- >>> From: John Hubbard [mailto:jhubb...@nvidia.com] > ...    config GUP_BENCHMARK    bool "Enable infrastructure for get_user_pages() and related calls >>>

Re: [PATCH net-next] net: x25_asy: Delete the x25_asy driver

2020-11-07 Thread Jakub Kicinski
On Fri, 06 Nov 2020 06:43:53 +0100 Martin Schiller wrote: > On 2020-11-05 16:06, Arnd Bergmann wrote: > > ... > > Adding Martin Schiller and Andrew Hendry, plus the linux-x25 mailing > > list to Cc. When I last looked at the wan drivers, I think I concluded > > that this should still be kept

Re: [PATCH V3] fsl/fman: add missing put_devcie() call in fman_port_probe()

2020-11-07 Thread Jakub Kicinski
On Sat, 7 Nov 2020 17:09:25 +0800 Yu Kuai wrote: > if of_find_device_by_node() succeed, fman_port_probe() doesn't have a > corresponding put_device(). Thus add jump target to fix the exception > handling for this function implementation. > > Fixes: 0572054617f3 ("fsl/fman: fix dereference null

[PATCH] docs: networking: phy: s/2.5 times faster/2.5 times as fast/

2020-11-07 Thread Jonathan Neuschäfer
2.5 times faster would be 3.5 Gbps (4.375 Gbaud after 8b/10b encoding). Signed-off-by: Jonathan Neuschäfer --- Documentation/networking/phy.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/networking/phy.rst b/Documentation/networking/phy.rst index

Re: [GIT PULL] io_uring fixes for 5.10-rc

2020-11-07 Thread pr-tracker-bot
The pull request you sent on Sat, 7 Nov 2020 13:13:57 -0700: > git://git.kernel.dk/linux-block.git tags/io_uring-5.10-2020-11-07 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e9c02d68cc26b28a9a12ebd1aeaed673ad0e73e2 Thank you! -- Deet-doot-dot, I am a bot.

Re: [PATCH v22 12/23] LSM: Specify which LSM to display

2020-11-07 Thread John Johansen
On 11/7/20 1:15 AM, Greg KH wrote: > On Fri, Nov 06, 2020 at 04:20:43PM -0800, Casey Schaufler wrote: >> On 11/5/2020 1:22 AM, Greg KH wrote: >>> On Wed, Nov 04, 2020 at 03:41:03PM -0800, Casey Schaufler wrote: Create a new entry "display" in the procfs attr directory for controlling

Re: [RESEND PATCH] net: macb: fix NULL dereference due to no pcs_config method

2020-11-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Thu, 5 Nov 2020 18:58:33 +0100 you wrote: > This patch fixes NULL pointer dereference due to NULL pcs_config > in pcs_ops. > > Reported-by: Nicolas Ferre > Link: >

Re: [RESEND PATCH] net: macb: fix NULL dereference due to no pcs_config method

2020-11-07 Thread Jakub Kicinski
On Fri, 6 Nov 2020 10:26:59 +0100 Nicolas Ferre wrote: > On 05/11/2020 at 18:58, Parshuram Thombare wrote: > > This patch fixes NULL pointer dereference due to NULL pcs_config > > in pcs_ops. > > > > Reported-by: Nicolas Ferre > > Link: > >

Re: [PATCH v4 net-next 1/3] ptp: idt82p33: add adjphase support

2020-11-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Thu, 5 Nov 2020 22:52:07 -0500 you wrote: > From: Min Li > > Add idt82p33_adjphase() to support PHC write phase mode. > > Changes since v1: > -Fix broken build > > [...] Here is the summary with links: -

Re: [PATCH v4 net-next 1/3] ptp: idt82p33: add adjphase support

2020-11-07 Thread Jakub Kicinski
On Thu, 5 Nov 2020 22:52:07 -0500 min.li...@renesas.com wrote: > From: Min Li > > Add idt82p33_adjphase() to support PHC write phase mode. > > Signed-off-by: Min Li > Acked-by: Richard Cochran Applied all 3, thanks.

[tip: locking/urgent] futex: Handle transient "ownerless" rtmutex state correctly

2020-11-07 Thread tip-bot2 for Mike Galbraith
The following commit has been merged into the locking/urgent branch of tip: Commit-ID: 9f5d1c336a10c0d24e83e40b4c1b9539f7dba627 Gitweb: https://git.kernel.org/tip/9f5d1c336a10c0d24e83e40b4c1b9539f7dba627 Author:Mike Galbraith AuthorDate:Wed, 04 Nov 2020 16:12:44 +01:00

Re: [tip: locking/urgent] futex: Handle transient "ownerless" rtmutex state correctly

2020-11-07 Thread Thomas Gleixner
On Sat, Nov 07 2020 at 18:05, Mike Galbraith wrote: > On Fri, 2020-11-06 at 21:26 +, tip-bot2 for Mike Galbraith wrote: >> +if (unlikely(!newowner)) { >> +ret = -EAGAIN; > ^^^ > > My box just discovered an unnoticed typo. That 'ret'

Re: [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m

2020-11-07 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (refs/heads/master): On Fri, 6 Nov 2020 18:11:25 +0200 you wrote: > With CONFIG_BRIDGE=m the compilation fails: > > ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in > function `prestera_bridge_port_event': >

Re: [PATCH net] net: marvell: prestera: fix compilation with CONFIG_BRIDGE=m

2020-11-07 Thread Jakub Kicinski
On Fri, 6 Nov 2020 12:13:12 -0800 Randy Dunlap wrote: > On 11/6/20 8:11 AM, Vadym Kochan wrote: > > With CONFIG_BRIDGE=m the compilation fails: > > > > ld: drivers/net/ethernet/marvell/prestera/prestera_switchdev.o: in > > function `prestera_bridge_port_event': > >

[PATCH v2] module: fix comment style

2020-11-07 Thread Sergey Shtylyov
Many comments in this module do not comply with the preferred multi-line comment style as reported by 'scripts/checkpatch.pl': WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Fix those comments, along with (unreported for some

Re: [PATCH v2] net: macvlan: remove redundant initialization in macvlan_dev_netpoll_setup

2020-11-07 Thread Jakub Kicinski
On Wed, 4 Nov 2020 20:54:04 -0500 menglong8.d...@gmail.com wrote: > From: Menglong Dong > > The initialization for err with 0 seems useless, as it is soon updated > with -ENOMEM. So, we can remove it. > > Changes since v1: > -Keep -ENOMEM still. > > Signed-off-by: Menglong Dong Applied.

[GIT PULL] io_uring fixes for 5.10-rc

2020-11-07 Thread Jens Axboe
Hi Linus, A set of fixes for io_uring that should go into this release: - SQPOLL cancelation fixes - Two fixes for the io_identity COW - Cancelation overflow fix (Pavel) - Drain request cancelation fix (Pavel) - Link timeout race fix (Pavel) Please pull! The following changes since commit

Re: next-20201105 - build issue with KASAN on ARM

2020-11-07 Thread Nathan Chancellor
Hi Valdis, On Sat, Nov 07, 2020 at 01:33:20PM -0500, Valdis Klētnieks wrote: > commit d6d51a96c7d63b7450860a3037f2d62388286a52 > Author: Linus Walleij > Date: Sun Oct 25 23:52:08 2020 +0100 > > ARM: 9014/2: Replace string mem* functions for KASan > > I'm trying to figure out why this has

Re: [PATCH] cxgb4: Fix the -Wmisleading-indentation warning

2020-11-07 Thread Jakub Kicinski
On Wed, 4 Nov 2020 13:24:04 +0800 xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > Fix the gcc warning: > > drivers/net/ethernet/chelsio/cxgb4/cxgb4_debugfs.c:2673:9: warning: this > 'for' clause does not guard... [-Wmisleading-indentation] > 2673 | for (i = 0; i < n; ++i) \ > >

Re: [GIT PULL] RISC-V Fixes for 5.10-rc3

2020-11-07 Thread pr-tracker-bot
The pull request you sent on Fri, 06 Nov 2020 23:41:08 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git > tags/riscv-for-linus-5.10-rc3 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/4b1d362db99d9233406cb7cfe35fc698ef92be25 Thank you! --

Re: [PULL REQUEST] i2c for 5.10

2020-11-07 Thread pr-tracker-bot
The pull request you sent on Sat, 7 Nov 2020 19:39:57 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git i2c/for-current has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/af6e7de0c7d1338c3e4224c764fbcb7e28064df9 Thank you! -- Deet-doot-dot, I am a

Re: [PATCH net-next] net: emaclite: Add error handling for of_address_ and phy read functions

2020-11-07 Thread Jakub Kicinski
On Tue, 3 Nov 2020 19:01:05 +0530 Radhey Shyam Pandey wrote: > From: Shravya Kumbham > > Add ret variable, conditions to check the return value and it's error > path for of_address_to_resource() and phy_read() functions. > > Addresses-Coverity: Event check_return value. > Signed-off-by: Shravya

Re: [PATCH] drm/ingenic: ipu: Search for scaling coefs up to 102% of the screen

2020-11-07 Thread Sam Ravnborg
Hi Paul. On Thu, Nov 05, 2020 at 08:39:05AM +, Paul Cercueil wrote: > Increase the scaled image's theorical width/height until we find a > configuration that has valid scaling coefficients, up to 102% of the > screen's resolution. This makes sure that we can scale from almost > every

Re: [PATCH] locking: remove duplicate include of percpu-rwsem.h

2020-11-07 Thread Paul E. McKenney
On Sat, Nov 07, 2020 at 04:24:03PM +0800, Wang Qing wrote: > Remove duplicate header include which is unnecessary. > > Signed-off-by: Wang Qing Queued for further review and testing, thank you! I had to apply against v5.10-rc1 and then cherry-pick the result, which did work fine. However, in

Re: [PATCH 00/19] [Set 2] Rid W=1 warnings from GPU

2020-11-07 Thread Sam Ravnborg
On Sat, Nov 07, 2020 at 06:41:38PM +, Lee Jones wrote: > On Sat, 07 Nov 2020, Sam Ravnborg wrote: > > > Hi Christian. > > > > > I'm not sure if we want to do some of the suggested changes to radeon. > > > > All patches for radeon looks good to me except "drm/radeon/radeon: Move > >

[Linux-kernel-mentees] [PATCH v3 net] rose: Fix Null pointer dereference in rose_send_frame()

2020-11-07 Thread Anmol Karn
rose_send_frame() dereferences `neigh->dev` when called from rose_transmit_clear_request(), and the first occurrence of the `neigh` is in rose_loopback_timer() as `rose_loopback_neigh`, and it is initialized in rose_add_loopback_neigh() as NULL. i.e when `rose_loopback_neigh` used in

Re: [PATCH 1/2] tomoyo: Convert get_user_pages*() to pin_user_pages*()

2020-11-07 Thread John Hubbard
On 11/7/20 1:04 AM, John Hubbard wrote: On 11/7/20 12:24 AM, Souptick Joarder wrote: In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. This is case 5 as per document [1]. It

Re: [PATCH net-next 0/2] net: axienet: Dynamically enable MDIO interface

2020-11-07 Thread Jakub Kicinski
On Tue, 3 Nov 2020 16:56:08 +0530 Radhey Shyam Pandey wrote: > This patchset dynamically enable MDIO interface. The background for this > change is coming from Cadence GEM controller(macb) in which MDC is active > only during MDIO read or write operations while the PHY registers are > read or

Re: [PATCH] mm/gup_benchmark: GUP_BENCHMARK depends on DEBUG_FS

2020-11-07 Thread John Hubbard
On 11/7/20 11:05 AM, Song Bao Hua (Barry Song) wrote: -Original Message- From: John Hubbard [mailto:jhubb...@nvidia.com] ... config GUP_BENCHMARK bool "Enable infrastructure for get_user_pages() and related calls benchmarking" + depends on DEBUG_FS I think "select

Re: [PATCH v40 10/24] mm: Add 'mprotect' hook to struct vm_operations_struct

2020-11-07 Thread Dave Hansen
On 11/7/20 7:09 AM, Dr. Greg wrote: > In all of these discussions there hasn't been a refutation of my point > that the only reason this hook is needed is to stop the potential for > anonymous code execution on SGX2 capable hardware. So we will assume, > that while unspoken, this is the rationale

Re: [PATCH v5 1/1] sched/uclamp: add SCHED_FLAG_UTIL_CLAMP_RESET flag to reset uclamp

2020-11-07 Thread Yun Hsiang
Hi Patrick, On Fri, Nov 06, 2020 at 11:36:48AM +0100, Patrick Bellasi wrote: > > Hi Yun, > thanks for keep improving this. > > I'm replying here but still considering all other reviewers comments. > > Best, > Patrick > > On Tue, Nov 03, 2020 at 03:37:56 +0100, Yun Hsiang > wrote... > > >

[PATCH] module: fix comment style

2020-11-07 Thread Sergey Shtylyov
Many comments in this module do not comply with the preferred multi-line comment style as reported by 'scripts/checkpatch.pl': WARNING: Block comments use * on subsequent lines WARNING: Block comments use a trailing */ on a separate line Fix those comments, along with (unreported for some

[PATCH] docs: mtd: spi-nor: Fix formatting of text vs. diagrams

2020-11-07 Thread Jonathan Neuschäfer
Corrently, all diagrams below "Before this framework, the layer is like" and the text in between are rendered as one monospace text block. Instead, each individual diagram should be a monospace text block. Signed-off-by: Jonathan Neuschäfer --- Documentation/driver-api/mtd/spi-nor.rst | 6

Re: [PATCH 1/2] MIPS: Ingenic: Add missing nodes for Ingenic SoCs and boards.

2020-11-07 Thread H. Nikolaus Schaller
> Am 07.11.2020 um 12:52 schrieb 周琰杰 (Zhou Yanjie) : > > 1.Add OTG/OTG PHY/RNG nodes for JZ4780, CGU/OTG nodes for CI20. > 2.Add OTG/OTG PHY/RNG/OST nodes for X1000, SSI/CGU/OST/OTG/SC16IS752 > nodes for CU1000-Neo. > 3.Add OTG/OTG PHY/DTRNG/OST nodes for X1830, SSI/CGU/OST/OTG/SC16IS752 >

Re: [PATCH 2/2] MIPS: Ingenic: Refresh defconfig for Ingenic SoCs based boards.

2020-11-07 Thread H. Nikolaus Schaller
> Am 07.11.2020 um 12:52 schrieb 周琰杰 (Zhou Yanjie) : > > 1.Refresh defconfig of CI20 to support OTG and RNG. > 2.Refresh defconfig of CU1000-Neo to support OTG/RNG/OST/SC16IS752. > 3.Refresh defconfig of CU1830-Neo to support OTG/DTRNG/OST/SC16IS752. > > Tested-by: 周正 (Zhou Zheng) >

RE: [PATCH] mm/gup_benchmark: GUP_BENCHMARK depends on DEBUG_FS

2020-11-07 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: John Hubbard [mailto:jhubb...@nvidia.com] > Sent: Saturday, November 7, 2020 1:13 PM > To: Song Bao Hua (Barry Song) ; > a...@linux-foundation.org; linux...@kvack.org; > linux-kernel@vger.kernel.org > Cc: Linuxarm ; Ralph Campbell > ; John Garry > Subject:

Re: [Linux-kernel-mentees] [PATCH v2] net: rose: Fix Null pointer dereference in rose_send_frame()

2020-11-07 Thread Anmol karn
Hello, Sorry for this wrong subject(It should be v3 instead of v2), please ignore this patch. I will send a new one with the corrected subject. Thanks, Anmol On Sun, Nov 8, 2020 at 12:27 AM Anmol Karn wrote: > > rose_send_frame() dereferences `neigh->dev` when called from >

[Linux-kernel-mentees] [PATCH v2] net: rose: Fix Null pointer dereference in rose_send_frame()

2020-11-07 Thread Anmol Karn
rose_send_frame() dereferences `neigh->dev` when called from rose_transmit_clear_request(), and the first occurrence of the `neigh` is in rose_loopback_timer() as `rose_loopback_neigh`, and it is initialized in rose_add_loopback_neigh() as NULL. i.e when `rose_loopback_neigh` used in

Re: [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-07 Thread Lee Jones
On Sat, 07 Nov 2020, Kalle Valo wrote: > Lee Jones writes: > > > On Mon, 02 Nov 2020, Brian Norris wrote: > > > >> On Mon, Nov 2, 2020 at 3:25 AM Lee Jones wrote: > >> > --- a/drivers/net/wireless/realtek/rtw88/pci.h > >> > +++ b/drivers/net/wireless/realtek/rtw88/pci.h > >> > @@ -212,6

Re: [PATCH 00/19] [Set 2] Rid W=1 warnings from GPU

2020-11-07 Thread Lee Jones
On Sat, 07 Nov 2020, Sam Ravnborg wrote: > Hi Christian. > > > I'm not sure if we want to do some of the suggested changes to radeon. > > All patches for radeon looks good to me except "drm/radeon/radeon: Move > prototype into shared header". Was that the one where the prototype needs moving

[PULL REQUEST] i2c for 5.10

2020-11-07 Thread Wolfram Sang
Linus, here are driver bugfixes for I2C. Most of them are for the new mlxbf driver which got more exposure after rc1. The sh_mobile patch should already have reached you during the merge window, but I accidently dropped it. However, since it fixes a problem with rebooting, I think it is still

next-20201105 - build issue with KASAN on ARM

2020-11-07 Thread Valdis Klētnieks
commit d6d51a96c7d63b7450860a3037f2d62388286a52 Author: Linus Walleij Date: Sun Oct 25 23:52:08 2020 +0100 ARM: 9014/2: Replace string mem* functions for KASan I'm trying to figure out why this has 3 Tested-By: tags but blows up for fairly obvious reasons on ARM. CC

Re: [PATCH] applesmc: Re-work SMC comms v2

2020-11-07 Thread Henrik Rydberg
On 2020-11-06 21:02, Henrik Rydberg wrote: So as it stands, it does not work at all. I will continue to check another machine, and see if I can get something working. On the MacBookAir3,1 the situation is somewhat better. The first three tree positions result in zero failures and 10 reads per

Re: [PATCH v5 1/1] sched/uclamp: add SCHED_FLAG_UTIL_CLAMP_RESET flag to reset uclamp

2020-11-07 Thread Yun Hsiang
On Wed, Nov 04, 2020 at 10:45:09AM +0100, Dietmar Eggemann wrote: > On 03/11/2020 14:48, Qais Yousef wrote: > > Oops, +Juri for real this time. > > > > On 11/03/20 13:46, Qais Yousef wrote: > >> Hi Yun > >> > >> +Juri (A question for you below) > >> > >> On 11/03/20 10:37, Yun Hsiang wrote: > >

HID device development question: getting hid-generic out of the way for a custom egalax touchscreen driver

2020-11-07 Thread Christopher Piggott
I have a touchscreen device that uses an egalax controller. When it starts up, it gets grabbed by hid-generic. The basics work, but for some reason a few manufacturers put the touch controller 90 degrees out of whack with the actual display, so you have to do an affine transform to rotate it

Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization

2020-11-07 Thread Adrian Ratiu
On Sat, 07 Nov 2020, Russell King - ARM Linux admin wrote: On Fri, Nov 06, 2020 at 07:14:36AM +0200, Adrian Ratiu wrote: diff --git a/arch/arm/lib/xor-neon.c b/arch/arm/lib/xor-neon.c index e1e76186ec23..84c91c48dfa2 100644 --- a/arch/arm/lib/xor-neon.c +++ b/arch/arm/lib/xor-neon.c @@ -18,6

Re: [PATCH v3 bpf] trace: bpf: Fix passing zero to PTR_ERR()

2020-11-07 Thread Yonghong Song
On 11/6/20 11:45 PM, Wang Qing wrote: There is a bug when passing zero to PTR_ERR() and return. Fix smatch err. Signed-off-by: Wang Qing Acked-by: Yonghong Song

Re: [PATCH 2/2] arm: lib: xor-neon: disable clang vectorization

2020-11-07 Thread Adrian Ratiu
On Fri, 06 Nov 2020, Nick Desaulniers wrote: On Fri, Nov 6, 2020 at 3:50 AM Adrian Ratiu wrote: Hi Nathan, On Fri, 06 Nov 2020, Nathan Chancellor wrote: > + Ard, who wrote this code. > > On Fri, Nov 06, 2020 at 07:14:36AM +0200, Adrian Ratiu wrote: >> Due to a Clang bug [1] neon

Re: [PATCH v3 0/3] Reduce context clear batch size to avoid gpu hang

2020-11-07 Thread rwright
On Mon, Nov 02, 2020 at 12:57:10PM -0700, rwri...@hpe.com wrote: > On Mon, Nov 02, 2020 at 10:48:54AM +0100, Hans de Goede wrote: > > Hi, > > > ... > That said, if the i915 maintainers respond in favor of the simpler > unconditional reduction of the batch size, I will be glad to > propose a much

Re: [PATCH] netfilter: conntrack: fix -Wformat

2020-11-07 Thread Jakub Kicinski
On Fri, 6 Nov 2020 23:55:50 -0800 Nick Desaulniers wrote: > -ntohs(tuple->src.u.icmp.id)); > +(__be16)ntohs(tuple->src.u.icmp.id)); Joe has a point, besides __be16 clearly is not the right type here, the result of ntohs is in host order.

Re: [PATCH net-next 10/11] net: hns3: add ethtool priv-flag for EQ/CQ

2020-11-07 Thread Jakub Kicinski
On Sat, 7 Nov 2020 14:31:20 +0800 Huazhong Tan wrote: > +static void hns3_update_cqe_mode(struct net_device *netdev, bool enable, > bool is_tx) Wrap this to 80 characters, please.

Re: [PATCH net-next 02/11] net: hns3: add support for 1us unit GL configuration

2020-11-07 Thread Jakub Kicinski
On Sat, 7 Nov 2020 14:31:12 +0800 Huazhong Tan wrote: > For device whose version is above V3(include V3), the GL > configuration can set as 1us unit, so adds support for > configuring this field. > > Signed-off-by: Huazhong Tan Doesn't build. drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c:

Re: [PATCH] net/dsa: remove unused macros to tame gcc warning

2020-11-07 Thread Joe Perches
On Sat, 2020-11-07 at 20:54 +0800, Alex Shi wrote: > 在 2020/11/7 上午12:39, Florian Fainelli 写道: > > > It is good to remember that there are multiple readers of source > > > files. There is the compiler which generates code from it, and there > > > is the human trying to understand what is going on,

Re: [V2] [PATCH] net/ethernet: update ret when ptp_clock is ERROR

2020-11-07 Thread Jakub Kicinski
On Sat, 7 Nov 2020 06:58:16 -0800 Richard Cochran wrote: > On Sat, Nov 07, 2020 at 11:38:38AM +0800, Wang Qing wrote: > > We always have to update the value of ret, otherwise the error value > > may be the previous one. And ptp_clock_register() never return NULL > > when PTP_1588_CLOCK enable,

Re: [PATCH 00/19] [Set 2] Rid W=1 warnings from GPU

2020-11-07 Thread Sam Ravnborg
Hi Christian. > I'm not sure if we want to do some of the suggested changes to radeon. All patches for radeon looks good to me except "drm/radeon/radeon: Move prototype into shared header". Acked-by: Sam Ravnborg from me to have them applied (except the shared header one). I can reply to the

Re: [f2fs-dev] [PATCH v4 2/2] f2fs: fix compat F2FS_IOC_{MOVE, GARBAGE_COLLECT}_RANGE

2020-11-07 Thread Eric Biggers
On Sat, Nov 07, 2020 at 05:25:23PM +0800, Chao Yu wrote: > On 2020/11/7 2:03, Eric Biggers wrote: > > On Fri, Nov 06, 2020 at 02:53:31PM +0800, Chao Yu wrote: > > > +#if defined(__KERNEL__) > > > +struct compat_f2fs_gc_range { > > > + u32 sync; > > > + compat_u64 start; > > > + compat_u64 len; > >

Re: [tip: locking/urgent] futex: Handle transient "ownerless" rtmutex state correctly

2020-11-07 Thread Mike Galbraith
On Fri, 2020-11-06 at 21:26 +, tip-bot2 for Mike Galbraith wrote: > > --- > kernel/futex.c | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-) > > diff --git a/kernel/futex.c b/kernel/futex.c > index f8614ef..7406914 100644 > --- a/kernel/futex.c > +++ b/kernel/futex.c >

[PATCH v1 5/5] arm64: dts: rockchip: add QoS register compatibles for px30

2020-11-07 Thread Johan Jonker
With the conversion of syscon.yaml minItems for compatibles was set to 2. Current Rockchip dtsi files only use "syscon" for QoS registers. Add Rockchip QoS compatibles for px30 to reduce notifications produced with: make ARCH=arm64 dtbs_check

[PATCH v1 4/5] arm64: dts: rockchip: add QoS register compatibles for rk3399

2020-11-07 Thread Johan Jonker
With the conversion of syscon.yaml minItems for compatibles was set to 2. Current Rockchip dtsi files only use "syscon" for QoS registers. Add Rockchip QoS compatibles for rk3399 to reduce notifications produced with: make ARCH=arm64 dtbs_check

[PATCH v1 2/5] ARM: dts: rockchip: add QoS register compatibles for rk3066/rk3188

2020-11-07 Thread Johan Jonker
With the conversion of syscon.yaml minItems for compatibles was set to 2. Current Rockchip dtsi files only use "syscon" for QoS registers. Add Rockchip QoS compatibles for rk3066/rk3188 to reduce notifications produced with: make ARCH=arm dtbs_check

[PATCH v1 3/5] ARM: dts: rockchip: add QoS register compatibles for rk3288

2020-11-07 Thread Johan Jonker
With the conversion of syscon.yaml minItems for compatibles was set to 2. Current Rockchip dtsi files only use "syscon" for QoS registers. Add Rockchip QoS compatibles for rk3288 to reduce notifications produced with: make ARCH=arm dtbs_check

[PATCH v1 1/5] dt-binding: mfd: syscon: add Rockchip QoS register compatibles

2020-11-07 Thread Johan Jonker
With the conversion of syscon.yaml minItems for compatibles was set to 2. Current Rockchip dtsi files only use "syscon" for QoS registers. Add Rockchip QoS compatibles to reduce notifications produced with: make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mfd/syscon.yaml

Re: [PATCH -next] irq-chip/gic-v3-its: Fixed an issue where the ITS executes the residual commands in the queue again when the ITS wakes up from sleep mode.

2020-11-07 Thread Marc Zyngier
[dropping Jason, whose email address has been bouncing for weeks now] On 2020-11-07 10:42, Xu Qiang wrote: On my platform, ITS_FLAGS_SAVE_SUSPEND_STATE is not set,thus do nothing Which platform? in its suspend and resuse function.On the other hand,firmware stores

[PATCH] scsi: bnx2fc: fix comparison to bool warning

2020-11-07 Thread xiakaixu1987
From: Kaixu Xia Fix the following coccicheck warning: ./drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2089:5-23: WARNING: Comparison to bool ./drivers/scsi/bnx2fc/bnx2fc_fcoe.c:2187:5-23: WARNING: Comparison to bool Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c

Abschließende Mitteilung für die Zahlung des nicht beanspruchten Preisgeldes,.

2020-11-07 Thread ABOGADO VITALIS MANUEL COLON
ANWALTSKANZLEI: ABOGADO VITALIS MANUEL COLON. Calle de Raimundo Fernández Villaverde, 50, 28010 Madrid, Spanien. E mail. analyn.hernan...@mail2lawyer.com AKTENZEICHEN: JMCB-ES/11-547/05-17 KUNDENNUMMER: MD-DE/LOT-516 Abschließende Mitteilung für die Zahlung des nicht beanspruchten Preisgeldes.

Re: [PATCH 41/41] realtek: rtw88: pci: Add prototypes for .probe, .remove and .shutdown

2020-11-07 Thread Kalle Valo
Lee Jones writes: > On Mon, 02 Nov 2020, Brian Norris wrote: > >> On Mon, Nov 2, 2020 at 3:25 AM Lee Jones wrote: >> > --- a/drivers/net/wireless/realtek/rtw88/pci.h >> > +++ b/drivers/net/wireless/realtek/rtw88/pci.h >> > @@ -212,6 +212,10 @@ struct rtw_pci { >> > void __iomem *mmap;

Re: [03/41] rtlwifi: rtl8192cu: mac: Fix some missing/ill-documented function parameters

2020-11-07 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:124: warning: Function > parameter or member 'hw' not described in 'rtl92c_llt_write' > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/mac.c:124: warning: Excess >

[PATCH] ALSA: firewire: fix comparison to bool warning

2020-11-07 Thread xiakaixu1987
From: Kaixu Xia Fix the following coccicheck warning: ./sound/firewire/amdtp-stream.h:273:6-19: WARNING: Comparison to bool Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- sound/firewire/amdtp-stream.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [38/41] rtw88: rtw8822c: Remove unused variable 'corr_val'

2020-11-07 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function > ‘rtw8822c_dpk_dc_corr_check’: > drivers/net/wireless/realtek/rtw88/rtw8822c.c:2445:5: warning: variable > ‘corr_val’ set but not used

Re: [36/41] rtw88: rtw8822b: Return type is not const

2020-11-07 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/realtek/rtw88/rtw8822b.c:90:8: warning: type qualifiers > ignored on function return type [-Wignored-qualifiers] > > Cc: Yan-Hsuan Chuang > Cc: Kalle Valo > Cc: "David S. Miller" > Cc: Jakub

Re: [PATCH 09/41] wl1251: cmd: Rename 'len' to 'buf_len' in the documentation

2020-11-07 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/ti/wl1251/cmd.c:70: warning: Function parameter or > member 'buf_len' not described in 'wl1251_cmd_test' > drivers/net/wireless/ti/wl1251/cmd.c:70: warning: Excess function parameter > 'len'

Re: [tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

2020-11-07 Thread Borislav Petkov
On Sat, Nov 07, 2020 at 03:13:58PM -, tip-bot2 for Ingo Molnar wrote: > The following commit has been merged into the perf/kprobes branch of tip: > > Commit-ID: a70a04b3844f59c29573a8581d5c263225060dd6 > Gitweb: > https://git.kernel.org/tip/a70a04b3844f59c29573a8581d5c263225060dd6

Re: [PATCH 06/41] brcmfmac: bcmsdh: Fix description for function parameter 'pktlist'

2020-11-07 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c:380: warning: > Function parameter or member 'pktlist' not described in > 'brcmf_sdiod_sglist_rw' >

Re: [02/41] rsi: rsi_91x_usb: Fix some basic kernel-doc issues

2020-11-07 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/rsi/rsi_91x_usb.c:26: warning: cannot understand > function prototype: 'u16 dev_oper_mode = DEV_OPMODE_STA_BT_DUAL; ' > drivers/net/wireless/rsi/rsi_91x_usb.c:88: warning: Function parameter or >

Re: [PATCH 17/41] intersil: hostap_hw: Prevent incompatible function type cast

2020-11-07 Thread Kalle Valo
Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/net/wireless/intersil/hostap/hostap_hw.c: In function > ‘prism2_init_local_data’: > drivers/net/wireless/intersil/hostap/hostap_hw.c:3173:48: warning: cast > between incompatible function types from ‘void

[PATCH] drivers: staging: small refactor

2020-11-07 Thread Sotir Danailov
Small refactor of 3 files in the staging directory. Signed-off-by: Sotir Danailov --- drivers/staging/mt7621-pci/pci-mt7621.c | 1 - drivers/staging/rtl8188eu/core/rtw_ap.c | 4 +++- drivers/staging/rtl8188eu/core/rtw_xmit.c | 25 +++ 3 files changed, 20 insertions(+),

Re: [PATCH v2 net-next 3/3] octeontx2-af: Add devlink health reporters for NIX

2020-11-07 Thread Sunil Kovvuri
On Sat, Nov 7, 2020 at 2:28 AM Saeed Mahameed wrote: > > On Fri, 2020-11-06 at 00:59 +0530, Sunil Kovvuri wrote: > > > > > > Output: > > > > > > # ./devlink health > > > > > > pci/0002:01:00.0: > > > > > >reporter npa > > > > > > state healthy error 0 recover 0 > > > > > >reporter

Re: [PATCH] rtlwifi: Fix non-canonical address access issues

2020-11-07 Thread Kalle Valo
WeitaoWangoc wrote: > During realtek USB wireless NIC initialization, it's unexpected > disconnection will cause urb sumbmit fail. On the one hand, > _rtl_usb_cleanup_rx will be called to clean up rx stuff, especially for > rtl_wq. On the other hand, disconnection will cause rtl_usb_disconnect >

Re: [PATCH] Drivers: ssb: remove unnecessary CONFIG_PM_SLEEP

2020-11-07 Thread Kalle Valo
Coiby Xu writes: > SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > Signed-off-by: Coiby Xu > --- > drivers/ssb/pcihost_wrapper.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/drivers/ssb/pcihost_wrapper.c b/drivers/ssb/pcihost_wrapper.c > index

Re: [PATCH] net/sunrpc: Fix return value from proc_do_xprt()

2020-11-07 Thread J. Bruce Fields
On Sat, Nov 07, 2020 at 01:49:40PM +, Alex Dewar wrote: > On Fri, Nov 06, 2020 at 05:07:21PM -0500, J. Bruce Fields wrote: > > Whoops, got 3 independent patches for this and overlooked this one. See > > https://lore.kernel.org/linux-nfs/20201106205959.gb26...@fieldses.org/T/#t > > > > --b. >

Re: [PATCH v2 1/1] Fonts: Replace discarded const qualifier

2020-11-07 Thread Greg KH
On Sat, Nov 07, 2020 at 12:19:18AM -0500, Peilin Ye wrote: > Hi all, > > On Tue, Nov 03, 2020 at 10:55:23AM +, Lee Jones wrote: > > Would you be kind enough to let us know when this lands in Mainline > > please? We'll need to back-port it to start fixing up our Stable > > kernels ASAP. > >

[net-next,v2,0/5] seg6: add support for SRv6 End.DT4 behavior

2020-11-07 Thread Andrea Mayer
This patchset provides support for the SRv6 End.DT4 behavior. The SRv6 End.DT4 is used to implement multi-tenant IPv4 L3 VPN. It decapsulates the received packets and performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux implementation leverages a VRF device. The

[net-next,v2,2/5] seg6: improve management of behavior attributes

2020-11-07 Thread Andrea Mayer
Depending on the attribute (i.e.: SEG6_LOCAL_SRH, SEG6_LOCAL_TABLE, etc), the parse() callback performs some validity checks on the provided input and updates the tunnel state (slwt) with the result of the parsing operation. However, an attribute may also need to reserve some additional resources

[net-next,v2,5/5] selftests: add selftest for the SRv6 End.DT4 behavior

2020-11-07 Thread Andrea Mayer
this selftest is designed for evaluating the new SRv6 End.DT4 behavior used, in this example, for implementing IPv4 L3 VPN use cases. Signed-off-by: Andrea Mayer --- .../selftests/net/srv6_end_dt4_l3vpn_test.sh | 494 ++ 1 file changed, 494 insertions(+) create mode 100755

[net-next,v2,4/5] seg6: add support for the SRv6 End.DT4 behavior

2020-11-07 Thread Andrea Mayer
SRv6 End.DT4 is defined in the SRv6 Network Programming [1]. The SRv6 End.DT4 is used to implement IPv4 L3VPN use-cases in multi-tenants environments. It decapsulates the received packets and it performs IPv4 routing lookup in the routing table of the tenant. The SRv6 End.DT4 Linux

[net-next,v2,1/5] vrf: add mac header for tunneled packets when sniffer is attached

2020-11-07 Thread Andrea Mayer
Before this patch, a sniffer attached to a VRF used as the receiving interface of L3 tunneled packets detects them as malformed packets and it complains about that (i.e.: tcpdump shows bogus packets). The reason is that a tunneled L3 packet does not carry any L2 information and when the VRF is

[net-next,v2,3/5] seg6: add callbacks for customizing the creation/destruction of a behavior

2020-11-07 Thread Andrea Mayer
We introduce two callbacks used for customizing the creation/destruction of a SRv6 behavior. Such callbacks are defined in the new struct seg6_local_lwtunnel_ops and hereafter we provide a brief description of them: - build_state(...): used for calling the custom constructor of the behavior

[PATCH] proc: fix comparison to bool warning

2020-11-07 Thread xiakaixu1987
From: Kaixu Xia Fix the following coccicheck warning: ./fs/proc/generic.c:370:5-31: WARNING: Comparison to bool Reported-by: Tosk Robot Signed-off-by: Kaixu Xia --- fs/proc/generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/proc/generic.c b/fs/proc/generic.c

Re: [PATCH v40 10/24] mm: Add 'mprotect' hook to struct vm_operations_struct

2020-11-07 Thread Dr. Greg
On Fri, Nov 06, 2020 at 09:13:11PM +, Matthew Wilcox wrote: > On Fri, Nov 06, 2020 at 11:43:59AM -0600, Dr. Greg wrote: > > The 900 pound primate in the room, that no one is acknowledging, is > > that this technology was designed to not allow the operating system to > > have any control over

[PATCH] mm/zsmalloc: include sparsemem.h for MAX_PHYSMEM_BITS

2020-11-07 Thread Stefan Agner
Most architectures define MAX_PHYSMEM_BITS in asm/sparsemem.h and don't include it in asm/pgtable.h. Include asm/sparsemem.h directly to get the MAX_PHYSMEM_BITS define on all architectures. This fixes a crash when accessing zram on 32-bit ARM platform with LPAE and more than 4GB of memory:

[tip: irq/core] irqdomain: Introduce irq_domain_create_legacy() API

2020-11-07 Thread tip-bot2 for Andy Shevchenko
The following commit has been merged into the irq/core branch of tip: Commit-ID: b6e95788fde8c9bc9da729102085dd36a5a0cda6 Gitweb: https://git.kernel.org/tip/b6e95788fde8c9bc9da729102085dd36a5a0cda6 Author:Andy Shevchenko AuthorDate:Fri, 30 Oct 2020 18:59:18 +02:00

Re: [PATCH 10/19] drm/radeon/radeon: Move prototype into shared header

2020-11-07 Thread Lee Jones
On Sat, 07 Nov 2020, Sam Ravnborg wrote: > Hi Lee, > > On Fri, Nov 06, 2020 at 09:49:40PM +, Lee Jones wrote: > > Unfortunately, a suitable one didn't already exist. > > > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/radeon/radeon_device.c:637:6: warning: no

[tip: perf/urgent] perf/core: Fix a memory leak in perf_event_parse_addr_filter()

2020-11-07 Thread 尹亮
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 7bdb157cdebbf95a1cd94ed2e01b338714075d00 Gitweb: https://git.kernel.org/tip/7bdb157cdebbf95a1cd94ed2e01b338714075d00 Author:kiyin(尹亮) AuthorDate:Wed, 04 Nov 2020 08:23:22 +03:00 Committer:

[tip: perf/kprobes] locking/atomics: Regenerate the atomics-check SHA1's

2020-11-07 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the perf/kprobes branch of tip: Commit-ID: a70a04b3844f59c29573a8581d5c263225060dd6 Gitweb: https://git.kernel.org/tip/a70a04b3844f59c29573a8581d5c263225060dd6 Author:Ingo Molnar AuthorDate:Sat, 07 Nov 2020 12:54:49 +01:00

[tip: irq/core] regmap: irq: Convert to use irq_domain_create_legacy()

2020-11-07 Thread tip-bot2 for Andy Shevchenko
The following commit has been merged into the irq/core branch of tip: Commit-ID: d315c627a18249930750fe4eb2b21f3fe9b32ea4 Gitweb: https://git.kernel.org/tip/d315c627a18249930750fe4eb2b21f3fe9b32ea4 Author:Andy Shevchenko AuthorDate:Fri, 30 Oct 2020 18:59:19 +02:00

<    1   2   3   4   >