[PATCH v2] tpm_tis_spi_main: set cs_change = 0 when timesout

2021-02-04 Thread wanghongzhe
when i reach TPM_RETRY, the cs cannot change back to 'high'. So the TPM chips thinks this communication is not over. And next times communication cannot be effective because the communications mixed up with the last time. v1 -> v2: - fix spi_xfer->cs_change error Signed-off-by: wanghongzhe

Re: [PATCH v3 2/2] dmabuf: Add dmabuf inode number to /proc/*/fdinfo

2021-02-04 Thread Christian König
Am 05.02.21 um 03:23 schrieb Kalesh Singh: If a FD refers to a DMA buffer add the DMA buffer inode number to /proc//fdinfo/ and /proc//task//fdindo/. The dmabuf inode number allows userspace to uniquely identify the buffer and avoids a dependency on /proc//fd/* when accounting per-process DMA

Re: Possible deny of service with memfd_create()

2021-02-04 Thread Christian König
Am 05.02.21 um 01:32 schrieb Hugh Dickins: On Thu, 4 Feb 2021, Michal Hocko wrote: On Thu 04-02-21 17:32:20, Christian Koenig wrote: Hi Michal, as requested in the other mail thread the following sample code gets my test system down within seconds. The issue is that the memory allocated for

Re: [PATCH -next] RISCV: Add some depends for NUMA

2021-02-04 Thread Kefeng Wang
On 2021/2/5 14:58, Palmer Dabbelt wrote: On Wed, 03 Feb 2021 06:23:43 PST (-0800), wangkefeng.w...@huawei.com wrote: The numa feature is useless for riscv32 platform(MAXPHYSMEM_1GB if 32bit), I'm not convinced of that.  There's no reason NUMA shouldn't work on 32-bit, it doesn't depend on

Re: [PATCH v1] tpm_tis_spi_main: set cs_change = 0 when timesout

2021-02-04 Thread kernel test robot
Hi wanghongzhe, Thank you for the patch! Yet something to improve: [auto build test ERROR on char-misc/char-misc-testing] [also build test ERROR on v5.11-rc6 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH v2] drm/qxl: do not run release if qxl failed to init

2021-02-04 Thread Gerd Hoffmann
On Thu, Feb 04, 2021 at 11:30:50AM -0500, Tong Zhang wrote: > if qxl_device_init() fail, drm device will not be registered, > in this case, do not run qxl_drm_release() How do you trigger this? take care, Gerd

Re: [PATCH] x86/sgx: Drop racy follow_pfn check

2021-02-04 Thread Daniel Vetter
On Fri, Feb 5, 2021 at 3:26 AM Jarkko Sakkinen wrote: > > On Thu, Feb 04, 2021 at 07:45:19PM +0100, Daniel Vetter wrote: > > References: > > https://lore.kernel.org/dri-devel/20201127164131.2244124-1-daniel.vet...@ffwll.ch/ > > What is the difference between this and "Link:" anyway? Afaik

Re: [PATCH v3 3/4] drm_dp_mst_topology: export two functions

2021-02-04 Thread Sam McNally
On Tue, 2 Feb 2021 at 09:03, Lyude Paul wrote: > > On Wed, 2020-09-23 at 12:13 +1000, Sam McNally wrote: > > From: Hans Verkuil > > > > These are required for the CEC MST support. > > > > Signed-off-by: Hans Verkuil > > Signed-off-by: Sam McNally > > --- > > > > (no changes since v1) > > > >

Re: [PATCH 15/18] irqchip/apple-aic: Add support for the Apple Interrupt Controller

2021-02-04 Thread Hector Martin 'marcan'
On 05/02/2021 08.04, Arnd Bergmann wrote: On Thu, Feb 4, 2021 at 11:06 PM Hector Martin 'marcan' wrote: If we split it up again, one of the two still needs to be the root, decide whether what fired is an IRQ or FIQ, and dispatch accordingly. Or we could have three nodes and have one root

Re: [PATCH v6 01/10] [hack] silence ttm fini WARNING

2021-02-04 Thread Gerd Hoffmann
On Thu, Feb 04, 2021 at 03:58:33PM +0100, Christian König wrote: > ? > > What's the background here? > > Christian. > > Am 04.02.21 um 15:57 schrieb Gerd Hoffmann: > > kobject: '(null)' ((ptrval)): is not initialized, yet kobject_put() > > is being called. > > WARNING: CPU: 0 PID: 209

Re: ANNOUNCE: pahole v1.20 (gcc11 DWARF5's default, lots of ELF sections, BTF)

2021-02-04 Thread Andrii Nakryiko
On Thu, Feb 4, 2021 at 8:34 PM Arnaldo Carvalho de Melo wrote: > > > > On February 4, 2021 9:01:51 PM GMT-03:00, Andrii Nakryiko > wrote: > >On Thu, Feb 4, 2021 at 2:09 PM Arnaldo Carvalho de Melo> > >wrote: > >> The v1.20 release of pahole and its friends is out, mostly > >>

Re: [PATCH v2 2/2] of: property: Add fw_devlink support for interrupts

2021-02-04 Thread Marek Szyprowski
Hi Saravana, On 04.02.2021 22:31, Saravana Kannan wrote: > On Thu, Feb 4, 2021 at 3:52 AM Marek Szyprowski > wrote: >> On 21.01.2021 23:57, Saravana Kannan wrote: >>> This allows fw_devlink to create device links between consumers of an >>> interrupt and the supplier of the interrupt. >>> >>>

[RESEND PATH] ASoC: dmaengine_pcm: add peripheral configuration

2021-02-04 Thread Shengjiu Wang
The commit e7bbb7acabf4 ("dmaengine: add peripheral configuration") adds peripheral configuration for dma_slave_config. This configuration is useful for some audio peripherals, for example, the peripheral supports multi fifos, we can let the DMA know which fifos are selected. So also add this

Re: [PATCH v3 4/4] drm_dp_cec: add MST support

2021-02-04 Thread Sam McNally
On Thu, 4 Feb 2021 at 21:42, Hans Verkuil wrote: > > On 23/09/2020 04:13, Sam McNally wrote: > > With DP v2.0 errata E5, CEC tunneling can be supported through an MST > > topology. > > > > There are some minor differences for CEC tunneling through an MST > > topology compared to CEC tunneling to

Re: [PATCH] mm/memtest: Add ARCH_USE_MEMTEST

2021-02-04 Thread Max Filippov
On Thu, Feb 4, 2021 at 8:10 PM Anshuman Khandual wrote: > > early_memtest() does not get called from all architectures. Hence enabling > CONFIG_MEMTEST and providing a valid memtest=[1..N] kernel command line > option might not trigger the memory pattern tests as would be expected in > normal

Re: [PATCH v3 04/11] iio: core: rework iio device group creation

2021-02-04 Thread Alexandru Ardelean
On Thu, Feb 4, 2021 at 7:39 PM Jonathan Cameron wrote: > > On Mon, 1 Feb 2021 16:50:58 +0200 > Alexandru Ardelean wrote: > > > Up until now, the device groups that an IIO device had were limited to 6. > > Two of these groups would account for buffer attributes (the buffer/ and > > scan_elements/

Re: [PATCH 2/2] block: avoid to drop & re-add partitions if partitions aren't changed

2021-02-04 Thread Ming Lei
On Fri, Feb 05, 2021 at 08:14:29AM +0100, Christoph Hellwig wrote: > On Fri, Feb 05, 2021 at 10:17:08AM +0800, Ming Lei wrote: > > block ioctl(BLKRRPART) always drops current partitions and adds > > partitions again, even though there isn't any change in partitions table. > > > > ioctl(BLKRRPART)

Re: [PATCH v14 6/8] mm: hugetlb: introduce nr_free_vmemmap_pages in the struct hstate

2021-02-04 Thread Miaohe Lin
On 2021/2/4 11:50, Muchun Song wrote: > All the infrastructure is ready, so we introduce nr_free_vmemmap_pages > field in the hstate to indicate how many vmemmap pages associated with > a HugeTLB page that can be freed to buddy allocator. And initialize it > in the hugetlb_vmemmap_init(). This

Re: [PATCH v14 7/8] mm: hugetlb: gather discrete indexes of tail page

2021-02-04 Thread Miaohe Lin
On 2021/2/4 11:50, Muchun Song wrote: > For HugeTLB page, there are more metadata to save in the struct page. > But the head struct page cannot meet our needs, so we have to abuse > other tail struct page to store the metadata. In order to avoid > conflicts caused by subsequent use of more tail

Re: [patch 08/12] x86/entry: Use run_sysvec_on_irqstack_cond() for XEN upcall

2021-02-04 Thread kernel test robot
Hi Thomas, I love your patch! Perhaps something to improve: [auto build test WARNING on tip/x86/asm] [also build test WARNING on tip/master linus/master tip/x86/core v5.11-rc6 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we

[PATCH 2/2] can: m_can: m_can_class_allocate_dev(): remove impossible error return judgment

2021-02-04 Thread Xulin Sun
If the previous can_net device has been successfully allocated, its private data structure is impossible to be empty, remove this redundant error return judgment. Otherwise, memory leaks for alloc_candev() will be triggered. Signed-off-by: Xulin Sun --- drivers/net/can/m_can/m_can.c | 5 -

[PATCH 1/2] can: m_can: m_can_plat_probe(): free can_net device in case probe fails

2021-02-04 Thread Xulin Sun
The can_net device is allocated through kvzalloc(), if the subsequent probe cases fail to initialize, it should free the can_net device that has been successfully allocated before. To fix below memory leaks call trace: unreferenced object 0xfc08418b (size 32768): comm "kworker/0:1", pid

Re: [PATCH v14 5/8] mm: hugetlb: add a kernel parameter hugetlb_free_vmemmap

2021-02-04 Thread Miaohe Lin
Hi: On 2021/2/4 11:50, Muchun Song wrote: > Add a kernel parameter hugetlb_free_vmemmap to enable the feature of > freeing unused vmemmap pages associated with each hugetlb page on boot. > > We disables PMD mapping of vmemmap pages for x86-64 arch when this > feature is enabled. Because

[PATCH] staging: bcm2835-audio: Replace unsafe strcpy() with strscpy()

2021-02-04 Thread Juerg Haefliger
Replace strcpy() with strscpy() in bcm2835-audio/bcm2835.c to prevent the following when loading snd-bcm2835: [ 58.480634] [ cut here ] [ 58.485321] kernel BUG at lib/string.c:1149! [ 58.489650] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP [ 58.495214] Modules

Re: [PATCH v3 1/2] dt-bindings: iommu: add bindings for sprd iommu

2021-02-04 Thread Chunyan Zhang
Hi Rob, On Fri, 5 Feb 2021 at 07:25, Rob Herring wrote: > > On Wed, Feb 03, 2021 at 05:07:26PM +0800, Chunyan Zhang wrote: > > From: Chunyan Zhang > > > > This iommu module can be used by Unisoc's multimedia devices, such as > > display, Image codec(jpeg) and a few signal processors, including

Re: [PATCH] arch:powerpc simple_write_to_buffer return check

2021-02-04 Thread Christophe Leroy
Please provide some description of the change. And please clarify the patch subject, because as far as I can see, the return is already checked allthough the check seams wrong. Le 04/02/2021 à 19:16, Mayank Suman a écrit : Signed-off-by: Mayank Suman --- arch/powerpc/kernel/eeh.c

[PATCH v3 3/3] mailbox: cmdq: add mt8192 support

2021-02-04 Thread Hsin-Yi Wang
From: Yongqiang Niu add mt8192 support Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- drivers/mailbox/mtk-cmdq-mailbox.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c index

[PATCH v3 2/3] arm64: dts: mt8192: add gce node

2021-02-04 Thread Hsin-Yi Wang
From: Yongqiang Niu add gce node for mt8192 Signed-off-by: Yongqiang Niu Signed-off-by: Hsin-Yi Wang --- arch/arm64/boot/dts/mediatek/mt8192.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8192.dtsi

[PATCH v3 1/3] dt-binding: gce: add gce header file for mt8192

2021-02-04 Thread Hsin-Yi Wang
From: Yongqiang Niu Add documentation for the mt8192 gce. Add gce header file defined the gce hardware event, subsys number and constant for mt8192. Signed-off-by: Yongqiang Niu Reviewed-by: Rob Herring Signed-off-by: Hsin-Yi Wang --- .../devicetree/bindings/mailbox/mtk-gce.txt | 7 +-

[PATCH v3 0/3] support gce on mt8192 platform

2021-02-04 Thread Hsin-Yi Wang
Change since v2: - add controy_by_sw for mt8192 Change since v1: - move out shift jump patch - remove useless patch Yongqiang Niu (3): dt-binding: gce: add gce header file for mt8192 arm64: dts: mt8192: add gce node mailbox: cmdq: add mt8192 support

Re: [PATCH 2/2] block: avoid to drop & re-add partitions if partitions aren't changed

2021-02-04 Thread Christoph Hellwig
On Fri, Feb 05, 2021 at 10:17:08AM +0800, Ming Lei wrote: > block ioctl(BLKRRPART) always drops current partitions and adds > partitions again, even though there isn't any change in partitions table. > > ioctl(BLKRRPART) may be called by systemd-udevd and some disk utilities > frequently. Err,

Re: [PATCH 18/18] arm64: apple: Add initial Mac Mini 2020 (M1) devicetree

2021-02-04 Thread Hector Martin 'marcan'
On 05/02/2021 08.08, Arnd Bergmann wrote: On Thu, Feb 4, 2021 at 10:44 PM Hector Martin 'marcan' wrote: On 05/02/2021 06.29, Arnd Bergmann wrote: On Thu, Feb 4, 2021 at 9:39 PM Hector Martin wrote: We tend to split the dts file into one file per SoC and one for the specific board. I guess

Re: [PATCH] dt-bindings: pinctrl: Group tuples in pin control properties

2021-02-04 Thread Krzysztof Kozlowski
On Thu, Feb 04, 2021 at 01:57:18PM +0100, Geert Uytterhoeven wrote: > To improve human readability and enable automatic validation, the tuples > in "pinctrl-*" properties should be grouped using angle brackets. > > Signed-off-by: Geert Uytterhoeven > --- >

[PATCH V4 2/2] power: supply: bq27xxx: Add support for BQ78Z100

2021-02-04 Thread LI Qingwu
Add support for TI BQ78Z100, I2C interface gas gauge. It provides a fully integrated safety protection and authentication for 1 to 2-series cell Li-Ion and Li-Polymer battery packs. The patch was tested with BQ78Z100 equipment. Reviewed-by: Krzysztof Kozlowski Signed-off-by: LI Qingwu ---

[PATCH V4 0/2] power: bq27xxx: add bq78z100

2021-02-04 Thread LI Qingwu
Changes in V4: Correct the wrong part number in the subject, bq78z100 instead of bq78z10. LI Qingwu (2): dt-bindings: power: bq27xxx: add bq78z100 power: supply: bq27xxx: Add support for BQ78Z100 .../bindings/power/supply/bq27xxx.yaml| 1 + drivers/power/supply/bq27xxx_battery.c

[PATCH V4 1/2] dt-bindings: power: bq27xxx: add bq78z100

2021-02-04 Thread LI Qingwu
Add bindings for TI BQ78Z100. An I2C interface gas gauge. It provides a fully integrated safety protection and authentication for 1 to 2-series cell Li-Ion and Li-Polymer battery packs. Acked-by: Rob Herring Signed-off-by: LI Qingwu ---

Re: [PATCH v3 01/11] docs: ioctl-number.rst: reserve IIO subsystem ioctl() space

2021-02-04 Thread Alexandru Ardelean
On Thu, Feb 4, 2021 at 7:13 PM Jonathan Cameron wrote: > > On Mon, 1 Feb 2021 16:50:55 +0200 > Alexandru Ardelean wrote: > > > Currently, only the 'i' 0x90 ioctl() actually exists and is defined in > > 'uapi/linux/iio/events.h'. > > > > It's the IIO_GET_EVENT_FD_IOCTL, which is used to retrieve

[PATCH 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg

2021-02-04 Thread Shengjiu Wang
This is a dummy cpu dai driver for rpmsg audio use case, which is mainly used for getting the user's configuration from devicetree and configure the clocks which is used by Cortex-M core. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/Kconfig | 7 ++ sound/soc/fsl/Makefile| 2 +

[PATCH 4/7] ASoC: imx-audio-rpmsg: Add rpmsg_driver for audio channel

2021-02-04 Thread Shengjiu Wang
This driver is used to accept the message from rpmsg audio channel, and if this driver is probed, it will help to register the platform driver, the platform driver will use this audio channel to send and receive message to and from Cortex-M core. Signed-off-by: Shengjiu Wang ---

[PATCH 5/7] ASoC: imx-pcm-rpmsg: Add platform driver for audio base on rpmsg

2021-02-04 Thread Shengjiu Wang
platform driver base on rpmsg is the interface for sending and receiving rpmsg to and from M core. It will tell the Cortex-M core sound format/rate/channel, where is the data buffer, where is the period size, when to start, when to stop and when suspend or resume happen, each this behavior there

[PATCH 7/7] ASoC: dt-bindings: imx-rpmsg: Add binding doc for rpmsg machine driver

2021-02-04 Thread Shengjiu Wang
Imx-rpmsg is a new added machine driver for supporting audio on Cortex-M core. The Cortex-M core will control the audio interface, DMA and audio codec, setup the pipeline, the audio driver on Cortex-A core side is just to communitcate with M core, it is a virtual sound card and don't touch the

[PATCH 3/7] ASoC: dt-bindings: fsl_rpmsg: Add binding doc for rpmsg cpu dai driver

2021-02-04 Thread Shengjiu Wang
fsl_rpmsg cpu dai driver is dummy driver, which is mainly used for getting the user's configuration from device tree and configure the clocks which is used by Cortex-M core. So in this document define the needed property. Signed-off-by: Shengjiu Wang ---

[PATCH 6/7] ASoC: imx-rpmsg: Add machine driver for audio base on rpmsg

2021-02-04 Thread Shengjiu Wang
The platform device is not registered by device tree or cpu dai driver, it is registered by the rpmsg channel, So add a dedicated machine driver to handle this case. Signed-off-by: Shengjiu Wang --- sound/soc/fsl/Kconfig | 12 sound/soc/fsl/Makefile| 2 +

[PATCH 0/7] Add audio driver base on rpmsg on i.MX platform

2021-02-04 Thread Shengjiu Wang
On Asymmetric multiprocessor, there is Cortex-A core and Cortex-M core, Linux is running on A core, RTOS is running on M core. The audio hardware device can be controlled by Cortex-M device, So audio playback/capture can be handled by M core. Rpmsg is the interface for sending and receiving msg

[PATCH 1/7] ASoC: soc-component: Add snd_soc_pcm_component_ack

2021-02-04 Thread Shengjiu Wang
Add snd_soc_pcm_component_ack back, which can be used to get updated buffer pointer in platform driver. On Asymmetric multiprocessor, this pointer can be sent to Cortex-M core for audio processing. Signed-off-by: Shengjiu Wang --- include/sound/soc-component.h | 3 +++

Re: [PATCH v1 2/2] cpufreq: ACPI: Update arch scale-invariance max perf ratio if CPPC is not there

2021-02-04 Thread Giovanni Gherdovich
On Thu, 2021-02-04 at 18:34 +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > If the maximum performance level taken for computing the > arch_max_freq_ratio value used in the x86 scale-invariance code is > higher than the one corresponding to the cpuinfo.max_freq value > coming from

Re: [PATCH] RISC-V: Add a non-void return for sbi v02 functions

2021-02-04 Thread Palmer Dabbelt
On Wed, 03 Feb 2021 21:26:43 PST (-0800), Atish Patra wrote: SBI v0.2 functions can return an error code from SBI implementation. We are already processing the SBI error code and coverts it to the Linux error code. Propagate to the error code to the caller as well. As of now, kvm is the only

Re: [PATCH] selftests/vDSO: fix ABI selftest on riscv

2021-02-04 Thread Palmer Dabbelt
On Thu, 04 Feb 2021 06:50:42 PST (-0800), tklau...@distanz.ch wrote: Only older versions of the RISC-V GCC toolchain define __riscv__. Check for __riscv as well, which is used by newer GCC toolchains. Also set VDSO_32BIT based on __riscv_xlen. Before (on riscv64): $ ./vdso_test_abi [vDSO

Re: [PATCH v1 1/2] cpufreq: ACPI: Extend frequency tables to cover boost frequencies

2021-02-04 Thread Giovanni Gherdovich
On Thu, 2021-02-04 at 18:25 +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > A severe performance regression on AMD EPYC processors when using > the schedutil scaling governor was discovered by Phoronix.com and > attributed to the following commits: > > 41ea667227ba ("x86,

Re: [PATCH v2 1/1] powerpc/kvm: Save Timebase Offset to fix sched_clock() while running guest code.

2021-02-04 Thread Leonardo Bras
Hey Nick, thanks for reviewing :) On Fri, 2021-02-05 at 16:28 +1000, Nicholas Piggin wrote: > Excerpts from Leonardo Bras's message of February 5, 2021 4:06 pm: > > Before guest entry, TBU40 register is changed to reflect guest timebase. > > After exitting guest, the register is reverted to it's

Re: [PATCH -next] RISCV: Add some depends for NUMA

2021-02-04 Thread Palmer Dabbelt
On Wed, 03 Feb 2021 06:23:43 PST (-0800), wangkefeng.w...@huawei.com wrote: The numa feature is useless for riscv32 platform(MAXPHYSMEM_1GB if 32bit), I'm not convinced of that. There's no reason NUMA shouldn't work on 32-bit, it doesn't depend on having a large amount of memory just having

[PATCH] ssb: Use true and false for bool variable

2021-02-04 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./include/linux/ssb/ssb_driver_gige.h:89:8-9: WARNING: return of 0/1 in function 'ssb_gige_one_dma_at_once' with return type bool. ./include/linux/ssb/ssb_driver_gige.h:79:8-9: WARNING: return of 0/1 in function 'ssb_gige_have_roboswitch' with return type

[PATCH v5 1/2] nbd: Fix NULL pointer in flush_workqueue

2021-02-04 Thread Sun Ke
Open /dev/nbdX first, the config_refs will be 1 and the pointers in nbd_device are still null. Disconnect /dev/nbdX, then reference a null recv_workq. The protection by config_refs in nbd_genl_disconnect is useless. [ 656.366194] BUG: kernel NULL pointer dereference, address: 0020 [

[PATCH v5 2/2] nbd: share nbd_put and return by goto put_nbd

2021-02-04 Thread Sun Ke
Replace the following two statements by the statement “goto put_nbd;” nbd_put(nbd); return 0; Suggested-by: Markus Elfring Signed-off-by: Sun Ke --- drivers/block/nbd.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/block/nbd.c

[PATCH v5 0/2] fix a NULL pointer bug and simplify the code

2021-02-04 Thread Sun Ke
v5: Adjust the title and add “Suggested-by”. v4: Share exception handling code for if branches and move put_nbd adjustment to a separate patch. v3: Do not use unlock and add put_nbd. v2: Use jump target unlock. Sun Ke (2): nbd: Fix NULL pointer in flush_workqueue nbd: share nbd_put

Re: Linux 5.11-rc5

2021-02-04 Thread Greg KH
On Thu, Feb 04, 2021 at 10:32:56AM -0800, Linus Torvalds wrote: > On Thu, Feb 4, 2021 at 10:19 AM Mike Rapoport wrote: > > > > On Mon, Jan 25, 2021 at 12:49:39PM -0800, Linus Torvalds wrote: > > > > > > Mike: should we perhaps revert the first patch too (commit > > > bde9cfa3afe4: "x86/setup:

Re: Kernel version numbers after 4.9.255 and 4.4.255

2021-02-04 Thread Greg KH
On Thu, Feb 04, 2021 at 09:19:33PM +0100, Christoph Biedl wrote: > David Laight wrote... > > > A full wrap might catch checks for less than (say) 4.4.2 which > > might be present to avoid very early versions. > > So sticking at 255 or wrapping onto (say) 128 to 255 might be better. > > Hitting

Re: [PATCH v3 2/2] tpm: in tpm2_del_space check if ops pointer is still valid

2021-02-04 Thread Greg KH
On Fri, Feb 05, 2021 at 12:50:43AM +0100, Lino Sanfilippo wrote: > From: Lino Sanfilippo > > In tpm2_del_space() chip->ops is used for flushing the sessions. However > this function may be called after tpm_chip_unregister() which sets > the chip->ops pointer to NULL. > Avoid a possible NULL

[PATCH] perf record: Fix continue profiling after draining the buffer

2021-02-04 Thread Yang Jihong
commit da231338ec9c098707c8a1e4d8a50e2400e2fe17 uses eventfd to solve rare race where the setting and checking of 'done' which add done_fd to pollfd. When draining buffer, revents of done_fd is 0 and evlist__filter_pollfd function returns a non-zero value. As a result, perf record does not stop

Re: [PATCH v3 1/2] tpm: fix reference counting for struct tpm_chip

2021-02-04 Thread Greg KH
On Fri, Feb 05, 2021 at 12:50:42AM +0100, Lino Sanfilippo wrote: > From: Lino Sanfilippo > > The following sequence of operations results in a refcount warning: > > 1. Open device /dev/tpmrm > 2. Remove module tpm_tis_spi > 3. Write a TPM command to the file descriptor opened at step 1. > >

Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-04 Thread Kai-Heng Feng
On Fri, Feb 5, 2021 at 2:45 PM Aaron Ma wrote: > > > On 2/5/21 12:27 PM, Kai-Heng Feng wrote: > > Can you please test the following patch, which should address the root > > cause: > > https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furq...@google.com/ > > > > It also helps another

Re: [PATCH][next] net/mlx5e: Fix spelling mistake "Unknouwn" -> "Unknown"

2021-02-04 Thread Saeed Mahameed
On Wed, 2021-02-03 at 14:57 -0800, Jesse Brandeburg wrote: > Colin King wrote: > > > From: Colin Ian King > > > > There is a spelling mistake in a netdev_warn message. Fix it. > > > > Signed-off-by: Colin Ian King > > Trivial patch, looks fine! > > Reviewed-by: Jesse Brandeburg Applied to

Re: [PATCH][next] net/mlx5e: Fix spelling mistake "channles" -> "channels"

2021-02-04 Thread Saeed Mahameed
On Thu, 2021-02-04 at 09:32 +, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a netdev_warn message. Fix it. > > Signed-off-by: Colin Ian King > --- Applied to net-next-mlx5 thanks!

Re: [PATCH] xhci-pci: Set AMD Renoir USB controller to D3 when shutdown

2021-02-04 Thread Aaron Ma
On 2/5/21 12:27 PM, Kai-Heng Feng wrote: Can you please test the following patch, which should address the root cause: https://lore.kernel.org/linux-acpi/20201201213019.1558738-1-furq...@google.com/ It also helps another AMD laptop on S5:

Re: [PATCH 0/6] Support second Image Signal Processor on rk3399

2021-02-04 Thread Sebastian Fricke
Hey Heiko, On 03.02.2021 20:54, Heiko Stübner wrote: Hi Sebastian, Am Mittwoch, 3. Februar 2021, 19:14:22 CET schrieb Sebastian Fricke: Hey Heiko, I have tested your patch set on my nanoPC-T4, here is a complete log with: - relevant kernel log entries - system information - media ctl output

Re: [PATCH] drm/msm: Fix legacy relocs path

2021-02-04 Thread Akhil P Oommen
On 2/5/2021 4:26 AM, Rob Clark wrote: From: Rob Clark In moving code around, we ended up using the same pointer to copy_from_user() the relocs tables as we used for the cmd table entry, which is clearly not right. This went unnoticed because modern mesa on non-ancent kernels does not actually

Re: Small student project idea on appropriate integration trees in MAINTAINERS

2021-02-04 Thread Lukas Bulwahn
On Fri, Jan 29, 2021 at 12:54 AM Jonathan Corbet wrote: > > On Fri, 22 Jan 2021 09:22:24 +0100 > Lukas Bulwahn wrote: > > > In this project, we can make use of: > > > > - gitdm [git://git.lwn.net/gitdm.git]: gitdm includes some scripts to > > parse MAINTAINERS and obtain the integration tree

Re: [PATCH] mm: cma: support sysfs

2021-02-04 Thread John Hubbard
On 2/4/21 10:24 PM, Minchan Kim wrote: On Thu, Feb 04, 2021 at 09:49:54PM -0800, John Hubbard wrote: On 2/4/21 9:17 PM, Minchan Kim wrote: ... # cat vmstat | grep -i cma nr_free_cma 261718 # cat meminfo | grep -i cma CmaTotal:1048576 kB CmaFree: 1046872 kB OK, given that CMA

ERROR: modpost: "ioremap" undefined!

2021-02-04 Thread kernel test robot
Hi Nick, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 61556703b610a104de324e4f061dc6cf7b218b46 commit: 1e1b6d63d6340764e00356873e5794225a2a03ea lib/string.c: implement stpcpy date: 4 months ago config:

[PATCH] selftests: breakpoints: Use correct error messages in breakpoint_test_arm64.c

2021-02-04 Thread Tiezhu Yang
When call ptrace(PTRACE_CONT, ...) failed, use correct error messages. Signed-off-by: Tiezhu Yang --- tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/breakpoints/breakpoint_test_arm64.c

Re: [PATCH 2/2] mmc: mmc_test: use erase_arg for mmc_erase command

2021-02-04 Thread Adrian Hunter
On 4/02/21 2:05 pm, yann.gaut...@foss.st.com wrote: > From: Yann Gautier > > Since [1], the erase argument for mmc_erase() function is saved in > erase_arg field of card structure. It is preferable to use it instead of > hard-coded MMC_SECURE_ERASE_ARG, which from eMMC 4.51 spec is not >

[PATCH] mm: memcontrol: remove rcu_read_lock from get_mem_cgroup_from_page

2021-02-04 Thread Muchun Song
The get_mem_cgroup_from_page() is called under page lock, so the page memcg cannot be changed under us. Also, css_get is enough because page has a reference to the memcg. If we really want to make the get_mem_cgroup_from_page() suitable for arbitrary page, we should use page_memcg_rcu() instead

[PATCH] selftests/bpf: Simplify the calculation of variables

2021-02-04 Thread Jiapeng Chong
Fix the following coccicheck warnings: ./tools/testing/selftests/bpf/xdpxceiver.c:954:28-30: WARNING !A || A && B is equivalent to !A || B. ./tools/testing/selftests/bpf/xdpxceiver.c:932:28-30: WARNING !A || A && B is equivalent to !A || B. ./tools/testing/selftests/bpf/xdpxceiver.c:909:28-30:

Re: [PATCH v2 1/1] powerpc/kvm: Save Timebase Offset to fix sched_clock() while running guest code.

2021-02-04 Thread Nicholas Piggin
Excerpts from Leonardo Bras's message of February 5, 2021 4:06 pm: > Before guest entry, TBU40 register is changed to reflect guest timebase. > After exitting guest, the register is reverted to it's original value. > > If one tries to get the timestamp from host between those changes, it > will

[PATCH] net: core: Clean code style issues in `neighbour.c`

2021-02-04 Thread Zheng Yongjun
Do code format alignment to clean code style issues. Signed-off-by: Zheng Yongjun --- net/core/neighbour.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 9500d28a43b0..a742c918a09b 100644 ---

Re: [PATCH] mm: cma: support sysfs

2021-02-04 Thread Minchan Kim
On Thu, Feb 04, 2021 at 09:49:54PM -0800, John Hubbard wrote: > On 2/4/21 9:17 PM, Minchan Kim wrote: > ... > > > > > Presumably, having the source code, you can easily deduce that a > > > > > bluetooth > > > > > allocation failure goes directly to a CMA allocation failure, right? > > > > > >

[PATCH] mm: memcontrol: fix missing wakeup oom task

2021-02-04 Thread Muchun Song
We call memcg_oom_recover() in the uncharge_batch() to wakeup OOM task when page uncharged, but for the slab pages, we do not do this when page uncharged. When we drain per cpu stock, we also should do this. The memcg_oom_recover() is small, so make it inline. And the parameter of memcg cannot be

Re: [PATCH v5 5/5] arm64: dts: mt8192: add pwrap node

2021-02-04 Thread kernel test robot
/kernel/git/robh/linux.git for-next config: arm64-randconfig-r021-20210204 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin

Re: [PATCH] arch:powerpc simple_write_to_buffer return check

2021-02-04 Thread Mayank Suman
On 05/02/21 4:05 am, Oliver O'Halloran wrote: > On Fri, Feb 5, 2021 at 5:17 AM Mayank Suman wrote: >> >> Signed-off-by: Mayank Suman > > commit messages aren't optional Sorry. I will include the commit message in PATCH v2. > >> --- >> arch/powerpc/kernel/eeh.c| 8

Re: [PATCH v3 3/3] scsi: ufs: Fix wrong Task Tag used in task management request UPIUs

2021-02-04 Thread Can Guo
On 2021-02-01 10:39, Bart Van Assche wrote: On 1/28/21 9:57 PM, Can Guo wrote: On 2021-01-29 11:15, Bart Van Assche wrote: On 1/27/21 8:16 PM, Can Guo wrote: In __ufshcd_issue_tm_cmd(), it is not right to use hba->nutrs + req->tag as the Task Tag in one TMR UPIU. Directly use req->tag as the

Re: [PATCH v2 2/3] fs/efs: Correct spacing after C keywords

2021-02-04 Thread Joe Perches
On Thu, 2021-02-04 at 21:14 -0800, Amy Parker wrote: > In EFS code, some C keywords (most commonly 'for') do not have spaces > before their instructions, such as for() vs for (). The kernel style > guide indicates that these should be of the latter variant. This patch > updates them

[PATCH v2 1/1] powerpc/kvm: Save Timebase Offset to fix sched_clock() while running guest code.

2021-02-04 Thread Leonardo Bras
Before guest entry, TBU40 register is changed to reflect guest timebase. After exitting guest, the register is reverted to it's original value. If one tries to get the timestamp from host between those changes, it will present an incorrect value. An example would be trying to add a tracepoint in

Re: [PATCH v2 1/3] fs/efs: Use correct brace styling for statements

2021-02-04 Thread Joe Perches
On Thu, 2021-02-04 at 21:14 -0800, Amy Parker wrote: > Many single-line statements have unnecessary braces, and some statement > pairs have mismatched braces. This is a clear violation of the kernel > style guide, which mandates that single line statements have no braces > and that pairs with

Re: [PATCH v3 0/2] KVM: x86/mmu: Skip mmu_notifier changes when possible

2021-02-04 Thread David Stevens
These patches might be responsible for some instability in one of our stress tests. I'll send an update once I figure out what's going on. Thanks, David On Thu, Jan 28, 2021 at 9:48 PM Paolo Bonzini wrote: > > On 28/01/21 07:05, David Stevens wrote: > > These patches reduce how often

[PATCH v1] tpm_tis_spi_main: set cs_change = 0 when timesout

2021-02-04 Thread wanghongzhe
when i reach TPM_RETRY, the cs cannot change back to 'high'. So the TPM chips thinks this communication is not over. And next times communication cannot be effective because the communications mixed up with the last time. Signed-off-by: wanghongzhe --- drivers/char/tpm/tpm_tis_spi_main.c | 12

Re: [PATCH] mm: cma: support sysfs

2021-02-04 Thread John Hubbard
On 2/4/21 9:17 PM, Minchan Kim wrote: ... Presumably, having the source code, you can easily deduce that a bluetooth allocation failure goes directly to a CMA allocation failure, right? Still wondering about this... It would work if we have full source code and stack are not complicated for

Re: [PATCH v2 7/7] Documentation: coresight: Add PID tracing description

2021-02-04 Thread Leo Yan
On Thu, Feb 04, 2021 at 12:14:12PM +, Mike Leach wrote: [...] > > >>> +To support tracing PID for the kernel runs at different exception > > >>> levels, > > >>> +the PMU formats are defined as follow: > > >>> + > > >>> + "contextid1": Available on both EL1 kernel and EL2 kernel. When the

[PATCH] drivers: scsi: lpfc: Mundane spelling and sentence construction fixes throughout the file

2021-02-04 Thread Bhaskar Chowdhury
Few spellings and sentence construction done throughout the file. Signed-off-by: Bhaskar Chowdhury --- drivers/scsi/lpfc/lpfc_init.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c

Re: [PATCH RESEND v2 4/5] iommu/tegra-smmu: Rework tegra_smmu_probe_device()

2021-02-04 Thread Nicolin Chen
Hi Guillaume, On Thu, Feb 04, 2021 at 11:10:15AM +, Guillaume Tucker wrote: > Hi Nicolin, > > A regression was detected by kernelci.org in IGT's drm_read tests > on mainline, it was first seen on 17th December 2020. You can > find some details here: > >

Re: [PATCH] mm: cma: support sysfs

2021-02-04 Thread Minchan Kim
On Fri, Feb 05, 2021 at 02:55:26AM +, Matthew Wilcox wrote: > On Wed, Feb 03, 2021 at 07:50:01AM -0800, Minchan Kim wrote: > > +++ b/mm/Makefile > > @@ -106,6 +106,7 @@ obj-$(CONFIG_ZSMALLOC) += zsmalloc.o > > obj-$(CONFIG_Z3FOLD) += z3fold.o > > obj-$(CONFIG_GENERIC_EARLY_IOREMAP) +=

Re: [PATCH net-next 7/7] net: marvell: prestera: fix port event handling on init

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 18:54:58 +0200 Vadym Kochan wrote: > For some reason there might be a crash during ports creation if port > events are handling at the same time because fw may send initial > port event with down state. > > The crash points to cancel_delayed_work() which is called when port

Re: [PATCH v3 2/4] drm_dp_mst_topology: use correct AUX channel

2021-02-04 Thread Sam McNally
On Thu, 4 Feb 2021 at 21:19, Hans Verkuil wrote: > > On 01/02/2021 23:13, Ville Syrjälä wrote: > > On Wed, Sep 23, 2020 at 12:13:53PM +1000, Sam McNally wrote: > >> From: Hans Verkuil > >> > >> For adapters behind an MST hub use the correct AUX channel. > >> > >> Signed-off-by: Hans Verkuil >

Re: [PATCH net-next 5/7] net: marvell: prestera: add LAG support

2021-02-04 Thread Jakub Kicinski
On Wed, 3 Feb 2021 18:54:56 +0200 Vadym Kochan wrote: > From: Serhiy Boiko > > The following features are supported: > > - LAG basic operations > - create/delete LAG > - add/remove a member to LAG > - enable/disable member in LAG > - LAG Bridge support > -

Re: [PATCH] mm: cma: support sysfs

2021-02-04 Thread Minchan Kim
On Thu, Feb 04, 2021 at 06:52:01PM -0800, John Hubbard wrote: > On 2/4/21 5:44 PM, Minchan Kim wrote: > > On Thu, Feb 04, 2021 at 04:24:20PM -0800, John Hubbard wrote: > > > On 2/4/21 4:12 PM, Minchan Kim wrote: > > > ... > > > > > > Then, how to know how often CMA API failed? > > > > > > > > > >

[PATCH v2 3/3] fs/efs: Fix line breakage for C keywords

2021-02-04 Thread Amy Parker
Some statements - such as if statements - are not broken into their lines correctly. For example, some are expressed on a single line. Single line if statements are expressely prohibited by the style guide. This patch corrects these violations. Signed-off-by: Amy Parker --- fs/efs/inode.c |

[PATCH v2 0/3] fs/efs: Follow kernel style guide

2021-02-04 Thread Amy Parker
As the EFS driver is old and non-maintained, many kernel style guide rules have not been followed, and their violations have not been noticed. This patchset corrects those violations. v2: - Corrected commit message line breaking v1: - Fixed brace styling - Corrected C keyword spacing -

Re: [PATCH 1/3] fs/efs: Use correct brace styling for statements

2021-02-04 Thread Amy Parker
On Thu, Feb 4, 2021 at 9:09 PM Chaitanya Kulkarni wrote: > > On 2/4/21 21:01, Amy Parker wrote: > >> Commit message is too long. Follow the style present in the tree. > > Are you referring to the per-line length? That was supposed to have > > been broken up, my apologies. Or is it the overall

[PATCH v2 2/3] fs/efs: Correct spacing after C keywords

2021-02-04 Thread Amy Parker
In EFS code, some C keywords (most commonly 'for') do not have spaces before their instructions, such as for() vs for (). The kernel style guide indicates that these should be of the latter variant. This patch updates them accordingly. Signed-off-by: Amy Parker --- fs/efs/inode.c | 8

[PATCH v2 1/3] fs/efs: Use correct brace styling for statements

2021-02-04 Thread Amy Parker
Many single-line statements have unnecessary braces, and some statement pairs have mismatched braces. This is a clear violation of the kernel style guide, which mandates that single line statements have no braces and that pairs with at least one multi-line block maintain their braces. This

Re: [PATCH v2 4/4] hugetlb: Do early cow when page pinned on src mm

2021-02-04 Thread Mike Kravetz
On 2/4/21 5:43 PM, Peter Xu wrote: > On Thu, Feb 04, 2021 at 03:25:37PM -0800, Mike Kravetz wrote: >> On 2/4/21 6:50 AM, Peter Xu wrote: >>> This is the last missing piece of the COW-during-fork effort when there're >>> pinned pages found. One can reference 70e806e4e645 ("mm: Do early cow for >>>

  1   2   3   4   5   6   7   8   9   10   >