[PATCH] mm/hugetlb: remove redundant reservation check condition in alloc_huge_page()

2021-02-09 Thread Miaohe Lin
If there is no reservation corresponding to a vma, map_chg is always != 0, i.e. we can not meet the condition where a vma does not have reservation while map_chg = 0. Signed-off-by: Miaohe Lin --- mm/hugetlb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/hugetlb.c

[PATCH v3] mm: cma: support sysfs

2021-02-09 Thread Minchan Kim
Since CMA is getting used more widely, it's more important to keep monitoring CMA statistics for system health since it's directly related to user experience. This patch introduces sysfs statistics for CMA, in order to provide some basic monitoring of the CMA allocator. * the number of CMA page

[PATCH -next] soc: ti: knav_qmss_queue: Make symbol 'knav_acc_firmwares' static

2021-02-09 Thread Wei Yongjun
The sparse tool complains as follows: drivers/soc/ti/knav_qmss_queue.c:70:12: warning: symbol 'knav_acc_firmwares' was not declared. Should it be static? This symbol is not used outside of knav_qmss_queue.c, so this commit marks it 'static const char * const'. Reported-by: Hulk Robot

Re: [PATCH] ubsan: remove overflow checks

2021-02-09 Thread Peter Zijlstra
On Tue, Feb 09, 2021 at 04:19:03PM -0800, Kees Cook wrote: > On Wed, Feb 10, 2021 at 02:23:48AM +0300, Andrey Ryabinin wrote: > > Since GCC 8.0 -fsanitize=signed-integer-overflow doesn't work with -fwrapv. > > -fwrapv makes signed overflows defines and GCC essentially disables > > ubsan checks. On

RE: [PATCH v2 0/9] Introduce vfio-pci-core subsystem

2021-02-09 Thread Tian, Kevin
Hi, Max, > From: Max Gurtovoy > Sent: Tuesday, February 2, 2021 12:28 AM > > Hi Alex and Cornelia, > > This series split the vfio_pci driver into 2 parts: pci driver and a > subsystem driver that will also be library of code. The pci driver, > vfio_pci.ko will be used as before and it will

Re: [PATCH v2] mm: cma: support sysfs

2021-02-09 Thread John Hubbard
On 2/9/21 11:26 PM, Greg KH wrote: ... I just am not especially happy about the inability to do natural, efficient things here, such as use a statically allocated set of things with sysfs. And I remain convinced that the above is not "improper"; it's a reasonable step, given the limitations of

Re: [PATCH] sched/autogroup: Use true and false for bool variable

2021-02-09 Thread Peter Zijlstra
On Wed, Feb 10, 2021 at 11:46:25AM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: Please fix your robot or find yourself in the 'special' mailbox. 2b076054e524 ("remove boolinit.cocci")

[PATCH v2 0/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-09 Thread Drew Fustini
This series first converts the debugfs files in the pinctrl subsystem to octal permissions and then adds a new debug file "pinmux-select". Function name and group name can be written to "pinmux-select" which will cause the function and group to be activated on the pin controller. Notes for PATCH

[PATCH v2 1/2] pinctrl: use to octal permissions for debugfs files

2021-02-09 Thread Drew Fustini
Switch over pinctrl debugfs files to use octal permissions as they are preferred over symbolic permissions. Refer to commit f90774e1fd27 ("checkpatch: look for symbolic permissions and suggest octal instead"). Signed-off-by: Drew Fustini --- drivers/pinctrl/core.c| 6 +++---

[PATCH v2 2/2] pinctrl: pinmux: Add pinmux-select debugfs file

2021-02-09 Thread Drew Fustini
Add "pinmux-select" to debugfs which will activate a function and group when 2 integers " " are written to the file. The write operation pinmux_select() handles this by checking if fsel and gsel are valid selectors and then calling ops->set_mux(). The existing "pinmux-functions" debugfs file

Re: [PATCH] dmaengine: ti: k3-udma: Fix NULL pointer dereference error

2021-02-09 Thread Péter Ujfalusi
Hi Kishon, On 2/9/21 2:45 PM, Kishon Vijay Abraham I wrote: > Hi Peter, > > On 09/02/21 5:53 pm, Péter Ujfalusi wrote: >> Hi Kishon, >> >> On 2/9/21 11:00 AM, Kishon Vijay Abraham I wrote: >>> bcdma_get_*() and udma_get_*() checks if bchan/rchan/tchan/rflow is >>> already allocated by checking

[PATCH -next] soc: mediatek: Make symbol 'mtk_mutex_driver' static

2021-02-09 Thread Wei Yongjun
The sparse tool complains as follows: drivers/soc/mediatek/mtk-mutex.c:464:24: warning: symbol 'mtk_mutex_driver' was not declared. Should it be static? This symbol is not used outside of mtk-mutex.c, so this commit marks it static. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun ---

[PATCH -next] mfd: arizona: Make some symbols static

2021-02-09 Thread Wei Yongjun
The sparse tool complains as follows: drivers/mfd/arizona-spi.c:28:31: warning: symbol 'reset_gpios' was not declared. Should it be static? drivers/mfd/arizona-spi.c:29:31: warning: symbol 'ldoena_gpios' was not declared. Should it be static? Those symbols are not used outside of

[PATCH -next] drm/rockchip: cdn-dp: Mark cdn_dp_resume as __maybe_unused

2021-02-09 Thread Wei Yongjun
The function cdn_dp_resume() may have no callers depending on configuration, so it must be marked __maybe_unused to avoid harmless warning: drivers/gpu/drm/rockchip/cdn-dp-core.c:1124:12: warning: 'cdn_dp_resume' defined but not used [-Wunused-function] 1124 | static int cdn_dp_resume(struct

Re: [PATCH v2] Drivers: staging: most: sound: Fixed styling issue.

2021-02-09 Thread Greg KH
On Wed, Feb 10, 2021 at 06:30:45AM +0530, Mukul Mehar wrote: > This patch fixes a warning, of the line ending with a '(', > generated by checkpatch.pl. > > Signed-off-by: Mukul Mehar > --- > Changes since v1: > - Fixed indentation. > --- > drivers/staging/most/sound/sound.c | 6 +++--- > 1

[PATCH] sign-file: add openssl engine support

2021-02-09 Thread Yang Song
Use a customized signature service supported by openssl engine to sign the kernel module. Add command line parameters that support engine for sign-file to use the customized openssl engine service to sign kernel modules. Signed-off-by: Yang Song --- scripts/sign-file.c | 65

Re: [PATCH 0/3] drm/ttm: constify static vm_operations_structs

2021-02-09 Thread Christian König
Reviewed-by: Christian König for the series. Am 10.02.21 um 00:48 schrieb Rikard Falkeborn: Constify a few static vm_operations_struct that are never modified. Their only usage is to assign their address to the vm_ops field in the vm_area_struct, which is a pointer to const

[PATCH -next] NTB: Drop kfree for memory allocated with devm_kzalloc

2021-02-09 Thread Wei Yongjun
It's not necessary to free memory allocated with devm_kzalloc and using kfree leads to a double free. Fixes: 363baf7d6051 ("NTB: Add support for EPF PCI-Express Non-Transparent Bridge") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/ntb/hw/epf/ntb_hw_epf.c | 1 - 1 file

Re: [PATCH] Documentation: Replace lkml.org links with lore

2021-02-09 Thread Joe Perches
On Tue, 2021-02-09 at 23:28 -0800, Kees Cook wrote: > On Sun, Jan 10, 2021 at 12:41:44PM -0800, Joe Perches wrote: > > Replace the lkml.org links with lore to better use a single source > > that's more likely to stay available long-term. > > What's the best way to teach checkpatch about this? I

Re: [PATCH] rtlwifi: rtl8821ae: phy: Simplify bool comparison

2021-02-09 Thread Kalle Valo
Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8821ae/phy.c:3853:7-17: > WARNING: Comparison of 0/1 to bool variable. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Patch applied to wireless-drivers-next.git, thanks.

Re: [PATCH] rtlwifi: rtl8192se: Simplify bool comparison

2021-02-09 Thread Kalle Valo
Jiapeng Chong wrote: > Fix the follow coccicheck warnings: > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27: > WARNING: Comparison of 0/1 to bool variable. > > ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26: > WARNING: Comparison of 0/1 to bool variable. >

Re: [PATCH v2] nvme: Add 48-bit DMA address quirk for Amazon NVMe controllers

2021-02-09 Thread Christoph Hellwig
On Wed, Feb 10, 2021 at 01:39:42AM +0100, Filippo Sironi wrote: > Amazon NVMe controllers do not support 64-bit DMA addresses; they are > limited to 48-bit DMA addresses. Let's add a quirk to ensure that we > make use of 48-bit DMA addresses to avoid misbehavior. This should probably say some,

Re: [PATCH 1/4] perf/core: Add support to exclude kernel mode instruction tracing

2021-02-09 Thread Sai Prakash Ranjan
Hi Peter, On 2021-02-02 11:41, Sai Prakash Ranjan wrote: Hi Peter, On 2021-02-01 19:11, Peter Zijlstra wrote: On Mon, Feb 01, 2021 at 01:11:04PM +0530, Sai Prakash Ranjan wrote: Ok I suppose you mean CONFIG_SECURITY_LOCKDOWN_LSM? But I don't see how this new config has to depend on that?

Re: [PATCH] staging: rtl8723bs: fix block comments alignment

2021-02-09 Thread karthek
On Wed, Feb 10, 2021 at 10:27:17AM +0300, Dan Carpenter wrote: > On Wed, Feb 10, 2021 at 12:23:17AM +0530, karthik alapati wrote: > > fix checkpatch.pl warning for "block comments should align the * on each > > line" > > > > Signed-off-by: karthik alapati > > --- > >

Re: [PATCH] Documentation: Replace lkml.org links with lore

2021-02-09 Thread Kees Cook
On Sun, Jan 10, 2021 at 12:41:44PM -0800, Joe Perches wrote: > Replace the lkml.org links with lore to better use a single source > that's more likely to stay available long-term. What's the best way to teach checkpatch about this? I couldn't find the right place to do it. (And more generally,

Re: [PATCH v2 01/14] x86/fault: Fix AMD erratum #91 errata fixup for user code

2021-02-09 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH v2] mm: cma: support sysfs

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 11:16:07PM -0800, John Hubbard wrote: > On 2/9/21 11:12 PM, Minchan Kim wrote: > ... > > > > Agreed. How about this for the warning part? > > > > > > > > + > > > > +/* > > > > + * note: kobj_type should provide a release function to free > > > > dynamically > > > > + *

Re: [PATCH 0/4] crypto: hisilicon - some updates to adapt Kunpeng930

2021-02-09 Thread Herbert Xu
On Thu, Feb 04, 2021 at 04:59:32PM +0800, Hui Tang wrote: > 1.Update clusters number for both Kunpeng920 and Kunpeng930. > 2.Some bugfixs only on Kunpeng920, so added hardware version wrap. > 3.Fix use of 'dma_map_single'. > 4.Fix PASID on Kunpeng930. > > Hui Tang (2): > crypto: hisilicon/hpre

Re: [ANNOUNCE] exfatprogs-1.1.0 version released

2021-02-09 Thread Sedat Dilek
On Wed, Feb 10, 2021 at 5:51 AM Namjae Jeon wrote: > > Hope Sven will do a new release for Debian. > > ( Note that Debian/bullseye release plans "Milestone 2" this Friday, > > February 12th (see [1] > "Key > > release dates" > "[2021-Feb-12] Soft Freeze"). Dunno which impact this > > might

Re: [PATCH] crypto: hisilicon/hpre - enable Elliptic curve cryptography

2021-02-09 Thread Herbert Xu
On Thu, Feb 04, 2021 at 05:00:24PM +0800, Hui Tang wrote: > Enable x25519/x448/ecdh/ecdsa/sm2 algorithm on Kunpeng 930. > > Signed-off-by: Hui Tang > --- > drivers/crypto/hisilicon/hpre/hpre_main.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Patch applied. Thanks. --

Re: [PATCH 0/6] crypto: hisilicon/qm - misc fixes

2021-02-09 Thread Herbert Xu
On Fri, Feb 05, 2021 at 06:12:52PM +0800, Weili Qian wrote: > This patchset fixes some bugs: > 1. Removing the waiting reset's completion logic of driver. > 2. In order to prevent request missing, >call user's callback before device resetting. > 3. Fix the value of 'QM_SQC_VFT_BASE_MASK_V2'. >

Re: [PATCH 1/2] crypto: octeontx2 - fix -Wpointer-bool-conversion warning

2021-02-09 Thread Herbert Xu
On Thu, Feb 04, 2021 at 04:42:15PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_CPUMASK_OFFSTACK is disabled, clang reports a warning > about a bogus condition: > > drivers/crypto/marvell/octeontx2/otx2_cptlf.c:334:21: error: address of array >

[PATCH] mm/huge_memory.c: Remove unnecessary local variable ret2

2021-02-09 Thread Miaohe Lin
There is no need to use a new local variable ret2 to get the return value of handle_userfault(). Use ret directly to make code more succinct. Signed-off-by: Miaohe Lin --- mm/huge_memory.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/mm/huge_memory.c

Re: [PATCH] crypto: cavium: remove casting dma_alloc_coherent

2021-02-09 Thread Herbert Xu
On Thu, Feb 04, 2021 at 07:11:33AM +, Xu Wang wrote: > Remove casting the values returned by dma_alloc_coherent. > > Signed-off-by: Xu Wang > --- > drivers/crypto/cavium/cpt/cptvf_main.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Patch applied. Thanks. -- Email:

Re: [PATCH] crypto: keembay-ocs-aes - Fix 'q' assignment during CCM B0 generation

2021-02-09 Thread Herbert Xu
On Wed, Feb 03, 2021 at 03:42:10PM +, Daniele Alessandrelli wrote: > From: Daniele Alessandrelli > > In ocs_aes_ccm_write_b0(), 'q' (the octet length of the binary > representation of the octet length of the payload) is set to 'iv[0]', > while it should be set to 'iv[0] & 0x7' (i.e., only

[nouveau] WARNING: possible circular locking dependency detected in linux-next

2021-02-09 Thread Alexander Kapshuk
-20210209 #142 Tainted: GW [ 57.207497] -- [ 57.207508] Xorg/459 is trying to acquire lock: [ 57.207521] 888016edc518 (>mutex){+.+.}-{3:3}, at: nouveau_bo_move+0x4bf/0x2ec0 [nouv

Re: [PATCH] crypto: Fixed optimzation to optimization in the file crypto/xor.c

2021-02-09 Thread Herbert Xu
On Wed, Feb 03, 2021 at 09:09:33PM +0530, Bhaskar Chowdhury wrote: > > s/optimzation/optimization/ > > Signed-off-by: Bhaskar Chowdhury > --- > crypto/xor.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch applied. Thanks. -- Email: Herbert Xu Home Page:

Re: [PATCH] crypto: powerpc: remove unneeded semicolon

2021-02-09 Thread Herbert Xu
On Tue, Feb 02, 2021 at 11:17:30AM +0800, Yang Li wrote: > Eliminate the following coccicheck warning: > ./arch/powerpc/crypto/sha256-spe-glue.c:132:2-3: Unneeded > semicolon > > Reported-by: Abaci Robot > Signed-off-by: Yang Li > --- > arch/powerpc/crypto/sha256-spe-glue.c | 2 +- > 1 file

Re: [PATCH] crypto: ecdh_helper - Ensure 'len >= secret.len' in decode_key()

2021-02-09 Thread Herbert Xu
On Wed, Feb 03, 2021 at 11:28:37AM +, Daniele Alessandrelli wrote: > From: Daniele Alessandrelli > > The length ('len' parameter) passed to crypto_ecdh_decode_key() is never > checked against the length encoded in the passed buffer ('buf' > parameter). This could lead to an out-of-bounds

Re: [PATCH] crypto: marvell - CRYPTO_DEV_OCTEONTX2_CPT should depend on ARCH_THUNDER2

2021-02-09 Thread Herbert Xu
On Mon, Feb 01, 2021 at 02:44:31PM +0100, Geert Uytterhoeven wrote: > The Marvell OcteonTX2 CPT physical function PCI device is present only > on OcteonTx2 SoC, and not available as an independent PCIe endpoint. > Hence add a dependency on ARCH_THUNDER2, to prevent asking the user > about this

Re: [PATCH v2] crypto: caam - Replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE

2021-02-09 Thread Herbert Xu
On Tue, Feb 02, 2021 at 10:06:15AM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/crypto/caam/debugfs.c:23:0-23: WARNING: caam_fops_u64_ro > should be defined with DEFINE_DEBUGFS_ATTRIBUTE. > > ./drivers/crypto/caam/debugfs.c:22:0-23: WARNING: caam_fops_u32_ro

Re: [PATCH] hw_random/timeriomem-rng: Fix cooldown period calculation

2021-02-09 Thread Herbert Xu
On Mon, Feb 01, 2021 at 04:14:59PM +0100, Jan Henrik Weinstock wrote: > Ensure cooldown period tolerance of 1% is actually accounted for. > > Signed-off-by: Jan Henrik Weinstock > --- > > Before patch, if period_us was less than 100us, no extra sleep time was > added. If it was more than 100us,

Re: [PATCH v6 04/11] crypto: qce: skcipher: Return unsupported if any three keys are same for DES3 algorithms

2021-02-09 Thread Herbert Xu
On Sun, Feb 07, 2021 at 09:39:39AM -0500, Thara Gopinath wrote: > > + /* > + * The crypto engine does not support any two keys > + * being the same for triple des algorithms. The > + * verify_skcipher_des3_key does not check for all the > + * below conditions. Return

Re: [PATCH v2] mm: cma: support sysfs

2021-02-09 Thread John Hubbard
On 2/9/21 11:12 PM, Minchan Kim wrote: ... Agreed. How about this for the warning part? + +/* + * note: kobj_type should provide a release function to free dynamically + * allocated object since kobject is responsible for controlling lifespan + * of the object. However, cma_area is static

[PATCH] mm/hugetlb: optimize the surplus state transfer code in move_hugetlb_state()

2021-02-09 Thread Miaohe Lin
We should not transfer the per-node surplus state when we do not cross the node in order to save some cpu cycles Signed-off-by: Miaohe Lin --- mm/hugetlb.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/mm/hugetlb.c b/mm/hugetlb.c index da347047ea10..4f2c92ddbca4 100644 ---

Re: [page-reclaim] Augmented Page Reclaim

2021-02-09 Thread Yu Zhao
On Tue, Feb 09, 2021 at 01:32:58PM -0800, Jesse Barnes wrote: > > == > > Augmented Page Reclaim > > == > > We would like to share a work with you and see if there is enough > > interest to warrant a run for the mainline. This work is a part of > > result

Re: [PATCH v2] mm: cma: support sysfs

2021-02-09 Thread Minchan Kim
On Wed, Feb 10, 2021 at 07:43:37AM +0100, Greg KH wrote: > On Tue, Feb 09, 2021 at 01:13:17PM -0800, Minchan Kim wrote: > > On Tue, Feb 09, 2021 at 12:11:20PM -0800, John Hubbard wrote: > > > On 2/9/21 9:49 AM, Greg KH wrote: > > > > > > That's fine if you want to add it to the parent. If so,

[PATCH] mfd: dbx500-prcmu: Use true and false for bool variable

2021-02-09 Thread Jiapeng Chong
Fix the following coccicheck warning: ./include/linux/mfd/db8500-prcmu.h:723:8-9: WARNING: return of 0/1 in function 'db8500_prcmu_is_ac_wake_requested' with return type bool. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- include/linux/mfd/db8500-prcmu.h | 2 +- 1 file changed, 1

Re: [patch V2 12/13] softirq: Move do_softirq_own_stack() to generic asm header

2021-02-09 Thread Kees Cook
On Wed, Feb 10, 2021 at 12:40:53AM +0100, Thomas Gleixner wrote: > To avoid include recursion hell move the do_softirq_own_stack() related > content into a generic asm header and include it from all places in arch/ > which need the prototype. > > This allows architectures to provide an inline

Re: [patch V2 11/13] softirq: Move __ARCH_HAS_DO_SOFTIRQ to Kconfig

2021-02-09 Thread Kees Cook
On Wed, Feb 10, 2021 at 12:40:52AM +0100, Thomas Gleixner wrote: > To prepare for inlining do_softirq_own_stack() replace > __ARCH_HAS_DO_SOFTIRQ with a Kconfig switch and select it in the affected > architectures. > > This allows in the next step to move the function prototype and the inline >

Re: [PATCH net-next 7/9] net: phy: icplus: select page before writing control register

2021-02-09 Thread Heiner Kallweit
On 09.02.2021 17:40, Michael Walle wrote: > Registers >= 16 are paged. Be sure to set the page. It seems this was > working for now, because the default is correct for the registers used > in the driver at the moment. But this will also assume, nobody will > change the page select register before

Re: [PATCH v7 3/6] mfd: bd9576: Add IRQ support

2021-02-09 Thread Matti Vaittinen
Hello Lee, I appreciate your thorough reviews :) Thanks. On Tue, 2021-02-09 at 15:25 +, Lee Jones wrote: > On Fri, 22 Jan 2021, Matti Vaittinen wrote: > > > BD9573 and BD9576 support set of "protection" interrupts for > > "fatal" > > issues. Those lead to SOC reset as PMIC shuts the power

RE: How can a userspace program tell if the system supports the ACPI S4 state (Suspend-to-Disk)?

2021-02-09 Thread Dexuan Cui
> From: James Morse > Sent: Tuesday, February 9, 2021 10:15 AM > To: Dexuan Cui > Cc: Rafael J. Wysocki ; linux-a...@vger.kernel.org; > linux-kernel@vger.kernel.org; linux-hyp...@vger.kernel.org; Michael Kelley > ; Leandro Pereira > Subject: Re: How can a userspace program tell if the system

[PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-02-09 Thread huangxuesen
From: huangxuesen bpf_skb_adjust_room sets the inner_protocol as skb->protocol for packets encapsulation. But that is not appropriate when pushing Ethernet header. Add an option to further specify encap L2 type and set the inner_protocol as ETH_P_TEB. Suggested-by: Willem de Bruijn

Re: [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls

2021-02-09 Thread Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote: > From: Ira Weiny > > Add VM_BUG_ON bounds checks to ensure the newly lifted and created page > memory operations do not result in corrupted data in neighbor pages and > to make them consistent with zero_user().[1][2] > I did not understand this, in my

[PATCH] mm/hugetlb: use some helper functions to cleanup code

2021-02-09 Thread Miaohe Lin
We could use pages_per_huge_page to get the number of pages per hugepage, use get_hstate_idx to calculate hstate index, and use hstate_is_gigantic to check if a hstate is gigantic to make code more succinct. Signed-off-by: Miaohe Lin --- fs/hugetlbfs/inode.c | 2 +- mm/hugetlb.c | 6

Re: [PATCH 00/20] Rid W=1 warnings in Crypto

2021-02-09 Thread Herbert Xu
On Thu, Feb 04, 2021 at 11:09:40AM +, Lee Jones wrote: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > This is set 1 of 2 sets required to fully clean Crypto. > > Lee Jones (20): >

Re: [PATCH RFC 0/6] Add roundrobin raid1 read policy

2021-02-09 Thread Anand Jain
On 10/02/2021 04:30, Michal Rostecki wrote: From: Michal Rostecki This patch series adds a new raid1 read policy - roundrobin. For each request, it selects the mirror which has lower load than queue depth. Load is defined as the number of inflight requests + a penalty value (if the scheduled

Re: [PATCH v2 16/24] net: stmmac: Use optional reset control API to work with stmmaceth

2021-02-09 Thread Jisheng Zhang
Hi, On Mon, 8 Feb 2021 16:56:00 +0300 Serge Semin wrote: > > Since commit bb3222f71b57 ("net: stmmac: platform: use optional clk/reset > get APIs") a manual implementation of the optional device reset control > functionality has been replaced with using the > devm_reset_control_get_optional()

Re: [PATCH V2 3/8] mm/highmem: Introduce memcpy_page(), memmove_page(), and memset_page()

2021-02-09 Thread Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote: > From: Ira Weiny > > 3 more common kmap patterns are kmap/memcpy/kunmap, kmap/memmove/kunmap. > and kmap/memset/kunmap. > > Add helper functions for those patterns which use kmap_local_page(). > > Cc: Andrew Morton > Cc: Christoph Hellwig >

Re: [PATCH] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 12:01:06PM -0800, Dan Williams wrote: > On Tue, Feb 9, 2021 at 11:16 AM Greg KH wrote: > [..] > > > diff --git a/drivers/base/auxiliary.c b/drivers/base/auxiliary.c > > > index 8336535f1e11..53f93a506626 100644 > > > --- a/drivers/base/auxiliary.c > > > +++

[PATCH] tee: optee: add invoke_fn tracepoints

2021-02-09 Thread Jisheng Zhang
Add tracepoints to retrieve information about the invoke_fn. This would help to measure how many invoke_fn are triggered and how long it takes to complete one invoke_fn call. Signed-off-by: Jisheng Zhang --- Since v1: - add BUILD_BUG_ON() macro usage to make sure that the size of what is being

Re: [PATCH v2] driver core: auxiliary bus: Fix calling stage for auxiliary bus init

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 03:17:00PM -0700, Dave Jiang wrote: > When the auxiliary device code is built into the kernel, it can be executed > before the auxiliary bus is registered. This causes bus->p to be not > allocated and triggers a NULL pointer dereference when the auxiliary bus > device gets

[PATCH 2/3] Revert "ASoC: audio-graph-card: Add clocks property to endpoint node"

2021-02-09 Thread Sameer Pujar
An endpoint is not a device and it is recommended to use clocks property in the device node. Hence reverting the original change. Fixes: 531e5b7abbde ("ASoC: audio-graph-card: Add clocks property to endpoint node") Suggested-by: Rob Herring Cc: Kuninori Morimoto Signed-off-by: Sameer Pujar

[PATCH 3/3] arm64: tegra: Move clocks from RT5658 endpoint to device node

2021-02-09 Thread Sameer Pujar
An endpoint is not a device and it is recommended to use clocks property in device node. RT5658 Codec binding already specifies the usage of clocks property. Thus move the clocks from endpoint to device node. Fixes: 5b4f6323096a ("arm64: tegra: Audio graph sound card for Jetson AGX Xavier")

[PATCH 0/3] Use clocks property in a device node

2021-02-09 Thread Sameer Pujar
It is recommended to not specifiy clocks property in an endpoint subnode. This series moves clocks to device node. However after moving the clocks to device node, the audio playback or capture fails. The specified clock is not actually getting enabled and hence the failure is seen. There seems to

[PATCH 1/3] ASoC: simple-card-utils: Fix device module clock

2021-02-09 Thread Sameer Pujar
If "clocks = <>" is specified from the CPU or Codec component device node, the clock is not getting enabled. Thus audio playback or capture fails. Fix this by populating "simple_dai->clk" field when clocks property is specified from device node as well. Also tidy up by re-organising conditional

Re: [PATCH v2 3/3] crypto: hisilicon/sec - fixes shash test error

2021-02-09 Thread Herbert Xu
On Sun, Feb 07, 2021 at 06:04:40PM +0800, Longfang Liu wrote: > If the header file "crypto/internal/hash.h" not > added, the allocation of crypto_tfm will fail when > the shash algorithm calculates the hash > through the software. > > Signed-off-by: Longfang Liu > --- >

Re: [PATCH v2] mm: cma: support sysfs

2021-02-09 Thread Greg KH
On Tue, Feb 09, 2021 at 01:13:17PM -0800, Minchan Kim wrote: > On Tue, Feb 09, 2021 at 12:11:20PM -0800, John Hubbard wrote: > > On 2/9/21 9:49 AM, Greg KH wrote: > > > > > That's fine if you want to add it to the parent. If so, then the > > > > > kobject controls the lifetime of the structure,

Re: [PATCH v2 6/7] ASoC: codec: lpass-tx-macro: add support for lpass tx macro

2021-02-09 Thread kernel test robot
' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Srinivas-Kandagatla/ASoC-codecs-add-support-for-LPASS-Codec-TX-and-RX-macros/20210209-084643 base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next config: ia64-randconfig

Re: [PATCH V2 2/8] mm/highmem: Convert memcpy_[to|from]_page() to kmap_local_page()

2021-02-09 Thread Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote: > From: Ira Weiny > > kmap_local_page() is more efficient and is well suited for these calls. > Convert the kmap() to kmap_local_page() > > Cc: Andrew Morton > Cc: Christoph Hellwig > Signed-off-by: Ira Weiny Looks good. Reviewed-by: Chaitanya

Re: [PATCH v2 2/7] ASoC: fsl_rpmsg: Add CPU DAI driver for audio base on rpmsg

2021-02-09 Thread Shengjiu Wang
On Wed, Feb 10, 2021 at 6:30 AM Mark Brown wrote: > > On Tue, Feb 09, 2021 at 05:16:16PM +0800, Shengjiu Wang wrote: > > On Mon, Feb 8, 2021 at 7:53 PM Mark Brown wrote: > > > > hw_params() can be called multiple times and there's no need for it to > > > be balanced with hw_free(), I'd move this

Re: [kbuild-all] Re: [PATCH v12 7/7] kasan: don't run tests in async mode

2021-02-09 Thread Rong Chen
/0day-ci/linux/commits/Vincenzo-Frascino/arm64-ARMv8-5-A-MTE-Add-async-mode-support/20210209-080907 base:59fa6a163ffabc1bf25c5e0e33899e268a96d3cc config: powerpc64-randconfig-r033-20210209 (attached as .config) compiler: powerpc-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget

Re: [PATCH V2 1/8] mm/highmem: Lift memcpy_[to|from]_page to core

2021-02-09 Thread Chaitanya Kulkarni
On 2/9/21 22:25, ira.we...@intel.com wrote: > From: Ira Weiny > > Working through a conversion to a call kmap_local_page() instead of > kmap() revealed many places where the pattern kmap/memcpy/kunmap > occurred. > > Eric Biggers, Matthew Wilcox, Christoph Hellwig, Dan Williams, and Al > Viro all

Re: [PATCH v3] printk: fix deadlock when kernel panic

2021-02-09 Thread Sergey Senozhatsky
On (21/02/10 11:48), Muchun Song wrote: > printk_safe_flush_on_panic() caused the following deadlock on our > server: > > CPU0: CPU1: > panic rcu_dump_cpu_stacks > kdump_nmi_shootdown_cpus

Re: [GIT PULL] memblock: remove return value of memblock_free_all()

2021-02-09 Thread Mike Rapoport
On Tue, Feb 09, 2021 at 05:17:30PM -0800, Linus Torvalds wrote: > On Tue, Feb 9, 2021 at 1:43 AM Mike Rapoport wrote: > > > > This a small cleanup in memblock for 5.12 merge window. > > If it's going to make Andrew's patches easier to apply during the 5.12 > timeframe, I'm happy to pull this

Re: [PATCH Resend] mailbox: arm_mhuv2: Fix sparse warnings

2021-02-09 Thread Viresh Kumar
On 10-02-21, 00:25, Jassi Brar wrote: > Yup any bug fix should be sent in rc. But this, imo, lies on the > boundary of code and cosmetic issues, so I practiced discretion to > keep it for the next pull request lest I won't have much to send ;) Fair enough, would have been better though if you

[PATCH v2] perf probe: fix kretprobe issue caused by GCC bug

2021-02-09 Thread Jianlin Lv
Perf failed to add kretprobe event with debuginfo of vmlinux which is compiled by gcc with -fpatchable-function-entry option enabled. The same issue with kernel module. Issue: # perf probe -v 'kernel_clone%return $retval' .. Writing event: r:probe/kernel_clone__return _text+599624

Re: [PATCH] crypto: picoxcell - convert sysfs sprintf/snprintf family to sysfs_emit

2021-02-09 Thread Herbert Xu
On Thu, Feb 04, 2021 at 03:24:13PM +0800, Jiapeng Chong wrote: > Fix the following coccicheck warning: > > ./drivers/crypto/picoxcell_crypto.c:1201:8-16: WARNING: use scnprintf > or sprintf. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong > --- > drivers/crypto/picoxcell_crypto.c

Re: [RESEND PATCH v18 0/3] userspace MHI client interface driver

2021-02-09 Thread Manivannan Sadhasivam
On Tue, Feb 09, 2021 at 08:17:44AM -0800, Jakub Kicinski wrote: > On Tue, 9 Feb 2021 10:20:30 +0100 Aleksander Morgado wrote: > > This may be a stupid suggestion, but would the integration look less a > > backdoor if it would have been named "mhi_wwan" and it exposed already > > all the

Re: [PATCH Resend] mailbox: arm_mhuv2: Fix sparse warnings

2021-02-09 Thread Jassi Brar
On Tue, Feb 9, 2021 at 5:18 AM Viresh Kumar wrote: > > This patch fixes a bunch of sparse warnings in the newly added arm_mhuv2 > driver. > > drivers/mailbox/arm_mhuv2.c:506:24: warning: incorrect type in argument 1 > (different address spaces) > drivers/mailbox/arm_mhuv2.c:506:24:expected

[PATCH V2 6/8] btrfs: use memcpy_[to|from]_page() and kmap_local_page()

2021-02-09 Thread ira . weiny
From: Ira Weiny There are many places where the pattern kmap/memcpy/kunmap occurs. This pattern was lifted to the core common functions memcpy_[to|from]_page(). Use these new functions to reduce the code, eliminate direct uses of kmap, and leverage the new core functions use of

[PATCH V2 7/8] btrfs: use copy_highpage() instead of 2 kmaps()

2021-02-09 Thread ira . weiny
From: Ira Weiny There are many places where kmap/memove/kunmap patterns occur. This pattern exists in the core common function copy_highpage(). Use copy_highpage to avoid open coding the use of kmap and leverages the core functions use of kmap_local_page(). Development of this patch was aided

[PATCH V2 8/8] btrfs: convert to zero_user()

2021-02-09 Thread ira . weiny
From: Ira Weiny There are many places where kmap/memset/kunmap patterns occur. This pattern exists in the core as zero_user() Use zero_user() to eliminate direct uses of kmap and leverage the new core functions use of kmap_local_page(). The development of this patch was aided by the following

[PATCH V2 3/8] mm/highmem: Introduce memcpy_page(), memmove_page(), and memset_page()

2021-02-09 Thread ira . weiny
From: Ira Weiny 3 more common kmap patterns are kmap/memcpy/kunmap, kmap/memmove/kunmap. and kmap/memset/kunmap. Add helper functions for those patterns which use kmap_local_page(). Cc: Andrew Morton Cc: Christoph Hellwig Signed-off-by: Ira Weiny --- New for V2 --- include/linux/highmem.h

[PATCH V2 5/8] iov_iter: Remove memzero_page() in favor of zero_user()

2021-02-09 Thread ira . weiny
From: Ira Weiny zero_user() is already defined with the same interface and contains the same code pattern as memzero_page(). Remove memzero_page() and use the already defined common function zero_user() To: Alexander Viro Cc: Andrew Morton Cc: Christoph Hellwig Signed-off-by: Ira Weiny

[PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls

2021-02-09 Thread ira . weiny
From: Ira Weiny Add VM_BUG_ON bounds checks to ensure the newly lifted and created page memory operations do not result in corrupted data in neighbor pages and to make them consistent with zero_user().[1][2] [1] https://lore.kernel.org/lkml/20201210053502.gs1563...@iweiny-desk2.sc.intel.com/

[PATCH V2 0/8] btrfs: convert kmaps to core page calls

2021-02-09 Thread ira . weiny
From: Ira Weiny Changes from V1: Rework commit messages because they were very weak Change 'fs/btrfs: X' to 'btrfs: x' https://lore.kernel.org/lkml/20210209151442.gu1...@suse.cz/ Per Andrew Split out changes to highmem.h

[PATCH V2 1/8] mm/highmem: Lift memcpy_[to|from]_page to core

2021-02-09 Thread ira . weiny
From: Ira Weiny Working through a conversion to a call kmap_local_page() instead of kmap() revealed many places where the pattern kmap/memcpy/kunmap occurred. Eric Biggers, Matthew Wilcox, Christoph Hellwig, Dan Williams, and Al Viro all suggested putting this code into helper functions. Al

[PATCH V2 2/8] mm/highmem: Convert memcpy_[to|from]_page() to kmap_local_page()

2021-02-09 Thread ira . weiny
From: Ira Weiny kmap_local_page() is more efficient and is well suited for these calls. Convert the kmap() to kmap_local_page() Cc: Andrew Morton Cc: Christoph Hellwig Signed-off-by: Ira Weiny --- New for V2 --- include/linux/highmem.h | 8 1 file changed, 4 insertions(+), 4

Re: [PATCH v7 2/6] mfd: Support ROHM BD9576MUF and BD9573MUF

2021-02-09 Thread Matti Vaittinen
Hello Lee, On Tue, 2021-02-09 at 14:55 +, Lee Jones wrote: > On Fri, 22 Jan 2021, Matti Vaittinen wrote: > > > Add core support for ROHM BD9576MUF and BD9573MUF PMICs which are > > mainly used to power the R-Car series processors. > > > > Signed-off-by: Matti Vaittinen > > --- > > + > >

Re: [PATCH v2 08/14] x86/fault: Skip erratum #93 workaround on new CPUs

2021-02-09 Thread Andy Lutomirski
On Tue, Feb 9, 2021 at 6:33 PM Andy Lutomirski wrote: > > Erratum #93 applies to the first generation of AMD K8 CPUs. Skip the > workaround on newer CPUs. Whoops, this breaks the !CPU_SUP_AMD build. It needs a fixup like this:

Re: [PATCH v2 06/28] locking/rwlocks: Add contention detection for rwlocks

2021-02-09 Thread Guenter Roeck
On 2/9/21 4:27 PM, Waiman Long wrote: [ ... ] > > It is because in arch/mips/include/asm/spinlock.h, asm/qrwlock.h is included > before asm/qspinlock.h. The compilation error should be gone if the > asm/qrwlock.h is removed or moved after asm/qspinlock.h. > > I did a x86 build and there was

Re: [PATCH] bpf_lru_list: Read double-checked variable once without lock

2021-02-09 Thread Martin KaFai Lau
On Tue, Feb 09, 2021 at 12:27:01PM +0100, Marco Elver wrote: > For double-checked locking in bpf_common_lru_push_free(), node->type is > read outside the critical section and then re-checked under the lock. > However, concurrent writes to node->type result in data races. > > For example, the

Re: [PATCH v1 5/5] driver core: Set fw_devlink=on by default

2021-02-09 Thread Guenter Roeck
ixes the problem. Bisect log is attached. It may also break a variety of other boot tests, but with 115 of 430 boot tests failing in -next it is difficult to identify all culprits. Guenter --- Bisect log: # bad: [a4bfd8d46ac357c12529e4eebb6c89502b03ecc9] Add linux-next specific files for 202102

[PATCH] docs: reporting-issues.rst: explain how to decode stack traces

2021-02-09 Thread Thorsten Leemhuis
Replace placeholder text about decoding stack traces with a section that properly describes what a typical user should do these days. To make it works for them, add a paragraph in an earlier section to ensure people build their kernels with everything that's needed to decode stack traces later.

Re: [PATCH] ext4: add .kunitconfig fragment to enable ext4-specific tests

2021-02-09 Thread Daniel Latypov
On Tue, Feb 9, 2021 at 6:33 PM Theodore Ts'o wrote: > > On Tue, Feb 09, 2021 at 05:32:06PM -0800, Daniel Latypov wrote: > > > > After [2]: > > $ ./tools/testing/kunit.py run --kunitconfig=fs/ext4/.kunitconfig > > Any chance that in the future this might become: > > $ ./tools/testing/kunit.py

Re: [PATCH] net/mlx5: docs: correct section reference in table of contents

2021-02-09 Thread Saeed Mahameed
On Fri, 2021-02-05 at 10:55 +0100, Lukas Bulwahn wrote: > Commit 142d93d12dc1 ("net/mlx5: Add devlink subfunction port > documentation") refers to a section 'mlx5 port function' in the table > of > contents, but includes a section 'mlx5 function attributes' instead. > > Hence, make htmldocs

RE: linux-next: manual merge of the gpio-brgl tree with the arm-soc tree

2021-02-09 Thread nobuhiro1.iwamatsu
Hi all, > -Original Message- > From: Arnd Bergmann [mailto:a...@kernel.org] > Sent: Tuesday, February 9, 2021 8:36 PM > To: Geert Uytterhoeven > Cc: Stephen Rothwell ; Bartosz Golaszewski > ; Olof Johansson ; > Arnd Bergmann ; ARM ; > Bartosz Golaszewski > ; Linux Kernel Mailing List

Re: [next] [s390 ] net: mlx5: tc_tun.h:24:29: error: field 'match_level' has incomplete type

2021-02-09 Thread Saeed Mahameed
On Wed, 2021-02-10 at 10:50 +0530, Naresh Kamboju wrote: > While building Linux next tag 20210209 s390 (defconfig) with gcc-9 > make modules failed. > ... > Reported-by: Naresh Kamboju > Thanks for the report a patch was already posted earlier today https://patchwork.ker

  1   2   3   4   5   6   7   8   9   10   >