Re: [PATCH 11/16] dmaengine: ti: k3-psil-j721e: Add entry for CSI2RX

2021-04-06 Thread Pratyush Yadav
On 06/04/21 06:33PM, Péter Ujfalusi wrote: > > > On 4/6/21 6:09 PM, Pratyush Yadav wrote: > > On 04/04/21 04:24PM, Péter Ujfalusi wrote: > >> Hi Pratyush, > >> > >> On 3/30/21 8:33 PM, Pratyush Yadav wrote: > >>> The CSI2RX subsystem uses PSI-L DMA to transfer frames to memory. It can > >>> have

Re: [PATCH v4 00/20] Implement GENERIC_CMDLINE

2021-04-06 Thread Daniel Walker
On Fri, Apr 02, 2021 at 03:18:01PM +, Christophe Leroy wrote: > The purpose of this series is to improve and enhance the > handling of kernel boot arguments. > > Current situation is that most if not all architectures are using > similar options to do some manupulation on command line

[PATCH][next] net/mlx5: Fix bit-wise and with zero

2021-04-06 Thread Colin King
From: Colin Ian King The bit-wise and of the action field with MLX5_ACCEL_ESP_ACTION_DECRYPT is incorrect as MLX5_ACCEL_ESP_ACTION_DECRYPT is zero and not intended to be a bit-flag. Fix this by using the == operator as was originally intended. Addresses-Coverity: ("Logically dead code") Fixes:

Re: [PATCH v6 1/9] locking/qspinlock: Add ARCH_USE_QUEUED_SPINLOCKS_XCHG32

2021-04-06 Thread Boqun Feng
Hi, On Wed, Mar 31, 2021 at 02:30:32PM +, guo...@kernel.org wrote: > From: Guo Ren > > Some architectures don't have sub-word swap atomic instruction, > they only have the full word's one. > > The sub-word swap only improve the performance when: > NR_CPUS < 16K > * 0- 7: locked byte > *

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces around operator in HalBtc8723b1Ant.h

2021-04-06 Thread Fabio M. De Francesco
On Tuesday, April 6, 2021 6:44:00 PM CEST Julia Lawall wrote: > > On Tue, 6 Apr 2021, Fabio M. De Francesco wrote: > > > Added spaces around operators in file HalBtc8723b1Ant.h. Issue detected > > by checkpatch.pl. Spaces are preferred to improve readibility. > > > > Signed-off-by: Fabio M. De

Re: [PATCH v2 11/14] drm/bridge: ti-sn65dsi86: Power things properly for reading the EDID

2021-04-06 Thread Andrzej Hajda
Hello again after easter, I have looked little bit more at sn65* driver and its application to have better background. I miss only info what panel do you have, how it is enabled/power controlled. W dniu 01.04.2021 o 16:57, Doug Anderson pisze: > Hi, > > On Thu, Apr 1, 2021 at 4:12 AM Andrzej

Re: [PATCH v1 1/1] kernel.h: Split out panic and oops helpers

2021-04-06 Thread Luis Chamberlain
On Tue, Apr 06, 2021 at 04:31:58PM +0300, Andy Shevchenko wrote: > diff --git a/include/linux/panic_notifier.h b/include/linux/panic_notifier.h > new file mode 100644 > index ..41e32483d7a7 > --- /dev/null > +++ b/include/linux/panic_notifier.h > @@ -0,0 +1,12 @@ > +/*

Re: [bug report] Memory leak from acpi_ev_install_space_handler()

2021-04-06 Thread John Garry
On 06/04/2021 17:40, Rafael J. Wysocki wrote: On Tue, Apr 6, 2021 at 5:51 PM John Garry wrote: Hi guys, On next-20210406, I enabled CONFIG_DEBUG_KMEMLEAK and CONFIG_DEBUG_TEST_DRIVER_REMOVE for my arm64 system, and see this: Hi Rafael, Why exactly do you think

Re: [PATCH v4 4/8] hugetlb: create remove_hugetlb_page() to separate functionality

2021-04-06 Thread Mike Kravetz
On 4/6/21 2:56 AM, Michal Hocko wrote: > On Mon 05-04-21 16:00:39, Mike Kravetz wrote: >> The new remove_hugetlb_page() routine is designed to remove a hugetlb >> page from hugetlbfs processing. It will remove the page from the active >> or free list, update global counters and set the compound

Re: [PATCH v4 12/18] of/address: Add infrastructure to declare MMIO as non-posted

2021-04-06 Thread Rob Herring
On Fri, Apr 02, 2021 at 06:05:36PM +0900, Hector Martin wrote: > This implements the 'nonposted-mmio' boolean property. Placing this > property in a bus marks all direct child devices as requiring > non-posted MMIO mappings. If no such property is found, the default > is posted MMIO. > >

Re: [PATCH v4 2/6] dt-bindings: PCI: Add bindings for Brcmstb endpoint device voltage regulators

2021-04-06 Thread Mark Brown
On Thu, Apr 01, 2021 at 05:21:42PM -0400, Jim Quinlan wrote: > Similar to the regulator bindings found in "rockchip-pcie-host.txt", this > allows optional regulators to be attached and controlled by the PCIe RC > driver. That being said, this driver searches in the DT subnode (the EP > node, eg

Re: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-06 Thread Moritz Fischer
Hi Matthew, On Tue, Apr 06, 2021 at 09:05:35AM -0700, matthew.gerl...@linux.intel.com wrote: > > Hi Moritz, > > On Mon, 5 Apr 2021, Moritz Fischer wrote: > > > Hi Matthew, > > > > On Mon, Apr 05, 2021 at 04:53:00PM -0700, matthew.gerl...@linux.intel.com > > wrote: > > > From: Matthew Gerlach

[PATCH v7 8/8] pwm: pca9685: Add error messages for failed regmap calls

2021-04-06 Thread Clemens Gruber
Regmap operations can fail if the underlying subsystem is not working properly (e.g. hogged I2C bus, etc.) As this is useful information for the user, print an error message if it happens. Let probe fail if the first regmap_read or the first regmap_write fails. Signed-off-by: Clemens Gruber ---

Re: [PATCH v4 05/18] dt-bindings: timer: arm,arch_timer: Add interrupt-names support

2021-04-06 Thread Rob Herring
On Fri, 02 Apr 2021 18:05:29 +0900, Hector Martin wrote: > Not all platforms provide the same set of timers/interrupts, and Linux > only needs one (plus kvm/guest ones); some platforms are working around > this by using dummy fake interrupts. Implementing interrupt-names allows > the devicetree to

[PATCH v7 7/8] pwm: pca9685: Restrict period change for enabled PWMs

2021-04-06 Thread Clemens Gruber
Previously, the last used PWM channel could change the global prescale setting, even if other channels are already in use. Fix it by only allowing the first enabled PWM to change the global chip-wide prescale setting. If there is more than one channel in use, the prescale settings resulting from

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces around operator in HalBtc8723b1Ant.h

2021-04-06 Thread Julia Lawall
On Tue, 6 Apr 2021, Fabio M. De Francesco wrote: > Added spaces around operators in file HalBtc8723b1Ant.h. Issue detected > by checkpatch.pl. Spaces are preferred to improve readibility. > > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h | 2 +-

[PATCH v7 6/8] pwm: pca9685: Support new PWM_STAGGERING_ALLOWED flag

2021-04-06 Thread Clemens Gruber
The PCA9685 supports staggered LED output ON times to minimize current surges and reduce EMI. When the PWM_STAGGERING_ALLOWED flag is set for a channel, its ON time is delayed by channel number x counter range / 16, which avoids asserting all the enabled outputs at the same counter value while

[PATCH v7 5/8] pwm: core: Support new PWM_STAGGERING_ALLOWED flag

2021-04-06 Thread Clemens Gruber
If the flag PWM_STAGGERING_ALLOWED is set on a channel, the PWM driver may (if supported by the HW) delay the ON time of the channel relative to the channel number. This does not alter the duty cycle ratio and is only relevant for PWM chips with less prescalers than channels, which would otherwise

[PATCH v7 4/8] dt-bindings: pwm: Support new PWM_STAGGERING_ALLOWED flag

2021-04-06 Thread Clemens Gruber
Add the flag and corresponding documentation for the new PWM staggering mode feature. Cc: Rob Herring Signed-off-by: Clemens Gruber --- Documentation/devicetree/bindings/pwm/pwm.txt | 1 + include/dt-bindings/pwm/pwm.h | 1 + 2 files changed, 2 insertions(+) diff --git

[PATCH v7 3/8] pwm: pca9685: Improve runtime PM behavior

2021-04-06 Thread Clemens Gruber
The chip does not come out of POR in active state but in sleep state. To be sure (in case the bootloader woke it up) we force it to sleep in probe. On kernels without CONFIG_PM, we wake the chip in .probe and put it to sleep in .remove. Signed-off-by: Clemens Gruber --- Changes since v6: -

[PATCH v7 2/8] pwm: pca9685: Support hardware readout

2021-04-06 Thread Clemens Gruber
Implements .get_state to read-out the current hardware state. The hardware readout may return slightly different values than those that were set in apply due to the limited range of possible prescale and counter register values. Also note that although the datasheet mentions 200 Hz as default

[PATCH v7 1/8] pwm: pca9685: Switch to atomic API

2021-04-06 Thread Clemens Gruber
The switch to the atomic API goes hand in hand with a few fixes to previously experienced issues: - The duty cycle is no longer lost after disable/enable (previously the OFF registers were cleared in disable and the user was required to call config to restore the duty cycle settings) - If one

Re: [PATCH 6/8] drivers: firmware: efi: libstub: enable generic commandline

2021-04-06 Thread Daniel Walker
On Fri, Apr 02, 2021 at 07:36:53PM +0200, Christophe Leroy wrote: > > > Le 30/03/2021 à 19:57, Daniel Walker a écrit : > > This adds code to handle the generic command line changes. > > The efi code appears that it doesn't benefit as much from this design > > as it could. > > > > For example,

Re: [RFC PATCH 0/6] mm: thp: use generic THP migration for NUMA hinting fault

2021-04-06 Thread Yang Shi
On Tue, Apr 6, 2021 at 5:03 AM Gerald Schaefer wrote: > > On Thu, 1 Apr 2021 13:10:49 -0700 > Yang Shi wrote: > > [...] > > > > > > > > Yes, it could be. The old behavior of migration was to return -ENOMEM > > > > if THP migration is not supported then split THP. That behavior was > > > > not

Re: [bug report] Memory leak from acpi_ev_install_space_handler()

2021-04-06 Thread Rafael J. Wysocki
On Tue, Apr 6, 2021 at 5:51 PM John Garry wrote: > > Hi guys, > > On next-20210406, I enabled CONFIG_DEBUG_KMEMLEAK and > CONFIG_DEBUG_TEST_DRIVER_REMOVE for my arm64 system, and see this: Why exactly do you think that acpi_ev_install_space_handler() leaks memory? > root@debia

[Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Add spaces around operator in HalBtc8723b1Ant.h

2021-04-06 Thread Fabio M. De Francesco
Added spaces around operators in file HalBtc8723b1Ant.h. Issue detected by checkpatch.pl. Spaces are preferred to improve readibility. Signed-off-by: Fabio M. De Francesco --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH][next] regmap-irq: Fix dereference of a potentially null d->virt_buf

2021-04-06 Thread Colin King
From: Colin Ian King The clean up of struct d can potentiallly index into a null array d->virt_buf causing errorenous pointer dereferencing issues on kfree calls. Fix this by adding a null check on d->virt_buf before attempting to traverse the array to kfree the objects. Addresses-Coverity:

Re: [PATCH 4/8] CMDLINE: powerpc: convert to generic builtin command line

2021-04-06 Thread Daniel Walker
On Fri, Apr 02, 2021 at 07:34:19PM +0200, Christophe Leroy wrote: > > > Le 30/03/2021 à 19:56, Daniel Walker a écrit : > > This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE > > option. > > > > This includes a scripted mass convert of the config files to use > > the new generic

Re: [PATCH v5 0/2] ata: ahci_brcm: Fix use of BCM7216 reset controller

2021-04-06 Thread Florian Fainelli
On 4/6/2021 8:42 AM, Lorenzo Pieralisi wrote: > On Fri, 12 Mar 2021 15:45:53 -0500, Jim Quinlan wrote: >> v5 -- Improved (I hope) commit description (Bjorn). >>-- Rnamed error labels (Krzyszt). >>-- Fixed typos. >> >> v4 -- does not rely on a pending commit, unlike v3. >> >> v3 --

Re: [RFC v1 25/26] x86/tdx: Make DMA pages shared

2021-04-06 Thread Dave Hansen
On 4/6/21 9:31 AM, Kirill A. Shutemov wrote: > On Thu, Apr 01, 2021 at 02:01:15PM -0700, Dave Hansen wrote: >>> @@ -1977,8 +1978,8 @@ static int __set_memory_enc_dec(unsigned long addr, >>> int numpages, bool enc) >>> struct cpa_data cpa; >>> int ret; >>> >>> - /* Nothing to do if

Re: [RFC v1 21/26] x86/mm: Move force_dma_unencrypted() to common code

2021-04-06 Thread Kirill A. Shutemov
On Tue, Apr 06, 2021 at 09:11:25AM -0700, Dave Hansen wrote: > On 4/6/21 8:37 AM, Kirill A. Shutemov wrote: > > On Thu, Apr 01, 2021 at 01:06:29PM -0700, Dave Hansen wrote: > >> On 2/5/21 3:38 PM, Kuppuswamy Sathyanarayanan wrote: > >>> From: "Kirill A. Shutemov" > >>> > >>> Intel TDX doesn't

[PATCH v5.4 1/1] iommu/vt-d: Fix agaw for a supported 48 bit guest address width

2021-04-06 Thread Saeed Mirzamohammadi
The IOMMU driver calculates the guest addressability for a DMA request based on the value of the mgaw reported from the IOMMU. However, this is a fused value and as mentioned in the spec, the guest width should be calculated based on the supported adjusted guest address width (SAGAW). This is

Re: [PATCH 2/8] CMDLINE: drivers: of: ifdef out cmdline section

2021-04-06 Thread Daniel Walker
On Fri, Apr 02, 2021 at 07:32:08PM +0200, Christophe Leroy wrote: > > > Le 30/03/2021 à 19:56, Daniel Walker a écrit : > > It looks like there's some seepage of cmdline stuff into > > the generic device tree code. This conflicts with the > > generic cmdline implementation so I remove it in the

Re: [PATCH v4 3/6] PCI: brcmstb: Add control of slot0 device voltage regulators

2021-04-06 Thread Mark Brown
On Thu, Apr 01, 2021 at 05:21:43PM -0400, Jim Quinlan wrote: > + /* Look for specific pcie regulators in the RC DT node. */ > + for_each_property_of_node(np, pp) { > + for (i = 0; i < ns; i++) > + if (strcmp(supplies[i], pp->name) == 0) This is broken, the

[PATCH v2] arm64: dts: qcom: Update iommu property for simultaneous playback

2021-04-06 Thread Srinivasa Rao Mandadapu
From: V Sujith Kumar Reddy Update iommu property in lpass cpu node for supporting simultaneous playback on headset and speaker. Signed-off-by: V Sujith Kumar Reddy Signed-off-by: Srinivasa Rao Mandadapu --- Changes since v1: -- Commit messge header change

Re: [PATCH v6 2/8] mm,memory_hotplug: Relax fully spanned sections check

2021-04-06 Thread Oscar Salvador
On 2021-04-06 17:32, David Hildenbrand wrote: I'd only relax start_pfn. That way the function is pretty much impossible to abuse for sub-section onlining/offlining. if (WARN_ON_ONCE(!nr_pages || !IS_ALIGNED(start_pfn, pageblock_nr_pages)) !IS_ALIGNED(start_pfn

CONGRATULATIONS

2021-04-06 Thread Alexander Holmes
How are you today? This is MoneyGram International Inc. we are contacting you concerning your winning fund $1.500, 000.00 USD; your e-mail won $1.500, 000.00 dollars through Internet contest, and lottery bonus under MoneyGram International Inc. Worldwide. The lottery bonus is contesting once in a

Re: [PATCH] perf: util/mem-events.h: Remove unnecessary struct declaration

2021-04-06 Thread Arnaldo Carvalho de Melo
Em Tue, Apr 06, 2021 at 06:51:02PM +0800, Wan Jiabing escreveu: > struct mem_info is defined at 22nd line. > The declaration here is unnecessary. Remove it. Thanks, applied. - Arnaldo > Signed-off-by: Wan Jiabing > --- > tools/perf/util/mem-events.h | 1 - > 1 file changed, 1 deletion(-) >

Re: [PATCH v9 2/4] dt-bindings: mtd: Add a property to declare secure regions in NAND chips

2021-04-06 Thread Rob Herring
On Thu, 01 Apr 2021 20:45:06 +0530, Manivannan Sadhasivam wrote: > On a typical end product, a vendor may choose to secure some regions in > the NAND memory which are supposed to stay intact between FW upgrades. > The access to those regions will be blocked by a secure element like > Trustzone. So

Re: [RFC v1 25/26] x86/tdx: Make DMA pages shared

2021-04-06 Thread Kirill A. Shutemov
On Thu, Apr 01, 2021 at 02:01:15PM -0700, Dave Hansen wrote: > > +int tdx_map_gpa(phys_addr_t gpa, int numpages, bool private) > > +{ > > + int ret, i; > > + > > + ret = __tdx_map_gpa(gpa, numpages, private); > > + if (ret || !private) > > + return ret; > > + > > + for (i = 0; i

Re: [PATCH v6 1/5] dt-bindings: usb: Add binding for Realtek RTS5411 hub controller

2021-04-06 Thread Rob Herring
On Mon, Apr 05, 2021 at 01:18:13PM -0700, Matthias Kaehlcke wrote: > The Realtek RTS5411 is a USB 3.0 hub controller with 4 ports. > > This initial version of the binding only describes USB related > aspects of the RTS5411, it does not cover the option of > connecting the controller as an i2c

Re: [PATCH v2 3/7] powerpc: convert config files to generic cmdline

2021-04-06 Thread Daniel Walker
On Thu, Apr 01, 2021 at 03:08:04PM -0500, Rob Herring wrote: > On Tue, Mar 30, 2021 at 6:31 PM Daniel Walker wrote: > > > > On Tue, Mar 30, 2021 at 03:13:04PM -0500, Rob Herring wrote: > > > On Tue, Mar 30, 2021 at 12:33 PM Daniel Walker wrote: > > > > > > > > On Thu, Mar 25, 2021 at 05:29:44PM

Re: [PATCH V4 XRT Alveo 06/20] fpga: xrt: char dev node helper functions

2021-04-06 Thread Max Zhen
On 3/30/21 6:45 AM, Tom Rix wrote: CAUTION: This message has originated from an External Source. Please use proper judgment and caution when opening attachments, clicking links, or responding to this email. It is unclear from the changelog if this new patch was split from an existing

[PATCH][next] erofs: fix uninitialized variable i used in a while-loop

2021-04-06 Thread Colin King
From: Colin Ian King The while-loop iterates until src is non-null or i is 3, however, the loop counter i is not intinitialied to zero, causing incorrect iteration counts. Fix this by initializing it to zero. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 1aa5f2e2feed ("erofs:

Re: [PATCH 1/2] perf util: move bperf definitions to a libperf header

2021-04-06 Thread Song Liu
> On Apr 6, 2021, at 7:21 AM, Jiri Olsa wrote: > > On Fri, Apr 02, 2021 at 05:29:37PM -0700, Song Liu wrote: >> By following the same protocol, other tools can share hardware PMCs with >> perf. Move perf_event_attr_map_entry and BPERF_DEFAULT_ATTR_MAP_PATH to >> bperf.h for other tools to

Re: [PATCH v3] mm: slub: move sysfs slab alloc/free interfaces to debugfs

2021-04-06 Thread kernel test robot
Hi Faiyaz, Thank you for the patch! Yet something to improve: [auto build test ERROR on v5.12-rc6] [cannot apply to hnaz-linux-mm/master next-20210406] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented

Re: [PATCH v6 01/27] mm: Introduce struct folio

2021-04-06 Thread Matthew Wilcox
On Tue, Apr 06, 2021 at 04:05:50PM +0100, Christoph Hellwig wrote: > On Tue, Apr 06, 2021 at 03:55:11PM +0100, Matthew Wilcox wrote: > > Assuming we're getting rid of them all though, we have to include: > > > > $ git grep 'page->mapping' fs |wc -l > > 358 > > $ git grep 'page->index' fs |wc -l >

[PATCH] KVM: x86/mmu: preserve pending TLB flush across calls to kvm_tdp_mmu_zap_sp

2021-04-06 Thread Paolo Bonzini
Right now, if a call to kvm_tdp_mmu_zap_sp returns false, the caller will skip the TLB flush, which is wrong. There are two ways to fix it: - since kvm_tdp_mmu_zap_sp will not yield and therefore will not flush the TLB itself, we could change the call to kvm_tdp_mmu_zap_sp to use "flush |=

Re: rtlwifi/rtl8192cu AP mode broken with PS STA

2021-04-06 Thread Larry Finger
On 4/6/21 7:06 AM, Maciej S. Szmigiero wrote: On 06.04.2021 12:00, Kalle Valo wrote: "Maciej S. Szmigiero" writes: On 29.03.2021 00:54, Maciej S. Szmigiero wrote: Hi, It looks like rtlwifi/rtl8192cu AP mode is broken when a STA is using PS, since the driver does not update its beacon to

Re: [PATCH] tty: use printk_safe context at tty_msg()

2021-04-06 Thread Tetsuo Handa
On 2021/04/07 0:10, Petr Mladek wrote: >> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c >> index 6d4995a5f318..d59f7873bc49 100644 >> --- a/drivers/tty/tty_buffer.c >> +++ b/drivers/tty/tty_buffer.c >> @@ -156,6 +156,7 @@ static struct tty_buffer *tty_buffer_alloc(struct >>

Re: [PATCH v4 02/16] perf/x86/intel: Handle guest PEBS overflow PMI for KVM guest

2021-04-06 Thread Peter Zijlstra
On Mon, Mar 29, 2021 at 01:41:23PM +0800, Like Xu wrote: > With PEBS virtualization, the guest PEBS records get delivered to the > guest DS, and the host pmi handler uses perf_guest_cbs->is_in_guest() > to distinguish whether the PMI comes from the guest code like Intel PT. > > No matter how many

Re: [PATCH] powerpc/perf: prevent mixed EBB and non-EBB events

2021-04-06 Thread Athira Rajeev
> On 05-Mar-2021, at 11:20 AM, Athira Rajeev > wrote: > > > >> On 24-Feb-2021, at 5:51 PM, Thadeu Lima de Souza Cascardo >> wrote: >> >> EBB events must be under exclusive groups, so there is no mix of EBB and >> non-EBB events on the same PMU. This requirement worked fine as perf core

Re: linux-next: manual merge of the driver-core tree with the devicetree tree

2021-04-06 Thread Saravana Kannan
On Tue, Apr 6, 2021 at 2:11 AM Greg KH wrote: > > On Tue, Apr 06, 2021 at 06:19:45PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the driver-core tree got a conflict in: > > > > drivers/of/property.c > > > > between commit: > > > > 3915fed92365 ("of:

Re: [PATCH v3 08/15] arm64: socfpga: merge Agilex and N5X into ARCH_INTEL_SOCFPGA

2021-04-06 Thread Krzysztof Kozlowski
On Tue, 6 Apr 2021 at 18:10, Guenter Roeck wrote: > > On Thu, Mar 11, 2021 at 04:25:38PM +0100, Krzysztof Kozlowski wrote: > > Agilex, N5X and Stratix 10 share all quite similar arm64 hard cores and > > SoC-part. Up to a point that N5X uses the same DTSI as Agilex. From > > the Linux kernel

Re: [PATCH] cgroup: Relax restrictions on kernel threads moving out of root cpu cgroup

2021-04-06 Thread Tejun Heo
Hello, On Tue, Apr 06, 2021 at 08:57:15PM +0530, Pavan Kondeti wrote: > Yeah. The workqueue attrs comes in handy to reduce the nice/prio of a > background workqueue if we identify that it is cpu intensive. However, this > needs case by case analysis, tweaking etc. If there is no other

Re: [RFC v1 23/26] x86/tdx: Make pages shared in ioremap()

2021-04-06 Thread Dave Hansen
On 4/6/21 9:00 AM, Kirill A. Shutemov wrote: >>> --- a/arch/x86/mm/ioremap.c >>> +++ b/arch/x86/mm/ioremap.c >>> @@ -87,12 +87,12 @@ static unsigned int __ioremap_check_ram(struct resource >>> *res) >>> } >>> >>> /* >>> - * In a SEV guest, NONE and RESERVED should not be mapped encrypted

Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-06 Thread Chun-Kuang Hu
Andrew Lunn 於 2021年4月7日 週三 上午12:02寫道: > > On Tue, Apr 06, 2021 at 11:47:08PM +0800, Chun-Kuang Hu wrote: > > Hi, Qingfang: > > > > DENG Qingfang 於 2021年4月6日 週二 下午10:19寫道: > > > > > > Add support for MediaTek PHYs found in MT7530 and MT7531 switches. > > > The initialization procedure is from the

Re: [PATCH 1/4] hwtracing: Add trace function support for HiSilicon PCIe Tune and Trace device

2021-04-06 Thread kernel test robot
Hi Yicong, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.12-rc6 next-20210406] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [PATCH v3] sched/fair: bring back select_idle_smt, but differently

2021-04-06 Thread Vincent Guittot
On Tue, 6 Apr 2021 at 17:55, Rik van Riel wrote: > > On Tue, 2021-04-06 at 17:31 +0200, Vincent Guittot wrote: > > On Tue, 6 Apr 2021 at 17:26, Rik van Riel wrote: > > > On Tue, 2021-04-06 at 17:10 +0200, Vincent Guittot wrote: > > > > On Fri, 26 Mar 2021 at 20:19, Rik van Riel > > > > wrote: >

Re: KCSAN: data-race in __jbd2_journal_file_buffer / jbd2_journal_dirty_metadata

2021-04-06 Thread Jan Kara
On Tue 06-04-21 11:01:39, Theodore Ts'o wrote: > On Tue, Apr 06, 2021 at 02:32:33PM +0200, Jan Kara wrote: > > And the comment explains, why we do this unreliable check. Again, if we > > wanted to silence KCSAN, we could use data_race() macro but AFAIU Ted isn't > > very fond of that annotation. >

Re: [RFC v1 22/26] x86/tdx: Exclude Shared bit from __PHYSICAL_MASK

2021-04-06 Thread Dave Hansen
On 4/6/21 8:54 AM, Kirill A. Shutemov wrote: > On Thu, Apr 01, 2021 at 01:13:16PM -0700, Dave Hansen wrote: >>> @@ -56,6 +61,9 @@ static void tdx_get_info(void) >>> >>> td_info.gpa_width = rcx & GENMASK(5, 0); >>> td_info.attributes = rdx; >>> + >>> + /* Exclude Shared bit from the

Re: disk-io.c:undefined reference to `atomic64_set_386'

2021-04-06 Thread Randy Dunlap
On 4/6/21 7:43 AM, David Sterba wrote: > On Thu, Apr 01, 2021 at 12:34:38AM +0800, kernel test robot wrote: >> Hi Josef, >> >> FYI, the error/warning still remains. >> >> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git >> master >> head:

[PATCH] staging: rtl8723bs: core: Move constants to the right of comparison

2021-04-06 Thread Zhansaya Bagdauletkyzy
Move constant variables to the right side of comparisons to increase consistency with Linux kernel code base. Reported by checkpatch. Signed-off-by: Zhansaya Bagdauletkyzy --- drivers/staging/rtl8723bs/core/rtw_pwrctrl.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

Re: [RFC v1 21/26] x86/mm: Move force_dma_unencrypted() to common code

2021-04-06 Thread Dave Hansen
On 4/6/21 8:37 AM, Kirill A. Shutemov wrote: > On Thu, Apr 01, 2021 at 01:06:29PM -0700, Dave Hansen wrote: >> On 2/5/21 3:38 PM, Kuppuswamy Sathyanarayanan wrote: >>> From: "Kirill A. Shutemov" >>> >>> Intel TDX doesn't allow VMM to access guest memory. Any memory that is >>> required for

Re: [PATCH RFC 1/1] kernel/cpu: to track which CPUHP callback is failed

2021-04-06 Thread Qais Yousef
On 04/05/21 14:22, Dongli Zhang wrote: > May I have if there is any feedback on this? To pr_err_once() here helps > narrow > down what is the root cause of cpu online failure. > > > The issue fixed by d7eb79c6290c ("KVM: kvmclock: Fix vCPUs > 64 can't be > online/hotpluged") is able to

Re: [PATCH v3 08/15] arm64: socfpga: merge Agilex and N5X into ARCH_INTEL_SOCFPGA

2021-04-06 Thread Guenter Roeck
On Thu, Mar 11, 2021 at 04:25:38PM +0100, Krzysztof Kozlowski wrote: > Agilex, N5X and Stratix 10 share all quite similar arm64 hard cores and > SoC-part. Up to a point that N5X uses the same DTSI as Agilex. From > the Linux kernel point of view these are flavors of the same > architecture so

Re: [PATCH v3 1/4] KVM: x86: Fix a spurious -E2BIG in KVM_GET_EMULATED_CPUID

2021-04-06 Thread Sean Christopherson
On Tue, Apr 06, 2021, Vitaly Kuznetsov wrote: > Emanuele Giuseppe Esposito writes: > > > When retrieving emulated CPUID entries, check for an insufficient array > > size if and only if KVM is actually inserting an entry. > > If userspace has a priori knowledge of the exact array size, > >

Re: [PATCH 0/9] sched: Core scheduling interfaces

2021-04-06 Thread Tejun Heo
Hello, On Tue, Apr 06, 2021 at 05:32:04PM +0200, Peter Zijlstra wrote: > > I find it difficult to like the proposed interface from the name (the term > > "core" is really confusing given how the word tends to be used internally) > > to the semantics (it isn't like anything else) and even the

Re: [PATCH v11 08/13] KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS hypercall

2021-04-06 Thread Ashish Kalra
On Tue, Apr 06, 2021 at 03:48:20PM +, Sean Christopherson wrote: > On Mon, Apr 05, 2021, Ashish Kalra wrote: > > From: Ashish Kalra > > ... > > > diff --git a/arch/x86/include/asm/kvm_host.h > > b/arch/x86/include/asm/kvm_host.h > > index 3768819693e5..78284ebbbee7 100644 > > ---

Re: [PATCH v3 1/4] KVM: x86: Fix a spurious -E2BIG in KVM_GET_EMULATED_CPUID

2021-04-06 Thread Sean Christopherson
On Tue, Apr 06, 2021, Emanuele Giuseppe Esposito wrote: > When retrieving emulated CPUID entries, check for an insufficient array > size if and only if KVM is actually inserting an entry. > If userspace has a priori knowledge of the exact array size, > KVM_GET_EMULATED_CPUID will incorrectly fail

Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-06 Thread Chun-Kuang Hu
DENG Qingfang 於 2021年4月6日 週二 下午11:57寫道: > > On Tue, Apr 6, 2021 at 11:47 PM Chun-Kuang Hu wrote: > > > > Hi, Qingfang: > > > > DENG Qingfang 於 2021年4月6日 週二 下午10:19寫道: > > > --- a/drivers/net/phy/Kconfig > > > +++ b/drivers/net/phy/Kconfig > > > @@ -207,6 +207,11 @@ config MARVELL_88X_PHY >

Re: [PATCH 1/5] x509: add support for rsa-pss

2021-04-06 Thread kernel test robot
Hi Hongbo, Thank you for the patch! Yet something to improve: [auto build test ERROR on crypto/master] [also build test ERROR on security/next-testing linus/master v5.12-rc6 next-20210406] [cannot apply to cryptodev/master] [If your patch is applied to the wrong git tree, kindly drop us a note

Re: [PATCH bpf-next v2 3/6] bpf: Add a bpf_snprintf helper

2021-04-06 Thread Florent Revest
On Fri, Mar 26, 2021 at 11:55 PM Andrii Nakryiko wrote: > On Tue, Mar 23, 2021 at 7:23 PM Florent Revest wrote: > > The implementation takes inspiration from the existing bpf_trace_printk > > helper but there are a few differences: > > > > To allow for a large number of format-specifiers,

Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-06 Thread Andrew Lunn
On Tue, Apr 06, 2021 at 11:57:14PM +0800, DENG Qingfang wrote: > On Tue, Apr 6, 2021 at 11:47 PM Chun-Kuang Hu wrote: > > > > Hi, Qingfang: > > > > DENG Qingfang 於 2021年4月6日 週二 下午10:19寫道: > > > --- a/drivers/net/phy/Kconfig > > > +++ b/drivers/net/phy/Kconfig > > > @@ -207,6 +207,11 @@ config

Re: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-06 Thread matthew . gerlach
Hi Moritz, On Mon, 5 Apr 2021, Moritz Fischer wrote: Hi Matthew, On Mon, Apr 05, 2021 at 04:53:00PM -0700, matthew.gerl...@linux.intel.com wrote: From: Matthew Gerlach This patch adds DFL bus driver for the Altera SPI Master controller. The SPI master is connected to an Intel SPI Slave

[PATCH RESEND] lib/scatterlist: Fix NULL pointer deference

2021-04-06 Thread Ricardo Ribalda
When sg_alloc_table_from_pages is called with n_pages = 0, we write in a non-allocated page. Fix it by checking early the error condition. [7.666801] BUG: kernel NULL pointer dereference, address: 0010 [7.667487] #PF: supervisor read access in kernel mode [7.667970] #PF:

Re: [PATCH 11/13] lib: add fast path for find_first_*_bit() and find_last_bit()

2021-04-06 Thread Guenter Roeck
On Mon, Mar 15, 2021 at 06:54:22PM -0700, Yury Norov wrote: > Similarly to bitmap functions, users would benefit if we'll handle > a case of small-size bitmaps that fit into a single word. > > While here, move the find_last_bit() declaration to bitops/find.h > where other find_*_bit() functions

Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-06 Thread Andrew Lunn
On Tue, Apr 06, 2021 at 11:47:08PM +0800, Chun-Kuang Hu wrote: > Hi, Qingfang: > > DENG Qingfang 於 2021年4月6日 週二 下午10:19寫道: > > > > Add support for MediaTek PHYs found in MT7530 and MT7531 switches. > > The initialization procedure is from the vendor driver, but due to lack > > of documentation,

Re: [RFC net-next 2/4] net: dsa: mt7530: add interrupt support

2021-04-06 Thread DENG Qingfang
On Tue, Apr 6, 2021 at 11:49 PM Andrew Lunn wrote: > O.K. So that makes it similar to the mv88e6xxx. With that driver, i > kept interrupt setup and mdio setup separate. I add the interrupt > controller first, and then do mdio setup, calling a helper to map the > PHY interrupts and assign them to

[Outreachy kernel] [PATCH v3] staging: rtl8723bs: hal: Remove camelcase in Hal8723BReg.h

2021-04-06 Thread Fabio M. De Francesco
Remove camelcase in some symbols defined in Hal8723BReg.h. These symbols are not used anywhere else, therefore this patch does not break the driver. Signed-off-by: Fabio M. De Francesco --- Patch v3 changes nothing with respect to v2 and v1. It exists only to cc some recipients that were

Re: [RFC v1 23/26] x86/tdx: Make pages shared in ioremap()

2021-04-06 Thread Kirill A. Shutemov
On Thu, Apr 01, 2021 at 01:26:23PM -0700, Dave Hansen wrote: > On 2/5/21 3:38 PM, Kuppuswamy Sathyanarayanan wrote: > > From: "Kirill A. Shutemov" > > > > All ioremap()ed paged that are not backed by normal memory (NONE or > > RESERVED) have to be mapped as shared. > > s/paged/pages/ > > > >

Re: [PATCH v4 3/3] sched/fair: Introduce a CPU capacity comparison helper

2021-04-06 Thread Valentin Schneider
On 06/04/21 17:37, Dietmar Eggemann wrote: > On 01/04/2021 21:30, Valentin Schneider wrote: >> While at it, replace group_smaller_{min, max}_cpu_capacity() with >> comparisons of the source group's min/max capacity and the destination >> CPU's capacity. > > IMHO, you haven't mentioned why you

Re: [PATCH -next] NFSD: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Chuck Lever III
Hello- > On Apr 6, 2021, at 8:08 AM, Huang Guobin wrote: > > From: Guobin Huang > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). > > Reported-by: Hulk Robot > Signed-off-by: Guobin Huang This change has been pushed to

[PATCH v2] staging: rtl8723bs: core: reorganize characters so the lines are under 100 ch

2021-04-06 Thread Beatriz Martins de Carvalho
Cleans up warnings of "line over 100 characters" but avoiding more than 90 characters in file rtw_ap.c Signed-off-by: Beatriz Martins de Carvalho --- Changes in v2: - revert some cleans up warning previously applied wrong This patch came from patch series that could find in:

Re: [PATCH] sunrpc: Remove unused function ip_map_lookup

2021-04-06 Thread Chuck Lever III
Hello- > On Apr 5, 2021, at 11:46 PM, Jiapeng Chong > wrote: > > Fix the following clang warnings: > > net/sunrpc/svcauth_unix.c:306:30: warning: unused function > 'ip_map_lookup' [-Wunused-function]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong This has been pushed to the

Re: [RFC net-next 1/4] net: phy: add MediaTek PHY driver

2021-04-06 Thread DENG Qingfang
On Tue, Apr 6, 2021 at 11:47 PM Chun-Kuang Hu wrote: > > Hi, Qingfang: > > DENG Qingfang 於 2021年4月6日 週二 下午10:19寫道: > > --- a/drivers/net/phy/Kconfig > > +++ b/drivers/net/phy/Kconfig > > @@ -207,6 +207,11 @@ config MARVELL_88X_PHY > > Support for the Marvell 88X Dual-port

[PATCH v3] ACPI: processor: Fix build when CONFIG_ACPI_PROCESSOR=m

2021-04-06 Thread Vitaly Kuznetsov
Commit 8c182bd7 ("ACPI: processor: Fix CPU0 wakeup in acpi_idle_play_dead()") tried to fix CPU0 hotplug breakage by copying wakeup_cpu0() + start_cpu0() logic from hlt_play_dead()//mwait_play_dead() into acpi_idle_play_dead(). The problem is that these functions are not exported to modules so

Re: [PATCH v4 1/3] sched/fair: Ignore percpu threads for imbalance pulls

2021-04-06 Thread Valentin Schneider
On 06/04/21 17:35, Dietmar Eggemann wrote: > On 01/04/2021 21:30, Valentin Schneider wrote: >> From: Lingutla Chandrasekhar >> >> During load balance, LBF_SOME_PINNED will bet set if any candidate task > > nitpick; s/bet/be ? > Yes indeed... > [...] > > Reviewed-by: Dietmar Eggemann

Re: [PATCH -next] NFSD: Use DEFINE_SPINLOCK() for spinlock

2021-04-06 Thread Bruce Fields
On Tue, Apr 06, 2021 at 03:46:34PM +, Chuck Lever III wrote: > > > > On Apr 6, 2021, at 8:08 AM, Huang Guobin wrote: > > > > From: Guobin Huang > > > > spinlock can be initialized automatically with DEFINE_SPINLOCK() > > rather than explicitly calling spin_lock_init(). > > > >

Re: [PATCH v3] sched/fair: bring back select_idle_smt, but differently

2021-04-06 Thread Rik van Riel
On Tue, 2021-04-06 at 17:31 +0200, Vincent Guittot wrote: > On Tue, 6 Apr 2021 at 17:26, Rik van Riel wrote: > > On Tue, 2021-04-06 at 17:10 +0200, Vincent Guittot wrote: > > > On Fri, 26 Mar 2021 at 20:19, Rik van Riel > > > wrote: > > > > > > > -static int select_idle_cpu(struct task_struct

Re: [RFC v1 22/26] x86/tdx: Exclude Shared bit from __PHYSICAL_MASK

2021-04-06 Thread Kirill A. Shutemov
On Thu, Apr 01, 2021 at 01:13:16PM -0700, Dave Hansen wrote: > > @@ -56,6 +61,9 @@ static void tdx_get_info(void) > > > > td_info.gpa_width = rcx & GENMASK(5, 0); > > td_info.attributes = rdx; > > + > > + /* Exclude Shared bit from the __PHYSICAL_MASK */ > > + physical_mask &=

Re: [PATCH 1/2] zram: fix crashes due to use of cpu hotplug multistate

2021-04-06 Thread Josh Poimboeuf
On Tue, Apr 06, 2021 at 02:00:19PM +0200, Miroslav Benes wrote: > Hi, > > > > Driver developers will simply have to open code these protections. In > > > light of what I see on LTP / fuzzing, I suspect the use case will grow > > > and we'll have to revisit this in the future. But for now, sure,

[bug report] Memory leak from acpi_ev_install_space_handler()

2021-04-06 Thread John Garry
Hi guys, On next-20210406, I enabled CONFIG_DEBUG_KMEMLEAK and CONFIG_DEBUG_TEST_DRIVER_REMOVE for my arm64 system, and see this: root@debian:/home/john# more /sys/kernel/debug/kmemleak unreferenced object 0x202803c11f00 (size 128): comm "swapper/0", pid 1, jiffies 4294894325 (ag

[PATCH v1 1/2] dt-bindings: pwm: convert pwm-rockchip.txt to YAML

2021-04-06 Thread Johan Jonker
Current dts files with 'pwm' nodes are manually verified. In order to automate this process pwm-rockchip.txt has to be converted to yaml. Signed-off-by: Johan Jonker --- .../devicetree/bindings/pwm/pwm-rockchip.txt | 27 - .../devicetree/bindings/pwm/pwm-rockchip.yaml | 66

[PATCH v1 2/2] dt-bindings: pwm: add more compatible strings to pwm-rockchip.yaml

2021-04-06 Thread Johan Jonker
The compatible strings below are already in use in the Rockchip dtsi files, but were somehow never added to a document, so add "rockchip,rk3328-pwm" "rockchip,rk3036-pwm", "rockchip,rk2928-pwm" "rockchip,rk3368-pwm", "rockchip,rk3288-pwm" "rockchip,rk3399-pwm", "rockchip,rk3288-pwm"

[PATCH 3/5] x86/speculation: Introduce SPEC_CTRL_MSR bit for PSFD

2021-04-06 Thread Ramakrishna Saripalli
From: Ramakrishna Saripalli All AMD processors that support PSF implement a bit in SPEC_CTRL MSR (0x48) to disable or enable Predictive Store Forwarding. Signed-off-by: Ramakrishna Saripalli --- arch/x86/include/asm/msr-index.h | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH 5/5] x86/speculation: Add PSF mitigation kernel parameters

2021-04-06 Thread Ramakrishna Saripalli
From: Ramakrishna Saripalli PSF mitigation introduces new kernel parameters. The kernel parameters for PSF mitigation are modeled after spec_store_bypass_disable. Signed-off-by: Ramakrishna Saripalli --- .../admin-guide/kernel-parameters.txt | 45 +++ 1 file changed,

[PATCH 4/5] x86/speculation: Implement PSF mitigation support

2021-04-06 Thread Ramakrishna Saripalli
From: Ramakrishna Saripalli Implement support for PSF mitigation via kernel parameters. On AMD processors that support Predictive Store Forwarding(PSF), the disabling of Speculative Store Bypass(SSB) will also disable PSF. Two kernel parameters are being introduced to enable PSF mitigation.

[PATCH 2/5] x86/speculation: Implement support for PSFD detection and reporting

2021-04-06 Thread Ramakrishna Saripalli
From: Ramakrishna Saripalli All AMD processors that support Predictive Store Forwarding (PSF) provide a CPUID bit to detect support for mitigation of this feature. This bit is referred to as PSFD (Predictive Store Forwarding Disable) If CPU advertises PSFD: - Advertise a generic feature

[PATCH 1/5] x86/cpufeatures: Define feature bits to support mitigation of PSF

2021-04-06 Thread Ramakrishna Saripalli
From: Ramakrishna Saripalli Certain AMD processors feature a new technology called Predictive Store Forwarding (PSF). PSF is a micro-architectural optimization designed to improve the performance of code execution by predicting dependencies between loads and stores. Incorrect PSF predictions

<    2   3   4   5   6   7   8   9   10   11   >