A cry for help

2021-04-09 Thread Miss Farrina kipkalya
My dearest, I am writing this mail to you with tears and sorrow from my heart. With due respect, trust and humanity, i appeal to you to exercise a little patience and read through my letter i feel quite safe dealing with you in this important business having gone through your remarkable profile,

Re: [PATCH] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove

2021-04-09 Thread Michal Hocko
On Fri 09-04-21 13:09:57, Mel Gorman wrote: > zone_pcp_reset allegedly protects against a race with drain_pages > using local_irq_save but this is bogus. local_irq_save only operates > on the local CPU. If memory hotplug is running on CPU A and drain_pages > is running on CPU B, disabling IRQs on

Re: [PATCH v4] lib/string: Introduce sysfs_streqcase

2021-04-09 Thread Gioh Kim
On Fri, Apr 9, 2021 at 9:11 AM Andy Shevchenko wrote: > > > > On Friday, April 9, 2021, Andrew Morton wrote: >> >> On Thu, 8 Apr 2021 15:06:05 +0200 Gioh Kim wrote: >> >> > As the name shows, it checks if strings are equal in case insensitive >> > manner. >> >> Peh. Who would die if we simply

[PATCH 3/3] staging: rtl8723bs: remove MSG_8192C macro definitions

2021-04-09 Thread Fabio Aiuto
remove obsolete MSG_8192C macro definitions. MSG_8192C is a private trace mechanism macro and is deactivated. (i.e. the default behaviour is _do nothing_) The only way to activate it is to manually define a debug symbol. So just remove it. Signed-off-by: Fabio Aiuto ---

[PATCH 2/3] staging: rtl8723bs: remove commented out MSG_8192C log

2021-04-09 Thread Fabio Aiuto
remove commented out MSG_8192C log. MSG_8192C is a private trace mechanism macro and is deactivated. (i.e. the default behaviour is _do nothing_) The only way to activate it is to manually define a debug symbol. So just remove it. Signed-off-by: Fabio Aiuto ---

[PATCH 1/3] staging: rtl8723bs: remove all MSG_8192C logs

2021-04-09 Thread Fabio Aiuto
remove all MSG_8192C logs. MSG_8192C is a private trace mechanism macro and is deactivated. (i.e. the default behaviour is _do nothing_) The only way to activate it is to manually define a debug symbol. So just remove it. Signed-off-by: Fabio Aiuto ---

[PATCH 0/3] staging: rtl8723bs: remove MGS_8192C trace logs

2021-04-09 Thread Fabio Aiuto
This patchset removes the tracing private macro MSG_8192C. This macro belongs to a redundant driver specific tracing macro family. Moreover the default behaviour is _do nothing_ as to activate it, it's necessary to hardcode a DEBUG symbol definition. Fabio Aiuto (3): staging: rtl8723bs:

Re: [PATCH v3] drivers: introduce and use WANT_DMA_CMA for soft dependencies on DMA_CMA

2021-04-09 Thread Linus Walleij
On Fri, Apr 9, 2021 at 1:20 PM David Hildenbrand wrote: > Random drivers should not override a user configuration of core knobs > (e.g., CONFIG_DMA_CMA=n). Applicable drivers would like to use DMA_CMA, > which depends on CMA, if possible; however, these drivers also have to > tolerate if DMA_CMA

Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions

2021-04-09 Thread David Howells
Matthew Wilcox wrote: > iirc i looked at doing this as part of the folio work, and it ended up > increasing the size of the kernel. Did you run bloat-o-meter on the > result of doing this? add/remove: 2/2 grow/shrink: 15/16 up/down: 408/-599 (-191) Function

Re: [PATCH v4 1/4] KVM: x86: Fix a spurious -E2BIG in KVM_GET_EMULATED_CPUID

2021-04-09 Thread Emanuele Giuseppe Esposito
On 08/04/2021 22:29, Sean Christopherson wrote: On Thu, Apr 08, 2021, Emanuele Giuseppe Esposito wrote: When retrieving emulated CPUID entries, check for an insufficient array size if and only if KVM is actually inserting an entry. If userspace has a priori knowledge of the exact array size,

[RFC PATCH v2 18/18] mm: lru: use lruvec lock to serialize memcg changes

2021-04-09 Thread Muchun Song
As described by commit fc574c23558c ("mm/swap.c: serialize memcg changes in pagevec_lru_move_fn"), TestClearPageLRU() aims to serialize mem_cgroup_move_account() during pagevec_lru_move_fn(). Now lock_page_lruvec*() has the ability to detect whether page memcg has been changed. So we can use

[RFC PATCH v2 16/18] mm: memcontrol: rename {un}lock_page_memcg() to {un}lock_page_objcg()

2021-04-09 Thread Muchun Song
Now the lock_page_memcg() does not lock a page and memcg binding, it actually lock a page and objcg binding. So rename lock_page_memcg() to lock_page_objcg(). This is just code cleanup without any functionality changes. Signed-off-by: Muchun Song ---

[RFC PATCH v2 13/18] mm: memcontrol: make all the callers of page_memcg() safe

2021-04-09 Thread Muchun Song
When we use objcg APIs to charge the LRU pages, the page will not hold a reference to the memcg associated with the page. So the caller of the page_memcg() should hold an rcu read lock or obtain a reference to the memcg associated with the page to protect memcg from being released. So introduce

[RFC PATCH v2 17/18] mm: lru: add VM_BUG_ON_PAGE to lru maintenance function

2021-04-09 Thread Muchun Song
We need to make sure that the page is deleted from or added to the correct lruvec list. So add a VM_BUG_ON_PAGE() to catch invalid users. Signed-off-by: Muchun Song --- include/linux/mm_inline.h | 6 ++ mm/vmscan.c | 1 - 2 files changed, 6 insertions(+), 1 deletion(-) diff

[RFC PATCH v2 14/18] mm: memcontrol: introduce memcg_reparent_ops

2021-04-09 Thread Muchun Song
In the previous patch, we know how to make the lruvec lock safe when the LRU pages reparented. We should do something like following. memcg_reparent_objcgs(memcg) 1) lock // lruvec belongs to memcg and lruvec_parent belongs to parent memcg. spin_lock(>lru_lock);

[RFC PATCH v2 15/18] mm: memcontrol: use obj_cgroup APIs to charge the LRU pages

2021-04-09 Thread Muchun Song
We will reuse the obj_cgroup APIs to charge the LRU pages. Finally, page->memcg_data will have 2 different meanings. - For the slab pages, page->memcg_data points to an object cgroups vector. - For the kmem pages (exclude the slab pages) and the LRU pages, page->memcg_data points to

[RFC PATCH v2 12/18] mm: thp: make deferred split queue lock safe when the LRU pages reparented

2021-04-09 Thread Muchun Song
Similar to lruvec lock, we use the same approach to make the lock safe when the LRU pages reparented. Signed-off-by: Muchun Song --- mm/huge_memory.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 275dbfc8b2ae..aa5d7b72d5fc

[RFC PATCH v2 11/18] mm: thp: introduce lock/unlock_split_queue{_irqsave}()

2021-04-09 Thread Muchun Song
We should make thp deferred split queue lock safe when LRU pages reparented. Similar to lock_page_lruvec{_irqsave, _irq}(), we introduce lock/unlock_split_queue{_irqsave}() to make the deferred split queue lock easier to be reparented. And in the next patch, we can use a similar approach (just

[RFC PATCH v2 10/18] mm: vmscan: rework move_pages_to_lru()

2021-04-09 Thread Muchun Song
In the later patch, we will reparent the LRU pages. The pages which will move to appropriate LRU list can be reparented during the process of the move_pages_to_lru(). So holding a lruvec lock by the caller is wrong, we should use the more general interface of relock_page_lruvec_irq() to acquire

[RFC PATCH v2 09/18] mm: vmscan: remove noinline_for_stack

2021-04-09 Thread Muchun Song
The noinline_for_stack is introduced by commit 666356297ec4 ("vmscan: set up pagevec as late as possible in shrink_inactive_list()"), its purpose is to delay the allocation of pagevec as late as possible to save stack memory. But the commit 2bcf88796381 ("mm: take pagevecs off reclaim stack")

[RFC PATCH v2 08/18] mm: memcontrol: make lruvec lock safe when the LRU pages reparented

2021-04-09 Thread Muchun Song
The diagram below shows how to make the page lruvec lock safe when the LRU pages reparented. lock_page_lruvec(page) retry: lruvec = mem_cgroup_page_lruvec(page); // The page is reparented at this time. spin_lock(>lru_lock); if (unlikely(lruvec_memcg(lruvec)

[RFC PATCH v2 07/18] mm: memcontrol: introduce compact_lock_page_lruvec_irqsave

2021-04-09 Thread Muchun Song
If we reuse the objcg APIs to charge LRU pages, the page_memcg() can be changed when the LRU pages reparented. In this case, we need to acquire the new lruvec lock. lruvec = mem_cgroup_page_lruvec(page); // The page is reparented. compact_lock_irqsave(>lru_lock, , cc); //

[RFC PATCH v2 06/18] mm: memcontrol: move the objcg infrastructure out of CONFIG_MEMCG_KMEM

2021-04-09 Thread Muchun Song
Because memory allocations pinning memcgs for a long time - it exists at a larger scale and is causing recurring problems in the real world: page cache doesn't get reclaimed for a long time, or is used by the second, third, fourth, ... instance of the same job that was restarted into a new cgroup

[RFC PATCH v2 05/18] mm: memcontrol: simplify the logic of objcg pinning memcg

2021-04-09 Thread Muchun Song
The obj_cgroup_release() and memcg_reparent_objcgs() are serialized by the css_set_lock. We do not need to care about objcg->memcg being released in the process of obj_cgroup_release(). So there is no need to pin memcg before releasing objcg. Remove those pinning logic to simplfy the code. There

[RFC PATCH v2 04/18] mm: memcontrol: simplify lruvec_holds_page_lru_lock

2021-04-09 Thread Muchun Song
We already have a helper lruvec_memcg() to get the memcg from lruvec, we do not need to do it ourselves in the lruvec_holds_page_lru_lock(). So use lruvec_memcg() instead. And if mem_cgroup_disabled() returns false, the page_memcg(page) (the LRU pages) cannot be NULL. So remove the odd logic of

[RFC PATCH v2 03/18] mm: memcontrol: remove the pgdata parameter of mem_cgroup_page_lruvec

2021-04-09 Thread Muchun Song
All the callers of mem_cgroup_page_lruvec() just pass page_pgdat(page) as the 2nd parameter to it (except isolate_migratepages_block()). But for isolate_migratepages_block(), the page_pgdat(page) is also equal to the local variable of @pgdat. So mem_cgroup_page_lruvec() do not need the pgdat

[RFC PATCH v2 02/18] mm: memcontrol: bail out early when !mm in get_mem_cgroup_from_mm

2021-04-09 Thread Muchun Song
When mm is NULL, we do not need to hold rcu lock and call css_tryget for the root memcg. And we also do not need to check !mm in every loop of while. So bail out early when !mm. Signed-off-by: Muchun Song Acked-by: Johannes Weiner --- mm/memcontrol.c | 21 ++--- 1 file changed,

[RFC PATCH v2 01/18] mm: memcontrol: fix page charging in page replacement

2021-04-09 Thread Muchun Song
The pages aren't accounted at the root level, so do not charge the page to the root memcg in page replacement. Although we do not display the value (mem_cgroup_usage) so there shouldn't be any actual problem, but there is a WARN_ON_ONCE in the page_counter_cancel(). Who knows if it will trigger?

[RFC PATCH v2 00/18] Use obj_cgroup APIs to charge the LRU pages

2021-04-09 Thread Muchun Song
Since the following patchsets applied. All the kernel memory are charged with the new APIs of obj_cgroup. [v17,00/19] The new cgroup slab memory controller [v5,0/7] Use obj_cgroup APIs to charge kmem pages But user memory allocations (LRU pages) pinning memcgs for a long time -

RE: [PATCH rdma-next 4/8] IB/core: Skip device which doesn't have necessary capabilities

2021-04-09 Thread Parav Pandit
> From: Jason Gunthorpe > Sent: Thursday, April 8, 2021 5:46 PM > On Wed, Apr 07, 2021 at 03:44:35PM +, Parav Pandit wrote: > > > > If it returns EOPNOTUPP then the remove is never called so if it > > > allocated memory and left it allocated then it is leaking memory. > > > > > I probably

Re: [PATCH v3] drivers: introduce and use WANT_DMA_CMA for soft dependencies on DMA_CMA

2021-04-09 Thread Lucas Stach
Am Freitag, dem 09.04.2021 um 13:20 +0200 schrieb David Hildenbrand: > Random drivers should not override a user configuration of core knobs > (e.g., CONFIG_DMA_CMA=n). Applicable drivers would like to use DMA_CMA, > which depends on CMA, if possible; however, these drivers also have to > tolerate

[syzbot] BUG: corrupted list in klist_dec_and_del

2021-04-09 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:e49d033b Linux 5.12-rc6 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=167accfcd0 kernel config: https://syzkaller.appspot.com/x/.config?x=f91155ccddaf919c dashboard link:

Re: [RFC PATCH v2 3/4] arm64: Detect FTRACE cases that make the stack trace unreliable

2021-04-09 Thread Mark Rutland
On Mon, Apr 05, 2021 at 03:43:12PM -0500, madve...@linux.microsoft.com wrote: > From: "Madhavan T. Venkataraman" > > When CONFIG_DYNAMIC_FTRACE_WITH_REGS is enabled and tracing is activated > for a function, the ftrace infrastructure is called for the function at > the very beginning. Ftrace

Re: [PATCH v7 4/8] dt-bindings: pwm: Support new PWM_STAGGERING_ALLOWED flag

2021-04-09 Thread Thierry Reding
On Wed, Apr 07, 2021 at 07:33:57AM +0200, Uwe Kleine-König wrote: > On Tue, Apr 06, 2021 at 06:41:36PM +0200, Clemens Gruber wrote: > > Add the flag and corresponding documentation for the new PWM staggering > > mode feature. > > > > Cc: Rob Herring > > Signed-off-by: Clemens Gruber > > For

Re: [RFC v3 net-next 0/4] MT7530 interrupt support

2021-04-09 Thread René van Dorst
Quoting Andrew Lunn : On Thu, Apr 08, 2021 at 11:00:08PM +0800, DENG Qingfang wrote: Hi René, On Thu, Apr 8, 2021 at 10:02 PM René van Dorst wrote: > > Tested on Ubiquiti ER-X-SFP (MT7621) with 1 external phy which uses irq=POLL. > I wonder if the external PHY's IRQ can be registered

Re: [PATCH 4/7] KVM: SVM: hyper-v: Nested enlightenments in VMCB

2021-04-09 Thread Vineeth Pillai
On 4/8/21 11:44 AM, Paolo Bonzini wrote: On 07/04/21 16:41, Vineeth Pillai wrote: +#define VMCB_ALL_CLEAN_MASK (__CLEAN_MASK | (1U << VMCB_HV_NESTED_ENLIGHTENMENTS)) +#else +#define VMCB_ALL_CLEAN_MASK __CLEAN_MASK +#endif I think this should depend on whether KVM is running on top of

Re: [PATCH 1/2] iommu/sva: Tighten SVA bind API with explicit flags

2021-04-09 Thread Lu Baolu
Hi Jacob, On 2021/4/9 1:08, Jacob Pan wrote: The void* drvdata parameter isn't really used in iommu_sva_bind_device() API, the current IDXD code "borrows" the drvdata for a VT-d private flag for supervisor SVA usage. Supervisor/Privileged mode request is a generic feature. It should be

[Outreachy kernel][PATCH 2/2 v3] staging: media: hantro: Align line break to the open parenthesis in file hantro_mpeg2.c

2021-04-09 Thread Aline Santana Cordeiro
Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch. Signed-off-by: Aline Santana Cordeiro --- Changes since v2: - Rename the commit messages properly Changes since v1: - Send patchset without the cover-letter - Rename the commit

[Outreachy kernel][PATCH 1/2 v3] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

2021-04-09 Thread Aline Santana Cordeiro
Aligns line break with the remaining function arguments to the open parenthesis. Issue found by checkpatch. Signed-off-by: Aline Santana Cordeiro --- Changes since v2: - Rename the commit messages properly Changes since v1: - Send patchset without the cover-letter - Rename the commit

Re: [v3,PATCH 3/3] pwm: mtk_disp: implement .get_state()

2021-04-09 Thread Thierry Reding
On Tue, Apr 06, 2021 at 12:27:56PM +0200, Uwe Kleine-König wrote: > On Tue, Apr 06, 2021 at 05:57:42PM +0800, Rex-BC Chen wrote: > > implement get_state function for pwm-mtk-disp > > > > Signed-off-by: Rex-BC Chen > > Signed-off-by: Jitao Shi > > Ideally you S-o-b line is the last one to show

Re: [PATCH 1/7] hyperv: Detect Nested virtualization support for SVM

2021-04-09 Thread Vineeth Pillai
On 4/8/21 11:24 AM, Sean Christopherson wrote: Technically, you can use normal memory accesses, so long as software guarantees the VMCS isn't resident in the VMCS cache and knows the field offsets for the underlying CPU. The lack of an architecturally defined layout is the biggest issue,

[PATCH -next] drm/etnaviv: remove unneeded if-null-free check

2021-04-09 Thread Qiheng Lin
Eliminate the following coccicheck warning: drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:616:2-8: WARNING: NULL check before some freeing functions is not needed. drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:618:2-8: WARNING: NULL check before some freeing functions is not needed.

[PATCH 2/2] ARM: dts: imx28: Add DTS description of imx28 based XEA board

2021-04-09 Thread Lukasz Majewski
This patch adds DTS definition of the imx278 based XEA board. Signed-off-by: Lukasz Majewski --- Changes for v2: - Fix 'memory' node and remove regulators subnode - Rename 'flash0: s25fl256s0@0' to flash@0 - Add proper compatible for XEA board --- arch/arm/boot/dts/Makefile | 3 +-

Re: [PATCH] iommu: exynos: remove unneeded local variable initialization

2021-04-09 Thread Marek Szyprowski
On 08.04.2021 22:16, Krzysztof Kozlowski wrote: > The initialization of 'fault_addr' local variable is not needed as it is > shortly after overwritten. > > Addresses-Coverity: Unused value > Signed-off-by: Krzysztof Kozlowski Acked-by: Marek Szyprowski > --- > drivers/iommu/exynos-iommu.c |

[PATCH] x86/cpu: Comment Skylake server stepping too

2021-04-09 Thread Andrew Cooper
Further to commit 53375a5a218e ("x86/cpu: Resort and comment Intel models"), CascadeLake and CooperLake are steppings of Skylake, and make up the 1st to 3rd generation "Xeon Scalable Processor" line. Signed-off-by: Andrew Cooper --- CC: Peter Zijlstra CC: Tony Luck CC: x...@kernel.org CC:

Re: build failure of malta_qemu_32r6_defconfig

2021-04-09 Thread Thomas Bogendoerfer
On Thu, Apr 08, 2021 at 09:42:11AM +0800, YunQiang Su wrote: > Sudip Mukherjee 于2021年4月8日周四 上午2:26写道: > > > > Hi Thomas, > > > > I was building v5.10.28 with malta_qemu_32r6_defconfig and noticed that > > it fails to build, so tried next-20210407 to see if it has been fixed. > > But linux-next

Re: [PATCH v7] RISC-V: enable XIP

2021-04-09 Thread Mike Rapoport
On Fri, Apr 09, 2021 at 07:39:59AM -0400, Alex Ghiti wrote: > Hi David, > > Le 4/9/21 à 4:23 AM, David Hildenbrand a écrit : > > On 09.04.21 09:14, Alex Ghiti wrote: > > > Le 4/9/21 à 2:51 AM, Alexandre Ghiti a écrit : > > > > From: Vitaly Wool > > > > > > > > Introduce XIP (eXecute In Place)

Re: [PATCH] pinctrl: at91-pio4: Fix slew rate disablement

2021-04-09 Thread Ludovic.Desroches
On Fri, Apr 09, 2021 at 11:25:22AM +0300, Tudor Ambarus wrote: > The slew rate was enabled by default for each configuration of the > pin. In case the pin had more than one configuration, even if > we set the slew rate as disabled in the device tree, the next pin > configuration would set again

[PATCH] mm/memory_hotplug: Make unpopulated zones PCP structures unreachable during hot remove

2021-04-09 Thread Mel Gorman
zone_pcp_reset allegedly protects against a race with drain_pages using local_irq_save but this is bogus. local_irq_save only operates on the local CPU. If memory hotplug is running on CPU A and drain_pages is running on CPU B, disabling IRQs on CPU A does not affect CPU B and offers no

[PATCH -next] scsi: qla2xxx: remove unneeded if-null-free check

2021-04-09 Thread Qiheng Lin
Eliminate the following coccicheck warning: drivers/scsi/qla2xxx/qla_os.c:4622:2-7: WARNING: NULL check before some freeing functions is not needed. drivers/scsi/qla2xxx/qla_os.c:4637:3-8: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Qiheng Lin ---

Re: [RFC PATCH v2 0/4] arm64: Implement stack trace reliability checks

2021-04-09 Thread Mark Rutland
Hi Madhavan, I've noted some concerns below. At a high-level, I'm not keen on the blacklisting approach, and I think there's some other preparatory work that would be more valuable in the short term. On Mon, Apr 05, 2021 at 03:43:09PM -0500, madve...@linux.microsoft.com wrote: > From: "Madhavan

Re: [PATCH] pwm: Rename pwm_get_state() to better reflect its semantic

2021-04-09 Thread Thierry Reding
On Tue, Apr 06, 2021 at 03:43:56PM +0200, Uwe Kleine-König wrote: > Hello Thierry, > > On Tue, Apr 06, 2021 at 01:16:31PM +0200, Thierry Reding wrote: > > On Tue, Apr 06, 2021 at 09:30:36AM +0200, Uwe Kleine-König wrote: > > > Given that lowlevel drivers usually cannot implement exactly what a >

Re: [PATCH v7] RISC-V: enable XIP

2021-04-09 Thread David Hildenbrand
On 09.04.21 13:39, Alex Ghiti wrote: Hi David, Le 4/9/21 à 4:23 AM, David Hildenbrand a écrit : On 09.04.21 09:14, Alex Ghiti wrote: Le 4/9/21 à 2:51 AM, Alexandre Ghiti a écrit : From: Vitaly Wool Introduce XIP (eXecute In Place) support for RISC-V platforms. It allows code to be executed

Fwd: Function Level Reset notification to PCIe device driver

2021-04-09 Thread ragas gupta
Hello, This query is regarding Function level reset feature for SRIOV. As per code in Linux PCIe driver the function level reset is done by writing “1” to “reset” under sysfs interface. e.g. “echo 1 > /sys/bus/pci/devices/ /reset “ As function level reset is not triggered via the

[Outreachy kernel] [PATCH] staging: rtl8723bs: include: Correct mispelled words in comments

2021-04-09 Thread Fabio M. De Francesco
Correct misspelled words in comments of several files. Issue (largely) detected by checkpatch.pl. Signed-off-by: Fabio M. De Francesco --- .../rtl8723bs/include/Hal8192CPhyReg.h| 8 ++--- .../staging/rtl8723bs/include/basic_types.h | 2 +-

Re: [PATCH 2/2] powerpc: make 'boot_text_mapped' static

2021-04-09 Thread Segher Boessenkool
Hi! On Thu, Apr 08, 2021 at 07:04:35AM +0200, Christophe Leroy wrote: > Le 08/04/2021 à 03:18, Yu Kuai a écrit : > >-int boot_text_mapped __force_data = 0; > >+static int boot_text_mapped __force_data; > > Are you sure the initialisation to 0 can be removed ? Usually > initialisation to 0 is

Re: [PATCH v6 00/30] Network fs helper library & fscache kiocb API

2021-04-09 Thread David Wysochanski
On Thu, Apr 8, 2021 at 10:04 AM David Howells wrote: > > > Here's a set of patches to do two things: > > (1) Add a helper library to handle the new VM readahead interface. This > is intended to be used unconditionally by the filesystem (whether or > not caching is enabled) and

[tip: sched/core] sched/fair: Ignore percpu threads for imbalance pulls

2021-04-09 Thread tip-bot2 for Lingutla Chandrasekhar
The following commit has been merged into the sched/core branch of tip: Commit-ID: 8d25d10a4f5a5d87c062838358ab5b3ed7eaa131 Gitweb: https://git.kernel.org/tip/8d25d10a4f5a5d87c062838358ab5b3ed7eaa131 Author:Lingutla Chandrasekhar AuthorDate:Wed, 07 Apr 2021 23:06:26

[tip: sched/core] sched/fair: Clean up active balance nr_balance_failed trickery

2021-04-09 Thread tip-bot2 for Valentin Schneider
The following commit has been merged into the sched/core branch of tip: Commit-ID: 03149668b42785918f362a88106094863db73b63 Gitweb: https://git.kernel.org/tip/03149668b42785918f362a88106094863db73b63 Author:Valentin Schneider AuthorDate:Wed, 07 Apr 2021 23:06:27 +01:00

[tip: sched/core] sched/fair: Introduce a CPU capacity comparison helper

2021-04-09 Thread tip-bot2 for Valentin Schneider
The following commit has been merged into the sched/core branch of tip: Commit-ID: 816969e4af7a56bfd284d2e0fa11511900ab93e3 Gitweb: https://git.kernel.org/tip/816969e4af7a56bfd284d2e0fa11511900ab93e3 Author:Valentin Schneider AuthorDate:Wed, 07 Apr 2021 23:06:28 +01:00

[PATCH -next] scsi: qla4xxx: remove unneeded if-null-free check

2021-04-09 Thread Qiheng Lin
Eliminate the following coccicheck warning: drivers/scsi/qla4xxx/ql4_os.c:4175:2-7: WARNING: NULL check before some freeing functions is not needed. drivers/scsi/qla4xxx/ql4_os.c:4196:2-7: WARNING: NULL check before some freeing functions is not needed. drivers/scsi/qla4xxx/ql4_os.c:4215:2-7:

Re: [PATCH] staging: rtl8712: fix wrong function output

2021-04-09 Thread Greg KH
On Fri, Apr 09, 2021 at 01:41:59PM +0200, Sergei Krainov wrote: > On Fri, Apr 09, 2021 at 08:33:23AM +0200, Greg KH wrote: > > On Fri, Apr 09, 2021 at 01:45:27AM +0200, Sergei Krainov wrote: > > > Function r8712_find_network() were returning wlan_network even if it > > > didn't match required

Re: static_branch/jump_label vs branch merging

2021-04-09 Thread Peter Zijlstra
On Fri, Apr 09, 2021 at 07:55:42AM -0400, David Malcolm wrote: > On Fri, 2021-04-09 at 13:12 +0200, Peter Zijlstra wrote: > > On Fri, Apr 09, 2021 at 11:57:22AM +0200, Ard Biesheuvel wrote: > > > On Thu, 8 Apr 2021 at 18:53, Peter Zijlstra > > > wrote: > > > > > > Is there *any* way in which we

Re: [RFC PATCH 2/3] mm: Return bool from pagebit test functions

2021-04-09 Thread David Howells
Matthew Wilcox wrote: > On Fri, Apr 09, 2021 at 11:59:17AM +0100, David Howells wrote: > > Make functions that test page bits return a bool, not an int. This means > > that the value is definitely 0 or 1 if they're used in arithmetic, rather > > than rely on test_bit() and friends to return

Re: [PATCH] staging: fieldbus: simplify devm_anybuss_host_common_probe

2021-04-09 Thread Sven Van Asbroeck
Hello Tian, thank you for the contribution. See below. On Fri, Apr 9, 2021 at 4:33 AM Tian Tao wrote: > > Use devm_add_action_or_reset() instead of devres_alloc() and > devres_add(), which works the same. This will simplify the > code. There is no functional changes. > > Signed-off-by: Tian Tao

Re: [PATCH] cpufreq: intel_pstate: Simplify intel_pstate_update_perf_limits()

2021-04-09 Thread Chen Yu
On Wed, Apr 07, 2021 at 04:21:55PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Because pstate.max_freq is always equal to the product of > pstate.max_pstate and pstate.scaling and, analogously, > pstate.turbo_freq is always equal to the product of > pstate.turbo_pstate and

Re: [PATCH V2 3/4] dt-bindings: power: reset: qcom-pon: Convert qcom PON binding to yaml

2021-04-09 Thread Sebastian Reichel
Hi, On Fri, Apr 09, 2021 at 01:48:58PM +0530, ska...@codeaurora.org wrote: >> Please do not drop the example :) > > As per my understanding on Rob's comments [1] I have added one complete > example in qcom,pm8941-pwrkey.yaml (see patch 4/4) and dropped it here. > > [1]

Re: [RFC PATCH v2 1/4] arm64: Implement infrastructure for stack trace reliability checks

2021-04-09 Thread Mark Brown
On Thu, Apr 08, 2021 at 06:30:22PM -0500, Madhavan T. Venkataraman wrote: > On 4/8/21 2:30 PM, Madhavan T. Venkataraman wrote: > > 1. Create a common section (I will have to come up with an appropriate > > name) and put > >all such functions in that one section. > > 2. Create one section

Re: static_branch/jump_label vs branch merging

2021-04-09 Thread David Malcolm
On Fri, 2021-04-09 at 13:12 +0200, Peter Zijlstra wrote: > On Fri, Apr 09, 2021 at 11:57:22AM +0200, Ard Biesheuvel wrote: > > On Thu, 8 Apr 2021 at 18:53, Peter Zijlstra > > wrote: > > > > Is there *any* way in which we can have the compiler recognise > > > that the > > > asm_goto only depends

[PATCH v1 2/2] clk: qcom: Add lpass clock controller driver for SC7280

2021-04-09 Thread Taniya Das
Add support for the lpass clock controller found on SC7280 based devices. This would allow lpass peripheral loader drivers to control the clocks to bring the subsystem out of reset. Signed-off-by: Taniya Das --- drivers/clk/qcom/Kconfig | 8 ++ drivers/clk/qcom/Makefile | 1

[PATCH v1 1/2] dt-bindings: clock: Add YAML schemas for LPASS clocks on SC7280

2021-04-09 Thread Taniya Das
The LPASS(Low Power Audio Subsystem) clock provider have a bunch of generic properties that are needed in a device tree. Add the LPASS clock IDs for LPASS PIL client to request for the clocks. Signed-off-by: Taniya Das --- .../bindings/clock/qcom,sc7280-lpasscc.yaml| 69

Re: [RFC PATCH v1 2/2] docs: reporting-issues: make everyone CC the regressions list

2021-04-09 Thread Thorsten Leemhuis
On 08.04.21 19:31, Jonathan Corbet wrote: > Thorsten Leemhuis writes: > >> +In case you performed a successful bisection, use the title of the change >> that >> +introduced the regression as the second part of your subject. Make the >> report >> +also mention the commit id of the culprit. For

[PATCH net-next] cxgb4: remove unneeded if-null-free check

2021-04-09 Thread Qiheng Lin
Eliminate the following coccicheck warning: drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:529:3-9: WARNING: NULL check before some freeing functions is not needed. drivers/net/ethernet/chelsio/cxgb4/cxgb4_tc_u32.c:533:2-8: WARNING: NULL check before some freeing functions is not needed.

Re: [Outreachy kernel] Re: [PATCH 1/2 v2] staging: media: hantro: Align line break to the open parenthesis in file hantro_hw.h

2021-04-09 Thread ascordeiro
Em sex, 2021-04-09 às 10:25 +0200, Vaishali Thakkar escreveu: > On Thu, Apr 8, 2021 at 7:41 PM ascordeiro > wrote: > > > > Em qui, 2021-04-08 às 13:20 -0300, Ezequiel Garcia escreveu: > > > Ola Aline, > > Ola Ezequiel, > > > > > Welcome to the kernel community. Hope you enjoy some of this > > >

[tip: x86/urgent] x86/traps: Correct exc_general_protection() and math_error() return paths

2021-04-09 Thread tip-bot2 for Thomas Tai
The following commit has been merged into the x86/urgent branch of tip: Commit-ID: 632a1c209b8773cb0119fe3aada9f1db14fa357c Gitweb: https://git.kernel.org/tip/632a1c209b8773cb0119fe3aada9f1db14fa357c Author:Thomas Tai AuthorDate:Thu, 08 Apr 2021 13:28:33 -04:00 Committer:

Re: [PATCH] pinctrl: samsung: use 'int' for register masks in Exynos

2021-04-09 Thread Sylwester Nawrocki
On 08.04.2021 21:50, Krzysztof Kozlowski wrote: > The Special Function Registers on all Exynos SoC, including ARM64, are > 32-bit wide, so entire driver uses matching functions like readl() or > writel(). On 64-bit ARM using unsigned long for register masks: > 1. makes little sense as immediately

Re: [PATCH -next] power: reset: hisi-reboot: add missing MODULE_DEVICE_TABLE

2021-04-09 Thread Sebastian Reichel
Hi, On Fri, Apr 09, 2021 at 10:50:11AM +0800, Chen Lifu wrote: > This patch adds missing MODULE_DEVICE_TABLE definition which generates > correct modalias for automatic loading of this driver when it is built > as an external module. > > Reported-by: Hulk Robot > Signed-off-by: Chen Lifu > ---

Re: Subject: Re: [PATCH v3] kbuild: add support for zstd compressed modules

2021-04-09 Thread Sedat Dilek
On Fri, Apr 9, 2021 at 1:31 PM Sedat Dilek wrote: > > On Fri, Apr 9, 2021 at 1:10 PM Piotr Gorski wrote: > > > > I originally posted the patch in a different form [1] even before > > Masahiro's changes. > > I've been testing this solution since December last year and posted it in > > March

linux-next: Tree for Apr 9

2021-04-09 Thread Stephen Rothwell
Hi all, Changes since 20210408: New trees: iio, iio-fixes The arm-soc tree gained a build failure so I reverted some commits. The bluetooth tree lost its build failure. The drm tree gained a conflict against the drm-misc-fixes tree and also a bad merge for which I applied a merge fix patch.

[PATCH] nfc: pn533: remove redundant assignment

2021-04-09 Thread samirweng1979
From: wengjianfeng In many places,first assign a value to a variable and then return the variable. which is redundant, we should directly return the value. in pn533_rf_field funciton,return statement in the if statement is redundant, we just delete it. Signed-off-by: wengjianfeng ---

Re: Problem in pfmemalloc skb handling in net/core/dev.c

2021-04-09 Thread Eric Dumazet
On 4/9/21 12:14 PM, Xie He wrote: > On Fri, Apr 9, 2021 at 3:04 AM Eric Dumazet wrote: >> >> Note that pfmemalloc skbs are normally dropped in sk_filter_trim_cap() >> >> Simply make sure your protocol use it. > > It seems "sk_filter_trim_cap" needs an "struct sock" argument. Some of > my

Re: [PATCH v2 1/1] kernel.h: Split out panic and oops helpers

2021-04-09 Thread Sebastian Reichel
Hi, On Fri, Apr 09, 2021 at 01:02:50PM +0300, Andy Shevchenko wrote: > kernel.h is being used as a dump for all kinds of stuff for a long time. > Here is the attempt to start cleaning it up by splitting out panic and > oops helpers. > > There are several purposes of doing this: > - dropping

[PATCH v8 4/4] fix origin_map - don't split a bio for the origin device if it does not have registered snapshots.

2021-04-09 Thread Sergei Shtepa
Signed-off-by: Sergei Shtepa --- drivers/md/dm-snap.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/md/dm-snap.c b/drivers/md/dm-snap.c index 11890db71f3f..81e8e3bb6d25 100644 --- a/drivers/md/dm-snap.c +++ b/drivers/md/dm-snap.c @@ -2685,11

[PATCH v8 3/4] Adds blk_interposer to md.

2021-04-09 Thread Sergei Shtepa
* The new flag DM_INTERPOSE_FLAG allows to specify that the dm target will be attached using blk_interposer. * The [interpose] option allows to specify which device will be attached via the interposer. * The connection and disconnection of the interrupter is performed in the functions

[PATCH v8 1/4] Adds blk_interposer. It allows to redirect bio requests to another block device.

2021-04-09 Thread Sergei Shtepa
Signed-off-by: Sergei Shtepa --- block/genhd.c | 51 +++ fs/block_dev.c| 3 +++ include/linux/blk_types.h | 6 + include/linux/blkdev.h| 32 4 files changed, 92 insertions(+) diff --git

[PATCH v8 2/4] Adds the blk_interposers logic to __submit_bio_noacct().

2021-04-09 Thread Sergei Shtepa
* The calling to blk_partition_remap() function has moved from submit_bio_checks() to submit_bio_noacct(). * The __submit_bio() and __submit_bio_noacct_mq() functions have been removed and their functionality moved to submit_bio_noacct(). * Added locking of the block device queue using the

[PATCH v8 0/4] block device interposer

2021-04-09 Thread Sergei Shtepa
I think I'm ready to suggest the next version of block device interposer (blk_interposer). It allows to redirect bio requests to other block devices. In this series of patches, I reviewed the process of attaching and detaching device mapper via blk_interposer. Now the dm-target is attached to

[PATCH v2 2/2] docs: reporting-issues: make people CC the regressions list

2021-04-09 Thread Thorsten Leemhuis
Make people CC the recently created mailing list dedicated to Linux kernel regressions when reporting one. Some paragraphs had to be reshuffled and slightly rewritten during the process, as the text otherwise would have gotten unnecessarily hard to follow. Signed-off-by: Thorsten Leemhuis ---

[PATCH v2 0/2] Mention regression mailing list in reporting-bugs and MAINTAINERS

2021-04-09 Thread Thorsten Leemhuis
Hi! A mailing list for regressions was finally created as regressi...@lists.linux.dev (we dropped the linux- prefix as the term is already in the domain name). Hence, add it to MAINTAINERS, as that where people will look it up. I was a bit unsure how to actually do that, see the note in the first

[PATCH v2 1/2] MAINTAINERS: add regressions mailing list

2021-04-09 Thread Thorsten Leemhuis
Add the newly created regression mailing list finally created after it already had been agreed on during the maintainers summit 2017 (see https://lwn.net/Articles/738216/ ). The topic was recently discussed again, where an idea to create a broader list for all issues was discussed, but Linus

[PATCH v4] media: venus : hfi: add venus image info into smem

2021-04-09 Thread Dikshita Agarwal
Fill fw version info into smem to be printed as part of soc info. Signed-off-by: Dikshita Agarwal Reported-by: kernel test robot change since v3: added dependency on QCOM_SMEM (Stephen) --- drivers/media/platform/Kconfig | 2 +- drivers/media/platform/qcom/venus/hfi_msgs.c |

Re: [PATCH v6 01/30] iov_iter: Add ITER_XARRAY

2021-04-09 Thread Matthew Wilcox
On Fri, Apr 09, 2021 at 10:09:05AM +0100, David Howells wrote: > Al Viro wrote: > > > > +#define iterate_all_kinds(i, n, v, I, B, K, X) { \ > > > > Do you have any users that would pass different B and X? > > > > > @@ -1440,7 +1665,7 @@ ssize_t iov_iter_get_pages_alloc(struct iov_iter

[PATCH 6/7] evm: Allow choice of hash algorithm for HMAC

2021-04-09 Thread Roberto Sassu
Commit 5feeb61183dd ("evm: Allow non-SHA1 digital signatures") introduced the possibility to use a different hash algorithm for signatures, but kept the algorithm for the HMAC hard-coded (SHA1). Switching to a different algorithm for HMAC would require to change the code in different places. This

[PATCH 7/7] evm: Extend evm= with allow_metadata_writes and complete values

2021-04-09 Thread Roberto Sassu
With the patch 'evm: Ignore INTEGRITY_NOLABEL/INTEGRITY_NOXATTRS if conditions are safe', the INTEGRITY_NOLABEL and INTEGRITY_NOXATTRS errors can be ignored by setting the EVM_SETUP_COMPLETE flag. Also, the same errors can be avoided by disabling EVM verification completely with the

[PATCH 5/7] ima: Introduce appraise_exec_immutable policy

2021-04-09 Thread Roberto Sassu
This patch modifies the existing "appraise_exec_tcb" policy, by adding the appraise_type=meta_immutable requirement for executed files. This policy can be selected by specifying ima_policy="appraise_exec_tcb|appraise_exec_immutable" in the kernel command line. Signed-off-by: Roberto Sassu ---

[PATCH 4/7] ima: Introduce appraise_exec_tcb and appraise_tmpfs policies

2021-04-09 Thread Roberto Sassu
This patch introduces two new hard-coded policies, named appraise_exec_tcb and appraise_tmpfs. The first appraises files executed or mmapped, as opposed to files owned by root, requiring in addition a digital signature. The second appraises files in the tmpfs and ramfs filesystems, to avoid that

[PATCH 3/7] ima: Introduce exec_tcb and tmpfs policies

2021-04-09 Thread Roberto Sassu
This patch introduces two new hard-coded policies, named exec_tcb and tmpfs. The first excludes the FILE_CHECK rules to measure only files executed and mmapped. The second excludes the dont_measure rule for the tmpfs filesystem for the ima_tcb, tcb and exec_tcb policies, as this could be used as a

[PATCH 2/7] ima: Add meta_immutable appraisal type

2021-04-09 Thread Roberto Sassu
Currently, IMA supports the appraise_type=imasig option in the policy to require signed file content or metadata. This patch introduces the new option appraise_type=meta_immutable to require that file metadata is also immutable, i.e. it cannot have been produced by the system itself but only from

[PATCH 1/7] ima: Avoid measurement and audit if access to the file will be denied

2021-04-09 Thread Roberto Sassu
Currently, IMA adds a measurement entry and an audit log even if access to the file will be denied when appraisal is in enforce mode. This gives the false indication to a verifier analyzing the data that file access occurred. It also has the undesirable effect of unnecessarily revoking access to

[PATCH 0/7] ima/evm: Small enhancements

2021-04-09 Thread Roberto Sassu
This patch set provides some small enhancements for IMA and EVM. Patch 1 avoids measurement and audit when access to the file will be denied by IMA itself. Patch 2 introduces a new policy keyword meta_immutable to protect the label transition during binary execution. Patch 3-5 add new

<    4   5   6   7   8   9   10   11   12   13   >