[PATCH] mtd: rawnand: fix an error code in nand_setup_interface()

2021-04-13 Thread Dan Carpenter
We should return an error code if the timing mode is not acknowledged by the NAND chip. Fixes: 415ae78ffb5d ("mtd: rawnand: check ONFI timings have been acked by the chip") Signed-off-by: Dan Carpenter --- >From static analysis. Not tested. drivers/mtd/nand/raw/nand_base.c | 1 + 1 file

Re: [syzbot] KASAN: use-after-free Read in get_wchan

2021-04-13 Thread Dmitry Vyukov
On Wed, Apr 14, 2021 at 7:52 AM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:b2b3d18f riscv: Make NUMA depend on MMU > git tree: git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git > fixes > console output:

[PATCH 4/4] selftests: add tests for process_vm_exec

2021-04-13 Thread Andrei Vagin
Output: $ make run_tests TAP version 13 1..4 # selftests: process_vm_exec: process_vm_exec # 1..1 # ok 1 275 ns/syscall # # Totals: pass:1 fail:0 xfail:0 xpass:0 skip:0 error:0 ok 1 selftests: process_vm_exec: process_vm_exec # selftests: process_vm_exec: process_vm_exec_fault # 1..1 #

[PATCH 3/4] arch/x86: allow to execute syscalls via process_vm_exec

2021-04-13 Thread Andrei Vagin
process_vm_exec allows to execute code in an address space of another process. It changes the current address space to the target address space and resume the current process with registers from sigcontex that is passed in the arguments. This changes adds the PROCESS_VM_EXEC_SYSCALL flag and if

[PATCH 1/4] signal: add a helper to restore a process state from sigcontex

2021-04-13 Thread Andrei Vagin
It will be used to implement process_vm_exec. Signed-off-by: Andrei Vagin --- arch/x86/kernel/signal.c | 78 ++-- 1 file changed, 43 insertions(+), 35 deletions(-) diff --git a/arch/x86/kernel/signal.c b/arch/x86/kernel/signal.c index

[PATCH 2/4] arch/x86: implement the process_vm_exec syscall

2021-04-13 Thread Andrei Vagin
This change introduces the new system call: process_vm_exec(pid_t pid, struct sigcontext *uctx, unsigned long flags, siginfo_t * uinfo, sigset_t *sigmask, size_t sizemask) process_vm_exec allows to execute the current process in an address space of another process.

[PATCH 0/4 POC] Allow executing code and syscalls in another address space

2021-04-13 Thread Andrei Vagin
We already have process_vm_readv and process_vm_writev to read and write to a process memory faster than we can do this with ptrace. And now it is time for process_vm_exec that allows executing code in an address space of another process. We can do this with ptrace but it is much slower. =

Re: [PATCH] riscv: locks: introduce ticket-based spinlock implementation

2021-04-13 Thread Guo Ren
On Tue, Apr 13, 2021 at 6:54 PM David Laight wrote: > > From: Catalin Marinas > > Sent: 13 April 2021 11:45 > ... > > This indeed needs some care. IIUC RISC-V has similar restrictions as arm > > here, no load/store instructions are allowed between LR and SC. You > > can't guarantee that the

[PATCH v7 3/9] regulator: add warning flags

2021-04-13 Thread Matti Vaittinen
Add 'warning' level events and error flags to regulator core. Current regulator core notifications are used to inform consumers about errors where HW is misbehaving in such way it is assumed to be broken/unrecoverable. There are PMICs which are designed for system(s) that may have use for

Re: [PATCH net-next] net: Space: remove hp100 probe

2021-04-13 Thread Arnd Bergmann
On Wed, Apr 14, 2021, 00:42 Stephen Hemminger wrote: > > On Tue, 13 Apr 2021 16:16:17 +0200 Arnd Bergmann wrote: > > > */ > > static struct devprobe2 isa_probes[] __initdata = { > > -#if defined(CONFIG_HP100) && defined(CONFIG_ISA) /* ISA, EISA */ > > - {hp100_probe, 0}, > > -#endif >

[PATCH v7 2/9] reboot: thermal: Export hardware protection shutdown

2021-04-13 Thread Matti Vaittinen
Thermal core contains a logic for safety shutdown. System is attempted to be powered off if temperature exceeds safety limits. Currently this can be also utilized by regulator subsystem as a final protection measure if PMICs report dangerous over-voltage, over-current or over-temperature and if

[syzbot] KASAN: use-after-free Read in get_wchan

2021-04-13 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b2b3d18f riscv: Make NUMA depend on MMU git tree: git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git fixes console output: https://syzkaller.appspot.com/x/log.txt?x=12b59d16d0 kernel config:

[PATCH v7 1/9] dt_bindings: Add protection limit properties

2021-04-13 Thread Matti Vaittinen
Support specifying protection/error/warning limits for regulator over current, over temperature and over/under voltage. Most of the PMICs support only "protection" feature but few setups do also support error/warning level indications. On many ICs most of the protection limits can't actually be

Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. > > Issues Fixed: > - Tests should default to

[PATCH v7 0/9] Extend regulator notification support

2021-04-13 Thread Matti Vaittinen
Extend regulator notification support This series extends the regulator notification and error flag support. Initial discussion on the topic can be found here: https://lore.kernel.org/lkml/6046836e22b8252983f08d5621c35ececb97820d.ca...@fi.rohmeurope.com/ This series is built on top of the

Re: [PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Greg KH
On Wed, Apr 14, 2021 at 12:33:02AM -0400, Nico Pache wrote: > There are few instances of KUNIT tests that are not properly defined. > This commit focuses on correcting these issues to match the standard > defined in the Documentation. > > Issues Fixed: > - Tests should default to

Re: [PATCH 3/4] mce/copyin: fix to not SIGBUS when copying from user hits poison

2021-04-13 Thread Jue Wang
On Tue, 13 Apr 2021 12:07:22 +0200, Petkov, Borislav wrote: >> KVM apparently passes a machine check into the guest. > Ah, there it is: > static void kvm_send_hwpoison_signal(unsigned long address, struct > task_struct *tsk) > { > send_sig_mceerr(BUS_MCEERR_AR, (void __user *)address,

Re: [syzbot] unexpected kernel reboot (4)

2021-04-13 Thread Dmitry Vyukov
On Tue, Apr 13, 2021 at 11:27 PM syzbot wrote: > > Hello, > > syzbot found the following issue on: > > HEAD commit:89698bec Merge tag 'm68knommu-for-v5.12-rc7' of git://git... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1243fcfed0 > kernel

Re: [PATCH 1/5] mm/swapfile: add percpu_ref support for swap

2021-04-13 Thread Huang, Ying
Dennis Zhou writes: > On Wed, Apr 14, 2021 at 11:59:03AM +0800, Huang, Ying wrote: >> Dennis Zhou writes: >> >> > Hello, >> > >> > On Wed, Apr 14, 2021 at 10:06:48AM +0800, Huang, Ying wrote: >> >> Miaohe Lin writes: >> >> >> >> > On 2021/4/14 9:17, Huang, Ying wrote: >> >> >> Miaohe Lin

Re: [PATCH v7 2/3] dt-bindings: touchscreen: Add HY46XX bindings

2021-04-13 Thread Dmitry Torokhov
On Tue, Apr 13, 2021 at 04:44:45PM +0200, Giulio Benetti wrote: > This adds device tree bindings for the Hycon HY46XX touchscreen series. > > Signed-off-by: Giulio Benetti Applied, thank you. -- Dmitry

Re: [PATCH v7 1/3] dt-bindings: Add Hycon Technology vendor prefix

2021-04-13 Thread Dmitry Torokhov
On Tue, Apr 13, 2021 at 04:44:44PM +0200, Giulio Benetti wrote: > Update Documentation/devicetree/bindings/vendor-prefixes.yaml to > include "hycon" as a vendor prefix for "Hycon Technology". > Company website: https://www.hycontek.com/ > > Signed-off-by: Giulio Benetti > Reviewed-by: Jonathan

Re: [PATCH v7 3/3] Input: add driver for the Hycon HY46XX touchpanel series

2021-04-13 Thread Dmitry Torokhov
Hi Giulio, On Tue, Apr 13, 2021 at 04:44:46PM +0200, Giulio Benetti wrote: > + > + input_mt_report_pointer_emulation(tsdata->input, true); For touchscreens it does not make much sense to report BTN_DOUBLETAP, BTN_TRIPLETAP, etc, events (they are really for touchpads), so I changed this to

Re: [PATCH 5.4 v3 1/1] iommu/vt-d: Fix agaw for a supported 48 bit guest address width

2021-04-13 Thread Greg KH
On Tue, Apr 13, 2021 at 11:05:34AM -0700, Saeed Mirzamohammadi wrote: > Hi Greg, > > I don’t have any commit ID since the fix is not in mainline or any Linus’ > tree yet. The driver has completely changed for newer stable versions (and > also mainline) and the fix only applies for 5.4, 4.19,

Re: [PATCH net-next v2 1/2] of: net: pass the dst buffer to of_get_mac_address()

2021-04-13 Thread Dan Carpenter
Hi Michael, url: https://github.com/0day-ci/linux/commits/Michael-Walle/of-net-support-non-platform-devices-in-of_get_mac_address/20210406-234030 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git cc0626c2aaed8e475efdd85fa374b497a7192e35 config:

Re: [PATCH][next] iommu/vt-d: Fix out-bounds-warning in intel_svm_page_response()

2021-04-13 Thread Lu Baolu
Hi Gustavo, On 4/14/21 3:54 AM, Gustavo A. R. Silva wrote: Replace call to memcpy() with just a couple of simple assignments in order to fix the following out-of-bounds warning: drivers/iommu/intel/svm.c:1198:4: warning: 'memcpy' offset [25, 32] from the object at 'desc' is out of the bounds

Re: Question on KASAN calltrace record in RT

2021-04-13 Thread Dmitry Vyukov
On Wed, Apr 14, 2021 at 6:00 AM Mike Galbraith wrote: > > On Tue, 2021-04-13 at 17:29 +0200, Dmitry Vyukov wrote: > > On Tue, Apr 6, 2021 at 10:26 AM Zhang, Qiang > > wrote: > > > > > > Hello everyone > > > > > > In RT system, after Andrew test, found the following calltrace , > > > in

Re: [PATCH] x86: Accelerate copy_page with non-temporal in X86

2021-04-13 Thread Kemeng Shi
on 2021/4/13 22:53, Borislav Petkov wrote: > I thought "should be better" too last time when I measured rep; movs vs > NT stores but actual measurements showed no real difference. Mabye the NT stores make difference when store to slow dimms, like the persistent memory I just tested. Also, it

Re: [PATCH v2 3/4] powerpc: Rename probe_kernel_read_inst()

2021-04-13 Thread Aneesh Kumar K.V
Christophe Leroy writes: > When probe_kernel_read_inst() was created, it was to mimic > probe_kernel_read() function. > > Since then, probe_kernel_read() has been renamed > copy_from_kernel_nofault(). > > Rename probe_kernel_read_inst() into copy_from_kernel_nofault_inst(). At first glance I

Re: [Outreachy kernel] [PATCH] :staging: rtl8723bs: Remove useless led_blink_hdl()

2021-04-13 Thread Dan Carpenter
On Tue, Apr 13, 2021 at 10:08:32PM +0200, Fabio M. De Francesco wrote: > On Tuesday, April 13, 2021 9:48:44 PM CEST Matthew Wilcox wrote: > > On Tue, Apr 13, 2021 at 09:45:03PM +0200, Fabio M. De Francesco wrote: > > > 1) The driver doesn't call that function from anywhere else than the > > >

Re: [PATCH] mm: Define ARCH_HAS_FIRST_USER_ADDRESS

2021-04-13 Thread Christophe Leroy
Le 14/04/2021 à 04:54, Anshuman Khandual a écrit : Currently most platforms define FIRST_USER_ADDRESS as 0UL duplicating the same code all over. Instead define a new option ARCH_HAS_FIRST_USER_ADDRESS for those platforms which would override generic default FIRST_USER_ADDRESS value 0UL. This

Re: [RFC PATCH v8 11/19] virtio/vsock: dequeue callback for SOCK_SEQPACKET

2021-04-13 Thread Arseny Krasnov
I'll fix some issues of this patch found by kernel test robot On 13.04.2021 15:44, Arseny Krasnov wrote: > This adds transport callback and it's logic for SEQPACKET dequeue. > Callback fetches RW packets from rx queue of socket until whole record > is copied(if user's buffer is full, user is not

Re: [PATCH v2 1/2] perf/core: Share an event with multiple cgroups

2021-04-13 Thread kernel test robot
Hi Namhyung, I love your patch! Perhaps something to improve: [auto build test WARNING on tip/perf/core] [also build test WARNING on tip/master linux/master linus/master v5.12-rc7 next-20210413] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch

[PATCH] perf/core: fix memdup_user.cocci warnings

2021-04-13 Thread kernel test robot
-by: kernel test robot Signed-off-by: kernel test robot --- url: https://github.com/0day-ci/linux/commits/Namhyung-Kim/perf-core-Sharing-events-with-multiple-cgroups/20210413-124251 base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git cface0326a6c2ae5c8f47bd466f07624b3e348a7

Re: [PATCH] USB: Don't set USB_PORT_FEAT_SUSPEND on WD19's Realtek Hub

2021-04-13 Thread Chris Chiu
On Tue, Apr 13, 2021 at 10:44 PM Alan Stern wrote: > > On Tue, Apr 13, 2021 at 03:52:14PM +0800, Chris Chiu wrote: > > On Mon, Apr 12, 2021 at 11:12 PM Alan Stern > > wrote: > > > > > > On Mon, Apr 12, 2021 at 11:00:06PM +0800, chris.c...@canonical.com wrote: > > > > The USB_PORT_FEAT_SUSPEND

Re: [PATCH v2] firmware_loader: fix use-after-free in firmware_fallback_sysfs

2021-04-13 Thread Anirudh Rayabharam
On Tue, Apr 13, 2021 at 04:51:38PM +, Luis Chamberlain wrote: > On Tue, Apr 13, 2021 at 04:12:42PM +0530, Anirudh Rayabharam wrote: > > The use-after-free happens when a fw_priv object has been freed but > > hasn't been removed from the pending list (pending_fw_head). The next > > time

Re: [PATCH v7 4/7] mm,hugetlb: Split prep_new_huge_page functionality

2021-04-13 Thread Oscar Salvador
On Tue, Apr 13, 2021 at 02:33:41PM -0700, Mike Kravetz wrote: > > -static void prep_new_huge_page(struct hstate *h, struct page *page, int > > nid) > > +/* > > + * Must be called with the hugetlb lock held > > + */ > > +static void __prep_account_new_huge_page(struct hstate *h, int nid) > > +{ >

Re: [PATCH] staging: mt7621-pci: stop using of_pci_range_to_resource

2021-04-13 Thread Sergio Paracuellos
Hi Illya, On Wed, Apr 14, 2021 at 6:10 AM Ilya Lipnitskiy wrote: > > Hi Sergio, > > Just as an aside, are you planning to move staging/mt7621-pci into > arch/mips/pci at some point? This driver seems more maintained (by > you!) than many in-tree drivers... Yes, I am planning to move it and

Re: [PATCH v7 5/7] mm: Make alloc_contig_range handle free hugetlb pages

2021-04-13 Thread Oscar Salvador
On Tue, Apr 13, 2021 at 03:29:02PM -0700, Mike Kravetz wrote: > > spin_lock_irq(hugetlb_lock) > > 1) update_and_free_page > >PageHuge() == F > >__free_pages() > > 2) enqueue_huge_page > >SetPageHugeFreed() > > spin_unlock(_lock) > > Very small nit, the above should

Re: [PATCH v7 6/7] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-04-13 Thread Oscar Salvador
On Tue, Apr 13, 2021 at 03:48:53PM -0700, Mike Kravetz wrote: > The label free_new is: > > free_new: > spin_unlock_irq(_lock); > __free_pages(new_page, huge_page_order(h)); > > return ret; > > So, we are locking and immediately unlocking without any code in > between.

[char-misc-next] mei: me: add Alder Lake P device id.

2021-04-13 Thread Tomas Winkler
Add Alder Lake P device ID. Cc: Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 1 + drivers/misc/mei/pci-me.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h index 14be76d4c2e6..cb34925e10f1 100644 ---

Re: [PATCH v2 00/16] Multigenerational LRU Framework

2021-04-13 Thread Dave Chinner
On Tue, Apr 13, 2021 at 09:40:12PM -0600, Yu Zhao wrote: > On Tue, Apr 13, 2021 at 5:14 PM Dave Chinner wrote: > > On Tue, Apr 13, 2021 at 10:13:24AM -0600, Jens Axboe wrote: > > > On 4/13/21 1:51 AM, SeongJae Park wrote: > > > > From: SeongJae Park > > > > > > > > Hello, > > > > > > > > > > > >

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-13 Thread Paul E. McKenney
On Tue, Apr 13, 2021 at 10:49:11PM +0200, Thomas Gleixner wrote: > Paul, > > On Mon, Apr 12 2021 at 16:18, Paul E. McKenney wrote: > > On Mon, Apr 12, 2021 at 10:37:10PM +0200, Thomas Gleixner wrote: > >> On Mon, Apr 12 2021 at 12:57, Paul E. McKenney wrote: > >> > On Mon, Apr 12, 2021 at

Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: hal: Remove four set but not used variables

2021-04-13 Thread Dan Carpenter
On Tue, Apr 13, 2021 at 08:42:22PM +0200, Fabio M. De Francesco wrote: > Removed four variables that were set but not used. > > Signed-off-by: Fabio M. De Francesco > --- > drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff

Re: [PATCH] [v4] Input: Add "Select" button to Microsoft Xbox One controller.

2021-04-13 Thread Chris Ye
That line was using tab + 4 spaces on the left and was reformatted to use 2 tabs. If you don't like it I've uploaded patch v5 not touching that line. On Tue, Apr 13, 2021 at 5:34 AM Bastien Nocera wrote: > > On Tue, 2021-04-13 at 01:02 +, Chris Ye wrote: > > Add "Select" button input

Re: [PATCH] Documentation: syscalls: add a note about ABI-agnostic types

2021-04-13 Thread Yury Norov
Ping? On Fri, Apr 09, 2021 at 01:43:04PM -0700, Yury Norov wrote: > Recently added memfd_secret() syscall had a flags parameter passed > as unsigned long, which requires creation of compat entry for it. > It was possible to change the type of flags to unsigned int and so > avoid bothering with

Re: [syzbot] WARNING in unsafe_follow_pfn

2021-04-13 Thread Dan Carpenter
On Tue, Apr 13, 2021 at 03:11:45PM -0300, Jason Gunthorpe wrote: > On Tue, Apr 13, 2021 at 07:20:12PM +0200, Dmitry Vyukov wrote: > > > > Plus users are going to be seeing this as well. According to the commit > > > > message for 69bacee7f9ad ("mm: Add unsafe_follow_pfn") "Unfortunately > > > >

[PATCH v8 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-13 Thread Paul E. McKenney
Some sorts of per-CPU clock sources have a history of going out of synchronization with each other. However, this problem has purportedy been solved in the past ten years. Except that it is all too possible that the problem has instead simply been made less likely, which might mean that some of

[PATCH v8 clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-04-13 Thread Paul E. McKenney
When the clocksource watchdog marks a clock as unstable, this might be due to that clock being unstable or it might be due to delays that happen to occur between the reads of the two clocks. Yes, interrupts are disabled across those two reads, but there are no shortage of things that can delay

[PATCH v8 clocksource 1/5] clocksource: Provide module parameters to inject delays in watchdog

2021-04-13 Thread Paul E. McKenney
When the clocksource watchdog marks a clock as unstable, this might be due to that clock being unstable or it might be due to delays that happen to occur between the reads of the two clocks. Yes, interrupts are disabled across those two reads, but there are no shortage of things that can delay

[PATCH v8 clocksource 5/5] clocksource: Limit number of CPUs checked for clock synchronization

2021-04-13 Thread Paul E. McKenney
Currently, if skew is detected on a clock marked CLOCK_SOURCE_VERIFY_PERCPU, that clock is checked on all CPUs. This is thorough, but might not be what you want on a system with a few tens of CPUs, let alone a few hundred of them. Therefore, by default check only up to eight randomly chosen

[PATCH v8 clocksource 4/5] clocksource: Provide a module parameter to fuzz per-CPU clock checking

2021-04-13 Thread Paul E. McKenney
Code that checks for clock desynchronization must itself be tested, so create a new clocksource.inject_delay_shift_percpu= kernel boot parameter that adds or subtracts a large value from the check read, using the specified bit of the CPU ID to determine whether to add or to subtract. Cc: John

[PATCH v8 clocksource] Do not mark clocks unstable due to delays for v5.13

2021-04-13 Thread Paul E. McKenney
Hello! If there is a sufficient delay between reading the watchdog clock and the clock under test, the clock under test will be marked unstable through no fault of its own. This series checks for this, doing limited retries to get a good set of clock reads. If the clock is marked unstable and

xilinx_axienet_main.c:undefined reference to `of_address_to_resource'

2021-04-13 Thread kernel test robot
Hi Robert, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 50987beca096a7ed4f453a6da245fd6a2fadedeb commit: 57baf8cc70ea4cf5503c9d42f31f6a86d7f5ff1a net: axienet: Handle deferred probe on clock properly date: 9

[PATCH 2/2] m68k: update configs to match the proper KUNIT syntax

2021-04-13 Thread Nico Pache
No functional changes other than CONFIG name changes Signed-off-by: Nico Pache --- arch/m68k/configs/amiga_defconfig| 6 +++--- arch/m68k/configs/apollo_defconfig | 6 +++--- arch/m68k/configs/atari_defconfig| 6 +++--- arch/m68k/configs/bvme6000_defconfig | 6 +++---

[PATCH 1/2] kunit: Fix formatting of KUNIT tests to meet the standard

2021-04-13 Thread Nico Pache
There are few instances of KUNIT tests that are not properly defined. This commit focuses on correcting these issues to match the standard defined in the Documentation. Issues Fixed: - Tests should default to KUNIT_ALL_TESTS - Tests configs tristate should have `if !KUNIT_ALL_TESTS` -

Re: [PATCH v3] Documentation: kunit: add tips for running KUnit

2021-04-13 Thread David Gow
On Wed, Apr 14, 2021 at 8:45 AM Daniel Latypov wrote: > > This is long overdue. > > There are several things that aren't nailed down (in-tree > .kunitconfig's), or partially broken (GCOV on UML), but having them > documented, warts and all, is better than having nothing. > > This covers a bunch

Re: [PATCH v4 1/2] mfd: google,cros-ec: add DT bindings for a baseboard's switch device

2021-04-13 Thread Ikjoon Jang
On Tue, Apr 13, 2021 at 10:57 PM Rob Herring wrote: > > On Mon, Apr 12, 2021 at 07:30:19PM +0800, Ikjoon Jang wrote: > > This is for ChromeOS tablets which have a 'cros_cbas' switch device > > in the "Whiskers" base board. This device can be instantiated only by > > device tree on ARM platforms.

Re: [PATCH 1/2] iommu/sva: Tighten SVA bind API with explicit flags

2021-04-13 Thread kernel test robot
Hi Jacob, I love your patch! Yet something to improve: [auto build test ERROR on vkoul-dmaengine/next] [also build test ERROR on char-misc/char-misc-testing v5.12-rc7] [cannot apply to iommu/next next-20210413] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH] staging: mt7621-pci: stop using of_pci_range_to_resource

2021-04-13 Thread Ilya Lipnitskiy
Hi Sergio, Just as an aside, are you planning to move staging/mt7621-pci into arch/mips/pci at some point? This driver seems more maintained (by you!) than many in-tree drivers... Ilya On Sat, Apr 10, 2021 at 12:23 PM Sergio Paracuellos wrote: > > Hi Ilya, > > On Sat, Apr 10, 2021 at 7:33 PM

Re: [PATCH v2 2/3] soundwire: Intel: introduce DMI quirks for HP Spectre x360 Convertible

2021-04-13 Thread Vinod Koul
On 12-04-21, 14:37, Dave Hansen wrote: > On 3/1/21 11:51 PM, Bard Liao wrote: > > +++ b/drivers/soundwire/dmi-quirks.c > > @@ -0,0 +1,66 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) > > +// Copyright(c) 2021 Intel Corporation. > > It looks like this is already in intel-next, so

Re: [PATCH 1/5] mm/swapfile: add percpu_ref support for swap

2021-04-13 Thread Dennis Zhou
On Wed, Apr 14, 2021 at 11:59:03AM +0800, Huang, Ying wrote: > Dennis Zhou writes: > > > Hello, > > > > On Wed, Apr 14, 2021 at 10:06:48AM +0800, Huang, Ying wrote: > >> Miaohe Lin writes: > >> > >> > On 2021/4/14 9:17, Huang, Ying wrote: > >> >> Miaohe Lin writes: > >> >> > >> >>> On

Re: [PATCH v2 1/1] powerpc/iommu: Enable remaining IOMMU Pagesizes present in LoPAR

2021-04-13 Thread Leonardo Bras
On Mon, 2021-04-12 at 17:21 -0500, Segher Boessenkool wrote: > On Fri, Apr 09, 2021 at 02:36:16PM +1000, Alexey Kardashevskiy wrote: > > On 08/04/2021 19:04, Michael Ellerman wrote: > > > > > > +#define QUERY_DDW_PGSIZE_4K0x01 > > > > > > +#define QUERY_DDW_PGSIZE_64K 0x02 > > > > >

Re: Question on KASAN calltrace record in RT

2021-04-13 Thread Mike Galbraith
On Tue, 2021-04-13 at 17:29 +0200, Dmitry Vyukov wrote: > On Tue, Apr 6, 2021 at 10:26 AM Zhang, Qiang > wrote: > > > > Hello everyone > > > > In RT system, after Andrew test, found the following calltrace , > > in KASAN, we record callstack through stack_depot_save(), in this function, >

Re: [PATCH 1/5] mm/swapfile: add percpu_ref support for swap

2021-04-13 Thread Huang, Ying
Dennis Zhou writes: > Hello, > > On Wed, Apr 14, 2021 at 10:06:48AM +0800, Huang, Ying wrote: >> Miaohe Lin writes: >> >> > On 2021/4/14 9:17, Huang, Ying wrote: >> >> Miaohe Lin writes: >> >> >> >>> On 2021/4/12 15:24, Huang, Ying wrote: >> "Huang, Ying" writes: >> >> >

Re: [PATCH RFC 6/6] dcache: prevent flooding with negative dentries

2021-04-13 Thread Al Viro
On Thu, Jan 21, 2021 at 06:49:45PM +0530, Gautham Ananthakrishna wrote: > + spin_lock(>d_lock); > + parent = lock_parent(victim); > + > + rcu_read_unlock(); Similar story. As soon as you hit that rcu_read_unlock(), the memory pointed to by victim might be reused. If you have hit

the qemu-nbd process automatically exit with the commit 43347d56c 'livepatch: send a fake signal to all blocking tasks'

2021-04-13 Thread xiaojun . zhao141
I found the qemu-nbd process(started with qemu-nbd -t -c /dev/nbd0 nbd.qcow2) will automatically exit when I patched for functions of the nbd with livepatch. The nbd relative source: static int nbd_start_device_ioctl(struct nbd_device *nbd, struct block_device *bdev) {

[PATCH] netfilter: nf_conntrack: Add conntrack helper for ESP/IPsec

2021-04-13 Thread Cole Dishington
Introduce changes to add ESP connection tracking helper to netfilter conntrack. The connection tracking of ESP is based on IPsec SPIs. The underlying motivation for this patch was to allow multiple VPN ESP clients to be distinguished when using NAT. Added config flag CONFIG_NF_CT_PROTO_ESP to

Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

2021-04-13 Thread Viresh Kumar
On 14-04-21, 10:07, Jie Deng wrote: > Hi maintainers, > > What's the status of this patch based on the review comments you got ? I was expecting a new version to be honest.. > Is i2c/for-next the right tree to merge it > ? It should be. -- viresh

Re: [PATCH 1/5] mm/swapfile: add percpu_ref support for swap

2021-04-13 Thread Dennis Zhou
Hello, On Wed, Apr 14, 2021 at 10:06:48AM +0800, Huang, Ying wrote: > Miaohe Lin writes: > > > On 2021/4/14 9:17, Huang, Ying wrote: > >> Miaohe Lin writes: > >> > >>> On 2021/4/12 15:24, Huang, Ying wrote: > "Huang, Ying" writes: > > > Miaohe Lin writes: > > > >> We

Re: [PATCH RFC 1/6] dcache: sweep cached negative dentries to the end of list of siblings

2021-04-13 Thread Al Viro
On Thu, Jan 21, 2021 at 06:49:40PM +0530, Gautham Ananthakrishna wrote: > +static void sweep_negative(struct dentry *dentry) > +{ > + struct dentry *parent; > + > + if (!d_is_tail_negative(dentry)) { > + parent = lock_parent(dentry); > + if (!parent) > +

Re: [PATCH v2 00/16] Multigenerational LRU Framework

2021-04-13 Thread Yu Zhao
On Tue, Apr 13, 2021 at 5:14 PM Dave Chinner wrote: > > On Tue, Apr 13, 2021 at 10:13:24AM -0600, Jens Axboe wrote: > > On 4/13/21 1:51 AM, SeongJae Park wrote: > > > From: SeongJae Park > > > > > > Hello, > > > > > > > > > Very interesting work, thank you for sharing this :) > > > > > > On Tue,

Re: [PATCH 2/5] swap: fix do_swap_page() race with swapoff

2021-04-13 Thread Miaohe Lin
On 2021/4/14 11:07, Huang, Ying wrote: > Miaohe Lin writes: > >> On 2021/4/13 9:27, Huang, Ying wrote: >>> Miaohe Lin writes: >>> When I was investigating the swap code, I found the below possible race window: CPU 1 CPU 2 -

[PATCH] ASoC: codec: remove unused variable

2021-04-13 Thread Jiapeng Chong
Fix the following gcc warning: sound/soc/codecs/jz4760.c:201:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- sound/soc/codecs/jz4760.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

Re: [PATCH v2 2/3] drm/msm/dp: do not re initialize of audio_comp at display_disable()

2021-04-13 Thread Stephen Boyd
Quoting Kuogee Hsieh (2021-04-13 16:11:30) > At dongle unplug, dp initializes audio_comp followed by sending disconnect > event notification to audio and to make sure audio had shutdown completely > by wait for audio completion notification at display_disable(). This patch Is this

Re: [PATCH v2] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB

2021-04-13 Thread Bjorn Andersson
On Tue 13 Apr 21:51 CDT 2021, Julian Braha wrote: > When PINCTRL_MSM is enabled, and GPIOLIB is disabled, > Kbuild gives the following warning: > > WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP > Depends on [n]: GPIOLIB [=n] > Selected by [y]: > - PINCTRL_MSM [=y] &&

Re: [PATCH 1/3] vfio/iommu_type1: Add HWDBM status maintanance

2021-04-13 Thread kernel test robot
Hi Keqian, Thank you for the patch! Yet something to improve: [auto build test ERROR on vfio/next] [also build test ERROR on linux/master linus/master v5.12-rc7 next-20210413] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

Re: [PATCH 1/2] dt-bindings: soc: qcom: Add bindings for Qualcomm Memshare service

2021-04-13 Thread Bjorn Andersson
On Sat 10 Apr 03:05 CDT 2021, Nikita Travkin wrote: > Hi, sorry for a late reply but I couldn't answer earlier. > > 30.03.2021 19:40, Rob Herring ??: > > On Fri, Mar 19, 2021 at 10:23:20PM +0500, nikitos...@gmail.com wrote: > >> From: Nikita Travkin > >> > >> Add DT bindings for

[PATCH v2 6/8] MIPS: pci-legacy: remove redundant info messages

2021-04-13 Thread Ilya Lipnitskiy
Remove the following pci-legacy message: PCI host bridge /pci@44/host-bridge ranges: MEM 0x2000..0x2fff IO 0x0046..0x0046 It is followed shortly by the same data from pci_register_host_bridge: PCI host bridge to bus :00 pci_bus

[PATCH v2 8/8] MIPS: pci-legacy: use generic pci_enable_resources

2021-04-13 Thread Ilya Lipnitskiy
Follow the reasoning from commit 842de40d93e0 ("PCI: add generic pci_enable_resources()"): The only functional difference from the MIPS version is that the generic one uses "!r->parent" to check for resource collisions instead of "!r->start && r->end". That should have no effect on any

[PATCH v2 3/8] MIPS: pci-rt3883: trivial: remove unused variable

2021-04-13 Thread Ilya Lipnitskiy
Fixes the following compiler warning: warning: unused variable 'flags' [-Wunused-variable] Fixes: e5067c718b3a ("MIPS: pci-rt3883: Remove odd locking in PCI config space access code") Signed-off-by: Ilya Lipnitskiy Acked-by: Sergey Ryazanov Cc: triv...@kernel.org ---

[PATCH v2 7/8] MIPS: pci-legacy: remove busn_resource field

2021-04-13 Thread Ilya Lipnitskiy
No drivers set the busn_resource field in the pci_controller struct. Commit 7ee214b540d9 ("MIPS: PCI: Remove unused busn_offset") almost removed it over 3 years ago. Remove it for good to free up memory and eliminate messages like: pci_bus :00: root bus resource [??? 0x flags 0x0]

[PATCH v2 5/8] MIPS: pci-legacy: stop using of_pci_range_to_resource

2021-04-13 Thread Ilya Lipnitskiy
Mirror commit aeba3731b150 ("powerpc/pci: Fix IO space breakage after of_pci_range_to_resource() change"). Most MIPS platforms do not define PCI_IOBASE, nor implement pci_address_to_pio(). Moreover, IO_SPACE_LIMIT is 0x for most MIPS platforms. of_pci_range_to_resource passes the _start

[PATCH v2 1/8] MIPS: pci-rt2880: fix slot 0 configuration

2021-04-13 Thread Ilya Lipnitskiy
pci_fixup_irqs() used to call pcibios_map_irq on every PCI device, which for RT2880 included bus 0 slot 0. After pci_fixup_irqs() got removed, only slots/funcs with devices attached would be called. While arguably the right thing, that left no chance for this driver to ever initialize slot 0,

[PATCH v2 4/8] MIPS: pci-rt3883: more accurate DT error messages

2021-04-13 Thread Ilya Lipnitskiy
Existing strings do not make sense: one is always NULL and the other refers to the wrong parent node. Signed-off-by: Ilya Lipnitskiy --- arch/mips/pci/pci-rt3883.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/mips/pci/pci-rt3883.c b/arch/mips/pci/pci-rt3883.c

[PATCH v2 0/8] MIPS: fixes for PCI legacy drivers (rt2880, rt3883)

2021-04-13 Thread Ilya Lipnitskiy
One major fix for rt2880-pci in the first patch - fixes breakage that existed since v4.14. Other more minor fixes, cleanups, and improvements that either free up memory, make dmesg messages clearer, or remove redundant dmesg output. v2: - Do not use internal pci-rt2880 config read and write

[PATCH v2 2/8] MIPS: pci-rt2880: remove unneeded locks

2021-04-13 Thread Ilya Lipnitskiy
Mirror pci-rt3883 fix from commit e5067c718b3a ("MIPS: pci-rt3883: Remove odd locking in PCI config space access code"). pci-rt2880 shares the driver layout with pci-rt3883 and the same reasons apply. Caller (generic PCI code) already does proper locking, so no need to add another one here. Local

[PATCH v2] time: Fix overwrite err unexpected in clock_adjtime32

2021-04-13 Thread Chen Jun
the correct error is covered by put_old_timex32. Fixes: 3a4d44b61625 ("ntp: Move adjtimex related compat syscalls to native counterparts") Signed-off-by: Chen Jun --- v2: Make "Fixes" tag correct kernel/time/posix-timers.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 2/5] swap: fix do_swap_page() race with swapoff

2021-04-13 Thread Huang, Ying
Miaohe Lin writes: > On 2021/4/13 9:27, Huang, Ying wrote: >> Miaohe Lin writes: >> >>> When I was investigating the swap code, I found the below possible race >>> window: >>> >>> CPU 1 CPU 2 >>> - - >>>

Re: [PATCH v3] nbd_genl_status: null check for nla_nest_start

2021-04-13 Thread Mark-PK Tsai
From: Michal Kubecek Hi, I found that CVE-2019-16089 still exist in upstream kernel. Does anyone know why this patch was not merged?

Re: [PATCH 6/7] i915: Convert to verify_page_range()

2021-04-13 Thread Kees Cook
On Mon, Apr 12, 2021 at 10:00:18AM +0200, Peter Zijlstra wrote: > check_{present,absent}() only need R/O access, use verify_page_range() > instead to remove modular use of apply_to_page_range(). > > Signed-off-by: Peter Zijlstra (Intel) > --- > drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c

RE: [PATCH] arm64: dts: imx8mq-evk: add one regulator used to power up pcie phy

2021-04-13 Thread Richard Zhu
Hi Shawn: Regarding Lucas' advice, this patch should be split out and post for you to pick up into DT tree. Since the other two patches are accepted by PCIe tree now. Can you help to pick up this patch? Thanks in advanced.

Re: [PATCH 4/7] mm: Introduce verify_page_range()

2021-04-13 Thread Kees Cook
On Tue, Apr 13, 2021 at 09:36:32AM +0200, Peter Zijlstra wrote: > On Mon, Apr 12, 2021 at 01:05:09PM -0700, Kees Cook wrote: > > On Mon, Apr 12, 2021 at 10:00:16AM +0200, Peter Zijlstra wrote: > > > +struct vpr_data { > > > + int (*fn)(pte_t pte, unsigned long addr, void *data); > > > + void

Re: [v2 PATCH 6/7] mm: migrate: check mapcount for THP instead of ref count

2021-04-13 Thread Huang, Ying
Yang Shi writes: > The generic migration path will check refcount, so no need check refcount > here. > But the old code actually prevents from migrating shared THP (mapped by > multiple > processes), so bail out early if mapcount is > 1 to keep the behavior. What prevents us from migrating

Re: [PATCH RFC 1/6] dcache: sweep cached negative dentries to the end of list of siblings

2021-04-13 Thread Al Viro
On Thu, Jan 21, 2021 at 06:49:40PM +0530, Gautham Ananthakrishna wrote: > From: Konstantin Khlebnikov > > For disk filesystems result of every negative lookup is cached, content of > directories is usually cached too. Production of negative dentries isn't > limited with disk speed. It's really

Re: [PATCH 2/5] swap: fix do_swap_page() race with swapoff

2021-04-13 Thread Miaohe Lin
On 2021/4/13 9:27, Huang, Ying wrote: > Miaohe Lin writes: > >> When I was investigating the swap code, I found the below possible race >> window: >> >> CPU 1CPU 2 >> -- >> do_swap_page >> synchronous

[PATCH] mm: Define ARCH_HAS_FIRST_USER_ADDRESS

2021-04-13 Thread Anshuman Khandual
Currently most platforms define FIRST_USER_ADDRESS as 0UL duplicating the same code all over. Instead define a new option ARCH_HAS_FIRST_USER_ADDRESS for those platforms which would override generic default FIRST_USER_ADDRESS value 0UL. This makes it much cleaner with reduced code. Cc:

[PATCH v2] drivers: pinctrl: qcom: fix Kconfig dependency on GPIOLIB

2021-04-13 Thread Julian Braha
When PINCTRL_MSM is enabled, and GPIOLIB is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for GPIOLIB_IRQCHIP Depends on [n]: GPIOLIB [=n] Selected by [y]: - PINCTRL_MSM [=y] && PINCTRL [=y] && (ARCH_QCOM || COMPILE_TEST [=y]) This is because

Re: [PATCH 4.19 00/66] 4.19.187-rc1 review

2021-04-13 Thread Samuel Zou
On 2021/4/12 16:40, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.187 release. There are 66 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [RFC PATCH v2 2/2] kvm/arm64: Try stage2 block mapping for host device MMIO

2021-04-13 Thread Keqian Zhu
Hi Marc, I think I have fully tested this patch. The next step is to do some restriction on HVA in vfio module, so we can build block mapping for it with a higher probability. Is there anything to improve? If not, could you apply it? ^_^ Thanks, Keqian On 2021/4/7 21:18, Marc Zyngier wrote:

Re: [PATCH] hrtimer: Update softirq_expires_next correctly after __hrtimer_get_next_event()

2021-04-13 Thread Lorenzo Colitti
On Wed, Apr 14, 2021 at 2:14 AM Greg KH wrote: > To give context, the commit is now 46eb1701c046 ("hrtimer: Update > softirq_expires_next correctly after __hrtimer_get_next_event()") and is > attached below. > > The f_ncm.c driver is doing a lot of calls to hrtimer_start() with mode >

  1   2   3   4   5   6   7   8   9   10   >