Re: [PATCH 5/6] eventfs: get rid of dentry pointers without refcounts

2024-01-31 Thread Linus Torvalds
On Wed, 31 Jan 2024 at 05:14, Steven Rostedt wrote: > > If you also notice, tracefs only allows mkdir/rmdir to be assigned to > one directory. Once it is assigned, no other directories can have mkdir > rmdir functionality. I think that does limit the damage, but it's not clear that it is

Re: [PATCH 6/6] eventfs: clean up dentry ops and add revalidate function

2024-01-31 Thread Steven Rostedt
On Tue, 30 Jan 2024 11:03:55 -0800 Linus Torvalds wrote: > It would probably be cleaner to make eventfs its own filesystem, or at > least set its own dentry ops when looking up eventfs files. But as it > is, only eventfs dentries use d_fsdata, so we don't really need to split > these things up

Re: [ANNOUNCE] 5.10.204-rt100

2024-01-31 Thread Luis Claudio R. Goncalves
On Tue, Jan 30, 2024 at 08:35:51PM +0100, Pavel Machek wrote: > Hi! > > We (as in cip project), are trying to do -cip-rt releases > once a month. Are there any plans for 5.10-rt release any time soon? > That would help us ;-). Hi Pavel! I already pushed v5.10-rt-next (containing

Re: [linus:master] [eventfs] 852e46e239: BUG:unable_to_handle_page_fault_for_address

2024-01-31 Thread Steven Rostedt
On Wed, 31 Jan 2024 11:13:58 -0500 Steven Rostedt wrote: > On Wed, 31 Jan 2024 10:58:47 -0500 > Steven Rostedt wrote: > > > @@ -788,6 +717,7 @@ static void init_once(void *foo) > > { > > struct tracefs_inode *ti = (struct tracefs_inode *) foo; > > > > + memset(ti, 0, sizeof(*ti)); > >

Re: [linus:master] [eventfs] 852e46e239: BUG:unable_to_handle_page_fault_for_address

2024-01-31 Thread Steven Rostedt
On Wed, 31 Jan 2024 10:58:47 -0500 Steven Rostedt wrote: > BTW, I ran my full test suite on your patches with the below updates and it > all passed. Note, I did not run the "bisectable" portion of my test. That > is, the part that runs tests on each patch in the series. Because I know > that

Re: [PATCH RFC 0/4] Introduce uts_release

2024-01-31 Thread John Garry
On 31/01/2024 16:22, Greg KH wrote: before: real0m53.591s user1m1.842s sys 0m9.161s after: real0m37.481s user0m46.461s sys 0m7.199s Sending as an RFC as I need to test more of the conversions and I would like to also convert more UTS_RELEASE users to prove this is

Re: [PATCH v9 3/3] remoteproc: zynqmp: parse TCM from device tree

2024-01-31 Thread Mathieu Poirier
On Tue, Jan 30, 2024 at 02:47:07PM -0600, Tanmay Shah wrote: > > On 1/17/24 12:58 PM, Mathieu Poirier wrote: > > Alright, I spent several hours looking at this patchset and the driver as a > > whole. I certainly salute your efforts to heed my advice and make the code > > less > > brittle but

Re: [PATCH RFC 0/4] Introduce uts_release

2024-01-31 Thread Greg KH
On Wed, Jan 31, 2024 at 10:48:47AM +, John Garry wrote: > When hacking it is a waste of time and compute energy that we need to > rebuild much kernel code just for changing the head git commit, like this: > > > touch include/generated/utsrelease.h > > time make -j3 > mkdir -p

Re: [linus:master] [eventfs] 852e46e239: BUG:unable_to_handle_page_fault_for_address

2024-01-31 Thread Steven Rostedt
On Wed, 31 Jan 2024 10:58:47 -0500 Steven Rostedt wrote: > @@ -788,6 +717,7 @@ static void init_once(void *foo) > { > struct tracefs_inode *ti = (struct tracefs_inode *) foo; > > + memset(ti, 0, sizeof(*ti)); > inode_init_once(>vfs_inode); > } > Note, that

Re: [linus:master] [eventfs] 852e46e239: BUG:unable_to_handle_page_fault_for_address

2024-01-31 Thread Steven Rostedt
On Tue, 30 Jan 2024 11:54:56 -0800 Linus Torvalds wrote: > If you do run the full tracefs tests on the whole series, and there > are no other major problems, I'll happily take it all for 6.8. And > yes, even mark it for stable. I think the other bugs are much harder > to hit, but I do think they

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

2024-01-31 Thread Marek Szyprowski
Hi Christophe, On 31.01.2024 12:58, Christophe Leroy wrote: > Le 30/01/2024 à 18:48, Marek Szyprowski a écrit : >> [Vous ne recevez pas souvent de courriers de m.szyprow...@samsung.com. >> Découvrez pourquoi ceci est important à >> https://aka.ms/LearnAboutSenderIdentification ] >> >> On

Re: [RFC PATCH v2 8/8] dax: Fix incorrect list of dcache aliasing architectures

2024-01-31 Thread Mathieu Desnoyers
On 2024-01-30 22:13, Dan Williams wrote: Dave Chinner wrote: On Tue, Jan 30, 2024 at 11:52:55AM -0500, Mathieu Desnoyers wrote: commit d92576f1167c ("dax: does not work correctly with virtual aliasing caches") prevents DAX from building on architectures with virtually aliased dcache with:

Re: [RFC PATCH v2 7/8] Introduce dcache_is_aliasing() across all architectures

2024-01-31 Thread Mathieu Desnoyers
On 2024-01-30 21:48, Dave Chinner wrote: On Tue, Jan 30, 2024 at 11:52:54AM -0500, Mathieu Desnoyers wrote: Introduce a generic way to query whether the dcache is virtually aliased on all architectures. Its purpose is to ensure that subsystems which are incompatible with virtually aliased data

How to display a ktime value as trace timestamp in trace output?

2024-01-31 Thread David Howells
Hi Steven, I have a tracepoint in AF_RXRPC that displays information about a timeout I'm going to set. I have the timeout in a ktime_t as an absolute time. Is there a way to display this in the trace output such that it looks like a trace timestamp and can be (roughly) correlated with the

Re: [PATCH RFC v3 08/35] mm: cma: Introduce cma_alloc_range()

2024-01-31 Thread Alexandru Elisei
Hi, On Wed, Jan 31, 2024 at 11:54:17AM +0530, Anshuman Khandual wrote: > > > On 1/30/24 17:05, Alexandru Elisei wrote: > > Hi, > > > > On Tue, Jan 30, 2024 at 10:50:00AM +0530, Anshuman Khandual wrote: > >> > >> On 1/25/24 22:12, Alexandru Elisei wrote: > >>> Today, cma_alloc() is used to

[PATCH] ring-buffer: Clean ring_buffer_poll_wait() error return

2024-01-31 Thread Vincent Donnefort
The return type for ring_buffer_poll_wait() is __poll_t. This is behind the scenes an unsigned where we can set event bits. In case of a non-allocated CPU, we do return instead -EINVAL (0xffea). Lucky us, this ends up setting few error bits (EPOLLERR | EPOLLHUP | EPOLLNVAL), so user-space at

Re: [PATCH RFC v3 09/35] mm: cma: Introduce cma_remove_mem()

2024-01-31 Thread Alexandru Elisei
Hi, On Wed, Jan 31, 2024 at 06:49:34PM +0530, Anshuman Khandual wrote: > On 1/30/24 17:03, Alexandru Elisei wrote: > > Hi, > > > > I really appreciate the feedback you have given me so far. I believe the > > commit message isn't clear enough and there has been a confusion. > > > > A CMA user

Re: [PATCH RFC v3 06/35] mm: cma: Make CMA_ALLOC_SUCCESS/FAIL count the number of pages

2024-01-31 Thread Alexandru Elisei
Hi, On Wed, Jan 31, 2024 at 10:10:05AM +0530, Anshuman Khandual wrote: > > > On 1/30/24 17:28, Alexandru Elisei wrote: > > Hi, > > > > On Tue, Jan 30, 2024 at 10:22:11AM +0530, Anshuman Khandual wrote: > >> > >> On 1/29/24 17:21, Alexandru Elisei wrote: > >>> Hi, > >>> > >>> On Mon, Jan 29,

Re: [PATCH RFC v3 09/35] mm: cma: Introduce cma_remove_mem()

2024-01-31 Thread Anshuman Khandual
On 1/30/24 17:03, Alexandru Elisei wrote: > Hi, > > I really appreciate the feedback you have given me so far. I believe the > commit message isn't clear enough and there has been a confusion. > > A CMA user adds a CMA area to the cma_areas array with > cma_declare_contiguous_nid() or

Re: [PATCH 5/6] eventfs: get rid of dentry pointers without refcounts

2024-01-31 Thread Steven Rostedt
On Wed, 31 Jan 2024 07:57:40 -0500 Steven Rostedt wrote: > static int instance_rmdir(const char *name) > { > struct trace_array *tr; > int ret; > > mutex_lock(_mutex); Note, event_mutex prevents dynamic events from being created. No kprobe can be added while the

Re: [PATCH 5/6] eventfs: get rid of dentry pointers without refcounts

2024-01-31 Thread Steven Rostedt
On Tue, 30 Jan 2024 22:20:24 -0800 Linus Torvalds wrote: > On Tue, 30 Jan 2024 at 21:57, Linus Torvalds > wrote: > > > > Ugh. > > Oh, and double-ugh on that tracefs_syscall_mkdir/rmdir(). I hate how > it does that "unlock and re-lock inode" thing. I'd figured you'd like that one. > > It's

Re: [PATCH RFC v3 11/35] mm: Allow an arch to hook into folio allocation when VMA is known

2024-01-31 Thread Alexandru Elisei
Hi, On Wed, Jan 31, 2024 at 12:23:51PM +0530, Anshuman Khandual wrote: > > > On 1/30/24 17:04, Alexandru Elisei wrote: > > Hi, > > > > On Tue, Jan 30, 2024 at 03:25:20PM +0530, Anshuman Khandual wrote: > >> > >> On 1/25/24 22:12, Alexandru Elisei wrote: > >>> arm64 uses VM_HIGH_ARCH_0 and

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

2024-01-31 Thread Christophe Leroy
Hi, Le 30/01/2024 à 18:48, Marek Szyprowski a écrit : > [Vous ne recevez pas souvent de courriers de m.szyprow...@samsung.com. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > Dear All, > > On 30.01.2024 12:03, Christophe Leroy wrote: >> Le

Re: [PATCH 0/4] apply page shift to PFN instead of VA in pfn_to_virt

2024-01-31 Thread Arnd Bergmann
On Wed, Jan 31, 2024, at 06:51, Yan Zhao wrote: > This is a tiny fix to pfn_to_virt() for some platforms. > > The original implementaion of pfn_to_virt() takes PFN instead of PA as the > input to macro __va, with PAGE_SHIFT applying to the converted VA, which > is not right under most conditions,

Re: [RFC PATCH 2/5] mfd: add 88pm88x driver

2024-01-31 Thread Lee Jones
On Sun, 28 Jan 2024, Karel Balej wrote: > > > + /* GPIO1: DVC, GPIO0: input */ > > > + REG_SEQ0(PM88X_REG_GPIO_CTRL1, 0x40), > > > > Shouldn't you set these up using Pintrl? > > You mean to add a new MFD cell for the pins and write the respective > driver? The downstream implementation has no

[PATCH RFC 1/4] init: Add uts_release

2024-01-31 Thread John Garry
Add a char [] for UTS_RELEASE so that we don't need to rebuild code which references UTS_RELEASE. Signed-off-by: John Garry --- include/linux/utsname.h | 1 + init/version.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/include/linux/utsname.h b/include/linux/utsname.h index

[PATCH RFC 0/4] Introduce uts_release

2024-01-31 Thread John Garry
When hacking it is a waste of time and compute energy that we need to rebuild much kernel code just for changing the head git commit, like this: > touch include/generated/utsrelease.h > time make -j3 mkdir -p /home/john/mnt_sda4/john/kernel-dev2/tools/objtool && make

[PATCH RFC 4/4] firmware_loader: Use uts_release

2024-01-31 Thread John Garry
Instead of using UTS_RELEASE, use uts_release, which means that we don't need to rebuild the code just for the git head commit changing. Since UTS_RELEASE was used for fw_path and this points to const data, append uts_release dynamically to an intermediate string. Signed-off-by: John Garry ---

[PATCH RFC 3/4] net: ethtool: Use uts_release

2024-01-31 Thread John Garry
Instead of using UTS_RELEASE, use uts_release, which means that we don't need to rebuild the code just for the git head commit changing. Signed-off-by: John Garry --- net/ethtool/ioctl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ethtool/ioctl.c

[PATCH RFC 2/4] tracing: Use uts_release

2024-01-31 Thread John Garry
Instead of using UTS_RELEASE, use uts_release, which means that we don't need to rebuild the code just for the git head commit changing. Signed-off-by: John Garry --- kernel/trace/trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/trace/trace.c

[PATCH net v2 2/2] net: dqs: add NIC stall detector based on BQL

2024-01-31 Thread Breno Leitao
From: Jakub Kicinski softnet_data->time_squeeze is sometimes used as a proxy for host overload or indication of scheduling problems. In practice this statistic is very noisy and has hard to grasp units - e.g. is 10 squeezes a second to be expected, or high? Delaying network (NAPI) processing

Re: [PATCH 3/3] remoteproc: qcom_q6v5_pas: Unload lite firmware on ADSP

2024-01-31 Thread Abel Vesa
On 24-01-29 17:17:28, Dmitry Baryshkov wrote: > On Mon, 29 Jan 2024 at 15:35, Abel Vesa wrote: > > > > From: Sibi Sankar > > > > The UEFI loads a lite variant of the ADSP firmware to support charging > > use cases. The kernel needs to unload and reload it with the firmware > > that has full

<    1   2