Re: [PATCH] ARM: OMAP1: fix incorrect kernel-doc comment syntax in file

2021-03-30 Thread Aaro Koskinen
t; OMAP1610_GPTIMER1_BASE() instead" > > Provide a simple fix by replacing this occurrence with general comment > format, i.e. '/*', to prevent kernel-doc from parsing it. > > Signed-off-by: Aditya Srivastava Acked-by: Aaro Koskinen A. > --- > * Applies perfectly on nex

[PATCH] ARM: OMAP1: OSK: fix ohci-omap breakage

2020-12-14 Thread Aaro Koskinen
;usb: ohci-omap: Fix descriptor conversion") Signed-off-by: Linus Walleij [aaro.koski...@iki.fi: rebased and updated the changelog] Signed-off-by: Aaro Koskinen --- This is the patch that should have been merged: https://marc.info/?l=linux-usb=160682513710441=2 arch/arm/mach-omap1/b

[PATCH] ARM: dts: OMAP3: disable AES on N950/N9

2020-11-29 Thread Aaro Koskinen
AES needs to be disabled on Nokia N950/N9 as well (HS devices), otherwise kernel fails to boot. Fixes: c312f066314e ("ARM: dts: omap3: Migrate AES from hwmods to sysc-omap2") Signed-off-by: Aaro Koskinen --- arch/arm/boot/dts/omap3-n950-n9.dtsi | 8 1 file changed, 8

Re: [BISECTED REGRESSION] Broken USB/GPIO on OMAP1 OSK

2020-11-29 Thread Aaro Koskinen
Hi, On Sun, Nov 29, 2020 at 01:51:54AM +0200, Aaro Koskinen wrote: > I tried to upgrade my OMAP1 OSK board to v5.9, but the rootfs cannot > be accessed anymore due to broken USB. It fails to probe with the > following logs: > > [9.219940] ohci ohci: cannot find GPIO ch

[BISECTED REGRESSION] Broken USB/GPIO on OMAP1 OSK

2020-11-28 Thread Aaro Koskinen
Hi, I tried to upgrade my OMAP1 OSK board to v5.9, but the rootfs cannot be accessed anymore due to broken USB. It fails to probe with the following logs: [9.219940] ohci ohci: cannot find GPIO chip i2c-tps65010, deferring [9.250366] ohci ohci: cannot find GPIO chip i2c-tps65010,

Re: [REGRESSION] omapdrm/N900 display broken

2020-08-23 Thread Aaro Koskinen
Hi, On Tue, Aug 04, 2020 at 03:39:37PM +0300, Tomi Valkeinen wrote: > On 04/08/2020 15:13, Tomi Valkeinen wrote: > > Can you try to pinpoint a bit where the hang happens? Maybe add > > DRM/omapdrm debug prints, or perhaps sysrq works and it shows a lock > > that's in deadlock. > > Also, one

[REGRESSION] omapdrm/N900 display broken

2020-07-28 Thread Aaro Koskinen
Hi, Looks like N900 display support has broken after v5.6. When using v5.7, or the current mainline (v5.8-rc7), the boot hangs at: [6.269500] omapdss_dss 4805.dss: 4805.dss supply vdda_video not found, using dummy regulator [6.321685] DSS: OMAP DSS rev 2.0 [6.328002]

Re: [Outreachy kernel] [PATCH v2 0/5] Remove typedef declarations in staging: octeon

2019-10-23 Thread Aaro Koskinen
Hi, On Sat, Oct 12, 2019 at 08:35:19PM +0200, Julia Lawall wrote: > On Sat, 12 Oct 2019, Wambui Karuga wrote: > > This patchset removes the addition of new typedefs data types in octeon, > > along with replacing the previous uses with the new declaration format. > > > > v2 of the series removes

Re: [PATCH] staging: octeon: Fix incorrect type in assignment

2019-10-23 Thread Aaro Koskinen
Hi, On Thu, Oct 10, 2019 at 07:38:15AM +0300, Wambui Karuga wrote: > Fix the following warning generated by sparse in > drivers/staging/octeon/ethernet-tx.c: > > drivers/staging/octeon/ethernet-tx.c:563:50: warning: incorrect type in > assignment (different base types) >

Re: [PATCH] staging: octeon: Remove typedef declaration

2019-10-23 Thread Aaro Koskinen
Hi, On Tue, Oct 08, 2019 at 07:09:43AM +0300, Wambui Karuga wrote: > Fixes checkpatch.pl warning: do not add new typedefs in > drivers/staging/octeon/octeon-stubs.h:41 > > Signed-off-by: Wambui Karuga > --- > drivers/staging/octeon/octeon-stubs.h | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [PATCH 02/13] MIPS: Loongson64: Sepreate loongson2ef/loongson64 code

2019-09-02 Thread Aaro Koskinen
On Wed, Aug 28, 2019 at 08:37:34AM +0800, Jiaxun Yang wrote: > On 2019/8/28 上午6:05, Aaro Koskinen wrote: > Hi Aaro, > >You need to update lemote2f_defconfig with his patch. > > How to generate this config? We should not edit it manually right? It's possible to edit chang

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-28 Thread Aaro Koskinen
Hi, On Wed, Aug 28, 2019 at 03:02:36PM +0200, Arnd Bergmann wrote: > On Tue, Aug 27, 2019 at 9:05 PM Aaro Koskinen wrote: > > On Tue, Aug 27, 2019 at 06:33:01PM +0200, Arnd Bergmann wrote: > > > On Fri, Aug 16, 2019 at 10:34 AM Aaro Koskinen > > > wrote: >

Re: [PATCH 02/13] MIPS: Loongson64: Sepreate loongson2ef/loongson64 code

2019-08-27 Thread Aaro Koskinen
Hi, On Tue, Aug 27, 2019 at 04:52:51PM +0800, Jiaxun Yang wrote: > As later model of GSx64 family processors including 2-series-soc have > similar design with initial loongson3a while loongson2e/f seems less > identical, we seprate loongson2e/f support code out of mach-loongson64

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-27 Thread Aaro Koskinen
Hi, On Tue, Aug 27, 2019 at 06:33:01PM +0200, Arnd Bergmann wrote: > On Fri, Aug 16, 2019 at 10:34 AM Aaro Koskinen wrote: > > On Wed, Aug 14, 2019 at 12:36:40PM +0200, Arnd Bergmann wrote: > > > On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > > > >

Re: Build regressions/improvements in v5.3-rc5

2019-08-21 Thread Aaro Koskinen
Hi, On Mon, Aug 19, 2019 at 11:07:49AM +0200, Geert Uytterhoeven wrote: > On Mon, Aug 19, 2019 at 10:47 AM Geert Uytterhoeven > wrote: > > JFYI, when comparing v5.3-rc5[1] to v5.3-rc4[3], the summaries are: > > - build errors: +7/-0 > > + /kisskb/src/include/asm-generic/5level-fixup.h:

OMAP DRM regression on N900

2019-08-18 Thread Aaro Koskinen
Hi, I haven't got display working on N900 since v5.1. Bisected to: d17eb4537a7eb16da9eafbfd5717e12b45b77251 is the first bad commit commit d17eb4537a7eb16da9eafbfd5717e12b45b77251 Author: Laurent Pinchart Date: Wed Sep 12 19:41:31 2018 +0300 drm/omap: Factor out common init/cleanup code

Re: [PATCH 1/7] [RFC] ARM: remove Intel iop33x and iop13xx support

2019-08-16 Thread Aaro Koskinen
Hi, On Fri, Aug 16, 2019 at 04:58:33PM +0100, Russell King - ARM Linux admin wrote: > On Fri, Aug 16, 2019 at 06:42:49PM +0300, Aaro Koskinen wrote: > > On Wed, Aug 14, 2019 at 10:36:01AM +0200, Linus Walleij wrote: > > > On Mon, Aug 12, 2019 at 11:45 AM Martin Michlmayr wrot

Re: [PATCH 1/7] [RFC] ARM: remove Intel iop33x and iop13xx support

2019-08-16 Thread Aaro Koskinen
Hi, On Wed, Aug 14, 2019 at 10:36:01AM +0200, Linus Walleij wrote: > On Mon, Aug 12, 2019 at 11:45 AM Martin Michlmayr wrote: > > As Arnd points out, Debian used to have support for various iop32x > > devices. While Debian hasn't supported iop32x in a number of years, > > these devices are

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-16 Thread Aaro Koskinen
Hi, On Wed, Aug 14, 2019 at 12:36:40PM +0200, Arnd Bergmann wrote: > On Wed, Aug 14, 2019 at 9:49 AM Tony Lindgren wrote: > > * Arnd Bergmann [190813 19:34]: > > > -#define OMAP1_IO_OFFSET0x0100 /* Virtual IO > > > = 0xfefb */ > > > +#define OMAP1_IO_OFFSET

Re: [PATCH 21/22] ARM: omap1: use common clk framework

2019-08-14 Thread Aaro Koskinen
Hi, On Thu, Aug 08, 2019 at 11:43:39PM +0200, Arnd Bergmann wrote: > The omap1 clock driver now uses types and calling conventions > that are compatible with the common clk core. > > Turn on CONFIG_COMMON_CLK and remove all the code that is > now duplicated. > > Note: if this previous steps

Re: [PATCH 14/22] ARM: omap1: use pci_ioremap_io() for omap_cf

2019-08-13 Thread Aaro Koskinen
Hi, On Tue, Aug 13, 2019 at 01:02:16PM +0200, Arnd Bergmann wrote: > On Tue, Aug 13, 2019 at 12:36 PM Tony Lindgren wrote: > > * Arnd Bergmann [190808 21:34]: > > > The ISA I/O space handling in omap_cf is incompatible with > > > PCI drivers in a multiplatform kernel, and requires a custom > >

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

2019-06-14 Thread Aaro Koskinen
stopped working. Add a 30-bit ZONE_DMA to the 32-bit pmac builds > > to allow them to reliably allocate dma coherent memory. > > > > Fixes: 65a21b71f948 ("powerpc/dma: remove dma_nommu_dma_supported") > > Reported-by: Aaro Koskinen > > Signed-off-by: Ch

Re: [PATCH] powerpc: enable a 30-bit ZONE_DMA for 32-bit pmac

2019-06-14 Thread Aaro Koskinen
o allow them to reliably allocate dma coherent memory. > > Fixes: 65a21b71f948 ("powerpc/dma: remove dma_nommu_dma_supported") > Reported-by: Aaro Koskinen > Signed-off-by: Christoph Hellwig Tested-by: Aaro Koskinen A. > --- > arch/powerpc/include/asm/page.h

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-06-12 Thread Aaro Koskinen
Hi, On Wed, Jun 12, 2019 at 06:55:28AM +0100, Maciej W. Rozycki wrote: > On Tue, 11 Jun 2019, Aaro Koskinen wrote: > > > However, with your patch the "nobody cared" is never reached so all is > > good. I tried 10 boots with the patch and all were successful. Witho

Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook

2019-06-11 Thread Aaro Koskinen
Hi, On Tue, Jun 11, 2019 at 05:20:12PM -0500, Larry Finger wrote: > It is obvious that the case of a mask smaller than min_mask should be > handled by the IOMMU. In my system, CONFIG_IOMMU_SUPPORT is selected. All > other CONFIG variables containing IOMMU are not selected. When >

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-06-10 Thread Aaro Koskinen
Hi, On Sun, May 26, 2019 at 06:19:00AM -0300, Alexandre Oliva wrote: > On Mar 8, 2019, "Maciej W. Rozycki" wrote: > > > Anyway I meant: does `war_io_reorder_wmb' expand to `wmb' on your system? > > No, it expands to `barrier' on the yeeloong: > > CONFIG_CPU_LOONGSON2F=y >

Re: [BISECTED REGRESSION] b43legacy broken on G4 PowerBook

2019-06-06 Thread Aaro Koskinen
Hi, On Thu, Jun 06, 2019 at 10:54:51AM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2019-06-06 at 01:50 +0300, Aaro Koskinen wrote: > > Hi, > > > > When upgrading from v5.0 -> v5.1 on G4 PowerBook, I noticed WLAN does > > not work anymore: > > > &

[BISECTED REGRESSION] b43legacy broken on G4 PowerBook

2019-06-05 Thread Aaro Koskinen
Hi, When upgrading from v5.0 -> v5.1 on G4 PowerBook, I noticed WLAN does not work anymore: [ 42.004303] b43legacy-phy0: Loading firmware version 0x127, patch level 14 (2005-04-18 02:36:27) [ 42.184837] b43legacy-phy0 debug: Chip initialized [ 42.184873] b43legacy-phy0 ERROR: The

Re: [PATCH v3] powerpc: fix kexec failure on book3s/32

2019-06-05 Thread Aaro Koskinen
MMU and jump to the second part. So it > is possible to run this first part inplace instead of running the > copy. Once the MMU is off, there is no protection anymore and the > second part of the code will just run as before. > > Reported-by: Aaro Koskinen > Fixes: 63b2bc619565 ("

Re: [Qemu-devel] Running linux on qemu omap

2019-05-24 Thread Aaro Koskinen
Hi, On Fri, May 24, 2019 at 06:00:18PM +0300, Aaro Koskinen wrote: > Please don't delete OMAP boards quite yet :) In the mainline kernel > they are not orphaned, they frequently get tested using actual hardware, > and QEMU would help in additional testing. I'll try to get N8x0 boot

Re: [Qemu-devel] Running linux on qemu omap

2019-05-24 Thread Aaro Koskinen
Hi, On Fri, May 24, 2019 at 10:08:09AM +0100, Peter Maydell wrote: > On Thu, 23 May 2019 at 19:36, Aaro Koskinen wrote: > > Cheetah works with serial console. I tried with console on display, > > and it seems to boot up, and the frame buffer window gets correctly > > size

Re: [Qemu-devel] Running linux on qemu omap

2019-05-23 Thread Aaro Koskinen
Hi, On Thu, May 23, 2019 at 02:00:41PM +0200, Philippe Mathieu-Daudé wrote: > On 5/23/19 1:27 PM, Thomas Huth wrote: > > On 22/05/2019 20.19, Aaro Koskinen wrote: > >> On Wed, May 22, 2019 at 11:33:41AM +0200, Corentin Labbe wrote: > >>> qemu-system-arm -M

Re: Running linux on qemu omap

2019-05-22 Thread Aaro Koskinen
Hi, On Wed, May 22, 2019 at 11:33:41AM +0200, Corentin Labbe wrote: > qemu-system-arm -M help |grep OMAP > cheetah Palm Tungsten|E aka. Cheetah PDA (OMAP310) > n800 Nokia N800 tablet aka. RX-34 (OMAP2420) > n810 Nokia N810 tablet aka. RX-44 (OMAP2420)

Re: [PATCH] kernel/panic: Use SYSTEM_RESET2 command for warm reset

2019-05-16 Thread Aaro Koskinen
Hi, On Wed, May 08, 2019 at 06:47:12PM -0700, Prasad Sodagudi wrote: > Some platforms may need warm reboot support when kernel crashed > for post mortem analysis instead of cold reboot. So use config > CONFIG_WARM_REBOOT_ON_PANIC and SYSTEM_RESET2 psci command > support for warm reset. Please

Re: [PATCH] dt-bindings: Convert vendor prefixes to json-schema

2019-05-13 Thread Aaro Koskinen
Hi, On Mon, May 13, 2019 at 08:02:08AM -0500, Rob Herring wrote: > On Sat, May 11, 2019 at 1:23 PM Aaro Koskinen wrote: > > On Fri, May 10, 2019 at 02:40:18PM -0500, Rob Herring wrote: > > > Convert the vendor prefix registry to a schema. This will enable checking > > &g

Re: [PATCH] dt-bindings: Convert vendor prefixes to json-schema

2019-05-11 Thread Aaro Koskinen
On Fri, May 10, 2019 at 02:40:18PM -0500, Rob Herring wrote: > Convert the vendor prefix registry to a schema. This will enable checking > that new vendor prefixes are added (in addition to the less than perfect > checkpatch.pl check) and will also check against adding other prefixes > which are

Re: [PATCH] staging: xgifb: delete the driver

2019-04-25 Thread Aaro Koskinen
Hi, On Fri, Jan 18, 2019 at 12:20:28PM +0100, Daniel Vetter wrote: > On Fri, Jan 18, 2019 at 11:08:28AM +0100, Greg Kroah-Hartman wrote: > > There has not been any real work done on cleaning this driver up and > > getting it out of the staging tree in years. Also, no new fb drivers > > are being

[PATCH] ARM: OMAP1: ams-delta: fix early boot crash when LED support is disabled

2019-04-15 Thread Aaro Koskinen
When we boot with the LED support (CONFIG_NEW_LEDS) disabled, gpio_led_register_device() will return a NULL pointer and we try to dereference it. Fix by checking also for a NULL pointer. Fixes: 19a2668a8ae3 ("ARM: OMAP1: ams-delta: Provide GPIO lookup table for LED device") Signed-of

Re: [RESEND][PATCH v2] firmware/psci: add support for SYSTEM_RESET2

2019-04-11 Thread Aaro Koskinen
Hi, On Thu, Apr 11, 2019 at 05:49:36PM +0100, Sudeep Holla wrote: > On Thu, Apr 11, 2019 at 11:42:28AM +, Koskinen, Aaro (Nokia - FI/Espoo) > wrote: > > From: Sudeep Holla [sudeep.ho...@arm.com]: > > > static void psci_sys_reset(enum reboot_mode reboot_mode, const char *cmd) > > > { > > >

Re: [PATCH v2] drivers: firmware: psci: add support for warm reset

2019-04-05 Thread Aaro Koskinen
Hi, On Fri, Apr 05, 2019 at 08:58:30AM +0530, saiprakash.ran...@codeaurora.org wrote: > On 2019-04-04 00:21, Aaro Koskinen wrote: > >From: Aaro Koskinen > > > >Add support for warm reset using SYSTEM_RESET2 introduced in PSCI > >1.1 specification. > > &

[PATCH v2] drivers: firmware: psci: add support for warm reset

2019-04-03 Thread Aaro Koskinen
From: Aaro Koskinen Add support for warm reset using SYSTEM_RESET2 introduced in PSCI 1.1 specification. Signed-off-by: Aaro Koskinen --- v2: Added #define PSCI_1_1_SYSTEM_RESET_WARM. Refactored psci_probe. v1: https://marc.info/?l=linux-arm-kernel

Re: [PATCH] drivers: firmware: psci: add support for warm reset

2019-04-03 Thread Aaro Koskinen
Hi, On Wed, Apr 03, 2019 at 04:33:15AM +0100, Mark Rutland wrote: > On Mon, Apr 01, 2019 at 09:14:43PM +0300, Aaro Koskinen wrote: > > From: Aaro Koskinen > > > > Add support for warm reset using SYSTEM_RESET2 introduced in PSCI > > 1.1 specification. > >

[PATCH] drivers: firmware: psci: add support for warm reset

2019-04-01 Thread Aaro Koskinen
From: Aaro Koskinen Add support for warm reset using SYSTEM_RESET2 introduced in PSCI 1.1 specification. Signed-off-by: Aaro Koskinen --- drivers/firmware/psci.c | 25 + include/uapi/linux/psci.h | 3 +++ 2 files changed, 28 insertions(+) diff --git a/drivers

Re: [PATCH] staging: octeon-ethernet: fix incorrect PHY mode

2019-03-26 Thread Aaro Koskinen
Hi, On Tue, Mar 26, 2019 at 10:01:50AM +0100, Andrew Lunn wrote: > Humm, that is unique, as far as i know. Every other MAC driver uses > of_get_phy_mode() to get the value out of device tree. The proprietary > delay values can then be used to fine tune the basic delay setting > read from DT.

[PATCH] staging: octeon-ethernet: fix incorrect PHY mode

2019-03-25 Thread Aaro Koskinen
rrect mode. Tested on EdgeRouter Lite (RGMII_RXID, at803x PHY) and D-Link DSR-500N (RGMII, broadcom PHY). Fixes: 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode") Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 2 +- drivers/stagi

Re: [PATCH] mtd: rawnand: ams-delta: Drop board specific partition info

2019-03-24 Thread Aaro Koskinen
Hi, On Sun, Mar 24, 2019 at 05:48:22PM +0100, Janusz Krzysztofik wrote: > Hi Aaro, > > Thanks for your review. > > On Wednesday, March 20, 2019 2:16:30 AM CET Aaro Koskinen wrote: > > On Tue, Mar 19, 2019 at 11:37:18PM +0100, Janusz Krzysztofik wrote: > > > Af

[PATCH v4] panic/reboot: allow specifying reboot_mode for panic only

2019-03-21 Thread Aaro Koskinen
From: Aaro Koskinen Allow specifying reboot_mode for panic only. This is needed on systems where ramoops is used to store panic logs, and user wants to use warm reset to preserve those, while still having cold reset on normal reboots. Signed-off-by: Aaro Koskinen Reviewed-by: Kees Cook

Re: [RESEND PATCH] mips: ralink: allow zboot

2019-03-21 Thread Aaro Koskinen
Hi, On Thu, Mar 21, 2019 at 11:03:34AM -0600, George Hilliard wrote: > Architecturally, there's nothing preventing compressed images from > working. Bootloaders built with support for the various compression > methods can decompress and run the kernel. In practice, many > bootloaders do not

Re: [PATCH] mtd: rawnand: ams-delta: Drop board specific partition info

2019-03-19 Thread Aaro Koskinen
On Tue, Mar 19, 2019 at 11:37:18PM +0100, Janusz Krzysztofik wrote: > After recent modifications, only a hardcoded partition info makes > the driver device specific. Other than that, the driver uses GPIO > exclusively and can be used on any hardware. > > Drop the partition info and use MTD

Re: [PATCH] ARM: OMAP1: ams-delta: Fix broken GPIO ID allocation

2019-03-19 Thread Aaro Koskinen
p board specific global GPIO > numbers") > Signed-off-by: Janusz Krzysztofik > Cc: sta...@vger.kernel.org Acked-by: Aaro Koskinen A.

Re: [PATCH] staging: octeon-usb octeon-hcd: Fix several typos.

2019-03-15 Thread Aaro Koskinen
Hi, On Sat, Mar 09, 2019 at 03:18:27PM -0300, Laura Lazzati wrote: > I found that the comments had several typos such as "aenable", "internaly" > and some others. > I fixed them all. > > Signed-off-by: Laura Lazzati I spotted one more typo that could be fixed as well: > @@ -1797,7 +1797,7 @@

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-03-07 Thread Aaro Koskinen
Hi, On Thu, Mar 07, 2019 at 03:41:01AM -0300, Alexandre Oliva wrote: > On Feb 17, 2019, "Maciej W. Rozycki" wrote: > > > Is there an MMIO completion barrier missing there somewhere by any chance > > causing an IRQ that has been handled already to be redelivered because an > > MMIO write

[PATCH v3] panic/reboot: allow specifying reboot_mode for panic only

2019-02-21 Thread Aaro Koskinen
From: Aaro Koskinen Allow specifying reboot_mode for panic only. This is needed on systems where ramoops is used to store panic logs, and user wants to use warm reset to preserve those, while still having cold reset on normal reboots. Signed-off-by: Aaro Koskinen --- v3: Move

[RESEND PATCH v2] panic/reboot: allow specifying reboot_mode for panic only

2019-02-21 Thread Aaro Koskinen
From: Aaro Koskinen Allow specifying reboot_mode for panic only. This is needed on systems where ramoops is used to store panic logs, and user wants to use warm reset to preserve those, while still having cold reset on normal reboots. Signed-off-by: Aaro Koskinen --- v2: Use

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-02-17 Thread Aaro Koskinen
On Sun, Feb 17, 2019 at 01:59:26AM -0300, Alexandre Oliva wrote: > On Feb 11, 2019, Aaro Koskinen wrote: > > > ATA (libata) CS5536 driver is having issues with spurious IRQs and often > > disables IRQs completely during the boot. You should see a warning > > in dm

Re: [RFC] On the Current Troubles of Mainlining Loongson Platform Drivers

2019-02-11 Thread Aaro Koskinen
Hi, On Mon, Feb 11, 2019 at 08:38:00PM -0200, Alexandre Oliva wrote: > On Feb 11, 2019, Tom Li wrote: > >> and, more recently, a very slow system overall, that's been present since > >> 4.20. > > > The mainline framebuffer driver doesn't have any hardware drawing, printing > > even a single

Re: [PATCH 0/1] mips: loongson64: move EC header to include/asm/mach-loongson64

2019-02-10 Thread Aaro Koskinen
Hi, On Sun, Feb 10, 2019 at 09:06:16PM +0800, Yifeng Li wrote: > In order to operate the Embedded Controller from multiple platform > drivers, it should be possible to include lemote-2f/ec_kb3310b.h > from everywhere. This commits move it from lemote-2f/ec_kb3310b.h > to

[PATCH v2] panic/reboot: allow specifying reboot_mode for panic only

2019-02-08 Thread Aaro Koskinen
From: Aaro Koskinen Allow specifying reboot_mode for panic only. This is needed on systems where ramoops is used to store panic logs, and user wants to use warm reset to preserve those, while still having cold reset on normal reboots. Signed-off-by: Aaro Koskinen --- v2: Use

[PATCH] panic/reboot: allow specifying reboot_mode for panic only

2019-02-07 Thread Aaro Koskinen
From: Aaro Koskinen Allow specifying reboot_mode for panic only. This is needed on systems where ramoops is used to store panic logs, and user wants to use warm reset to preserve those, while still having cold reset on normal reboots. Signed-off-by: Aaro Koskinen --- .../admin-guide/kernel

Re: [PATCH] irqchip/i8259: fix shutdown order by moving syscore_ops registration

2019-02-07 Thread Aaro Koskinen
Hi, On Thu, Feb 07, 2019 at 08:56:37AM +, Marc Zyngier wrote: > On 06/02/2019 21:26, Aaro Koskinen wrote: > > static void init_8259A(int auto_eoi) > > { > > unsigned long flags; > > @@ -332,6 +324,7 @@ struct irq_domain * __init __init_i8259_irqs(st

[PATCH] irqchip/i8259: fix shutdown order by moving syscore_ops registration

2019-02-06 Thread Aaro Koskinen
as we have all interrupts masked already. irq-i8259 is registering syscore_ops using device_initcall(), while cpufreq uses core_initcall(). Fix the shutdown order simply by registering the irq syscore_ops during the early IRQ init instead of using a separate initcall at later stage. Signed-of

Re: [REGRESSION 4.20-rc1] 45975c7d21a1 ("rcu: Define RCU-sched API in terms of RCU for Tree RCU PREEMPT builds")

2019-02-05 Thread Aaro Koskinen
Hi, On Tue, Feb 05, 2019 at 09:05:59PM +0800, Tom Li wrote: > On Tue, Feb 05, 2019 at 11:58:09AM +0200, Aaro Koskinen wrote: > > Can you try below fix? It works on my Loongson. > > Hello Aaro, thanks for your response. But in case you've missed > the original th

Re: [REGRESSION 4.20-rc1] 45975c7d21a1 ("rcu: Define RCU-sched API in terms of RCU for Tree RCU PREEMPT builds")

2019-02-05 Thread Aaro Koskinen
; [ 23.668000] PM: Calling i8259A_shutdown+0x0/0xa8 > [ 23.672000] PM: Calling irq_gc_shutdown+0x0/0x88 > [ 23.672000] PM: Calling cpufreq_suspend+0x0/0x1a0 > [ 23.672000] cpufreq_suspend() > [ 23.672000] cpufreq_suspend: Suspending Governors > [ 23.672000] cpufreq_stop_

[PATCH] MMC: OMAP: fix the maximum timeout setting

2019-02-02 Thread Aaro Koskinen
, OMAP310), and also checked on real hardware using Palm TE (OMAP310), Nokia 770 (OMAP1710) and Nokia N810 (OMAP2420) that MMC works as before. [1] http://www.ti.com/lit/ug/spru680/spru680.pdf Fixes: 730c9b7e6630f ("[MMC] Add OMAP MMC host driver") Signed-off-by: Aaro Koskinen --- dri

[PATCH] staging: octeon: fix broken phylib usage

2019-01-27 Thread Aaro Koskinen
ng") Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c index 2848fa71a33d..d6248eecf123 100644 --- a/drivers/staging/octeon/e

Re: [RFC v7 0/5] pstore/block: new support logger for block devices

2019-01-23 Thread Aaro Koskinen
Hi, On Wed, Jan 23, 2019 at 08:05:11PM +0800, liaoweixiong wrote: > Why should we need pstore_block? > 1. Most embedded intelligent equipment have no persistent ram, which > increases costs. We perfer to cheaper solutions, like block devices. > In fast, there is already a sample for block device

Re: [RFC v5 1/4] pstore/blk: new support logger for block devices

2019-01-23 Thread Aaro Koskinen
Hi, On Sat, Jan 19, 2019 at 04:53:48PM +0800, liaoweixiong wrote: > On 2019-01-18 08:12, Kees Cook wrote: > >> MTD (drivers/mtd/mtdoops.c). > > > > Would mtdoops get dropped in favor of pstore/blk, or do they not share > > features? > > We can show them what pstore/blk do. I think they will be

Re: [PATCH 1/5] mips: cavium: no need to check return value of debugfs_create functions

2019-01-22 Thread Aaro Koskinen
Hi, On Tue, Jan 22, 2019 at 03:57:38PM +0100, Greg Kroah-Hartman wrote: > -static int init_debufs(void) > +static void init_debugfs(void) > { > - struct dentry *show_dentry; > dir = debugfs_create_dir("oct_ilm", 0); > - if (!dir) { > - pr_err("oct_ilm: failed to create

Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

2019-01-21 Thread Aaro Koskinen
Hi, On Mon, Jan 21, 2019 at 09:11:01AM -0800, Tony Lindgren wrote: > * Arthur Demchenkov [190121 03:22]: > > Wrong polarity of card detect GPIO pin leads to the system not > > booting from external mmc, if the back cover of N900 is closed. > > When the cover is open the system boots fine. > > >

Re: [PATCH] KEYS: user: Align the payload buffer

2019-01-15 Thread Aaro Koskinen
platforms would require more than 'long' alignment. > > Reported-by: Aaro Koskinen > Fixes: 2aa349f6e37c ("[PATCH] Keys: Export user-defined keyring operations") > Fixes: 88bd6ccdcdd6 ("ext4 crypto: add encryption key management facilities") > Cc: sta...@vger.kernel.org

Re: Bug report: unaligned access with ext4 encryption

2019-01-10 Thread Aaro Koskinen
Hi, On Thu, Jan 10, 2019 at 03:01:14PM -0800, Eric Biggers wrote: > On Fri, Jan 11, 2019 at 12:29:28AM +0200, Aaro Koskinen wrote: > > Hi, > > > > On Fri, Jan 04, 2019 at 05:28:02PM +, David Howells wrote: > > > Eric Biggers wrote: > > > > Hi Aaro,

Re: Bug report: unaligned access with ext4 encryption

2019-01-10 Thread Aaro Koskinen
Hi, On Fri, Jan 04, 2019 at 05:28:02PM +, David Howells wrote: > Eric Biggers wrote: > > Hi Aaro, thanks for the bug report! I think you're on the right track; it > > makes > > much more sense to have the keyrings subsystem store the payload with better > > alignment, than to work around

Bug report: unaligned access with ext4 encryption

2018-12-30 Thread Aaro Koskinen
Hi, When using ext4 encryption on SPARC, there's plenty of dmesg noise about unaligned access: [ 167.269526] Kernel unaligned access at TPC[5497a0] find_and_lock_process_key+0x80/0x120 [ 167.270152] Kernel unaligned access at TPC[5497a0] find_and_lock_process_key+0x80/0x120 [ 181.087451]

[PATCH] ARM: OMAP: DTS: N950/N9: fix onenand timings

2018-12-23 Thread Aaro Koskinen
ng on both Nokia N950 and N9. Fixes: a758f50f10cf ("mtd: onenand: omap2: Configure driver from DT") Signed-off-by: Aaro Koskinen --- arch/arm/boot/dts/omap3-n950-n9.dtsi | 42 ++-- 1 file changed, 28 insertions(+), 14 deletions(-) diff --git a/arch/arm/boot/dts/o

Re: Fixing MIPS delay slot emulation weakness?

2018-12-17 Thread Aaro Koskinen
Hi, On Mon, Dec 17, 2018 at 01:55:28AM +, Maciej W. Rozycki wrote: > As to actual implementations I believe all the Cavium Octeon line CPUs > (David, please correct me if I am wrong) have no FPU and they have vendor > extensions beyond the base ISA + ASE instruction set. Arguably you

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-12-17 Thread Aaro Koskinen
Hi, On Sun, Nov 25, 2018 at 09:14:28AM -0800, Tony Lindgren wrote: > * Aaro Koskinen [181125 16:58]: > > Below changes get traffic going with DMA & g_ether... > > Oh cool, if you have dma and g_ether working, you should > test it with a variable size ping test loop :) Th

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-12-17 Thread Aaro Koskinen
On Thu, Nov 22, 2018 at 03:12:36PM +, Russell King - ARM Linux wrote: > Also we can't deal with the omap_set_dma_dest_burst_mode() setting - > DMAengine always uses a 64 byte burst, but udc wants a smaller burst > setting. Does this matter? Looking at OMAP1 docs, it seems it supports only 16

[PATCH] staging: octeon-ethernet: delete redundant include

2018-12-05 Thread Aaro Koskinen
cvmx-smix-defs.h is not needed by this driver. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 1 - drivers/staging/octeon/ethernet.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet

[PATCH] staging: octeon-ethernet: delete redundant include

2018-12-05 Thread Aaro Koskinen
cvmx-smix-defs.h is not needed by this driver. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 1 - drivers/staging/octeon/ethernet.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet

[PATCH] staging: octeon-usb: use a helper function to set the DMA mask

2018-12-04 Thread Aaro Koskinen
Use a helper function to set the DMA mask. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 9c766f5b812f

[PATCH] staging: octeon-usb: use a helper function to set the DMA mask

2018-12-04 Thread Aaro Koskinen
Use a helper function to set the DMA mask. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index 9c766f5b812f

[PATCH] ARM: OMAP1: add MMC configuration for Palm Tungsten E

2018-12-04 Thread Aaro Koskinen
Add initial MMC configuration for Palm Tungsten E to allow using a proper rootfs on the device. This still assumes the bootloader enabling the MMC, and that the card is always present and writeable. Signed-off-by: Aaro Koskinen --- arch/arm/mach-omap1/board-palmte.c | 29

[PATCH] ARM: OMAP1: add MMC configuration for Palm Tungsten E

2018-12-04 Thread Aaro Koskinen
Add initial MMC configuration for Palm Tungsten E to allow using a proper rootfs on the device. This still assumes the bootloader enabling the MMC, and that the card is always present and writeable. Signed-off-by: Aaro Koskinen --- arch/arm/mach-omap1/board-palmte.c | 29

[PATCH] ARM: OMAP1: fix USB configuration for device-only setups

2018-12-04 Thread Aaro Koskinen
Currently we do USB configuration only if the host mode (CONFIG_USB) is enabled. But it should be done also in the case of device-only setups, so change the condition to CONFIG_USB_SUPPORT. This allows to use omap_udc on Palm Tungsten E. Signed-off-by: Aaro Koskinen --- arch/arm/mach-omap1

[PATCH] ARM: OMAP1: fix USB configuration for device-only setups

2018-12-04 Thread Aaro Koskinen
Currently we do USB configuration only if the host mode (CONFIG_USB) is enabled. But it should be done also in the case of device-only setups, so change the condition to CONFIG_USB_SUPPORT. This allows to use omap_udc on Palm Tungsten E. Signed-off-by: Aaro Koskinen --- arch/arm/mach-omap1

Re: Fwd: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Aaro Koskinen
On Fri, Nov 30, 2018 at 11:48:24AM -0800, Kees Cook wrote: > Better yet, since it's only 17 files, how about doing context-specific > changes? "This API is terrible" I think we should only use "good" with selected operators like !, ++, -- E.g. "This API is !good++" Suggested-by: George Orwell

Re: Fwd: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-11-30 Thread Aaro Koskinen
On Fri, Nov 30, 2018 at 11:48:24AM -0800, Kees Cook wrote: > Better yet, since it's only 17 files, how about doing context-specific > changes? "This API is terrible" I think we should only use "good" with selected operators like !, ++, -- E.g. "This API is !good++" Suggested-by: George Orwell

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Aaro Koskinen
Hi, On Sun, Nov 25, 2018 at 11:11:05AM +, Russell King - ARM Linux wrote: > I think we're better off leaving omap-udc well alone, and if it's > now broken with DMA, then that's unfortunate - it would require > someone with the hardware to diagnose the problem and fix it. I > think trying to

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-25 Thread Aaro Koskinen
Hi, On Sun, Nov 25, 2018 at 11:11:05AM +, Russell King - ARM Linux wrote: > I think we're better off leaving omap-udc well alone, and if it's > now broken with DMA, then that's unfortunate - it would require > someone with the hardware to diagnose the problem and fix it. I > think trying to

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Aaro Koskinen
Hello, On Sat, Nov 24, 2018 at 05:48:23PM +, Russell King - ARM Linux wrote: > Hmm, there's more questionable stuff in this driver, and the gadget > layer. [...] > So, whatever way I look at this, the code in the removal path both > in omap_udc and the gadget removal code higher up looks

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Aaro Koskinen
Hello, On Sat, Nov 24, 2018 at 05:48:23PM +, Russell King - ARM Linux wrote: > Hmm, there's more questionable stuff in this driver, and the gadget > layer. [...] > So, whatever way I look at this, the code in the removal path both > in omap_udc and the gadget removal code higher up looks

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Aaro Koskinen
Hi, On Fri, Nov 23, 2018 at 01:45:46PM +0200, Peter Ujfalusi wrote: > On 23/11/2018 0.01, Aaro Koskinen wrote: > > With that reverted, the DMA works OK (and I can also now confirm that > > OMAP_DMA_LCH_2D works). I haven't yet checked if we actually need that > &

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Aaro Koskinen
Hi, On Fri, Nov 23, 2018 at 01:45:46PM +0200, Peter Ujfalusi wrote: > On 23/11/2018 0.01, Aaro Koskinen wrote: > > With that reverted, the DMA works OK (and I can also now confirm that > > OMAP_DMA_LCH_2D works). I haven't yet checked if we actually need that > &

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Aaro Koskinen
Hi, On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > On 22/11/2018 17.12, Russell King - ARM Linux wrote: > > I'm also not sure about this: > > > > if (cpu_is_omap15xx()) > > end++; > > > > in dma_dest_len() - is that missing from the omap-dma driver?

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-23 Thread Aaro Koskinen
Hi, On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > On 22/11/2018 17.12, Russell King - ARM Linux wrote: > > I'm also not sure about this: > > > > if (cpu_is_omap15xx()) > > end++; > > > > in dma_dest_len() - is that missing from the omap-dma driver?

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Aaro Koskinen
Hi, On Fri, Nov 23, 2018 at 12:25:49AM +, Russell King - ARM Linux wrote: > The patch was more for Peter to take a peek at OK, I'll hack with other platforms meanwhile. A.

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Aaro Koskinen
Hi, On Fri, Nov 23, 2018 at 12:25:49AM +, Russell King - ARM Linux wrote: > The patch was more for Peter to take a peek at OK, I'll hack with other platforms meanwhile. A.

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Aaro Koskinen
Hi, On Thu, Nov 22, 2018 at 03:12:36PM +, Russell King - ARM Linux wrote: > On Thu, Nov 22, 2018 at 10:29:48AM +, Russell King - ARM Linux wrote: > > On Tue, Nov 20, 2018 at 11:04:06PM +0200, Aaro Koskinen wrote: > > > I had switched to PIO mode in 2015 since the WARN

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Aaro Koskinen
Hi, On Thu, Nov 22, 2018 at 03:12:36PM +, Russell King - ARM Linux wrote: > On Thu, Nov 22, 2018 at 10:29:48AM +, Russell King - ARM Linux wrote: > > On Tue, Nov 20, 2018 at 11:04:06PM +0200, Aaro Koskinen wrote: > > > I had switched to PIO mode in 2015 since the WARN

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-22 Thread Aaro Koskinen
Hi, On Thu, Nov 22, 2018 at 10:31:31AM +0200, Peter Ujfalusi wrote: > On 20/11/2018 23.04, Aaro Koskinen wrote: > > On Tue, Nov 20, 2018 at 09:28:37AM +0200, Peter Ujfalusi wrote: > >> On 19/11/2018 20.46, Aaro Koskinen wrote: > >>> On Mon, Nov 19, 2018 at 12:40:40

  1   2   3   4   5   6   7   8   9   10   >