Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-11-28 Thread Abel Wu
On 11/27/23 9:56 PM, Tobias Huschle Wrote: On Wed, Nov 22, 2023 at 11:00:16AM +0100, Peter Zijlstra wrote: On Tue, Nov 21, 2023 at 02:17:21PM +0100, Tobias Huschle wrote: The below should also work for internal entities, but last time I poked around with it I had some regressions elsewhere -- y

Re: Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-11-20 Thread Abel Wu
On 11/20/23 6:56 PM, Peter Zijlstra Wrote: On Sat, Nov 18, 2023 at 01:14:32PM +0800, Abel Wu wrote: Hi Peter, I'm a little confused here. As we adopt placement strategy #1 when PLACE_LAG is enabled, the lag of that entity needs to be preserved. Given that the weight doesn't chang

Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-11-17 Thread Abel Wu
On 11/17/23 2:58 AM, Tobias Huschle Wrote: TRACE EXCERPT The sched_place trace event was added to the end of the place_entity function and outputs: sev -> sched_entity vruntime sed -> sched_entity deadline sel -> sched_entity vlag avg -> cfs_rq avg_vrunt

Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-11-17 Thread Abel Wu
On 11/17/23 5:23 PM, Peter Zijlstra Wrote: Your email is pretty badly mangled by wrapping, please try and reconfigure your MUA, esp. the trace and debug output is unreadable. On Thu, Nov 16, 2023 at 07:58:18PM +0100, Tobias Huschle wrote: The base scenario are two KVM guests running on an s39

Re: Re: EEVDF/vhost regression (bisected to 86bfbb7ce4f6 sched/fair: Add lag based placement)

2023-11-17 Thread Abel Wu
this patch that we have in tip/sched/urgent. And please also apply this fix: https://lore.kernel.org/all/20231117080106.12890-1-s921975...@gmail.com/ I'll try and read the rest of the email a little later, gotta run errands first. --- commit eab03c23c2a162085b13200d7942fc5a00b5ccc8 A

Re: [PATCH] mm/slub: embed __slab_alloc to its caller

2021-02-02 Thread Abel Wu
> On Feb 2, 2021, at 6:11 PM, Christoph Lameter wrote: > > On Tue, 2 Feb 2021, Abel Wu wrote: > >> Since slab_alloc_node() is the only caller of __slab_alloc(), embed >> __slab_alloc() to its caller to save function call overhead. This >> will also expand the calle

[PATCH] mm/slub: embed __slab_alloc to its caller

2021-02-02 Thread Abel Wu
lso rename ___slab_alloc() to __slab_alloc(). Signed-off-by: Abel Wu --- mm/slub.c | 46 -- 1 file changed, 16 insertions(+), 30 deletions(-) diff --git a/mm/slub.c b/mm/slub.c index 7ecbbbe5bc0c..0f69d2d0471a 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2654,

Re: [PATCH] PM: hibernate: add sanity check on power_kobj

2021-02-01 Thread Abel Wu
> On Feb 1, 2021, at 6:52 PM, Pavel Machek wrote: > > On Mon 2021-02-01 02:50:41, Abel Wu wrote: >> The @power_kobj is initialized in pm_init() which is the same >> initcall level as pm_disk_init(). Although this dependency is >> guaranteed based on the current init

[PATCH] PM: hibernate: add sanity check on power_kobj

2021-01-31 Thread Abel Wu
-by: Abel Wu --- kernel/power/hibernate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c index da0b41914177..060089cc261d 100644 --- a/kernel/power/hibernate.c +++ b/kernel/power/hibernate.c @@ -1262,6 +1262,9 @@ static const struct

Re: [PATCH] mm/slub: make add_full() condition more explicit

2020-08-19 Thread Abel Wu
On 2020/8/20 3:37, Andrew Morton wrote: > On Tue, 11 Aug 2020 10:02:36 +0800 wrote: > >> From: Abel Wu >> >> The commit below is incomplete, as it didn't handle the add_full() part. >> commit a4d3f8916c65 ("slub: remove useless kmem_cache_debug() bef

Re: [PATCH] mm/slub: sysfs cleanup on cpu partial when !SLUB_CPU_PARTIAL

2020-08-19 Thread Abel Wu
On 2020/8/19 11:26, Andrew Morton wrote: > On Thu, 13 Aug 2020 16:48:54 +0800 wrote: > >> Hide cpu partial related sysfs entries when !CONFIG_SLUB_CPU_PARTIAL to >> avoid confusion. >> > > But it changes the userspace interface in ways which might cause > existing code to misbehave? Yes, inde

Re: [PATCH] mm/slub: make add_full() condition more explicit

2020-08-17 Thread Abel Wu
ping :) On 2020/8/11 10:02, wuyun...@huawei.com wrote: > From: Abel Wu > > The commit below is incomplete, as it didn't handle the add_full() part. > commit a4d3f8916c65 ("slub: remove useless kmem_cache_debug() before > remove_full()") > > This patch c

Re: [PATCH] mm/slub: remove useless kmem_cache_debug

2020-08-10 Thread Abel Wu
On 2020/8/11 9:29, Abel Wu wrote: > > > On 2020/8/11 3:44, David Rientjes wrote: >> On Mon, 10 Aug 2020, wuyun...@huawei.com wrote: >> >>> From: Abel Wu >>> >>> The commit below is incomplete, as it didn't handle the add_full()

Re: [PATCH] mm/slub: remove useless kmem_cache_debug

2020-08-10 Thread Abel Wu
On 2020/8/11 3:44, David Rientjes wrote: > On Mon, 10 Aug 2020, wuyun...@huawei.com wrote: > >> From: Abel Wu >> >> The commit below is incomplete, as it didn't handle the add_full() part. >> commit a4d3f8916c65 ("slub: remove useless kmem_cache_debug()