[PATCH] net: called rtnl_unlock() before runpm resumes devices

From: "Chia-Lin Kao (AceLan)" The rtnl_lock() has been called in rtnetlink_rcv_msg(), and then in __dev_open() it calls pm_runtime_resume() to resume devices, and in some devices' resume function(igb_resum,igc_resume) they calls rtnl_lock() again. That leads to a recursive lock. It should leave

[PATCH] Input: i8042 - add dmi quirk

From: "Chia-Lin Kao (AceLan)" On some platforms, the EC doesn't support the register reading sequence for sentelic[1], and then make the EC can't respond commands for a while when probing. It leads to the keyboard non-responsive for around 10 seconds while waking up from s2idle. [ 44.304488]

Re: [PATCH v6 4/6] mfd: ahc1ec0: Add support for Advantech embedded controller

Campion Kang 於 2021年1月18日 週一 下午8:37寫道： > > AHC1EC0 is the embedded controller driver for Advantech industrial > products. This provides sub-devices such as hwmon and watchdog, and also > expose functions for sub-devices to read/write the value to embedded > controller. > > Changed since V5: >

Re: [PATCH v6 5/6] hwmon: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller

Campion Kang 於 2021年1月18日 週一 下午8:37寫道： > > This is one of sub-device driver for Advantech embedded controller > AHC1EC0. This driver provides sysfs ABI for Advantech related > applications to monitor the system status. > > Changed since V5: > - remove unnecessary header files > -

Re: [PATCH v6 6/6] watchdog: ahc1ec0-wdt: Add sub-device watchdog for Advantech embedded controller

Campion Kang 於 2021年1月18日 週一 下午8:39寫道： > > This is one of sub-device driver for Advantech embedded controller > AHC1EC0. This driver provide watchdog functionality for Advantech > related applications to restart the system. > > Changed since V5: > - remove unnecessary header files >

Re: [PATCH v3 5/6] mfd: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller

Hi Lee, One question for you. Lee Jones 於 2020年10月29日 週四 下午9:14寫道： > > On Thu, 29 Oct 2020, Shihlun Lin wrote: > > > This is one of sub-device driver for Advantech embedded controller > > AHC1EC0. This driver provides sysfs ABI for Advantech related > > applications to monitor the system

Re: [PATCH] iio: dac: ad5593r: Dynamically set AD5593R channel modes

if configfs will make the driver probe again when new table is loaded If we can't use configfs, is there any other way we could try? Thanks. Andy Shevchenko 於 2020年9月3日 週四 下午6:54寫道： > > On Thu, Sep 3, 2020 at 1:42 PM Andy Shevchenko > wrote: > > On Thu, Sep 3, 2020 at 10:37 AM Ac

Re: [PATCH] iio: dac: ad5593r: Dynamically set AD5593R channel modes

nko 於 2020年8月31日 週一 下午8:48寫道： > > On Mon, Aug 31, 2020 at 3:45 PM Andy Shevchenko > wrote: > > On Mon, Aug 31, 2020 at 2:28 PM AceLan Kao wrote: > > > This patch is mainly for Advantech's UNO-420[1] which is a x86-based > > > platform. > > > This

Re: [PATCH] iio: dac: ad5593r: Dynamically set AD5593R channel modes

Hi Jonathan and Andy, This patch is mainly for Advantech's UNO-420[1] which is a x86-based platform. This platform is more like a development platform for customers to customize their products, so, specify the channel modes in ACPI table is not generic enough, that's why William submit this

Re: [PATCH] iio: dac: ad5593r: Dynamically set AD5593R channel modes

Hi William, Please read my comment below. William Sung 於 2020年8月24日 週一 下午1:43寫道： > > To use ad5593r more flexibly, we use the module parameter to setting the > channel modes dynamically whenever the module probe up. Users can pass > the channel modes to the module parameter for allocating the >

[PATCH] USB: serial: option: add Quectel EG95 LTE modem

) I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) Signed-off-by: AceLan Kao --- drivers/usb/serial/option.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index 254a8bbeea67..a12ad91a7e0b 100644 --- a/drivers

[PATCH] net: usb: qmi_wwan: add support for Quectel EG95 LTE modem

) I: If#=0x4 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) Signed-off-by: AceLan Kao --- drivers/net/usb/qmi_wwan.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c index 31b1d4b959f6..07c42c0719f5 100644 --- a/drivers/net/usb

Re: [PATCH v2] mfd: intel-lpss: use devm_ioremap_uc for MMIO

Confirmed the patch works well on Dell XPS 7390 2-in-1 machine. Tested-by: AceLan Kao Tuowen Zhao 於 2019年10月8日 週二 上午2:43寫道： > > Some BIOS erroneously specifies write-combining BAR for intel-lpss-pci > in MTRR. This will cause the system to hang during boot. If possible, > th

Re: [PATCH] r8169: add enable_aspm parameter

Hi Heiner, I've tried and verified your PCI ASPM patches and it works well. I've replied the patch thread and hope this can make it get some progress. BTW, do you think we can revert commit b75bb8a5b755 ("r8169: disable ASPM again") once the PCI ASPM patches get merged? Best regards,

Re: [PATCH] r8169: add enable_aspm parameter

Heiner Kallweit 於 2019年7月9日 週二 上午2:27寫道： > > On 08.07.2019 08:37, AceLan Kao wrote: > > We have many commits in the driver which enable and then disable ASPM > > function over and over again. > >commit b75bb8a5b755 ("r8169: disable ASPM again") > >

[PATCH] r8169: add enable_aspm parameter

and if we can't come out a solution to make both happy, I'd suggest we add a parameter in the driver to toggle it. Signed-off-by: AceLan Kao --- drivers/net/ethernet/realtek/r8169.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169

Re: [PATCH] i2c: designware: Add disable runtime pm quirk

proposed solution from my colleague is generic and apply to all platforms which loads intel-lpss-pci driver, it may lead to unexpected regressions which we don't see now. Please give some suggestions, thanks. Best regards, AceLan Kao. Jarkko Nikula 於 2019年6月26日 週三 下午2:27寫道： > > On 6/26/19 5

Re: [PATCH] i2c: designware: Add disable runtime pm quirk

n 6/25/19 11:30 AM, AceLan Kao wrote: > > Dell machines come with goodix touchpad IC suffer from the double click > > issue if the Designware I2C adapter enters runtime suspend. > > > > It's because the goodix re-assert the interrupt if host doesn't read the > > da

[PATCH] i2c: designware: Add disable runtime pm quirk

a quirk to mark those machines and avoid the designware from entering runtime suspend. Link: https://bugzilla.kernel.org/show_bug.cgi?id=202683 Signed-off-by: AceLan Kao --- drivers/i2c/busses/i2c-designware-master.c | 30 -- 1 file changed, 28 insertions(+), 2 deletions

Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3

Christoph Hellwig 於 2018年11月6日 週二 下午3:10寫道： > > On Tue, Nov 06, 2018 at 10:04:01AM +0800, AceLan Kao wrote: > > It leads to the power consumption raises to 2.2W during s2idle, while > > it consumes less than 1W during long idle if put SK hynix nvme to D3 > > and then en

Re: [PATCH 1/2] pci: prevent sk hynix nvme from entering D3

Christoph Hellwig 於 2018年11月6日 週二 下午3:10寫道： > > On Tue, Nov 06, 2018 at 10:04:01AM +0800, AceLan Kao wrote: > > It leads to the power consumption raises to 2.2W during s2idle, while > > it consumes less than 1W during long idle if put SK hynix nvme to D3 > > and then en

[PATCH v2 2/2] nvme: add quirk to not call disable function when suspending

, the power consumption drops to 0.77 Watt during s2idle. V2: - replace PCI_DEVICE with PCI_VDEVICE - replace 0x1c5c with SK_HYNIX Signed-off-by: AceLan Kao --- drivers/nvme/host/nvme.h | 5 + drivers/nvme/host/pci.c | 8 +++- 2 files changed, 12 insertions(+), 1 deletion

[PATCH v2 2/2] nvme: add quirk to not call disable function when suspending

, the power consumption drops to 0.77 Watt during s2idle. V2: - replace PCI_DEVICE with PCI_VDEVICE - replace 0x1c5c with SK_HYNIX Signed-off-by: AceLan Kao --- drivers/nvme/host/nvme.h | 5 + drivers/nvme/host/pci.c | 8 +++- 2 files changed, 12 insertions(+), 1 deletion

[PATCH v2 1/2] pci: prevent sk hynix nvme from entering D3

PST feature during s2idle, we can't disable nvme device while suspending, too. BTW, prevent it from entering D3 will increase the power consumtion around 0.13W ~ 0.15W during short/long idle, and the power consumption during s2idle becomes 0.77W. Signed-off-by: AceLan Kao --- drivers/pci/quirk

[PATCH v2 1/2] pci: prevent sk hynix nvme from entering D3

PST feature during s2idle, we can't disable nvme device while suspending, too. BTW, prevent it from entering D3 will increase the power consumtion around 0.13W ~ 0.15W during short/long idle, and the power consumption during s2idle becomes 0.77W. Signed-off-by: AceLan Kao --- drivers/pci/quirk

Re: [PATCH 2/2] nvme: add quirk to not call disable function when suspending

Right, should replace it with SK_HYNIX. I'll prepare v2 patch for that. Sinan Kaya 於 2018年11月6日 週二 上午10:24寫道： > > On 11/5/2018 6:04 PM, AceLan Kao wrote: > > + { PCI_DEVICE(0x1c5c, 0x1527), /* Sk Hynix */ > > + .driver_data = NVME_QUIRK_NO_DISABLE, }, >

Re: [PATCH 2/2] nvme: add quirk to not call disable function when suspending

Right, should replace it with SK_HYNIX. I'll prepare v2 patch for that. Sinan Kaya 於 2018年11月6日 週二 上午10:24寫道： > > On 11/5/2018 6:04 PM, AceLan Kao wrote: > > + { PCI_DEVICE(0x1c5c, 0x1527), /* Sk Hynix */ > > + .driver_data = NVME_QUIRK_NO_DISABLE, }, >

[PATCH 1/2] pci: prevent sk hynix nvme from entering D3

PST feature during s2idle, we can't disable nvme device while suspending, too. BTW, prevent it from entering D3 will increase the power consumtion around 0.13W ~ 0.15W during short/long idle, and the power consumption during s2idle becomes 0.77W. Signed-off-by: AceLan Kao --- drivers/pci/quirk

[PATCH 2/2] nvme: add quirk to not call disable function when suspending

, the power consumption drops to 0.77 Watt during s2idle. Signed-off-by: AceLan Kao --- drivers/nvme/host/nvme.h | 5 + drivers/nvme/host/pci.c | 8 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index cee79cb388af

[PATCH 1/2] pci: prevent sk hynix nvme from entering D3

PST feature during s2idle, we can't disable nvme device while suspending, too. BTW, prevent it from entering D3 will increase the power consumtion around 0.13W ~ 0.15W during short/long idle, and the power consumption during s2idle becomes 0.77W. Signed-off-by: AceLan Kao --- drivers/pci/quirk

[PATCH 2/2] nvme: add quirk to not call disable function when suspending

, the power consumption drops to 0.77 Watt during s2idle. Signed-off-by: AceLan Kao --- drivers/nvme/host/nvme.h | 5 + drivers/nvme/host/pci.c | 8 +++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h index cee79cb388af

[PATCH] usb: core: disable USB2 LPM when suspending

e USB2 LPM in usb_suspend() fixes the issue mentioned above, and try 30 times of s2idle, S3 and S5, the USB devices keep working well. Disable USB2 LPM seems do no harm to the system. Signed-off-by: AceLan Kao --- drivers/usb/core/driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/d

[PATCH] usb: core: disable USB2 LPM when suspending

e USB2 LPM in usb_suspend() fixes the issue mentioned above, and try 30 times of s2idle, S3 and S5, the USB devices keep working well. Disable USB2 LPM seems do no harm to the system. Signed-off-by: AceLan Kao --- drivers/usb/core/driver.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/d

[PATCH] HID: i2c-hid: Fix flooded incomplete report after S3 on Rayd touchscreen

after resume. Cc: sta...@vger.kernel.org Signed-off-by: AceLan Kao --- drivers/hid/hid-ids.h | 1 + drivers/hid/i2c-hid/i2c-hid.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index c7981ddd8776..e80bcd71fe1e 100644 --- a/drivers/hid

[PATCH] HID: i2c-hid: Fix flooded incomplete report after S3 on Rayd touchscreen

after resume. Cc: sta...@vger.kernel.org Signed-off-by: AceLan Kao --- drivers/hid/hid-ids.h | 1 + drivers/hid/i2c-hid/i2c-hid.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h index c7981ddd8776..e80bcd71fe1e 100644 --- a/drivers/hid

Re: [PATCH] PCI: Fix calculation of bridge window's size

Hi Bjorn, Here is the public bug. https://bugzilla.kernel.org/show_bug.cgi?id=200769 Best regards, AceLan Kao. 2018-08-09 2:00 GMT+08:00 Bjorn Helgaas : > On Wed, Aug 08, 2018 at 01:48:37PM +0800, AceLan Kao wrote: >> There are some 0 resource size pci devices, and

Re: [PATCH] PCI: Fix calculation of bridge window's size

Hi Bjorn, Here is the public bug. https://bugzilla.kernel.org/show_bug.cgi?id=200769 Best regards, AceLan Kao. 2018-08-09 2:00 GMT+08:00 Bjorn Helgaas : > On Wed, Aug 08, 2018 at 01:48:37PM +0800, AceLan Kao wrote: >> There are some 0 resource size pci devices, and

[PATCH] PCI: Fix calculation of bridge window's size

:05:00.0 failed with error -16 To fix this, check if the resource size equals to 0, doesn't increase size. Fixes: c9c75143a596 ("PCI: Fix calculation of bridge window's size and alignment") CC: sta...@vger.kernel.org # 4.14+ Signed-off-by: AceLan Kao --- drivers/pci/setup-bus.c | 3 +

[PATCH] PCI: Fix calculation of bridge window's size

:05:00.0 failed with error -16 To fix this, check if the resource size equals to 0, doesn't increase size. Fixes: c9c75143a596 ("PCI: Fix calculation of bridge window's size and alignment") CC: sta...@vger.kernel.org # 4.14+ Signed-off-by: AceLan Kao --- drivers/pci/setup-bus.c | 3 +

Re: [PATCH v2] platform/x86: intel-vbtn: Add support for dock mode detection

Looks good to me Reviewed-By: AceLan Kao 2018-06-25 8:29 GMT+08:00 Matt Delco : > The Dell laptop I have has an ACPI that sends 0xCB and 0xCC on entering > tablet mode. On exiting tablet mode it sends 0xCA and 0xCD. Based on: > > http://www.traby.de/medion/DSDT/dsdt

Re: [PATCH v2] platform/x86: intel-vbtn: Add support for dock mode detection

Looks good to me Reviewed-By: AceLan Kao 2018-06-25 8:29 GMT+08:00 Matt Delco : > The Dell laptop I have has an ACPI that sends 0xCB and 0xCC on entering > tablet mode. On exiting tablet mode it sends 0xCA and 0xCD. Based on: > > http://www.traby.de/medion/DSDT/dsdt

Re: [PATCH] platform/x86: intel-vbtn: Ignore extraneous events from tablet mode

There is a v2 patch. Please ignore this one. 2018-06-22 4:37 GMT+08:00 Dmitry Torokhov : > On Thu, Jun 21, 2018 at 01:12:07PM -0700, Matt Delco wrote: >> The Dell laptop I have has an ACPI that sends 0xCB and 0xCC on entering >> tablet mode. On exiting tablet mode it sends 0xCA and 0xCD. This

Re: [PATCH] platform/x86: intel-vbtn: Ignore extraneous events from tablet mode

There is a v2 patch. Please ignore this one. 2018-06-22 4:37 GMT+08:00 Dmitry Torokhov : > On Thu, Jun 21, 2018 at 01:12:07PM -0700, Matt Delco wrote: >> The Dell laptop I have has an ACPI that sends 0xCB and 0xCC on entering >> tablet mode. On exiting tablet mode it sends 0xCA and 0xCD. This

Re: [PATCH v2] Revert "alx: remove WoL support"

ke up twice" bug, but with recent kernel version, I don't have this issue anymore. I can't tell which version actually fix the bug (I don't remember..). Best regards, AceLan Kao. 2018-05-21 11:18 GMT+08:00 David Miller <da...@davemloft.net>: > From: AceLan Kao <acelan@canonical.co

Re: [PATCH v2] Revert "alx: remove WoL support"

ke up twice" bug, but with recent kernel version, I don't have this issue anymore. I can't tell which version actually fix the bug (I don't remember..). Best regards, AceLan Kao. 2018-05-21 11:18 GMT+08:00 David Miller : > From: AceLan Kao > Date: Mon, 21 May 2018 11:14:00 +0800 > >&

Re: [PATCH v2] Revert "alx: remove WoL support"

on is more feasible for you? Thanks. Best regards, AceLan Kao. 2018-05-14 21:35 GMT+08:00 David Miller <da...@davemloft.net>: > From: AceLan Kao <acelan@canonical.com> > Date: Mon, 14 May 2018 11:28:39 +0800 > >> This reverts commit bc2bebe8de8ed4ba6482c9cc370b0dd72ffe

Re: [PATCH v2] Revert "alx: remove WoL support"

on is more feasible for you? Thanks. Best regards, AceLan Kao. 2018-05-14 21:35 GMT+08:00 David Miller : > From: AceLan Kao > Date: Mon, 14 May 2018 11:28:39 +0800 > >> This reverts commit bc2bebe8de8ed4ba6482c9cc370b0dd72ffe8cd2. >> >> The WoL feature is a must to pass En

[PATCH v2] Revert "alx: remove WoL support"

e when WoL is enabled. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61651 Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/net/ethernet/atheros/alx/ethtool.c | 36 + drivers/net/ethernet/atheros/alx/hw.c | 154 - drivers/net/ethernet/

[PATCH v2] Revert "alx: remove WoL support"

e when WoL is enabled. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61651 Signed-off-by: AceLan Kao --- drivers/net/ethernet/atheros/alx/ethtool.c | 36 + drivers/net/ethernet/atheros/alx/hw.c | 154 - drivers/net/ethernet/atheros/alx/hw.h | 5 + d

Re: [PATCH 2/2] alx: add disable_wol paramenter

Okay, I'll submit a new patch with some more description of why we need this feature. Thanks. 2018-05-10 20:34 GMT+08:00 Andrew Lunn <and...@lunn.ch>: > On Thu, May 10, 2018 at 01:58:24PM +0800, AceLan Kao wrote: >> Hi Andrew, >> >> We have some machines using Qu

Re: [PATCH 2/2] alx: add disable_wol paramenter

Okay, I'll submit a new patch with some more description of why we need this feature. Thanks. 2018-05-10 20:34 GMT+08:00 Andrew Lunn : > On Thu, May 10, 2018 at 01:58:24PM +0800, AceLan Kao wrote: >> Hi Andrew, >> >> We have some machines using Qualcomm Atheros Killer E240

Re: [PATCH 2/2] alx: add disable_wol paramenter

the feature has been removed for 5 years into account, I doubt if we still can reproduce this issue, but again, to verify this issue we need to add back this feature first. Set WoL disabled by default won't introduce any regression but give users and developers a chance to fix it. Best regards, AceLan Kao

Re: [PATCH 2/2] alx: add disable_wol paramenter

the feature has been removed for 5 years into account, I doubt if we still can reproduce this issue, but again, to verify this issue we need to add back this feature first. Set WoL disabled by default won't introduce any regression but give users and developers a chance to fix it. Best regards, AceLan Kao

Re: [PATCH 2/2] alx: add disable_wol paramenter

, AceLan Kao. 2018-04-24 11:45 GMT+08:00 AceLan Kao <acelan@canonical.com>: > Hi, > > May I know the final decision of this patch? > Thanks. > > Best regards, > AceLan Kao. > > 2018-04-10 10:40 GMT+08:00 AceLan Kao <acelan@canonical.com>: &

Re: [PATCH 2/2] alx: add disable_wol paramenter

, AceLan Kao. 2018-04-24 11:45 GMT+08:00 AceLan Kao : > Hi, > > May I know the final decision of this patch? > Thanks. > > Best regards, > AceLan Kao. > > 2018-04-10 10:40 GMT+08:00 AceLan Kao : >> The problem is I don't have a machine with that wakeup issue, and

Re: [PATCH 2/2] alx: add disable_wol paramenter

Hi, May I know the final decision of this patch? Thanks. Best regards, AceLan Kao. 2018-04-10 10:40 GMT+08:00 AceLan Kao <acelan@canonical.com>: > The problem is I don't have a machine with that wakeup issue, and I > need WoL feature. > Instead of spreading "alx wi

Re: [PATCH 2/2] alx: add disable_wol paramenter

Hi, May I know the final decision of this patch? Thanks. Best regards, AceLan Kao. 2018-04-10 10:40 GMT+08:00 AceLan Kao : > The problem is I don't have a machine with that wakeup issue, and I > need WoL feature. > Instead of spreading "alx with WoL" dkms package everywh

Re: [PATCH 2/2] alx: add disable_wol paramenter

GMT+08:00 David Miller <da...@davemloft.net>: > From: Andrew Lunn <and...@lunn.ch> > Date: Mon, 9 Apr 2018 14:39:10 +0200 > >> On Mon, Apr 09, 2018 at 07:35:14PM +0800, AceLan Kao wrote: >>> The WoL feature was reported broken and will lead to >>> the syste

Re: [PATCH 2/2] alx: add disable_wol paramenter

GMT+08:00 David Miller : > From: Andrew Lunn > Date: Mon, 9 Apr 2018 14:39:10 +0200 > >> On Mon, Apr 09, 2018 at 07:35:14PM +0800, AceLan Kao wrote: >>> The WoL feature was reported broken and will lead to >>> the system resume immediately after suspending. >>&g

[PATCH 2/2] alx: add disable_wol paramenter

?id=61651 Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/net/ethernet/atheros/alx/ethtool.c | 7 ++- drivers/net/ethernet/atheros/alx/main.c| 5 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/alx/ethtool.c b/drive

[PATCH 2/2] alx: add disable_wol paramenter

?id=61651 Signed-off-by: AceLan Kao --- drivers/net/ethernet/atheros/alx/ethtool.c | 7 ++- drivers/net/ethernet/atheros/alx/main.c| 5 + 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/atheros/alx/ethtool.c b/drivers/net/ethernet/atheros/alx

[PATCH 1/2] Revert "alx: remove WoL support"

This reverts commit bc2bebe8de8ed4ba6482c9cc370b0dd72ffe8cd2. There are still many people need this feature, so try adding it back. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61651 Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/net/ethernet/atheros/alx/eth

[PATCH 1/2] Revert "alx: remove WoL support"

This reverts commit bc2bebe8de8ed4ba6482c9cc370b0dd72ffe8cd2. There are still many people need this feature, so try adding it back. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=61651 Signed-off-by: AceLan Kao --- drivers/net/ethernet/atheros/alx/ethtool.c | 36 +++ drivers/net

[PATCH] ath9k: add a quirk to set use_msi automatically

Dell Vostro 15-3572 Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/net/wireless/ath/ath9k/init.c | 53 +++ 1 file changed, 53 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c

[PATCH] ath9k: add a quirk to set use_msi automatically

Dell Vostro 15-3572 Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 53 +++ 1 file changed, 53 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c index 43adead..e479fae 100644

[PATCH] Bluetooth: btusb: Add support for 0cf3:e010

=01 Prot=01 Driver=btusb I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index f

[PATCH] Bluetooth: btusb: Add support for 0cf3:e010

=01 Prot=01 Driver=btusb I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb Signed-off-by: AceLan Kao --- drivers/bluetooth/btusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index f7120c9..9136edb 100644 --- a/drivers

Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

Hi Alex, 2017-10-27 0:10 GMT+08:00 Alan Cox : > >> > +static int __init dell_uart_bl_init(void) >> > +{ >> > + ftty = filp_open("/dev/ttyS0", O_RDWR | O_NOCTTY | O_NDELAY, 0); >> > > You have no idea what name is assigned. This doesn't work. Yes, I did. The port is

Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

Hi Alex, 2017-10-27 0:10 GMT+08:00 Alan Cox : > >> > +static int __init dell_uart_bl_init(void) >> > +{ >> > + ftty = filp_open("/dev/ttyS0", O_RDWR | O_NOCTTY | O_NDELAY, 0); >> > > You have no idea what name is assigned. This doesn't work. Yes, I did. The port is defined in BIOS as PNP0501

Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

Hi Mario, 2017-10-26 23:54 GMT+08:00 <mario.limoncie...@dell.com>: >> -Original Message- >> From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- >> ow...@vger.kernel.org] On Behalf Of AceLan Kao >> Sent: Thursday, October 26, 2017 2

Re: [PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

Hi Mario, 2017-10-26 23:54 GMT+08:00 : >> -Original Message- >> From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- >> ow...@vger.kernel.org] On Behalf Of AceLan Kao >> Sent: Thursday, October 26, 2017 2:54 AM >> To: Darren Har

[PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

Name (_CID, EisaId ("PNP0501") The 8250 PNP driver will be loaded by default, and this driver uses "DELL0501" to confirm the uart port is a backlight interface and leverages the port created by 8250 PNP driver to communicate with the scalar board. Signed-off-by: AceLan

[PATCH] platform/x86: dell-uart-backlight: new backlight driver for DELL AIO

Name (_CID, EisaId ("PNP0501") The 8250 PNP driver will be loaded by default, and this driver uses "DELL0501" to confirm the uart port is a backlight interface and leverages the port created by 8250 PNP driver to communicate with the scalar board. Signed-off-by

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

Hi Daniel, After applied the 2 commits you mentioned in the email, ath9k works. https://marc.info/?l=linux-wireless=150631274108016=2 https://github.com/endlessm/linux/commit/739c7a924db8f4434a9617657 Best regards, AceLan Kao. 2017-10-05 14:39 GMT+08:00 AceLan Kao <acelan@canonical.

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

Hi Daniel, After applied the 2 commits you mentioned in the email, ath9k works. https://marc.info/?l=linux-wireless=150631274108016=2 https://github.com/endlessm/linux/commit/739c7a924db8f4434a9617657 Best regards, AceLan Kao. 2017-10-05 14:39 GMT+08:00 AceLan Kao : > Hi all, > > Pl

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

Hi all, Please drop my patches, Qualcomm is working internally and will submit the MSI patch by themselves. Thanks. Hi Daniel, I'll try your patches tomorrow. Best regards, AceLan Kao. 2017-10-02 12:21 GMT+08:00 Daniel Drake <dr...@endlessm.com>: > Hi AceLan, > > On Thu, Sep 2

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

Hi all, Please drop my patches, Qualcomm is working internally and will submit the MSI patch by themselves. Thanks. Hi Daniel, I'll try your patches tomorrow. Best regards, AceLan Kao. 2017-10-02 12:21 GMT+08:00 Daniel Drake : > Hi AceLan, > > On Thu, Sep 28, 2017 at 4:28 PM, A

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

Wireless Network Adapter [168c:0036] (rev 01) Subsystem: Dell QCA9565 / AR9565 Wireless Network Adapter [1028:020e] Kernel driver in use: ath9k Kernel modules: ath9k Do you have a chance to see if my patch works on your side? Best regards, AceLan Kao. 2017-09-26 22:14 GMT+08

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

Wireless Network Adapter [168c:0036] (rev 01) Subsystem: Dell QCA9565 / AR9565 Wireless Network Adapter [1028:020e] Kernel driver in use: ath9k Kernel modules: ath9k Do you have a chance to see if my patch works on your side? Best regards, AceLan Kao. 2017-09-26 22:14 GMT+08

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

org>: > On Tue, Sep 26, 2017 at 02:41:35PM +0800, AceLan Kao wrote: >> Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI >> for WLAN device. So adding a quirk to list those machines and set >> use_msi automatically. >> Adding Dell Inspiron 24-3460

Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically

017 at 02:41:35PM +0800, AceLan Kao wrote: >> Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI >> for WLAN device. So adding a quirk to list those machines and set >> use_msi automatically. >> Adding Dell Inspiron 24-3460 to the quirk. > > Huh?

[PATCH 5/6] ath9k: set use_msi=1 on Dell Vostro 15-3572

BIOS on Dell Vostro 15-3572 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/ini

[PATCH 6/6] ath9k: set use_msi=1 on Dell Inspiron 14-3473

BIOS on Dell Inspiron 14-3473 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/ini

[PATCH 5/6] ath9k: set use_msi=1 on Dell Vostro 15-3572

BIOS on Dell Vostro 15-3572 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath

[PATCH 6/6] ath9k: set use_msi=1 on Dell Inspiron 14-3473

BIOS on Dell Inspiron 14-3473 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath

[PATCH 4/6] ath9k: set use_msi=1 on Dell Inspiron 3472

BIOS on Dell Inspiron 3472 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/ini

[PATCH 4/6] ath9k: set use_msi=1 on Dell Inspiron 3472

BIOS on Dell Inspiron 3472 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath

[PATCH 3/6] ath9k: set use_msi=1 on Dell Vostro 3262

BIOS on Dell Vostro 3262 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/ini

[PATCH 1/6] ath9k: add MSI support and use_msi parameter

Adding MSI support for ath9k devices. This patch is originally from Qualcomm, but they have no intention of submitting and maintaining ath9k driver now. The credit should go to Qualcomm. Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/net/wireless/ath/ath9k/hw.c

[PATCH 2/6] ath9k: add a quirk to set use_msi automatically

Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI for WLAN device. So adding a quirk to list those machines and set use_msi automatically. Adding Dell Inspiron 24-3460 to the quirk. Signed-off-by: AceLan Kao <acelan@canonical.com> --- drivers/net/wireless/ath

[PATCH 1/6] ath9k: add MSI support and use_msi parameter

Adding MSI support for ath9k devices. This patch is originally from Qualcomm, but they have no intention of submitting and maintaining ath9k driver now. The credit should go to Qualcomm. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/hw.c | 33 ++-- drivers

[PATCH 2/6] ath9k: add a quirk to set use_msi automatically

Some platform(BIOS) blocks legacy interrupts (INTx), and only allows MSI for WLAN device. So adding a quirk to list those machines and set use_msi automatically. Adding Dell Inspiron 24-3460 to the quirk. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 21

[PATCH 3/6] ath9k: set use_msi=1 on Dell Vostro 3262

BIOS on Dell Vostro 3262 blocks legacy interrupts (INTx), and only allows MSI for WLAN device. Signed-off-by: AceLan Kao --- drivers/net/wireless/ath/ath9k/init.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k

Re: [PATCH] intel-vbtn: match power button on press rather than release

Looks like I'm one hour late to ack the patch. Thanks any way for the quick response. 2017-08-07 8:38 GMT+08:00 Rafael J. Wysocki : > On Mon, Aug 7, 2017 at 1:24 AM, Darren Hart wrote: >> On Sun, Aug 06, 2017 at 12:20:22AM +0200, Rafael Wysocki wrote: >>>

Re: [PATCH] intel-vbtn: match power button on press rather than release

Looks like I'm one hour late to ack the patch. Thanks any way for the quick response. 2017-08-07 8:38 GMT+08:00 Rafael J. Wysocki : > On Mon, Aug 7, 2017 at 1:24 AM, Darren Hart wrote: >> On Sun, Aug 06, 2017 at 12:20:22AM +0200, Rafael Wysocki wrote: >>> On Saturday, August 5, 2017 10:57:53 PM

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

events on the spec later. 2017-04-25 13:01 GMT+08:00 Maarten Maathuis <madman2...@gmail.com>: > On Tue, Apr 25, 2017 at 4:43 AM, AceLan Kao <acelan@canonical.com> wrote: >> According the spec. I have, the values are correct. >> Please merge it, thanks. >> >

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

events on the spec later. 2017-04-25 13:01 GMT+08:00 Maarten Maathuis : > On Tue, Apr 25, 2017 at 4:43 AM, AceLan Kao wrote: >> According the spec. I have, the values are correct. >> Please merge it, thanks. >> > > Is there a reason the whole spec isn't implemented? &

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

According the spec. I have, the values are correct. Please merge it, thanks. 2017-04-25 5:41 GMT+08:00 Maarten Maathuis : > On Mon, Apr 24, 2017 at 11:37 PM, Andy Shevchenko > wrote: >> On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

According the spec. I have, the values are correct. Please merge it, thanks. 2017-04-25 5:41 GMT+08:00 Maarten Maathuis : > On Mon, Apr 24, 2017 at 11:37 PM, Andy Shevchenko > wrote: >> On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis >> wrote: >>> Tested on HP Elite X2 1012 G1. >>> Matches

Re: [PATCH] ACPI: Override rev for DELL Latitude 3350

Hi Rafael, The patch you mentioned is pretty the same as mine, I'm happy to see that patch goes into upstream. Please keep doing this, thanks. Best regards, AceLan Kao. 2016-11-22 6:43 GMT+08:00 Rafael J. Wysocki <r...@rjwysocki.net>: > On Monday, November 21, 2016 10:07:05 AM AceLan

  1   2   >