Hello Steve,
On 02.02.24 02:46, Steven Rostedt wrote:
> On Thu, 1 Feb 2024 13:21:37 +0100
> Ahmad Fatoum wrote:
>> For this to be maximally useful, I need to configure this not only at
>> boot-time,
>> but also dump the ftrace buffer at boot time. Probe deferral can hi
Hello Masami-san,
On 02.02.24 07:04, Masami Hiramatsu (Google) wrote:
> On Thu, 1 Feb 2024 13:21:37 +0100
> Ahmad Fatoum wrote:
>> For drivers that don't call dev_err_probe, I find myself sometimes doing
>> printf
>> debugging inside the probe function.
[snip]
&g
Hello,
I semi-regularly debug probe failures. For drivers that use dev_err_probe
rigorously, this is a quick matter: The probe function records a deferral reason
and if the deferral persists, deferred_probe_timeout_work_func() will print
the collected reasons, even if PID 1 is never started.
For
Hi,
On 15.04.21 12:10, Alexandre Torgue wrote:
> Add vref_ddr-supply to the STPMIC1 regulators supplies pattern
> list.
>
> Signed-off-by: Alexandre Torgue
>
> diff --git a/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> b/Documentation/devicetree/bindings/mfd/st,stpmic1.yaml
> index
Hi,
On 15.04.21 12:10, Alexandre Torgue wrote:
> Running "make dtbs_check W=1", some warnings are reported concerning
> DSI. This patch reorder DSI nodes to avoid:
>
> soc/dsi@5a00: unnecessary #address-cells/#size-cells without
> "ranges" or child "reg" property
This reverts parts of
-by: Ahmad Fatoum
---
drivers/watchdog/Kconfig | 1 +-
drivers/watchdog/f71808e_wdt.c | 390 --
2 files changed, 53 insertions(+), 338 deletions(-)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 7ff941e71b79..cbce0c176a7e 100644
es anyway
- fixed checkpatch.pl nitpicks (Guenther)
- fixed locally used variable declared without static (0-day)
- fixed unneded line break due to old line limit (Guenther)
- renamed struct fintek_wdog_data to struct fintek_wdt
Ahmad Fatoum (3):
watchdog: f71808e_wdt: rename variant-in
.
Suggested-by: Guenter Roeck
Signed-off-by: Ahmad Fatoum
---
drivers/watchdog/f71808e_wdt.c | 42 +++
1 file changed, 38 insertions(+), 4 deletions(-)
diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
index 5496d2bb0089..e96f2c274b80
it's readily apparent
that functions are not variant-specific. Some watchdog_-prefixed
functions remain, but these will be dropped altogether with the move
to the kernel watchdog API in a later commit.
Signed-off-by: Ahmad Fatoum
---
drivers/watchdog/f71808e_wdt.c | 66
Hello,
On 16.03.21 18:47, Ahmad Fatoum wrote:
> On 04.02.21 18:00, Ahmad Fatoum wrote:
>> This series migrates the driver to the new kernel watchdog API and
>> then to the driver model.
>>
>> Main feedback from Guenther on v2 was that I need to split it up to
>&
Hello Greg,
On 23.03.21 16:37, Ahmad Fatoum wrote:
> We now have three places within the same file doing the same operation
> of freeing this pointer and setting it anew. A helper makes this
> arguably easier to read, so add one.
>
> Reviewed-by: Andy Shevchenko
> Reviewed
Hello Richard, Sumit,
On 01.04.21 15:17, Richard Weinberger wrote:
> Sumit,
>
> - Ursprüngliche Mail -
>> Von: "Sumit Garg"
>> IIUC, this would require support for multiple trusted keys backends at
>> runtime but currently the trusted keys subsystem only supports a
>> single backend
Hello Richard,
On 01.04.21 13:05, Richard Weinberger wrote:
> Ahmad,
>
> - Ursprüngliche Mail -
>> Von: "Ahmad Fatoum"
>>> I don't want you to force to use cryptsetup.
>>
>> I'd love to use cryptsetup with LUKS and trusted keys eventu
Hello Richard,
On 01.04.21 12:53, Richard Weinberger wrote:
> Ahmad,
>
> - Ursprüngliche Mail -
>> Do you mean systemd-cryptsetup? It looks to me like it's just a way to supply
>> the keyphrase. With trusted keys and a keyphrase unknown to userspace, this
>> won't work.
>
> Nah, I meant
Hello,
On 01.04.21 12:20, Richard Weinberger wrote:
> Ahmad,
>
> - Ursprüngliche Mail -
>> Von: "Ahmad Fatoum"
>>> I'm pretty sure with minimal changes it will work with your recent approach
>>> too.
>>
>> I am using dmsetup di
Hello Richard,
On 31.03.21 20:35, Richard Weinberger wrote:
> Ahmad,
>
> On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum wrote:
>> +#define KEYMOD "kernel:trusted"
>
> why is the CAAM key modifier hard coded?
> I'd love to have way to pass my own modifier.
>
Hello Richard,
On 31.03.21 21:36, Richard Weinberger wrote:
> James,
>
> - Ursprüngliche Mail -
>> Von: "James Bottomley"
>> Well, yes. For the TPM, there's a defined ASN.1 format for the keys:
>>
>>
Hello Richard,
On 30.03.21 23:50, Richard Weinberger wrote:
> Ahmad,
>
> On Wed, Mar 17, 2021 at 3:08 PM Ahmad Fatoum wrote:
>
>> TABLE="0 $BLOCKS crypt $ALGO :32:trusted:$KEYNAME 0 $DEV 0 1
>> allow_discards"
>> echo $TABLE | dmsetup create
Hello Jarkko,
On 01.04.21 01:30, Jarkko Sakkinen wrote:
>> Option (C) sounds reasonable to me but I would rather prefer an info
>> message rather than warning as otherwise it would reflect that we are
>> enforcing kernel RNG choice for a user to trust upon.
>
> I gave some though on this.
>
> I
Hello Adrien,
On 30.03.21 10:35, Adrien Grassein wrote:
> Add the description for the USB host port.
> At this time, the port will not work directly from the
> kernel because it's connected through a resettable hub
> that is not handle in the kernel. It should be controlled
> in the bootloader or
Hello Jarkko,
On 28.03.21 22:37, Jarkko Sakkinen wrote:
> On Sat, Mar 27, 2021 at 01:41:24PM +0100, David Gstir wrote:
>> Generally speaking, I’d say trusting the CAAM RNG and trusting in it’s
>> other features are two separate things. However, reading through the CAAM
>> key blob spec I’ve got
Hello Sumit,
On 24.03.21 11:47, Sumit Garg wrote:
> On Wed, 24 Mar 2021 at 14:56, Ahmad Fatoum wrote:
>>
>> Hello Mimi,
>>
>> On 23.03.21 19:07, Mimi Zohar wrote:
>>> On Tue, 2021-03-23 at 17:35 +0100, Ahmad Fatoum wrote:
>>>> On 21.03.21 21:48,
Hello Mimi,
On 23.03.21 19:07, Mimi Zohar wrote:
> On Tue, 2021-03-23 at 17:35 +0100, Ahmad Fatoum wrote:
>> On 21.03.21 21:48, Horia Geantă wrote:
>>> caam has random number generation capabilities, so it's worth using that
>>> by implementing .get_random.
>>
Hello Horia,
On 21.03.21 21:46, Horia Geantă wrote:
> On 3/16/2021 7:01 PM, Ahmad Fatoum wrote:
>> +init_job_desc(desc, 0);
>> +append_key_as_imm(desc, keymod, keymod_len, keymod_len,
>> + CLASS_2 | KEY_DEST_CLASS_REG);
>> +append_seq_
Hello Horia,
On 21.03.21 21:01, Horia Geantă wrote:
>> - [RFC] drivers: crypto: caam: key: Add caam_tk key type
>>Franck added[3] a new "caam_tk" key type based on Udit's work. The key
>>material stays within the kernel only, but can optionally be user-set
>>instead of coming from
Hello Horia,
On 21.03.21 21:48, Horia Geantă wrote:
> On 3/16/2021 7:02 PM, Ahmad Fatoum wrote:
> [...]
>> +struct trusted_key_ops caam_trusted_key_ops = {
>> +.migratable = 0, /* non-migratable */
>> +.init = trusted_caam_init,
>> +.seal = trus
Hello Horia,
On 21.03.21 21:01, Horia Geantă wrote:
> On 3/16/2021 7:02 PM, Ahmad Fatoum wrote:
>> This patch series builds on top of Sumit's rework to have the CAAM as yet
>> another
>> trusted key backend.
>>
> Shouldn't the description under TRUSTED_
: add deferring probe reason to
devices_deferred property")
Reviewed-by: Andy Shevchenko
Reviewed-by: Andrzej Hajda
Signed-off-by: Ahmad Fatoum
---
v2 -> v3:
- collected Andrzej's Reviewed-by
v1 -> v2:
- reworded commit message (Andy)
- collected Andy's Reviewed-by
---
drivers/base/dd.c
We now have three places within the same file doing the same operation
of freeing this pointer and setting it anew. A helper makes this
arguably easier to read, so add one.
Reviewed-by: Andy Shevchenko
Reviewed-by: Andrzej Hajda
Signed-off-by: Ahmad Fatoum
---
v2 -> v3:
- fixed typo in com
Hello,
On 23.03.21 15:07, Greg Kroah-Hartman wrote:
> On Fri, Mar 19, 2021 at 12:04:58PM +0100, Ahmad Fatoum wrote:
>> We now have three places within the same file doing the same operation
>> of freeing this pointer and setting it anew. A helper make this
>> arguably easie
;ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1
support")
With this addressed:
Reviewed-by: Ahmad Fatoum
You could send a proper patch and stick your S-o-b under it.
Cheers,
Ahmad
>
> I added Ahmad to Cc, he added board support to DistroKit for that board, and
> might wa
this patch, which has removed the priv->lock added in
> RFC v2.
Overnight test (10h, 64 mil frames) didn't see any out-of-order frames
between 2 FlexCANs on a dual core machine:
Tested-by: Ahmad Fatoum
No performance measurements taken.
>
> There is
Hello Andy,
On 19.03.21 13:16, Andy Shevchenko wrote:
> On Fri, Mar 19, 2021 at 1:46 PM Ahmad Fatoum wrote:
>> On 19.03.21 12:13, Andy Shevchenko wrote:
>>> On Fri, Mar 19, 2021 at 1:05 PM Ahmad Fatoum
>>> wrote:
>>>>
>>>> We now have three p
Hi,
On 19.03.21 12:15, Andy Shevchenko wrote:
> On Fri, Mar 19, 2021 at 1:05 PM Ahmad Fatoum wrote:
>>
>> We now have three places within the same file doing the same operation
>> of freeing this pointer and setting it anew. A helper make this
>> arguably easier to rea
On 19.03.21 12:13, Andy Shevchenko wrote:
> On Fri, Mar 19, 2021 at 1:05 PM Ahmad Fatoum wrote:
>>
>> We now have three places within the same file doing the same operation
>> of freeing this pointer and setting it anew. A helper make this
>
> makes
>
>>
: add deferring probe reason to
devices_deferred property")
Reviewed-by: Andy Shevchenko
Signed-off-by: Ahmad Fatoum
---
v1 -> v2:
- reworded commit message (Andy)
- collected Andy's Reviewed-by
---
drivers/base/dd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/base/dd.c b
We now have three places within the same file doing the same operation
of freeing this pointer and setting it anew. A helper make this
arguably easier to read, so add one.
Signed-off-by: Ahmad Fatoum
---
v1 -> v2:
- no change
---
drivers/base/dd.c | 17 +++--
1 file changed,
On 18.03.21 08:46, Yunsheng Lin wrote:
> On 2021/3/18 15:10, Ahmad Fatoum wrote:
>> On 15.03.21 04:10, Yunsheng Lin wrote:
>>> Currently pfifo_fast has both TCQ_F_CAN_BYPASS and TCQ_F_NOLOCK
>>> flag set, but queue discipline by-pass does not work for lockless
>
We now have three places within the same file doing the same operation
of freeing this pointer and setting it anew. A helper make this
arguably easier to read, so add one.
Signed-off-by: Ahmad Fatoum
---
drivers/base/dd.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions
rring probe reason to
devices_deferred property")
Signed-off-by: Ahmad Fatoum
---
drivers/base/dd.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/base/dd.c b/drivers/base/dd.c
index 9179825ff646..e2cf3b29123e 100644
--- a/drivers/base/dd.c
+++ b/drivers/base/dd.c
@@ -97,6 +97,9
bout 10% with this
> patch.
>
> Signed-off-by: Yunsheng Lin
> ---
> RFC V2: fix requeued skb out of order and data race problem.
cansequence didn't find any frame reordering with 2 FlexCAN's communicating
with each other on a dual core i.MX6. Feel free to add:
Tested-by: Ahmad
Hi Jarkko,
On 17.03.21 22:57, Jarkko Sakkinen wrote:
> On Wed, Mar 17, 2021 at 03:29:05PM +0100, Ahmad Fatoum wrote:
>> MODULE_DEVICE_TABLE is defined in , which is not
>> included. Add the include to fix the build error its lack caused.
>>
>> Cc: Sumit Garg
>
MODULE_DEVICE_TABLE is defined in , which is not
included. Add the include to fix the build error its lack caused.
Cc: Sumit Garg
Signed-off-by: Ahmad Fatoum
---
security/keys/trusted-keys/trusted_tee.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/keys/trusted-keys
Hello Richard,
On 17.03.21 00:10, Richard Weinberger wrote:
> On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum wrote:
>> This series has been tested with dmcrypt[5] on an i.MX6DL.
>
> Do have this series also in a git repo to pull from?
> I'd like to give it a test on various sys
Hello Richard,
On 17.03.21 00:14, Richard Weinberger wrote:
> Ahmad,
>
> On Tue, Mar 16, 2021 at 6:24 PM Ahmad Fatoum wrote:
>> +#include
>> +#include
>> +#include
>> +#include
>> +#include
>> +
>> +struct caam_blob_priv *blobifier;
Hello Jarkko,
On 16.03.21 20:22, Jarkko Sakkinen wrote:
> On Tue, Mar 16, 2021 at 06:01:18PM +0100, Ahmad Fatoum wrote:
>> The Cryptographic Acceleration and Assurance Module (CAAM) is an IP core
>> built into many newer i.MX and QorIQ SoCs by NXP.
>>
>> The CA
Hello,
On 04.02.21 18:00, Ahmad Fatoum wrote:
> This series migrates the driver to the new kernel watchdog API and
> then to the driver model.
>
> Main feedback from Guenther on v2 was that I need to split it up to
> enable review. I have done so by removing the extra refact
generalized trusted keys to support multiple backends
and added an API to access the CAAM blob mechanism. Based on these,
provide the necessary glue to use the CAAM for trusted keys.
Signed-off-by: Ahmad Fatoum
---
To: Jonathan Corbet
To: David Howells
To: Jarkko Sakkinen
To: James Bottomley
rris
Cc: "Serge E. Hallyn"
Cc: Steffen Trumtrar
Cc: Udit Agarwal
Cc: Jan Luebbe
Cc: David Gstir
Cc: Franck LENORMAND
Cc: Sumit Garg
Cc: linux-integr...@vger.kernel.org
Cc: keyri...@vger.kernel.org
Cc: linux-cry...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-security-
For cases a trusted key source already sources the kernel RNG, we can
use get_random_bytes_wait to get the random data for key material.
Make the get_random callback optional to allow sources to make use of
this.
Signed-off-by: Ahmad Fatoum
---
To: James Bottomley
To: Jarkko Sakkinen
To: Mimi
into memory alongside
the CAAM driver.
They will be used in a later commit as a source for the trusted key
seal/unseal mechanism.
Signed-off-by: Steffen Trumtrar
Signed-off-by: Ahmad Fatoum
---
To: "Horia Geantă"
To: Aymen Sghaier
To: Herbert Xu
To: "David S. Miller"
Cc:
On 13.03.21 16:16, Ahmad Fatoum wrote:
>> +/* i.MX boards use device trees now. For build tests without CONFIG_OF, do
>> nothing */
>> +#ifdef CONFIG_OF
>> if (imx_keep_uart_clocks) {
>> int i;
>>
>> -imx_uart
)
> Suggested-by: Aisheng Dong
> Signed-off-by: Adam Ford
> Reviewed-by: Abel Vesa
> Tested-by: Ahmad Fatoum
>
> ---
> V4: Check if of_stdout is available before using it.
> Re-align #ifdef to remove repeated code.
> V3: Return a method more closely related to upst
Hello,
On 11.03.21 16:18, Alexandre TORGUE wrote:
>> I raised this issue before with your colleagues. I still believe the correct
>> way
>> would be for the TF-A to pass down either a device tree or an overlay with
>> the
>> actual settings in use, e.g.:
>>
>> - Clocks/Resets done via SCMI
Hello,
On 11.03.21 15:02, Alexandre TORGUE wrote:
> On 3/11/21 12:43 PM, Marek Vasut wrote:
>> On 3/11/21 9:08 AM, Alexandre TORGUE wrote:
>>> 1- Break the current ABI: as soon as those patches are merged,
>>> stm32mp157c-dk2.dtb will impose to use
>>> A tf-a for scmi clocks. For people using
Hello Dillon,
On 11.03.21 13:23, dillon min wrote:
> For stm32h7's new board support , I guess following the stm32f7/stm32f4's
> style
> is a reasonable way to do it, but add a little optimization。
> which means :
> old structure
> stm32h7-pinctrl.dtsi --> stm32h743-pinctrl.dtsi (referenced by
=
> of_clk_get(of_stdout, i);
of_stdout may be NULL if there is no stdout-path. You should check that earlier.
With this fixed, feel free to add:
Tested-by: Ahmad Fatoum
> +
> + /* Stop if there are no more of_stdout references */
> +
Hello Gabriel,
On 26.01.21 10:01, gabriel.fernan...@foss.st.com wrote:
> From: Gabriel Fernandez
>
> This change reflects board hardware configuration where RCC security
> features are configured for RCC[TZEN]=1 and RCC[MCKPROT]=0, that is
> RCC TrustZone is hardened and RCC MCKPROT is
Hello Jarkko,
On 10.02.21 18:00, Jarkko Sakkinen wrote:
> On Tue, Nov 03, 2020 at 09:31:43PM +0530, Sumit Garg wrote:
>> +case Opt_new:
>> +key_len = payload->key_len;
>> +ret = static_call(trusted_key_get_random)(payload->key,
>> +
struct fintek_wdt
Ahmad Fatoum (3):
watchdog: f71808e_wdt: rename variant-independent identifiers appropriately
watchdog: f71808e_wdt: migrate to new kernel watchdog API
watchdog: f71808e_wdt: refactor to platform device/driver pair
drivers/watchdog/Kconfig | 1 +-
drivers/watchdog/f71808e
-by: Ahmad Fatoum
---
drivers/watchdog/Kconfig | 1 +-
drivers/watchdog/f71808e_wdt.c | 390 --
2 files changed, 53 insertions(+), 338 deletions(-)
diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
index 7ff941e71b79..cbce0c176a7e 100644
it's readily apparent
that functions are not variant-specific. Some watchdog_-prefixed
functions remain, but these will be dropped altogether with the move
to the kernel watchdog API in a later commit.
Signed-off-by: Ahmad Fatoum
---
drivers/watchdog/f71808e_wdt.c | 66
.
Suggested-by: Guenter Roeck
Signed-off-by: Ahmad Fatoum
---
drivers/watchdog/f71808e_wdt.c | 42 +++
1 file changed, 38 insertions(+), 4 deletions(-)
diff --git a/drivers/watchdog/f71808e_wdt.c b/drivers/watchdog/f71808e_wdt.c
index 5496d2bb0089..e96f2c274b80
Hello Mike,
On 02.02.21 19:10, Mike Snitzer wrote:
> On Fri, Jan 22 2021 at 3:43am -0500,
> Ahmad Fatoum wrote:
>
>> IS_ENABLED(CONFIG_ENCRYPTED_KEYS) is true whether the option is built-in
>> or a module, so use it instead of #if defined checking for each
>>
On 22.01.21 20:04, Ahmad Fatoum wrote:
> On 22.01.21 19:18, Jarkko Sakkinen wrote:
>> On Fri, Jan 22, 2021 at 08:05:51PM +0200, Jarkko Sakkinen wrote:
>>> On Fri, Jan 22, 2021 at 09:43:21AM +0100, Ahmad Fatoum wrote:
>>>> Commit 27f5411a718c ("dm crypt: supp
Hello,
I've been looking into how a migration to using trusted/encrypted keys
would look like (particularly with dm-crypt).
Currently, it seems the the only way is to re-encrypt the partitions
because trusted/encrypted keys always generate their payloads from
RNG.
If instead there was a key
Hello Jonathan,
On 24.01.21 16:22, Jonathan Cameron wrote:
> On Fri, 22 Jan 2021 12:33:55 +0100
> Ahmad Fatoum wrote:
>
>> For non-DMA usage, we have an easy way to associate a timestamp with a
>> sample: iio_pollfunc_store_time stores a timestamp in the primary
&
into that buffer
as well. Until this is implemented, restrict timestamping support to
only PIO. For low-frequency sampling, PIO is probably good enough.
Cc: Holger Assmann
Acked-by: Fabrice Gasnier
Signed-off-by: Ahmad Fatoum
---
v2 -> v3:
- explicitly specify alignment (Jonathan)
- increase buffer s
too strongly about it. Please dismiss and thanks for the
clarification.
Cheers,
Ahmad
> BR,
>
> Lionel
>
> On 1/19/21 10:52 AM, Ahmad Fatoum wrote:
>> There is no SoC-external hardware support needed for the hash1, rng1,
>> crc1 and cryp1 IP blocks to function
into that buffer
as well. Until this is implemented, restrict timestamping support to
only PIO. For low-frequency sampling, PIO is probably good enough.
Cc: Holger Assmann
Acked-by: Fabrice Gasnier
Signed-off-by: Ahmad Fatoum
---
v3 -> v4:
- descrease buffer size to correct size (Marc)
v2 -&
On 25.01.21 12:49, Marc Kleine-Budde wrote:
> On 1/25/21 12:21 PM, Ahmad Fatoum wrote:
>> For non-DMA usage, we have an easy way to associate a timestamp with a
>> sample: iio_pollfunc_store_time stores a timestamp in the primary
>> trigger IRQ handler and stm32_adc
Hello Jarkko,
On 22.01.21 19:18, Jarkko Sakkinen wrote:
> On Fri, Jan 22, 2021 at 08:05:51PM +0200, Jarkko Sakkinen wrote:
>> On Fri, Jan 22, 2021 at 09:43:21AM +0100, Ahmad Fatoum wrote:
>>> Commit 27f5411a718c ("dm crypt: support using encrypted keys") extend
Hello Fabrice,
On 19.01.21 18:56, Fabrice Gasnier wrote:
> On 1/18/21 12:42 PM, Ahmad Fatoum wrote:
>> Hello Jonathan,
>>
>> On 16.01.21 18:53, Jonathan Cameron wrote:
>>> On Tue, 12 Jan 2021 16:24:42 +0100
>>> Ahmad Fatoum wrote:
>>>
>&
if (!priv->enabled)
Sorry, didn't look too closely first time.
- User sets ->enable = 0
- IRQ raised before disabling
- you return IRQ_NONE, kernel logs a spurious IRQ
I'd say that's a bug. Instead:
- Can we ask whether an irq is enabled? If so, you can drop ->enabled
- Otherwi
into that buffer
as well. Until this is implemented, restrict timestamping support to
only PIO. For low-frequency sampling, PIO is probably good enough.
Cc: Holger Assmann
Acked-by: Fabrice Gasnier
Signed-off-by: Ahmad Fatoum
---
v1 -> v2:
- Added comment about timestamping being PIO only (Fabr
Hi,
On 22.01.21 11:23, Fabrice Gasnier wrote:
> On 1/21/21 7:02 PM, Ahmad Fatoum wrote:
>> For non-DMA usage, we have an easy way to associate a timestamp with a
>> sample: iio_pollfunc_store_time stores a timestamp in the primary
>> trigger IRQ handler and stm32_adc
Hello Oleksij,
On 22.01.21 10:33, Oleksij Rempel wrote:
> Add simple GPIO base pulse counter. This device is used to measure
> rotation speed of some agricultural devices, so no high frequency on the
> counter pin is expected.
>
> The maximal measurement frequency depends on the CPU and system
remove that first #if guard.
Suggested-by: Arnd Bergmann
Signed-off-by: Ahmad Fatoum
---
Cc: Dmitry Baryshkov
---
drivers/md/dm-crypt.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/md/dm-crypt.c b/drivers/md/dm-crypt.c
index 8c874710f0bc..7eeb9248eda5 100644
Commit 27f5411a718c ("dm crypt: support using encrypted keys") extended
dm-crypt to allow use of "encrypted" keys along with "user" and "logon".
Along the same lines, teach dm-crypt to support "trusted" keys as well.
Signed-off-by: Ahmad
into that buffer
as well. Until this is implemented, restrict timestamping support to
only PIO. For low-frequency sampling, PIO is probably good enough.
Cc: Holger Assmann
Signed-off-by: Ahmad Fatoum
---
drivers/iio/adc/stm32-adc.c | 31 +--
1 file changed, 25 insertions(+), 6
s/timetamping/timestamping/
Cc: triv...@kernel.org
Signed-off-by: Ahmad Fatoum
---
drivers/iio/common/st_sensors/st_sensors_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/common/st_sensors/st_sensors_buffer.c
b/drivers/iio/common/st_sensors
Hello Sasha,
On 20.01.21 15:26, Sasha Levin wrote:
> On Tue, Jan 19, 2021 at 10:08:15PM -0800, Jakub Kicinski wrote:
>> On Tue, 19 Jan 2021 20:25:45 -0500 Sasha Levin wrote:
>>> From: David Wu
>>>
>>> [ Upstream commit 5b55299eed78538cc4746e50ee97103a1643249c ]
>>>
>>> Since the original mtu is
Hello Sumit,
On 03.11.20 17:01, Sumit Garg wrote:
> Add support for TEE based trusted keys where TEE provides the functionality
> to seal and unseal trusted keys using hardware unique key.
>
> Refer to Documentation/tee.txt for detailed information about TEE.
>
> Signed-off-by: Sumit Garg
>
There is no SoC-external hardware support needed for the hash1, rng1,
crc1 and cryp1 IP blocks to function. Enable them thus unconditionally
instead of replicating their enablement in board device trees.
Signed-off-by: Ahmad Fatoum
---
arch/arm/boot/dts/stm32mp151.dtsi | 3
Hello Shawn,
On 19.01.21 09:57, Shawn Guo wrote:
> On Fri, Nov 13, 2020 at 04:28:55PM +0100, Ahmad Fatoum wrote:
>> The SoC dtsi lists a NOP USB PHY for each of the two HSIC-only USB
>> controllers. Their device tree node doesn't indicate a vcc-supply
>> resulting in:
&g
Hello,
did this maybe slip through the cracks?
On 13.11.20 16:28, Ahmad Fatoum wrote:
> The SoC dtsi lists a NOP USB PHY for each of the two HSIC-only USB
> controllers. Their device tree node doesn't indicate a vcc-supply
> resulting in:
>
> usb_phy_generic usbphynop1: suppl
Hello Jonathan,
On 16.01.21 18:53, Jonathan Cameron wrote:
> On Tue, 12 Jan 2021 16:24:42 +0100
> Ahmad Fatoum wrote:
>
>> 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") makes sure
>> that threaded IRQs either
>> - have IRQF_ONESHOT set
>
Hello Kamel,
On 30.12.20 14:43, Kamel Bouhara wrote:
> Hi Ahmad,
>
> On 4/28/20 1:18 PM, Ahmad Fatoum wrote:
>> The nvmem cell binding used to apply to all objects which match
>> "^.*@[0-9a-f]+$", without taking a compatible into account, which
>> preclude
reg property and vice versa.
Fixes: e888d445ac33 ("nvmem: resolve cells from DT at registration time").
Signed-off-by: Ahmad Fatoum
---
Previous Discussion:
https://lore.kernel.org/lkml/20200428111829.2215-1-a.fat...@pengutronix.de/
v1:
- Ignore all nodes with a unit address (i.e
Hello Stephen,
On 25.11.20 03:17, Stephen Boyd wrote:
> Quoting Ahmad Fatoum (2020-11-13 06:53:09)
>> diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
>> index ba33c79158de..b2e4b6234ac0 100644
>> --- a/drivers/clk/imx/clk-imx6q.c
>> +++ b/
litch-free reparenting.
As such systems are doing everything correctly, a warning is too
harsh. Demote to a notice, so users are still alerted, but without
cluttering a loglevel=5 boot.
While at it, add the words "possible glitch" into the log message, to
make it more user-friendly.
IRQs disabled), this no longer
occurs.
Cc: Lucas Stach
Reported-by: Holger Assmann
Fixes: 695e2f5c289b ("iio: adc: stm32-adc: fix a regression when using dma and
irq")
Signed-off-by: Ahmad Fatoum
---
drivers/iio/adc/stm32-adc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 11.01.21 16:17, Max Krummenacher wrote:
> When the kernel is configured to use the Thumb-2 instruction set
> "suspend-to-memory" fails to resume. Observed on a Colibri iMX6ULL
> (i.MX 6ULL) and Apalis iMX6 (i.MX 6Q).
>
> It looks like the CPU resumes unconditionally in ARM instruction mode
kov
> Cc: kasan-...@googlegroups.com
> Reviewed-by: Ard Biesheuvel
> Tested-by: Ard Biesheuvel # QEMU/KVM/mach-virt/LPAE/8G
> Tested-by: Florian Fainelli # Brahma SoCs
> Tested-by: Ahmad Fatoum # i.MX6Q
> Reported-by: Russell King - ARM Linux
> Signed-off-by: Ahmad Fato
Hello Oleksander,
On 26.12.20 10:47, Oleksandr Suvorov wrote:
> Add support of sub-functions disabling. It allows one to define
> an stmpe sub-function device in devicetree, but keep it disabled.
>
> Signed-off-by: Oleksandr Suvorov
> ---
>
> drivers/mfd/stmpe.c | 3 +++
> 1 file changed, 3
Hello Kishon,
On 21.12.20 04:15, Kishon Vijay Abraham I wrote:
>> So how was it meant to be?
>
> It is intended to be ->init() and then ->power_on(). So ideally it
> should be the way dwc3 is.
Thanks. Should we do something about the inconsistency?
Amend documentation and maybe print a warning
Hello,
I just noticed that USB controller drivers differ in the order in which they
do phy_init and phy_power_on. For example:
__dwc2_lowlevel_hw_enable():
ret = phy_power_on(hsotg->phy);
if (ret == 0)
ret = phy_init(hsotg->phy);
On 17.12.20 18:59, Jakub Kicinski wrote:
> On Thu, 17 Dec 2020 09:25:48 +0100 Ahmad Fatoum wrote:
>> On 17.12.20 02:13, Jakub Kicinski wrote:
>>>> + netdev_warn(priv->dev, "HW Timestamping init failed:
>>>> %pe\n",
>&
Hello,
On 17.12.20 02:13, Jakub Kicinski wrote:
>> +netdev_warn(priv->dev, "HW Timestamping init failed:
>> %pe\n",
>> +ERR_PTR(ret));
>
> why convert to ERR_PTR and use %pe and not just %d?
To get a symbolic error name if support is
Hello Arnaud,
On Wed, 2020-12-09 at 14:12 +0100, Arnaud Pouliquen wrote:
> From: Etienne Carriere
>
> Change stm32 remoteproc driver to not generate an error message
> when device probe operation is deferred for the reset controller.
>
> Signed-off-by: Etienne Carriere
> Signed-off-by: Arnaud
1 - 100 of 189 matches
Mail list logo
