On Sat, Feb 16, 2019 at 12:06:23PM -0500, Yangtao Li wrote:
> kmalloc() could fail, so insert a check of its return value. And
> if it fails, returns -ENOMEM.
>
> And remove (struct pstate_idx_revmap_data *) to fix coccinelle WARNING
> by the way.
>
> WARNING: casting value returned by memory
about this
opal call, then just a firmware supporting newer hardware is required,
instead of waiting for kernel updates.
Signed-off-by: Abhishek Goel
Signed-off-by: Akshay Adiga
---
Changes from v1 :
- Code is rebased on Nick Piggin's v4 patch "powerpc/64s: reimplement book3s
idle code
about this
opal call, then just a firmware supporting newer hardware is required,
instead of waiting for kernel updates.
Signed-off-by: Abhishek Goel
Signed-off-by: Akshay Adiga
---
Changes from v1 :
- Code is rebased on Nick Piggin's v4 patch "powerpc/64s: reimplement book3s
idle code
Passing pointer to the pnv_idle_state instead of psscr value and mask.
This helps us to pass more information to the stop loop. This will help to
figure out the method to enter/exit idle state.
Signed-off-by: Akshay Adiga
---
Changes from v1 :
- Code is rebased on Nick Piggin's v4 patch
Passing pointer to the pnv_idle_state instead of psscr value and mask.
This helps us to pass more information to the stop loop. This will help to
figure out the method to enter/exit idle state.
Signed-off-by: Akshay Adiga
---
Changes from v1 :
- Code is rebased on Nick Piggin's v4 patch
uot; : indicates it should be used by hotplug driver
compatible strings :
"ibm,state-v1" : kernel checks if it knows about this version
"opal-supported" : indicates kernel can fall back to use opal
for stop-transitions
Signed-off-by: Akshay Adiga
---
Change
by OPAL
- All the decision making such as identifying first thread in
the core and taking locks before restoring in such cases have also been
moved to OPAL
Abhishek Goel (1):
cpuidle/powernv: save-restore sprs in opal
Akshay Adiga (2):
cpuidle/powernv: Add support for states with ibm,cpuid
uot; : indicates it should be used by hotplug driver
compatible strings :
"ibm,state-v1" : kernel checks if it knows about this version
"opal-supported" : indicates kernel can fall back to use opal
for stop-transitions
Signed-off-by: Akshay Adiga
---
Change
by OPAL
- All the decision making such as identifying first thread in
the core and taking locks before restoring in such cases have also been
moved to OPAL
Abhishek Goel (1):
cpuidle/powernv: save-restore sprs in opal
Akshay Adiga (2):
cpuidle/powernv: Add support for states with ibm,cpuid
Export pnv_idle_states and nr_pnv_idle_states so that its accessible to
cpuidle driver. Use properties from pnv_idle_states structure for powernv
cpuidle_init.
Signed-off-by: Akshay Adiga
---
arch/powerpc/include/asm/cpuidle.h | 2 ++
drivers/cpuidle/cpuidle-powernv.c | 49
Export pnv_idle_states and nr_pnv_idle_states so that its accessible to
cpuidle driver. Use properties from pnv_idle_states structure for powernv
cpuidle_init.
Signed-off-by: Akshay Adiga
---
arch/powerpc/include/asm/cpuidle.h | 2 ++
drivers/cpuidle/cpuidle-powernv.c | 49
things so that number of available idle states can be
accessible to cpuidle-powernv driver. Hence adding nr_pnv_idle_states to
track number of idle states.
Signed-off-by: Akshay Adiga
---
arch/powerpc/include/asm/cpuidle.h| 14 +++
arch/powerpc/platforms/powernv/idle.c | 197
things so that number of available idle states can be
accessible to cpuidle-powernv driver. Hence adding nr_pnv_idle_states to
track number of idle states.
Signed-off-by: Akshay Adiga
---
arch/powerpc/include/asm/cpuidle.h| 14 +++
arch/powerpc/platforms/powernv/idle.c | 197
On Wed, May 16, 2018 at 05:32:14PM +0530, Akshay Adiga wrote:
> Init all present cpus for deep states instead of "all possible" cpus.
> Init fails if the possible cpu is gaurded. Resulting in making only
> non-deep states available for cpuidle/hotplug.
>
> Signed-off-by
On Wed, May 16, 2018 at 05:32:14PM +0530, Akshay Adiga wrote:
> Init all present cpus for deep states instead of "all possible" cpus.
> Init fails if the possible cpu is gaurded. Resulting in making only
> non-deep states available for cpuidle/hotplug.
>
> Si
Yes this needs to be sent to stable.
Fixes: d405a98c ("powerpc/powernv: Move cpuidle related code from setup.c
to new file")
Yes this needs to be sent to stable.
Fixes: d405a98c ("powerpc/powernv: Move cpuidle related code from setup.c
to new file")
Init all present cpus for deep states instead of "all possible" cpus.
Init fails if the possible cpu is gaurded. Resulting in making only
non-deep states available for cpuidle/hotplug.
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
arch/powerpc/platforms/po
Init all present cpus for deep states instead of "all possible" cpus.
Init fails if the possible cpu is gaurded. Resulting in making only
non-deep states available for cpuidle/hotplug.
Signed-off-by: Akshay Adiga
---
arch/powerpc/platforms/powernv/idle.c | 4 ++--
1 file changed, 2
deepest stop state.
On onlining cpu, request restore of PSSCR to deepest stop state used by
cpuidle.
Cc: <sta...@vger.kernel.org> # v4.14+
Fixes : 1e1601b38e6e ("powerpc/powernv/idle: Restore SPRs for deep idle
states via stop API.")
Reported-by: Pridhiviraj Paidipeddi <ppaid...@lin
deepest stop state.
On onlining cpu, request restore of PSSCR to deepest stop state used by
cpuidle.
Cc: # v4.14+
Fixes : 1e1601b38e6e ("powerpc/powernv/idle: Restore SPRs for deep idle
states via stop API.")
Reported-by: Pridhiviraj Paidipeddi
Signed-off-by: Akshay Adiga
---
arch/powerpc/
On Mon, Feb 26, 2018 at 03:47:12PM +1100, Stewart Smith wrote:
> Akshay Adiga <akshay.ad...@linux.vnet.ibm.com> writes:
> > commit 1e1601b38e6e ("powerpc/powernv/idle: Restore SPRs for deep idle
> > states via stop API.") uses stop-api provided by the firmware to r
On Mon, Feb 26, 2018 at 03:47:12PM +1100, Stewart Smith wrote:
> Akshay Adiga writes:
> > commit 1e1601b38e6e ("powerpc/powernv/idle: Restore SPRs for deep idle
> > states via stop API.") uses stop-api provided by the firmware to restore
> > PSSCR. PSSCR restore i
deepest stop state.
On onlining cpu, request restore of PSSCR to deepest stop state used by
cpuidle.
Fixes : 1e1601b38e6e ("powerpc/powernv/idle: Restore SPRs for deep idle
states via stop API.")
Reported-by: Pridhiviraj Paidipeddi <ppaid...@linux.vnet.ibm.com>
Signed-off-by: Akshay Adiga
deepest stop state.
On onlining cpu, request restore of PSSCR to deepest stop state used by
cpuidle.
Fixes : 1e1601b38e6e ("powerpc/powernv/idle: Restore SPRs for deep idle
states via stop API.")
Reported-by: Pridhiviraj Paidipeddi
Signed-off-by: Akshay Adiga
---
arch/powerpc/include/as
Hi Michael,
Any comments on this patch ?
On 09/06/2017 02:32 PM, pavrampu wrote:
On 2017-08-31 17:17, Gautham R. Shenoy wrote:
> From: "Gautham R. Shenoy"
>
> commit 24be85a23d1f ("powerpc/powernv: Clear PECE1 in LPCR via
> stop-api only on Hotplug") clears the PECE1
Hi Michael,
Any comments on this patch ?
On 09/06/2017 02:32 PM, pavrampu wrote:
On 2017-08-31 17:17, Gautham R. Shenoy wrote:
> From: "Gautham R. Shenoy"
>
> commit 24be85a23d1f ("powerpc/powernv: Clear PECE1 in LPCR via
> stop-api only on Hotplug") clears the PECE1 bit of the LPCR via
>
On 08/31/2017 05:37 PM, Nicholas Piggin wrote:
On Thu, 31 Aug 2017 17:17:41 +0530
"Gautham R. Shenoy" wrote:
> From: "Gautham R. Shenoy"
>
> commit 24be85a23d1f ("powerpc/powernv: Clear PECE1 in LPCR via
> stop-api only on Hotplug") clears
On 08/31/2017 05:37 PM, Nicholas Piggin wrote:
On Thu, 31 Aug 2017 17:17:41 +0530
"Gautham R. Shenoy" wrote:
> From: "Gautham R. Shenoy"
>
> commit 24be85a23d1f ("powerpc/powernv: Clear PECE1 in LPCR via
> stop-api only on Hotplug") clears the PECE1 bit of the LPCR via
> stop-api during
in pnv_wakeup_noloss if
the R12[42:45] corresponds to HMI as wakeup reason.
Bug existed prior to "commit 9d29250136f6 ("powerpc/64s/idle: Avoid SRR
usage in idle sleep/wake paths") but was never hit in practice
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
in pnv_wakeup_noloss if
the R12[42:45] corresponds to HMI as wakeup reason.
Bug existed prior to "commit 9d29250136f6 ("powerpc/64s/idle: Avoid SRR
usage in idle sleep/wake paths") but was never hit in practice
Signed-off-by: Akshay Adiga
Fixes: 9d29250136f6 ("powerpc/64s/i
othwell <s...@canb.auug.org.au>
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
drivers/cpufreq/powernv-cpufreq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index c82304b..c5c5bc3 100644
--- a/d
Signed-off-by: Akshay Adiga
---
drivers/cpufreq/powernv-cpufreq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index c82304b..c5c5bc3 100644
--- a/drivers/cpufreq/powernv-cpufreq.c
+++ b/drivers/cpufreq/powernv-cpufreq.c
Hi Rafeal,
Good catch, I need to set lpstate_idx = gpstate_idx.
I will send a patch which fixes this commit.
Thanks Stephen for reporting it. :)
Regards
Akshay Adiga
On 11/14/2016 05:33 AM, Rafael J. Wysocki wrote:
On Monday, November 14, 2016 10:40:09 AM Stephen Rothwell wrote:
> Hi Raf
Hi Rafeal,
Good catch, I need to set lpstate_idx = gpstate_idx.
I will send a patch which fixes this commit.
Thanks Stephen for reporting it. :)
Regards
Akshay Adiga
On 11/14/2016 05:33 AM, Rafael J. Wysocki wrote:
On Monday, November 14, 2016 10:40:09 AM Stephen Rothwell wrote:
> Hi Raf
frequency: 2.26 GHz (asserted by call to hardware)
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
tools/power/cpupower/utils/cpufreq-info.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tools/power/cpupower/utils/cpufreq-info.c
b/tools/power
frequency: 2.26 GHz (asserted by call to hardware)
Signed-off-by: Akshay Adiga
---
tools/power/cpupower/utils/cpufreq-info.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tools/power/cpupower/utils/cpufreq-info.c
b/tools/power/cpupower/utils/cpufreq-info.c
Thanks gautham for the review.
Good point, I have made the macros more generic in the next version as
you have mentioned.
I will post a separate patch to set pstates using these macros. :)
On 11/08/2016 09:10 AM, Gautham R Shenoy wrote:
On Mon, Nov 07, 2016 at 01:09:09PM +0530, Akshay Adiga
Thanks gautham for the review.
Good point, I have made the macros more generic in the next version as
you have mentioned.
I will post a separate patch to set pstates using these macros. :)
On 11/08/2016 09:10 AM, Gautham R Shenoy wrote:
On Mon, Nov 07, 2016 at 01:09:09PM +0530, Akshay Adiga
Adding fast_switch which does light weight operation to set the desired
pstate. Both global and local pstates are set to the same desired pstate.
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
Reviewed-by: Gautham R. Shenoy <e...@linux.vnet.ibm.com>
Acked-by:
Adding fast_switch which does light weight operation to set the desired
pstate. Both global and local pstates are set to the same desired pstate.
Signed-off-by: Akshay Adiga
Reviewed-by: Gautham R. Shenoy
Acked-by: Viresh Kumar
---
Changes from v2 :
- No changes.
Changes from v1 :
- Removed
will be called
for a given govenor, but gpstate_timer can fire after the governor has
changed to schedutil.
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
Reviewed-by: Gautham R. Shenoy <e...@linux.vnet.ibm.com>
Acked-by: Viresh Kumar <viresh.ku...@linaro.org>
---
Changes
will be called
for a given govenor, but gpstate_timer can fire after the governor has
changed to schedutil.
Signed-off-by: Akshay Adiga
Reviewed-by: Gautham R. Shenoy
Acked-by: Viresh Kumar
---
Changes from v2 :
- Added generic macros GET_LPSTATE and GET_GPSTATE
instead of making it specific to PMCR
Thanks Viresh for taking a look at it.
I will make the mentioned changes in the next version of the patch.
Regards
Akshay Adiga
On 11/04/2016 12:03 PM, Viresh Kumar wrote:
On 04-11-16, 10:57, Akshay Adiga wrote:
Adding fast_switch which does light weight operation to
set the desired
Thanks Viresh for taking a look at it.
I will make the mentioned changes in the next version of the patch.
Regards
Akshay Adiga
On 11/04/2016 12:03 PM, Viresh Kumar wrote:
On 04-11-16, 10:57, Akshay Adiga wrote:
Adding fast_switch which does light weight operation to
set the desired
Adding fast_switch which does light weight operation to set the desired
pstate. Both global and local pstates are set to the same desired pstate.
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
Changes from v1 :
- Removed unnecessary check for index out of bound.
d
will be called
for a given govenor, but gpstate_timer can fire after the governor has
changed to schedutil.
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
Changes from v1 :
- Corrected Commit message
- Type cast pstate values read from PMCR to type s8
- Added Macros to get
Adding fast_switch which does light weight operation to set the desired
pstate. Both global and local pstates are set to the same desired pstate.
Signed-off-by: Akshay Adiga
---
Changes from v1 :
- Removed unnecessary check for index out of bound.
drivers/cpufreq/powernv-cpufreq.c | 20
will be called
for a given govenor, but gpstate_timer can fire after the governor has
changed to schedutil.
Signed-off-by: Akshay Adiga
---
Changes from v1 :
- Corrected Commit message
- Type cast pstate values read from PMCR to type s8
- Added Macros to get local and global pstates from PMCR
Thanks Viresh for taking a look at it.
I will make the mentioned changes in the next version of the patch and
will add Shilpa and Gautham to the mail chain.
Regards
Akshay Adiga
On 11/04/2016 12:11 PM, Viresh Kumar wrote:
On 04-11-16, 10:57, Akshay Adiga wrote:
As fast_switch may get
Thanks Viresh for taking a look at it.
I will make the mentioned changes in the next version of the patch and
will add Shilpa and Gautham to the mail chain.
Regards
Akshay Adiga
On 11/04/2016 12:11 PM, Viresh Kumar wrote:
On 04-11-16, 10:57, Akshay Adiga wrote:
As fast_switch may get
Adding fast_switch which does light weight operation to
set the desired pstate.
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
drivers/cpufreq/powernv-cpufreq.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/p
Adding fast_switch which does light weight operation to
set the desired pstate.
Signed-off-by: Akshay Adiga
---
drivers/cpufreq/powernv-cpufreq.c | 22 +-
1 file changed, 21 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq
to a different value. Hence the timer handler cannot rely
on the cached values of local and global pstate and needs to read it
from the PMSR.
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
drivers/cpufreq/powernv-cpufreq.c | 32 ++--
1 file chang
to a different value. Hence the timer handler cannot rely
on the cached values of local and global pstate and needs to read it
from the PMSR.
Signed-off-by: Akshay Adiga
---
drivers/cpufreq/powernv-cpufreq.c | 32 ++--
1 file changed, 22 insertions(+), 10 deletions(-)
diff
Hi Michael,
Here is the link to the bug raised on launchpad.
https://bugs.launchpad.net/ubuntu/+source/gcc-5/+bug/1628207
On 09/23/2016 09:45 AM, Akshay Adiga wrote:
Hi Michael,
Anton found this bug and raised it against gcc v7.0 and a fix is
available
in upstream gcc.
https
Hi Michael,
Here is the link to the bug raised on launchpad.
https://bugs.launchpad.net/ubuntu/+source/gcc-5/+bug/1628207
On 09/23/2016 09:45 AM, Akshay Adiga wrote:
Hi Michael,
Anton found this bug and raised it against gcc v7.0 and a fix is
available
in upstream gcc.
https
raised bug against Ubuntu for fixing gcc for 16.04.
https://bugzilla.linux.ibm.com/show_bug.cgi?id=146668
On 09/22/2016 03:51 PM, Michael Ellerman wrote:
Akshay Adiga <akshay.ad...@linux.vnet.ibm.com> writes:
Observed that boot arguments (passed as CONFIG_CMDLINE) are not being
pic
raised bug against Ubuntu for fixing gcc for 16.04.
https://bugzilla.linux.ibm.com/show_bug.cgi?id=146668
On 09/22/2016 03:51 PM, Michael Ellerman wrote:
Akshay Adiga writes:
Observed that boot arguments (passed as CONFIG_CMDLINE) are not being
picked up by kernel while using gcc-ppc64-linux-gnu
3308ec: 78 f3 c3 7f mr r3,r30
c03308f0: 5d 08 e3 4b bl c016114c
c03308f4: 00 00 00 60 nop
The problem goes away when compiler optimization is restricted to -O1.
Reported-by: Madhavan Srinivasan <ma...@linux.vnet.ibm.com>
Signed-of
7f mr r3,r30
c03308f0: 5d 08 e3 4b bl c016114c
c03308f4: 00 00 00 60 nop
The problem goes away when compiler optimization is restricted to -O1.
Reported-by: Madhavan Srinivasan
Signed-off-by: Akshay Adiga
---
init/main.c | 8 +++-
1
ux.vnet.ibm.com>
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
drivers/cpufreq/powernv-cpufreq.c | 21 -
1 file changed, 20 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index 87796
rtup_entry+0x38c/0x460
[c0078d66bf20] [c003d930] start_secondary+0x330/0x380
[c0078d66bf90] [c0008e6c] start_secondary_prolog+0x10/0x14
Fixes: 08d27eb ("cpufreq: powernv: Replacing pstate_id with
frequency table index")
Reported-by: Madhavan Srinivasan
Signed-
On 06/30/2016 11:53 AM, Akshay Adiga wrote:
Refactoring code to use frequency table index instead of pstate_id.
This abstraction will make the code independent of the pstate values.
- No functional changes
- The highest frequency is at frequency table index 0 and the frequency
decreases
On 06/30/2016 11:53 AM, Akshay Adiga wrote:
Refactoring code to use frequency table index instead of pstate_id.
This abstraction will make the code independent of the pstate values.
- No functional changes
- The highest frequency is at frequency table index 0 and the frequency
decreases
store index instead of pstate
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
Reviewed-by: Gautham R. Shenoy <e...@linux.vnet.ibm.com>
---
Changes from v1:
- changed macro names from get_pstate()/ get_index() to
idx_to_pstate()/ pstate_to_idx()
- Renamed variables that
store index instead of pstate
Signed-off-by: Akshay Adiga
Reviewed-by: Gautham R. Shenoy
---
Changes from v1:
- changed macro names from get_pstate()/ get_index() to
idx_to_pstate()/ pstate_to_idx()
- Renamed variables that store index instead of pstate_id to *_idx
- Retained previous
Hi viresh,
My apologies. I realize that i have messed it up a quite a few places. Surely
with the checkpatch as well. I will send a v2 with corrections.
On 06/27/2016 12:00 PM, Viresh Kumar wrote:
Hi Akshay,
Did you try running checkpatch for this?
On 24-06-16, 19:33, Akshay Adiga wrote
Hi viresh,
My apologies. I realize that i have messed it up a quite a few places. Surely
with the checkpatch as well. I will send a v2 with corrections.
On 06/27/2016 12:00 PM, Viresh Kumar wrote:
Hi Akshay,
Did you try running checkpatch for this?
On 24-06-16, 19:33, Akshay Adiga wrote
() and get_pstate() can be used for conversion between
pstate_id and index.
- powernv_pstate_info now contains frequency table index to min, max and
nominal frequency (instead of pstate_ids)
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
drivers/cpufreq/powernv-cpufreq.c
() and get_pstate() can be used for conversion between
pstate_id and index.
- powernv_pstate_info now contains frequency table index to min, max and
nominal frequency (instead of pstate_ids)
Signed-off-by: Akshay Adiga
---
drivers/cpufreq/powernv-cpufreq.c | 107
On 05/03/2016 08:49 PM, Akshay Adiga wrote:
Fixes are based on patch https://patchwork.ozlabs.org/patch/612058/ which
is in Rafael's linux-next.
- Patch [1] fixes WARN_ON in powernv_target_index()
- Patch [2] Deleting any pending timer to saves an unnecessary irq call
in powernv_target_index
On 05/03/2016 08:49 PM, Akshay Adiga wrote:
Fixes are based on patch https://patchwork.ozlabs.org/patch/612058/ which
is in Rafael's linux-next.
- Patch [1] fixes WARN_ON in powernv_target_index()
- Patch [2] Deleting any pending timer to saves an unnecessary irq call
in powernv_target_index
igned-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
Patch is based on Rafael's linux-next
drivers/cpufreq/powernv-cpufreq.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index 1
When global and local pstate are equal in a powernv_target_index() call,
we don't queue a timer. But we may have timer already queued for future.
This could cause the timer to fire one additional time for no use.
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
Patch is
do without making spinlocks irq safe.
- As the smp_call_function_any() is a blocking call and does not access
global_pstates_info, it could reduce the critcal section by moving
smp_call_function_any() after giving up the lock.
Reported-by: Abdul Haleem
Signed-off-by: Akshay Adiga
---
Pa
When global and local pstate are equal in a powernv_target_index() call,
we don't queue a timer. But we may have timer already queued for future.
This could cause the timer to fire one additional time for no use.
Signed-off-by: Akshay Adiga
---
Patch is based on Rafael's linux-next
drivers
Fixes are based on patch https://patchwork.ozlabs.org/patch/612058/ which
is in Rafael's linux-next.
- Patch [1] fixes WARN_ON in powernv_target_index()
- Patch [2] Deleting any pending timer to saves an unnecessary irq call
in powernv_target_index()
Akshay Adiga (2):
cpufreq: powernv: Move
Fixes are based on patch https://patchwork.ozlabs.org/patch/612058/ which
is in Rafael's linux-next.
- Patch [1] fixes WARN_ON in powernv_target_index()
- Patch [2] Deleting any pending timer to saves an unnecessary irq call
in powernv_target_index()
Akshay Adiga (2):
cpufreq: powernv: Move
Hi Viresh,
On 05/03/2016 05:19 PM, Viresh Kumar wrote:
On 03-05-16, 15:10, Akshay Adiga wrote:
Fixing a WARN_ON caused by smp_call_function_any() when irq is disabled,
because of changes made in the patch
('cpufreq: powernv: Ramp-down global pstate slower than local-pstate')
https
Hi Viresh,
On 05/03/2016 05:19 PM, Viresh Kumar wrote:
On 03-05-16, 15:10, Akshay Adiga wrote:
Fixing a WARN_ON caused by smp_call_function_any() when irq is disabled,
because of changes made in the patch
('cpufreq: powernv: Ramp-down global pstate slower than local-pstate')
https
ed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
Patch is based on Rafael's linux-next
drivers/cpufreq/powernv-cpufreq.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufreq/powernv-cpufreq.c
index 144c732..1f
] [c00cca88] kthread+0x108/0x130
[c007f648fe30] [c00095e8] ret_from_kernel_thread+0x5c/0x74
Moving smp_call_function_any() out of the critical section and changing
irq safe spinlocks to normal spinlocks.
Reported-by: Abdul Haleem
Signed-off-by: Akshay Adiga
---
Patch is based
Deleting pending gpstates->timer for the policy when global and local pstate
are equal while executing target_index(). This saves an unnecessary
irq call.
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
Patch is based on Rafael's linux-next
drivers/cpufreq/powernv-cpuf
Fixes are based on patch https://patchwork.ozlabs.org/patch/612058/ which is
in Rafael's linux-next.
- Patch [1] fixes WARN_ON in powernv_target_index()
- Patch [2] Deleting any pending timer to saves an unnecessary irq call
in powernv_target_index()
Akshay Adiga (2):
cpufreq: powernv: Move
Deleting pending gpstates->timer for the policy when global and local pstate
are equal while executing target_index(). This saves an unnecessary
irq call.
Signed-off-by: Akshay Adiga
---
Patch is based on Rafael's linux-next
drivers/cpufreq/powernv-cpufreq.c | 2 ++
1 file changed, 2 inserti
Fixes are based on patch https://patchwork.ozlabs.org/patch/612058/ which is
in Rafael's linux-next.
- Patch [1] fixes WARN_ON in powernv_target_index()
- Patch [2] Deleting any pending timer to saves an unnecessary irq call
in powernv_target_index()
Akshay Adiga (2):
cpufreq: powernv: Move
v2:
- dropped the unreated change.
Akshay Adiga (1):
cpufreq: powernv: Ramp-down global pstate slower than local-pstate
Shilpasri G Bhat (1):
cpufreq: powernv: Remove flag use-case of policy->driver_data
drivers/cpufreq/powernv-cpufreq.c | 269 --
1 file changed
v2:
- dropped the unreated change.
Akshay Adiga (1):
cpufreq: powernv: Ramp-down global pstate slower than local-pstate
Shilpasri G Bhat (1):
cpufreq: powernv: Remove flag use-case of policy->driver_data
drivers/cpufreq/powernv-cpufreq.c | 269 --
1 file changed
-41.24
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
Reviewed-by: Gautham R. Shenoy <e...@linux.vnet.ibm.com>
Acked-by: Viresh Kumar <viresh.ku...@linaro.org>
---
drivers/cpufreq/powernv-cpufreq.c | 258 --
1 file changed, 25
-41.24
Signed-off-by: Akshay Adiga
Reviewed-by: Gautham R. Shenoy
Acked-by: Viresh Kumar
---
drivers/cpufreq/powernv-cpufreq.c | 258 --
1 file changed, 251 insertions(+), 7 deletions(-)
diff --git a/drivers/cpufreq/powernv-cpufreq.c
b/drivers/cpufr
ck if the attribute already exists. This is required as
policy->driver_data is used for other purposes in the later patch.
Signed-off-by: Shilpasri G Bhat <shilpa.b...@linux.vnet.ibm.com>
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
Acked-by: Viresh Kumar <viresh.k
s is required as
policy->driver_data is used for other purposes in the later patch.
Signed-off-by: Shilpasri G Bhat
Signed-off-by: Akshay Adiga
Acked-by: Viresh Kumar
---
drivers/cpufreq/powernv-cpufreq.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers
Hi Viresh,
On 04/18/2016 03:48 PM, Viresh Kumar wrote:
On 15-04-16, 11:58, Akshay Adiga wrote:
static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb,
- unsigned long action, void *unused)
+ unsigned long
Hi Viresh,
On 04/18/2016 03:48 PM, Viresh Kumar wrote:
On 15-04-16, 11:58, Akshay Adiga wrote:
static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb,
- unsigned long action, void *unused)
+ unsigned long
shows
better MaxLatency with this patch.
Changes from v1:
- Fixed coding style
- Added a routine to reset global_pstate_info instead of hacky memset
- Handled case when cpufreq_table_validate_and_show() fails
- changed int queue_gpstate_timer() to void queue_gpstate_timer()
Akshay Adiga (1):
cpu
ck if the attribute already exists. This is required as
policy->driver_data is used for other purposes in the later patch.
Signed-off-by: Shilpasri G Bhat <shilpa.b...@linux.vnet.ibm.com>
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
---
drivers/cpufreq/powernv-cpufreq.
shows
better MaxLatency with this patch.
Changes from v1:
- Fixed coding style
- Added a routine to reset global_pstate_info instead of hacky memset
- Handled case when cpufreq_table_validate_and_show() fails
- changed int queue_gpstate_timer() to void queue_gpstate_timer()
Akshay Adiga (1):
cpu
s is required as
policy->driver_data is used for other purposes in the later patch.
Signed-off-by: Shilpasri G Bhat
Signed-off-by: Akshay Adiga
---
drivers/cpufreq/powernv-cpufreq.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/cpufreq/powernv-cpuf
-41.24
Signed-off-by: Akshay Adiga <akshay.ad...@linux.vnet.ibm.com>
Reviewed-by: Gautham R. Shenoy <e...@linux.vnet.ibm.com>
---
drivers/cpufreq/powernv-cpufreq.c | 261 --
1 file changed, 252 insertions(+), 9 deletions(-)
diff --git a/drivers/cpu
1 - 100 of 101 matches
Mail list logo