Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-04 Thread Alessandro Zummo
mpatible at all > with the previous implementations? Alexandre is absolutely right. There's no need to rename a driver, it would just piss off people who are used to that name and have it in their scripts. Like when your eth0 gets renamed to some obscure enXXX . -- Best regards, Alessandro Zu

Re: [RESEND PATCH] rtc: rk808: rename rtc-rk808.c to rtc-rk8xx.c

2016-01-04 Thread Alessandro Zummo
XX . -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [PATCH] char: make misc_deregister a void function

2015-07-31 Thread Alessandro Zummo
On Thu, 30 Jul 2015 15:59:57 -0700 Greg Kroah-Hartman wrote: > If the different subsystem maintainers want to give me an ack for this, > I'd appreciate it. I'd like to just take the single patch in through > the char-misc tree in one piece. RTC Acked-by: Alessandro Zummo -

Re: [PATCH] char: make misc_deregister a void function

2015-07-31 Thread Alessandro Zummo
Zummo a.zu...@towertech.it -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [5/5] drivers/rtc/sa1100: Replace deprecated rtc_tm_to_time() and rtc_time_to_tm()

2015-06-03 Thread Alessandro Zummo
On Mon, 1 Jun 2015 21:59:09 +0200 Alexandre Belloni wrote: > I feel that we still have a bit of time before having to hurry and find > a proper solution ;) agreed :) -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towert

Re: [5/5] drivers/rtc/sa1100: Replace deprecated rtc_tm_to_time() and rtc_time_to_tm()

2015-06-03 Thread Alessandro Zummo
On Mon, 1 Jun 2015 21:59:09 +0200 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: I feel that we still have a bit of time before having to hurry and find a proper solution ;) agreed :) -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http

Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

2015-04-01 Thread Alessandro Zummo
reasonable given that pr_fmt is widely used elsewhere. I don't like too much the need to have one define for each file, but it's the way it works :-/ -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list

Re: [rtc-linux] Re: [PATCH 3/3] rtc: hctosys: use function name in the error log

2015-04-01 Thread Alessandro Zummo
that pr_fmt is widely used elsewhere. I don't like too much the need to have one define for each file, but it's the way it works :-/ -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line

Re: [rtc-linux] Re: [PATCH] MAINTAINERS: Add Alexandre Belloni as an RTC maintainer

2015-03-28 Thread Alessandro Zummo
On Sat, 28 Mar 2015 22:29:20 +0100 Alexandre Belloni wrote: > I'll keep that in mind. > Could you give me permissions on the rtc-linux patchwork? Sure. Let me find the way to do it :) -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towert

Re: [rtc-linux] Re: [PATCH] MAINTAINERS: Add Alexandre Belloni as an RTC maintainer

2015-03-28 Thread Alessandro Zummo
On Sat, 28 Mar 2015 22:29:20 +0100 Alexandre Belloni alexandre.bell...@free-electrons.com wrote: I'll keep that in mind. Could you give me permissions on the rtc-linux patchwork? Sure. Let me find the way to do it :) -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino

Re: [PATCH] MAINTAINERS: Add Alexandre Belloni as an RTC maintainer

2015-03-25 Thread Alessandro Zummo
ave multiple wiring configuration and break very easily. -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ker

Re: [PATCH] MAINTAINERS: Add Alexandre Belloni as an RTC maintainer

2015-03-25 Thread Alessandro Zummo
there that are quite rare or have multiple wiring configuration and break very easily. -- Best regards, Alessandro Zummo - CEO, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()

2015-03-19 Thread Alessandro Zummo
On Wed, 18 Mar 2015 10:37:26 -0700 John Stultz wrote: > On Wed, Jan 28, 2015 at 10:27 AM, Alessandro Zummo > wrote: > > On Thu, 29 Jan 2015 00:12:09 +0800 > > Xunlei Pang wrote: > > > >> ping Alessandro > > > > -EBUSY . saw that, looks fine anyh

Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()

2015-03-19 Thread Alessandro Zummo
On Wed, 18 Mar 2015 10:37:26 -0700 John Stultz john.stu...@linaro.org wrote: On Wed, Jan 28, 2015 at 10:27 AM, Alessandro Zummo a.zu...@towertech.it wrote: On Thu, 29 Jan 2015 00:12:09 +0800 Xunlei Pang pang.xun...@linaro.org wrote: ping Alessandro -EBUSY . saw that, looks fine

Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()

2015-03-18 Thread Alessandro Zummo
On Wed, 18 Mar 2015 10:37:26 -0700 John Stultz wrote: > Hey Alessandro, > I was hoping to let these go through you (with your review), but if > you're still too busy I can queue them if you'd rather. Hello, will review today and let you know. -- Best regards, Alessan

Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()

2015-03-18 Thread Alessandro Zummo
, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()

2015-01-28 Thread Alessandro Zummo
On Thu, 29 Jan 2015 00:12:09 +0800 Xunlei Pang wrote: > ping Alessandro -EBUSY . saw that, looks fine anyhow, but would like to have a deeper look. we have still some time 'till 2038, right? ;) -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy h

Re: [RFC PATCH v3 0/8] Provide y2038/y2106 safe rtc_class_ops.set_mmss64()

2015-01-28 Thread Alessandro Zummo
On Thu, 29 Jan 2015 00:12:09 +0800 Xunlei Pang pang.xun...@linaro.org wrote: ping Alessandro -EBUSY . saw that, looks fine anyhow, but would like to have a deeper look. we have still some time 'till 2038, right? ;) -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Alessandro Zummo
On Wed, 14 Jan 2015 23:26:37 +0800 Xunlei Pang wrote: > But on the other hand, we will have no test for set_mmss64(), > because adding the set_mmss64() will make set_mmss() dysfunctional. add a module parameter -- Best regards, Alessandro Zummo, Tower Technologies - Torino,

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Alessandro Zummo
egards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Ple

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Alessandro Zummo
:) -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-14 Thread Alessandro Zummo
On Wed, 14 Jan 2015 23:26:37 +0800 Xunlei Pang pang.xun...@linaro.org wrote: But on the other hand, we will have no test for set_mmss64(), because adding the set_mmss64() will make set_mmss() dysfunctional. add a module parameter -- Best regards, Alessandro Zummo, Tower Technologies

Re: [RFC PATCH v2 6/9] rtc/mxc: Modify rtc_update_alarm() not to touch the alarm time

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:54 +0800 Xunlei Pang wrote: > rtc_class_ops's set_alarm() shouldn't deal with the alarm date, > as this is handled in the rtc core. Please CC the author and ask him. The same applies for the other drivers. -- Best regards, Alessandro Zummo, Tower Techno

Re: [RFC PATCH v2 2/9] time: Provide y2106 safe get_seconds() replacement

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:50 +0800 Xunlei Pang wrote: > -EXPORT_SYMBOL(get_seconds); > +EXPORT_SYMBOL(get_seconds64); Please leave get_seconds untouched -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from thi

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-13 Thread Alessandro Zummo
time64 test driver? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [RFC PATCH v2 4/9] rtc/ab3100: Update driver to address y2038/y2106 issues

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:52 +0800 Xunlei Pang wrote: > From: Xunlei Pang > > This driver has a number of y2038/y2106 issues. This should probably be evaluated by Linus Walleij -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.tow

Re: [RFC PATCH v2 1/9] rtc: Provide y2038 safe rtc_class_ops.set_mmss() replacement

2015-01-13 Thread Alessandro Zummo
only when required for readability. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC PATCH v2 1/9] rtc: Provide y2038 safe rtc_class_ops.set_mmss() replacement

2015-01-13 Thread Alessandro Zummo
for readability. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [RFC PATCH v2 4/9] rtc/ab3100: Update driver to address y2038/y2106 issues

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:52 +0800 Xunlei Pang xlp...@126.com wrote: From: Xunlei Pang pang.xun...@linaro.org This driver has a number of y2038/y2106 issues. This should probably be evaluated by Linus Walleij linus.wall...@stericsson.com -- Best regards, Alessandro Zummo, Tower

Re: [RFC PATCH v2 3/9] rtc/test: Update driver to address y2038/y2106 issues

2015-01-13 Thread Alessandro Zummo
test driver? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [RFC PATCH v2 6/9] rtc/mxc: Modify rtc_update_alarm() not to touch the alarm time

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:54 +0800 Xunlei Pang xlp...@126.com wrote: rtc_class_ops's set_alarm() shouldn't deal with the alarm date, as this is handled in the rtc core. Please CC the author and ask him. The same applies for the other drivers. -- Best regards, Alessandro Zummo, Tower

Re: [RFC PATCH v2 2/9] time: Provide y2106 safe get_seconds() replacement

2015-01-13 Thread Alessandro Zummo
On Tue, 13 Jan 2015 23:44:50 +0800 Xunlei Pang xlp...@126.com wrote: -EXPORT_SYMBOL(get_seconds); +EXPORT_SYMBOL(get_seconds64); Please leave get_seconds untouched -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from

Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-04 Thread Alessandro Zummo
On Thu, 04 Dec 2014 13:29:58 +0100 Stefan Agner wrote: > > Acked-by: Alessandro Zummo > > Through which tree is this going upstream? Andrew usually picks up those small patches, unless there's a more appropriate tree. -- Best regards, Alessandro Zummo, Tower

Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-04 Thread Alessandro Zummo
e clock support but also makes it optional > so Vybrid platform can use the clock if defined > while making sure not to break i.MX . > > Signed-off-by: Sanchayan Maity Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy

Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-04 Thread Alessandro Zummo
the clock support but also makes it optional so Vybrid platform can use the clock if defined while making sure not to break i.MX . Signed-off-by: Sanchayan Maity maitysancha...@gmail.com Acked-by: Alessandro Zummo a.zu...@towertech.it -- Best regards, Alessandro Zummo, Tower

Re: [RESEND PATCHv2] drivers/rtc/rtc-snvs: Add clock support

2014-12-04 Thread Alessandro Zummo
On Thu, 04 Dec 2014 13:29:58 +0100 Stefan Agner ste...@agner.ch wrote: Acked-by: Alessandro Zummo a.zu...@towertech.it Through which tree is this going upstream? Andrew usually picks up those small patches, unless there's a more appropriate tree. -- Best regards, Alessandro

Re: [RFC PATCH 4/4] rtc/imxdi: Update driver to address time issues

2014-11-30 Thread Alessandro Zummo
ose patches will cause headaches to a lot of people. Too many of this stuff seems a copy & paste work, without actually looking/thinking to the side effects. Is there any particular reason your are pursuing this? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy

Re: [RFC PATCH 4/4] rtc/imxdi: Update driver to address time issues

2014-11-30 Thread Alessandro Zummo
patches will cause headaches to a lot of people. Too many of this stuff seems a copy paste work, without actually looking/thinking to the side effects. Is there any particular reason your are pursuing this? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http

Re: [RESEND PATCH v3] rtc: ds1307: add trickle charger device tree binding

2014-09-08 Thread Alessandro Zummo
On Mon, 8 Sep 2014 07:26:57 -0400 Jason Cooper wrote: > Most likely, the rtc maintainer will take the series with the DT > maintainers Acks. You made all the binding changes as discussed by Mark > and I, so fwiw, > > Acked-by: Jason Cooper Acked-by: Alessandro Zummo --

Re: [RESEND PATCH v3] rtc: ds1307: add trickle charger device tree binding

2014-09-08 Thread Alessandro Zummo
-by: Alessandro Zummo a.zu...@towertech.it -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [RFC V1] mfd: da9063: Add support for AD silicon variant

2014-07-16 Thread Alessandro Zummo
ult to > support BB (or greater) silicon. any particular reason for not supporting both at the same time, either with a module option, platform data, dt, etc ? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from th

Re: [RFC V1] mfd: da9063: Add support for AD silicon variant

2014-07-16 Thread Alessandro Zummo
it will default to support BB (or greater) silicon. any particular reason for not supporting both at the same time, either with a module option, platform data, dt, etc ? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from

Re: [rtc-linux] [PATCH] drivers/rtc/interface.c: check the error after __rtc_read_time()

2014-07-04 Thread Alessandro Zummo
; > Signed-off-by: Hyogi Gim Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.ke

Re: [rtc-linux] [PATCH] drivers/rtc/interface.c: check the error after __rtc_read_time()

2014-07-04 Thread Alessandro Zummo
-off-by: Hyogi Gim hyogi@lge.com Acked-by: Alessandro Zummo a.zu...@towertech.it -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH 0/2][RFC] Try to handle hctosys w/ rtc modules

2014-06-30 Thread Alessandro Zummo
sed at boot with a different identifier than rtcX (and move the option to the kernel command line) -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

Re: [PATCH 0/2][RFC] Try to handle hctosys w/ rtc modules

2014-06-30 Thread Alessandro Zummo
identifier than rtcX (and move the option to the kernel command line) -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: rtc/hctosys.c Problem during kernel boot

2014-06-21 Thread Alessandro Zummo
I'm testing them and they're working fine so far. Will handle them the next week. -- Best regards, Alessandro Zummo Tower Technologies Sent from my iPhone, please excuse my brevity. > On 21/giu/2014, at 15:08, Alexander Holler wrote: > > Am 12.06.2014 01:53, schrieb Jo

Re: rtc/hctosys.c Problem during kernel boot

2014-06-21 Thread Alessandro Zummo
I'm testing them and they're working fine so far. Will handle them the next week. -- Best regards, Alessandro Zummo Tower Technologies Sent from my iPhone, please excuse my brevity. On 21/giu/2014, at 15:08, Alexander Holler hol...@ahsoftware.de wrote: Am 12.06.2014 01:53

Re: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-19 Thread Alessandro Zummo
. > > > > I don't know what's the preferred workflow in these cases... > > That's fine. I'm happy to create shared branches when required. mfd tree will be ok. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubs

Re: [PATCH v2 07/10] regulator: Add driver for Maxim 77802 PMIC regulators

2014-06-19 Thread Alessandro Zummo
the preferred workflow in these cases... That's fine. I'm happy to create shared branches when required. mfd tree will be ok. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe

Re: rtc/hctosys.c Problem during kernel boot

2014-06-12 Thread Alessandro Zummo
tosys, I have 3 patches, and 2 more to implement > rtc_read_timeval() for higher resolution clocks. Yes, I know the experience might be a painful one. Please send the patches and let's see if they fix the issue for John too. -- Best regards, Alessandro Zummo, Tower Technologies - Tor

Re: rtc/hctosys.c Problem during kernel boot

2014-06-12 Thread Alessandro Zummo
of hctosys, I have 3 patches, and 2 more to implement rtc_read_timeval() for higher resolution clocks. Yes, I know the experience might be a painful one. Please send the patches and let's see if they fix the issue for John too. -- Best regards, Alessandro Zummo, Tower Technologies - Torino

Re: [rtc-linux] [PATCH] rtc: fix potential race condition and remove build errors

2014-05-19 Thread Alessandro Zummo
On Mon, 19 May 2014 21:28:20 +0530 Raghavendra Ganiga wrote: > also the sysfs will not create entry for alarm if > irq registration fails in probe > > Signed-off-by: Raghavendra Chandra Ganiga Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technolog

Re: [rtc-linux] [PATCH] rtc: fix potential race condition and remove build errors

2014-05-19 Thread Alessandro Zummo
On Mon, 19 May 2014 21:28:20 +0530 Raghavendra Ganiga ravi23gan...@gmail.com wrote: also the sysfs will not create entry for alarm if irq registration fails in probe Signed-off-by: Raghavendra Chandra Ganiga ravi23gan...@gmail.com Acked-by: Alessandro Zummo a.zu...@towertech.it

Re: query regarding not returning error if request_irq fails after rtc registration

2014-05-15 Thread Alessandro Zummo
set_alarm > and alarm_irq_enable can return error since there is no irq handler > for the rtc interrupt > or is there any other solution > or let the set_alarm and alarm_irq_enable routine be as it is and will you can use a flag (or set the irq to -1) -- Best regards, Alessandro Zummo, Tower

Re: query regarding not returning error if request_irq fails after rtc registration

2014-05-15 Thread Alessandro Zummo
the set_alarm and alarm_irq_enable can return error since there is no irq handler for the rtc interrupt or is there any other solution or let the set_alarm and alarm_irq_enable routine be as it is and will you can use a flag (or set the irq to -1) -- Best regards, Alessandro Zummo, Tower

Re: [PATCH] rtc: Add support for Microchip MCP795

2014-05-09 Thread Alessandro Zummo
On Tue, 6 May 2014 19:13:18 +0200 a...@atx.name wrote: > Adds driver for SPI RTC Microchip MCP795. Does only support saving/loading > time from the chip (i. e. no alarms/power events/ID). > > Signed-off-by: Josef Gajdusek Acked-by: Alessandro Zummo -- Best regards, Ales

Re: [PATCH] rtc: Add support for Microchip MCP795

2014-05-09 Thread Alessandro Zummo
On Tue, 6 May 2014 19:13:18 +0200 a...@atx.name wrote: Adds driver for SPI RTC Microchip MCP795. Does only support saving/loading time from the chip (i. e. no alarms/power events/ID). Signed-off-by: Josef Gajdusek a...@atx.name Acked-by: Alessandro Zummo a.zu...@towertech.it -- Best

Re: rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-06 Thread Alessandro Zummo
mentation ok as per your last comment > on the proc interface. please provide the feedback. That's sounds like a plan. Please send the code when you're ready. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe fr

Re: [rtc-linux] Re: X86: Impossible select Enhanced Real Time Clock Support (legacy PC RTC driver)

2014-05-06 Thread Alessandro Zummo
sorry for the delay. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.o

Re: [rtc-linux] [PATCH 1/2] RTC: rtc-cmos: drivers/char/rtc.c features for DECstation support

2014-05-06 Thread Alessandro Zummo
ak anything on non-Alpha machines. Did you test it on x86? It would be fine if we can get a couple of Tested-by: -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

Re: [rtc-linux] [PATCH 1/2] RTC: rtc-cmos: drivers/char/rtc.c features for DECstation support

2014-05-06 Thread Alessandro Zummo
anything on non-Alpha machines. Did you test it on x86? It would be fine if we can get a couple of Tested-by: -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [rtc-linux] Re: X86: Impossible select Enhanced Real Time Clock Support (legacy PC RTC driver)

2014-05-06 Thread Alessandro Zummo
for the delay. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-05-06 Thread Alessandro Zummo
ok as per your last comment on the proc interface. please provide the feedback. That's sounds like a plan. Please send the code when you're ready. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-04-30 Thread Alessandro Zummo
const char *alarm_str, *diodes = "disabled", *resistors = " "; > + > + regmap_read(priv->map, DS1343_CONTROL_REG, ); is this thing really useful? what about having sysfs entries instead? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy

Re: [PATCH] rtc: add support for maxim dallas rtc ds1343 and ds1344

2014-04-30 Thread Alessandro Zummo
*alarm_str, *diodes = disabled, *resistors = ; + + regmap_read(priv-map, DS1343_CONTROL_REG, data); is this thing really useful? what about having sysfs entries instead? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it

Re: X86: Impossible select Enhanced Real Time Clock Support (legacy PC RTC driver)

2014-04-28 Thread Alessandro Zummo
ar as I know, no recent distribution is using the old code anymore and the new (well, not so new anymore) framework provides the same functionality. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: sen

Re: X86: Impossible select Enhanced Real Time Clock Support (legacy PC RTC driver)

2014-04-28 Thread Alessandro Zummo
distribution is using the old code anymore and the new (well, not so new anymore) framework provides the same functionality. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux

Re: [rtc-linux] Re: [PATCH resend] mfd/rtc: s5m: Do not allocate RTC I2C dummy and regmap for unsupported chipsets

2014-04-17 Thread Alessandro Zummo
it to mfd or via another tree / next. The patch looks good to m. Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [rtc-linux] Re: [PATCH resend] mfd/rtc: s5m: Do not allocate RTC I2C dummy and regmap for unsupported chipsets

2014-04-17 Thread Alessandro Zummo
please add it to mfd or via another tree / next. The patch looks good to m. Acked-by: Alessandro Zummo a.zu...@towertech.it -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH V1 2/2] rtc: da9063: RTC driver

2014-04-11 Thread Alessandro Zummo
whole patchset. thanks! -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vge

Re: [PATCH V1 2/2] rtc: da9063: RTC driver

2014-04-11 Thread Alessandro Zummo
patchset. thanks! -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH] RTC: Fix infinite loop in initializing the alarm.

2014-04-08 Thread Alessandro Zummo
year-fixing loop expects the > time being invalid due to leap year. > > Fix reduces the loop to the leap years and adds final validity check. > > Signed-off-by: Ales Novak Seems reasonable. Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technolog

Re: [PATCH] RTC: Fix infinite loop in initializing the alarm.

2014-04-08 Thread Alessandro Zummo
the year-fixing loop expects the time being invalid due to leap year. Fix reduces the loop to the leap years and adds final validity check. Signed-off-by: Ales Novak alno...@suse.cz Seems reasonable. Acked-by: Alessandro Zummo a.zu...@towertech.it -- Best regards, Alessandro Zummo

Re: kernfs/rtc: circular dependency between kernfs and ops_lock

2014-03-31 Thread Alessandro Zummo
trs could be called in the rtc base class, before the device removal? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

Re: kernfs/rtc: circular dependency between kernfs and ops_lock

2014-03-31 Thread Alessandro Zummo
in the probe function, which should not be done. the last patches fixes it. I'll keep trying to trigger the bug on my systems. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubsc

Re: kernfs/rtc: circular dependency between kernfs and ops_lock

2014-03-31 Thread Alessandro Zummo
os->rtc); - hpet_unregister_irq_handler(cmos_interrupt); + + if (is_hpet_enabled()) { + hpet_unregister_irq_handler(cmos_interrupt); + } } rtc_device_unregister(cmos->rtc); -- Best regards, Alessandro Zummo, T

Re: kernfs/rtc: circular dependency between kernfs and ops_lock

2014-03-31 Thread Alessandro Zummo
()) { + hpet_unregister_irq_handler(cmos_interrupt); + } } rtc_device_unregister(cmos-rtc); -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe

Re: kernfs/rtc: circular dependency between kernfs and ops_lock

2014-03-31 Thread Alessandro Zummo
in the probe function, which should not be done. the last patches fixes it. I'll keep trying to trigger the bug on my systems. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux

Re: kernfs/rtc: circular dependency between kernfs and ops_lock

2014-03-31 Thread Alessandro Zummo
could be called in the rtc base class, before the device removal? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org

Re: kernfs/rtc: circular dependency between kernfs and ops_lock

2014-03-25 Thread Alessandro Zummo
any rtc_class_open() users access it again */ - rtc_sysfs_del_device(rtc); rtc_dev_del_device(rtc); rtc_proc_del_device(rtc); device_unregister(>dev); -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.t

Re: kernfs/rtc: circular dependency between kernfs and ops_lock

2014-03-25 Thread Alessandro Zummo
*/ - rtc_sysfs_del_device(rtc); rtc_dev_del_device(rtc); rtc_proc_del_device(rtc); device_unregister(rtc-dev); -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it

Re: [rtc-linux] [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-21 Thread Alessandro Zummo
is a patch to add support for > maxim dallas rtc ds1347 > > Signed-off-by: Raghavendra Chandra Ganiga Acked-by: Alessandro Zummo -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the lin

Re: [rtc-linux] [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-21 Thread Alessandro Zummo
rtc ds1347 This is a patch to add support for maxim dallas rtc ds1347 Signed-off-by: Raghavendra Chandra Ganiga ravi23gan...@gmail.com Acked-by: Alessandro Zummo a.zu...@towertech.it -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Alessandro Zummo
On Thu, 20 Mar 2014 12:19:55 -0700 Joe Perches wrote: > This depends on how long you want to live, but it could be > > while (dt->tm_year >= 100) dt->tm_year % 100 ? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http:

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Alessandro Zummo
>dev, "DS1347 RTC Status Reg = 0x%02x\n", data); > + > + rtc = devm_rtc_device_register(>dev, "ds1347", > + _rtc_ops, THIS_MODULE); > + > + if (IS_ERR(rtc)) > + return PTR_ERR(rtc); > + > + spi_set_dr

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Alessandro Zummo
, +}; + +module_spi_driver(ds1347_driver); + +MODULE_DESCRIPTION(DS1347 SPI RTC DRIVER); +MODULE_AUTHOR(Raghavendra C Ganiga ravi23gan...@gmail.com); +MODULE_LICENSE(GPL); should be GPL v2 as you declared in the comments at the top of the file. -- Best regards, Alessandro Zummo, Tower Technologies

Re: [PATCH] rtc: add support for maxim dallas rtc ds1347

2014-03-20 Thread Alessandro Zummo
On Thu, 20 Mar 2014 12:19:55 -0700 Joe Perches j...@perches.com wrote: This depends on how long you want to live, but it could be while (dt-tm_year = 100) dt-tm_year % 100 ? -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it

Re: [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-07 Thread Alessandro Zummo
On Thu, 6 Mar 2014 16:40:02 + "Opensource [Steve Twiss]" wrote: > Change History: > > Changes made to this driver since previous RFC V1 > Comments by Alessandro Zummo > - http://www.kernelhub.org/?p=2=426327 > - Use return PTR_ERR(rtc->rtc_dev); instead of go

Re: [PATCH V1 2/2] rtc: da9063: RTC driver

2014-03-07 Thread Alessandro Zummo
On Thu, 6 Mar 2014 16:40:02 + Opensource [Steve Twiss] stwiss.opensou...@diasemi.com wrote: Change History: Changes made to this driver since previous RFC V1 Comments by Alessandro Zummo - http://www.kernelhub.org/?p=2msg=426327 - Use return PTR_ERR(rtc-rtc_dev); instead of goto err

Re: [RFC V1 2/2] rtc: da9063: RTC driver

2014-03-05 Thread Alessandro Zummo
+} if the interrupt is mandatory you should request it before registering the rtc device. if it isn't, please return 0. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linu

Re: [RFC V1 2/2] rtc: da9063: RTC driver

2014-03-05 Thread Alessandro Zummo
, please return 0. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: kernfs/rtc: circular dependency between kernfs and ops_lock

2014-02-24 Thread Alessandro Zummo
an't try to delete a sysfs file which acquires a lock > while holding the same lock. Pretty interesting indeed. One option would be to remove the sys files before acquiring the lock. But I wonder if this could lead to other issues. -- Best regards, Alessandro Zummo, Tower Technol

Re: kernfs/rtc: circular dependency between kernfs and ops_lock

2014-02-24 Thread Alessandro Zummo
to delete a sysfs file which acquires a lock while holding the same lock. Pretty interesting indeed. One option would be to remove the sys files before acquiring the lock. But I wonder if this could lead to other issues. -- Best regards, Alessandro Zummo, Tower Technologies - Torino

Re: question about drivers/rtc/rtc-cmos.c

2013-12-27 Thread Alessandro Zummo
say it's an error. Did you got it by hand or with one of your tools? ;) -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

Re: question about drivers/rtc/rtc-cmos.c

2013-12-27 Thread Alessandro Zummo
, I'd say it's an error. Did you got it by hand or with one of your tools? ;) -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: Can someone Ack and queue a patch for RTC subsytem?

2013-12-19 Thread Alessandro Zummo
gt; arch/arm/, and to more readily see and remove code duplication by > drivers. I meant in drivers/rtc but using another tree. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsu

Re: Can someone Ack and queue a patch for RTC subsytem?

2013-12-19 Thread Alessandro Zummo
the best. If the only consumers are mvebu boards, I believe it is correct to route though that tree. imho. -- Best regards, Alessandro Zummo, Tower Technologies - Torino, Italy http://www.towertech.it -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: Can someone Ack and queue a patch for RTC subsytem?

2013-12-19 Thread Alessandro Zummo
selects CONFIG_RTC_INTF_PROC. I know, but that makes the procfs entry a mess. sysfs is the way, > Do you want me to send a v7 w/ the .proc helper removed or leave > things as they are and Ack the patch as is? Unless absolutely needed, I'd prefer if you can remove them or move to s

Re: [rtc-linux] Re: Can someone Ack and queue a patch for RTC subsytem?

2013-12-19 Thread Alessandro Zummo
hem go thru subsystem's tree and, as far as I can see, I saw very relevant comments and fixes in all those years. I'd love to devote more time to Linux but I'd need to find someone that hires me just to do that the whole day :) -- Best regards, Alessandro Zummo, Tower Technologies -

  1   2   3   >