Re: [RFC PATCH v3 0/7] Add virtio_rtc module and related changes

2024-03-13 Thread Alexandre Belloni
iver later on because it is incompatible with some evolution of the subsystem. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [RFC PATCH v3 0/7] Add virtio_rtc module and related changes

2024-03-13 Thread Alexandre Belloni
On 13/03/2024 12:29:38+, David Woodhouse wrote: > On Wed, 2024-03-13 at 12:18 +0100, Alexandre Belloni wrote: > > > > I still don't know anything about virtio but under Linux, an RTC is > > always UTC (or localtime when dual booting but let's not care) and never > >

Re: [RFC PATCH v3 0/7] Add virtio_rtc module and related changes

2024-03-13 Thread Alexandre Belloni
still don't know anything about virtio but under Linux, an RTC is always UTC (or localtime when dual booting but let's not care) and never accounts for leap seconds. Having an RTC and RTC driver behaving differently would be super inconvenient. Why don't you leave this to userspace? I guess I'm still qu

Re: [RFC PATCH v3 7/7] virtio_rtc: Add RTC class driver

2024-03-11 Thread Alexandre Belloni
;> + > >> + viortc_class = > >> + devm_kzalloc(parent_dev, sizeof(*viortc_class), > >> GFP_KERNEL); > >> + if (!viortc_class) > >> + return ERR_PTR(-ENOMEM); > >> + > >> + viortc_class->viortc = viortc; > >> + > >> + rtc = devm_rtc_allocate_device(parent_dev); > >> + if (IS_ERR(rtc)) > >> + return ERR_PTR(PTR_ERR(rtc)); > >> + > >> + viortc_class->rtc = rtc; > >> + > >> + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features); > >> + > >> + rtc->ops = have_alarm ? _class_with_alarm_ops : > >> + _class_no_alarm_ops; > > > > Don't do this, simply clear the alarm feature. > > > > OK (sorry, was obviously very inelegant). > > Best regards, > > Peter -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [RFC PATCH v3 7/7] virtio_rtc: Add RTC class driver

2024-03-08 Thread Alexandre Belloni
_ERR(rtc)) > + return ERR_PTR(PTR_ERR(rtc)); > + > + viortc_class->rtc = rtc; > + > + clear_bit(RTC_FEATURE_UPDATE_INTERRUPT, rtc->features); > + > + rtc->ops = have_alarm ? _class_with_alarm_ops : > + _class_no_alarm_ops; Don't do this, simply clear the alarm feature. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 1/1] rtc: pcf85063: add integrity check

2021-04-19 Thread Alexandre Belloni
the case that default values > will be set on boot? The CCF will disable any clocks that are not used on boot so the clock will be either used and configured or not used and disabled. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

[PATCH 2/3] rtc: pcf8523: add alarm support

2021-04-17 Thread Alexandre Belloni
Alarm support requires unconditionally disabling clock out because it is using the int1 pin. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 181 +- 1 file changed, 180 insertions(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-pcf8523.c b

[PATCH 3/3] rtc: pcf8523: report oscillator failures

2021-04-17 Thread Alexandre Belloni
Report oscillator failures and invalid date/time on RTC_VL_READ. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index feadab8e3bd3

[PATCH 1/3] rtc: pcf8523: remove useless define

2021-04-17 Thread Alexandre Belloni
Drop DRIVER_NAME as it is only used once Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf8523.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/rtc/rtc-pcf8523.c b/drivers/rtc/rtc-pcf8523.c index 5e1e7b2a8c9a..fe3ab41d8326 100644 --- a/drivers/rtc/rtc

[PATCH v2 3/3] rtc: rtc_update_irq_enable: rework UIE emulation

2021-04-17 Thread Alexandre Belloni
of __rtc_set_alarm anymore. Tested-by: Łukasz Stelmach Signed-off-by: Alexandre Belloni --- Changes in v2: - Fix possible deadlock when using UIE emulation (no impact on Łukasz' test) - Remove rc drivers/rtc/interface.c | 34 ++ 1 file changed, 10 insertions

[PATCH v2 2/3] rtc: ds1307: remove flags

2021-04-17 Thread Alexandre Belloni
flags is now unused, drop it. Tested-by: Łukasz Stelmach Reviewed-by: Łukasz Stelmach Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 76d67c419f7d..089509d0a3a0 100644

[PATCH v2 1/3] rtc: ds1307: replace HAS_ALARM by RTC_FEATURE_ALARM

2021-04-17 Thread Alexandre Belloni
The core now has RTC_FEATURE_ALARM for the driver to indicate whether alarms are available. Use that instead of HAS_ALARM to ensure the alarm callbacks are not even called. Tested-by: Łukasz Stelmach Reviewed-by: Łukasz Stelmach Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c

[PATCH] imx-sc: remove .read_alarm

2021-04-17 Thread Alexandre Belloni
The RTC core properly handles RTC without .read_alarm and doesn't use it to set alarms. .read_alarm can be safely dropped. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-imx-sc.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/rtc/rtc-imx-sc.c b/drivers/rtc/rtc-imx

Re: [PATCH] rtc: remove unused function

2021-04-16 Thread Alexandre Belloni
commit: ef062a45ec9c2b6d15ddd9f76f897219334c7cd2 Best regards, -- Alexandre Belloni

Re: [PATCH] rtc: fsl-ftm-alarm: add MODULE_TABLE()

2021-04-16 Thread Alexandre Belloni
On Wed, 14 Apr 2021 10:40:06 +0200, Michael Walle wrote: > The module doesn't load automatically. Fix it by adding the missing > MODULE_TABLE(). Applied, thanks! [1/1] rtc: fsl-ftm-alarm: add MODULE_TABLE() commit: 199bb382375ad1b2178e250f82f6d95f8d6f7709 Best regards, -- Ale

Re: (subset) [PATCH V2 0/4] Add RTC support for PMIC PMK8350

2021-04-16 Thread Alexandre Belloni
ee/bindings/rtc/qcom-pm8xxx-rtc.yaml Applied, thanks! [1/4] rtc: pm8xxx: Add RTC support for PMIC PMK8350 commit: c8f0ca8b7a4b91f637ccd9a55f37dbac73d6f6bf [4/4] dt-bindings: rtc: qcom-pm8xxx-rtc: Add qcom pm8xxx rtc bindings commit: 8138c5f0318c69a878582d2140dac08e6a99880d Best regards, -- Alexandre Belloni

Re: [PATCH 1/1] rtc: pcf85063: fallback to parent of_node

2021-04-16 Thread Alexandre Belloni
uld have been that way from the beginning as you point out. Best regards, -- Alexandre Belloni

Re: [PATCH 1/1] rtc: pcf85063: add integrity check

2021-04-16 Thread Alexandre Belloni
regmap_write(pcf85063->regmap, PCF85063_REG_OFFSET, 0); > + if (err < 0) > + goto err_restore; > + > + err = regmap_write(pcf85063->regmap, PCF85063_REG_RAM, 0); > + if (err < 0) > + goto err_restore; > + I'm not sure I get the use case beca

Re: [PATCH 0/2] m68k: Add Virtual M68k Machine

2021-04-16 Thread Alexandre Belloni
On 16/04/2021 22:26:26+0200, Alexandre Belloni wrote: > On Tue, 23 Mar 2021 23:14:28 +0100, Laurent Vivier wrote: > > The most powerful m68k machine emulated by QEMU is a Quadra 800, > > but this machine is very limited: only 1 GiB of memory and only some > > specific in

Re: [PATCH 0/2] m68k: Add Virtual M68k Machine

2021-04-16 Thread Alexandre Belloni
k: introduce a virtual m68k machine commit: 95631785c64840f3816f7a4cc2ce1a5332f43184 Best regards, -- Alexandre Belloni

Re: [PATCH V2 3/4] dt-bindings: mfd: Convert pm8xxx bindings to yaml

2021-04-16 Thread Alexandre Belloni
| 54 +++ > > > 2 files changed, 54 insertions(+), 100 deletions(-) > > > delete mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.txt > > > create mode 100644 Documentation/devicetree/bindings/mfd/qcom-pm8xxx.yaml > > > > Applied, thank

Re: [PATCH V2 0/4] Add RTC support for PMIC PMK8350

2021-04-13 Thread Alexandre Belloni
/devicetree/bindings/rtc/qcom-pm8xxx-rtc.yaml > This is mostly about the RTC driver but the bindings doc is in mfd. How do you prefer that to be merged? there is no build dependency so I can take 1 and 4 and you could take 2 and 3. Or one of us can take all 4 patches. -- Alexandre Belloni, co-owner and CO

Re: [PATCH 22/24] ARM: at91: sama7: introduce sama7 SoC family

2021-04-08 Thread Alexandre Belloni
On 08/04/2021 17:24:39+0200, Nicolas Ferre wrote: > On 01/04/2021 at 12:24, Claudiu Beznea - M18063 wrote: > > On 01.04.2021 12:38, Claudiu Beznea - M18063 wrote: > > > On 31.03.2021 19:01, Alexandre Belloni wrote: > > > > EXTERNAL EMAIL: Do not click links or op

Re: New 'make dtbs_check W=1' warnings

2021-04-08 Thread Alexandre Belloni
m/coresight.txt is not yaml yet. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 3/3] ARM: at91: Kconfig: select PLL, generic clock and utmi support

2021-04-07 Thread Alexandre Belloni
l "SAMA7G5 family" > depends on ARCH_MULTI_V7 > + select HAVE_AT91_GENERATED_CLK > + select HAVE_AT91_SAM9X60_PLL > + select HAVE_AT91_UTMI Shouldn't that be squashed in 1/3? > select SOC_SAMA7 > help > Select this if you are usi

Re: [PATCH] memory: atmel-sdramc: check of_device_get_match_data() return value

2021-04-07 Thread Alexandre Belloni
45,8 @@ static int atmel_ramc_probe(struct platform_device *pdev) > struct clk *clk; > > caps = of_device_get_match_data(>dev); > + if (!caps) > + return -EINVAL; > > if (caps->has_ddrck) { > clk = devm_clk_get(>dev, &q

Re: [PATCH v2 09/19] dt-bindings: i3c: update i3c.yaml references

2021-04-07 Thread Alexandre Belloni
Update the cross-references accordingly. > > Fixes: 5e4cdca887fd ("dt-bindings: i3c: Convert the bus description to yaml") > Acked-by: Rob Herring Acked-by: Alexandre Belloni > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/devicetree/bindings/i3c/cdns,i3c-master

Re: [PATCH 22/24] ARM: at91: sama7: introduce sama7 SoC family

2021-03-31 Thread Alexandre Belloni
+ "microchip,sama7g5", > + NULL > +}; > + > +DT_MACHINE_START(sama7g5_dt, "Microchip SAMA7G5") > + /* Maintainer: Microchip */ > + .init_machine = sama7_dt_device_init, > + .dt_compat = sama7g5_dt_board_compat, > +MACHINE_END > + > -- > 2.25.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 10/24] ARM: at91: sfrbu: add sfrbu registers definitions for sama7g5

2021-03-31 Thread Alexandre Belloni
Power Mode Control */ > +#define AT91_SFRBU_PD_VALUE_MSK (0x3) GENMASK > +#define AT91_SFRBU_25LDOCR_PD_VALUE(v) ((v) & > AT91_SFRBU_PD_VALUE_MSK) /* LDOANA Pull-down value */ this macro is not necessary, you can use FIELD_PREP with the previous define. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 01/24] ARM: at91: pm: move pm_bu to soc_pm data structure

2021-03-31 Thread Alexandre Belloni
On 31/03/2021 13:58:45+0300, Claudiu Beznea wrote: > Move pm_bu to soc_pm data structure. > > Signed-off-by: Claudiu Beznea Reviewed-by: Alexandre Belloni > --- > arch/arm/mach-at91/pm.c | 34 +- > 1 file changed, 21 insertions(+), 13 dele

[PATCH 3/3] rtc: rtc_update_irq_enable: rework UIE emulation

2021-03-29 Thread Alexandre Belloni
of __rtc_set_alarm anymore. Signed-off-by: Alexandre Belloni --- drivers/rtc/interface.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c index dcb34c73319e..b162964d2b39 100644 --- a/drivers/rtc

[PATCH 2/3] rtc: ds1307: remove flags

2021-03-29 Thread Alexandre Belloni
flags is now unused, drop it. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/rtc/rtc-ds1307.c b/drivers/rtc/rtc-ds1307.c index 76d67c419f7d..089509d0a3a0 100644 --- a/drivers/rtc/rtc-ds1307.c +++ b/drivers/rtc/rtc

[PATCH 1/3] rtc: ds1307: replace HAS_ALARM by RTC_FEATURE_ALARM

2021-03-29 Thread Alexandre Belloni
The core now has RTC_FEATURE_ALARM for the driver to indicate whether alarms are available. Use that instead of HAS_ALARM to ensure the alarm callbacks are not even called. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1307.c | 42 +++- 1 file

Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-29 Thread Alexandre Belloni
__rtc_set_alarm() the > same way it is being done in ds1337_set_alarm(). What are your thoughts? > I did introduce RTC_FEATURE_ALARM for that in v5.12. I'm sending patches that are not well tested but should solve your issue. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH 0/4] rtc:abx80x: Enable distributed digital calibration

2021-03-28 Thread Alexandre Belloni
ure per se. The SQW > output must be enabled for usage of this feature. Please use the .set_offset and .get_offset rtc_ops for this part. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [RESEND 1/1] arch: arm: mach-at91: pm: Move prototypes to mutually included header

2021-03-26 Thread Alexandre Belloni
On 26/03/2021 18:18:04+0100, Alexandre Belloni wrote: > On Wed, 3 Mar 2021 12:41:49 +, Lee Jones wrote: > > Both the caller and the supplier's source file should have access to > > the include file containing the prototypes. > > > > Fixes the following

Re: [RESEND 1/1] arch: arm: mach-at91: pm: Move prototypes to mutually included header

2021-03-26 Thread Alexandre Belloni
issing-prototypes] > 1661 | void at91_pinctrl_gpio_resume(void) > | ^~~~ Applied, thanks! [1/1] arch: arm: mach-at91: pm: Move prototypes to mutually included header commit: 10e9119e865047f4e22cbd69de991d6bc26c4faf Best regards, -- Alexandre Belloni

Re: [PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-25 Thread Alexandre Belloni
x86 still needs it. I'll work on that. Again, the patch is fine as is. Reviewed-by: Alexandre Belloni -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH V3 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Alexandre Belloni
> diff --git a/arch/powerpc/platforms/chrp/time.c > b/arch/powerpc/platforms/chrp/time.c > index acde7bbe0716..b94dfd5090d8 100644 > --- a/arch/powerpc/platforms/chrp/time.c > +++ b/arch/powerpc/platforms/chrp/time.c > @@ -30,8 +30,6 @@ > > #include > > -extern spinlock_t rtc_lock; > - > #define NVRAM_AS0 0x74 > #define NVRAM_AS1 0x75 > #define NVRAM_DATA 0x77 > -- > 2.17.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-24 Thread Alexandre Belloni
On 24/03/2021 09:19:58+0100, Geert Uytterhoeven wrote: > Hi Alexandre, > > On Tue, Mar 23, 2021 at 11:18 PM Alexandre Belloni > wrote: > > On 23/03/2021 05:12:57-0400, He Ying wrote: > > > We found these warnings in arch/powerpc/kernel/time.c as follows: > > &

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread Alexandre Belloni
On 23/03/2021 23:18:17+0100, Alexandre Belloni wrote: > Hello, > > On 23/03/2021 05:12:57-0400, He Ying wrote: > > We found these warnings in arch/powerpc/kernel/time.c as follows: > > warning: symbol 'decrementer_max' was not declared. Should it be static? > >

Re: [PATCH v2 -next] powerpc: kernel/time.c - cleanup warnings

2021-03-23 Thread Alexandre Belloni
n_unlock_irq(_lock); > + spin_unlock_irq(_rtc_lock); > return 0; > } > > @@ -296,7 +296,7 @@ static int rtc_probe(struct platform_device *pdev) > rtc->range_max = (1ULL << 33) - 1; > rtc->max_user_freq = MAX_PERIODIC_RATE; > > - spin_lock_irq(_lock); > + spin_lock_irq(_rtc_lock); > > rtc1_write(ECMPLREG, 0); > rtc1_write(ECMPMREG, 0); > @@ -304,7 +304,7 @@ static int rtc_probe(struct platform_device *pdev) > rtc1_write(RTCL1LREG, 0); > rtc1_write(RTCL1HREG, 0); > > - spin_unlock_irq(_lock); > + spin_unlock_irq(_rtc_lock); > > aie_irq = platform_get_irq(pdev, 0); > if (aie_irq <= 0) { > -- > 2.17.1 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] dt-bindings: i3c: Fix silvaco,i3c-master-v1 compatible string

2021-03-23 Thread Alexandre Belloni
5db9c8 Best regards, -- Alexandre Belloni

Re: [PATCH v5] rtc: rx6110: add ACPI bindings to I2C

2021-03-23 Thread Alexandre Belloni
KP by just mentioning > > it in the comments section (after the cutter '---' line). I'll leave > > this to Alexandre and Alessandro to decide if you need a resend or > > they may remove it when applying. (In my opinion resend is not needed > > right now) > Ok. Thanks a

Re: [PATCH v5] rtc: rx6110: add ACPI bindings to I2C

2021-03-23 Thread Alexandre Belloni
egards, -- Alexandre Belloni

Re: [PATCH -next] phy: sparx5_serdes: Fix return value check in sparx5_serdes_probe()

2021-03-18 Thread Alexandre Belloni
n", > iores->name); > - return PTR_ERR(iomem); > + return -ENOMEM; > } A better fix would use devm_platform_ioremap_resource and get rid of the error messages > for (idx = 0; idx < ARRAY_SIZE(sparx5_serdes_ioma

Re: [PATCH] MIPS: generic: use true and false for bool variable

2021-03-17 Thread Alexandre Belloni
l coccinelle script submission doesn't give any good reason. bool in Linux is _Bool and, as per C99, it holds either 0 or 1, not true or false. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] dt-bindings: Clean-up undocumented compatible strings

2021-03-17 Thread Alexandre Belloni
c: Sam Ravnborg > Cc: Vinod Koul > Cc: Alexandre Belloni > Cc: Jonathan Cameron > Cc: Pavel Machek > Cc: Kishon Vijay Abraham I > Cc: Sebastian Reichel > Cc: Mark Brown > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kernel.org > Cc: dmaeng...@vger.kernel.org > Cc: l

Re: [PATCH] rtc: ds1307: set uie_unsupported if no interrupt is available

2021-03-16 Thread Alexandre Belloni
On 16/03/2021 13:12:08+0100, Lukasz Stelmach wrote: > It was <2021-03-15 pon 23:01>, when Alexandre Belloni wrote: > > Hello, > > > > On 05/03/2021 18:44:11+0100, Łukasz Stelmach wrote: > >> For an RTC without an IRQ assigned rtc_update_irq_enable() should

Re: [PATCH] rtc: rv3028: correct weekday register usage

2021-03-15 Thread Alexandre Belloni
e commit: 6e00b6d0083ea5f529b057e87c0236747871b6a8 Best regards, -- Alexandre Belloni

Re: [PATCH] rtc: cmos: Disable irq around direct invocation of cmos_interrupt()

2021-03-15 Thread Alexandre Belloni
hard IRQ") > > Sigh. I wish people would at least try to check the code/history > before doing these blind "cleanups" :( > Sorry I didn't catch that when applying. I'm usually more wary when getting those kind of cleanups. -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH] rtc: cmos: Disable irq around direct invocation of cmos_interrupt()

2021-03-15 Thread Alexandre Belloni
775): [] > asm_sysvec_apic_timer_interrupt+0x12/0x20 > <4>[ 254.193023] hardirqs last disabled at (43774): [] > sysvec_apic_timer_interrupt+0xa/0xb0 > <4>[ 254.193049] softirqs last enabled at (42548): [] > __do_softirq+0x342/0x48e > <4>[ 254.193074] softirqs last disabled at (42543): [] > irq_exit_rcu+0xad/0xd0 > <4>[ 254.193101] > other info that might help us debug this: > <4>[ 254.193107] Possible unsafe locking scenario: > > [...] Applied, thanks! [1/1] rtc: cmos: Disable irq around direct invocation of cmos_interrupt() commit: bd5aa93d615cac77d991c448b986761e7a8d Best regards, -- Alexandre Belloni

Re: [PATCH] rtc: tps65910: include linux/property.h

2021-03-15 Thread Alexandre Belloni
esent' [-Werror,-Wimplicit-function-declaration] Applied, thanks! [1/1] rtc: tps65910: include linux/property.h commit: 936d3685e62436a378f02b8b74759b054d4aeca1 Best regards, -- Alexandre Belloni

Re: [PATCH v9 2/4] pinctrl: pinmux: Add pinmux-select debugfs file

2021-03-13 Thread Alexandre Belloni
e bus core. On what bus are those SIMs? (I guess the answer will be UART and then unfortunately UARTs are not represented as busses). -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: rtc: rtc-m48t59: rtc-m48t59.0: IRQ index 0 not found

2021-03-11 Thread Alexandre Belloni
ier kernel (tested 4.9.260, > 4.19.179 and 4.14.224). > > Does this Input/output error is normal ? (I think no) This is due to 7723f4c5ecdb8d832f049f8483beb0d1081cedf6 Can you try that? >From 55cc33fab5ac9f7e2a97aa7c564e8b35355886d5 Mon Sep 17 00:00:00 2001 From: Alexandre Belloni Date: T

Re: [GIT PULL] Immutable branch between MFD, PWM and RTC due for the v5.13 merge window

2021-03-10 Thread Alexandre Belloni
we accept that > these few patches are based on -rc1. For the latter it would be > beneficial to merge the tag into a tree that is already based on -rc2. > The solution is simply for the maintainers merging the immutable branch to do that in a branch based on -rc2. Eg. I've rebased r

Re: [PATCH RESEND][next] i3c: master: cdns: Fix fall-through warnings for Clang

2021-03-05 Thread Alexandre Belloni
ster *master) > > case IBIR_TYPE_MR: > WARN_ON(IBIR_XFER_BYTES(ibir) || (ibir & IBIR_ERROR)); > + break; > + > default: > break; > } > -- > 2.27.0 > -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH][next] i3c: master: svc: remove redundant assignment to cmd->read_len

2021-03-04 Thread Alexandre Belloni
svc: remove redundant assignment to cmd->read_len commit: 437f5e2af73081ec08ec5d73d82c650377a4bb17 Best regards, -- Alexandre Belloni

Re: [RESEND 1/1] arch: arm: mach-at91: pm: Move prototypes to mutually included header

2021-03-03 Thread Alexandre Belloni
1661 | void at91_pinctrl_gpio_resume(void) > | ^~~~ > > Cc: Russell King > Cc: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Ludovic Desroches > Signed-off-by: Lee Jones I'm pretty sure you had my ack on v3 ;) Acked-by: Alexandre Belloni

Re: [PATCH v7 3/3] arm64: dts: reset: add microchip sparx5 switch reset driver

2021-03-03 Thread Alexandre Belloni
On 03/03/2021 09:11:58+0100, Steen Hegelund wrote: > This provides reset driver support for the Microchip Sparx5 PCB134 and > PCB135 reference boards. > > Signed-off-by: Steen Hegelund Reviewed-by: Alexandre Belloni > --- > arch/arm64/boot/dts/microchip/sparx5.dtsi | 7

Re: [PATCH v7 2/3] reset: mchp: sparx5: add switch reset driver

2021-03-03 Thread Alexandre Belloni
h Core reset that is needed. > > The driver has protection so that the system busses, DDR controller, PCI-E > and ARM A53 CPU and a few other subsystems are not touched by the reset. > > Signed-off-by: Steen Hegelund Reviewed-by: Alexandre Belloni > --- > drivers/reset/Kconfig

Re: [PATCH v6 2/3] reset: mchp: sparx5: add switch reset driver

2021-02-25 Thread Alexandre Belloni
t; +static int mchp_sparx5_map_io(struct platform_device *pdev, char *name, > + struct regmap **target) > +{ > + struct resource *res; > + struct regmap *map; > + void __iomem *mem; > + > + res = platform_get_resource_byname(pdev, IO

Re: watchdog: pcf2127: systemd fails on 5.11

2021-02-24 Thread Alexandre Belloni
al test shows that spin_lock_irqsave around regmap calls are not > a good idea as it result in: > BUG: scheduling while atomic: watchdog/70/0x0002 > BUG: scheduling while atomic: systemd/1/0x0002 > The issue is not only regmap but the fact that i2C and spi accesses are allowed to

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Alexandre Belloni
On 22/02/2021 22:20:47+0100, Alexandre Belloni wrote: > On 22/02/2021 18:12:42+0100, Sebastian Reichel wrote: > > Congatec's QMX6 system on module (SoM) uses a m41t62 as RTC. The > > modules SQW clock output defaults to 32768 Hz. This behaviour is > > used to provide the i

Re: [PATCHv1 1/6] rtc: m41t80: add support for protected clock

2021-02-22 Thread Alexandre Belloni
ware limitations and is > described in Documentation/devicetree/bindings/clock/clock-bindings.txt. > > Signed-off-by: Sebastian Reichel Acked-by: Alexandre Belloni > --- > Documentation/devicetree/bindings/rtc/rtc-m41t80.txt | 1 + > drivers/rtc/rtc-m41t80.c

[GIT PULL] RTC for 5.12

2021-02-21 Thread Alexandre Belloni
- replace spin_lock_irqsave with spin_lock in hard IRQ - pcf2127: disable Power-On Reset Override and run OTP refresh Alexandre Belloni (58): rtc: opal: set range rtc: introduce features bitfield rtc: pl031: use

[GIT PULL] I3C changes for 5.12

2021-02-21 Thread Alexandre Belloni
/bindings/i3c/i3c.yaml create mode 100644 Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml create mode 100644 drivers/i3c/master/svc-i3c-master.c -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [bug] RTC alarm vs system suspend race condition

2021-02-18 Thread Alexandre Belloni
mt+0x64/0xc0) > [] (warn_slowpath_fmt) from [] > (tps6586x_irq_sync_unlock+0x6c/0x70) > [] (tps6586x_irq_sync_unlock) from [] > (__disable_irq_nosync+0x58/0x88) > [] (__disable_irq_nosync) from [] (disable_irq+0xc/0x20) > [] (disable_irq) from [] > (tps6586x_rtc_alarm_irq_enable+0x4c/0x58) > [] (tps6586x_rtc_alarm_irq_enable) from [] > (rtc_timer_do_work+0xfc/0x1dc) > [] (rtc_timer_do_work) from [] > (process_one_work+0x1e8/0x44c) > [] (process_one_work) from [] (worker_thread+0x64/0x5a8) > [] (worker_thread) from [] (kthread+0x148/0x14c) > [] (kthread) from [] (ret_from_fork+0x14/0x24) > Exception stack(0xc59d5fb0 to 0xc59d5ff8) > 5fa0: > 5fc0: > 5fe0: 0013 > ---[ end trace f97d91a3f84ea22d ]--- -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v5 1/3] dt-bindings: reset: microchip sparx5 reset driver bindings

2021-02-15 Thread Alexandre Belloni
ble > + - reg > + - reg-names > + - "#reset-cells" > + > +additionalProperties: false > + > +examples: > + - | > +reset: reset-controller@0 { > +compatible = "microchip,sparx5-switch-reset"; > +#reset-cells = <1>; > +reg = <0x0 0xd0>, > + <0x1101 0x1>; > +reg-names = "cpu", "gcb"; > +}; > + > -- > 2.30.0 > -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: (subset) [v2 1/2] rtc: pcf2127: properly set flag WD_CD for rtc chips(pcf2129, pca2129)

2021-02-13 Thread Alexandre Belloni
our first version, after renaming has_nvmem. Best regards, -- Alexandre Belloni

Re: [PATCH] pinctrl: PINCTRL_MICROCHIP_SGPIO should depend on ARCH_SPARX5 || SOC_VCOREIII

2021-02-10 Thread Alexandre Belloni
ically desired configuration. > > > > Could you add CONFIG_PCI to the || chain? > > Sure. > > Is PCIe the only other transport over which the register can be accessed? > Or can this also be done over e.g. SPI, like on Ocelot[1]? > > [1] https://lore.kernel.org/linux-gpio/20200511145329.gv34...@piout.net/ > Yes, this driver IP is also available on Ocelot (this is SOC_VCOREIII) so this is also available over SPI. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

[GIT PULL] I3C fixes for 5.11

2021-02-09 Thread Alexandre Belloni
(+), 1 deletion(-) -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [GIT PULL 2/3] ARM: dts: samsung: DTS for v5.12

2021-02-08 Thread Alexandre Belloni
On 08/02/2021 23:14:02+0100, Arnd Bergmann wrote: > On Mon, Feb 8, 2021 at 10:35 PM Alexandre Belloni > wrote: > > On 08/02/2021 20:52:37+0100, Arnd Bergmann wrote: > > > On Mon, Feb 8, 2021 at 7:42 PM Krzysztof Kozlowski > > > wrote: > > > > Let me ste

Re: WARNING in mc1NUM_get_time

2021-02-08 Thread Alexandre Belloni
000 > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkal...@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [GIT PULL 2/3] ARM: dts: samsung: DTS for v5.12

2021-02-08 Thread Alexandre Belloni
ny platforms with the dtb built into the firmware? I feel like this is a mythical creature used to scare people into keeping the DTB ABI stable. Aren't all the distribution already able to cope with keeping DTB and kernel in sync? -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com

Re: [PATCH v2 1/2] iio: hid-sensors: Move get sensitivity attribute to hid-sensor-common

2021-02-06 Thread Alexandre Belloni
ultiple drivers to get attribute info for sensitivity > field. Moving this to common place will avoid code repetition. > > Signed-off-by: Ye Xiang Acked-by: Alexandre Belloni > --- > drivers/iio/accel/hid-sensor-accel-3d.c | 23 ++--- > .../hid-sensors/h

Re: [PATCH 0/6] spin lock usage optimization for RTC drivers

2021-02-05 Thread Alexandre Belloni
5aaf53b76fd594dad2661ffe [5/6] rtc: mxc: Replace spin_lock_irqsave with spin_lock in hard IRQ commit: 3f2d30184773e408c4e6f9e15c350828e482480c [6/6] rtc: mxc_v2: Replace spin_lock_irqsave with spin_lock in hard IRQ commit: 0c1095d334dafda22463454b0519c926447b555e Best regards, -- Alexandre Belloni

[tip: timers/core] alarmtimer: Update kerneldoc

2021-02-05 Thread tip-bot2 for Alexandre Belloni
The following commit has been merged into the timers/core branch of tip: Commit-ID: b5c28ea601b801d0ecd5ec703b8d54f77bfe5365 Gitweb: https://git.kernel.org/tip/b5c28ea601b801d0ecd5ec703b8d54f77bfe5365 Author:Alexandre Belloni AuthorDate:Tue, 02 Feb 2021 02:34:57 +01:00

Re: [PATCH] drivers: soc: atmel: fix type for same7

2021-02-04 Thread Alexandre Belloni
s: soc: atmel: add per soc id and version match > masks") > Signed-off-by: Arnd Bergmann Acked-by: Alexandre Belloni > --- > It is broken in the soc tree at the moment, I can pick up > the fix directly if I get an Ack > --- > drivers/soc/atmel/soc.c | 2 +- > 1 file change

[PATCH RESEND v2] ARM: dts: lpc32xx: Revert set default clock rate of HCLK PLL

2021-02-03 Thread Alexandre Belloni
and finally reparent ARM_CLK, DDRAM_CLK, PERIPH_CLK to HCLK PLL. Currently, the HCLK driver simply updates the registers but this has no real effect and all the clock rate calculation end up being wrong. This is especially annoying for the peripheral (e.g. UARTs, I2C, SPI). Signed-off-by: Alexandre

Re: [PATCH] drivers: rtc: Make xilinx zynqmp driver depend on HAS_IOMEM

2021-02-02 Thread Alexandre Belloni
sconfig, > even though it won't build. > > [...] Applied, thanks! [1/1] drivers: rtc: Make xilinx zynqmp driver depend on HAS_IOMEM commit: ddd0521549a975e6148732d6ca6b89ffa862c0e5 Best regards, -- Alexandre Belloni

[PATCH 1/2] rtc: s3c: stop setting bogus time

2021-02-02 Thread Alexandre Belloni
It doesn't make sense to set the RTC to a default value at probe time. Let the core handle invalid date and time. Also, this is basically dead code since commit 22652ba72453 ("rtc: stop validating rtc_time in .read_time") Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-

[PATCH 2/2] rtc: s3c: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-s3c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index f07b0c43aafe..e57d3ca70a78 100644

[PATCH 01/21] rtc: class: remove bogus documentation

2021-02-02 Thread Alexandre Belloni
rtc_device_unregister is gone since commit fdcfd854333b ("rtc: rework rtc_register_device() resource management"). Remove its documentation. Signed-off-by: Alexandre Belloni --- drivers/rtc/class.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/rtc/class.c b/drivers/r

[PATCH 00/21] rtc: remove make W=1 warnings

2021-02-02 Thread Alexandre Belloni
Hi, This series removes some make W=1 warning, especially when CONFIG_OF is not defined. Alexandre Belloni (21): rtc: class: remove bogus documentation rtc: armada38x: depend on OF rtc: bq32k: quiet maybe-unused variable warning rtc: brcmstb-waketimer: quiet maybe-unused variable warning

[PATCH 03/21] rtc: bq32k: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-bq32k.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c index 933e4237237d..2235c968842d 100644

[PATCH 1/2] rtc: rv3028: fix PORF handling

2021-02-02 Thread Alexandre Belloni
The PORF bit is cleared on interrupts which prevents the driver to know when the time and date are invalid. Stop clearing PORF in the interrupt handler. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3028.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/rtc/rtc-rv3028.c b

[PATCH 07/21] rtc: ds3232: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds3232.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index 535e4a88fbb6..168bc27f1f5a 100644

[PATCH 2/2] rtc: rv3028: remove useless warning messages

2021-02-02 Thread Alexandre Belloni
Remove voltage low messages as userspace has a proper way to get the information and react on it. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3028.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c index

[PATCH 06/21] rtc: ds1672: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1672.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1672.c b/drivers/rtc/rtc-ds1672.c index 630493759d15..4cd8efbef6cf 100644

[PATCH 08/21] rtc: isl1208: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-isl1208.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-isl1208.c b/drivers/rtc/rtc-isl1208.c index 563a6d9c9fcf..182dfa605515 100644

[PATCH 10/21] rtc: meson: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-meson.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c index 8642c06565ea..44bdc8b4a90d 100644

[PATCH 11/21] rtc: pcf85063: quiet maybe-unused variable warnings

2021-02-02 Thread Alexandre Belloni
pcf85063a_config and rv8263_config are only referenced by pcf85063_of_match, move them in the #ifdef CONFIG_OF section. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-pcf85063.c | 38 +++--- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git

[PATCH 13/21] rtc: rs5c372: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rs5c372.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c index 3bd6eaa0dcf6..80980414890c 100644

[PATCH 17/21] rtc: rv8803: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv8803.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c index 8821264e9385..72adef5a5ebe 100644

[PATCH 14/21] rtc: rv3028: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3028.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv3028.c b/drivers/rtc/rtc-rv3028.c index 2ee2afa3fa66..0c48d980d06a 100644

[PATCH 21/21] rtc: sd3078: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-sd3078.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-sd3078.c b/drivers/rtc/rtc-sd3078.c index f6bee69ba017..24e8528e23ec 100644

[PATCH 15/21] rtc: rv3029: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3029c2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv3029c2.c b/drivers/rtc/rtc-rv3029c2.c index 71102c7fbd7d..8cb84c9595fc

[PATCH 16/21] rtc: rv3032: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rv3032.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rv3032.c b/drivers/rtc/rtc-rv3032.c index 5161016bce00..d63102d5cb1e 100644

[PATCH 19/21] rtc: rx8581: quiet maybe-unused variable warning

2021-02-02 Thread Alexandre Belloni
When CONFIG_OF is disabled then the matching table is not referenced. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx8581.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index de109139529b..aed4898a0ff4 100644

  1   2   3   4   5   6   7   8   9   10   >