Re: [PATCH 0/4] bug fixes in ntb_hw_amd and ntb_perf

r XLAT registers > NTB: ntb_perf: Clear stale values in doorbell and command SPAD > register > NTB: ntb_hw_amd: set peer limit register This series, Acked-by: Allen Hubbe > > drivers/ntb/hw/amd/ntb_hw_amd.c | 8 > drivers/ntb/test/ntb_perf.c | 14 +++-

Re: [PATCH] ntb: ntb_transport: Mark expected switch fall-throughs

("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Acked-by: Allen Hubbe > --- > drivers/ntb/ntb_transport.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c > index 9398959..c643b9c 10

Re: [PATCH] ntb: ntb_transport: Mark expected switch fall-throughs

("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Acked-by: Allen Hubbe > --- > drivers/ntb/ntb_transport.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c > index 9398959..c643b9c 10

Re: [PATCH v2 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

t can be addressed when there is renued interest in making things work more than one peer. This patch, and the others in this series: Acked-by: Allen Hubbe

Re: [PATCH v2 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

t can be addressed when there is renued interest in making things work more than one peer. This patch, and the others in this series: Acked-by: Allen Hubbe

Re: [PATCH v2 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

On Mon, Jul 23, 2018 at 12:08 PM Logan Gunthorpe wrote: > I don't think you'll ever have a case where two peers have the same > index, as the index is really an abstract concept the hardware doesn't > really know about. That is the point of index, that there should never be two peers with the

Re: [PATCH v2 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

On Mon, Jul 23, 2018 at 12:08 PM Logan Gunthorpe wrote: > I don't think you'll ever have a case where two peers have the same > index, as the index is really an abstract concept the hardware doesn't > really know about. That is the point of index, that there should never be two peers with the

Re: [PATCH v2 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

On Fri, Jul 20, 2018 at 2:00 PM Logan Gunthorpe wrote: > > This commit fixes pingpong support for existing drivers that do not > implement ntb_default_port_number() and ntb_default_peer_port_number(). > This is required for hardware (like the crosslink topology of > switchtec) which cannot assign

Re: [PATCH v2 4/8] NTB: ntb_pingpong: Choose doorbells based on port number

On Fri, Jul 20, 2018 at 2:00 PM Logan Gunthorpe wrote: > > This commit fixes pingpong support for existing drivers that do not > implement ntb_default_port_number() and ntb_default_peer_port_number(). > This is required for hardware (like the crosslink topology of > switchtec) which cannot assign

Re: [PATCH 0/8] Fix breakage caused by the NTB multi-port patchset

equire one more memory window than number of peers > NTB: perf: Fix support for hardware that doesn't have port numbers > NTB: perf: Fix race condition when run with ntb_test > NTB: ntb_test: Fix bug when counting remote files Thanks Logan. Series: Acked-by: Allen Hubbe > >

Re: [PATCH 0/8] Fix breakage caused by the NTB multi-port patchset

equire one more memory window than number of peers > NTB: perf: Fix support for hardware that doesn't have port numbers > NTB: perf: Fix race condition when run with ntb_test > NTB: ntb_test: Fix bug when counting remote files Thanks Logan. Series: Acked-by: Allen Hubbe > >

[PATCH] MAINTAINERS: NTB: Update contact info

I am no longer employed by Dell EMC. For the purposes of NTB driver development and maintenance, please contact me via my personal email. Signed-off-by: Allen Hubbe <alle...@gmail.com> Signed-off-by: Allen Hubbe <allen.hu...@emc.com> --- MAINTAINERS | 2 +- 1 file changed, 1 ins

[PATCH] MAINTAINERS: NTB: Update contact info

I am no longer employed by Dell EMC. For the purposes of NTB driver development and maintenance, please contact me via my personal email. Signed-off-by: Allen Hubbe Signed-off-by: Allen Hubbe --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b

RE: [PATCH 2/2] ntb_hw_switchtec: Check for alignment of the buffer in mw_set_trans()

From: Logan Gunthorpe > On 11/12/17 12:17 PM, Allen Hubbe wrote: > >> mw_get_align doesn't communicate the fact that the buffer has to be > >> aligned by its size. > > > > Is that not the purpose of the addr_align out parameter of > > ntb_mw_get_align(

RE: [PATCH 2/2] ntb_hw_switchtec: Check for alignment of the buffer in mw_set_trans()

From: Logan Gunthorpe > On 11/12/17 12:17 PM, Allen Hubbe wrote: > >> mw_get_align doesn't communicate the fact that the buffer has to be > >> aligned by its size. > > > > Is that not the purpose of the addr_align out parameter of > > ntb_mw_get_align(

RE: [PATCH 2/2] ntb_hw_switchtec: Check for alignment of the buffer in mw_set_trans()

From: Logan Gunthorpe > mw_get_align doesn't communicate the fact that the buffer has to be > aligned by its size. Is that not the purpose of the addr_align out parameter of ntb_mw_get_align()? > It may also be that all hardware does not have this > restriction (ie. if the hardware adds to the

RE: [PATCH 2/2] ntb_hw_switchtec: Check for alignment of the buffer in mw_set_trans()

From: Logan Gunthorpe > mw_get_align doesn't communicate the fact that the buffer has to be > aligned by its size. Is that not the purpose of the addr_align out parameter of ntb_mw_get_align()? > It may also be that all hardware does not have this > restriction (ie. if the hardware adds to the

RE: [PATCH 2/2] ntb_hw_switchtec: Check for alignment of the buffer in mw_set_trans()

From: Logan Gunthorpe > With Switchtec hardware, the buffer used for a memory window must be > aligned to its size (the hardware only replaces the lower bits). In > certain circumstances dma_alloc_coherent() will not provide a buffer > that adheres to this requirement like when using the CMA and >

RE: [PATCH 2/2] ntb_hw_switchtec: Check for alignment of the buffer in mw_set_trans()

From: Logan Gunthorpe > With Switchtec hardware, the buffer used for a memory window must be > aligned to its size (the hardware only replaces the lower bits). In > certain circumstances dma_alloc_coherent() will not provide a buffer > that adheres to this requirement like when using the CMA and >

RE: [PATCH 1/2] ntb_transport: Fix bug with max_mw_size parameter

ize in > ntb_transport_init_queue(). > > Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers") > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Cc: Jon Mason <jdma...@kudzu.us> > Cc: Dave Jiang <dave.ji...@intel.com> >

RE: [PATCH 1/2] ntb_transport: Fix bug with max_mw_size parameter

ize in > ntb_transport_init_queue(). > > Fixes: e26a5843f7f5 ("NTB: Split ntb_hw_intel and ntb_transport drivers") > Signed-off-by: Logan Gunthorpe > Cc: Jon Mason > Cc: Dave Jiang > Cc: Allen Hubbe Acked-by: Allen Hubbe > --- > drivers/ntb/ntb_transport.c |

RE: [PATCH v2 00/15] NTB: Add full multi-port API support to the test drivers

f the patch set, nothing looks obviously wrong. You should probably also seek Dave's ack on at least ntb_perf. Acked-by: Allen Hubbe <allen.hu...@dell.com> > Serge Semin (15): > NTB: Rename NTB messaging API methods > NTB: Set dma mask and dma coherent mask to NTB devices &g

RE: [PATCH v2 00/15] NTB: Add full multi-port API support to the test drivers

f the patch set, nothing looks obviously wrong. You should probably also seek Dave's ack on at least ntb_perf. Acked-by: Allen Hubbe > Serge Semin (15): > NTB: Rename NTB messaging API methods > NTB: Set dma mask and dma coherent mask to NTB devices > NTB: Fix UB/bug in ntb_mw_

RE: [PATCH v3 14/16] switchtec_ntb: implement scratchpad registers

From: Logan Gunthorpe > On 01/08/17 01:10 PM, Jon Mason wrote: > > It would probaly be better if I remarked about the SPADs in the actual > > patch about the SPADS :) > > > > The whole point of using the SPADs in the NTB driver was to workaround > > the problems establishing a connection between

RE: [PATCH v3 14/16] switchtec_ntb: implement scratchpad registers

From: Logan Gunthorpe > On 01/08/17 01:10 PM, Jon Mason wrote: > > It would probaly be better if I remarked about the SPADs in the actual > > patch about the SPADS :) > > > > The whole point of using the SPADs in the NTB driver was to workaround > > the problems establishing a connection between

RE: [PATCH v3 00/16] Switchtec NTB Support

From: Logan Gunthorpe > Changes since v2: > > - Reordered the ntb_test link patch per Allen > - Removed an extra call to switchtec_ntb_init_mw > - Fixed a typo in the switchtec.txt documentation. Patches 5..16 (also 5 [was 6], and 14, objections notwithstanding): Acked-by: Allen

RE: [PATCH v3 00/16] Switchtec NTB Support

From: Logan Gunthorpe > Changes since v2: > > - Reordered the ntb_test link patch per Allen > - Removed an extra call to switchtec_ntb_init_mw > - Fixed a typo in the switchtec.txt documentation. Patches 5..16 (also 5 [was 6], and 14, objections notwithstanding): Acked-

RE: [PATCH v2 00/16] Switchtec NTB Support

request_module() call such that the NTB module is automatically > loaded when appropriate hardware exists. Patches 5..16: Acked-by: Allen Hubbe <allen.hu...@dell.com> Should the order of 6 and 7 be swapped? While I still have some objections to this series, we have already be

RE: [PATCH v2 00/16] Switchtec NTB Support

request_module() call such that the NTB module is automatically > loaded when appropriate hardware exists. Patches 5..16: Acked-by: Allen Hubbe Should the order of 6 and 7 be swapped? While I still have some objections to this series, we have already been over them, and I won't let these

RE: [PATCH v4 4/5] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

From: Logan Gunthorpe > Now that ioread64 and iowrite64 are available in io-64-nonatomic, > we can remove the hack at the top of ntb_hw_intel.c and replace it > with an include. > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Cc: Jon Mason <jdma...@kudzu.us&g

RE: [PATCH v4 4/5] ntb: ntb_hw_intel: use io-64-nonatomic instead of in-driver hacks

From: Logan Gunthorpe > Now that ioread64 and iowrite64 are available in io-64-nonatomic, > we can remove the hack at the top of ntb_hw_intel.c and replace it > with an include. > > Signed-off-by: Logan Gunthorpe > Cc: Jon Mason > Cc: Allen Hubbe > Acked-by: Dave Jiang

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

Let me try that again... From: Hubbe, Allen > From: Logan Gunthorpe > > On 6/29/2017 2:13 PM, Allen Hubbe wrote: > > > Unfortunately, it is to work around hardware errata. That is not so > > > trivial to fix. > > > > Can you describe more what

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

Let me try that again... From: Hubbe, Allen > From: Logan Gunthorpe > > On 6/29/2017 2:13 PM, Allen Hubbe wrote: > > > Unfortunately, it is to work around hardware errata. That is not so > > > trivial to fix. > > > > Can you describe more what

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

From: Logan Gunthorpe > On 6/29/2017 12:11 PM, Allen Hubbe wrote: > > Nak. This breaks a work around for stability issues on some hardware. I > > am ok with changing the > comment to say, this is only supported when called after link up. I would > still like to allow

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

From: Logan Gunthorpe > On 6/29/2017 12:11 PM, Allen Hubbe wrote: > > Nak. This breaks a work around for stability issues on some hardware. I > > am ok with changing the > comment to say, this is only supported when called after link up. I would > still like to allow

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

From: Logan Gunthorpe > This patch adds a comment and a check to the ntb_mw_get_align and > ntb_mw_count functions so that they always fail if the function is > called before the link is up. > > This is to prevent accidental mis-use in clients that are testing > on hardware that this doesn't

RE: [PATCH 06/16] ntb: add check and comment for link up to mw_count and mw_get_align

From: Logan Gunthorpe > This patch adds a comment and a check to the ntb_mw_get_align and > ntb_mw_count functions so that they always fail if the function is > called before the link is up. > > This is to prevent accidental mis-use in clients that are testing > on hardware that this doesn't

RE: [PATCH 05/16] ntb: ensure ntb_mw_get_align is only called when the link is up

ntb_tool so that peer_mw_trans will print zero if it is run before > the link goes up. > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> Acked-by: Allen Hubbe <allen.hu...@dell.com> > --- > drivers/ntb/ntb_transport.c | 20 ++-- > drivers/ntb

RE: [PATCH 05/16] ntb: ensure ntb_mw_get_align is only called when the link is up

ntb_tool so that peer_mw_trans will print zero if it is run before > the link goes up. > > Signed-off-by: Logan Gunthorpe Acked-by: Allen Hubbe > --- > drivers/ntb/ntb_transport.c | 20 ++-- > drivers/ntb/test/ntb_perf.c | 18 +- > drivers/ntb

RE: [PATCH 12/16] switchtec_ntb: add link management

From: Logan Gunthorpe > switchtec_ntb checks for a link by looking at the shared memory > window. If the magic number is correct and the otherside indicates > their link is enabled then we take the link to be up. > > Whenever we change our local link status we send a msg to the > otherside to

RE: [PATCH 12/16] switchtec_ntb: add link management

From: Logan Gunthorpe > switchtec_ntb checks for a link by looking at the shared memory > window. If the magic number is correct and the otherside indicates > their link is enabled then we take the link to be up. > > Whenever we change our local link status we send a msg to the > otherside to

RE: [PATCH 14/16] switchtec_ntb: implement scratchpad registers

From: Logan Gunthorpe > Seeing there is no dedicated hardware for this, we simply add > these as entries in the shared memory window. Thus, we could support > any number of them but 128 seems like enough, for now. Scratchpads are not natively supported by this hardware, - but the hardware does

RE: [PATCH 14/16] switchtec_ntb: implement scratchpad registers

From: Logan Gunthorpe > Seeing there is no dedicated hardware for this, we simply add > these as entries in the shared memory window. Thus, we could support > any number of them but 128 seems like enough, for now. Scratchpads are not natively supported by this hardware, - but the hardware does

RE: [PATCH] ntb: use correct mw_count function in ntb_tool and ntb_transport

ill matter for any future driver with asymetric memory window > counts. > > Signed-off-by: Logan Gunthorpe <log...@deltatee.com> > Cc: Jon Mason <jdma...@kudzu.us> > Cc: Dave Jiang <dave.ji...@intel.com> > Cc: Allen Hubbe <allen.hu...@emc.com> > Cc: Serge S

RE: [PATCH] ntb: use correct mw_count function in ntb_tool and ntb_transport

ill matter for any future driver with asymetric memory window > counts. > > Signed-off-by: Logan Gunthorpe > Cc: Jon Mason > Cc: Dave Jiang > Cc: Allen Hubbe > Cc: Serge Semin Acked-by: Allen Hubbe > --- > > Hi Guys, > > I caught this issue while finishing

RE: New NTB API Issue

From: Logan Gunthorpe > But any translation can be > programmed by any peer. That doesn't seem safe. Even though it can be done as you say, would it not be better to have each specific translation under the control of exactly one driver? If drivers can reach across and set the translation of

RE: New NTB API Issue

From: Logan Gunthorpe > But any translation can be > programmed by any peer. That doesn't seem safe. Even though it can be done as you say, would it not be better to have each specific translation under the control of exactly one driver? If drivers can reach across and set the translation of

RE: New NTB API Issue

From: Logan Gunthorpe > Hey, > > Thanks Serge for the detailed explanation. This is pretty much exactly > as I had thought it should be interpreted. My only problem remains that > my hardware can't provide ntb_mw_get_align until the port it is asking > about has configured itself. The easiest way

RE: New NTB API Issue

From: Logan Gunthorpe > Hey, > > Thanks Serge for the detailed explanation. This is pretty much exactly > as I had thought it should be interpreted. My only problem remains that > my hardware can't provide ntb_mw_get_align until the port it is asking > about has configured itself. The easiest way

RE: New NTB API Issue

From: Logan Gunthorpe > On 23/06/17 07:18 AM, Allen Hubbe wrote: > > By "remote" do you mean the source or destination of a write? > > Look at how these calls are used in ntb_transport and ntb_perf: > > They both call ntb_peer_mw_get_addr to get the size of the BA

RE: New NTB API Issue

From: Logan Gunthorpe > On 23/06/17 07:18 AM, Allen Hubbe wrote: > > By "remote" do you mean the source or destination of a write? > > Look at how these calls are used in ntb_transport and ntb_perf: > > They both call ntb_peer_mw_get_addr to get the size of the BA

RE: New NTB API Issue

From: Logan Gunthorpe > On 6/22/2017 4:42 PM, Allen Hubbe wrote: > > From: Logan Gunthorpe > >> Any thoughts on changing the semantics of mw_get_align so it must be > >> called with the link up? > > > > The intention of these is that these calls retu

RE: New NTB API Issue

From: Logan Gunthorpe > On 6/22/2017 4:42 PM, Allen Hubbe wrote: > > From: Logan Gunthorpe > >> Any thoughts on changing the semantics of mw_get_align so it must be > >> called with the link up? > > > > The intention of these is that these calls retu

RE: New NTB API Issue

From: Logan Gunthorpe > Any thoughts on changing the semantics of mw_get_align so it must be > called with the link up? The intention of these is that these calls return information from the local port. The calls themselves don't reach across the link to the peer, but the information returned

RE: New NTB API Issue

From: Logan Gunthorpe > Any thoughts on changing the semantics of mw_get_align so it must be > called with the link up? The intention of these is that these calls return information from the local port. The calls themselves don't reach across the link to the peer, but the information returned

RE: New NTB API Issue

From: Logan Gunthorpe > On 6/22/2017 12:32 PM, Allen Hubbe wrote: > > From: Logan Gunthorpe > >> 2) The changes to the Intel and AMD driver for mw_get_align sets > >> *max_size to the local pci resource size. (Thus making the assumption > >> that the local is

RE: New NTB API Issue

From: Logan Gunthorpe > On 6/22/2017 12:32 PM, Allen Hubbe wrote: > > From: Logan Gunthorpe > >> 2) The changes to the Intel and AMD driver for mw_get_align sets > >> *max_size to the local pci resource size. (Thus making the assumption > >> that the local is

RE: New NTB API Issue

From: Logan Gunthorpe > Hey Guys, > > I've run into some subtle issues with the new API: > > It has to do with splitting mw_get_range into mw_get_align and > peer_mw_get_addr. > > The original mw_get_range returned the size of the /local/ memory > window's size, address and alignment

RE: New NTB API Issue

From: Logan Gunthorpe > Hey Guys, > > I've run into some subtle issues with the new API: > > It has to do with splitting mw_get_range into mw_get_align and > peer_mw_get_addr. > > The original mw_get_range returned the size of the /local/ memory > window's size, address and alignment

RE: [RFC PATCH 00/13] Switchtec NTB Support

From: Logan Gunthorpe > On 16/06/17 09:34 AM, Allen Hubbe wrote: > > In code review, I really only have found minor nits. Overall, the driver > > looks good. > > Great, thanks for such a quick review! > > > In switchtec_ntb_part_op, there is a delay of up to 50s (

RE: [RFC PATCH 00/13] Switchtec NTB Support

From: Logan Gunthorpe > On 16/06/17 09:34 AM, Allen Hubbe wrote: > > In code review, I really only have found minor nits. Overall, the driver > > looks good. > > Great, thanks for such a quick review! > > > In switchtec_ntb_part_op, there is a delay of up to 50s (

RE: [RFC PATCH 00/13] Switchtec NTB Support

From: Logan Gunthorpe > On 16/06/17 07:53 AM, Allen Hubbe wrote: > > See what is staged in https://github.com/jonmason/ntb.git ntb-next, with > > the addition of multi-peer > support by Serge. It would be good at this stage to understand whether the > api changes there

RE: [RFC PATCH 00/13] Switchtec NTB Support

From: Logan Gunthorpe > On 16/06/17 07:53 AM, Allen Hubbe wrote: > > See what is staged in https://github.com/jonmason/ntb.git ntb-next, with > > the addition of multi-peer > support by Serge. It would be good at this stage to understand whether the > api changes there

RE: [RFC PATCH 00/13] Switchtec NTB Support

From: Logan Gunthorpe > Hi, > > This patchset implements Non-Transparent Bridge (NTB) support for the > Microsemi Switchtec series of switches. We're looking for some > review from the community at this point but hope to get it upstreamed > for v4.14. > > Switchtec NTB support is configured over

RE: [RFC PATCH 00/13] Switchtec NTB Support

From: Logan Gunthorpe > Hi, > > This patchset implements Non-Transparent Bridge (NTB) support for the > Microsemi Switchtec series of switches. We're looking for some > review from the community at this point but hope to get it upstreamed > for v4.14. > > Switchtec NTB support is configured over

RE: [BUG] ntb: Sleep in interrupt handling

From: Jia-Ju Bai > According to ntb_transport.c, the driver may sleep in interrupt handling. > The function call path is: > ntb_transport_rxc_db (tasklet_init indicates it handles interrupt) >ntb_process_rxc > ntb_async_rx >ntb_async_rx_submit > schedule_timeout --> may

RE: [BUG] ntb: Sleep in interrupt handling

From: Jia-Ju Bai > According to ntb_transport.c, the driver may sleep in interrupt handling. > The function call path is: > ntb_transport_rxc_db (tasklet_init indicates it handles interrupt) >ntb_process_rxc > ntb_async_rx >ntb_async_rx_submit > schedule_timeout --> may

RE: [PATCH v3] NTB: Add IDT 89HPESxNTx PCIe-switches support

From: Serge Semin > IDT 89HPESxNTx device series is PCIe-switches, which support ... > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> Acked-by: Allen Hubbe <allen.hu...@dell.com> With minor comments. Please include my Ack if you send v4. > +static u32 idt_nt_re

RE: [PATCH v3] NTB: Add IDT 89HPESxNTx PCIe-switches support

From: Serge Semin > IDT 89HPESxNTx device series is PCIe-switches, which support ... > Signed-off-by: Serge Semin Acked-by: Allen Hubbe With minor comments. Please include my Ack if you send v4. > +static u32 idt_nt_read(struct idt_ntb_dev *ndev, const unsigne

RE: [PATCH v2] NTB: Add IDT 89HPESxNTx PCIe-switches support

From: Serge Semin > +/* > + * idt_nt_write() - PCI configuration space registers write method > + * @ndev:IDT NTB hardware driver descriptor > + * @reg: Register to write data to > + * @data:Value to write to the register > + * > + * WARNING! IDT PCIe-switch registers are all Little

RE: [PATCH v2] NTB: Add IDT 89HPESxNTx PCIe-switches support

From: Serge Semin > +/* > + * idt_nt_write() - PCI configuration space registers write method > + * @ndev:IDT NTB hardware driver descriptor > + * @reg: Register to write data to > + * @data:Value to write to the register > + * > + * WARNING! IDT PCIe-switch registers are all Little

RE: [PATCH] NTB: Add IDT 89HPESxNTx PCIe-switches support

From: Serge Semin > +static void idt_nt_write(struct idt_ntb_dev *ndev, > + const unsigned int reg, const u32 data) > +{ > + /* > + * It's obvious bug to request a register exceeding the maximum possible > + * value as well as to have it unaligned. > + */ >

RE: [PATCH] NTB: Add IDT 89HPESxNTx PCIe-switches support

From: Serge Semin > +static void idt_nt_write(struct idt_ntb_dev *ndev, > + const unsigned int reg, const u32 data) > +{ > + /* > + * It's obvious bug to request a register exceeding the maximum possible > + * value as well as to have it unaligned. > + */ >

RE: [PATCH v3 9/9] NTB: Add ntb.h comments

From: Serge Semin > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> Acked-by: Allen Hubbe <allen.hu...@dell.com> > --- > include/linux/ntb.h | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/include/linux/ntb.h

RE: [PATCH v3 9/9] NTB: Add ntb.h comments

From: Serge Semin > Signed-off-by: Serge Semin Acked-by: Allen Hubbe > --- > include/linux/ntb.h | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/include/linux/ntb.h b/include/linux/ntb.h > index 6d46179..dab0a1b 100644 > -

RE: [PATCH v3 9/9] NTB: Add ntb.h comments

From: Serge Semin > Signed-off-by: Serge Semin > --- > include/linux/ntb.h | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/include/linux/ntb.h b/include/linux/ntb.h > index 6d46179..dab0a1b 100644 > --- a/include/linux/ntb.h

RE: [PATCH v3 9/9] NTB: Add ntb.h comments

From: Serge Semin > Signed-off-by: Serge Semin > --- > include/linux/ntb.h | 19 --- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/include/linux/ntb.h b/include/linux/ntb.h > index 6d46179..dab0a1b 100644 > --- a/include/linux/ntb.h > +++

RE: [PATCH v3 5/9] NTB: Alter Scratchpads API to support multi-ports devices

methods are now made optional. > > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> Acked-by: Allen Hubbe <allen.hu...@dell.com> > --- > drivers/ntb/hw/amd/ntb_hw_amd.c | 14 +++ > drivers/ntb/hw/intel/ntb_hw_intel.c | 14 +++ > drivers

RE: [PATCH v3 5/9] NTB: Alter Scratchpads API to support multi-ports devices

methods are now made optional. > > Signed-off-by: Serge Semin Acked-by: Allen Hubbe > --- > drivers/ntb/hw/amd/ntb_hw_amd.c | 14 +++ > drivers/ntb/hw/intel/ntb_hw_intel.c | 14 +++ > drivers/ntb/ntb_transport.c | 17 - > drivers/nt

RE: [PATCH v3 4/9] NTB: Alter MW API to support multi-ports devices

b_peer_mw_clear_trans(pidx, widx); - clear the translation address of an > outbound memory window > > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> Acked-by: Allen Hubbe <allen.hu...@dell.com> > --- > drivers/ntb/hw/amd/ntb_hw_amd.c | 68 +--- > drivers

RE: [PATCH v3 4/9] NTB: Alter MW API to support multi-ports devices

b_peer_mw_clear_trans(pidx, widx); - clear the translation address of an > outbound memory window > > Signed-off-by: Serge Semin Acked-by: Allen Hubbe > --- > drivers/ntb/hw/amd/ntb_hw_amd.c | 68 +--- > drivers/ntb/hw/intel/ntb_hw_intel.c | 90 > d

RE: [PATCH v3 1/9] NTB: Make link-state API being declared first

From: Serge Semin > Since link operations are usually performed before memory window access > operations, it's logically better to declare link-related API before any > of MW/Doorbell/Scratchpad methods. > > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> Acked-by:

RE: [PATCH v3 1/9] NTB: Make link-state API being declared first

From: Serge Semin > Since link operations are usually performed before memory window access > operations, it's logically better to declare link-related API before any > of MW/Doorbell/Scratchpad methods. > > Signed-off-by: Serge Semin Acked-by: Allen Hubbe > --- > incl

RE: [PATCH v3 2/9] NTB: Add indexed ports NTB API

implement it. > > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> Acked-by: Allen Hubbe <allen.hu...@dell.com> > --- > drivers/ntb/ntb.c | 54 ++ > drivers/ntb/ntb_transport.c | 6 ++ > drivers/ntb/test/ntb_perf.c | 4 ++

RE: [PATCH v3 2/9] NTB: Add indexed ports NTB API

implement it. > > Signed-off-by: Serge Semin Acked-by: Allen Hubbe > --- > drivers/ntb/ntb.c | 54 ++ > drivers/ntb/ntb_transport.c | 6 ++ > drivers/ntb/test/ntb_perf.c | 4 ++ > drivers/ntb/test/ntb_pingpong.c | 6 ++ > drivers/ntb/

RE: [PATCH v2 9/9] NTB: Add ntb.h comments

From: Serge Semin > > Signed-off-by: Serge Semin > > --- > include/linux/ntb.h | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/include/linux/ntb.h b/include/linux/ntb.h > index fe0437c..c5a369c 100644 > ---

RE: [PATCH v2 9/9] NTB: Add ntb.h comments

From: Serge Semin > > Signed-off-by: Serge Semin > > --- > include/linux/ntb.h | 17 +++-- > 1 file changed, 11 insertions(+), 6 deletions(-) > > diff --git a/include/linux/ntb.h b/include/linux/ntb.h > index fe0437c..c5a369c 100644 > --- a/include/linux/ntb.h > +++

RE: [PATCH v2 7/9] NTB: Add new Memory Windows API documentation

From: Serge Semin > Since the new API slightly changes the way a typical NTB client driver > works, the documentation file needs to be appropriately updated. > > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> Acked-by: Allen Hubbe <allen.hu...@dell.com> > >

RE: [PATCH v2 8/9] NTB: Add PCIe Gen4 link speed

From: Serge Semin > > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> Acked-by: Allen Hubbe <allen.hu...@dell.com> > > --- > include/linux/ntb.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/ntb.h b/include/linux/n

RE: [PATCH v2 7/9] NTB: Add new Memory Windows API documentation

From: Serge Semin > Since the new API slightly changes the way a typical NTB client driver > works, the documentation file needs to be appropriately updated. > > Signed-off-by: Serge Semin Acked-by: Allen Hubbe > > --- > Docum

RE: [PATCH v2 8/9] NTB: Add PCIe Gen4 link speed

From: Serge Semin > > Signed-off-by: Serge Semin Acked-by: Allen Hubbe > > --- > include/linux/ntb.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/linux/ntb.h b/include/linux/ntb.h > index 90746df..fe0437c 100644 > --- a/include/linux/ntb

RE: [PATCH v2 6/9] NTB: Add Messaging NTB API

egisters, so s/hadrware/hardware/ > this API is made optional. > > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> Acked-by: Allen Hubbe <allen.hu...@dell.com> > > --- > drivers/ntb/ntb.c | 13 > include/linux/ntb.h | 205 >

RE: [PATCH v2 6/9] NTB: Add Messaging NTB API

egisters, so s/hadrware/hardware/ > this API is made optional. > > Signed-off-by: Serge Semin Acked-by: Allen Hubbe > > --- > drivers/ntb/ntb.c | 13 > include/linux/ntb.h | 205 > > 2 files changed,

RE: [PATCH v2 5/9] NTB: Alter Scratchpads API to support multi-ports devices

From: Serge Semin > Even though there is no any real NTB hardware, which would have both more > than two ports and Scratchpad registers, it is logically correct to have > Scratchpad API accepting a peer port index as well. Intel/AMD drivers utilize > Primary and Secondary topology to split

RE: [PATCH v2 5/9] NTB: Alter Scratchpads API to support multi-ports devices

From: Serge Semin > Even though there is no any real NTB hardware, which would have both more > than two ports and Scratchpad registers, it is logically correct to have > Scratchpad API accepting a peer port index as well. Intel/AMD drivers utilize > Primary and Secondary topology to split

RE: [PATCH v2 4/9] NTB: Alter MW API to support multi-ports devices

From: Serge Semin > Multi-port NTB devices permit to share a memory between all accessible peers. > Memory Windows API is altered to correspondingly initialize and map memory > windows for such devices: > ntb_mw_count(pidx); - number of inbound memory windows, which can be > allocated > for

RE: [PATCH v2 4/9] NTB: Alter MW API to support multi-ports devices

From: Serge Semin > Multi-port NTB devices permit to share a memory between all accessible peers. > Memory Windows API is altered to correspondingly initialize and map memory > windows for such devices: > ntb_mw_count(pidx); - number of inbound memory windows, which can be > allocated > for

RE: [PATCH v2 1/9] NTB: Make link-state API being declared first

From: Serge Semin > Since link operations are usually performed before memory window access > operations, it's logically better to declared link-related API before any > other methods. Additionally it's good practice for readability to declare > NTB device callback methods of hadrware drivers with

RE: [PATCH v2 3/9] NTB: Alter link-state API to support multi-port devices

local device and possible peers. > > Signed-off-by: Serge Semin <fancer.lan...@gmail.com> Acked-by: Allen Hubbe <allen.hu...@dell.com> > > --- > drivers/ntb/hw/amd/ntb_hw_amd.c | 2 +- > drivers/ntb/hw/intel/ntb_hw_intel.c | 2 +- &

RE: [PATCH v2 2/9] NTB: Add indexed ports NTB API

From: Serge Semin > There are some NTB hardware, which can combine more than just two domains > over NTB. For instance, some IDT PCIe-switches can have NTB-functions > activated on more than two-ports. The different domains are distinguished > by ports they are connected to. So the new

  1   2   3   4   >