Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

On Thu, Jun 30, 2016 at 12:53 AM, Wolfram Sang <w...@the-dreams.de> wrote: > On Thu, Jun 30, 2016 at 12:03:47AM +0530, Amitoj Kaur Chawla wrote: >> This script detects cases which have incorrect error handling for >> devm_ioremap_resource function, employing a NULL test in

Re: [Cocci] [PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

On Thu, Jun 30, 2016 at 12:53 AM, Wolfram Sang wrote: > On Thu, Jun 30, 2016 at 12:03:47AM +0530, Amitoj Kaur Chawla wrote: >> This script detects cases which have incorrect error handling for >> devm_ioremap_resource function, employing a NULL test instead of an >> IS_ERR

[PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

This script detects cases which have incorrect error handling for devm_ioremap_resource function, employing a NULL test instead of an IS_ERR() test. Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- .../coccinelle/null/devm_ioremap_resource.cocci| 37 ++

[PATCH] Coccinelle: Script to replace NULL test with IS_ERR test for devm_ioremap_resource

This script detects cases which have incorrect error handling for devm_ioremap_resource function, employing a NULL test instead of an IS_ERR() test. Signed-off-by: Amitoj Kaur Chawla --- .../coccinelle/null/devm_ioremap_resource.cocci| 37 ++ 1 file changed, 37

[PATCH] PCI: xilinx: Modify error handling

R(E) ...+> } Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/pci/host/pcie-xilinx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c index 65f0fe0..d76ea8d 100644 --- a/drivers/pci/host/p

[PATCH] PCI: xilinx: Modify error handling

R(E) ...+> } Signed-off-by: Amitoj Kaur Chawla --- drivers/pci/host/pcie-xilinx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-xilinx.c b/drivers/pci/host/pcie-xilinx.c index 65f0fe0..d76ea8d 100644 --- a/drivers/pci/host/pcie-xilinx.c +++ b/drivers/pc

[PATCH] x86/xen: Use DIV_ROUND_UP

)) / d + DIV_ROUND_UP(n,d) ) Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- arch/x86/xen/enlighten.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 880862c..6847512 100644 --- a/arch/x

[PATCH] x86/xen: Use DIV_ROUND_UP

)) / d + DIV_ROUND_UP(n,d) ) Signed-off-by: Amitoj Kaur Chawla --- arch/x86/xen/enlighten.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 880862c..6847512 100644 --- a/arch/x86/xen/enlighten.c +++ b/arch/x86/xen

[PATCH] ALSA: riptide: Use DIV_ROUND_UP

)) / d + DIV_ROUND_UP(n,d) ) Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- sound/pci/riptide/riptide.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c index 94639d6..067a912 100644 --- a/sound/pci/r

[PATCH] ALSA: riptide: Use DIV_ROUND_UP

)) / d + DIV_ROUND_UP(n,d) ) Signed-off-by: Amitoj Kaur Chawla --- sound/pci/riptide/riptide.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c index 94639d6..067a912 100644 --- a/sound/pci/riptide/riptide.c +++ b/sound

[PATCH] i2c: mv64xxx: Use clk_enable_prepare and clk_disable_unprepare

; @@ - clk_disable(e); - clk_unprepare(e); + clk_disable_unprepare(e); Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/i2c/busses/i2c-mv64xxx.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/

[PATCH] i2c: mv64xxx: Use clk_enable_prepare and clk_disable_unprepare

; @@ - clk_disable(e); - clk_unprepare(e); + clk_disable_unprepare(e); Signed-off-by: Amitoj Kaur Chawla --- drivers/i2c/busses/i2c-mv64xxx.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/i2c/busses/i2c-mv64xxx.c b/drivers/i2c/busses/i2c-mv64xxx.c index

[PATCH] pinctrl: stm32: Modify error handling for pinctrl_register

) ; } Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/pinctrl/stm32/pinctrl-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index 8deb566..857bb3d 100644 --- a/drivers/p

[PATCH] pinctrl: stm32: Modify error handling for pinctrl_register

) ; } Signed-off-by: Amitoj Kaur Chawla --- drivers/pinctrl/stm32/pinctrl-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c index 8deb566..857bb3d 100644 --- a/drivers/pinctrl/stm32/pinctrl-stm32.c

[PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent

pci_free_consistent's argument 'struct pci_dev' should be NULL not 0. The Coccinelle semantic patch used to make this change is as follows: @@ @@ pci_free_consistent( - 0 + NULL , ...) Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/net/ethernet/tundra/tsi108_eth

[PATCH] net: ethernet: tundra: Correct argument for pci_free_consistent

pci_free_consistent's argument 'struct pci_dev' should be NULL not 0. The Coccinelle semantic patch used to make this change is as follows: @@ @@ pci_free_consistent( - 0 + NULL , ...) Signed-off-by: Amitoj Kaur Chawla --- drivers/net/ethernet/tundra/tsi108_eth.c | 3 ++- 1 file changed, 2

[PATCH] pinctrl: Add missing of_node_put

-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/pinctrl/sirf/pinctrl-atlas7.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/sirf/pinctrl-atlas7.c b/drivers/pinctrl/sirf/pinctrl-atlas7.c index 3d233fc..7d9c1a3 100644 --- a/drivers/pinctrl/sirf/p

[PATCH] pinctrl: Add missing of_node_put

-by: Amitoj Kaur Chawla --- drivers/pinctrl/sirf/pinctrl-atlas7.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/sirf/pinctrl-atlas7.c b/drivers/pinctrl/sirf/pinctrl-atlas7.c index 3d233fc..7d9c1a3 100644 --- a/drivers/pinctrl/sirf/pinctrl-atlas7.c +++ b/drivers

[PATCH] caif: Remove unneeded header file

Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- net/caif/chnl_net.c | 1 - 1 file chan

[PATCH] caif: Remove unneeded header file

Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla --- net/caif/chnl_net.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH] ASOC: wm8753: Remove unneeded header file

Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- sound/soc/codecs/wm8753.c | 1 -

[PATCH] ASOC: wm8753: Remove unneeded header file

Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla --- sound/soc/codecs/wm8753.c | 1 - 1 file changed, 1 deletion

[PATCH] w1: Remove unneeded header file

Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/w1/w1.c | 1 - 1 file chan

[PATCH] w1: Remove unneeded header file

Drop redundant include of moduleparam.h The Coccinelle semantic patch used to make this change is as follows: @ includesmodule @ @@ #include @ depends on includesmodule @ @@ - #include Signed-off-by: Amitoj Kaur Chawla --- drivers/w1/w1.c | 1 - 1 file changed, 1 deletion(-) diff --git

[PATCH] memstick: Use kmemdup instead of kmalloc and memcpy

- memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/memstick/core/mspro_block.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c index 922a750..0fb27d3

[PATCH] memstick: Use kmemdup instead of kmalloc and memcpy

- memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla --- drivers/memstick/core/mspro_block.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c index 922a750..0fb27d3 100644 --- a/drivers

[PATCH] i40e: Remove redundant memset

Remove redundant call to memset before a call to memcpy. The Coccinelle semantic patch used to make this change is as follows: @@ expression e1,e2,e3,e4; @@ - memset(e1,e2,e3); memcpy(e1,e4,e3); Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/net/ethernet/inte

[PATCH] i40e: Remove redundant memset

Remove redundant call to memset before a call to memcpy. The Coccinelle semantic patch used to make this change is as follows: @@ expression e1,e2,e3,e4; @@ - memset(e1,e2,e3); memcpy(e1,e4,e3); Signed-off-by: Amitoj Kaur Chawla --- drivers/net/ethernet/intel/i40e/i40e_main.c | 1 - 1 file

[PATCH] dlm: Use kmemdup instead of kmalloc and memcpy

- memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- fs/dlm/lowcomms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 1ab012a..963016c 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowc

[PATCH] dlm: Use kmemdup instead of kmalloc and memcpy

- memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla --- fs/dlm/lowcomms.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/dlm/lowcomms.c b/fs/dlm/lowcomms.c index 1ab012a..963016c 100644 --- a/fs/dlm/lowcomms.c +++ b/fs/dlm/lowcomms.c @@ -1279,10 +1279,9

[PATCH] tipc: Use kmemdup instead of kmalloc and memcpy

- memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- net/tipc/server.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/tipc/server.c b/net/tipc/server.c index 2446bfb..38a6f33 100644 --- a/net/tipc/server.c +++ b/net/tipc/se

[PATCH] tipc: Use kmemdup instead of kmalloc and memcpy

- memcpy(to, from, size); Signed-off-by: Amitoj Kaur Chawla --- net/tipc/server.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/tipc/server.c b/net/tipc/server.c index 2446bfb..38a6f33 100644 --- a/net/tipc/server.c +++ b/net/tipc/server.c @@ -411,13 +411,12 @@ static

[PATCH] hfs: Change structure initialisation to C99 style

@ identifier i1,fld; type T; field list[n] fs; @@ struct i1 { fs T fld; ...}; @@ identifier decl.i1,i2,decl.fld; expression e; position bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- fs/hfs/inode.c | 4 +

[PATCH] hfs: Change structure initialisation to C99 style

@ identifier i1,fld; type T; field list[n] fs; @@ struct i1 { fs T fld; ...}; @@ identifier decl.i1,i2,decl.fld; expression e; position bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- fs/hfs/inode.c | 4 ++-- 1 file changed, 2

[PATCH] ddbridge: Replace vmalloc with vzalloc

-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/media/pci/ddbridge/ddbridge-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/pci/ddbridge/ddbridge-core.c b/drivers/media/pci/ddbridge/ddbridge-core.c index 6e995ef..47def73 100644 --- a/drivers

[PATCH] ddbridge: Replace vmalloc with vzalloc

-by: Amitoj Kaur Chawla --- drivers/media/pci/ddbridge/ddbridge-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/pci/ddbridge/ddbridge-core.c b/drivers/media/pci/ddbridge/ddbridge-core.c index 6e995ef..47def73 100644 --- a/drivers/media/pci/ddbridge/ddbridge

[PATCH] ACPICA: Use acpi_os_allocate_zeroed

) S - memset(d, 0, sizeof(T)); Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/acpi/acpica/utcache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/acpi/acpica/utcache.c b/drivers/acpi/acpica/utcache.c index f8e9978..862f963

[PATCH] ACPICA: Use acpi_os_allocate_zeroed

) S - memset(d, 0, sizeof(T)); Signed-off-by: Amitoj Kaur Chawla --- drivers/acpi/acpica/utcache.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/acpi/acpica/utcache.c b/drivers/acpi/acpica/utcache.c index f8e9978..862f963 100644 --- a/drivers/acpi/acpica

[PATCH] net: cavium: liquidio: Use vzalloc instead of vmalloc

-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/net/ethernet/cavium/liquidio/octeon_device.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c index f

[PATCH] net: cavium: liquidio: Use vzalloc instead of vmalloc

-by: Amitoj Kaur Chawla --- drivers/net/ethernet/cavium/liquidio/octeon_device.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/cavium/liquidio/octeon_device.c b/drivers/net/ethernet/cavium/liquidio/octeon_device.c index f67641a..2bf90c1 100644

[PATCH] ACPICA: Use acpi_os_allocate_zeroed

) S - memset(d, 0, sizeof(T)); Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/acpi/acpica/uttrack.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/acpi/acpica/uttrack.c b/drivers/acpi/acpica/uttrack.c index 60c406a..5ad2641

[PATCH] ACPICA: Use acpi_os_allocate_zeroed

) S - memset(d, 0, sizeof(T)); Signed-off-by: Amitoj Kaur Chawla --- drivers/acpi/acpica/uttrack.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/acpi/acpica/uttrack.c b/drivers/acpi/acpica/uttrack.c index 60c406a..5ad2641 100644 --- a/drivers/acpi/acpica

[PATCH] ALSA: ctxfi: Change structure initialisation to C99 style

; ...}; @@ identifier decl.i1,i2,decl.fld; expression e; position bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- sound/pci/ctxfi/cthw20k2.c | 34 +- 1 file changed, 17 insertions(

[PATCH] ALSA: ctxfi: Change structure initialisation to C99 style

; ...}; @@ identifier decl.i1,i2,decl.fld; expression e; position bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- sound/pci/ctxfi/cthw20k2.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git

[PATCH v2] ALSA: usb-audio: Change structure initialisation to C99 style

,decl.fld; expression e; position bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- Changes in v2: -Modified commit message sound/usb/mixer_maps.c | 6 -- 1 file changed, 4 insertions(+), 2 del

[PATCH v2] ALSA: usb-audio: Change structure initialisation to C99 style

,decl.fld; expression e; position bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Modified commit message sound/usb/mixer_maps.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound

[PATCH] ALSA: usb-audio: Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- sound/usb/mixer_maps.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c index 1f8fb0d9..9

[PATCH] ALSA: usb-audio: Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- sound/usb/mixer_maps.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/sound/usb/mixer_maps.c b/sound/usb/mixer_maps.c index 1f8fb0d9..9038b2e 100644 --- a/sound/usb

[PATCH] ALSA: seq_oss: Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Also, removed some unnecessary comments. Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- sound/core/seq/oss/seq_oss_synth.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/co

[PATCH] ALSA: seq_oss: Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Also, removed some unnecessary comments. Signed-off-by: Amitoj Kaur Chawla --- sound/core/seq/oss/seq_oss_synth.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/sound/core/seq/oss/seq_oss_synth.c

[PATCH] sound: aedsp16: Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- sound/oss/aedsp16.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/oss/aedsp16.c b/sound/oss/aedsp16.c index 35b5912..b

[PATCH] sound: aedsp16: Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- sound/oss/aedsp16.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/sound/oss/aedsp16.c b/sound/oss/aedsp16.c index 35b5912..bb477d5 100644 --- a/sound/oss

[PATCH] [ACPI] Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- arch/ia64/kernel/acpi-ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/kernel/acpi-ext.c b/arch/ia64/kernel/acpi-ext.c index b

[PATCH] [ACPI] Change structure initialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- arch/ia64/kernel/acpi-ext.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/ia64/kernel/acpi-ext.c b/arch/ia64/kernel/acpi-ext.c index bd09bf7..31e331a 100644

[PATCH] parisc: Change structure intialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- arch/parisc/lib/iomap.c | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/arch/parisc/lib/iom

[PATCH] parisc: Change structure intialisation to C99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- arch/parisc/lib/iomap.c | 64 - 1 file changed, 32 insertions(+), 32 deletions(-) diff --git a/arch/parisc/lib/iomap.c b/arch/parisc/lib

[PATCH 1/2] ARM: pxa: ssp: Drop unnecessary freeing functions

= devm_ioremap(...) | x = devm_ioremap_nocache(...) ) @@ expression r.x; @@ ( * kfree(x) | * free_irq(x) | * iounmap(x) ) Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- arch/arm/plat-pxa/ssp.c | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/ar

[PATCH 2/2] ARM: pxa: ssp: Switch to devm_ioremap_resource

rce to take advantage of the null check on res by devm_ioremap_resource. Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- arch/arm/plat-pxa/ssp.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-

[PATCH 0/2] ARM: pxa: ssp: Clean up probe and remove functions

and devm_ioremap with devm_ioremap_resource. Amitoj Kaur Chawla (2): ARM: pxa: ssp: Drop unnecessary freeing functions ARM: pxa: ssp: Switch to devm_ioremap_resource arch/arm/plat-pxa/ssp.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) -- 1.9.1

[PATCH 1/2] ARM: pxa: ssp: Drop unnecessary freeing functions

= devm_ioremap(...) | x = devm_ioremap_nocache(...) ) @@ expression r.x; @@ ( * kfree(x) | * free_irq(x) | * iounmap(x) ) Signed-off-by: Amitoj Kaur Chawla --- arch/arm/plat-pxa/ssp.c | 9 - 1 file changed, 9 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index

[PATCH 2/2] ARM: pxa: ssp: Switch to devm_ioremap_resource

rce to take advantage of the null check on res by devm_ioremap_resource. Signed-off-by: Amitoj Kaur Chawla --- arch/arm/plat-pxa/ssp.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletions(-) diff --git a/arch/arm/plat-pxa/ssp.c b/arch/arm/plat-pxa/ssp.c index 97bd43c..aecc

[PATCH 0/2] ARM: pxa: ssp: Clean up probe and remove functions

and devm_ioremap with devm_ioremap_resource. Amitoj Kaur Chawla (2): ARM: pxa: ssp: Drop unnecessary freeing functions ARM: pxa: ssp: Switch to devm_ioremap_resource arch/arm/plat-pxa/ssp.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) -- 1.9.1

[PATCH] ARM: zx: Fix devm_ioremap_resource error detection code

-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- arch/arm/mach-zx/zx296702-pm-domain.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c index e08574d..17f778b 100644 --- a/arch/arm/m

[PATCH] ARM: zx: Fix devm_ioremap_resource error detection code

-by: Amitoj Kaur Chawla --- arch/arm/mach-zx/zx296702-pm-domain.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c index e08574d..17f778b 100644 --- a/arch/arm/mach-zx/zx296702-pm-domain.c

[PATCH] pinctrl: xway: Change structure initialisation to c99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/pinctrl/pinctrl-xway.c | 72 -- 1 file changed, 48 insertions(+), 24 deletions(-) diff --git a/drivers/pinctrl/p

[PATCH] pinctrl: xway: Change structure initialisation to c99 style

bad.p, bad.fix; @@ struct i1 i2@p = { ..., + .fld = e - e@fix ,...}; Signed-off-by: Amitoj Kaur Chawla --- drivers/pinctrl/pinctrl-xway.c | 72 -- 1 file changed, 48 insertions(+), 24 deletions(-) diff --git a/drivers/pinctrl/pinctrl-xway.c b/drivers/pinctrl

[PATCH] dmaengine: xilinx_vdma: Use dma_pool_zalloc

, 0, sizeof(T)); Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/dma/xilinx/xilinx_vdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_vdma.c b/drivers/dma/xilinx/xilinx_vdma.c index ef67f27..d35317f 100644 --- a/drive

[PATCH] dmaengine: xilinx_vdma: Use dma_pool_zalloc

, 0, sizeof(T)); Signed-off-by: Amitoj Kaur Chawla --- drivers/dma/xilinx/xilinx_vdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/xilinx/xilinx_vdma.c b/drivers/dma/xilinx/xilinx_vdma.c index ef67f27..d35317f 100644 --- a/drivers/dma/xilinx/xilinx_vdma.c

[PATCH] saa7164: Replace if and BUG with BUG_ON

ed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/media/pci/saa7164/saa7164-encoder.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-encoder.c b/drivers/media/pci/saa7164/saa7164-encoder.c index 1b184c3..32a353d 100644 -

[PATCH] saa7164: Replace if and BUG with BUG_ON

ed-off-by: Amitoj Kaur Chawla --- drivers/media/pci/saa7164/saa7164-encoder.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/pci/saa7164/saa7164-encoder.c b/drivers/media/pci/saa7164/saa7164-encoder.c index 1b184c3..32a353d 100644 --- a/drivers/media/pci/s

[PATCH] mtd: Replace if and BUG with BUG_ON

ed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/mtd/ssfdc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index daf82ba..41b13d1 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -380,8 +380,7 @

[PATCH] mtd: Replace if and BUG with BUG_ON

ed-off-by: Amitoj Kaur Chawla --- drivers/mtd/ssfdc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mtd/ssfdc.c b/drivers/mtd/ssfdc.c index daf82ba..41b13d1 100644 --- a/drivers/mtd/ssfdc.c +++ b/drivers/mtd/ssfdc.c @@ -380,8 +380,7 @@ static int ssfdcr_readsect(

[PATCH] um: Eliminate null test after alloc_bootmem

alloc_bootmem function never returns NULL. Thus a NULL test after a call to this function is unnecessary. The Coccinelle semantic patch used to make this change is follows: @@ expression E; statement S; @@ E = alloc_bootmem(...) ... when != E - if (E == NULL) S Signed-off-by: Amitoj Kaur Chawla

[PATCH] um: Eliminate null test after alloc_bootmem

alloc_bootmem function never returns NULL. Thus a NULL test after a call to this function is unnecessary. The Coccinelle semantic patch used to make this change is follows: @@ expression E; statement S; @@ E = alloc_bootmem(...) ... when != E - if (E == NULL) S Signed-off-by: Amitoj Kaur Chawla

[PATCH] drbd: Replace if and BUG with BUG_ON

{ BUG(); } + BUG_ON(E); ) @@ expression E,f; @@ ( if (<+... f(...) ...+>) { BUG(); } | - if (E) { BUG(); } + BUG_ON(E); ) Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/block/drbd/drbd_state.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/

[PATCH] drbd: Replace if and BUG with BUG_ON

{ BUG(); } + BUG_ON(E); ) @@ expression E,f; @@ ( if (<+... f(...) ...+>) { BUG(); } | - if (E) { BUG(); } + BUG_ON(E); ) Signed-off-by: Amitoj Kaur Chawla --- drivers/block/drbd/drbd_state.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/drbd/drbd_state

[PATCH] mailbox: Fix devm_ioremap_resource error detection code

devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. The Coccinelle semantic patch used to make this change is as follows: @@ expression e,e1; statement S; @@ *e = devm_ioremap_resource(...); if (!e1) S Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- d

[PATCH] mailbox: Fix devm_ioremap_resource error detection code

devm_ioremap_resource returns an ERR_PTR value, not NULL, on failure. The Coccinelle semantic patch used to make this change is as follows: @@ expression e,e1; statement S; @@ *e = devm_ioremap_resource(...); if (!e1) S Signed-off-by: Amitoj Kaur Chawla --- drivers/mailbox/mailbox-sti.c | 4

[PATCH] dm thin: Remove return statement from void function

Return statement at the end of a void function is useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/md/d

[PATCH] dm thin: Remove return statement from void function

Return statement at the end of a void function is useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla --- drivers/md/dm-thin.c | 2 +- 1 file chan

[PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue

of alloc_ordered_workqueue. WQ_MEM_RECLAIM flag has been set since ethernet devices seem to sit in memory reclaim path, so to guarantee forward progress regardless of memory pressure. Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> Acked-by: Tejun Heo <t...@kernel.org>

[PATCH] qlge: Replace create_singlethread_workqueue with alloc_ordered_workqueue

of alloc_ordered_workqueue. WQ_MEM_RECLAIM flag has been set since ethernet devices seem to sit in memory reclaim path, so to guarantee forward progress regardless of memory pressure. Signed-off-by: Amitoj Kaur Chawla Acked-by: Tejun Heo --- Not sure if the assumption of requiring ordering of work items

[PATCH] can: mcp251x: Replace create_freezable_workqueue with alloc_workqueue

ere is required. WQ_MEM_RECLAIM flag has been set here to ensure forward progress regardless of memory pressure. The order of execution is not important so set @max_active as 0. Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> Acked-by: Tejun Heo <t...@kernel.org> --- driv

[PATCH] can: mcp251x: Replace create_freezable_workqueue with alloc_workqueue

ere is required. WQ_MEM_RECLAIM flag has been set here to ensure forward progress regardless of memory pressure. The order of execution is not important so set @max_active as 0. Signed-off-by: Amitoj Kaur Chawla Acked-by: Tejun Heo --- drivers/net/can/spi/mcp251x.c | 3 ++- 1 file changed

[PATCH v2] misc: mic: Remove return statements from void functions

Return statements at the end of void functions are useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- C

[PATCH v2] misc: mic: Remove return statements from void functions

Return statements at the end of void functions are useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Resend to add

[PATCH] iio: light: tsl2563: Remove flush_scheduled_work

ies of flush_scheduled_work(). Acked-by: Tejun Heo <t...@kernel.org> Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/iio/light/tsl2563.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c index 1

[PATCH] iio: light: tsl2563: Remove flush_scheduled_work

ies of flush_scheduled_work(). Acked-by: Tejun Heo Signed-off-by: Amitoj Kaur Chawla --- drivers/iio/light/tsl2563.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/light/tsl2563.c b/drivers/iio/light/tsl2563.c index 12731d6..57b108c 100644 --- a/drivers/iio/light/tsl256

[PATCH] misc: mic: Remove return statements from void functions

Return statements at the end of void functions are useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/m

[PATCH] misc: mic: Remove return statements from void functions

Return statements at the end of void functions are useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla --- drivers/misc/mic/host/mic_boot.c | 6 +++

[PATCH] crypto: n2 - Remove return statement from void function

Return statement at the end of a void function is useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- drivers/cryp

[PATCH] crypto: n2 - Remove return statement from void function

Return statement at the end of a void function is useless. The Coccinelle semantic patch used to make this change is as follows: // @@ identifier f; expression e; @@ void f(...) { <... - return e; ...> } // Signed-off-by: Amitoj Kaur Chawla --- drivers/crypto/n2_core.c | 2 +- 1 file c

Re: [PATCH 1/2] Staging: atm: fix 'endianess' spelling to 'endianness' in fore200e.c This is a patch to the fore200e that fixes the spelling of 'endianess' to the correct one, that is, 'endianness' fo

On Thu, Mar 10, 2016 at 11:00 AM, rneha725 wrote: > Signed-off-by: Neha Rani > --- Hi Neha, You should ideally submit patches for drivers/staging/ as a newbie and not other drivers. Other than that, Your subject is too long and you haven't written a

Re: [PATCH 1/2] Staging: atm: fix 'endianess' spelling to 'endianness' in fore200e.c This is a patch to the fore200e that fixes the spelling of 'endianess' to the correct one, that is, 'endianness' fo

On Thu, Mar 10, 2016 at 11:00 AM, rneha725 wrote: > Signed-off-by: Neha Rani > --- Hi Neha, You should ideally submit patches for drivers/staging/ as a newbie and not other drivers. Other than that, Your subject is too long and you haven't written a commit message, A better way to write the

[PATCH v2 2/6] leds: lp8788: Use devm_led_classdev_register

= - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } // Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- Changes

[PATCH v2 3/6] leds: wm831x-status: Use devm_led_classdev_register

= - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } // Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- Changes

[PATCH v2 5/6] leds: da903x: Use devm_led_classdev_register

= - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } // Signed-off-by: Amitoj Kaur Chawla <amitoj1...@gmail.com> --- Changes

[PATCH v2 2/6] leds: lp8788: Use devm_led_classdev_register

= - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } // Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Remove unnecessary

[PATCH v2 3/6] leds: wm831x-status: Use devm_led_classdev_register

= - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } // Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Remove unnecessary

[PATCH v2 5/6] leds: da903x: Use devm_led_classdev_register

= - led_classdev_register + devm_led_classdev_register (...); ... ?- led_classdev_unregister(...); ... } @remove depends on prb@ identifier platform.removefn; @@ removefn(...) { ... ?- led_classdev_unregister(...); ... } // Signed-off-by: Amitoj Kaur Chawla --- Changes in v2: -Remove unnecessary

<    1   2   3   4   >