[no subject]

2018-05-12 Thread Badari Pulavarty
hi Lkml https://bit.ly/2KhYIvQ Badari Pulavarty

[no subject]

2018-05-12 Thread Badari Pulavarty
hi Lkml https://bit.ly/2KhYIvQ Badari Pulavarty

Hi lkml

2016-02-15 Thread Badari Pulavarty
Good morning lkml http://www.drewlin.me/pitch.php?cause=1va2u3y80rqgv Badari Pulavarty

Hi lkml

2016-02-15 Thread Badari Pulavarty
Good morning lkml http://www.drewlin.me/pitch.php?cause=1va2u3y80rqgv Badari Pulavarty

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Badari Pulavarty
On Thu, 2008-02-14 at 09:12 -0800, Dave Hansen wrote: .. > > > > - Use currently other not exported functions in kernel/resource.c, like > > > > walk_memory_resource (where we would still need the maximum > > > possible number > > > > of pages NR_MEM_SECTIONS) > > > > > > It isn't the act of

Re: [PATCH] drivers/base: export gpl (un)register_memory_notifier

2008-02-14 Thread Badari Pulavarty
On Thu, 2008-02-14 at 09:12 -0800, Dave Hansen wrote: .. - Use currently other not exported functions in kernel/resource.c, like walk_memory_resource (where we would still need the maximum possible number of pages NR_MEM_SECTIONS) It isn't the act of exporting that's the

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-13 Thread Badari Pulavarty
On Wed, 2008-02-13 at 14:09 +0900, Yasunori Goto wrote: > Thanks Badari-san. > > I understand what was occured. :-) > > > On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: > > > > > + /* > > > > > +* Its ugly, but this is the best I

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-13 Thread Badari Pulavarty
On Wed, 2008-02-13 at 14:09 +0900, Yasunori Goto wrote: Thanks Badari-san. I understand what was occured. :-) On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: + /* +* Its ugly, but this is the best I can do - HELP !! +* We don't know where the allocations

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 14:15 -0800, Dave Hansen wrote: > On Tue, 2008-02-12 at 14:07 -0800, Badari Pulavarty wrote: > > On Tue, 2008-02-12 at 13:57 -0800, Dave Hansen wrote: > > > On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: > > > > > > > >

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 14:15 -0800, Dave Hansen wrote: > On Tue, 2008-02-12 at 14:07 -0800, Badari Pulavarty wrote: > > On Tue, 2008-02-12 at 13:57 -0800, Dave Hansen wrote: > > > On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: > > > > > > > >

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 13:57 -0800, Dave Hansen wrote: > On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: > > > > +static void __remove_section(struct zone *zone, unsigned long > > section_nr) > > +{ > > + if (!valid_section_nr(sectio

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 12:59 -0800, Dave Hansen wrote: > On Tue, 2008-02-12 at 09:22 -0800, Badari Pulavarty wrote: > > +static void __remove_section(struct zone *zone, unsigned long > > phys_start_pfn) > > +{ > > + if (!pfn_valid(phys_start_pfn)) > > +

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 17:06 +0900, Yasunori Goto wrote: > > On Mon, 2008-02-11 at 11:48 -0800, Andrew Morton wrote: > > > On Mon, 11 Feb 2008 09:23:18 -0800 > > > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > > > > > Hi Andrew, > > >

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 13:57 -0800, Dave Hansen wrote: On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: +static void __remove_section(struct zone *zone, unsigned long section_nr) +{ + if (!valid_section_nr(section_nr)) + return

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 14:15 -0800, Dave Hansen wrote: On Tue, 2008-02-12 at 14:07 -0800, Badari Pulavarty wrote: On Tue, 2008-02-12 at 13:57 -0800, Dave Hansen wrote: On Tue, 2008-02-12 at 13:56 -0800, Badari Pulavarty wrote: +static void __remove_section(struct zone *zone, unsigned

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 17:06 +0900, Yasunori Goto wrote: On Mon, 2008-02-11 at 11:48 -0800, Andrew Morton wrote: On Mon, 11 Feb 2008 09:23:18 -0800 Badari Pulavarty [EMAIL PROTECTED] wrote: Hi Andrew, While testing hotplug memory remove against -mm, I noticed

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-12 Thread Badari Pulavarty
On Tue, 2008-02-12 at 12:59 -0800, Dave Hansen wrote: On Tue, 2008-02-12 at 09:22 -0800, Badari Pulavarty wrote: +static void __remove_section(struct zone *zone, unsigned long phys_start_pfn) +{ + if (!pfn_valid(phys_start_pfn)) + return; I think you need at least

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-11 Thread Badari Pulavarty
On Mon, 2008-02-11 at 11:48 -0800, Andrew Morton wrote: > On Mon, 11 Feb 2008 09:23:18 -0800 > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > Hi Andrew, > > > > While testing hotplug memory remove against -mm, I noticed > > that unregister_mem

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-11 Thread Badari Pulavarty
On Mon, 2008-02-11 at 09:54 -0800, Greg KH wrote: > On Mon, Feb 11, 2008 at 09:23:18AM -0800, Badari Pulavarty wrote: > > Hi Andrew, > > > > While testing hotplug memory remove against -mm, I noticed > > that unregister_memory() is not cleaning up /sysfs entrie

[-mm PATCH] register_memory/unregister_memory clean ups

2008-02-11 Thread Badari Pulavarty
y() static. Another bug fix - before calling unregister_memory() remove_memory_block() gets a ref on kobject. unregister_memory() need to drop that ref before calling sysdev_unregister(). Signed-off-by: Badari Pulavarty <[EMAIL PROTECTED]> --- drivers/base/memory.c | 22 +++---

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-11 Thread Badari Pulavarty
On Mon, 2008-02-11 at 09:54 -0800, Greg KH wrote: On Mon, Feb 11, 2008 at 09:23:18AM -0800, Badari Pulavarty wrote: Hi Andrew, While testing hotplug memory remove against -mm, I noticed that unregister_memory() is not cleaning up /sysfs entries correctly. It also de-references

[-mm PATCH] register_memory/unregister_memory clean ups

2008-02-11 Thread Badari Pulavarty
. Another bug fix - before calling unregister_memory() remove_memory_block() gets a ref on kobject. unregister_memory() need to drop that ref before calling sysdev_unregister(). Signed-off-by: Badari Pulavarty [EMAIL PROTECTED] --- drivers/base/memory.c | 22 +++--- 1 file changed

Re: [-mm PATCH] register_memory/unregister_memory clean ups

2008-02-11 Thread Badari Pulavarty
On Mon, 2008-02-11 at 11:48 -0800, Andrew Morton wrote: On Mon, 11 Feb 2008 09:23:18 -0800 Badari Pulavarty [EMAIL PROTECTED] wrote: Hi Andrew, While testing hotplug memory remove against -mm, I noticed that unregister_memory() is not cleaning up /sysfs entries correctly. It also de

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Badari Pulavarty
On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > > > > Hi Greg,

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Badari Pulavarty
On Thu, 2008-02-07 at 21:41 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 09:08:42PM -0800, Badari Pulavarty wrote: > > > > On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > > > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > > > On

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Badari Pulavarty
On Thu, 2008-02-07 at 21:41 -0800, Greg KH wrote: On Thu, Feb 07, 2008 at 09:08:42PM -0800, Badari Pulavarty wrote: On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-08 Thread Badari Pulavarty
On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: Hi Greg, While playing with hotplug memory

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: > > On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > > > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > > > > Hi Greg,

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: > On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: > > Hi Greg, > > > > While playing with hotplug memory remove on 2.6.24-mm1, I > > noticed that /sysfs directory entries are not getting removed.

[-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
? With this change, the directories are getting removed correctly. Comments ? Thanks, Badari sysdev_unregister() should call kobject_del() to remove the object. Signed-off-by: Badari Pulavarty <[EMAIL PROTECTED]> --- drivers/base/sys.c |1 + 1 file changed, 1 insertion(+) Index: linux-

[-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
? With this change, the directories are getting removed correctly. Comments ? Thanks, Badari sysdev_unregister() should call kobject_del() to remove the object. Signed-off-by: Badari Pulavarty [EMAIL PROTECTED] --- drivers/base/sys.c |1 + 1 file changed, 1 insertion(+) Index: linux-2.6.24

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: Hi Greg, While playing with hotplug memory remove on 2.6.24-mm1, I noticed that /sysfs directory entries are not getting removed. sysdev_unregister() used to call

Re: [-mm PATCH] sysdev_unregister() should call kobject_del()

2008-02-07 Thread Badari Pulavarty
On Thu, 2008-02-07 at 20:55 -0800, Greg KH wrote: On Thu, Feb 07, 2008 at 05:25:46PM -0800, Badari Pulavarty wrote: On Thu, 2008-02-07 at 16:38 -0800, Greg KH wrote: On Thu, Feb 07, 2008 at 03:56:58PM -0800, Badari Pulavarty wrote: Hi Greg, While playing with hotplug memory

Re: [PATCH] drivers/base: export (un)register_memory_notifier

2008-02-01 Thread Badari Pulavarty
L_GPL() ? Otherwise, looks good to me. I have been planning to send this as part of my next update with ppc64 arch-specific remove support and generic __remove_pages() support. If this is blocking your work, lets get this in. Acked-by: Badari Pulavarty <[EMAIL PROTECTED]> Thanks, Badari -- T

Re: [PATCH] drivers/base: export (un)register_memory_notifier

2008-02-01 Thread Badari Pulavarty
remove support and generic __remove_pages() support. If this is blocking your work, lets get this in. Acked-by: Badari Pulavarty [EMAIL PROTECTED] Thanks, Badari -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [PATCH] dio: falling through to buffered I/O when invalidation of a page fails

2007-12-14 Thread Badari Pulavarty
On Tue, 2007-12-11 at 17:00 -0800, Zach Brown wrote: > Hisashi Hifumi wrote: > > Hi. > > > > Current dio has some problems: > > 1, In ext3 ordered, dio write can return with EIO because of the race > > between invalidation of > > a page and jbd. jbd pins the bhs while committing journal so > >

Re: [PATCH] dio: falling through to buffered I/O when invalidation of a page fails

2007-12-14 Thread Badari Pulavarty
On Tue, 2007-12-11 at 17:00 -0800, Zach Brown wrote: Hisashi Hifumi wrote: Hi. Current dio has some problems: 1, In ext3 ordered, dio write can return with EIO because of the race between invalidation of a page and jbd. jbd pins the bhs while committing journal so

Re: 2.6.24-rc4-mm1 kobject changes broken with hvcs driver on powerpc

2007-12-06 Thread Badari Pulavarty
On Thu, 2007-12-06 at 12:31 -0800, Greg KH wrote: > On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote: > > Greg KH wrote: > > > > >> Why release the spinlock here? It's done after the count is incremented. > > >> This patch does not seem correct. > > > > > > Doh, you are correct, I'll

Re: 2.6.24-rc4-mm1 kobject changes broken with hvcs driver on powerpc

2007-12-06 Thread Badari Pulavarty
On Fri, 2007-12-07 at 00:28 +0530, Balbir Singh wrote: > Greg KH wrote: > > >> Why release the spinlock here? It's done after the count is incremented. > >> This patch does not seem correct. > > > > Doh, you are correct, I'll make sure that I fix this up before applying > > it. > > > > thanks,

Re: 2.6.24-rc4-mm1 kobject changes broken with hvcs driver on powerpc

2007-12-06 Thread Badari Pulavarty
On Fri, 2007-12-07 at 00:28 +0530, Balbir Singh wrote: Greg KH wrote: Why release the spinlock here? It's done after the count is incremented. This patch does not seem correct. Doh, you are correct, I'll make sure that I fix this up before applying it. thanks, greg k-h

Re: 2.6.24-rc4-mm1 kobject changes broken with hvcs driver on powerpc

2007-12-06 Thread Badari Pulavarty
On Thu, 2007-12-06 at 12:31 -0800, Greg KH wrote: On Fri, Dec 07, 2007 at 12:28:58AM +0530, Balbir Singh wrote: Greg KH wrote: Why release the spinlock here? It's done after the count is incremented. This patch does not seem correct. Doh, you are correct, I'll make sure that I

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

2007-11-06 Thread Badari Pulavarty
On Tue, 2007-11-06 at 02:33 -0800, [EMAIL PROTECTED] wrote: > The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz > > It contains the following patches against 2.6.24-rc1:

Re: mm snapshot broken-out-2007-11-06-02-32 - powerpc link failure

2007-11-06 Thread Badari Pulavarty
On Tue, 2007-11-06 at 23:47 +0530, Kamalesh Babulal wrote: > Hi Andrew, > > The kernel linking fails on the powerpc, with following error message > > CC init/version.o > LD init/built-in.o > LD .tmp_vmlinux1 > arch/powerpc/kernel/built-in.o(.toc+0x1550): undefined reference

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

2007-11-06 Thread Badari Pulavarty
On Tue, 2007-11-06 at 02:33 -0800, [EMAIL PROTECTED] wrote: > The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz > >

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build failure - rpadlpar_sysfs

2007-11-06 Thread Badari Pulavarty
[drivers/pci/hotplug] Error 2 > make[1]: *** [drivers/pci] Error 2 > make: *** [drivers] Error 2 > > The patch, > gregkh-driver-kset-convert-pci-hotplug-to-use-kset_create_and_register.patch > is causing the build failure. Here is the fix (against 24-rc1 mm-brokenout). Can you

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build fails on powerpc

2007-11-06 Thread Badari Pulavarty
On Tue, 2007-11-06 at 18:27 +0530, Kamalesh Babulal wrote: > [EMAIL PROTECTED] wrote: > > powerpc-move-_rtc_time-routines-under-config_adb_cuda.patch > > CC net/9p/error.o > arch/powerpc/platforms/powermac/time.c:168: error: implicit declaration of > function ‘from_rtc_time’ >

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build fails on powerpc

2007-11-06 Thread Badari Pulavarty
On Tue, 2007-11-06 at 18:27 +0530, Kamalesh Babulal wrote: [EMAIL PROTECTED] wrote: powerpc-move-_rtc_time-routines-under-config_adb_cuda.patch CC net/9p/error.o arch/powerpc/platforms/powermac/time.c:168: error: implicit declaration of function ‘from_rtc_time’

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded - build failure - rpadlpar_sysfs

2007-11-06 Thread Badari Pulavarty
: *** [drivers] Error 2 The patch, gregkh-driver-kset-convert-pci-hotplug-to-use-kset_create_and_register.patch is causing the build failure. Here is the fix (against 24-rc1 mm-brokenout). Can you try it ? Thanks, Badari Signed-off-by: Badari Pulavarty [EMAIL PROTECTED] --- drivers/pci/hotplug

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

2007-11-06 Thread Badari Pulavarty
On Tue, 2007-11-06 at 02:33 -0800, [EMAIL PROTECTED] wrote: The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz gregkh-driver-kset-convert-sys-devices-to-use-kset_create.patch

Re: mm snapshot broken-out-2007-11-06-02-32 - powerpc link failure

2007-11-06 Thread Badari Pulavarty
On Tue, 2007-11-06 at 23:47 +0530, Kamalesh Babulal wrote: Hi Andrew, The kernel linking fails on the powerpc, with following error message CC init/version.o LD init/built-in.o LD .tmp_vmlinux1 arch/powerpc/kernel/built-in.o(.toc+0x1550): undefined reference to

Re: mm snapshot broken-out-2007-11-06-02-32.tar.gz uploaded

2007-11-06 Thread Badari Pulavarty
On Tue, 2007-11-06 at 02:33 -0800, [EMAIL PROTECTED] wrote: The mm snapshot broken-out-2007-11-06-02-32.tar.gz has been uploaded to ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-11-06-02-32.tar.gz It contains the following patches against 2.6.24-rc1: Getting

Re: [PATCH] Add IORESOUCE_BUSY flag for System RAM (Re: [Question] How to represent SYSTEM_RAM in kerenel/resouce.c)

2007-11-01 Thread Badari Pulavarty
ORESOURCE_BUSY; > if (request_resource(_resource, res) < 0) { > printk("System RAM resource %llx - %llx cannot be added\n", > (unsigned long long)res->start, (unsigned long long)res->end); > Not quite.. You need following patch on top of thi

Re: [PATCH] Add IORESOUCE_BUSY flag for System RAM (Re: [Question] How to represent SYSTEM_RAM in kerenel/resouce.c)

2007-11-01 Thread Badari Pulavarty
resource BUSY, walk_memory_resource() won't be able to find it. Signed-off-by: Badari Pulavarty [EMAIL PROTECTED] --- kernel/resource.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.24-rc1/kernel/resource.c

[PATCH] vortex_up should initialize "err"

2007-10-17 Thread Badari Pulavarty
Simple compile warning fix. (against 2.6.23-git12) Thanks, Badari vortex_up() should initialize 'err' for a successful return. drivers/net/3c59x.c: In function `vortex_up': drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this function Signed-off-by: Badari Pulavarty

[PATCH] Move _rtc_time() routines under CONFIG_ADB_CUDA

2007-10-17 Thread Badari Pulavarty
/powermac/time.c:95: warning: `from_rtc_time' defined but not used Signed-off-by: Badari Pulavarty <[EMAIL PROTECTED]> --- arch/powerpc/platforms/powermac/time.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.23/arch/powerpc/platforms/powermac/

[PATCH] ip_gra_reasm() should set "err" incase of skb_clone() failure

2007-10-17 Thread Badari Pulavarty
Simple error handling fix (against 2.26.23-git12). Thanks, Badari Need to initialize "err" in case of skb_clone() failure. net/ipv4/ip_fragment.c: In function `ip_defrag': net/ipv4/ip_fragment.c:540: warning: `err' might be used uninitialized in this function Signed-off-by: Badari

Re: 2.6.23-git11 compile issues

2007-10-17 Thread Badari Pulavarty
On Wed, 2007-10-17 at 18:38 +0300, Ismail Dönmez wrote: > Wednesday 17 October 2007 Tarihinde 18:33:18 yazmıştı: > > Known issue ? > > > > > > Thanks, > > Badari > > > > CHK include/linux/version.h > > CHK include/linux/utsrelease.h > > CC arch/x86/kernel/asm-offsets.s > > In

[PATCH] ip_gra_reasm() should set err incase of skb_clone() failure

2007-10-17 Thread Badari Pulavarty
Simple error handling fix (against 2.26.23-git12). Thanks, Badari Need to initialize err in case of skb_clone() failure. net/ipv4/ip_fragment.c: In function `ip_defrag': net/ipv4/ip_fragment.c:540: warning: `err' might be used uninitialized in this function Signed-off-by: Badari Pulavarty

[PATCH] Move _rtc_time() routines under CONFIG_ADB_CUDA

2007-10-17 Thread Badari Pulavarty
/powermac/time.c:95: warning: `from_rtc_time' defined but not used Signed-off-by: Badari Pulavarty [EMAIL PROTECTED] --- arch/powerpc/platforms/powermac/time.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-2.6.23/arch/powerpc/platforms/powermac/time.c

[PATCH] vortex_up should initialize err

2007-10-17 Thread Badari Pulavarty
Simple compile warning fix. (against 2.6.23-git12) Thanks, Badari vortex_up() should initialize 'err' for a successful return. drivers/net/3c59x.c: In function `vortex_up': drivers/net/3c59x.c:1494: warning: `err' might be used uninitialized in this function Signed-off-by: Badari Pulavarty

Re: 2.6.23-git11 compile issues

2007-10-17 Thread Badari Pulavarty
On Wed, 2007-10-17 at 18:38 +0300, Ismail Dönmez wrote: Wednesday 17 October 2007 Tarihinde 18:33:18 yazmıştı: Known issue ? Thanks, Badari CHK include/linux/version.h CHK include/linux/utsrelease.h CC arch/x86/kernel/asm-offsets.s In file included from

Re: 2.6.23-rc9: Oops in cache_alloc_refill() mm/slab.c

2007-10-05 Thread Badari Pulavarty
On Fri, 2007-10-05 at 15:41 +0200, Valerie Clement wrote: > Badari Pulavarty wrote: > > On Thu, 2007-10-04 at 18:13 +0200, Valerie Clement wrote: > >> While running ffsb tests on my ext4 filesystem, I got an Oops in > >> cache_alloc_refill(). > >>

Re: 2.6.23-rc9: Oops in cache_alloc_refill() mm/slab.c

2007-10-05 Thread Badari Pulavarty
On Fri, 2007-10-05 at 15:41 +0200, Valerie Clement wrote: Badari Pulavarty wrote: On Thu, 2007-10-04 at 18:13 +0200, Valerie Clement wrote: While running ffsb tests on my ext4 filesystem, I got an Oops in cache_alloc_refill(). I turned on SLAB debugging and here is the message I got

Re: 2.6.23-rc9: Oops in cache_alloc_refill() mm/slab.c

2007-10-04 Thread Badari Pulavarty
On Thu, 2007-10-04 at 18:13 +0200, Valerie Clement wrote: > While running ffsb tests on my ext4 filesystem, I got an Oops in > cache_alloc_refill(). > I turned on SLAB debugging and here is the message I got: > > slab: Internal list corruption detected in cache 'buffer_head'(30), > slabp

Re: 2.6.23-rc9: Oops in cache_alloc_refill() mm/slab.c

2007-10-04 Thread Badari Pulavarty
On Thu, 2007-10-04 at 18:13 +0200, Valerie Clement wrote: While running ffsb tests on my ext4 filesystem, I got an Oops in cache_alloc_refill(). I turned on SLAB debugging and here is the message I got: slab: Internal list corruption detected in cache 'buffer_head'(30), slabp

Re: kernel Oops in ext3 code

2007-09-28 Thread Badari Pulavarty
On Fri, 2007-09-28 at 06:54 +0200, Norbert Preining wrote: > Hi Mingming, > > On Do, 27 Sep 2007, Mingming Cao wrote: > > Could you please sent the objdump of the ext4_discard_reservation > > function? It doesn't match what I see here. > > I assume you meant ext3_ I made > objdump -x

Re: kernel Oops in ext3 code

2007-09-28 Thread Badari Pulavarty
On Fri, 2007-09-28 at 06:54 +0200, Norbert Preining wrote: Hi Mingming, On Do, 27 Sep 2007, Mingming Cao wrote: Could you please sent the objdump of the ext4_discard_reservation function? It doesn't match what I see here. I assume you meant ext3_ I made objdump -x -D -s

Re: 2.6.23-rc8-mm1

2007-09-25 Thread Badari Pulavarty
a cast vmemmap_section_start() gets called with an argument which is unsigned long. Signed-off-by: Badari Pulavarty <[EMAIL PROTECTED]> Index: linux-2.6.23-rc8/arch/powerpc/mm/init_64.c === --- linux-2.6.23-rc8.orig/arch/powe

Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure

2007-09-25 Thread Badari Pulavarty
k_action': > /root/scrap/linux-2.6.23-rc8/drivers/base/memory.c:188: undefined reference > to `.remove_memory' > make: *** [.tmp_vmlinux1] Error 1 > I ran into the same thing earlier. Here is the fix I made. Thanks, Badari Memory hotplug remove is currently supported only on IA64 Sig

Re: Linux 2.6.23-rc8 (build failure from -rc1)

2007-09-25 Thread Badari Pulavarty
On Tue, 2007-09-25 at 10:02 -0700, Andrew Morton wrote: > On Tue, 25 Sep 2007 09:57:01 -0700 Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > On Mon, 2007-09-24 at 17:46 -0700, Linus Torvalds wrote: > > > Ok, I think I'm getting close to releasing a real 2.6.23. Things

Re: Linux 2.6.23-rc8 (build failure from -rc1)

2007-09-25 Thread Badari Pulavarty
On Mon, 2007-09-24 at 17:46 -0700, Linus Torvalds wrote: > Ok, I think I'm getting close to releasing a real 2.6.23. Things seem to > have calmed down, and I think Thomas Gleixner may have found the > suspend/resume regression that has dogged us for a while, so I'm feeling > happy about things.

Re: Linux 2.6.23-rc8 (build failure from -rc1)

2007-09-25 Thread Badari Pulavarty
On Mon, 2007-09-24 at 17:46 -0700, Linus Torvalds wrote: Ok, I think I'm getting close to releasing a real 2.6.23. Things seem to have calmed down, and I think Thomas Gleixner may have found the suspend/resume regression that has dogged us for a while, so I'm feeling happy about things.

Re: Linux 2.6.23-rc8 (build failure from -rc1)

2007-09-25 Thread Badari Pulavarty
On Tue, 2007-09-25 at 10:02 -0700, Andrew Morton wrote: On Tue, 25 Sep 2007 09:57:01 -0700 Badari Pulavarty [EMAIL PROTECTED] wrote: On Mon, 2007-09-24 at 17:46 -0700, Linus Torvalds wrote: Ok, I think I'm getting close to releasing a real 2.6.23. Things seem to have calmed down, and I

Re: 2.6.23-rc8-mm1 - powerpc memory hotplug link failure

2007-09-25 Thread Badari Pulavarty
-2.6.23-rc8/drivers/base/memory.c:188: undefined reference to `.remove_memory' make: *** [.tmp_vmlinux1] Error 1 I ran into the same thing earlier. Here is the fix I made. Thanks, Badari Memory hotplug remove is currently supported only on IA64 Signed-off-by: Badari Pulavarty [EMAIL PROTECTED

Re: 2.6.23-rc8-mm1

2007-09-25 Thread Badari Pulavarty
a cast vmemmap_section_start() gets called with an argument which is unsigned long. Signed-off-by: Badari Pulavarty [EMAIL PROTECTED] Index: linux-2.6.23-rc8/arch/powerpc/mm/init_64.c === --- linux-2.6.23-rc8.orig/arch/powerpc/mm

Re: 2.6.23-rc6: hanging ext3 dbench tests

2007-09-24 Thread Badari Pulavarty
On Mon, 2007-09-24 at 13:04 -0700, Linus Torvalds wrote: > > On Mon, 24 Sep 2007, Badari Pulavarty wrote: > > > > Whats happening on my machine is .. > > > > dbench forks of 4 children and sends them a signal to start the work. > > 3 out of 4 children ge

Re: 2.6.23-rc6: hanging ext3 dbench tests

2007-09-24 Thread Badari Pulavarty
On Mon, 2007-09-24 at 13:04 -0700, Linus Torvalds wrote: > > On Mon, 24 Sep 2007, Badari Pulavarty wrote: > > > > Whats happening on my machine is .. > > > > dbench forks of 4 children and sends them a signal to start the work. > > 3 out of 4 children ge

Re: 2.6.23-rc6: hanging ext3 dbench tests

2007-09-24 Thread Badari Pulavarty
Hi Andy, I managed to reproduce the dbench problem. (not sure if its the same thing or not - but symptoms are same). My problem has nothing to do with ext3. I can produce it on ext2, jfs also. Whats happening on my machine is .. dbench forks of 4 children and sends them a signal to start the

Re: 2.6.23-rc6: hanging ext3 dbench tests

2007-09-24 Thread Badari Pulavarty
Hi Andy, I managed to reproduce the dbench problem. (not sure if its the same thing or not - but symptoms are same). My problem has nothing to do with ext3. I can produce it on ext2, jfs also. Whats happening on my machine is .. dbench forks of 4 children and sends them a signal to start the

Re: 2.6.23-rc6: hanging ext3 dbench tests

2007-09-24 Thread Badari Pulavarty
On Mon, 2007-09-24 at 13:04 -0700, Linus Torvalds wrote: On Mon, 24 Sep 2007, Badari Pulavarty wrote: Whats happening on my machine is .. dbench forks of 4 children and sends them a signal to start the work. 3 out of 4 children gets the signal and does the work. One of the child

Re: 2.6.23-rc6: hanging ext3 dbench tests

2007-09-24 Thread Badari Pulavarty
On Mon, 2007-09-24 at 13:04 -0700, Linus Torvalds wrote: On Mon, 24 Sep 2007, Badari Pulavarty wrote: Whats happening on my machine is .. dbench forks of 4 children and sends them a signal to start the work. 3 out of 4 children gets the signal and does the work. One of the child

Re: [PATCH] ext4: FLEX_BG Kernel support v2.

2007-09-21 Thread Badari Pulavarty
On Fri, 2007-09-21 at 09:06 -0500, Jose R. Santos wrote: > From: Jose R. Santos <[EMAIL PROTECTED]> > > ext4: FLEX_BG Kernel support v2. > > @@ -702,13 +702,15 @@ static inline int ext4_valid_inum(struct super_block > *sb, unsigned long ino) > #define EXT4_FEATURE_INCOMPAT_META_BG

Re: [PATCH] ext4: FLEX_BG Kernel support v2.

2007-09-21 Thread Badari Pulavarty
On Fri, 2007-09-21 at 09:06 -0500, Jose R. Santos wrote: From: Jose R. Santos [EMAIL PROTECTED] ext4: FLEX_BG Kernel support v2. @@ -702,13 +702,15 @@ static inline int ext4_valid_inum(struct super_block *sb, unsigned long ino) #define EXT4_FEATURE_INCOMPAT_META_BG

Re: 2.6.23-rc6-mm1 panic (memory controller issue ?)

2007-09-18 Thread Badari Pulavarty
On Tue, 2007-09-18 at 15:21 -0700, Badari Pulavarty wrote: > Hi Balbir, > > I get following panic from SLUB, while doing simple fsx tests. > I haven't used any container/memory controller stuff except > that I configured them in :( > > Looks like slub doesn't like on

2.6.23-rc6-mm1 panic (memory controller issue ?)

2007-09-18 Thread Badari Pulavarty
Hi Balbir, I get following panic from SLUB, while doing simple fsx tests. I haven't used any container/memory controller stuff except that I configured them in :( Looks like slub doesn't like one of the flags passed in ? Known issue ? Ideas ? Thanks, Badari CONFIG_CONTAINERS=y

2.6.23-rc6-mm1 panic (memory controller issue ?)

2007-09-18 Thread Badari Pulavarty
Hi Balbir, I get following panic from SLUB, while doing simple fsx tests. I haven't used any container/memory controller stuff except that I configured them in :( Looks like slub doesn't like one of the flags passed in ? Known issue ? Ideas ? Thanks, Badari CONFIG_CONTAINERS=y

Re: 2.6.23-rc6-mm1 panic (memory controller issue ?)

2007-09-18 Thread Badari Pulavarty
On Tue, 2007-09-18 at 15:21 -0700, Badari Pulavarty wrote: Hi Balbir, I get following panic from SLUB, while doing simple fsx tests. I haven't used any container/memory controller stuff except that I configured them in :( Looks like slub doesn't like one of the flags passed in ? Known

Re: [PATCH] JBD slab cleanups

2007-09-17 Thread Badari Pulavarty
On Mon, 2007-09-17 at 12:29 -0700, Mingming Cao wrote: > On Fri, 2007-09-14 at 11:53 -0700, Mingming Cao wrote: > > jbd/jbd2: Replace slab allocations with page cache allocations > > > > From: Christoph Lameter <[EMAIL PROTECTED]> > > > > JBD should not pass slab pages down to the block layer. >

Re: [PATCH] JBD slab cleanups

2007-09-17 Thread Badari Pulavarty
On Mon, 2007-09-17 at 12:29 -0700, Mingming Cao wrote: On Fri, 2007-09-14 at 11:53 -0700, Mingming Cao wrote: jbd/jbd2: Replace slab allocations with page cache allocations From: Christoph Lameter [EMAIL PROTECTED] JBD should not pass slab pages down to the block layer. Use page

Re: [PATCH] add check do_direct_IO() return val

2007-07-31 Thread Badari Pulavarty
On Tue, 2007-07-31 at 15:34 -0700, Andrew Morton wrote: > On Tue, 31 Jul 2007 15:25:11 -0700 > Badari Pulavarty <[EMAIL PROTECTED]> wrote: > > > + dio->map_bh.b_state = 0; > > ho hum, thanks. > > We zero out so many fields in there now that a kzalloc()

Re: [PATCH] add check do_direct_IO() return val

2007-07-31 Thread Badari Pulavarty
fer state. Thanks, Badari Need to initialize map_bh.b_state to zero. Otherwise, in case of a faulty user-buffer its possible to go into dio_zero_block() and submit a page by mistake - since it checks for buffer_new(). http://marc.info/?l=linux-kernel=118551339032528=2 Signed-off-by: Badari Pulavarty <[E

Re: [PATCH] add check do_direct_IO() return val

2007-07-31 Thread Badari Pulavarty
map_bh.b_state to zero. Otherwise, in case of a faulty user-buffer its possible to go into dio_zero_block() and submit a page by mistake - since it checks for buffer_new(). http://marc.info/?l=linux-kernelm=118551339032528w=2 Signed-off-by: Badari Pulavarty [EMAIL PROTECTED] --- fs/direct-io.c |1

Re: [PATCH] add check do_direct_IO() return val

2007-07-31 Thread Badari Pulavarty
On Tue, 2007-07-31 at 15:34 -0700, Andrew Morton wrote: On Tue, 31 Jul 2007 15:25:11 -0700 Badari Pulavarty [EMAIL PROTECTED] wrote: + dio-map_bh.b_state = 0; ho hum, thanks. We zero out so many fields in there now that a kzalloc() might yield a net gain. 0.01% in an unnamed

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
On Mon, 2007-07-30 at 16:38 -0700, Zach Brown wrote: > On Jul 30, 2007, at 2:58 PM, Badari Pulavarty wrote: > > > On Mon, 2007-07-30 at 14:45 -0700, Zach Brown wrote: > >>> I am also taking a look at it right now. > >> > >> Are we having a race

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
On Mon, 2007-07-30 at 16:38 -0700, Zach Brown wrote: > On Jul 30, 2007, at 2:58 PM, Badari Pulavarty wrote: > > > On Mon, 2007-07-30 at 14:45 -0700, Zach Brown wrote: > >>> I am also taking a look at it right now. > >> > >> Are we having a race

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
On Mon, 2007-07-30 at 14:45 -0700, Zach Brown wrote: > > I am also taking a look at it right now. > > Are we having a race to write a little test app that reproduces the > problem? :) Nope. Feel free to write the test case. I am just looking at the code to see what needs to be done. Thanks,

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
On Mon, 2007-07-30 at 13:53 -0700, Andrew Morton wrote: > On Sat, 28 Jul 2007 11:47:19 +0800 > Joe Jin <[EMAIL PROTECTED]> wrote: > > > > I tested Andrew's patch and panic was gone but got few ENOTBLK. > > > So I tried with Joe's patch , both panic and ENOTBLK are gone now. > > > But in Joe's

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
On Mon, 2007-07-30 at 13:53 -0700, Andrew Morton wrote: On Sat, 28 Jul 2007 11:47:19 +0800 Joe Jin [EMAIL PROTECTED] wrote: I tested Andrew's patch and panic was gone but got few ENOTBLK. So I tried with Joe's patch , both panic and ENOTBLK are gone now. But in Joe's patch if (ret ==

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
On Mon, 2007-07-30 at 14:45 -0700, Zach Brown wrote: I am also taking a look at it right now. Are we having a race to write a little test app that reproduces the problem? :) Nope. Feel free to write the test case. I am just looking at the code to see what needs to be done. Thanks, Badari

Re: [PATCH] add check do_direct_IO() return val

2007-07-30 Thread Badari Pulavarty
On Mon, 2007-07-30 at 16:38 -0700, Zach Brown wrote: On Jul 30, 2007, at 2:58 PM, Badari Pulavarty wrote: On Mon, 2007-07-30 at 14:45 -0700, Zach Brown wrote: I am also taking a look at it right now. Are we having a race to write a little test app that reproduces the problem

  1   2   3   4   >