[PATCH v2 12/14] thermal: exynos: remove separate exynos_tmu.h header file

2018-04-16 Thread Bartlomiej Zolnierkiewicz
exynos_tmu.h is used only by exynos_tmu.c so there is no need for a separate include file. Also while at it remove no longer needed cpu_cooling.h include. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com>

[PATCH v2 12/14] thermal: exynos: remove separate exynos_tmu.h header file

2018-04-16 Thread Bartlomiej Zolnierkiewicz
exynos_tmu.h is used only by exynos_tmu.c so there is no need for a separate include file. Also while at it remove no longer needed cpu_cooling.h include. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz Acked-by: Daniel Lezcano

Re: [PATCH 14/14] arm64: dts: exynos: remove no longer needed samsung thermal properties

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 03:02:45 PM Daniel Lezcano wrote: > On 16/04/2018 12:12, Bartlomiej Zolnierkiewicz wrote: > > Remove no longer needed samsung thermal properties. > > > > There should be no functional changes caused by this patch. > > > > Signed-

Re: [PATCH 14/14] arm64: dts: exynos: remove no longer needed samsung thermal properties

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 03:02:45 PM Daniel Lezcano wrote: > On 16/04/2018 12:12, Bartlomiej Zolnierkiewicz wrote: > > Remove no longer needed samsung thermal properties. > > > > There should be no functional changes caused by this patch. > > > > Signed-

Re: [PATCH 02/14] thermal: exynos: Propagate error value from tmu_read()

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 02:54:01 PM Daniel Lezcano wrote: > On 16/04/2018 14:49, Bartlomiej Zolnierkiewicz wrote: > > On Monday, April 16, 2018 02:41:48 PM Daniel Lezcano wrote: > >> On 16/04/2018 14:35, Bartlomiej Zolnierkiewicz wrote: > >>> On Monday, April 16, 2

Re: [PATCH 02/14] thermal: exynos: Propagate error value from tmu_read()

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 02:54:01 PM Daniel Lezcano wrote: > On 16/04/2018 14:49, Bartlomiej Zolnierkiewicz wrote: > > On Monday, April 16, 2018 02:41:48 PM Daniel Lezcano wrote: > >> On 16/04/2018 14:35, Bartlomiej Zolnierkiewicz wrote: > >>> On Monday, April 16, 2

Re: [PATCH 02/14] thermal: exynos: Propagate error value from tmu_read()

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 02:41:48 PM Daniel Lezcano wrote: > On 16/04/2018 14:35, Bartlomiej Zolnierkiewicz wrote: > > On Monday, April 16, 2018 02:16:56 PM Daniel Lezcano wrote: > >> On 16/04/2018 12:11, Bartlomiej Zolnierkiewicz wrote: > >>> From: Marek Szypro

Re: [PATCH 02/14] thermal: exynos: Propagate error value from tmu_read()

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 02:41:48 PM Daniel Lezcano wrote: > On 16/04/2018 14:35, Bartlomiej Zolnierkiewicz wrote: > > On Monday, April 16, 2018 02:16:56 PM Daniel Lezcano wrote: > >> On 16/04/2018 12:11, Bartlomiej Zolnierkiewicz wrote: > >>> From: Marek Sz

Re: [PATCH 03/14] thermal: exynos: Read soc_type from match data

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 02:19:30 PM Daniel Lezcano wrote: > On 16/04/2018 12:11, Bartlomiej Zolnierkiewicz wrote: > > From: Maciej Purski <m.pur...@samsung.com> > > > > Device context's field data->soc is currently obtained by comparing > > of_compatibl

Re: [PATCH 03/14] thermal: exynos: Read soc_type from match data

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 02:19:30 PM Daniel Lezcano wrote: > On 16/04/2018 12:11, Bartlomiej Zolnierkiewicz wrote: > > From: Maciej Purski > > > > Device context's field data->soc is currently obtained by comparing > > of_compatible's. Provide soc_type as .data fie

Re: [PATCH 02/14] thermal: exynos: Propagate error value from tmu_read()

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 02:16:56 PM Daniel Lezcano wrote: > On 16/04/2018 12:11, Bartlomiej Zolnierkiewicz wrote: > > From: Marek Szyprowski <m.szyprow...@samsung.com> > > > > tmu_read() in case of Exynos4210 might return error for out of bound > > values. Curr

Re: [PATCH 02/14] thermal: exynos: Propagate error value from tmu_read()

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 02:16:56 PM Daniel Lezcano wrote: > On 16/04/2018 12:11, Bartlomiej Zolnierkiewicz wrote: > > From: Marek Szyprowski > > > > tmu_read() in case of Exynos4210 might return error for out of bound > > values. Current code ignores such val

Re: [PATCH 01/14] thermal: exynos: Reading temperature makes sense only when TMU is turned on

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 02:06:41 PM Daniel Lezcano wrote: > On 16/04/2018 12:11, Bartlomiej Zolnierkiewicz wrote: > > From: Marek Szyprowski <m.szyprow...@samsung.com> > > > > When thermal sensor is not yet enabled, reading temperature might return > > ran

Re: [PATCH 01/14] thermal: exynos: Reading temperature makes sense only when TMU is turned on

2018-04-16 Thread Bartlomiej Zolnierkiewicz
On Monday, April 16, 2018 02:06:41 PM Daniel Lezcano wrote: > On 16/04/2018 12:11, Bartlomiej Zolnierkiewicz wrote: > > From: Marek Szyprowski > > > > When thermal sensor is not yet enabled, reading temperature might return > > random value. This might even result in s

[PATCH 03/14] thermal: exynos: Read soc_type from match data

2018-04-16 Thread Bartlomiej Zolnierkiewicz
From: Maciej Purski <m.pur...@samsung.com> Device context's field data->soc is currently obtained by comparing of_compatible's. Provide soc_type as .data field in device's match table, as it is done in most drivers. Signed-off-by: Maciej Purski <m.pur...@samsung.com> Signed-off

[PATCH 03/14] thermal: exynos: Read soc_type from match data

2018-04-16 Thread Bartlomiej Zolnierkiewicz
From: Maciej Purski Device context's field data->soc is currently obtained by comparing of_compatible's. Provide soc_type as .data field in device's match table, as it is done in most drivers. Signed-off-by: Maciej Purski Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/sams

[PATCH 07/14] thermal: exynos: remove parsing of samsung,tmu_noise_cancel_mode property

2018-04-16 Thread Bartlomiej Zolnierkiewicz
All SoCs use the same value (4) for the noise cancel mode so just make it explicit and remove parsing of samsung,tmu_noise_cancel_mode property. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/t

[PATCH 07/14] thermal: exynos: remove parsing of samsung,tmu_noise_cancel_mode property

2018-04-16 Thread Bartlomiej Zolnierkiewicz
All SoCs use the same value (4) for the noise cancel mode so just make it explicit and remove parsing of samsung,tmu_noise_cancel_mode property. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 10

[PATCH 05/14] thermal: exynos: remove parsing of samsung,tmu_default_temp_offset property

2018-04-16 Thread Bartlomiej Zolnierkiewicz
by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 48 ++-- drivers/thermal/samsung/exynos_tmu.h | 2 -- 2 files changed, 13 insertions(+), 37 deletions(-) diff --git a/drivers/thermal/s

[PATCH 05/14] thermal: exynos: remove parsing of samsung,tmu_default_temp_offset property

2018-04-16 Thread Bartlomiej Zolnierkiewicz
by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 48 ++-- drivers/thermal/samsung/exynos_tmu.h | 2 -- 2 files changed, 13 insertions(+), 37 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal

[PATCH 11/14] thermal: exynos: remove parsing of samsung,tmu_cal_type property

2018-04-16 Thread Bartlomiej Zolnierkiewicz
by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 43 drivers/thermal/samsung/exynos_tmu.h | 10 - 2 files changed, 9 insertions(+), 44 deletions(-) diff --git a/drivers/t

[PATCH 11/14] thermal: exynos: remove parsing of samsung,tmu_cal_type property

2018-04-16 Thread Bartlomiej Zolnierkiewicz
by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 43 drivers/thermal/samsung/exynos_tmu.h | 10 - 2 files changed, 9 insertions(+), 44 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b

[PATCH 09/14] thermal: exynos: remove parsing of samsung,tmu_reference_voltage property

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Since pdata reference_voltage values are SoC (not platform) specific just move it from platform data to struct exynos_tmu_data instance. Then remove parsing of samsung,tmu_reference_voltage property. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej

[PATCH 09/14] thermal: exynos: remove parsing of samsung,tmu_reference_voltage property

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Since pdata reference_voltage values are SoC (not platform) specific just move it from platform data to struct exynos_tmu_data instance. Then remove parsing of samsung,tmu_reference_voltage property. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej

[PATCH 10/14] thermal: exynos: remove parsing of samsung,tmu_gain property

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Since pdata gain values are SoC (not platform) specific just move it from platform data to struct exynos_tmu_data instance. Then remove parsing of samsung,tmu_gain property. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zoln

[PATCH 10/14] thermal: exynos: remove parsing of samsung,tmu_gain property

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Since pdata gain values are SoC (not platform) specific just move it from platform data to struct exynos_tmu_data instance. Then remove parsing of samsung,tmu_gain property. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal

[PATCH 06/14] thermal: exynos: remove parsing of samsung,tmu_[first,second]_point_trim properties

2018-04-16 Thread Bartlomiej Zolnierkiewicz
ake it explicit and remove parsing of samsung,tmu_[first,second]_point_trim properties. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 20 +--- driver

[PATCH 06/14] thermal: exynos: remove parsing of samsung,tmu_[first,second]_point_trim properties

2018-04-16 Thread Bartlomiej Zolnierkiewicz
ake it explicit and remove parsing of samsung,tmu_[first,second]_point_trim properties. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 20 +--- drivers/thermal/samsung/exynos_tmu.h |

[PATCH 14/14] arm64: dts: exynos: remove no longer needed samsung thermal properties

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Remove no longer needed samsung thermal properties. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- .../dts/exynos/exynos5433-tmu-g3d-sensor-conf.dtsi | 20 .../boot/dts/exynos/exyn

[PATCH 13/14] ARM: dts: exynos: remove no longer needed samsung thermal properties

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Remove no longer needed samsung thermal properties. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- arch/arm/boot/dts/exynos3250.dtsi | 2 +- arch/arm/boot/dts/exynos

[PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file

2018-04-16 Thread Bartlomiej Zolnierkiewicz
exynos_tmu.h is used only by exynos_tmu.c so there is no need for a separate include file. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 18 +++- d

[PATCH 14/14] arm64: dts: exynos: remove no longer needed samsung thermal properties

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Remove no longer needed samsung thermal properties. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- .../dts/exynos/exynos5433-tmu-g3d-sensor-conf.dtsi | 20 .../boot/dts/exynos/exynos5433-tmu-sensor-conf.dtsi | 19

[PATCH 13/14] ARM: dts: exynos: remove no longer needed samsung thermal properties

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Remove no longer needed samsung thermal properties. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- arch/arm/boot/dts/exynos3250.dtsi | 2 +- arch/arm/boot/dts/exynos4.dtsi| 2 +- arch/arm/boot/dts

[PATCH 12/14] thermal: exynos: remove separate exynos_tmu.h header file

2018-04-16 Thread Bartlomiej Zolnierkiewicz
exynos_tmu.h is used only by exynos_tmu.c so there is no need for a separate include file. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 18 +++- drivers/thermal/samsung/exynos_tmu.h

[PATCH 08/14] thermal: exynos: remove parsing of samsung,tmu[_min,_max]_efuse_value properties

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Since pdata efuse values are SoC (not platform) specific just move them from platform data to struct exynos_tmu_data instance. Then remove parsing of samsung,tmu[_,min_,max]_efuse_value properties. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej

[PATCH 08/14] thermal: exynos: remove parsing of samsung,tmu[_min,_max]_efuse_value properties

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Since pdata efuse values are SoC (not platform) specific just move them from platform data to struct exynos_tmu_data instance. Then remove parsing of samsung,tmu[_,min_,max]_efuse_value properties. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej

[PATCH 01/14] thermal: exynos: Reading temperature makes sense only when TMU is turned on

2018-04-16 Thread Bartlomiej Zolnierkiewicz
exynos: Fix first temperature read after registering sensor") CC: sta...@vger.kernel.org # v4.6+ Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/sam

[PATCH 04/14] thermal: exynos: remove unused "type" field from struct exynos_tmu_platform_data

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Remove unused "type" field from struct exynos_tmu_platform_data. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.h | 2 -- 1 file changed, 2 deletions(-) diff

[PATCH 01/14] thermal: exynos: Reading temperature makes sense only when TMU is turned on

2018-04-16 Thread Bartlomiej Zolnierkiewicz
;) CC: sta...@vger.kernel.org # v4.6+ Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index ed805c7..986cbd0 100644 ---

[PATCH 04/14] thermal: exynos: remove unused "type" field from struct exynos_tmu_platform_data

2018-04-16 Thread Bartlomiej Zolnierkiewicz
Remove unused "type" field from struct exynos_tmu_platform_data. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/therm

[PATCH 02/14] thermal: exynos: Propagate error value from tmu_read()

2018-04-16 Thread Bartlomiej Zolnierkiewicz
ed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> CC: sta...@vger.kernel.org # v4.6+ Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/sa

[PATCH 02/14] thermal: exynos: Propagate error value from tmu_read()

2018-04-16 Thread Bartlomiej Zolnierkiewicz
...@vger.kernel.org # v4.6+ Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c index 986cbd0..ac83f72 100644

[PATCH 00/14] thermal: exynos: pending fixes and cleanups

2018-04-16 Thread Bartlomiej Zolnierkiewicz
ready present in linux-soc-thermal-tree) - drop "thermal: exynos: remove separate thermal_exynos.h header file" patch (to be resend once dts changes are merged) Tested on Exynos4210 based Trats board and Exynos5422 based Odroid-XU3 Lite board. Best regards, -- Bartlomiej Zolnierkiewicz Sams

[PATCH 00/14] thermal: exynos: pending fixes and cleanups

2018-04-16 Thread Bartlomiej Zolnierkiewicz
ready present in linux-soc-thermal-tree) - drop "thermal: exynos: remove separate thermal_exynos.h header file" patch (to be resend once dts changes are merged) Tested on Exynos4210 based Trats board and Exynos5422 based Odroid-XU3 Lite board. Best regards, -- Bartlomiej Zolnierkiewicz Sams

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 01:12:39 PM Bartlomiej Zolnierkiewicz wrote: > On Friday, April 13, 2018 12:41:18 PM Bartlomiej Zolnierkiewicz wrote: > > On Friday, April 13, 2018 12:30:04 PM Daniel Lezcano wrote: > > > On 13/04/2018 11:28, Bartlomiej Zo

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 01:12:39 PM Bartlomiej Zolnierkiewicz wrote: > On Friday, April 13, 2018 12:41:18 PM Bartlomiej Zolnierkiewicz wrote: > > On Friday, April 13, 2018 12:30:04 PM Daniel Lezcano wrote: > > > On 13/04/2018 11:28, Bartlomiej Zo

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 12:41:18 PM Bartlomiej Zolnierkiewicz wrote: > On Friday, April 13, 2018 12:30:04 PM Daniel Lezcano wrote: > > On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote: > > > > [ ... ] > > > > >>> It is okay to return

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 12:41:18 PM Bartlomiej Zolnierkiewicz wrote: > On Friday, April 13, 2018 12:30:04 PM Daniel Lezcano wrote: > > On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote: > > > > [ ... ] > > > > >>> It is okay to return

Re: [PATCH] thermal/drivers/exynos_tmu: Fix warnings in temp_to_code / code_to_temp

2018-04-13 Thread Bartlomiej Zolnierkiewicz
warnings. > > Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> Thanks Daniel, this is much better fix. Acked-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> > --- > drivers/thermal/samsung/exynos_tmu.c | 46 > ++-- >

Re: [PATCH] thermal/drivers/exynos_tmu: Fix warnings in temp_to_code / code_to_temp

2018-04-13 Thread Bartlomiej Zolnierkiewicz
ings. > > Signed-off-by: Daniel Lezcano Thanks Daniel, this is much better fix. Acked-by: Bartlomiej Zolnierkiewicz > --- > drivers/thermal/samsung/exynos_tmu.c | 46 > ++-- > 1 file changed, 12 insertions(+), 34 deletions(-) > > di

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 12:30:04 PM Daniel Lezcano wrote: > On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote: > > [ ... ] > > >>> It is okay to return 0 because this code-path (the default one) will be > >>> never hit by the driver (probe makes sure of

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 12:30:04 PM Daniel Lezcano wrote: > On 13/04/2018 11:28, Bartlomiej Zolnierkiewicz wrote: > > [ ... ] > > >>> It is okay to return 0 because this code-path (the default one) will be > >>> never hit by the driver (probe makes sure of

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
> > Rui, bzolnier, please consider the following fix: > > > > > as it is late in this merge window, I'd prefer to > > 1. drop all the thermal-soc material in the first pull request which I > > will send out soon. > > 2. you can prepare another pull request conta

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
nier, please consider the following fix: > > > > > as it is late in this merge window, I'd prefer to > > 1. drop all the thermal-soc material in the first pull request which I > > will send out soon. > > 2. you can prepare another pull request containing the thermal-soc >

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 11:19:40 AM Daniel Lezcano wrote: > On 13/04/2018 11:08, Bartlomiej Zolnierkiewicz wrote: > > On Friday, April 13, 2018 11:00:43 AM Daniel Lezcano wrote: > >> On 13/04/2018 10:55, Bartlomiej Zolnierkiewicz wrote: > >>> On Friday, April 13, 20

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 11:19:40 AM Daniel Lezcano wrote: > On 13/04/2018 11:08, Bartlomiej Zolnierkiewicz wrote: > > On Friday, April 13, 2018 11:00:43 AM Daniel Lezcano wrote: > >> On 13/04/2018 10:55, Bartlomiej Zolnierkiewicz wrote: > >>> On Friday, April 13, 20

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 11:00:43 AM Daniel Lezcano wrote: > On 13/04/2018 10:55, Bartlomiej Zolnierkiewicz wrote: > > On Friday, April 13, 2018 01:39:05 PM Zhang Rui wrote: > >> Hi, Eduardo, > >> > >> On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote:

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
On Friday, April 13, 2018 11:00:43 AM Daniel Lezcano wrote: > On 13/04/2018 10:55, Bartlomiej Zolnierkiewicz wrote: > > On Friday, April 13, 2018 01:39:05 PM Zhang Rui wrote: > >> Hi, Eduardo, > >> > >> On 四, 2018-04-12 at 21:08 -0700, Eduardo Valentin wrote:

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
nd out soon. > 2. you can prepare another pull request containing the thermal-soc > materials except the exynos fixes > 3. exynos fixes with the problem solved can be queued for -rc2 or > later. Could you please just merge the obvious fix from Arnd instead? [ it was posted two weeks ago and ACKed by me ] https://patchwork.kernel.org/patch/10313313/ Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
re another pull request containing the thermal-soc > materials except the exynos fixes > 3. exynos fixes with the problem solved can be queued for -rc2 or > later. Could you please just merge the obvious fix from Arnd instead? [ it was posted two weeks ago and ACKed by me ] https://patchwork.kernel.org/patch/10313313/ Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
) * > + *temp = (temp_code - data->temp_error1) * > (EXYNOS_SECOND_POINT_TRIM - EXYNOS_FIRST_POINT_TRIM) / > (data->temp_error2 - data->temp_error1) + > EXYNOS_FIRST_POINT_TRIM; > break; > ca

Re: [GIT PULL] Thermal management updates for v4.17-rc1

2018-04-13 Thread Bartlomiej Zolnierkiewicz
(EXYNOS_SECOND_POINT_TRIM - EXYNOS_FIRST_POINT_TRIM) / > (data->temp_error2 - data->temp_error1) + > EXYNOS_FIRST_POINT_TRIM; > break; > case TYPE_ONE_POINT_TRIMMING: > - temp = temp_code - data->temp_error1 + EXYNOS_FIRST_POINT_TRIM; > + *temp = temp_code - data->temp_error1 + EXYNOS_FIRST_POINT_TRIM; > break; > default: > WARN_ON(1); > + ret = -EINVAL; ditto > break; > } > > - return temp; > + return ret; > } Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland Samsung Electronics

[PATCH 05/17] thermal: bcm2835: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after HW-block setup (if necessary) and setting data->tz. Cc: Eric Anholt <e...@anholt.net> Cc: Stefan Wahren <stefan.wah...@i2se.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/broadcom/bcm2835_thermal.c | 6 +

[PATCH 06/17] thermal: brcmstb: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after setting priv->thermal. Cc: Markus Mayer <mma...@broadcom.com> Cc: bcm-kernel-feedback-l...@broadcom.com Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/broadcom/brcmstb_thermal.c | 4 ++-- 1 file changed, 2 i

[PATCH 05/17] thermal: bcm2835: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after HW-block setup (if necessary) and setting data->tz. Cc: Eric Anholt Cc: Stefan Wahren Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/broadcom/bcm2835_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/ther

[PATCH 06/17] thermal: brcmstb: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after setting priv->thermal. Cc: Markus Mayer Cc: bcm-kernel-feedback-l...@broadcom.com Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/broadcom/brcmstb_thermal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/broad

[PATCH 17/17] thermal: warn on attempts to read temperature on disabled sensors

2018-04-10 Thread Bartlomiej Zolnierkiewicz
* Add ops_of_thermal flag to struct thermal_zone_device_ops and set it in of-thermal.c. * Add checking sensor mode for drivers using of-thermal.c to thermal_zone_get_temp() (print a warning if sensor is disabled). Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.

[PATCH 17/17] thermal: warn on attempts to read temperature on disabled sensors

2018-04-10 Thread Bartlomiej Zolnierkiewicz
* Add ops_of_thermal flag to struct thermal_zone_device_ops and set it in of-thermal.c. * Add checking sensor mode for drivers using of-thermal.c to thermal_zone_get_temp() (print a warning if sensor is disabled). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/of-thermal.c

[PATCH 16/17] thermal: zx2967: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after checking sensor coefficients. Cc: Jun Nie <jun@linaro.org> Cc: Baoyou Xie <baoyou@linaro.org> Cc: Shawn Guo <shawn...@kernel.org> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/zx2967_thermal.c |

[PATCH 16/17] thermal: zx2967: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after checking sensor coefficients. Cc: Jun Nie Cc: Baoyou Xie Cc: Shawn Guo Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/zx2967_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/zx2967_thermal.c b/drivers

[PATCH 11/17] thermal: rockchip_thermal: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
* Enable/check sensor explicitly in rockchip_thermal_probe() (also check sensor after doing chipset specific control operation). * Remove superfluous second sensor enable/check attempt. Cc: Heiko Stuebner <he...@sntech.de> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@sa

[PATCH 11/17] thermal: rockchip_thermal: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
* Enable/check sensor explicitly in rockchip_thermal_probe() (also check sensor after doing chipset specific control operation). * Remove superfluous second sensor enable/check attempt. Cc: Heiko Stuebner Signed-off-by: Bartlomiej Zolnierkiewicz --- This driver may require some more fixing

[PATCH 15/17] thermal: uniphier: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable sensor after checking trip points (unipher_tm_enable_sensor() enables IRQ so we need to toggle sensor before calling it) and check sensor after doing chipset specific enable sensor operation. Cc: Masahiro Yamada <yamada.masah...@socionext.com> Signed-off-by: Bartlomiej Zolnierk

[PATCH 14/17] thermal: ti-soc-thermal: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable sensor after setting sensor data and check sensor after writing update interval. Cc: Eduardo Valentin <edubez...@gmail.com> Cc: Keerthy <j-keer...@ti.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/ti-soc-thermal/ti-th

[PATCH 14/17] thermal: ti-soc-thermal: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable sensor after setting sensor data and check sensor after writing update interval. Cc: Eduardo Valentin Cc: Keerthy Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 15/17] thermal: uniphier: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable sensor after checking trip points (unipher_tm_enable_sensor() enables IRQ so we need to toggle sensor before calling it) and check sensor after doing chipset specific enable sensor operation. Cc: Masahiro Yamada Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal

[PATCH 12/17] thermal: exynos: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable sensor after doing chipset specific initialization operation and check sensor after doing chipset specific control operation. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/samsung/exynos_tmu.c | 8 +--- 1 file changed, 5 insertions

[PATCH 13/17] thermal: tegra: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after setting zone->tz and programming hwtrips. Cc: Thierry Reding <thierry.red...@gmail.com> Cc: Jonathan Hunter <jonath...@nvidia.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/tegra/soctherm.c | 6 +++-

[PATCH 12/17] thermal: exynos: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable sensor after doing chipset specific initialization operation and check sensor after doing chipset specific control operation. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/samsung/exynos_tmu.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH 13/17] thermal: tegra: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after setting zone->tz and programming hwtrips. Cc: Thierry Reding Cc: Jonathan Hunter Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/tegra/soctherm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/tegra/soctherm.

[PATCH 10/17] thermal: rcar_gen3_thermal: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after setting tsc->zone and checking ntrips. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/rcar_gen3_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c

[PATCH 04/17] thermal: do sensor checking explicitly in drivers

2018-04-10 Thread Bartlomiej Zolnierkiewicz
(only place which calls ->set_mode). Modify mode_store() in thermal_sysfs.c accordingly. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/acpi/thermal.c | 2 ++ drivers/net/ethernet/mellanox/mlxsw/core_thermal.c | 2 -- drive

[PATCH 04/17] thermal: do sensor checking explicitly in drivers

2018-04-10 Thread Bartlomiej Zolnierkiewicz
(only place which calls ->set_mode). Modify mode_store() in thermal_sysfs.c accordingly. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/acpi/thermal.c | 2 ++ drivers/net/ethernet/mellanox/mlxsw/core_thermal.c | 2 -- drivers/platform/x86/

[PATCH 10/17] thermal: rcar_gen3_thermal: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after setting tsc->zone and checking ntrips. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/rcar_gen3_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_therma

[PATCH 08/17] thermal: qcom: tsens: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after setting tmdev->sensor[i].tzd and calling chipset specific enable operation. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/qcom/tsens.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/driver

[PATCH 09/17] thermal: qoriq: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after enabling monitoring. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/qoriq_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c

[PATCH 09/17] thermal: qoriq: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after enabling monitoring. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/qoriq_thermal.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c index cdd6f59..2695021 100644

[PATCH 08/17] thermal: qcom: tsens: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Enable/check sensor after setting tmdev->sensor[i].tzd and calling chipset specific enable operation. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/qcom/tsens.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/qcom/tsens.c b/driv

[PATCH 03/17] thermal: add thermal_zone_device_check() helper

2018-04-10 Thread Bartlomiej Zolnierkiewicz
* Rename static thermal_zone_device_check() helper in thermal_core.c to thermal_zone_device_work_check(). * Add thermal_zone_device_check() helper. Then update core code and drivers to use it. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/acpi/the

[PATCH 03/17] thermal: add thermal_zone_device_check() helper

2018-04-10 Thread Bartlomiej Zolnierkiewicz
* Rename static thermal_zone_device_check() helper in thermal_core.c to thermal_zone_device_work_check(). * Add thermal_zone_device_check() helper. Then update core code and drivers to use it. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/acpi/thermal.c

[PATCH 07/17] thermal: hisi_thermal: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
* Enable/check sensor after checking ntrips and doing chipset specific enable operation. * Remove superfluous second sensor enable/check attempt. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/hisi_thermal.c | 9 +++-- 1 file changed, 3 inse

[PATCH 07/17] thermal: hisi_thermal: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
* Enable/check sensor after checking ntrips and doing chipset specific enable operation. * Remove superfluous second sensor enable/check attempt. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/hisi_thermal.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff

[PATCH 01/17] thermal: add thermal_zone_device_toggle() helper

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Add thermal_zone_device_toggle() helper. Then update core code and drivers to use it. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/hisi_thermal.c | 14 ++ drivers/thermal/of-thermal.c | 2 +- drivers/thermal/rockchip_the

[PATCH 01/17] thermal: add thermal_zone_device_toggle() helper

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Add thermal_zone_device_toggle() helper. Then update core code and drivers to use it. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/hisi_thermal.c | 14 ++ drivers/thermal/of-thermal.c | 2 +- drivers/thermal/rockchip_thermal.c | 22

[PATCH 00/17] thermal: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
tions are separated and corresponding drivers are modified to use the new helpers to enable and check sensor explicitly. Tested on Exynos5422 based Odroid-XU3 Lite board (aforementioned warnings from the thermal core are now gone). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland

[PATCH 02/17] thermal: separate sensor registration and enable

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Move thermal_zone_device_toggle() call to the users of [devm]_thermal_zone_of_sensor_register(). Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnier...@samsung.com> --- drivers/thermal/broadcom/bcm2835_thermal.c | 2 ++ drivers/thermal/broadcom/brcmstb_thermal.c | 2 ++ d

[PATCH 00/17] thermal: enable/check sensor after its setup is finished

2018-04-10 Thread Bartlomiej Zolnierkiewicz
tions are separated and corresponding drivers are modified to use the new helpers to enable and check sensor explicitly. Tested on Exynos5422 based Odroid-XU3 Lite board (aforementioned warnings from the thermal core are now gone). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R Institute Poland

[PATCH 02/17] thermal: separate sensor registration and enable

2018-04-10 Thread Bartlomiej Zolnierkiewicz
Move thermal_zone_device_toggle() call to the users of [devm]_thermal_zone_of_sensor_register(). Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/thermal/broadcom/bcm2835_thermal.c | 2 ++ drivers/thermal/broadcom/brcmstb_thermal.c | 2 ++ drivers/thermal/broadcom/ns

[GIT PULL] fbdev changes for v4.17

2018-04-10 Thread Bartlomiej Zolnierkiewicz
!MICROBLAZE && !OPENRISC + !ARM64 && !ARC && !MICROBLAZE && !OPENRISC && !NDS32 && !S390 default y help Saying Y here will allow you to use Linux in text mode through a Best regards, -- Bartlomiej Zolnierkiewi

[GIT PULL] fbdev changes for v4.17

2018-04-10 Thread Bartlomiej Zolnierkiewicz
!MICROBLAZE && !OPENRISC + !ARM64 && !ARC && !MICROBLAZE && !OPENRISC && !NDS32 && !S390 default y help Saying Y here will allow you to use Linux in text mode through a Best regards, -- Bartlomiej Zolnierkiewi

<    1   2   3   4   5   6   7   8   9   10   >