Re: [PATCH] bw-qcam: adds parameter aggressive to skip passive detection and directly attempt initialization

2007-12-05 Thread Brett Warden
On Dec 5, 2007 9:37 AM, Alan Cox <[EMAIL PROTECTED]> wrote: > Although I would suggest that "aggressive" may not be the best term - I'm > not such of a good one however - skip_passive ? How about force_init? -- Brett Warden -- To unsubscribe from this list: send the l

Re: [PATCH] bw-qcam: Adds module parameter 'aggressive' to skip polite auto-detection prior to direct initialization.

2007-12-05 Thread Brett Warden
Sorry, forgot to copy back to the lists. On Dec 5, 2007 8:49 AM, Brett Warden <[EMAIL PROTECTED]> wrote: > On Dec 4, 2007 4:46 PM, Alan Cox <[EMAIL PROTECTED]> wrote: > > > > Someone still has a bw-qcam device ? > > Yes. I haven't found a better option for ver

Re: [PATCH] bw-qcam: adds parameter aggressive to skip passive detection and directly attempt initialization

2007-12-05 Thread Brett Warden
On Dec 5, 2007 9:37 AM, Alan Cox [EMAIL PROTECTED] wrote: Although I would suggest that aggressive may not be the best term - I'm not such of a good one however - skip_passive ? How about force_init? -- Brett Warden -- To unsubscribe from this list: send the line unsubscribe linux-kernel

Re: [PATCH] bw-qcam: Adds module parameter 'aggressive' to skip polite auto-detection prior to direct initialization.

2007-12-05 Thread Brett Warden
Sorry, forgot to copy back to the lists. On Dec 5, 2007 8:49 AM, Brett Warden [EMAIL PROTECTED] wrote: On Dec 4, 2007 4:46 PM, Alan Cox [EMAIL PROTECTED] wrote: Someone still has a bw-qcam device ? Yes. I haven't found a better option for very-low-light, although I admit I haven't looked

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-27 Thread Brett Warden
printk(KERN_ERR "No Quickcam found on port %s\n", q->pport->name); return 0; /* not found */ + } } -- Brett Warden - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAI

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-27 Thread Brett Warden
); return 0; /* not found */ + } } -- Brett Warden - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
On 9/26/07, Ray Lee <[EMAIL PROTECTED]> wrote: > On 9/26/07, Brett Warden <[EMAIL PROTECTED]> wrote: > > On 9/26/07, Ray Lee <[EMAIL PROTECTED]> wrote: > > > > > Just as an aside, if you've tested this and it works, then there's no > > > point

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
/* turn port around */ + write_lpcontrol(q, 0xe); + reverse_port(q); + write_lpcontrol(q, 0x6); (void) qc_waithand(q, 1); - write_lpcontrol(q, 0x2e); + reverse_port(q); + write_lpcontrol(q

[PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
write_lpcontrol(q, 0xe); (void) qc_waithand(q, 0); } -- Brett Warden - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
); + reverse_port(q); + write_lpcontrol(q, 0x6); (void) qc_waithand(q, 1); - write_lpcontrol(q, 0x2e); + reverse_port(q); + write_lpcontrol(q, 0xe); (void) qc_waithand(q, 0); } -- Brett Warden

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
); + reverse_port(q); + write_lpcontrol(q, 0x6); (void) qc_waithand(q, 1); - write_lpcontrol(q, 0x2e); + reverse_port(q); + write_lpcontrol(q, 0xe); (void) qc_waithand(q, 0); } -- Brett Warden - To unsubscribe

Re: [PATCH] bw-qcam: use data_reverse instead of manually poking the control register

2007-09-26 Thread Brett Warden
On 9/26/07, Ray Lee [EMAIL PROTECTED] wrote: On 9/26/07, Brett Warden [EMAIL PROTECTED] wrote: On 9/26/07, Ray Lee [EMAIL PROTECTED] wrote: Just as an aside, if you've tested this and it works, then there's no point to keep the write_lpcontrol even as a comment. Kill those four lines