Re: [PATCH 05/16] arch: remove blackfin port

2018-03-15 Thread Bryan Wu
Personally Blackfin Linux is my most special memory. Thanks a lot for the folks from community and contributors from all over the world. Acked-by: Bryan Wu <coolo...@gmail.com> On Wed, Mar 14, 2018 at 10:36 PM, Arnd Bergmann <a...@arndb.de> wrote: > The Analog Devices Blackfin

Re: [PATCH 05/16] arch: remove blackfin port

2018-03-15 Thread Bryan Wu
Personally Blackfin Linux is my most special memory. Thanks a lot for the folks from community and contributors from all over the world. Acked-by: Bryan Wu On Wed, Mar 14, 2018 at 10:36 PM, Arnd Bergmann wrote: > The Analog Devices Blackfin port was added in 2007 and was rather >

Re: [PATCH] MAINTAINERS: Change LED subsystem git tree URL

2015-08-19 Thread Bryan Wu
On Wed, Aug 19, 2015 at 3:47 AM, Jacek Anaszewski wrote: > This patch removes Bryan Wu from the list of LED subsystem > maintainers and replaces related git tree URL with the one > maintained by Jacek Anaszewski. > > Signed-off-by: Jacek Anaszewski > Cc: Bryan Wu > Cc: R

Re: [PATCH] MAINTAINERS: Change LED subsystem git tree URL

2015-08-19 Thread Bryan Wu
On Wed, Aug 19, 2015 at 3:47 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: This patch removes Bryan Wu from the list of LED subsystem maintainers and replaces related git tree URL with the one maintained by Jacek Anaszewski. Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Cc

[GIT PULL] LED subsystem updates for 4.2

2015-06-30 Thread Bryan Wu
Hi Linus, In this cycle, we finished to merge patches for LED Flash class driver. Other than that we have some bug fixes and new drivers for LED controllers. So please consider to pull the following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22: Linux 4.1-rc2 (2015-05-03

[GIT PULL] LED subsystem updates for 4.2

2015-06-30 Thread Bryan Wu
Hi Linus, In this cycle, we finished to merge patches for LED Flash class driver. Other than that we have some bug fixes and new drivers for LED controllers. So please consider to pull the following changes since commit 5ebe6afaf0057ac3eaeb98defd5456894b446d22: Linux 4.1-rc2 (2015-05-03

Re: [PATCH -next] leds: fix aat1290 build errors

2015-06-29 Thread Bryan Wu
aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init' >> >> Signed-off-by: Randy Dunlap >> Cc: Jacek Anaszewski >> Cc: Bryan Wu >> Cc: Richard Purdie >> --- >> drivers/leds/Kconfig |1 + >> 1 file changed, 1 insertion(+)

Re: [PATCH -next] leds: fix aat1290 build errors

2015-06-29 Thread Bryan Wu
' Signed-off-by: Randy Dunlap rdun...@infradead.org Cc: Jacek Anaszewski j.anaszew...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- drivers/leds/Kconfig |1 + 1 file changed, 1 insertion(+) --- linux-next-20150626.orig/drivers/leds/Kconfig

Re: [PATCH] drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c

2015-06-16 Thread Bryan Wu
runtime impact is >> zero -- it will remain at level 6 in initcall ordering. >> >> And since it can't be modular, we remove all the __exitcall >> stuff related to module_exit() -- it is dead code that won't >> ever be executed. >> >> Cc: Bryan Wu >

Re: [PATCH] drivers/leds: don't use module_init in non-modular leds-cobalt-raq.c

2015-06-16 Thread Bryan Wu
remove all the __exitcall stuff related to module_exit() -- it is dead code that won't ever be executed. Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net Cc: Jacek Anaszewski j.anaszew...@samsung.com Cc: linux-l...@vger.kernel.org Signed-off-by: Paul Gortmaker paul.gortma

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-05-19 Thread Bryan Wu
On Fri, May 15, 2015 at 7:41 AM, Jacek Anaszewski wrote: > On 05/15/2015 04:11 PM, Stas Sergeev wrote: >> >> 15.05.2015 17:09, Jacek Anaszewski пишет: >>> >>> On 05/15/2015 10:12 AM, Jacek Anaszewski wrote: Hi Stas, On 05/14/2015 05:24 PM, Stas Sergeev wrote: > > >

Re: [PATCH v2] leds: fix brightness changing when software blinking is active

2015-05-19 Thread Bryan Wu
On Fri, May 15, 2015 at 7:41 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: On 05/15/2015 04:11 PM, Stas Sergeev wrote: 15.05.2015 17:09, Jacek Anaszewski пишет: On 05/15/2015 10:12 AM, Jacek Anaszewski wrote: Hi Stas, On 05/14/2015 05:24 PM, Stas Sergeev wrote: The following

Re: [PATCH] leds: remove redundant SET_BRIGHTNESS_SYNC flag

2015-05-14 Thread Bryan Wu
still make code more clear and easy to understand. Thanks, -Bryan > > On 05/13/2015 05:41 PM, Stas Sergeev wrote: >> >> >> There is a complimentary flag called SET_BRIGHTNESS_ASYNC. >> Having both is redundant. This patch removes the unneeded flag >> witho

Re: [PATCH] leds: remove redundant SET_BRIGHTNESS_SYNC flag

2015-05-14 Thread Bryan Wu
code more clear and easy to understand. Thanks, -Bryan On 05/13/2015 05:41 PM, Stas Sergeev wrote: There is a complimentary flag called SET_BRIGHTNESS_ASYNC. Having both is redundant. This patch removes the unneeded flag without any functionality change. CC: Bryan Wu coolo...@gmail.com CC

Re: [PATCH] Documentation: leds-lp5523: describe master fader attributes

2015-05-13 Thread Bryan Wu
On Wed, May 13, 2015 at 2:57 AM, Jacek Anaszewski wrote: > Hi Toshi, > > On 05/13/2015 03:15 AM, Toshi Kikuchi wrote: >> >> Add the usage of the new attributes for master faders. >> >> Signed-off-by: Toshi Kikuchi >> --- >> Documentation/leds/leds-lp5523.txt | 30 ++

Re: [PATCH] Documentation: leds-lp5523: describe master fader attributes

2015-05-13 Thread Bryan Wu
On Wed, May 13, 2015 at 2:57 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Hi Toshi, On 05/13/2015 03:15 AM, Toshi Kikuchi wrote: Add the usage of the new attributes for master faders. Signed-off-by: Toshi Kikuchi tos...@chromium.org --- Documentation/leds/leds-lp5523.txt | 30

Re: [PATCH] leds: lp5523: add master_fader support

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 1:51 AM, Jacek Anaszewski wrote: > On 05/12/2015 10:25 AM, Kim, Milo wrote: >> >> Hi Jacek and Toshi, >> >> On 5/12/2015 4:25 PM, Jacek Anaszewski wrote: >>> >>> Hi Toshi, >>> >>> On 05/11/2015 09:10 PM, Toshi Kikuchi wrote: This patch introduces 4 new

Re: [PATCH 3/3] leds: leds-gpio: Allow compile test if !GPIOLIB

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 3:23 AM, Linus Walleij wrote: > On Thu, May 7, 2015 at 10:08 AM, Geert Uytterhoeven > wrote: > >> The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is >> not enabled. Hence drivers that depend on GPIOLIB, but use GPIO consumer >> functionality only, can

Re: [PATCH 2/3] leds: leds-gpio: Add missing #include

2015-05-12 Thread Bryan Wu
On Thu, May 7, 2015 at 5:15 AM, Jacek Anaszewski wrote: > On 05/07/2015 10:08 AM, Geert Uytterhoeven wrote: >> >> drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: >> drivers/leds/leds-gpio.c:194: error: implicit declaration of function >> ‘of_node’ >> drivers/leds/leds-gpio.c:194:

Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 3:31 AM, Linus Walleij wrote: > On Thu, May 7, 2015 at 10:08 AM, Geert Uytterhoeven > wrote: > >> If GPIOLIB=n: >> >> drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: >> drivers/leds/leds-gpio.c:187: error: implicit declaration of function >>

Re: [PATCH v9 1/3] of: Add vendor prefix for Kinetic technologies

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 1:37 AM, Ingi Kim wrote: > This patch adds vendor prefix for Kinetic technologies > > Signed-off-by: Ingi Kim > Acked-by: Rob Herring > Acked-by: Seung-Woo Kim > Reviewed-by: Varka Bhadram Merged into my tree with DT reviewer's acks. Thanks, -Bryan > --- >

Re: [PATCH v9 3/3] leds: Add ktd2692 flash LED driver

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 5:40 AM, Jacek Anaszewski wrote: > Hi Ingi, > > On 05/12/2015 10:37 AM, Ingi Kim wrote: >> >> This patch adds a driver to support the ktd2692 flash LEDs. >> ktd2692 can control flash current by ExpressWire interface. >> >> Signed-off-by: Ingi Kim >> Acked-by: Seung-Woo

Re: [PATCH v9 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 5:39 AM, Jacek Anaszewski wrote: > Hi Ingi, > > On 05/12/2015 10:37 AM, Ingi Kim wrote: >> >> This patch adds the device tree bindings for ktd2692 flash LEDs. >> Add Optional properties of child node for Flash LED >> >> Signed-off-by: Ingi Kim >> Acked-by: Seung-Woo Kim

Re: [PATCH 2/3] leds: leds-gpio: Add missing #include linux/of.h

2015-05-12 Thread Bryan Wu
On Thu, May 7, 2015 at 5:15 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: On 05/07/2015 10:08 AM, Geert Uytterhoeven wrote: drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: drivers/leds/leds-gpio.c:194: error: implicit declaration of function ‘of_node’

Re: [PATCH v9 2/3] leds: ktd2692: add device tree bindings for ktd2692

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 5:39 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Hi Ingi, On 05/12/2015 10:37 AM, Ingi Kim wrote: This patch adds the device tree bindings for ktd2692 flash LEDs. Add Optional properties of child node for Flash LED Signed-off-by: Ingi Kim

Re: [PATCH v9 1/3] of: Add vendor prefix for Kinetic technologies

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 1:37 AM, Ingi Kim ingi2@samsung.com wrote: This patch adds vendor prefix for Kinetic technologies Signed-off-by: Ingi Kim ingi2@samsung.com Acked-by: Rob Herring r...@kernel.org Acked-by: Seung-Woo Kim sw0312@samsung.com Reviewed-by: Varka Bhadram

Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 3:31 AM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, May 7, 2015 at 10:08 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: If GPIOLIB=n: drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: drivers/leds/leds-gpio.c:187: error: implicit

Re: [PATCH 3/3] leds: leds-gpio: Allow compile test if !GPIOLIB

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 3:23 AM, Linus Walleij linus.wall...@linaro.org wrote: On Thu, May 7, 2015 at 10:08 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: The GPIO subsystem provides dummy GPIO consumer functions if GPIOLIB is not enabled. Hence drivers that depend on GPIOLIB, but use

Re: [PATCH v9 3/3] leds: Add ktd2692 flash LED driver

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 5:40 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Hi Ingi, On 05/12/2015 10:37 AM, Ingi Kim wrote: This patch adds a driver to support the ktd2692 flash LEDs. ktd2692 can control flash current by ExpressWire interface. Signed-off-by: Ingi Kim

Re: [PATCH] leds: lp5523: add master_fader support

2015-05-12 Thread Bryan Wu
On Tue, May 12, 2015 at 1:51 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: On 05/12/2015 10:25 AM, Kim, Milo wrote: Hi Jacek and Toshi, On 5/12/2015 4:25 PM, Jacek Anaszewski wrote: Hi Toshi, On 05/11/2015 09:10 PM, Toshi Kikuchi wrote: This patch introduces 4 new attributes:

Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface

2015-05-08 Thread Bryan Wu
On Thu, May 7, 2015 at 1:08 AM, Geert Uytterhoeven wrote: > If GPIOLIB=n: > > drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: > drivers/leds/leds-gpio.c:187: error: implicit declaration of function > ‘devm_get_gpiod_from_child’ > drivers/leds/leds-gpio.c:187: warning:

Re: [PATCH 1/3] gpiolib: Add missing dummies for the unified device properties interface

2015-05-08 Thread Bryan Wu
On Thu, May 7, 2015 at 1:08 AM, Geert Uytterhoeven ge...@linux-m68k.org wrote: If GPIOLIB=n: drivers/leds/leds-gpio.c: In function ‘gpio_leds_create’: drivers/leds/leds-gpio.c:187: error: implicit declaration of function ‘devm_get_gpiod_from_child’ drivers/leds/leds-gpio.c:187:

Re: [PATCH] MAINTAINERS: Add co-maintainer for LED subsystem

2015-04-24 Thread Bryan Wu
On Thu, Apr 16, 2015 at 10:09 AM, Bryan Wu wrote: > On Thu, Apr 9, 2015 at 10:30 AM, Bryan Wu wrote: >> On Thu, Apr 9, 2015 at 1:01 AM, Jacek Anaszewski >> wrote: >>> This patch adds myself (Jacek Anaszewski) as a co-maintainer for >>> LED subsystem. >>&g

Re: [PATCH] MAINTAINERS: Add co-maintainer for LED subsystem

2015-04-24 Thread Bryan Wu
On Thu, Apr 16, 2015 at 10:09 AM, Bryan Wu coolo...@gmail.com wrote: On Thu, Apr 9, 2015 at 10:30 AM, Bryan Wu coolo...@gmail.com wrote: On Thu, Apr 9, 2015 at 1:01 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: This patch adds myself (Jacek Anaszewski) as a co-maintainer for LED

Re: [PATCH] leds: gpio: Fix device teardown on probe deferral

2015-04-20 Thread Bryan Wu
t already >> registered led is not torn down properly. This causes create_gpio_led() >> to fail for the first led on re-probe(). >> >> Fix this misbehaviour by incrementing num_leds only if all >> potentially failing calls completed successfully. >> >> Signed-

Re: [PATCH] leds: gpio: Fix device teardown on probe deferral

2015-04-20 Thread Bryan Wu
: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net Cc: linux-l...@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/leds/leds-gpio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) For this patch: Acked-by: Jacek Anaszewski j.anaszew...@samsung.com

Re: [PATCH] MAINTAINERS: Add co-maintainer for LED subsystem

2015-04-16 Thread Bryan Wu
On Thu, Apr 9, 2015 at 10:30 AM, Bryan Wu wrote: > On Thu, Apr 9, 2015 at 1:01 AM, Jacek Anaszewski > wrote: >> This patch adds myself (Jacek Anaszewski) as a co-maintainer for >> LED subsystem. >> > > Jacek will start to help maintain LED subsystem. > > Acke

Re: [PATCH] MAINTAINERS: Add co-maintainer for LED subsystem

2015-04-16 Thread Bryan Wu
On Thu, Apr 9, 2015 at 10:30 AM, Bryan Wu coolo...@gmail.com wrote: On Thu, Apr 9, 2015 at 1:01 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: This patch adds myself (Jacek Anaszewski) as a co-maintainer for LED subsystem. Jacek will start to help maintain LED subsystem. Acked

[GIT PULL] LED subsystem updates for 4.1

2015-04-15 Thread Bryan Wu
Hi Linus, In this cycle, we merged some fix and update for LED Flash class driver. Then the core code of LED Flash class driver is in the kernel now. Moreover, we also got some bug fixes, code cleanup and new drivers for LED controllers. So please consider to pull the following changes since

[GIT PULL] LED subsystem updates for 4.1

2015-04-15 Thread Bryan Wu
Hi Linus, In this cycle, we merged some fix and update for LED Flash class driver. Then the core code of LED Flash class driver is in the kernel now. Moreover, we also got some bug fixes, code cleanup and new drivers for LED controllers. So please consider to pull the following changes since

Re: [PATCH v2] leds: fix redundant trigger API #ifdef

2015-04-09 Thread Bryan Wu
On Thu, Apr 9, 2015 at 8:37 AM, Valentin Rothberg wrote: > Commit 5a15d172057c ("leds: unify the location of led-trigger API") > moved the leds trigger API to led.h. Moving the function definitions > caused a logical problem regarding the visibility of #idef blocks. As > listed in the code

Re: [PATCH -next] leds: Fix build failure seen if LEDS_TRIGGERS is not configured

2015-04-09 Thread Bryan Wu
On Thu, Apr 9, 2015 at 8:42 AM, Guenter Roeck wrote: > Fix: > > drivers/leds/led-class.c: In function 'brightness_store': > drivers/leds/led-class.c:57: error: > implicit declaration of function 'led_trigger_remove' > > seen if LEDS_TRIGGERS is not configured. > Thanks

Re: [PATCH] MAINTAINERS: Add co-maintainer for LED subsystem

2015-04-09 Thread Bryan Wu
On Thu, Apr 9, 2015 at 1:01 AM, Jacek Anaszewski wrote: > This patch adds myself (Jacek Anaszewski) as a co-maintainer for > LED subsystem. > Jacek will start to help maintain LED subsystem. Acked-by: Bryan Wu > Signed-off-by: Jacek Anaszewski > --- > MAINTAINERS |1 +

Re: [PATCH -next] leds: Fix build failure seen if LEDS_TRIGGERS is not configured

2015-04-09 Thread Bryan Wu
On Thu, Apr 9, 2015 at 8:42 AM, Guenter Roeck li...@roeck-us.net wrote: Fix: drivers/leds/led-class.c: In function 'brightness_store': drivers/leds/led-class.c:57: error: implicit declaration of function 'led_trigger_remove' seen if LEDS_TRIGGERS is not configured.

Re: [PATCH v2] leds: fix redundant trigger API #ifdef

2015-04-09 Thread Bryan Wu
On Thu, Apr 9, 2015 at 8:37 AM, Valentin Rothberg valentinrothb...@gmail.com wrote: Commit 5a15d172057c (leds: unify the location of led-trigger API) moved the leds trigger API to led.h. Moving the function definitions caused a logical problem regarding the visibility of #idef blocks. As

Re: [PATCH] MAINTAINERS: Add co-maintainer for LED subsystem

2015-04-09 Thread Bryan Wu
On Thu, Apr 9, 2015 at 1:01 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: This patch adds myself (Jacek Anaszewski) as a co-maintainer for LED subsystem. Jacek will start to help maintain LED subsystem. Acked-by: Bryan Wu coolo...@gmail.com Signed-off-by: Jacek Anaszewski j.anaszew

Re: [PATCH] leds-gpio: Fix error handling and memory leak

2015-03-30 Thread Bryan Wu
On Thu, Mar 26, 2015 at 8:08 PM, Corey Minyard wrote: > On 03/26/2015 08:20 PM, Bryan Wu wrote: >> On Mon, Mar 9, 2015 at 5:43 PM, wrote: >>> From: Corey Minyard >>> >>> The leds-gpio driver would not clean up properly if it failed in some >>> p

Re: [PATCH 0/3] Handle LEDs with the same name

2015-03-30 Thread Bryan Wu
On Mon, Mar 30, 2015 at 10:45 AM, Ricardo Ribalda Delgado wrote: > This is a rework of the original patch + 3 fixup patches from me. > Contains a lot of feedback from Geert Uytterhoeven > Thanks! > > Ricardo Ribalda Delgado (1): > leds/led-class: Handle LEDs with the same name > > Sakari Ailus

Re: [PATCH 0/3] leds/class: Fix string handling

2015-03-30 Thread Bryan Wu
On Mon, Mar 30, 2015 at 10:46 AM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > On Mon, Mar 30, 2015 at 7:15 PM, Bryan Wu wrote: >> Thanks, Geert and Ricardo. >> Ricardo, do you mind folding your fixing patches with original one >> together and send it out ag

Re: [PATCH 0/3] leds/class: Fix string handling

2015-03-30 Thread Bryan Wu
On Mon, Mar 30, 2015 at 1:55 AM, Ricardo Ribalda Delgado wrote: > Fix errors reported by Geert Uytterhoeven. > > I didn't have the chance to test the changes it in real hardware. > > Thanks, Geert and Ricardo. Ricardo, do you mind folding your fixing patches with original one together and send

Re: [PATCH 0/3] leds/class: Fix string handling

2015-03-30 Thread Bryan Wu
On Mon, Mar 30, 2015 at 1:55 AM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: Fix errors reported by Geert Uytterhoeven. I didn't have the chance to test the changes it in real hardware. Thanks, Geert and Ricardo. Ricardo, do you mind folding your fixing patches with original one

Re: [PATCH 0/3] leds/class: Fix string handling

2015-03-30 Thread Bryan Wu
On Mon, Mar 30, 2015 at 10:46 AM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: Hello Bryan On Mon, Mar 30, 2015 at 7:15 PM, Bryan Wu coolo...@gmail.com wrote: Thanks, Geert and Ricardo. Ricardo, do you mind folding your fixing patches with original one together and send it out

Re: [PATCH 0/3] Handle LEDs with the same name

2015-03-30 Thread Bryan Wu
On Mon, Mar 30, 2015 at 10:45 AM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: This is a rework of the original patch + 3 fixup patches from me. Contains a lot of feedback from Geert Uytterhoeven ge...@linux-m68k.org Thanks! Ricardo Ribalda Delgado (1): leds/led-class: Handle

Re: [PATCH] leds-gpio: Fix error handling and memory leak

2015-03-30 Thread Bryan Wu
On Thu, Mar 26, 2015 at 8:08 PM, Corey Minyard miny...@acm.org wrote: On 03/26/2015 08:20 PM, Bryan Wu wrote: On Mon, Mar 9, 2015 at 5:43 PM, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com The leds-gpio driver would not clean up properly if it failed in some places

Re: [PATCH v3] led/led-class: Handle LEDs with the same name

2015-03-27 Thread Bryan Wu
On Fri, Mar 27, 2015 at 1:09 AM, Ricardo Ribalda Delgado wrote: > Hi Sakari > > cc: adding Greg (core and FormatGuard) and Chistopher (sparse) >> >> I just realised there was another issue --- the name is now interpreted as >> format string. Bad things will happen if there's e.g. %s in the name

Re: [PATCH v3] led/led-class: Handle LEDs with the same name

2015-03-27 Thread Bryan Wu
On Fri, Mar 27, 2015 at 1:09 AM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: Hi Sakari cc: adding Greg (core and FormatGuard) and Chistopher (sparse) I just realised there was another issue --- the name is now interpreted as format string. Bad things will happen if there's e.g.

Re: [PATCH] leds-gpio: Fix error handling and memory leak

2015-03-26 Thread Bryan Wu
On Mon, Mar 9, 2015 at 5:43 PM, wrote: > From: Corey Minyard > > The leds-gpio driver would not clean up properly if it failed in some > places, and it wasn't freeing its private data. > > Signed-off-by: Corey Minyard > --- > drivers/leds/leds-gpio.c | 13 + > 1 file changed, 9

Re: [PATCH] leds-gpio: Fix error handling and memory leak

2015-03-26 Thread Bryan Wu
On Mon, Mar 9, 2015 at 5:43 PM, miny...@acm.org wrote: From: Corey Minyard cminy...@mvista.com The leds-gpio driver would not clean up properly if it failed in some places, and it wasn't freeing its private data. Signed-off-by: Corey Minyard cminy...@mvista.com ---

Re: [PATCH v3] led/led-class: Handle LEDs with the same name

2015-03-25 Thread Bryan Wu
On Wed, Mar 25, 2015 at 6:53 AM, Sakari Ailus wrote: > On Wed, Mar 25, 2015 at 02:22:53PM +0100, Ricardo Ribalda Delgado wrote: >> Hi Sakari! >> >> Regarding s/dev_info/dev_warn : Do you want to send the patch or I should >> >> do it? >> > >> > Is this one merged already? If yes, sure I can.

Re: [PATCH v3] led/led-class: Handle LEDs with the same name

2015-03-25 Thread Bryan Wu
On Wed, Mar 25, 2015 at 6:53 AM, Sakari Ailus sakari.ai...@iki.fi wrote: On Wed, Mar 25, 2015 at 02:22:53PM +0100, Ricardo Ribalda Delgado wrote: Hi Sakari! Regarding s/dev_info/dev_warn : Do you want to send the patch or I should do it? Is this one merged already? If yes, sure I can.

Re: [PATCH v2] leds: Add arbitrary pattern trigger

2015-03-20 Thread Bryan Wu
On Fri, Mar 20, 2015 at 7:42 AM, Raphaël Teysseyre wrote: > Hi all, > > Following your comments about [PATCH] leds: Add arbitrary pattern trigger, > here is a revised version of this patch. > > This is intended for embedded systems without screen or network access > to show a status (or error)

Re: [PATCH v2] leds: Add arbitrary pattern trigger

2015-03-20 Thread Bryan Wu
On Fri, Mar 20, 2015 at 7:42 AM, Raphaël Teysseyre rteysse...@gmail.com wrote: Hi all, Following your comments about [PATCH] leds: Add arbitrary pattern trigger, here is a revised version of this patch. This is intended for embedded systems without screen or network access to show a status

Re: [PATCH/RFC v13 02/13] dt-binding: leds: Add common LED DT bindings macros

2015-03-17 Thread Bryan Wu
On Thu, Mar 12, 2015 at 8:45 AM, Jacek Anaszewski wrote: > Add macros for defining boost mode and trigger type properties > of flash LED devices. > Applied, thanks, -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie

Re: [PATCH] leds: fix semicolon.cocci warnings

2015-03-17 Thread Bryan Wu
On Tue, Mar 17, 2015 at 12:42 PM, kbuild test robot wrote: > drivers/leds/leds-pm8941-wled.c:368:2-3: Unneeded semicolon > > > Removes unneeded semicolon. I fixed it and pushed again. Thanks, -Bryan > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > CC: Courtney Cavin >

Re: [PATCH v4 2/2] leds: add Qualcomm PM8941 WLED driver

2015-03-17 Thread Bryan Wu
On Thu, Mar 12, 2015 at 8:47 AM, Bjorn Andersson wrote: > > From: Courtney Cavin > > This adds support for the WLED ('White' LED) block on Qualcomm's > PM8941 PMICs. > Thanks, applied! -Bryan > Signed-off-by: Courtney Cavin > Signed-off-by: Bjorn Andersson > --- > Changes since v3: > - Use

Re: [PATCH] leds: fix semicolon.cocci warnings

2015-03-17 Thread Bryan Wu
On Tue, Mar 17, 2015 at 12:42 PM, kbuild test robot fengguang...@intel.com wrote: drivers/leds/leds-pm8941-wled.c:368:2-3: Unneeded semicolon Removes unneeded semicolon. I fixed it and pushed again. Thanks, -Bryan Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Courtney Cavin

Re: [PATCH/RFC v13 02/13] dt-binding: leds: Add common LED DT bindings macros

2015-03-17 Thread Bryan Wu
...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- include/dt-bindings/leds/common.h | 21 + 1 file changed, 21 insertions(+) create mode 100644 include/dt-bindings/leds/common.h diff --git a/include/dt-bindings/leds/common.h b/include/dt

Re: [PATCH v4 2/2] leds: add Qualcomm PM8941 WLED driver

2015-03-17 Thread Bryan Wu
On Thu, Mar 12, 2015 at 8:47 AM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: From: Courtney Cavin courtney.ca...@sonymobile.com This adds support for the WLED ('White' LED) block on Qualcomm's PM8941 PMICs. Thanks, applied! -Bryan Signed-off-by: Courtney Cavin

Re: [PATCH/RFC v12 04/19] dt-binding: leds: Add common LED DT bindings macros

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 11:56 PM, Jacek Anaszewski wrote: > On 03/04/2015 05:14 PM, Jacek Anaszewski wrote: >> >> Add macros for defining boost mode and trigger type properties >> of flash LED devices. >> >> Signed-off-by: Jacek Anaszewski >> Acked-by

Re: [PATCH/RFC v12 03/19] Documentation: leds: Add description of LED Flash class extension

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 8:14 AM, Jacek Anaszewski wrote: > The documentation being added contains overall description of the > LED Flash Class and the related sysfs attributes. > Thanks, merged! -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan

Re: [PATCH/RFC v12 02/19] leds: flash: document sysfs interface

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 8:14 AM, Jacek Anaszewski wrote: > Add a documentation of LED Flash class specific sysfs attributes. > Thanks, merged! -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Park > Cc: Bryan Wu > Cc: Richard Purdie > --- > Documentation

Re: [PATCH/RFC v12 01/19] leds: flash: Remove synchronized flash strobe feature

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 8:14 AM, Jacek Anaszewski wrote: > Synchronized flash strobe feature has been considered not fitting > for LED subsystem sysfs interface and thus is being removed. > OK, I will merge this. -Bryan > Signed-off-by: Jacek Anaszewski > Acked-by: Kyungmin Pa

Re: [PATCH RFC] leds: Add status code trigger

2015-03-09 Thread Bryan Wu
On Thu, Feb 19, 2015 at 12:26 AM, Raphaël Teysseyre wrote: > Hi all, > > Here is a new trigger. It would allow userspace to make an LED > blink with a pattern to show a status (or error) code to a human. > This is useful for embedded systems without screen or network > access. Obviously, the LED

Re: [PATCH v3 2/2] leds: add Qualcomm PM8941 WLED driver

2015-03-09 Thread Bryan Wu
On Tue, Feb 24, 2015 at 7:49 PM, Bjorn Andersson wrote: > From: Courtney Cavin > > This adds support for the WLED ('White' LED) block on Qualcomm's > PM8941 PMICs. > > Signed-off-by: Courtney Cavin > Signed-off-by: Bjorn Andersson > --- > > The details surrounding the OVP spike issue that

Re: [PATCH v2] leds: Introduce devres helper for led_classdev_register

2015-03-09 Thread Bryan Wu
On Mon, Feb 23, 2015 at 4:11 PM, Bjorn Andersson wrote: > Suggested-by: Stephen Boyd > Signed-off-by: Bjorn Andersson > --- > Changes since v1: > - updating devres.txt > - unregister function I merged this patch into my tree and added _unregister function into document. Thanks, -Bryan > >

Re: [PATCH v3 2/2] leds: add Qualcomm PM8941 WLED driver

2015-03-09 Thread Bryan Wu
On Tue, Feb 24, 2015 at 7:49 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: From: Courtney Cavin courtney.ca...@sonymobile.com This adds support for the WLED ('White' LED) block on Qualcomm's PM8941 PMICs. Signed-off-by: Courtney Cavin courtney.ca...@sonymobile.com Signed-off-by:

Re: [PATCH v2] leds: Introduce devres helper for led_classdev_register

2015-03-09 Thread Bryan Wu
On Mon, Feb 23, 2015 at 4:11 PM, Bjorn Andersson bjorn.anders...@sonymobile.com wrote: Suggested-by: Stephen Boyd sb...@codeaurora.org Signed-off-by: Bjorn Andersson bjorn.anders...@sonymobile.com --- Changes since v1: - updating devres.txt - unregister function I merged this patch into my

Re: [PATCH RFC] leds: Add status code trigger

2015-03-09 Thread Bryan Wu
On Thu, Feb 19, 2015 at 12:26 AM, Raphaël Teysseyre rteysse...@gmail.com wrote: Hi all, Here is a new trigger. It would allow userspace to make an LED blink with a pattern to show a status (or error) code to a human. This is useful for embedded systems without screen or network access.

Re: [PATCH/RFC v12 03/19] Documentation: leds: Add description of LED Flash class extension

2015-03-09 Thread Bryan Wu
-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- Documentation/leds/leds-class-flash.txt | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/leds/leds-class-flash.txt diff --git

Re: [PATCH/RFC v12 04/19] dt-binding: leds: Add common LED DT bindings macros

2015-03-09 Thread Bryan Wu
Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- include/dt-bindings/leds/max77693.h | 21 + 1 file changed, 21 insertions(+) create mode 100644 include/dt-bindings/leds/max77693.h This should be obviously

Re: [PATCH/RFC v12 02/19] leds: flash: document sysfs interface

2015-03-09 Thread Bryan Wu
On Wed, Mar 4, 2015 at 8:14 AM, Jacek Anaszewski j.anaszew...@samsung.com wrote: Add a documentation of LED Flash class specific sysfs attributes. Thanks, merged! -Bryan Signed-off-by: Jacek Anaszewski j.anaszew...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu

Re: [PATCH/RFC v12 01/19] leds: flash: Remove synchronized flash strobe feature

2015-03-09 Thread Bryan Wu
...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Cc: Bryan Wu coolo...@gmail.com Cc: Richard Purdie rpur...@rpsys.net --- drivers/leds/led-class-flash.c | 82 --- include/linux/led-class-flash.h | 14 --- include/linux/leds.h

Re: [PATCH 0/3] Add ktd2692 Flash LED driver

2015-03-02 Thread Bryan Wu
On Mon, Mar 2, 2015 at 1:15 AM, Sakari Ailus wrote: > H Ingi, > > On Mon, Mar 02, 2015 at 04:14:39PM +0900, Ingi Kim wrote: >> Hi Jacek >> >> On 2015년 02월 27일 17:42, Jacek Anaszewski wrote: >> > Hi Ingi, >> > >> > On 02/27/2015 02:01 AM, Ingi Kim wrote: >> >> This patch supports KTD2692 flash LED

Re: [PATCH v2 3/4] leds: Let the binding document example for leds-gpio follow the gpio bindings

2015-03-02 Thread Bryan Wu
On Mon, Mar 2, 2015 at 3:24 AM, Linus Walleij wrote: > On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl > wrote: > >> From: Olliver Schinagl >> >> In the gpio bindings documents it is requested to use the marco's in >> include/dt-bindings/gpio/gpio.h whenever possible. The gpios in the led >>

Re: [PATCH v2 3/4] leds: Let the binding document example for leds-gpio follow the gpio bindings

2015-03-02 Thread Bryan Wu
On Mon, Mar 2, 2015 at 3:24 AM, Linus Walleij linus.wall...@linaro.org wrote: On Wed, Jan 21, 2015 at 10:33 PM, Olliver Schinagl o.schin...@ultimaker.com wrote: From: Olliver Schinagl oli...@schinagl.nl In the gpio bindings documents it is requested to use the marco's in

Re: [PATCH 0/3] Add ktd2692 Flash LED driver

2015-03-02 Thread Bryan Wu
On Mon, Mar 2, 2015 at 1:15 AM, Sakari Ailus sakari.ai...@iki.fi wrote: H Ingi, On Mon, Mar 02, 2015 at 04:14:39PM +0900, Ingi Kim wrote: Hi Jacek On 2015년 02월 27일 17:42, Jacek Anaszewski wrote: Hi Ingi, On 02/27/2015 02:01 AM, Ingi Kim wrote: This patch supports KTD2692 flash LED

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-19 Thread Bryan Wu
On Tue, Feb 17, 2015 at 10:55 PM, Ricardo Ribalda Delgado wrote: > Hi > > On Wed, Feb 18, 2015 at 2:36 AM, Bryan Wu wrote: > >>> >> >> I got it. In this case we need to give the leds device a unique name. >> Go back to your patch, you're adding 0, 1 at the

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-19 Thread Bryan Wu
On Tue, Feb 17, 2015 at 10:55 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: Hi On Wed, Feb 18, 2015 at 2:36 AM, Bryan Wu coolo...@gmail.com wrote: I got it. In this case we need to give the leds device a unique name. Go back to your patch, you're adding 0, 1 at the end

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
> Thanks! On Tue, Feb 17, 2015 at 5:11 PM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > On Wed, Feb 18, 2015 at 1:52 AM, Bryan Wu wrote: >>> >>> Lets say that we have a type of add-on card. Described by this DT >>> overlay (card.dtb): >>&

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 4:32 PM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > On Wed, Feb 18, 2015 at 12:59 AM, Bryan Wu wrote: >> >> DT just describe the hardware, so if it's a different hardware, they >> should have different name. >> red0 for GPIO 0, red

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 3:47 PM, Ricardo Ribalda Delgado wrote: > Hi > > On Wed, Feb 18, 2015 at 12:35 AM, Bryan Wu wrote: > >> So why not use name "red0" and name another one "red1"? since you have >> multiple different red leds here any way. &g

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 2:54 PM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > On Tue, Feb 17, 2015 at 11:34 PM, Bryan Wu wrote: >> >> Can you show me your device tree code for overlaying describing a camera? >> > > The camera is composed by fpga modul

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 2:30 PM, Bjorn Andersson wrote: > On Tue, Feb 17, 2015 at 2:14 PM, Bryan Wu wrote: >> On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd wrote: >>> On 01/23/15 16:54, Bjorn Andersson wrote: >> >> Thanks for the review, Stephen. >> Bjorn

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Thu, Feb 12, 2015 at 12:45 PM, Ricardo Ribalda Delgado wrote: > Hello Bryan > > On Thu, Feb 12, 2015 at 8:48 PM, Bryan Wu wrote: >> >> Could you please give me some real error message or example about this >> device tree overlays? Looks like it's not only f

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-17 Thread Bryan Wu
On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd wrote: > On 01/23/15 16:54, Bjorn Andersson wrote: Thanks for the review, Stephen. Bjorn, could you please update your patch according to Stephen's review. -Bryan >> + >> +static int pm8941_wled_configure(struct pm8941_wled *wled, struct device >>

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 2:54 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: Hello Bryan On Tue, Feb 17, 2015 at 11:34 PM, Bryan Wu coolo...@gmail.com wrote: Can you show me your device tree code for overlaying describing a camera? The camera is composed by fpga modules

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 4:32 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: Hello Bryan On Wed, Feb 18, 2015 at 12:59 AM, Bryan Wu coolo...@gmail.com wrote: DT just describe the hardware, so if it's a different hardware, they should have different name. red0 for GPIO 0, red1

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
Thanks! On Tue, Feb 17, 2015 at 5:11 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: Hello Bryan On Wed, Feb 18, 2015 at 1:52 AM, Bryan Wu coolo...@gmail.com wrote: Lets say that we have a type of add-on card. Described by this DT overlay (card.dtb): I think who write

Re: [PATCH] led/led-class: Handle LEDs with the same name

2015-02-17 Thread Bryan Wu
On Tue, Feb 17, 2015 at 3:47 PM, Ricardo Ribalda Delgado ricardo.riba...@gmail.com wrote: Hi On Wed, Feb 18, 2015 at 12:35 AM, Bryan Wu coolo...@gmail.com wrote: So why not use name red0 and name another one red1? since you have multiple different red leds here any way. I cannot control

Re: [PATCH v2 2/2] leds: add Qualcomm PM8941 WLED driver

2015-02-17 Thread Bryan Wu
On Thu, Feb 12, 2015 at 8:04 PM, Stephen Boyd sb...@codeaurora.org wrote: On 01/23/15 16:54, Bjorn Andersson wrote: Thanks for the review, Stephen. Bjorn, could you please update your patch according to Stephen's review. -Bryan + +static int pm8941_wled_configure(struct pm8941_wled *wled,

  1   2   3   4   5   6   7   8   9   10   >