Re: /proc/net/dev regression

2015-01-11 Thread Carlos R. Mafra
On Sun, 11 Jan 2015 at 1:39:13 +, Al Viro wrote: > On Sun, Jan 11, 2015 at 01:33:35AM +0000, Carlos R. Mafra wrote: > > > I think the problem with wmnet is not that it was expecting the fields > > to be aligned because it never had problems before (when definitely more >

Re: /proc/net/dev regression

2015-01-11 Thread Carlos R. Mafra
On Sun, 11 Jan 2015 at 1:39:13 +, Al Viro wrote: On Sun, Jan 11, 2015 at 01:33:35AM +, Carlos R. Mafra wrote: I think the problem with wmnet is not that it was expecting the fields to be aligned because it never had problems before (when definitely more than 10 megabytes were

Re: /proc/net/dev regression

2015-01-10 Thread Carlos R. Mafra
On Sun, 11 Jan 2015 at 1:00:36 +, Al Viro wrote: > On Sun, Jan 11, 2015 at 12:27:06AM +, Al Viro wrote: > > On Sat, Jan 10, 2015 at 11:25:18PM +0000, Carlos R. Mafra wrote: > > > [mafra@linux-g29b:wmnet]$ cat net_dev_bad.txt >

Re: /proc/net/dev regression

2015-01-10 Thread Carlos R. Mafra
On Sun, 11 Jan 2015 at 0:27:06 +, Al Viro wrote: > On Sat, Jan 10, 2015 at 11:25:18PM +0000, Carlos R. Mafra wrote: > > [mafra@linux-g29b:wmnet]$ cat net_dev_bad.txt > > Inter-| Receive| Transmit > > face |bytesp

/proc/net/dev regression

2015-01-10 Thread Carlos R. Mafra
I use a dockapp called 'wmnet' [1] to monitor the speed of my internet connection and after the kernel v3.18 it does no longer work properly (it still doesn't work in v3.19-rc3) I bisected the problem and the culprit is this commit: commit 6e094bd805a9b6ad2f5421125db8f604a166616c Author: Rafał

/proc/net/dev regression

2015-01-10 Thread Carlos R. Mafra
I use a dockapp called 'wmnet' [1] to monitor the speed of my internet connection and after the kernel v3.18 it does no longer work properly (it still doesn't work in v3.19-rc3) I bisected the problem and the culprit is this commit: commit 6e094bd805a9b6ad2f5421125db8f604a166616c Author: Rafał

Re: /proc/net/dev regression

2015-01-10 Thread Carlos R. Mafra
On Sun, 11 Jan 2015 at 0:27:06 +, Al Viro wrote: On Sat, Jan 10, 2015 at 11:25:18PM +, Carlos R. Mafra wrote: [mafra@linux-g29b:wmnet]$ cat net_dev_bad.txt Inter-| Receive| Transmit face |bytespackets errs drop fifo frame

Re: /proc/net/dev regression

2015-01-10 Thread Carlos R. Mafra
On Sun, 11 Jan 2015 at 1:00:36 +, Al Viro wrote: On Sun, Jan 11, 2015 at 12:27:06AM +, Al Viro wrote: On Sat, Jan 10, 2015 at 11:25:18PM +, Carlos R. Mafra wrote: [mafra@linux-g29b:wmnet]$ cat net_dev_bad.txt Inter-| Receive

Re: Bisected regression from 3.17 still present in 3.19-rc1

2014-12-30 Thread Carlos R. Mafra
On Tue, 30 Dec 2014 at 11:36:53 +, Matthew Garrett wrote: > On Tue, 2014-12-30 at 10:16 +0000, Carlos R. Mafra wrote: > > On Tue, 30 Dec 2014 at 1:28:21 +, Matthew Garrett wrote: > > > What is CONFIG_ACPI_SBS set to? > > > > CONFIG_ACPI_SBS is not

Re: Bisected regression from 3.17 still present in 3.19-rc1

2014-12-30 Thread Carlos R. Mafra
On Tue, 30 Dec 2014 at 1:28:21 +, Matthew Garrett wrote: > On Sun, 2014-12-28 at 18:54 +0000, Carlos R. Mafra wrote: > > The laptop is a 2-year-old macbook Pro with retina display. > > > > I use a dockapp called wmlaptop2 (http://repo.or.cz/w/wmlaptop2.git) > >

Re: Bisected regression from 3.17 still present in 3.19-rc1

2014-12-30 Thread Carlos R. Mafra
On Tue, 30 Dec 2014 at 1:28:21 +, Matthew Garrett wrote: On Sun, 2014-12-28 at 18:54 +, Carlos R. Mafra wrote: The laptop is a 2-year-old macbook Pro with retina display. I use a dockapp called wmlaptop2 (http://repo.or.cz/w/wmlaptop2.git) which, among other things, displays

Re: Bisected regression from 3.17 still present in 3.19-rc1

2014-12-30 Thread Carlos R. Mafra
On Tue, 30 Dec 2014 at 11:36:53 +, Matthew Garrett wrote: On Tue, 2014-12-30 at 10:16 +, Carlos R. Mafra wrote: On Tue, 30 Dec 2014 at 1:28:21 +, Matthew Garrett wrote: What is CONFIG_ACPI_SBS set to? CONFIG_ACPI_SBS is not set There's your problem. The Darwin call

Re: Bisected regression from 3.17 still present in 3.19-rc1

2014-12-29 Thread Carlos R. Mafra
On Mon, 29 Dec 2014 at 23:20:13 +0100, Andreas Noever wrote: > On Mon, Dec 29, 2014 at 10:57 PM, Carlos R. Mafra wrote: > > On Mon, 29 Dec 2014 at 22:49:37 +0100, Rafael J. Wysocki wrote: > >> On Sunday, December 28, 2014 06:54:09 PM Carlos R. Mafra wrote: > >> > >

Re: Bisected regression from 3.17 still present in 3.19-rc1

2014-12-29 Thread Carlos R. Mafra
On Mon, 29 Dec 2014 at 22:49:37 +0100, Rafael J. Wysocki wrote: > On Sunday, December 28, 2014 06:54:09 PM Carlos R. Mafra wrote: > > > > The laptop is a 2-year-old macbook Pro with retina display. > > > > I use a dockapp called wmlaptop2 (http://repo.or.cz/w/wmla

Re: Bisected regression from 3.17 still present in 3.19-rc1

2014-12-29 Thread Carlos R. Mafra
On Mon, 29 Dec 2014 at 22:49:37 +0100, Rafael J. Wysocki wrote: On Sunday, December 28, 2014 06:54:09 PM Carlos R. Mafra wrote: The laptop is a 2-year-old macbook Pro with retina display. I use a dockapp called wmlaptop2 (http://repo.or.cz/w/wmlaptop2.git) which, among other things

Re: Bisected regression from 3.17 still present in 3.19-rc1

2014-12-29 Thread Carlos R. Mafra
On Mon, 29 Dec 2014 at 23:20:13 +0100, Andreas Noever wrote: On Mon, Dec 29, 2014 at 10:57 PM, Carlos R. Mafra crma...@gmail.com wrote: On Mon, 29 Dec 2014 at 22:49:37 +0100, Rafael J. Wysocki wrote: On Sunday, December 28, 2014 06:54:09 PM Carlos R. Mafra wrote: The laptop is a 2-year

Bisected regression from 3.17 still present in 3.19-rc1

2014-12-28 Thread Carlos R. Mafra
The laptop is a 2-year-old macbook Pro with retina display. I use a dockapp called wmlaptop2 (http://repo.or.cz/w/wmlaptop2.git) which, among other things, displays battery information (% of charge remaining etc). With the kernel v3.17 the battery information stopped working and it still does

Bisected regression from 3.17 still present in 3.19-rc1

2014-12-28 Thread Carlos R. Mafra
The laptop is a 2-year-old macbook Pro with retina display. I use a dockapp called wmlaptop2 (http://repo.or.cz/w/wmlaptop2.git) which, among other things, displays battery information (% of charge remaining etc). With the kernel v3.17 the battery information stopped working and it still does

Re: [Intel-gfx] External monitor issues with 3.17-rc4 and i915 module

2014-09-18 Thread Carlos R. Mafra
On Wed, 17 Sep 2014 at 11:39:57 +0300, Jani Nikula wrote: > On Tue, 16 Sep 2014, "Carlos R. Mafra" wrote: > > Hi, the same happens with 3.17-rc5. The kernel is unfortunately > > unusable with my external monitor because after some plug, unplug > > and susp

Re: [Intel-gfx] External monitor issues with 3.17-rc4 and i915 module

2014-09-18 Thread Carlos R. Mafra
On Wed, 17 Sep 2014 at 11:39:57 +0300, Jani Nikula wrote: On Tue, 16 Sep 2014, Carlos R. Mafra crma...@gmail.com wrote: Hi, the same happens with 3.17-rc5. The kernel is unfortunately unusable with my external monitor because after some plug, unplug and suspend to RAM cycles the behaviour

Re: External monitor issues with 3.17-rc4 and i915 module

2014-09-16 Thread Carlos R. Mafra
provide more information if necessary. On Tue, 9 Sep 2014 at 22:54:30 +0100, Carlos R. Mafra wrote: > There is an issue with the latest kernel 3.17-rc4 regarding my external > monitor. > > I boot my laptop and plug the external monitor with the VGA cable and > it works fine

Re: External monitor issues with 3.17-rc4 and i915 module

2014-09-16 Thread Carlos R. Mafra
provide more information if necessary. On Tue, 9 Sep 2014 at 22:54:30 +0100, Carlos R. Mafra wrote: There is an issue with the latest kernel 3.17-rc4 regarding my external monitor. I boot my laptop and plug the external monitor with the VGA cable and it works fine. Then I unplug the monitor

External monitor issues with 3.17-rc4 and i915 module

2014-09-09 Thread Carlos R. Mafra
There is an issue with the latest kernel 3.17-rc4 regarding my external monitor. I boot my laptop and plug the external monitor with the VGA cable and it works fine. Then I unplug the monitor and suspend to RAM. When the laptop resumes there are a bunch of warnings in 'dmesg' (see below). After

External monitor issues with 3.17-rc4 and i915 module

2014-09-09 Thread Carlos R. Mafra
There is an issue with the latest kernel 3.17-rc4 regarding my external monitor. I boot my laptop and plug the external monitor with the VGA cable and it works fine. Then I unplug the monitor and suspend to RAM. When the laptop resumes there are a bunch of warnings in 'dmesg' (see below). After

[3.17-rc3] Warning in ieee80211_can_queue_work

2014-09-01 Thread Carlos R. Mafra
I am using the kernel 3.17-rc3 which I compiled today and I get the warning below right before suspending to RAM: [ 37.856537] [ cut here ] [ 37.856559] WARNING: CPU: 3 PID: 43 at /home/mafra/linux-2.6/net/mac80211/util.c:716

[3.17-rc3] Warning in ieee80211_can_queue_work

2014-09-01 Thread Carlos R. Mafra
I am using the kernel 3.17-rc3 which I compiled today and I get the warning below right before suspending to RAM: [ 37.856537] [ cut here ] [ 37.856559] WARNING: CPU: 3 PID: 43 at /home/mafra/linux-2.6/net/mac80211/util.c:716

3.13.0-rc4+: Warning at drivers/gpu/drm/i915/intel_display.c

2013-12-17 Thread Carlos R. Mafra
I've been using an external monitor with my retina Macbook and sometimes I see the warning below. I think it happens when I unplug the monitor from the thunderbolt port (I use a converter to VGA). [10906.327043] [ cut here ] [10906.327059] WARNING: CPU: 3 PID: 643 at

3.13.0-rc4+: Warning at drivers/gpu/drm/i915/intel_display.c

2013-12-17 Thread Carlos R. Mafra
I've been using an external monitor with my retina Macbook and sometimes I see the warning below. I think it happens when I unplug the monitor from the thunderbolt port (I use a converter to VGA). [10906.327043] [ cut here ] [10906.327059] WARNING: CPU: 3 PID: 643 at

Re: ACPI errors with 3.7-rc3

2013-01-27 Thread Carlos R. Mafra
I started to encounter a dvb-related issue which requires me to reboot after trying to watch tv, so let's wee what happens. ] > On Sat, Jan 26, 2013 at 5:39 PM, Carlos R. Mafra wrote: > > On Sat, 26 Jan 2013 at 14:23:12 +0100, Rafael J. Wysocki wrote: > >> On Saturday, January 26

Re: ACPI errors with 3.7-rc3

2013-01-27 Thread Carlos R. Mafra
to encounter a dvb-related issue which requires me to reboot after trying to watch tv, so let's wee what happens. ] On Sat, Jan 26, 2013 at 5:39 PM, Carlos R. Mafra crma...@gmail.com wrote: On Sat, 26 Jan 2013 at 14:23:12 +0100, Rafael J. Wysocki wrote: On Saturday, January 26, 2013 12:23:37 PM

Re: ACPI errors with 3.7-rc3

2013-01-26 Thread Carlos R. Mafra
On Sat, 26 Jan 2013 at 14:23:12 +0100, Rafael J. Wysocki wrote: > On Saturday, January 26, 2013 12:23:37 PM Carlos R. Mafra wrote: > > On Thu, 8 Nov 2012 at 5:47:15 +0100, Greg KH wrote: > > > On Wed, Nov 07, 2012 at 10:49:40PM +0100, Rafael J. Wysocki wrote: > > >

Re: ACPI errors with 3.7-rc3

2013-01-26 Thread Carlos R. Mafra
On Thu, 8 Nov 2012 at 5:47:15 +0100, Greg KH wrote: > On Wed, Nov 07, 2012 at 10:49:40PM +0100, Rafael J. Wysocki wrote: > > On Tuesday, November 06, 2012 01:48:26 PM Greg KH wrote: > > > On Tue, Nov 06, 2012 at 04:42:24PM +0400, Azat Khuzhin wrote: > > > > I'v also have such errors on my

Re: ACPI errors with 3.7-rc3

2013-01-26 Thread Carlos R. Mafra
On Thu, 8 Nov 2012 at 5:47:15 +0100, Greg KH wrote: On Wed, Nov 07, 2012 at 10:49:40PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 06, 2012 01:48:26 PM Greg KH wrote: On Tue, Nov 06, 2012 at 04:42:24PM +0400, Azat Khuzhin wrote: I'v also have such errors on my macbook pro.

Re: ACPI errors with 3.7-rc3

2013-01-26 Thread Carlos R. Mafra
On Sat, 26 Jan 2013 at 14:23:12 +0100, Rafael J. Wysocki wrote: On Saturday, January 26, 2013 12:23:37 PM Carlos R. Mafra wrote: On Thu, 8 Nov 2012 at 5:47:15 +0100, Greg KH wrote: On Wed, Nov 07, 2012 at 10:49:40PM +0100, Rafael J. Wysocki wrote: On Tuesday, November 06, 2012 01:48:26

Re: 2.6.25-rc1 regression - ondemand governor does not work at all

2008-02-13 Thread Carlos R. Mafra
Lukas Hejtmanek wrote: > Hello, > > as of 2.6.25-rc1, ondemand governor from cpufreq (acpi-p states driver) does > not change frequency. Machine is still running at max frequency regardless of > system load. Try the patch here: http://lkml.org/lkml/2008/2/12/351 -- To unsubscribe from this

Re: 2.6.25-rc1 regression - ondemand governor does not work at all

2008-02-13 Thread Carlos R. Mafra
Lukas Hejtmanek wrote: Hello, as of 2.6.25-rc1, ondemand governor from cpufreq (acpi-p states driver) does not change frequency. Machine is still running at max frequency regardless of system load. Try the patch here: http://lkml.org/lkml/2008/2/12/351 -- To unsubscribe from this list:

Re: [PATCH] timeconst.pl: correct reversal of USEC_TO_HZ and HZ_TO_USEC

2008-02-12 Thread Carlos R. Mafra
OTECTED]> Tested-by: Carlos R. Mafra <[EMAIL PROTECTED]> > --- > kernel/timeconst.pl |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/timeconst.pl b/kernel/timeconst.pl > index 62b1287..4146803 100644 > --- a/kernel/timeconst.p

Re: [2.6.25-rc1] Strange regression with CONFIG_HZ_300=y

2008-02-12 Thread Carlos R. Mafra
H. Peter Anvin wrote: > Eric Piel wrote: >>> >>> The laptop is a Vaio VGN-FZ240E, core 2 duo T7250 @ 2.0 GHz and the >>> kernel is x86_64. >> >> Hi, it's great you found out the culprit commit because I was really >> wondering where this bug was coming from... >> As a data point, my machine has a

Re: [2.6.25-rc1] Strange regression with CONFIG_HZ_300=y

2008-02-12 Thread Carlos R. Mafra
Eric Piel wrote: > Carlos R. Mafra wrote: >> I apologize in advance if I am crazy about this, but I noticed >> a strange regression wrt 2.6.24 in cpufreq (I think) in 2.6.25-rc1, which >> goes away if I revert the following commit: >> >> commit bdc807871d58285737d5

Re: [PATCH] timeconst.pl: correct reversal of USEC_TO_HZ and HZ_TO_USEC

2008-02-12 Thread Carlos R. Mafra
H. Peter Anvin wrote: The USEC_TO_HZ and HZ_TO_USEC constant sets were mislabelled, with seriously incorrect results. This among other things manifested itself as cpufreq not working when a tickless kernel was configured. Signed-off-by: H. Peter Anvin [EMAIL PROTECTED] Tested-by: Carlos R

Re: [2.6.25-rc1] Strange regression with CONFIG_HZ_300=y

2008-02-12 Thread Carlos R. Mafra
H. Peter Anvin wrote: Eric Piel wrote: The laptop is a Vaio VGN-FZ240E, core 2 duo T7250 @ 2.0 GHz and the kernel is x86_64. Hi, it's great you found out the culprit commit because I was really wondering where this bug was coming from... As a data point, my machine has a core 2 duo @

Re: [2.6.25-rc1] Strange regression with CONFIG_HZ_300=y

2008-02-12 Thread Carlos R. Mafra
Eric Piel wrote: Carlos R. Mafra wrote: I apologize in advance if I am crazy about this, but I noticed a strange regression wrt 2.6.24 in cpufreq (I think) in 2.6.25-rc1, which goes away if I revert the following commit: commit bdc807871d58285737d50dc6163d0feb72cb0dc2 Author: H. Peter Anvin

Re: [2.6.25-rc1 regression] Suspend to RAM (bisected)

2008-02-11 Thread Carlos R. Mafra
Venki Pallipadi wrote: > On Mon, Feb 11, 2008 at 12:06:50PM -0800, Venki Pallipadi wrote: >> On Mon, Feb 11, 2008 at 05:37:04PM -0200, Carlos R. Mafra wrote: >>> Pallipadi, Venkatesh wrote: >>>> Can you send me the output of acpidump and full dmesg to me. Looks like &

[2.6.25-rc1] Strange regression with CONFIG_HZ_300=y

2008-02-11 Thread Carlos R. Mafra
ys use the ondemand governor compiled in and as the default governor). The laptop is a Vaio VGN-FZ240E, core 2 duo T7250 @ 2.0 GHz and the kernel is x86_64. If someone needs more information about this I will be happy to provide. Carlos R. Mafra -- To unsubscribe from this list: send the line "

[2.6.25-rc1] Strange regression with CONFIG_HZ_300=y

2008-02-11 Thread Carlos R. Mafra
the ondemand governor compiled in and as the default governor). The laptop is a Vaio VGN-FZ240E, core 2 duo T7250 @ 2.0 GHz and the kernel is x86_64. If someone needs more information about this I will be happy to provide. Carlos R. Mafra -- To unsubscribe from this list: send the line unsubscribe

Re: [2.6.25-rc1 regression] Suspend to RAM (bisected)

2008-02-11 Thread Carlos R. Mafra
Venki Pallipadi wrote: On Mon, Feb 11, 2008 at 12:06:50PM -0800, Venki Pallipadi wrote: On Mon, Feb 11, 2008 at 05:37:04PM -0200, Carlos R. Mafra wrote: Pallipadi, Venkatesh wrote: Can you send me the output of acpidump and full dmesg to me. Looks like it is a platform issue due to which we

Re: [2.6.25-rc1 regression] Suspend to RAM (bisected)

2008-02-10 Thread Carlos R. Mafra
Arjan van de Ven wrote: > On Mon, 11 Feb 2008 03:25:33 -0200 > "Carlos R. Mafra" <[EMAIL PROTECTED]> wrote: > >> The problem with suspend to RAM is that right after typing (from >> inside X) 'echo mem > /sys/power/state' the screen becomes black and >

[2.6.25-rc1 regression] Suspend to RAM (bisected)

2008-02-10 Thread Carlos R. Mafra
rev 0c) (prog-if 00 [VGA]) If there is anything else I can do to help please let me know. Carlos R. Mafra -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info

[2.6.25-rc1 regression] Suspend to RAM (bisected)

2008-02-10 Thread Carlos R. Mafra
]) If there is anything else I can do to help please let me know. Carlos R. Mafra -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [2.6.25-rc1 regression] Suspend to RAM (bisected)

2008-02-10 Thread Carlos R. Mafra
Arjan van de Ven wrote: On Mon, 11 Feb 2008 03:25:33 -0200 Carlos R. Mafra [EMAIL PROTECTED] wrote: The problem with suspend to RAM is that right after typing (from inside X) 'echo mem /sys/power/state' the screen becomes black and the laptop freezes. I have to use SysRq+b to reboot. I

[PATCH] x86: Clean up k8topology.c

2008-01-02 Thread Carlos R. Mafra
f9f48331a7eca4fc60d2a03369dc5f53 k8topology_64.o.before Signed-off-by: Carlos R. Mafra <[EMAIL PROTECTED]> diff --git a/arch/x86/mm/k8topology_64.c b/arch/x86/mm/k8topology_64.c index 3695c9e..32b963d 100644 --- a/arch/x86/mm/k8topology_64.c +++ b/arch/x86/mm/k8topology_64.c @@ -1,9 +1,9 @@ -/* +/* *

[PATCH] x86: Clean up k8topology.c

2008-01-02 Thread Carlos R. Mafra
f9f48331a7eca4fc60d2a03369dc5f53 k8topology_64.o.before Signed-off-by: Carlos R. Mafra [EMAIL PROTECTED] diff --git a/arch/x86/mm/k8topology_64.c b/arch/x86/mm/k8topology_64.c index 3695c9e..32b963d 100644 --- a/arch/x86/mm/k8topology_64.c +++ b/arch/x86/mm/k8topology_64.c @@ -1,9 +1,9 @@ -/* +/* * AMD K8

Re: [PATCH] Fix errors detected by checkpatch.pl on nmi_int.c

2008-01-01 Thread Carlos R. Mafra
On Tue 1.Jan'08 at 17:05:49 -0800, Carlos R. Mafra wrote: > This patch fixes most errors detected by checkpatch.pl. > [...] As pointed out by Jesper Juhl, my patch was not inlined :-( I did set up mutt especially to send this patch (instead of thunderbird), and I did test it before s

[PATCH] Fix errors detected by checkpatch.pl on nmi_int.c

2008-01-01 Thread Carlos R. Mafra
-by: Carlos R. Mafra <[EMAIL PROTECTED]> diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c index 2d0eeac..9510b08 100644 --- a/arch/x86/oprofile/nmi_int.c +++ b/arch/x86/oprofile/nmi_int.c @@ -18,11 +18,11 @@ #include #include #include - + #include "op_counter.h

[PATCH] Fix errors detected by checkpatch.pl on nmi_int.c

2008-01-01 Thread Carlos R. Mafra
-by: Carlos R. Mafra [EMAIL PROTECTED] diff --git a/arch/x86/oprofile/nmi_int.c b/arch/x86/oprofile/nmi_int.c index 2d0eeac..9510b08 100644 --- a/arch/x86/oprofile/nmi_int.c +++ b/arch/x86/oprofile/nmi_int.c @@ -18,11 +18,11 @@ #include asm/nmi.h #include asm/msr.h #include asm/apic.h

Re: [PATCH] Fix errors detected by checkpatch.pl on nmi_int.c

2008-01-01 Thread Carlos R. Mafra
On Tue 1.Jan'08 at 17:05:49 -0800, Carlos R. Mafra wrote: This patch fixes most errors detected by checkpatch.pl. [...] As pointed out by Jesper Juhl, my patch was not inlined :-( I did set up mutt especially to send this patch (instead of thunderbird), and I did test it before sending