Dear Greg,
This is extcon-next pull request for v5.13. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit e49d033bddf5b565044e2abe4241353959bc9120:
Linux 5.12-rc6 (2021-04-04 14
]
between devfreq and drm for gpu driver.
[1]
https://patchwork.kernel.org/project/linux-pm/patch/20210308133041.10516-1-daniel.lezc...@linaro.org/
Best Regards,
Chanwoo Choi
The following changes since commit e49d033bddf5b565044e2abe4241353959bc9120:
Linux 5.12-rc6 (2021-04-04 14:15:36 -0700
On 4/1/21 9:16 AM, Chanwoo Choi wrote:
> On 3/31/21 10:03 PM, andrew-sh.cheng wrote:
>> On Wed, 2021-03-31 at 17:35 +0900, Chanwoo Choi wrote:
>>> On 3/31/21 5:27 PM, Chanwoo Choi wrote:
>>>> Hi,
>>>>
>>>> On 3/31/21 5:03 PM, andrew-sh.cheng w
On 3/31/21 10:03 PM, andrew-sh.cheng wrote:
> On Wed, 2021-03-31 at 17:35 +0900, Chanwoo Choi wrote:
>> On 3/31/21 5:27 PM, Chanwoo Choi wrote:
>>> Hi,
>>>
>>> On 3/31/21 5:03 PM, andrew-sh.cheng wrote:
>>>> On Thu, 2021-03-25 at 17:14 +090
On 3/31/21 5:27 PM, Chanwoo Choi wrote:
> Hi,
>
> On 3/31/21 5:03 PM, andrew-sh.cheng wrote:
>> On Thu, 2021-03-25 at 17:14 +0900, Chanwoo Choi wrote:
>>> Hi,
>>>
>>> You are missing to add these patches to linux-pm mailing list.
>>> Need to sen
Hi,
On 3/31/21 5:03 PM, andrew-sh.cheng wrote:
> On Thu, 2021-03-25 at 17:14 +0900, Chanwoo Choi wrote:
>> Hi,
>>
>> You are missing to add these patches to linux-pm mailing list.
>> Need to send them to linu-pm ML.
>>
>> Also, before received this se
t; +
> cci_df->cci_clk = devm_clk_get(cci_dev, "cci_clock");
> ret = PTR_ERR_OR_ZERO(cci_df->cci_clk);
> if (ret) {
> @@ -152,6 +176,9 @@ static int mtk_cci_devfreq_probe(struct platform_device
> *pdev)
> goto err_opp;
> }
>
> + opp_nb->notifier_call = ccidevfreq_opp_notifier;
> + dev_pm_opp_register_notifier(cci_dev, opp_nb);
Need to check whether return value is valid or not.
> +
> return 0;
>
> err_opp:
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
You are missing to add these patches to linux-pm mailing list.
Need to send them to linu-pm ML.
Also, before received this series, I tried to clean-up these patches
on testing branch[1]. So that I add my comment with my clean-up case.
[1]
of devfreq,
you can use devfreq_register_opp_notifier/devfreq_unregister_opp_notifier
functions.
> + dev_pm_opp_of_remove_table(cci_dev);
> + regulator_disable(cci_df->cpu_reg);
> +
> + return 0;
> +}
> +
> +static const __maybe_unused struct of_device_id
> + mediatek_cci_of_match[] = {
Need to change it as following at same line:
static const __maybe_unused struct of_device_idmediatek_cci_of_match[] = {
> + { .compatible = "mediatek,mt8183-cci" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, mediatek_cci_of_match);
> +
> +static struct platform_driver cci_devfreq_driver = {
> + .probe = mtk_cci_devfreq_probe,
> + .remove = mtk_cci_devfreq_remove,
> + .driver = {
> + .name = "mediatek-cci-devfreq",
> + .of_match_table = of_match_ptr(mediatek_cci_of_match),
> + },
> +};
> +
> +module_platform_driver(cci_devfreq_driver);
> +
> +MODULE_DESCRIPTION("Mediatek CCI devfreq driver");
> +MODULE_AUTHOR("Andrew-sh.Cheng ");
> +MODULE_LICENSE("GPL v2");
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
y.
> + * @dev: reference to cpu device.
> + * @opp_table: reference to cpu opp table.
> + *
> + * This structure stores the required cpu_state of a cpu.
> + * This is auto-populated by the governor.
> + */
> +struct devfreq_cpu_state;
> +
> +enum devfreq_parent_d
work-queue
>>> initialization fails.
>>>
>>> Signed-off-by: Matti Vaittinen
>>> Suggested-by: Chanwoo Choi
>>> ---
>>> drivers/extcon/extcon-gpio.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff
Hi,
Need to fix the work as following:
s/extconn/extcon
And I'd like you to use the more correct patch title like the following example:
"extcon: Use resource-managed function for delayed work"
Thanks,
Chanwoo Choi
On 3/23/21 10:57 PM, Matti Vaittinen wrote:
> Few drivers implemen
title
-PM / devfreq: event: Fix typos
--
Best Regards,
Samsung Electronics
Chanwoo Choi
req;
@@ -390,7 +393,7 @@ static int devfreq_set_target(struct devfreq *devfreq,
unsigned long new_freq,
if (devfreq->suspend_freq)
devfreq->resume_freq = new_freq;
- return err;
+ return 0;
}
/**
--
Best Regards,
Samsung Electronics
Chanwoo Choi
t;profile.get_dev_status = imx8m_ddrc_get_dev_status;
priv->profile.exit = imx8m_ddrc_exit;
priv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq;
priv->profile.initial_freq = clk_get_rate(priv->dram_core);
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
nclude per device governor
* init and exit, opp changes out of devfreq, suspend
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
target(struct devfreq *devfreq,
unsigned long new_freq,
devfreq->previous_freq = new_freq;
if (devfreq->suspend_freq)
- devfreq->resume_freq = cur_freq;
+ devfreq->resume_freq = new_freq;
return err;
}
Applied it.
--
Best Regards,
Sa
Hi,
On 3/23/21 3:11 PM, Aisheng Dong wrote:
>> From: Chanwoo Choi
>> Sent: Tuesday, March 23, 2021 12:11 PM
>>
>> Hi,
>>
>> On 3/23/21 12:25 PM, Dong Aisheng wrote:
>>> Hi Chanwoo,
>>>
>>> On Tue, Mar 23, 2021 at 11:13 AM Dong
| 37 +++
>> drivers/devfreq/governor.h| 2 -
>> drivers/devfreq/governor_simpleondemand.c | 31 ++--
>> drivers/devfreq/imx8m-ddrc.c | 14 ---
>> 5 files changed, 35 insertions(+), 54 deletions(-)
>>
>> --
>> 2.25.1
>>
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
On 3/18/21 6:54 PM, Chanwoo Choi wrote:
> On 3/18/21 5:03 PM, Dong Aisheng wrote:
>> Hi Chanwoo,
>>
>> On Sat, Mar 13, 2021 at 2:45 PM Dong Aisheng wrote:
>>>
>>> On Sat, Mar 13, 2021 at 12:09 AM Chanwoo Choi wrote:
>>>>
>>>> On 21.
On 3/18/21 5:03 PM, Dong Aisheng wrote:
> Hi Chanwoo,
>
> On Sat, Mar 13, 2021 at 2:45 PM Dong Aisheng wrote:
>>
>> On Sat, Mar 13, 2021 at 12:09 AM Chanwoo Choi wrote:
>>>
>>> On 21. 3. 12. 오후 7:57, Dong Aisheng wrote:
>>>> On Thu, Mar 11, 20
v,
>
> if (devfreq->profile->timer < 0
> || devfreq->profile->timer >= DEVFREQ_TIMER_NUM) {
> - goto err_out;
> + mutex_unlock(>lock);
> + goto err_dev;
> }
>
> if (!devfreq->profile->max_state && !devfreq->profile->freq_table) {
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Fixes: 4dc3bab8687f ("PM / devfreq: Add support delayed timer for polling mode")
Also, need to send it to stable lkml.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Dear Greg,
This is extcon-fixes pull request for v5.12. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit 1e28eed17697bcf343c6743f0028cc3b5dd88bf0:
Linux 5.12-rc3 (2021-03-14 14
On 21. 3. 12. 오후 7:57, Dong Aisheng wrote:
On Thu, Mar 11, 2021 at 2:54 PM Chanwoo Choi wrote:
On 3/10/21 1:56 PM, Dong Aisheng wrote:
On Wed, Mar 10, 2021 at 11:08 AM Chanwoo Choi wrote:
On 3/10/21 11:56 AM, Dong Aisheng wrote:
On Wed, Mar 10, 2021 at 12:12 AM Chanwoo Choi wrote
On 3/10/21 1:56 PM, Dong Aisheng wrote:
> On Wed, Mar 10, 2021 at 11:08 AM Chanwoo Choi wrote:
>>
>> On 3/10/21 11:56 AM, Dong Aisheng wrote:
>>> On Wed, Mar 10, 2021 at 12:12 AM Chanwoo Choi wrote:
>>>>
>>>> On 21. 3. 10. 오전 12:58, Chanwoo Choi
On 3/10/21 12:00 PM, Dong Aisheng wrote:
> On Wed, Mar 10, 2021 at 12:20 AM Chanwoo Choi wrote:
>>
>> On 21. 3. 9. 오후 9:58, Dong Aisheng wrote:
>>> Check .get_dev_status() in devfreq_update_stats in case it's abused
>>> when a device does not provide it.
&g
On 3/10/21 11:56 AM, Dong Aisheng wrote:
> On Wed, Mar 10, 2021 at 12:12 AM Chanwoo Choi wrote:
>>
>> On 21. 3. 10. 오전 12:58, Chanwoo Choi wrote:
>>> On 21. 3. 9. 오후 9:58, Dong Aisheng wrote:
>>>> The devfreq monitor depends on the device to provide load
On 3/10/21 11:43 AM, Dong Aisheng wrote:
> On Tue, Mar 9, 2021 at 11:53 PM Chanwoo Choi wrote:
>>
>> On 21. 3. 9. 오후 9:58, Dong Aisheng wrote:
>>> Use the more accurate returned new_freq as resume_freq.
>>> It's the same as how devfreq->previous_freq was
ung Electronics
Chanwoo Choi
iv->profile.get_cur_freq = imx8m_ddrc_get_cur_freq;
priv->profile.initial_freq = clk_get_rate(priv->dram_core);
Acked-by: Chanwoo Choi
Will merge this patch after finishing the discussion of
prev patch related to.get_dev_status.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
t_status.busy_time = 0;
df->last_status.current_frequency = 0;
return 0;
}
return df->profile->get_dev_status(df->dev.parent, >last_status);
}
#endif /* _GOVERNOR_H */
--
Best Regards,
Samsung Electronics
Chanwoo Choi
On 21. 3. 10. 오전 12:58, Chanwoo Choi wrote:
On 21. 3. 9. 오후 9:58, Dong Aisheng wrote:
The devfreq monitor depends on the device to provide load information
by .get_dev_status() to calculate the next target freq.
And this will cause changing governor to simple ondemand fail
if device can't
l/git/chanwoo/linux.git/commit/?h=devfreq-testing=dc9e557845c17cee173a6adcc3ae14940da03f44
--
Best Regards,
Samsung Electronics
Chanwoo Choi
)
{
+ if (!df->profile->get_dev_status)
+ return -EINVAL;
+
return df->profile->get_dev_status(df->dev.parent, >last_status);
}
#endif /* _GOVERNOR_H */
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
rt() usage.
please check the tegra30-devfreq.c for this update.
$ grep -rn "devfreq_monitor_start" drivers/
drivers/devfreq/governor_simpleondemand.c:92:
devfreq_monitor_start(devfreq);
drivers/devfreq/tegra30-devfreq.c:744: devfreq_monitor_start(devfreq);
..
--
Best Regards,
Samsung Electronics
Chanwoo Choi
upport for suspend/resume of a devfreq device
--
Best Regards,
Samsung Electronics
Chanwoo Choi
q, new_freq, cur_freq);
freqs.new = new_freq;
I'd like you to squash patch4 with patch6 because actually patch6
is too minor clean-up. I think it is possible.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
Applied it. But, if you have any other objection, please let me know.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
e governor
* init and exit, opp changes out of devfreq, suspend
As I replied from patch1, I recommend that squash it with patch1.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
one patch with patch1/2 by
squashing.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
<60>;
> };
>
Applied it with following minor fixup (unneeded spaces). Thanks
diff --git a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
index ddde2c4f97df..ac189dd82b08 100644
--- a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
+++ b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
@@ -154,7 +154,7 @@ Following properties relate to DDR timing:
driver strength. Default value is 80.
- rockchip,phy_lpddr4_odt : When the DRAM type is LPDDR4, this parameter
defines
- the PHY side ODT strength. Default value is
60.
+ the PHY side ODT strength. Default value is
60.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
-by: Enric Balletbo i Serra
> Reviewed-by: Chanwoo Choi
> Acked-by: Rob Herring
> Signed-off-by: Gaël PORTAY
> Acked-by: MyungJoo Ham
> Signed-off-by: Daniel Lezcano
> ---
> Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt | 2 ++
> 1 file changed, 2 insertions(
; Did you experience a new/different issue?
>>
>> The patch should be fine and address the problem, I just didn't see it was
>> already fixed in linux-next as I'm still testing on mainline (rc2 at
>> the moment).
>>
>> I assume the fix will make it into a future -rc then.
>
> It's still only in linux-next via extcon tree, so it seems Greg did
> not take it yet.
>
> Chanwoo,
> You might need to follow up on this, so your pull request won't get lost.
I'm sorry. Because of my fault, the previous pull request was not merged to
v5.12-rc1.
To fix this issue, I'll send the pull request for rc3 to Greg.
Best Regards,
Chanwoo Choi
Samsung Electronics
provide a flag in the devfreq's profile to
> tell the common devfreq code to register the newly created devfreq as
> a cooling device.
>
> Suggested-by: Chanwoo Choi
> Signed-off-by: Daniel Lezcano
> Reviewed-by: Steven Price
> Reviewed-by: Lukasz Luba
> ---
> V6:
>
On 21. 3. 7. 오후 11:28, Daniel Lezcano wrote:
On 07/03/2021 15:16, Chanwoo Choi wrote:
On 21. 3. 7. 오후 6:45, Daniel Lezcano wrote:
Currently the default behavior is to manually having the devfreq
backend to register themselves as a devfreq cooling device.
Instead of adding the code
provide a flag in the devfreq's profile to
> tell the common devfreq code to register the newly created devfreq as
> a cooling device.
>
> Suggested-by: Chanwoo Choi
> Signed-off-by: Daniel Lezcano
> ---
> V3:
> - Rebased on linux-pm branch without units.h
> - Set the c
profile to
tell the common devfreq code to register the newly created devfreq as
a cooling device.
Suggested-by: Chanwoo Choi
Signed-off-by: Daniel Lezcano
---
V3:
- Rebased on linux-pm branch without units.h
- Set the cdev to NULL in case of error
- Added description for the cdev
in the devfreq's profile to
tell the common devfreq code to register the newly created devfreq as
a cooling device.
Suggested-by: Chanwoo Choi
Signed-off-by: Daniel Lezcano
---
drivers/devfreq/devfreq.c | 11 +++
include/linux/devfreq.h | 7 +++
2 files changed, 18 insertions(+)
diff --git
103,6 +103,7 @@ struct devfreq_dev_profile {
unsigned long initial_freq;
unsigned int polling_ms;
enum devfreq_timer timer;
+ bool is_cooling_device;
int (*target)(struct device *dev, unsigned long *freq, u32 flags);
int (*get_dev_status)(struct device
On 21. 2. 28. 오전 1:35, Krzysztof Kozlowski wrote:
On Sat, 29 Aug 2020 at 15:10, Chanwoo Choi wrote:
On Sat, Aug 29, 2020 at 12:31 AM Krzysztof Kozlowski wrote:
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and the error value gets printed
Hi,
You missed sending the patches to linux-pm mailing list.
On next version, please send it linux-pm.
Thanks,
Chanwoo Choi
On 21. 2. 20. 오전 12:59, Abel Vesa wrote:
This has been on my queue for quite some time now. It is more of a
proof-of-concept.
This rework is done with the compatibility
m-noc",},
+ { .compatible = "fsl,imx8mn-noc",},
{ .compatible = "fsl,imx8m-noc", },
{ .compatible = "fsl,imx8m-nic", },
{ /* sentinel */ },
For this patch, you need to get the ack of use of new 'fsl,icc-id
property'. IMO, looks good to me.
Acked-by: Chanwoo Choi
And you must update the DT binding document.
[1] Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
Thanks,
Chanwoo Choi
On 21. 2. 20. 오전 1:00, Abel Vesa wrote:
Seems that, in order to be able to resume from suspend, the dram rate
needs to be the highest one available. Therefore, add the late system
suspend/resume PM ops which set the highest rate on suspend and the
latest one used before suspending on resume.
Hi,
On 21. 2. 20. 오전 1:00, Abel Vesa wrote:
i.MX8M platforms get their dram OPPs from the EL3.
We don't need to duplicate that in the kernel dram dts node.
We should just trust the OPPs provided by the EL3.
Signed-off-by: Abel Vesa
---
drivers/devfreq/imx8m-ddrc.c | 49
riv;
- const char *gov = DEVFREQ_GOV_USERSPACE;
+ const char *gov = DEVFREQ_GOV_POWERSAVE;
int ret;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
Acked-by: Chanwoo Choi
Thanks,
Chanwoo Choi
dev;
struct imx8m_ddrc *priv;
- const char *gov = DEVFREQ_GOV_USERSPACE;
+ const char *gov = DEVFREQ_GOV_POWERSAVE;
int ret;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
Acked-by: Chanwoo Choi
Thanks,
Chanwoo Choi
On 21. 2. 26. 오후 5:51, Daniel Lezcano wrote:
On 26/02/2021 07:08, Chanwoo Choi wrote:
On 21. 2. 24. 오후 11:42, Daniel Lezcano wrote:
HZ unit conversion macros are available in units.h, use them and
remove the duplicate definition.
Signed-off-by: Daniel Lezcano
Reviewed-by: Christian
On 21. 2. 24. 오후 11:42, Daniel Lezcano wrote:
HZ unit conversion macros are available in units.h, use them and
remove the duplicate definition.
Signed-off-by: Daniel Lezcano
Reviewed-by: Christian Eggers
Acked-by: Chanwoo Choi
---
drivers/devfreq/devfreq.c | 2 +-
1 file changed, 1
con_dev *edev)
sizeof(*edev->nh), GFP_KERNEL);
if (!edev->nh) {
ret = -ENOMEM;
+ device_unregister(>dev);
goto err_dev;
}
Thanks for fixup. Applied it.
Thanks,
Chanwoo Choi
+ - const: usb_vbus
required:
- compatible
Applied it.
Thanks,
Chanwoo Choi
x900>;
+interrupts = <0x0 0x9 0 IRQ_TYPE_EDGE_BOTH>;
+interrupt-names = "usb_id";
+};
+};
+
+usb-controller {
+ extcon = <_id>;
+};
Applied it.
Thanks,
Chanwoo Choi
if (device_may_wakeup(dev)) {
+ if (info->id_irq > 0)
+ ret = disable_irq_wake(info->id_irq);
+ if (info->vbus_irq > 0)
+ ret = disable_irq_wake(info->vbus_irq);
+ }
return ret;
}
Looks good to me. Apply it. for v5.13-rc1.
Thanks,
Chanwoo Choi
On 2/16/21 7:41 PM, Lukasz Luba wrote:
> Hi Chanwoo,
>
> On 2/15/21 3:00 PM, Chanwoo Choi wrote:
>> Hi Lukasz,
>>
>> On Fri, Feb 12, 2021 at 7:28 AM Lukasz Luba wrote:
>>>
>>>
>>>
>>> On 2/11/21 11:07 AM, Lukasz Luba wrote:
&
mal/devfreq_cooling.c
> @@ -19,10 +19,10 @@
> #include
> #include
> #include
> +#include
>
> #include
>
> -#define HZ_PER_KHZ 1000
> #define SCALE_ERROR_MITIGATION 100
>
> static DEFINE_IDA(devfreq_ida);
>
For devfreq part,
Acked-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi,
Please use get_maintainer.pl script when you send the patches.
I didn't receive the patches. I'll review.
Thanks,
Chanwoo Choi
On 21. 1. 26. 오전 9:38, Guru Das Srinagesh wrote:
From: Anirudh Ghayal
VBUS can be detected via a dedicated PMIC pin. Add support
for reporting the VBUS status
Hi Lukasz,
On Fri, Feb 12, 2021 at 7:28 AM Lukasz Luba wrote:
>
>
>
> On 2/11/21 11:07 AM, Lukasz Luba wrote:
> > Hi Chanwoo,
> >
> > On 2/3/21 10:21 AM, Lukasz Luba wrote:
> >> Hi Chanwoo,
> >>
> >> Thank you for looking at this.
> >
From: Nikita Travkin
In it's curent state this driver ignores OTG adapters with ID pin
connected to ground. This commit adds a check to set extcon into
host mode when such OTG adapter is connected.
Signed-off-by: Nikita Travkin
Signed-off-by: Chanwoo Choi
---
drivers/extcon/extcon-sm5502.c
d new extcon_register_notifier_all() to monitor
all external connectors")
Reported-by: kernel test robot
Signed-off-by: Krzysztof Kozlowski
Signed-off-by: Chanwoo Choi
---
include/linux/extcon.h | 23 +++
1 file changed, 23 insertions(+)
diff --git a/include/linux/extcon.h b/inc
Instead of pull request for extcon next of v5.12, send the patches
because the pull request was too late for merging them.
Detailed description of this patchset as following:
- Add missing function definitions for extcon_register_notifier()
- Add charging interrupt handling such as CHGINS and
From: Timon Baetz
This allows the MAX8997 charger to set the current limit depending on
the detected extcon charger type.
Signed-off-by: Timon Baetz
Signed-off-by: Chanwoo Choi
---
drivers/extcon/extcon-max8997.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/extcon/extcon
Dear Greg,
On 2/15/21 6:26 PM, Greg KH wrote:
> On Mon, Feb 15, 2021 at 06:35:16PM +0900, Chanwoo Choi wrote:
>> Dear Greg,
>>
>> This is extcon-next pull request for v5.12. I add detailed description of
>> this pull request on below. Please pull extcon with following u
Dear Greg,
This is extcon-next pull request for v5.12. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Changes from v2:
- Add missing the diff statistics information
Changes from v1:
- Add missing committer information
Best Regards,
Chanwoo
Dear Greg,
On 2/12/21 4:50 PM, Greg KH wrote:
> On Fri, Feb 12, 2021 at 02:19:37PM +0900, Chanwoo Choi wrote:
>> Dear Greg,
>>
>> This is extcon-next pull request for v5.12. I add detailed description of
>> this pull request on below. Please pull extcon with following
Dear Greg,
This is extcon-next pull request for v5.12. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Changes from v1:
- Add missing committer information
Best Regards,
Chanwoo Choi
The following changes since commit
Dear Greg,
On Tue, Feb 9, 2021 at 7:43 PM Greg KH wrote:
>
> On Tue, Feb 09, 2021 at 07:49:59PM +0900, Chanwoo Choi wrote:
> > Dear Greg,
> >
> > This is extcon-next pull request for v5.12. I add detailed description of
> > this pull request on below. Please pull
Dear Greg,
This is extcon-next pull request for v5.12. I add detailed description of
this pull request on below. Please pull extcon with following updates.
Best Regards,
Chanwoo Choi
The following changes since commit 6ee1d745b7c9fd573fba142a2efdad76a9f1cb04:
Linux 5.11-rc5 (2021-01-24 16
greed to take this series upstream
> through the MFD tree and to provide an immutable branch for the ASoC
> and extcon subsystems to merge.
>
> Mark and extcon-maintainers may we have your ack for merging these
> through the MFD tree ?
About patch2~patch6, I agree to take these patches to MFD tree.
Acke-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
ut just the
> translation of the required-OPPs ?
>
> I am fine with most of the stuff and I would like to take it via OPP
> tree, hope that would be fine ?
I agree. Take these patches to OPP tree.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Hsin-Yi,
I have reviewed this patch already.
This version looks good to me.
I add my acked-by again.
Acked-by: Chanwoo Choi
Thanks,
Chanwoo Choi
On 2/4/21 5:14 PM, Hsin-Yi Wang wrote:
> From: Saravana Kannan
>
> Look at the required OPPs of the "parent" device t
Hi Hsin-Yi,
On 2/4/21 5:14 PM, Hsin-Yi Wang wrote:
> From: Saravana Kannan
>
> The OPP table can be used often in devfreq. Trying to get it each time can
> be expensive, so cache it in the devfreq struct.
>
> Signed-off-by: Saravana Kannan
> Reviewed-by: Chanwoo Choi
>
ched OPP table reference in devfreq to avoid looking up every time.
> - Renamed variable in passive governor to be more intuitive.
> - Updated cover letter with examples.
>
> Saravana Kannan (3):
> OPP: Add function to look up required OPP's for a given OPP
> PM / devfreq: Cache OPP table reference in devfreq
> PM / devfreq: Add required OPPs support to passive governor
>
> drivers/devfreq/devfreq.c | 6
> drivers/devfreq/governor_passive.c | 20 ---
> drivers/opp/core.c | 58 ++
> include/linux/devfreq.h| 2 ++
> include/linux/pm_opp.h | 11 ++
> 5 files changed, 92 insertions(+), 5 deletions(-)
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
quested by OPP
> interface
> * @stop_polling: devfreq polling status of a device.
> @@ -185,6 +187,8 @@ struct devfreq {
> struct dev_pm_qos_request user_max_freq_req;
> unsigned long scaling_min_freq;
> unsigned long scaling_max_freq;
> + unsigned long user_min_freq;
> + unsigned long user_max_freq;
> bool stop_polling;
>
> unsigned long suspend_freq;
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Hi Lukasz,
I'll review this patchset until tomorrow.
Thanks.
Chanwoo Choi
On 2/1/21 8:23 PM, Lukasz Luba wrote:
> Daniel, Chanwoo
>
> Gentle ping. Have you have a chance to check these patches?
>
> On 1/26/21 10:39 AM, Lukasz Luba wrote:
>> Hi all,
>>
>
platform_device
> *pdev)
> default:
> ret = -EINVAL;
> goto err_edev;
> - };
> + }
>
> no_pmu:
> arm_smccc_smc(ROCKCHIP_SIP_DRAM_FREQ, 0, 0,
>
Applied it. I changed the patch title as following:
- PM / devfreq: rk3399_dmc: Remove unneeded semicolon
--
Best Regards,
Chanwoo Choi
Samsung Electronics
> +
> + /*
> + * Keep top FSYS1 aclk enabled permanently. It's required for CMU
> register access.
> + */
> + clk_prepare_enable(hws[CLK_ACLK_FSYS1_200]->clk);
> }
>
> CLK_OF_DECLARE(exynos7_clk_top1, "samsung,exynos7-clock-top1",
>
Acked-by: Chanwoo Choi
--
Best Regards,
Chanwoo Choi
Samsung Electronics
v_pm_opp_put(opp);
>
> return ret;
> @@ -849,7 +849,7 @@ static int tegra_devfreq_probe(struct platform_device
> *pdev)
> return err;
> }
>
> - err = dev_pm_opp_of_add_table(>dev);
> + err = dev_pm_opp_of_add_table_noclk(>dev);
>
;dev, "Unable to create 'downdifferential'
> attr\n");
> +}
> +
> +static void devfreq_simple_ondemand_sysfs_remove(struct devfreq *df)
> +{
> + sysfs_remove_file(>dev.kobj, _attr_upthreshold.attr);
> + sysfs_remove_file(>dev.kobj, _attr_downdifferential.attr);
> +}
> +
> static int devfreq_simple_ondemand_handler(struct devfreq *devfreq,
> unsigned int event, void *data)
> {
> switch (event) {
> case DEVFREQ_GOV_START:
> devfreq_monitor_start(devfreq);
> + devfreq_simple_ondemand_sysfs_setup(devfreq);
> break;
>
> case DEVFREQ_GOV_STOP:
> + devfreq_simple_ondemand_sysfs_remove(devfreq);
> devfreq_monitor_stop(devfreq);
> break;
>
>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
Cc: Thierry Reding
> Cc: MyungJoo Ham
> Cc: Chanwoo Choi
> Cc: Linus Walleij
> Cc: Bartosz Golaszewski
> Cc: Jonathan Cameron
> Cc: Dmitry Torokhov
> Cc: Thomas Gleixner
> Cc: Marc Zyngier
> Cc: Mauro Carvalho Chehab
> Cc: Chen-Yu Tsai
> Cc: Ulf Hansson
>
Hi Yangtao,
On Tue, Jan 5, 2021 at 1:13 PM Chanwoo Choi wrote:
>
> On Sun, Jan 3, 2021 at 12:58 PM Yangtao Li wrote:
> >
> > Use devm_pm_opp_* API to simplify code.
> >
> > Signed-off-by: Yangtao Li
> > ---
> > drivers/devfreq/imx8m-ddrc.c |
evfreq *devfreq)
> -{
> - WARN_ON(devres_release(dev, devm_devfreq_opp_release,
> - devm_devfreq_dev_match, devfreq));
> -}
> -EXPORT_SYMBOL(devm_devfreq_unregister_opp_notifier);
Need to support devm_devfreq_unregister_opp_notifier()
because sometimes, the user wants to release the resource by himself.
(snip)
Best Regards,
Chanwoo Choi
;
> if (ret < 0)
> - goto err_reg;
> + return ret;
>
> if (passive)
> ret = exynos_bus_profile_init_passive(bus, profile);
> @@ -456,11 +436,7 @@ static int exynos_bus_probe(struct platform_device *pdev)
> return 0;
>
> err:
> - dev_pm_opp_of_remove_table(dev);
> clk_disable_unprepare(bus->clk);
> -err_reg:
> - dev_pm_opp_put_regulators(bus->opp_table);
> - bus->opp_table = NULL;
>
> return ret;
> }
> --
> 2.25.1
>
--
Best Regards,
Chanwoo Choi
if (ret)
> - goto err;
> -
> - return 0;
> + return imx_bus_init_icc(dev);
Remove the unneeded blank line under '.return imx_bus_init_icc(dev);".
> -err:
> - dev_pm_opp_of_remove_table(dev);
> - return ret;
> }
>
> static const struct of_device_id imx_bus_of_match[] = {
> --
> 2.25.1
>
--
Best Regards,
Chanwoo Choi
value is not the return value of devm_devfreq_add_device().
On this patch, 'ret' value of 'return ret' is from imx8m_ddrc_check_opps().
Surely, it is well working with this modification. But, it is not code
for exception handling.
So, we need to remain the following codes:
return 0;
err:
return ret;
> }
>
> --
> 2.25.1
>
--
Best Regards,
Chanwoo Choi
> { .compatible = "rockchip,rk3399-dmc" },
> { },
> @@ -502,7 +487,6 @@ MODULE_DEVICE_TABLE(of, rk3399dmc_devfreq_of_match);
>
> static struct platform_driver rk3399_dmcfreq_driver = {
> .probe = rk3399_dmcfreq_probe,
> - .remove = rk3399_dmcfreq_remove,
> .driver = {
> .name = "rk3399-dmc-freq",
> .pm = _dmcfreq_pm,
> --
> 2.25.1
>
--
Best Regards,
Chanwoo Choi
t; *pdev)
> reset_control_reset(tegra->reset);
> disable_clk:
> clk_disable_unprepare(tegra->clock);
> -remove_table:
> - dev_pm_opp_of_remove_table(>dev);
> -put_hw:
> - dev_pm_opp_put_supported_hw(tegra->opp_table);
You might remove the 'devm_pm_opp_remove_all_dynamic(>dev)
under ' remove_opp' goto statement.
(snip)
--
Best Regards,
Chanwoo Choi
; goto err_devfreq;
> >
> > devfreq->nb_max.notifier_call = qos_max_notifier_call;
> > - err = dev_pm_qos_add_notifier(devfreq->dev.parent, >nb_max,
> > + err = dev_pm_qos_add_notifier(dev, >nb_max,
> > DEV_PM_QOS_MAX_FREQUENCY);
> > if (err)
> > goto err_devfreq;
> > --
> > 2.17.1
> >
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
+ * : Indicate polling_interval sysfs attribute
> * - DEVFREQ_GOV_ATTR_TIMER
> * : Indicate timer sysfs attribute
> */
> --
> 2.17.1
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
m_extcon_unregister_notifier_all(struct device *dev,
> + struct extcon_dev
> *edev,
> + struct notifier_block
> *nb) { }
> +
> static inline struct extcon_dev *extcon_get_extcon_dev(const char
> *extcon_name)
> {
> return ERR_PTR(-ENODEV);
> --
> 2.25.1
>
Applied it. Thanks.
--
Best Regards,
Chanwoo Choi
k_struct
> *work)
> case MAX8997_MUICIRQ_DCDTmr:
> case MAX8997_MUICIRQ_ChgDetRun:
> case MAX8997_MUICIRQ_ChgTyp:
> + case MAX8997_PMICIRQ_CHGINS:
> + case MAX8997_PMICIRQ_CHGRM:
> /* Handle charger cable */
> ret = max8997_muic_chg_handler(info);
> break;
> --
> 2.25.1
>
>
Applied it. Thans.
--
Best Regards,
Chanwoo Choi
1 - 100 of 7212 matches
Mail list logo
