Re: Questions on the task isolation patches

2016-12-02 Thread Chris Metcalf
and the restart the task isolation after the new packet, right? Yes, exactly. I am not likely to pursue KVM myself, at least until the basic patch series has been accepted upstream. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: Questions on the task isolation patches

2016-12-02 Thread Chris Metcalf
and the restart the task isolation after the new packet, right? Yes, exactly. I am not likely to pursue KVM myself, at least until the basic patch series has been accepted upstream. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

[tip:timers/core] timekeeping/clocksource_cyc2ns: Document intended range limitation

2016-11-29 Thread tip-bot for Chris Metcalf
Commit-ID: ec4101e8903e318b9fd4e3bbf72b1eaba53c64e1 Gitweb: http://git.kernel.org/tip/ec4101e8903e318b9fd4e3bbf72b1eaba53c64e1 Author: Chris Metcalf <cmetc...@mellanox.com> AuthorDate: Mon, 28 Nov 2016 14:35:20 -0800 Committer: Thomas Gleixner <t...@linutronix.de> CommitDate:

[tip:timers/core] timekeeping/clocksource_cyc2ns: Document intended range limitation

2016-11-29 Thread tip-bot for Chris Metcalf
Commit-ID: ec4101e8903e318b9fd4e3bbf72b1eaba53c64e1 Gitweb: http://git.kernel.org/tip/ec4101e8903e318b9fd4e3bbf72b1eaba53c64e1 Author: Chris Metcalf AuthorDate: Mon, 28 Nov 2016 14:35:20 -0800 Committer: Thomas Gleixner CommitDate: Tue, 29 Nov 2016 18:02:58 +0100 timekeeping

[GIT PULL] arch/tile bugfix for 4.9-rc7

2016-11-23 Thread Chris Metcalf
Linus, Please pull the following change for 4.9-rc7 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git stable This fixes a bug that causes reboots after 208 days of uptime :-) Chris Metcalf (1): tile: avoid using clocksource_cyc2ns with absolute cycle count

[GIT PULL] arch/tile bugfix for 4.9-rc7

2016-11-23 Thread Chris Metcalf
Linus, Please pull the following change for 4.9-rc7 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git stable This fixes a bug that causes reboots after 208 days of uptime :-) Chris Metcalf (1): tile: avoid using clocksource_cyc2ns with absolute cycle count

Re: [PATCH 4/4] timekeeping: clocksource_cyc2ns: Document intended range limitation

2016-11-21 Thread Chris Metcalf
On 11/21/2016 3:54 AM, Ingo Molnar wrote: * John Stultz <john.stu...@linaro.org> wrote: From: Chris Metcalf <cmetc...@mellanox.com> The "cycles" argument should not be an absolute clocksource cycle value, as the implementation's arithmetic will overflow relatively ea

Re: [PATCH 4/4] timekeeping: clocksource_cyc2ns: Document intended range limitation

2016-11-21 Thread Chris Metcalf
On 11/21/2016 3:54 AM, Ingo Molnar wrote: * John Stultz wrote: From: Chris Metcalf The "cycles" argument should not be an absolute clocksource cycle value, as the implementation's arithmetic will overflow relatively easily with wide (64 bit) clocksource counters. For p

Re: [PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-18 Thread Chris Metcalf
On 11/18/2016 5:34 AM, Peter Zijlstra wrote: On Thu, Nov 17, 2016 at 03:00:14PM -0500, Chris Metcalf wrote: On 11/17/2016 4:53 AM, Peter Zijlstra wrote: On Wed, Nov 16, 2016 at 03:16:59PM -0500, Chris Metcalf wrote: PeterZ (cc'ed) then improved it to use __int128 math via mul_u64_u32_shr

Re: [PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-18 Thread Chris Metcalf
On 11/18/2016 5:34 AM, Peter Zijlstra wrote: On Thu, Nov 17, 2016 at 03:00:14PM -0500, Chris Metcalf wrote: On 11/17/2016 4:53 AM, Peter Zijlstra wrote: On Wed, Nov 16, 2016 at 03:16:59PM -0500, Chris Metcalf wrote: PeterZ (cc'ed) then improved it to use __int128 math via mul_u64_u32_shr

Re: [PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-17 Thread Chris Metcalf
On 11/17/2016 4:53 AM, Peter Zijlstra wrote: On Wed, Nov 16, 2016 at 03:16:59PM -0500, Chris Metcalf wrote: PeterZ (cc'ed) then improved it to use __int128 math via mul_u64_u32_shr(), but that doesn't help tile; we only do one multiply instead of two, but the multiply is handled by an out

Re: [PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-17 Thread Chris Metcalf
On 11/17/2016 4:53 AM, Peter Zijlstra wrote: On Wed, Nov 16, 2016 at 03:16:59PM -0500, Chris Metcalf wrote: PeterZ (cc'ed) then improved it to use __int128 math via mul_u64_u32_shr(), but that doesn't help tile; we only do one multiply instead of two, but the multiply is handled by an out

Re: [PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-16 Thread Chris Metcalf
On 11/16/2016 2:59 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:35 AM, Chris Metcalf <cmetc...@mellanox.com> wrote: For large values of "mult" and long uptimes, the intermediate result of "cycles * mult" can overflow 64 bits. For example, the tile platfor

Re: [PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-16 Thread Chris Metcalf
On 11/16/2016 2:59 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:35 AM, Chris Metcalf wrote: For large values of "mult" and long uptimes, the intermediate result of "cycles * mult" can overflow 64 bits. For example, the tile platform calls clocksource_cyc2ns with a 1.

Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
On 11/16/2016 2:45 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:30 AM, Chris Metcalf <cmetc...@mellanox.com> wrote: diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 08398182f56e..529884b8 100644 --- a/include/linux/clocksource.h +++ b/include

Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
On 11/16/2016 2:45 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:30 AM, Chris Metcalf wrote: diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 08398182f56e..529884b8 100644 --- a/include/linux/clocksource.h +++ b/include/linux/clocksource.h @@ -171,6 +171,10

[PATCH v2] time: Avoid signed overflow in timekeeping_delta_to_ns()

2016-11-16 Thread Chris Metcalf
btle way by changing the type of "nsec" to unsigned and adding a comment explaining why. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- v2: just use "u64 nsec" to fix the signed shift problem kernel/time/timekeeping.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v2] time: Avoid signed overflow in timekeeping_delta_to_ns()

2016-11-16 Thread Chris Metcalf
btle way by changing the type of "nsec" to unsigned and adding a comment explaining why. Signed-off-by: Chris Metcalf --- v2: just use "u64 nsec" to fix the signed shift problem kernel/time/timekeeping.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
On 11/16/2016 1:04 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 8:57 AM, Chris Metcalf <cmetc...@mellanox.com> wrote: include/linux/clocksource.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 083981

Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
On 11/16/2016 1:04 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 8:57 AM, Chris Metcalf wrote: include/linux/clocksource.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 08398182f56e..b2a022acf232 100644

Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
On 11/16/2016 3:00 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:56 AM, Chris Metcalf <cmetc...@mellanox.com> wrote: On 11/16/2016 2:45 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:30 AM, Chris Metcalf <cmetc...@mellanox.com> wrote: diff --git a/include/linux/clocksource

Re: [PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
On 11/16/2016 3:00 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:56 AM, Chris Metcalf wrote: On 11/16/2016 2:45 PM, John Stultz wrote: On Wed, Nov 16, 2016 at 11:30 AM, Chris Metcalf wrote: diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h index 08398182f56e

[PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-16 Thread Chris Metcalf
cyc2ns() is intended to be used for relative cycle counts, not absolute cycle counts, performance is more importance than accepting a wider range of cycle values. So, just use mult_frac() directly in tile's sched_clock(). Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- Blackfin sh

[PATCH v2] tile: avoid using clocksource_cyc2ns with absolute cycle count

2016-11-16 Thread Chris Metcalf
cyc2ns() is intended to be used for relative cycle counts, not absolute cycle counts, performance is more importance than accepting a wider range of cycle values. So, just use mult_frac() directly in tile's sched_clock(). Signed-off-by: Chris Metcalf --- Blackfin should make a similar change in their s

[PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
the same as the fix for arch/x86 __cycles_2_ns() in commit 4cecf6d401a0 ("sched, x86: Avoid unnecessary overflow in sched_clock"), using the new mult_frac() helper. In addition to tile, arm/plat-omap and blackfin also use this helper function, so will presumably hit similar issues. Signe

[PATCH] clocksource_cyc2ns: avoid overflowing 64 bits

2016-11-16 Thread Chris Metcalf
the same as the fix for arch/x86 __cycles_2_ns() in commit 4cecf6d401a0 ("sched, x86: Avoid unnecessary overflow in sched_clock"), using the new mult_frac() helper. In addition to tile, arm/plat-omap and blackfin also use this helper function, so will presumably hit similar issues.

[GIT PULL] arch/tile bugfix for 4.9-rc6

2016-11-14 Thread Chris Metcalf
Linus, Please pull the following change for 4.9-rc6 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git stable This just fixes an incompatibility with tile __ro_after_init. Chris Metcalf (1): tile: handle __ro_after_init like parisc does arch/tile/include/asm

[GIT PULL] arch/tile bugfix for 4.9-rc6

2016-11-14 Thread Chris Metcalf
Linus, Please pull the following change for 4.9-rc6 from: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git stable This just fixes an incompatibility with tile __ro_after_init. Chris Metcalf (1): tile: handle __ro_after_init like parisc does arch/tile/include/asm

[PATCH v2] tile: handle __ro_after_init like parisc does

2016-11-14 Thread Chris Metcalf
. __read_mostly. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/tile/include/asm/cache.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/tile/include/asm/cache.h b/arch/tile/include/asm/cache.h index 6160761d5f61..4810e48dbbbf 100644 --- a/arch/tile/include/asm/c

[PATCH v2] tile: handle __ro_after_init like parisc does

2016-11-14 Thread Chris Metcalf
. __read_mostly. Signed-off-by: Chris Metcalf --- arch/tile/include/asm/cache.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/tile/include/asm/cache.h b/arch/tile/include/asm/cache.h index 6160761d5f61..4810e48dbbbf 100644 --- a/arch/tile/include/asm/cache.h +++ b/arch/tile/include/asm

[PATCH] time: Avoid signed overflow in timekeeping_delta_to_ns()

2016-11-14 Thread Chris Metcalf
This bugfix was originally made in commit 35a4933a8959 ("time: Avoid signed overflow in timekeeping_get_ns()"). When the code was refactored in commit 6bd58f09e1d8 ("time: Add cycles to nanoseconds translation") the signed overflow fix was lost. Re-introduce it. Signed-o

[PATCH] time: Avoid signed overflow in timekeeping_delta_to_ns()

2016-11-14 Thread Chris Metcalf
This bugfix was originally made in commit 35a4933a8959 ("time: Avoid signed overflow in timekeeping_get_ns()"). When the code was refactored in commit 6bd58f09e1d8 ("time: Add cycles to nanoseconds translation") the signed overflow fix was lost. Re-introduce it. Signed-o

[PATCH] tile-srom: allow the driver to be built as a module

2016-11-07 Thread Chris Metcalf
The code was already configured that way, but the Kconfig file didn't support requesting it. A buglet caused a null pointer deref when unloading the module, but this commit also corrects that issue. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- This is in response to Paul's patc

[PATCH] tile-srom: allow the driver to be built as a module

2016-11-07 Thread Chris Metcalf
The code was already configured that way, but the Kconfig file didn't support requesting it. A buglet caused a null pointer deref when unloading the module, but this commit also corrects that issue. Signed-off-by: Chris Metcalf --- This is in response to Paul's patch (see the in-reply

[PATCH] tile: handle RO_AFTER_INIT_DATA

2016-11-07 Thread Chris Metcalf
This is the minimal change to handle RO_AFTER_INIT_DATA. The tile architecture already marks RO_DATA as read-only in the kernel, so grouping RO_AFTER_INIT_DATA with RO_DATA, as is done by default, means the kernel faults in init when it tries to write to RO_AFTER_INIT_DATA. For now, just move it

[PATCH] tile: handle RO_AFTER_INIT_DATA

2016-11-07 Thread Chris Metcalf
This is the minimal change to handle RO_AFTER_INIT_DATA. The tile architecture already marks RO_DATA as read-only in the kernel, so grouping RO_AFTER_INIT_DATA with RO_DATA, as is done by default, means the kernel faults in init when it tries to write to RO_AFTER_INIT_DATA. For now, just move it

task isolation discussion at Linux Plumbers

2016-11-04 Thread Chris Metcalf
at adding equivalent support for x86. Many thanks to all those who participated in the discussion. Frederic, we wished you had been there! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

task isolation discussion at Linux Plumbers

2016-11-04 Thread Chris Metcalf
at adding equivalent support for x86. Many thanks to all those who participated in the discussion. Frederic, we wished you had been there! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 01/18] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option

2016-10-24 Thread Chris Metcalf
fusing, since there are no architectures except tile that use the __SYSCALL_COMPAT functionality in the current tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 01/18] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option

2016-10-24 Thread Chris Metcalf
fusing, since there are no architectures except tile that use the __SYSCALL_COMPAT functionality in the current tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 02/18] arm64: ilp32: add documentation on the ILP32 ABI for ARM64

2016-10-24 Thread Chris Metcalf
ot;the following types". Likewise later with "next syscalls". -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 02/18] arm64: ilp32: add documentation on the ILP32 ABI for ARM64

2016-10-24 Thread Chris Metcalf
finition, like "have their top 32 bits zeroed". +AARCH64/ILP32 provides next types turned to 64-bit (comparing to AARCH32): What does "turned" mean here? And I "next types" isn't standard English; you want to say something like "the following types". Likew

Re: Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-09-30 Thread Chris Metcalf
On 9/27/2016 10:35 AM, Frederic Weisbecker wrote: On 8/16/2016 5:19 PM, Chris Metcalf wrote: Here is a respin of the task-isolation patch set. Again, I have been getting email asking me when and where this patch will be upstreamed so folks can start using it. I had been thinking the obvious

Re: Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-09-30 Thread Chris Metcalf
On 9/27/2016 10:35 AM, Frederic Weisbecker wrote: On 8/16/2016 5:19 PM, Chris Metcalf wrote: Here is a respin of the task-isolation patch set. Again, I have been getting email asking me when and where this patch will be upstreamed so folks can start using it. I had been thinking the obvious

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-30 Thread Chris Metcalf
On 8/30/2016 2:43 PM, Andy Lutomirski wrote: On Aug 30, 2016 10:02 AM, "Chris Metcalf" <cmetc...@mellanox.com> wrote: We really want to run task isolation last, so we can guarantee that all the isolation prerequisites are met (dynticks stopped, per-cpu lru cache empty, etc)

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-30 Thread Chris Metcalf
On 8/30/2016 2:43 PM, Andy Lutomirski wrote: On Aug 30, 2016 10:02 AM, "Chris Metcalf" wrote: We really want to run task isolation last, so we can guarantee that all the isolation prerequisites are met (dynticks stopped, per-cpu lru cache empty, etc). But achieving that state c

Re: [PATCH] arch/arm: enable task isolation functionality

2016-09-26 Thread Chris Metcalf
to try to keep it updated (buildable at least) with any further changes. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH] arch/arm: enable task isolation functionality

2016-09-26 Thread Chris Metcalf
at least) with any further changes. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v2 09/11] tile/tracing: fix compat syscall handling

2016-09-20 Thread Chris Metcalf
On 9/16/2016 3:11 AM, Marcin Nowakowski wrote: Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski<marcin.nowakow...@imgtec.com> Cc:Cc: Steven Rostedt<rost...@goodmis.org> Cc: Ingo Molnar<mi...@redhat.com> Cc: C

Re: [PATCH v2 09/11] tile/tracing: fix compat syscall handling

2016-09-20 Thread Chris Metcalf
On 9/16/2016 3:11 AM, Marcin Nowakowski wrote: Add missing arch code - arch_trace_is_compat_syscall and arch_syscall_addr Signed-off-by: Marcin Nowakowski Cc:Cc: Steven Rostedt Cc: Ingo Molnar Cc: Chris Metcalf --- arch/tile/include/asm/ftrace.h | 10 ++ arch/tile/kernel/Makefile

Re: [PATCH] tile: migrate exception table users off module.h and onto extable.h

2016-09-20 Thread Chris Metcalf
eally need to compile these files. Cc: Chris Metcalf<cmetc...@mellanox.com> Signed-off-by: Paul Gortmaker<paul.gortma...@windriver.com> --- [see:https://lkml.org/lkml/2016/7/24/224 for additional context if needed] arch/tile/kernel/unaligned.c | 2 +- arch/tile/mm/extable.c

Re: [PATCH] tile: migrate exception table users off module.h and onto extable.h

2016-09-20 Thread Chris Metcalf
eally need to compile these files. Cc: Chris Metcalf Signed-off-by: Paul Gortmaker --- [see:https://lkml.org/lkml/2016/7/24/224 for additional context if needed] arch/tile/kernel/unaligned.c | 2 +- arch/tile/mm/extable.c | 2 +- arch/tile/mm/fault.c | 2 +- 3 files changed, 3

Re: Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-09-13 Thread Chris Metcalf
t argument details. I can work on that and also write some doc (Documentation/task-isolation.txt ?). Sure, documentation is always welcome! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-09-13 Thread Chris Metcalf
t argument details. I can work on that and also write some doc (Documentation/task-isolation.txt ?). Sure, documentation is always welcome! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-12 Thread Chris Metcalf
On 9/12/2016 1:41 PM, Andy Lutomirski wrote: On Sep 9, 2016 1:40 PM, "Chris Metcalf" <cmetc...@mellanox.com> wrote: On 9/2/2016 1:28 PM, Andy Lutomirski wrote: On Sep 2, 2016 7:04 AM, "Chris Metcalf" <cmetc...@mellanox.com> wrote: On 8/30/2016 3:50 PM, Andy L

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-12 Thread Chris Metcalf
On 9/12/2016 1:41 PM, Andy Lutomirski wrote: On Sep 9, 2016 1:40 PM, "Chris Metcalf" wrote: On 9/2/2016 1:28 PM, Andy Lutomirski wrote: On Sep 2, 2016 7:04 AM, "Chris Metcalf" wrote: On 8/30/2016 3:50 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 12:37 PM, Chris

Re: Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-09-12 Thread Chris Metcalf
On 9/7/2016 5:11 PM, Francis Giraldeau wrote: On 2016-08-29 12:27 PM, Chris Metcalf wrote: On 8/16/2016 5:19 PM, Chris Metcalf wrote: Here is a respin of the task-isolation patch set. No concerns have been raised yet with the v15 version of the patch series in the two weeks since I posted

Re: Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-09-12 Thread Chris Metcalf
On 9/7/2016 5:11 PM, Francis Giraldeau wrote: On 2016-08-29 12:27 PM, Chris Metcalf wrote: On 8/16/2016 5:19 PM, Chris Metcalf wrote: Here is a respin of the task-isolation patch set. No concerns have been raised yet with the v15 version of the patch series in the two weeks since I posted

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-09-09 Thread Chris Metcalf
On 9/3/2016 11:31 AM, Frederic Weisbecker wrote: On Tue, Aug 30, 2016 at 02:17:27PM -0400, Chris Metcalf wrote: On 8/30/2016 1:36 PM, Chris Metcalf wrote: See the other thread with Peter Z for the longer discussion of this. At this point I'm leaning towards replacing the set_tsk_need_resched

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-09-09 Thread Chris Metcalf
On 9/3/2016 11:31 AM, Frederic Weisbecker wrote: On Tue, Aug 30, 2016 at 02:17:27PM -0400, Chris Metcalf wrote: On 8/30/2016 1:36 PM, Chris Metcalf wrote: See the other thread with Peter Z for the longer discussion of this. At this point I'm leaning towards replacing the set_tsk_need_resched

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-09 Thread Chris Metcalf
On 9/2/2016 1:28 PM, Andy Lutomirski wrote: On Sep 2, 2016 7:04 AM, "Chris Metcalf" <cmetc...@mellanox.com> wrote: On 8/30/2016 3:50 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 12:37 PM, Chris Metcalf <cmetc...@mellanox.com> wrote: On 8/30/2016 2:43 PM, Andy L

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-09 Thread Chris Metcalf
On 9/2/2016 1:28 PM, Andy Lutomirski wrote: On Sep 2, 2016 7:04 AM, "Chris Metcalf" wrote: On 8/30/2016 3:50 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 12:37 PM, Chris Metcalf wrote: On 8/30/2016 2:43 PM, Andy Lutomirski wrote: What if we did it the other way around: se

Re: [RFC v4 10/22] arch/tile/kernel/time: set ->min_delta_ticks and ->max_delta_ticks

2016-09-09 Thread Chris Metcalf
On 9/8/2016 7:21 AM, Nicolai Stange wrote: Chris Metcalf <cmetc...@mellanox.com> writes: On 08/22/2016 07:33 PM, Nicolai Stange wrote: With the yet to come introduction of NTP correction awareness to the clockevent core, drivers should report their valid ranges in units of

Re: [RFC v4 10/22] arch/tile/kernel/time: set ->min_delta_ticks and ->max_delta_ticks

2016-09-09 Thread Chris Metcalf
On 9/8/2016 7:21 AM, Nicolai Stange wrote: Chris Metcalf writes: On 08/22/2016 07:33 PM, Nicolai Stange wrote: With the yet to come introduction of NTP correction awareness to the clockevent core, drivers should report their valid ranges in units of cycles to the latter. Currently

[PATCH] tile: remove #pragma unroll from finv_buffer_remote()

2016-09-06 Thread Chris Metcalf
n any case, so the extra optimization here was mostly just for it's own sake. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/tile/lib/cacheflush.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/tile/lib/cacheflush.c b/arch/tile/lib/ca

[PATCH] tile: remove #pragma unroll from finv_buffer_remote()

2016-09-06 Thread Chris Metcalf
n any case, so the extra optimization here was mostly just for it's own sake. Signed-off-by: Chris Metcalf --- arch/tile/lib/cacheflush.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/arch/tile/lib/cacheflush.c b/arch/tile/lib/cacheflush.c index 9c0ec22009a5..c1

Re: [RFC v4 10/22] arch/tile/kernel/time: set ->min_delta_ticks and ->max_delta_ticks

2016-09-06 Thread Chris Metcalf
nitialize ->min_delta_ticks and ->max_delta_ticks with these values. Signed-off-by: Nicolai Stange <nicsta...@gmail.com> --- arch/tile/kernel/time.c | 2 ++ 1 file changed, 2 insertions(+) Thanks. Taken into the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [RFC v4 10/22] arch/tile/kernel/time: set ->min_delta_ticks and ->max_delta_ticks

2016-09-06 Thread Chris Metcalf
nitialize ->min_delta_ticks and ->max_delta_ticks with these values. Signed-off-by: Nicolai Stange --- arch/tile/kernel/time.c | 2 ++ 1 file changed, 2 insertions(+) Thanks. Taken into the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 0/2] tile-module: Fine-tuning for module_alloc()

2016-09-06 Thread Chris Metcalf
arch/tile/kernel/module.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) Thanks! Taken into the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH 0/2] tile-module: Fine-tuning for module_alloc()

2016-09-06 Thread Chris Metcalf
+-- 1 file changed, 5 insertions(+), 6 deletions(-) Thanks! Taken into the tile tree. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-02 Thread Chris Metcalf
On 8/30/2016 3:50 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 12:37 PM, Chris Metcalf <cmetc...@mellanox.com> wrote: On 8/30/2016 2:43 PM, Andy Lutomirski wrote: What if we did it the other way around: set a percpu flag saying "going quiescent; disallow new deferred work&qu

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-02 Thread Chris Metcalf
On 8/30/2016 3:50 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 12:37 PM, Chris Metcalf wrote: On 8/30/2016 2:43 PM, Andy Lutomirski wrote: What if we did it the other way around: set a percpu flag saying "going quiescent; disallow new deferred work", then finish all exi

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-02 Thread Chris Metcalf
On 9/1/2016 6:06 AM, Peter Zijlstra wrote: On Tue, Aug 30, 2016 at 11:32:16AM -0400, Chris Metcalf wrote: On 8/30/2016 3:58 AM, Peter Zijlstra wrote: What !? I really don't get this, what are you waiting for? Why is rescheduling making things better. We need to wait for the last dyntick

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-09-02 Thread Chris Metcalf
On 9/1/2016 6:06 AM, Peter Zijlstra wrote: On Tue, Aug 30, 2016 at 11:32:16AM -0400, Chris Metcalf wrote: On 8/30/2016 3:58 AM, Peter Zijlstra wrote: What !? I really don't get this, what are you waiting for? Why is rescheduling making things better. We need to wait for the last dyntick

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 1:10 PM, Frederic Weisbecker wrote: On Tue, Aug 30, 2016 at 11:41:36AM -0400, Chris Metcalf wrote: On 8/29/2016 8:55 PM, Frederic Weisbecker wrote: On Mon, Aug 15, 2016 at 10:59:55AM -0400, Chris Metcalf wrote: On 8/11/2016 2:50 PM, Christoph Lameter wrote: On Thu, 11 Aug 2016

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 1:10 PM, Frederic Weisbecker wrote: On Tue, Aug 30, 2016 at 11:41:36AM -0400, Chris Metcalf wrote: On 8/29/2016 8:55 PM, Frederic Weisbecker wrote: On Mon, Aug 15, 2016 at 10:59:55AM -0400, Chris Metcalf wrote: On 8/11/2016 2:50 PM, Christoph Lameter wrote: On Thu, 11 Aug 2016

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 2:43 PM, Andy Lutomirski wrote: On Aug 30, 2016 10:02 AM, "Chris Metcalf" <cmetc...@mellanox.com> wrote: On 8/30/2016 12:30 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 8:32 AM, Chris Metcalf <cmetc...@mellanox.com> wrote: The basic idea is j

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 2:43 PM, Andy Lutomirski wrote: On Aug 30, 2016 10:02 AM, "Chris Metcalf" wrote: On 8/30/2016 12:30 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 8:32 AM, Chris Metcalf wrote: The basic idea is just that we don't want to be at risk from the dyntick getti

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 1:36 PM, Chris Metcalf wrote: See the other thread with Peter Z for the longer discussion of this. At this point I'm leaning towards replacing the set_tsk_need_resched() with set_current_state(TASK_INTERRUPTIBLE); schedule(); __set_current_state(TASK_RUNNING); I

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 1:36 PM, Chris Metcalf wrote: See the other thread with Peter Z for the longer discussion of this. At this point I'm leaning towards replacing the set_tsk_need_resched() with set_current_state(TASK_INTERRUPTIBLE); schedule(); __set_current_state(TASK_RUNNING); I

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 12:30 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 8:32 AM, Chris Metcalf <cmetc...@mellanox.com> wrote: On 8/30/2016 3:58 AM, Peter Zijlstra wrote: On Mon, Aug 29, 2016 at 12:40:32PM -0400, Chris Metcalf wrote: On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue,

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 12:30 PM, Andy Lutomirski wrote: On Tue, Aug 30, 2016 at 8:32 AM, Chris Metcalf wrote: On 8/30/2016 3:58 AM, Peter Zijlstra wrote: On Mon, Aug 29, 2016 at 12:40:32PM -0400, Chris Metcalf wrote: On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/29/2016 8:55 PM, Frederic Weisbecker wrote: On Mon, Aug 15, 2016 at 10:59:55AM -0400, Chris Metcalf wrote: On 8/11/2016 2:50 PM, Christoph Lameter wrote: On Thu, 11 Aug 2016, Frederic Weisbecker wrote: Do we need to quiesce vmstat everytime before entering userspace? I thought

Re: [PATCH v14 04/14] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/29/2016 8:55 PM, Frederic Weisbecker wrote: On Mon, Aug 15, 2016 at 10:59:55AM -0400, Chris Metcalf wrote: On 8/11/2016 2:50 PM, Christoph Lameter wrote: On Thu, 11 Aug 2016, Frederic Weisbecker wrote: Do we need to quiesce vmstat everytime before entering userspace? I thought

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 3:58 AM, Peter Zijlstra wrote: On Mon, Aug 29, 2016 at 12:40:32PM -0400, Chris Metcalf wrote: On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM -0400, Chris Metcalf wrote: + /* +* Request rescheduling unless we are in full dynticks mode

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-30 Thread Chris Metcalf
On 8/30/2016 3:58 AM, Peter Zijlstra wrote: On Mon, Aug 29, 2016 at 12:40:32PM -0400, Chris Metcalf wrote: On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM -0400, Chris Metcalf wrote: + /* +* Request rescheduling unless we are in full dynticks mode

Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-08-29 Thread Chris Metcalf
On 8/16/2016 5:19 PM, Chris Metcalf wrote: Here is a respin of the task-isolation patch set. Again, I have been getting email asking me when and where this patch will be upstreamed so folks can start using it. I had been thinking the obvious path was via Frederic Weisbecker to Ingo as a NOHZ

Ping: [PATCH v15 00/13] support "task_isolation" mode

2016-08-29 Thread Chris Metcalf
On 8/16/2016 5:19 PM, Chris Metcalf wrote: Here is a respin of the task-isolation patch set. Again, I have been getting email asking me when and where this patch will be upstreamed so folks can start using it. I had been thinking the obvious path was via Frederic Weisbecker to Ingo as a NOHZ

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-29 Thread Chris Metcalf
On 8/29/2016 12:48 PM, Peter Zijlstra wrote: On Mon, Aug 29, 2016 at 12:40:32PM -0400, Chris Metcalf wrote: On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM -0400, Chris Metcalf wrote: + /* +* Request rescheduling unless we are in full dynticks

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-29 Thread Chris Metcalf
On 8/29/2016 12:48 PM, Peter Zijlstra wrote: On Mon, Aug 29, 2016 at 12:40:32PM -0400, Chris Metcalf wrote: On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM -0400, Chris Metcalf wrote: + /* +* Request rescheduling unless we are in full dynticks

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-29 Thread Chris Metcalf
On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM -0400, Chris Metcalf wrote: + /* +* Request rescheduling unless we are in full dynticks mode. +* We would eventually get pre-empted without this, and if +* there's another task waiting

Re: [PATCH v15 04/13] task_isolation: add initial support

2016-08-29 Thread Chris Metcalf
On 8/29/2016 12:33 PM, Peter Zijlstra wrote: On Tue, Aug 16, 2016 at 05:19:27PM -0400, Chris Metcalf wrote: + /* +* Request rescheduling unless we are in full dynticks mode. +* We would eventually get pre-empted without this, and if +* there's another task waiting

Re: [PATCH] tile/pci_gx: fix spelling mistake: "delievered" -> "delivered"

2016-08-29 Thread Chris Metcalf
(-) Thanks; taken into the tile tree! -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH] tile/pci_gx: fix spelling mistake: "delievered" -> "delivered"

2016-08-29 Thread Chris Metcalf
On 8/18/2016 11:42 AM, Colin King wrote: From: Colin Ian King trivial fix to spelling mistake in pr_warn message Signed-off-by: Colin Ian King --- arch/tile/kernel/pci_gx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks; taken into the tile tree! -- Chris Metcalf, Mellanox

[PATCH v9 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-08-29 Thread Chris Metcalf
racing API (sparc64 and mips) are converted to use the cpumask approach rather than the all/allbutself approach. The mips code ignored the "include_self" boolean but with this change it will now also dump a local backtrace if requested. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com>

[PATCH v9 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-08-29 Thread Chris Metcalf
racing API (sparc64 and mips) are converted to use the cpumask approach rather than the all/allbutself approach. The mips code ignored the "include_self" boolean but with this change it will now also dump a local backtrace if requested. Signed-off-by: Chris Metcalf Reviewed-by: Aaron Tomli

[PATCH v9 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI

2016-08-29 Thread Chris Metcalf
. The register state will be missing, but that state is likely not particularly helpful in any case. Or, if we think it is helpful, we should be capturing and emitting the current register state in all cases when regs == NULL is passed to nmi_cpu_backtrace(). Signed-off-by: Chris Metcalf <cm

[PATCH v9 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI

2016-08-29 Thread Chris Metcalf
. The register state will be missing, but that state is likely not particularly helpful in any case. Or, if we think it is helpful, we should be capturing and emitting the current register state in all cases when regs == NULL is passed to nmi_cpu_backtrace(). Signed-off-by: Chris Metcalf Acked

[PATCH v9 3/4] arch/tile: adopt the new nmi_backtrace framework

2016-08-29 Thread Chris Metcalf
backtrace if the old one was still in progress. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/tile/include/asm/irq.h | 5 ++-- arch/tile/kernel/pmc.c | 3 -- arch/tile/kernel/process.c | 73 +++-- arch/tile/kernel/traps.c

[PATCH v9 3/4] arch/tile: adopt the new nmi_backtrace framework

2016-08-29 Thread Chris Metcalf
backtrace if the old one was still in progress. Signed-off-by: Chris Metcalf --- arch/tile/include/asm/irq.h | 5 ++-- arch/tile/kernel/pmc.c | 3 -- arch/tile/kernel/process.c | 73 +++-- arch/tile/kernel/traps.c| 9 -- 4 files changed, 27

<    1   2   3   4   5   6   7   8   9   10   >