Re: [PATCH] nohz_full: Make sched_should_stop_tick() more conservative

2016-04-04 Thread Chris Metcalf
On 4/4/2016 3:36 PM, Rik van Riel wrote: On Fri, 2016-04-01 at 15:42 -0400, Chris Metcalf wrote: On arm64, when calling enqueue_task_fair() from migration_cpu_stop(), we find the nr_running value updated by add_nr_running(), but the cfs.nr_running value has not always yet been updated

Re: [PATCH] nohz_full: Make sched_should_stop_tick() more conservative

2016-04-04 Thread Chris Metcalf
On 4/4/2016 3:36 PM, Rik van Riel wrote: On Fri, 2016-04-01 at 15:42 -0400, Chris Metcalf wrote: On arm64, when calling enqueue_task_fair() from migration_cpu_stop(), we find the nr_running value updated by add_nr_running(), but the cfs.nr_running value has not always yet been updated

Re: [PATCH] nohz_full: Make sched_should_stop_tick() more conservative

2016-04-04 Thread Chris Metcalf
On 4/4/2016 3:12 PM, Rik van Riel wrote: On Fri, 2016-04-01 at 15:42 -0400, Chris Metcalf wrote: On arm64, when calling enqueue_task_fair() from migration_cpu_stop(), we find the nr_running value updated by add_nr_running(), but the cfs.nr_running value has not always yet been updated

Re: [PATCH] nohz_full: Make sched_should_stop_tick() more conservative

2016-04-04 Thread Chris Metcalf
On 4/4/2016 3:12 PM, Rik van Riel wrote: On Fri, 2016-04-01 at 15:42 -0400, Chris Metcalf wrote: On arm64, when calling enqueue_task_fair() from migration_cpu_stop(), we find the nr_running value updated by add_nr_running(), but the cfs.nr_running value has not always yet been updated

[PATCH] nohz_full: Make sched_should_stop_tick() more conservative

2016-04-01 Thread Chris Metcalf
. Correct this by using rq->nr_running instead of rq->cfs.nr_running. This should always be more conservative, and reverts the test to the form it had before commit 76d92ac305f2 ("sched: Migrate sched to use new tick dependency mask model"). Signed-off-by: Chris Metcalf <cmetc...@

[PATCH] nohz_full: Make sched_should_stop_tick() more conservative

2016-04-01 Thread Chris Metcalf
. Correct this by using rq->nr_running instead of rq->cfs.nr_running. This should always be more conservative, and reverts the test to the form it had before commit 76d92ac305f2 ("sched: Migrate sched to use new tick dependency mask model"). Signed-off-by: Chris Metcalf --- I found

[PATCH v4 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI

2016-03-30 Thread Chris Metcalf
. The register state will be missing, but that state is likely not particularly helpful in any case. Or, if we think it is helpful, we should be capturing and emitting the current register state in all cases when regs == NULL is passed to nmi_cpu_backtrace(). Signed-off-by: Chris Metcalf <cm

[PATCH v4 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI

2016-03-30 Thread Chris Metcalf
. The register state will be missing, but that state is likely not particularly helpful in any case. Or, if we think it is helpful, we should be capturing and emitting the current register state in all cases when regs == NULL is passed to nmi_cpu_backtrace(). Signed-off-by: Chris Metcalf --- arch/arm

[PATCH v4 0/4] improvements to the nmi_backtrace code

2016-03-30 Thread Chris Metcalf
g/r/1458667179-19630-1-git-send-email-cmetc...@mellanox.com v2: Switch to using __cpuidle tagging, switch S-O-B to Mellanox https://lkml.kernel.org/r/1458147733-29338-1-git-send-email-cmetc...@mellanox.com Chris Metcalf (4): nmi_backtrace: add more trigger_*_cpu_backtrace() methods nmi_backtr

[PATCH v4 3/4] arch/tile: adopt the new nmi_backtrace framework

2016-03-30 Thread Chris Metcalf
backtrace if the old one was still in progress. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/tile/include/asm/irq.h | 4 +-- arch/tile/kernel/pmc.c | 3 -- arch/tile/kernel/process.c | 72 ++--- arch/tile/kernel/traps.c

[PATCH v4 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-30 Thread Chris Metcalf
ted to using the new cpumask approach in this change. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/arm/include/asm/irq.h| 4 +-- arch/arm/kernel/smp.c | 4 +-- arch/x86/include/asm/irq.h| 4 +-- arch/x86/kernel/apic/hw_nmi.c | 6 ++--- include/

[PATCH v4 0/4] improvements to the nmi_backtrace code

2016-03-30 Thread Chris Metcalf
g/r/1458667179-19630-1-git-send-email-cmetc...@mellanox.com v2: Switch to using __cpuidle tagging, switch S-O-B to Mellanox https://lkml.kernel.org/r/1458147733-29338-1-git-send-email-cmetc...@mellanox.com Chris Metcalf (4): nmi_backtrace: add more trigger_*_cpu_backtrace() methods nmi_backtr

[PATCH v4 3/4] arch/tile: adopt the new nmi_backtrace framework

2016-03-30 Thread Chris Metcalf
backtrace if the old one was still in progress. Signed-off-by: Chris Metcalf --- arch/tile/include/asm/irq.h | 4 +-- arch/tile/kernel/pmc.c | 3 -- arch/tile/kernel/process.c | 72 ++--- arch/tile/kernel/traps.c| 7 +++-- 4 files changed, 23

[PATCH v4 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-30 Thread Chris Metcalf
ted to using the new cpumask approach in this change. Signed-off-by: Chris Metcalf --- arch/arm/include/asm/irq.h| 4 +-- arch/arm/kernel/smp.c | 4 +-- arch/x86/include/asm/irq.h| 4 +-- arch/x86/kernel/apic/hw_nmi.c | 6 ++--- include/linux/

[PATCH v4 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-30 Thread Chris Metcalf
-by: Peter Zijlstra (Intel) <pet...@infradead.org> Tested-by: Peter Zijlstra (Intel) <pet...@infradead.org> Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/alpha/kernel/vmlinux.lds.S | 1 + arch/arc/kernel/vmlinux.lds.S| 1 + arch/arm/kernel/vmlinux.lds

[PATCH v4 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-30 Thread Chris Metcalf
-by: Peter Zijlstra (Intel) Tested-by: Peter Zijlstra (Intel) Signed-off-by: Chris Metcalf --- arch/alpha/kernel/vmlinux.lds.S | 1 + arch/arc/kernel/vmlinux.lds.S| 1 + arch/arm/kernel/vmlinux.lds.S| 1 + arch/arm64/kernel/vmlinux.lds.S | 1 + arch/arm64

Re: [PATCH 5/5] tile/defconfigs: Remove CONFIG_IPV6_PRIVACY

2016-03-30 Thread Chris Metcalf
On 3/30/2016 7:42 AM, Borislav Petkov wrote: From: Borislav Petkov<b...@suse.de> Option is long gone, see 5d9efa7ee99e ("ipv6: Remove privacy config option.") Signed-off-by: Borislav Petkov<b...@suse.de> Cc: Chris Metcalf<cmetc...@ezchip.com> Thanks! Taken i

Re: [PATCH 5/5] tile/defconfigs: Remove CONFIG_IPV6_PRIVACY

2016-03-30 Thread Chris Metcalf
On 3/30/2016 7:42 AM, Borislav Petkov wrote: From: Borislav Petkov Option is long gone, see 5d9efa7ee99e ("ipv6: Remove privacy config option.") Signed-off-by: Borislav Petkov Cc: Chris Metcalf Thanks! Taken into the tile tree. -- Chris Metcalf, Mellanox Technol

[GIT PULL] arch/tile bugfixes for 4.6-rc2

2016-03-28 Thread Chris Metcalf
misspellings in comments. Chris Metcalf (3): tile kgdb: fix bug in copy to gdb regs, and optimize memset MAINTAINERS: update arch/tile maintainer email domain MAINTAINERS: update web link for tile architecture MAINTAINERS | 4 ++-- arch/tile/include/hv

[GIT PULL] arch/tile bugfixes for 4.6-rc2

2016-03-28 Thread Chris Metcalf
misspellings in comments. Chris Metcalf (3): tile kgdb: fix bug in copy to gdb regs, and optimize memset MAINTAINERS: update arch/tile maintainer email domain MAINTAINERS: update web link for tile architecture MAINTAINERS | 4 ++-- arch/tile/include/hv

Re: [PATCH v2 5/6] tile: mm: Use hugetlb_bad_size

2016-03-23 Thread Chris Metcalf
nux.intel.com> Cc: Paul Gortmaker<paul.gortma...@windriver.com> Cc: Dave Hansen<dave.han...@linux.intel.com> Acked-by: Chris Metcalf <cmetc...@mellanox.com> -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v2 5/6] tile: mm: Use hugetlb_bad_size

2016-03-23 Thread Chris Metcalf
Bai Cc: Dominik Dingel Cc: Kirill A. Shutemov Cc: Paul Gortmaker Cc: Dave Hansen Acked-by: Chris Metcalf -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

[PATCH v3 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-22 Thread Chris Metcalf
-by: Peter Zijlstra (Intel) <pet...@infradead.org> Tested-by: Peter Zijlstra (Intel) <pet...@infradead.org> Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/alpha/kernel/vmlinux.lds.S | 1 + arch/arc/kernel/vmlinux.lds.S| 1 + arch/arm/kernel/vmlinux.lds

[PATCH v3 0/4] improvements to the nmi_backtrace code

2016-03-22 Thread Chris Metcalf
ing __cpuidle tagging, switch S-O-B to Mellanox https://lkml.kernel.org/r/1458147733-29338-1-git-send-email-cmetc...@mellanox.com Chris Metcalf (4): nmi_backtrace: add more trigger_*_cpu_backtrace() methods nmi_backtrace: do a local dump_stack() instead of a self-NMI arch/tile: adopt the

[PATCH v3 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-22 Thread Chris Metcalf
-by: Peter Zijlstra (Intel) Tested-by: Peter Zijlstra (Intel) Signed-off-by: Chris Metcalf --- arch/alpha/kernel/vmlinux.lds.S | 1 + arch/arc/kernel/vmlinux.lds.S| 1 + arch/arm/kernel/vmlinux.lds.S| 1 + arch/arm64/kernel/vmlinux.lds.S | 1 + arch/arm64

[PATCH v3 0/4] improvements to the nmi_backtrace code

2016-03-22 Thread Chris Metcalf
ing __cpuidle tagging, switch S-O-B to Mellanox https://lkml.kernel.org/r/1458147733-29338-1-git-send-email-cmetc...@mellanox.com Chris Metcalf (4): nmi_backtrace: add more trigger_*_cpu_backtrace() methods nmi_backtrace: do a local dump_stack() instead of a self-NMI arch/tile: adopt the

[PATCH v3 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-22 Thread Chris Metcalf
ted to using the new cpumask approach in this change. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/arm/include/asm/irq.h| 4 +-- arch/arm/kernel/smp.c | 4 +-- arch/x86/include/asm/irq.h| 4 +-- arch/x86/kernel/apic/hw_nmi.c | 6 ++--- include/

[PATCH v3 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-22 Thread Chris Metcalf
ted to using the new cpumask approach in this change. Signed-off-by: Chris Metcalf --- arch/arm/include/asm/irq.h| 4 +-- arch/arm/kernel/smp.c | 4 +-- arch/x86/include/asm/irq.h| 4 +-- arch/x86/kernel/apic/hw_nmi.c | 6 ++--- include/linux/

[PATCH v3 3/4] arch/tile: adopt the new nmi_backtrace framework

2016-03-22 Thread Chris Metcalf
backtrace if the old one was still in progress. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/tile/include/asm/irq.h | 4 +-- arch/tile/kernel/pmc.c | 3 -- arch/tile/kernel/process.c | 72 ++--- arch/tile/kernel/traps.c

[PATCH v3 3/4] arch/tile: adopt the new nmi_backtrace framework

2016-03-22 Thread Chris Metcalf
backtrace if the old one was still in progress. Signed-off-by: Chris Metcalf --- arch/tile/include/asm/irq.h | 4 +-- arch/tile/kernel/pmc.c | 3 -- arch/tile/kernel/process.c | 72 ++--- arch/tile/kernel/traps.c| 7 +++-- 4 files changed, 23

[PATCH v3 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI

2016-03-22 Thread Chris Metcalf
. The register state will be missing, but that state is likely not particularly helpful in any case. Or, if we think it is helpful, we should be capturing and emitting the current register state in all cases when regs == NULL is passed to nmi_cpu_backtrace(). Signed-off-by: Chris Metcalf <cm

[PATCH v3 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI

2016-03-22 Thread Chris Metcalf
. The register state will be missing, but that state is likely not particularly helpful in any case. Or, if we think it is helpful, we should be capturing and emitting the current register state in all cases when regs == NULL is passed to nmi_cpu_backtrace(). Signed-off-by: Chris Metcalf --- arch/arm

Re: [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-21 Thread Chris Metcalf
On 03/21/2016 12:32 PM, Peter Zijlstra wrote: On Mon, Mar 21, 2016 at 12:15:12PM -0400, Chris Metcalf wrote: On 03/21/2016 11:42 AM, Peter Zijlstra wrote: The most common idle function for x86 is: mwait_idle_with_hints(), trouble is, its an inline, so I'm not sure adding __cpuidle to it does

Re: [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-21 Thread Chris Metcalf
On 03/21/2016 12:32 PM, Peter Zijlstra wrote: On Mon, Mar 21, 2016 at 12:15:12PM -0400, Chris Metcalf wrote: On 03/21/2016 11:42 AM, Peter Zijlstra wrote: The most common idle function for x86 is: mwait_idle_with_hints(), trouble is, its an inline, so I'm not sure adding __cpuidle to it does

Re: [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-21 Thread Chris Metcalf
On 03/21/2016 11:42 AM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:13PM -0400, Chris Metcalf wrote: diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 9f7c21c22477..d569ae7fde37 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -298,7

Re: [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-21 Thread Chris Metcalf
On 03/21/2016 11:42 AM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:13PM -0400, Chris Metcalf wrote: diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c index 9f7c21c22477..d569ae7fde37 100644 --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -298,7

Re: [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-21 Thread Chris Metcalf
On 03/21/2016 11:38 AM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:13PM -0400, Chris Metcalf wrote: diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 48958d3cec9e..37afd721ec99 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -887,8 +887,8 @@ static void

Re: [PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-21 Thread Chris Metcalf
On 03/21/2016 11:38 AM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:13PM -0400, Chris Metcalf wrote: diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 48958d3cec9e..37afd721ec99 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -887,8 +887,8 @@ static void

Re: [PATCH v11 01/13] vmstat: add quiet_vmstat_sync function

2016-03-21 Thread Chris Metcalf
On 03/21/2016 10:34 AM, Michal Hocko wrote: On Fri 11-03-16 17:10:11, Chris Metcalf wrote: In commit f01f17d3705b ("mm, vmstat: make quiet_vmstat lighter") the quiet_vmstat() function became asynchronous, in the sense that the vmstat work was still scheduled to run on the core when th

Re: [PATCH v11 01/13] vmstat: add quiet_vmstat_sync function

2016-03-21 Thread Chris Metcalf
On 03/21/2016 10:34 AM, Michal Hocko wrote: On Fri 11-03-16 17:10:11, Chris Metcalf wrote: In commit f01f17d3705b ("mm, vmstat: make quiet_vmstat lighter") the quiet_vmstat() function became asynchronous, in the sense that the vmstat work was still scheduled to run on the core when th

[PATCH v2 0/4] improvements to the nmi_backtrace code

2016-03-20 Thread Chris Metcalf
dle. That might be more usefully done by someone with arm platform experience in a follow-up patch. v1 of the series is here: https://lkml.kernel.org/r/1456782024-7122-1-git-send-email-cmetc...@ezchip.com Chris Metcalf (4): nmi_backtrace: add more trigger_*_cpu_backtrace() methods nmi_backtr

[PATCH v2 0/4] improvements to the nmi_backtrace code

2016-03-20 Thread Chris Metcalf
dle. That might be more usefully done by someone with arm platform experience in a follow-up patch. v1 of the series is here: https://lkml.kernel.org/r/1456782024-7122-1-git-send-email-cmetc...@ezchip.com Chris Metcalf (4): nmi_backtrace: add more trigger_*_cpu_backtrace() methods nmi_backtr

[PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-19 Thread Chris Metcalf
y grouping all the cpuidle code together into a new .cpuidle.text section, and then checking the address of the interrupted PC to see if it lies within that section. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/alpha/kernel/vmlinux.lds.S | 1 + arch/arc/kernel/vmlinux.l

[PATCH v2 4/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-19 Thread Chris Metcalf
y grouping all the cpuidle code together into a new .cpuidle.text section, and then checking the address of the interrupted PC to see if it lies within that section. Signed-off-by: Chris Metcalf --- arch/alpha/kernel/vmlinux.lds.S | 1 + arch/arc/kernel/vmlinux.lds.S| 1 + arch/

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
On 3/17/2016 3:36 PM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: Currently you can only request a backtrace of either all cpus, or all cpus but yourself. It can also be helpful to request a remote backtrace of a single cpu, and since we want

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
On 3/17/2016 3:36 PM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: Currently you can only request a backtrace of either all cpus, or all cpus but yourself. It can also be helpful to request a remote backtrace of a single cpu, and since we want

[PATCH v2 3/4] arch/tile: adopt the new nmi_backtrace framework

2016-03-19 Thread Chris Metcalf
backtrace if the old one was still in progress. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/tile/include/asm/irq.h | 4 +-- arch/tile/kernel/pmc.c | 3 -- arch/tile/kernel/process.c | 72 ++--- arch/tile/kernel/traps.c

[PATCH v2 3/4] arch/tile: adopt the new nmi_backtrace framework

2016-03-19 Thread Chris Metcalf
backtrace if the old one was still in progress. Signed-off-by: Chris Metcalf --- arch/tile/include/asm/irq.h | 4 +-- arch/tile/kernel/pmc.c | 3 -- arch/tile/kernel/process.c | 72 ++--- arch/tile/kernel/traps.c| 7 +++-- 4 files changed, 23

[PATCH v2 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI

2016-03-19 Thread Chris Metcalf
. The register state will be missing, but that state is likely not particularly helpful in any case. Or, if we think it is helpful, we should be capturing and emitting the current register state in all cases when regs == NULL is passed to nmi_cpu_backtrace(). Signed-off-by: Chris Metcalf <cm

[PATCH v2 2/4] nmi_backtrace: do a local dump_stack() instead of a self-NMI

2016-03-19 Thread Chris Metcalf
. The register state will be missing, but that state is likely not particularly helpful in any case. Or, if we think it is helpful, we should be capturing and emitting the current register state in all cases when regs == NULL is passed to nmi_cpu_backtrace(). Signed-off-by: Chris Metcalf --- arch/arm

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
attempts. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
attempts. -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v11 12/13] arm64: factor work_pending state machine to C

2016-03-19 Thread Chris Metcalf
you saw with Mark's original patch are improved with this version, which still tests the TIF flags prior to calling out to the loop in C code. Thanks! On 03/11/2016 05:10 PM, Chris Metcalf wrote: Currently ret_fast_syscall, work_pending, and ret_to_user form an ad-hoc state machine that can

Re: [PATCH v11 12/13] arm64: factor work_pending state machine to C

2016-03-19 Thread Chris Metcalf
you saw with Mark's original patch are improved with this version, which still tests the TIF flags prior to calling out to the loop in C code. Thanks! On 03/11/2016 05:10 PM, Chris Metcalf wrote: Currently ret_fast_syscall, work_pending, and ret_to_user form an ad-hoc state machine that can

[PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
ted to using the new cpumask approach in this change. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/arm/include/asm/irq.h| 4 +-- arch/arm/kernel/smp.c | 4 +-- arch/x86/include/asm/irq.h| 4 +-- arch/x86/kernel/apic/hw_nmi.c | 6 ++--- include/

[PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
ted to using the new cpumask approach in this change. Signed-off-by: Chris Metcalf --- arch/arm/include/asm/irq.h| 4 +-- arch/arm/kernel/smp.c | 4 +-- arch/x86/include/asm/irq.h| 4 +-- arch/x86/kernel/apic/hw_nmi.c | 6 ++--- include/linux/

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
On 3/17/2016 6:38 PM, Peter Zijlstra wrote: On Thu, Mar 17, 2016 at 06:31:44PM -0400, Chris Metcalf wrote: On 3/17/2016 3:36 PM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: Currently you can only request a backtrace of either all cpus, or all cpus

Re: [PATCH v2 1/4] nmi_backtrace: add more trigger_*_cpu_backtrace() methods

2016-03-19 Thread Chris Metcalf
On 3/17/2016 6:38 PM, Peter Zijlstra wrote: On Thu, Mar 17, 2016 at 06:31:44PM -0400, Chris Metcalf wrote: On 3/17/2016 3:36 PM, Peter Zijlstra wrote: On Wed, Mar 16, 2016 at 01:02:10PM -0400, Chris Metcalf wrote: Currently you can only request a backtrace of either all cpus, or all cpus

[PATCH v11 06/13] task_isolation: support PR_TASK_ISOLATION_STRICT mode

2016-03-11 Thread Chris Metcalf
to do so. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- include/linux/isolation.h | 10 +++ include/uapi/linux/prctl.h | 3 ++ kernel/isolation.c | 73 ++ 3 files changed, 86 insertions(+) diff --git a/include/linux/isolati

[PATCH v11 12/13] arm64: factor work_pending state machine to C

2016-03-11 Thread Chris Metcalf
to trace_hardirqs_on just before the return to userspace. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/arm64/kernel/entry.S | 12 arch/arm64/kernel/signal.c | 36 ++-- 2 files changed, 30 insertions(+), 18 deletions(-) diff --git a/arch

[PATCH v11 06/13] task_isolation: support PR_TASK_ISOLATION_STRICT mode

2016-03-11 Thread Chris Metcalf
to do so. Signed-off-by: Chris Metcalf --- include/linux/isolation.h | 10 +++ include/uapi/linux/prctl.h | 3 ++ kernel/isolation.c | 73 ++ 3 files changed, 86 insertions(+) diff --git a/include/linux/isolation.h b/include/linux

[PATCH v11 12/13] arm64: factor work_pending state machine to C

2016-03-11 Thread Chris Metcalf
to trace_hardirqs_on just before the return to userspace. Signed-off-by: Chris Metcalf --- arch/arm64/kernel/entry.S | 12 arch/arm64/kernel/signal.c | 36 ++-- 2 files changed, 30 insertions(+), 18 deletions(-) diff --git a/arch/arm64/kernel/entry.S b/arch

[PATCH v11 05/13] task_isolation: support CONFIG_TASK_ISOLATION_ALL

2016-03-11 Thread Chris Metcalf
This option, similar to NO_HZ_FULL_ALL, simplifies configuring a system to boot by default with all cores except the boot core running in task isolation mode. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- init/Kconfig | 10 ++ kernel/isolation.c | 6 ++ 2

[PATCH v11 09/13] arm, tile: turn off timer tick for oneshot_stopped state

2016-03-11 Thread Chris Metcalf
l properly re-enable it. This fix avoids a small performance hiccup for regular applications, but for TASK_ISOLATION code, it fixes a potentially serious kernel timer interruption to the time-sensitive application. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/tile/kernel/time.c

[PATCH v11 05/13] task_isolation: support CONFIG_TASK_ISOLATION_ALL

2016-03-11 Thread Chris Metcalf
This option, similar to NO_HZ_FULL_ALL, simplifies configuring a system to boot by default with all cores except the boot core running in task isolation mode. Signed-off-by: Chris Metcalf --- init/Kconfig | 10 ++ kernel/isolation.c | 6 ++ 2 files changed, 16 insertions

[PATCH v11 09/13] arm, tile: turn off timer tick for oneshot_stopped state

2016-03-11 Thread Chris Metcalf
l properly re-enable it. This fix avoids a small performance hiccup for regular applications, but for TASK_ISOLATION code, it fixes a potentially serious kernel timer interruption to the time-sensitive application. Signed-off-by: Chris Metcalf --- arch/tile/kernel/time.c | 1 +

[PATCH v11 02/13] vmstat: add vmstat_idle function

2016-03-11 Thread Chris Metcalf
This function checks to see if a vmstat worker is not running, and the vmstat diffs don't require an update. The function is called from the task-isolation code to see if we need to actually do some work to quiet vmstat. Acked-by: Christoph Lameter <c...@linux.com> Signed-off-by: Chris M

[PATCH v11 04/13] task_isolation: add initial support

2016-03-11 Thread Chris Metcalf
patches that follow provide these changes for x86, tile, and arm64. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- Documentation/kernel-parameters.txt | 8 ++ drivers/base/cpu.c | 18 + include/linux/isolation.h | 48 include/l

[PATCH v11 02/13] vmstat: add vmstat_idle function

2016-03-11 Thread Chris Metcalf
This function checks to see if a vmstat worker is not running, and the vmstat diffs don't require an update. The function is called from the task-isolation code to see if we need to actually do some work to quiet vmstat. Acked-by: Christoph Lameter Signed-off-by: Chris Metcalf --- include

[PATCH v11 04/13] task_isolation: add initial support

2016-03-11 Thread Chris Metcalf
patches that follow provide these changes for x86, tile, and arm64. Signed-off-by: Chris Metcalf --- Documentation/kernel-parameters.txt | 8 ++ drivers/base/cpu.c | 18 + include/linux/isolation.h | 48 include/linux/sched.h

[PATCH v11 03/13] lru_add_drain_all: factor out lru_add_drain_needed

2016-03-11 Thread Chris Metcalf
This per-cpu check was being done in the loop in lru_add_drain_all(), but having it be callable for a particular cpu is helpful for the task-isolation patches. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- include/linux/swap.h | 1 + mm/swap.c| 15 ++- 2

[PATCH v11 03/13] lru_add_drain_all: factor out lru_add_drain_needed

2016-03-11 Thread Chris Metcalf
This per-cpu check was being done in the loop in lru_add_drain_all(), but having it be callable for a particular cpu is helpful for the task-isolation patches. Signed-off-by: Chris Metcalf --- include/linux/swap.h | 1 + mm/swap.c| 15 ++- 2 files changed, 11 insertions

[PATCH v11 00/13] support "task_isolation" mode

2016-03-11 Thread Chris Metcalf
chieve its primary goal of enabling truly tick-free operation, but that is ongoing orthogonal work. The series is available at: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git dataplane Chris Metcalf (13): vmstat: add quiet_vmstat_sync function vmstat: add vmstat_idl

[PATCH v11 00/13] support "task_isolation" mode

2016-03-11 Thread Chris Metcalf
chieve its primary goal of enabling truly tick-free operation, but that is ongoing orthogonal work. The series is available at: git://git.kernel.org/pub/scm/linux/kernel/git/cmetcalf/linux-tile.git dataplane Chris Metcalf (13): vmstat: add quiet_vmstat_sync function vmstat: add vmstat_idl

[PATCH v11 07/13] task_isolation: add debug boot flag

2016-03-11 Thread Chris Metcalf
ating code what remote core and context is preparing to deliver an interrupt to a task_isolation core. Additionally, delivering a signal to the process in STRICT mode allows applications to report up task isolation failures into their own application logging framework. Signed-off-by: Chris Metc

[PATCH v11 11/13] arch/tile: enable task isolation functionality

2016-03-11 Thread Chris Metcalf
not generate signals to the application. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/tile/include/asm/thread_info.h | 4 +++- arch/tile/kernel/process.c | 9 + arch/tile/kernel/ptrace.c | 7 +++ arch/tile/kernel/single_step.c | 5 +

[PATCH v11 10/13] arch/x86: enable task isolation functionality

2016-03-11 Thread Chris Metcalf
detection of syscalls. We add strict reporting for the kernel exception types that do not result in signals, namely non-signalling page faults and non-signalling MPX fixups. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/x86/entry/common.c| 18 +- ar

[PATCH v11 07/13] task_isolation: add debug boot flag

2016-03-11 Thread Chris Metcalf
ating code what remote core and context is preparing to deliver an interrupt to a task_isolation core. Additionally, delivering a signal to the process in STRICT mode allows applications to report up task isolation failures into their own application logging framework. Signed-off-by: Chr

[PATCH v11 11/13] arch/tile: enable task isolation functionality

2016-03-11 Thread Chris Metcalf
not generate signals to the application. Signed-off-by: Chris Metcalf --- arch/tile/include/asm/thread_info.h | 4 +++- arch/tile/kernel/process.c | 9 + arch/tile/kernel/ptrace.c | 7 +++ arch/tile/kernel/single_step.c | 5 + arch/tile/kernel/smp.c

[PATCH v11 10/13] arch/x86: enable task isolation functionality

2016-03-11 Thread Chris Metcalf
detection of syscalls. We add strict reporting for the kernel exception types that do not result in signals, namely non-signalling page faults and non-signalling MPX fixups. Signed-off-by: Chris Metcalf --- arch/x86/entry/common.c| 18 +- arch/x86/include/asm

[PATCH v11 08/13] task_isolation: add PR_TASK_ISOLATION_ONE_SHOT flag

2016-03-11 Thread Chris Metcalf
ly to turn task isolation off before starting to use kernel services. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- include/uapi/linux/prctl.h | 1 + kernel/isolation.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/include/uapi/linux/prctl.h b/include/uapi/lin

[PATCH v11 13/13] arch/arm64: enable task isolation functionality

2016-03-11 Thread Chris Metcalf
hem in strict or debug mode. Finally, add an explicit check for STRICT mode in do_mem_abort() to handle the case of page faults. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- arch/arm64/include/asm/thread_info.h | 5 - arch/arm64/kernel/ptrace.c | 15 ---

[PATCH v11 08/13] task_isolation: add PR_TASK_ISOLATION_ONE_SHOT flag

2016-03-11 Thread Chris Metcalf
ly to turn task isolation off before starting to use kernel services. Signed-off-by: Chris Metcalf --- include/uapi/linux/prctl.h | 1 + kernel/isolation.c | 7 +++ 2 files changed, 8 insertions(+) diff --git a/include/uapi/linux/prctl.h b/include/uapi/linux/prctl.h index a5

[PATCH v11 13/13] arch/arm64: enable task isolation functionality

2016-03-11 Thread Chris Metcalf
hem in strict or debug mode. Finally, add an explicit check for STRICT mode in do_mem_abort() to handle the case of page faults. Signed-off-by: Chris Metcalf --- arch/arm64/include/asm/thread_info.h | 5 - arch/arm64/kernel/ptrace.c | 15 --- arch/arm64/kernel/signal.c

[PATCH v11 01/13] vmstat: add quiet_vmstat_sync function

2016-03-11 Thread Chris Metcalf
guarantees that the vmstat worker will not run on the core on return from the function. Add a quiet_vmstat_sync() function with that semantic. Signed-off-by: Chris Metcalf <cmetc...@mellanox.com> --- include/linux/vmstat.h | 2 ++ mm/vmstat.c| 9 + 2 files changed, 11 ins

[PATCH v11 01/13] vmstat: add quiet_vmstat_sync function

2016-03-11 Thread Chris Metcalf
guarantees that the vmstat worker will not run on the core on return from the function. Add a quiet_vmstat_sync() function with that semantic. Signed-off-by: Chris Metcalf --- include/linux/vmstat.h | 2 ++ mm/vmstat.c| 9 + 2 files changed, 11 insertions(+) diff --git a/inc

Re: [PATCH v10 09/12] arch/x86: enable task isolation functionality

2016-03-09 Thread Chris Metcalf
On 3/9/2016 4:07 PM, Andy Lutomirski wrote: On Wed, Mar 9, 2016 at 1:05 PM, Chris Metcalf <cmetc...@mellanox.com> wrote: On 3/9/2016 3:58 PM, Andy Lutomirski wrote: My preference would be not to have to require all task-isolation users to also figure out all the complexities of creati

Re: [PATCH v10 09/12] arch/x86: enable task isolation functionality

2016-03-09 Thread Chris Metcalf
On 3/9/2016 4:07 PM, Andy Lutomirski wrote: On Wed, Mar 9, 2016 at 1:05 PM, Chris Metcalf wrote: On 3/9/2016 3:58 PM, Andy Lutomirski wrote: My preference would be not to have to require all task-isolation users to also figure out all the complexities of creating BPF programs, so my

Re: [PATCH v10 09/12] arch/x86: enable task isolation functionality

2016-03-09 Thread Chris Metcalf
is surely writing:) Happily, task isolation is so simple an API that all that is needed is a prctl(). ... Unless somehow a requirement to inflict a huge blob of eBPF into the kernel just to use task isolation safely is added, of course :-) -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v10 09/12] arch/x86: enable task isolation functionality

2016-03-09 Thread Chris Metcalf
is surely writing:) Happily, task isolation is so simple an API that all that is needed is a prctl(). ... Unless somehow a requirement to inflict a huge blob of eBPF into the kernel just to use task isolation safely is added, of course :-) -- Chris Metcalf, Mellanox Technologies http://www.mellanox.com

Re: [PATCH v9 04/13] task_isolation: add initial support

2016-03-09 Thread Chris Metcalf
mail thread with Andy Lutomirski. Whether it gets included in v11 is still TBD. TL;DR: Various minor issues in answer to Frederic's comments :-) = On 03/04/2016 07:56 AM, Frederic Weisbecker wrote: On Thu, Feb 11, 2016 at 02:24:25PM -0500, Chris Metcalf wrote: We don't want

Re: [PATCH v9 04/13] task_isolation: add initial support

2016-03-09 Thread Chris Metcalf
mail thread with Andy Lutomirski. Whether it gets included in v11 is still TBD. TL;DR: Various minor issues in answer to Frederic's comments :-) = On 03/04/2016 07:56 AM, Frederic Weisbecker wrote: On Thu, Feb 11, 2016 at 02:24:25PM -0500, Chris Metcalf wrote: We don't want

Re: [PATCH v10 09/12] arch/x86: enable task isolation functionality

2016-03-08 Thread Chris Metcalf
/* Common entry point for both prctl and syscall. */ @@ -824,6 +905,8 @@ static long do_seccomp(unsigned int op, unsigned int flags, return seccomp_set_mode_strict(); case SECCOMP_SET_MODE_FILTER: return seccomp_set_mode_filter(flags, uargs); +

Re: [PATCH v10 09/12] arch/x86: enable task isolation functionality

2016-03-08 Thread Chris Metcalf
/* Common entry point for both prctl and syscall. */ @@ -824,6 +905,8 @@ static long do_seccomp(unsigned int op, unsigned int flags, return seccomp_set_mode_strict(); case SECCOMP_SET_MODE_FILTER: return seccomp_set_mode_filter(flags, uargs); +

Re: [PATCH v10 09/12] arch/x86: enable task isolation functionality

2016-03-07 Thread Chris Metcalf
On 03/03/2016 06:46 PM, Andy Lutomirski wrote: On Thu, Mar 3, 2016 at 11:52 AM, Chris Metcalf <cmetc...@mellanox.com> wrote: On 03/02/2016 07:36 PM, Andy Lutomirski wrote: On Mar 2, 2016 12:10 PM, "Chris Metcalf" <cmetc...@ezchip.com> wrote: In prepare_ex

Re: [PATCH v10 09/12] arch/x86: enable task isolation functionality

2016-03-07 Thread Chris Metcalf
On 03/03/2016 06:46 PM, Andy Lutomirski wrote: On Thu, Mar 3, 2016 at 11:52 AM, Chris Metcalf wrote: On 03/02/2016 07:36 PM, Andy Lutomirski wrote: On Mar 2, 2016 12:10 PM, "Chris Metcalf" wrote: In prepare_exit_to_usermode(), call task_isolation_ready() when we are checking the t

Re: [PATCH 2/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-07 Thread Chris Metcalf
On 03/07/2016 04:48 AM, Peter Zijlstra wrote: On Tue, Mar 01, 2016 at 11:01:42AM -0500, Chris Metcalf wrote: +++ b/kernel/sched/idle.c @@ -52,15 +52,25 @@ static int __init cpu_idle_nopoll_setup(char *__unused) __setup("hlt", cpu_idle_nopoll_setup); #endif +static DEFINE_PE

Re: [PATCH 2/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-07 Thread Chris Metcalf
On 03/07/2016 04:48 AM, Peter Zijlstra wrote: On Tue, Mar 01, 2016 at 11:01:42AM -0500, Chris Metcalf wrote: +++ b/kernel/sched/idle.c @@ -52,15 +52,25 @@ static int __init cpu_idle_nopoll_setup(char *__unused) __setup("hlt", cpu_idle_nopoll_setup); #endif +static DEFINE_PE

Re: [PATCH 2/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-07 Thread Chris Metcalf
On 03/07/2016 03:26 AM, Daniel Thompson wrote: Chris Metcalf wrote: +static DEFINE_PER_CPU(bool, cpu_idling); + +/* Was the cpu was in the low-level idle code when interrupted? */ +bool in_cpu_idle(void) +{ +return this_cpu_read(cpu_idling); I think we continue to need the code to identify

Re: [PATCH 2/4] nmi_backtrace: generate one-line reports for idle cpus

2016-03-07 Thread Chris Metcalf
On 03/07/2016 03:26 AM, Daniel Thompson wrote: Chris Metcalf wrote: +static DEFINE_PER_CPU(bool, cpu_idling); + +/* Was the cpu was in the low-level idle code when interrupted? */ +bool in_cpu_idle(void) +{ +return this_cpu_read(cpu_idling); I think we continue to need the code to identify

<    1   2   3   4   5   6   7   8   9   10   >